Bug 1358417 - Use ATK_ROLE_DESCRIPTION_TERM for "term" role and "dt" element. r=surkov
authorJoanmarie Diggs <jdiggs@igalia.com>
Fri, 16 Jun 2017 14:02:55 -0400
changeset 364499 053002880e93
parent 364498 956306ea34f3
child 364500 2ab14fdd3af3
push id32043
push userarchaeopteryx@coole-files.de
push dateSat, 17 Jun 2017 20:28:42 +0000
treeherdermozilla-central@0ef3bfc9f4b8 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssurkov
bugs1358417
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1358417 - Use ATK_ROLE_DESCRIPTION_TERM for "term" role and "dt" element. r=surkov
accessible/base/ARIAMap.cpp
accessible/base/RoleMap.h
accessible/tests/mochitest/role/test_aria.html
dom/base/nsGkAtomList.h
--- a/accessible/base/ARIAMap.cpp
+++ b/accessible/base/ARIAMap.cpp
@@ -1069,16 +1069,26 @@ static const nsRoleMapEntry sWAIRoleMaps
     roles::PROPERTYPAGE,
     kUseMapRole,
     eNoValue,
     eNoAction,
     eNoLiveAttr,
     kGenericAccType,
     kNoReqStates
   },
+  { // term
+    &nsGkAtoms::term,
+    roles::TERM,
+    kUseMapRole,
+    eNoValue,
+    eNoAction,
+    eNoLiveAttr,
+    kGenericAccType,
+    states::READONLY
+  },
   { // textbox
     &nsGkAtoms::textbox,
     roles::ENTRY,
     kUseMapRole,
     eNoValue,
     eActivateAction,
     eNoLiveAttr,
     kGenericAccType,
--- a/accessible/base/RoleMap.h
+++ b/accessible/base/RoleMap.h
@@ -1029,17 +1029,17 @@ ROLE(DEFINITION_LIST,
      ATK_ROLE_LIST,
      NSAccessibilityListRole,
      ROLE_SYSTEM_LIST,
      ROLE_SYSTEM_LIST,
      eNameFromSubtreeIfReqRule)
 
 ROLE(TERM,
      "term",
-     ATK_ROLE_LIST_ITEM,
+     ATK_ROLE_DESCRIPTION_TERM,
      NSAccessibilityGroupRole,
      ROLE_SYSTEM_LISTITEM,
      ROLE_SYSTEM_LISTITEM,
      eNameFromSubtreeRule)
 
 ROLE(DEFINITION,
      "definition",
      ATK_ROLE_PARAGRAPH,
--- a/accessible/tests/mochitest/role/test_aria.html
+++ b/accessible/tests/mochitest/role/test_aria.html
@@ -61,16 +61,17 @@
       testRole("aria_separator", ROLE_SEPARATOR);
       testRole("aria_slider", ROLE_SLIDER);
       testRole("aria_spinbutton", ROLE_SPINBUTTON);
       testRole("aria_status", ROLE_STATUSBAR);
       testRole("aria_switch", ROLE_SWITCH);
       testRole("aria_tab", ROLE_PAGETAB);
       testRole("aria_tablist", ROLE_PAGETABLIST);
       testRole("aria_tabpanel", ROLE_PROPERTYPAGE);
+      testRole("aria_term", ROLE_TERM);
       testRole("aria_textbox", ROLE_ENTRY);
       testRole("aria_timer", ROLE_TEXT); // weak role
       testRole("aria_toolbar", ROLE_TOOLBAR);
       testRole("aria_tooltip", ROLE_TOOLTIP);
       testRole("aria_tree", ROLE_OUTLINE);
       testRole("aria_treegrid", ROLE_TREE_TABLE);
       testRole("aria_treeitem", ROLE_OUTLINEITEM);
 
@@ -238,16 +239,17 @@
   <span id="aria_separator" role="separator"/>
   <span id="aria_slider" role="slider"/>
   <span id="aria_spinbutton" role="spinbutton"/>
   <span id="aria_status" role="status"/>
   <span id="aria_switch" role="switch"/>
   <span id="aria_tab" role="tab"/>
   <span id="aria_tablist" role="tablist"/>
   <span id="aria_tabpanel" role="tabpanel"/>
+  <span id="aria_term" role="term"/>
   <span id="aria_textbox" role="textbox"/>
   <span id="aria_timer" role="timer"/>
   <span id="aria_toolbar" role="toolbar"/>
   <span id="aria_tooltip" role="tooltip"/>
   <span id="aria_tree" role="tree"/>
   <span id="aria_treegrid" role="treegrid"/>
   <span id="aria_treeitem" role="treeitem"/>
 
--- a/dom/base/nsGkAtomList.h
+++ b/dom/base/nsGkAtomList.h
@@ -1304,16 +1304,17 @@ GK_ATOM(tabpanels, "tabpanels")
 GK_ATOM(tag, "tag")
 GK_ATOM(target, "target")
 GK_ATOM(targets, "targets")
 GK_ATOM(tbody, "tbody")
 GK_ATOM(td, "td")
 GK_ATOM(_template, "template")
 GK_ATOM(text_decoration, "text-decoration")
 GK_ATOM(terminate, "terminate")
+GK_ATOM(term, "term")
 GK_ATOM(test, "test")
 GK_ATOM(text, "text")
 GK_ATOM(textAlign, "text-align")
 GK_ATOM(textarea, "textarea")
 GK_ATOM(textbox, "textbox")
 GK_ATOM(textnode, "textnode")
 GK_ATOM(textNodeDirectionalityMap, "textNodeDirectionalityMap")
 GK_ATOM(tfoot, "tfoot")