Bug 1536392 - Drop GeckoView checks for individual transform properties cases. r=boris
authorHiroyuki Ikezoe <hikezoe.birchill@mozilla.com>
Thu, 26 Sep 2019 21:01:30 +0000
changeset 495187 049de73fed5c1f0b3b5a92a1ec2f7096de694188
parent 495186 8b55e3a5434e09ec084f38e3cc295ffc4b6085b7
child 495188 fcab1dd29374d213aa95af210684381fa6638d68
push id36623
push usershindli@mozilla.com
push dateFri, 27 Sep 2019 04:28:18 +0000
treeherdermozilla-central@dcfdecc355c0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersboris
bugs1536392
milestone71.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1536392 - Drop GeckoView checks for individual transform properties cases. r=boris Now all test cases for individual transform properties work fine on GeckoView. Depends on D47200 Differential Revision: https://phabricator.services.mozilla.com/D47201
layout/style/test/test_animations_omta.html
--- a/layout/style/test/test_animations_omta.html
+++ b/layout/style/test/test_animations_omta.html
@@ -2596,28 +2596,23 @@ addAsyncAnimTest(async function() {
 
   omta_is("transform", { compositorValue: { tx: 300 },
                          usesMultipleProperties: true },
           RunningOn.Compositor,
           "transform-like properties transition runs on compositor thread");
 
   advance_clock(5000);
 
-  if (isGeckoView()) {
-    todo(false,
-         "Bug 1536392: GeckoView with e10s: cannot get correct OMTA style");
-  } else {
-    omta_is("transform",
-            // The order is: translate, scale, transform.
-            // So the translate() in transform should be multiplied by 1.5.
-            { compositorValue: [ 1.5, 0, 0, 1.5, (150 + 150*1.5), 0 ],
-              usesMultipleProperties: true },
-            RunningOn.Compositor,
-            "transform-like properties on compositor at 5s");
-  }
+  omta_is("transform",
+          // The order is: translate, scale, transform.
+          // So the translate() in transform should be multiplied by 1.5.
+          { compositorValue: [ 1.5, 0, 0, 1.5, (150 + 150*1.5), 0 ],
+            usesMultipleProperties: true },
+          RunningOn.Compositor,
+          "transform-like properties on compositor at 5s");
 
   done_div();
 });
 
 // Multiple transform-like properties animation. The non-animating properties
 // shouldn't be overridden by animating ones.
 addAsyncAnimTest(async function() {
   new_div("translate: 100px; " +
@@ -2633,28 +2628,23 @@ addAsyncAnimTest(async function() {
 
   omta_is("transform", { compositorValue: { tx: 300 },
                          usesMultipleProperties: true },
           RunningOn.Compositor,
           "transform-like properties transition runs on compositor thread");
 
   advance_clock(5000);
 
-  if (isGeckoView()) {
-    todo(false,
-         "Bug 1536392: GeckoView with e10s: cannot get correct OMTA style");
-  } else {
-    omta_is("transform",
-            // The order is: translate, scale, transform.
-            // So the translate() in transform should be multiplied by 1.5.
-            { compositorValue: [ 1.5, 0, 0, 1.5, (150 + 200*1.5), 0 ],
-              usesMultipleProperties: true },
-            RunningOn.Compositor,
-            "transform-like properties on compositor at 5s");
-  }
+  omta_is("transform",
+          // The order is: translate, scale, transform.
+          // So the translate() in transform should be multiplied by 1.5.
+          { compositorValue: [ 1.5, 0, 0, 1.5, (150 + 200*1.5), 0 ],
+            usesMultipleProperties: true },
+          RunningOn.Compositor,
+          "transform-like properties on compositor at 5s");
 
   done_div();
 });
 
 // Multiple transform-like properties animation with delay. The delayed
 // animating properties shouldn't be overridden.
 //
 // Note:
@@ -2684,38 +2674,28 @@ addAsyncAnimTest(async function() {
      "in delay phase, got " + computedStr);
   computedStr = window.getComputedStyle(gDiv).scale;
   ok(computedStr === "1.25",
      "The computed value of scale property should be equal to 1.25 " +
      "in delay phase, got " + computedStr);
 
   advance_clock(2500);
 
-  if (isGeckoView()) {
-    todo(false,
-         "Bug 1536392: GeckoView with e10s: cannot get correct OMTA style");
-  } else {
-    omta_is("transform", { compositorValue: [ 1.25, 0, 0, 1.25, 100, 0 ],
-                           usesMultipleProperties: true },
-            RunningOn.Compositor,
-            "transform-like properties on compositor at 2.5s");
-  }
+  omta_is("transform", { compositorValue: [ 1.25, 0, 0, 1.25, 100, 0 ],
+                         usesMultipleProperties: true },
+          RunningOn.Compositor,
+          "transform-like properties on compositor at 2.5s");
 
   advance_clock(5000);
 
-  if (isGeckoView()) {
-    todo(false,
-         "Bug 1536392: GeckoView with e10s: cannot get correct OMTA style");
-  } else {
-    omta_is("transform",
-            { compositorValue: [ 1.75, 0, 0, 1.75, 100, 0 ],
-              usesMultipleProperties: true },
-            RunningOn.Compositor,
-            "transform-like properties on compositor at 7.5s");
-  }
+  omta_is("transform",
+          { compositorValue: [ 1.75, 0, 0, 1.75, 100, 0 ],
+            usesMultipleProperties: true },
+          RunningOn.Compositor,
+          "transform-like properties on compositor at 7.5s");
 
   done_div();
 });
 
 // Multiple transform-like properties animation. The motion-path shouldn't be
 // overridden by other transform animations. So, in this case, we should fall
 // back transform animations to main thread if offset-path presents.
 // FIXME: Bug 1429305: Run animations of motion path on the compositor thread.