Bug 620367 - Fix unused variable warning in InsertVisitedURI::AddVisit; r+a=sdwilsh
authorMs2ger <ms2ger@gmail.com>
Tue, 21 Dec 2010 15:03:01 -0800
changeset 59577 046dada4fadce81561707a5a700d4c6371c90ebc
parent 59576 6b98f6cf45899ad77115976ea1dd160eeff93ba8
child 59578 c544c99fad5ac09c0d4b0a778d511ee0292cf673
push id17673
push userdholbert@mozilla.com
push dateTue, 21 Dec 2010 23:04:38 +0000
treeherdermozilla-central@52b229f6a051 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs620367
milestone2.0b9pre
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 620367 - Fix unused variable warning in InsertVisitedURI::AddVisit; r+a=sdwilsh
toolkit/components/places/src/History.cpp
--- a/toolkit/components/places/src/History.cpp
+++ b/toolkit/components/places/src/History.cpp
@@ -562,19 +562,21 @@ private:
                                _place.sessionId);
     NS_ENSURE_SUCCESS(rv, rv);
 
     mozStorageStatementScoper scoper(stmt);
     rv = stmt->Execute();
     NS_ENSURE_SUCCESS(rv, rv);
 
     // Now that it should be in the database, we need to obtain the id of the
-    // visit we just added.
+    // place we just added.
     bool visited = FetchVisitInfo(_place);
-    NS_ASSERTION(!visited, "Not visited after adding a visit!");
+    if (visited) {
+      NS_NOTREACHED("Not visited after adding a visit!");
+    }
 
     return NS_OK;
   }
 
   /**
    * Updates the frecency, and possibly the hidden-ness of aPlace.
    *
    * @param aPlace