Part 2 of Bug 930194 - Add prerequisite checks for MozillaMaintenance Service tests that fail the tests if the build system is not properly configured. r=bbondy
authorRobert Strong <robert.bugzilla@gmail.com>
Fri, 10 Jan 2014 18:45:54 -0800
changeset 163026 046258beb9286f7ad22565f33e51c7757461cb84
parent 163025 7c3432eb049bfb7eb2052a7b23d3d9997ca699e9
child 163027 abf4a69f46e2f044da13b297cfae62b4846af149
push id25979
push usercbook@mozilla.com
push dateMon, 13 Jan 2014 11:46:02 +0000
treeherdermozilla-central@ea6657f1d682 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbbondy
bugs930194
milestone29.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Part 2 of Bug 930194 - Add prerequisite checks for MozillaMaintenance Service tests that fail the tests if the build system is not properly configured. r=bbondy
toolkit/mozapps/update/tests/unit_aus_update/head_update.js
--- a/toolkit/mozapps/update/tests/unit_aus_update/head_update.js
+++ b/toolkit/mozapps/update/tests/unit_aus_update/head_update.js
@@ -778,18 +778,20 @@ function shouldRunServiceTest(aFirstTest
   // an error.
   if (aFirstTest && process.exitValue != 0) {
     do_throw("First test, check for service stopped state returned error " +
              process.exitValue);
   }
 
 #ifndef DISABLE_UPDATER_AUTHENTICODE_CHECK
   if (!isBinarySigned(updaterBinPath)) {
-    logTestInfo("this test can only run on builds with signed binaries.");
-    return false;
+    logTestInfo("test registry key exists but this test can only run on " +
+                "builds with signed binaries when " +
+                "DISABLE_UPDATER_AUTHENTICODE_CHECK is not defined");
+    do_throw("this test can only run on builds with signed binaries.");
   }
 #endif
   return true;
 }
 
 /**
  * Helper function to check whether the a binary is signed.
  *