Bug 1161882 - "Add a Keyword for this search..." dialog accept button is disabled. r=ttaubert
authorMarco Bonardo <mbonardo@mozilla.com>
Fri, 08 May 2015 12:43:24 +0200
changeset 242963 045bd99f20246714bf7ffa1e9c7d2109627e6826
parent 242962 0070705f844296d7d79a7dc0ae544dd44d100bab
child 242964 1683f5135a1f4ee5e046d8446ffd02b95591411d
push id28714
push userkwierso@gmail.com
push dateFri, 08 May 2015 17:29:48 +0000
treeherdermozilla-central@5e8adf0e7f2c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersttaubert
bugs1161882
milestone40.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1161882 - "Add a Keyword for this search..." dialog accept button is disabled. r=ttaubert
browser/components/places/content/editBookmarkOverlay.js
--- a/browser/components/places/content/editBookmarkOverlay.js
+++ b/browser/components/places/content/editBookmarkOverlay.js
@@ -179,17 +179,20 @@ let gEditItemOverlay = {
         return !(this._element(rowId).collapsed = !visible);
       };
 
     if (showOrCollapse("nameRow", !bulkTagging, "name")) {
       this._initNamePicker();
       this._namePicker.readOnly = this.readOnly;
     }
 
-    if (showOrCollapse("locationRow", isURI, "location")) {
+    // In some cases we want to hide the location field, since it's not
+    // human-readable, but we still want to initialize it.
+    showOrCollapse("locationRow", isURI, "location");
+    if (isURI) {
       this._initLocationField();
       this._locationField.readOnly = !this._paneInfo.isItem;
     }
 
     if (showOrCollapse("descriptionRow",
                        this._paneInfo.isItem && !this.readOnly,
                        "description")) {
       this._initDescriptionField();