Bug 1610886 - Make it easier to run test-verify on try; r=bc
authorGeoff Brown <gbrown@mozilla.com>
Wed, 25 Mar 2020 19:32:42 +0000
changeset 520425 03c92cf1a7318c5de00c9b4fede8995158124938
parent 520424 b07dafd8ecc30d7bb28d51b203e23cdd6393bcdd
child 520426 485c738acdb1482ba1b7ede8ab40282dc10e296a
push id37250
push userdvarga@mozilla.com
push dateThu, 26 Mar 2020 04:04:15 +0000
treeherdermozilla-central@85bae8580dde [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbc
bugs1610886
milestone76.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1610886 - Make it easier to run test-verify on try; r=bc Ensure a minimum of 1 chunk for "per-file" tests like test-verify when run on try, even when no local file changes are detected. --full is still required. Differential Revision: https://phabricator.services.mozilla.com/D67694
taskcluster/taskgraph/util/perfile.py
--- a/taskcluster/taskgraph/util/perfile.py
+++ b/taskcluster/taskgraph/util/perfile.py
@@ -78,9 +78,16 @@ def perfile_number_of_chunks(is_try, try
                     for gdir in gpu_dirs:
                         if len(path.split(gdir)) > 1:
                             gpu = True
 
                 if not gpu:
                     test_count += 1
 
     chunks = test_count/tests_per_chunk
-    return int(math.ceil(chunks))
+    chunks = int(math.ceil(chunks))
+
+    # Never return 0 chunks on try, so that per-file tests can be pushed to try with
+    # an explicit path, and also so "empty" runs can be checked on try.
+    if is_try and chunks == 0:
+        chunks = 1
+
+    return chunks