Bug 1515528 - Disable accessibility on aarch64-windows. r=dmajor,chmanchester
authorMike Hommey <mh+mozilla@glandium.org>
Fri, 11 Jan 2019 00:20:35 +0000
changeset 453422 02cd44e39566b22dc5c02f031c02045aca2a4393
parent 453421 c7d7c62b7b11c28bcc44d8a3424dcb419b9d7bce
child 453423 7d8101dcf03a2bfb19b5511716100d6014c093f8
push id35357
push usernerli@mozilla.com
push dateFri, 11 Jan 2019 21:54:07 +0000
treeherdermozilla-central@0ce024c91511 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdmajor, chmanchester
bugs1515528
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1515528 - Disable accessibility on aarch64-windows. r=dmajor,chmanchester Depends on D15265 Differential Revision: https://phabricator.services.mozilla.com/D15266
browser/config/mozconfigs/win64-aarch64/common-win64
toolkit/moz.configure
--- a/browser/config/mozconfigs/win64-aarch64/common-win64
+++ b/browser/config/mozconfigs/win64-aarch64/common-win64
@@ -1,7 +1,4 @@
 # This file is used by all AArch64 Win64 builds
 
 ac_add_options --target=aarch64-windows-mingw32
 ac_add_options --host=x86_64-pc-mingw32
-
-# Accessibility doesn't work.
-ac_add_options --disable-accessibility
--- a/toolkit/moz.configure
+++ b/toolkit/moz.configure
@@ -1126,19 +1126,27 @@ def midl_flags(c_compiler, target, vc_co
     }[target.cpu]
 
 
 set_config('MIDL_FLAGS', midl_flags)
 
 # Accessibility
 # ==============================================================
 
-option('--disable-accessibility', help='Disable accessibility support')
+@depends(target)
+def a11y_default(target):
+    # Accessibility doesn't work on aarch64-windows yet.
+    if target.kernel == 'WINNT' and target.cpu == 'aarch64':
+        return False
+    return True
 
-@depends('--disable-accessibility', check_for_midl, midl, c_compiler)
+option('--enable-accessibility',
+       default=a11y_default, help='{Enable|Disable} accessibility support')
+
+@depends('--enable-accessibility', check_for_midl, midl, c_compiler)
 def accessibility(value, check_for_midl, midl, c_compiler):
     enabled = bool(value)
 
     if not enabled:
         return
 
     if check_for_midl and not midl:
         if c_compiler and c_compiler.type in ('gcc', 'clang'):