Bug 1173182: Fix false positives in telemetry environment CPU extensions field; r=gfritzsche
authorAaron Klotz <aklotz@mozilla.com>
Wed, 10 Jun 2015 11:02:29 -0600
changeset 248082 01ae75cfedd0654fc85fd670cd7ac3844b18ef24
parent 248081 fcfdee109765d38d65a680307975620173f5007c
child 248083 2a981c61aa56f94067d23d2861b18757d10c3e32
push id28888
push userkwierso@gmail.com
push dateThu, 11 Jun 2015 01:29:45 +0000
treeherdermozilla-central@04c057942da4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgfritzsche
bugs1173182
milestone41.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1173182: Fix false positives in telemetry environment CPU extensions field; r=gfritzsche
toolkit/components/telemetry/TelemetryEnvironment.jsm
--- a/toolkit/components/telemetry/TelemetryEnvironment.jsm
+++ b/toolkit/components/telemetry/TelemetryEnvironment.jsm
@@ -1038,21 +1038,19 @@ EnvironmentCache.prototype = {
 
     const CPU_EXTENSIONS = ["hasMMX", "hasSSE", "hasSSE2", "hasSSE3", "hasSSSE3",
                             "hasSSE4A", "hasSSE4_1", "hasSSE4_2", "hasEDSP", "hasARMv6",
                             "hasARMv7", "hasNEON"];
 
     // Enumerate the available CPU extensions.
     let availableExts = [];
     for (let ext of CPU_EXTENSIONS) {
-      try {
-        Services.sysinfo.getProperty(ext);
-        // If it doesn't throw, add it to the list.
+      if (getSysinfoProperty(ext, false)) {
         availableExts.push(ext);
-      } catch (e) {}
+      }
     }
 
     cpuData.extensions = availableExts;
 
     return cpuData;
   },
 
 #if defined(MOZ_WIDGET_GONK) || defined(MOZ_WIDGET_ANDROID)