Bug 1354232 - Don't store the result of update_expected, r=maja_zf
authorJames Graham <james@hoppipolla.co.uk>
Thu, 07 Jun 2018 11:40:56 +0100
changeset 427356 004b079b76d06c3e9d74210700b28994cdeff886
parent 427355 5028820efd9ed3d1dbcb9bde5cbc235414a8d23c
child 427357 9d5ed234247c64c7863724c99b071931452b9822
push id34301
push userbtara@mozilla.com
push dateThu, 19 Jul 2018 21:49:46 +0000
treeherdermozilla-central@690cb3015db6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmaja_zf
bugs1354232
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1354232 - Don't store the result of update_expected, r=maja_zf The needs_human feature never worked well and is unused. MozReview-Commit-ID: KemDBXjHPV8
testing/web-platform/tests/tools/wptrunner/wptrunner/update/metadata.py
--- a/testing/web-platform/tests/tools/wptrunner/wptrunner/update/metadata.py
+++ b/testing/web-platform/tests/tools/wptrunner/wptrunner/update/metadata.py
@@ -13,33 +13,31 @@ class GetUpdatePropertyList(Step):
             state.config, state.product)
         state.property_order = property_order + state.extra_properties
         state.boolean_properties = boolean_properties
 
 
 class UpdateExpected(Step):
     """Do the metadata update on the local checkout"""
 
-    provides = ["needs_human"]
-
     def create(self, state):
         if state.sync_tree is not None:
             sync_root = state.sync_tree.root
         else:
             sync_root = None
 
-        state.needs_human = metadata.update_expected(state.paths,
-                                                     state.serve_root,
-                                                     state.run_log,
-                                                     rev_old=None,
-                                                     ignore_existing=state.ignore_existing,
-                                                     sync_root=sync_root,
-                                                     property_order=state.property_order,
-                                                     boolean_properties=state.boolean_properties,
-                                                     stability=state.stability)
+        metadata.update_expected(state.paths,
+                                 state.serve_root,
+                                 state.run_log,
+                                 rev_old=None,
+                                 ignore_existing=state.ignore_existing,
+                                 sync_root=sync_root,
+                                 property_order=state.property_order,
+                                 boolean_properties=state.boolean_properties,
+                                 stability=state.stability)
 
 
 class CreateMetadataPatch(Step):
     """Create a patch/commit for the metadata checkout"""
 
     def create(self, state):
         if not state.patch:
             return