31f2b92312abea75502d1e1d4eb4ccf9225f740d: Bug 1588710 - Try to use clang 11 for stackwalk r=firefox-build-system-reviewers,andi,mhentges default tip
Sylvestre Ledru <sledru@mozilla.com> - Sat, 28 Nov 2020 13:34:01 +0000 - rev 558593
Push 37986 by rmaries@mozilla.com at Sat, 28 Nov 2020 21:35:48 +0000
Bug 1588710 - Try to use clang 11 for stackwalk r=firefox-build-system-reviewers,andi,mhentges Differential Revision: https://phabricator.services.mozilla.com/D97568
194ca0c692cd02eb8b3a0387f5d3b999132bf9ae: Bug 1662062. Make StackingContextHelper constructor handle pinch zooming resolution when calculatoring the scale. r=jrmuizel
Timothy Nikkel <tnikkel@gmail.com> - Sat, 28 Nov 2020 09:50:14 +0000 - rev 558592
Push 37986 by rmaries@mozilla.com at Sat, 28 Nov 2020 21:35:48 +0000
Bug 1662062. Make StackingContextHelper constructor handle pinch zooming resolution when calculatoring the scale. r=jrmuizel Looks like it's just a case we missed. This affects on desktop and android. Differential Revision: https://phabricator.services.mozilla.com/D97716
43cc31d4bf1d5fa50c7f90d7f864aada1e570db0: Backed out changeset 774fb7eed629 (bug 1662062) for Build bustages in StackingContextHelper.cpp. CLOSED TREE
Dorel Luca <dluca@mozilla.com> - Sat, 28 Nov 2020 11:13:29 +0200 - rev 558591
Push 37986 by rmaries@mozilla.com at Sat, 28 Nov 2020 21:35:48 +0000
Backed out changeset 774fb7eed629 (bug 1662062) for Build bustages in StackingContextHelper.cpp. CLOSED TREE
774fb7eed629431765c3991deb25326c00156d79: Bug 1662062. Make StackingContextHelper constructor handle pinch zooming resolution when calculatoring the scale. r=jrmuizel
Timothy Nikkel <tnikkel@gmail.com> - Fri, 27 Nov 2020 14:11:48 +0000 - rev 558590
Push 37986 by rmaries@mozilla.com at Sat, 28 Nov 2020 21:35:48 +0000
Bug 1662062. Make StackingContextHelper constructor handle pinch zooming resolution when calculatoring the scale. r=jrmuizel Looks like it's just a case we missed. This affects on desktop and android. Differential Revision: https://phabricator.services.mozilla.com/D97716
63ef4a835e6c7012d527417b843a3995c66ebac7: Bug 1678310: Expose siteOriginNoSuffix on nsIPrincipal r=baku,nika
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Sat, 28 Nov 2020 07:21:32 +0000 - rev 558589
Push 37986 by rmaries@mozilla.com at Sat, 28 Nov 2020 21:35:48 +0000
Bug 1678310: Expose siteOriginNoSuffix on nsIPrincipal r=baku,nika Differential Revision: https://phabricator.services.mozilla.com/D97605
77486ce0e2bcf6f7b0beeef34dbadceb1cd4d3f6: Bug 1678553 - part 12: Make `ContentCache` store character rects with `Maybe` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 27 Nov 2020 14:48:03 +0000 - rev 558588
Push 37985 by dluca@mozilla.com at Sat, 28 Nov 2020 09:27:06 +0000
Bug 1678553 - part 12: Make `ContentCache` store character rects with `Maybe` r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D97981
f7c2ac8767d534c32b487fa73ff2922f1525a3ac: Backed out 2 changesets (bug 1645528) for scroll related mochitest failures CLOSED TREE
Bogdan Tara <btara@mozilla.com> - Sat, 28 Nov 2020 04:21:50 +0200 - rev 558587
Push 37985 by dluca@mozilla.com at Sat, 28 Nov 2020 09:27:06 +0000
Backed out 2 changesets (bug 1645528) for scroll related mochitest failures CLOSED TREE Backed out changeset 08cd8d747c33 (bug 1645528) Backed out changeset 4bc8953d9bed (bug 1645528)
a4cd97ff70a9db2550000efc69a4358c4db062b3: Bug 1678553 - part 11: Make `ContentCache` store its `Caret` with `Maybe` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 27 Nov 2020 14:47:50 +0000 - rev 558586
Push 37985 by dluca@mozilla.com at Sat, 28 Nov 2020 09:27:06 +0000
Bug 1678553 - part 11: Make `ContentCache` store its `Caret` with `Maybe` r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D97980
08cd8d747c33ab8d092ea6de2aac565e79093b3e: Bug 1645528 - Code cleanups r=mattwoodrow
Robert Mader <robert.mader@posteo.de> - Thu, 26 Nov 2020 22:15:31 +0000 - rev 558585
Push 37985 by dluca@mozilla.com at Sat, 28 Nov 2020 09:27:06 +0000
Bug 1645528 - Code cleanups r=mattwoodrow Remove dead code that was left in D93173 so file histories would get preserved. Depends on D93173 Differential Revision: https://phabricator.services.mozilla.com/D96934
4bc8953d9bed6603f5f28f9a0b02adc8e9083617: Bug 1645528 - Connect nsRefreshDrivers in content processes with a widget-local vsync source r=mattwoodrow,emilio
Robert Mader <robert.mader@posteo.de> - Fri, 27 Nov 2020 23:33:18 +0000 - rev 558584
Push 37985 by dluca@mozilla.com at Sat, 28 Nov 2020 09:27:06 +0000
Bug 1645528 - Connect nsRefreshDrivers in content processes with a widget-local vsync source r=mattwoodrow,emilio To allow `requestAnimationFrame()` and similar things to run at monitor speed if there is only a window-specific vsyncsource available. This is the case for Wayland and, in the future, EGL/X11. Other backends may opt for window specific vsyncsources as well at some point. The idea is to, instead of using global vsync objects, expose a vsyncsource from nsWindow and use it for refresh drivers. For the content process, move VsyncChild to BrowserChild, so for each Browserchild there is only one VsyncChild to which all refresh drivers connect. IPC in managed either by PBrowser or PBackground. Right now, PBrowser is only used on Wayland, as both PBrowser and the Wayland vsyncsource run on the main thread. Other backends keep using the background thread for now. While at it, make it so that we constantly update the refresh rate. This is necessary for Wayland, but also on other platforms variable refresh rates are increasingly common. Do that by transimitting the vsync rate `SendNotify()`. How to test: - run the Wayland backend - enable `widget.wayland_vsync.enabled` - optionally: disable `privacy.reduceTimerPrecision` - run `vsynctester.com` or `testufo.com` Expected results: Instead of fixed 60Hz, things should update at monitor refresh rate - e.g. 144Hz Original patch by Kenny Levinsen. Differential Revision: https://phabricator.services.mozilla.com/D93173
05ee4f04dd02c3f5adcb4de614a12ffe139a8e71: Bug 1678553 - part 10: Make `ContentCache` store its `Selection` with `Maybe` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 27 Nov 2020 14:47:37 +0000 - rev 558583
Push 37985 by dluca@mozilla.com at Sat, 28 Nov 2020 09:27:06 +0000
Bug 1678553 - part 10: Make `ContentCache` store its `Selection` with `Maybe` r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D97979
d70a9cd7bd71672181847c87599501c35726b494: Bug 1679577 - Disable d3d11 double buffering on Nightly. r=jrmuizel
Matt Woodrow <mwoodrow@mozilla.com> - Fri, 27 Nov 2020 22:32:06 +0000 - rev 558582
Push 37985 by dluca@mozilla.com at Sat, 28 Nov 2020 09:27:06 +0000
Bug 1679577 - Disable d3d11 double buffering on Nightly. r=jrmuizel We're unlikely to get around to fixing the bugs preventing this from riding the trains in the near future, so it'll be better to have Nightly be consistent with release (since it can hide bugs otherwise). Depends on D98092 Differential Revision: https://phabricator.services.mozilla.com/D98093
c927b7ad07cb89caa91b183a3af13734f441be01: Bug 1679577 - Disable advanced layers pref. r=jrmuizel
Matt Woodrow <mwoodrow@mozilla.com> - Fri, 27 Nov 2020 22:24:11 +0000 - rev 558581
Push 37985 by dluca@mozilla.com at Sat, 28 Nov 2020 09:27:06 +0000
Bug 1679577 - Disable advanced layers pref. r=jrmuizel We want to remove this in the future, as it's a large amount of code and is being superceeded by WebRender. Depends on D98091 Differential Revision: https://phabricator.services.mozilla.com/D98092
ea7a5405334e2c55da08f92bc47c7983de261581: Bug 1545313 - Don't force present if we haven't resized the swap chain yet. r=jrmuizel
Matt Woodrow <mwoodrow@mozilla.com> - Fri, 27 Nov 2020 22:32:05 +0000 - rev 558580
Push 37985 by dluca@mozilla.com at Sat, 28 Nov 2020 09:27:06 +0000
Bug 1545313 - Don't force present if we haven't resized the swap chain yet. r=jrmuizel This matches the behaviour of MLGDevice Depends on D98036 Differential Revision: https://phabricator.services.mozilla.com/D98091
c1fa6c80a1a0b89163701c9a07f9b892ecb6d91e: Bug 1678553 - part 9: Make `ContentCacheInChild` store last commit start offset and commit string with `Maybe` and `OffsetAndData` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 27 Nov 2020 14:47:30 +0000 - rev 558579
Push 37985 by dluca@mozilla.com at Sat, 28 Nov 2020 09:27:06 +0000
Bug 1678553 - part 9: Make `ContentCacheInChild` store last commit start offset and commit string with `Maybe` and `OffsetAndData` r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D97978
d324a75e0e515ff8d348e059b8c6110ba26d96e3: Bug 1678553 - part 8: Make `TSFTextStore` store its `Selection` with `Maybe` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 27 Nov 2020 14:47:22 +0000 - rev 558578
Push 37985 by dluca@mozilla.com at Sat, 28 Nov 2020 09:27:06 +0000
Bug 1678553 - part 8: Make `TSFTextStore` store its `Selection` with `Maybe` r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D97954
18d9b3798b38db1789632c5e78ba1720ff1e4d5f: Bug 1666347 - Delete assorted dead code after removal of vendored `psutil` r=firefox-build-system-reviewers,rstewart
Ricky Stewart <rstewart@mozilla.com> - Fri, 27 Nov 2020 16:21:07 +0000 - rev 558577
Push 37985 by dluca@mozilla.com at Sat, 28 Nov 2020 09:27:06 +0000
Bug 1666347 - Delete assorted dead code after removal of vendored `psutil` r=firefox-build-system-reviewers,rstewart Most of the deletions here come from bug 1481612, the `--with-windows-wheel` option to `mach vendor python`, which according to that commit message "is very single-purpose: it's intended to let us vendor an unpacked wheel for psutil on Windows". Since vendoring `psutil` is something we're no longer doing, we can safely just delete that added code. Differential Revision: https://phabricator.services.mozilla.com/D90919
975d8f1de67388eb2b661b181e93db9d18a2af04: Bug 1666345 - Un-vendor `psutil` r=firefox-build-system-reviewers,rstewart
Ricky Stewart <rstewart@mozilla.com> - Fri, 20 Nov 2020 19:33:30 +0000 - rev 558576
Push 37985 by dluca@mozilla.com at Sat, 28 Nov 2020 09:27:06 +0000
Bug 1666345 - Un-vendor `psutil` r=firefox-build-system-reviewers,rstewart After bug 1661624, it's no longer required. Differential Revision: https://phabricator.services.mozilla.com/D90916
4058e147401f15cfca916f32156381725b4d2137: Bug 1661624 - Include `psutil` in the `mach` `virtualenv`s r=firefox-build-system-reviewers,rstewart
Ricky Stewart <rstewart@mozilla.com> - Fri, 27 Nov 2020 21:05:00 +0000 - rev 558575
Push 37985 by dluca@mozilla.com at Sat, 28 Nov 2020 09:27:06 +0000
Bug 1661624 - Include `psutil` in the `mach` `virtualenv`s r=firefox-build-system-reviewers,rstewart Install `psutil` when setting up the `mach` `virtualenv`s and stop importing the in-tree version in the build. Nothing in-tree currently assumes or mandates the installation of `psutil` (all uses of `psutil` are guarded with imports of the form `try : import psutil; except ImportError: psutil = None`), so there's no back-incompatibility concerns here. There will be an awkward period where telemetry will be lacking CPU/disk data for everyone until they re-run `mach bootstrap` or `mach create-mach-environment`, but that will come back as people gradually update their `virtualenv`s. An alternative to circumvent that issue is REQUIRING that `psutil` be installed by adding an assertion in `mach` that `psutil` can be found (allowing us to remove all the conditional logic in-tree around whether `psutil` is installed), but I wouldn't claim that we're ready to do that and deal with whatever fallout might occur. Differential Revision: https://phabricator.services.mozilla.com/D90914
aa9fa0c1429b6d4b5f353d3ae582aeefbfe70b77: Bug 1667152 - Add `--requirements` argument to `mach python` r=ahal
Ricky Stewart <rstewart@mozilla.com> - Fri, 20 Nov 2020 19:29:26 +0000 - rev 558574
Push 37985 by dluca@mozilla.com at Sat, 28 Nov 2020 09:27:06 +0000
Bug 1667152 - Add `--requirements` argument to `mach python` r=ahal Differential Revision: https://phabricator.services.mozilla.com/D91313
124e488aae3abf81f24593043ed3073dcc1645a7: Bug 1589103 Unskip browser_privilegedmozilla_process_pref.js r=nika
neha <nkochar@mozilla.com> - Fri, 27 Nov 2020 20:06:08 +0000 - rev 558573
Push 37985 by dluca@mozilla.com at Sat, 28 Nov 2020 09:27:06 +0000
Bug 1589103 Unskip browser_privilegedmozilla_process_pref.js r=nika Depends on D98086 Differential Revision: https://phabricator.services.mozilla.com/D98087
484813dea46a20436776138bc01bd320a89458e3: Bug 1589103 Don't wait for SSTabRestored event. This event doesn't get fired when back/forward causes processes switching. r=nika
neha <nkochar@mozilla.com> - Fri, 27 Nov 2020 20:03:09 +0000 - rev 558572
Push 37985 by dluca@mozilla.com at Sat, 28 Nov 2020 09:27:06 +0000
Bug 1589103 Don't wait for SSTabRestored event. This event doesn't get fired when back/forward causes processes switching. r=nika Differential Revision: https://phabricator.services.mozilla.com/D98086
00c93ac66282823257969d14e0aa0b115fb29f14: Bug 1678451 - Split the Ubuntu test image and work around recent issues. r=releng-reviewers,bhearsum
Mike Hommey <mh+mozilla@glandium.org> - Fri, 27 Nov 2020 16:34:50 +0000 - rev 558571
Push 37985 by dluca@mozilla.com at Sat, 28 Nov 2020 09:27:06 +0000
Bug 1678451 - Split the Ubuntu test image and work around recent issues. r=releng-reviewers,bhearsum To avoid breakage from Ubuntu package upgrades, we split the test image into two, one that sets up the packages only, and that won't change when we need to update our scripts, and another that derives from it, that adds all our scripts and other setup. Additionally, we work around the recent timeout issues due to the upgrade of packages. The timeout itself is due to gst-launch waiting indefinitely when it crashes, rather than exiting with an error code. Bug 1679491 addresses this issue, but the core problem is that gst-launch crashes, which seems to be that some change in libc (presumably "Fix pthread_rwlock_try*lock stalls") turns `gst_object_unref: assertion '((GObject *) object)->ref_count > 0' failed` fatal warnings (which were already happening) into actual crashes (presumably because a race condition is lost on a use-after-free). This workaround, however, will stop working as soon as the updated libc package migrates from bionic-updates into bionic proper, presumaby on the next 18.04 dot-release. Hopefully, we won't be rebuilding the base image for a while, avoiding further problems. Eventually, we'll want to upload the base image to docker hub so that it's set in stone, and change the FROM in the base image to use that instead. Differential Revision: https://phabricator.services.mozilla.com/D98045
720abcd1630aaf326eb70265bee1a0d28c3d4552: Bug 1679568. Cleanup profile creation. r=aosmond
Jeff Muizelaar <jmuizelaar@mozilla.com> - Fri, 27 Nov 2020 19:09:24 +0000 - rev 558570
Push 37985 by dluca@mozilla.com at Sat, 28 Nov 2020 09:27:06 +0000
Bug 1679568. Cleanup profile creation. r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D98084
6a903dbf9aa287f8d1f2863e0b8915218d5ac346: Bug 1679568. Reduce the visibility of the qcms_profile members. r=aosmond
Jeff Muizelaar <jmuizelaar@mozilla.com> - Fri, 27 Nov 2020 19:08:26 +0000 - rev 558569
Push 37985 by dluca@mozilla.com at Sat, 28 Nov 2020 09:27:06 +0000
Bug 1679568. Reduce the visibility of the qcms_profile members. r=aosmond And make profile_sRGB() public. Differential Revision: https://phabricator.services.mozilla.com/D98083
350917c61bc2f72a7c4d0a9b2a6e2c89a679a4b1: Bug 1679411 - Make qcms_profile_sRGB() safer. r=aosmond
Jeff Muizelaar <jmuizelaar@mozilla.com> - Fri, 27 Nov 2020 18:26:33 +0000 - rev 558568
Push 37985 by dluca@mozilla.com at Sat, 28 Nov 2020 09:27:06 +0000
Bug 1679411 - Make qcms_profile_sRGB() safer. r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D98056
1c8480affdfd71eeced35da2b6acf3d8b36f0523: Bug 1678813 - to ensure we would create promise focus before tab is closed. r=bryce
alwu <alwu@mozilla.com> - Fri, 27 Nov 2020 18:09:34 +0000 - rev 558567
Push 37985 by dluca@mozilla.com at Sat, 28 Nov 2020 09:27:06 +0000
Bug 1678813 - to ensure we would create promise focus before tab is closed. r=bryce Differential Revision: https://phabricator.services.mozilla.com/D98014
fa29b052066874836933b78c8b6d0812d58239ab: Bug 1678613 - Use property descriptors in promise previewers. r=nchevobbe
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 27 Nov 2020 15:53:55 +0000 - rev 558566
Push 37985 by dluca@mozilla.com at Sat, 28 Nov 2020 09:27:06 +0000
Bug 1678613 - Use property descriptors in promise previewers. r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D97760
c37b45058138b98b1705bc761c448d22b41cfbe9: Bug 1669282 Disable scheme handlers in flatpak until portal is provided; r=stransky DONTBUILD
Jan Horak <jhorak@redhat.com> - Fri, 27 Nov 2020 15:38:34 +0000 - rev 558565
Push 37985 by dluca@mozilla.com at Sat, 28 Nov 2020 09:27:06 +0000
Bug 1669282 Disable scheme handlers in flatpak until portal is provided; r=stransky DONTBUILD We need to disable current scheme handling under flatpak because it expects there's system handler for all schemes (which is wrong for example for 'localhost') until there's a flatpak portal which provides if system has a handler for specific scheme. Differential Revision: https://phabricator.services.mozilla.com/D97967
d7ae1b44e7a6084835bd0fffae8b4391f464f92c: Bug 1677696 - Use texture array shader variant for clear tiles. r=jnicol
Nicolas Silva <nsilva@mozilla.com> - Fri, 27 Nov 2020 15:53:06 +0000 - rev 558564
Push 37985 by dluca@mozilla.com at Sat, 28 Nov 2020 09:27:06 +0000
Bug 1677696 - Use texture array shader variant for clear tiles. r=jnicol The dummy texture is a texture array. The bug was caused by selecting the non-array version of the shader while binding a texture array. Differential Revision: https://phabricator.services.mozilla.com/D97991
11714ca0f7e69914a4240cd223d8cbb7f5716cda: Bug 1679468 - Block AMD 8.56.1.15/16 from WebRender. r=mattwoodrow
Jeff Muizelaar <jmuizelaar@mozilla.com> - Fri, 27 Nov 2020 03:31:09 +0000 - rev 558563
Push 37985 by dluca@mozilla.com at Sat, 28 Nov 2020 09:27:06 +0000
Bug 1679468 - Block AMD 8.56.1.15/16 from WebRender. r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D98030
93032b063d9f791d4406fcbf090c5f319565e9af: Bug 1678711 - Make running with --software without the "software" feature panic. r=lsalzman
Jeff Muizelaar <jmuizelaar@mozilla.com> - Fri, 27 Nov 2020 14:51:19 +0000 - rev 558562
Push 37985 by dluca@mozilla.com at Sat, 28 Nov 2020 09:27:06 +0000
Bug 1678711 - Make running with --software without the "software" feature panic. r=lsalzman I think this is more helpful than silently failing. Differential Revision: https://phabricator.services.mozilla.com/D97804
505df7b646b699f59e53c845e8f2f96bbbedafe9: Bug 1650609 - Add a testcase to ensure 'Save Page As' is working in OfflineMode. r=dimi
Tim Huang <tihuang@mozilla.com> - Thu, 19 Nov 2020 09:26:23 +0000 - rev 558561
Push 37985 by dluca@mozilla.com at Sat, 28 Nov 2020 09:27:06 +0000
Bug 1650609 - Add a testcase to ensure 'Save Page As' is working in OfflineMode. r=dimi Differential Revision: https://phabricator.services.mozilla.com/D96997
c42696dc97c623acea5083ffcfef03a5f990756a: Backed out changeset e3fe4c531d53 (bug 1678711) for wrench bustages on main.rs . CLOSED TREE
Narcis Beleuzu <nbeleuzu@mozilla.com> - Fri, 27 Nov 2020 16:38:40 +0200 - rev 558560
Push 37984 by nbeleuzu@mozilla.com at Fri, 27 Nov 2020 15:53:21 +0000
Backed out changeset e3fe4c531d53 (bug 1678711) for wrench bustages on main.rs . CLOSED TREE
655eb620b6c86a7d66fd109a02d7d1d8fc5e097c: Bug 1670834 - Make `TSFTextStore` stop setting selection with expanding it to cluster boundaries in Nightly channel and early beta builds or active TIP is Keyman Desktop r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 27 Nov 2020 11:49:53 +0000 - rev 558559
Push 37984 by nbeleuzu@mozilla.com at Fri, 27 Nov 2020 15:53:21 +0000
Bug 1670834 - Make `TSFTextStore` stop setting selection with expanding it to cluster boundaries in Nightly channel and early beta builds or active TIP is Keyman Desktop r=m_kato IPA (SIL) keyboard for Keyman Desktop tries to delete only a combined diacritical mark when user toggles it. However, `TSFTextStore` uses `eSetSelection` event without explicitly setting `mExpandToClusterBoundary`. Its default value is `true` and it causes deleting a previous base character of the deleting diacritical mark too. I think that it should be set to `false` when the selection range is specified by IME framework and IME itself. However, some TIPs may have already done some hack if focused window is ours. For avoiding the regression risk, we should change our behavior only when - The active TIP is Keyman Desktop (It has common CLSID for any keyboard layouts) - In the Nightly channel or early beta builds for any other TIPs Differential Revision: https://phabricator.services.mozilla.com/D97976
7fc573b3ad65351d6db818a16909daf386e42dc6: Backed out 2 changesets (bug 1678553) for MinGW bustages on ToString.h
Narcis Beleuzu <nbeleuzu@mozilla.com> - Fri, 27 Nov 2020 16:35:26 +0200 - rev 558558
Push 37984 by nbeleuzu@mozilla.com at Fri, 27 Nov 2020 15:53:21 +0000
Backed out 2 changesets (bug 1678553) for MinGW bustages on ToString.h Backed out changeset a21c164db6ff (bug 1678553) Backed out changeset 2f95b040da6c (bug 1678553)
e3fe4c531d533ed0424fb5d528e0ce3d4c312fd1: Bug 1678711 - Make running with --software without the "software" feature panic. r=lsalzman
Jeff Muizelaar <jmuizelaar@mozilla.com> - Fri, 20 Nov 2020 20:08:16 +0000 - rev 558557
Push 37984 by nbeleuzu@mozilla.com at Fri, 27 Nov 2020 15:53:21 +0000
Bug 1678711 - Make running with --software without the "software" feature panic. r=lsalzman I think this is more helpful than silently failing. Differential Revision: https://phabricator.services.mozilla.com/D97804
2ea2d5dcce731e9fd3932769e55e32d8bf9a680b: Bug 1678160 - Use QueryPerformanceCounter on Windows instead of clock(). r=lsalzman
Jeff Muizelaar <jmuizelaar@mozilla.com> - Thu, 19 Nov 2020 03:46:52 +0000 - rev 558556
Push 37984 by nbeleuzu@mozilla.com at Fri, 27 Nov 2020 15:53:21 +0000
Bug 1678160 - Use QueryPerformanceCounter on Windows instead of clock(). r=lsalzman QueryPerformanceCounter has more precision. Differential Revision: https://phabricator.services.mozilla.com/D97501
afee4b159b05a4d5695a736af8839ee2ac24acb2: Bug 1679451 - set css/CSS2/text/text-transform-bicameral-003.xht as intermittent on Windows 7 debug. r=jgraham DONTBUILD
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 27 Nov 2020 13:14:28 +0000 - rev 558555
Push 37984 by nbeleuzu@mozilla.com at Fri, 27 Nov 2020 15:53:21 +0000
Bug 1679451 - set css/CSS2/text/text-transform-bicameral-003.xht as intermittent on Windows 7 debug. r=jgraham DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D98048
d20bc2412405792bc88466f736d4c50d12261ccf: Backed out changeset 60be841f0025 (bug 1670834) for MinGW bustages on ToString.h CLOSED TREE
Narcis Beleuzu <nbeleuzu@mozilla.com> - Fri, 27 Nov 2020 15:44:09 +0200 - rev 558554
Push 37984 by nbeleuzu@mozilla.com at Fri, 27 Nov 2020 15:53:21 +0000
Backed out changeset 60be841f0025 (bug 1670834) for MinGW bustages on ToString.h CLOSED TREE
a21c164db6ff79e79e4c77364da7a8e931646598: Bug 1678553 - part 9: Make `ContentCacheInChild` store last commit start offset and commit string with `Maybe` and `OffsetAndData` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 27 Nov 2020 06:39:59 +0000 - rev 558553
Push 37984 by nbeleuzu@mozilla.com at Fri, 27 Nov 2020 15:53:21 +0000
Bug 1678553 - part 9: Make `ContentCacheInChild` store last commit start offset and commit string with `Maybe` and `OffsetAndData` r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D97978
60be841f0025d8e948c30a32d2c258fc4a8e1155: Bug 1670834 - Make `TSFTextStore` stop setting selection with expanding it to cluster boundaries in Nightly channel and early beta builds or active TIP is Keyman Desktop r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 27 Nov 2020 11:49:53 +0000 - rev 558552
Push 37984 by nbeleuzu@mozilla.com at Fri, 27 Nov 2020 15:53:21 +0000
Bug 1670834 - Make `TSFTextStore` stop setting selection with expanding it to cluster boundaries in Nightly channel and early beta builds or active TIP is Keyman Desktop r=m_kato IPA (SIL) keyboard for Keyman Desktop tries to delete only a combined diacritical mark when user toggles it. However, `TSFTextStore` uses `eSetSelection` event without explicitly setting `mExpandToClusterBoundary`. Its default value is `true` and it causes deleting a previous base character of the deleting diacritical mark too. I think that it should be set to `false` when the selection range is specified by IME framework and IME itself. However, some TIPs may have already done some hack if focused window is ours. For avoiding the regression risk, we should change our behavior only when - The active TIP is Keyman Desktop (It has common CLSID for any keyboard layouts) - In the Nightly channel or early beta builds for any other TIPs Differential Revision: https://phabricator.services.mozilla.com/D97976
88d559804ae95728240e48d60b3bff51ca7f2959: Bug 1624446 - Adjust reftest fuzziness. r=jnicol
Nicolas Silva <nsilva@mozilla.com> - Thu, 26 Nov 2020 16:54:32 +0000 - rev 558551
Push 37984 by nbeleuzu@mozilla.com at Fri, 27 Nov 2020 15:53:21 +0000
Bug 1624446 - Adjust reftest fuzziness. r=jnicol Differential Revision: https://phabricator.services.mozilla.com/D98002
2f95b040da6cce680729dc2e90a0e8ca838f1af6: Bug 1678553 - part 8: Make `TSFTextStore` store its `Selection` with `Maybe` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 27 Nov 2020 06:41:20 +0000 - rev 558550
Push 37984 by nbeleuzu@mozilla.com at Fri, 27 Nov 2020 15:53:21 +0000
Bug 1678553 - part 8: Make `TSFTextStore` store its `Selection` with `Maybe` r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D97954
cbec456b418b4dcd0059d9f5725e746db804d04f: Bug 1679035 - Part 5: Use tzcnt for MacroAssembler::ctz64() on x86. r=iain
André Bargull <andre.bargull@gmail.com> - Fri, 27 Nov 2020 10:44:36 +0000 - rev 558549
Push 37984 by nbeleuzu@mozilla.com at Fri, 27 Nov 2020 15:53:21 +0000
Bug 1679035 - Part 5: Use tzcnt for MacroAssembler::ctz64() on x86. r=iain Similar to part 2 and part 4, use `tzcnt` for `MacroAssembler::ctz64()` on x86. Depends on D97962 Differential Revision: https://phabricator.services.mozilla.com/D97963
8858896c3f731e0886c5cb28ee3e9ecf1de30176: Bug 1679035 - Part 4: Use lzcnt for MacroAssembler::clz64() on x86. r=iain
André Bargull <andre.bargull@gmail.com> - Thu, 26 Nov 2020 21:02:38 +0000 - rev 558548
Push 37984 by nbeleuzu@mozilla.com at Fri, 27 Nov 2020 15:53:21 +0000
Bug 1679035 - Part 4: Use lzcnt for MacroAssembler::clz64() on x86. r=iain Also use `lzcnt` for `MacroAssembler::clz64()` on x86. And add a comment where we rely on `bsr` not modifying its output when the input is zero. Drive-by change: - Actually test we get the expected result in `wasmFullPassI64()` in "lib/wasm.js". Differential Revision: https://phabricator.services.mozilla.com/D97962
0cdb6eba18ba1bd681d55517910e4d109cb0ae99: Bug 1679035 - Part 3: Use sarx, shrx, shlx for MacroAssembler shift functions. r=iain
André Bargull <andre.bargull@gmail.com> - Wed, 25 Nov 2020 15:03:23 +0000 - rev 558547
Push 37984 by nbeleuzu@mozilla.com at Fri, 27 Nov 2020 15:53:21 +0000
Bug 1679035 - Part 3: Use sarx, shrx, shlx for MacroAssembler shift functions. r=iain BMI2 adds support for `sarx`, `shrx`, and `shlx`. These are similar to the existing `sar`, `shr`, and `shl` instructions, but don't require the shift amount to be in `ecx`, which helps the register allocator. They don't affect any flags, but this is mostly irrelevant in our code. Because flags aren't affected, the BMI2 shift instructions can also be faster, cf. instructions timings from Agner. Existing callers to `MacroAssembler::{sarl,shrl,shll}_cl()` were updated to call `MacroAssembler::{rshift32Arithmetic,rshift32,lshift32}()`, which ensures the BMI2 shift instructions are called when they're supported. `LIRGeneratorX86Shared::lowerForShift{Int64}()` is also called for `MRotate`, which still requires the rotate amount to be in `ecx`. (BMI2 didn't add new variable rotate instructions, so we can't update those.) Furthermore `lowerForShiftInt64()` also requires to always use `ecx` on x86, because the 64-bit MacroAssembler shift functions in "MacroAssembler-x86-inl.h" are using the `shrd` resp. `shld` instructions which also require the shift amount to be in `ecx`. Similar changes were also applied to "WasmBaselineCompile.cpp". Differential Revision: https://phabricator.services.mozilla.com/D97887
8ae6c2ccdd5634124274fc5d9b7d96065b8ae093: Bug 1679035 - Part 2: Use tzcnt instruction for MacroAssembler::ctz{32,64}(). r=iain
André Bargull <andre.bargull@gmail.com> - Wed, 25 Nov 2020 15:00:19 +0000 - rev 558546
Push 37984 by nbeleuzu@mozilla.com at Fri, 27 Nov 2020 15:53:21 +0000
Bug 1679035 - Part 2: Use tzcnt instruction for MacroAssembler::ctz{32,64}(). r=iain BMI1 added support for the `tzcnt` instruction which can be used to implement `MacroAssembler::ctz{32,64}()`. Differential Revision: https://phabricator.services.mozilla.com/D97886
585e872c67a2eb7aca96a429a7ba13f977a430a9: Bug 1679035 - Part 1: Use lzcnt instruction for MacroAssembler::clz{32,64}(). r=iain
André Bargull <andre.bargull@gmail.com> - Wed, 25 Nov 2020 14:58:24 +0000 - rev 558545
Push 37984 by nbeleuzu@mozilla.com at Fri, 27 Nov 2020 15:53:21 +0000
Bug 1679035 - Part 1: Use lzcnt instruction for MacroAssembler::clz{32,64}(). r=iain Use the `lzcnt` instruction when it is available. Differential Revision: https://phabricator.services.mozilla.com/D97885
3d360356c59f7da4b6d59ca38cb19e8654ddf2c1: Bug 1663213 - Clear DoH cache when the TRRService mode goes from ON to OFF r=necko-reviewers,kershaw
Valentin Gosu <valentin.gosu@gmail.com> - Fri, 27 Nov 2020 10:44:28 +0000 - rev 558544
Push 37984 by nbeleuzu@mozilla.com at Fri, 27 Nov 2020 15:53:21 +0000
Bug 1663213 - Clear DoH cache when the TRRService mode goes from ON to OFF r=necko-reviewers,kershaw This is necessary in order to avoid using cached entries on a network where they might not be valid (such as when using a VPN). This might not fix things when turning on the VPN does not cause a network change event and thus no network.trr.mode/doh-rollout.mode change actually happens. Differential Revision: https://phabricator.services.mozilla.com/D97995
aaa9af4e5ebac0db29fe28a7e2db9336457f9b00: Bug 1588710 - Do not fail on stack protector on some asm chromium & breakpad sandboxing code r=mhentges
Sylvestre Ledru <sledru@mozilla.com> - Fri, 27 Nov 2020 10:14:01 +0000 - rev 558543
Push 37984 by nbeleuzu@mozilla.com at Fri, 27 Nov 2020 15:53:21 +0000
Bug 1588710 - Do not fail on stack protector on some asm chromium & breakpad sandboxing code r=mhentges caused: [task 2020-11-05T10:14:26.012Z] 10:14:26 INFO - In file included from Unified_cpp_sandbox_linux2.cpp:137: [task 2020-11-05T10:14:26.012Z] 10:14:26 ERROR - /builds/worker/checkouts/gecko/security/sandbox/chromium/sandbox/linux/seccomp-bpf/syscall.cc:369:3: error: Unable to protect inline asm that clobbers stack pointer against stack clash [-Werror,-Wstack-protector] [task 2020-11-05T10:14:26.012Z] 10:14:26 INFO - asm volatile( [task 2020-11-05T10:14:26.013Z] 10:14:26 INFO - ^ [task 2020-11-05T10:14:26.013Z] 10:14:26 INFO - 1 error generated. Differential Revision: https://phabricator.services.mozilla.com/D97567
92ee97433b0cd47d8ed0335e317a18beb894c161: Bug 1679442 - Fix handling of missing assertion count, r=whimboo
James Graham <james@hoppipolla.co.uk> - Thu, 26 Nov 2020 20:42:10 +0000 - rev 558542
Push 37984 by nbeleuzu@mozilla.com at Fri, 27 Nov 2020 15:53:21 +0000
Bug 1679442 - Fix handling of missing assertion count, r=whimboo This doesn't work in Py3 because we can't compare an int with None. If the count is None we don't want to log anything, so just check for that. Differential Revision: https://phabricator.services.mozilla.com/D98018
ab82da735f6c6cecabf08d7eef7388140a454763: Backed out changeset 223338b5183e (bug 1663213) for xpcshell failure on test_trr.js . CLOSED TREE
Narcis Beleuzu <nbeleuzu@mozilla.com> - Fri, 27 Nov 2020 11:42:52 +0200 - rev 558541
Push 37984 by nbeleuzu@mozilla.com at Fri, 27 Nov 2020 15:53:21 +0000
Backed out changeset 223338b5183e (bug 1663213) for xpcshell failure on test_trr.js . CLOSED TREE
58b1d3c7d6dae31ededf0b485b9dbe855b085dd0: Bug 1678553 - part 7: Make `TSFTextStore` store its `Composition` with `Maybe` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 27 Nov 2020 02:01:03 +0000 - rev 558540
Push 37984 by nbeleuzu@mozilla.com at Fri, 27 Nov 2020 15:53:21 +0000
Bug 1678553 - part 7: Make `TSFTextStore` store its `Composition` with `Maybe` r=m_kato Then, `TSFTextStore::mComposition` becomes much simpler. Differential Revision: https://phabricator.services.mozilla.com/D97953
7a1bef988ee2c073783f5cb2b247834894d2e446: Bug 1679396 - Upgrade Sphinx and update requirements r=sylvestre DONTBUILD
Zac Svoboda <cczac1@gmail.com> - Fri, 27 Nov 2020 08:54:33 +0000 - rev 558539
Push 37984 by nbeleuzu@mozilla.com at Fri, 27 Nov 2020 15:53:21 +0000
Bug 1679396 - Upgrade Sphinx and update requirements r=sylvestre DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D97994
223338b5183e466f35f9df2e9d1b86aa2efde3dd: Bug 1663213 - Clear DoH cache when the TRRService mode goes from ON to OFF r=necko-reviewers,kershaw
Valentin Gosu <valentin.gosu@gmail.com> - Thu, 26 Nov 2020 20:01:47 +0000 - rev 558538
Push 37984 by nbeleuzu@mozilla.com at Fri, 27 Nov 2020 15:53:21 +0000
Bug 1663213 - Clear DoH cache when the TRRService mode goes from ON to OFF r=necko-reviewers,kershaw This is necessary in order to avoid using cached entries on a network where they might not be valid (such as when using a VPN). This might not fix things when turning on the VPN does not cause a network change event and thus no network.trr.mode/doh-rollout.mode change actually happens. Differential Revision: https://phabricator.services.mozilla.com/D97995
0ecc51ff0cddf5ba357038b51d2cce52c2267972: Backed out 6 changesets (bug 1660336) for causing media related failures. CLOSED TREE
Csoregi Natalia <ncsoregi@mozilla.com> - Fri, 27 Nov 2020 05:08:40 +0200 - rev 558537
Push 37984 by nbeleuzu@mozilla.com at Fri, 27 Nov 2020 15:53:21 +0000
Backed out 6 changesets (bug 1660336) for causing media related failures. CLOSED TREE Backed out changeset 1aa6c9d65403 (bug 1660336) Backed out changeset f1dadb052d3a (bug 1660336) Backed out changeset bdf9d27bd4d2 (bug 1660336) Backed out changeset 373a658bb281 (bug 1660336) Backed out changeset 5ccda5ab6563 (bug 1660336) Backed out changeset e6f396b25887 (bug 1660336)
66841ce77403a398abccad8698b2ed352ffc3694: Bug 1678553 - part 6: Make `TSFTextStore::MouseTracker` store the range from TSF with `Maybe<StartAndEndOffsets>` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 27 Nov 2020 01:58:05 +0000 - rev 558536
Push 37984 by nbeleuzu@mozilla.com at Fri, 27 Nov 2020 15:53:21 +0000
Bug 1678553 - part 6: Make `TSFTextStore::MouseTracker` store the range from TSF with `Maybe<StartAndEndOffsets>` r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D97952
1aa6c9d65403b441c567ebda260f6b528060b492: Bug 1660336 Provide libva headers to build Firefox without libva-devel installed, r=jya
Martin Stransky <stransky@redhat.com> - Thu, 26 Nov 2020 21:26:05 +0000 - rev 558535
Push 37984 by nbeleuzu@mozilla.com at Fri, 27 Nov 2020 15:53:21 +0000
Bug 1660336 Provide libva headers to build Firefox without libva-devel installed, r=jya Differential Revision: https://phabricator.services.mozilla.com/D97920
f1dadb052d3aede268e66ea7e96c2827dd95605d: Bug 1660336 Provide libva wrapper to run Firefox on systems without libva installed, r=jya
stransky <stransky@redhat.com> - Thu, 26 Nov 2020 21:25:59 +0000 - rev 558534
Push 37984 by nbeleuzu@mozilla.com at Fri, 27 Nov 2020 15:53:21 +0000
Bug 1660336 Provide libva wrapper to run Firefox on systems without libva installed, r=jya Differential Revision: https://phabricator.services.mozilla.com/D94650
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -60 tip