f58ae8ec64c812739509de09659327bf7ea33494: Merge autoland to mozilla-central. a=merge default tip
Cosmin Sabou <csabou@mozilla.com> - Fri, 24 May 2019 12:53:24 +0300 - rev 475326
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Merge autoland to mozilla-central. a=merge
77898b7a7ea2197f9fa8fb4c3273450ec281f9c0: Bug 1546880 - [raptor] Remove proxy workaround from raptor-youtube-playback tests. r=perftest-reviewers,stephendonner
Henrik Skupin <mail@hskupin.info> - Fri, 24 May 2019 05:36:42 +0000 - rev 475325
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1546880 - [raptor] Remove proxy workaround from raptor-youtube-playback tests. r=perftest-reviewers,stephendonner Differential Revision: https://phabricator.services.mozilla.com/D32378
5b555225cd80dcef6ad2d4562422fc562f44d566: Bug 1546880 - Remove usage of proxy server from testing/profiles/perf/user.js. r=jmaher
Henrik Skupin <mail@hskupin.info> - Thu, 23 May 2019 23:45:18 +0000 - rev 475324
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1546880 - Remove usage of proxy server from testing/profiles/perf/user.js. r=jmaher Differential Revision: https://phabricator.services.mozilla.com/D32376
2bdc4e2c82aee93479fcb5efa74c7837fd0fc38c: Bug 1546880 - [talos] Replace remote w3c image with local copy. r=jmaher
Henrik Skupin <mail@hskupin.info> - Thu, 23 May 2019 23:39:38 +0000 - rev 475323
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1546880 - [talos] Replace remote w3c image with local copy. r=jmaher Differential Revision: https://phabricator.services.mozilla.com/D32375
03f986bdfdc395deb9359f219b35ce197ae7fbd5: Bug 1546323 Run cold page load tests against Fennec v64 in CI r=Bebe
alexandru.ionescu <alexandru.ionescu@softvision.ro> - Fri, 24 May 2019 07:12:19 +0000 - rev 475322
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1546323 Run cold page load tests against Fennec v64 in CI r=Bebe Differential Revision: https://phabricator.services.mozilla.com/D31773
4488934be4ddbbd72fcdc0f5968e596494ab5447: Backed out changeset 22fad4a26360 (bug 1548659) for Decision Task bustage CLOSED TREE
arthur.iakab <aiakab@mozilla.com> - Fri, 24 May 2019 10:11:25 +0300 - rev 475321
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Backed out changeset 22fad4a26360 (bug 1548659) for Decision Task bustage CLOSED TREE
22fad4a263600854248defec334e89d80c325f3d: Bug 1548659 - demote all android-em-4.3 tests to tier 2 and restrict platforms r=jmaher,RyanVM,gbrown
Edwin Gao <egao@mozilla.com> - Fri, 24 May 2019 06:52:46 +0000 - rev 475320
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1548659 - demote all android-em-4.3 tests to tier 2 and restrict platforms r=jmaher,RyanVM,gbrown Changes: - demote all existing `android-em-4.*` tests to tier 2 - ensure the above tests only run on `try` and `mozilla-central` but with exceptions Differential Revision: https://phabricator.services.mozilla.com/D32086
3eda0c8cf975171c9d1c1f2d4c2f555531b03e88: Bug 1552287 part 2: [css-contain] Adjust various reflow & baseline methods so that layout-contained frames behave as if they have no baseline. r=TYLin
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 24 May 2019 04:46:17 +0000 - rev 475319
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1552287 part 2: [css-contain] Adjust various reflow & baseline methods so that layout-contained frames behave as if they have no baseline. r=TYLin We previously (in bug 1491235) adjusted some utility code to make layout-contained frames behave as if they have no baseline. But that's not sufficient. To make frames fully report lack-of-a-baseline, we now do the following for layout-contained frames, as of this patch: (a) We now leave the ReflowOutput outparam's BlockStartAscent member at its default value (which is what we do for frames without a baseline like e.g. nsCheckboxRadioFrame and nsHTMLCanvasFrame). And if the parent cares about the baseline, it'll then ask directly, using a baseline getter. (b) We now return 'false' in more implementations of bool-returning baseline-getter-methods (where 'false' indicates 'no baseline'). (c) We now return the margin-box-bottom edge, in the nscoord-returning 'GetLogicalBaseline()' getter method. (We typically do this by deferring to the inherited method, which ultimately comes from nsFrame's implementation). It's appropriate to use the margin-box-bottom edge when there's no baseline, per the definition of 'vertical-align: baseline', here: https://drafts.csswg.org/css2/visudet.html#propdef-vertical-align Depends on D32182 Differential Revision: https://phabricator.services.mozilla.com/D32183
9360fef47426b836880d8a0cdf99b9357d1273c9: Bug 1552287 part 1: [css-contain] Fix some CSS layout-containment web-platform-tests to make their assumptions more valid. r=TYLin
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 24 May 2019 04:46:07 +0000 - rev 475318
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1552287 part 1: [css-contain] Fix some CSS layout-containment web-platform-tests to make their assumptions more valid. r=TYLin In particular: - In contain-layout-suppress-baseline-002.html, the test currently indirectly relies on the 50px-tall-canvas being the tallest thing in each flex container. This isn't robustly true (and in fact on windows, the textarea is taller at 50.8px tall). So I'm adjusting this test so that it no longer has a hardcoded flex container size and no longer depends on this. - In contain-layout-baseline-005.html and its reference case, we need to explicitly specify 'vertical-align:baseline' to test baseline-alignment, because some of its tested form controls have other UA-stylesheet-provided default values of 'vertical-align'. (e.g. <select multiple> defaults to 'vertical-align:text-bottom") - Also: in that same test, we need to reduce the width of the an <input> textfield -- otherwise, it and the other elements on its line may not fit and may linewrap, which prevents us from effectively testing baseline-alignment on the linewrapped element. - In contain-layout-button-001.html, the expectation was not correct. Before this patch, the test expects that a layout-contained button will have the same baseline as an empty button, and that's an invalid expectation. An empty button uses a point inside of its content-box as its baseline, whereas a layout-contained element *has no baseline*, which means that it does 'vertical-align:baseline' alignment by aligning its own margin-bottom edge with the parent's baseline, per https://drafts.csswg.org/css2/visudet.html#propdef-vertical-align So, I'm amending the test to have this expectation and updating its meta tags to reference the updated expectation and with a reference to that spec text. Firefox fails the amended contain-layout-button-001.html test, so this patch adds a .ini file to reflect that failure. The next patch in this series will fix our implementation to make us pass the test, and will remove the .ini file. Chrome also fails the amended contain-layout-button-001.html tests, and I filed https://bugs.chromium.org/p/chromium/issues/detail?id=965740 on them with an explanation. Differential Revision: https://phabricator.services.mozilla.com/D32182
378c7b4699e1414768c217ba96c8d6f723f73747: Bug 1553252 - Use cbindgen for text-overflow r=emilio
violet <violet.bugreport@gmail.com> - Fri, 24 May 2019 04:48:46 +0000 - rev 475317
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1553252 - Use cbindgen for text-overflow r=emilio Differential Revision: https://phabricator.services.mozilla.com/D32285
ae71e496d5873033d9696c54fb8b36297abbf8d0: Bug 1429301 - Implement offset-rotate. r=emilio
Boris Chiou <boris.chiou@gmail.com> - Fri, 24 May 2019 03:42:03 +0000 - rev 475316
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1429301 - Implement offset-rotate. r=emilio This includes style system and layout update. I add 3 extra reftests because the original tests use ray() function as the offset-path, but we don't support it. It'd be better to add tests using a different type of offset-path. The spec issue about the serialization: https://github.com/w3c/fxtf-drafts/issues/340 Differential Revision: https://phabricator.services.mozilla.com/D32212
d795681e08ee85b905917247f81df03a451a2864: Backed out changeset 82b18d61da00 (bug 1553378) for build bustages. CLOSED TREE
Razvan Maries <rmaries@mozilla.com> - Fri, 24 May 2019 06:50:14 +0300 - rev 475315
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Backed out changeset 82b18d61da00 (bug 1553378) for build bustages. CLOSED TREE
6280c120acca9ac2b6c47db350f7bf8455f0b3a3: Bug 1550401 - Report OOM size when StringParam::GetString is failure. r=geckoview-reviewers,snorp
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 22 May 2019 18:43:08 +0000 - rev 475314
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1550401 - Report OOM size when StringParam::GetString is failure. r=geckoview-reviewers,snorp Actually, all JNI Exceptions with `java.lang.OutOfMemoryError` call `NS_ABORT_OOM(0)`. But `JNIEnv::NewString` in `StringParam::GetString` can know OOM size when returning `nullptr`. So call `NS_ABORT_OOM` directly when `NewString` is failure. Differential Revision: https://phabricator.services.mozilla.com/D31026
82b18d61da0017c61a072f20d2928de0e6ba1b87: Bug 1553378 - Devirtualize calls to GetText() / TextLength() when we know we have a Text node. r=smaug,jfkthame
Cameron McCormack <cam@mcc.id.au> - Fri, 24 May 2019 03:18:44 +0000 - rev 475313
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1553378 - Devirtualize calls to GetText() / TextLength() when we know we have a Text node. r=smaug,jfkthame Differential Revision: https://phabricator.services.mozilla.com/D32100
4cac09d7acbd1e6b841ae1786935f02e6ad9ec5d: Bug 1534081 - pref on vorbis decoding on RDD for macOS. r=drno
Michael Froman <mfroman@mozilla.com> - Fri, 24 May 2019 02:45:51 +0000 - rev 475312
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1534081 - pref on vorbis decoding on RDD for macOS. r=drno Differential Revision: https://phabricator.services.mozilla.com/D32349
6e69ff803ac9930aeb479e1462f46f941a17104c: Bug 1553701 - Remove the clip chain stack during the prepare_prims pass in WR. r=kvark,nical
Glenn Watson <github@intuitionlibrary.com> - Fri, 24 May 2019 03:09:28 +0000 - rev 475311
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1553701 - Remove the clip chain stack during the prepare_prims pass in WR. r=kvark,nical During the visibility pass, the main clip chain instance for each primitive is created. In the prim prepare pass, a clip chain instance is generated for each segment (of primitives that are segmented). This previously required maintaining the active clip chain stack during both passes. However, this is not ideal for a number of reasons: the code is somewhat complicated / error prone and the segment clip chain building step does more work than required. This patch changes the segment clip chain building code to set up the active clip nodes based on the result of the initial clip chain built for the overall primitive during the visibility pass. This means that it's no longer necessary to maintain the active clip chain stack during the prepare pass. This simplifies some upcoming picture caching changes related to avoiding redundant cache invalidations, which is the main motivation for the change. Differential Revision: https://phabricator.services.mozilla.com/D32250
065da3e6d4a7c1cd88bc98dfcbe45bedcbf1a917: Bug 1551520 - Use WR relative transform instead of the world inverse r=gw
Dzmitry Malyshau <dmalyshau@mozilla.com> - Fri, 24 May 2019 00:22:17 +0000 - rev 475310
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1551520 - Use WR relative transform instead of the world inverse r=gw This is a follow-up to https://phabricator.services.mozilla.com/D30600 Previously, I changed changed the space mapper logic to use the world transformations. This was seemingly needed because we requrested the relation between primitives and their clip nodes, which could be in unrelated spatial sub-trees. However, I believe the change was a mistake, since for clips we should not even try to get the relative mapping, and clipping is done in world space for these cases. This change reverts that logic back. ~~Fingers crossed for the try to not show any asserts firing up inside get_relative_transform.~~ Try is green 🎉 Differential Revision: https://phabricator.services.mozilla.com/D32382
6c59557f4033ec64ca701ebaeaa429f8659cd70e: Bug 1544242 - Give up on a test that's too fuzzy on win and OSX for now. CLOSED TREE
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 24 May 2019 04:56:57 +0200 - rev 475309
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1544242 - Give up on a test that's too fuzzy on win and OSX for now. CLOSED TREE Will try to reland it fixed.
a18731ceef1cfd33f9829d56e1afc3d8ddb093e0: Bug 1547795 - Hide Picture-in-Picture toggle on videos where its probably more annoying than not. r=JSON_voorhees
Mike Conley <mconley@mozilla.com> - Fri, 24 May 2019 01:41:08 +0000 - rev 475308
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1547795 - Hide Picture-in-Picture toggle on videos where its probably more annoying than not. r=JSON_voorhees This makes our video controls bindings check on loadedmetadata events whether or not to display the toggle. Differential Revision: https://phabricator.services.mozilla.com/D32365
99dfff71a4ca4e7cec211404f9efde80b3b7a693: Bug 1553972 - make --with-pgo-profile-path take a directory; r=nalexander
Nathan Froyd <froydnj@mozilla.com> - Fri, 24 May 2019 01:53:59 +0000 - rev 475307
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1553972 - make --with-pgo-profile-path take a directory; r=nalexander e10s profiling or IR-based PGO instrumentation will both produce multiple `.profraw` files that need to be handled in some way. Since clang's `-fprofile-generate` option takes a directory, it seems fitting to make `--with-pgo-profile-path` mirror that by taking a directory, and letting `merge_profdata.py` deal with whatever files it might find in said directory. Differential Revision: https://phabricator.services.mozilla.com/D32389
9ca9aa85cf988ace58d5b150cd01e772d995d2ef: Bug 1553973 - make run-profileserver.sh collect all .profraw files; r=firefox-build-system-reviewers,mshal
Nathan Froyd <froydnj@mozilla.com> - Thu, 23 May 2019 21:54:17 +0000 - rev 475306
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1553973 - make run-profileserver.sh collect all .profraw files; r=firefox-build-system-reviewers,mshal This change is necessary to make either e10s profiling or LLVM IR-based PGO instrumentation work properly, as both will generate multiple `.profraw` files. Differential Revision: https://phabricator.services.mozilla.com/D32390
16fd32ce0588d3ed6236919675903d6fb33b404f: Bug 1553710 - Sort the available chunks pool r=jonco
Paul Bone <pbone@mozilla.com> - Fri, 24 May 2019 01:40:35 +0000 - rev 475305
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1553710 - Sort the available chunks pool r=jonco Differential Revision: https://phabricator.services.mozilla.com/D32276
4c53283a32df35e65d1a0a36dabdffe5d57315db: Bug 1544242 - Add a test for a bug that this inadvertently fixes. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 24 May 2019 01:11:52 +0000 - rev 475304
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1544242 - Add a test for a bug that this inadvertently fixes. r=heycam Always generating the slot assignment combinator means that we check the current host correctly. Differential Revision: https://phabricator.services.mozilla.com/D32405
6c075a98cbe2ecb385960b75018c1ac0f8ac4c91: Bug 1543829 - include LMDB license in about:license r=mossop,mhoye
Myk Melez <myk@mykzilla.org> - Fri, 24 May 2019 01:25:44 +0000 - rev 475303
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1543829 - include LMDB license in about:license r=mossop,mhoye Differential Revision: https://phabricator.services.mozilla.com/D30122
2e6402ff4bf6510cb26c0c552860b8f32c899af8: Bug 1553198: PreferenceExperiment only cleans up its own experiments r=mythmon
Ethan Glasser-Camp <ethan@betacantrips.com> - Thu, 23 May 2019 18:05:05 +0000 - rev 475302
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1553198: PreferenceExperiment only cleans up its own experiments r=mythmon Differential Revision: https://phabricator.services.mozilla.com/D32340
bb245437de6449617e2a50a4db207d86114154d4: Bug 1553198: PreferenceExperiments.start takes an actionName r=mythmon
Ethan Glasser-Camp <ethan@betacantrips.com> - Thu, 23 May 2019 18:23:16 +0000 - rev 475301
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1553198: PreferenceExperiments.start takes an actionName r=mythmon Differential Revision: https://phabricator.services.mozilla.com/D32339
81d97da2c8b05e734845244cdf8a8207622e3e87: Bug 1553198: Introduce PreferenceExperiments storage format v3 r=mythmon
Ethan Glasser-Camp <ethan@betacantrips.com> - Thu, 23 May 2019 18:21:20 +0000 - rev 475300
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1553198: Introduce PreferenceExperiments storage format v3 r=mythmon This format includes an "actionName" for each experiment which identifies the source of the experiment. This makes it possible for each experiment type to identify which experiments it should clean up vs. which it should leave alone because they don't belong to it. Differential Revision: https://phabricator.services.mozilla.com/D32338
1becf7e812023c910b3b8d84413e1f376590cd58: Bug 1544242 - Cleanup selector-matching for nested pseudo-elements, match ::slotted correctly when there's no selector before it, and add tests. r=heycam,mats
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 24 May 2019 01:09:15 +0000 - rev 475299
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1544242 - Cleanup selector-matching for nested pseudo-elements, match ::slotted correctly when there's no selector before it, and add tests. r=heycam,mats D29542 fixed the bogus checks that was making nested pseudo-elements match author rules. This adds tests and ends up being just a cleanup, though as it turns out we it also fixes an issue with ::slotted() matched from Element.matches. Differential Revision: https://phabricator.services.mozilla.com/D27529
96d3637d6e79b80061484002b70085a033d5b37b: Bug 1551871 - disabled browser_dbg-sourcemapped-preview.js on linux and macosx1010 r=jmaher
Andreea Pavel <apavel@mozilla.com> - Fri, 24 May 2019 01:12:00 +0000 - rev 475298
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1551871 - disabled browser_dbg-sourcemapped-preview.js on linux and macosx1010 r=jmaher Differential Revision: https://phabricator.services.mozilla.com/D32377
d451bd35ca1c95f6392cea158332c34e4729ee22: Backed out changeset 9a5f590f5f75 (bug 1480236) for android build bustages at nsIGlobalObject.cpp on a CLOSED TREE
Andreea Pavel <apavel@mozilla.com> - Fri, 24 May 2019 04:15:04 +0300 - rev 475297
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Backed out changeset 9a5f590f5f75 (bug 1480236) for android build bustages at nsIGlobalObject.cpp on a CLOSED TREE
e282b9c14e0022d87c4a27190ec0739aeb668171: Bug 1553498 - Inserts an empty page for about:certviewer and redirects to it when the user put that URL in the browser. r=johannh,smaug
Carolina <carolina.jimenez.g@gmail.com> - Thu, 23 May 2019 22:12:30 +0000 - rev 475296
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1553498 - Inserts an empty page for about:certviewer and redirects to it when the user put that URL in the browser. r=johannh,smaug Differential Revision: https://phabricator.services.mozilla.com/D32152
9a5f590f5f7574e186216d510692eab02e242ec8: Bug 1480236 - Implement queueMicrotask(), r=baku
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 23 May 2019 21:26:05 +0000 - rev 475295
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1480236 - Implement queueMicrotask(), r=baku Differential Revision: https://phabricator.services.mozilla.com/D32341
ebc58c182383d769cc609e6eb17dda547586d5ab: No bug: [release] Fix path to update-verify diff-summary log; r=bhearsum
Tom Prince <mozilla@hocat.ca> - Fri, 24 May 2019 00:22:50 +0000 - rev 475294
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
No bug: [release] Fix path to update-verify diff-summary log; r=bhearsum when update-verify migrated from using build-tools to in-tree, the path to `diff-summary.log` was not updated. Differential Revision: https://phabricator.services.mozilla.com/D32403
5ca3dedbdd6e7dab41342c1bc95ec2baab98e8e3: bug 1552310 - use the correct field to delete preloaded certificates that have been removed from the preload list r=jcj,KevinJacobs
Dana Keeler <dkeeler@mozilla.com> - Thu, 23 May 2019 23:57:39 +0000 - rev 475293
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
bug 1552310 - use the correct field to delete preloaded certificates that have been removed from the preload list r=jcj,KevinJacobs The initial implementation made some incorrect assumptions about the data that was in our data set and used the wrong field to identify the certificates to delete when they are removed from our preload list. Now that the data set has the expected field (the hash of the whole certificate), we can use it instead. Differential Revision: https://phabricator.services.mozilla.com/D32380
be1723043e976056d8cbb139912c9f2a325e190e: Bug 1543384 - Fix race in extension state setter r=kmag
Rob Wu <rob@robwu.nl> - Thu, 23 May 2019 20:39:13 +0000 - rev 475292
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1543384 - Fix race in extension state setter r=kmag As a side effect of this patch, the format of the "state" value of "async shutdown timeout" crash reports will change, as follows: "Run manifest: " has been replaced with "Run manifest, ": ``` - Startup: Run manifest: asyncEmitManifestEntry("background") + Startup: Run manifest, asyncEmitManifestEntry("background") ``` Multiple states are now separated by ", " instead of ",": ``` - Startup: Run manifest: manifest_name,manifest_version + Startup: Run manifest, manifest_name, manifest_version ``` "Run manifest" will always have a "Startup: " in front of it: ``` - Startup: Emit Startup,Run manifest + Startup: Emit Startup, Startup: Run manifest ``` And removed the `manifest_*` event dispatch since it has no listeners. Differential Revision: https://phabricator.services.mozilla.com/D26986
c87317c4190283cc4352331417babef3d3f9546d: Merge autoland to mozilla-central. a=merge
Ciure Andrei <aciure@mozilla.com> - Fri, 24 May 2019 06:52:59 +0300 - rev 475291
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Merge autoland to mozilla-central. a=merge
6acae89335b04d1d634fe5f6be2637f25e3e81e2: Backed out 23 changesets (bug 1550633) for causing bug 1548454 to permafail on a CLOSED TREE
Andreea Pavel <apavel@mozilla.com> - Fri, 24 May 2019 03:38:26 +0300 - rev 475290
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Backed out 23 changesets (bug 1550633) for causing bug 1548454 to permafail on a CLOSED TREE Backed out changeset ce4a146da49d (bug 1550633) Backed out changeset e1a33576d6ad (bug 1550633) Backed out changeset bbd8f62b9bff (bug 1550633) Backed out changeset 583d4e0945ad (bug 1550633) Backed out changeset 29487a59512d (bug 1550633) Backed out changeset 0f6ddd898e89 (bug 1550633) Backed out changeset fd1afdd721e3 (bug 1550633) Backed out changeset d4a6c1337f89 (bug 1550633) Backed out changeset 2d4773f2dc6c (bug 1550633) Backed out changeset e9dea69efffe (bug 1550633) Backed out changeset 4265dd65cec3 (bug 1550633) Backed out changeset 2aaaa42c409b (bug 1550633) Backed out changeset d85485f76233 (bug 1550633) Backed out changeset b6e8370b6efb (bug 1550633) Backed out changeset afaef937598b (bug 1550633) Backed out changeset 470d8fae0461 (bug 1550633) Backed out changeset 8024fcefe8b1 (bug 1550633) Backed out changeset 224eadc5ef27 (bug 1550633) Backed out changeset 26c3c521ce27 (bug 1550633) Backed out changeset def294ad0efb (bug 1550633) Backed out changeset b15cc6e689e7 (bug 1550633) Backed out changeset be178934cbbb (bug 1550633) Backed out changeset 9893ccf1f8ad (bug 1550633)
3b14313df83b02bcbc04a4b788d63f6e9a20becb: Backed out 2 changesets (bug 1552287) for failing contain-layout-suppress-baseline-002.html on a CLOSED TREE
Andreea Pavel <apavel@mozilla.com> - Fri, 24 May 2019 03:34:03 +0300 - rev 475289
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Backed out 2 changesets (bug 1552287) for failing contain-layout-suppress-baseline-002.html on a CLOSED TREE Backed out changeset 815c6657d164 (bug 1552287) Backed out changeset 888c32d2a32e (bug 1552287)
ee890b30dbe3126fa7c0c55b911de8dc65ef3867: Bug 1552875 - Set anonymous function name in field initializer. r=jorendorff
Ashley Hauck <khyperia@mozilla.com> - Thu, 23 May 2019 21:54:34 +0000 - rev 475288
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1552875 - Set anonymous function name in field initializer. r=jorendorff Differential Revision: https://phabricator.services.mozilla.com/D32070
7d73f17d3c58fcadca4d41674973f254ba5f6a6b: Bug 1553154 - enable animation preferences for test_animation_observers_async.html. r=birtles
Sebastian Hengst <archaeopteryx@coole-files.de> - Wed, 22 May 2019 23:51:19 +0000 - rev 475287
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1553154 - enable animation preferences for test_animation_observers_async.html. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D32035
815c6657d164d34b215a39d233cc60b2e6f546fa: Bug 1552287 part 2: [css-contain] Adjust various reflow & baseline methods so that layout-contained frames behave as if they have no baseline. r=TYLin
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 23 May 2019 21:41:35 +0000 - rev 475286
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1552287 part 2: [css-contain] Adjust various reflow & baseline methods so that layout-contained frames behave as if they have no baseline. r=TYLin We previously (in bug 1491235) adjusted some utility code to make layout-contained frames behave as if they have no baseline. But that's not sufficient. To make frames fully report lack-of-a-baseline, we now do the following for layout-contained frames, as of this patch: (a) We now leave the ReflowOutput outparam's BlockStartAscent member at its default value (which is what we do for frames without a baseline like e.g. nsCheckboxRadioFrame and nsHTMLCanvasFrame). And if the parent cares about the baseline, it'll then ask directly, using a baseline getter. (b) We now return 'false' in more implementations of bool-returning baseline-getter-methods (where 'false' indicates 'no baseline'). (c) We now return the margin-box-bottom edge, in the nscoord-returning 'GetLogicalBaseline()' getter method. (We typically do this by deferring to the inherited method, which ultimately comes from nsFrame's implementation). It's appropriate to use the margin-box-bottom edge when there's no baseline, per the definition of 'vertical-align: baseline', here: https://drafts.csswg.org/css2/visudet.html#propdef-vertical-align Depends on D32182 Differential Revision: https://phabricator.services.mozilla.com/D32183
888c32d2a32e849046cfe945593fe684c79e9ffa: Bug 1552287 part 1: [css-contain] Fix some CSS layout-containment web-platform-tests to make their assumptions more valid. r=TYLin
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 23 May 2019 21:41:24 +0000 - rev 475285
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1552287 part 1: [css-contain] Fix some CSS layout-containment web-platform-tests to make their assumptions more valid. r=TYLin In particular: - In contain-layout-baseline-005.html and its reference case, we need to explicitly specify 'vertical-align:baseline' to test baseline-alignment, because some of its tested form controls have other UA-stylesheet-provided default values of 'vertical-align'. (e.g. <select multiple> defaults to 'vertical-align:text-bottom") - Also: in that same test, we need to reduce the width of the an <input> textfield -- otherwise, it and the other elements on its line may not fit and may linewrap, which prevents us from effectively testing baseline-alignment on the linewrapped element. - In contain-layout-button-001.html, the expectation was not correct. Before this patch, the test expects that a layout-contained button will have the same baseline as an empty button, and that's an invalid expectation. An empty button uses a point inside of its content-box as its baseline, whereas a layout-contained element *has no baseline*, which means that it does 'vertical-align:baseline' alignment by aligning its own margin-bottom edge with the parent's baseline, per https://drafts.csswg.org/css2/visudet.html#propdef-vertical-align So, I'm amending the test to have this expectation and updating its meta tags to reference the updated expectation and with a reference to that spec text. Firefox fails the amended contain-layout-button-001.html test, so this patch adds a .ini file to reflect that failure. The next patch in this series will fix our implementation to make us pass the test, and will remove the .ini file. Chrome also fails the amended contain-layout-button-001.html tests, and I filed https://bugs.chromium.org/p/chromium/issues/detail?id=965740 on them with an explanation. Differential Revision: https://phabricator.services.mozilla.com/D32182
7a039c35fc6f96e13d1a24c54139c942902ee5a4: Bug 1553680 - Read the Cookie response headers from a `white-space: pre' element so that any white-space in them would be preserved in the expectation value; r=baku
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 23 May 2019 11:28:53 +0000 - rev 475284
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1553680 - Read the Cookie response headers from a `white-space: pre' element so that any white-space in them would be preserved in the expectation value; r=baku Differential Revision: https://phabricator.services.mozilla.com/D32239
e2fc1ab0dcf5462567fe24c0cf1d360c038c8312: Bug 1517475 - Execute recipe runner on Remote Settings "sync" event r=mythmon
Mathieu Leplatre <mathieu@mozilla.com> - Thu, 23 May 2019 21:11:06 +0000 - rev 475283
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1517475 - Execute recipe runner on Remote Settings "sync" event r=mythmon Differential Revision: https://phabricator.services.mozilla.com/D30513
cd5d8525541fc8a324498043cc250a87632dc72a: Bug 1471698 - Remove our binutils-corruption-avoiding workaround for mingw-clang r=froydnj
Tom Ritter <tom@mozilla.com> - Wed, 22 May 2019 13:40:36 +0000 - rev 475282
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1471698 - Remove our binutils-corruption-avoiding workaround for mingw-clang r=froydnj Depends on D31347 Differential Revision: https://phabricator.services.mozilla.com/D31349
ca67f4681a4a6674f3ae2e1bed1bc2cfbdea3749: Backed out 3 changesets (bug 1551385) for breaking reftests at vtt_overlapping_time.html on a CLOSED TREE
Andreea Pavel <apavel@mozilla.com> - Fri, 24 May 2019 00:23:19 +0300 - rev 475281
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Backed out 3 changesets (bug 1551385) for breaking reftests at vtt_overlapping_time.html on a CLOSED TREE Backed out changeset 4268e661e741 (bug 1551385) Backed out changeset fb20dcf3c072 (bug 1551385) Backed out changeset 883151b42d88 (bug 1551385)
ab9d5eeaa90e155f484ae3457aac82fd4d61f8d9: Bug 1370630 - Untrusted submit event shouldn't trigger form submission; r=smaug
Stone Shih <sshih@mozilla.com> - Thu, 23 May 2019 20:30:20 +0000 - rev 475280
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1370630 - Untrusted submit event shouldn't trigger form submission; r=smaug Differential Revision: https://phabricator.services.mozilla.com/D28070
a9e860d35d5b7074e68e2cd2d50e53cdb69e7523: Bug 1536672 - Implement WebGL OVR_multiview2 behind draft flag. r=lsalzman,qdot
Jeff Gilbert <jgilbert@mozilla.com> - Thu, 23 May 2019 20:48:21 +0000 - rev 475279
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1536672 - Implement WebGL OVR_multiview2 behind draft flag. r=lsalzman,qdot Also disable clang-format for gfx/gl/GLConsts.h. Differential Revision: https://phabricator.services.mozilla.com/D28168
2196d50bfb2d53fd40ed2705d496da3c6a4b10ba: Bug 1552563 - remove mochitest-media from whitelist not requiring compiz CLOSED TREE
Edwin Gao <egao@mozilla.com> - Thu, 23 May 2019 23:53:21 +0300 - rev 475278
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1552563 - remove mochitest-media from whitelist not requiring compiz CLOSED TREE Summary: Changes: - remove `mochitest-media` from the whiteslist - compiz is required. Test Plan: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=pending%2Crunning%2Csuperseded%2Cusercancel%2Cretry%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&classifiedState=unclassified&group_state=expanded&revision=f16b0ce4af9e575ef2ec877b405698c0b0c62f92 Reviewers: jmaher, gbrown Bug #: 1552563 Differential Revision: https://phabricator.services.mozilla.com/D32383
aeff5661bcaba04d129d7f70fa51cf9b4529bcf1: Backed out changeset 52e365586577 (bug 1552563) for failing test_getUserMedia_basicScreenshare.html on a CLOSED TREE
Andreea Pavel <apavel@mozilla.com> - Thu, 23 May 2019 23:52:19 +0300 - rev 475277
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Backed out changeset 52e365586577 (bug 1552563) for failing test_getUserMedia_basicScreenshare.html on a CLOSED TREE
d697540809add645ca5ada471c0f94f4773734b0: Backed out changeset 9b60f95e81da (bug 1547795) for breaking a11y at test_media.html on a CLOSED TREE
Andreea Pavel <apavel@mozilla.com> - Thu, 23 May 2019 23:47:50 +0300 - rev 475276
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Backed out changeset 9b60f95e81da (bug 1547795) for breaking a11y at test_media.html on a CLOSED TREE
53f2ffc77a62f878d0bd919dd1437debcd1f4371: Bug 1551339 - Update VIXL to recent Utils and Globals files. r=nbp
Sean Stangl <sean.stangl@gmail.com> - Thu, 23 May 2019 20:26:52 +0000 - rev 475275
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1551339 - Update VIXL to recent Utils and Globals files. r=nbp This is preliminary work to allowing encoding of JSCVTFP, the instruction that exists on new AArch64 devices that greatly speeds up websites that use floating-point math. Differential Revision: https://phabricator.services.mozilla.com/D30997
af36f91523276c0e96596810dc480e1a5ae80921: Bug 1551648 - Record peak resident memory usage in telemetry. r=erahm
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 23 May 2019 20:06:33 +0000 - rev 475274
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1551648 - Record peak resident memory usage in telemetry. r=erahm Differential Revision: https://phabricator.services.mozilla.com/D32184
61ae24d322cb05bec32cf7620778f15a2e6908e5: Bug 1552549 - Update rand dependency to 0.6 r=kats,froydnj,nika,jkt,jcj
Dzmitry Malyshau <dmalyshau@mozilla.com> - Thu, 23 May 2019 19:54:25 +0000 - rev 475273
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1552549 - Update rand dependency to 0.6 r=kats,froydnj,nika,jkt,jcj Update rand version in u2fhid and xpcom Differential Revision: https://phabricator.services.mozilla.com/D31669
ce4a146da49d57afadd9205edd251c32d5d0bd9a: Bug 1550633 - part17 : modify test 'browser_cache.js'. r=timhuang
alwu <alwu@mozilla.com> - Thu, 23 May 2019 17:58:40 +0000 - rev 475272
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part17 : modify test 'browser_cache.js'. r=timhuang As now we won't automatically load disabled text track, we have to mark track as `default` in order to trigger loading. Differential Revision: https://phabricator.services.mozilla.com/D32359
e1a33576d6ad38789b39e381c2ebaac2c2a81b93: Bug 1550633 - part16 : turn off the pref 'media.block-autoplay-until-in-foreground' in wpt. r=jgraham
alwu <alwu@mozilla.com> - Thu, 23 May 2019 17:58:40 +0000 - rev 475271
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part16 : turn off the pref 'media.block-autoplay-until-in-foreground' in wpt. r=jgraham Sometime wpt runs test even before the document becomes visible, which would delay `video.play()` and cause `play()` running in wrong order. Differential Revision: https://phabricator.services.mozilla.com/D32079
bbd8f62b9bff25922b19925a83cf287be4b2dc1d: Bug 1550633 - part15 : return error when we failed to create channel. r=jya
alwu <alwu@mozilla.com> - Thu, 23 May 2019 09:03:08 +0000 - rev 475270
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part15 : return error when we failed to create channel. r=jya The channel might not be created correctly if we pass invaild url (eg. "invalid://url"), we should handle this error. Differential Revision: https://phabricator.services.mozilla.com/D32038
583d4e0945ad964ef5a9cc1a8ccec8faa248e32b: Bug 1550633 - part14 : add a test for 'honor user preferences for automatic text track selection'. r=bzbarsky
alwu <alwu@mozilla.com> - Thu, 23 May 2019 09:03:10 +0000 - rev 475269
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part14 : add a test for 'honor user preferences for automatic text track selection'. r=bzbarsky This test is used to ensure that we queue 'honor user preferences for automatic text track selection' as a marco task, not a mirco task. In this test, we would trigger a media event before queuing a text track selection task, and check the text track's mode to know whether the text track selection runs after the task for media event. Differential Revision: https://phabricator.services.mozilla.com/D31921
29487a59512dd951a532f1be441d29c6c618c1d8: Bug 1550633 - part13.6 - refactor tests. r=jya
alwu <alwu@mozilla.com> - Thu, 23 May 2019 09:03:12 +0000 - rev 475268
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part13.6 - refactor tests. r=jya Refactor those tests' structure in order to make them more readable, and add the comment to show what the test purpose is for each test. Differential Revision: https://phabricator.services.mozilla.com/D31914
0f6ddd898e891aa423510b0c66c702c09d77c728: Bug 1550633 - part13.5 - wait text track element's 'load' event. r=jya
alwu <alwu@mozilla.com> - Thu, 23 May 2019 09:03:14 +0000 - rev 475267
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part13.5 - wait text track element's 'load' event. r=jya This patch do two things in order to trigger loading for track element and wait for correct event to check track's and cues' status after loading finished. (1) listen track element's load event There are some tests listening video's loadedmetadata, but it's wrong. The loading process of media element and track element are completely non-related. If you would like to check track element's status, you should wait for track element's load event. (2) enable track explictly If the text track which has default attribute is added to the media element before the media element starts running automatic track selection [1], then it would be enable by the media element. Otherwise, you have to enable track explicitly by changing its track mode. [1] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:text-track-7 Differential Revision: https://phabricator.services.mozilla.com/D31913
fd1afdd721e3261a2f716ea117763ba52a231d05: Bug 1550633 - part13.4 : don't use anonymous function. r=jya
alwu <alwu@mozilla.com> - Thu, 23 May 2019 09:03:16 +0000 - rev 475266
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part13.4 : don't use anonymous function. r=jya Use named function for callback to reduce the indentation. Differential Revision: https://phabricator.services.mozilla.com/D31912
d4a6c1337f891a761cd7ef03668d91743a50f065: Bug 1550633 - part13.3 - create elements in HTML, not in JS. r=jya
alwu <alwu@mozilla.com> - Thu, 23 May 2019 09:03:18 +0000 - rev 475265
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part13.3 - create elements in HTML, not in JS. r=jya Create test elements in HTML beforehand, which can remove unnecessary JS code and make test cleaner. Differential Revision: https://phabricator.services.mozilla.com/D31911
2d4773f2dc6c83c0399e6add6a592e1782fffc3b: Bug 1550633 - part13.2 - no need to set pref "media.webvtt.regions.enabled". r=jya
alwu <alwu@mozilla.com> - Thu, 23 May 2019 09:03:21 +0000 - rev 475264
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part13.2 - no need to set pref "media.webvtt.regions.enabled". r=jya These tests didn't use region at all, so we have no need to set the pref. Differential Revision: https://phabricator.services.mozilla.com/D31910
e9dea69efffeea4795c1640d225580008fdf060f: Bug 1550633 - part13.1 - remove unnecessary elements. r=jya
alwu <alwu@mozilla.com> - Thu, 23 May 2019 09:03:23 +0000 - rev 475263
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part13.1 - remove unnecessary elements. r=jya These elemenets are useless and we can run tests without them. Differential Revision: https://phabricator.services.mozilla.com/D31909
4265dd65cec3cc256ead96f0b9054c0756f13252: Bug 1550633 - part12 : enable wpts. r=jya
alwu <alwu@mozilla.com> - Thu, 23 May 2019 09:03:25 +0000 - rev 475262
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part12 : enable wpts. r=jya Differential Revision: https://phabricator.services.mozilla.com/D31561
2aaaa42c409b7b56b3660326c4c7ffbdb2215635: Bug 1550633 - part11.1 - modify 'track-element-src-change-error.html'. r=jya
alwu <alwu@mozilla.com> - Thu, 23 May 2019 09:03:29 +0000 - rev 475261
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part11.1 - modify 'track-element-src-change-error.html'. r=jya According to spec [1], if the track URL changes so that it is no longer equal to URL while fetching is ongoing, we need to change the text track readiness state to`failed to load` and dispatch `error`. So we now only fire `error` if `src` is removed during loading, but if the track element has finished loading before removing `src`, we won't dispatch `error` for it. [1] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:text-track-failed-to-load-3 Differential Revision: https://phabricator.services.mozilla.com/D31915
d85485f76233138488e76d8434be46d954547ea3: Bug 1550633 - part11 : modify wpt 'track-element-src-change.html' and 'track-element-src-change-error.html'. r=jya
alwu <alwu@mozilla.com> - Thu, 23 May 2019 09:03:27 +0000 - rev 475260
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part11 : modify wpt 'track-element-src-change.html' and 'track-element-src-change-error.html'. r=jya According to the spec [1], the text track list of cues is initially empty. It is dynamically modified when the referenced file is parsed. Therefore, after reset the track element's url, the number of cues of the text track should be zero, until we start parsing resource and add cue into the list. [1] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:text-track-list-of-cues https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:text-track-list-of-cues-3 Differential Revision: https://phabricator.services.mozilla.com/D31560
b6e8370b6efb20689269602b5361406dfce1d574: Bug 1550633 - part10 : automatically capture and print the address of track element in debug log and add new log. r=jya
alwu <alwu@mozilla.com> - Thu, 23 May 2019 09:03:31 +0000 - rev 475259
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part10 : automatically capture and print the address of track element in debug log and add new log. r=jya To reduce non-neccesary input, we can always capture `this` and print the address in the log, and use same log level for all of them. Differential Revision: https://phabricator.services.mozilla.com/D31559
afaef937598b8c46c009a0523c0fbe4ba61c6c25: Bug 1550633 - part9 : capture 'this' in lambda. r=jya
alwu <alwu@mozilla.com> - Thu, 23 May 2019 09:03:33 +0000 - rev 475258
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part9 : capture 'this' in lambda. r=jya There are too many `self` used in the lambda, we can just capture `this` to remove redudant `self`. Differential Revision: https://phabricator.services.mozilla.com/D31558
470d8fae0461968d745100f64c23aa296f0d9a05: Bug 1550633 - part8 : no need to reload if the new url is the same. r=jya
alwu <alwu@mozilla.com> - Thu, 23 May 2019 09:03:35 +0000 - rev 475257
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part8 : no need to reload if the new url is the same. r=jya Accoding to spec [1], after loading finished, the start the track processing model would stop at step12 and wait until the track URL changes to the URL which is not equal to the URL we have loaded before. That means, if we change track URL to the same URL we loaded before, we won't have to reload the resource. [1] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:track-url-5 Differential Revision: https://phabricator.services.mozilla.com/D31557
8024fcefe8b13d215211cbfe09f979998f3c5217: Bug 1550633 - part7 : change ready state to 'FAILED_TO_LOAD' and dispatch 'error' event when we have no 'src' or have an empty url. r=jya
alwu <alwu@mozilla.com> - Thu, 23 May 2019 09:03:37 +0000 - rev 475256
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part7 : change ready state to 'FAILED_TO_LOAD' and dispatch 'error' event when we have no 'src' or have an empty url. r=jya `Failed to load` [1] indicates that the text track was enabled, but when the user agent attempted to obtain it, this failed in some way. According to the spec [2], if fetching fails for any reason (network error, the server returns an error code, CORS fails, etc), or if URL is the empty string, then queue a task to first change the text track readiness state to `failed to load` and then fire an event named `error` at the track element. And spec [3] also mention that, if the track URL changes so that it is no longer equal to URL while fetching is ongoing, we also need to change the text track readiness state to`failed to load` and dispatch `error`. [1] https://html.spec.whatwg.org/multipage/media.html#text-track-readiness-state [2] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:text-track-failed-to-load [3] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:text-track-failed-to-load-3 Differential Revision: https://phabricator.services.mozilla.com/D31556
224eadc5ef27bdcd41375742314c8360464173b7: Bug 1550633 - part6 : clear track's cues list whenever track element's src attribute set, changed or removed. r=jya,baku
alwu <alwu@mozilla.com> - Thu, 23 May 2019 09:03:40 +0000 - rev 475255
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part6 : clear track's cues list whenever track element's src attribute set, changed or removed. r=jya,baku According to the spec [1], we should empty track's cue list whenever a track element has its src attribute set, changed, or removed. [1] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:attr-track-src Differential Revision: https://phabricator.services.mozilla.com/D31552
26c3c521ce27aa67922a0a0ed1f4b6d3272e902a: Bug 1550633 - part5 : modify and enable test 'track-mode-not-changed-by-new-track.html'. r=jya
alwu <alwu@mozilla.com> - Thu, 23 May 2019 09:03:42 +0000 - rev 475254
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part5 : modify and enable test 'track-mode-not-changed-by-new-track.html'. r=jya In `honor user preferences for automatic text track selection` [1], we would set `did-perform-automatic-track-selection` flag to true [2], and then we won't execute automatic track selection anymore [3]. It means that we would only do automatic track selection one time, and then user has to enable newly added track explicitly by changing its mode. In this test, we have done the automatic track selection when we added the `metadata` track to media element's text track list, so we won't run it again, even if the newly added track has `default` attribute. Therefore, we have to enable the `caption` track explicitly. In addition, add the missing `event` parameter for the function `trackAdded()`. [1] https://html.spec.whatwg.org/multipage/media.html#honor-user-preferences-for-automatic-text-track-selection [2] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:did-perform-automatic-track-selection-2 [3] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:did-perform-automatic-track-selection Differential Revision: https://phabricator.services.mozilla.com/D31375
def294ad0efb614102f890e85b5b8f9c1e0cf2d7: Bug 1550633 - part4 : no need to run text track selection in stable state. r=bzbarsky
alwu <alwu@mozilla.com> - Thu, 23 May 2019 09:04:58 +0000 - rev 475253
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part4 : no need to run text track selection in stable state. r=bzbarsky According to spec [1], it doesn't mention that we have to run text track selection in stable state, it just said "the user agent must queue a task to run the following steps". [1] https://html.spec.whatwg.org/multipage/media.html#honor-user-preferences-for-automatic-text-track-selection Differential Revision: https://phabricator.services.mozilla.com/D31374
b15cc6e689e79f87439d0163e7f7bb1964ad23bc: Bug 1550633 - part3 : add debug log to show track's kind. r=jya
alwu <alwu@mozilla.com> - Thu, 23 May 2019 09:05:00 +0000 - rev 475252
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part3 : add debug log to show track's kind. r=jya Showing track's kind in debug log is helpful. Differential Revision: https://phabricator.services.mozilla.com/D31373
be178934cbbba786670417e9a1090713cc4ebc05: Bug 1550633 - part2 : maybe start loading resource when the track's mode changes. r=jya
alwu <alwu@mozilla.com> - Thu, 23 May 2019 09:05:02 +0000 - rev 475251
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part2 : maybe start loading resource when the track's mode changes. r=jya According to the spec [1], the user agent must start the track processing model when text track has its text track mode changed. [1] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:start-the-track-processing-model Differential Revision: https://phabricator.services.mozilla.com/D31372
9893ccf1f8ad07ae7a1c8a69b089ef5b3f99d6ed: Bug 1550633 - part1 : HTMLTrackElement should not load resource when its text track is disable. r=jya
alwu <alwu@mozilla.com> - Thu, 23 May 2019 09:05:04 +0000 - rev 475250
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part1 : HTMLTrackElement should not load resource when its text track is disable. r=jya According to the spec step2 [1], we should not load resource for the track element which text track is disabled. [1] https://html.spec.whatwg.org/multipage/media.html#start-the-track-processing-model Differential Revision: https://phabricator.services.mozilla.com/D31371
9ab833800af2dc539e24bbe64189867726585ecf: Bug 1549776 - Add taskcluster jobs for running wrench on Android. r=jrmuizel
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 23 May 2019 19:31:06 +0000 - rev 475249
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1549776 - Add taskcluster jobs for running wrench on Android. r=jrmuizel Also docs for running the same thing locally. Differential Revision: https://phabricator.services.mozilla.com/D32015
83eafb86df0f1439dfb262761c73c0316ebfdaec: Bug 1549776 - Add a script to run wrench reftests on an Android emulator. r=gbrown
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 23 May 2019 17:02:49 +0000 - rev 475248
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1549776 - Add a script to run wrench reftests on an Android emulator. r=gbrown This adds an android_emulator_wrench.py script that uses mozharness to control the Android emulator, and run the wrench reftests. It has an associated wrench.py config script which is similar to existing android config scripts. The android_emulator_wrench script is structured a little differently from other android mozharness scripts, mostly for two reasons: 1) I tried hard to make it locally runnable by developers, using ./mach python. This allows develpers to more easily reproduce the setup that runs in automation, and does so without duplicating a lot of code. 2) I also tried to make the script use fewer of what I consider to be "opaque" mozharness features, like the actions list which can run hard-to-find preflight and postflight functions. Instead of treating mozharness like a framework and filling in some functions for it to invoke as part of it's grand plan, I treat it more like a library and specifically the functions I want in the order that I want, which makes it easier for novice developers to debug problems. As part of writing this script I extracted a few helper functions and made some minor changes to existing android/adb mozharness machinery, but these are all simple refactorings and should introduce no functional change. Differential Revision: https://phabricator.services.mozilla.com/D32014
f1bf5f2b37a8aa5b318955bfd4ce656f6e30198a: Bug 1549776 - Disable more reftests due to failures on Android. r=gw
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 23 May 2019 15:30:22 +0000 - rev 475247
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1549776 - Disable more reftests due to failures on Android. r=gw Differential Revision: https://phabricator.services.mozilla.com/D32013
91aef90259cc471c1d05de637d312454ed90aba4: Bug 1549776 - Disable some reftests on debug Android. r=gw
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 23 May 2019 15:30:18 +0000 - rev 475246
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1549776 - Disable some reftests on debug Android. r=gw These tests cause panics in debug mode because of the extra GL error checking. Tests that are disabled are annotated with the failing GL call. Differential Revision: https://phabricator.services.mozilla.com/D32012
a08b3b243d9dfe3a9bd51130de4ec941cee421ae: Bug 1549776 - Disable some reftests on Android. r=gw
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 23 May 2019 15:30:08 +0000 - rev 475245
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1549776 - Disable some reftests on Android. r=gw Differential Revision: https://phabricator.services.mozilla.com/D32011
8f4f4cc896abda8635f1f8259c35c408c1c6b8ab: Bug 1549776 - Ensure debug wrench aborts on panic. r=gw
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 23 May 2019 15:30:04 +0000 - rev 475244
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1549776 - Ensure debug wrench aborts on panic. r=gw This makes it so that when running reftests, wrench actually terminates after a panic rather than just hanging. Termination is detectable and so we can clean up properly instead of waiting until some other layer hits a timeout. Differential Revision: https://phabricator.services.mozilla.com/D32010
743a0b35f1cbaef8fbebc8244121250e51d8bdea: Bug 1549776 - Fix path to artifact. r=gw
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 23 May 2019 15:29:55 +0000 - rev 475243
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1549776 - Fix path to artifact. r=gw Typo when I first landed this, but nothing relied on it so it didn't matter. Differential Revision: https://phabricator.services.mozilla.com/D32009
d63dc26dba151d1a5668df7a29561136c7e8da09: Bug 1553845 - turn on all talos/raptor jobs for osx 10.14. r=gbrown
Joel Maher <jmaher@mozilla.com> - Thu, 23 May 2019 15:23:47 +0000 - rev 475242
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1553845 - turn on all talos/raptor jobs for osx 10.14. r=gbrown turn on all talos/raptor jobs for osx 10.14. Differential Revision: https://phabricator.services.mozilla.com/D32334
9b60f95e81dae91129af4eb80863010cedf4ca57: Bug 1547795 - Hide Picture-in-Picture toggle on videos where its probably more annoying than not. r=JSON_voorhees
Mike Conley <mconley@mozilla.com> - Thu, 23 May 2019 18:49:10 +0000 - rev 475241
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1547795 - Hide Picture-in-Picture toggle on videos where its probably more annoying than not. r=JSON_voorhees This makes our video controls bindings check on loadedmetadata events whether or not to display the toggle. Differential Revision: https://phabricator.services.mozilla.com/D32365
f3534b56753ed9d04b018bd6b0549923775e5661: Bug 1492305 - Fix LibSecret unlocking & NSS return values r=keeler,MattN
Kevin Jacobs <kjacobs@mozilla.com> - Wed, 22 May 2019 18:25:59 +0000 - rev 475240
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1492305 - Fix LibSecret unlocking & NSS return values r=keeler,MattN This fixes issues with the NSS and LibSecret keystore not correctly rejecting unlocking of the key store. Updated for dynamic loading of LibSecret and a bug workaround added elsewhere (updated green try below) Depends on D9969. Differential Revision: https://phabricator.services.mozilla.com/D7713
aaee3b838d53cb52e978b811ea9e744ba79c0e99: Bug 1552422 - correct Balrog scope for comm-esrXX branches. r=tomprince
Rob Lemley <rob@thunderbird.net> - Tue, 21 May 2019 21:16:57 +0000 - rev 475239
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1552422 - correct Balrog scope for comm-esrXX branches. r=tomprince Copying fix from THUNDERBIRD_60_VERBRANCH on mozilla-esr60. https://hg.mozilla.org/releases/mozilla-esr60/rev/eae0435135ad6713bf9d776f71b7d7cc3e01756d Differential Revision: https://phabricator.services.mozilla.com/D31584
7eaaa8f90abd04fd6bedfd8e0dbd8fcba5027c0a: Bug 1546432 - Move DocumentL10n to use mozILocalization. r=smaug
Zibi Braniecki <zbraniecki@mozilla.com> - Tue, 21 May 2019 19:22:36 +0000 - rev 475238
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1546432 - Move DocumentL10n to use mozILocalization. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D31554
53386b4a7e83865eb8a1206c1c096f978a9a4b31: Bug 1546432 - Add basic Mutations tests. r=smaug
Zibi Braniecki <zbraniecki@mozilla.com> - Tue, 21 May 2019 19:22:29 +0000 - rev 475237
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1546432 - Add basic Mutations tests. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D31553
8444c891fa21bf91717021fc2a6c09ca1fa8ef06: Bug 1546432 - Add roots management to Mutations. r=smaug
Zibi Braniecki <zbraniecki@mozilla.com> - Thu, 23 May 2019 19:01:35 +0000 - rev 475236
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1546432 - Add roots management to Mutations. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D31337
03ee100c9534af5152231d40b83a6154f9585242: Bug 1546432 - Migrate DocumentL10n to use dom::l10n::Mutations. r=smaug
Zibi Braniecki <zbraniecki@mozilla.com> - Tue, 21 May 2019 19:46:32 +0000 - rev 475235
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1546432 - Migrate DocumentL10n to use dom::l10n::Mutations. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D28981
b2413635c1484c3c1ea426020b074161732f8ac6: Bug 1546432 - Introduce mozilla::dom::l10n::Mutations. r=smaug
Zibi Braniecki <zbraniecki@mozilla.com> - Tue, 21 May 2019 19:21:54 +0000 - rev 475234
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1546432 - Introduce mozilla::dom::l10n::Mutations. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D28979
1f4aa15478f1464a55ecb07068e4498ccf384225: Bug 1368266 - Set overridePc to firstPc instead of lastPc when unwinding frames. r=jandem
Kannan Vijayan <kvijayan@mozilla.com> - Thu, 23 May 2019 11:18:50 +0000 - rev 475233
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1368266 - Set overridePc to firstPc instead of lastPc when unwinding frames. r=jandem Differential Revision: https://phabricator.services.mozilla.com/D32186
136b9bb7ebee5455f5dcd3b564d790606675d819: Bug 1552528 - Enable & disable the structured spewer when the gecko profiler starts and stops r=mgaudet
Denis Palmeiro <dpalmeiro@mozilla.com> - Thu, 23 May 2019 18:41:29 +0000 - rev 475232
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1552528 - Enable & disable the structured spewer when the gecko profiler starts and stops r=mgaudet The structured spewer does not exit gracefully when the browser is closed. This leads to incomplete JSON since we never end up emitting the closing ']' on destruction. Another approach that lets us do this gracefully is to have the structured spewer start and stop alongside the gecko profiler. This also lets us focus spewing on the specific area of interest such as a page load, or some janky behaviour on a website. Differential Revision: https://phabricator.services.mozilla.com/D32135
57626db4615868cfa10834a2bf6529457c334684: Bug 1552687 - guard access to gfxDWriteFontFileStream with mutex. r=jfkthame
Lee Salzman <lsalzman@mozilla.com> - Thu, 23 May 2019 18:42:03 +0000 - rev 475231
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1552687 - guard access to gfxDWriteFontFileStream with mutex. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D32214
4268e661e741a5ad122880f818bbcabc9135cb7d: Bug 1551385 - part3 : add test 'test_webvtt_overlapping_time.html' and 'vtt_overlapping_time.html'. r=heycam
Alastor Wu <alwu@mozilla.com> - Wed, 22 May 2019 20:29:08 +0000 - rev 475230
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1551385 - part3 : add test 'test_webvtt_overlapping_time.html' and 'vtt_overlapping_time.html'. r=heycam Adding tests to ensure that when cues with overlapping times, the one with earlier end timestamp should disappear when the media time reaches its end time. In this test, we have two cues with overlapping time, when the video starts, both cues should be displayed. When the time passes 1 seconds, the first cue should disappear and the second cues should be still displayed. Differential Revision: https://phabricator.services.mozilla.com/D31172
fb20dcf3c07280de6c2b4d8b9a1edcdeec9d4d29: Bug 1551385 - part2 : recompute display state when display cues amount is different from the one we rendered last time. r=heycam
Alastor Wu <alwu@mozilla.com> - Thu, 23 May 2019 18:13:13 +0000 - rev 475229
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1551385 - part2 : recompute display state when display cues amount is different from the one we rendered last time. r=heycam If the amount of cues which are going to be displayed is different from the one we displayed last time, we have to compute cues' display state again because cue's position might be affected by other cues. Differential Revision: https://phabricator.services.mozilla.com/D31170
883151b42d88925215fb1212af70e6e425cd0f23: Bug 1551385 - part1 : let 'processCue()' handle cleaning cues div. r=heycam
Alastor Wu <alwu@mozilla.com> - Wed, 22 May 2019 05:39:40 +0000 - rev 475228
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1551385 - part1 : let 'processCue()' handle cleaning cues div. r=heycam We can actually let `processCue()` to handle rendering cues or cleaning displayed cues, no need to use another way to clear the cue. The advantages is to make the code cleaner and easier to read, now we just need to know JS side would handle all rendering stuffs for us. We don't need to have different behavior when there is no showing cue. The way we clear displayed cues are intuitive, we would remove all child nodes under the overlay, which are used to display cues. Differential Revision: https://phabricator.services.mozilla.com/D31171
916a05c96ee29fd1b4dfa9e33c92d4e5a758dcc7: Bug 1550692 Process subsection headers in about:telemetry should be clear that they're about processes r=chutten,flod
monikamaheshwari <monikamaheshwari1996@gmail.com> - Thu, 23 May 2019 18:00:50 +0000 - rev 475227
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550692 Process subsection headers in about:telemetry should be clear that they're about processes r=chutten,flod Differential Revision: https://phabricator.services.mozilla.com/D31718
9473fc5214f68bfded83c5f8dd8d582051037008: Bug 1550495 - Set directory root does not work for debugger.html. r=loganfsmyth
Jason Laster <jlaster@mozilla.com> - Thu, 23 May 2019 18:00:47 +0000 - rev 475226
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550495 - Set directory root does not work for debugger.html. r=loganfsmyth Differential Revision: https://phabricator.services.mozilla.com/D31313
5d620aaff95a8ca5a6be0e269ccea4b6d72b1c8f: Bug 1552516 - Fix race condition in a devtools test. r=jdescottes,jlast
Julian Descottes <jdescottes@mozilla.com> - Thu, 23 May 2019 16:45:08 +0000 - rev 475225
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1552516 - Fix race condition in a devtools test. r=jdescottes,jlast Differential Revision: https://phabricator.services.mozilla.com/D31800
06fd76912201276f6212687eba91ff75facefdf9: Bug 1551078 - Add rustfmt as part of mozlint r=ahal
Sylvestre Ledru <sledru@mozilla.com> - Thu, 23 May 2019 17:26:05 +0000 - rev 475224
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1551078 - Add rustfmt as part of mozlint r=ahal Two use cases: 1) Show the errors $ ./mach lint -l rustfmt js/rust/src/rust.rs Also works on a directory: $ ./mach lint -l rustfmt js/rust/src/ 2) Update the code $ ./mach lint -l rustfmt js/rust/src/rust.rs --fix To install it: $ rustup component add rustfmt $ export PATH=$PATH:~/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/ Differential Revision: https://phabricator.services.mozilla.com/D30813
52e365586577f26dcfb773db5441e79150a14f61: Bug 1552563 - do not run compiz on linux tests unless needed by tests r=jmaher
Edwin Gao <egao@mozilla.com> - Tue, 21 May 2019 16:33:43 +0000 - rev 475223
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1552563 - do not run compiz on linux tests unless needed by tests r=jmaher Changes: - removed UBUNTU_1604 detection mechanism at top of `test-linux.sh` file, since all tests are run on Ubuntu 16.04 anyway - added new environment value `NEED_COMPIZ`, defaulting to `true`, which will inform the test if compiz is required for tests - from `test-linux.sh` remove unconditional invocation of compiz, and replace it with detection of `NEED_COMPIZ` environment variable Differential Revision: https://phabricator.services.mozilla.com/D31724
d551d37b9ad0dd1c8ad2e87c74344f623fc4b694: Merge autoland to mozilla-central. a=merge
Ciure Andrei <aciure@mozilla.com> - Fri, 24 May 2019 00:51:34 +0300 - rev 475222
Push 36057 by aciure@mozilla.com at Thu, 23 May 2019 21:52:03 +0000
Merge autoland to mozilla-central. a=merge
ae1b2b5ee05c54ecdb80876134eda2f4973640b6: Bug 1553224 - Run test-verify on Android x86_64; r=jmaher
Geoff Brown <gbrown@mozilla.com> - Thu, 23 May 2019 16:57:17 +0000 - rev 475221
Push 36057 by aciure@mozilla.com at Thu, 23 May 2019 21:52:03 +0000
Bug 1553224 - Run test-verify on Android x86_64; r=jmaher I had been waiting for more complete x86_64 coverage, but realized that's not strictly necessary: TV works okay as-is on Android x86_64. Differential Revision: https://phabricator.services.mozilla.com/D32347
afb705ca89e170f53f0a64e1339e9b5e6d5f84a8: Bug 1553548: [css-contain] Make table-wrapper-box inherit CSS "contain" from table box. r=TYLin
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 23 May 2019 16:52:28 +0000 - rev 475220
Push 36057 by aciure@mozilla.com at Thu, 23 May 2019 21:52:03 +0000
Bug 1553548: [css-contain] Make table-wrapper-box inherit CSS "contain" from table box. r=TYLin Differential Revision: https://phabricator.services.mozilla.com/D32179
e95e6a0e38542135a67bad172386f5d3652a9410: Bug 1553810 - remove RSSRCS support from the build system; r=nalexander
Nathan Froyd <froydnj@mozilla.com> - Thu, 23 May 2019 15:20:26 +0000 - rev 475219
Push 36057 by aciure@mozilla.com at Thu, 23 May 2019 21:52:03 +0000
Bug 1553810 - remove RSSRCS support from the build system; r=nalexander We used to support specifying single Rust files for compilation, emphasis on "used to". Differential Revision: https://phabricator.services.mozilla.com/D32314
687e01c1125ba892f11c85fdb4690a2768b50445: Bug 1552897 - Ride along: format with black r=ahal
Sylvestre Ledru <sledru@mozilla.com> - Thu, 23 May 2019 16:44:04 +0000 - rev 475218
Push 36057 by aciure@mozilla.com at Thu, 23 May 2019 21:52:03 +0000
Bug 1552897 - Ride along: format with black r=ahal Depends on D31807 Differential Revision: https://phabricator.services.mozilla.com/D31808
0d3252cab0d8e5cece49bd84b63832d4f55fefe8: Bug 1552897 - Add support of diff in stylish/mozlint results r=ahal
Robert Bartlensky <bartlensky.robert@gmail.com> - Thu, 23 May 2019 16:42:46 +0000 - rev 475217
Push 36057 by aciure@mozilla.com at Thu, 23 May 2019 21:52:03 +0000
Bug 1552897 - Add support of diff in stylish/mozlint results r=ahal Differential Revision: https://phabricator.services.mozilla.com/D31807
494e3008ec9da0456a7b2d13e68bee84f88572f4: No bug: [declarative-artifacts] Report task being generated in artifact_map errors; r=sfraser
Tom Prince <mozilla@hocat.ca> - Thu, 23 May 2019 16:38:36 +0000 - rev 475216
Push 36057 by aciure@mozilla.com at Thu, 23 May 2019 21:52:03 +0000
No bug: [declarative-artifacts] Report task being generated in artifact_map errors; r=sfraser Differential Revision: https://phabricator.services.mozilla.com/D31741
705ac184fb58d25c36736aa5fc8a3f844ae91f9a: Bug 1550567 - pref on vorbis decoding on RDD for linux. r=drno
Michael Froman <mfroman@mozilla.com> - Thu, 23 May 2019 16:13:26 +0000 - rev 475215
Push 36057 by aciure@mozilla.com at Thu, 23 May 2019 21:52:03 +0000
Bug 1550567 - pref on vorbis decoding on RDD for linux. r=drno Differential Revision: https://phabricator.services.mozilla.com/D32327
be5b9ac813f5b515a1884fd2c5048e6b601da694: Bug 1548362 - Include visual viewport offsets in bounds and hittest calculations. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Wed, 15 May 2019 00:06:30 +0000 - rev 475214
Push 36057 by aciure@mozilla.com at Thu, 23 May 2019 21:52:03 +0000
Bug 1548362 - Include visual viewport offsets in bounds and hittest calculations. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D30385
9d7773bd3ae77a29908e365d5eece5890a334ab6: Bug 1380905 - Allow HTMLComboboxAccessible to be shut down twice. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Wed, 22 May 2019 04:50:31 +0000 - rev 475213
Push 36057 by aciure@mozilla.com at Thu, 23 May 2019 21:52:03 +0000
Bug 1380905 - Allow HTMLComboboxAccessible to be shut down twice. r=Jamie Accessibles can be shut down twice. For example, their doc might shut them down in its own ShutDown, while a reference is still being held by a dispatched event. When the event goes away, or the cycle collector kicks in, the accessible may be finally released and shut down again via LastRelease. Differential Revision: https://phabricator.services.mozilla.com/D31815
020c8c871c0d3b3920fe95935cfef06501976c0f: Bug 1552795 - Remove all trailing whitespaces in idl files r=Ehsan
Sylvestre Ledru <sledru@mozilla.com> - Wed, 22 May 2019 22:37:14 +0000 - rev 475212
Push 36057 by aciure@mozilla.com at Thu, 23 May 2019 21:52:03 +0000
Bug 1552795 - Remove all trailing whitespaces in idl files r=Ehsan Differential Revision: https://phabricator.services.mozilla.com/D31769
98fff5841f431d08657920cd48ed308d75dfead2: Merge mozilla-central to autoland. a=merge on a CLOSED TREE
Daniel Varga <dvarga@mozilla.com> - Thu, 23 May 2019 18:59:21 +0300 - rev 475211
Push 36057 by aciure@mozilla.com at Thu, 23 May 2019 21:52:03 +0000
Merge mozilla-central to autoland. a=merge on a CLOSED TREE
0ac1469f9416f0a5beab24d22b3c1e63af89ed14: Bug 1137575 - disable test_native_mouse_mac.xul for osx 10.14. r=spohl
Joel Maher <jmaher@mozilla.com> - Thu, 23 May 2019 15:40:08 +0000 - rev 475210
Push 36057 by aciure@mozilla.com at Thu, 23 May 2019 21:52:03 +0000
Bug 1137575 - disable test_native_mouse_mac.xul for osx 10.14. r=spohl disable test_native_mouse_mac.xul for osx 10.14. Differential Revision: https://phabricator.services.mozilla.com/D32336
781c2bb366d3725e94dc44deab768cd9fd706e75: Backed out 2 changesets (bug 1553772) for Geckoview failures in org.mozilla.geckoview.test.SelectionActionDelegateTest.collapseToStart[#designmode]
Dorel Luca <dluca@mozilla.com> - Thu, 23 May 2019 18:30:54 +0300 - rev 475209
Push 36057 by aciure@mozilla.com at Thu, 23 May 2019 21:52:03 +0000
Backed out 2 changesets (bug 1553772) for Geckoview failures in org.mozilla.geckoview.test.SelectionActionDelegateTest.collapseToStart[#designmode] Backed out changeset 7286e18fbc17 (bug 1553772) Backed out changeset 58d40da71355 (bug 1553772)
dfabf5135cf1b219f4ea809d4b066ffe5d8a3cef: Bug 1553387 - Use createXULElement for 'window' menuitems on osx r=Gijs
Brian Grinstead <bgrinstead@mozilla.com> - Thu, 23 May 2019 15:12:21 +0000 - rev 475208
Push 36057 by aciure@mozilla.com at Thu, 23 May 2019 21:52:03 +0000
Bug 1553387 - Use createXULElement for 'window' menuitems on osx r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D32166
0cdcafff0e52f5355747ee52f9413422bce21399: Bug 1553766: encapsulate range boundary specific members of `nsDocumentEncoder` and free their memory in `nsDocumentEncoder::Initialize`. r=hsivonen
Mirko Brodesser <mbrodesser@mozilla.com> - Thu, 23 May 2019 14:47:10 +0000 - rev 475207
Push 36057 by aciure@mozilla.com at Thu, 23 May 2019 21:52:03 +0000
Bug 1553766: encapsulate range boundary specific members of `nsDocumentEncoder` and free their memory in `nsDocumentEncoder::Initialize`. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D32304
(0) -300000 -100000 -30000 -10000 -3000 -1000 -120 tip