searching for reviewer(yzen)
c42d1925392094fbfcc75877f507dac43c5e3c9e: Bug 1691544 - Part 1 - Use -moz-accent-color for focus ring on Linux. r=yzen,dao
harry <htwyford@mozilla.com> - Wed, 24 Feb 2021 16:02:40 +0000 - rev 568620
Push 38235 by ncsoregi@mozilla.com at Wed, 24 Feb 2021 21:51:51 +0000
Bug 1691544 - Part 1 - Use -moz-accent-color for focus ring on Linux. r=yzen,dao Dao points out at https://phabricator.services.mozilla.com/D105097#inline-590409 that prefers-contrast is not adequate when accounting for various Linux OS themes. We have to use the OS accent color on Linux if we want to maintain compatibility with OS themes. This follows not supporting the new color for the unfocused Urlbar on Linux (see D104898) and not supporting the grey result-highlight colour on Linux (see D105535). We should change focus-outline-color universally on Linux for the same reasons. Differential Revision: https://phabricator.services.mozilla.com/D105672
2560f3f055fd371f4c2bc528a8c7e270ac7c0714: Bug 1688960 - Use h1 and h2 elements for panel headers and subheaders. r=Standard8,yzen,fluent-reviewers,flod
Mike Conley <mconley@mozilla.com> - Wed, 24 Feb 2021 02:52:30 +0000 - rev 568532
Push 38233 by abutkovits@mozilla.com at Wed, 24 Feb 2021 10:01:19 +0000
Bug 1688960 - Use h1 and h2 elements for panel headers and subheaders. r=Standard8,yzen,fluent-reviewers,flod Differential Revision: https://phabricator.services.mozilla.com/D105081
a34474998cd6daf45b77ce16ec8077f9c5e1fac0: Bug 1688960 - Use h1 and h2 elements for panel headers and subheaders. r=Standard8,yzen,fluent-reviewers,flod
Mike Conley <mconley@mozilla.com> - Tue, 23 Feb 2021 23:16:12 +0000 - rev 568503
Push 38233 by abutkovits@mozilla.com at Wed, 24 Feb 2021 10:01:19 +0000
Bug 1688960 - Use h1 and h2 elements for panel headers and subheaders. r=Standard8,yzen,fluent-reviewers,flod Differential Revision: https://phabricator.services.mozilla.com/D105081
4998c3672d369a5d269d8180320e3c1e413bfd13: Bug 1652192: Enable event logging for accessible/tests/browser/states/browser_test_visibility.js. r=yzen
James Teh <jteh@mozilla.com> - Sun, 14 Feb 2021 22:14:03 +0000 - rev 567464
Push 38204 by malexandru@mozilla.com at Mon, 15 Feb 2021 09:31:20 +0000
Bug 1652192: Enable event logging for accessible/tests/browser/states/browser_test_visibility.js. r=yzen I can't reproduce this on try, so I'm landing this so I can get (hopefully) useful info next time it fails. Differential Revision: https://phabricator.services.mozilla.com/D104942
df15427a4962755d41d6425f07822ec8c0d44223: Bug 1690456: Don't allow nsAccessibilityService to be shut down while a parent document is still shutting down. r=yzen
James Teh <jteh@mozilla.com> - Thu, 04 Feb 2021 01:10:52 +0000 - rev 565933
Push 38169 by abutkovits@mozilla.com at Thu, 04 Feb 2021 09:38:34 +0000
Bug 1690456: Don't allow nsAccessibilityService to be shut down while a parent document is still shutting down. r=yzen DocAccessible::Shutdown calls DocManager::NotifyOfDocumentShutdown, which can shut down nsAccessibilityService if there are no more consumers. Previously, this could happen even when shutting down child documents. Since shutting down the service shuts down all documents, this resulted in shutting down the parent document within an outer call to shut down that same document. Even if that reentry were prevented, the service would have been gone when returning to the outer Shutdown call, which still needs the service to complete its cleanup. To fix this, DocManager::NotifyOfDocumentShutdown takes an argument specifying whether to allow service shutdown. This is set to false when shutting down child documents. The service is thus allowed to shut down when returning to the parent document Shutdown. In addition, mPresShell is cleared before shutting down child documents to prevent reentry like this. While this should no longer happen, this should safeguard against similar pain in future. Differential Revision: https://phabricator.services.mozilla.com/D103966
767c22222bec798565d02f1c5b60c1120891d873: Bug 1686238: Only attempt to traverse containers menu if containers are enabled and defined r=yzen
Morgan Reschenberg <mreschenberg@mozilla.com> - Fri, 22 Jan 2021 21:02:50 +0000 - rev 564353
Push 38135 by ncsoregi@mozilla.com at Sat, 23 Jan 2021 10:00:21 +0000
Bug 1686238: Only attempt to traverse containers menu if containers are enabled and defined r=yzen Differential Revision: https://phabricator.services.mozilla.com/D102799
739437f45d3bd43eb0c687c9e959f73926b17d23: Bug 1669748: Null check the document IAccessibles sent for OOP iframes. r=yzen
James Teh <jteh@mozilla.com> - Tue, 19 Jan 2021 19:30:57 +0000 - rev 563810
Push 38121 by smolnar@mozilla.com at Wed, 20 Jan 2021 09:51:21 +0000
Bug 1669748: Null check the document IAccessibles sent for OOP iframes. r=yzen The COM proxy for a DocAccessibleParent at the top level in its content process really should never be null. However, some systems seem to have a broken COM configuration which causes problems like this. This does mean a11y is broken, but users who get a11y enabled because of something other than an AT (e.g. touch screen) probably aren't even aware. Regardless, we shouldn't crash. Instead, we assert (in debug builds) and null check. Differential Revision: https://phabricator.services.mozilla.com/D102129
d52f7c7e3f881bd076b8e1d13b51900577083966: Bug 1682055 - Fix customize menu accessibility issues. r=yzen,prathiksha
Erica Wright <ewright@mozilla.com> - Fri, 08 Jan 2021 16:35:33 +0000 - rev 562451
Push 38089 by malexandru@mozilla.com at Fri, 08 Jan 2021 21:57:36 +0000
Bug 1682055 - Fix customize menu accessibility issues. r=yzen,prathiksha Differential Revision: https://phabricator.services.mozilla.com/D100275
d5d011725ca9f6564d38cd5d836f295ba56ff5cc: Bug 1683330 - Revert skipping inserted node when using TreeWalker.Next in insertion iterator. r=yzen
Eitan Isaacson <eitan@monotonous.org> - Fri, 18 Dec 2020 22:19:18 +0000 - rev 561322
Push 38045 by ncsoregi@mozilla.com at Sat, 19 Dec 2020 09:33:21 +0000
Bug 1683330 - Revert skipping inserted node when using TreeWalker.Next in insertion iterator. r=yzen This change that was introduced in bug 1682692 was not actually tested and is unrelated to the fix. I thought that this was more correct, and I added it. But this change should be reverted. Differential Revision: https://phabricator.services.mozilla.com/D100169
be26ed8ea40c9660d14c29e2adc174c13a9edf3f: Bug 1680440 - [devtools] Remove backward compatibility code in CombinedProgress#onProgressForWalker. r=yzen.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 11 Dec 2020 13:54:54 +0000 - rev 560333
Push 38023 by ncsoregi@mozilla.com at Fri, 11 Dec 2020 21:30:49 +0000
Bug 1680440 - [devtools] Remove backward compatibility code in CombinedProgress#onProgressForWalker. r=yzen. Older server didn't have the `completed` property, and we needed to rely on the `progress` one. `completed` was added in 79, so we'll always have access to it now. Differential Revision: https://phabricator.services.mozilla.com/D98731
c9a470a98696c8524f73d97d0255abc2a52ffa62: Bug 1326659 - [devtools] Remove macos skipif for browser_toolbox_keyboard_navigation.js r=yzen
Julian Descottes <jdescottes@mozilla.com> - Tue, 08 Dec 2020 18:15:25 +0000 - rev 559857
Push 38014 by apavel@mozilla.com at Tue, 08 Dec 2020 21:34:57 +0000
Bug 1326659 - [devtools] Remove macos skipif for browser_toolbox_keyboard_navigation.js r=yzen Depends on D98987 Try push looks ok without the skip-if, might be fine to remove it Differential Revision: https://phabricator.services.mozilla.com/D99038
8dae0f4af8f85654c68b853133d658aacdb9ea20: Bug 1326659 - [devtools] Use button element to render close button in NotificationBox r=nchevobbe,yzen
Julian Descottes <jdescottes@mozilla.com> - Tue, 08 Dec 2020 18:14:22 +0000 - rev 559856
Push 38014 by apavel@mozilla.com at Tue, 08 Dec 2020 21:34:57 +0000
Bug 1326659 - [devtools] Use button element to render close button in NotificationBox r=nchevobbe,yzen Differential Revision: https://phabricator.services.mozilla.com/D98987
0d15a058dff46598dd0af0b4db0b2bbbbfa5340b: Bug 1664894: Track VoiceOver under A11Y_INSTANTIATORS telemetry r=eeejay,yzen
Morgan Reschenberg <mreschenberg@mozilla.com> - Mon, 07 Dec 2020 22:14:30 +0000 - rev 559746
Push 38012 by dluca@mozilla.com at Tue, 08 Dec 2020 09:45:00 +0000
Bug 1664894: Track VoiceOver under A11Y_INSTANTIATORS telemetry r=eeejay,yzen Differential Revision: https://phabricator.services.mozilla.com/D98697
01b9ec34dbde6170c0892237dbd9de3217e880b2: Bug 1677016: Provide ability for browser a11y tests to load XUL documents in the parent process. r=yzen
James Teh <jteh@mozilla.com> - Mon, 16 Nov 2020 23:50:02 +0000 - rev 557473
Push 37957 by malexandru@mozilla.com at Tue, 17 Nov 2020 09:44:06 +0000
Bug 1677016: Provide ability for browser a11y tests to load XUL documents in the parent process. r=yzen addAccessibleTask can now take a chrome: true option to load the test in the parent process if it is a XUL document. Differential Revision: https://phabricator.services.mozilla.com/D96960
c68ab3e8a465e653107aa8889c0c7b8f982ab205: Bug 1675094 Replace executeSoon() with waitForTick() in accessible/tests/browser r=Jamie,yzen
Andrey Bienkowski <hexagonrecursion@gmail.com> - Thu, 05 Nov 2020 18:27:40 +0000 - rev 556110
Push 37925 by apavel@mozilla.com at Fri, 06 Nov 2020 04:14:34 +0000
Bug 1675094 Replace executeSoon() with waitForTick() in accessible/tests/browser r=Jamie,yzen Differential Revision: https://phabricator.services.mozilla.com/D95779
26f19aaba8e2ada7250db0f018a2db763100037d: Bug 1672694 - P1: Query layout for selectable text state. r=morgan,Jamie,yzen
Eitan Isaacson <eitan@monotonous.org> - Wed, 04 Nov 2020 19:56:55 +0000 - rev 555893
Push 37922 by cbrindusan@mozilla.com at Thu, 05 Nov 2020 04:52:47 +0000
Bug 1672694 - P1: Query layout for selectable text state. r=morgan,Jamie,yzen The SELECTABLE_TEXT state is currently under-utilized and probably wrong, since it simply relies on testing if a hypertext has any text. A more correct reflection of the state should be taken from layout's IsSelectable method. Note, even if an element is styled `user-select: none`, the text will still be keyboard selectable if it is editable (eg. input or contenteditable), so we should consider that SELECTABLE_TEXT. Differential Revision: https://phabricator.services.mozilla.com/D95783
532dcdd149e5a6af44b0fa75bd069066c75b2bb4: Bug 1673882 - [devtools] Fix DOMNode icon in a11y panel sidebar. r=yzen.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 29 Oct 2020 14:52:11 +0000 - rev 555090
Push 37903 by apavel@mozilla.com at Fri, 30 Oct 2020 03:48:30 +0000
Bug 1673882 - [devtools] Fix DOMNode icon in a11y panel sidebar. r=yzen. The panel was using the `highlighterFront` property of the nodeFront, but it was removed in Bug 1623667, and as a result, highlighting was broken. To be consistent with the other panels having such capabilities (console, debugger, …), we now use the toolbox `getHighlighter` function. This wasn't caught because there wasn't any test covering this behavior; this patch adds one, that was failing without the fix in Accessible. Differential Revision: https://phabricator.services.mozilla.com/D95030
cc8134ef17713f45d589222281945b9f8352333f: Bug 1672937 - [devtools] Remove l10n fixtures in accessibility jest tests. r=yzen.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Sat, 24 Oct 2020 06:05:07 +0000 - rev 554775
Push 37898 by abutkovits@mozilla.com at Wed, 28 Oct 2020 09:24:21 +0000
Bug 1672937 - [devtools] Remove l10n fixtures in accessibility jest tests. r=yzen. Those fixtures aren't needed anymore since the l10n module supports Node environment. Tests and stubs were updated accordingly so we now have the actual properties values instead of their keys. Depends on D94571 Differential Revision: https://phabricator.services.mozilla.com/D94572
9d74ce5f7e0476e7bcde908d0cb495a145364026: Bug 1665751 Part 3: Rewrite textSelection/test_general.html to use async await instead of event queue, r=yzen DONTBUILD
Marco Zehe <mzehe@mozilla.com> - Mon, 21 Sep 2020 18:34:45 +0000 - rev 549552
Push 37802 by rmaries@mozilla.com at Tue, 22 Sep 2020 09:45:38 +0000
Bug 1665751 Part 3: Rewrite textSelection/test_general.html to use async await instead of event queue, r=yzen DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D90860
ac97b9243102a1e12d633f8b4f676eb8536ed01f: Bug 1665751 Part 2: Factor out the Select All And Focus element sequence into a utility function for use by other test files, r=yzen DONTBUILD
Marco Zehe <mzehe@mozilla.com> - Mon, 21 Sep 2020 18:34:27 +0000 - rev 549551
Push 37802 by rmaries@mozilla.com at Tue, 22 Sep 2020 09:45:38 +0000
Bug 1665751 Part 2: Factor out the Select All And Focus element sequence into a utility function for use by other test files, r=yzen DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D90859
6917838bb7739d6467c634e0b46611f987e58c32: Bug 1665751 - Convert test_userinput.html to promisified events, r=yzen DONTBUILD
Marco Zehe <mzehe@mozilla.com> - Sat, 19 Sep 2020 06:49:35 +0000 - rev 549364
Push 37795 by ccoroiu@mozilla.com at Sat, 19 Sep 2020 09:34:53 +0000
Bug 1665751 - Convert test_userinput.html to promisified events, r=yzen DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D90682
ab4e18b490a3c3ca286c5e8cfd318a6729a12dc4: Bug 1660359 part 2: Allow a11y focus on a remote print preview OuterDocAccessible. r=jwatt,yzen
James Teh <jteh@mozilla.com> - Thu, 27 Aug 2020 06:12:25 +0000 - rev 546902
Push 37737 by csabou@mozilla.com at Sat, 29 Aug 2020 09:12:26 +0000
Bug 1660359 part 2: Allow a11y focus on a remote print preview OuterDocAccessible. r=jwatt,yzen Print preview documents don't get DocAccessibles because this currently causes crashes and doesn't provide much value. However, we still want to tell a11y clients something useful when a print preview document gets focus, rather than a11y focus just going nowhere. Therefore, we allow a11y focus to land on the OuterDocAccessible (browser element) in this case. Differential Revision: https://phabricator.services.mozilla.com/D87997
e3b7b1a14ab1d0f25622d030bc882451915e62f0: Bug 1660359 part 1: Unify rejection of a11y focus on remote OuterDocAccessibles. r=yzen
James Teh <jteh@mozilla.com> - Thu, 27 Aug 2020 06:12:29 +0000 - rev 546711
Push 37736 by apavel@mozilla.com at Fri, 28 Aug 2020 15:31:26 +0000
Bug 1660359 part 1: Unify rejection of a11y focus on remote OuterDocAccessibles. r=yzen Before Fission, FocusManager::FocusedDOMNode rejected a11y focus on remote XUL browsers by checking EventStateManager::IsRemoteTarget. In bug 1594623, code was added to FocusManager::ProcessDOMFocus to prevent a11y focus on OuterDocAccessibles in order to reject focus on OOP iframes. In bug 1635784, EventStateManager::IsRemoteTarget was renamed to EventStateManager::IsTopLevelRemoteTarget, and EventStateManager::IsRemoteTarget now checks for OOP iframes as well. This allows us to unify rejection of a11y focus on remote OuterDocAccessibles in FocusManager::FocusedDOMNode. Differential Revision: https://phabricator.services.mozilla.com/D87996
697accb3ceb382cb613d9ded02f115caa3d71de0: Bug 1660359 part 2: Allow a11y focus on a remote print preview OuterDocAccessible. r=jwatt,yzen
James Teh <jteh@mozilla.com> - Wed, 26 Aug 2020 13:49:43 +0000 - rev 546367
Push 37734 by ccoroiu@mozilla.com at Thu, 27 Aug 2020 09:30:43 +0000
Bug 1660359 part 2: Allow a11y focus on a remote print preview OuterDocAccessible. r=jwatt,yzen Print preview documents don't get DocAccessibles because this currently causes crashes and doesn't provide much value. However, we still want to tell a11y clients something useful when a print preview document gets focus, rather than a11y focus just going nowhere. Therefore, we allow a11y focus to land on the OuterDocAccessible (browser element) in this case. Differential Revision: https://phabricator.services.mozilla.com/D87997
fc650bd7d6b8ae03713e90193c111f9d9aa83f9a: Bug 1660359 part 1: Unify rejection of a11y focus on remote OuterDocAccessibles. r=yzen
James Teh <jteh@mozilla.com> - Mon, 24 Aug 2020 17:17:19 +0000 - rev 546366
Push 37734 by ccoroiu@mozilla.com at Thu, 27 Aug 2020 09:30:43 +0000
Bug 1660359 part 1: Unify rejection of a11y focus on remote OuterDocAccessibles. r=yzen Before Fission, FocusManager::FocusedDOMNode rejected a11y focus on remote XUL browsers by checking EventStateManager::IsRemoteTarget. In bug 1594623, code was added to FocusManager::ProcessDOMFocus to prevent a11y focus on OuterDocAccessibles in order to reject focus on OOP iframes. In bug 1635784, EventStateManager::IsRemoteTarget was renamed to EventStateManager::IsTopLevelRemoteTarget, and EventStateManager::IsRemoteTarget now checks for OOP iframes as well. This allows us to unify rejection of a11y focus on remote OuterDocAccessibles in FocusManager::FocusedDOMNode. Differential Revision: https://phabricator.services.mozilla.com/D87996
9e2d306e37b5fe088bafa7edea23de9771bd42f8: Bug 1629890 - Convert accessible isDestroyed getter to Actor::isDestroyed() r=yzen,nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Mon, 10 Aug 2020 18:56:38 +0000 - rev 544387
Push 37694 by dluca@mozilla.com at Wed, 12 Aug 2020 21:49:48 +0000
Bug 1629890 - Convert accessible isDestroyed getter to Actor::isDestroyed() r=yzen,nchevobbe Depends on D86324 Differential Revision: https://phabricator.services.mozilla.com/D86325
b9141033e4a4a4ef463f31477396aae72858a2d1: Bug 1639328 - Fix browser_hidden_iframe.js. r=yzen
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 11 Aug 2020 02:17:15 +0000 - rev 544288
Push 37692 by cbrindusan@mozilla.com at Wed, 12 Aug 2020 03:44:18 +0000
Bug 1639328 - Fix browser_hidden_iframe.js. r=yzen Differential Revision: https://phabricator.services.mozilla.com/D86591
23130282a937f703c23003353b362a503be6e182: Bug 1639328 - Fix browser_hidden_iframe.js. r=yzen
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 10 Aug 2020 23:00:10 +0000 - rev 544185
Push 37689 by ncsoregi@mozilla.com at Tue, 11 Aug 2020 09:17:31 +0000
Bug 1639328 - Fix browser_hidden_iframe.js. r=yzen Differential Revision: https://phabricator.services.mozilla.com/D86591
f3a845bd10aaabd0bfe8711bb4c6ac2df5d927a6: Bug 1657744 - Don't fail when forcing e10s off on a11y browser tests. r=yzen DONTBUILD
Eitan Isaacson <eitan@monotonous.org> - Thu, 06 Aug 2020 23:19:23 +0000 - rev 543686
Push 37679 by btara@mozilla.com at Fri, 07 Aug 2020 09:31:58 +0000
Bug 1657744 - Don't fail when forcing e10s off on a11y browser tests. r=yzen DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D86271
3e441eedb6579084d36b847b7c5eab06d1449445: Bug 1647666: test_doc_busy.html: Handle the case where the busy change and not-busy change events are coalesced out of existence. r=yzen
James Teh <jteh@mozilla.com> - Sun, 12 Jul 2020 14:56:23 +0000 - rev 540095
Push 37591 by nbeleuzu@mozilla.com at Sun, 12 Jul 2020 21:44:58 +0000
Bug 1647666: test_doc_busy.html: Handle the case where the busy change and not-busy change events are coalesced out of existence. r=yzen Also removed debug logging, as well as about:blank check which turned out not to be the cause of the timeout. Differential Revision: https://phabricator.services.mozilla.com/D82137
5db8f5164ed6731aca5fb2c4adf1c5eb0d7f6fdc: Bug 1648069 - Make the Changes view a document for screen readers, r=yzen
Marco Zehe <mzehe@mozilla.com> - Fri, 26 Jun 2020 00:15:21 +0000 - rev 537554
Push 37544 by dluca@mozilla.com at Fri, 26 Jun 2020 09:45:40 +0000
Bug 1648069 - Make the Changes view a document for screen readers, r=yzen Also make it focusable so screen readers will pick up even the "no changes yet" scenario and won't skip over it. Differential Revision: https://phabricator.services.mozilla.com/D80865
7ba87dd39ebb9cfa253e8f6fe4455516dd2d502c: Bug 1630208 part 4: Re-enable accessible/tests/browser/hittest/browser_test_zoom_text.js. r=yzen
James Teh <jteh@mozilla.com> - Wed, 17 Jun 2020 18:42:48 +0000 - rev 536226
Push 37517 by malexandru@mozilla.com at Thu, 18 Jun 2020 04:43:29 +0000
Bug 1630208 part 4: Re-enable accessible/tests/browser/hittest/browser_test_zoom_text.js. r=yzen The intermittent leak has been fixed, so we can now re-enable this. Differential Revision: https://phabricator.services.mozilla.com/D79782
11f1206f750698c94dc6384973a0e4d6d019858f: Bug 1630208 part 3: Clean up the remote XPC document accessible cache on shutdown. r=yzen
James Teh <jteh@mozilla.com> - Wed, 17 Jun 2020 18:42:30 +0000 - rev 536225
Push 37517 by malexandru@mozilla.com at Thu, 18 Jun 2020 04:43:29 +0000
Bug 1630208 part 3: Clean up the remote XPC document accessible cache on shutdown. r=yzen The cache should already be empty by this point unless there's a bug, but we should still clean up regardless. Also, the hashtable itself was previously never cleaned up even if it was empty. Differential Revision: https://phabricator.services.mozilla.com/D79781
ff44409be7643400d9fe5d6c5bbb203abc382862: Bug 1630208 part 2: Drop events for DocAccessibleParents which are already shut down. r=yzen
James Teh <jteh@mozilla.com> - Wed, 17 Jun 2020 18:40:42 +0000 - rev 536224
Push 37517 by malexandru@mozilla.com at Thu, 18 Jun 2020 04:43:29 +0000
Bug 1630208 part 2: Drop events for DocAccessibleParents which are already shut down. r=yzen We can receive IPC events after a DocAccessibleParent is shut down if the BrowserParent is in the process of being destroyed (probably the tab closed) but there are still events in the IPC queue. Most Recv*Event methods in BrowserParent check mShutdown, but a few don't. For the events that don't, if the event is for a document, we'll successfully fire the platform event, and then successfully get and cache an xpcAccessibleDocument. However, that xpcAccessibleDocument will never be removed from the cache because it's already shut down, so NotifyOfRemoteDocShutdown (which would normally remove it from the XPC cache) won't get called. This results in a leaked object. Thus, it's important that all Recv*Event methods drop the event if mShutdown is true. This patch adds that check to the methods which didn't have it already. Differential Revision: https://phabricator.services.mozilla.com/D79780
085812b8255e76f7de4f9f05b035fa2b97b0b52f: Bug 1630208 part 1: Assert that we don't add a shut down DocAccessibleParent to the remote XPC cache in DocManager::GetXPCDocument. r=yzen
James Teh <jteh@mozilla.com> - Wed, 17 Jun 2020 18:37:58 +0000 - rev 536223
Push 37517 by malexandru@mozilla.com at Thu, 18 Jun 2020 04:43:29 +0000
Bug 1630208 part 1: Assert that we don't add a shut down DocAccessibleParent to the remote XPC cache in DocManager::GetXPCDocument. r=yzen We really want to know about this because the document will never be removed from the cache, since NotifyOfRemoteDocShutdown (which would normally remove it from the XPC cache) won't get called. Differential Revision: https://phabricator.services.mozilla.com/D79779
3435100c8a79141bc3ac99ded0cb2fecbae97326: Bug 1644669 part 2 - Make the flex container view more accessible to screen reader users, r=yzen
Marco Zehe <mzehe@mozilla.com> - Fri, 12 Jun 2020 17:39:44 +0000 - rev 535543
Push 37501 by nbeleuzu@mozilla.com at Sat, 13 Jun 2020 03:21:52 +0000
Bug 1644669 part 2 - Make the flex container view more accessible to screen reader users, r=yzen This patch does the following: 1. Both the flex-direction and flex-wrap badges are being treated as illustrations, not generic containers, so screen readers immediately pick up the full meaning from the title. 2. Turns the flex item list sub heading into an actual heading for screen readers. It is level 3 because the accordeon headings are all level 2. Differential Revision: https://phabricator.services.mozilla.com/D79129
f495c9163247176a0c7c45016a763ae11095e6c5: Bug 1644669 Part 1 - Label the button to return to the flex container view for screen readers, r=yzen
Marco Zehe <mzehe@mozilla.com> - Fri, 12 Jun 2020 14:50:30 +0000 - rev 535542
Push 37501 by nbeleuzu@mozilla.com at Sat, 13 Jun 2020 03:21:52 +0000
Bug 1644669 Part 1 - Label the button to return to the flex container view for screen readers, r=yzen Differential Revision: https://phabricator.services.mozilla.com/D79128
3fefa1d023a6f62cc899f02539cce31edd88bd41: Bug 1630391: Add telemetry test for backplate and a11y theme scalars. r=chutten,yzen
Morgan Reschenberg <mreschenberg@mozilla.com> - Fri, 12 Jun 2020 17:02:45 +0000 - rev 535518
Push 37501 by nbeleuzu@mozilla.com at Sat, 13 Jun 2020 03:21:52 +0000
Bug 1630391: Add telemetry test for backplate and a11y theme scalars. r=chutten,yzen Differential Revision: https://phabricator.services.mozilla.com/D72184
f55dacce61a217fbf9ff3b54c85c4db2ed7d0032: Bug 1644693 - Grid accordeon: Give the section headers proper heading roles and levels for better structure, r=yzen
Marco Zehe <mzehe@mozilla.com> - Fri, 12 Jun 2020 15:18:40 +0000 - rev 535485
Push 37501 by nbeleuzu@mozilla.com at Sat, 13 Jun 2020 03:21:52 +0000
Bug 1644693 - Grid accordeon: Give the section headers proper heading roles and levels for better structure, r=yzen Differential Revision: https://phabricator.services.mozilla.com/D79131
2909e1179d0d1c6de3d1d2be92c3aee08d3384fd: Bug 1644343 Part 3 - Make the box model understandable to screen reader users, r=yzen,flod
Marco Zehe <mzehe@mozilla.com> - Fri, 12 Jun 2020 12:08:09 +0000 - rev 535455
Push 37501 by nbeleuzu@mozilla.com at Sat, 13 Jun 2020 03:21:52 +0000
Bug 1644343 Part 3 - Make the box model understandable to screen reader users, r=yzen,flod This patch adds IDs to all the box divs so they can be referenced by ARIA attributes. The actual legend spans also act as region landmarks with an associated level so the nesting is relayed. In addition, each of those boxes gets the buttons for its dimensions rendered in-place so for assistive technologies, this all follows a logical flow. aria-owns changes the accessibility tree so the nesting and associated properties are grouped together. The actual buttons also receive a localizable aria-label that is a combination of the button text and title, so screen reader users not only hear "0 button" without knowing immediately what that button actually belongs to. Title is secondary information. Differential Revision: https://phabricator.services.mozilla.com/D78953
d4f83af5e5246671a95ff70c8bbbd67bc2c02fc7: Bug 1644343 Part 2 - Make the dimension information in the box model more explicit for screen readers, r=yzen,flod
Marco Zehe <mzehe@mozilla.com> - Thu, 11 Jun 2020 10:54:45 +0000 - rev 535454
Push 37501 by nbeleuzu@mozilla.com at Sat, 13 Jun 2020 03:21:52 +0000
Bug 1644343 Part 2 - Make the dimension information in the box model more explicit for screen readers, r=yzen,flod This patch turns the info that holds the dimensions and position info into a region. Because the visual representation is without explanatory text, an aria-label is constructed for that region to hold a more explicit version of the displayed information. Differential Revision: https://phabricator.services.mozilla.com/D78952
f9f69dac57bee05981f9f38944f184c7e53140cc: Bug 1644343 Part 1 - Make layout properties accessible to screen readers, r=yzen
Marco Zehe <mzehe@mozilla.com> - Thu, 11 Jun 2020 15:31:08 +0000 - rev 535453
Push 37501 by nbeleuzu@mozilla.com at Sat, 13 Jun 2020 03:21:52 +0000
Bug 1644343 Part 1 - Make layout properties accessible to screen readers, r=yzen 1. Fix the twisty so it has a role and name that reflects the action the button will take when clicked (show or hide). 2. Give the section itself a heading so it can easily be found. Make it a level 3 so it is clear that this is a sub section of the box model view. 3. Order the properties themselves in a table with rows for each property, and cells for the name and value. 4. Make the property names and values, which are not editable, not clickable. Differential Revision: https://phabricator.services.mozilla.com/D78951
f1f9e78e6a1290ab7427776bb59f2a87311e6dab: Bug 1596018 - Mark all presentational divs that might become scrollable, with a tabindex of -1 so they are not reached when tabbing, r=yzen
Marco Zehe <mzehe@mozilla.com> - Fri, 12 Jun 2020 11:11:50 +0000 - rev 535437
Push 37501 by nbeleuzu@mozilla.com at Sat, 13 Jun 2020 03:21:52 +0000
Bug 1596018 - Mark all presentational divs that might become scrollable, with a tabindex of -1 so they are not reached when tabbing, r=yzen Differential Revision: https://phabricator.services.mozilla.com/D79019
04b11bcd330ec9e5803cdf54f35673e506a7685c: Bug 1596018 - Mark all presentational divs that might become scrollable, with a tabindex of -1 so they are not reached when tabbing, r=yzen
Marco Zehe <mzehe@mozilla.com> - Thu, 11 Jun 2020 14:55:24 +0000 - rev 535109
Push 37498 by apavel@mozilla.com at Fri, 12 Jun 2020 03:05:25 +0000
Bug 1596018 - Mark all presentational divs that might become scrollable, with a tabindex of -1 so they are not reached when tabbing, r=yzen Differential Revision: https://phabricator.services.mozilla.com/D79019
b1ea583f8cb86bf703b37e0f6bbee151e9a85c1a: Bug 1630391: Add telemetry test for backplate and a11y theme scalars. r=chutten,yzen
Morgan Reschenberg <mreschenberg@mozilla.com> - Wed, 10 Jun 2020 20:40:33 +0000 - rev 534970
Push 37496 by btara@mozilla.com at Thu, 11 Jun 2020 04:04:33 +0000
Bug 1630391: Add telemetry test for backplate and a11y theme scalars. r=chutten,yzen Differential Revision: https://phabricator.services.mozilla.com/D72184
c15ccd143f3267081423ac6f59e5341918e344a9: Bug 1630391: Add telemetry test for backplate and a11y theme scalars. r=chutten,yzen
Morgan Reschenberg <mreschenberg@mozilla.com> - Tue, 09 Jun 2020 21:56:01 +0000 - rev 534771
Push 37494 by nbeleuzu@mozilla.com at Wed, 10 Jun 2020 14:02:18 +0000
Bug 1630391: Add telemetry test for backplate and a11y theme scalars. r=chutten,yzen Differential Revision: https://phabricator.services.mozilla.com/D72184
3d1e9c77a42dec977bd7a22e2668af56b2587145: Bug 1644127 - Turn the layout side pane into a document for screen readers, r=yzen
Marco Zehe <mzehe@mozilla.com> - Mon, 08 Jun 2020 16:53:03 +0000 - rev 534579
Push 37491 by apavel@mozilla.com at Tue, 09 Jun 2020 09:21:34 +0000
Bug 1644127 - Turn the layout side pane into a document for screen readers, r=yzen This will make it navigable with screen reader commands. Depends on D78674 Differential Revision: https://phabricator.services.mozilla.com/D78675
be296969313c0ff1a85e6eb1811f89643c38f715: Bug 977244 - Make the rules view easier to navigate with a screen reader, r=yzen
Marco Zehe <mzehe@mozilla.com> - Mon, 08 Jun 2020 17:08:53 +0000 - rev 534578
Push 37491 by apavel@mozilla.com at Tue, 09 Jun 2020 09:21:34 +0000
Bug 977244 - Make the rules view easier to navigate with a screen reader, r=yzen To give the whole rules view more structure: 1. Make the container a document so screen readers invoke their reading mode. 2. Give the different section headers a proper heading role. 3. Make each separate item an article so screen readers can navigate them more easily. 4. Give the expander twisty for the pseudo classes a proper label that adjusts depending on whether pseudo classes are expanded or collapsed. Also make it a button for screen readers. This patch does not attempt to simulate any advanced navigation via the keyboard. Differential Revision: https://phabricator.services.mozilla.com/D78674
13b2c57cb1fe9ae6735f898a72c4858dc4d5d225: Bug 1151648: Construct accessible objects for SVG elements which have title or desc. r=MarcoZ,yzen
James Teh <jteh@mozilla.com> - Wed, 03 Jun 2020 13:18:38 +0000 - rev 534040
Push 37482 by nbeleuzu@mozilla.com at Fri, 05 Jun 2020 14:35:19 +0000
Bug 1151648: Construct accessible objects for SVG elements which have title or desc. r=MarcoZ,yzen According to SVG Accessibility API Mappings, an SVG element which has title or desc element must be exposed. https://w3c.github.io/svg-aam/#include_elements Previously, we didn't expose <g> elements at all even if they had a title/desc, and we unconditionally exposed some other SVG elements even when they didn't. This removes the Dev Tools A11y Panel code which explicitly allowed unlabelled descendants of role="img" <svg> elements, since we don't create descendants if they don't have a label now anyway. The associated tests had to be tweaked as well, since now we don't create unlabelled descendants. Original patch by Takeshi Kurosawa. Differential Revision: https://phabricator.services.mozilla.com/D77763
f65636dc2b12ab0480672a418adccc64219d8d7a: Bug 1427304: Return the oleacc window accessible for the outer HWND of windows created with popup=yes. r=yzen
James Teh <jteh@mozilla.com> - Fri, 29 May 2020 14:16:14 +0000 - rev 533096
Push 37462 by malexandru@mozilla.com at Sat, 30 May 2020 09:46:43 +0000
Bug 1427304: Return the oleacc window accessible for the outer HWND of windows created with popup=yes. r=yzen Differential Revision: https://phabricator.services.mozilla.com/D77442