searching for reviewer(vp)
385e0938172e2c9799de8ab42d0b052ae65495ee: Bug 1246555 - Abort infinite loop when a marker has a recursive stack trace in the marker details view. r=vp
Jordan Santell <jsantell@mozilla.com> - Tue, 23 Feb 2016 14:13:56 -0800 - rev 285267
Push 30027 by cbook@mozilla.com at Wed, 24 Feb 2016 11:04:26 +0000
Bug 1246555 - Abort infinite loop when a marker has a recursive stack trace in the marker details view. r=vp MozReview-Commit-ID: KLBXHfNF7EB
517676505f44d907b04319f8dc631e1c01f7cefe: Bug 1246273 - Add localized strings for types and attempts in the JIT opts view. r=vp
Jordan Santell <jsantell@mozilla.com> - Fri, 05 Feb 2016 13:26:09 -0800 - rev 283589
Push 29987 by cbook@mozilla.com at Wed, 10 Feb 2016 10:43:53 +0000
Bug 1246273 - Add localized strings for types and attempts in the JIT opts view. r=vp
912f7aa4d70f46d8c1c210d3a14547289b1df05e: Bug 1243929 - Only show jit optimizations panel when pref is on and current selected frame has optimizations. r=vp
Jordan Santell <jsantell@mozilla.com> - Fri, 05 Feb 2016 11:04:33 -0800 - rev 283588
Push 29987 by cbook@mozilla.com at Wed, 10 Feb 2016 10:43:53 +0000
Bug 1243929 - Only show jit optimizations panel when pref is on and current selected frame has optimizations. r=vp
fd756c76b859e3f12df64e416004fb3a2245b410: Bug 1172120 - Filter out uninteresting markers and bars in a test failing on linux/e10s consistently for marker details. r=vp
Jordan Santell <jsantell@mozilla.com> - Sat, 06 Feb 2016 12:20:14 -0800 - rev 283587
Push 29987 by cbook@mozilla.com at Wed, 10 Feb 2016 10:43:53 +0000
Bug 1172120 - Filter out uninteresting markers and bars in a test failing on linux/e10s consistently for marker details. r=vp
07f9be6ddc8d286561df77f585f854f3e457c1c9: Bug 1175756 - Change JIT optimizations to be a view pref, rather than a recording pref. r=vp
Jordan Santell <jsantell@mozilla.com> - Wed, 03 Feb 2016 14:59:38 -0800 - rev 283211
Push 29975 by philringnalda@gmail.com at Sat, 06 Feb 2016 02:27:56 +0000
Bug 1175756 - Change JIT optimizations to be a view pref, rather than a recording pref. r=vp
2e91c47d5ced479b43d9d46ee8f2a5f43adec60d: Bug 1204174 - Reduce test iterations to reduce intermittent timeouts. r=vp
Jordan Santell <jsantell@mozilla.com> - Wed, 27 Jan 2016 08:54:00 +0100 - rev 282144
Push 29952 by kwierso@gmail.com at Fri, 29 Jan 2016 01:47:42 +0000
Bug 1204174 - Reduce test iterations to reduce intermittent timeouts. r=vp
9dcc5c1e959450709696ec1dba5ad0ae3741e71b: Bug 1222417 - Filter Input Fixes in toolbar.js and memory.css. r=vp
Eduard Hanu <hanue@uni.coventry.ac.uk> - Tue, 10 Nov 2015 15:40:00 +0100 - rev 272086
Push 29660 by kwierso@gmail.com at Thu, 12 Nov 2015 00:33:54 +0000
Bug 1222417 - Filter Input Fixes in toolbar.js and memory.css. r=vp
d041722de44b55f6dbf591a7fefadc70120db007: Bug 1216542 - disable browser_wa_properties-view-media-nodes.js on OSX, due to failures on 10.10.5. r=vp
Jordan Santell <jsantell@mozilla.com> - Fri, 06 Nov 2015 20:40:00 +0100 - rev 271932
Push 29658 by cbook@mozilla.com at Wed, 11 Nov 2015 11:08:38 +0000
Bug 1216542 - disable browser_wa_properties-view-media-nodes.js on OSX, due to failures on 10.10.5. r=vp
e39cb56d2a6328c031bb59aa9817770c65470d7b: Bug 1141261 - Immediately disconnecting an audio node is now reflected properly in the web audio graph due to bug 1204595; tests for that scenario. r=vp
Jordan Santell <jsantell@mozilla.com> - Tue, 15 Sep 2015 17:02:16 -0700 - rev 262654
Push 29380 by kwierso@gmail.com at Wed, 16 Sep 2015 17:14:36 +0000
Bug 1141261 - Immediately disconnecting an audio node is now reflected properly in the web audio graph due to bug 1204595; tests for that scenario. r=vp
d81b35757962722421c4cd36dc88cf2a0eee0d7d: Bug 1150299 - Show optimization graph in the call tree sidebar. r=shu,vp
Jordan Santell <jsantell@mozilla.com> - Mon, 31 Aug 2015 15:26:02 -0700 - rev 262490
Push 29374 by cbook@mozilla.com at Tue, 15 Sep 2015 12:59:51 +0000
Bug 1150299 - Show optimization graph in the call tree sidebar. r=shu,vp
a27897b9091148a6f821eac1af8a381001dc8ed9: Bug 1171488 - Attach host and client system data to recording profiles r=vp,mossop
Jordan Santell <jsantell@mozilla.com> - Fri, 11 Sep 2015 09:37:20 -0700 - rev 262184
Push 29363 by philringnalda@gmail.com at Sat, 12 Sep 2015 22:59:06 +0000
Bug 1171488 - Attach host and client system data to recording profiles r=vp,mossop
206f2986ff806ef4fb02170f321f110c04c64952: Bug 1122058 - Add tests for adding telemetry to performance tool. r=vp,mratcliffe
Jordan Santell <jsantell@mozilla.com> - Sat, 12 Sep 2015 09:09:48 -0700 - rev 262183
Push 29363 by philringnalda@gmail.com at Sat, 12 Sep 2015 22:59:06 +0000
Bug 1122058 - Add tests for adding telemetry to performance tool. r=vp,mratcliffe
5d0470be49b3e5efe101a48e9875cf4c7f9a3d5f: Bug 1122058 - Add telemetry hooks to various performance tools actions. r=vp,mratcliffe
Jordan Santell <jsantell@mozilla.com> - Wed, 09 Sep 2015 15:20:12 -0700 - rev 262182
Push 29363 by philringnalda@gmail.com at Sat, 12 Sep 2015 22:59:06 +0000
Bug 1122058 - Add telemetry hooks to various performance tools actions. r=vp,mratcliffe
28f1e57d47573b0c78e67221df93148111c24e2a: Bug 1171488 - Attach host and client system data to recording profiles r=vp,mossop
Jordan Santell <jsantell@mozilla.com> - Tue, 08 Sep 2015 15:24:03 -0700 - rev 261899
Push 29355 by cbook@mozilla.com at Fri, 11 Sep 2015 14:37:04 +0000
Bug 1171488 - Attach host and client system data to recording profiles r=vp,mossop
f73784293c11abb3f2a4e2272d7aa3423d5f9dbe: Bug 1194457 - Rename some perftools tests to match naming scheme of other tests. r=vp
Jordan Santell <jsantell@mozilla.com> - Wed, 09 Sep 2015 15:50:44 -0700 - rev 261682
Push 29354 by cbook@mozilla.com at Fri, 11 Sep 2015 14:29:49 +0000
Bug 1194457 - Rename some perftools tests to match naming scheme of other tests. r=vp
619a307029d6cc27e733b862cc38cbb1fead09ff: Bug 1171488 - Attach host and client system data to recording profiles r=vp,mossop
Jordan Santell <jsantell@mozilla.com> - Tue, 08 Sep 2015 15:24:03 -0700 - rev 261600
Push 29350 by philringnalda@gmail.com at Thu, 10 Sep 2015 20:22:38 +0000
Bug 1171488 - Attach host and client system data to recording profiles r=vp,mossop
8613a4ad3e3ba283fa7cbf3a31ee91178dd37b6e: Bug 1171488 - Attach host and client system data to recording profiles r=vp,mossop
Jordan Santell <jsantell@mozilla.com> - Wed, 26 Aug 2015 14:27:04 -0700 - rev 260372
Push 29308 by ryanvm@gmail.com at Wed, 02 Sep 2015 01:15:13 +0000
Bug 1171488 - Attach host and client system data to recording profiles r=vp,mossop
b22743d8ef64b3206e57807af088a5b843589381: Bug 1198582 - Buffer percentage should never be a negative value. r=vp
Jordan Santell <jsantell@mozilla.com> - Wed, 26 Aug 2015 10:43:49 -0700 - rev 260030
Push 29298 by ryanvm@gmail.com at Mon, 31 Aug 2015 02:09:10 +0000
Bug 1198582 - Buffer percentage should never be a negative value. r=vp
944ac81b4b761ab2ee7a5e7261ce88bcac3be20e: Bug 1144423 - Display bytesize and percentages for both bytesize and counts in the allocations call tree. r=fitzgen,vp
Jordan Santell <jsantell@mozilla.com> - Tue, 25 Aug 2015 22:30:04 -0700 - rev 260029
Push 29298 by ryanvm@gmail.com at Mon, 31 Aug 2015 02:09:10 +0000
Bug 1144423 - Display bytesize and percentages for both bytesize and counts in the allocations call tree. r=fitzgen,vp
87ed59529e01fcf1b695c24949ef3dc41d8b5195: Bug 1153477 - Add a button to GC markers when allocations are on to snapto all objects allocated from this button to the previous one in theallocations call tree. r=vp,fitzgen
Jordan Santell <jsantell@mozilla.com> - Thu, 20 Aug 2015 13:10:47 -0700 - rev 259416
Push 29278 by ryanvm@gmail.com at Thu, 27 Aug 2015 00:28:17 +0000
Bug 1153477 - Add a button to GC markers when allocations are on to snapto all objects allocated from this button to the previous one in theallocations call tree. r=vp,fitzgen
4bbecd76b761941b0745b36740d442b4abec3af5: Bug 1194458 - Calculate bytesize costs per frame for allocations in the performance tools. r=vp,shu
Jordan Santell <jsantell@mozilla.com> - Wed, 19 Aug 2015 18:04:50 -0700 - rev 259415
Push 29278 by ryanvm@gmail.com at Thu, 27 Aug 2015 00:28:17 +0000
Bug 1194458 - Calculate bytesize costs per frame for allocations in the performance tools. r=vp,shu
23f1554d94b84e95711a4e9605e9c8b82b2309f3: Bug 1190594 - Disable memory flame graphs in performance tool. r=vp
Jordan Santell <jsantell@mozilla.com> - Thu, 06 Aug 2015 11:15:51 -0700 - rev 259117
Push 29269 by ryanvm@gmail.com at Tue, 25 Aug 2015 00:57:59 +0000
Bug 1190594 - Disable memory flame graphs in performance tool. r=vp
cebf9a1b7e47f22749a06b433591b5437366223f: Bug 1171517 - Use styling to hide performance graphs rather than the Element.hidden property. r=vp
Jordan Santell <jsantell@mozilla.com> - Sat, 22 Aug 2015 12:55:44 -0700 - rev 259116
Push 29269 by ryanvm@gmail.com at Tue, 25 Aug 2015 00:57:59 +0000
Bug 1171517 - Use styling to hide performance graphs rather than the Element.hidden property. r=vp
7479b25812d1da2420794585653cac97282f92ab: Bug 1197646 - Sort timeline markers when recording is completed, due to GC markers not guaranteeing order. r=vp
Jordan Santell <jsantell@mozilla.com> - Sun, 23 Aug 2015 17:41:33 -0700 - rev 259115
Push 29269 by ryanvm@gmail.com at Tue, 25 Aug 2015 00:57:59 +0000
Bug 1197646 - Sort timeline markers when recording is completed, due to GC markers not guaranteeing order. r=vp
dce78cf37b68d5b9db981806c27c4b8ec8e784a9: Bug 1165994 - Move marker tests to server side, pull out e10s process communication helpers into their own file. r=vp
Jordan Santell <jsantell@mozilla.com> - Wed, 19 Aug 2015 09:49:41 -0700 - rev 258722
Push 29262 by ryanvm@gmail.com at Sun, 23 Aug 2015 19:07:39 +0000
Bug 1165994 - Move marker tests to server side, pull out e10s process communication helpers into their own file. r=vp
f5d2323f5d65378b0b6c1f9e8f6e2cb8c9c64650: Bug 1165994 - Move marker tests to server side, pull out e10s process communication helpers into their own file. r=vp
Jordan Santell <jsantell@mozilla.com> - Wed, 19 Aug 2015 09:49:41 -0700 - rev 258707
Push 29262 by ryanvm@gmail.com at Sun, 23 Aug 2015 19:07:39 +0000
Bug 1165994 - Move marker tests to server side, pull out e10s process communication helpers into their own file. r=vp
cc3c25bf13e2ea026e336e3eab941f18348d8208: Bug 1193023 - Intermittent fix, be more lenient on tick count for framerate actor tests. r=vp
Jordan Santell <jsantell@mozilla.com> - Sun, 16 Aug 2015 14:06:04 -0400 - rev 258012
Push 29240 by kwierso@gmail.com at Mon, 17 Aug 2015 23:54:24 +0000
Bug 1193023 - Intermittent fix, be more lenient on tick count for framerate actor tests. r=vp
00db61e6f388da802c2b8978713fbcda206d9aa1: Bug 1172180 - Create a PerformanceActor, and migrate existing pseudo PerformanceFront to a legacy front. r=vp
Jordan Santell <jsantell@mozilla.com> - Wed, 12 Aug 2015 21:42:54 -0400 - rev 257628
Push 29225 by kwierso@gmail.com at Thu, 13 Aug 2015 23:31:33 +0000
Bug 1172180 - Create a PerformanceActor, and migrate existing pseudo PerformanceFront to a legacy front. r=vp
4e11c910454fcd4fb14ece6a1c7438c8a19ef57e: Bug 1172180 - Create a PerformanceActor, and migrate existing pseudo PerformanceFront to a legacy front. r=vp
Jordan Santell <jsantell@mozilla.com> - Thu, 06 Aug 2015 14:38:45 -0700 - rev 257209
Push 29209 by ryanvm@gmail.com at Tue, 11 Aug 2015 14:52:43 +0000
Bug 1172180 - Create a PerformanceActor, and migrate existing pseudo PerformanceFront to a legacy front. r=vp
f750fa33440ad32be8f309fb551998e0e5da19cd: Bug 1171489 - Do not count ticks in the framerate module from iframes. r=vp
Jordan Santell <jsantell@mozilla.com> - Fri, 07 Aug 2015 19:58:18 -0700 - rev 256997
Push 29198 by philringnalda@gmail.com at Sun, 09 Aug 2015 22:45:16 +0000
Bug 1171489 - Do not count ticks in the framerate module from iframes. r=vp
3301c85aa6713f50caf3c8e63893b7e2904d3945: Bug 1163763 - L10N-ify many strings that didn't make previous uplifts for performance tools, and consolidate strings into one tool rather than profiler and timeline. r=vp
Jordan Santell <jsantell@mozilla.com> - Thu, 16 Jul 2015 13:28:30 -0700 - rev 256153
Push 29170 by cbook@mozilla.com at Wed, 05 Aug 2015 10:55:23 +0000
Bug 1163763 - L10N-ify many strings that didn't make previous uplifts for performance tools, and consolidate strings into one tool rather than profiler and timeline. r=vp
88ecc638d778ef1a1e147fb025a0df03c48d31da: Bug 1172408 - When checking if a marker details element has an action on click, pass in the marker details container so that we don't ascend up to the document, throwing an error. r=vp
Jordan Santell <jsantell@mozilla.com> - Thu, 16 Jul 2015 15:40:23 -0700 - rev 255741
Push 29154 by cbook@mozilla.com at Mon, 03 Aug 2015 11:54:29 +0000
Bug 1172408 - When checking if a marker details element has an action on click, pass in the marker details container so that we don't ascend up to the document, throwing an error. r=vp
8eae214f9f1cfe16681c667104f5cc1d35c3633a: Bug 1172180 - Add polling events for profiler/buffer status on the profiler itself. r=vp
Jordan Santell <jsantell@mozilla.com> - Wed, 15 Jul 2015 15:40:45 -0700 - rev 253567
Push 29070 by ttaubert@mozilla.com at Mon, 20 Jul 2015 07:15:19 +0000
Bug 1172180 - Add polling events for profiler/buffer status on the profiler itself. r=vp
1fc0f98211001235189d328f2c870785eab3a4ab: Bug 1182894 - Add tests for collapsing markers while filtering in the performance tool. r=vp
Jordan Santell <jsantell@mozilla.com> - Tue, 14 Jul 2015 19:23:00 -0400 - rev 253051
Push 29056 by kwierso@gmail.com at Wed, 15 Jul 2015 23:34:03 +0000
Bug 1182894 - Add tests for collapsing markers while filtering in the performance tool. r=vp
d2daa6751884a18868897335f0a3ab563a090212: Bug 1167021 - Pull out calculation cost logic of frame nodes from the view into the model, and add tests for cost calculation and recursion. r=vp
Jordan Santell <jsantell@mozilla.com> - Tue, 14 Jul 2015 14:40:47 -0700 - rev 253003
Push 29053 by ryanvm@gmail.com at Wed, 15 Jul 2015 17:26:05 +0000
Bug 1167021 - Pull out calculation cost logic of frame nodes from the view into the model, and add tests for cost calculation and recursion. r=vp
277d6aaf2ba2ec9012a35374e39e19a635887b1a: Bug 1175760 - Set recording configurations based on UI prefs, but also target support overrides UI prefs. r=vp
Jordan Santell <jsantell@mozilla.com> - Mon, 13 Jul 2015 17:24:24 -0700 - rev 252829
Push 29046 by ryanvm@gmail.com at Wed, 15 Jul 2015 03:26:54 +0000
Bug 1175760 - Set recording configurations based on UI prefs, but also target support overrides UI prefs. r=vp
1beb2b478d0808db24240fa779e3e1dca79d50bd: Bug 1176537 - Change how markers are collapsed to prevent issues for folding in deeply nested markers, and actually fix the other waterfall collapsing tests to actually run. r=vp
Jordan Santell <jsantell@mozilla.com> - Sun, 12 Jul 2015 16:41:22 -0700 - rev 252828
Push 29046 by ryanvm@gmail.com at Wed, 15 Jul 2015 03:26:54 +0000
Bug 1176537 - Change how markers are collapsed to prevent issues for folding in deeply nested markers, and actually fix the other waterfall collapsing tests to actually run. r=vp
d964bc1d6bc206b3a9c6247b34f9751957b17da4: Bug 1159389 - Migrate profiler actor to use new form of protocol.js actors, and become a standalone module consumed by actors. r=vp, r=jryans
Jordan Santell <jsantell@mozilla.com> - Mon, 13 Jul 2015 13:20:00 -0400 - rev 252768
Push 29044 by kwierso@gmail.com at Tue, 14 Jul 2015 22:21:56 +0000
Bug 1159389 - Migrate profiler actor to use new form of protocol.js actors, and become a standalone module consumed by actors. r=vp, r=jryans
d3f0281f73572af565f2f777af91eb43621d3996: Bug 1170035 - Always show protocol version in network monitor. r=vp
Veeti Paananen <veeti.paananen@rojekti.fi> - Tue, 02 Jun 2015 02:30:00 -0400 - rev 250222
Push 28950 by cbook@mozilla.com at Fri, 26 Jun 2015 09:54:25 +0000
Bug 1170035 - Always show protocol version in network monitor. r=vp
95dc0052f4102c241163005987b8616964941a4c: Bug 1150295 - Display an icon next to frames in the call tree that contain viewable optimization data. r=vp,a=kwierso
Jordan Santell <jsantell@mozilla.com> - Wed, 17 Jun 2015 14:31:15 -0700 - rev 249824
Push 28939 by cbook@mozilla.com at Mon, 22 Jun 2015 11:56:54 +0000
Bug 1150295 - Display an icon next to frames in the call tree that contain viewable optimization data. r=vp,a=kwierso
c3100b5ccfe8252ee54da48763b37711aadd8bb1: Bug 1175650 - skeleton view for JIT Optimizations in the performance tool. r=vp,a=kwierso
Jordan Santell <jsantell@mozilla.com> - Thu, 18 Jun 2015 12:59:46 -0700 - rev 249820
Push 28939 by cbook@mozilla.com at Mon, 22 Jun 2015 11:56:54 +0000
Bug 1175650 - skeleton view for JIT Optimizations in the performance tool. r=vp,a=kwierso
2fe76a95986b4472652595435cab1d37262c8a95: Bug 1175650 - skeleton view for JIT Optimizations in the performance tool. r=vp
Jordan Santell <jsantell@mozilla.com> - Thu, 18 Jun 2015 12:59:46 -0700 - rev 249819
Push 28939 by cbook@mozilla.com at Mon, 22 Jun 2015 11:56:54 +0000
Bug 1175650 - skeleton view for JIT Optimizations in the performance tool. r=vp
844efb38a131a2a7320c8f837413a69302c9c4fb: Bug 1174829 - Remove vestigial PerformanceActorsConnection references in comments. r=vp
Jordan Santell <jsantell@mozilla.com> - Mon, 15 Jun 2015 11:38:39 -0700 - rev 249433
Push 28926 by cbook@mozilla.com at Thu, 18 Jun 2015 13:09:03 +0000
Bug 1174829 - Remove vestigial PerformanceActorsConnection references in comments. r=vp
10f378449181ccfe93c953089cd0a1caf19d92b1: Bug 1173695 - When extra threads are in a profile of a nested profile, stringified, handle that gracefully for older recordings. r=vp
Jordan Santell <jsantell@mozilla.com> - Thu, 11 Jun 2015 18:45:21 -0700 - rev 249432
Push 28926 by cbook@mozilla.com at Thu, 18 Jun 2015 13:09:03 +0000
Bug 1173695 - When extra threads are in a profile of a nested profile, stringified, handle that gracefully for older recordings. r=vp
d479c310b3d4fa0e0d894e1550d89a3db6874f77: Bug 1175705 - Make enable-jit-optimizations a recording-feature rather than a toggleable display feature. r=vp
Jordan Santell <jsantell@mozilla.com> - Wed, 17 Jun 2015 14:57:45 -0700 - rev 249431
Push 28926 by cbook@mozilla.com at Thu, 18 Jun 2015 13:09:03 +0000
Bug 1175705 - Make enable-jit-optimizations a recording-feature rather than a toggleable display feature. r=vp
99f99d774fa3cea30621c7337b55624448498b94: Bug 1171821 - Children markers should not be hidden when filtering out their parent markers. r=vp
Jordan Santell <jsantell@mozilla.com> - Tue, 09 Jun 2015 15:36:52 -0700 - rev 248904
Push 28910 by kwierso@gmail.com at Tue, 16 Jun 2015 00:49:24 +0000
Bug 1171821 - Children markers should not be hidden when filtering out their parent markers. r=vp
e4738a23d0c488a38e2eee42b7df46e221055ed7: Bug 1152992 - If markers do not have a definition, classify them as "Unknown" in the perftools. r=vp
Jordan Santell <jsantell@mozilla.com> - Tue, 09 Jun 2015 20:34:51 -0700 - rev 248831
Push 28908 by ryanvm@gmail.com at Mon, 15 Jun 2015 19:49:26 +0000
Bug 1152992 - If markers do not have a definition, classify them as "Unknown" in the perftools. r=vp
3d3972877fbb3252d110ba45693d58f603a32b25: Bug 1173393 - Detail views in Performance should be unique EventTargets and not bleed events between each other. r=vp
Jordan Santell <jsantell@mozilla.com> - Wed, 10 Jun 2015 10:27:54 -0700 - rev 248130
Push 28892 by cbook@mozilla.com at Thu, 11 Jun 2015 12:41:51 +0000
Bug 1173393 - Detail views in Performance should be unique EventTargets and not bleed events between each other. r=vp
ea7e872d6e4c5803ea9070990201732f232361ce: Bug 1172182 part 2: correctly link to the memory module via timeline actor. r=vp
Jordan Santell <jsantell@mozilla.com> - Tue, 09 Jun 2015 22:31:19 -0700 - rev 247976
Push 28887 by kwierso@gmail.com at Thu, 11 Jun 2015 01:10:53 +0000
Bug 1172182 part 2: correctly link to the memory module via timeline actor. r=vp
65d973f2bbdf16df3614321217c7a71c7aa74c95: Bug 1169146 - Clearing recordings while a recording is in progress now correctly sets the state of the recording buttons. r=vp
Jordan Santell <jsantell@mozilla.com> - Tue, 09 Jun 2015 18:24:46 -0700 - rev 247975
Push 28887 by kwierso@gmail.com at Thu, 11 Jun 2015 01:10:53 +0000
Bug 1169146 - Clearing recordings while a recording is in progress now correctly sets the state of the recording buttons. r=vp