searching for reviewer(tnikkel)
40d9553a84b9253e3fee8e60e994da3c70d66228: Bug 1783500 - Account for input region margins when anchoring to a large rect. r=tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 10 Aug 2022 10:46:22 +0000 - rev 626655
Push 40109 by nbeleuzu@mozilla.com at Wed, 10 Aug 2022 15:45:33 +0000
Bug 1783500 - Account for input region margins when anchoring to a large rect. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D154074
fc1e55745c43ef00123caaf70c91e324c0068039: Bug 1783500 - Account for negative popup margins when anchoring to a large rect. r=tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 09 Aug 2022 10:42:39 +0000 - rev 626527
Push 40105 by smolnar@mozilla.com at Tue, 09 Aug 2022 21:31:27 +0000
Bug 1783500 - Account for negative popup margins when anchoring to a large rect. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D154074
558de1255ee53b6c068ebeadda2289b07d853d7b: Bug 1783500 - Remove pointlessly-virtual method. r=tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 09 Aug 2022 10:31:52 +0000 - rev 626526
Push 40105 by smolnar@mozilla.com at Tue, 09 Aug 2022 21:31:27 +0000
Bug 1783500 - Remove pointlessly-virtual method. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D154075
c281f844bed576c492ab052805f9644eb0a262a2: Bug 1781962 - A simple test case for swipe-to-navigation on RTL. r=tnikkel
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Tue, 09 Aug 2022 02:01:37 +0000 - rev 626486
Push 40103 by bszekely@mozilla.com at Tue, 09 Aug 2022 09:33:38 +0000
Bug 1781962 - A simple test case for swipe-to-navigation on RTL. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D153902
065a34bf58c25ca46748560154d27dbe37f7a979: Bug 1776795 - Move the swipe-to-nav icon in response to the swipe gestures on Windows. r=tnikkel,desktop-theme-reviewers,sfoster
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Tue, 02 Aug 2022 23:08:46 +0000 - rev 625825
Push 40074 by ccozmuta@mozilla.com at Wed, 03 Aug 2022 03:42:48 +0000
Bug 1776795 - Move the swipe-to-nav icon in response to the swipe gestures on Windows. r=tnikkel,desktop-theme-reviewers,sfoster Both Chrome and Edge on Windows also move the swipe-to-nav arrow icon, the distance of move seems to be a fixed value, it doesn't depend on the browser window size. So we also use a fixed value, 100px here. Chrome on Mac also moves the icon, but in a slightly different way. The icon is a semicircle shape, it never leaves the edge of the browser window even if it's moving during swipe gestures. So we introduce a new preference named "browser.swipe.navigation-icon-move-distance" to implement platform dependent swipe-to-nav icon behaviors. As of now the value on platforms other than Windows is zero so that the icon never moves on the platforms. Depends on D152951 Differential Revision: https://phabricator.services.mozilla.com/D150433
573e1fde234ccd0d82bf7f25f4fac0e2ba59650d: Bug 1776795 - Fix the swipe-to-nav icon position on RTL environments. r=desktop-theme-reviewers,tnikkel,Itiel
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Tue, 02 Aug 2022 23:08:45 +0000 - rev 625824
Push 40074 by ccozmuta@mozilla.com at Wed, 03 Aug 2022 03:42:48 +0000
Bug 1776795 - Fix the swipe-to-nav icon position on RTL environments. r=desktop-theme-reviewers,tnikkel,Itiel Differential Revision: https://phabricator.services.mozilla.com/D152951
7bed4509ae7c902b6339752ac6328f50729069ae: Bug 1776795 - Move the swipe-to-nav icon in response to the swipe gestures on Windows. r=tnikkel,desktop-theme-reviewers,sfoster
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Tue, 02 Aug 2022 06:49:55 +0000 - rev 625696
Push 40070 by nfay@mozilla.com at Tue, 02 Aug 2022 09:41:16 +0000
Bug 1776795 - Move the swipe-to-nav icon in response to the swipe gestures on Windows. r=tnikkel,desktop-theme-reviewers,sfoster Both Chrome and Edge on Windows also move the swipe-to-nav arrow icon, the distance of move seems to be a fixed value, it doesn't depend on the browser window size. So we also use a fixed value, 100px here. Chrome on Mac also moves the icon, but in a slightly different way. The icon is a semicircle shape, it never leaves the edge of the browser window even if it's moving during swipe gestures. So we introduce a new preference named "browser.swipe.navigation-icon-move-distance" to implement platform dependent swipe-to-nav icon behaviors. As of now the value on platforms other than Windows is zero so that the icon never moves on the platforms. Differential Revision: https://phabricator.services.mozilla.com/D150433
344336b549397aa5fa2a8e3b2862adf3400c8718: Bug 1776795 - Fix the swipe-to-nav icon position on RTL environments. r=desktop-theme-reviewers,tnikkel,Itiel
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Tue, 02 Aug 2022 06:49:55 +0000 - rev 625695
Push 40070 by nfay@mozilla.com at Tue, 02 Aug 2022 09:41:16 +0000
Bug 1776795 - Fix the swipe-to-nav icon position on RTL environments. r=desktop-theme-reviewers,tnikkel,Itiel Differential Revision: https://phabricator.services.mozilla.com/D152951
29943068938aa9e94955dbe13c2e4c254553e4ce: Bug 1779953 - Ensure MaybeRecordFrame is called before EndFrame. r=tnikkel
Lee Salzman <lsalzman@mozilla.com> - Wed, 20 Jul 2022 16:55:20 +0000 - rev 624551
Push 40008 by csabou@mozilla.com at Thu, 21 Jul 2022 03:47:38 +0000
Bug 1779953 - Ensure MaybeRecordFrame is called before EndFrame. r=tnikkel If MaybeRecordFrame is called after EndFrame, this means we are reading from the back buffer state immediately after a call to SwapBuffers. The state of the back buffer is undefined in that scenario, and mostly was just returning old frames. We actually want to call MaybeRecordFrame before EndFrame, so we get the valid contents of the back buffer before it is swapped out. Differential Revision: https://phabricator.services.mozilla.com/D151988
ae48bad81e775d4ee0632c3bad506983c5fa9b97: Bug 1779602 - Remove nsImageGeometryMixin. r=tnikkel
Jeff Muizelaar <jmuizelaar@mozilla.com> - Mon, 18 Jul 2022 21:20:50 +0000 - rev 624309
Push 40001 by abutkovits@mozilla.com at Tue, 19 Jul 2022 09:34:24 +0000
Bug 1779602 - Remove nsImageGeometryMixin. r=tnikkel nsImageGeometryMixin was disabled in bug 1776198. No problems have shown up so let's get rid of it. Differential Revision: https://phabricator.services.mozilla.com/D151864
bdd81e931a8fef981f103607fa0d78b8a4cdb61d: Bug 1777324 - Move reftest README to firefox source documentation. r=tnikkel
Dan Robertson <drobertson@mozilla.com> - Fri, 15 Jul 2022 21:40:22 +0000 - rev 624214
Push 39991 by nfay@mozilla.com at Sat, 16 Jul 2022 09:20:56 +0000
Bug 1777324 - Move reftest README to firefox source documentation. r=tnikkel Move the README for the layout reftests to the firefox source documentation. Differential Revision: https://phabricator.services.mozilla.com/D150630
937db60c3c63934fafc8e2d89ed83481f45a4913: Bug 1771822 - Follow-up simplifications to DisplayPortUtils functions. r=tnikkel
Botond Ballo <botond@mozilla.com> - Thu, 14 Jul 2022 18:39:34 +0000 - rev 624045
Push 39985 by ctuns@mozilla.com at Fri, 15 Jul 2022 03:58:18 +0000
Bug 1771822 - Follow-up simplifications to DisplayPortUtils functions. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D151798
f41c9ad861cd753f446e23d3d83870c0e16da500: Bug 1771822 - Remove the layers.low-precision-{buffer,resolution} prefs. r=tnikkel
Botond Ballo <botond@mozilla.com> - Thu, 14 Jul 2022 18:39:33 +0000 - rev 624044
Push 39985 by ctuns@mozilla.com at Fri, 15 Jul 2022 03:58:18 +0000
Bug 1771822 - Remove the layers.low-precision-{buffer,resolution} prefs. r=tnikkel These are no longer used. Depends on D151796 Differential Revision: https://phabricator.services.mozilla.com/D151797
af7f68944b4f95187f0e2df14b00f747ccdb9d51: Bug 1771822 - Remove the apz.minimap.enabled pref. r=tnikkel
Botond Ballo <botond@mozilla.com> - Thu, 14 Jul 2022 18:39:33 +0000 - rev 624043
Push 39985 by ctuns@mozilla.com at Fri, 15 Jul 2022 03:58:18 +0000
Bug 1771822 - Remove the apz.minimap.enabled pref. r=tnikkel It's currently unused. Depends on D151795 Differential Revision: https://phabricator.services.mozilla.com/D151796
b0c7abb73386b8af16ea03adc2fdae76a6e34bba: Bug 1771822 - Do not explicitly set some other prefs, which are now always enabled, in tests. r=tnikkel
Botond Ballo <botond@mozilla.com> - Thu, 14 Jul 2022 18:39:32 +0000 - rev 624042
Push 39985 by ctuns@mozilla.com at Fri, 15 Jul 2022 03:58:18 +0000
Bug 1771822 - Do not explicitly set some other prefs, which are now always enabled, in tests. r=tnikkel The prefs handled in this patch are: apz.paint_skipping.enabled apz.force_disable_desktop_zooming_scrollbars apz.mac.enable_double_tap_zoom_touchpad_gesture dom.event.default_to_passive_touch_listeners dom.visualviewport.enabled (one use left over) Differential Revision: https://phabricator.services.mozilla.com/D151795
324b78cf12d8ba00e299b2f8766cc8f40f27cd75: Bug 1778718 - Make filter/backdrop-filter wrapping work when ignoring a scroll frame. r=tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 12 Jul 2022 09:46:01 +0000 - rev 623622
Push 39972 by imoraru@mozilla.com at Tue, 12 Jul 2022 21:56:41 +0000
Bug 1778718 - Make filter/backdrop-filter wrapping work when ignoring a scroll frame. r=tnikkel Factor the code to build the top layer and wrapping for filters into a common function. Differential Revision: https://phabricator.services.mozilla.com/D151475
448330c1255aac494b8be682f6d1cd9de40bba61: Bug 1778718 - Make filters on the root work when using fallback drawing. r=tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 12 Jul 2022 09:46:01 +0000 - rev 623621
Push 39972 by imoraru@mozilla.com at Tue, 12 Jul 2022 21:56:41 +0000
Bug 1778718 - Make filters on the root work when using fallback drawing. r=tnikkel This code-path will be hit with the next patch. Depends on D151473 Differential Revision: https://phabricator.services.mozilla.com/D151474
0a598b1533e6794061a605e91655cad88c8ab4c9: Bug 1771822 - Do not explicitly set apz.allow_zooming in mochitests. r=tnikkel
Botond Ballo <botond@mozilla.com> - Tue, 12 Jul 2022 06:49:11 +0000 - rev 623600
Push 39972 by imoraru@mozilla.com at Tue, 12 Jul 2022 21:56:41 +0000
Bug 1771822 - Do not explicitly set apz.allow_zooming in mochitests. r=tnikkel We can't do likewise for reftests and web platform tests because those test suites disable apz.allow_zooming by default on android. Differential Revision: https://phabricator.services.mozilla.com/D151576
23f4c9e279743ee87472215198e3b6cc6e19a8c9: Bug 1778718 - Clean-up some scroll frame DL building code. r=tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 11 Jul 2022 20:18:35 +0000 - rev 623545
Push 39968 by abutkovits@mozilla.com at Tue, 12 Jul 2022 04:20:08 +0000
Bug 1778718 - Clean-up some scroll frame DL building code. r=tnikkel This doesn't change behavior but makes the next patch simpler, and makes the ignore-scrollframe and non-ignore-scrollframe code-paths match. Differential Revision: https://phabricator.services.mozilla.com/D151473
5f662264782ddbf021c5f15099c4fd8c9ce3b33b: Bug 1682621, the command event can supply an input source so provide it in PendingPopup::MouseInputSource so that it is available during the popupshowing event, r=tnikkel
Neil Deakin <neil@mozilla.com> - Sun, 03 Jul 2022 09:44:39 +0000 - rev 622861
Push 39931 by nfay@mozilla.com at Sun, 03 Jul 2022 21:37:09 +0000
Bug 1682621, the command event can supply an input source so provide it in PendingPopup::MouseInputSource so that it is available during the popupshowing event, r=tnikkel This is to fix the test failure in browser_menu_touch.js. Differential Revision: https://phabricator.services.mozilla.com/D150805
8a9d64524b788b6b5ededc0259c7a6df1ecd167e: Bug 1682621, set input source to MOZ_SOURCE_KEYBOARD for command events on buttons, r=tnikkel
Neil Deakin <neil@mozilla.com> - Sun, 03 Jul 2022 09:44:38 +0000 - rev 622859
Push 39931 by nfay@mozilla.com at Sun, 03 Jul 2022 21:37:09 +0000
Bug 1682621, set input source to MOZ_SOURCE_KEYBOARD for command events on buttons, r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D149284
e32910a4948b822f63865daef2d018a1a2813e3a: Bug 1682621, set input source to MOZ_SOURCE_KEYBOARD for command events on buttons, r=tnikkel
Neil Deakin <neil@mozilla.com> - Wed, 29 Jun 2022 12:38:30 +0000 - rev 622556
Push 39916 by ccozmuta@mozilla.com at Wed, 29 Jun 2022 21:58:21 +0000
Bug 1682621, set input source to MOZ_SOURCE_KEYBOARD for command events on buttons, r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D149284
782fd4871c5f10baa965e2d8ed13281dfb81dab9: Bug 1682621, set input source to MOZ_SOURCE_KEYBOARD for command events on buttons, r=tnikkel
Neil Deakin <neil@mozilla.com> - Tue, 28 Jun 2022 16:02:37 +0000 - rev 622355
Push 39912 by mlaza@mozilla.com at Wed, 29 Jun 2022 03:44:30 +0000
Bug 1682621, set input source to MOZ_SOURCE_KEYBOARD for command events on buttons, r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D149284
5cb5a9657445285e3b37f7708408d0c2117a3a1c: Bug 1776778: Make reftest harness log & fail gracefully when its drawSnapshot() call fails. r=tnikkel
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 28 Jun 2022 01:21:21 +0000 - rev 622255
Push 39910 by bszekely@mozilla.com at Tue, 28 Jun 2022 09:16:40 +0000
Bug 1776778: Make reftest harness log & fail gracefully when its drawSnapshot() call fails. r=tnikkel This is just touching reftest.jsm, so this doesn't impact users at all. I'm using the same approach we use for other similar failure conditions in this file (logging and incrementing the exception count), cribbing from e.g. https://searchfox.org/mozilla-central/rev/5b2d2863bd315f232a3f769f76e0eb16cdca7cb0/layout/tools/reftest/reftest.jsm#1229-1231 https://searchfox.org/mozilla-central/rev/5b2d2863bd315f232a3f769f76e0eb16cdca7cb0/layout/tools/reftest/reftest.jsm#985-986 I confirmed in a try run that this does turn the reftest harness orange (with REFTEST ERROR logging) if I force the drawSnapshot call to fail and trigger the codepath that I'm adding here. Differential Revision: https://phabricator.services.mozilla.com/D150436
ec0bd8f37b9abfd2d0ac7c22a7ef5cbfb7323980: Bug 1776530 - Assert that APZUpdater::RunOnUpdaterThread() is not called directly from the updater thread. r=tnikkel
Botond Ballo <botond@mozilla.com> - Sat, 25 Jun 2022 04:33:51 +0000 - rev 622088
Push 39897 by ncsoregi@mozilla.com at Sat, 25 Jun 2022 09:53:34 +0000
Bug 1776530 - Assert that APZUpdater::RunOnUpdaterThread() is not called directly from the updater thread. r=tnikkel With the exception of the egde case scenarios in which IsConnectedToWebRender() returns false. Also add a comment warning that if RunOnUpdaterThread() were to be called directly from the updater thread when connected to WebRender, the implementation would be incorrect. Differential Revision: https://phabricator.services.mozilla.com/D150309
6f6fcfd3c0f5781ab9a52f0bb11d20a476cd2d57: Bug 1776530 - Rename APZUpdater::UsingWebRenderUpdaterThread() to IsConnectedToWebRender(). r=tnikkel
Botond Ballo <botond@mozilla.com> - Sat, 25 Jun 2022 04:33:51 +0000 - rev 622087
Push 39897 by ncsoregi@mozilla.com at Sat, 25 Jun 2022 09:53:34 +0000
Bug 1776530 - Rename APZUpdater::UsingWebRenderUpdaterThread() to IsConnectedToWebRender(). r=tnikkel The earlier name dates back to a time when we could use WebRender but not necessarily use a WebRender thread as the updater thread. Also add a comment to list the remaining situatins in which this function can return false. Differential Revision: https://phabricator.services.mozilla.com/D150308
7e39a8bcbbb2068bf6a605676904be3fdb1b0654: Bug 1539730 - Implement swipe-to-nav back/forward in history on Linux. r=tnikkel
Jonathan Watt <jwatt@jwatt.org> - Wed, 22 Jun 2022 22:08:38 +0000 - rev 621829
Push 39885 by nfay@mozilla.com at Thu, 23 Jun 2022 03:54:50 +0000
Bug 1539730 - Implement swipe-to-nav back/forward in history on Linux. r=tnikkel Ideally we'd use GDK_TOUCHPAD_SWIPE/GdkEventTouchpadSwipe (GTK's native events) for this for the best compatibility with the the platform/other apps. Unfortunately that seems complicated, so for now we use our SwipeTracker code and make our own determination of what counts as a swipe. Note that the pref widget.swipe.whole-page-pixel-size can be used to tweak the swipe sensitivity. Differential Revision: https://phabricator.services.mozilla.com/D149512
5db9af7d249e82df382a5f6357bdb6a380ca0b6d: Bug 1772640 - Use NSCoordSaturatingMultiply to avoid overflowing nscoord. r=tnikkel
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Wed, 22 Jun 2022 01:30:29 +0000 - rev 621637
Push 39882 by bszekely@mozilla.com at Wed, 22 Jun 2022 09:43:42 +0000
Bug 1772640 - Use NSCoordSaturatingMultiply to avoid overflowing nscoord. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D149838
91fe1def0df92a7e5072f44d04f2530713e103f5: Bug 1764585 - Wait for some pref changes to take effect. r=tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 20 Jun 2022 13:57:09 +0000 - rev 621433
Push 39874 by csabou@mozilla.com at Mon, 20 Jun 2022 21:49:56 +0000
Bug 1764585 - Wait for some pref changes to take effect. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D149745
a26122221a5fed88d9b8286fbbbaad02b797169a: Bug 1771503 - Disable the 'two layers that scroll together' assertion for matrices with Inf or NaN elements. r=tnikkel
Botond Ballo <botond@mozilla.com> - Fri, 17 Jun 2022 23:50:49 +0000 - rev 621373
Push 39865 by smolnar@mozilla.com at Sat, 18 Jun 2022 09:30:37 +0000
Bug 1771503 - Disable the 'two layers that scroll together' assertion for matrices with Inf or NaN elements. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D149466
241220a4282111ca5639254ce8b63efba18d50d5: Bug 1774511 - Use more typed units in AppWindow. r=tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 16 Jun 2022 05:03:04 +0000 - rev 621077
Push 39858 by bszekely@mozilla.com at Thu, 16 Jun 2022 09:30:51 +0000
Bug 1774511 - Use more typed units in AppWindow. r=tnikkel Doesn't change behavior but hopefully makes code easier to follow / prove correct. Differential Revision: https://phabricator.services.mozilla.com/D149462
32f6c59157f35415243d6563003ef235b8a98d92: Bug 1774408 - Don't use widget scale in AppWindow. r=tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 15 Jun 2022 23:42:37 +0000 - rev 621060
Push 39858 by bszekely@mozilla.com at Thu, 16 Jun 2022 09:30:51 +0000
Bug 1774408 - Don't use widget scale in AppWindow. r=tnikkel This does fix the Pre-XUL skeleton UI scaling for me, but the others are harmless and I can't repro the bug as described. I _guess_ this can happen if you have window borders on Windows, since we were mishandling those? But I don't know how to get those on Win10+. The other scalings are symmetrical so they ended up working out in the end. In any case this is the right thing to do and I'm ~sure it will fix the bug in the reporter's configuration. Differential Revision: https://phabricator.services.mozilla.com/D149449
b616eb2e52eaa4d6d6f9fdd911bee0008f11d072: Bug 1773813 - Test. r=tnikkel,pip-reviewers,mconley
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 15 Jun 2022 08:17:59 +0000 - rev 620938
Push 39854 by imoraru@mozilla.com at Wed, 15 Jun 2022 15:46:59 +0000
Bug 1773813 - Test. r=tnikkel,pip-reviewers,mconley Differential Revision: https://phabricator.services.mozilla.com/D149233
d9bf7a44ab1c54125f36a7335b5a028cc89c8025: Bug 1773256 - Use ProjectPoint when transforming coordinates from parent to child in BrowserParent. r=tnikkel
Botond Ballo <botond@mozilla.com> - Wed, 15 Jun 2022 05:29:52 +0000 - rev 620925
Push 39853 by bszekely@mozilla.com at Wed, 15 Jun 2022 09:37:00 +0000
Bug 1773256 - Use ProjectPoint when transforming coordinates from parent to child in BrowserParent. r=tnikkel This patch also backs out the incorrect fix for bug 1745834 (see comment 12 on the bug for an explanation). Differential Revision: https://phabricator.services.mozilla.com/D149321
33fd5efbb2a8ded2b5639b6ffcf625d8b20cf01a: Bug 1773813 - Incorporate OS zoom factor in window sizing calculations. r=tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 14 Jun 2022 15:01:52 +0000 - rev 620868
Push 39850 by ctuns@mozilla.com at Tue, 14 Jun 2022 21:37:29 +0000
Bug 1773813 - Incorporate OS zoom factor in window sizing calculations. r=tnikkel In bug 1773342 I made OS text scale factor behave like a full zoom factor which applies to all pages (including the browser chrome). That's generally straight forward but it makes some callsites that use unzoomed CSS coordinates misbehave (or behave correctly accidentally actually in some other cases). The main fix here is making nsIBaseWindow::UnscaledDevicePixelsPerCSSPixel() and nsIScreen::GetDefaultCSSScaleFactor() account for OS zoom as necessary. However, I also went through the relevant code and cleaned it up to use typed units and operations when possible. The setup means: * nsIWidget::GetDefaultScale() doesn't account for OS full zoom. * nsIBaseWindow and nsIScreen does. These are the places where this should matter and stuff can get confused, but this works surprisingly well for all callers (except one nsDeviceContext one which we use only for PuppetWidget and we can remove by falling back to 1.0 like all other widgets until the update comes). Differential Revision: https://phabricator.services.mozilla.com/D149033
da5c711906738cdf67223f50a77d4276eb13c2d3: Bug 1773813 - Incorporate OS zoom factor in window sizing calculations. r=tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 14 Jun 2022 11:37:25 +0000 - rev 620832
Push 39850 by ctuns@mozilla.com at Tue, 14 Jun 2022 21:37:29 +0000
Bug 1773813 - Incorporate OS zoom factor in window sizing calculations. r=tnikkel In bug 1773342 I made OS text scale factor behave like a full zoom factor which applies to all pages (including the browser chrome). That's generally straight forward but it makes some callsites that use unzoomed CSS coordinates misbehave (or behave correctly accidentally actually in some other cases). The main fix here is making nsIBaseWindow::UnscaledDevicePixelsPerCSSPixel() and nsIScreen::GetDefaultCSSScaleFactor() account for OS zoom as necessary. However, I also went through the relevant code and cleaned it up to use typed units and operations when possible. The setup means: * nsIWidget::GetDefaultScale() doesn't account for OS full zoom. * nsIBaseWindow and nsIScreen does. These are the places where this should matter and stuff can get confused, but this works surprisingly well for all callers (except one nsDeviceContext one which we use only for PuppetWidget and we can remove by falling back to 1.0 like all other widgets until the update comes). Differential Revision: https://phabricator.services.mozilla.com/D149033
6fdfef57e6d74759ed9041d212979dac2bf0dd6e: Bug 1773633 - Allow configuring OS zoom behavior. r=tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 13 Jun 2022 11:38:43 +0000 - rev 620707
Push 39841 by ctuns@mozilla.com at Mon, 13 Jun 2022 15:12:39 +0000
Bug 1773633 - Allow configuring OS zoom behavior. r=tnikkel This is reasonably straight-forward and should allow us change the desired behavior on platforms if / when we need. Also, this adds tests for the feature by using the relevant float pref (though we can't easily assert the full-zoom behavior because it changes the size of the reftest window itself). Differential Revision: https://phabricator.services.mozilla.com/D148902
348eb31da96b3473b0705e17b23538f2a40b2d96: Bug 1773811 - Fix APZ autoscroll coordinates. r=tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 13 Jun 2022 00:54:33 +0000 - rev 620623
Push 39839 by ctuns@mozilla.com at Mon, 13 Jun 2022 09:46:41 +0000
Bug 1773811 - Fix APZ autoscroll coordinates. r=tnikkel In bug 1773342, I made OS text zoom behave like layout full zoom on all pages (including the main browser page). This means that getting CSS pixels from the browser page and turning them to LayoutDevice pixels by multiplying by GetDefaultScale() isn't right. However, the caller already has the right device pixel values, so just use them. Differential Revision: https://phabricator.services.mozilla.com/D149026
5df8a7315ddbf4e514b424b79190f160ef6daea3: Bug 1773633 - Allow configuring OS zoom behavior. r=tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 13 Jun 2022 00:05:00 +0000 - rev 620622
Push 39839 by ctuns@mozilla.com at Mon, 13 Jun 2022 09:46:41 +0000
Bug 1773633 - Allow configuring OS zoom behavior. r=tnikkel This is reasonably straight-forward and should allow us change the desired behavior on platforms if / when we need. Also, this adds tests for the feature by using the relevant float pref (though we can't easily assert the full-zoom behavior because it changes the size of the reftest window itself). Differential Revision: https://phabricator.services.mozilla.com/D148902
b30d8e1d397517a2266a8aa5bbf2ec8fafdd72e2: Bug 1772561 - Do not call RDLUtils::AssertDisplayItemUnmodified() in opt builds r=tnikkel
Miko Mynttinen <mikokm@gmail.com> - Mon, 06 Jun 2022 22:32:19 +0000 - rev 619836
Push 39807 by abutkovits@mozilla.com at Tue, 07 Jun 2022 04:23:49 +0000
Bug 1772561 - Do not call RDLUtils::AssertDisplayItemUnmodified() in opt builds r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D148272
a6d9ec5a481ed79a135ba4bb5811222b49a97167: Bug 1771822 - Do not explicitly set dom.visualviewport.enabled in tests. r=tnikkel
Botond Ballo <botond@mozilla.com> - Thu, 02 Jun 2022 22:57:56 +0000 - rev 619618
Push 39788 by nfay@mozilla.com at Fri, 03 Jun 2022 03:41:38 +0000
Bug 1771822 - Do not explicitly set dom.visualviewport.enabled in tests. r=tnikkel This pref is now enabled by default on all platforms. Depends on D147810 Differential Revision: https://phabricator.services.mozilla.com/D147811
493bb853cb56c51373615a13c8207c52abfb020b: Bug 1771822 - Remove the browser.chrome.dynamictoolbar pref. r=tnikkel,perftest-reviewers,AlexandruIonescu
Botond Ballo <botond@mozilla.com> - Thu, 02 Jun 2022 22:57:56 +0000 - rev 619617
Push 39788 by nfay@mozilla.com at Fri, 03 Jun 2022 03:41:38 +0000
Bug 1771822 - Remove the browser.chrome.dynamictoolbar pref. r=tnikkel,perftest-reviewers,AlexandruIonescu This pref is left over from a previous dynamic toolbar implementation, and no one was reading its value. Differential Revision: https://phabricator.services.mozilla.com/D147810
e09e890938a500af93baebeb130af8315cd875d6: Bug 1771929 - Add methods to copy nsDisplayList and nsDisplayListSet r=tnikkel
Miko Mynttinen <mikokm@gmail.com> - Wed, 01 Jun 2022 15:37:12 +0000 - rev 619427
Push 39783 by apavel@mozilla.com at Wed, 01 Jun 2022 21:31:38 +0000
Bug 1771929 - Add methods to copy nsDisplayList and nsDisplayListSet r=tnikkel Also adds nsDisplayListSet::IsEmpty() and moves the list pointers in an array. Differential Revision: https://phabricator.services.mozilla.com/D147765
288ec82161d2944bfd1983575458242c148aa49c: Bug 1771754 - Improve display list logging r=tnikkel
Miko Mynttinen <mikokm@gmail.com> - Tue, 31 May 2022 15:45:31 +0000 - rev 619322
Push 39777 by smolnar@mozilla.com at Tue, 31 May 2022 21:47:21 +0000
Bug 1771754 - Improve display list logging r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D147665
b4f7e56bdfbb367e6e7be4a9f63d13e7143dfbaf: Bug 1771754 - Improve display list logging r=tnikkel
Miko Mynttinen <mikokm@gmail.com> - Tue, 31 May 2022 12:46:22 +0000 - rev 619300
Push 39777 by smolnar@mozilla.com at Tue, 31 May 2022 21:47:21 +0000
Bug 1771754 - Improve display list logging r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D147665
785cba38f1eeb3878e4605101982c20884fb0927: Bug 1766650 - Store modified frames in display root frame RetainedDisplayListBuilder r=tnikkel
Miko Mynttinen <mikokm@gmail.com> - Mon, 30 May 2022 14:20:58 +0000 - rev 619161
Push 39773 by ccozmuta@mozilla.com at Tue, 31 May 2022 04:09:28 +0000
Bug 1766650 - Store modified frames in display root frame RetainedDisplayListBuilder r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D144889
481c50c1fa9c0770db9a55ce0199480189972ca6: Bug 1769559 - Remove invalid assertion. r=tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 30 May 2022 09:32:02 +0000 - rev 619141
Push 39773 by ccozmuta@mozilla.com at Tue, 31 May 2022 04:09:28 +0000
Bug 1769559 - Remove invalid assertion. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D147631
a2633b4ffc953ea8210121d183df76cbdfd48288: Bug 1770619 - Identify the async zoom container in the WebRenderScrollData dump. r=tnikkel
Botond Ballo <botond@mozilla.com> - Sat, 28 May 2022 21:55:54 +0000 - rev 619124
Push 39764 by ccozmuta@mozilla.com at Sun, 29 May 2022 09:03:10 +0000
Bug 1770619 - Identify the async zoom container in the WebRenderScrollData dump. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D147571
5a92f4c222d23d4a00c2b1dab42550ad44f154b3: Bug 1770619 - In the content-side WebRenderScrollData dump, include the display item from which a WebRenderLayerScrollData node was created. r=tnikkel
Botond Ballo <botond@mozilla.com> - Sat, 28 May 2022 21:55:54 +0000 - rev 619123
Push 39764 by ccozmuta@mozilla.com at Sun, 29 May 2022 09:03:10 +0000
Bug 1770619 - In the content-side WebRenderScrollData dump, include the display item from which a WebRenderLayerScrollData node was created. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D147009
2f3bfb5941625d46cc18ee69b03d05dbd407218b: Bug 1769953 - Only force tile cache slice for root scroll bar. r=tnikkel
Glenn Watson <git@intuitionlibrary.com> - Thu, 26 May 2022 03:30:50 +0000 - rev 618917
Push 39751 by smolnar@mozilla.com at Thu, 26 May 2022 15:51:59 +0000
Bug 1769953 - Only force tile cache slice for root scroll bar. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D147370