searching for reviewer(tnikkel)
61e4c760f34148d16047975c124b6f79635603fa: Bug 1678560 - Avoid including nsILoadGroup.h in header files. r=tnikkel
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:12:44 +0000 - rev 558389
Push 37978 by nerli@mozilla.com at Tue, 24 Nov 2020 09:22:28 +0000
Bug 1678560 - Avoid including nsILoadGroup.h in header files. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D97739 Depends on D97737
ef76276f219b02ccda12e8af99e56e5e7e24699a: Bug 1678334 - Sprinkle const in a bunch of ComputeScrollMetadata. r=tnikkel
Kartikaya Gupta <kats@pancake.staktrace.com> - Thu, 19 Nov 2020 22:59:45 +0000 - rev 558111
Push 37967 by abutkovits@mozilla.com at Fri, 20 Nov 2020 09:45:11 +0000
Bug 1678334 - Sprinkle const in a bunch of ComputeScrollMetadata. r=tnikkel This reduces the chance that we accidentally introduce more side-effect-producing code into this function. It doesn't remove the side effects already in this function though. Depends on D97624 Differential Revision: https://phabricator.services.mozilla.com/D97625
d88686d227658d8c318e81ad7a0506e530656e21: Bug 1678334 - Mark a bunch of parameters const. r=tnikkel
Kartikaya Gupta <kats@pancake.staktrace.com> - Thu, 19 Nov 2020 22:52:36 +0000 - rev 558110
Push 37967 by abutkovits@mozilla.com at Fri, 20 Nov 2020 09:45:11 +0000
Bug 1678334 - Mark a bunch of parameters const. r=tnikkel These parameters are conceptually not modified by the functions, so they should be const. Depends on D97623 Differential Revision: https://phabricator.services.mozilla.com/D97624
3a6b2dff69d8711665d88bc3612ec0ccce095288: Bug 1678334 - Make GetScrollTargetFrame() const. r=tnikkel
Kartikaya Gupta <kats@pancake.staktrace.com> - Thu, 19 Nov 2020 22:46:33 +0000 - rev 558109
Push 37967 by abutkovits@mozilla.com at Fri, 20 Nov 2020 09:45:11 +0000
Bug 1678334 - Make GetScrollTargetFrame() const. r=tnikkel This removes one const_cast but also adds two new ones. I think the new ones are reasonable - conceptually the function does not modify the input, so the input should be const. If that input is returned as the output then we need to strip the const because the return value shouldn't be const (because the caller should be free to modify it if desired). Depends on D97622 Differential Revision: https://phabricator.services.mozilla.com/D97623
025750e9ce492c014743fd74fec70de81850502b: Bug 1678334 - Mark some functions as const. r=tnikkel
Kartikaya Gupta <kats@pancake.staktrace.com> - Thu, 19 Nov 2020 22:44:42 +0000 - rev 558107
Push 37967 by abutkovits@mozilla.com at Fri, 20 Nov 2020 09:45:11 +0000
Bug 1678334 - Mark some functions as const. r=tnikkel This functions are conceptually getters and should be const. Differential Revision: https://phabricator.services.mozilla.com/D97621
e9b3009540c6b1b95b9a930693c911b8face4b0a: Bug 1662019 - Encapsulate the ScrollGeneration::New calls a bit more. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 13 Nov 2020 22:58:13 +0000 - rev 557251
Push 37949 by nbeleuzu@mozilla.com at Sat, 14 Nov 2020 21:51:26 +0000
Bug 1662019 - Encapsulate the ScrollGeneration::New calls a bit more. r=tnikkel Instead of the scrollframe manually calling ScrollGeneration::New this has the ScrollPositionUpdate do it automatically. Just makes things a little more encapsulated. Note that this patch does contain a small functional change, which is that if ScrollFrameHelper::ScrollToImpl is called with ScrollOrigin::apz, it will not increment mScrollGeneration whereas it used to before. As far as I can tell this should be a harmless change. Depends on D97036 Differential Revision: https://phabricator.services.mozilla.com/D97037
4424cf5d56cd861688a734514b873dc9dec630ff: Bug 1662019 - Replace the uint32_t scroll generation with ScrollGeneration. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 13 Nov 2020 22:58:06 +0000 - rev 557250
Push 37949 by nbeleuzu@mozilla.com at Sat, 14 Nov 2020 21:51:26 +0000
Bug 1662019 - Replace the uint32_t scroll generation with ScrollGeneration. r=tnikkel Depends on D97035 Differential Revision: https://phabricator.services.mozilla.com/D97036
280e26de10686accbba52a06985a729747dfaf7e: Bug 1662019 - Create a dedicated struct for the scroll generation. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 13 Nov 2020 22:57:53 +0000 - rev 557249
Push 37949 by nbeleuzu@mozilla.com at Sat, 14 Nov 2020 21:51:26 +0000
Bug 1662019 - Create a dedicated struct for the scroll generation. r=tnikkel Note in particular the struct keeps its own static (per-process) counter value, and uses a uint64_t. Depends on D97034 Differential Revision: https://phabricator.services.mozilla.com/D97035
65959f8bf4f30d192c343bd103872b977256c6cd: Bug 1673505 - Don't create inactive scrollframe hitinfos for hidden scrollframes. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 03 Nov 2020 19:43:07 +0000 - rev 555668
Push 37918 by apavel@mozilla.com at Tue, 03 Nov 2020 21:39:33 +0000
Bug 1673505 - Don't create inactive scrollframe hitinfos for hidden scrollframes. r=tnikkel If there is a scrollframe that is inactive but also visibility:hidden, then we shouldn't create a hit test info for it, because APZ will consider it as being visible. In the non-fission case this doesn't matter much but in the fission case the input event could end up getting sent to the wrong process if the hidden inactive scrollframe is sitting on top of an OOP iframe. Differential Revision: https://phabricator.services.mozilla.com/D95767
5418b2ee8b2466ca7c69388226bcca880ea0b1a5: Bug 1673728 - Default to adding phase information to the synthesized scroll events on macOS. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 30 Oct 2020 18:33:54 +0000 - rev 555284
Push 37908 by abutkovits@mozilla.com at Sat, 31 Oct 2020 09:44:45 +0000
Bug 1673728 - Default to adding phase information to the synthesized scroll events on macOS. r=tnikkel This causes the generated scroll events to be turned into PanGestureInput events instead of ScrollWheelInput events. This exercises different codepaths that are more representative of real-world behaviour on mac laptops. This patch also allows a pref to flip the behaviour back to the old behaviour of triggering ScrollWheelInputs, since in some cases we may want to test that behaviour explicitly. Depends on D95320 Differential Revision: https://phabricator.services.mozilla.com/D95321
af6e2a613f7a6715b5c1005a2d70d285b87deea0: Bug 1673728 - Don't put garbage in the synthesized scrollwheel event. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 30 Oct 2020 18:32:25 +0000 - rev 555283
Push 37908 by abutkovits@mozilla.com at Sat, 31 Oct 2020 09:44:45 +0000
Bug 1673728 - Don't put garbage in the synthesized scrollwheel event. r=tnikkel Apparently objective-C doesn't do a great job when you give a vararg function that takes int32_t arguments double values. I guess tests that use macOS synthesized wheel inputs were basically only working by accident. Differential Revision: https://phabricator.services.mozilla.com/D95320
a7080bae91c109472da36f0d197add5746b1be06: Bug 1668875 - Distinguish theme changes that can and cannot affect style/layout. r=tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 27 Oct 2020 10:24:40 +0000 - rev 554601
Push 37896 by rmaries@mozilla.com at Tue, 27 Oct 2020 15:58:19 +0000
Bug 1668875 - Distinguish theme changes that can and cannot affect style/layout. r=tnikkel This should make the optimization landed earlier in this bug apply for some of the NotifyThemeChanged() calls in nsWindow.cpp which are causing all the extra invalidations. If we know that system colors/fonts didn't change, we can avoid doing a bunch of reflow work and the patch from earlier in the bug can avoid re-rasterizing images too. Differential Revision: https://phabricator.services.mozilla.com/D94425
7b3e9881ab7332672704fe95030aec47f7a4d6c0: Bug 1646222 - Don't invalidate vector images as a result of size/display mode changes. r=tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 22 Oct 2020 09:29:43 +0000 - rev 554008
Push 37885 by apavel@mozilla.com at Thu, 22 Oct 2020 14:54:09 +0000
Bug 1646222 - Don't invalidate vector images as a result of size/display mode changes. r=tnikkel sizemode/displaymode media queries only affect a given browsing context tree so there's no need to propagate the change to images in that case. Differential Revision: https://phabricator.services.mozilla.com/D94422
c0f026dd4def969b4a13ae949aece083c2284093: Bug 1671235 - Enable desktop zoom for release. r=kats,botond,tnikkel
Kris Taeleman <ktaeleman@mozilla.com> - Wed, 14 Oct 2020 20:14:46 +0000 - rev 553043
Push 37862 by apavel@mozilla.com at Thu, 15 Oct 2020 03:57:02 +0000
Bug 1671235 - Enable desktop zoom for release. r=kats,botond,tnikkel Differential Revision: https://phabricator.services.mozilla.com/D93545
950fb95c57691a44125695c0a095f14daa9002bf: Bug 1671217 - Ensure we clear mIsFirstPaint in the visual-viewport-only MVM case. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 14 Oct 2020 19:26:27 +0000 - rev 553034
Push 37862 by apavel@mozilla.com at Thu, 15 Oct 2020 03:57:02 +0000
Bug 1671217 - Ensure we clear mIsFirstPaint in the visual-viewport-only MVM case. r=tnikkel There should be no user-visible correctness change here, just doing less unnecessary work. Differential Revision: https://phabricator.services.mozilla.com/D93540
cebe79ab2a6636dbd21873b297ae26dca78cdc70: Bug 1671004 - Extract helper for appending to mScrollUpdates. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 13 Oct 2020 18:50:51 +0000 - rev 552877
Push 37859 by smolnar@mozilla.com at Wed, 14 Oct 2020 09:52:12 +0000
Bug 1671004 - Extract helper for appending to mScrollUpdates. r=tnikkel This just makes it easier to add printfs and/or set breakpoints. Additional changes in bug 1662019 will flesh this function out a bit more. Differential Revision: https://phabricator.services.mozilla.com/D93415
6e538f817ee889f4314224a7b66b1d7c4d1a94db: Bug 1671002 - Dump both x and y coordinates for SCROLLRESTORE logs. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 13 Oct 2020 18:49:31 +0000 - rev 552876
Push 37859 by smolnar@mozilla.com at Wed, 14 Oct 2020 09:52:12 +0000
Bug 1671002 - Dump both x and y coordinates for SCROLLRESTORE logs. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D93414
3e7c8003cd571c2315df7ca83b4e55690fdcf9d6: Bug 1670454 - Use GetImageDecodeFlags more r=tnikkel
longsonr <longsonr@gmail.com> - Sun, 11 Oct 2020 09:05:20 +0000 - rev 552618
Push 37853 by apavel@mozilla.com at Mon, 12 Oct 2020 09:36:05 +0000
Bug 1670454 - Use GetImageDecodeFlags more r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D93159
095c8aec7254d999ce27a3f0c531ecd965f87f3b: Bug 1665343 - Remove blob specialness in image cache. r=tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 22 Sep 2020 22:02:42 +0000 - rev 549711
Push 37805 by abutkovits@mozilla.com at Wed, 23 Sep 2020 09:59:09 +0000
Bug 1665343 - Remove blob specialness in image cache. r=tnikkel We use it to merge blobs, but that doesn't match the spec. Per: https://html.spec.whatwg.org/#the-list-of-available-images We should key off the URI, and thus a revoked image should be able to be reused if the request is cached. This works to allow printing revoked blob images, which other browsers allow. I don't see any way to make that work easily while preserving the blob image optimization. That being said, it seems other browsers also re-decode when creating different URLs for the same blob (see the test-case attached to the bug), so it seems we should be able to live without it. Differential Revision: https://phabricator.services.mozilla.com/D90544
bf270919afa6400aa7a784ae81f3763137dce887: Bug 1664638 - Replace the ScrollPositionUpdate from scrollframe construction with one that has the scroll position. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Sat, 19 Sep 2020 00:30:22 +0000 - rev 549354
Push 37795 by ccoroiu@mozilla.com at Sat, 19 Sep 2020 09:34:53 +0000
Bug 1664638 - Replace the ScrollPositionUpdate from scrollframe construction with one that has the scroll position. r=tnikkel In some cases (in this scenario, with a RTL XUL scrollframe), the scrollframe can have a nonzero scroll position upon construction or reconstruction, without having executed the scrolling code in ScrollFrameHelper::RestoreState or ScrollFrameHelper::ScrollToRestoredPosition. In such cases APZ is not properly notified of the scroll position, and it can get into a state where it is out of sync with the main thread scroll position (until a subsequent scroll). To correct this, we replace the ScrollPositionUpdate that is created during scrollframe construction with a new ScrollPositionUpdate that holds the correct scroll position, so that APZ is properly notified of the scroll position. Differential Revision: https://phabricator.services.mozilla.com/D90674
7f3f056d1898dc7749f7b324d0c67a56271b47fd: Bug 1664838 - Add a test. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 15 Sep 2020 22:05:21 +0000 - rev 548826
Push 37787 by malexandru@mozilla.com at Wed, 16 Sep 2020 09:56:56 +0000
Bug 1664838 - Add a test. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D90311
641fc4c5c561f68a153f729d62661d9a2d462bfe: Bug 1658169 - Have smooth-type scroll updates trigger smooth scroll animations. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Sat, 12 Sep 2020 13:07:18 +0000 - rev 548444
Push 37779 by ncsoregi@mozilla.com at Sat, 12 Sep 2020 22:03:12 +0000
Bug 1658169 - Have smooth-type scroll updates trigger smooth scroll animations. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D89667
1c58e6aeb1e6265cfb525157b9753d2e890103e3: Bug 1658169 - Add a SmoothScrollAnimation that matches the main-thread smooth scroll physics. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Sat, 12 Sep 2020 14:15:47 +0000 - rev 548443
Push 37779 by ncsoregi@mozilla.com at Sat, 12 Sep 2020 22:03:12 +0000
Bug 1658169 - Add a SmoothScrollAnimation that matches the main-thread smooth scroll physics. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D89666
05c0f3920dcebf16dffc0e39454a9a2a0724cb21: Bug 1658169 - Move the origin-based physics computation to APZPublicUtils. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Sat, 12 Sep 2020 14:08:10 +0000 - rev 548442
Push 37779 by ncsoregi@mozilla.com at Sat, 12 Sep 2020 22:03:12 +0000
Bug 1658169 - Move the origin-based physics computation to APZPublicUtils. r=tnikkel This is just moving code to make it reusable in APZ. As part of this, I replace use of Preferences::* with the StaticPrefs::* API, because we can't use Preferences:: in the GPU process and we'll want to be able to invoke this code from there. Differential Revision: https://phabricator.services.mozilla.com/D89665
4734b8387b508f549f7b2f69d2017360bc5a8111: Bug 1658169 - Moving missing general.smoothScroll* prefs from all.js to StaticPrefs.yaml. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Sat, 12 Sep 2020 13:07:01 +0000 - rev 548441
Push 37779 by ncsoregi@mozilla.com at Sat, 12 Sep 2020 22:03:12 +0000
Bug 1658169 - Moving missing general.smoothScroll* prefs from all.js to StaticPrefs.yaml. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D89664
78a2b4fc4a69786f8a98071e19f6baf9563ee6bc: Bug 1658169 - Move the SmoothMsdScrollAnimation into its own file. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Sat, 12 Sep 2020 14:14:58 +0000 - rev 548440
Push 37779 by ncsoregi@mozilla.com at Sat, 12 Sep 2020 22:03:12 +0000
Bug 1658169 - Move the SmoothMsdScrollAnimation into its own file. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D89663
e07a8f86a5afbbcb903aa579bc029a2a7d0866de: Bug 1658169 - Rename the existing smooth scroll on the APZ side to smooth-msd. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Sat, 12 Sep 2020 13:06:51 +0000 - rev 548439
Push 37779 by ncsoregi@mozilla.com at Sat, 12 Sep 2020 22:03:12 +0000
Bug 1658169 - Rename the existing smooth scroll on the APZ side to smooth-msd. r=tnikkel This is used for scrolls of type eSmoothMsd that the main-thread sends over, and for scroll snapping. For consistent naming let's call this smooth msd. Differential Revision: https://phabricator.services.mozilla.com/D89662
574d01f80791d16daaeb6b8adc446bdebd8f2d49: Bug 1658169 - Unified compilation fixes. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Sat, 12 Sep 2020 13:06:49 +0000 - rev 548438
Push 37779 by ncsoregi@mozilla.com at Sat, 12 Sep 2020 22:03:12 +0000
Bug 1658169 - Unified compilation fixes. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D89661
afe9bfd9f1ab06f4b4acb6cdd7ce44d638258e98: Bug 1662014 - Drop mRelativeOffset and mLastSmoothScrollOrigin. r=tnikkel,botond
Kartikaya Gupta <kgupta@mozilla.com> - Sat, 12 Sep 2020 13:06:41 +0000 - rev 548436
Push 37779 by ncsoregi@mozilla.com at Sat, 12 Sep 2020 22:03:12 +0000
Bug 1662014 - Drop mRelativeOffset and mLastSmoothScrollOrigin. r=tnikkel,botond The only place these fields are still read are for detecting if an APZ animation is pending (not yet submitted in a transaction) and we can replace that code with something slightly simpler. And then delete the unused fields. Differential Revision: https://phabricator.services.mozilla.com/D88751
c8c89974599350ada75a3fa653e2c18ed6424338: Bug 1662014 - Remove unused fields/APIs. r=botond,tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Sat, 12 Sep 2020 13:06:39 +0000 - rev 548435
Push 37779 by ncsoregi@mozilla.com at Sat, 12 Sep 2020 22:03:12 +0000
Bug 1662014 - Remove unused fields/APIs. r=botond,tnikkel These things are all unused now. Differential Revision: https://phabricator.services.mozilla.com/D88750
04b1220fb04324826c66621cd90896c363bc0009: Bug 1661903 - Update test expectation to match Chrome and be consistent with other similar scenarios. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Sat, 12 Sep 2020 13:06:22 +0000 - rev 548432
Push 37779 by ncsoregi@mozilla.com at Sat, 12 Sep 2020 22:03:12 +0000
Bug 1661903 - Update test expectation to match Chrome and be consistent with other similar scenarios. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D88747
9960b0962e313fe6b742b84fe7dd6dc302b7d130: Bug 1662013 - Make the scroll-behavior-element WPT test pass. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Sat, 12 Sep 2020 13:06:12 +0000 - rev 548430
Push 37779 by ncsoregi@mozilla.com at Sat, 12 Sep 2020 22:03:12 +0000
Bug 1662013 - Make the scroll-behavior-element WPT test pass. r=tnikkel The previous patches caused the scroll-behavior-element WPT to fail, specificallly the subtest that does a no-op instant scroll immediately following an APZ smooth scroll, within the same transaction. In this subtest, the APZ smooth scroll request gets added to mScrollUpdates but then the instant scroll is a no-op (destination is same as current position) so we early return and don't add a scroll update for it. This patch adds a bit of code to the early-exit path to detect this scenario and let APZ know to cancel the animation. By itself this causes a different test to fail, because we also hit this codepath when the main thread internally does a no-op instant scroll to reclamp the scroll offset after a reflow. That requires further refining the condition with a new scroll origin used for the clamping call. This ain't the prettiest thing but I'm hopeful that after untangling more of the surrounding code in the future we can replace this with something more elegant. Differential Revision: https://phabricator.services.mozilla.com/D88745
b78646d59e32d680001a8d85322b5a16b514d190: Bug 1662013 - Update NotifyLayersUpdated to use the ScrollPositionUpdates. r=tnikkel,botond
Kartikaya Gupta <kgupta@mozilla.com> - Sat, 12 Sep 2020 13:06:10 +0000 - rev 548429
Push 37779 by ncsoregi@mozilla.com at Sat, 12 Sep 2020 22:03:12 +0000
Bug 1662013 - Update NotifyLayersUpdated to use the ScrollPositionUpdates. r=tnikkel,botond This rewrites a big chunk of the NotifyLayersUpdated code (most of the code that deals with incoming scroll requests from the main-thread) to instead iterate through the list of ScrollPositionUpdates on the metadata and apply them in order. A bunch of the ApplyXXXUpdateFrom functions on FrameMetrics have their innards deduplicated and boil down to a single line, which is then inlined, so those functions get removed entirely. Note that this rewrite doesn't yet handle all the possible types of ScrollPositionUpdate instances, just the ones that the old code handled. In the future this support will be fleshed out with tests to exercise the relevant codepaths. There is also a change to nsGfxScrollFrame which slightly modifies the semantics of mApzScrollPos to handle the case where multiple relative scrolls happen in a single transaction. As the implementation now requires multiple relative ScrollPositionUpdates rather than a single "unified" relative scroll in the FrameMetrics, we need to update mApzScrollPos for each relative ScrollPositionUpdate we generate. Differential Revision: https://phabricator.services.mozilla.com/D88744
98fb30c331e23e9f2435229f57a62e918e407da0: Bug 1662013 - Introduce a ScrollPositionUpdate and plumb it in. r=tnikkel,botond
Kartikaya Gupta <kgupta@mozilla.com> - Sat, 12 Sep 2020 13:05:53 +0000 - rev 548426
Push 37779 by ncsoregi@mozilla.com at Sat, 12 Sep 2020 22:03:12 +0000
Bug 1662013 - Introduce a ScrollPositionUpdate and plumb it in. r=tnikkel,botond This adds a ScrollPositionUpdate class. Code in nsGfxScrollFrame creates instances of these classes every time the scroll generation is incremented, and saves them to an array. The array is sent in the scroll metadata to the compositor as part of a paint transaction. Currently this data is not used at all on the APZ side, and exists alongside (independently of) the existing scroll fields, so this patch should not have any functional effects. Differential Revision: https://phabricator.services.mozilla.com/D88741
8ee4c4a5cb6d96d39eb7c7cbb3a431bdf20938c1: Bug 1658881 - When failing to create a channel and an image request, make sure to set the image blocking status appropriately. r=tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 09 Sep 2020 22:58:29 +0000 - rev 548096
Push 37774 by nbeleuzu@mozilla.com at Fri, 11 Sep 2020 02:31:36 +0000
Bug 1658881 - When failing to create a channel and an image request, make sure to set the image blocking status appropriately. r=tnikkel This is the same status as we do for known no-data protocols here: https://searchfox.org/mozilla-central/rev/ac142717cc067d875e83e4b1316f004f6e063a46/dom/base/nsNoDataProtocolContentPolicy.cpp#59 This ensures we treat these two cases the same. Differential Revision: https://phabricator.services.mozilla.com/D89382
b5d39e472f05f3f38c10d3fdd61eb7b9a3ee8a50: Bug 1658881 - When failing to create a channel and an image request, make sure to set the image blocking status appropriately. r=tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 07 Sep 2020 23:04:41 +0000 - rev 547808
Push 37765 by abutkovits@mozilla.com at Tue, 08 Sep 2020 16:13:32 +0000
Bug 1658881 - When failing to create a channel and an image request, make sure to set the image blocking status appropriately. r=tnikkel This is the same status as we do for known no-data protocols here: https://searchfox.org/mozilla-central/rev/ac142717cc067d875e83e4b1316f004f6e063a46/dom/base/nsNoDataProtocolContentPolicy.cpp#59 This ensures we treat these two cases the same. Differential Revision: https://phabricator.services.mozilla.com/D89382
11a7c8990f933bbe52147b06f01f7db3166b9d41: Bug 1661608 - Use correct viewport type in RecordMouseLocation(). r=tnikkel
Botond Ballo <botond@mozilla.com> - Fri, 28 Aug 2020 21:44:16 +0000 - rev 546906
Push 37737 by csabou@mozilla.com at Sat, 29 Aug 2020 09:12:26 +0000
Bug 1661608 - Use correct viewport type in RecordMouseLocation(). r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D88676
d3abe25ade22d965cfa2c163c4f70dc665204ed0: Bug 1661755 - Don't store a NotSpecified value, use the equivalent None value instead. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 28 Aug 2020 20:34:41 +0000 - rev 546895
Push 37737 by csabou@mozilla.com at Sat, 29 Aug 2020 09:12:26 +0000
Bug 1661755 - Don't store a NotSpecified value, use the equivalent None value instead. r=tnikkel This should not have any functional effects, but it maintains a useful invariant that the stored field is never NotSpecified. NotSpecified should only be used as a default value for function parameters, and converted to some other origin when "at rest" in the field. Differential Revision: https://phabricator.services.mozilla.com/D88665
af56f0e4130a6b3364a9aecd54bc7082b7d820e5: Bug 1661755 - Update logging. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 28 Aug 2020 20:43:50 +0000 - rev 546894
Push 37737 by csabou@mozilla.com at Sat, 29 Aug 2020 09:12:26 +0000
Bug 1661755 - Update logging. r=tnikkel This looks like a holdover from when we added ScrollMetadata as a superobject of FrameMetrics. Depends on D88648 Differential Revision: https://phabricator.services.mozilla.com/D88649
dc9b3a104093fefc313c58948c1e13eb06c413ae: Bug 1661755 - Flip the ref and test setups for scroll-behavior-6.html. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 28 Aug 2020 20:43:47 +0000 - rev 546893
Push 37737 by csabou@mozilla.com at Sat, 29 Aug 2020 09:12:26 +0000
Bug 1661755 - Flip the ref and test setups for scroll-behavior-6.html. r=tnikkel For all the other scroll-behavior-* tests, the "complex" behaviour is the "test" and the "let's scroll these things to their intended destination" behaviour is the "ref", as one would expect. Except for some reason in scroll-behavior-6, the "ref" branch is the one doing all the tricky scrolling things and the other branch has the simple intended outcomes. This patch inverts the branches so that the test behaves more as expected. Differential Revision: https://phabricator.services.mozilla.com/D88648
4b0795cc0cfbb8acde26fbc2f5c59f381d0abb51: Bug 1655846 - Hit MOZ_CRASH(assertion failed: `(left == right)` left: `1024`, right: `0`). r=tnikkel
Jon Bauman <jbauman@mozilla.com> - Fri, 14 Aug 2020 23:17:37 +0000 - rev 544739
Push 37700 by dluca@mozilla.com at Sat, 15 Aug 2020 09:31:17 +0000
Bug 1655846 - Hit MOZ_CRASH(assertion failed: `(left == right)` left: `1024`, right: `0`). r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D87003
9ef828c9bd891822d22c53a6af567023f0128568: Bug 1648686 - Don't rollup the hamburger menu when pinching over content (on mac). r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 13 Aug 2020 09:45:26 +0000 - rev 544510
Push 37696 by apavel@mozilla.com at Thu, 13 Aug 2020 15:46:18 +0000
Bug 1648686 - Don't rollup the hamburger menu when pinching over content (on mac). r=tnikkel It seems like ShouldRollupOnMouseWheelEvent really means something more like "ShouldRollupIfPageIsGonnaMove" so it seems appropriate to use in this situation. Might be worth renaming the function at some point if my interpration is correct, but the name propagates into xhtml attributes and such so it's more than I want to do right now. Differential Revision: https://phabricator.services.mozilla.com/D86839
510e2a73c290aaef08044b101fe65f2089c57cf7: Bug 1653576 - Don't let dmanip events roll up popups if the events are inside the popup. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 11 Aug 2020 21:44:30 +0000 - rev 544316
Push 37692 by cbrindusan@mozilla.com at Wed, 12 Aug 2020 03:44:18 +0000
Bug 1653576 - Don't let dmanip events roll up popups if the events are inside the popup. r=tnikkel The existing rollup-handling code in SendAnAPZEvent was mostly copied from the DealWithPopups function, so this patch removes that duplication and reuses the existing codepath. And it adds some extra checking for dmanip events that mirrors the checking we do for other events, so that events that are targeted inside the popup don't cause the popup to get rolled up. Differential Revision: https://phabricator.services.mozilla.com/D86603
15b0c4b2dbe858c102a77e36e821eb4d6d2130c7: Bug 1653576 - Generify EventIsInsideWindow to allow passing a point. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 11 Aug 2020 22:15:51 +0000 - rev 544315
Push 37692 by cbrindusan@mozilla.com at Wed, 12 Aug 2020 03:44:18 +0000
Bug 1653576 - Generify EventIsInsideWindow to allow passing a point. r=tnikkel This allows us to reuse this function and the GetPopupsToRollup function when an event point is different than what comes out of GetMessagePos. For instance, the WM_POINTERDOWN code can now reuse this functions properly. This fixes a latent bug where it was calling GetPopupsToRollup which was using an possibly-incorrect point internally. Differential Revision: https://phabricator.services.mozilla.com/D86754
67d48a5990e0bbd3915f9c0d9e79b9dfa00398dc: Bug 1656130 - Extending GPU_WAIT_TIME_MS telemetry. r=tnikkel
Kris Taeleman <ktaeleman@mozilla.com> - Fri, 07 Aug 2020 20:28:53 +0000 - rev 544159
Push 37688 by apavel@mozilla.com at Tue, 11 Aug 2020 03:16:35 +0000
Bug 1656130 - Extending GPU_WAIT_TIME_MS telemetry. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D86400
3aecd9a7137e1cf9f5fa2cd1dae5453008f3e4d6: Bug 1653796 - Eliminate non-monotonic sample times at the start of APZ animations with WR. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 06 Aug 2020 18:29:56 +0000 - rev 544152
Push 37688 by apavel@mozilla.com at Tue, 11 Aug 2020 03:16:35 +0000
Bug 1653796 - Eliminate non-monotonic sample times at the start of APZ animations with WR. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D86045
037e038956759d8ddf00f4ac51f0a02ae1c6d74e: Bug 1658046 - Fix missing return statement. r=tnikkel,botond
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 07 Aug 2020 21:02:28 +0000 - rev 543834
Push 37682 by ccoroiu@mozilla.com at Sat, 08 Aug 2020 09:35:45 +0000
Bug 1658046 - Fix missing return statement. r=tnikkel,botond Differential Revision: https://phabricator.services.mozilla.com/D86439
33cf94c2936b92fdd7934c9796176343fff25427: Bug 1653796 - Eliminate non-monotonic sample times at the start of APZ animations with WR. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 05 Aug 2020 20:26:36 +0000 - rev 543474
Push 37674 by abutkovits@mozilla.com at Thu, 06 Aug 2020 03:34:56 +0000
Bug 1653796 - Eliminate non-monotonic sample times at the start of APZ animations with WR. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D86045
97656f06b190bb60834f2655b3d751bdb2b9c8d3: Bug 1656628 - Avoid calling setTimeout(undefined) in synthesizeNativeWheelAndWaitForWheelEvent(). r=tnikkel
Botond Ballo <botond@mozilla.com> - Fri, 31 Jul 2020 23:55:28 +0000 - rev 542988
Push 37657 by nerli@mozilla.com at Sat, 01 Aug 2020 09:48:10 +0000
Bug 1656628 - Avoid calling setTimeout(undefined) in synthesizeNativeWheelAndWaitForWheelEvent(). r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D85645
20c5d58809393b66e1424fcc54abf3b958e83e84: Bug 1655238 - Only cancel existing APZ animations on mousedown when the mousedown lands on a scrollthumb. r=tnikkel
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 31 Jul 2020 15:36:24 +0000 - rev 542954
Push 37657 by nerli@mozilla.com at Sat, 01 Aug 2020 09:48:10 +0000
Bug 1655238 - Only cancel existing APZ animations on mousedown when the mousedown lands on a scrollthumb. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D85453