searching for reviewer(tcsc)
e36730a6d5898a03b25439a75340e46c8240848c: Bug 1538015 (part 2) - restrict when incoming synced prefs are applied. r=tcsc,pauljt,Gijs
Mark Hammond <mhammond@skippinet.com.au> - Tue, 25 Jun 2019 04:40:58 +0000 - rev 480003
Push 36199 by aciure@mozilla.com at Tue, 25 Jun 2019 15:52:35 +0000
Bug 1538015 (part 2) - restrict when incoming synced prefs are applied. r=tcsc,pauljt,Gijs Specifically, a "control pref" for a pref must already exist locally, or a new preference, `services.sync.prefs.dangerously_allow_arbitrary` must be set to true. This also removes a few preferences from the set we sync by default based due to potential harm which can be caused syncing inappropriate values. Differential Revision: https://phabricator.services.mozilla.com/D29775
643214222e38498bbd795d70890f0e6b9ac581b0: Bug 1538015 (part 1) - test only change to tighten up the checks being made. r=tcsc
Mark Hammond <mhammond@skippinet.com.au> - Tue, 25 Jun 2019 04:40:41 +0000 - rev 480002
Push 36199 by aciure@mozilla.com at Tue, 25 Jun 2019 15:52:35 +0000
Bug 1538015 (part 1) - test only change to tighten up the checks being made. r=tcsc This is a test-only change to make the existing synced prefs tests more explicit about values being checked and moves a couple of prefs around to make things a bit clearer, which should make the test changes in part 2 clearer. Differential Revision: https://phabricator.services.mozilla.com/D29774
006da247f592a392bdaeb128fc956e070c344c29: Bug 1550967 - ensure sync's username pref is set whenever FxA has a user. r=tcsc
Mark Hammond <mhammond@skippinet.com.au> - Thu, 13 Jun 2019 01:32:07 +0000 - rev 478583
Push 36146 by opoprus@mozilla.com at Thu, 13 Jun 2019 09:54:24 +0000
Bug 1550967 - ensure sync's username pref is set whenever FxA has a user. r=tcsc Differential Revision: https://phabricator.services.mozilla.com/D34309
b071db6bea7a03f23852097adbac201032005fea: Bug 1148205 - Replace misnamed `formSubmitURL` and `hostname` properties on nsILoginInfo in services/sync/ r=markh,tcsc
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 05 Jun 2019 03:59:46 +0000 - rev 476925
Push 36112 by malexandru@mozilla.com at Wed, 05 Jun 2019 15:52:48 +0000
Bug 1148205 - Replace misnamed `formSubmitURL` and `hostname` properties on nsILoginInfo in services/sync/ r=markh,tcsc Differential Revision: https://phabricator.services.mozilla.com/D33347
246b4a16ab9610d0a91d4e5270b01537c7efc792: Bug 1552621 - Include optional steps in Sync engine telemetry. r=tcsc,tdsmith
Lina Cambridge <lina@yakshaving.ninja> - Tue, 04 Jun 2019 20:08:07 +0000 - rev 476893
Push 36110 by malexandru@mozilla.com at Wed, 05 Jun 2019 09:49:10 +0000
Bug 1552621 - Include optional steps in Sync engine telemetry. r=tcsc,tdsmith Before this commit, we used event telemetry to record timing and counts for the different steps of a bookmark merge (fetching the local tree, new local contents, remote tree, and new remote contents; merging; applying; fetching outgoing records; and notifying observers). This has several limitations. We need to store all numbers as strings, include a "flow ID" to tag events from the same merge, and collect failure reasons twice. We also can't correlate these events to the existing engine telemetry, meaning we can't see other stats for that engine, or for the entire sync. Finally, we need to run separate queries on these events for analysis, instead of extending our existing engine dashboards. This approach also feels like an abuse of event telemetry, so this commit adds a "steps" field for each engine in the Sync ping. Each step has a name, time taken, and additional named counts, like the number of items in the tree, or merged structure stats. Currently, only the `buffered-bookmarks` engine records these steps. Differential Revision: https://phabricator.services.mozilla.com/D33411
22fa4447a9a2f2fe231fdb35597ba3e021646968: Bug 1552621 - Record bookmark validation telemetry for the buffered engine. r=tcsc
Lina Cambridge <lina@yakshaving.ninja> - Tue, 04 Jun 2019 20:08:51 +0000 - rev 476892
Push 36110 by malexandru@mozilla.com at Wed, 05 Jun 2019 09:49:10 +0000
Bug 1552621 - Record bookmark validation telemetry for the buffered engine. r=tcsc Differential Revision: https://phabricator.services.mozilla.com/D33410
7a67c62d4b8b1a36c98b98a0d8c6cdeff425160a: Bug 1552621 - Record shutdown blocker progress in the bookmarks mirror. r=markh,tcsc
Lina Cambridge <lina@yakshaving.ninja> - Mon, 03 Jun 2019 23:04:37 +0000 - rev 476891
Push 36110 by malexandru@mozilla.com at Wed, 05 Jun 2019 09:49:10 +0000
Bug 1552621 - Record shutdown blocker progress in the bookmarks mirror. r=markh,tcsc This commit introduces a `mozISyncedBookmarksMirrorProgressListener` interface for capturing telemetry and updating shutdown blocker state after each step of the merge, instead of waiting until the end. This also means we can also record events for interrupted and failed merges, and pass validation data through to the Sync ping. Shutdown hang crash reports now have a `steps` field, indicating the sequence of completed steps and when they were recorded. If the last step in the hang report is `fetchLocalTree`, we know the merger is blocked on `fetchNewLocalContents`. If the last step is `fetchNewLocalContents`, the merger is stuck at `fetchRemoteTree`, since that's the next step after `fetchNewLocalContents`. This commit also implements `Driver::record_telemetry_event` to dispatch progress callback runnables to the main thread. Differential Revision: https://phabricator.services.mozilla.com/D31950
3fae03e3595a90150c92e848ad53bf17f6ed493d: Bug 1551062 - Abort merging when the synced bookmarks mirror is finalized. r=tcsc
Lina Cambridge <lina@yakshaving.ninja> - Tue, 14 May 2019 03:40:30 +0000 - rev 473735
Push 36013 by csabou@mozilla.com at Tue, 14 May 2019 16:01:08 +0000
Bug 1551062 - Abort merging when the synced bookmarks mirror is finalized. r=tcsc This commit adds an `AbortController` to the bookmark merger that aborts fetching and merging when the mirror is finalized on shutdown. Differential Revision: https://phabricator.services.mozilla.com/D31000
e391c48bc166bf4cba9dafe7b5c1d1310444269f: Bug 1548884 - Enable the synced bookmarks mirror on Nightly and Beta. r=tcsc
Lina Cambridge <lina@yakshaving.ninja> - Mon, 06 May 2019 20:40:20 +0000 - rev 472782
Push 35978 by shindli@mozilla.com at Tue, 07 May 2019 09:44:39 +0000
Bug 1548884 - Enable the synced bookmarks mirror on Nightly and Beta. r=tcsc The number of Sync users on these channels is low compared to Release, so we can do this without a gradual rollout. This also lets more users test the new bookmark sync engine without manually flipping the pref. Differential Revision: https://phabricator.services.mozilla.com/D29859
76e8b769a7c00797dcaeef19cbaaa564f1f373b6: Bug 1546035 - Remove local and remote livemarks when syncing. r=mak,tcsc
Lina Cambridge <lina@yakshaving.ninja> - Thu, 02 May 2019 08:03:36 +0000 - rev 472337
Push 35954 by rgurzau@mozilla.com at Fri, 03 May 2019 04:14:31 +0000
Bug 1546035 - Remove local and remote livemarks when syncing. r=mak,tcsc This commit exports livemarks before syncing for the first time, to avoid losing livemarks that Sync may have resurrected. As of v0.2.4, Dogear treats livemarks as non-syncable, and deletes them on both sides. This also bumps the mirror schema version, to trigger a first sync. Differential Revision: https://phabricator.services.mozilla.com/D28543
52c866bc91aa95ee7b416a8a77185edfff0e84a8: Bug 1536170 - Replace all usage of Async.yieldingIterator with Async.yieldingForEach r=tcsc
Barret Rennie <barret@brennie.ca> - Mon, 15 Apr 2019 19:26:18 +0000 - rev 469930
Push 35884 by apavel@mozilla.com at Thu, 18 Apr 2019 21:35:00 +0000
Bug 1536170 - Replace all usage of Async.yieldingIterator with Async.yieldingForEach r=tcsc Differential Revision: https://phabricator.services.mozilla.com/D26593
2b4f6184e971ee9be6367e5ad9c5d6784e98f857: Bug 1536170 - Add unit tests for Async.yieldingForEach() r=tcsc
Barret Rennie <barret@brennie.ca> - Mon, 15 Apr 2019 19:26:16 +0000 - rev 469929
Push 35884 by apavel@mozilla.com at Thu, 18 Apr 2019 21:35:00 +0000
Bug 1536170 - Add unit tests for Async.yieldingForEach() r=tcsc Differential Revision: https://phabricator.services.mozilla.com/D26592
f33bfaf16d975de81421d687fd519d0fa56e10d6: Bug 1536170 - Replace Async.jankYielder r=tcsc,markh,eoger
Barret Rennie <barret@brennie.ca> - Wed, 17 Apr 2019 03:00:35 +0000 - rev 469928
Push 35884 by apavel@mozilla.com at Thu, 18 Apr 2019 21:35:00 +0000
Bug 1536170 - Replace Async.jankYielder r=tcsc,markh,eoger `Async.jankYielder` is known to, unfortunately, cause jank by creating a lot of immediately resolved promises that must be then GCed. For a collection of 50 items, it will create 50 promises and 49 of them will immediately resolve. Instead of `Async.jankYielder`, we now have `Async.yieldState`, which simply keeps track of whether or not the caller should yield to the event loop. Two higher level looping constructs are built on top of it: * `Async.yieldingIterator`, which has been rewritten to not create extraneous promises; and * `Async.yieldingForEach`, which is a replacement for awaiting `Async.jankYielder` in a loop. Instead, it accepts the loop body as a function. Each of these can share an instance of an `Async.yieldState`, which allows an object with multiple loops to yield every N iterations overall, instead of every N iterations of each loop, which keeps the behaviour of using one `Async.jankYielders` in multiple places. Differential Revision: https://phabricator.services.mozilla.com/D26229
e41b319d724345dbc5313d145d29b717ce6fdd8c: Bug 1536170 - Replace all usage of Async.yieldingIterator with Async.yieldingForEach r=tcsc
Barret Rennie <barret@brennie.ca> - Fri, 12 Apr 2019 19:07:26 +0000 - rev 469341
Push 35865 by apavel@mozilla.com at Sat, 13 Apr 2019 21:44:49 +0000
Bug 1536170 - Replace all usage of Async.yieldingIterator with Async.yieldingForEach r=tcsc Differential Revision: https://phabricator.services.mozilla.com/D26593
0d8c58e90773ced99afad4c4f055f494745c7420: Bug 1536170 - Add unit tests for Async.yieldingForEach() r=tcsc
Barret Rennie <barret@brennie.ca> - Fri, 12 Apr 2019 19:07:08 +0000 - rev 469340
Push 35865 by apavel@mozilla.com at Sat, 13 Apr 2019 21:44:49 +0000
Bug 1536170 - Add unit tests for Async.yieldingForEach() r=tcsc Differential Revision: https://phabricator.services.mozilla.com/D26592
19c23f03b47178f8071769ebc564d8076d076f5c: Bug 1536170 - Replace Async.jankYielder r=tcsc,markh,eoger
Barret Rennie <barret@brennie.ca> - Fri, 12 Apr 2019 19:07:00 +0000 - rev 469339
Push 35865 by apavel@mozilla.com at Sat, 13 Apr 2019 21:44:49 +0000
Bug 1536170 - Replace Async.jankYielder r=tcsc,markh,eoger `Async.jankYielder` is known to, unfortunately, cause jank by creating a lot of immediately resolved promises that must be then GCed. For a collection of 50 items, it will create 50 promises and 49 of them will immediately resolve. Instead of `Async.jankYielder`, we now have `Async.yieldState`, which simply keeps track of whether or not the caller should yield to the event loop. Two higher level looping constructs are built on top of it: * `Async.yieldingIterator`, which has been rewritten to not create extraneous promises; and * `Async.yieldingForEach`, which is a replacement for awaiting `Async.jankYielder` in a loop. Instead, it accepts the loop body as a function. Each of these can share an instance of an `Async.yieldState`, which allows an object with multiple loops to yield every N iterations overall, instead of every N iterations of each loop, which keeps the behaviour of using one `Async.jankYielders` in multiple places. Differential Revision: https://phabricator.services.mozilla.com/D26229
57c26f8e0bf7ab4e1d23bdbf68ed91c0bd925204: Bug 1536170 - Replace all usage of Async.yieldingIterator with Async.yieldingForEach r=tcsc
Barret Rennie <barret@brennie.ca> - Thu, 11 Apr 2019 18:40:02 +0000 - rev 469068
Push 35856 by csabou@mozilla.com at Fri, 12 Apr 2019 03:19:48 +0000
Bug 1536170 - Replace all usage of Async.yieldingIterator with Async.yieldingForEach r=tcsc Differential Revision: https://phabricator.services.mozilla.com/D26593
ccea2e827d9dff136b8f6ac9b357e3fabb5e3ec7: Bug 1536170 - Add unit tests for Async.yieldingForEach() r=tcsc
Barret Rennie <barret@brennie.ca> - Thu, 11 Apr 2019 18:39:54 +0000 - rev 469067
Push 35856 by csabou@mozilla.com at Fri, 12 Apr 2019 03:19:48 +0000
Bug 1536170 - Add unit tests for Async.yieldingForEach() r=tcsc Differential Revision: https://phabricator.services.mozilla.com/D26592
51a67bffd7d2670d12d87058973bc01e64f10096: Bug 1536170 - Replace Async.jankYielder r=tcsc,markh,eoger
Barret Rennie <barret@brennie.ca> - Thu, 11 Apr 2019 18:39:43 +0000 - rev 469066
Push 35856 by csabou@mozilla.com at Fri, 12 Apr 2019 03:19:48 +0000
Bug 1536170 - Replace Async.jankYielder r=tcsc,markh,eoger `Async.jankYielder` is known to, unfortunately, cause jank by creating a lot of immediately resolved promises that must be then GCed. For a collection of 50 items, it will create 50 promises and 49 of them will immediately resolve. Instead of `Async.jankYielder`, we now have `Async.yieldState`, which simply keeps track of whether or not the caller should yield to the event loop. Two higher level looping constructs are built on top of it: * `Async.yieldingIterator`, which has been rewritten to not create extraneous promises; and * `Async.yieldingForEach`, which is a replacement for awaiting `Async.jankYielder` in a loop. Instead, it accepts the loop body as a function. Each of these can share an instance of an `Async.yieldState`, which allows an object with multiple loops to yield every N iterations overall, instead of every N iterations of each loop, which keeps the behaviour of using one `Async.jankYielders` in multiple places. Differential Revision: https://phabricator.services.mozilla.com/D26229
39c9c1e5dd5718920508b5003f4e242e50536238: Bug 1540894 - Store diverging structure in the bookmarks mirror. r=tcsc
Lina Cambridge <lina@yakshaving.ninja> - Fri, 05 Apr 2019 20:44:43 +0000 - rev 468240
Push 35824 by apavel@mozilla.com at Sat, 06 Apr 2019 10:57:50 +0000
Bug 1540894 - Store diverging structure in the bookmarks mirror. r=tcsc This commit: * Uses chunking to insert child GUIDs in `storeRemoteFolder`. * Changes the mirror schema to store diverging structure, so that it can be passed to Dogear. * Sorts remote items by GUID, so that diverging ones can be reparented in a deterministic order. * Measures and logs the time taken to run the Rust merger. * Adds tests for multiple parents and replacing invalid remote items. * Fixes two tests in `test_bookmark_structure_changes` to ensure the remote structure is consistent. Differential Revision: https://phabricator.services.mozilla.com/D26275
eea220d8fd4c656997171fd24f9d29b4988aeb6a: Bug 1540894 - Vendor Dogear v0.2.3. r=tcsc
Lina Cambridge <lina@yakshaving.ninja> - Fri, 05 Apr 2019 20:44:18 +0000 - rev 468239
Push 35824 by apavel@mozilla.com at Sat, 06 Apr 2019 10:57:50 +0000
Bug 1540894 - Vendor Dogear v0.2.3. r=tcsc Differential Revision: https://phabricator.services.mozilla.com/D26274
b052410b667385a66f5b9916b1e91bef80f8fc09: Bug 1539697 - Report more detailed errors in the mozStorage Rust binding. r=mak,tcsc
Lina Cambridge <lina@yakshaving.ninja> - Tue, 02 Apr 2019 16:56:41 +0000 - rev 467646
Push 35806 by rgurzau@mozilla.com at Wed, 03 Apr 2019 04:07:39 +0000
Bug 1539697 - Report more detailed errors in the mozStorage Rust binding. r=mak,tcsc The `nsresult` codes that mozStorage returns are often too generic. For example, `NS_ERROR_FAILURE` might be anything from a SQL syntax error to an invalid column name in a trigger. This commit adds a `Conn::call_and_wrap_error` helper that checks the last SQLite error, and returns that instead of `nsresult`. Not all errors are SQLite errors, however, so we only use this for mozStorage methods that return `convertResultCode`. Differential Revision: https://phabricator.services.mozilla.com/D25179
e7282f4449c83d2657edc29f8131b8b4985ab2ef: Bug 1482608 - Fix up inconsistent bookmarks at sync time. r=markh,tcsc
Lina Cambridge <lina@yakshaving.ninja> - Mon, 25 Mar 2019 04:50:38 +0000 - rev 465876
Push 35752 by opoprus@mozilla.com at Mon, 25 Mar 2019 09:51:53 +0000
Bug 1482608 - Fix up inconsistent bookmarks at sync time. r=markh,tcsc This commit changes the mirror to store divergent structure, instead of dropping or trying to fix up records as they're stored. * We no longer ignore records for items with invalid GUIDs. Instead, we store them in the mirror, and make new GUIDs for them. Dogear takes care of marking the old GUID as deleted, and flagging the item and its parent for reupload. * Each item stores its `parentid` in the database, so we can fix up orphans and parent-child disagreements. * Each item also stores a new validity state: valid, reupload, or replace. An item marked with "reupload" can be applied, but should be updated remotely. We use this to rewrite legacy tag queries. An item marked with "replace" can't be applied; for example, a bookmark or query without a valid URL. If the item exists locally, we can replace the server's invalid copy with a valid local copy. If not, we must delete it from the server. * We don't need to protect the mirror's roots, since Dogear fixes them for us. Differential Revision: https://phabricator.services.mozilla.com/D20077
4782957f96a4d958880e7c177a8ed42d8caab7cf: Bug 1482608 - Port the synced bookmarks merger to Rust. r=nika,mak,markh,tcsc
Lina Cambridge <lina@yakshaving.ninja> - Mon, 25 Mar 2019 04:50:14 +0000 - rev 465875
Push 35752 by opoprus@mozilla.com at Mon, 25 Mar 2019 09:51:53 +0000
Bug 1482608 - Port the synced bookmarks merger to Rust. r=nika,mak,markh,tcsc This commit introduces a Rust XPCOM component, `mozISyncedBookmarksMerger`, that wraps the Dogear crate for merging and applying synced bookmarks. How this works: `SyncedBookmarksMirror.jsm` manages opening the connection, initializing the schema, and writing incoming items into the mirror database. The new `mozISyncedBookmarksMerger` holds a handle to the same connection. When JS code calls `mozISyncedBookmarksMerger::apply`, the merger builds local and remote trees, produces a merged tree, applies the tree back to Places, and stages outgoing items for upload in a temp table, all on the storage thread. It then calls back in to JS, which inflates Sync records for outgoing items, notifies Places observers, and cleans up. Since Dogear has a more robust merging algorithm that attempts to fix up invalid trees, `test_bookmark_corruption.js` intentionally fails. This is fixed in the next commit, which changes the merger to handle invalid structure. Differential Revision: https://phabricator.services.mozilla.com/D20076
db429d8a37159e4572fc885ec963c9d914592f28: Bug 1522381 - don't rely on Services.startup.getStartupInfo().main for telemetry session start. r=tcsc
Mark Hammond <mhammond@skippinet.com.au> - Fri, 08 Feb 2019 01:49:33 +0000 - rev 457673
Push 35517 by opoprus@mozilla.com at Fri, 08 Feb 2019 09:49:17 +0000
Bug 1522381 - don't rely on Services.startup.getStartupInfo().main for telemetry session start. r=tcsc Differential Revision: https://phabricator.services.mozilla.com/D19098
28ee88825b3dc360fb09bc69f25e0580f2780ca5: Bug 1512867 - Always update or upload synced bookmarks that only exist on one side. r=tcsc
Lina Cambridge <lina@yakshaving.ninja> - Wed, 12 Dec 2018 01:00:13 +0000 - rev 450164
Push 35190 by ccoroiu@mozilla.com at Wed, 12 Dec 2018 05:10:47 +0000
Bug 1512867 - Always update or upload synced bookmarks that only exist on one side. r=tcsc Differential Revision: https://phabricator.services.mozilla.com/D14034
575c5e68b8f19caf629b59c6bce4e6eb7c8159d4: Bug 1506287 - Check changed flags when merging child lists for local and remote nodes. r=tcsc
Lina Cambridge <lina@yakshaving.ninja> - Tue, 20 Nov 2018 02:21:08 +0000 - rev 447168
Push 35070 by aiakab@mozilla.com at Tue, 20 Nov 2018 09:34:57 +0000
Bug 1506287 - Check changed flags when merging child lists for local and remote nodes. r=tcsc Differential Revision: https://phabricator.services.mozilla.com/D12079
be95dcc90365a291775621517c22ac1b4f3e4ea2: Bug 1496878 - Ensure the bookmark merger flags newer locally moved children for reupload. r=tcsc
Lina Cambridge <lina@yakshaving.ninja> - Fri, 16 Nov 2018 01:19:49 +0000 - rev 446710
Push 35046 by btara@mozilla.com at Fri, 16 Nov 2018 09:46:36 +0000
Bug 1496878 - Ensure the bookmark merger flags newer locally moved children for reupload. r=tcsc This commit: * Changes the merger to flag locally moved children for reupload, along with their parents, if the local move is newer. * Replaces `valueState` and `structureState` in the merge states table with simpler flags. Rows with `useRemote` need to be updated in Places; rows with `shouldUpload` need change counter bumps. * `itemsToMerge` now accounts for local-only items with a `LEFT JOIN`. * Uses `shouldUpload` from the merged tree to set the change counters for all items, instead of relying on existing values and the `flagNewStructure` trigger to handle items with new structure. * Fixes keyword reuploading to handle the above, and match the non-mirror behavior. * Removes `structureCounts.new` from telemetry. Any merge with items added to the same folder on both sides will count as new structure, so it's not especially interesting. MozReview-Commit-ID: EktIBQN9FSY Depends on D11119 Differential Revision: https://phabricator.services.mozilla.com/D11120
0af4e03a28324571a26eb755a769c2f326533788: Bug 1438255 Part 2 Convert sync addon unit tests to use webextensions r=tcsc
Andrew Swan <aswan@mozilla.com> - Wed, 24 Oct 2018 13:26:06 -0700 - rev 443428
Push 34956 by rgurzau@mozilla.com at Tue, 30 Oct 2018 05:30:29 +0000
Bug 1438255 Part 2 Convert sync addon unit tests to use webextensions r=tcsc This isn't strictly part of removing support for non-restartless extensions, but it ensures that sync is testing with the types of extensions that people are really using these days. Differential Revision: https://phabricator.services.mozilla.com/D10111
63520174c8a5ec18cb71cf9c0ebaee790dfd5323: Bug 1438255 Part 1 Remove handling in sync for non-restartless addons r=tcsc
Andrew Swan <aswan@mozilla.com> - Mon, 29 Oct 2018 10:03:07 -0700 - rev 443427
Push 34956 by rgurzau@mozilla.com at Tue, 30 Oct 2018 05:30:29 +0000
Bug 1438255 Part 1 Remove handling in sync for non-restartless addons r=tcsc Differential Revision: https://phabricator.services.mozilla.com/D10110
5622861eb245cc20b3a121ffb73f1b58c9745934: Bug 1488899 - Get TPS working. r=tcsc
Mark Hammond <mhammond@skippinet.com.au> - Mon, 15 Oct 2018 22:42:22 +0000 - rev 441344
Push 34860 by nerli@mozilla.com at Tue, 16 Oct 2018 04:26:23 +0000
Bug 1488899 - Get TPS working. r=tcsc This patch disables a couple of tests, removes old async support from TPS, and puts more effort into preventing Syncs while TPS is running, and removed an unused import. Differential Revision: https://phabricator.services.mozilla.com/D8692
483e333ad24b323c1326a8df7414500c08ae433b: Bug 1492341 - Bump mozrunner version to 7.0.2; r=tcsc
Dave Hunt <dhunt@mozilla.com> - Thu, 20 Sep 2018 16:33:56 +0000 - rev 437714
Push 34693 by btara@mozilla.com at Fri, 21 Sep 2018 21:59:01 +0000
Bug 1492341 - Bump mozrunner version to 7.0.2; r=tcsc TPS is currently depending on mozrunner v7.0.1, which depends on an earlier version of mozprofile. For TPS to be able to use the latest version of mozprofile we need to release a new version of mozrunner with the recent mozprofile version identifier update. Differential Revision: https://phabricator.services.mozilla.com/D6406
8320750a187eaf04befb1921becbc866c3dd5bb3: Bug 1492010 - Ensure Sync engines with overridden telemetry names correctly report their validation results. r=tcsc
Lina Cambridge <lina@yakshaving.ninja> - Tue, 18 Sep 2018 08:04:57 +0000 - rev 436932
Push 34665 by ebalazs@mozilla.com at Tue, 18 Sep 2018 14:32:15 +0000
Bug 1492010 - Ensure Sync engines with overridden telemetry names correctly report their validation results. r=tcsc Differential Revision: https://phabricator.services.mozilla.com/D6097
66fb08227855c12a5362dc9027a3bddf125b6c39: Bug 1483017 - ensure Sync is initialized before disconnecting. r=tcsc
Mark Hammond <mhammond@skippinet.com.au> - Wed, 29 Aug 2018 01:29:19 +0000 - rev 433663
Push 34520 by ebalazs@mozilla.com at Wed, 29 Aug 2018 09:42:57 +0000
Bug 1483017 - ensure Sync is initialized before disconnecting. r=tcsc MozReview-Commit-ID: 8987f26wH16 Differential Revision: https://phabricator.services.mozilla.com/D4276
bca1895bb276e2f50401f2838ecb42d38b3d9c20: Bug 1484085 - don't log failure to obtain clients engine. r=tcsc
Mark Hammond <mhammond@skippinet.com.au> - Thu, 23 Aug 2018 02:00:27 +0000 - rev 432980
Push 34494 by rgurzau@mozilla.com at Thu, 23 Aug 2018 09:39:43 +0000
Bug 1484085 - don't log failure to obtain clients engine. r=tcsc MozReview-Commit-ID: Aj31c1OZnFf Differential Revision: https://phabricator.services.mozilla.com/D3657
3fd274a79d272c32e03b03993945688e087c7e56: Bug 1476393 - Record pwmgr histograms in sync ping r=markh,tcsc
irrationalagent <leifdoines@gmail.com> - Fri, 03 Aug 2018 09:30:06 -0600 - rev 431300
Push 34436 by ebalazs@mozilla.com at Tue, 14 Aug 2018 09:30:02 +0000
Bug 1476393 - Record pwmgr histograms in sync ping r=markh,tcsc MozReview-Commit-ID: CkZAwlCORtX
44517ac63b7ca1e1d8f71fe320cedd50b60c56fe: Bug 1476393 - Allow sync ping to contain histograms r=markh,tcsc
irrationalagent <leifdoines@gmail.com> - Fri, 03 Aug 2018 09:16:08 -0600 - rev 431299
Push 34436 by ebalazs@mozilla.com at Tue, 14 Aug 2018 09:30:02 +0000
Bug 1476393 - Allow sync ping to contain histograms r=markh,tcsc MozReview-Commit-ID: KztXiSPUCE5
b4af8690942566c964ee6a11be297c556a17c423: Bug 1479511 - modernize how TPS shuts down Firefox. r=tcsc
Mark Hammond <mhammond@skippinet.com.au> - Wed, 08 Aug 2018 20:59:30 +0000 - rev 430581
Push 34409 by toros@mozilla.com at Thu, 09 Aug 2018 10:00:05 +0000
Bug 1479511 - modernize how TPS shuts down Firefox. r=tcsc MozReview-Commit-ID: EzhGbhPCiOV Differential Revision: https://phabricator.services.mozilla.com/D2546
e7eb8b37d85e58a3890867ffa4704dcf2085cdb7: Bug 1478558 - Remove usage of http://mozqa.com/ in services/sync/tests/tps/test_tabs.js r=whimboo,tcsc
Mark Hammond <mhammond@skippinet.com.au> - Wed, 08 Aug 2018 20:59:24 +0000 - rev 430579
Push 34409 by toros@mozilla.com at Thu, 09 Aug 2018 10:00:05 +0000
Bug 1478558 - Remove usage of http://mozqa.com/ in services/sync/tests/tps/test_tabs.js r=whimboo,tcsc MozReview-Commit-ID: Gd8qmfBWf8u Differential Revision: https://phabricator.services.mozilla.com/D2547
3535c07b0da95bee0bfb7d5279a08fa9d92e07f1: Bug 1479998 - use PlacesUtils to get a tab's favicon rather than SessionStore. r=tcsc
Mark Hammond <mhammond@skippinet.com.au> - Wed, 01 Aug 2018 16:41:26 +0000 - rev 429759
Push 34373 by csabou@mozilla.com at Thu, 02 Aug 2018 13:09:17 +0000
Bug 1479998 - use PlacesUtils to get a tab's favicon rather than SessionStore. r=tcsc MozReview-Commit-ID: DdYbW5r9JfF Differential Revision: https://phabricator.services.mozilla.com/D2592
bc3f6f7249edd9d126669ba7a4f22b49eddbc6b3: Bug 1478547 - exceptions processing sync logins now bubble up for better handling and recovery. r=tcsc
Mark Hammond <mhammond@skippinet.com.au> - Thu, 26 Jul 2018 05:38:03 +0000 - rev 428421
Push 34335 by shindli@mozilla.com at Thu, 26 Jul 2018 11:19:11 +0000
Bug 1478547 - exceptions processing sync logins now bubble up for better handling and recovery. r=tcsc MozReview-Commit-ID: 3y8ryBxueFS Differential Revision: https://phabricator.services.mozilla.com/D2408
b22dd03454ff403ad5bd671f7204b532bb3bd202: Bug 1476393 - Document histograms in sync ping and add pwmgr prompt histograms r=tcsc
irrationalagent <leifdoines@gmail.com> - Tue, 26 Jun 2018 18:39:15 +0100 - rev 428059
Push 34326 by archaeopteryx@coole-files.de at Wed, 25 Jul 2018 14:15:13 +0000
Bug 1476393 - Document histograms in sync ping and add pwmgr prompt histograms r=tcsc MozReview-Commit-ID: 3Xqnp9g4pT9
cb876d3e8a6971873881ab12916f43c0330cf0ef: Bug 1476393 - Allow Histograms to Be Sent In Sync Ping r=tcsc
irrationalagent <leifdoines@gmail.com> - Tue, 19 Jun 2018 13:48:47 +0200 - rev 428058
Push 34326 by archaeopteryx@coole-files.de at Wed, 25 Jul 2018 14:15:13 +0000
Bug 1476393 - Allow Histograms to Be Sent In Sync Ping r=tcsc MozReview-Commit-ID: HhtcE5PF2sC
4b14023b1a14b91260f62ff2ebbd76056bf91bd7: Bug 1471757 - Use 'valid' credit card numbers in tps tests. r=tcsc
Edouard Oger <eoger@fastmail.com> - Wed, 27 Jun 2018 19:14:43 -0400 - rev 424184
Push 34200 by shindli@mozilla.com at Thu, 28 Jun 2018 21:52:47 +0000
Bug 1471757 - Use 'valid' credit card numbers in tps tests. r=tcsc MozReview-Commit-ID: 668ycAESHtE
40eebd227af715e57e99c97ec0e46aca0ae90e4e: Bug 1466899 - TPS now checks the name from the clients collection rather than the tabs collection. r=tcsc
Mark Hammond <mhammond@skippinet.com.au> - Tue, 26 Jun 2018 00:34:59 +0000 - rev 423996
Push 34197 by csabou@mozilla.com at Thu, 28 Jun 2018 09:44:02 +0000
Bug 1466899 - TPS now checks the name from the clients collection rather than the tabs collection. r=tcsc MozReview-Commit-ID: K9Vep0k2nRF Differential Revision: https://phabricator.services.mozilla.com/D1819
c7ee94e1b547524c8fc2453318a8919aca9139d0: Bug 1466940 - Add logging of tabs in TPS to assist with investigating test failures; r=tcsc
Dave Hunt <dhunt@mozilla.com> - Tue, 05 Jun 2018 21:49:59 +0100 - rev 421557
Push 34097 by nbeleuzu@mozilla.com at Wed, 06 Jun 2018 16:59:16 +0000
Bug 1466940 - Add logging of tabs in TPS to assist with investigating test failures; r=tcsc MozReview-Commit-ID: AW7RrtglYEN
9f37295358eb90ce22866d24a0ff2641db3953a0: Bug 1461009 - Rework bookmarks mirror event telemetry. r=tcsc
Kit Cambridge <kit@yakshaving.ninja> - Thu, 10 May 2018 18:25:20 -0700 - rev 419315
Push 34036 by dluca@mozilla.com at Wed, 23 May 2018 09:50:27 +0000
Bug 1461009 - Rework bookmarks mirror event telemetry. r=tcsc MozReview-Commit-ID: L5pXbAaclDe
84da15c4f7797cae68b7dcc08deb00e7a5b89491: Bug 1461009 - Move extra event telemetry field normalization into Sync. r=tcsc
Kit Cambridge <kit@yakshaving.ninja> - Thu, 10 May 2018 18:23:51 -0700 - rev 419314
Push 34036 by dluca@mozilla.com at Wed, 23 May 2018 09:50:27 +0000
Bug 1461009 - Move extra event telemetry field normalization into Sync. r=tcsc MozReview-Commit-ID: 8Par4kHJ958
ce656fdc2dd47f62b7467715037ee5f94d62ef10: Bug 1461009 - Remove ignore count event telemetry from the bookmarks mirror. r=tcsc
Kit Cambridge <kit@yakshaving.ninja> - Thu, 10 May 2018 18:22:37 -0700 - rev 419313
Push 34036 by dluca@mozilla.com at Wed, 23 May 2018 09:50:27 +0000
Bug 1461009 - Remove ignore count event telemetry from the bookmarks mirror. r=tcsc MozReview-Commit-ID: Hp45TfQRmpM
77b189833de1067c21f8230d6c68a29f1e4d7455: Bug 1460396 - Make notifyHistoryObservers an arrow function. r=tcsc
Edouard Oger <eoger@fastmail.com> - Wed, 09 May 2018 15:26:04 -0400 - rev 417826
Push 33980 by ebalazs@mozilla.com at Fri, 11 May 2018 09:35:12 +0000
Bug 1460396 - Make notifyHistoryObservers an arrow function. r=tcsc MozReview-Commit-ID: B4BPE98YxEi