searching for reviewer(tcampbell)
a320eb1a5edd48a4d02ccd948479a4394a454efc: Bug 1704385: Fix testcases r=tcampbell
Iain Ireland <iireland@mozilla.com> - Thu, 16 Jun 2022 22:01:05 +0000 - rev 621218
Push 39861 by nfay@mozilla.com at Fri, 17 Jun 2022 09:39:07 +0000
Bug 1704385: Fix testcases r=tcampbell Some of the non262 tests were failing after I rebased. It turns out that the tests themselves were wrong. Differential Revision: https://phabricator.services.mozilla.com/D148329
c5264944735156b47fad10bf7f74252868f1733d: Bug 1773778 - Part 17: Remove deprecated HeapPtrValue typedef r=tcampbell
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 14 Jun 2022 12:30:14 +0000 - rev 620854
Push 39850 by ctuns@mozilla.com at Tue, 14 Jun 2022 21:37:29 +0000
Bug 1773778 - Part 17: Remove deprecated HeapPtrValue typedef r=tcampbell Depends on D149126 Differential Revision: https://phabricator.services.mozilla.com/D149127
ab09f34fcbac64122185a8c861b1fe127fc62bb3: Bug 1773778 - Part 16: Remove deprecated HeapPtrObject typedef r=tcampbell
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 14 Jun 2022 12:30:14 +0000 - rev 620853
Push 39850 by ctuns@mozilla.com at Tue, 14 Jun 2022 21:37:29 +0000
Bug 1773778 - Part 16: Remove deprecated HeapPtrObject typedef r=tcampbell Depends on D149125 Differential Revision: https://phabricator.services.mozilla.com/D149126
07c65bc3ea1b4b490d20352e40af9bb0990d7e1d: Bug 1773778 - Part 15: Remove deprecated HeapPtrJitCode typedef r=tcampbell
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 14 Jun 2022 12:30:13 +0000 - rev 620852
Push 39850 by ctuns@mozilla.com at Tue, 14 Jun 2022 21:37:29 +0000
Bug 1773778 - Part 15: Remove deprecated HeapPtrJitCode typedef r=tcampbell Depends on D149124 Differential Revision: https://phabricator.services.mozilla.com/D149125
8850e9d9c9627c10f3a7870ebdff174ae58bd915: Bug 1773778 - Part 14: Remove deprecated WeakHeapPtrSymbol typedef r=tcampbell
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 14 Jun 2022 12:30:13 +0000 - rev 620851
Push 39850 by ctuns@mozilla.com at Tue, 14 Jun 2022 21:37:29 +0000
Bug 1773778 - Part 14: Remove deprecated WeakHeapPtrSymbol typedef r=tcampbell Depends on D149123 Differential Revision: https://phabricator.services.mozilla.com/D149124
9b7a702f152ec73c5d44ed2471d84f7bb8ee425c: Bug 1773778 - Part 13: Remove deprecated WeakHeapPtrJitCode typedef r=tcampbell
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 14 Jun 2022 12:30:13 +0000 - rev 620850
Push 39850 by ctuns@mozilla.com at Tue, 14 Jun 2022 21:37:29 +0000
Bug 1773778 - Part 13: Remove deprecated WeakHeapPtrJitCode typedef r=tcampbell Depends on D149122 Differential Revision: https://phabricator.services.mozilla.com/D149123
67684221a8bb89c9d69b2d17b505804b15c9501c: Bug 1773778 - Part 12: Remove deprecated WeakHeapPtrDebugEnvironmentProxy typedef r=tcampbell
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 14 Jun 2022 12:30:12 +0000 - rev 620849
Push 39850 by ctuns@mozilla.com at Tue, 14 Jun 2022 21:37:29 +0000
Bug 1773778 - Part 12: Remove deprecated WeakHeapPtrDebugEnvironmentProxy typedef r=tcampbell Depends on D149121 Differential Revision: https://phabricator.services.mozilla.com/D149122
9a70b30342a185fc3d75ba817c592991f9b873b1: Bug 1773778 - Part 11: Remove deprecated WeakHeapPtrAtom typedef r=tcampbell
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 14 Jun 2022 12:30:12 +0000 - rev 620848
Push 39850 by ctuns@mozilla.com at Tue, 14 Jun 2022 21:37:29 +0000
Bug 1773778 - Part 11: Remove deprecated WeakHeapPtrAtom typedef r=tcampbell Depends on D149120 Differential Revision: https://phabricator.services.mozilla.com/D149121
b57c960a182378249376f747608cf5a2fd5eed9c: Bug 1773778 - Part 10: Remove deprecated ImmutableSymbolPtr typedef r=tcampbell
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 14 Jun 2022 12:30:11 +0000 - rev 620847
Push 39850 by ctuns@mozilla.com at Tue, 14 Jun 2022 21:37:29 +0000
Bug 1773778 - Part 10: Remove deprecated ImmutableSymbolPtr typedef r=tcampbell Depends on D149119 Differential Revision: https://phabricator.services.mozilla.com/D149120
72a47bfe4e5cdcb3efac7b09460fc62b2b74f53b: Bug 1773778 - Part 9: Remove deprecated ImmutablePropertyNamePtr typedef r=tcampbell
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 14 Jun 2022 12:30:11 +0000 - rev 620846
Push 39850 by ctuns@mozilla.com at Tue, 14 Jun 2022 21:37:29 +0000
Bug 1773778 - Part 9: Remove deprecated ImmutablePropertyNamePtr typedef r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D149119
1c994fe58dc79c72aae48a57b0e561eddb097fa0: Bug 1773778 - Part 8: Remove deprecated GCPtrValue typedef r=tcampbell
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 14 Jun 2022 12:30:11 +0000 - rev 620845
Push 39850 by ctuns@mozilla.com at Tue, 14 Jun 2022 21:37:29 +0000
Bug 1773778 - Part 8: Remove deprecated GCPtrValue typedef r=tcampbell Depends on D149117 Differential Revision: https://phabricator.services.mozilla.com/D149118
eaa6af639ae0d9c53d65f477307237ccccd374c7: Bug 1773778 - Part 7: Remove deprecated GCPtrObject typedef r=tcampbell
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 14 Jun 2022 12:30:10 +0000 - rev 620844
Push 39850 by ctuns@mozilla.com at Tue, 14 Jun 2022 21:37:29 +0000
Bug 1773778 - Part 7: Remove deprecated GCPtrObject typedef r=tcampbell Depends on D149116 Differential Revision: https://phabricator.services.mozilla.com/D149117
592fd3c8debbc41862d6895242ca01a028e7002b: Bug 1773778 - Part 6: Remove deprecated GCPtrLinearString typedef r=tcampbell
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 14 Jun 2022 12:30:10 +0000 - rev 620843
Push 39850 by ctuns@mozilla.com at Tue, 14 Jun 2022 21:37:29 +0000
Bug 1773778 - Part 6: Remove deprecated GCPtrLinearString typedef r=tcampbell Depends on D149115 Differential Revision: https://phabricator.services.mozilla.com/D149116
a9f08ad1497f2d5c4ef3a4230a8524fd13d186b0: Bug 1773778 - Part 5: Remove depreacted GCPtrFunction typedef r=tcampbell
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 14 Jun 2022 12:30:09 +0000 - rev 620842
Push 39850 by ctuns@mozilla.com at Tue, 14 Jun 2022 21:37:29 +0000
Bug 1773778 - Part 5: Remove depreacted GCPtrFunction typedef r=tcampbell Depends on D149114 Differential Revision: https://phabricator.services.mozilla.com/D149115
de60b0087d84be9d604a4989d40f9af55db8e586: Bug 1773778 - Part 4: Remove deprecated GCPtrAtom typedef r=tcampbell
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 14 Jun 2022 12:30:09 +0000 - rev 620841
Push 39850 by ctuns@mozilla.com at Tue, 14 Jun 2022 21:37:29 +0000
Bug 1773778 - Part 4: Remove deprecated GCPtrAtom typedef r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D149114
7c481f5d479035a99f2a4b27b8fdfa21c58641a7: Bug 1773778 - Part 3: Remove deprecated PreBarrieredValue typedef r=tcampbell
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 14 Jun 2022 12:30:08 +0000 - rev 620840
Push 39850 by ctuns@mozilla.com at Tue, 14 Jun 2022 21:37:29 +0000
Bug 1773778 - Part 3: Remove deprecated PreBarrieredValue typedef r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D149113
e3c016c6d10c1961a33fa0af19b77880436ad51b: Bug 1773778 - Part 2: Remove deprecated PreBarrieredId typedef r=tcampbell
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 14 Jun 2022 12:30:08 +0000 - rev 620839
Push 39850 by ctuns@mozilla.com at Tue, 14 Jun 2022 21:37:29 +0000
Bug 1773778 - Part 2: Remove deprecated PreBarrieredId typedef r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D149112
00a20c4add665f094e0713a5a67715b70670f7b9: Bug 1773778 - Part 1: Remove unsued typedefs r=tcampbell
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 14 Jun 2022 12:30:08 +0000 - rev 620838
Push 39850 by ctuns@mozilla.com at Tue, 14 Jun 2022 21:37:29 +0000
Bug 1773778 - Part 1: Remove unsued typedefs r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D149111
0b95325e435a1e3d92a17e21cb7d0dd44112e59e: Bug 1763606 - Part 8: Support calling detachArrayBuffer on detached array buffer objects . r=tcampbell
André Bargull <andre.bargull@gmail.com> - Wed, 08 Jun 2022 14:40:55 +0000 - rev 620126
Push 39819 by nbeleuzu@mozilla.com at Wed, 08 Jun 2022 21:48:24 +0000
Bug 1763606 - Part 8: Support calling detachArrayBuffer on detached array buffer objects . r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D145729
416ec1f14c2d50416c5b5636bdbf962c8861a7e1: Bug 1763606 - Part 7: Remove detached ArrayBuffer checks from TypedArray.prototype.sort comparator. r=tcampbell
André Bargull <andre.bargull@gmail.com> - Wed, 08 Jun 2022 14:40:54 +0000 - rev 620125
Push 39819 by nbeleuzu@mozilla.com at Wed, 08 Jun 2022 21:48:24 +0000
Bug 1763606 - Part 7: Remove detached ArrayBuffer checks from TypedArray.prototype.sort comparator. r=tcampbell Remove the check per <https://github.com/tc39/ecma262/pull/2723>. Depends on D143290 Differential Revision: https://phabricator.services.mozilla.com/D143291
0dc0d70ce93be9d380a3cc4add994385869aa116: Bug 1763606 - Part 6: Copy shared memory for RadixSort. r=tcampbell
André Bargull <andre.bargull@gmail.com> - Wed, 08 Jun 2022 14:40:54 +0000 - rev 620124
Push 39819 by nbeleuzu@mozilla.com at Wed, 08 Jun 2022 21:48:24 +0000
Bug 1763606 - Part 6: Copy shared memory for RadixSort. r=tcampbell Similar to part 5, concurrent write accesses shouldn't affect the sort algorithm. Depends on D143289 Differential Revision: https://phabricator.services.mozilla.com/D143290
d76311eb2427a5f01e694a17624026d7a6c9c691: Bug 1763606 - Part 5: Sort TypedArray elements in a temporary buffer. r=tcampbell
André Bargull <andre.bargull@gmail.com> - Wed, 08 Jun 2022 14:40:54 +0000 - rev 620123
Push 39819 by nbeleuzu@mozilla.com at Wed, 08 Jun 2022 21:48:24 +0000
Bug 1763606 - Part 5: Sort TypedArray elements in a temporary buffer. r=tcampbell <https://github.com/tc39/ecma262/pull/1585> changed `Array.prototype.sort` to first collect all elements in a temporary list. And because `TypedArray.prototype.sort` follows `Array.prototype.sort`, the same copying has to happen here. Depends on D143288 Differential Revision: https://phabricator.services.mozilla.com/D143289
b69a3b47f56df90b8d2d1c0af2dfbf27bf339c74: Bug 1763606 - Part 4: Add a test case for concurrent modifications when sorting. r=tcampbell
André Bargull <andre.bargull@gmail.com> - Wed, 08 Jun 2022 14:40:53 +0000 - rev 620122
Push 39819 by nbeleuzu@mozilla.com at Wed, 08 Jun 2022 21:48:24 +0000
Bug 1763606 - Part 4: Add a test case for concurrent modifications when sorting. r=tcampbell Depends on D143287 Differential Revision: https://phabricator.services.mozilla.com/D143288
2c8f470e2be863d4fd3f5e111a697c58272b2c01: Bug 1763606 - Part 3: Port TypedArray RadixSort function to C++. r=tcampbell
André Bargull <andre.bargull@gmail.com> - Wed, 08 Jun 2022 14:40:53 +0000 - rev 620121
Push 39819 by nbeleuzu@mozilla.com at Wed, 08 Jun 2022 21:48:24 +0000
Bug 1763606 - Part 3: Port TypedArray RadixSort function to C++. r=tcampbell An almost direct translation of the JS implementation to C++. In contrast to the JS implementation, we're using a smaller fallback to `std::sort`, because the C++ implementation is faster, but we're also calling into `std::sort` for large arrays to avoid allocating a large heap buffer. As a further improvement, the radix sort implementation calls the counting sort function for 16-bit types when the number of elements reaches `2^16`. That way we can further reduce the number of allocated heap memory. The pre- and post-process steps from the JS implementation can be omitted, because we can directly interpret the TypedArray memory contents as unsigned integers in C++. The concurrent write access handling in `SortByColumn` is necessary to avoid an out-of-bounds access when a different thread writes to the same shared memory location. This was also an issue in the JS implementation, except the only visible outcome in that implementation was that the internal `aux` array could leak to the user. Depends on D143286 Differential Revision: https://phabricator.services.mozilla.com/D143287
b245af1692e134a44e9d6d503ed5b3793eb5532f: Bug 1763606 - Part 2: Port TypedArray CountingSort function to C++. r=tcampbell
André Bargull <andre.bargull@gmail.com> - Wed, 08 Jun 2022 14:40:52 +0000 - rev 620120
Push 39819 by nbeleuzu@mozilla.com at Wed, 08 Jun 2022 21:48:24 +0000
Bug 1763606 - Part 2: Port TypedArray CountingSort function to C++. r=tcampbell Direct translation of the JS counting sort implementation to C++. The stack allocated buffer has inline storage to store the complete uint8_t range. (This function will also be used in the next part for uint16_t, but in that case the complete buffer will be heap allocated.) The C++ implementation is faster than the JS implementation and therefore we can use a smaller limit when we fallback to `std::sort` for small arrays. Depends on D143285 Differential Revision: https://phabricator.services.mozilla.com/D143286
0214766ba07230c9ed06175b6ee647fcfe5f15ac: Bug 1763606 - Part 1: Replace TypedArray QuickSort JS-function with C++. r=tcampbell
André Bargull <andre.bargull@gmail.com> - Wed, 08 Jun 2022 14:40:52 +0000 - rev 620119
Push 39819 by nbeleuzu@mozilla.com at Wed, 08 Jun 2022 21:48:24 +0000
Bug 1763606 - Part 1: Replace TypedArray QuickSort JS-function with C++. r=tcampbell Invoke `std::sort` without a comparator function for integral types including `uint8_clamped`. For floating point types invoke `std::sort` with a comparator function to ensure negative zero is sorted before positive zero. To further improve the performance when sorting floating point numbers, compare numbers using their unsigned sort value using the same approach as currently used in RadixSort. When the backing buffer is a SharedArrayBuffer, we need to copy the TypedArray contents to avoid UB in std::sort when a different thread is modifying the same SharedArrayBuffer memory. The next two patches in this queue will provide specialisations for `TypedArraySort()` to select faster sort algorithms than `std::sort` for certain TypedArray element types. Differential Revision: https://phabricator.services.mozilla.com/D143285
9ef1c94e04f7c76943f944c6d17f2545e44ce016: Bug 1771084 part 2 - Add Realm option to freeze builtins. r=tcampbell,nika
Jan de Mooij <jdemooij@mozilla.com> - Tue, 07 Jun 2022 15:40:44 +0000 - rev 619969
Push 39813 by nfay@mozilla.com at Wed, 08 Jun 2022 03:52:13 +0000
Bug 1771084 part 2 - Add Realm option to freeze builtins. r=tcampbell,nika Differential Revision: https://phabricator.services.mozilla.com/D147281
5b47e7f223fa7f9b54e8e805ec61ada3538b617a: Bug 1772234 - Update the style guide to deprecate rooting API typedefs. r=tcampbell
Bobby Holley <bobbyholley@gmail.com> - Thu, 02 Jun 2022 21:01:42 +0000 - rev 619609
Push 39788 by nfay@mozilla.com at Fri, 03 Jun 2022 03:41:38 +0000
Bug 1772234 - Update the style guide to deprecate rooting API typedefs. r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D148081
566613faa2d316a0727a883bebc33950d0b8cc63: Bug 1771124 - Remove unused GlobalObject::initBuiltinConstructor. r=tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Wed, 01 Jun 2022 10:06:07 +0000 - rev 619399
Push 39781 by nbeleuzu@mozilla.com at Wed, 01 Jun 2022 15:47:02 +0000
Bug 1771124 - Remove unused GlobalObject::initBuiltinConstructor. r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D147277
7fce0c26d9ce9e3340a815b13e5c77452e5c3fb0: Bug 1770048: Improve self-hosted new_List r=jandem,tcampbell
Iain Ireland <iireland@mozilla.com> - Thu, 19 May 2022 14:30:10 +0000 - rev 618246
Push 39720 by nbeleuzu@mozilla.com at Thu, 19 May 2022 18:03:18 +0000
Bug 1770048: Improve self-hosted new_List r=jandem,tcampbell Differential Revision: https://phabricator.services.mozilla.com/D146760
cac8af0a354284932bf33e385ae401e860c2efc7: Bug 1763606 - Part 7: Remove detached ArrayBuffer checks from TypedArray.prototype.sort comparator. r=tcampbell
André Bargull <andre.bargull@gmail.com> - Fri, 06 May 2022 07:31:27 +0000 - rev 616434
Push 39659 by csabou@mozilla.com at Fri, 06 May 2022 21:56:34 +0000
Bug 1763606 - Part 7: Remove detached ArrayBuffer checks from TypedArray.prototype.sort comparator. r=tcampbell Remove the check per <https://github.com/tc39/ecma262/pull/2723>. Depends on D143290 Differential Revision: https://phabricator.services.mozilla.com/D143291
993971e98bc6ce439d384949eaca9fcd8e42b509: Bug 1763606 - Part 6: Copy shared memory for RadixSort. r=tcampbell
André Bargull <andre.bargull@gmail.com> - Fri, 06 May 2022 07:31:26 +0000 - rev 616433
Push 39659 by csabou@mozilla.com at Fri, 06 May 2022 21:56:34 +0000
Bug 1763606 - Part 6: Copy shared memory for RadixSort. r=tcampbell Similar to part 5, concurrent write accesses shouldn't affect the sort algorithm. Depends on D143289 Differential Revision: https://phabricator.services.mozilla.com/D143290
1e0e956513ab1f1e8fb6ed20051244aaa39b8018: Bug 1763606 - Part 5: Sort TypedArray elements in a temporary buffer. r=tcampbell
André Bargull <andre.bargull@gmail.com> - Fri, 06 May 2022 07:31:26 +0000 - rev 616432
Push 39659 by csabou@mozilla.com at Fri, 06 May 2022 21:56:34 +0000
Bug 1763606 - Part 5: Sort TypedArray elements in a temporary buffer. r=tcampbell <https://github.com/tc39/ecma262/pull/1585> changed `Array.prototype.sort` to first collect all elements in a temporary list. And because `TypedArray.prototype.sort` follows `Array.prototype.sort`, the same copying has to happen here. Depends on D143288 Differential Revision: https://phabricator.services.mozilla.com/D143289
e477519e66c57300661c3e9c737cff294eca2c40: Bug 1763606 - Part 4: Add a test case for concurrent modifications when sorting. r=tcampbell
André Bargull <andre.bargull@gmail.com> - Fri, 06 May 2022 07:31:26 +0000 - rev 616431
Push 39659 by csabou@mozilla.com at Fri, 06 May 2022 21:56:34 +0000
Bug 1763606 - Part 4: Add a test case for concurrent modifications when sorting. r=tcampbell Depends on D143287 Differential Revision: https://phabricator.services.mozilla.com/D143288
403a6eebf0a4e26010e1b4b896fb0209b53f74ef: Bug 1763606 - Part 3: Port TypedArray RadixSort function to C++. r=tcampbell
André Bargull <andre.bargull@gmail.com> - Fri, 06 May 2022 07:31:25 +0000 - rev 616430
Push 39659 by csabou@mozilla.com at Fri, 06 May 2022 21:56:34 +0000
Bug 1763606 - Part 3: Port TypedArray RadixSort function to C++. r=tcampbell An almost direct translation of the JS implementation to C++. In contrast to the JS implementation, we're using a smaller fallback to `std::sort`, because the C++ implementation is faster, but we're also calling into `std::sort` for large arrays to avoid allocating a large heap buffer. As a further improvement, the radix sort implementation calls the counting sort function for 16-bit types when the number of elements reaches `2^16`. That way we can further reduce the number of allocated heap memory. The pre- and post-process steps from the JS implementation can be omitted, because we can directly interpret the TypedArray memory contents as unsigned integers in C++. The concurrent write access handling in `SortByColumn` is necessary to avoid an out-of-bounds access when a different thread writes to the same shared memory location. This was also an issue in the JS implementation, except the only visible outcome in that implementation was that the internal `aux` array could leak to the user. Depends on D143286 Differential Revision: https://phabricator.services.mozilla.com/D143287
5d55dc85cdbe888d019482f1eddc3bf28077bbfa: Bug 1763606 - Part 2: Port TypedArray CountingSort function to C++. r=tcampbell
André Bargull <andre.bargull@gmail.com> - Fri, 06 May 2022 07:31:25 +0000 - rev 616429
Push 39659 by csabou@mozilla.com at Fri, 06 May 2022 21:56:34 +0000
Bug 1763606 - Part 2: Port TypedArray CountingSort function to C++. r=tcampbell Direct translation of the JS counting sort implementation to C++. The stack allocated buffer has inline storage to store the complete uint8_t range. (This function will also be used in the next part for uint16_t, but in that case the complete buffer will be heap allocated.) The C++ implementation is faster than the JS implementation and therefore we can use a smaller limit when we fallback to `std::sort` for small arrays. Depends on D143285 Differential Revision: https://phabricator.services.mozilla.com/D143286
80dc9032e75f9e8fc36b9e63d71c28f3e47f2f35: Bug 1763606 - Part 1: Replace TypedArray QuickSort JS-function with C++. r=tcampbell
André Bargull <andre.bargull@gmail.com> - Fri, 06 May 2022 07:31:24 +0000 - rev 616428
Push 39659 by csabou@mozilla.com at Fri, 06 May 2022 21:56:34 +0000
Bug 1763606 - Part 1: Replace TypedArray QuickSort JS-function with C++. r=tcampbell Invoke `std::sort` without a comparator function for integral types including `uint8_clamped`. For floating point types invoke `std::sort` with a comparator function to ensure negative zero is sorted before positive zero. To further improve the performance when sorting floating point numbers, compare numbers using their unsigned sort value using the same approach as currently used in RadixSort. When the backing buffer is a SharedArrayBuffer, we need to copy the TypedArray contents to avoid UB in std::sort when a different thread is modifying the same SharedArrayBuffer memory. The next two patches in this queue will provide specialisations for `TypedArraySort()` to select faster sort algorithms than `std::sort` for certain TypedArray element types. Differential Revision: https://phabricator.services.mozilla.com/D143285
71c453477e4e85a2ad40148972b64e39ca6fbd8b: Bug 1767394: Save any pending exceptions before closing iterators from Ion. r=tcampbell
André Bargull <andre.bargull@gmail.com> - Wed, 04 May 2022 15:00:20 +0000 - rev 616133
Push 39649 by mlaza@mozilla.com at Wed, 04 May 2022 23:45:51 +0000
Bug 1767394: Save any pending exceptions before closing iterators from Ion. r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D145330
d0bbd66c2ca7f4f911dfb671ca446753e80f005a: Bug 1766840: Don't call tzset for WASI. r=tcampbell
André Bargull <andre.bargull@gmail.com> - Thu, 28 Apr 2022 13:34:32 +0000 - rev 615577
Push 39625 by nfay@mozilla.com at Thu, 28 Apr 2022 21:47:15 +0000
Bug 1766840: Don't call tzset for WASI. r=tcampbell WASI doesn't support `tzset`. Differential Revision: https://phabricator.services.mozilla.com/D144948
c9baea28c7fb3500326eec79fe745fdb11369049: Bug 1740481: Explicitly call tzset before localtime_r and localtime_s. r=tcampbell,bthrall
André Bargull <andre.bargull@gmail.com> - Thu, 28 Apr 2022 12:14:10 +0000 - rev 615575
Push 39625 by nfay@mozilla.com at Thu, 28 Apr 2022 21:47:15 +0000
Bug 1740481: Explicitly call tzset before localtime_r and localtime_s. r=tcampbell,bthrall Neither `localtime_r` nor `localtime_s` are required to act as if `tzset` has been called. So if we want to detect any time zone changes, we need to call it explicitly. Differential Revision: https://phabricator.services.mozilla.com/D130876
c90b12354d4c3a6bc6ca2fc2ccb01202a20b2205: Bug 1763605 - Part 2: Don't throw for detached array buffers in TypedArray.prototype.set. r=tcampbell
André Bargull <andre.bargull@gmail.com> - Tue, 19 Apr 2022 13:35:08 +0000 - rev 614588
Push 39588 by mlaza@mozilla.com at Tue, 19 Apr 2022 21:46:07 +0000
Bug 1763605 - Part 2: Don't throw for detached array buffers in TypedArray.prototype.set. r=tcampbell Per <https://github.com/tc39/ecma262/pull/2646>. Depends on D143568 Differential Revision: https://phabricator.services.mozilla.com/D143569
6de961f4203e5f4ecea5b709735014a274011b2b: Bug 1763605 - Part 1: Add separate SetTypedArrayFromTypedArray and SetTypedArrayFromArrayLike functions. r=tcampbell
André Bargull <andre.bargull@gmail.com> - Tue, 19 Apr 2022 13:35:08 +0000 - rev 614587
Push 39588 by mlaza@mozilla.com at Tue, 19 Apr 2022 21:46:07 +0000
Bug 1763605 - Part 1: Add separate SetTypedArrayFromTypedArray and SetTypedArrayFromArrayLike functions. r=tcampbell Add separate `SetTypedArrayFromTypedArray` and `SetTypedArrayFromArrayLike` functions to follow the spec more closely. And update step numbers to match the current draft spec. Differential Revision: https://phabricator.services.mozilla.com/D143568
2a9c7ca887128f70c6869e4a8a12b0d4f9c4cd51: Bug 1763996: Handle NaN values in ComparatorNumeric. r=tcampbell
André Bargull <andre.bargull@gmail.com> - Wed, 13 Apr 2022 08:04:32 +0000 - rev 614142
Push 39558 by nfay@mozilla.com at Wed, 13 Apr 2022 18:06:38 +0000
Bug 1763996: Handle NaN values in ComparatorNumeric. r=tcampbell Normalising `NaN` comparator results to `0` was added in ES6, but the two numeric comparator functions were never updated to include this change. Differential Revision: https://phabricator.services.mozilla.com/D143337
6bd3fdf782d23cedc310cf05a08ef8b56c436fb2: Bug 1763996: Handle NaN values in ComparatorNumeric. r=tcampbell
André Bargull <andre.bargull@gmail.com> - Tue, 12 Apr 2022 09:30:53 +0000 - rev 614030
Push 39553 by nfay@mozilla.com at Tue, 12 Apr 2022 15:57:11 +0000
Bug 1763996: Handle NaN values in ComparatorNumeric. r=tcampbell Normalising `NaN` comparator results to `0` was added in ES6, but the two numeric comparator functions were never updated to include this change. Differential Revision: https://phabricator.services.mozilla.com/D143337
a9a3140427ea922ae2b05d3c0e496c0c85fb4b75: Bug 1762933 - Part 3: Fix implicit this-capture in lambdas. r=tcampbell
André Bargull <andre.bargull@gmail.com> - Tue, 05 Apr 2022 11:53:42 +0000 - rev 613387
Push 39523 by ctuns@mozilla.com at Tue, 05 Apr 2022 21:23:13 +0000
Bug 1762933 - Part 3: Fix implicit this-capture in lambdas. r=tcampbell Implicit `this` capture through `=` is deprecated in C++20. Differential Revision: https://phabricator.services.mozilla.com/D142857
b1a9775198ab669efa4b222f0b32d0774ee7996b: Bug 1762933 - Part 2: Fix implicit coercion between different enum types. r=tcampbell
André Bargull <andre.bargull@gmail.com> - Tue, 05 Apr 2022 11:53:41 +0000 - rev 613386
Push 39523 by ctuns@mozilla.com at Tue, 05 Apr 2022 21:23:13 +0000
Bug 1762933 - Part 2: Fix implicit coercion between different enum types. r=tcampbell Use `std::underlying_type_t` to convert from an enum to its underlying type. Depends on D142855 Differential Revision: https://phabricator.services.mozilla.com/D142856
14e582a97f5fa9a55b20409fbf7c011681b3d9dd: Bug 1762933 - Part 1: Avoid static_cast on non-integral types. r=tcampbell
André Bargull <andre.bargull@gmail.com> - Tue, 05 Apr 2022 11:53:41 +0000 - rev 613385
Push 39523 by ctuns@mozilla.com at Tue, 05 Apr 2022 21:23:13 +0000
Bug 1762933 - Part 1: Avoid static_cast on non-integral types. r=tcampbell Otherwise we can for example end up with generating `static_cast` between const and non-const pointers. Differential Revision: https://phabricator.services.mozilla.com/D142855
3d561c34f1131677a4f84fe6b5746082d0d0dc64: Bug 1761581 - Directly report errors in self-hosted code. r=tcampbell
Tooru Fujisawa <arai_a@mac.com> - Fri, 01 Apr 2022 21:20:13 +0000 - rev 613183
Push 39506 by nbeleuzu@mozilla.com at Sat, 02 Apr 2022 09:44:13 +0000
Bug 1761581 - Directly report errors in self-hosted code. r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D142353
40c4a9994215625e495b7690dc24e589187cf111: Bug 1756592: Cache forced-return in ExceptionBailoutInfo r=tcampbell
Iain Ireland <iireland@mozilla.com> - Thu, 31 Mar 2022 22:42:25 +0000 - rev 612945
Push 39503 by ncsoregi@mozilla.com at Fri, 01 Apr 2022 09:28:03 +0000
Bug 1756592: Cache forced-return in ExceptionBailoutInfo r=tcampbell My first draft of this patch cached cx->status, but that's a private member that isn't exposed by an accessor. Under the assumption that this was a deliberate choice, this version of the patch only caches whether we are doing a forced return. Differential Revision: https://phabricator.services.mozilla.com/D140283
cf113d27c1a888c87ce128e54c889b9c90a33e25: Bug 1758242 - Remove GlobalScope::create. r=tcampbell
Tooru Fujisawa <arai_a@mac.com> - Wed, 09 Mar 2022 08:42:23 +0000 - rev 610074
Push 39393 by ncsoregi@mozilla.com at Wed, 09 Mar 2022 21:37:17 +0000
Bug 1758242 - Remove GlobalScope::create. r=tcampbell Depends on D140481 Differential Revision: https://phabricator.services.mozilla.com/D140482