searching for reviewer(sriram)
fb2697d854d01d40a7dbb74a6994a6072035b32e: Bug 947261 - Ensure that mActionItemBarPresenter is removed from the menu when cleared. r=sriram
Richard Newman <rnewman@mozilla.com> - Tue, 17 Dec 2013 20:44:14 -0800 - rev 161008
Push 25862 by cbook@mozilla.com at Wed, 18 Dec 2013 11:40:53 +0000
Bug 947261 - Ensure that mActionItemBarPresenter is removed from the menu when cleared. r=sriram
847cd981f103f9c82c87b124aae648ae4775a52e: Bug 947281 - Fix calcuations for how many actionbar items to show. r=sriram,margaret
Wes Johnston <wjohnston@mozilla.com> - Tue, 17 Dec 2013 09:41:55 -0800 - rev 160869
Push 25855 by ryanvm@gmail.com at Tue, 17 Dec 2013 21:10:10 +0000
Bug 947281 - Fix calcuations for how many actionbar items to show. r=sriram,margaret
26f883648b25bc246ec7207162267573a2e4cebb: Bug 948157 - Use custom style for native action bar. r=sriram
Wes Johnston <wjohnston@mozilla.com> - Tue, 10 Dec 2013 10:51:23 -0800 - rev 159720
Push 25811 by kwierso@gmail.com at Tue, 10 Dec 2013 23:59:03 +0000
Bug 948157 - Use custom style for native action bar. r=sriram
b3128b3dc02dc8d3efe05cb6c80ac1dcdc64d21b: Bug 935473 - Replace ViewGroup.MarginLayoutParams with MarginLayoutParams (r=sriram)
Lucas Rocha <lucasr@lucasr.org> - Thu, 05 Dec 2013 16:26:34 +0000 - rev 158977
Push 25768 by ryanvm@gmail.com at Thu, 05 Dec 2013 22:35:18 +0000
Bug 935473 - Replace ViewGroup.MarginLayoutParams with MarginLayoutParams (r=sriram)
cd918aef9e641d5fc74a5da2d398784e29f93548: Bug 936756 - Switch locales via pref, not via system locale setting. r=mfinkle,sriram (relanded as one patch)
Richard Newman <rnewman@mozilla.com> - Tue, 03 Dec 2013 15:05:43 -0800 - rev 158709
Push 25753 by cbook@mozilla.com at Wed, 04 Dec 2013 08:42:38 +0000
Bug 936756 - Switch locales via pref, not via system locale setting. r=mfinkle,sriram (relanded as one patch)
c46514ce6886b72bc6bce0b40026bfb790a35abc: Bug 936756 - Part 3: rebuild menus and action items on locale change. r=sriram
Richard Newman <rnewman@mozilla.com> - Sun, 01 Dec 2013 21:53:17 -0800 - rev 158203
Push 25738 by cbook@mozilla.com at Mon, 02 Dec 2013 11:44:25 +0000
Bug 936756 - Part 3: rebuild menus and action items on locale change. r=sriram
a2bbfd0fabacdc3af23a948fb9368a1371bea240: Bug 768667 - Fix un-bitrotting. r=bustage,sriram
Wes Johnston <wjohnston@mozilla.com> - Fri, 22 Nov 2013 15:18:04 -0800 - rev 157207
Push 25704 by mbrubeck@mozilla.com at Sat, 23 Nov 2013 22:25:36 +0000
Bug 768667 - Fix un-bitrotting. r=bustage,sriram
9579f738c88adc32172d0c7412badd6d3e3a045b: Bug 768667 - Follow up for review comments. r=sriram
Wes Johnston <wjohnston@mozilla.com> - Fri, 22 Nov 2013 14:13:23 -0800 - rev 157206
Push 25704 by mbrubeck@mozilla.com at Sat, 23 Nov 2013 22:25:36 +0000
Bug 768667 - Follow up for review comments. r=sriram
bac06128c286e7cf76bc1b6d7cd6e346fa77f2a9: Bug 768667 - Use an actionmode for text selection. r=margaret,sriram
Wes Johnston <wjohnston@mozilla.com> - Tue, 19 Nov 2013 11:57:37 -0800 - rev 157204
Push 25704 by mbrubeck@mozilla.com at Sat, 23 Nov 2013 22:25:36 +0000
Bug 768667 - Use an actionmode for text selection. r=margaret,sriram
ad5cc1a173bf0fe9f1ac6a9ccdc41366ec78b5c6: Bug 768667 - Provide an action mode for compatibility with old Android versions. r=sriram
Wes Johnston <wjohnston@mozilla.com> - Tue, 19 Nov 2013 11:57:35 -0800 - rev 157203
Push 25704 by mbrubeck@mozilla.com at Sat, 23 Nov 2013 22:25:36 +0000
Bug 768667 - Provide an action mode for compatibility with old Android versions. r=sriram
0b75c809f3f7fb7637899282fd6f21e7a55e4926: Bug 938205 - Factor out editing UI into ToolbarEditLayout (r=sriram)
Lucas Rocha <lucasr@mozilla.com> - Fri, 22 Nov 2013 15:34:29 +0000 - rev 157102
Push 25698 by ryanvm@gmail.com at Fri, 22 Nov 2013 20:28:29 +0000
Bug 938205 - Factor out editing UI into ToolbarEditLayout (r=sriram)
d37c31a42f3115681786163d72e529160d375dd0: Bug 938205 - Remove unused imports from BrowserToolbar (r=sriram)
Lucas Rocha <lucasr@mozilla.com> - Fri, 22 Nov 2013 15:34:29 +0000 - rev 157101
Push 25698 by ryanvm@gmail.com at Fri, 22 Nov 2013 20:28:29 +0000
Bug 938205 - Remove unused imports from BrowserToolbar (r=sriram)
ea5939461476bb47acb483b65097f58583fd1157: Bug 938205 - Factor out editing UI into ToolbarEditLayout (r=sriram)
Lucas Rocha <lucasr@mozilla.com> - Fri, 22 Nov 2013 15:34:29 +0000 - rev 157096
Push 25698 by ryanvm@gmail.com at Fri, 22 Nov 2013 20:28:29 +0000
Bug 938205 - Factor out editing UI into ToolbarEditLayout (r=sriram)
eb8ef0e80c9ce15b074f742aacc637f7e678d731: Bug 938205 - Remove unused imports from BrowserToolbar (r=sriram)
Lucas Rocha <lucasr@mozilla.com> - Fri, 22 Nov 2013 15:34:29 +0000 - rev 157095
Push 25698 by ryanvm@gmail.com at Fri, 22 Nov 2013 20:28:29 +0000
Bug 938205 - Remove unused imports from BrowserToolbar (r=sriram)
47c6e250d9857587e7162506f75fea76b9153655: Bug 935628 - Remove BrowserToolbarBackground class (r=sriram)
Lucas Rocha <lucasr@mozilla.com> - Fri, 22 Nov 2013 14:31:39 +0000 - rev 157087
Push 25698 by ryanvm@gmail.com at Fri, 22 Nov 2013 20:28:29 +0000
Bug 935628 - Remove BrowserToolbarBackground class (r=sriram)
105743ce84415e353e05c2641c3209a2a6731261: Bug 871522 - Factor out EditText handling into ToolbarEditText (r=sriram)
Lucas Rocha <lucasr@lucasr.org> - Fri, 22 Nov 2013 13:47:42 +0000 - rev 157084
Push 25698 by ryanvm@gmail.com at Fri, 22 Nov 2013 20:28:29 +0000
Bug 871522 - Factor out EditText handling into ToolbarEditText (r=sriram)
d21e0ed66e40d3def5d1c81fc621f97bcf72e658: Bug 871522 - Remove unnecessary long press listener from toolbar (r=sriram)
Lucas Rocha <lucasr@lucasr.org> - Fri, 22 Nov 2013 13:47:42 +0000 - rev 157083
Push 25698 by ryanvm@gmail.com at Fri, 22 Nov 2013 20:28:29 +0000
Bug 871522 - Remove unnecessary long press listener from toolbar (r=sriram)
79c1b20129d7534eb213ffa34a04b2204d009799: Bug 871522 - Encapsulate isEditing assignment into a setter (r=sriram)
Lucas Rocha <lucasr@lucasr.org> - Fri, 22 Nov 2013 13:47:42 +0000 - rev 157082
Push 25698 by ryanvm@gmail.com at Fri, 22 Nov 2013 20:28:29 +0000
Bug 871522 - Encapsulate isEditing assignment into a setter (r=sriram)
2bd9d2e52dc93a8c88f28cd2e217f2734df61b09: Bug 935628 - Only show right edge in toolbar when necessary (r=sriram)
Lucas Rocha <lucasr@mozilla.com> - Fri, 22 Nov 2013 13:33:15 +0000 - rev 157081
Push 25698 by ryanvm@gmail.com at Fri, 22 Nov 2013 20:28:29 +0000
Bug 935628 - Only show right edge in toolbar when necessary (r=sriram)
0f9ebc032d4d8f64adcebbd6b7d59889a56a978d: Bug 935628 - Remove BrowserToolbarBackground from toolbar (r=sriram)
Lucas Rocha <lucasr@mozilla.com> - Fri, 22 Nov 2013 13:33:15 +0000 - rev 157080
Push 25698 by ryanvm@gmail.com at Fri, 22 Nov 2013 20:28:29 +0000
Bug 935628 - Remove BrowserToolbarBackground from toolbar (r=sriram)
e224bc414b8dd5e4d9b9381b17ba255cbebeeee8: Bug 935628 - Animate toolbar with translation instead of scroll (r=sriram)
Lucas Rocha <lucasr@mozilla.com> - Fri, 22 Nov 2013 13:33:15 +0000 - rev 157079
Push 25698 by ryanvm@gmail.com at Fri, 22 Nov 2013 20:28:29 +0000
Bug 935628 - Animate toolbar with translation instead of scroll (r=sriram)
26df3bab1ab93d23a9c4d5686bdaee3c9fed7a5e: Bug 768667 - Use an actionmode for text selection. r=margaret,sriram
Wes Johnston <wjohnston@mozilla.com> - Tue, 19 Nov 2013 11:57:37 -0800 - rev 156358
Push 25676 by ryanvm@gmail.com at Wed, 20 Nov 2013 01:33:12 +0000
Bug 768667 - Use an actionmode for text selection. r=margaret,sriram
3c9dbe653a4e731aaf9c65bfc181d026e0ef2c50: Bug 768667 - Provide an action mode for compatibility with old Android versions. r=sriram
Wes Johnston <wjohnston@mozilla.com> - Tue, 19 Nov 2013 11:57:35 -0800 - rev 156357
Push 25676 by ryanvm@gmail.com at Wed, 20 Nov 2013 01:33:12 +0000
Bug 768667 - Provide an action mode for compatibility with old Android versions. r=sriram
49c93d558e911b94aa19021e55d04a79131edf96: Bug 937641 - Move toolbar-related classes to the toolbar package (r=sriram)
Lucas Rocha <lucasr@lucasr.org> - Tue, 19 Nov 2013 15:46:48 +0000 - rev 156343
Push 25675 by ryanvm@gmail.com at Tue, 19 Nov 2013 18:44:46 +0000
Bug 937641 - Move toolbar-related classes to the toolbar package (r=sriram)
0a96234a780368ba7d8688ec13abe0705fef4fc7: Bug 935604 - Part 2: Typing about:home directly does not break tab. r=sriram
Michael Comella <michael.l.comella@gmail.com> - Thu, 14 Nov 2013 14:13:54 -0800 - rev 156058
Push 25668 by kwierso@gmail.com at Tue, 19 Nov 2013 02:26:21 +0000
Bug 935604 - Part 2: Typing about:home directly does not break tab. r=sriram
120a9e538651c0efdc2cba783d0541084e680532: Bug 934900 - Ensure back/forward are not re-enabled while in editing mode (r=sriram)
Lucas Rocha <lucasr@lucasr.org> - Mon, 11 Nov 2013 18:43:40 +0000 - rev 154446
Push 25642 by kwierso@gmail.com at Tue, 12 Nov 2013 00:11:44 +0000
Bug 934900 - Ensure back/forward are not re-enabled while in editing mode (r=sriram)
5fdcf5a9697feac43370e3f871da844c623827a6: Bug 935628 - Only show right edge in toolbar when necessary (r=sriram)
Lucas Rocha <lucasr@mozilla.com> - Mon, 11 Nov 2013 18:33:55 +0000 - rev 154443
Push 25642 by kwierso@gmail.com at Tue, 12 Nov 2013 00:11:44 +0000
Bug 935628 - Only show right edge in toolbar when necessary (r=sriram)
da1a4740a72209c41f0314d6a45311e279d9dee1: Bug 935628 - Remove BrowserToolbarBackground from toolbar (r=sriram)
Lucas Rocha <lucasr@mozilla.com> - Mon, 11 Nov 2013 18:33:49 +0000 - rev 154442
Push 25642 by kwierso@gmail.com at Tue, 12 Nov 2013 00:11:44 +0000
Bug 935628 - Remove BrowserToolbarBackground from toolbar (r=sriram)
f16921967806d5dfd9e40dae2c5c04a14f550d8a: Bug 935628 - Animate toolbar with translation instead of scroll (r=sriram)
Lucas Rocha <lucasr@mozilla.com> - Mon, 11 Nov 2013 18:33:45 +0000 - rev 154441
Push 25642 by kwierso@gmail.com at Tue, 12 Nov 2013 00:11:44 +0000
Bug 935628 - Animate toolbar with translation instead of scroll (r=sriram)
5431745749bc2dcb79086e2c86d873de51c2b1d6: Bug 935534 - Use simpler element form for CustomEditText (r=sriram)
Lucas Rocha <lucasr@lucasr.org> - Fri, 08 Nov 2013 15:07:30 +0000 - rev 154144
Push 25625 by ryanvm@gmail.com at Fri, 08 Nov 2013 19:48:34 +0000
Bug 935534 - Use simpler element form for CustomEditText (r=sriram)
f91777954222efda30a3e30da0dd71651b27a608: Bug 935534 - Use UrlBar.ImageButton.Unused on Back/Fwd phone buttons (r=sriram)
Lucas Rocha <lucasr@lucasr.org> - Fri, 08 Nov 2013 15:07:29 +0000 - rev 154143
Push 25625 by ryanvm@gmail.com at Fri, 08 Nov 2013 19:48:34 +0000
Bug 935534 - Use UrlBar.ImageButton.Unused on Back/Fwd phone buttons (r=sriram)
9a56cb111bf5f8b1fd0771b3c69f63ca136f7635: Bug 935523 - Make BrowserApp's mBrowserToolbar non-static and private (r=sriram)
Lucas Rocha <lucasr@lucasr.org> - Fri, 08 Nov 2013 15:04:19 +0000 - rev 154142
Push 25625 by ryanvm@gmail.com at Fri, 08 Nov 2013 19:48:34 +0000
Bug 935523 - Make BrowserApp's mBrowserToolbar non-static and private (r=sriram)
e18759fb71eacdbb1dc94f3a45ab425341584f1d: Bug 935523 - Remove setShadowVisibility() as it's not needed anymore (r=sriram)
Lucas Rocha <lucasr@lucasr.org> - Fri, 08 Nov 2013 15:04:18 +0000 - rev 154141
Push 25625 by ryanvm@gmail.com at Fri, 08 Nov 2013 19:48:34 +0000
Bug 935523 - Remove setShadowVisibility() as it's not needed anymore (r=sriram)
ff7e84f5968bad29b075f354ee74bfe695e5bf9b: Bug 935530 - Fix subtle misalignment of stop button (r=sriram)
Lucas Rocha <lucasr@mozilla.com> - Fri, 08 Nov 2013 14:47:41 +0000 - rev 154139
Push 25625 by ryanvm@gmail.com at Fri, 08 Nov 2013 19:48:34 +0000
Bug 935530 - Fix subtle misalignment of stop button (r=sriram)
4e7de85bedc2c2a6c3b36f1f3724b47fcf4028f1: Bug 933428 - Remove "Share" and "Add to Home Screen" from about:home context menus. r=sriram
Margaret Leibovic <margaret.leibovic@gmail.com> - Mon, 04 Nov 2013 14:38:59 -0800 - rev 153440
Push 25587 by kwierso@gmail.com at Tue, 05 Nov 2013 05:07:06 +0000
Bug 933428 - Remove "Share" and "Add to Home Screen" from about:home context menus. r=sriram
af76477c0003f3b815e2ef98a51902a65348c4d9: Bug 930589 - Hide "Edit" context menu item for reading list items. r=sriram
Margaret Leibovic <margaret.leibovic@gmail.com> - Mon, 04 Nov 2013 14:38:59 -0800 - rev 153439
Push 25587 by kwierso@gmail.com at Tue, 05 Nov 2013 05:07:06 +0000
Bug 930589 - Hide "Edit" context menu item for reading list items. r=sriram
d6136cbe47d169a7942c315166c28a26657c44d6: Bug 933992 - sLoadTasks removal incorrectly uses long, not Integer. r=sriram
Richard Newman <rnewman@mozilla.com> - Fri, 01 Nov 2013 16:56:06 -0700 - rev 153156
Push 25569 by kwierso@gmail.com at Sat, 02 Nov 2013 03:28:23 +0000
Bug 933992 - sLoadTasks removal incorrectly uses long, not Integer. r=sriram
fbfc523379eef8f8c79c115758283e0a33ff6a1e: Bug 918007 - Disable toolbar elements while in editing mode on tablets (r=sriram)
Lucas Rocha <lucasr@mozilla.com> - Thu, 31 Oct 2013 20:49:53 +0000 - rev 152859
Push 25561 by ryanvm@gmail.com at Fri, 01 Nov 2013 00:00:16 +0000
Bug 918007 - Disable toolbar elements while in editing mode on tablets (r=sriram)
053a33ad3c5a4dd64156ce43f92a04b4beff34cd: Bug 918007 - Factor out method to enable/disable buttons (r=sriram)
Lucas Rocha <lucasr@mozilla.com> - Thu, 31 Oct 2013 20:49:52 +0000 - rev 152858
Push 25561 by ryanvm@gmail.com at Fri, 01 Nov 2013 00:00:16 +0000
Bug 918007 - Factor out method to enable/disable buttons (r=sriram)
200fa2ac65e4c1d1c947a5cac90e22a9013f07a2: Bug 925722 - Handle touch events in HomeSearchListView with onTouchEvent (r=sriram)
Lucas Rocha <lucasr@lucasr.org> - Tue, 29 Oct 2013 11:26:25 +0000 - rev 152664
Push 25558 by ryanvm@gmail.com at Thu, 31 Oct 2013 02:34:59 +0000
Bug 925722 - Handle touch events in HomeSearchListView with onTouchEvent (r=sriram)
0117133ba8efeec277059f2f214b1fff55b5dd77: Bug 918007 - Disable toolbar elements while in editing mode on tablets (r=sriram)
Lucas Rocha <lucasr@mozilla.com> - Wed, 23 Oct 2013 14:16:44 +0100 - rev 151800
Push 25510 by cbook@mozilla.com at Thu, 24 Oct 2013 04:49:08 +0000
Bug 918007 - Disable toolbar elements while in editing mode on tablets (r=sriram)
2d8cdd7baa58bfab0b5cd805e555f4bdb26a4c9b: Bug 918007 - Factor out method to enable/disable buttons (r=sriram)
Lucas Rocha <lucasr@mozilla.com> - Wed, 23 Oct 2013 14:16:39 +0100 - rev 151799
Push 25510 by cbook@mozilla.com at Thu, 24 Oct 2013 04:49:08 +0000
Bug 918007 - Factor out method to enable/disable buttons (r=sriram)
1674e4611f80a3623cc9e6d3f5a72006768ca76c: Bug 906323 - It should be possible to update a menuitem's label, r=sriram, f=margaret
Mark Capella <markcapella@twcny.rr.com> - Thu, 17 Oct 2013 02:06:56 -0400 - rev 151226
Push 25481 by cbook@mozilla.com at Fri, 18 Oct 2013 09:41:17 +0000
Bug 906323 - It should be possible to update a menuitem's label, r=sriram, f=margaret
8254d15a537dbaca36aa08d5718ed1428a8d5a79: Bug 925546: OnPinSiteListener -> OnEditPinnedSiteListener. r=sriram
Michael Comella <michael.l.comella@gmail.com> - Wed, 16 Oct 2013 10:09:41 -0700 - rev 150991
Push 25473 by ryanvm@gmail.com at Wed, 16 Oct 2013 21:00:56 +0000
Bug 925546: OnPinSiteListener -> OnEditPinnedSiteListener. r=sriram
4291e6d212060c954cabc19548bafcb039202eb1: Bug 919230 - Implement empty screen state for bookmarks. r=sriram
Chenxia Liu <liuche@mozilla.com> - Wed, 16 Oct 2013 09:42:33 -0700 - rev 150990
Push 25473 by ryanvm@gmail.com at Wed, 16 Oct 2013 21:00:56 +0000
Bug 919230 - Implement empty screen state for bookmarks. r=sriram
d0cf13b1749a891948e8f06aa1ea7a3da1595e3a: Bug 927371 - Remove performEmptySearch from SearchLoader (r=sriram)
Lucas Rocha <lucasr@mozilla.com> - Wed, 16 Oct 2013 17:02:02 +0100 - rev 150986
Push 25473 by ryanvm@gmail.com at Wed, 16 Oct 2013 21:00:56 +0000
Bug 927371 - Remove performEmptySearch from SearchLoader (r=sriram)
0bc8a298c227e2dedc3f466ca9bda70fc040a583: Bug 918044 - Block layout requests while handling focus changes in TopSitesGridView (r=sriram)
Lucas Rocha <lucasr@lucasr.org> - Wed, 16 Oct 2013 16:39:34 +0100 - rev 150984
Push 25473 by ryanvm@gmail.com at Wed, 16 Oct 2013 21:00:56 +0000
Bug 918044 - Block layout requests while handling focus changes in TopSitesGridView (r=sriram)
1aa64512625666f625944f8922b09c4deb3d2f22: NO BUG - Deleted unused resource `gecko_actionbar_bg'. r=sriram
Nick Alexander <nalexander@mozilla.com> - Tue, 01 Oct 2013 14:13:22 -0700 - rev 149516
Push 25392 by kwierso@gmail.com at Wed, 02 Oct 2013 01:28:41 +0000
NO BUG - Deleted unused resource `gecko_actionbar_bg'. r=sriram
c554c6a0c003d99b292e1505902116fd4cd7e42a: Bug 906230 - Hide the Reading List page in about:home on low memory devices (r=sriram)
Lucas Rocha <lucasr@mozilla.com> - Tue, 01 Oct 2013 14:22:24 +0100 - rev 149462
Push 25390 by ryanvm@gmail.com at Tue, 01 Oct 2013 20:43:13 +0000
Bug 906230 - Hide the Reading List page in about:home on low memory devices (r=sriram)
132dbcea6676aa0bd73ee984d13ae83b217b607a: Bug 919768 - Slowdown and OOM hit visiting top-sites in about:home. r=sriram
Richard Newman <rnewman@mozilla.com> - Mon, 30 Sep 2013 20:56:09 -0700 - rev 149353
Push 25385 by emorley@mozilla.com at Tue, 01 Oct 2013 09:25:32 +0000
Bug 919768 - Slowdown and OOM hit visiting top-sites in about:home. r=sriram