searching for reviewer(spohl)
09ccf334001b34afb2e77743d47655300008229f: Bug 1592416 - Right click opens context menu on wrong monitor or virtual desktop (mac OS Catalina) r=spohl
Haik Aftandilian <haftandilian@mozilla.com> - Thu, 21 May 2020 00:09:32 +0000 - rev 531383
Push 37439 by btara@mozilla.com at Thu, 21 May 2020 21:49:34 +0000
Bug 1592416 - Right click opens context menu on wrong monitor or virtual desktop (mac OS Catalina) r=spohl Add the NSWindowCollectionBehaviorMoveToActiveSpace behavior to nsCocoaWindow popups so that they override the "Assign To" space setting and display on the active space. This also addresses bug 1589893 where, when "Assign To" space is used, popup menus are not visible in full screen mode. With mutiple displays, recreate the popup widget each time it is displayed to workaround a problem where the re-shown popup appears on the "Assign To" display instead of the current display. Differential Revision: https://phabricator.services.mozilla.com/D75419
b8259db1782b52d2ff53e131b3e531a90927852c: Bug 1638821 - Make the decision to whether paint focus rings depend on the theme, not the platform. r=spohl
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 19 May 2020 15:46:42 +0000 - rev 530881
Push 37433 by dluca@mozilla.com at Wed, 20 May 2020 03:39:31 +0000
Bug 1638821 - Make the decision to whether paint focus rings depend on the theme, not the platform. r=spohl The current code assumes that nsNativeTheme is in use which breaks with the non-native theme. Instead of hackily remove the FOCUS bit, make the theme check for the FOCUSRING bit, which is the right thing to check for anyway. Differential Revision: https://phabricator.services.mozilla.com/D75782
39826e3d41917efa3dd0dd4b040a8d9b69c50c93: Bug 1636723. Have nsPrintSettingsX use the NSPrintInfo methods rather than mess with its internal dictionary. r=spohl
Jonathan Watt <jwatt@jwatt.org> - Fri, 15 May 2020 11:45:28 +0000 - rev 530258
Push 37420 by nerli@mozilla.com at Fri, 15 May 2020 21:52:36 +0000
Bug 1636723. Have nsPrintSettingsX use the NSPrintInfo methods rather than mess with its internal dictionary. r=spohl It is not obvious that the dict is an internal implementation detail of the NSPrintInfo, so it was confusing to me that in some places setters are using a dict but getters are using NSPrintInfo methods. This hopefully makes the code simpler and easier to understand. Differential Revision: https://phabricator.services.mozilla.com/D74543
6d7fac080dca7f3ec0fdd86c9e84834a7e68a9e3: Bug 1276537 part 2 - Remove nsIWidget::SetShowsFullScreenButton. r=spohl
Xidorn Quan <me@upsuper.org> - Fri, 15 May 2020 06:19:14 +0000 - rev 530222
Push 37420 by nerli@mozilla.com at Fri, 15 May 2020 21:52:36 +0000
Bug 1276537 part 2 - Remove nsIWidget::SetShowsFullScreenButton. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D74555
7b2be27b7bb98f63cc72bb64871ca05a239ed782: Bug 1276537 part 1 - Make resizable window on macOS always show full screen button. r=spohl
Xidorn Quan <me@upsuper.org> - Fri, 15 May 2020 06:19:14 +0000 - rev 530221
Push 37420 by nerli@mozilla.com at Fri, 15 May 2020 21:52:36 +0000
Bug 1276537 part 1 - Make resizable window on macOS always show full screen button. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D74833
61712ddac4343108711a57549068d6f836f485cc: Bug 1635517 - Update deprecated accessibilityIsIgnored to isAccessibilityElement. r=spohl
Eitan Isaacson <eitan@monotonous.org> - Tue, 12 May 2020 17:39:18 +0000 - rev 529479
Push 37409 by apavel@mozilla.com at Wed, 13 May 2020 03:44:05 +0000
Bug 1635517 - Update deprecated accessibilityIsIgnored to isAccessibilityElement. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D74431
78ed541858a26f7ebfe55eb05db9c7b1871fc9ba: Bug 1633119 - Use orderFront for force window full screen. r=spohl
Xidorn Quan <me@upsuper.org> - Sat, 09 May 2020 12:04:29 +0000 - rev 528978
Push 37399 by ccoroiu@mozilla.com at Sat, 09 May 2020 21:30:55 +0000
Bug 1633119 - Use orderFront for force window full screen. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D74527
546092740e58fe69b912d5dde35f01b3c9326e26: Bug 1635577 - add wakelog log. r=spohl,karlt
alwu <alwu@mozilla.com> - Thu, 07 May 2020 19:51:30 +0000 - rev 528674
Push 37393 by rmaries@mozilla.com at Fri, 08 May 2020 03:38:07 +0000
Bug 1635577 - add wakelog log. r=spohl,karlt Differential Revision: https://phabricator.services.mozilla.com/D73949
01866ba8633840dec6c37acc7518374b3ab1196f: Bug 1631887 - Claim to support NonDisappearingScrollbarWidth on the non-native theme. r=spohl
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 22 Apr 2020 17:45:39 +0000 - rev 525438
Push 37339 by nerli@mozilla.com at Thu, 23 Apr 2020 09:52:48 +0000
Bug 1631887 - Claim to support NonDisappearingScrollbarWidth on the non-native theme. r=spohl This is used by platforms with overlay scrollbars, only in order to reserve enough space for the chevron of the `<select>` element. So our general min-widget-size, which is the same as for scrollbars works. Differential Revision: https://phabricator.services.mozilla.com/D71825
a0be8f02af467a49ca3dee204f38d03e0ccc2fb6: Bug 1629313 - Part 1 - Set As Desktop Background fails on macOS r=spohl
Haik Aftandilian <haftandilian@mozilla.com> - Tue, 21 Apr 2020 19:57:29 +0000 - rev 525270
Push 37335 by aiakab@mozilla.com at Wed, 22 Apr 2020 04:10:25 +0000
Bug 1629313 - Part 1 - Set As Desktop Background fails on macOS r=spohl Change the nsMacShellService::SetDesktopBackground() implementation (specifically code in the OnStateChange handler) to use the Apple setDesktopImageURL API instead of Apple Events to allow the "Set As Desktop Background..." context menu option to work again. Alternatively, to allow the AppleEvent-base implementation to work again, Firefox could be signed with the com.apple.security.automation.apple-events entitlement but this would also require the user to grant Firefox permission to control Finder. setDesktopImageURL requires Mac OS 10.6 or newer and hence was not an option originally. The implementation only changes the background of the focused screen in the current workspace (which matches the behavior of Safari). Differential Revision: https://phabricator.services.mozilla.com/D71426
c7623d3b49ec7da3731d77e841217251025f5c16: Bug 1631887 - Claim to support NonDisappearingScrollbarWidth on the non-native theme. r=spohl
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 21 Apr 2020 20:36:22 +0000 - rev 525268
Push 37335 by aiakab@mozilla.com at Wed, 22 Apr 2020 04:10:25 +0000
Bug 1631887 - Claim to support NonDisappearingScrollbarWidth on the non-native theme. r=spohl This is used by platforms with overlay scrollbars, only in order to reserve enough space for the chevron of the `<select>` element. So our general min-widget-size, which is the same as for scrollbars works. Differential Revision: https://phabricator.services.mozilla.com/D71825
a6637962605fab6cdba8e230ab275352fd942a3d: Bug 1624786 - Replace "clang-format off" with semicolon workaround for clang-format bug 1629756. r=spohl
Chris Peterson <cpeterson@mozilla.com> - Mon, 20 Apr 2020 12:18:48 +0000 - rev 525027
Push 37333 by cbrindusan@mozilla.com at Tue, 21 Apr 2020 09:42:20 +0000
Bug 1624786 - Replace "clang-format off" with semicolon workaround for clang-format bug 1629756. r=spohl This semicolon workaround is tidier than the `// clang-format off/on` comments and avoids turning off all clang-format checks. The comment also links to clang-format bug 1629756 so future code readers can learn why this extra semicolon exists. And if we find a way to fix this in clang-format, then we can search for this bug number to find and remove these extra semicolons and comments. Differential Revision: https://phabricator.services.mozilla.com/D71504
39ee5303a7e89a03482a9a1cb13a39f3760fff3c: Bug 1623745 - Add a value to the pwmgr.reauthenticated telemetry event to specify if the user was able to authenticate without a password. r=MattN,spohl
Jared Wein <jwein@mozilla.com> - Thu, 16 Apr 2020 21:33:24 +0000 - rev 524494
Push 37321 by dluca@mozilla.com at Fri, 17 Apr 2020 09:38:52 +0000
Bug 1623745 - Add a value to the pwmgr.reauthenticated telemetry event to specify if the user was able to authenticate without a password. r=MattN,spohl Differential Revision: https://phabricator.services.mozilla.com/D70136
a7235bdaa392b40512559d6a4a578adfb4a1fc44: Bug 1627414 - getDisplayMedia does not work when firefox is full screen on macOS r=spohl
Haik Aftandilian <haftandilian@mozilla.com> - Tue, 14 Apr 2020 20:27:55 +0000 - rev 524004
Push 37314 by shindli@mozilla.com at Wed, 15 Apr 2020 09:25:24 +0000
Bug 1627414 - getDisplayMedia does not work when firefox is full screen on macOS r=spohl Change the GetScreenCapturePermissionState() heuristic to use the full window list instead of just on-screen windows to allow it it to work in full screen mode. Differential Revision: https://phabricator.services.mozilla.com/D70931
81e4b5376ea8e075126f1a1b0b2b66b72bf74b8c: Bug 1624786 - Replace MOZ_MUST_USE with [[nodiscard]] in widget/cocoa. r=spohl
Chris Peterson <cpeterson@mozilla.com> - Wed, 08 Apr 2020 16:41:42 +0000 - rev 523346
Push 37299 by shindli@mozilla.com at Fri, 10 Apr 2020 09:54:19 +0000
Bug 1624786 - Replace MOZ_MUST_USE with [[nodiscard]] in widget/cocoa. r=spohl Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's __attribute__((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers. Differential Revision: https://phabricator.services.mozilla.com/D68148
b293d01619f7350ee271a8dcaeb15dc6a28da22a: Bug 1610613 - Make Picture-in-Picture window persist across workspaces on macOS. r=spohl
Mike Conley <mconley@mozilla.com> - Tue, 07 Apr 2020 13:28:24 +0000 - rev 522608
Push 37293 by apavel@mozilla.com at Tue, 07 Apr 2020 21:44:02 +0000
Bug 1610613 - Make Picture-in-Picture window persist across workspaces on macOS. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D69932
71ba43d7b2df59cfb55cc085fa602bd809bf322f: Bug 1350875 part 2 - Have cocoa always notify fullscreen will change. r=spohl
Xidorn Quan <me@upsuper.org> - Thu, 02 Apr 2020 11:38:43 +0000 - rev 522565
Push 37293 by apavel@mozilla.com at Tue, 07 Apr 2020 21:44:02 +0000
Bug 1350875 part 2 - Have cocoa always notify fullscreen will change. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D68679
0c0f77ca0a7eccbbb91a45df7ee63d687fac88ee: Bug 1611482: Prevent the existance of dangling pointers upon failure of FindDataStart. r=spohl,valentin
Bas Schouten <bschouten@mozilla.com> - Thu, 02 Apr 2020 13:54:55 +0000 - rev 522002
Push 37281 by btara@mozilla.com at Sat, 04 Apr 2020 09:29:13 +0000
Bug 1611482: Prevent the existance of dangling pointers upon failure of FindDataStart. r=spohl,valentin Differential Revision: https://phabricator.services.mozilla.com/D60997
40fe811eab33812e9536ceaaeeedac0c8be18743: Bug 1624251 - Fix use-after-free in nsMacFinderProgress r=spohl
Christoph Walcher <christoph-wa@gmx.de> - Sat, 28 Mar 2020 01:46:29 +0000 - rev 521053
Push 37266 by ccoroiu@mozilla.com at Mon, 30 Mar 2020 22:01:01 +0000
Bug 1624251 - Fix use-after-free in nsMacFinderProgress r=spohl Differential Revision: https://phabricator.services.mozilla.com/D68667
fcba04973afc0462247576b9a097d972d7294e17: Bug 1624708 - Make non-native theme keyboard navigable. r=spohl
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 24 Mar 2020 22:51:26 +0000 - rev 520306
Push 37246 by opoprus@mozilla.com at Wed, 25 Mar 2020 03:40:33 +0000
Bug 1624708 - Make non-native theme keyboard navigable. r=spohl By painting focus colors. I suspect this was mostly an oversight? But it is the most obvious issue I always find with this theme. I followed active > focus > hover, which seems to match what GTK does (and makes sense, generally). Differential Revision: https://phabricator.services.mozilla.com/D68088
e2f021fe0c3e0f3c0653d153ba1448627471edf7: Bug 1624696 - Respect padding for all elements except checkbox/radio. r=spohl,mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 24 Mar 2020 22:51:26 +0000 - rev 520305
Push 37246 by opoprus@mozilla.com at Wed, 25 Mar 2020 03:40:33 +0000
Bug 1624696 - Respect padding for all elements except checkbox/radio. r=spohl,mstange Only button / menulist-button were missing from the hard-coded if condition. I don't think we ever want to override author padding, and this can cause compat issues as the one in this bug. I'm making HasAuthorSpecifiedRules fast in bug 1624080, btw. Differential Revision: https://phabricator.services.mozilla.com/D68085
0ee82dc106f20c4f207fa33f84e910566b29fa79: Bug 1624708 - Make non-native theme keyboard navigable. r=spohl
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 24 Mar 2020 21:01:34 +0000 - rev 520282
Push 37246 by opoprus@mozilla.com at Wed, 25 Mar 2020 03:40:33 +0000
Bug 1624708 - Make non-native theme keyboard navigable. r=spohl By painting focus colors. I suspect this was mostly an oversight? But it is the most obvious issue I always find with this theme. I followed active > focus > hover, which seems to match what GTK does (and makes sense, generally). Differential Revision: https://phabricator.services.mozilla.com/D68088
f3c5f5a1b35dccaf7d301e1a19653e738f327964: Bug 1624696 - Respect padding for all elements except checkbox/radio. r=spohl,mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 24 Mar 2020 21:02:12 +0000 - rev 520281
Push 37246 by opoprus@mozilla.com at Wed, 25 Mar 2020 03:40:33 +0000
Bug 1624696 - Respect padding for all elements except checkbox/radio. r=spohl,mstange Only button / menulist-button were missing from the hard-coded if condition. I don't think we ever want to override author padding, and this can cause compat issues as the one in this bug. I'm making HasAuthorSpecifiedRules fast in bug 1624080, btw. Differential Revision: https://phabricator.services.mozilla.com/D68085
0dbf5723afe27908bd2f899400fe7ad8eae078ff: Bug 1623695 - Change the asyncReauthenticateUser API to use wide strings to fix encoding issues with user-facing dialog strings. r=agashlin,spohl
Jared Wein <jwein@mozilla.com> - Fri, 20 Mar 2020 18:56:40 +0000 - rev 519894
Push 37234 by ccoroiu@mozilla.com at Fri, 20 Mar 2020 21:58:02 +0000
Bug 1623695 - Change the asyncReauthenticateUser API to use wide strings to fix encoding issues with user-facing dialog strings. r=agashlin,spohl Differential Revision: https://phabricator.services.mozilla.com/D67530
1f21bc6af7282ef11073f7e536e39a1c6fe12dc2: Bug 1602635 - [macOS] Remove security.sandbox.content.mac.earlyinit and the old sandbox startup code paths r=spohl
Haik Aftandilian <haftandilian@mozilla.com> - Tue, 17 Mar 2020 18:29:03 +0000 - rev 519222
Push 37224 by btara@mozilla.com at Wed, 18 Mar 2020 04:14:11 +0000
Bug 1602635 - [macOS] Remove security.sandbox.content.mac.earlyinit and the old sandbox startup code paths r=spohl Remove old content sandbox code paths that allowed the sandbox to be started later during content process startup when the SetProcessSandbox() message was received from the parent process. This older way of starting the sandbox was still in the tree to support WebReplay which is now being removed. With this fix, content processes always use the "earlyinit" sandbox startup like the RDD and GMP processes. Differential Revision: https://phabricator.services.mozilla.com/D64968
b9bf352a94d2d41df26dae4a672daadb5185fdce: Bug 1614983 - Create a new sandbox profile for the socket process r=spohl
Haik Aftandilian <haftandilian@mozilla.com> - Wed, 11 Mar 2020 22:20:13 +0000 - rev 518272
Push 37206 by aciure@mozilla.com at Thu, 12 Mar 2020 03:57:49 +0000
Bug 1614983 - Create a new sandbox profile for the socket process r=spohl Add, but don't enable, a sandbox policy to be used with the socket process. A follow-up fix (bug 1611288) will change the socket process code to use the sandbox. The macOS socket sandbox is similar to the utility sandbox (only used for the RDD process), with additions to allow networking I/O, access to files for DNS resolution, access to certificate stores, and notifications about network configuration changes. Differential Revision: https://phabricator.services.mozilla.com/D64682
35ef92e229230816dff9ba8f826b4b5c6f59a98b: Bug 1615100 - Paint the range thumb using button colors. r=spohl
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 06 Mar 2020 17:54:04 +0000 - rev 517441
Push 37190 by aciure@mozilla.com at Sat, 07 Mar 2020 21:33:39 +0000
Bug 1615100 - Paint the range thumb using button colors. r=spohl This is very basic, and just uses the button colors. Did this because I thought that it was going to help me fix one test but it didn't in the end, feel free to reject, or to tell me to land the cleanup somewhere else :) Depends on D65674 Differential Revision: https://phabricator.services.mozilla.com/D65675
80e3811f81c81b4b9b125685ac82c80b65ec9334: Bug 1620307 - Rename -moz-menulist-button to -moz-menulist-arrow-button. r=spohl
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 05 Mar 2020 21:13:46 +0000 - rev 517136
Push 37186 by malexandru@mozilla.com at Fri, 06 Mar 2020 09:47:39 +0000
Bug 1620307 - Rename -moz-menulist-button to -moz-menulist-arrow-button. r=spohl This should be less confusing. This is not supported outside of chrome:// or user-agent stylesheets so we can name this however we want. Differential Revision: https://phabricator.services.mozilla.com/D65605
5a465a76e60f85ebd4361a169b3f65fba3c54767: Bug 1620246 - Fix snapping to avoid also changing coordinate spaces. r=spohl
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 05 Mar 2020 14:43:14 +0000 - rev 517055
Push 37185 by dluca@mozilla.com at Thu, 05 Mar 2020 21:27:12 +0000
Bug 1620246 - Fix snapping to avoid also changing coordinate spaces. r=spohl Bug 1615026 introduced some coordinate space change which I didn't intend. NSRectToSnappedRect does what we want instead. Differential Revision: https://phabricator.services.mozilla.com/D65519
c1e88fa43e7ec5da8e44015fb9cbbcf105178f94: Bug 1619664 - Decide which theme to use per document, not per-process. r=mstange,spohl
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 03 Mar 2020 19:46:41 +0000 - rev 516756
Push 37180 by opoprus@mozilla.com at Wed, 04 Mar 2020 08:41:40 +0000
Bug 1619664 - Decide which theme to use per document, not per-process. r=mstange,spohl This allows testing much more easily. There are some edge cases with native theme changes and such (ThemeChanged and co assume there's only one theme per process). But I don't think they matter much for our use cases. Differential Revision: https://phabricator.services.mozilla.com/D65162
cdf176917db42a1e760751782750dced73f3128c: Bug 1596488 - Revert mXBLAttached fix for native OSX menus r=spohl
Christoph Walcher <christoph-wa@gmx.de> - Mon, 03 Feb 2020 20:03:16 +0000 - rev 514630
Push 37140 by malexandru@mozilla.com at Thu, 20 Feb 2020 09:35:08 +0000
Bug 1596488 - Revert mXBLAttached fix for native OSX menus r=spohl Differential Revision: https://phabricator.services.mozilla.com/D61084
3b823d058ef541ec6abd5e781c6b9b4e1b893fbf: Bug 1615830 - Don't allow checkboxes to loose aspect-ratio. r=spohl
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 16 Feb 2020 16:04:31 +0000 - rev 514204
Push 37128 by aciure@mozilla.com at Sun, 16 Feb 2020 21:00:01 +0000
Bug 1615830 - Don't allow checkboxes to loose aspect-ratio. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D63006
ccbbd26e4bec0cda9a2d4e4b73de319092569c28: Bug 1615134 - Shell service API to open macOS Security & Privacy preferences panes. r=spohl
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Fri, 14 Feb 2020 04:06:09 +0000 - rev 513865
Push 37122 by csabou@mozilla.com at Fri, 14 Feb 2020 10:05:11 +0000
Bug 1615134 - Shell service API to open macOS Security & Privacy preferences panes. r=spohl Example: Cc["@mozilla.org/browser/shell-service;1"].getService(Ci.nsIMacShellService).showSecurityPreferences("Privacy_AllFiles") Differential Revision: https://phabricator.services.mozilla.com/D62690
a2e0699b6cb88cd88f1b0be00be031449a2d62fd: Bug 1612006 - getDisplayMedia NotFoundError in firefox after upgrade to MacOS 10.15.3 r=spohl
Haik Aftandilian <haftandilian@mozilla.com> - Thu, 13 Feb 2020 23:36:23 +0000 - rev 513856
Push 37122 by csabou@mozilla.com at Fri, 14 Feb 2020 10:05:11 +0000
Bug 1612006 - getDisplayMedia NotFoundError in firefox after upgrade to MacOS 10.15.3 r=spohl Update the heuristic-based screen recording permission check to be more reliable but still imperfect. Add pref "media.macos.screenrecording.oscheck.enabled" (true by default) to allow bypassing the permission check as a workaround and for testing. i.e., when the pref is set, nsIOSPermissionRequest::getScreenCapturePermissionState() always returns PERMISSION_STATE_AUTHORIZED on macOS. Differential Revision: https://phabricator.services.mozilla.com/D61909
53e73d02adf1666927fb37dd175272b0ac1668e4: Bug 1615028 - Make nsNativeBasicTheme honor custom scrollbar styles. r=spohl
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 12 Feb 2020 19:38:35 +0000 - rev 513608
Push 37118 by rmaries@mozilla.com at Thu, 13 Feb 2020 03:57:45 +0000
Bug 1615028 - Make nsNativeBasicTheme honor custom scrollbar styles. r=spohl By falling back to the generic code like nsNativeThemeGTK does. We may want to be more nuanced in other platforms? I don't know. This is very noticeable on Riot and other apps that override the scrollbar width / scrollbar colors. Differential Revision: https://phabricator.services.mozilla.com/D62634
bee05acc3ce7b56e5840e27a178262ff9a87a637: Bug 1596668, r=spohl
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Sat, 11 Jan 2020 16:04:19 +0000 - rev 509909
Push 37010 by dvarga@mozilla.com at Mon, 13 Jan 2020 15:45:24 +0000
Bug 1596668, r=spohl Differential Revision: https://phabricator.services.mozilla.com/D58206
efaa19655437fa9e130e19a1080ef46ae5cd47bc: Bug 1581555 - Allow dynamic location switching in the Touch Bar. r=spohl,mikedeboer
Harry Twyford <htwyford@mozilla.com> - Mon, 06 Jan 2020 18:03:21 +0000 - rev 509615
Push 37000 by shindli@mozilla.com at Fri, 10 Jan 2020 05:03:08 +0000
Bug 1581555 - Allow dynamic location switching in the Touch Bar. r=spohl,mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D58463
ae6bb3a1066959a8c43d003a3caab0af769455bf: Bug 1607140 - Add mTouchBarHelper null-checks to makeItemForIdentifier and updateItem. r=spohl
harry <htwyford@mozilla.com> - Tue, 07 Jan 2020 19:57:34 +0000 - rev 509166
Push 36993 by dluca@mozilla.com at Wed, 08 Jan 2020 09:41:58 +0000
Bug 1607140 - Add mTouchBarHelper null-checks to makeItemForIdentifier and updateItem. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D58997
320f70246faf7c1bf5e3d21ba148033536d260b7: Bug 1607140 - Add a more stringent check for mTouchBarHelper in loadIconForInput. r=spohl
harry <htwyford@mozilla.com> - Tue, 07 Jan 2020 18:57:06 +0000 - rev 509154
Push 36993 by dluca@mozilla.com at Wed, 08 Jan 2020 09:41:58 +0000
Bug 1607140 - Add a more stringent check for mTouchBarHelper in loadIconForInput. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D58957
83762a3e8989f47ad8caad554379d7852d9fd33a: Bug 1581555 - Allow dynamic location switching in the Touch Bar. r=spohl,mikedeboer
Harry Twyford <htwyford@mozilla.com> - Fri, 03 Jan 2020 18:06:57 +0000 - rev 508775
Push 36978 by aiakab@mozilla.com at Sat, 04 Jan 2020 09:46:47 +0000
Bug 1581555 - Allow dynamic location switching in the Touch Bar. r=spohl,mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D58463
3295c2e9b94405f3306b1fb03cd0da40e4383ace: Bug 1600356 - Part 3 - Streamline Touch Bar image loading. r=spohl
harry <htwyford@mozilla.com> - Fri, 03 Jan 2020 17:07:25 +0000 - rev 508771
Push 36978 by aiakab@mozilla.com at Sat, 04 Jan 2020 09:46:47 +0000
Bug 1600356 - Part 3 - Streamline Touch Bar image loading. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D55314
f742190493ffbb50185d474f8e9303f06e3cea1c: Bug 1600356 - Part 2 - Introduce TouchBarInputBaseType enum and change signatures on TouchBarInput update methods. r=spohl
harry <htwyford@mozilla.com> - Fri, 03 Jan 2020 17:07:25 +0000 - rev 508770
Push 36978 by aiakab@mozilla.com at Sat, 04 Jan 2020 09:46:47 +0000
Bug 1600356 - Part 2 - Introduce TouchBarInputBaseType enum and change signatures on TouchBarInput update methods. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D56590
2f5e9f3a1c3e501435daa99a280afd398af409b6: Bug 1600356 - Part 1 - Split out TouchBarInput into its own files. r=spohl
harry <htwyford@mozilla.com> - Tue, 31 Dec 2019 20:26:00 +0000 - rev 508769
Push 36978 by aiakab@mozilla.com at Sat, 04 Jan 2020 09:46:47 +0000
Bug 1600356 - Part 1 - Split out TouchBarInput into its own files. r=spohl nsTouchBar.h/.mm were getting a bit unwieldy, particularly after the TouchBarInputBaseType enum from the next part of this patch was added. This part splits out TouchBarInput into its own files. This makes the Touch Bar's file structure similar to that of the menu bar's: nsMenuBarX, nsMenuBarItemX, and nsMenuBarItemIconX contrasted with nsTouchBar, nsTouchBarInput, and nsTouchBarInputIcon. Differential Revision: https://phabricator.services.mozilla.com/D56589
155e5d7c120c3e7b48685d24816bd92908014613: Bug 1591230 - On macOS use MediaPlayer library for media keys when available. r=spohl,alwu
Paul Warner <paul.eliot.warner@gmail.com> - Tue, 31 Dec 2019 01:41:33 +0000 - rev 508506
Push 36967 by rgurzau@mozilla.com at Tue, 31 Dec 2019 09:43:49 +0000
Bug 1591230 - On macOS use MediaPlayer library for media keys when available. r=spohl,alwu On macOS 10.12.1+, we use `MediaPlayer` library, which has better media key integration, to replace the implementation of `CG EventLoop`. Differential Revision: https://phabricator.services.mozilla.com/D46890
b94ca7493062738c50896212e9121c2cab4f1b3d: Bug 1605412. Remove the Mac widget NS_PAPER_ORIENTATION_* defines. r=spohl
Jonathan Watt <jwatt@jwatt.org> - Sat, 21 Dec 2019 20:23:20 +0000 - rev 508295
Push 36945 by apavel@mozilla.com at Tue, 24 Dec 2019 04:11:00 +0000
Bug 1605412. Remove the Mac widget NS_PAPER_ORIENTATION_* defines. r=spohl The oldest Mac that we support is 10.9, so we no longer need these defines. Differential Revision: https://phabricator.services.mozilla.com/D58005
bc30f88b1154288bea4078551a49f9553db9cd07: Bug 1601508 - create a general interface for getting platform-specific media keys event source r=spohl
Alastor Wu <alwu@mozilla.com> - Fri, 06 Dec 2019 20:55:26 +0000 - rev 505888
Push 36890 by rmaries@mozilla.com at Sat, 07 Dec 2019 09:26:17 +0000
Bug 1601508 - create a general interface for getting platform-specific media keys event source r=spohl Create a general interface for getting platform-specific media keys event source in order to remove platform specific code from non-platform related folder `dom/media`. Differential Revision: https://phabricator.services.mozilla.com/D55892
e050f35bd4c2b8e482b0a1ba6b7bf846ff47cd10: Bug 1595082 - Ensure every Touch Bar input is updated at least once. r=mikedeboer,spohl
harry <htwyford@mozilla.com> - Tue, 19 Nov 2019 19:19:24 +0000 - rev 502709
Push 36822 by rmaries@mozilla.com at Wed, 20 Nov 2019 04:03:55 +0000
Bug 1595082 - Ensure every Touch Bar input is updated at least once. r=mikedeboer,spohl Differential Revision: https://phabricator.services.mozilla.com/D53176
23bffe0e868deab92467bb506d84d15b058c3052: Bug 1595082 - Ensure every Touch Bar input is updated at least once. r=mikedeboer,spohl
harry <htwyford@mozilla.com> - Tue, 19 Nov 2019 15:01:27 +0000 - rev 502621
Push 36819 by ffxbld at Tue, 19 Nov 2019 21:20:10 +0000
Bug 1595082 - Ensure every Touch Bar input is updated at least once. r=mikedeboer,spohl Differential Revision: https://phabricator.services.mozilla.com/D53176
284910a66370a61a378e10f667256b5c5b59607f: Bug 1596696 - Restore pre-bug 1576390 lock order. r=spohl
Markus Stange <mstange@themasta.com> - Fri, 15 Nov 2019 20:35:10 +0000 - rev 502284
Push 36808 by shindli@mozilla.com at Sat, 16 Nov 2019 05:13:16 +0000
Bug 1596696 - Restore pre-bug 1576390 lock order. r=spohl This method is interacting with two different locks. We have debug code that makes sure that locking and unlocking across all locks is well-nested. Adding this scope makes sure that we unlock mCompositingState before we unlock mViewTearDownLock. Differential Revision: https://phabricator.services.mozilla.com/D53263
5df0e903d13fa096db7b3d90c3d1fe972a5b34d4: Bug 1516367 - Move the minidump-analyzer out of the crash reporter application bundle r=spohl,dmajor
Gabriele Svelto <gsvelto@mozilla.com> - Thu, 14 Nov 2019 21:11:59 +0000 - rev 502056
Push 36805 by aiakab@mozilla.com at Fri, 15 Nov 2019 09:53:19 +0000
Bug 1516367 - Move the minidump-analyzer out of the crash reporter application bundle r=spohl,dmajor The minidump-analyzer tool was originally conceived to be used from the crash report client and as such was installed in the crash reporter client application bundle on macOS. It was later adapted to work from Firefox itself but this caused linking problems when invoked from the Firefox app bundle. This patch moves the minidump-analyzer into the Firefox app bundle and adapts the relevant code to find it there. The minidump-analyzer was also not signed like the rest of our executables and this patch addresses that issue too. Differential Revision: https://phabricator.services.mozilla.com/D52910