searching for reviewer(spohl)
f4c05f857e22849a2a6f2627bf731d0b997da0fc: Bug 1741499 - Cleanup a bit HeadlessLookAndFeelGTK too. r=spohl
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 17 Nov 2021 01:24:20 +0000 - rev 599404
Push 38985 by ctuns@mozilla.com at Wed, 17 Nov 2021 09:49:29 +0000
Bug 1741499 - Cleanup a bit HeadlessLookAndFeelGTK too. r=spohl The colors that I didn't move to nsXPLookAndFeel are always set via prefs. Differential Revision: https://phabricator.services.mozilla.com/D131286
c185ccef8c0db0d0cb51bea6782f8224fb23ca2e: Bug 1741499 - Remove HeadlessThemeGTK. r=spohl
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 17 Nov 2021 01:24:02 +0000 - rev 599403
Push 38985 by ctuns@mozilla.com at Wed, 17 Nov 2021 09:49:29 +0000
Bug 1741499 - Remove HeadlessThemeGTK. r=spohl We can just use the non-native theme, which is much more complete than this. Differential Revision: https://phabricator.services.mozilla.com/D131276
c7f9314dc6b40672eebd62c0217654e0ee42b762: Bug 1741495 - Make ThemeDrawsFocusForWidget return the right thing when drawing non-native widgets on Linux and Windows. r=spohl
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 17 Nov 2021 00:55:26 +0000 - rev 599398
Push 38985 by ctuns@mozilla.com at Wed, 17 Nov 2021 09:49:29 +0000
Bug 1741495 - Make ThemeDrawsFocusForWidget return the right thing when drawing non-native widgets on Linux and Windows. r=spohl Noticed this while digging into bug 1741359. Differential Revision: https://phabricator.services.mozilla.com/D131277
32793a1cded47434007d8cba5cf8bf6f0da6b0f2: Bug 1740119 - Let Window Server disconnection ride the trains r=spohl
Haik Aftandilian <haftandilian@mozilla.com> - Tue, 09 Nov 2021 02:22:35 +0000 - rev 598605
Push 38964 by malexandru@mozilla.com at Tue, 09 Nov 2021 07:28:52 +0000
Bug 1740119 - Let Window Server disconnection ride the trains r=spohl Differential Revision: https://phabricator.services.mozilla.com/D130691
281b10f8da46d9f7cb8a6535b741136580b457d1: Bug 1737085 - Mac browser_TabUnloader.js Nightly as Beta test failure r=spohl
Haik Aftandilian <haftandilian@mozilla.com> - Thu, 28 Oct 2021 15:34:31 +0000 - rev 597236
Push 38923 by csabou@mozilla.com at Thu, 28 Oct 2021 22:34:57 +0000
Bug 1737085 - Mac browser_TabUnloader.js Nightly as Beta test failure r=spohl Test-only fix: pref-on tab unloading and memory-pressure notifications when the test is run on beta or release. Tab unloading and memory pressure notifications are limited to Nightly at this time. Differential Revision: https://phabricator.services.mozilla.com/D129665
d3ad47305d043c6d9a63b05388c206caa7726b71: Bug 1730066 - Enable tab unloading on macOS r=spohl
Haik Aftandilian <haftandilian@mozilla.com> - Thu, 21 Oct 2021 04:43:35 +0000 - rev 596525
Push 38900 by nfay@mozilla.com at Thu, 21 Oct 2021 09:36:31 +0000
Bug 1730066 - Enable tab unloading on macOS r=spohl Enable tab unloading on macOS when the OS memory pressure level reaches "critical". Add a gtest that exercises the memory pressure response by testing that a tab unload attempt occurs and the internal memory-pressure notification is sent. Test does not cause a real OS memory pressure event. Use the memory_pressure(1) macOS command to generate artificial memory pressure events to test the browser response. For example, the following artificially puts the OS in the "critical" memory pressure level for 60 seconds. `$ sudo memory_pressure -S -l critical -s 60` Differential Revision: https://phabricator.services.mozilla.com/D126560
5aaf8123b97aafacc1a001396b2c1d417fbd4b0d: Bug 1467758 - WindowServer connection never being terminated r=spohl
Haik Aftandilian <haftandilian@mozilla.com> - Tue, 19 Oct 2021 16:38:33 +0000 - rev 596369
Push 38896 by abutkovits@mozilla.com at Tue, 19 Oct 2021 21:51:00 +0000
Bug 1467758 - WindowServer connection never being terminated r=spohl Drop the window server connection from the content process sandbox when out-of-process WebGL is enabled. Differential Revision: https://phabricator.services.mozilla.com/D128842
40fe290c760459430ae64aca0df18477f1aff466: Bug 1722833 - Make MozButtonactivetext use NSColor.controlTextColor on macOS 12+. r=mac-reviewers,spohl
Markus Stange <mstange.moz@gmail.com> - Mon, 18 Oct 2021 21:29:42 +0000 - rev 596249
Push 38892 by ctuns@mozilla.com at Tue, 19 Oct 2021 04:21:59 +0000
Bug 1722833 - Make MozButtonactivetext use NSColor.controlTextColor on macOS 12+. r=mac-reviewers,spohl Depends on D128785 Differential Revision: https://phabricator.services.mozilla.com/D128786
f718eaf8816e2fabd319aab507691fa829a2df88: Bug 1722833 - Add nsCocoaFeatures::OnMontereyOrLater(). r=mac-reviewers,spohl
Markus Stange <mstange.moz@gmail.com> - Mon, 18 Oct 2021 21:29:42 +0000 - rev 596248
Push 38892 by ctuns@mozilla.com at Tue, 19 Oct 2021 04:21:59 +0000
Bug 1722833 - Add nsCocoaFeatures::OnMontereyOrLater(). r=mac-reviewers,spohl Depends on D128616 Differential Revision: https://phabricator.services.mozilla.com/D128785
de071c6d60a73a8a0267ad5b3acb44ed4e5d76e5: Bug 1722833 - Tweak default button :active state rendering. r=mac-reviewers,spohl
Markus Stange <mstange.moz@gmail.com> - Mon, 18 Oct 2021 21:29:41 +0000 - rev 596247
Push 38892 by ctuns@mozilla.com at Tue, 19 Oct 2021 04:21:59 +0000
Bug 1722833 - Tweak default button :active state rendering. r=mac-reviewers,spohl Before this patch we were drawing default buttons as follows: (no state): Drawn as a regular default button, with white text. :active:hover: Drawn as a pressed non-default button, with white text. :active:not(:hover): Drawn as a regular non-default button, with regular button text (black in light mode, white in dark mode). With this patch, we are drawing default buttons as follows: (no state): Unchanged. :active:hover: Drawn as a pressed *default* button, with white text. :active:not(:hover): Drawn as a regular *default* button, with white text. So we're changing both the pressed state and the "dragged" state. The pressed state looks the same as before on all macOS versions prior to macOS 12; on those versions, pressed default buttons and pressed non-default buttons look the same. It's only on macOS 12 that the two diverge. The "dragged" state didn't seem to match any native behavior in the past, and is corrected for all macOS versions now. Differential Revision: https://phabricator.services.mozilla.com/D128616
8d0f2c12cfd5f915f284369075fe690d3f09b031: Bug 1728339 - Find the mount point BSD name correctly even under App Translocation, by calling statfs a second time. r=spohl
Markus Stange <mstange.moz@gmail.com> - Tue, 31 Aug 2021 21:23:50 +0000 - rev 590376
Push 38752 by malexandru@mozilla.com at Wed, 01 Sep 2021 03:48:05 +0000
Bug 1728339 - Find the mount point BSD name correctly even under App Translocation, by calling statfs a second time. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D124126
e154fb92d7312b8d15bcfd519c8424ede831d962: Bug 516362 p3. Add API to install from .dmg and relaunch. r=mstange,spohl
Jonathan Watt <jwatt@jwatt.org> - Mon, 30 Aug 2021 21:15:05 +0000 - rev 590260
Push 38748 by mlaza@mozilla.com at Tue, 31 Aug 2021 03:18:05 +0000
Bug 516362 p3. Add API to install from .dmg and relaunch. r=mstange,spohl Depends on D122685 Differential Revision: https://phabricator.services.mozilla.com/D122686
eb8885d5cd62970b7b0d215febbd5da6563f9198: Bug 516362 p3. Add API to install from .dmg and relaunch. r=mstange,spohl
Jonathan Watt <jwatt@jwatt.org> - Mon, 30 Aug 2021 17:51:54 +0000 - rev 590222
Push 38748 by mlaza@mozilla.com at Tue, 31 Aug 2021 03:18:05 +0000
Bug 516362 p3. Add API to install from .dmg and relaunch. r=mstange,spohl Depends on D122685 Differential Revision: https://phabricator.services.mozilla.com/D122686
32779cf61a9f6a4e6927d0fc104fa11072d9ea94: Bug 1714382 - Include the Mac memory pressure state in crash reports r=spohl,KrisWright
Haik Aftandilian <haftandilian@mozilla.com> - Tue, 27 Jul 2021 16:17:43 +0000 - rev 586746
Push 38647 by smolnar@mozilla.com at Wed, 28 Jul 2021 09:43:36 +0000
Bug 1714382 - Include the Mac memory pressure state in crash reports r=spohl,KrisWright Subscribe to memory pressure events on macOS and add crash report annotations to parent and content process crash reports that can be used to determine if the system was under memory pressure at the time of the crash. Include the memory pressure level reported via the DISPATCH_SOURCE_TYPE_MEMORYPRESSURE dispatch with timestamps of transitions, the memory pressure level as read from the kern.memorystatus_vm_pressure_level sysctl, and a measurement of the percentage of available memory in the system read from the kern.memorystatus_level sysctl. Differential Revision: https://phabricator.services.mozilla.com/D116725
4f0fe70a0e342747469bce427887727ee491f741: Bug 1714382 - Include the Mac memory pressure state in crash reports r=spohl,KrisWright
Haik Aftandilian <haftandilian@mozilla.com> - Mon, 26 Jul 2021 22:52:33 +0000 - rev 586685
Push 38644 by ncsoregi@mozilla.com at Tue, 27 Jul 2021 09:45:43 +0000
Bug 1714382 - Include the Mac memory pressure state in crash reports r=spohl,KrisWright Subscribe to memory pressure events on macOS and add crash report annotations to parent and content process crash reports that can be used to determine if the system was under memory pressure at the time of the crash. Include the memory pressure level reported via the DISPATCH_SOURCE_TYPE_MEMORYPRESSURE dispatch with timestamps of transitions, the memory pressure level as read from the kern.memorystatus_vm_pressure_level sysctl, and a measurement of the percentage of available memory in the system read from the kern.memorystatus_level sysctl. Differential Revision: https://phabricator.services.mozilla.com/D116725
d6b8125adf269b9ffe42446eec91d216864484fc: Bug 1710474 - Don't roll up native context menus in response to wheel events. r=mac-reviewers,spohl,bradwerth
Markus Stange <mstange.moz@gmail.com> - Mon, 24 May 2021 15:14:04 +0000 - rev 580529
Push 38488 by nbeleuzu@mozilla.com at Mon, 24 May 2021 21:58:32 +0000
Bug 1710474 - Don't roll up native context menus in response to wheel events. r=mac-reviewers,spohl,bradwerth I didn't add this check originally because the thinking was that macOS wouldn't dispatch these events to us anyway as long as a menu is open. However, our menu opening is asynchronous. So we can still get wheel events between the mousedown that asks to open the menu, and the delayed perform which then ends up opening the menu for real. We don't want to cancel opening when we get these straggler events. Differential Revision: https://phabricator.services.mozilla.com/D115763
b80e86475871c9bbfbab6a5ed6db3e38c9b5956f: Bug 1709598. Implement API to pin the app to the macOS Dock. r=spohl
Jonathan Watt <jwatt@jwatt.org> - Sat, 22 May 2021 23:45:55 +0000 - rev 580497
Push 38485 by cbrindusan@mozilla.com at Sun, 23 May 2021 09:23:07 +0000
Bug 1709598. Implement API to pin the app to the macOS Dock. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D115550
e706f7128abd09546d33033401fc85b1000681fa: Bug 1709598. Implement API to pin the app to the macOS Dock. r=spohl
Jonathan Watt <jwatt@jwatt.org> - Sat, 22 May 2021 22:44:00 +0000 - rev 580494
Push 38485 by cbrindusan@mozilla.com at Sun, 23 May 2021 09:23:07 +0000
Bug 1709598. Implement API to pin the app to the macOS Dock. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D115550
8c381a3500a284dae1ca91120ecb74f1dd7c1254: Bug 1708324 - [Fission] Full screen button for YouTube video embedded on Reddit doesn't work r=spohl
Haik Aftandilian <haftandilian@mozilla.com> - Tue, 18 May 2021 04:54:25 +0000 - rev 579850
Push 38469 by ncsoregi@mozilla.com at Tue, 18 May 2021 09:45:31 +0000
Bug 1708324 - [Fission] Full screen button for YouTube video embedded on Reddit doesn't work r=spohl During fullscreen transitions on Mac, ignore occlusion events caused by the widget DOM fullscreen transition effect which uses a temporary window. Add a test that attempts to enter fullscreen from a non-focused window. This test is to ensure the fix (and future fixes) do not regress the focus requirement for fullscreen. Differential Revision: https://phabricator.services.mozilla.com/D115046
432e93434d792c0ab9e98f3086b81abebc62c9f8: Bug 1704065 - Stop consuming pan gesture events in SwipeTracker if the swiping direction is not allowed to navigate. r=spohl
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Fri, 30 Apr 2021 09:08:08 +0000 - rev 578143
Push 38421 by abutkovits@mozilla.com at Fri, 30 Apr 2021 15:34:51 +0000
Bug 1704065 - Stop consuming pan gesture events in SwipeTracker if the swiping direction is not allowed to navigate. r=spohl This is what Safari does, i.e. once after a swipe gesture has started to a direction where there is no navigation history, then even if the swipe gesture switched to the opposite direction where navigation can happen, swipe navigation will never happen. Chrome looks like they are trying to do swipe navigation in such cases, but it looks like they sometimes fail it, the swipe navigation indicator (an arrow image) doesn't show up sometime when the swipe navigation goes to the opposite direction. This change fixes stuck-in-overscroll situations where user swipes horizontally to a direction where navigation is impossible during overscrolling, but doesn't fix situations where navigation is possible but the user cancels the navigation. To fix the later situations we need a different fix apart from this change. The mochitest in this change doesn't test the stuck-in-overscroll situations at all because we need to write a browser mochitest since swipe gesture is implemented as a browser feature but unfortunately SpecialPowers.snapshotWindow doesn't capture overscrolled gutter regions for some reasons, so instead the test checks whether the swipe gesture module keeps capturing wheel events in the situations where navigation is impossible. Differential Revision: https://phabricator.services.mozilla.com/D113636
a39509fabf04ebcc7c87eca48e7ebbff00961abc: Bug 1704065 - Don't start navigation swipe gestures where there is no navigation history. r=spohl
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Fri, 30 Apr 2021 09:08:08 +0000 - rev 578142
Push 38421 by abutkovits@mozilla.com at Fri, 30 Apr 2021 15:34:51 +0000
Bug 1704065 - Don't start navigation swipe gestures where there is no navigation history. r=spohl Apparently we should check each command specified by browser.gesture.swipe.left or browser.gesture.swipe.right, it will be fixed in bug 1707118. Differential Revision: https://phabricator.services.mozilla.com/D113635
dbc085f406dbeb9d42242510cd15efee4d965f0f: Bug 1705257 - Use activateItem in browser/base/content/test/backforward/browser_history_menu.js. r=mac-reviewers,spohl
Markus Stange <mstange.moz@gmail.com> - Wed, 21 Apr 2021 02:05:54 +0000 - rev 576876
Push 38393 by imoraru@mozilla.com at Wed, 21 Apr 2021 09:56:27 +0000
Bug 1705257 - Use activateItem in browser/base/content/test/backforward/browser_history_menu.js. r=mac-reviewers,spohl Differential Revision: https://phabricator.services.mozilla.com/D112126
f2abde6197570fcf0ab4d806fcf605751210fb86: Bug 1706454 - Use openMenu and activateItem in browser_context_menu_iframe.js and head.js. r=mac-reviewers,spohl
Markus Stange <mstange.moz@gmail.com> - Tue, 20 Apr 2021 20:13:41 +0000 - rev 576825
Push 38392 by ncsoregi@mozilla.com at Wed, 21 Apr 2021 03:11:09 +0000
Bug 1706454 - Use openMenu and activateItem in browser_context_menu_iframe.js and head.js. r=mac-reviewers,spohl Differential Revision: https://phabricator.services.mozilla.com/D112818
af1e867671229d30756462e3de784d36faf00858: Bug 1705822 - Make tests in browser/components/search work when run in sequence with native context menus. r=mac-reviewers,spohl
Harry Twyford <htwyford@mozilla.com> - Fri, 16 Apr 2021 21:01:30 +0000 - rev 576410
Push 38381 by nbeleuzu@mozilla.com at Sat, 17 Apr 2021 09:50:08 +0000
Bug 1705822 - Make tests in browser/components/search work when run in sequence with native context menus. r=mac-reviewers,spohl Differential Revision: https://phabricator.services.mozilla.com/D112416
5e5fa17b38f24d1728b3086b5bee66d6d1e937d4: Bug 1705207 - Make browser_toolbar_other_bookmarks.js work with native context menus. r=mac-reviewers,spohl,mstange
Harry Twyford <htwyford@mozilla.com> - Wed, 14 Apr 2021 20:53:27 +0000 - rev 575994
Push 38374 by nbeleuzu@mozilla.com at Thu, 15 Apr 2021 04:00:11 +0000
Bug 1705207 - Make browser_toolbar_other_bookmarks.js work with native context menus. r=mac-reviewers,spohl,mstange Differential Revision: https://phabricator.services.mozilla.com/D112087
0bd9480b8b0d6b8e1d3e244d92474e761d239a7c: Bug 1704912 - Make browser/components/places/tests/browser/browser_bookmarks_toolbar_context_menu_view_options.js work with native context menus r=mac-reviewers,spohl,bradwerth
Haik Aftandilian <haftandilian@mozilla.com> - Tue, 13 Apr 2021 21:02:49 +0000 - rev 575762
Push 38370 by malexandru@mozilla.com at Wed, 14 Apr 2021 03:39:18 +0000
Bug 1704912 - Make browser/components/places/tests/browser/browser_bookmarks_toolbar_context_menu_view_options.js work with native context menus r=mac-reviewers,spohl,bradwerth Differential Revision: https://phabricator.services.mozilla.com/D111922
044d285f3b4b471b95a4231147bb14ec88b4a135: Bug 1703774 - Fix radii computation in WebRender codepath for auto-style outline. r=spohl
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 08 Apr 2021 14:23:25 +0000 - rev 575059
Push 38358 by archaeopteryx@coole-files.de at Fri, 09 Apr 2021 09:20:20 +0000
Bug 1703774 - Fix radii computation in WebRender codepath for auto-style outline. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D111235
06c7e15580ee6958098cff76b9d1d9d8de9b5657: Bug 1703604 - When using a transparent scrollbar button / track color, use the thumb color to paint the scrollbar arrow. r=spohl
Emilio Cobos Alvarez <emilio@crisal.io> - Thu, 08 Apr 2021 09:48:01 +0000 - rev 574945
Push 38357 by malexandru@mozilla.com at Thu, 08 Apr 2021 21:54:39 +0000
Bug 1703604 - When using a transparent scrollbar button / track color, use the thumb color to paint the scrollbar arrow. r=spohl This improves the rendering of youtube.com on Windows, and I think should be uncontroversial. scrollbar-color: transparent transparent will still get you the fully transparent scrollbar. Differential Revision: https://phabricator.services.mozilla.com/D111137
47b38a36e71a903474a625fbb2d5f40a76b0bd9c: Bug 1703604 - When using a transparent scrollbar button / track color, use the thumb color to paint the scrollbar arrow. r=spohl
Emilio Cobos Alvarez <emilio@crisal.io> - Wed, 07 Apr 2021 19:41:17 +0000 - rev 574874
Push 38356 by archaeopteryx@coole-files.de at Thu, 08 Apr 2021 09:51:11 +0000
Bug 1703604 - When using a transparent scrollbar button / track color, use the thumb color to paint the scrollbar arrow. r=spohl This improves the rendering of youtube.com on Windows, and I think should be uncontroversial. scrollbar-color: transparent transparent will still get you the fully transparent scrollbar. Differential Revision: https://phabricator.services.mozilla.com/D111137
96250052e0022103de7e4947ad32b1570bc61bcf: Bug 1702351 - Stop overriding NSApp.appearance if widget.macos.respect-system-appearance is false; instead, only override NSWindow appearance, nsLookAndFeel appearance and nsNativeThemeCocoa appearance. r=spohl
Markus Stange <mstange.moz@gmail.com> - Thu, 01 Apr 2021 16:42:03 +0000 - rev 574019
Push 38341 by btara@mozilla.com at Fri, 02 Apr 2021 03:33:31 +0000
Bug 1702351 - Stop overriding NSApp.appearance if widget.macos.respect-system-appearance is false; instead, only override NSWindow appearance, nsLookAndFeel appearance and nsNativeThemeCocoa appearance. r=spohl This makes it so that native context menus, the file picker, and the emoji picker will respect the system appearance even if widget.macos.respect-system-appearance is false. The pref widget.macos.respect-system-appearance now only applies to system colors (nsLookAndFeel), `-moz-default-appearance` rendering (nsNativeThemeCocoa), and to the effective NSWindow appearance for windows without an lwtheme appearance override. Differential Revision: https://phabricator.services.mozilla.com/D110485
d8797033c9d4679cf49dd8c7c57cd5ebeeff189b: Bug 1702100 - Inherit NSMenu appearance from NSApp instead of NSWindow. r=spohl,harry
Markus Stange <mstange.moz@gmail.com> - Wed, 31 Mar 2021 22:25:27 +0000 - rev 573949
Push 38338 by ncsoregi@mozilla.com at Thu, 01 Apr 2021 03:12:48 +0000
Bug 1702100 - Inherit NSMenu appearance from NSApp instead of NSWindow. r=spohl,harry Differential Revision: https://phabricator.services.mozilla.com/D110362
1a95326e8e60d1045fd3cb733c9e52c235b113fa: Bug 1702097 - Reset NSAppearance.currentAppearance before native theme drawing. r=spohl
Markus Stange <mstange.moz@gmail.com> - Wed, 31 Mar 2021 15:53:39 +0000 - rev 573898
Push 38337 by ncsoregi@mozilla.com at Wed, 31 Mar 2021 21:54:44 +0000
Bug 1702097 - Reset NSAppearance.currentAppearance before native theme drawing. r=spohl This is global state, so it can have remnants from random other state changes. Starting with Big Sur, currentAppearance is deprecated in favor of performAsCurrentDrawingAppearance, which really does seem like a better API for this. Differential Revision: https://phabricator.services.mozilla.com/D110361
27d4a4303d53f8fe087e0f71c54421374723c431: Bug 1680177 - Set the correct modifier flags on command events dispatched by the native menu system. r=mac-reviewers,spohl
Markus Stange <mstange.moz@gmail.com> - Wed, 24 Mar 2021 16:51:32 +0000 - rev 572868
Push 38318 by cbrindusan@mozilla.com at Thu, 25 Mar 2021 03:42:26 +0000
Bug 1680177 - Set the correct modifier flags on command events dispatched by the native menu system. r=mac-reviewers,spohl Differential Revision: https://phabricator.services.mozilla.com/D109635
4c60dddf4f8c203bdabef72d85c76c9e876b02ce: Bug 1687783 - Part 4: Implement TaskScheduler on macOS backed by launchd. r=agashlin,spohl
Nick Alexander <nalexander@mozilla.com> - Thu, 11 Mar 2021 15:29:51 +0000 - rev 570686
Push 38279 by nerli@mozilla.com at Fri, 12 Mar 2021 03:37:52 +0000
Bug 1687783 - Part 4: Implement TaskScheduler on macOS backed by launchd. r=agashlin,spohl Differential Revision: https://phabricator.services.mozilla.com/D102789
194e31587e6c4174702a223b448e8748b1b4a144: Bug 1687783 - Part 4: Implement TaskScheduler on macOS backed by launchd. r=agashlin,spohl
Nick Alexander <nalexander@mozilla.com> - Wed, 10 Mar 2021 04:28:56 +0000 - rev 570406
Push 38276 by dluca@mozilla.com at Wed, 10 Mar 2021 21:58:46 +0000
Bug 1687783 - Part 4: Implement TaskScheduler on macOS backed by launchd. r=agashlin,spohl Differential Revision: https://phabricator.services.mozilla.com/D102789
1ccb7fa94f322ee96ec6aa02bb57ff6b8ee8e4b9: Bug 1697341 - Remove vibrancy code for sheet windows. r=spohl
Markus Stange <mstange@themasta.com> - Wed, 10 Mar 2021 00:54:21 +0000 - rev 570394
Push 38276 by dluca@mozilla.com at Wed, 10 Mar 2021 21:58:46 +0000
Bug 1697341 - Remove vibrancy code for sheet windows. r=spohl With -moz-appearance: dialog now always being transparent, setting up our own vibrant views for sheet windows is no longer necessary. We now let the regular sheet window background show through, and that background is already vibrant. Differential Revision: https://phabricator.services.mozilla.com/D51462
24a948d6dc0fd9b5ae718226ebaa6b3ebd01fbd8: Bug 1693959 - Return 2 instead of 4 for tooltip shadowOptions on 10.13 and below. r=spohl
Markus Stange <mstange.moz@gmail.com> - Mon, 01 Mar 2021 20:58:43 +0000 - rev 569136
Push 38256 by btara@mozilla.com at Wed, 03 Mar 2021 04:16:49 +0000
Bug 1693959 - Return 2 instead of 4 for tooltip shadowOptions on 10.13 and below. r=spohl On 10.13 and below, the native NSToolTipPanel doesn't override shadowOptions so it probably returns the panel default (which is 2) as well. Differential Revision: https://phabricator.services.mozilla.com/D106223
9c2ae38a274476b47917b5c9d3ccf5075a92ca0e: Bug 1694059 - Rename various nnt prefs. r=spohl,mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 22 Feb 2021 20:05:35 +0000 - rev 568278
Push 38230 by malexandru@mozilla.com at Tue, 23 Feb 2021 03:36:12 +0000
Bug 1694059 - Rename various nnt prefs. r=spohl,mstange As per feedback in D105931. Differential Revision: https://phabricator.services.mozilla.com/D105991
ffe056c7c496395708f643aeb00910622d689f64: Bug 1694002 - Tweak swipe threshold values to require more "deliberate" swiping. r=spohl
Markus Stange <mstange.moz@gmail.com> - Sun, 21 Feb 2021 00:41:32 +0000 - rev 568163
Push 38223 by dluca@mozilla.com at Sun, 21 Feb 2021 09:48:21 +0000
Bug 1694002 - Tweak swipe threshold values to require more "deliberate" swiping. r=spohl This reduces the required swipe distance, but increases how much velocity is needed to fling the page over the threshold. On the touchpad, the result feels more similar to Safari now, in my testing. With the magic mouse, it's still really easy to accidentally trigger a swipe with a horizontal fling; it seems easier to accumulate a lot of velocity quickly with the magic mouse. Differential Revision: https://phabricator.services.mozilla.com/D105873
b24f6cf3c3daccf3ae3bb1f4c1b15de1db836a38: Bug 1694000 - Restrict the MOZ_CRASH for uncaught exceptions in the event loop to the Nightly channel. r=spohl
Markus Stange <mstange.moz@gmail.com> - Sat, 20 Feb 2021 22:11:34 +0000 - rev 568162
Push 38223 by dluca@mozilla.com at Sun, 21 Feb 2021 09:48:21 +0000
Bug 1694000 - Restrict the MOZ_CRASH for uncaught exceptions in the event loop to the Nightly channel. r=spohl This reduces risk while we gather an inventory of exceptions that are outside our control and which we want to ignore. We still log all (non-ignored) exceptions in Beta/Release builds, we just don't crash for them. So if something else later causes a crash, we will still see the information in crash reports. Depends on D105871 Differential Revision: https://phabricator.services.mozilla.com/D105872
7a07827d12d7e7fb142333921a80b50a330f9e7f: Bug 1694000 - Ignore "Missing Touches." exception when it bubbles up to the event loop. r=spohl
Markus Stange <mstange.moz@gmail.com> - Sat, 20 Feb 2021 22:11:34 +0000 - rev 568161
Push 38223 by dluca@mozilla.com at Sun, 21 Feb 2021 09:48:21 +0000
Bug 1694000 - Ignore "Missing Touches." exception when it bubbles up to the event loop. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D105871
4bbe4ca120c52e43c689a0d943985b5dc70f9b5d: Bug 1693688 - Make the non-native theme not return minimum sizes for checkboxes (and most other widgets). r=spohl,mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 20 Feb 2021 00:13:10 +0000 - rev 568151
Push 38221 by cbrindusan@mozilla.com at Sat, 20 Feb 2021 09:33:16 +0000
Bug 1693688 - Make the non-native theme not return minimum sizes for checkboxes (and most other widgets). r=spohl,mstange This matches closer what Chrome and Safari do (Safari paints outside of the box when this happens, but the layout box still respects the author), see: data:text/html,<button style="padding: 0; width: 0"> data:text/html,<input type=checkbox style="width: 0"> Etc. For checkboxes, this matches what OSX does, too. Since we still want checkboxes to be slightly larger than what they'd be otherwise, we add a hook to tweak it when non-native theme is enabled. Differential Revision: https://phabricator.services.mozilla.com/D105798
e0b1f4b79d4b9bb1633283ef4f9f9e9dc6c0fe7e: Bug 1693688 - Make the non-native theme not return minimum sizes for checkboxes (and most other widgets). r=spohl,mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 19 Feb 2021 18:42:17 +0000 - rev 568114
Push 38221 by cbrindusan@mozilla.com at Sat, 20 Feb 2021 09:33:16 +0000
Bug 1693688 - Make the non-native theme not return minimum sizes for checkboxes (and most other widgets). r=spohl,mstange This matches closer what Chrome and Safari do (Safari paints outside of the box when this happens, but the layout box still respects the author), see: data:text/html,<button style="padding: 0; width: 0"> data:text/html,<input type=checkbox style="width: 0"> Etc. For checkboxes, this matches what OSX does, too. Since we still want checkboxes to be slightly larger than what they'd be otherwise, we add a hook to tweak it when non-native theme is enabled. Differential Revision: https://phabricator.services.mozilla.com/D105798
ffe6e944fe6cb2605abc2a7e82d07bd22a5eaac7: Bug 1693690 - Enable the native theme in toolkit/themes/osx. r=spohl
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 19 Feb 2021 18:16:55 +0000 - rev 568110
Push 38221 by cbrindusan@mozilla.com at Sat, 20 Feb 2021 09:33:16 +0000
Bug 1693690 - Enable the native theme in toolkit/themes/osx. r=spohl These tests rely on implementation details of nsNativeThemeCocoa.mm Differential Revision: https://phabricator.services.mozilla.com/D105808
cc9b78f73b0a68a78e6038b689ef767b2410dc83: Bug 1693696 - Switch custom window shadows to a different (private) API: Override -[NSWindow shadowOptions] instead of calling CGSSetWindowShadowAndRimParameters. r=mac-reviewers,spohl
Markus Stange <mstange.moz@gmail.com> - Fri, 19 Feb 2021 02:36:23 +0000 - rev 568053
Push 38218 by abutkovits@mozilla.com at Fri, 19 Feb 2021 09:45:47 +0000
Bug 1693696 - Switch custom window shadows to a different (private) API: Override -[NSWindow shadowOptions] instead of calling CGSSetWindowShadowAndRimParameters. r=mac-reviewers,spohl CGSSetWindowShadowAndRimParameters was interfering with the window's built-in mechanism to update shadow styles. The shadowOptions API should be less brittle. This also lets us get rid of the hardcoded window shadow parameters, which were based on macOS Yosemite and which look out of place on Big Sur. This patch also explicitly makes us only support different shadow types if the window is a `PopupWindow`. We effectively had the same behavior before, due to the `canBecomeKeyWindow` check. This patch also changes how the `default` style is treated: Rather than being the style for a normal top-level window, it's now the style of a regular menu/panel. Our arrow panels use `default`, so this makes them look better. The `StyleWindowShadow::Sheet` value is unused and we now treat it as default. Differential Revision: https://phabricator.services.mozilla.com/D105709
98efd2dcfc54441b8515e84c977eec22ba860d41: Bug 1693697 - Remove unnecessary call to CGSSetWindowBackgroundBlurRadius. r=mac-reviewers,spohl
Markus Stange <mstange.moz@gmail.com> - Fri, 19 Feb 2021 02:36:23 +0000 - rev 568052
Push 38218 by abutkovits@mozilla.com at Fri, 19 Feb 2021 09:45:47 +0000
Bug 1693697 - Remove unnecessary call to CGSSetWindowBackgroundBlurRadius. r=mac-reviewers,spohl This was only needed to achieve the right context menu appearance for our non-native context menus on macOS 10.9. We no longer support macOS 10.9. Differential Revision: https://phabricator.services.mozilla.com/D105708
cb05c7bcf9bff4d14ec7ade9820a26470f7e9e45: Bug 1693434 - Crash when an Objective C exception bubbles up into the native event loop. r=spohl
Markus Stange <mstange.moz@gmail.com> - Thu, 18 Feb 2021 17:25:52 +0000 - rev 568001
Push 38216 by dluca@mozilla.com at Thu, 18 Feb 2021 21:46:37 +0000
Bug 1693434 - Crash when an Objective C exception bubbles up into the native event loop. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D105562
084675db1f00b15e7bac089112ddde32bc265578: Bug 1693434 - Report uncaught Objective C exceptions. r=spohl
Markus Stange <mstange.moz@gmail.com> - Thu, 18 Feb 2021 17:25:52 +0000 - rev 568000
Push 38216 by dluca@mozilla.com at Thu, 18 Feb 2021 21:46:37 +0000
Bug 1693434 - Report uncaught Objective C exceptions. r=spohl NSSetUncaughtExceptionHandler installs a handler which is called just before we would crash anyway, I think. So this handler lets us collect information about exceptions that are not even caught by the native event loop. Differential Revision: https://phabricator.services.mozilla.com/D105561
b03a44019284e6c32e0768bb4437761d056aea11: Bug 1692647 - Apply new exception guard policy to the menu code: Non-throwing functions need to guard if they call throwing functions, see bug 1693392. r=spohl
Markus Stange <mstange.moz@gmail.com> - Wed, 17 Feb 2021 23:07:13 +0000 - rev 567902
Push 38213 by cbrindusan@mozilla.com at Thu, 18 Feb 2021 04:16:06 +0000
Bug 1692647 - Apply new exception guard policy to the menu code: Non-throwing functions need to guard if they call throwing functions, see bug 1693392. r=spohl This patch removes exception guards from a number of Objective C methods, and introduces exception guards to a number of C++ methods. The goal is to guard the "boundary" between the two worlds. Depends on D105517 Differential Revision: https://phabricator.services.mozilla.com/D105519
eb723067be18621b10a3bba3bbe3ae6a0cecb7c6: Bug 1692647 - Make Objective C exceptions fatal in menu code. r=spohl
Markus Stange <mstange.moz@gmail.com> - Wed, 17 Feb 2021 23:07:13 +0000 - rev 567901
Push 38213 by cbrindusan@mozilla.com at Thu, 18 Feb 2021 04:16:06 +0000
Bug 1692647 - Make Objective C exceptions fatal in menu code. r=spohl Fatal exceptions make it easier to reason about code, because early "abondonment" reduces the number of failure states that the code needs to handle. None of the Objective C calls we make in menu code is supposed to throw an exception; by crashing eagerly, we can quickly find out which ones do. Since this patch can introduce new crashes, I would like to get it patch into Nightly as quickly as possible so that we can watch crash stats and find any "expected" exceptions, and add custom handling for them. Differential Revision: https://phabricator.services.mozilla.com/D105517