searching for reviewer(snorp)
1362a0a6a7b2: Bug 1529119 - Expose msaa-level, double_tap_zooming, autozoom. r=snorp
Agi Sferro <agi@sferro.dev> - Mon, 22 Apr 2019 18:50:08 +0000 - rev 470388
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1529119 - Expose msaa-level, double_tap_zooming, autozoom. r=snorp FxR uses these prefs and they might be helpful to other embedders so we can just add them to GeckoRuntimeSettings. Differential Revision: https://phabricator.services.mozilla.com/D28232
55c286b28b78: Bug 1529119 - Remove duplicate entry in CHANGELOG. r=snorp
Agi Sferro <agi@sferro.dev> - Mon, 22 Apr 2019 18:50:15 +0000 - rev 470387
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1529119 - Remove duplicate entry in CHANGELOG. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D28238
c842ea1f7a56: Bug 1545106 - Fix javadoc issue in GeckoSessionSettings. r=snorp
Agi Sferro <agi@sferro.dev> - Thu, 18 Apr 2019 21:00:07 +0000 - rev 470147
Push 35888 by aiakab@mozilla.com at Fri, 19 Apr 2019 09:47:45 +0000
Bug 1545106 - Fix javadoc issue in GeckoSessionSettings. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D28079
401cb8e91e83: Bug 1545106 - Add GeckoSession-specific message delegate. r=snorp,esawin
Agi Sferro <agi@sferro.dev> - Thu, 18 Apr 2019 20:59:55 +0000 - rev 470146
Push 35888 by aiakab@mozilla.com at Fri, 19 Apr 2019 09:47:45 +0000
Bug 1545106 - Add GeckoSession-specific message delegate. r=snorp,esawin Differential Revision: https://phabricator.services.mozilla.com/D27955
cebb49d20b00: Bug 1545106 - Remove useless MessageDelegateInfo. r=snorp
Agi Sferro <agi@sferro.dev> - Thu, 18 Apr 2019 20:50:25 +0000 - rev 470145
Push 35888 by aiakab@mozilla.com at Fri, 19 Apr 2019 09:47:45 +0000
Bug 1545106 - Remove useless MessageDelegateInfo. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D28078
b749e0672a4e: Bug 1538294 - Add internal support for flushing session state to GV and flush state in response to a GeckoSession being set inactive. r=geckoview-reviewers,snorp
Dylan Roeh <droeh@mozilla.com> - Wed, 17 Apr 2019 15:26:53 +0000 - rev 470107
Push 35888 by aiakab@mozilla.com at Fri, 19 Apr 2019 09:47:45 +0000
Bug 1538294 - Add internal support for flushing session state to GV and flush state in response to a GeckoSession being set inactive. r=geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D27081
53793d2ea3ec: Bug 1539827 - Handle RuntimeException when setting clipboard data r=geckoview-reviewers,snorp
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Thu, 18 Apr 2019 10:13:38 +0000 - rev 470062
Push 35888 by aiakab@mozilla.com at Fri, 19 Apr 2019 09:47:45 +0000
Bug 1539827 - Handle RuntimeException when setting clipboard data r=geckoview-reviewers,snorp When setting large clipboard data, it may cause `TransactionTooLargeException` in binder IPC. So we have to handle `RuntimeException`. Differential Revision: https://phabricator.services.mozilla.com/D27466
5e0478607244: Bug 1518843 - GeckoView WebExtension Messaging. r=snorp,esawin,robwu,kmag
Agi Sferro <agi@mozilla.com> - Wed, 17 Apr 2019 18:28:10 +0000 - rev 469925
Push 35884 by apavel@mozilla.com at Thu, 18 Apr 2019 21:35:00 +0000
Bug 1518843 - GeckoView WebExtension Messaging. r=snorp,esawin,robwu,kmag This change allows GeckoView embedders to respond to `runtime.sendNativeMessage` and `runtime.connectNative` sent from WebExtensions. These APIs are available behind the new privileged-only permission `geckoViewAddons` and are used by GeckoView apps to communicate between content and the app. Depends On D22621 Differential Revision: https://phabricator.services.mozilla.com/D22622
8fd075dbd205: Bug 1518843 - Add GeckoView API to unregister WebExtensions. r=snorp,mbrubeck
Agi Sferro <agi@mozilla.com> - Wed, 17 Apr 2019 18:27:40 +0000 - rev 469924
Push 35884 by apavel@mozilla.com at Thu, 18 Apr 2019 21:35:00 +0000
Bug 1518843 - Add GeckoView API to unregister WebExtensions. r=snorp,mbrubeck Depends On D23093 --- .../components/geckoview/GeckoViewStartup.js | 1 + mobile/android/geckoview/api.txt | 1 + .../geckoview/test/WebExtensionTest.kt | 17 +++++++-- .../org/mozilla/geckoview/GeckoRuntime.java | 31 +++++++++++++++- .../mozilla/geckoview/doc-files/CHANGELOG.md | 6 ++- .../geckoview/GeckoViewWebExtension.jsm | 37 ++++++++++++++++++- 6 files changed, 85 insertions(+), 8 deletions(-) Differential Revision: https://phabricator.services.mozilla.com/D22621
99ba286125d1: Bug 1501108 - [3.4] Add a StorageController API to delete session context data. r=baku,snorp,geckoview-reviewers
Eugen Sawin <esawin@me73.com> - Wed, 17 Apr 2019 13:03:49 +0000 - rev 469862
Push 35883 by btara@mozilla.com at Wed, 17 Apr 2019 21:47:29 +0000
Bug 1501108 - [3.4] Add a StorageController API to delete session context data. r=baku,snorp,geckoview-reviewers Differential Revision: https://phabricator.services.mozilla.com/D23732
335cec0aacd8: Bug 1501108 - [2.3] Add Session Context ID test. r=snorp,baku
Eugen Sawin <esawin@mozilla.com> - Tue, 16 Apr 2019 20:25:10 +0000 - rev 469861
Push 35883 by btara@mozilla.com at Wed, 17 Apr 2019 21:47:29 +0000
Bug 1501108 - [2.3] Add Session Context ID test. r=snorp,baku Differential Revision: https://phabricator.services.mozilla.com/D20008
23a77e063257: Bug 1501108 - [1.3] Add GeckoView Session Context ID support. r=snorp,baku,mayhemer
Eugen Sawin <esawin@mozilla.com> - Tue, 16 Apr 2019 20:24:29 +0000 - rev 469860
Push 35883 by btara@mozilla.com at Wed, 17 Apr 2019 21:47:29 +0000
Bug 1501108 - [1.3] Add GeckoView Session Context ID support. r=snorp,baku,mayhemer Differential Revision: https://phabricator.services.mozilla.com/D19182
4a6e7c0051cb: Bug 1518843 - Move CallbackResult out of GeckoSession. r=snorp
Agi Sferro <agi@mozilla.com> - Tue, 16 Apr 2019 18:33:02 +0000 - rev 469764
Push 35882 by cbrindusan@mozilla.com at Wed, 17 Apr 2019 15:54:01 +0000
Bug 1518843 - Move CallbackResult out of GeckoSession. r=snorp Depends On D22620 Differential Revision: https://phabricator.services.mozilla.com/D23093
a1c8daed8d7f: Bug 1528279 - Don't record latencies while holding queue lock. r=geckoview-reviewers,snorp
Agi Sferro <agi@mozilla.com> - Tue, 16 Apr 2019 22:00:24 +0000 - rev 469735
Push 35880 by cbrindusan@mozilla.com at Wed, 17 Apr 2019 09:36:19 +0000
Bug 1528279 - Don't record latencies while holding queue lock. r=geckoview-reviewers,snorp Doing pretty much anything while holding the EventQueue lock is dangerous as we might try to enqueue an event and deadlock. This happens here where nsAppShell::RecordLatencies sometimes tries to enqueue an event to the main thread and deadlocks. To avoid this, we release and reacquire the lock instead. Differential Revision: https://phabricator.services.mozilla.com/D27824
a1e8c5a64ceb: Bug 1531833 - Fix PermissionDelegateTest to not require audio input on an emulator, where it's not available. r=snorp
Paul Adenot <paul@paul.cx> - Tue, 16 Apr 2019 15:44:45 +0000 - rev 469696
Push 35879 by nerli@mozilla.com at Tue, 16 Apr 2019 22:01:48 +0000
Bug 1531833 - Fix PermissionDelegateTest to not require audio input on an emulator, where it's not available. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D27573
cd74a5191ca1: Bug 1531833 - Add a Java method that enables and disable all that is needed to do audio communication with an earpiece. r=snorp
Paul Adenot <paul@paul.cx> - Tue, 16 Apr 2019 15:42:28 +0000 - rev 469691
Push 35879 by nerli@mozilla.com at Tue, 16 Apr 2019 22:01:48 +0000
Bug 1531833 - Add a Java method that enables and disable all that is needed to do audio communication with an earpiece. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D21735
ffe609cec2fe: Bug 1531833 - Add bluetooth permission to GeckoView. r=snorp
Paul Adenot <paul@paul.cx> - Tue, 16 Apr 2019 15:44:58 +0000 - rev 469690
Push 35879 by nerli@mozilla.com at Tue, 16 Apr 2019 22:01:48 +0000
Bug 1531833 - Add bluetooth permission to GeckoView. r=snorp This is needed to open an SCO channel and do proper (low-latency) bluetooth communication when doing a call using WebRTC, or simply recording local audio in a web application. I think this is more of a GeckoView thing, but I'm a bit fuzzy on the distinction, maybe it's the wrong manifest. I tested using Fennec. Differential Revision: https://phabricator.services.mozilla.com/D21734
724fc2049046: Bug 1543983 - Whitelist about:compat as a secure page on Fennec; r=snorp
Thomas Wisniewski <twisniewski@mozilla.com> - Tue, 16 Apr 2019 14:37:34 +0000 - rev 469679
Push 35879 by nerli@mozilla.com at Tue, 16 Apr 2019 22:01:48 +0000
Bug 1543983 - Whitelist about:compat as a secure page on Fennec; r=snorp Whitelist about:compat as a secure page on Fennec Differential Revision: https://phabricator.services.mozilla.com/D27391
1936dde5f34c: Bug 1501108 - [3.4] Add a StorageController API to delete session context data. r=baku,snorp,geckoview-reviewers
Eugen Sawin <esawin@me73.com> - Mon, 15 Apr 2019 20:59:24 +0000 - rev 469570
Push 35874 by ccoroiu@mozilla.com at Tue, 16 Apr 2019 04:04:58 +0000
Bug 1501108 - [3.4] Add a StorageController API to delete session context data. r=baku,snorp,geckoview-reviewers Differential Revision: https://phabricator.services.mozilla.com/D23732
de36c9fb8c65: Bug 1501108 - [2.2] Add Session Context ID test. r=snorp,baku
Eugen Sawin <esawin@mozilla.com> - Mon, 15 Apr 2019 20:58:36 +0000 - rev 469569
Push 35874 by ccoroiu@mozilla.com at Tue, 16 Apr 2019 04:04:58 +0000
Bug 1501108 - [2.2] Add Session Context ID test. r=snorp,baku Differential Revision: https://phabricator.services.mozilla.com/D20008
cad2b29b79d2: Bug 1501108 - [1.2] Add GeckoView Session Context ID support. r=snorp,baku,mayhemer
Eugen Sawin <esawin@mozilla.com> - Mon, 15 Apr 2019 20:58:30 +0000 - rev 469568
Push 35874 by ccoroiu@mozilla.com at Tue, 16 Apr 2019 04:04:58 +0000
Bug 1501108 - [1.2] Add GeckoView Session Context ID support. r=snorp,baku,mayhemer Differential Revision: https://phabricator.services.mozilla.com/D19182
82ec6a86a2bc: Bug 1542009 - Don't create a GeckoSession if there isn't one. r=geckoview-reviewers,esawin,snorp
Agi Sferro <agi@mozilla.com> - Mon, 15 Apr 2019 17:14:46 +0000 - rev 469529
Push 35873 by ccoroiu@mozilla.com at Mon, 15 Apr 2019 21:36:26 +0000
Bug 1542009 - Don't create a GeckoSession if there isn't one. r=geckoview-reviewers,esawin,snorp This fixes a problem where Gecko would call Vsync even when the browser does not have a surface attached to. This can be triggered by attaching a GeckoView without a session and then attaching a GeckoSession to the view. This causes GeckoView to create two Windows, one of which never gets put in the background causing Gecko to think the browser is still visible. The GeckoSession should be cleaned up by the GC but this may take a long time. To avoid this footgun we just don't create a GeckoSession when there isn't one already attached to the GeckoView, logging a warning in case the embedder is confused by the blank screen. Differential Revision: https://phabricator.services.mozilla.com/D27366
bc0600ed24ce: Bug 1509110 - Add testing for onHistoryStateChange and gotoHistoryIndex. r=geckoview-reviewers,snorp
Dylan Roeh <droeh@mozilla.com> - Fri, 12 Apr 2019 22:55:00 +0000 - rev 469359
Push 35865 by apavel@mozilla.com at Sat, 13 Apr 2019 21:44:49 +0000
Bug 1509110 - Add testing for onHistoryStateChange and gotoHistoryIndex. r=geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D24532
9a8350404d6c: Bug 1509110 - Add HistoryItem and HistoryList classes, HistoryDelegate.onHistoryStateChange callback, and GeckoSession.gotoHistoryIndex. r=esawin,geckoview-reviewers,snorp
Dylan Roeh <droeh@mozilla.com> - Fri, 12 Apr 2019 22:54:37 +0000 - rev 469358
Push 35865 by apavel@mozilla.com at Sat, 13 Apr 2019 21:44:49 +0000
Bug 1509110 - Add HistoryItem and HistoryList classes, HistoryDelegate.onHistoryStateChange callback, and GeckoSession.gotoHistoryIndex. r=esawin,geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D24439
951798189292: Bug 1538337 - [1.1] Add fingerprinting trackers to Content Blocking API. r=snorp,dimi,baku
Eugen Sawin <esawin@me73.com> - Fri, 12 Apr 2019 13:08:10 +0000 - rev 469275
Push 35861 by btara@mozilla.com at Fri, 12 Apr 2019 21:56:33 +0000
Bug 1538337 - [1.1] Add fingerprinting trackers to Content Blocking API. r=snorp,dimi,baku Differential Revision: https://phabricator.services.mozilla.com/D24777
1bc29703a90f: Bug 1509110 - Add testing for onHistoryStateChange and gotoHistoryIndex. r=geckoview-reviewers,snorp
Dylan Roeh <droeh@mozilla.com> - Thu, 11 Apr 2019 16:47:12 +0000 - rev 469031
Push 35856 by csabou@mozilla.com at Fri, 12 Apr 2019 03:19:48 +0000
Bug 1509110 - Add testing for onHistoryStateChange and gotoHistoryIndex. r=geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D24532
9ed5bb5e0cfc: Bug 1509110 - Add HistoryItem and HistoryList classes, HistoryDelegate.onHistoryStateChange callback, and GeckoSession.gotoHistoryIndex. r=esawin,geckoview-reviewers,snorp
Dylan Roeh <droeh@mozilla.com> - Thu, 11 Apr 2019 16:46:49 +0000 - rev 469030
Push 35856 by csabou@mozilla.com at Fri, 12 Apr 2019 03:19:48 +0000
Bug 1509110 - Add HistoryItem and HistoryList classes, HistoryDelegate.onHistoryStateChange callback, and GeckoSession.gotoHistoryIndex. r=esawin,geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D24439
81253689d39c: Bug 1509110 - Add testing for onHistoryStateChange and gotoHistoryIndex. r=geckoview-reviewers,snorp
Dylan Roeh <droeh@mozilla.com> - Thu, 11 Apr 2019 12:51:32 +0000 - rev 468999
Push 35856 by csabou@mozilla.com at Fri, 12 Apr 2019 03:19:48 +0000
Bug 1509110 - Add testing for onHistoryStateChange and gotoHistoryIndex. r=geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D24532
f3338782b169: Bug 1509110 - Add HistoryItem and HistoryList classes, HistoryDelegate.onHistoryStateChange callback, and GeckoSession.gotoHistoryIndex. r=esawin,geckoview-reviewers,snorp
Dylan Roeh <droeh@mozilla.com> - Thu, 11 Apr 2019 12:51:12 +0000 - rev 468998
Push 35856 by csabou@mozilla.com at Fri, 12 Apr 2019 03:19:48 +0000
Bug 1509110 - Add HistoryItem and HistoryList classes, HistoryDelegate.onHistoryStateChange callback, and GeckoSession.gotoHistoryIndex. r=esawin,geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D24439
b1268e5f7023: Bug 1531833 - Add a Java method that enables and disable all that is needed to do audio communication with an earpiece. r=snorp
Paul Adenot <paul@paul.cx> - Thu, 11 Apr 2019 09:19:34 +0000 - rev 468961
Push 35855 by aciure@mozilla.com at Thu, 11 Apr 2019 16:11:15 +0000
Bug 1531833 - Add a Java method that enables and disable all that is needed to do audio communication with an earpiece. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D21735
e3ec78b2db1f: Bug 1531833 - Add bluetooth permission to GeckoView. r=snorp
Paul Adenot <paul@paul.cx> - Thu, 11 Apr 2019 09:19:33 +0000 - rev 468960
Push 35855 by aciure@mozilla.com at Thu, 11 Apr 2019 16:11:15 +0000
Bug 1531833 - Add bluetooth permission to GeckoView. r=snorp This is needed to open an SCO channel and do proper (low-latency) bluetooth communication when doing a call using WebRTC, or simply recording local audio in a web application. I think this is more of a GeckoView thing, but I'm a bit fuzzy on the distinction, maybe it's the wrong manifest. I tested using Fennec. Differential Revision: https://phabricator.services.mozilla.com/D21734
d73ccfdab07c: Bug 1534756 - Don't throw exception in ManifestObtainer if a document has no manifest r=snorp
Marcos Cáceres <mcaceres@mozilla.com> - Wed, 10 Apr 2019 12:46:41 +0000 - rev 468917
Push 35854 by aciure@mozilla.com at Thu, 11 Apr 2019 09:50:57 +0000
Bug 1534756 - Don't throw exception in ManifestObtainer if a document has no manifest r=snorp We now return null when the manifest lacks a href or is missing. Differential Revision: https://phabricator.services.mozilla.com/D26873
9b937a1bec90: Bug 1534677 - Verify lang member in ManifestProcessor.jsm r=snorp
Marcos Cáceres <mcaceres@mozilla.com> - Thu, 11 Apr 2019 01:35:21 +0000 - rev 468916
Push 35854 by aciure@mozilla.com at Thu, 11 Apr 2019 09:50:57 +0000
Bug 1534677 - Verify lang member in ManifestProcessor.jsm r=snorp Implement language tag validation and canonicalization for lang member Differential Revision: https://phabricator.services.mozilla.com/D25713
ae91888401d2: Bug 1541500 - Apply Android ::selection styling to SVG as well as HTML content. r=snorp
Jonathan Kew <jkew@mozilla.com> - Wed, 10 Apr 2019 10:44:30 +0000 - rev 468749
Push 35850 by dvarga@mozilla.com at Wed, 10 Apr 2019 21:52:56 +0000
Bug 1541500 - Apply Android ::selection styling to SVG as well as HTML content. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D25980
dd9d6be5d271: Bug 1541017 - Update in-tree bugzilla components which used 'Android Background Services'. r=snorp
Sebastian Hengst <archaeopteryx@coole-files.de> - Tue, 09 Apr 2019 20:46:36 +0000 - rev 468725
Push 35850 by dvarga@mozilla.com at Wed, 10 Apr 2019 21:52:56 +0000
Bug 1541017 - Update in-tree bugzilla components which used 'Android Background Services'. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D25765
f9a157cbe246: Bug 1541609 - [geckoview] Enforce packages in API. r=snorp,esawin
Agi Sferro <agi@mozilla.com> - Wed, 10 Apr 2019 01:50:58 +0000 - rev 468690
Push 35845 by ncsoregi@mozilla.com at Wed, 10 Apr 2019 09:58:56 +0000
Bug 1541609 - [geckoview] Enforce packages in API. r=snorp,esawin Depends On D26029 Differential Revision: https://phabricator.services.mozilla.com/D26030
e0b94346bde9: Bug 1540790 - [api] Remove all org.mozilla.gecko references. r=snorp
Agi Sferro <agi@mozilla.com> - Wed, 10 Apr 2019 01:51:07 +0000 - rev 468688
Push 35845 by ncsoregi@mozilla.com at Wed, 10 Apr 2019 09:58:56 +0000
Bug 1540790 - [api] Remove all org.mozilla.gecko references. r=snorp Depends On D26027 Differential Revision: https://phabricator.services.mozilla.com/D26028
91a004f3826f: Bug 1514238 - Make RuntimeTelemetry.getSnapshot return a JSONObject. r=esawin,snorp
Agi Sferro <agi@mozilla.com> - Wed, 10 Apr 2019 01:51:15 +0000 - rev 468687
Push 35845 by ncsoregi@mozilla.com at Wed, 10 Apr 2019 09:58:56 +0000
Bug 1514238 - Make RuntimeTelemetry.getSnapshot return a JSONObject. r=esawin,snorp Depends On D26026 Differential Revision: https://phabricator.services.mozilla.com/D26027
77171121e247: Bug 1539639 - [geckoview] Add eslint for indentation and fix existing. r=esawin,snorp
Agi Sferro <agi@mozilla.com> - Wed, 10 Apr 2019 01:51:24 +0000 - rev 468685
Push 35845 by ncsoregi@mozilla.com at Wed, 10 Apr 2019 09:58:56 +0000
Bug 1539639 - [geckoview] Add eslint for indentation and fix existing. r=esawin,snorp Differential Revision: https://phabricator.services.mozilla.com/D26025
ea2baf2c9ae7: Bug 1534756 - Don't throw exception in ManifestObtainer if a document has no manifest r=snorp
Marcos Cáceres <mcaceres@mozilla.com> - Tue, 09 Apr 2019 20:32:54 +0000 - rev 468683
Push 35845 by ncsoregi@mozilla.com at Wed, 10 Apr 2019 09:58:56 +0000
Bug 1534756 - Don't throw exception in ManifestObtainer if a document has no manifest r=snorp We now return null when the manifest lacks a href or is missing. Differential Revision: https://phabricator.services.mozilla.com/D26448
c0394b2d9173: Bug 1534677 - Verify lang member in ManifestProcessor.jsm r=snorp
Marcos Cáceres <mcaceres@mozilla.com> - Mon, 08 Apr 2019 17:08:51 +0000 - rev 468465
Push 35838 by nerli@mozilla.com at Tue, 09 Apr 2019 09:54:40 +0000
Bug 1534677 - Verify lang member in ManifestProcessor.jsm r=snorp Implement language tag validation and canonicalization for lang member Differential Revision: https://phabricator.services.mozilla.com/D25713
b6f5942c42bb: Bug 1532582 - Display autofill popup in correct location. r=geckoview-reviewers,snorp,kats
Emily Toop <etoop@mozilla.com> - Fri, 29 Mar 2019 12:49:26 +0000 - rev 466757
Push 35780 by opoprus@mozilla.com at Fri, 29 Mar 2019 21:53:01 +0000
Bug 1532582 - Display autofill popup in correct location. r=geckoview-reviewers,snorp,kats This autofill popover was being displayed in the incorrect place because the display rect we were providing to the `AutofillManager` was the rect for the `GeckoView` and not the rect for the HTML element that the autofill popover was relating to. 1. Add view dimensions to info passed to autofill in `GeckoViewAutoFill`. 2. Use those view dimensions to calculate the correct location on the screen using `pageToScreenMatrix` in `GeckoSession`. The resulting locations were incorrect, as the values used by `pageToScreenMatrix` were out of date. The `GeckoSession` was only notified about updated metrics during first composite, which meant that when the metrics changed during zoom and scroll on soft keyboard presentation, `GeckoSession` was unaware of it. 3. Update `GeckoSession` with new screen metrics when they change and not only during first composite. Despite this change ensuring that `GeckoSession` always had the correct values for the viewport size and location, the request to provide the autofill location was made before the zoom and scroll was complete, meaning that even then out of date values were used during the calculation. The intial solution was to fire an event once zoom was complete, but despite this event being fired after the new screen size had been calculcated in `AsyncCompositionManager`, `GeckoSession` did not receive the values until after the event had been processed (the calls were out by 0.024ms). 5. Call new method `onScreenMetricsUpdated` inside `SessionTextInput` after screen metrics have been updated. Call `AutofillManager#notifyViewEntered` from this function. This was not my preferred solution to this, but timing issues meant I could not find/think of an alternative way of delaying the calculation of the autofill popover location until after `GeckoSession` had been updated. This patch currently fixes things on GV apps. Occasionally, on Fennec, the autofill view is out of alignment slightly. This needs further work. Differential Revision: https://phabricator.services.mozilla.com/D24397
3840d093c11b: Bug 1533704 - Don't make GeckoView's remote debugging setting control Marionette. r=snorp
Nick Alexander <nalexander@mozilla.com> - Thu, 28 Mar 2019 20:28:14 +0000 - rev 466658
Push 35776 by ccoroiu@mozilla.com at Fri, 29 Mar 2019 09:44:33 +0000
Bug 1533704 - Don't make GeckoView's remote debugging setting control Marionette. r=snorp We really want GeckoView's single remote debugigng setting to determine whether the engine can be remote controlled, but we're not quite there yet. The devtools use an abstract UNIX socket for this purpose, but Marionette uses a TCP socket that defaults to port 2828, and that means we see cross-App clashes for that port. Functionally this means that enabling Marionette reverts to the "old method": either pass the "--marionette" command line argument or set the `MOZ_MARIONETTE=1` environment variable to enable. Callers remain responsible for ensuring that the Marionette port is available. Differential Revision: https://phabricator.services.mozilla.com/D25138
78909d4b2ed3: Bug 1308405 - p5: Memorize sample buffers in CodecProxy. r=snorp
John Lin <jolin@mozilla.com> - Thu, 28 Mar 2019 18:06:25 +0000 - rev 466621
Push 35773 by ncsoregi@mozilla.com at Fri, 29 Mar 2019 04:11:36 +0000
Bug 1308405 - p5: Memorize sample buffers in CodecProxy. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D24591
f3367091fba8: Bug 1308405 - p4: Separate buffer from sample object. r=snorp
John Lin <jolin@mozilla.com> - Thu, 28 Mar 2019 18:06:23 +0000 - rev 466620
Push 35773 by ncsoregi@mozilla.com at Fri, 29 Mar 2019 04:11:36 +0000
Bug 1308405 - p4: Separate buffer from sample object. r=snorp To prevent new buffer object from being created per frame, either Sample.CREATOR has to keep track of all buffers from every remote codec, or the client must memorize seen buffers and avoid asking for them again and again. The former saves client code from modifications but complicates the implementation of Sample, a data structure class, while the latter requires changes to client code but avoid overcomplicating Sample.CREATOR implementation. The 2nd approach is taken: - move SampleBuffer out of Sample, and update clients accordingly - add a new IPC method for clients to get the buffers only when needed Differential Revision: https://phabricator.services.mozilla.com/D24590
e9985b6b2769: Bug 1308405 - p3: Use sample buffer class directly. r=snorp
John Lin <jolin@mozilla.com> - Thu, 28 Mar 2019 18:06:19 +0000 - rev 466619
Push 35773 by ncsoregi@mozilla.com at Fri, 29 Mar 2019 04:11:36 +0000
Bug 1308405 - p3: Use sample buffer class directly. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D24589
9a095e082820: Bug 1308405 - p2: Nodify and recycle sample objects. r=snorp
John Lin <jolin@mozilla.com> - Thu, 28 Mar 2019 18:05:08 +0000 - rev 466618
Push 35773 by ncsoregi@mozilla.com at Fri, 29 Mar 2019 04:11:36 +0000
Bug 1308405 - p2: Nodify and recycle sample objects. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D24588
4f609c054ed6: Bug 1539256 - Remove enabling AccessibleCaret pref in Android robocop test. r=snorp
Ting-Yu Lin <tlin@mozilla.com> - Wed, 27 Mar 2019 18:17:03 +0000 - rev 466474
Push 35768 by opoprus@mozilla.com at Thu, 28 Mar 2019 09:55:54 +0000
Bug 1539256 - Remove enabling AccessibleCaret pref in Android robocop test. r=snorp Bug 1493317 enables AccessibleCaret in unit tests. No need to manually flip the pref. Differential Revision: https://phabricator.services.mozilla.com/D24963
a6367a5c6020: Bug 1539250 - Move gv-docs task to tier 2; r=snorp
Geoff Brown <gbrown@mozilla.com> - Wed, 27 Mar 2019 13:16:19 +0000 - rev 466376
Push 35768 by opoprus@mozilla.com at Thu, 28 Mar 2019 09:55:54 +0000
Bug 1539250 - Move gv-docs task to tier 2; r=snorp Run gv-docs as tier 2 rather than tier 3, to make the task visible by default and get the benefit of at least some sheriffing. Differential Revision: https://phabricator.services.mozilla.com/D24956
2ce7f6ee895d: Bug 1530050 - [1.0] Add recommended and strict content blocking categories selections for safer app defaults. r=snorp,geckoview-reviewers
Eugen Sawin <esawin@me73.com> - Wed, 27 Mar 2019 14:39:11 +0000 - rev 466372
Push 35768 by opoprus@mozilla.com at Thu, 28 Mar 2019 09:55:54 +0000
Bug 1530050 - [1.0] Add recommended and strict content blocking categories selections for safer app defaults. r=snorp,geckoview-reviewers Differential Revision: https://phabricator.services.mozilla.com/D24967