searching for reviewer(shu)
3dee28e17417eb3fcb043027393abc7b4f506d78: Bug 1467052 - Use BindingName tag to distinguish between var and top-level function, instead of offset range. r=shu
Tooru Fujisawa <arai_a@mac.com> - Fri, 08 Jun 2018 10:06:13 +0900 - rev 421912
Push 34109 by aiakab@mozilla.com at Fri, 08 Jun 2018 09:56:12 +0000
Bug 1467052 - Use BindingName tag to distinguish between var and top-level function, instead of offset range. r=shu
b512c7a263b259b844aefd723301fb7643e1bfd2: Bug 1275292 - Delete ParseNodeAllocator::freeTree() and friends. r=shu.
Jason Orendorff <jorendorff@mozilla.com> - Tue, 27 Feb 2018 15:09:09 -0600 - rev 415647
Push 33901 by apavel@mozilla.com at Thu, 26 Apr 2018 06:05:37 +0000
Bug 1275292 - Delete ParseNodeAllocator::freeTree() and friends. r=shu.
784c1815c3c4131c0d5ed8b83988cdf7958cc54f: Bug 1438232 - Handle lazy scripts in CanReuseScriptForClone without forcing a delazify/clone. r=shu
Jan de Mooij <jdemooij@mozilla.com> - Fri, 16 Feb 2018 01:06:12 +0100 - rev 404116
Push 33451 by nbeleuzu@mozilla.com at Fri, 16 Feb 2018 09:51:13 +0000
Bug 1438232 - Handle lazy scripts in CanReuseScriptForClone without forcing a delazify/clone. r=shu
8cbd780d86fcc63b2e826494afb59452b705e3e8: Bug 1380881 - Implement optional catch binding proposal. r=shu
Kevin Gibbons <kevin@shapesecurity.com> - Wed, 12 Jul 2017 13:59:26 -0700 - rev 391315
Push 32868 by ryanvm@gmail.com at Fri, 10 Nov 2017 21:13:32 +0000
Bug 1380881 - Implement optional catch binding proposal. r=shu
50b8043a629c482ce42ff9ac29fb761bd055008a: Bug 1299519. Add a test for generator comprehensions inside derived class constructors. r=shu
Jeff Walden <jwalden@mit.edu> - Mon, 05 Sep 2016 20:23:26 -0700 - rev 390869
Push 32849 by archaeopteryx@coole-files.de at Thu, 09 Nov 2017 09:53:32 +0000
Bug 1299519. Add a test for generator comprehensions inside derived class constructors. r=shu
0a6f7d9bc6f0bcb55642c8e6422ace3c91424ee9: Bug 1374290 - Test262 export script. r=shu
Leo Balter <leonardo.balter@gmail.com> - Fri, 13 Oct 2017 14:40:01 -0700 - rev 386232
Push 32679 by archaeopteryx@coole-files.de at Sat, 14 Oct 2017 09:49:51 +0000
Bug 1374290 - Test262 export script. r=shu
ec879327cd7c9ae4be6b8a1d609fa915366d740d: Bug 1374290 - Import diff contents from a local Test262 folder. r=shu
Leo Balter <leonardo.balter@gmail.com> - Fri, 18 Aug 2017 15:58:00 -0700 - rev 386231
Push 32679 by archaeopteryx@coole-files.de at Sat, 14 Oct 2017 09:49:51 +0000
Bug 1374290 - Import diff contents from a local Test262 folder. r=shu
2e4748827cda73771b02c8e9316e257505518a36: Bug 1374239 - Store and re-throw module instantiation and evaluation errors r=shu
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 09 Aug 2017 18:05:15 +0100 - rev 376155
Push 32376 by kwierso@gmail.com at Wed, 23 Aug 2017 00:07:40 +0000
Bug 1374239 - Store and re-throw module instantiation and evaluation errors r=shu
f1fa0f399079df1a8d1b751b0ef680e15c8e561e: Bug 1365346 - Make Debugger.Source.prototype.sourceMapURL setter check its argc. r=shu
Jim Blandy <jimb@mozilla.com> - Tue, 16 May 2017 10:57:49 -0700 - rev 374712
Push 32335 by cbook@mozilla.com at Tue, 15 Aug 2017 09:42:31 +0000
Bug 1365346 - Make Debugger.Source.prototype.sourceMapURL setter check its argc. r=shu
79aa5930dbf10c62df6ec4d774e7e63ad32b36c7: Bug 1374239 - Store and re-throw module instantiation and evaluation errors r=shu
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 09 Aug 2017 18:05:15 +0100 - rev 373868
Push 32311 by kwierso@gmail.com at Fri, 11 Aug 2017 01:14:57 +0000
Bug 1374239 - Store and re-throw module instantiation and evaluation errors r=shu
074fb831cd7bf4129794047e3d3a4c3ed1a8227e: Bug 1377349 - Remove support for nested destructuring in object rest properties. r=shu
André Bargull <andre.bargull@gmail.com> - Mon, 10 Jul 2017 07:53:10 -0700 - rev 373609
Push 32305 by ryanvm@gmail.com at Wed, 09 Aug 2017 22:43:53 +0000
Bug 1377349 - Remove support for nested destructuring in object rest properties. r=shu
595d4c0210e227ff48e1095da958d5eb6b7ba5ca: Bug 1382209 - Part 2: Use correct YieldHandling for module contexts. r=shu
André Bargull <andre.bargull@gmail.com> - Wed, 09 Aug 2017 11:37:23 +0200 - rev 373608
Push 32305 by ryanvm@gmail.com at Wed, 09 Aug 2017 22:43:53 +0000
Bug 1382209 - Part 2: Use correct YieldHandling for module contexts. r=shu
bf1ddf4c16190059c640bb49a4ee15913cad8efc: Bug 1382209 - Part 1: Add new restrictions for "yield" and "await" as binding identifiers per ES2018 draft spec. r=shu
André Bargull <andre.bargull@gmail.com> - Wed, 09 Aug 2017 11:37:01 +0200 - rev 373607
Push 32305 by ryanvm@gmail.com at Wed, 09 Aug 2017 22:43:53 +0000
Bug 1382209 - Part 1: Add new restrictions for "yield" and "await" as binding identifiers per ES2018 draft spec. r=shu
97f1bedf7155dd886771d2821db258e02b6be28f: Bug 1377272 - Making ParserContext less intertwined with Parser;r=shu+381259
David Teller <dteller@mozilla.com> - Thu, 03 Aug 2017 11:27:03 +0200 - rev 373123
Push 32291 by ryanvm@gmail.com at Mon, 07 Aug 2017 01:16:58 +0000
Bug 1377272 - Making ParserContext less intertwined with Parser;r=shu+381259 To implement the BinJS decoder of Bug 1377007, we need to access ParserContext without a Parser. This patch makes it possible to construct one. MozReview-Commit-ID: Fx3S0UkU7Hq
a7128448688ccf97e31048c912f4d5dabe15f628: Bug 1379525 - Part 2: Properly handle rejection in async-from-sync iteration. r=shu
Tooru Fujisawa <arai_a@mac.com> - Fri, 04 Aug 2017 13:04:31 +0900 - rev 373065
Push 32288 by archaeopteryx@coole-files.de at Sat, 05 Aug 2017 09:55:48 +0000
Bug 1379525 - Part 2: Properly handle rejection in async-from-sync iteration. r=shu
a91dd87054d373849bdd6a3d5a26710b453164e0: Bug 1379525 - Part 1: Await on the value before yielding or returning inside async generator. r=shu,till
Tooru Fujisawa <arai_a@mac.com> - Fri, 04 Aug 2017 13:04:31 +0900 - rev 373064
Push 32288 by archaeopteryx@coole-files.de at Sat, 05 Aug 2017 09:55:48 +0000
Bug 1379525 - Part 1: Await on the value before yielding or returning inside async generator. r=shu,till
f21fd8353ea9fb7da7d159fccc8cd91859ed8abc: Bug 1379525 - Part 2: Properly handle rejection in async-from-sync iteration. r=shu
Tooru Fujisawa <arai_a@mac.com> - Fri, 04 Aug 2017 13:04:31 +0900 - rev 372940
Push 32285 by archaeopteryx@coole-files.de at Fri, 04 Aug 2017 17:29:33 +0000
Bug 1379525 - Part 2: Properly handle rejection in async-from-sync iteration. r=shu
fce216e62ff79f2f10d7c2e5b3fd5003e14c8fa8: Bug 1379525 - Part 1: Await on the value before yielding or returning inside async generator. r=shu
Tooru Fujisawa <arai_a@mac.com> - Fri, 04 Aug 2017 13:04:31 +0900 - rev 372939
Push 32285 by archaeopteryx@coole-files.de at Fri, 04 Aug 2017 17:29:33 +0000
Bug 1379525 - Part 1: Await on the value before yielding or returning inside async generator. r=shu
8f13e72bc7c5d89a57357a7b61c2e8f1a1c02a0b: Bug 1364566 - Enable lazy parsing for NonSyntactic scopes. r=shu+381259
Andrew McCreight <continuation@gmail.com> - Wed, 07 Jun 2017 13:05:14 -0700 - rev 372474
Push 32278 by archaeopteryx@coole-files.de at Thu, 03 Aug 2017 09:44:16 +0000
Bug 1364566 - Enable lazy parsing for NonSyntactic scopes. r=shu+381259 MozReview-Commit-ID: 2mu1n2POlC7
7fc035bd5371bd8d9f1910dde7a178321d4a51ed: Bug 1374290 - Fix encoding on imported PR files. r=shu
Leo Balter <leonardo.balter@gmail.com> - Tue, 01 Aug 2017 16:19:50 -0700 - rev 372407
Push 32275 by kwierso@gmail.com at Thu, 03 Aug 2017 00:12:02 +0000
Bug 1374290 - Fix encoding on imported PR files. r=shu
b5e11a443f1b8cd884bcc9694722ee13af83572d: Bug 1374290 - Import Pull Requests from Test262. r=shu
Leo Balter <leonardo.balter@gmail.com> - Tue, 01 Aug 2017 16:19:50 -0700 - rev 372406
Push 32275 by kwierso@gmail.com at Thu, 03 Aug 2017 00:12:02 +0000
Bug 1374290 - Import Pull Requests from Test262. r=shu
3bceabbf445d41049258415796c2961a04b7ef9d: Bug 1379717 - Throw TypeError when accessing caller/arguments on accessor method. r=shu
André Bargull <andre.bargull@gmail.com> - Fri, 28 Jul 2017 12:55:48 -0700 - rev 371905
Push 32256 by archaeopteryx@coole-files.de at Sun, 30 Jul 2017 09:19:42 +0000
Bug 1379717 - Throw TypeError when accessing caller/arguments on accessor method. r=shu
364538819208b8d875e54d344359d3941c73ee59: Bug 1272697 - Part 4: Add JSAPI functions for working with ReadableStream. r=shu,f=baku
Till Schneidereit <till@tillschneidereit.net> - Mon, 29 May 2017 16:26:32 +0200 - rev 371896
Push 32256 by archaeopteryx@coole-files.de at Sun, 30 Jul 2017 09:19:42 +0000
Bug 1272697 - Part 4: Add JSAPI functions for working with ReadableStream. r=shu,f=baku This adds a ton of JSAPI functions for creating and querying the state of ReadableStreams, and support for creating ReadableStream instances whose source is supplied by the embedding. MozReview-Commit-ID: 9uDWOazPaUI
ed14274963545e4e7406f51bd35700d557d2cc27: Bug 1272697 - Part 3: Implement ReadableStream and associated classes in the JS engine. r=shu
Till Schneidereit <till@tillschneidereit.net> - Tue, 31 Jan 2017 14:34:55 +0100 - rev 371895
Push 32256 by archaeopteryx@coole-files.de at Sun, 30 Jul 2017 09:19:42 +0000
Bug 1272697 - Part 3: Implement ReadableStream and associated classes in the JS engine. r=shu MozReview-Commit-ID: E4uux96ed2m
2693a863dabdd783e32e7b8ac6164e25c30fed4c: Bug 1272697 - Part 4: Add JSAPI functions for working with ReadableStream. r=shu
Till Schneidereit <till@tillschneidereit.net> - Mon, 29 May 2017 16:26:32 +0200 - rev 371726
Push 32253 by kwierso@gmail.com at Sat, 29 Jul 2017 00:40:54 +0000
Bug 1272697 - Part 4: Add JSAPI functions for working with ReadableStream. r=shu This adds a ton of JSAPI functions for creating and querying the state of ReadableStreams, and support for creating ReadableStream instances whose source is supplied by the embedding. MozReview-Commit-ID: 9uDWOazPaUI
862ba8683d196e7d194ab72d2a1680ff707c47d3: Bug 1272697 - Part 3: Implement ReadableStream and associated classes in the JS engine. r=shu
Till Schneidereit <till@tillschneidereit.net> - Tue, 31 Jan 2017 14:34:55 +0100 - rev 371725
Push 32253 by kwierso@gmail.com at Sat, 29 Jul 2017 00:40:54 +0000
Bug 1272697 - Part 3: Implement ReadableStream and associated classes in the JS engine. r=shu MozReview-Commit-ID: E4uux96ed2m
9315eabc7fb0301e772359505bff5704fe894b99: Bug 1368362 - Use setSlotWithType instead of setSlot in InitGlobalLexicalOperation. r=shu
Jan de Mooij <jdemooij@mozilla.com> - Mon, 24 Jul 2017 18:41:12 -0400 - rev 370778
Push 32232 by cbook@mozilla.com at Tue, 25 Jul 2017 12:27:52 +0000
Bug 1368362 - Use setSlotWithType instead of setSlot in InitGlobalLexicalOperation. r=shu
217ad633fbf7ea7b334c1da31c96248424f1d1dd: Bug 1379146 - SpiderMonkey: Reserve space when enqueuing compression tasks, to avoid OOM on helper threads. r=shu
Nicolas B. Pierron <nicolas.b.pierron@mozilla.com> - Fri, 21 Jul 2017 10:03:32 +0000 - rev 370202
Push 32213 by kwierso@gmail.com at Sat, 22 Jul 2017 01:13:06 +0000
Bug 1379146 - SpiderMonkey: Reserve space when enqueuing compression tasks, to avoid OOM on helper threads. r=shu
12383fa36e6b42ed97a5a097f2b0b754bde54962: Bug 1367896: Include script filename in crash reason. r=shu data-r=bsmedberg
Kris Maglione <maglione.k@gmail.com> - Wed, 05 Jul 2017 18:02:20 -0700 - rev 368201
Push 32159 by cbook@mozilla.com at Tue, 11 Jul 2017 10:52:11 +0000
Bug 1367896: Include script filename in crash reason. r=shu data-r=bsmedberg If the scope that we're trying to clone is actually a function script, this should give us the script URL. If it's not (presumably due to some sort of data corruption), it should give us a different crash, which should hopefully give us more information. MozReview-Commit-ID: Fppi0qt4GJP
95043a5e0f9732453d04812b8b6bb16e7e643ee8: Bug 1373414 - Backout wasm work stealing on JS helper threads. r=shu
Lars T Hansen <lhansen@mozilla.com> - Fri, 07 Jul 2017 16:03:39 -0700 - rev 368127
Push 32157 by kwierso@gmail.com at Tue, 11 Jul 2017 01:43:14 +0000
Bug 1373414 - Backout wasm work stealing on JS helper threads. r=shu
06895769b545612905059cdca1b09d275fa38818: Bug 1375776 (part 1) - Fix a comment about the PseudoStack. r=shu.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 03 Jul 2017 13:30:58 +1000 - rev 367349
Push 32130 by cbook@mozilla.com at Wed, 05 Jul 2017 11:01:49 +0000
Bug 1375776 (part 1) - Fix a comment about the PseudoStack. r=shu. The JS Engine now has a PseudoStack pointer, rather than a pointer and two sizes.
d365e0c892e30ea94209454ed26f57d1ad48c926: Bug 1356189 - Ensure 'await' is always a restricted identifier when parsing modules. r=shu
André Bargull <andre.bargull@gmail.com> - Wed, 28 Jun 2017 12:22:19 -0700 - rev 366632
Push 32105 by cbook@mozilla.com at Thu, 29 Jun 2017 13:47:53 +0000
Bug 1356189 - Ensure 'await' is always a restricted identifier when parsing modules. r=shu
02383934eea258ea88bf4b20a11e0dd9581a62ca: Bug 1363301: Always provide live wrappers for ScriptSourceObjects. r=shu,bholley
Kris Maglione <maglione.k@gmail.com> - Wed, 14 Jun 2017 15:38:59 -0700 - rev 364514
Push 32043 by archaeopteryx@coole-files.de at Sat, 17 Jun 2017 20:28:42 +0000
Bug 1363301: Always provide live wrappers for ScriptSourceObjects. r=shu,bholley MozReview-Commit-ID: LTNN66FywU4
e28dbb88b4c43f180a13b08e4236cc01c92ac900: Bug 1330373 - Capture JSScript::lazyScript field when encoding bytecode incrementally. r=shu
Nicolas B. Pierron <nicolas.b.pierron@mozilla.com> - Fri, 16 Jun 2017 12:31:54 +0000 - rev 364414
Push 32040 by kwierso@gmail.com at Sat, 17 Jun 2017 00:59:06 +0000
Bug 1330373 - Capture JSScript::lazyScript field when encoding bytecode incrementally. r=shu
726d125c339b2aeaccce67a7d40b8a4fdb38c826: Bug 1307633 - XDRScript: Do not attempt to free 0-initialized scriptData_ on OOM. r=shu
Nicolas B. Pierron <nicolas.b.pierron@mozilla.com> - Thu, 15 Jun 2017 12:32:27 +0000 - rev 364136
Push 32033 by archaeopteryx@coole-files.de at Thu, 15 Jun 2017 18:12:50 +0000
Bug 1307633 - XDRScript: Do not attempt to free 0-initialized scriptData_ on OOM. r=shu
29d1a9af2655b665a0a1b2eacbeaecdd6fbfbd9f: Bug 1368360 - Use distinct TDZCheckCache for for-of/for-in expression. r=shu
Ted Campbell <tcampbell@mozilla.com> - Wed, 14 Jun 2017 12:58:24 -0400 - rev 364104
Push 32033 by archaeopteryx@coole-files.de at Thu, 15 Jun 2017 18:12:50 +0000
Bug 1368360 - Use distinct TDZCheckCache for for-of/for-in expression. r=shu MozReview-Commit-ID: 6dS4wSFf4fB
d54918df1a29caa779c5149014c5ddc3c79f3b94: Bug 1370869 - Don't copy scope data in XDR decode r=shu
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 12 Jun 2017 10:43:46 +0100 - rev 363492
Push 32018 by kwierso@gmail.com at Tue, 13 Jun 2017 00:03:05 +0000
Bug 1370869 - Don't copy scope data in XDR decode r=shu
ed9bcfd60646b4e0def9b5ca80e67fa24d55af58: Bug 1370214 - Don't allocate RegExp objects during syntax parsing for RegExp literals. r=shu
André Bargull <andre.bargull@gmail.com> - Wed, 07 Jun 2017 03:19:41 -0700 - rev 363128
Push 31995 by cbook@mozilla.com at Fri, 09 Jun 2017 10:59:02 +0000
Bug 1370214 - Don't allocate RegExp objects during syntax parsing for RegExp literals. r=shu
8a43148a783bfded64c99ca534ff20f0f2f13a2a: Bug 1370869 - Don't allocate scope bindings data only to delete it immediately r=shu
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 08 Jun 2017 10:18:49 +0100 - rev 362946
Push 31989 by cbook@mozilla.com at Thu, 08 Jun 2017 12:44:27 +0000
Bug 1370869 - Don't allocate scope bindings data only to delete it immediately r=shu
bc64157bced9005d257e6b39d5189e6f2180e647: Bug 1169743 - Rework JSOP_CLASSHERITAGE to be jit-friendly. r=shu
Ted Campbell <tcampbell@mozilla.com> - Tue, 23 May 2017 16:23:53 -0400 - rev 362761
Push 31988 by cbook@mozilla.com at Thu, 08 Jun 2017 12:43:02 +0000
Bug 1169743 - Rework JSOP_CLASSHERITAGE to be jit-friendly. r=shu Initial patch by Eric Faust [:efaust]. MozReview-Commit-ID: 52I0IY0cMJn
47ce8dbb036e5452c0dd060c274cef056306d258: Bug 1356189 - Ensure 'await' is always a restricted identifier when parsing modules. r=shu
André Bargull <andre.bargull@gmail.com> - Tue, 06 Jun 2017 01:42:18 -0700 - rev 362728
Push 31987 by ryanvm@gmail.com at Thu, 08 Jun 2017 02:55:14 +0000
Bug 1356189 - Ensure 'await' is always a restricted identifier when parsing modules. r=shu
ee3c032059e517cf3d25b80c835dc45e2711b504: Bug 1368736 - Mark BaselineFrame as debuggee frame in HandleDebugTrap if the breakpoint is on JSOP_DEBUGAFTERYIELD. r=shu
Jan de Mooij <jdemooij@mozilla.com> - Tue, 06 Jun 2017 15:06:55 +0200 - rev 362575
Push 31983 by kwierso@gmail.com at Wed, 07 Jun 2017 00:19:30 +0000
Bug 1368736 - Mark BaselineFrame as debuggee frame in HandleDebugTrap if the breakpoint is on JSOP_DEBUGAFTERYIELD. r=shu
fd90d75e1b5111ca178efea29c7e1af7d1bdee4e: Bug 1369803 - Allow FinishIncrementalEncoding call even if StartIncrementalEncoding call failed. r=shu
Nicolas B. Pierron <nicolas.b.pierron@mozilla.com> - Tue, 06 Jun 2017 12:24:31 +0000 - rev 362573
Push 31983 by kwierso@gmail.com at Wed, 07 Jun 2017 00:19:30 +0000
Bug 1369803 - Allow FinishIncrementalEncoding call even if StartIncrementalEncoding call failed. r=shu
a325d838180b07692bbb0e04094ad5e1dc06cca9: Bug 1369644 - Remove use of |volatile| from ProfileEntry. r=mstange,shu,jseward,froydnj.
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 02 Jun 2017 17:16:56 +1000 - rev 362466
Push 31978 by archaeopteryx@coole-files.de at Tue, 06 Jun 2017 09:21:30 +0000
Bug 1369644 - Remove use of |volatile| from ProfileEntry. r=mstange,shu,jseward,froydnj. These annotations aren't doing anything useful. The important thing with the PseudoStack is that, during pushes, the stack pointer incrementing happens after the new entry is written, and this is ensured by the stack pointer being Atomic. The patch also improves the comments on PseudoStack.
da5a14ae4ce3084aa63a502e96af1a4c6ef76853: Bug 1357330 - Add test case. r=shu
André Bargull <andre.bargull@gmail.com> - Wed, 19 Apr 2017 05:42:25 -0700 - rev 362271
Push 31966 by archaeopteryx@coole-files.de at Mon, 05 Jun 2017 09:06:08 +0000
Bug 1357330 - Add test case. r=shu
76bff2cde94c44b7bd1c3d2ce847db095175577f: Bug 1357330. r=shu
André Bargull <andre.bargull@gmail.com> - Tue, 18 Apr 2017 07:07:13 -0700 - rev 362270
Push 31966 by archaeopteryx@coole-files.de at Mon, 05 Jun 2017 09:06:08 +0000
Bug 1357330. r=shu
8726e36dafe1c875d86b33b5885f6b9e6d1a5a12: Bug 1369276 (part 2) - Convert ProfileEntry::Flags to Kind. r=shu.
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 02 Jun 2017 12:46:09 +1000 - rev 362248
Push 31966 by archaeopteryx@coole-files.de at Mon, 05 Jun 2017 09:06:08 +0000
Bug 1369276 (part 2) - Convert ProfileEntry::Flags to Kind. r=shu. There are three flags in ProfileEntry::Flags, which suggests there are 2**3 = 8 combinations. But there are only actually 4 valid combinations. This patch converts the three flags to a single "kind" enum, which makes things clearer. Note also that the patch moves the condition at the start of AddPseudoEntry() to its callsite, for consistency with the earlier JS_OSR entry kind check.
70e36d9d546e22b44ec55eb5906987d95bfcbcc7: Bug 1369276 (part 1) - Fix category handling in AddPseudoEntry. r=shu.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 31 May 2017 15:03:55 +1000 - rev 362247
Push 31966 by archaeopteryx@coole-files.de at Mon, 05 Jun 2017 09:06:08 +0000
Bug 1369276 (part 1) - Fix category handling in AddPseudoEntry. r=shu. The category handling code at the end of AddPseudoEntry has two problems. - The assertion checks |category| for the IS_CPP_ENTRY flag. This represents a confusion between the entry's |category| and its |flags|. They're both stored in a single uint32_t, but are conceptually different types. So the assertion is vacuously satisfied. Furthermore, there's no clear way to fix the assertion -- it doesn't make sense to check the entry's flags for IS_CPP_ENTRY, because this code can clearly take C++ or JS entries. So the patch just removes the assertion. - The category is compared to zero. This also doesn't make sense, because zero isn't a valid category. The patch removes this comparison.
735a87a03948ba9462017b37f64fed601444c7cd: Bug 1367654 (part 3) - Remove unnecessary BEGIN_PSEUDO_JS frame from AutoGeckoProfilerEntry. r=shu.
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 26 May 2017 14:54:34 +1000 - rev 361464
Push 31931 by cbook@mozilla.com at Wed, 31 May 2017 09:29:10 +0000
Bug 1367654 (part 3) - Remove unnecessary BEGIN_PSEUDO_JS frame from AutoGeckoProfilerEntry. r=shu. BEGIN_PSEUDO_JS frames are necessary before a sequence of JS frames, in order to provide a stack address. But in AutoGeckoProfilerEntry the BEGIN_PSEUDO_JS frame is before a C++ frame, so it's useless.
7b82e5e570d6e28138167115fe74a2d5d32c9e07: Bug 1367654 (part 1) - Clean up ProfileEntry. r=shu.
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 26 May 2017 14:54:31 +1000 - rev 361462
Push 31931 by cbook@mozilla.com at Wed, 31 May 2017 09:29:10 +0000
Bug 1367654 (part 1) - Clean up ProfileEntry. r=shu. This patch: - renames flags_ as flagsAndCategory_ because it contains both the flags and the category; - uses << for some bitfield definitions, because it's easier to read; - removes some dead methods from ProfileEntry; - removes the unnecessary JS_FRIEND_API from setPC().