searching for reviewer(sfoster)
b74e5737da64a7af28ab4f81f996950917aa71c5: Bug 1548381 - Tests for the password generation autocomplete UI. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Tue, 21 May 2019 00:24:16 +0000 - rev 474670
Push 36043 by rmaries@mozilla.com at Tue, 21 May 2019 09:44:47 +0000
Bug 1548381 - Tests for the password generation autocomplete UI. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D31576
34bbe924602e6a465a34498f6e6e2f3f767ccddc: Bug 1548381 - Simplify test_autocomplete_new_password and use more common patterns. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Tue, 21 May 2019 00:24:18 +0000 - rev 474669
Push 36043 by rmaries@mozilla.com at Tue, 21 May 2019 09:44:47 +0000
Bug 1548381 - Simplify test_autocomplete_new_password and use more common patterns. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D31575
2a70e4e43c5ef18bfe4727339b656e5abff20afe: Bug 1548381 - Password generation autocomplete UI. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Tue, 21 May 2019 00:24:20 +0000 - rev 474668
Push 36043 by rmaries@mozilla.com at Tue, 21 May 2019 09:44:47 +0000
Bug 1548381 - Password generation autocomplete UI. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D31211
e92a0032aa2af1bdf34a30dc72860ad8a3b2108a: Bug 1548381 - Make a generic two-line autocomplete richlistitem element. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Tue, 21 May 2019 00:24:22 +0000 - rev 474667
Push 36043 by rmaries@mozilla.com at Tue, 21 May 2019 09:44:47 +0000
Bug 1548381 - Make a generic two-line autocomplete richlistitem element. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D31210
1433d315b1b74f64a560349c1a06a863b4083566: Bug 1548381 - Password Generation Autocomplete Result. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Tue, 21 May 2019 00:24:24 +0000 - rev 474666
Push 36043 by rmaries@mozilla.com at Tue, 21 May 2019 09:44:47 +0000
Bug 1548381 - Password Generation Autocomplete Result. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D31209
c5b9ba215f498e7e9b00e455df27c426dc1da4a0: Bug 1548381 - Simplify login autocomplete footer result to avoid JSON. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Tue, 21 May 2019 00:24:26 +0000 - rev 474665
Push 36043 by rmaries@mozilla.com at Tue, 21 May 2019 09:44:47 +0000
Bug 1548381 - Simplify login autocomplete footer result to avoid JSON. r=sfoster We don't need to use JSON since we now support getCommentAt for extra data. Also add unit tests that are missing. Differential Revision: https://phabricator.services.mozilla.com/D31208
e79711ad9ef56e0ede123fd455ed444980d173bc: Bug 1548381 - LoginManagerParent.doAutocompleteSearch/getGeneratedPassword tests. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Tue, 21 May 2019 05:16:28 +0000 - rev 474664
Push 36043 by rmaries@mozilla.com at Tue, 21 May 2019 09:44:47 +0000
Bug 1548381 - LoginManagerParent.doAutocompleteSearch/getGeneratedPassword tests. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D31207
c1beb9ce876d02c14c4277adabd67bfd00df502b: Bug 1548381 - Generate and cache a password for autocomplete="new-password" password fields. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Tue, 21 May 2019 00:24:30 +0000 - rev 474663
Push 36043 by rmaries@mozilla.com at Tue, 21 May 2019 09:44:47 +0000
Bug 1548381 - Generate and cache a password for autocomplete="new-password" password fields. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D31206
7b82d533e37e432561ac9dedc7598ea9780d40dd: Bug 1548381 - Add prefs to release and enable password generation. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Tue, 21 May 2019 00:24:32 +0000 - rev 474662
Push 36043 by rmaries@mozilla.com at Tue, 21 May 2019 09:44:47 +0000
Bug 1548381 - Add prefs to release and enable password generation. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D31205
0e7d8f96bf123f5d0f491fe7780223bde509e841: Bug 1548381 - Tests for the password generation autocomplete UI. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 20 May 2019 19:56:27 +0000 - rev 474626
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1548381 - Tests for the password generation autocomplete UI. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D31576
738ce5e88e05ae37464b0e94889a5156c5497435: Bug 1548381 - Simplify test_autocomplete_new_password and use more common patterns. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 20 May 2019 19:56:20 +0000 - rev 474625
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1548381 - Simplify test_autocomplete_new_password and use more common patterns. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D31575
38e35b6d8d80300cb306a782d1167ec5343acd36: Bug 1548381 - Password generation autocomplete UI. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 20 May 2019 19:56:07 +0000 - rev 474624
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1548381 - Password generation autocomplete UI. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D31211
cddbcd92ec10d62b501a42472f99152af909d26e: Bug 1548381 - Make a generic two-line autocomplete richlistitem element. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 20 May 2019 19:55:54 +0000 - rev 474623
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1548381 - Make a generic two-line autocomplete richlistitem element. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D31210
60ff6e363acf84e6c77e0f10fa47acced7b7968e: Bug 1548381 - Password Generation Autocomplete Result. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 20 May 2019 19:55:42 +0000 - rev 474622
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1548381 - Password Generation Autocomplete Result. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D31209
1e2300b95a59dfa70594e01e6b34716141e22105: Bug 1548381 - Simplify login autocomplete footer result to avoid JSON. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 20 May 2019 19:55:34 +0000 - rev 474621
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1548381 - Simplify login autocomplete footer result to avoid JSON. r=sfoster We don't need to use JSON since we now support getCommentAt for extra data. Also add unit tests that are missing. Differential Revision: https://phabricator.services.mozilla.com/D31208
e0cf735bdcf5235d4e2e7416d5a07956e7e74671: Bug 1548381 - LoginManagerParent.doAutocompleteSearch/getGeneratedPassword tests. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 20 May 2019 19:55:15 +0000 - rev 474620
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1548381 - LoginManagerParent.doAutocompleteSearch/getGeneratedPassword tests. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D31207
fde90ccfb57027a25127edd92eade0bc3e8c853f: Bug 1548381 - Generate and cache a password for autocomplete="new-password" password fields. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 20 May 2019 19:54:58 +0000 - rev 474619
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1548381 - Generate and cache a password for autocomplete="new-password" password fields. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D31206
426750b88fc2c221b005da3c4d8918216c7c0548: Bug 1548381 - Add prefs to release and enable password generation. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 20 May 2019 19:54:45 +0000 - rev 474618
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1548381 - Add prefs to release and enable password generation. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D31205
9cf745b75ebc43caf7d734ddf1526df2b803a7e2: Bug 1551407 - Move LoginAutoCompleteResult ctr. variables closer to their use and cleanup cruft. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 20 May 2019 18:22:09 +0000 - rev 474586
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1551407 - Move LoginAutoCompleteResult ctr. variables closer to their use and cleanup cruft. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D31035
289880efd19336feedf4dc5c3d75c799446398bb: Bug 1551407 - Delete login autocomplete rows using the AutocompleteItem instance. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 20 May 2019 19:17:05 +0000 - rev 474585
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1551407 - Delete login autocomplete rows using the AutocompleteItem instance. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D31034
801ff26b3c1de20fb8944eecd3899e49df76dd0e: Bug 1551407 - Read login autocomplete comments from the AutocompleteItem instance. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 20 May 2019 18:21:51 +0000 - rev 474584
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1551407 - Read login autocomplete comments from the AutocompleteItem instance. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D31033
dafc626c659054ce9feccae7632056cbe45a8751: Bug 1551407 - Read login autocomplete values from the AutocompleteItem instance. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 20 May 2019 18:21:42 +0000 - rev 474583
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1551407 - Read login autocomplete values from the AutocompleteItem instance. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D31032
ce3d6217e796190c89962408b59ebbda6869ba67: Bug 1551407 - Read login autocomplete labels from the AutocompleteItem instance. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 20 May 2019 18:21:40 +0000 - rev 474582
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1551407 - Read login autocomplete labels from the AutocompleteItem instance. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D31031
a737c603ae331d23393d618aaf2292395799c3a6: Bug 1551407 - Make a class for each style of login autocomplete item. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 20 May 2019 18:21:38 +0000 - rev 474581
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1551407 - Make a class for each style of login autocomplete item. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D31030
c74ca2406a0d4c550c998a5e911d7262351b75eb: Bug 1551407 - Move string utilities to the top-level of LoginAutoCompleteResult.jsm. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 20 May 2019 18:21:36 +0000 - rev 474580
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1551407 - Move string utilities to the top-level of LoginAutoCompleteResult.jsm. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D31029
00df22944d9abc5b26009738e4cfc4070ff2ed66: Bug 1551407 - Improve readability of LoginAutoCompleteResult. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 20 May 2019 18:21:34 +0000 - rev 474579
Push 36042 by dvarga@mozilla.com at Tue, 21 May 2019 04:19:40 +0000
Bug 1551407 - Improve readability of LoginAutoCompleteResult. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D31028
96563508f9fed49ddc64469d05c9d3d7be46d547: Bug 1548393 - Generate a digestable password, free of ambiguous characters. r=mhoye,sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 13 May 2019 20:55:46 +0000 - rev 473688
Push 36009 by apavel@mozilla.com at Tue, 14 May 2019 04:07:34 +0000
Bug 1548393 - Generate a digestable password, free of ambiguous characters. r=mhoye,sfoster Differential Revision: https://phabricator.services.mozilla.com/D30249
a42caa9f04fc41044437ac56eab6f6086c841d9f: Bug 1543258 - Handle NULL 'action_url' for Chrome login import. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 09 May 2019 22:59:18 +0000 - rev 473334
Push 35993 by nbeleuzu@mozilla.com at Fri, 10 May 2019 02:54:27 +0000
Bug 1543258 - Handle NULL 'action_url' for Chrome login import. r=sfoster Save it with the wildcard "" value so it works with any form action. Differential Revision: https://phabricator.services.mozilla.com/D30332
9f6d0100dec9ef0b8dc7ff7a4dc9f81364812ebc: Bug 1549146 - Resize the subdialog after showing/hiding the Custom DoH textbox to make sure scrollbars appear if necessary. r=sfoster
Jared Wein <jwein@mozilla.com> - Wed, 08 May 2019 15:49:25 +0000 - rev 473082
Push 35988 by opoprus@mozilla.com at Thu, 09 May 2019 03:32:40 +0000
Bug 1549146 - Resize the subdialog after showing/hiding the Custom DoH textbox to make sure scrollbars appear if necessary. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D30068
1b84518177e73dba6d06f515d3a09373ca19cfe7: Bug 1549537 - Unconditionally offer 'Span' option for desktop background position on Linux. r=sfoster
Ian Moody <moz-ian@perix.co.uk> - Tue, 07 May 2019 18:36:19 +0000 - rev 473024
Push 35986 by opoprus@mozilla.com at Wed, 08 May 2019 21:49:24 +0000
Bug 1549537 - Unconditionally offer 'Span' option for desktop background position on Linux. r=sfoster Bug 1544105 added a default implementation of `GfxInfoBase::FindMonitors` so `gfxInfo.getMonitors()` no longer throws on Linux, but it only ever returns the primary monitor there. Differential Revision: https://phabricator.services.mozilla.com/D30096
c22a9760c9eb5b8eac862485e90dd90e0f57be5d: Bug 1547459 - Use explicit text for desktop span preview not being available. r=sfoster
Ian Moody <moz-ian@perix.co.uk> - Mon, 06 May 2019 18:55:57 +0000 - rev 473023
Push 35986 by opoprus@mozilla.com at Wed, 08 May 2019 21:49:24 +0000
Bug 1547459 - Use explicit text for desktop span preview not being available. r=sfoster When I implemented the no preview for span I did originally try using text in the canvas, but discarded it when I realised trying to format it to display nicely (across different languages and text lengths) was a losing proposition. However just the prohibition symbol without context is confusing to users, and on reflection the text can easily be included as an element stacked on top of the canvas. Also lighten the background of the no preview message, since the pure black was indistinguishable from the frame sides on Windows and Linux. Differential Revision: https://phabricator.services.mozilla.com/D29750
036a4b9e84262578b682d6e36ac60416db334d07: Bug 1549146 - Resize the subdialog after showing/hiding the Custom textbox to make sure scrollbars appear if necessary. r=sfoster
Jared Wein <jwein@mozilla.com> - Mon, 06 May 2019 15:42:33 +0000 - rev 472711
Push 35976 by opoprus@mozilla.com at Mon, 06 May 2019 21:44:12 +0000
Bug 1549146 - Resize the subdialog after showing/hiding the Custom textbox to make sure scrollbars appear if necessary. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D30068
33363b7f728c5f4a61ccf7f890ab6f1140a5ef95: Bug 1533533-Add a label to hide synced tabs sidebar when it is shown r=sfoster,jaws,flod
Mohd Umar Alam <umaralam48@gmail.com> - Fri, 26 Apr 2019 06:10:43 +0000 - rev 471448
Push 35918 by rmaries@mozilla.com at Fri, 26 Apr 2019 15:44:19 +0000
Bug 1533533-Add a label to hide synced tabs sidebar when it is shown r=sfoster,jaws,flod Differential Revision: https://phabricator.services.mozilla.com/D28177
903c6563775ad6ec3185ba5743ba69d5a1650c2e: Bug 1540154 - Allow autocomplete=(email|tel|tel-national) to be username fields. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 03 Apr 2019 15:46:57 +0000 - rev 467813
Push 35810 by aciure@mozilla.com at Thu, 04 Apr 2019 04:33:36 +0000
Bug 1540154 - Allow autocomplete=(email|tel|tel-national) to be username fields. r=sfoster Some sites use `email`, `tel` and `tel-national` values for @autocomplete even when they are used as the username and 'username' would be more appropriate. We already allowed type=email / type=tel so allowing the autocomplete equivalents is reasonable. Differential Revision: https://phabricator.services.mozilla.com/D25883
275692bc35bcf6ef35d3bacfa69d43c1e876d52b: Bug 1304001 - Remove unused 'blur' event listener. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Fri, 22 Feb 2019 15:42:53 +0000 - rev 460599
Push 35596 by rmaries@mozilla.com at Sat, 23 Feb 2019 04:13:22 +0000
Bug 1304001 - Remove unused 'blur' event listener. r=sfoster The blur event doesn't bubble so this wouldn't actually listen to fields getting blurred. See bug 1138774. Differential Revision: https://phabricator.services.mozilla.com/D20396
d6646400f45d1a63ca75ac04e6b9b109c41970f4: Bug 1304001 - Stop passing the top window to LoginManagerContent. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Fri, 22 Feb 2019 15:41:35 +0000 - rev 460598
Push 35596 by rmaries@mozilla.com at Sat, 23 Feb 2019 04:13:22 +0000
Bug 1304001 - Stop passing the top window to LoginManagerContent. r=sfoster It wasn't clear in callee code that the window was the top-window and it wasn't necessary in many cases. Relying on the top-window would also cause problems with Fission if the windows are in separate processes. Differential Revision: https://phabricator.services.mozilla.com/D20395
32398fe05ec236a52a01c27bae96637b222c2bbd: Bug 1304001 - Move LoginUtils._getActionOrigin to LoginHelper. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Fri, 22 Feb 2019 15:41:15 +0000 - rev 460597
Push 35596 by rmaries@mozilla.com at Sat, 23 Feb 2019 04:13:22 +0000
Bug 1304001 - Move LoginUtils._getActionOrigin to LoginHelper. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D20394
e25db31b4a158194ddd1a9742ea14fdf39a4f2e5: Bug 1304001 - Move LoginUtils._getPasswordOrigin to LoginHelper. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Fri, 22 Feb 2019 15:41:03 +0000 - rev 460596
Push 35596 by rmaries@mozilla.com at Sat, 23 Feb 2019 04:13:22 +0000
Bug 1304001 - Move LoginUtils._getPasswordOrigin to LoginHelper. r=sfoster There were too many top-level objects in that large JSM and LoginHelper didn't exist when it was added. Differential Revision: https://phabricator.services.mozilla.com/D20393
06877b0fd1a95ec218992e15d8ff08cbf96e99a1: Bug 1304001 - Update comments related to gEnabled/rememberSignons. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Fri, 22 Feb 2019 15:40:43 +0000 - rev 460595
Push 35596 by rmaries@mozilla.com at Sat, 23 Feb 2019 04:13:22 +0000
Bug 1304001 - Update comments related to gEnabled/rememberSignons. r=sfoster Fixes some stales comments and identation. Differential Revision: https://phabricator.services.mozilla.com/D20392
61b426c73ccf9351cb3d0fd3a0061f02651b1d2c: Bug 1304001 - Update LoginHelper prefs even if no logger was created. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Fri, 22 Feb 2019 15:40:24 +0000 - rev 460594
Push 35596 by rmaries@mozilla.com at Sat, 23 Feb 2019 04:13:22 +0000
Bug 1304001 - Update LoginHelper prefs even if no logger was created. r=sfoster This means there is only one signon.* listener for the whole process, not per-logger. Also move LMC prefs to LMH. Differential Revision: https://phabricator.services.mozilla.com/D20391
275c3744e05930008a7e2c6adbbb1cb8ccba5767: Bug 1304001 - Stop passing the top window to LoginManagerContent. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 21 Feb 2019 20:19:16 +0000 - rev 460446
Push 35593 by ccoroiu@mozilla.com at Fri, 22 Feb 2019 16:25:14 +0000
Bug 1304001 - Stop passing the top window to LoginManagerContent. r=sfoster It wasn't clear in callee code that the window was the top-window and it wasn't necessary in many cases. Relying on the top-window would also cause problems with Fission if the windows are in separate processes. Differential Revision: https://phabricator.services.mozilla.com/D20395
c9628639b5e13d96e0c7260b5875d3987937d80c: Bug 1304001 - Move LoginUtils._getActionOrigin to LoginHelper. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 21 Feb 2019 20:18:51 +0000 - rev 460445
Push 35593 by ccoroiu@mozilla.com at Fri, 22 Feb 2019 16:25:14 +0000
Bug 1304001 - Move LoginUtils._getActionOrigin to LoginHelper. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D20394
7d8f97779a35029dcbc72430464e7254ef1d72ca: Bug 1304001 - Move LoginUtils._getPasswordOrigin to LoginHelper. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 21 Feb 2019 20:18:39 +0000 - rev 460444
Push 35593 by ccoroiu@mozilla.com at Fri, 22 Feb 2019 16:25:14 +0000
Bug 1304001 - Move LoginUtils._getPasswordOrigin to LoginHelper. r=sfoster There were too many top-level objects in that large JSM and LoginHelper didn't exist when it was added. Differential Revision: https://phabricator.services.mozilla.com/D20393
a5644de3c2f5a4dcb7e9bc4c6b0f822543d8736e: Bug 1304001 - Update comments related to gEnabled/rememberSignons. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 21 Feb 2019 20:18:19 +0000 - rev 460443
Push 35593 by ccoroiu@mozilla.com at Fri, 22 Feb 2019 16:25:14 +0000
Bug 1304001 - Update comments related to gEnabled/rememberSignons. r=sfoster Fixes some stales comments and identation. Differential Revision: https://phabricator.services.mozilla.com/D20392
e23ef4dbbc7fbd92321aa7deb4be32c11eb7d8bb: Bug 1304001 - Update LoginHelper prefs even if no logger was created. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 21 Feb 2019 20:18:05 +0000 - rev 460442
Push 35593 by ccoroiu@mozilla.com at Fri, 22 Feb 2019 16:25:14 +0000
Bug 1304001 - Update LoginHelper prefs even if no logger was created. r=sfoster This means there is only one signon.* listener for the whole process, not per-logger. Also move LMC prefs to LMH. Differential Revision: https://phabricator.services.mozilla.com/D20391
5fafa838de111e11253c041ecf98e56f782beac4: Bug 1304001 - Remove unused 'blur' event listener. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 20 Feb 2019 15:27:34 +0000 - rev 460111
Push 35584 by opoprus@mozilla.com at Thu, 21 Feb 2019 09:28:57 +0000
Bug 1304001 - Remove unused 'blur' event listener. r=sfoster The blur event doesn't bubble so this wouldn't actually listen to fields getting blurred. See bug 1138774. Differential Revision: https://phabricator.services.mozilla.com/D20396
d75340a9a2640341f920efe5d924e3d053d97a3f: Bug 1304001 - Stop passing the top window to LoginManagerContent. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 20 Feb 2019 17:59:59 +0000 - rev 460110
Push 35584 by opoprus@mozilla.com at Thu, 21 Feb 2019 09:28:57 +0000
Bug 1304001 - Stop passing the top window to LoginManagerContent. r=sfoster It wasn't clear in callee code that the window was the top-window and it wasn't necessary in many cases. Relying on the top-window would also cause problems with Fission if the windows are in separate processes. Differential Revision: https://phabricator.services.mozilla.com/D20395
ed7ae6b877df5d05ca3c2415d4ac8e0720745d10: Bug 1304001 - Move LoginUtils._getActionOrigin to LoginHelper. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 20 Feb 2019 15:27:03 +0000 - rev 460109
Push 35584 by opoprus@mozilla.com at Thu, 21 Feb 2019 09:28:57 +0000
Bug 1304001 - Move LoginUtils._getActionOrigin to LoginHelper. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D20394
93bd4d634b1437faf82bd18b1dd1a05556ad7ce5: Bug 1304001 - Move LoginUtils._getPasswordOrigin to LoginHelper. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 20 Feb 2019 15:26:44 +0000 - rev 460108
Push 35584 by opoprus@mozilla.com at Thu, 21 Feb 2019 09:28:57 +0000
Bug 1304001 - Move LoginUtils._getPasswordOrigin to LoginHelper. r=sfoster There were too many top-level objects in that large JSM and LoginHelper didn't exist when it was added. Differential Revision: https://phabricator.services.mozilla.com/D20393
e41015881591d63c4b0a2a34a9b9fb1293208e69: Bug 1304001 - Update comments related to gEnabled/rememberSignons. r=sfoster
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 20 Feb 2019 15:26:29 +0000 - rev 460107
Push 35584 by opoprus@mozilla.com at Thu, 21 Feb 2019 09:28:57 +0000
Bug 1304001 - Update comments related to gEnabled/rememberSignons. r=sfoster Fixes some stales comments and identation. Differential Revision: https://phabricator.services.mozilla.com/D20392