searching for reviewer(sfink)
227a100b5eb0725528166dbf551fd3b08f5c3c98: Bug 1565272 - Prevent races with the background decommit task r=sfink
Paul Bone <pbone@mozilla.com> - Wed, 17 Jul 2019 01:24:29 +0000 - rev 483045
Push 36303 by dvarga@mozilla.com at Wed, 17 Jul 2019 09:36:40 +0000
Bug 1565272 - Prevent races with the background decommit task r=sfink Differential Revision: https://phabricator.services.mozilla.com/D38043
e49dd8bce963da3e5782210152382af472e0eeee: Bug 1565272 - Fix some comments r=sfink
Paul Bone <pbone@mozilla.com> - Wed, 17 Jul 2019 01:24:27 +0000 - rev 483044
Push 36303 by dvarga@mozilla.com at Wed, 17 Jul 2019 09:36:40 +0000
Bug 1565272 - Fix some comments r=sfink + Spelling fixes. + Make the meaning of a comment clearer. Differential Revision: https://phabricator.services.mozilla.com/D38042
73f4c374201603e82d3e33b3af97bdaf3a818662: Bug 1565631 - Add an early return to Nursery::shouldCollect() r=sfink
Paul Bone <pbone@mozilla.com> - Tue, 16 Jul 2019 00:52:13 +0000 - rev 482871
Push 36299 by opoprus@mozilla.com at Tue, 16 Jul 2019 11:25:34 +0000
Bug 1565631 - Add an early return to Nursery::shouldCollect() r=sfink Differential Revision: https://phabricator.services.mozilla.com/D38030
4ac25fd8120af1eb7cd99bc4915f7c606bf2ba31: Bug 1564313 - Make some style changes to prose in comments r=sfink
Paul Bone <pbone@mozilla.com> - Fri, 12 Jul 2019 06:03:41 +0000 - rev 482535
Push 36284 by apavel@mozilla.com at Fri, 12 Jul 2019 21:43:58 +0000
Bug 1564313 - Make some style changes to prose in comments r=sfink * Remove double spaces after periods. * Add periods at the end of sentances. * Fix a spelling error. * Use a simpler sentance. Differential Revision: https://phabricator.services.mozilla.com/D37366
a5c589bdfa0dd716f108059dfaf9e5fbe19754a1: Bug 1564313 - Update comments to // style in nursery code r=sfink
Paul Bone <pbone@mozilla.com> - Fri, 12 Jul 2019 06:03:26 +0000 - rev 482534
Push 36284 by apavel@mozilla.com at Fri, 12 Jul 2019 21:43:58 +0000
Bug 1564313 - Update comments to // style in nursery code r=sfink Differential Revision: https://phabricator.services.mozilla.com/D37365
88bacba58490175fbd0d32cc8e02de0613159f01: Bug 1564072 - Deprecate FreeOp APIs that don't track memory and rename them to make their use obvious r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 25 Jun 2019 13:11:04 +0100 - rev 482416
Push 36281 by ncsoregi@mozilla.com at Thu, 11 Jul 2019 23:03:42 +0000
Bug 1564072 - Deprecate FreeOp APIs that don't track memory and rename them to make their use obvious r=sfink Differential Revision: https://phabricator.services.mozilla.com/D35798
e7faeed8fec20e2fbc3b101d252e1cb0a4105ee0: Bug 1564072 - Deprecate FreeOp APIs that don't track memory and rename them to make their use obvious r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 25 Jun 2019 13:11:04 +0100 - rev 482412
Push 36281 by ncsoregi@mozilla.com at Thu, 11 Jul 2019 23:03:42 +0000
Bug 1564072 - Deprecate FreeOp APIs that don't track memory and rename them to make their use obvious r=sfink Differential Revision: https://phabricator.services.mozilla.com/D35798
84bdb98325f07ff5a2bfe2dd56e1906dab9889d2: Bug 1564078 - Fix use of invocation kind that was previously lost and refactor malloc threshold updates r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 04 Jul 2019 16:01:53 +0100 - rev 482266
Push 36273 by csabou@mozilla.com at Thu, 11 Jul 2019 04:05:30 +0000
Bug 1564078 - Fix use of invocation kind that was previously lost and refactor malloc threshold updates r=sfink This restores the use of GC invocation kind that was inadvertantly removed by the patch in bug 1395509 comment 33 from the call to ZoneAllocator::updateAllGCThresholds in GCRuntime::endSweepingSweepGroup. Also refactors ZoneMallocThreshold::computeZoneTriggerBytes a little. Differential Revision: https://phabricator.services.mozilla.com/D36924
7631a5be1dd9cfcc1abe5353a9bcb5babf4e1b65: Bug 1564072 - Associate more per-zone memory with the zone r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 04 Jul 2019 15:49:19 +0100 - rev 482043
Push 36267 by aciure@mozilla.com at Wed, 10 Jul 2019 09:42:20 +0000
Bug 1564072 - Associate more per-zone memory with the zone r=sfink This replaces SystemAllocPolicy with ZoneAllocPolicy for things related to zones where possible. There are a few places where this isn't possible at the moment due to header include order. I'll try and revisit these later after removing the current malloc memory tracking as this simplifies the situation. Differential Revision: https://phabricator.services.mozilla.com/D36923
5a27a80a7a9e04a36c87baa489f04e2e379deb25: Bug 1563570 - Replace use of SweepActionRepeatFor with SweepActionForEach r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 08 Jul 2019 10:12:14 +0100 - rev 482042
Push 36267 by aciure@mozilla.com at Wed, 10 Jul 2019 09:42:20 +0000
Bug 1563570 - Replace use of SweepActionRepeatFor with SweepActionForEach r=sfink If we make the output pointer optional we can use SweepActionForEach in place of SweepAtionRepeatFor and remove the latter. Differential Revision: https://phabricator.services.mozilla.com/D37226
f0a5534db2e2c81f6a68acf9846029c74f15198a: Bug 1563570 - Remove SweepAction template parameters and replace with a fix Args struct r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 09 Jul 2019 11:15:10 +0100 - rev 482041
Push 36267 by aciure@mozilla.com at Wed, 10 Jul 2019 09:42:20 +0000
Bug 1563570 - Remove SweepAction template parameters and replace with a fix Args struct r=sfink This gets rid of all the template parameter packs everywhere now they're all basically the same thing. Differential Revision: https://phabricator.services.mozilla.com/D37225
dc90e3c311d02e70caff6abc6dd4e565b8d80c9e: Bug 1563570 - Pass sweep action loop iteration values in GCRuntime state r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 08 Jul 2019 10:12:13 +0100 - rev 482040
Push 36267 by aciure@mozilla.com at Wed, 10 Jul 2019 09:42:20 +0000
Bug 1563570 - Pass sweep action loop iteration values in GCRuntime state r=sfink This makes looping constucts take an out parameter to store the loop iteration value in. This gets rid of RemoveLastTemplateParameter which I enjoyed writing but always felt guitly about inflicting on the world. Differential Revision: https://phabricator.services.mozilla.com/D37224
955593e562a54d988860a5cb3ea7fbbd3be2ebba: Bug 1561887 part 1. Add an overload of JS::ObjectIsMarkedGray that works on TenuredHeap. r=sfink
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 08 Jul 2019 22:52:51 +0000 - rev 481937
Push 36266 by aciure@mozilla.com at Wed, 10 Jul 2019 09:40:52 +0000
Bug 1561887 part 1. Add an overload of JS::ObjectIsMarkedGray that works on TenuredHeap. r=sfink Differential Revision: https://phabricator.services.mozilla.com/D36868
71e66aca29eb5cdc74b1b05dd74ed2e35e940bc9: Bug 1563996 - Make dom.ipc.cpows.log.{enabled,stack} static prefs. r=sfink
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 09 Jul 2019 07:58:24 +0000 - rev 481859
Push 36265 by rgurzau@mozilla.com at Tue, 09 Jul 2019 15:37:42 +0000
Bug 1563996 - Make dom.ipc.cpows.log.{enabled,stack} static prefs. r=sfink Differential Revision: https://phabricator.services.mozilla.com/D37199
25c1534cc16eae5509972706e6e802933da273c7: Bug 1563996 - Make dom.ipc.cpows.forbid-unsafe-from-browser a static pref. r=sfink
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 09 Jul 2019 07:58:02 +0000 - rev 481858
Push 36265 by rgurzau@mozilla.com at Tue, 09 Jul 2019 15:37:42 +0000
Bug 1563996 - Make dom.ipc.cpows.forbid-unsafe-from-browser a static pref. r=sfink Differential Revision: https://phabricator.services.mozilla.com/D37198
ea7110a7591612495bfc01f3081424c0f86d98d9: Bug 1564072 - Track memory used by some ctypes data structures r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 27 Jun 2019 11:56:37 +0100 - rev 481752
Push 36262 by nbeleuzu@mozilla.com at Tue, 09 Jul 2019 03:48:24 +0000
Bug 1564072 - Track memory used by some ctypes data structures r=sfink The patch switches some ctypes data structures to ZoneAllocPolicy so that their memory use is tracked against the zone. The creation of heapHash in StructType::DefineInternal relies on the ZoneAllocPolicy being movable after having memory accounted to it. Differential Revision: https://phabricator.services.mozilla.com/D36178
52d045b1e2f53ddf97980fb503b121beb08ec774: Bug 1564072 - Allow ZoneAllocPolicy to be moved r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 27 Jun 2019 11:56:37 +0100 - rev 481751
Push 36262 by nbeleuzu@mozilla.com at Tue, 09 Jul 2019 03:48:24 +0000
Bug 1564072 - Allow ZoneAllocPolicy to be moved r=sfink Patch to allow ZoneAllocPolicy insstance to be moved after having memory accounted to it. This is useful in the situation where a data structure is populated before being attached to a GC thing by moving it. The code will currently assert (in unregisterPolicy()) if a ZoneAllocPolicy is copied after having memory accounted to it. This could be allowed but it seems better to force users to move in this situation. Differential Revision: https://phabricator.services.mozilla.com/D36177
2e490776b07e35013ae07a47798a983f482ffaa3: Bug 1562129 part 2 - Add --blinterp-eager to jit-test 'all' configuration. r=sfink
Jan de Mooij <jdemooij@mozilla.com> - Mon, 08 Jul 2019 11:22:04 +0000 - rev 481620
Push 36261 by nbeleuzu@mozilla.com at Tue, 09 Jul 2019 03:44:14 +0000
Bug 1562129 part 2 - Add --blinterp-eager to jit-test 'all' configuration. r=sfink To not make jstests even slower, this adds --jitflags=jstests and uses it for jstests in automation. For jstests we can use fewer jit configurations than for jit-tests. This also removes the bigint and bigintdebug autospider variants. BigInt is now enabled by default so we no longer need the configure flag etc. Differential Revision: https://phabricator.services.mozilla.com/D36307
f7088c17e4233adca92208d73394721c8c71308b: Bug 1395509 - Track malloc memory used by FileObject objects r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 11 Jun 2019 17:03:41 +0100 - rev 480904
Push 36227 by dvarga@mozilla.com at Tue, 02 Jul 2019 16:47:23 +0000
Bug 1395509 - Track malloc memory used by FileObject objects r=sfink Differential Revision: https://phabricator.services.mozilla.com/D34555
d7cd95d34fb600761c8e918274eaf31df440036b: Bug 1395509 - Use correct threshold for new malloc bytes counter r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 26 Jun 2019 13:02:28 +0100 - rev 480635
Push 36217 by ncsoregi@mozilla.com at Sat, 29 Jun 2019 10:00:32 +0000
Bug 1395509 - Use correct threshold for new malloc bytes counter r=sfink I realised I was using the wrong threshold to compare the malloc bytes counter against in ZoneAllocator::maybeMallocTriggerZoneGC. This was using the GC heap bytes threshold. In other places this correctly uses gcMallocThreshold. Differential Revision: https://phabricator.services.mozilla.com/D36009
337d59cc8ed5f211f595a2451aee9731b3638e1a: Bug 1560931 - Add low memory state API and use it to restrict max nursery size r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 24 Jun 2019 18:23:52 +0100 - rev 480181
Push 36206 by rgurzau@mozilla.com at Wed, 26 Jun 2019 21:55:08 +0000
Bug 1560931 - Add low memory state API and use it to restrict max nursery size r=sfink Add a lowMemoryState field to GCRuntime and an API set set it. Use it to restict the nursery size when resizing the nursery. Differential Revision: https://phabricator.services.mozilla.com/D35680
e996920037965b669fe3fd6306d6f8bee0ebc8bf: Bug 1560432 - Remove unused NSPR header from vm/Time.cpp. r=sfink
Jan de Mooij <jdemooij@mozilla.com> - Wed, 26 Jun 2019 15:22:27 +0000 - rev 480164
Push 36205 by rgurzau@mozilla.com at Wed, 26 Jun 2019 21:52:21 +0000
Bug 1560432 - Remove unused NSPR header from vm/Time.cpp. r=sfink Gary noticed we can't build without NSPR on Windows due to this unused #include inside #ifdef XP_WIN. This patch fixes the build. Differential Revision: https://phabricator.services.mozilla.com/D35494
eecb579563f7ab63376d5fd72ebf16ca0b672fc7: Bug 1559072: Revert GDB python bindings to old boxing format r=sfink
Iain Ireland <iireland@mozilla.com> - Tue, 25 Jun 2019 18:06:41 +0000 - rev 480157
Push 36205 by rgurzau@mozilla.com at Wed, 26 Jun 2019 21:52:21 +0000
Bug 1559072: Revert GDB python bindings to old boxing format r=sfink Depends on D35548 Differential Revision: https://phabricator.services.mozilla.com/D35549
a496acc657597bf9cf6f8d743747597ac732f182: Bug 1557193 - Enable the assertion in testScriptSourceCompression.cpp verifying that script source was, in fact, compressed off-thread synchronously. r=arai,jonco,sfink
Jeff Walden <jwalden@mit.edu> - Tue, 25 Jun 2019 02:31:44 +0000 - rev 479988
Push 36197 by aciure@mozilla.com at Tue, 25 Jun 2019 09:39:03 +0000
Bug 1557193 - Enable the assertion in testScriptSourceCompression.cpp verifying that script source was, in fact, compressed off-thread synchronously. r=arai,jonco,sfink Differential Revision: https://phabricator.services.mozilla.com/D33890
abacb77a97bbcfb54915aedd34ef7aefafdb0e78: Bug 1539270 Part 2: Runtime hook to expose the helper thread dispatch method to js r=sfink
Kristen Wright <kwright@mozilla.com> - Fri, 21 Jun 2019 20:38:02 +0000 - rev 479981
Push 36197 by aciure@mozilla.com at Tue, 25 Jun 2019 09:39:03 +0000
Bug 1539270 Part 2: Runtime hook to expose the helper thread dispatch method to js r=sfink Created a hook in Runtime to expose the helper thread dispatch method to js, which is set by XPCJSRUntime::init. Differential Revision: https://phabricator.services.mozilla.com/D27818
442d11bc5876b0134ede7abd20c812b9d4ee40a1: Bug 1395509 - Add FreeOp methods to deal with releasing RefCounted types r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 20 Jun 2019 15:17:06 -0700 - rev 479930
Push 36193 by ncsoregi@mozilla.com at Mon, 24 Jun 2019 15:28:54 +0000
Bug 1395509 - Add FreeOp methods to deal with releasing RefCounted types r=sfink Differential Revision: https://phabricator.services.mozilla.com/D35484
fb304348f7b171c95ae674adafaab5da3f3b41a9: Bug 1395509 - Track malloc memory used by script breakpoints r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 19 Jun 2019 11:15:40 -0700 - rev 479782
Push 36181 by shindli@mozilla.com at Fri, 21 Jun 2019 09:36:03 +0000
Bug 1395509 - Track malloc memory used by script breakpoints r=sfink Differential Revision: https://phabricator.services.mozilla.com/D35347
359226eb7bf50d2c23745c64979e92285ec5c830: Bug 1560064 - Barrier: Remove JS_BROKEN_GCC_ATTRIBUTE_WARNING guards. r=sfink
Marco Trevisan (Treviño) <mail@3v1n0.net> - Thu, 20 Jun 2019 19:19:58 +0200 - rev 479338
Push 36178 by aiakab@mozilla.com at Thu, 20 Jun 2019 21:50:59 +0000
Bug 1560064 - Barrier: Remove JS_BROKEN_GCC_ATTRIBUTE_WARNING guards. r=sfink
a94af4770d783d0a25bfd81b47f5b125a9fb2b2a: Bug 1560064 - Barrier: Set MovableCellHasher<JSObject*> visibility before being used. r=sfink
Marco Trevisan (Treviño) <mail@3v1n0.net> - Thu, 20 Jun 2019 19:15:39 +0200 - rev 479337
Push 36178 by aiakab@mozilla.com at Thu, 20 Jun 2019 21:50:59 +0000
Bug 1560064 - Barrier: Set MovableCellHasher<JSObject*> visibility before being used. r=sfink
ca7d45d235a61397589e68d0dc62a2bc82f9ea8c: Bug 1560064 - Barrier: Remove JS_BROKEN_GCC_ATTRIBUTE_WARNING guards r=sfink
Marco Trevisan <mail@3v1n0.net> - Wed, 19 Jun 2019 08:01:08 +0000 - rev 479190
Push 36173 by rgurzau@mozilla.com at Wed, 19 Jun 2019 15:50:11 +0000
Bug 1560064 - Barrier: Remove JS_BROKEN_GCC_ATTRIBUTE_WARNING guards r=sfink As per previous commit the warning isn't emitted anymore, so no need to guard against it. Also in this case the warning was actually right, so we need to make sure that we track similar ones. Depends on D35292 Differential Revision: https://phabricator.services.mozilla.com/D35293
75d71e4211bbf927435b0c843ba9fec15085774b: Bug 1560064 - Barrier: Set MovableCellHasher<JSObject*> visibility before being used r=sfink
Marco Trevisan <mail@3v1n0.net> - Wed, 19 Jun 2019 08:00:46 +0000 - rev 479189
Push 36173 by rgurzau@mozilla.com at Wed, 19 Jun 2019 15:50:11 +0000
Bug 1560064 - Barrier: Set MovableCellHasher<JSObject*> visibility before being used r=sfink Under GCC, the type attributes can't be set more than once, and when this happens only the firt definition they are ignored. Since MovableCellHasher<JSObject*> is used in various headers g++ implicitly set the symbol visibility to default (and thus hidden), making this symbol not to be exported as it should be. Move the template specialization with type attributes to Barrier.h, so that this might happen before any other definition, muting the warning and making the symbol to be really exported Fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=39159 Differential Revision: https://phabricator.services.mozilla.com/D35292
19f38c9cdd671aac3fc57ccde19560f337d7d992: Bug 1395509 - Track malloc memory used by TypedObject trace lists r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 12 Jun 2019 16:23:04 +0100 - rev 479043
Push 36158 by shindli@mozilla.com at Sat, 15 Jun 2019 21:47:33 +0000
Bug 1395509 - Track malloc memory used by TypedObject trace lists r=sfink This changes the format of the trace list from using -1 as a delimter to storing the list lengths up front so that we have length information. Differential Revision: https://phabricator.services.mozilla.com/D34731
219909ea3e4f3888a50771d86ad0a853a549fe39: Bug 1395509 - Track malloc memory used by PerfMesaurement objects r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 12 Jun 2019 16:22:13 +0100 - rev 479042
Push 36158 by shindli@mozilla.com at Sat, 15 Jun 2019 21:47:33 +0000
Bug 1395509 - Track malloc memory used by PerfMesaurement objects r=sfink Differential Revision: https://phabricator.services.mozilla.com/D34730
848bf60827e44be15183bd7d89d506a7677282f4: Bug 1395509 - Track malloc memory used by non-inline TypedArray elements r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 12 Jun 2019 16:22:03 +0100 - rev 479041
Push 36158 by shindli@mozilla.com at Sat, 15 Jun 2019 21:47:33 +0000
Bug 1395509 - Track malloc memory used by non-inline TypedArray elements r=sfink Note that we only track the for typed arrays that are not backed by an ArrayBuffer as the memory is tracked there from then on. Differential Revision: https://phabricator.services.mozilla.com/D34729
bc1b32cdf4ca78ef28bc6b5cfb884bef5ee56ac7: Bug 1395509 - Allow multiple associations for some memory uses r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 12 Jun 2019 16:19:52 +0100 - rev 479039
Push 36158 by shindli@mozilla.com at Sat, 15 Jun 2019 21:47:33 +0000
Bug 1395509 - Allow multiple associations for some memory uses r=sfink Some kinds of memory use (e.g. reg exp byte code) require multiple memory associations for a single cell. This patch adds machinery to let that happen for specific uses. Differential Revision: https://phabricator.services.mozilla.com/D34723
9de6fe9f087eb386f829300206084da2a0861ea3: Bug 1395509 - Track malloc memory used by TypedObject trace lists r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 12 Jun 2019 16:23:04 +0100 - rev 479005
Push 36156 by apavel@mozilla.com at Sat, 15 Jun 2019 09:57:03 +0000
Bug 1395509 - Track malloc memory used by TypedObject trace lists r=sfink This changes the format of the trace list from using -1 as a delimter to storing the list lengths up front so that we have length information. Differential Revision: https://phabricator.services.mozilla.com/D34731
d7492a7c1b7d6fa435b5aca42cec320cb050e6c6: Bug 1395509 - Track malloc memory used by PerfMesaurement objects r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 12 Jun 2019 16:22:13 +0100 - rev 479004
Push 36156 by apavel@mozilla.com at Sat, 15 Jun 2019 09:57:03 +0000
Bug 1395509 - Track malloc memory used by PerfMesaurement objects r=sfink Differential Revision: https://phabricator.services.mozilla.com/D34730
5d720afe50ea47cfc0a65d7d915afb65e91e6cc9: Bug 1395509 - Track malloc memory used by non-inline TypedArray elements r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 12 Jun 2019 16:22:03 +0100 - rev 479003
Push 36156 by apavel@mozilla.com at Sat, 15 Jun 2019 09:57:03 +0000
Bug 1395509 - Track malloc memory used by non-inline TypedArray elements r=sfink Note that we only track the for typed arrays that are not backed by an ArrayBuffer as the memory is tracked there from then on. Differential Revision: https://phabricator.services.mozilla.com/D34729
d37bdcb3509111ce7570bda5da58a4fa4eec5a43: Bug 1395509 - Allow multiple associations for some memory uses r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 12 Jun 2019 16:19:52 +0100 - rev 479001
Push 36156 by apavel@mozilla.com at Sat, 15 Jun 2019 09:57:03 +0000
Bug 1395509 - Allow multiple associations for some memory uses r=sfink Some kinds of memory use (e.g. reg exp byte code) require multiple memory associations for a single cell. This patch adds machinery to let that happen for specific uses. Differential Revision: https://phabricator.services.mozilla.com/D34723
1fca3e8b8e5e2862815ed108ab7b454eaaf33e70: Bug 1395509 - Track malloc memory used by FileObject objects r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 11 Jun 2019 17:03:41 +0100 - rev 478999
Push 36156 by apavel@mozilla.com at Sat, 15 Jun 2019 09:57:03 +0000
Bug 1395509 - Track malloc memory used by FileObject objects r=sfink Differential Revision: https://phabricator.services.mozilla.com/D34555
10cde525f0c83eca5590c337e584bf4f5f0b8145: Bug 1395509 - Track malloc memory used by Arguments objects r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 11 Jun 2019 17:03:41 +0100 - rev 478997
Push 36156 by apavel@mozilla.com at Sat, 15 Jun 2019 09:57:03 +0000
Bug 1395509 - Track malloc memory used by Arguments objects r=sfink Use memory tracking APIs to track malloc memory associated with ArgumentsObjects. This one is slightly more complicated because we can allocate these in the nursery and malloc memory is not tracked for nursery objects, so we have to do this if they get tenured. Differential Revision: https://phabricator.services.mozilla.com/D34553
ae799ea48e2cf970b0d780cdfc7494b8fabfb16c: Bug 1401624: Part 7: Update gdb pretty-printer r=sfink
Iain Ireland <iireland@mozilla.com> - Wed, 12 Jun 2019 17:51:02 +0000 - rev 478514
Push 36145 by aciure@mozilla.com at Thu, 13 Jun 2019 03:50:31 +0000
Bug 1401624: Part 7: Update gdb pretty-printer r=sfink This is a bit gross, but it passes all the tests that were not already failing. Differential Revision: https://phabricator.services.mozilla.com/D29057
037012f898dd143f0b8934a1945cfebcdeea7dcd: Bug 1401624: Part 2: Improve comments in TraceDataRelocations r=sfink
Iain Ireland <iireland@mozilla.com> - Wed, 12 Jun 2019 17:50:58 +0000 - rev 478509
Push 36145 by aciure@mozilla.com at Thu, 13 Jun 2019 03:50:31 +0000
Bug 1401624: Part 2: Improve comments in TraceDataRelocations r=sfink It took me a while to convince myself that this code was still okay for 0-tagged object Values. Adding a comment to make it clearer for future readers (and in the hope that a reviewer will notice my mistake if I am wrong.) Differential Revision: https://phabricator.services.mozilla.com/D29052
059c1897eb8f99752579a2d9e5b8d9e775a2f5e1: Bug 1395509 - Track malloc memory used by JS Map and Set objects r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 10 Jun 2019 16:11:25 +0100 - rev 478497
Push 36144 by aciure@mozilla.com at Wed, 12 Jun 2019 21:42:35 +0000
Bug 1395509 - Track malloc memory used by JS Map and Set objects r=sfink Use memory tracking APIs to track malloc memory associated with Map and Set objects. Differential Revision: https://phabricator.services.mozilla.com/D34371
46030572ffde627283544d8b8de052d86d598c4f: Bug 1401624: Part 7: Update gdb pretty-printer r=sfink
Iain Ireland <iireland@mozilla.com> - Mon, 03 Jun 2019 15:57:55 +0000 - rev 478470
Push 36143 by aciure@mozilla.com at Wed, 12 Jun 2019 21:41:19 +0000
Bug 1401624: Part 7: Update gdb pretty-printer r=sfink This is a bit gross, but it passes all the tests that were not already failing. Differential Revision: https://phabricator.services.mozilla.com/D29057
90a104231405cc68fef9ffec8e5a808cdd276fc7: Bug 1401624: Part 2: Improve comments in TraceDataRelocations r=sfink
Iain Ireland <iireland@mozilla.com> - Mon, 03 Jun 2019 15:56:58 +0000 - rev 478465
Push 36143 by aciure@mozilla.com at Wed, 12 Jun 2019 21:41:19 +0000
Bug 1401624: Part 2: Improve comments in TraceDataRelocations r=sfink It took me a while to convince myself that this code was still okay for 0-tagged object Values. Adding a comment to make it clearer for future readers (and in the hope that a reviewer will notice my mistake if I am wrong.) Differential Revision: https://phabricator.services.mozilla.com/D29052
1b3207f979714a183fba02476e292fd625b0beae: Bug 1395509 - Add a separate byte count for malloc allocations r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Fri, 07 Jun 2019 17:03:08 +0100 - rev 478283
Push 36139 by rgurzau@mozilla.com at Tue, 11 Jun 2019 21:35:17 +0000
Bug 1395509 - Add a separate byte count for malloc allocations r=sfink Previously I rolled the malloc byte count into a total byte count for each zone but this may adversely affect GC scheduling (e.g. by triggering more non-incremental GCs because allocation volumes appear higher with this change). So that we can land this machinery without disturbing benchmarks too much, this patch splits out the new malloc memory accounting into a separate counter and uses the maxMallocBytes setting as the threshold (default value is 128MB vs 30MB for the GC heap threshold) and a growth factor of 2. This should make the behaviour closer to the original behaviour for now. We can go back and adjust the parameters later to obtain the desired behaviour. Differential Revision: https://phabricator.services.mozilla.com/D34181
06ef8a540487729e22a41088b43b1e51bd0e00ff: Bug 1395509 - Move HeapSize class to gc/Scheduling.h where it belongs r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Fri, 07 Jun 2019 16:58:50 +0100 - rev 478282
Push 36139 by rgurzau@mozilla.com at Tue, 11 Jun 2019 21:35:17 +0000
Bug 1395509 - Move HeapSize class to gc/Scheduling.h where it belongs r=sfink Differential Revision: https://phabricator.services.mozilla.com/D34180
f3e11ae5fb1910db9dd1c19afe6c7a1fb855d902: Bug 1395509 - Fix assertions that all tracked memory is removed when a zone is collected r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 06 Jun 2019 16:00:17 +0100 - rev 478281
Push 36139 by rgurzau@mozilla.com at Tue, 11 Jun 2019 21:35:17 +0000
Bug 1395509 - Fix assertions that all tracked memory is removed when a zone is collected r=sfink The change to split out ZoneAllocator messed up the MemoryTracker code that prints out what failed to be removed by making it run after the Zone destructor which will already assert in the case (but without printing useful information first). Differential Revision: https://phabricator.services.mozilla.com/D33974
1052572788c600cde915b67e74c3c72cb1d48109: Bug 1556762 - Part 3: Use gcReason to distinguish pretenureObj|Str. r=sfink
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Tue, 04 Jun 2019 14:14:38 +0200 - rev 478279
Push 36139 by rgurzau@mozilla.com at Tue, 11 Jun 2019 21:35:17 +0000
Bug 1556762 - Part 3: Use gcReason to distinguish pretenureObj|Str. r=sfink Differential Revision: https://phabricator.services.mozilla.com/D33654