searching for reviewer(rstrong)
653923cc1453339f296cfb2cd73a73ea9593460c: Bug 1599360 - Use AppUpdater.jsm in aboutDialog-appUpdater.js when preffed on, and use the current implementation when preffed off r=rstrong
Drew Willcoxon <adw@mozilla.com> - Tue, 03 Dec 2019 06:01:32 +0000 - rev 505010
Push 36873 by shindli@mozilla.com at Tue, 03 Dec 2019 09:48:30 +0000
Bug 1599360 - Use AppUpdater.jsm in aboutDialog-appUpdater.js when preffed on, and use the current implementation when preffed off r=rstrong Summary of changes: * Copy aboutDialog-appUpdater.js to a new aboutDialog-appUpdater-legacy.js file * Update aboutDialog-appUpdater.js: Rewrite it to use the new AppUpdater.jsm when the `browser.aboutDialogNewAppUpdater` pref is true, and load aboutDialog-appUpdater-legacy.js otherwise * In toolkit/mozapps/update/tests/browser, add new browser.legacy.ini and browser.legacy.bits.ini files that do not set `browser.aboutDialogNewAppUpdater` to true, so that the old implementation is still tested * Update browser.ini and browser.bits.ini files to set `browser.aboutDialogNewAppUpdater` to true so that the new implementation is tested If all this is OK, I'll file another bug for removing the legacy stuff once we merge. Differential Revision: https://phabricator.services.mozilla.com/D54837
8127c15116e17efebceb1a82944c4867e714aa09: Bug 1599360 - Factor out appUpdater from aboutDialog-appUpdater.js into a jsm module r=rstrong
Drew Willcoxon <adw@mozilla.com> - Tue, 03 Dec 2019 06:01:32 +0000 - rev 505009
Push 36873 by shindli@mozilla.com at Tue, 03 Dec 2019 09:48:30 +0000
Bug 1599360 - Factor out appUpdater from aboutDialog-appUpdater.js into a jsm module r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D54677
0213f7cd22c42d87a1222719004db5cd574eae67: Bug 1595470 - Prevent EnsureCorrectPermissions from making faulty assumptions about childBuffer r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Wed, 13 Nov 2019 02:00:18 +0000 - rev 502000
Push 36805 by aiakab@mozilla.com at Fri, 15 Nov 2019 09:53:19 +0000
Bug 1595470 - Prevent EnsureCorrectPermissions from making faulty assumptions about childBuffer r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D52604
c5b0b8cd674f5dc6933e0b2b9c3fb18955af85c0: Bug 1577317 - Add telemetry for "fix update directory permissions". r=rstrong
Adam Gashlin <agashlin@mozilla.com> - Fri, 20 Sep 2019 17:11:11 +0000 - rev 494285
Push 36600 by aiakab@mozilla.com at Sat, 21 Sep 2019 09:52:11 +0000
Bug 1577317 - Add telemetry for "fix update directory permissions". r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D46241
9ace34dfde8de6b2d8ac78c7b342b6256d529153: Bug 1577760: Don't compile in version of mar-channel-id in `mar` tool; r=rstrong
Tom Prince <mozilla@hocat.ca> - Fri, 06 Sep 2019 18:37:14 +0000 - rev 492055
Push 36543 by ncsoregi@mozilla.com at Sat, 07 Sep 2019 09:40:21 +0000
Bug 1577760: Don't compile in version of mar-channel-id in `mar` tool; r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D44157
35e44efd549df9db932881c291aa0e4ac8bf6b67: Bug 1576783, make browser_doorhanger_bc_downloadAutoFailures_bgWin.js more resilient to when popupshown event fires, r=rstrong
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 27 Aug 2019 20:40:33 +0000 - rev 490289
Push 36499 by btara@mozilla.com at Wed, 28 Aug 2019 09:39:56 +0000
Bug 1576783, make browser_doorhanger_bc_downloadAutoFailures_bgWin.js more resilient to when popupshown event fires, r=rstrong popupshown may get fired while waiting for closeWindow or promiseFocus to be executed. Other uses of runDoorhangerUpdateTest seem to be simpler and should be fine without popupShown parameter. Differential Revision: https://phabricator.services.mozilla.com/D43672
971f34603d3b6592d216208c923893fd82a715d2: Bug 1563790 - Part 2: Lower No Progress Timeout when UI is displayed r=bytesized,rstrong
Adam Gashlin <agashlin@mozilla.com> - Thu, 01 Aug 2019 20:00:54 +0000 - rev 485741
Push 36373 by rmaries@mozilla.com at Fri, 02 Aug 2019 03:50:33 +0000
Bug 1563790 - Part 2: Lower No Progress Timeout when UI is displayed r=bytesized,rstrong Differential Revision: https://phabricator.services.mozilla.com/D39270
ad6ae5e8a4f04617b48bf4419bb6b4583c2feb23: Bug 1563790 - Part 1: Expose and require No Progress Timeout r=bytesized,rstrong
Adam Gashlin <agashlin@mozilla.com> - Thu, 01 Aug 2019 20:01:09 +0000 - rev 485740
Push 36373 by rmaries@mozilla.com at Fri, 02 Aug 2019 03:50:33 +0000
Bug 1563790 - Part 1: Expose and require No Progress Timeout r=bytesized,rstrong Differential Revision: https://phabricator.services.mozilla.com/D39095
d02282987e93cfa67b7bfc6bb575c734b332af4c: Bug 1551913 - Fix issues setting update directory permissions r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Wed, 24 Jul 2019 16:05:46 +0000 - rev 484712
Push 36345 by malexandru@mozilla.com at Thu, 25 Jul 2019 21:49:06 +0000
Bug 1551913 - Fix issues setting update directory permissions r=rstrong This patch addresses both Bug 1551913 and Bug 1552206. This patches the update directory permission-fixing code. This also fixes a related bug that I discovered while testing this patch: nsAutoSid doesn't actually work because both PSID and HANDLE are both typedef'ed from void*, so the compiler can't actually tell the difference between them and ends up calling CloseHandle instead of FreeSid. To fix this, I removed nsAutoSid and replaced it with UniqueSidPtr, a UniquePtr type that uses a custom deleter class to free the SID properly. Differential Revision: https://phabricator.services.mozilla.com/D34941
0c7bf4bc10a7e292e1d94e026ee6f60ed6daa00e: Bug 1567630 - Rename shouldUseService to useServiceOnFailure r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Mon, 22 Jul 2019 17:47:44 +0000 - rev 483736
Push 36333 by nerli@mozilla.com at Tue, 23 Jul 2019 15:57:48 +0000
Bug 1567630 - Rename shouldUseService to useServiceOnFailure r=rstrong This better describes the parameter's effect. Differential Revision: https://phabricator.services.mozilla.com/D38764
040c1590b378bee8c06b7cd27e1066ec851fa14b: Bug 1562952 - #ifdef-out NSS and certificate-related flags with NO_SIGN_VERIFY. r=rstrong
Mike Hommey <mh+mozilla@glandium.org> - Thu, 11 Jul 2019 21:08:47 +0000 - rev 483031
Push 36303 by dvarga@mozilla.com at Wed, 17 Jul 2019 09:36:40 +0000
Bug 1562952 - #ifdef-out NSS and certificate-related flags with NO_SIGN_VERIFY. r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D36991
250696e18e7dc5dddb48a0f00d2221f9d5cdf2b9: Bug 1562952 - #ifdef-out NSS and certificate-related flags with NO_SIGN_VERIFY. r=rstrong
Mike Hommey <mh+mozilla@glandium.org> - Wed, 10 Jul 2019 15:17:53 +0000 - rev 482322
Push 36276 by cbrindusan@mozilla.com at Thu, 11 Jul 2019 16:20:48 +0000
Bug 1562952 - #ifdef-out NSS and certificate-related flags with NO_SIGN_VERIFY. r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D36991
fc4a6e8f6e3446ff8c613eb4d46dcd66e393bfd0: Bug 1562952 - #ifdef-out NSS and certificate-related flags with NO_SIGN_VERIFY. r=rstrong
Mike Hommey <mh+mozilla@glandium.org> - Wed, 10 Jul 2019 06:52:57 +0000 - rev 482058
Push 36268 by aciure@mozilla.com at Wed, 10 Jul 2019 15:45:05 +0000
Bug 1562952 - #ifdef-out NSS and certificate-related flags with NO_SIGN_VERIFY. r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D36991
98a5a4864b88bceb374f48c841fc8c67fb3b1eed: Bug 1561636 - intermittent updater failures on Win64 (Error 19) r=rstrong
Kathy Brade <brade@pearlcrescent.com> - Thu, 27 Jun 2019 09:11:48 +0000 - rev 480360
Push 36211 by rmaries@mozilla.com at Thu, 27 Jun 2019 21:47:35 +0000
Bug 1561636 - intermittent updater failures on Win64 (Error 19) r=rstrong Avoid MinGW's _ftelli64() and _fseeki64() implementations because they are unreliable. Differential Revision: https://phabricator.services.mozilla.com/D36037
c35dfc59349855f1acfe97c5fc299ea10551b45b: Bug 1556733 - [10.15] Multiple "Firefox Nightly Software Update" Mac OS X quarantine dialogs when performing a software update r=rstrong,spohl
Haik Aftandilian <haftandilian@mozilla.com> - Thu, 27 Jun 2019 02:51:45 +0000 - rev 480293
Push 36208 by ccoroiu@mozilla.com at Thu, 27 Jun 2019 09:34:48 +0000
Bug 1556733 - [10.15] Multiple "Firefox Nightly Software Update" Mac OS X quarantine dialogs when performing a software update r=rstrong,spohl On Mac, remove the "com.apple.quarantine" extended attribute from the updater after it is copied to the staging area. Required on macOS 10.15 which has new restrictions on launching quarantined applications. Differential Revision: https://phabricator.services.mozilla.com/D35972
e74c6c4c5d62068686b0d87ac724f07931b1be3a: Bug 1558095 - Remove useless waitpid from updater. r=rstrong
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Tue, 11 Jun 2019 17:34:05 +0000 - rev 478339
Push 36140 by dluca@mozilla.com at Wed, 12 Jun 2019 12:02:49 +0000
Bug 1558095 - Remove useless waitpid from updater. r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D34503
a3031bdbf14ad7515fd6abca317b10e71ecfcbff: Bug 1557963. Stop using [array] in nsIUpdateService. r=rstrong
Boris Zbarsky <bzbarsky@mit.edu> - Sat, 08 Jun 2019 19:04:47 +0000 - rev 477980
Push 36129 by ncsoregi@mozilla.com at Sun, 09 Jun 2019 09:06:18 +0000
Bug 1557963. Stop using [array] in nsIUpdateService. r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D34278
ca8e3e6b3a825ff13012bc6029d767b54cdf573a: Bug 1532190 - Don't call CloseHandle on invalid handle during update service. r=rstrong
Ted Campbell <tcampbell@mozilla.com> - Thu, 02 May 2019 20:39:36 +0000 - rev 476320
Push 36092 by archaeopteryx@coole-files.de at Fri, 31 May 2019 17:03:46 +0000
Bug 1532190 - Don't call CloseHandle on invalid handle during update service. r=rstrong During forced shutdown, we may call 'closeHandle' without having a proper mutex. This results in a crash in ntdll, so instead just do nothing if the handle is missing. Differential Revision: https://phabricator.services.mozilla.com/D29716
29ab504dc7481c60532d7d5bf3f1f7d36c15235f: Bug 1552676 - Cleanup cookie policy tests. r=rstrong
Michael Kaply <mozilla@kaply.com> - Tue, 21 May 2019 19:15:36 +0000 - rev 474830
Push 36047 by nerli@mozilla.com at Wed, 22 May 2019 03:40:58 +0000
Bug 1552676 - Cleanup cookie policy tests. r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D32037
243251620b8e60ec461d348ee79a2df307655ba7: Bug 1551867 - Move appinfo init to head to avoid timing when initing enterprise policies. r=rstrong
Michael Kaply <mozilla@kaply.com> - Thu, 16 May 2019 23:47:13 +0000 - rev 474275
Push 36027 by shindli@mozilla.com at Fri, 17 May 2019 16:24:38 +0000
Bug 1551867 - Move appinfo init to head to avoid timing when initing enterprise policies. r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D31499
afaf68ba6e54f8309317b3d346396178fde23fb7: Bug 1546957 - Prevent BITS Requests from being cancelled twice r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Wed, 15 May 2019 21:55:36 +0000 - rev 474001
Push 36020 by dvarga@mozilla.com at Thu, 16 May 2019 04:15:07 +0000
Bug 1546957 - Prevent BITS Requests from being cancelled twice r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D31338
8096d130b1346ba0c6bc10450de6f86196f3f768: Bug 1546627 - Prevent Firefox from prematurely showing "Restart to Update" on startup r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Fri, 10 May 2019 19:06:34 +0000 - rev 473452
Push 35998 by rmaries@mozilla.com at Sat, 11 May 2019 09:44:50 +0000
Bug 1546627 - Prevent Firefox from prematurely showing "Restart to Update" on startup r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D30520
e978f9960f5759e80511573a05fd649cab27f0dc: Bug 1546627 - Prevent Firefox from prematurely showing "Restart to Update" on startup r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Fri, 10 May 2019 16:56:45 +0000 - rev 473426
Push 35996 by dvarga@mozilla.com at Fri, 10 May 2019 21:46:48 +0000
Bug 1546627 - Prevent Firefox from prematurely showing "Restart to Update" on startup r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D30520
adb1c1a79a40102f634a419b6c5d1245de474d67: Bug 1546287 - Fix leak in BITS update tests r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Fri, 03 May 2019 17:37:55 +0000 - rev 472530
Push 35958 by malexandru@mozilla.com at Fri, 03 May 2019 21:56:39 +0000
Bug 1546287 - Fix leak in BITS update tests r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D29751
b93a543241aee81d6c5212f09f1f7db6a25a6a85: Bug 1547099 - Ensure that BITS update is not used for mochitest-chrome update tests that do not use it r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Fri, 26 Apr 2019 15:38:38 +0000 - rev 471532
Push 35920 by aiakab@mozilla.com at Fri, 26 Apr 2019 22:02:33 +0000
Bug 1547099 - Ensure that BITS update is not used for mochitest-chrome update tests that do not use it r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D28999
30ed3b129f01e715bb12f91a7c11d6794d89601c: Bug 1542100 - Only enable BITS update for 50% of eligible population r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Tue, 23 Apr 2019 17:18:07 +0000 - rev 470568
Push 35908 by aciure@mozilla.com at Wed, 24 Apr 2019 04:28:40 +0000
Bug 1542100 - Only enable BITS update for 50% of eligible population r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D28368
27c8b8f5b3c81e5f216a4ac948c7d082e19fc287: Bug 1545793 - Don't put a BITS update in a failure state if the user doesn't have permission to access BITS r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Mon, 22 Apr 2019 17:06:59 +0000 - rev 470370
Push 35903 by opoprus@mozilla.com at Mon, 22 Apr 2019 21:46:44 +0000
Bug 1545793 - Don't put a BITS update in a failure state if the user doesn't have permission to access BITS r=rstrong This patch should prevent a guest user from putting a non-guest user's (existing) BITS download in a failure state. If, however, the guest user is the first user to try BITS, it will fail and will still put BITS in an error state, falling back to nsIIncrementalDownload. Differential Revision: https://phabricator.services.mozilla.com/D28258
be77d454cbe7e8cf3d619b56d87d399699bd7edd: Bug 1544562 - Call onUnload when about:preferences is closed r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Thu, 18 Apr 2019 20:52:02 +0000 - rev 470140
Push 35888 by aiakab@mozilla.com at Fri, 19 Apr 2019 09:47:45 +0000
Bug 1544562 - Call onUnload when about:preferences is closed r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D27591
7c149c2cd4a90a9063c02082c51362043f29d47c: Bug 1544894 - Fix bug where BITS notifications never return from active to idle mode r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Tue, 16 Apr 2019 18:21:45 +0000 - rev 469765
Push 35882 by cbrindusan@mozilla.com at Wed, 17 Apr 2019 15:54:01 +0000
Bug 1544894 - Fix bug where BITS notifications never return from active to idle mode r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D27781
252732b54408cbf9de761baf469a03e55066a280: Bug 1544562 - Call onUnload when about:preferences is closed r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Mon, 15 Apr 2019 21:23:04 +0000 - rev 469576
Push 35874 by ccoroiu@mozilla.com at Tue, 16 Apr 2019 04:04:58 +0000
Bug 1544562 - Call onUnload when about:preferences is closed r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D27591
fb9ff7baed4347cf0df3f252344a9f69e6942b44: Bug 1520321 - Adds Telemetry for BITS update downloads r=chutten,rstrong
Kirk Steuber <ksteuber@mozilla.com> - Mon, 15 Apr 2019 19:44:59 +0000 - rev 469556
Push 35874 by ccoroiu@mozilla.com at Tue, 16 Apr 2019 04:04:58 +0000
Bug 1520321 - Adds Telemetry for BITS update downloads r=chutten,rstrong These Histograms were added: UPDATE_CAN_USE_BITS_EXTERNAL UPDATE_CAN_USE_BITS_NOTIFY Used for telemetry indicating whether or not BITS can be used by this system. If BITS cannot be used, the probe will contain data indicating why not. UPDATE_BITS_RESULT_COMPLETE UPDATE_BITS_RESULT_PARTIAL Used for telemetry indicating whether the BITS update download succeeded. If it failed, the probe will contain data indicating how it failed. This scalar was added: update.bitshresult Used to indicate the hresult returned, if any, when a BITS download fails. Differential Revision: https://phabricator.services.mozilla.com/D25163
84cc6e41ba1757fab96a5aed49d494d771bded5b: Bug 1520321 - Use BITS in nsUpdateService r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Mon, 15 Apr 2019 19:44:45 +0000 - rev 469555
Push 35874 by ccoroiu@mozilla.com at Tue, 16 Apr 2019 04:04:58 +0000
Bug 1520321 - Use BITS in nsUpdateService r=rstrong nsUpdateService should use BITS for download. If the BITS download fails, it will fallback to the existing download mechanism (nsIIncrementalDownload). Differential Revision: https://phabricator.services.mozilla.com/D25162
1ec7f80cf258370b47afbe6de253bad316ad80c2: Bug 1539176 - modules/ manual ESLint no-throw-literal fixes. r=rstrong
Ian Moody <moz-ian@perix.co.uk> - Tue, 02 Apr 2019 13:41:10 +0000 - rev 467717
Push 35810 by aciure@mozilla.com at Thu, 04 Apr 2019 04:33:36 +0000
Bug 1539176 - modules/ manual ESLint no-throw-literal fixes. r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D25651
35a77a4804208a7eb187e674c68e85c90ecbd3c8: Bug 1534508: Move ProcessUpdates to after we have attempted to remote arguments to an existing instance. r=rstrong
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 13 Mar 2019 23:26:16 +0000 - rev 463913
Push 35700 by ncsoregi@mozilla.com at Thu, 14 Mar 2019 05:04:11 +0000
Bug 1534508: Move ProcessUpdates to after we have attempted to remote arguments to an existing instance. r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D23158
d75868102ceaeb949d2bbd50c3067acd97dae217: Bug 1526475 - Add file logging to the updater r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Mon, 04 Mar 2019 01:36:49 +0000 - rev 462191
Push 35642 by dvarga@mozilla.com at Mon, 04 Mar 2019 09:36:20 +0000
Bug 1526475 - Add file logging to the updater r=rstrong File logging can be turned on by setting `app.update.log.file=true`. It will log update messages that would normally go to the browser console (assuming `app.update.log==true`) to a file in the user profile directory called "update_messages.log". File logging will last for a single Firefox session only before it automatically disables itself. The goal of this is to make it easier to get troubleshooting/debugging information from users that might complain of update problems. This will be especially important when upcoming changes are made to the update mechanism. Differential Revision: https://phabricator.services.mozilla.com/D19422
e9677c67b09409735efdc4a63da14c1753d61d13: Bug 1523613: Fix memory leaks during updates. r=rstrong
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Mon, 25 Feb 2019 10:16:15 -0500 - rev 460883
Push 35612 by nerli@mozilla.com at Mon, 25 Feb 2019 21:58:23 +0000
Bug 1523613: Fix memory leaks during updates. r=rstrong
56840efb59f17cb0d70e68fbd9196acfa1b2621c: Bug 1524290: Fix a potential memory leak in updater.cpp. r=rstrong
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Thu, 31 Jan 2019 17:39:15 -0500 - rev 456343
Push 35479 by shindli@mozilla.com at Fri, 01 Feb 2019 03:57:26 +0000
Bug 1524290: Fix a potential memory leak in updater.cpp. r=rstrong
63b7e43db7ccc849c3977d487ffd02e55118310e: Bug 1521902: Remove unused argument from nsIShellService.isDefaultBrowser. r=rstrong,chutten
Dave Townsend <dtownsend@oxymoronical.com> - Thu, 24 Jan 2019 20:08:14 +0000 - rev 455327
Push 35432 by nbeleuzu@mozilla.com at Fri, 25 Jan 2019 04:27:48 +0000
Bug 1521902: Remove unused argument from nsIShellService.isDefaultBrowser. r=rstrong,chutten Differential Revision: https://phabricator.services.mozilla.com/D17281
217865622f7a145aab2909995002191d729c442a: Bug 1521902: Remove unused argument from nsIShellService.isDefaultBrowser. r=rstrong
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 22 Jan 2019 20:41:41 +0000 - rev 454884
Push 35419 by dluca@mozilla.com at Wed, 23 Jan 2019 16:31:25 +0000
Bug 1521902: Remove unused argument from nsIShellService.isDefaultBrowser. r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D17281
76786e51becf1fa3a23f0978791a80107acf2318: Bug 493503: Ensure that icons are refreshed in the macOS Dock and Finder after updates. r=mstange,rstrong
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Fri, 18 Jan 2019 05:48:45 -0500 - rev 454527
Push 35400 by csabou@mozilla.com at Sat, 19 Jan 2019 09:59:33 +0000
Bug 493503: Ensure that icons are refreshed in the macOS Dock and Finder after updates. r=mstange,rstrong
cad6506b2f5d1c179603ef7a125219ef94c7e04a: Bug 1518846: Fix missing includes in nsUpdateDriver.cpp. r=rstrong
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 09 Jan 2019 17:27:21 +0000 - rev 453159
Push 35346 by shindli@mozilla.com at Thu, 10 Jan 2019 04:03:25 +0000
Bug 1518846: Fix missing includes in nsUpdateDriver.cpp. r=rstrong Adds some includes that are needed for functions used in nsUpdateDriver.cpp. Differential Revision: https://phabricator.services.mozilla.com/D16063
f184da8d467cc98ff07dfbf880557eac00566c57: Bug 1514898 - Disable user impersonation on release r=rstrong
Adam Gashlin <agashlin@mozilla.com> - Wed, 09 Jan 2019 19:57:31 +0000 - rev 453141
Push 35346 by shindli@mozilla.com at Thu, 10 Jan 2019 04:03:25 +0000
Bug 1514898 - Disable user impersonation on release r=rstrong This introduces a DISABLE_USER_IMPERSONATION define when EARLY_BETA_OR_EARLIER is set, if that is present the maintenance service will not attempt to get an impersonation token for the user's updater process, and the updater will not attempt to use any token it is given. The bulk of the changes are restoring the old failure status codes and the tests that expect them, sorry for the noise that causes. Differential Revision: https://phabricator.services.mozilla.com/D15781
74bbbdf694678553a0c2afb2f810a2299616e07c: Bug 1515611 part 2 - QI nsIWritablePropertyBag instead of nsIPropertyBag on nsIUpdate. r=rstrong
Jan de Mooij <jdemooij@mozilla.com> - Thu, 20 Dec 2018 17:47:32 +0000 - rev 451824
Push 35259 by aiakab@mozilla.com at Sat, 22 Dec 2018 21:53:48 +0000
Bug 1515611 part 2 - QI nsIWritablePropertyBag instead of nsIPropertyBag on nsIUpdate. r=rstrong If we QI nsIPropertyBag on an XPCWrappedNative wrapping an XPCWrappedJS, calling the getProperty method might incorrectly end up calling .getProperty on the XPCWrappedJS itself, because it also implements nsIPropertyBag. This became a problem with same-compartment chrome globals because if we no longer cross a compartment boundary, we don't create a new WrappedNative and can now end up seeing the nsIPropertyBag if it got queried before nsIWritablePropertyBag. Depends on D15076 Differential Revision: https://phabricator.services.mozilla.com/D15077
dab6389dca555797ab04b33fc6d79b8547d1ec87: Bug 1515611 part 1 - Remove backgroundInterval from nsIUpdate. r=rstrong
Jan de Mooij <jdemooij@mozilla.com> - Sat, 22 Dec 2018 01:10:27 +0000 - rev 451823
Push 35259 by aiakab@mozilla.com at Sat, 22 Dec 2018 21:53:48 +0000
Bug 1515611 part 1 - Remove backgroundInterval from nsIUpdate. r=rstrong It was added in case there were CDN issues with downloading unthrottled and since there haven't been any issues it is no longer needed. This was suggested by rstrong and simplifies the next patch. Differential Revision: https://phabricator.services.mozilla.com/D15076
5dd777c5770d0a80575d6a6842725d3a1f048fc3: Bug 1514078 - Correctly report Windows running on AArch64 in the update URL. r=rstrong
Matt Howell <mhowell@mozilla.com> - Fri, 14 Dec 2018 02:23:01 +0000 - rev 450485
Push 35202 by btara@mozilla.com at Fri, 14 Dec 2018 05:43:22 +0000
Bug 1514078 - Correctly report Windows running on AArch64 in the update URL. r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D14502
6798cc7aaed0765f259470eb5f7cac16d4310545: Bug 1468552 - Update bspatch.cpp to match Chromium version; r=rstrong
June Wilde <jewilde@mozilla.com> - Tue, 27 Nov 2018 18:30:30 +0000 - rev 448368
Push 35111 by csabou@mozilla.com at Wed, 28 Nov 2018 04:06:56 +0000
Bug 1468552 - Update bspatch.cpp to match Chromium version; r=rstrong Adds bounds checking around file reads and header values Differential Revision: https://phabricator.services.mozilla.com/D12356
2b4f08a645a0385021b64b4f995c18cb2250a5c6: Bug 1468552 - Update bspatch.cpp to match Chromium version; r=rstrong
June Wilde <jewilde@mozilla.com> - Mon, 26 Nov 2018 22:01:08 +0000 - rev 448325
Push 35109 by csabou@mozilla.com at Tue, 27 Nov 2018 21:53:40 +0000
Bug 1468552 - Update bspatch.cpp to match Chromium version; r=rstrong Adds bounds checking around file reads and header values Differential Revision: https://phabricator.services.mozilla.com/D12356
d1d8e236cf158b5fc75a97d6f3a0ed76cc341ebc: Bug 1486637: Impersonate user when creating files in user-controlled directories r=rstrong,mhowell
Adam Gashlin <agashlin@mozilla.com> - Mon, 19 Nov 2018 18:45:52 +0000 - rev 447064
Push 35066 by rmaries@mozilla.com at Tue, 20 Nov 2018 04:59:51 +0000
Bug 1486637: Impersonate user when creating files in user-controlled directories r=rstrong,mhowell Get an impersonation token for the user who started the maintenance service, use that when creating or moving files in user-controlled directories (currently only update.status). This token is passed along to the updater where it is used the same way (update.status, update log, and elevated lock file). The workings of getting the token are in usertoken.cpp Differential Revision: https://phabricator.services.mozilla.com/D7840
97613730a99f6156f256d351b5b7767b1d80a2b6: Bug 1468542 - Restrict acceptable bounds for i in nss_secutil; r=rstrong
June Wilde <jewilde@mozilla.com> - Mon, 19 Nov 2018 20:57:50 +0200 - rev 447032
Push 35065 by rmaries@mozilla.com at Mon, 19 Nov 2018 21:56:32 +0000
Bug 1468542 - Restrict acceptable bounds for i in nss_secutil; r=rstrong Summary: Adds some missing braces on if structures Adds a check for i being larger or equal to nb Reviewers: rstrong Reviewed By: rstrong Bug #: 1468542 Differential Revision: https://phabricator.services.mozilla.com/D12193
4a30dea025cacebb50cd376e1429ae8041c75790: Bug 1503362 - Clear the app.update.enabled pref from profiles now that it is no longer in use r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Thu, 08 Nov 2018 16:41:07 +0000 - rev 445168
Push 35012 by btara@mozilla.com at Fri, 09 Nov 2018 05:26:19 +0000
Bug 1503362 - Clear the app.update.enabled pref from profiles now that it is no longer in use r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D11128