searching for reviewer(rstrong)
29ab504dc7481c60532d7d5bf3f1f7d36c15235f: Bug 1552676 - Cleanup cookie policy tests. r=rstrong
Michael Kaply <mozilla@kaply.com> - Tue, 21 May 2019 19:15:36 +0000 - rev 474830
Push 36047 by nerli@mozilla.com at Wed, 22 May 2019 03:40:58 +0000
Bug 1552676 - Cleanup cookie policy tests. r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D32037
243251620b8e60ec461d348ee79a2df307655ba7: Bug 1551867 - Move appinfo init to head to avoid timing when initing enterprise policies. r=rstrong
Michael Kaply <mozilla@kaply.com> - Thu, 16 May 2019 23:47:13 +0000 - rev 474275
Push 36027 by shindli@mozilla.com at Fri, 17 May 2019 16:24:38 +0000
Bug 1551867 - Move appinfo init to head to avoid timing when initing enterprise policies. r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D31499
afaf68ba6e54f8309317b3d346396178fde23fb7: Bug 1546957 - Prevent BITS Requests from being cancelled twice r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Wed, 15 May 2019 21:55:36 +0000 - rev 474001
Push 36020 by dvarga@mozilla.com at Thu, 16 May 2019 04:15:07 +0000
Bug 1546957 - Prevent BITS Requests from being cancelled twice r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D31338
8096d130b1346ba0c6bc10450de6f86196f3f768: Bug 1546627 - Prevent Firefox from prematurely showing "Restart to Update" on startup r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Fri, 10 May 2019 19:06:34 +0000 - rev 473452
Push 35998 by rmaries@mozilla.com at Sat, 11 May 2019 09:44:50 +0000
Bug 1546627 - Prevent Firefox from prematurely showing "Restart to Update" on startup r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D30520
e978f9960f5759e80511573a05fd649cab27f0dc: Bug 1546627 - Prevent Firefox from prematurely showing "Restart to Update" on startup r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Fri, 10 May 2019 16:56:45 +0000 - rev 473426
Push 35996 by dvarga@mozilla.com at Fri, 10 May 2019 21:46:48 +0000
Bug 1546627 - Prevent Firefox from prematurely showing "Restart to Update" on startup r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D30520
adb1c1a79a40102f634a419b6c5d1245de474d67: Bug 1546287 - Fix leak in BITS update tests r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Fri, 03 May 2019 17:37:55 +0000 - rev 472530
Push 35958 by malexandru@mozilla.com at Fri, 03 May 2019 21:56:39 +0000
Bug 1546287 - Fix leak in BITS update tests r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D29751
b93a543241aee81d6c5212f09f1f7db6a25a6a85: Bug 1547099 - Ensure that BITS update is not used for mochitest-chrome update tests that do not use it r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Fri, 26 Apr 2019 15:38:38 +0000 - rev 471532
Push 35920 by aiakab@mozilla.com at Fri, 26 Apr 2019 22:02:33 +0000
Bug 1547099 - Ensure that BITS update is not used for mochitest-chrome update tests that do not use it r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D28999
30ed3b129f01e715bb12f91a7c11d6794d89601c: Bug 1542100 - Only enable BITS update for 50% of eligible population r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Tue, 23 Apr 2019 17:18:07 +0000 - rev 470568
Push 35908 by aciure@mozilla.com at Wed, 24 Apr 2019 04:28:40 +0000
Bug 1542100 - Only enable BITS update for 50% of eligible population r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D28368
27c8b8f5b3c81e5f216a4ac948c7d082e19fc287: Bug 1545793 - Don't put a BITS update in a failure state if the user doesn't have permission to access BITS r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Mon, 22 Apr 2019 17:06:59 +0000 - rev 470370
Push 35903 by opoprus@mozilla.com at Mon, 22 Apr 2019 21:46:44 +0000
Bug 1545793 - Don't put a BITS update in a failure state if the user doesn't have permission to access BITS r=rstrong This patch should prevent a guest user from putting a non-guest user's (existing) BITS download in a failure state. If, however, the guest user is the first user to try BITS, it will fail and will still put BITS in an error state, falling back to nsIIncrementalDownload. Differential Revision: https://phabricator.services.mozilla.com/D28258
be77d454cbe7e8cf3d619b56d87d399699bd7edd: Bug 1544562 - Call onUnload when about:preferences is closed r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Thu, 18 Apr 2019 20:52:02 +0000 - rev 470140
Push 35888 by aiakab@mozilla.com at Fri, 19 Apr 2019 09:47:45 +0000
Bug 1544562 - Call onUnload when about:preferences is closed r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D27591
7c149c2cd4a90a9063c02082c51362043f29d47c: Bug 1544894 - Fix bug where BITS notifications never return from active to idle mode r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Tue, 16 Apr 2019 18:21:45 +0000 - rev 469765
Push 35882 by cbrindusan@mozilla.com at Wed, 17 Apr 2019 15:54:01 +0000
Bug 1544894 - Fix bug where BITS notifications never return from active to idle mode r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D27781
252732b54408cbf9de761baf469a03e55066a280: Bug 1544562 - Call onUnload when about:preferences is closed r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Mon, 15 Apr 2019 21:23:04 +0000 - rev 469576
Push 35874 by ccoroiu@mozilla.com at Tue, 16 Apr 2019 04:04:58 +0000
Bug 1544562 - Call onUnload when about:preferences is closed r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D27591
fb9ff7baed4347cf0df3f252344a9f69e6942b44: Bug 1520321 - Adds Telemetry for BITS update downloads r=chutten,rstrong
Kirk Steuber <ksteuber@mozilla.com> - Mon, 15 Apr 2019 19:44:59 +0000 - rev 469556
Push 35874 by ccoroiu@mozilla.com at Tue, 16 Apr 2019 04:04:58 +0000
Bug 1520321 - Adds Telemetry for BITS update downloads r=chutten,rstrong These Histograms were added: UPDATE_CAN_USE_BITS_EXTERNAL UPDATE_CAN_USE_BITS_NOTIFY Used for telemetry indicating whether or not BITS can be used by this system. If BITS cannot be used, the probe will contain data indicating why not. UPDATE_BITS_RESULT_COMPLETE UPDATE_BITS_RESULT_PARTIAL Used for telemetry indicating whether the BITS update download succeeded. If it failed, the probe will contain data indicating how it failed. This scalar was added: update.bitshresult Used to indicate the hresult returned, if any, when a BITS download fails. Differential Revision: https://phabricator.services.mozilla.com/D25163
84cc6e41ba1757fab96a5aed49d494d771bded5b: Bug 1520321 - Use BITS in nsUpdateService r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Mon, 15 Apr 2019 19:44:45 +0000 - rev 469555
Push 35874 by ccoroiu@mozilla.com at Tue, 16 Apr 2019 04:04:58 +0000
Bug 1520321 - Use BITS in nsUpdateService r=rstrong nsUpdateService should use BITS for download. If the BITS download fails, it will fallback to the existing download mechanism (nsIIncrementalDownload). Differential Revision: https://phabricator.services.mozilla.com/D25162
1ec7f80cf258370b47afbe6de253bad316ad80c2: Bug 1539176 - modules/ manual ESLint no-throw-literal fixes. r=rstrong
Ian Moody <moz-ian@perix.co.uk> - Tue, 02 Apr 2019 13:41:10 +0000 - rev 467717
Push 35810 by aciure@mozilla.com at Thu, 04 Apr 2019 04:33:36 +0000
Bug 1539176 - modules/ manual ESLint no-throw-literal fixes. r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D25651
35a77a4804208a7eb187e674c68e85c90ecbd3c8: Bug 1534508: Move ProcessUpdates to after we have attempted to remote arguments to an existing instance. r=rstrong
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 13 Mar 2019 23:26:16 +0000 - rev 463913
Push 35700 by ncsoregi@mozilla.com at Thu, 14 Mar 2019 05:04:11 +0000
Bug 1534508: Move ProcessUpdates to after we have attempted to remote arguments to an existing instance. r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D23158
d75868102ceaeb949d2bbd50c3067acd97dae217: Bug 1526475 - Add file logging to the updater r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Mon, 04 Mar 2019 01:36:49 +0000 - rev 462191
Push 35642 by dvarga@mozilla.com at Mon, 04 Mar 2019 09:36:20 +0000
Bug 1526475 - Add file logging to the updater r=rstrong File logging can be turned on by setting `app.update.log.file=true`. It will log update messages that would normally go to the browser console (assuming `app.update.log==true`) to a file in the user profile directory called "update_messages.log". File logging will last for a single Firefox session only before it automatically disables itself. The goal of this is to make it easier to get troubleshooting/debugging information from users that might complain of update problems. This will be especially important when upcoming changes are made to the update mechanism. Differential Revision: https://phabricator.services.mozilla.com/D19422
e9677c67b09409735efdc4a63da14c1753d61d13: Bug 1523613: Fix memory leaks during updates. r=rstrong
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Mon, 25 Feb 2019 10:16:15 -0500 - rev 460883
Push 35612 by nerli@mozilla.com at Mon, 25 Feb 2019 21:58:23 +0000
Bug 1523613: Fix memory leaks during updates. r=rstrong
56840efb59f17cb0d70e68fbd9196acfa1b2621c: Bug 1524290: Fix a potential memory leak in updater.cpp. r=rstrong
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Thu, 31 Jan 2019 17:39:15 -0500 - rev 456343
Push 35479 by shindli@mozilla.com at Fri, 01 Feb 2019 03:57:26 +0000
Bug 1524290: Fix a potential memory leak in updater.cpp. r=rstrong
63b7e43db7ccc849c3977d487ffd02e55118310e: Bug 1521902: Remove unused argument from nsIShellService.isDefaultBrowser. r=rstrong,chutten
Dave Townsend <dtownsend@oxymoronical.com> - Thu, 24 Jan 2019 20:08:14 +0000 - rev 455327
Push 35432 by nbeleuzu@mozilla.com at Fri, 25 Jan 2019 04:27:48 +0000
Bug 1521902: Remove unused argument from nsIShellService.isDefaultBrowser. r=rstrong,chutten Differential Revision: https://phabricator.services.mozilla.com/D17281
217865622f7a145aab2909995002191d729c442a: Bug 1521902: Remove unused argument from nsIShellService.isDefaultBrowser. r=rstrong
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 22 Jan 2019 20:41:41 +0000 - rev 454884
Push 35419 by dluca@mozilla.com at Wed, 23 Jan 2019 16:31:25 +0000
Bug 1521902: Remove unused argument from nsIShellService.isDefaultBrowser. r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D17281
76786e51becf1fa3a23f0978791a80107acf2318: Bug 493503: Ensure that icons are refreshed in the macOS Dock and Finder after updates. r=mstange,rstrong
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Fri, 18 Jan 2019 05:48:45 -0500 - rev 454527
Push 35400 by csabou@mozilla.com at Sat, 19 Jan 2019 09:59:33 +0000
Bug 493503: Ensure that icons are refreshed in the macOS Dock and Finder after updates. r=mstange,rstrong
cad6506b2f5d1c179603ef7a125219ef94c7e04a: Bug 1518846: Fix missing includes in nsUpdateDriver.cpp. r=rstrong
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 09 Jan 2019 17:27:21 +0000 - rev 453159
Push 35346 by shindli@mozilla.com at Thu, 10 Jan 2019 04:03:25 +0000
Bug 1518846: Fix missing includes in nsUpdateDriver.cpp. r=rstrong Adds some includes that are needed for functions used in nsUpdateDriver.cpp. Differential Revision: https://phabricator.services.mozilla.com/D16063
f184da8d467cc98ff07dfbf880557eac00566c57: Bug 1514898 - Disable user impersonation on release r=rstrong
Adam Gashlin <agashlin@mozilla.com> - Wed, 09 Jan 2019 19:57:31 +0000 - rev 453141
Push 35346 by shindli@mozilla.com at Thu, 10 Jan 2019 04:03:25 +0000
Bug 1514898 - Disable user impersonation on release r=rstrong This introduces a DISABLE_USER_IMPERSONATION define when EARLY_BETA_OR_EARLIER is set, if that is present the maintenance service will not attempt to get an impersonation token for the user's updater process, and the updater will not attempt to use any token it is given. The bulk of the changes are restoring the old failure status codes and the tests that expect them, sorry for the noise that causes. Differential Revision: https://phabricator.services.mozilla.com/D15781
74bbbdf694678553a0c2afb2f810a2299616e07c: Bug 1515611 part 2 - QI nsIWritablePropertyBag instead of nsIPropertyBag on nsIUpdate. r=rstrong
Jan de Mooij <jdemooij@mozilla.com> - Thu, 20 Dec 2018 17:47:32 +0000 - rev 451824
Push 35259 by aiakab@mozilla.com at Sat, 22 Dec 2018 21:53:48 +0000
Bug 1515611 part 2 - QI nsIWritablePropertyBag instead of nsIPropertyBag on nsIUpdate. r=rstrong If we QI nsIPropertyBag on an XPCWrappedNative wrapping an XPCWrappedJS, calling the getProperty method might incorrectly end up calling .getProperty on the XPCWrappedJS itself, because it also implements nsIPropertyBag. This became a problem with same-compartment chrome globals because if we no longer cross a compartment boundary, we don't create a new WrappedNative and can now end up seeing the nsIPropertyBag if it got queried before nsIWritablePropertyBag. Depends on D15076 Differential Revision: https://phabricator.services.mozilla.com/D15077
dab6389dca555797ab04b33fc6d79b8547d1ec87: Bug 1515611 part 1 - Remove backgroundInterval from nsIUpdate. r=rstrong
Jan de Mooij <jdemooij@mozilla.com> - Sat, 22 Dec 2018 01:10:27 +0000 - rev 451823
Push 35259 by aiakab@mozilla.com at Sat, 22 Dec 2018 21:53:48 +0000
Bug 1515611 part 1 - Remove backgroundInterval from nsIUpdate. r=rstrong It was added in case there were CDN issues with downloading unthrottled and since there haven't been any issues it is no longer needed. This was suggested by rstrong and simplifies the next patch. Differential Revision: https://phabricator.services.mozilla.com/D15076
5dd777c5770d0a80575d6a6842725d3a1f048fc3: Bug 1514078 - Correctly report Windows running on AArch64 in the update URL. r=rstrong
Matt Howell <mhowell@mozilla.com> - Fri, 14 Dec 2018 02:23:01 +0000 - rev 450485
Push 35202 by btara@mozilla.com at Fri, 14 Dec 2018 05:43:22 +0000
Bug 1514078 - Correctly report Windows running on AArch64 in the update URL. r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D14502
6798cc7aaed0765f259470eb5f7cac16d4310545: Bug 1468552 - Update bspatch.cpp to match Chromium version; r=rstrong
June Wilde <jewilde@mozilla.com> - Tue, 27 Nov 2018 18:30:30 +0000 - rev 448368
Push 35111 by csabou@mozilla.com at Wed, 28 Nov 2018 04:06:56 +0000
Bug 1468552 - Update bspatch.cpp to match Chromium version; r=rstrong Adds bounds checking around file reads and header values Differential Revision: https://phabricator.services.mozilla.com/D12356
2b4f08a645a0385021b64b4f995c18cb2250a5c6: Bug 1468552 - Update bspatch.cpp to match Chromium version; r=rstrong
June Wilde <jewilde@mozilla.com> - Mon, 26 Nov 2018 22:01:08 +0000 - rev 448325
Push 35109 by csabou@mozilla.com at Tue, 27 Nov 2018 21:53:40 +0000
Bug 1468552 - Update bspatch.cpp to match Chromium version; r=rstrong Adds bounds checking around file reads and header values Differential Revision: https://phabricator.services.mozilla.com/D12356
d1d8e236cf158b5fc75a97d6f3a0ed76cc341ebc: Bug 1486637: Impersonate user when creating files in user-controlled directories r=rstrong,mhowell
Adam Gashlin <agashlin@mozilla.com> - Mon, 19 Nov 2018 18:45:52 +0000 - rev 447064
Push 35066 by rmaries@mozilla.com at Tue, 20 Nov 2018 04:59:51 +0000
Bug 1486637: Impersonate user when creating files in user-controlled directories r=rstrong,mhowell Get an impersonation token for the user who started the maintenance service, use that when creating or moving files in user-controlled directories (currently only update.status). This token is passed along to the updater where it is used the same way (update.status, update log, and elevated lock file). The workings of getting the token are in usertoken.cpp Differential Revision: https://phabricator.services.mozilla.com/D7840
97613730a99f6156f256d351b5b7767b1d80a2b6: Bug 1468542 - Restrict acceptable bounds for i in nss_secutil; r=rstrong
June Wilde <jewilde@mozilla.com> - Mon, 19 Nov 2018 20:57:50 +0200 - rev 447032
Push 35065 by rmaries@mozilla.com at Mon, 19 Nov 2018 21:56:32 +0000
Bug 1468542 - Restrict acceptable bounds for i in nss_secutil; r=rstrong Summary: Adds some missing braces on if structures Adds a check for i being larger or equal to nb Reviewers: rstrong Reviewed By: rstrong Bug #: 1468542 Differential Revision: https://phabricator.services.mozilla.com/D12193
4a30dea025cacebb50cd376e1429ae8041c75790: Bug 1503362 - Clear the app.update.enabled pref from profiles now that it is no longer in use r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Thu, 08 Nov 2018 16:41:07 +0000 - rev 445168
Push 35012 by btara@mozilla.com at Fri, 09 Nov 2018 05:26:19 +0000
Bug 1503362 - Clear the app.update.enabled pref from profiles now that it is no longer in use r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D11128
cc07fe73ddcead18a7c3f92ce4bd3d5346cfd65c: bug 1501889 - add the ability to report binary transparency verification failures from the updater r=rstrong,francois
Dana Keeler <dkeeler@mozilla.com> - Tue, 06 Nov 2018 22:55:33 +0000 - rev 444746
Push 35001 by ncsoregi@mozilla.com at Wed, 07 Nov 2018 09:52:11 +0000
bug 1501889 - add the ability to report binary transparency verification failures from the updater r=rstrong,francois This patch adds the ability for the updater to report binary transparency verification failures without affecting the outcome of the update in progress. Differential Revision: https://phabricator.services.mozilla.com/D9846
663e1f142dd49d3bc7912a4e7661bdf7d02cda89: Bug 1458308 - Remove app.update.auto and app.update.enabled from prefs.rs and marionette.js r=rstrong,ato
Kirk Steuber <ksteuber@mozilla.com> - Tue, 06 Nov 2018 21:16:19 +0000 - rev 444732
Push 35001 by ncsoregi@mozilla.com at Wed, 07 Nov 2018 09:52:11 +0000
Bug 1458308 - Remove app.update.auto and app.update.enabled from prefs.rs and marionette.js r=rstrong,ato `app.update.auto` should actually never have been needed here. `app.update.disabledForTesting`, and before that, `app.update.enabled` will prevent updates altogether. Now that the `app.update.auto` pref is not the correct mechanism for disabling automatic update, this pref should be removed from these files. `app.update.enabled` can also be removed from prefs.rs at this time as per the comment in the file indicating that it can be removed when Firefox 62 stabilizes. Depends on D10315 Differential Revision: https://phabricator.services.mozilla.com/D10780
1b57a28b1e90c3d3c53c575090f4f98b493e452c: Bug 1458308 - Change lookups of app.update.auto to use nsIApplicationUpdateService::(get|set)AutoUpdateIsEnabled r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Tue, 06 Nov 2018 21:18:21 +0000 - rev 444731
Push 35001 by ncsoregi@mozilla.com at Wed, 07 Nov 2018 09:52:11 +0000
Bug 1458308 - Change lookups of app.update.auto to use nsIApplicationUpdateService::(get|set)AutoUpdateIsEnabled r=rstrong This patch also contains a few additional minor changes: - Clears the user value set to the pref app.update.auto after the value is migrated. - Fixes the app.update.auto pref migration test - Makes a number of functions asynchronous to allow them to wait for app.update.auto setting changes - TestAUSHelper's create-update-dir command no longer tries to set the permissions on all files in the update directory. Fixes a potential race condition when creating the update directory. Depends on D4594 Differential Revision: https://phabricator.services.mozilla.com/D10315
c6a1aa25f4fda10ef6f95a3d6d74285c2dbd74ea: Bug 1458308 - Tests for migration and UI of app.update.auto pref r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Tue, 06 Nov 2018 21:04:16 +0000 - rev 444730
Push 35001 by ncsoregi@mozilla.com at Wed, 07 Nov 2018 09:52:11 +0000
Bug 1458308 - Tests for migration and UI of app.update.auto pref r=rstrong Depends on D4593 Differential Revision: https://phabricator.services.mozilla.com/D4594
54dd159fd0a616b164b3926c153d6297b3c2bf99: Bug 1458308 - Move app.update.auto to be stored in the update directory on Windows only r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Tue, 06 Nov 2018 21:03:31 +0000 - rev 444727
Push 35001 by ncsoregi@mozilla.com at Wed, 07 Nov 2018 09:52:11 +0000
Bug 1458308 - Move app.update.auto to be stored in the update directory on Windows only r=rstrong This patch additionally includes support for automatic migration of the pref from its old location to its new location. This patch does not fix telemetry reporting of app.update.auto - that will be addressed in another patch in the same series. MozReview-Commit-ID: KjX1mmGVB8M Differential Revision: https://phabricator.services.mozilla.com/D4590
bfc6238f43786da1babdc8ee547ddc39ddbcb216: Bug 1468544 - Replace mar_hash_name with CityHash algorithm. r=rstrong
June Wilde <jewilde@mozilla.com> - Tue, 06 Nov 2018 13:34:21 -0500 - rev 444702
Push 35001 by ncsoregi@mozilla.com at Wed, 07 Nov 2018 09:52:11 +0000
Bug 1468544 - Replace mar_hash_name with CityHash algorithm. r=rstrong Make CityHash64, CityHash64WithSeed, and CityHash64WithSeeds usable from C code Remove unnecessary includes from mar_read.c as well Add DisableStlWrapping to mar tool's moz.build to fix linkage break when building in Windows with MSVC Differential Revision: https://phabricator.services.mozilla.com/D10774
f8d63cc0c95feea7aa1e6b28724be95ff3fba93c: Bug 1504878 - Exclude Mac OS from update log file tests. r=rstrong
Matt Howell <mhowell@mozilla.com> - Tue, 06 Nov 2018 18:15:24 +0000 - rev 444701
Push 35001 by ncsoregi@mozilla.com at Wed, 07 Nov 2018 09:52:11 +0000
Bug 1504878 - Exclude Mac OS from update log file tests. r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D10982
196dcfd11ce337df9f185d43f9e29c7eb5c787d8: Bug 1468544 - Replace mar_hash_name with CityHash algorithm; r=rstrong
June Wilde <jewilde@mozilla.com> - Tue, 06 Nov 2018 20:35:32 +0200 - rev 444659
Push 35000 by dvarga@mozilla.com at Tue, 06 Nov 2018 21:59:20 +0000
Bug 1468544 - Replace mar_hash_name with CityHash algorithm; r=rstrong Summary: Make CityHash64, CityHash64WithSeed, and CityHash64WithSeeds usable from C code Remove unnecessary includes from mar_read.c as well Add DisableStlWrapping to mar tool's moz.build to fix linkage break when building in Windows with MSVC Reviewers: rstrong Reviewed By: rstrong Bug #: 1468544 Differential Revision: https://phabricator.services.mozilla.com/D10774
30dec3c6ac99c13c5a887441e17efa8a821009a6: Bug 1468544 - Replace mar_hash_name with CityHash algorithm; r=rstrong
June Wilde <jewilde@mozilla.com> - Thu, 01 Nov 2018 19:43:55 +0200 - rev 443995
Push 34977 by dvarga@mozilla.com at Thu, 01 Nov 2018 22:29:07 +0000
Bug 1468544 - Replace mar_hash_name with CityHash algorithm; r=rstrong Summary: Makes CityHash64, CityHash64WithSeed, and CityHash64WithSeeds usable from C code Removes unnecessary includes from mar_read.c as well Reviewers: rstrong Reviewed By: rstrong Subscribers: ulfr, dveditz, tjr, mhowell, jmathies, rstrong, jewilde Tags: #secure-revision, #bmo-toolkit-core-security Bug #: 1468544 Differential Revision: https://phabricator.services.mozilla.com/D10426
91e7d48c9679517e3c10cc1b26873f6e25e8066c: Bug 1503331 - Remove support for a Custom field in the update URL r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Tue, 30 Oct 2018 17:12:28 +0000 - rev 443537
Push 34961 by aciure@mozilla.com at Tue, 30 Oct 2018 22:06:02 +0000
Bug 1503331 - Remove support for a Custom field in the update URL r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D10266
4bf34689d4b62ed8299e1239ec9c01a4a6833e38: Bug 1458308 - Tests for migration and UI of app.update.auto pref r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Mon, 29 Oct 2018 21:36:04 +0000 - rev 443528
Push 34961 by aciure@mozilla.com at Tue, 30 Oct 2018 22:06:02 +0000
Bug 1458308 - Tests for migration and UI of app.update.auto pref r=rstrong Depends on D4593 Differential Revision: https://phabricator.services.mozilla.com/D4594
7370877bd9e1c0276e486dfe16ff23eac202a833: Bug 1458308 - Move app.update.auto to be stored in the update directory on Windows only r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Mon, 29 Oct 2018 21:35:25 +0000 - rev 443525
Push 34961 by aciure@mozilla.com at Tue, 30 Oct 2018 22:06:02 +0000
Bug 1458308 - Move app.update.auto to be stored in the update directory on Windows only r=rstrong This patch additionally includes support for automatic migration of the pref from its old location to its new location. This patch does not fix telemetry reporting of app.update.auto - that will be addressed in another patch in the same series. MozReview-Commit-ID: KjX1mmGVB8M Differential Revision: https://phabricator.services.mozilla.com/D4590
3d22697d9c23a23087190225aa201a44bc1be130: Bug 1458314 - Move the update directory to an installation specific location r=rstrong
Kirk Steuber <ksteuber@mozilla.com> - Tue, 23 Oct 2018 21:41:04 +0000 - rev 442649
Push 34916 by aiakab@mozilla.com at Wed, 24 Oct 2018 04:14:42 +0000
Bug 1458314 - Move the update directory to an installation specific location r=rstrong This change applies to Windows only. Firefox will need to migrate the directory from the old location to the new location. This will be done only once by setting the pref `app.update.migrated.updateDir2.<install path hash>` to `true` once migration has completed. Note: The pref name app.update.migrated.updateDir has already been used, thus the '2' suffix. It can be found in ESR24. This also removes the old handling fallback for generating the update directory path. Since xulrunner is no longer supported, this should no longer be needed. If neither the vendor nor app name are defined, it falls back to the literal string "Mozilla". The code to generate the update directory path and the installation hash have been moved to the updatecommon library. This will allow those functions to be used in Firefox, the Mozilla Maintenance Service, the Mozilla Maintenance Service Installer, and TestAUSHelper. Additionally, the function that generates the update directory path now has extra functionality. It creates the update directory, sets the permissions on it and, optionally, recursively sets the permissions on everything within. This patch adds functionality that allows Firefox to set permissions on the new update directory on write failure. It attempts to set the permissions itself and, if that fails and the maintenance service is enabled, it calls into the maintenance service to try from there. If a write fails and the permissions cannot be fixed, the user is prompted to reinstall. Differential Revision: https://phabricator.services.mozilla.com/D4249
02361691547a0220d9c08951e9d7a578507bd039: Bug 1497937 - fixed a deprecation warning due to including an older header; r=rstrong
Alex Gaynor <agaynor@mozilla.com> - Tue, 23 Oct 2018 16:47:30 +0000 - rev 442620
Push 34916 by aiakab@mozilla.com at Wed, 24 Oct 2018 04:14:42 +0000
Bug 1497937 - fixed a deprecation warning due to including an older header; r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D8561
379d79841c5d439654d77f264f7c9d730863059e: Bug 1458129 - Prevent double free in mar_sign.c. r=rstrong
June Wilde <jewilde@mozilla.com> - Thu, 18 Oct 2018 13:29:08 -0400 - rev 441996
Push 34885 by csabou@mozilla.com at Fri, 19 Oct 2018 04:17:46 +0000
Bug 1458129 - Prevent double free in mar_sign.c. r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D8924
7ee4eac9ae35ab547b05e0ff600c4f26cc079144: Bug 1496094 - Fix determining the correct target path of a reparse point. r=rstrong
Matt Howell <mhowell@mozilla.com> - Fri, 05 Oct 2018 00:18:01 +0000 - rev 439729
Push 34783 by ncsoregi@mozilla.com at Fri, 05 Oct 2018 04:46:05 +0000
Bug 1496094 - Fix determining the correct target path of a reparse point. r=rstrong The two standard reparse data buffer structs (SymbolicLinkReparseBuffer and MountPointReparseBuffer) both contain one UTF-16 array called PathBuffer which contains two paths, the "print name" and the "substitute name", with no separator between them. There are also fields in the struct that provide the offset and the length of both those paths (in bytes). I had originally missed that these were separate paths and that the print name will typically not match the substitute name for file system links. This patch corrects that oversight and uses the offsets to correctly check only the substitute name. Differential Revision: https://phabricator.services.mozilla.com/D7645
96059b4f6d8a1590c97ffc47ca7f73530dd51cb5: bug 1490119: Add build system bits for building dep updater. r=firefox-build-system-reviewers,mshal,rstrong
Ben Hearsum <bhearsum@mozilla.com> - Wed, 19 Sep 2018 19:55:23 +0000 - rev 437283
Push 34674 by btara@mozilla.com at Wed, 19 Sep 2018 21:57:43 +0000
bug 1490119: Add build system bits for building dep updater. r=firefox-build-system-reviewers,mshal,rstrong This patch gets us building an updater binary that always embeds the dep certificates (instead of release or nightly), and builds a new tests package that includes it. I had a lot of trouble getting the test package generated correctly due to the fact that things in "_tests" won't be included for test packages that aren't "common". My fix for that isn't ideal - I'm open to something better. Differential Revision: https://phabricator.services.mozilla.com/D5900
59f5c546faa289cd0b7b713dc5ac9e4e53cb0c02: bug 1490119: Add build system bits for building dep updater. r=rstrong
Ben Hearsum <bhearsum@mozilla.com> - Tue, 11 Sep 2018 18:15:44 +0000 - rev 435794
Push 34619 by btara@mozilla.com at Wed, 12 Sep 2018 03:11:51 +0000
bug 1490119: Add build system bits for building dep updater. r=rstrong This patch gets us building an updater binary that always embeds the dep certificates (instead of release or nightly). It gets installed to its own directory, and a subsequent patch will get us creating a test package that includes it. Differential Revision: https://phabricator.services.mozilla.com/D5539