searching for reviewer(rhunt)
9d54a4e4532c719106671c2ee082aa2f01a63788: Bug 1637328 - Make stack copies in stubs handle v128 data. r=rhunt
Lars T Hansen <lhansen@mozilla.com> - Mon, 18 May 2020 08:41:42 +0000 - rev 530547
Push 37428 by nbeleuzu@mozilla.com at Mon, 18 May 2020 21:48:24 +0000
Bug 1637328 - Make stack copies in stubs handle v128 data. r=rhunt We can't MOZ_CRASH for the v128 cases of the stack copies in SetupABIArguments and StackCopy. In the former case we can emit a breakpoint instruction because the code should never be executed. In the latter case we just copy the data. Adds test cases that triggered the MOZ_CRASHes, and other test cases that are related but left out of the test cases when SIMD for baseline first landed. Differential Revision: https://phabricator.services.mozilla.com/D74934
2194251cb1f3377b6f9aa544ec3f417e49069280: Bug 1635783 - Update the stack matcher to handle v128. r=rhunt
Lars T Hansen <lhansen@mozilla.com> - Thu, 14 May 2020 07:49:35 +0000 - rev 529811
Push 37416 by csabou@mozilla.com at Thu, 14 May 2020 16:15:31 +0000
Bug 1635783 - Update the stack matcher to handle v128. r=rhunt Account for a possible "v128" in a profiler message. Also a drive-by fix for two regex problems, one where something that should be a non-capturing submatch was represented as a character set and one where a non-capturing submatch was represented as capturing. Differential Revision: https://phabricator.services.mozilla.com/D75107
1120db775f13ecc813430c05f7133beb8539fb6c: Bug 1637506 - Move allTrue porting interfaces to x86_shared. r=rhunt
Lars T Hansen <lhansen@mozilla.com> - Thu, 14 May 2020 07:38:15 +0000 - rev 529805
Push 37416 by csabou@mozilla.com at Thu, 14 May 2020 16:15:31 +0000
Bug 1637506 - Move allTrue porting interfaces to x86_shared. r=rhunt This is pure refactoring in preparation for further SIMD work, these functions were always x86_shared compatible but ended up in x64 code by mistake. Differential Revision: https://phabricator.services.mozilla.com/D75120
64cd0f5e058573a9866c4f5311827d2f569a7081: Bug 1635091 - Renumber the SIMD opcodes. r=rhunt
Lars T Hansen <lhansen@mozilla.com> - Wed, 13 May 2020 02:14:33 +0000 - rev 529517
Push 37410 by ncsoregi@mozilla.com at Wed, 13 May 2020 09:49:18 +0000
Bug 1635091 - Renumber the SIMD opcodes. r=rhunt Renumbers the SIMD opcodes in accordance with the latest proposal, dropping the legacy shuffle opcode. Fixes a few binary tests. Differential Revision: https://phabricator.services.mozilla.com/D74216
ec2d66612ed02cfb1e458f8780ba3aaf8777e28a: Bug 1635783 - Add a fast path for stack normalization. r=rhunt
Lars T Hansen <lhansen@mozilla.com> - Mon, 11 May 2020 14:30:44 +0000 - rev 529284
Push 37406 by dluca@mozilla.com at Tue, 12 May 2020 09:34:21 +0000
Bug 1635783 - Add a fast path for stack normalization. r=rhunt Stack normalization is uber-slow on emulator because it relies on regexes that are compiled to native instructions which are then emulated. That makes stack normalization very slow too, and as it's very hot some tests will time out nearly always. This patch inserts a simple cache for previously matched strings in stack normalization to avoid the regex engine altogether. This speeds up normalization and hence stack matching greatly (I observed a factor of four speedup per test iteration on an arm-sim noopt debug build for ion-error-ool.js). I also attempted some other fixes (filtering on simple strings, avoiding regex.replace, etc) but caching is by far the most effective fix, and with caching in place the other fixes still don't really move the needle. Depends on D74220 Differential Revision: https://phabricator.services.mozilla.com/D74607
d4756b84d2d52774ce2b93e61774a4aa9c8dde78: Bug 1635783 - Make an error message match more flexible. r=rhunt
Lars T Hansen <lhansen@mozilla.com> - Mon, 11 May 2020 08:30:06 +0000 - rev 529283
Push 37406 by dluca@mozilla.com at Tue, 12 May 2020 09:34:21 +0000
Bug 1635783 - Make an error message match more flexible. r=rhunt When SIMD is not enabled, v128 is not mentioned in the error message, so make allowances for that. Differential Revision: https://phabricator.services.mozilla.com/D74220
0f3e454359c94075c6c60a1922ae1e44a6e350c4: Bug 1478632 - wasm simd, part 8: spec test cases. r=rhunt
Lars T Hansen <lhansen@mozilla.com> - Tue, 05 May 2020 08:25:59 +0000 - rev 528035
Push 37381 by apavel@mozilla.com at Tue, 05 May 2020 15:29:23 +0000
Bug 1478632 - wasm simd, part 8: spec test cases. r=rhunt Import a rough-and-ready translation of the SIMD spec test cases. We place these in wasm/simd/spec instead of in wasm/spec/simd since the latter location will eventually be occupied by the canonical translation, after which the tests imported by the present patch can be deleted. Differential Revision: https://phabricator.services.mozilla.com/D71006
a95567deaf984947d5e3d8500dfc9e757d54e38f: Bug 1478632 - wasm simd, part 7: functional test cases. r=rhunt
Lars T Hansen <lhansen@mozilla.com> - Tue, 05 May 2020 08:25:00 +0000 - rev 528034
Push 37381 by apavel@mozilla.com at Tue, 05 May 2020 15:29:23 +0000
Bug 1478632 - wasm simd, part 7: functional test cases. r=rhunt Test cases for all instructions and all aspects of the JS interface. Differential Revision: https://phabricator.services.mozilla.com/D68853
fbe341549522b1649c1792b5535de2e46de84a1b: Bug 1478632 - wasm simd, part 4: test cases for the validator. r=rhunt
Lars T Hansen <lhansen@mozilla.com> - Tue, 05 May 2020 08:31:29 +0000 - rev 528030
Push 37381 by apavel@mozilla.com at Tue, 05 May 2020 15:29:23 +0000
Bug 1478632 - wasm simd, part 4: test cases for the validator. r=rhunt These test that validation works as it should, but do not compile or execute anything. Differential Revision: https://phabricator.services.mozilla.com/D59111
6d61cc7132d6ae1a3d5ca28f119fd4e38e05269a: Bug 1478632 - wasm simd, part 3: opcodes and validator. r=rhunt
Lars T Hansen <lhansen@mozilla.com> - Tue, 05 May 2020 08:22:58 +0000 - rev 528029
Push 37381 by apavel@mozilla.com at Tue, 05 May 2020 15:29:23 +0000
Bug 1478632 - wasm simd, part 3: opcodes and validator. r=rhunt We add all the opcodes and all the switches to decode them. Differential Revision: https://phabricator.services.mozilla.com/D57942
dede8f837d1daaa0ce69645b2b00ef3a95466574: Bug 1478632 - wasm simd, part 2: the v128 type. r=rhunt
Lars T Hansen <lhansen@mozilla.com> - Tue, 05 May 2020 08:22:20 +0000 - rev 528028
Push 37381 by apavel@mozilla.com at Tue, 05 May 2020 15:29:23 +0000
Bug 1478632 - wasm simd, part 2: the v128 type. r=rhunt We add V128 to the ValType enum and insert it in all switches throughout the engine. In many cases we insert MOZ_CRASH() that will be resolved in later patches. Note we're currently using MIRType::Int8x16 to represent V128. This will change later, when we do the Ion work. Differential Revision: https://phabricator.services.mozilla.com/D57941
b48f9d17198344d0af482a30c95e86a92ad7ce93: Bug 1478632 - wasm simd, part 1: feature gating and related prep. r=rhunt
Lars T Hansen <lhansen@mozilla.com> - Tue, 05 May 2020 08:17:47 +0000 - rev 528027
Push 37381 by apavel@mozilla.com at Tue, 05 May 2020 15:29:23 +0000
Bug 1478632 - wasm simd, part 1: feature gating and related prep. r=rhunt We add a configuration option for SIMD and apply ENABLE_WASM_SIMD throughout the engine as appropriate, mostly to insert #error or MOZ_CRASH where things need to be done in later patches or for architectures that we won't currently consider. We add a command line switch for the shell and an option for about:config and plumb the value of this through the engine. Differential Revision: https://phabricator.services.mozilla.com/D57940
bb3910236cadc8bf1ee655b32b7d09ae25883df4: Bug 1630936: Write documentation for Baldrdash in Spidermonkey; r=rhunt,lth
Benjamin Bouvier <benj@benj.me> - Tue, 21 Apr 2020 09:20:19 +0000 - rev 525049
Push 37334 by aiakab@mozilla.com at Tue, 21 Apr 2020 22:25:03 +0000
Bug 1630936: Write documentation for Baldrdash in Spidermonkey; r=rhunt,lth Differential Revision: https://phabricator.services.mozilla.com/D71313
54f41fca4bdacaa52a4f524969c047faef8e9fd9: Bug 1630936: Use log macros explicitly instead of ye olde extern crate way; r=rhunt
Benjamin Bouvier <benj@benj.me> - Tue, 21 Apr 2020 09:20:17 +0000 - rev 525048
Push 37334 by aiakab@mozilla.com at Tue, 21 Apr 2020 22:25:03 +0000
Bug 1630936: Use log macros explicitly instead of ye olde extern crate way; r=rhunt Differential Revision: https://phabricator.services.mozilla.com/D71312
8de9829f7c12b2fed6dcc5a85495b17c41a467c6: Bug 1630205: Reuse data structures even more across Cranelift compilations; r=rhunt
Benjamin Bouvier <benj@benj.me> - Thu, 16 Apr 2020 10:12:58 +0000 - rev 524364
Push 37320 by btara@mozilla.com at Thu, 16 Apr 2020 21:43:56 +0000
Bug 1630205: Reuse data structures even more across Cranelift compilations; r=rhunt Differential Revision: https://phabricator.services.mozilla.com/D71038
09c016706d3f16ba0687c74baf0938a8f5f5188d: Bug 1626967: Provide Cranelift the size of wasm::Frame from a StaticEnvironment value; r=rhunt
Benjamin Bouvier <benj@benj.me> - Fri, 10 Apr 2020 09:53:22 +0000 - rev 523372
Push 37301 by aiakab@mozilla.com at Fri, 10 Apr 2020 21:37:00 +0000
Bug 1626967: Provide Cranelift the size of wasm::Frame from a StaticEnvironment value; r=rhunt This avoids one platform-specific number (3 for x86_64, 4 for arm64). Differential Revision: https://phabricator.services.mozilla.com/D69396
b44cac1aa5f193213c96749cf9ea3deea5efd73c: Bug 1626967: Use snake_case in shared Cranelift data structures; r=rhunt
Benjamin Bouvier <benj@benj.me> - Fri, 10 Apr 2020 09:53:15 +0000 - rev 523371
Push 37301 by aiakab@mozilla.com at Fri, 10 Apr 2020 21:37:00 +0000
Bug 1626967: Use snake_case in shared Cranelift data structures; r=rhunt This favors Rust, but there's no way to generate different names in the bindings, as far as I know. Differential Revision: https://phabricator.services.mozilla.com/D69395
fb80ccae7376ec82a7a058de97c33f5c7b47f6cd: Bug 1626967: Use the regular Cranelift sinks to keep track of relocations; r=rhunt
Benjamin Bouvier <benj@benj.me> - Fri, 10 Apr 2020 09:53:07 +0000 - rev 523370
Push 37301 by aiakab@mozilla.com at Fri, 10 Apr 2020 21:37:00 +0000
Bug 1626967: Use the regular Cranelift sinks to keep track of relocations; r=rhunt This goes hand in hand with https://github.com/bytecodealliance/wasmtime/pull/1460, which will need to be merged first. This removes most of the Spidermonkey-specific machinery to collect relocations. The only remaining place is for stack-maps, which will be handled later. Differential Revision: https://phabricator.services.mozilla.com/D69394
985eea91c36c76c8ebdb28183251b3d61291a52b: Bug 1626967: Provide Cranelift the size of wasm::Frame from a StaticEnvironment value; r=rhunt
Benjamin Bouvier <benj@benj.me> - Tue, 07 Apr 2020 10:37:32 +0000 - rev 522560
Push 37292 by ccoroiu@mozilla.com at Tue, 07 Apr 2020 16:05:40 +0000
Bug 1626967: Provide Cranelift the size of wasm::Frame from a StaticEnvironment value; r=rhunt This avoids one platform-specific number (3 for x86_64, 4 for arm64). Differential Revision: https://phabricator.services.mozilla.com/D69396
837dab8ce31cb96546ca90b5703331644961ce94: Bug 1626967: Use snake_case in shared Cranelift data structures; r=rhunt
Benjamin Bouvier <benj@benj.me> - Tue, 07 Apr 2020 10:37:20 +0000 - rev 522559
Push 37292 by ccoroiu@mozilla.com at Tue, 07 Apr 2020 16:05:40 +0000
Bug 1626967: Use snake_case in shared Cranelift data structures; r=rhunt This favors Rust, but there's no way to generate different names in the bindings, as far as I know. Differential Revision: https://phabricator.services.mozilla.com/D69395
f48ad40e60afd31b716ff5bb15e69c99c9180945: Bug 1626967: Use the regular Cranelift sinks to keep track of relocations; r=rhunt
Benjamin Bouvier <benj@benj.me> - Tue, 07 Apr 2020 10:37:13 +0000 - rev 522558
Push 37292 by ccoroiu@mozilla.com at Tue, 07 Apr 2020 16:05:40 +0000
Bug 1626967: Use the regular Cranelift sinks to keep track of relocations; r=rhunt This goes hand in hand with https://github.com/bytecodealliance/wasmtime/pull/1460, which will need to be merged first. This removes most of the Spidermonkey-specific machinery to collect relocations. The only remaining place is for stack-maps, which will be handled later. Differential Revision: https://phabricator.services.mozilla.com/D69394
64918c6e2f834f6e2f26cc9493e8f50c15c01124: Bug 1625660 - Update the wat crate to 1.0.13. r=rhunt
Lars T Hansen <lhansen@mozilla.com> - Mon, 30 Mar 2020 16:16:36 +0000 - rev 521101
Push 37266 by ccoroiu@mozilla.com at Mon, 30 Mar 2020 22:01:01 +0000
Bug 1625660 - Update the wat crate to 1.0.13. r=rhunt Differential Revision: https://phabricator.services.mozilla.com/D68815
195f1fd6cc2b78b88fa77625d91c99bf5dfde9d8: Bug 1620748 - Decode already-read byte for type for debugger. r=rhunt
Lars T Hansen <lhansen@mozilla.com> - Fri, 27 Mar 2020 16:10:03 +0000 - rev 520764
Push 37259 by dluca@mozilla.com at Sat, 28 Mar 2020 09:32:56 +0000
Bug 1620748 - Decode already-read byte for type for debugger. r=rhunt This looks like a paste-o to me, the code in readValType() below clearly shows we should use the byte we've already read. Differential Revision: https://phabricator.services.mozilla.com/D68566
9b889a0ecb01af368c509d33cbba63514a9a0635: Bug 1620284 - Bump Cranelift to 5cfcbeb59d477e028c6fb312f1cf63aa711fcc3c; r=rhunt
Benjamin Bouvier <benj@benj.me> - Wed, 25 Mar 2020 14:43:05 +0000 - rev 520365
Push 37249 by dvarga@mozilla.com at Wed, 25 Mar 2020 21:39:06 +0000
Bug 1620284 - Bump Cranelift to 5cfcbeb59d477e028c6fb312f1cf63aa711fcc3c; r=rhunt Differential Revision: https://phabricator.services.mozilla.com/D65557
86267e092be2e6ccca476bec2f5776fcdd643672: Bug 1623602 - Properly guard a test case. r=rhunt
Lars T Hansen <lhansen@mozilla.com> - Thu, 19 Mar 2020 18:02:37 +0000 - rev 519785
Push 37232 by csabou@mozilla.com at Fri, 20 Mar 2020 09:53:53 +0000
Bug 1623602 - Properly guard a test case. r=rhunt An earlier change would disable SharedArrayBuffer in the JS shell for beta and release builds. This has uncovered some broken guards in various test cases, in this case, a test on whether the shell built-in setSharedObject is available. However, that is not affected by the change in the setting, so the guard really should test both setSharedObject (to ensure it's only tested in the shell) and SharedArrayBuffer (to ensure it's only tested when shared memory is available.) Differential Revision: https://phabricator.services.mozilla.com/D67474
a4254ff916a125db85b92d3087ec1f0fad851fb1: Bug 1621208 - Do not assume shared memory is enabled. r=rhunt
Lars T Hansen <lhansen@mozilla.com> - Wed, 11 Mar 2020 07:50:31 +0000 - rev 518129
Push 37206 by aciure@mozilla.com at Thu, 12 Mar 2020 03:57:49 +0000
Bug 1621208 - Do not assume shared memory is enabled. r=rhunt Update some of the bulk memory test cases so that they do not run tests on shared memory if shared memory is disabled in the engine. Differential Revision: https://phabricator.services.mozilla.com/D66191
05118e6c2fffef641c73bf1ca119959c70889c71: Bug 1621044 - Update in-tree consumers of bindgen. r=keeler,rhunt
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 10 Mar 2020 21:07:34 +0000 - rev 517961
Push 37203 by ccoroiu@mozilla.com at Wed, 11 Mar 2020 04:11:49 +0000
Bug 1621044 - Update in-tree consumers of bindgen. r=keeler,rhunt Differential Revision: https://phabricator.services.mozilla.com/D66281
4c839456c3fff6c961a29e589590a12768a44867: Bug 1620284 - Bump Cranelift to 135a48ca7e9a45d7d31911753e602e6de8b14e2a; r=rhunt
Benjamin Bouvier <benj@benj.me> - Thu, 05 Mar 2020 20:59:42 +0000 - rev 517204
Push 37188 by ncsoregi@mozilla.com at Fri, 06 Mar 2020 20:10:41 +0000
Bug 1620284 - Bump Cranelift to 135a48ca7e9a45d7d31911753e602e6de8b14e2a; r=rhunt Differential Revision: https://phabricator.services.mozilla.com/D65557
38ffe153da021a66fb5db9a7aa805b3d965f4a03: Bug 1617908 - More sophisticated write barrier for struct.set. r=rhunt
Lars T Hansen <lhansen@mozilla.com> - Tue, 03 Mar 2020 08:26:27 +0000 - rev 516554
Push 37176 by dluca@mozilla.com at Tue, 03 Mar 2020 15:54:57 +0000
Bug 1617908 - More sophisticated write barrier for struct.set. r=rhunt The write barrier for struct.set must take into account the location of its storage: if the storage is inline in the TypedObject, the object must be passed to the barrier, but for outline storage it must not. Additionally, we must avoid storage that is outline in the TypedObject but inline in an underlying ArrayBuffer. Introduce a static_assert to guard against this, it is not currently a problem and it should not be allowed to become one. Differential Revision: https://phabricator.services.mozilla.com/D64289
7df1967010af976aadade5e6e964731c6c9680e1: Bug 1614303: API changes for newest Cranelift version; r=rhunt
Benjamin Bouvier <benj@benj.me> - Mon, 10 Feb 2020 16:50:59 +0000 - rev 513693
Push 37120 by cbrindusan@mozilla.com at Thu, 13 Feb 2020 18:21:33 +0000
Bug 1614303: API changes for newest Cranelift version; r=rhunt Differential Revision: https://phabricator.services.mozilla.com/D62234
57d10ca6fbee57242db7eea07d5e5e685e00b006: Bug 1614303 - Bump Cranelift to "98c818c129979e98a3db150f8f9698f6451b7ef7"; r=rhunt
Benjamin Bouvier <benj@benj.me> - Mon, 10 Feb 2020 16:50:57 +0000 - rev 513692
Push 37120 by cbrindusan@mozilla.com at Thu, 13 Feb 2020 18:21:33 +0000
Bug 1614303 - Bump Cranelift to "98c818c129979e98a3db150f8f9698f6451b7ef7"; r=rhunt Differential Revision: https://phabricator.services.mozilla.com/D62233
16309c907652f1b1e46fa9bebf43faee5168b03d: Bug 1608791 - Harden the Rabaldr register wrappers. r=rhunt
Lars T Hansen <lhansen@mozilla.com> - Mon, 20 Jan 2020 12:23:12 +0000 - rev 510700
Push 37035 by aciure@mozilla.com at Mon, 20 Jan 2020 15:44:12 +0000
Bug 1608791 - Harden the Rabaldr register wrappers. r=rhunt By cleaning up the register set APIs very slightly we can simplify the wrappers and make space for meaningful assertions. Differential Revision: https://phabricator.services.mozilla.com/D59673
8c7371a02fd7f7e6da78289ae3d5c22949490204: Bug 1609138 - Clean up float registers on arm64. r=rhunt
Lars T Hansen <lhansen@mozilla.com> - Mon, 20 Jan 2020 12:22:23 +0000 - rev 510699
Push 37035 by aciure@mozilla.com at Mon, 20 Jan 2020 15:44:12 +0000
Bug 1609138 - Clean up float registers on arm64. r=rhunt Create a clearer distinction between the register's Encoding, which is its hardware name, and its Code, which is a dense encoding of bitwidth+Encoding along with a distinguished Invalid value. These concepts exist already but it gets out of hand when the FloatRegister uses a Code to encode the Encoding. Make FloatRegister contain separate fields for bitwidth, encoding, and validity, as it does on other platforms. Add assertions on validity of inputs and on the validity of the FloatRegister for some operations. And tidy up some, and rearrange the file to mirror the x86 file as much as possible. Expand the register name table so that it covers the possible range of Code and so that we won't reference the table OOB. Differential Revision: https://phabricator.services.mozilla.com/D59912
7d2c3216d225458e95547091e2d7e1efe067e88d: Bug 1608791 - Harden the Rabaldr register wrappers. r=rhunt
Lars T Hansen <lhansen@mozilla.com> - Mon, 20 Jan 2020 07:34:31 +0000 - rev 510687
Push 37035 by aciure@mozilla.com at Mon, 20 Jan 2020 15:44:12 +0000
Bug 1608791 - Harden the Rabaldr register wrappers. r=rhunt By cleaning up the register set APIs very slightly we can simplify the wrappers and make space for meaningful assertions. Differential Revision: https://phabricator.services.mozilla.com/D59673
d2b7ff305b35b60bb8e27cb41db70f085728ca4f: Bug 1609138 - Clean up float registers on arm64. r=rhunt
Lars T Hansen <lhansen@mozilla.com> - Mon, 20 Jan 2020 07:33:52 +0000 - rev 510686
Push 37035 by aciure@mozilla.com at Mon, 20 Jan 2020 15:44:12 +0000
Bug 1609138 - Clean up float registers on arm64. r=rhunt Create a clearer distinction between the register's Encoding, which is its hardware name, and its Code, which is a dense encoding of bitwidth+Encoding along with a distinguished Invalid value. These concepts exist already but it gets out of hand when the FloatRegister uses a Code to encode the Encoding. Make FloatRegister contain separate fields for bitwidth, encoding, and validity, as it does on other platforms. Add assertions on validity of inputs and on the validity of the FloatRegister for some operations. And tidy up some, and rearrange the file to mirror the x86 file as much as possible. Expand the register name table so that it covers the possible range of Code and so that we won't reference the table OOB. Differential Revision: https://phabricator.services.mozilla.com/D59912
d2457f7efd8a35a93816cbc6b47796c8cbc3b625: Bug 1608791 - Harden the Rabaldr register wrappers. r=rhunt
Lars T Hansen <lhansen@mozilla.com> - Tue, 14 Jan 2020 18:51:52 +0000 - rev 510237
Push 37015 by cbrindusan@mozilla.com at Wed, 15 Jan 2020 04:16:28 +0000
Bug 1608791 - Harden the Rabaldr register wrappers. r=rhunt By cleaning up the register set APIs very slightly we can simplify the wrappers and make space for meaningful assertions. Differential Revision: https://phabricator.services.mozilla.com/D59673
a7654938178351feeb8ec4e97994ffd9e4192214: Bug 1604740 - Zydis update. r=rhunt
Lars T Hansen <lhansen@mozilla.com> - Tue, 14 Jan 2020 19:00:47 +0000 - rev 510236
Push 37015 by cbrindusan@mozilla.com at Wed, 15 Jan 2020 04:16:28 +0000
Bug 1604740 - Zydis update. r=rhunt This pulls the Zydis working branch to get a compile fix for Solaris that was upstreamed to Zydis by Oracle. I ran the zydis/update.sh script, then 'hg add'ed four new files, and ran a quick test - everything seems to work OK, wonders never cease. A diff of new vs old code shows the Solaris fix is included. The patch includes a change to update.sh that gets the pulled rev from the git repo, not from the command line Differential Revision: https://phabricator.services.mozilla.com/D59915
d33c1e0b18ab78924d4d74cf4fd72459faafb6d3: Bug 1568533 - make CaptureCommandList.h Append() template use aligned pointers r=rhunt
Petr Sumbera <petr.sumbera@oracle.com> - Fri, 13 Dec 2019 20:18:45 +0000 - rev 508488
Push 36967 by rgurzau@mozilla.com at Tue, 31 Dec 2019 09:43:49 +0000
Bug 1568533 - make CaptureCommandList.h Append() template use aligned pointers r=rhunt Differential Revision: https://phabricator.services.mozilla.com/D48952
f1547816cf326f1060f787fe9846e6bda7a33cbf: Bug 1602712 - First implementation of GetNewOrUsedBrowserAsync;r=rhunt
David Teller <dteller@mozilla.com> - Thu, 19 Dec 2019 10:57:13 +0000 - rev 507820
Push 36932 by aciure@mozilla.com at Thu, 19 Dec 2019 21:52:02 +0000
Bug 1602712 - First implementation of GetNewOrUsedBrowserAsync;r=rhunt Depends on D56961 Differential Revision: https://phabricator.services.mozilla.com/D56962
050e0dee5088d44f1caff3bc82d3e02cd77f875b: Bug 1602712 - Split the parts of GetNewOrUsedBrowser that can be shared betwen sync and async;r=rhunt
David Teller <dteller@mozilla.com> - Thu, 19 Dec 2019 10:57:13 +0000 - rev 507819
Push 36932 by aciure@mozilla.com at Thu, 19 Dec 2019 21:52:02 +0000
Bug 1602712 - Split the parts of GetNewOrUsedBrowser that can be shared betwen sync and async;r=rhunt Differential Revision: https://phabricator.services.mozilla.com/D56961
4e7dd9fe1cde8e852a5653698614119941a08e0f: Bug 1604118 - Rename isRef, and tidy up. r=rhunt
Lars T Hansen <lhansen@mozilla.com> - Tue, 17 Dec 2019 13:39:41 +0000 - rev 507507
Push 36929 by opoprus@mozilla.com at Wed, 18 Dec 2019 16:02:51 +0000
Bug 1604118 - Rename isRef, and tidy up. r=rhunt Renames isRef() as isTypeIndex() and slightly change some error messages to distinguish indexed reference types from the more generic ones. Adds predicates on ValType to test various reference type subtypes, this reduces clutter. Slightly changes the code around existing uses of isRef() to improve error checking and provide resilience as we go forward toward other reference types, by calling out struct types specifically when they are the types we care about, and in one case changing from isRef() to !isAnyRef(), since that was the intent when we only had only the two cases AnyRef and Ref. Differential Revision: https://phabricator.services.mozilla.com/D57330
f23128d93320d080700b559277b8a034744adb8b: Bug 1603496 - abstract reference-type checking on JS values. r=rhunt
Lars T Hansen <lhansen@mozilla.com> - Mon, 16 Dec 2019 08:59:09 +0000 - rev 507056
Push 36922 by ncsoregi@mozilla.com at Mon, 16 Dec 2019 17:21:47 +0000
Bug 1603496 - abstract reference-type checking on JS values. r=rhunt Lift the code that checks JS values against reference types (and boxes anyref) from all the places where it is repeated into a common function. Clean up some code that assumes that the only reference types are anyref and funcref. Differential Revision: https://phabricator.services.mozilla.com/D56971
572a5cc1d0b5779c434dda5cba78a8ad59304eff: Bug 1603726 - Move tests to wasm/gc. r=rhunt
Lars T Hansen <lhansen@mozilla.com> - Mon, 16 Dec 2019 08:46:32 +0000 - rev 507055
Push 36922 by ncsoregi@mozilla.com at Mon, 16 Dec 2019 17:21:47 +0000
Bug 1603726 - Move tests to wasm/gc. r=rhunt Differential Revision: https://phabricator.services.mozilla.com/D57124
b0fb09545a0128c4ffdc4806e9f97cb3281f133c: Bug 1603772: Cranelift: replace native_pointer_{size,type} by const values; r=rhunt
Benjamin Bouvier <benj@benj.me> - Fri, 13 Dec 2019 19:35:58 +0000 - rev 507051
Push 36922 by ncsoregi@mozilla.com at Mon, 16 Dec 2019 17:21:47 +0000
Bug 1603772: Cranelift: replace native_pointer_{size,type} by const values; r=rhunt Differential Revision: https://phabricator.services.mozilla.com/D57127
fbeac1746d504ac63ad910d9c103ca2d65377d73: Bug 1603772: Revert the error type change when instantiating segments with Cranelift; r=rhunt
Benjamin Bouvier <benj@benj.me> - Fri, 13 Dec 2019 19:35:58 +0000 - rev 507050
Push 36922 by ncsoregi@mozilla.com at Mon, 16 Dec 2019 17:21:47 +0000
Bug 1603772: Revert the error type change when instantiating segments with Cranelift; r=rhunt Differential Revision: https://phabricator.services.mozilla.com/D57126
b92d5b9b880a082ca7c9a61ad9addc88c35f5ab8: Bug 1603772: Cranelift: only return the ret value when it's not used for internal purposes; r=rhunt
Benjamin Bouvier <benj@benj.me> - Fri, 13 Dec 2019 19:35:58 +0000 - rev 507049
Push 36922 by ncsoregi@mozilla.com at Mon, 16 Dec 2019 17:21:47 +0000
Bug 1603772: Cranelift: only return the ret value when it's not used for internal purposes; r=rhunt The return value of a wasm builtin call may just be used to check if the runtime caused an internal error (e.g. oom). There are assertions in code that the return value of wasm builtins not supposed to return a wasm value actually do this, so we shouldn't return values that are only internally used. This could have been done a simpler way by only having "FailureMode::NotZero" imply "do not return", but this is more future-proof like this: shared memory / atomics builtins both check the internal value *and* return it to the wasm value stack. Differential Revision: https://phabricator.services.mozilla.com/D57125
0b2556575c730985732cc1a975cd0da577c4a17d: Bug 1600124 - Don't crash debug builds if we get an empty rectangle passed. r=rhunt
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 16 Dec 2019 00:20:55 +0000 - rev 507038
Push 36921 by nerli@mozilla.com at Mon, 16 Dec 2019 09:50:52 +0000
Bug 1600124 - Don't crash debug builds if we get an empty rectangle passed. r=rhunt Depends on D57052 Differential Revision: https://phabricator.services.mozilla.com/D57053
e9dd453bc70df13a2fde4ec62d631d0eb26cad86: Bug 1601233: Output of mach vendor rust r=rhunt
Benjamin Bouvier <bbouvier@mozilla.com> - Thu, 05 Dec 2019 04:26:50 +0000 - rev 505575
Push 36885 by nbeleuzu@mozilla.com at Thu, 05 Dec 2019 21:53:30 +0000
Bug 1601233: Output of mach vendor rust r=rhunt Differential Revision: https://phabricator.services.mozilla.com/D55791
493c6741ff3e09d1f12c0a835540cfa6dd8d9cb2: Bug 1601233: Bump Cranelift to 497b4e1ca1d33dfd54314366d8e3a27a9fea225f; r=rhunt
Benjamin Bouvier <benj@benj.me> - Thu, 05 Dec 2019 04:26:50 +0000 - rev 505574
Push 36885 by nbeleuzu@mozilla.com at Thu, 05 Dec 2019 21:53:30 +0000
Bug 1601233: Bump Cranelift to 497b4e1ca1d33dfd54314366d8e3a27a9fea225f; r=rhunt Differential Revision: https://phabricator.services.mozilla.com/D55790
827afbfc6f341761ec9cac4590c8b8fe8305f5b7: Bug 1597989: Tweak eager segments bound checks behavior for Cranelift; r=rhunt
Benjamin Bouvier <benj@benj.me> - Tue, 03 Dec 2019 15:31:39 +0000 - rev 505081
Push 36879 by ncsoregi@mozilla.com at Tue, 03 Dec 2019 21:53:45 +0000
Bug 1597989: Tweak eager segments bound checks behavior for Cranelift; r=rhunt The eagerBoundsCheck variable was desynchronized from compiler feature support for bulk memory operations, namely for Cranelift. This manually checks for Cranelift usage, and this will need to be reverted once bulk memory opcodes support land in Cranelift. Differential Revision: https://phabricator.services.mozilla.com/D55683