searching for reviewer(rcaliman)
8c2c3afe6a3d: Bug 1543324 - Part 4: Increase body-color contrast (Light) and apply to fonts.css; r=rcaliman
Florens Verschelde <florens@fvsch.com> - Wed, 17 Apr 2019 14:06:59 +0000 - rev 470134
Push 35888 by aiakab@mozilla.com at Fri, 19 Apr 2019 09:47:45 +0000
Bug 1543324 - Part 4: Increase body-color contrast (Light) and apply to fonts.css; r=rcaliman Differential Revision: https://phabricator.services.mozilla.com/D27109
6fa8c4b075bc: Bug 1543348 - Create generic button background variables; r=rcaliman
Florens Verschelde <florens@fvsch.com> - Thu, 11 Apr 2019 16:23:47 +0000 - rev 469231
Push 35859 by shindli@mozilla.com at Fri, 12 Apr 2019 15:46:45 +0000
Bug 1543348 - Create generic button background variables; r=rcaliman Differential Revision: https://phabricator.services.mozilla.com/D26880
281f1757c40e: Bug 1539989 - Add a background on :hover of font names; r=rcaliman
Patrick Brosset <pbrosset@mozilla.com> - Tue, 02 Apr 2019 14:00:18 +0000 - rev 467593
Push 35804 by rgurzau@mozilla.com at Tue, 02 Apr 2019 21:49:08 +0000
Bug 1539989 - Add a background on :hover of font names; r=rcaliman Depends on D25598 Differential Revision: https://phabricator.services.mozilla.com/D25599
d06d70fe82a5: Bug 1539989 - Change the font highlighter's background color to match other highlighters; r=rcaliman
Patrick Brosset <pbrosset@mozilla.com> - Tue, 02 Apr 2019 13:59:29 +0000 - rev 467592
Push 35804 by rgurzau@mozilla.com at Tue, 02 Apr 2019 21:49:08 +0000
Bug 1539989 - Change the font highlighter's background color to match other highlighters; r=rcaliman Differential Revision: https://phabricator.services.mozilla.com/D25598
564c7f4a53b6: Bug 1531845 - Silence various React warnings to help clear up debug mode test logs r=rcaliman
Michael Ratcliffe <mratcliffe@mozilla.com> - Tue, 19 Mar 2019 15:29:37 +0000 - rev 465042
Push 35730 by rmaries@mozilla.com at Tue, 19 Mar 2019 21:51:47 +0000
Bug 1531845 - Silence various React warnings to help clear up debug mode test logs r=rcaliman Differential Revision: https://phabricator.services.mozilla.com/D23115
8b9c4b28f033: Bug 1533201 - Make cssPropertySupportsType take an enum. r=heycam,rcaliman
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 18 Mar 2019 16:38:48 +0000 - rev 464858
Push 35727 by dvarga@mozilla.com at Tue, 19 Mar 2019 09:48:59 +0000
Bug 1533201 - Make cssPropertySupportsType take an enum. r=heycam,rcaliman Differential Revision: https://phabricator.services.mozilla.com/D22427
70b39f59687c: Bug 1534610 - Switch to React.createRef() in inspector.js to save a few cycles r=rcaliman
Michael Ratcliffe <mratcliffe@mozilla.com> - Wed, 13 Mar 2019 13:55:28 +0000 - rev 463813
Push 35698 by ncsoregi@mozilla.com at Wed, 13 Mar 2019 21:52:48 +0000
Bug 1534610 - Switch to React.createRef() in inspector.js to save a few cycles r=rcaliman Differential Revision: https://phabricator.services.mozilla.com/D23131
f8f1b79cbc42: Bug 1533823 - Element style should refresh on "style-changed" and "pseudoclass" events. r=rcaliman
Gabriel Luong <gabriel.luong@gmail.com> - Fri, 08 Mar 2019 13:40:58 -0500 - rev 463471
Push 35685 by opoprus@mozilla.com at Tue, 12 Mar 2019 04:48:38 +0000
Bug 1533823 - Element style should refresh on "style-changed" and "pseudoclass" events. r=rcaliman Differential Revision: https://phabricator.services.mozilla.com/D22745
2c8674d20ba6: Bug 1527062 - Show a declaration has changed in the new rules view. r=rcaliman
Gabriel Luong <gabriel.luong@gmail.com> - Thu, 28 Feb 2019 14:29:37 -0500 - rev 462105
Push 35635 by rmaries@mozilla.com at Sat, 02 Mar 2019 09:41:56 +0000
Bug 1527062 - Show a declaration has changed in the new rules view. r=rcaliman Differential Revision: https://phabricator.services.mozilla.com/D21589
18bf7cf02118: Bug 1531230 - Stop using the TextPropertyEditor value in the TextProperty model. r=rcaliman
Gabriel Luong <gabriel.luong@gmail.com> - Wed, 27 Feb 2019 23:39:03 -0500 - rev 461744
Push 35628 by opoprus@mozilla.com at Thu, 28 Feb 2019 21:47:53 +0000
Bug 1531230 - Stop using the TextPropertyEditor value in the TextProperty model. r=rcaliman Differential Revision: https://phabricator.services.mozilla.com/D21480
885c75c731bf: Bug 1529847 - Move the Changes Front initialization to the Promise.all. r=rcaliman
Gabriel Luong <gabriel.luong@gmail.com> - Fri, 22 Feb 2019 00:51:44 -0500 - rev 460713
Push 35597 by rmaries@mozilla.com at Sat, 23 Feb 2019 04:15:57 +0000
Bug 1529847 - Move the Changes Front initialization to the Promise.all. r=rcaliman Differential Revision: https://phabricator.services.mozilla.com/D20784
b42cb063ba27: Bug 1529845 - Add a destroy for the MarkupContextMenu. r=rcaliman
Gabriel Luong <gabriel.luong@gmail.com> - Fri, 22 Feb 2019 00:38:30 -0500 - rev 460704
Push 35597 by rmaries@mozilla.com at Sat, 23 Feb 2019 04:15:57 +0000
Bug 1529845 - Add a destroy for the MarkupContextMenu. r=rcaliman Differential Revision: https://phabricator.services.mozilla.com/D20783
567e3f10af99: Bug 1479887 - Use CSS transform instead of relative positioning when centering the infobar; r=rcaliman
Patrick Brosset <pbrosset@mozilla.com> - Thu, 21 Feb 2019 14:30:48 +0000 - rev 460263
Push 35590 by rgurzau@mozilla.com at Fri, 22 Feb 2019 05:26:22 +0000
Bug 1479887 - Use CSS transform instead of relative positioning when centering the infobar; r=rcaliman Differential Revision: https://phabricator.services.mozilla.com/D20659
e92ff56d2be2: Bug 1529364 - Move the markup context menu into a separate module. r=rcaliman
Gabriel Luong <gabriel.luong@gmail.com> - Wed, 20 Feb 2019 15:03:38 -0500 - rev 460252
Push 35589 by rgurzau@mozilla.com at Thu, 21 Feb 2019 21:54:39 +0000
Bug 1529364 - Move the markup context menu into a separate module. r=rcaliman Differential Revision: https://phabricator.services.mozilla.com/D20554
05888c293d3e: Bug 1526591 - Remove devtools.inspector.shapesHighlighter.enabled pref. r=rcaliman
Gabriel Luong <gabriel.luong@gmail.com> - Fri, 08 Feb 2019 22:06:49 -0500 - rev 458538
Push 35537 by btara@mozilla.com at Mon, 11 Feb 2019 21:55:45 +0000
Bug 1526591 - Remove devtools.inspector.shapesHighlighter.enabled pref. r=rcaliman Differential Revision: https://phabricator.services.mozilla.com/D19255
da1dd1b03268: Bug 1526591 - Remove devtools.inspector.shapesHighlighter.enabled pref. r=rcaliman
Gabriel Luong <gabriel.luong@gmail.com> - Fri, 08 Feb 2019 22:06:49 -0500 - rev 458534
Push 35537 by btara@mozilla.com at Mon, 11 Feb 2019 21:55:45 +0000
Bug 1526591 - Remove devtools.inspector.shapesHighlighter.enabled pref. r=rcaliman Differential Revision: https://phabricator.services.mozilla.com/D19255
59175d6c6352: Bug 1523128 - Implement open source link in the new rules view. r=rcaliman
Gabriel Luong <gabriel.luong@gmail.com> - Thu, 07 Feb 2019 00:16:45 -0500 - rev 458432
Push 35529 by rmaries@mozilla.com at Sun, 10 Feb 2019 09:44:33 +0000
Bug 1523128 - Implement open source link in the new rules view. r=rcaliman Differential Revision: https://phabricator.services.mozilla.com/D18919
e354e08d4828: Bug 1524631 - Implement new declaration editor for the new rules view. r=rcaliman
Gabriel Luong <gabriel.luong@gmail.com> - Fri, 01 Feb 2019 15:40:33 -0500 - rev 457301
Push 35505 by csabou@mozilla.com at Tue, 05 Feb 2019 21:59:22 +0000
Bug 1524631 - Implement new declaration editor for the new rules view. r=rcaliman Differential Revision: https://phabricator.services.mozilla.com/D18387
94d34e0a4cbc: Bug 1524097 - Devtools Inspector doesn't show any nodes (besides `<html>`) for LinkedIn pages r=rcaliman
Michael Ratcliffe <mratcliffe@mozilla.com> - Mon, 04 Feb 2019 16:57:10 +0000 - rev 456646
Push 35498 by ccoroiu@mozilla.com at Mon, 04 Feb 2019 21:41:17 +0000
Bug 1524097 - Devtools Inspector doesn't show any nodes (besides `<html>`) for LinkedIn pages r=rcaliman I would have thought that the anonymous node fix would also have fixed this but we have had to manually add the before and after pseudo elements. Differential Revision: https://phabricator.services.mozilla.com/D18536
85f55cb935f6: Bug 1522809 - Nodes with `name="attributes"` break the markup view r=rcaliman
Michael Ratcliffe <mratcliffe@mozilla.com> - Fri, 01 Feb 2019 14:03:44 +0000 - rev 456439
Push 35485 by ncsoregi@mozilla.com at Fri, 01 Feb 2019 22:12:23 +0000
Bug 1522809 - Nodes with `name="attributes"` break the markup view r=rcaliman This is another very specific issue. If you have `<img name="attributes"/>` in the dom then `document.attributes` will return the `<img>` tag. In the source we bail if `!this.rawNode.attributes` but if we are on the document node this returns the image tag. Because the image tag is not a `NamedNodeMap` trying to iterate over the tag throws the error. There is a test file [here](https://bugzilla.mozilla.org/attachment.cgi?id=9040577). Differential Revision: https://phabricator.services.mozilla.com/D18340
e9a2417a0425: Bug 1522273 - Markup view not working on elements containing a 'constructor' attribute r=rcaliman
Michael Ratcliffe <mratcliffe@mozilla.com> - Thu, 31 Jan 2019 15:48:41 +0000 - rev 456278
Push 35478 by shindli@mozilla.com at Fri, 01 Feb 2019 03:55:46 +0000
Bug 1522273 - Markup view not working on elements containing a 'constructor' attribute r=rcaliman `ATTRIBUTE_TYPES` was an object and we used to access it's attributes using e.g. `ATTRIBUTE_TYPES["href"]`, which is fine in almost all cases. The problem occurred when the attribute name was `"constructor"`. This caused us to attempt to parse `ATTRIBUTE_TYPES["constructor"]`, which returned `{}.constructor` therefore breaking the attribute parser. Changing `ATTRIBUTE_TYPES` to a Map fixes the issue because `ATTRIBUTE_TYPES.get("constructor")` returns null rather than an object constructor. Differential Revision: https://phabricator.services.mozilla.com/D18220
22c5f8ae131e: Bug 1524005 - Inspect Element throwing on Anonymous nodes and content missing from Markup view r=rcaliman
Michael Ratcliffe <mratcliffe@mozilla.com> - Thu, 31 Jan 2019 13:00:34 +0000 - rev 456231
Push 35475 by rmaries@mozilla.com at Thu, 31 Jan 2019 16:55:18 +0000
Bug 1524005 - Inspect Element throwing on Anonymous nodes and content missing from Markup view r=rcaliman Differential Revision: https://phabricator.services.mozilla.com/D18106
55e283588f80: Bug 1523724 - Fix the selector dom structure in the new rules view. r=rcaliman
Gabriel Luong <gabriel.luong@gmail.com> - Tue, 29 Jan 2019 16:37:20 -0500 - rev 456012
Push 35466 by shindli@mozilla.com at Wed, 30 Jan 2019 04:11:39 +0000
Bug 1523724 - Fix the selector dom structure in the new rules view. r=rcaliman
09cb1559e2f9: Bug 1522217 - Implement add a new CSS rule in the new rules view. r=rcaliman
Gabriel Luong <gabriel.luong@gmail.com> - Tue, 29 Jan 2019 09:57:02 -0500 - rev 455956
Push 35463 by shindli@mozilla.com at Tue, 29 Jan 2019 21:38:17 +0000
Bug 1522217 - Implement add a new CSS rule in the new rules view. r=rcaliman
f42ed4eb7274: Bug 1513922 - Use -moz-appearance: textfield for the Weight number input r=rcaliman
garvitdelhi <garvitdelhi@gmail.com> - Tue, 29 Jan 2019 15:17:10 +0000 - rev 455910
Push 35462 by shindli@mozilla.com at Tue, 29 Jan 2019 21:36:31 +0000
Bug 1513922 - Use -moz-appearance: textfield for the Weight number input r=rcaliman Differential Revision: https://phabricator.services.mozilla.com/D17802
4778d85691d0: Bug 1523014 - Only render the rules warning and overridden rule filter if necessary. r=rcaliman
Gabriel Luong <gabriel.luong@gmail.com> - Mon, 28 Jan 2019 09:40:03 -0500 - rev 455661
Push 35454 by rmaries@mozilla.com at Mon, 28 Jan 2019 21:47:24 +0000
Bug 1523014 - Only render the rules warning and overridden rule filter if necessary. r=rcaliman
da2d6417cfda: Bug 1521678 - Implement property value editor in the new rules view. r=rcaliman
Gabriel Luong <gabriel.luong@gmail.com> - Thu, 24 Jan 2019 15:33:52 -0500 - rev 455350
Push 35433 by nbeleuzu@mozilla.com at Fri, 25 Jan 2019 04:29:27 +0000
Bug 1521678 - Implement property value editor in the new rules view. r=rcaliman
7f6996c8b32f: Bug 1521712 - Pick on mouseup to allow picking scrollbars; r=rcaliman
Patrick Brosset <pbrosset@mozilla.com> - Wed, 23 Jan 2019 12:17:41 +0000 - rev 455083
Push 35421 by aciure@mozilla.com at Thu, 24 Jan 2019 03:42:51 +0000
Bug 1521712 - Pick on mouseup to allow picking scrollbars; r=rcaliman Differential Revision: https://phabricator.services.mozilla.com/D17234
9da9417d2cb9: Bug 1521674 - Implement property name editor in the new rules view. r=rcaliman
Gabriel Luong <gabriel.luong@gmail.com> - Tue, 22 Jan 2019 22:20:05 -0500 - rev 454958
Push 35420 by archaeopteryx@coole-files.de at Wed, 23 Jan 2019 16:57:04 +0000
Bug 1521674 - Implement property name editor in the new rules view. r=rcaliman
2a721c78e648: Bug 1521013 - Implement selector editing in the new rules view. r=rcaliman
Gabriel Luong <gabriel.luong@gmail.com> - Tue, 22 Jan 2019 16:38:43 -0500 - rev 454857
Push 35418 by archaeopteryx@coole-files.de at Wed, 23 Jan 2019 09:28:26 +0000
Bug 1521013 - Implement selector editing in the new rules view. r=rcaliman
8ae27ed8d861: Bug 1521407 - Avoid rendering the computed property list if it is not necessary. r=rcaliman
Gabriel Luong <gabriel.luong@gmail.com> - Mon, 21 Jan 2019 14:38:00 -0500 - rev 454758
Push 35412 by csabou@mozilla.com at Tue, 22 Jan 2019 03:56:27 +0000
Bug 1521407 - Avoid rendering the computed property list if it is not necessary. r=rcaliman - Avoid rendering the computed property list is not expanded. - Avoid rendering the shorthand overridden computed property list if there is no overridden properties in the computed property list.
55fc0688ea18: Bug 1520389 - Implement the selector highlighter in the new rules view. r=rcaliman
Gabriel Luong <gabriel.luong@gmail.com> - Thu, 17 Jan 2019 10:29:38 -0500 - rev 454321
Push 35393 by ncsoregi@mozilla.com at Thu, 17 Jan 2019 21:55:14 +0000
Bug 1520389 - Implement the selector highlighter in the new rules view. r=rcaliman
83c3a433bd15: Bug 1519988 - Implement toggling on/off of a CSS declaration. r=rcaliman
Gabriel Luong <gabriel.luong@gmail.com> - Wed, 16 Jan 2019 21:05:25 -0500 - rev 454224
Push 35389 by shindli@mozilla.com at Thu, 17 Jan 2019 09:53:19 +0000
Bug 1519988 - Implement toggling on/off of a CSS declaration. r=rcaliman
362ff47b225e: Bug 1519530 - Implement the pseudo class panel functionality. r=rcaliman
Gabriel Luong <gabriel.luong@gmail.com> - Mon, 14 Jan 2019 15:14:03 -0500 - rev 453846
Push 35375 by cbrindusan@mozilla.com at Tue, 15 Jan 2019 04:39:53 +0000
Bug 1519530 - Implement the pseudo class panel functionality. r=rcaliman
1abbb5d43328: Bug 1519716 - Add pseudoElement state to the Rule state. r=rcaliman
Gabriel Luong <gabriel.luong@gmail.com> - Mon, 14 Jan 2019 12:18:53 -0500 - rev 453774
Push 35373 by cbrindusan@mozilla.com at Mon, 14 Jan 2019 21:52:01 +0000
Bug 1519716 - Add pseudoElement state to the Rule state. r=rcaliman
b7e4f51b79a9: Bug 1518850 - Add the computed property list and shorthand overridden list. r=rcaliman
Gabriel Luong <gabriel.luong@gmail.com> - Fri, 11 Jan 2019 14:31:10 -0500 - rev 453606
Push 35361 by nbeleuzu@mozilla.com at Sat, 12 Jan 2019 09:41:19 +0000
Bug 1518850 - Add the computed property list and shorthand overridden list. r=rcaliman
922c3f0e3d8c: Bug 1518618 - Add custom classes to the selectors for matches, attributes and pseudoclasses. r=rcaliman
Gabriel Luong <gabriel.luong@gmail.com> - Fri, 11 Jan 2019 14:11:32 -0500 - rev 453605
Push 35361 by nbeleuzu@mozilla.com at Sat, 12 Jan 2019 09:41:19 +0000
Bug 1518618 - Add custom classes to the selectors for matches, attributes and pseudoclasses. r=rcaliman
90d4b7df4ef5: Bug 1478894 - Part 2: Render the list of rules in the new Rules View. r=pbro, rcaliman
Gabriel Luong <gabriel.luong@gmail.com> - Tue, 08 Jan 2019 15:58:11 -0500 - rev 452980
Push 35337 by rmaries@mozilla.com at Wed, 09 Jan 2019 03:50:08 +0000
Bug 1478894 - Part 2: Render the list of rules in the new Rules View. r=pbro, rcaliman
b15134c683ba: Bug 1509543 - Add missing option parameter comment to devtools/server/actors/styles.js::getComputed() r=rcaliman
Michael Ratcliffe <mratcliffe@mozilla.com> - Mon, 26 Nov 2018 09:41:36 +0000 - rev 447989
Push 35102 by ccoroiu@mozilla.com at Mon, 26 Nov 2018 21:58:00 +0000
Bug 1509543 - Add missing option parameter comment to devtools/server/actors/styles.js::getComputed() r=rcaliman Rasvan, if you could r+ this for me then that would be great. Differential Revision: https://phabricator.services.mozilla.com/D12779
f2f2f8b59557: Bug 1509781 - Check if server supports changes actor to enable Changes panel;r=yulia,rcaliman
Julian Descottes <jdescottes@mozilla.com> - Mon, 26 Nov 2018 13:20:18 +0000 - rev 447970
Push 35100 by ncsoregi@mozilla.com at Mon, 26 Nov 2018 16:16:10 +0000
Bug 1509781 - Check if server supports changes actor to enable Changes panel;r=yulia,rcaliman This will enable connecting to Firefox 63 (and 64? not sure in which release the changes actor was introduced) from Nightly. Pinging yulia for review to check if there is a better way to handle such backward compatible code when using the getFront API. Differential Revision: https://phabricator.services.mozilla.com/D12872
8f05e7f014c8: Bug 1508353 - [Track Changes] Enable track changes for nightly. r=rcaliman
Gabriel Luong <gabriel.luong@gmail.com> - Wed, 21 Nov 2018 12:09:29 -0500 - rev 447593
Push 35082 by ccoroiu@mozilla.com at Wed, 21 Nov 2018 21:44:21 +0000
Bug 1508353 - [Track Changes] Enable track changes for nightly. r=rcaliman
facf21932367: Bug 1503902 - Avoid resizing RDM when restoring the device state and simply use the stored pref width and height. r=rcaliman
Gabriel Luong <gabriel.luong@gmail.com> - Thu, 15 Nov 2018 12:59:49 -0500 - rev 446606
Push 35045 by ncsoregi@mozilla.com at Thu, 15 Nov 2018 22:10:12 +0000
Bug 1503902 - Avoid resizing RDM when restoring the device state and simply use the stored pref width and height. r=rcaliman
969a48cb4f17: Bug 1503902 - RDM should restore the previous state when reopening after rotating the viewport. r=rcaliman
Gabriel Luong <gabriel.luong@gmail.com> - Wed, 07 Nov 2018 12:09:05 -0500 - rev 445020
Push 35006 by aiakab@mozilla.com at Wed, 07 Nov 2018 21:51:52 +0000
Bug 1503902 - RDM should restore the previous state when reopening after rotating the viewport. r=rcaliman
93012cb45617: Bug 1500933 Part 2: Avoid sending events from ChangesActor until we've verified there's a listener. r=rcaliman
Brad Werth <bwerth@mozilla.com> - Wed, 31 Oct 2018 17:22:27 +0000 - rev 443783
Push 34969 by cbrindusan@mozilla.com at Wed, 31 Oct 2018 21:39:53 +0000
Bug 1500933 Part 2: Avoid sending events from ChangesActor until we've verified there's a listener. r=rcaliman Depends on D10119 Differential Revision: https://phabricator.services.mozilla.com/D10120
8d9adc3af751: Bug 1500933 Part 1: Define a ChangesActor no-op method for use by the client to instantiate the actor. r=rcaliman
Brad Werth <bwerth@mozilla.com> - Wed, 31 Oct 2018 17:49:22 +0000 - rev 443782
Push 34969 by cbrindusan@mozilla.com at Wed, 31 Oct 2018 21:39:53 +0000
Bug 1500933 Part 1: Define a ChangesActor no-op method for use by the client to instantiate the actor. r=rcaliman Differential Revision: https://phabricator.services.mozilla.com/D10119
194a4baf87a5: Bug 1468754 Part 5: Make ChangesView respond to change events. r=rcaliman
Brad Werth <bwerth@mozilla.com> - Mon, 22 Oct 2018 19:18:15 +0000 - rev 442454
Push 34907 by ebalazs@mozilla.com at Tue, 23 Oct 2018 09:23:56 +0000
Bug 1468754 Part 5: Make ChangesView respond to change events. r=rcaliman Depends on D9176 Differential Revision: https://phabricator.services.mozilla.com/D9178
67f969f5bdba: Bug 1468754 Part 5: Make ChangesView respond to change events. r=rcaliman
Brad Werth <bwerth@mozilla.com> - Mon, 22 Oct 2018 18:01:41 +0000 - rev 442443
Push 34907 by ebalazs@mozilla.com at Tue, 23 Oct 2018 09:23:56 +0000
Bug 1468754 Part 5: Make ChangesView respond to change events. r=rcaliman Depends on D9176 Differential Revision: https://phabricator.services.mozilla.com/D9178
c36e8383aa3a: Bug 1468754 Part 5: Make ChangesView respond to change events. r=rcaliman
Brad Werth <bwerth@mozilla.com> - Mon, 22 Oct 2018 16:31:42 +0000 - rev 442420
Push 34907 by ebalazs@mozilla.com at Tue, 23 Oct 2018 09:23:56 +0000
Bug 1468754 Part 5: Make ChangesView respond to change events. r=rcaliman Depends on D9176 Differential Revision: https://phabricator.services.mozilla.com/D9178
0927741e9110: Bug 1497178 - Hide the flex outline for 0-sized items; r=rcaliman
Patrick Brosset <pbrosset@mozilla.com> - Fri, 19 Oct 2018 10:01:21 +0000 - rev 442119
Push 34890 by dvarga@mozilla.com at Sat, 20 Oct 2018 09:40:11 +0000
Bug 1497178 - Hide the flex outline for 0-sized items; r=rcaliman Differential Revision: https://phabricator.services.mozilla.com/D8969
bfb92e2d55e4: Bug 1499322 - Support pseudo elements in the flexbox inspector; r=rcaliman
Patrick Brosset <pbrosset@mozilla.com> - Wed, 17 Oct 2018 14:24:57 +0000 - rev 441675
Push 34873 by dluca@mozilla.com at Wed, 17 Oct 2018 22:54:14 +0000
Bug 1499322 - Support pseudo elements in the flexbox inspector; r=rcaliman On the server, when looking for a flex container for a node, we were bailing out if the displayType of the node was null. It was null for pseudo-elements. This value was returned by the displayType getter in the NodeActor class. Now, the reason for this dates to 4 years ago in bug 1139937 where trying to get the display style of a pseudo-element was done in a way to failed. So we just decided to return null at that point. It doesn't fail anymore, we're able to return, say, "block" if a pseudo-element has a display:block style. So I've removed the checks that returned null and that fixed the issue here. The other part of the fix that was need is in the FlexItemActor class on the server too. This class can be created for a pseudo-element too. It accesses element.style without checking if that property exists. However it does not exist for pseudo-elements. So we needed to add a check for that. It's not a problem to just skip it in this case because pseudo-elements can't have inline styles. Differential Revision: https://phabricator.services.mozilla.com/D8873