searching for reviewer(peterv)
1bec5b571ed1d86f15386e0fedb187319e199d4a: Bug 1121623 part 10. Use a more-accurate default value for 'concrete' in Web IDL bindings. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 24 May 2019 10:43:37 +0000 - rev 475392
Push 36060 by cbrindusan@mozilla.com at Fri, 24 May 2019 21:47:21 +0000
Bug 1121623 part 10. Use a more-accurate default value for 'concrete' in Web IDL bindings. r=peterv The idea is that we should only generate concreate-binding (wrap methods, etc) machinery for an interface by default if we have reason to expect that the interface is used as the primary interface for some objects. Two clear signals that would indicate that are the interface being a leaf interface (with no descendants) and the interface having a constructor. Other cases would require a 'concrete' annotation in Bindings.conf. Differential Revision: https://phabricator.services.mozilla.com/D32208
99d7cbadce926aad011bc60980eadb87bfa11f81: Bug 1121623 part 9. Change example codegen to not spit out WrapObject bits for non-concrete interfaces. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 24 May 2019 07:34:33 +0000 - rev 475391
Push 36060 by cbrindusan@mozilla.com at Fri, 24 May 2019 21:47:21 +0000
Bug 1121623 part 9. Change example codegen to not spit out WrapObject bits for non-concrete interfaces. r=peterv This should keep people from marking things concrete unnecessarily just so their example-generated WrapObject works. Differential Revision: https://phabricator.services.mozilla.com/D32207
b5e4781f21b39dc662549e551580300537b3460f: Bug 1121623 part 7. Remove AuthenticatorResponse::WrapObject. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 24 May 2019 07:23:54 +0000 - rev 475389
Push 36060 by cbrindusan@mozilla.com at Fri, 24 May 2019 21:47:21 +0000
Bug 1121623 part 7. Remove AuthenticatorResponse::WrapObject. r=peterv It's dead code because we never create AuthenticatorResponse objects directly, and all subclasses override WrapObject. Differential Revision: https://phabricator.services.mozilla.com/D32205
1e7a53dbff7b0a55633a7b57c4229259f47cd492: Bug 1121623 part 5. Remove PerformanceEntry::WrapObject. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 24 May 2019 07:23:47 +0000 - rev 475387
Push 36060 by cbrindusan@mozilla.com at Fri, 24 May 2019 21:47:21 +0000
Bug 1121623 part 5. Remove PerformanceEntry::WrapObject. r=peterv It's dead code, because we never create PerformanceEntry objects directly and subclasses override WrapObject. Differential Revision: https://phabricator.services.mozilla.com/D32203
8e672b4e0a3e3ed151a91abbca41cebf2692dd4f: Bug 1121623 part 3. Switch WebrtcGlobalInformation to being a namespace. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 24 May 2019 07:22:22 +0000 - rev 475385
Push 36060 by cbrindusan@mozilla.com at Fri, 24 May 2019 21:47:21 +0000
Bug 1121623 part 3. Switch WebrtcGlobalInformation to being a namespace. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D32201
5d10803def3ee7f35ee69f4a67870e7f9885e79a: Bug 1121623 part 2. Switch AddonManagerPermissions to being a namespace. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 24 May 2019 07:19:58 +0000 - rev 475384
Push 36060 by cbrindusan@mozilla.com at Fri, 24 May 2019 21:47:21 +0000
Bug 1121623 part 2. Switch AddonManagerPermissions to being a namespace. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D32200
08973de3de9ec12109ad5101d24f79ff710b6da8: Bug 1121623 part 1. Switch PromiseDebugging to being a namespace, since that's how we use it. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 24 May 2019 07:13:16 +0000 - rev 475383
Push 36060 by cbrindusan@mozilla.com at Fri, 24 May 2019 21:47:21 +0000
Bug 1121623 part 1. Switch PromiseDebugging to being a namespace, since that's how we use it. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D32199
bc517e65f14efda9a149410692057c1500dcb0e1: Bug 1549973 - Force tabState flush from C++ listener before tab is closed r=peterv
Alphan Chen <alchen@mozilla.com> - Wed, 22 May 2019 09:06:14 +0000 - rev 474893
Push 36050 by shindli@mozilla.com at Wed, 22 May 2019 15:25:01 +0000
Bug 1549973 - Force tabState flush from C++ listener before tab is closed r=peterv Differential Revision: https://phabricator.services.mozilla.com/D30475
bf656a3314e93271eaa946c029648ba70aba1460: Bug 1546887 - If requesting window.closed during teardown, return true instead of throwing. r=peterv
Mike Conley <mconley@mozilla.com> - Thu, 16 May 2019 12:34:57 +0000 - rev 474057
Push 36022 by ncsoregi@mozilla.com at Thu, 16 May 2019 21:55:16 +0000
Bug 1546887 - If requesting window.closed during teardown, return true instead of throwing. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D30435
7d2d7b47ec349aa71ab0a49a18cfced4b92b7189: Bug 1551335 - Update comment on RemoteOuterWindowProxy. r=peterv
Andrew McCreight <continuation@gmail.com> - Tue, 14 May 2019 09:13:20 +0000 - rev 473788
Push 36015 by cbrindusan@mozilla.com at Tue, 14 May 2019 21:40:04 +0000
Bug 1551335 - Update comment on RemoteOuterWindowProxy. r=peterv The second patch in bug 1518202 made it so that the reference to the browsing context is declared to the cycle collector after all. Differential Revision: https://phabricator.services.mozilla.com/D31001
b0c2270a44f33555ee54c4708f4b35a039375696: Bug 1550928 part 2. Stop using [array] in nsIPluginHost. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 14 May 2019 09:11:45 +0000 - rev 473759
Push 36013 by csabou@mozilla.com at Tue, 14 May 2019 16:01:08 +0000
Bug 1550928 part 2. Stop using [array] in nsIPluginHost. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D30767
aa417164d4c7beb948c37df4b6d57986548a00ca: Bug 1550928 part 1. Stop using [array] in nsIPluginTag. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 14 May 2019 09:11:37 +0000 - rev 473758
Push 36013 by csabou@mozilla.com at Tue, 14 May 2019 16:01:08 +0000
Bug 1550928 part 1. Stop using [array] in nsIPluginTag. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D30766
3288c43195a26565edec3d59a8f8bce6018be592: Bug 1474130 - Implement ScrollPosition/Privacy/DocCapability listeners in C++ r=peterv
Alphan Chen <alchen@mozilla.com> - Sat, 04 May 2019 10:42:52 +0000 - rev 472766
Push 35978 by shindli@mozilla.com at Tue, 07 May 2019 09:44:39 +0000
Bug 1474130 - Implement ScrollPosition/Privacy/DocCapability listeners in C++ r=peterv Differential Revision: https://phabricator.services.mozilla.com/D23057
03166449953fbcaaf6c66d2c3b358319781a0e52: Bug 1539759 - improve DTD entity handling, r=peterv
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 03 May 2019 09:13:58 +0000 - rev 472442
Push 35956 by dluca@mozilla.com at Fri, 03 May 2019 12:59:14 +0000
Bug 1539759 - improve DTD entity handling, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D27904
4c6e2e3f23f9adc7c89e8c500a14ec9cd9f074bd: Bug 1539759 - improve DTD entity handling, r=peterv
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 02 May 2019 09:22:10 +0000 - rev 472246
Push 35951 by cbrindusan@mozilla.com at Thu, 02 May 2019 15:30:19 +0000
Bug 1539759 - improve DTD entity handling, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D27904
5f451bcec20508390823a0a3244ff7301fdafa6e: Bug 1539759 - improve DTD entity handling, r=peterv
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 02 May 2019 08:19:08 +0000 - rev 472239
Push 35951 by cbrindusan@mozilla.com at Thu, 02 May 2019 15:30:19 +0000
Bug 1539759 - improve DTD entity handling, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D27904
11b4d70a2b5d6373f5ec8fa01ca48a1c7bc1829e: Bug 1547911 - Only restore non-empty browsing context children. r=peterv
Andreas Farre <farre@mozilla.com> - Tue, 30 Apr 2019 16:11:03 +0000 - rev 471981
Push 35944 by ccoroiu@mozilla.com at Tue, 30 Apr 2019 21:53:37 +0000
Bug 1547911 - Only restore non-empty browsing context children. r=peterv Also, make sure to evict the right browsing contexts from the cache. Differential Revision: https://phabricator.services.mozilla.com/D29349
3073770e06f157040f4c64951b7e8425e1ad7bbe: Bug 1535403 - Take indirection into account for the CC optimizations for the outer window wrapper. r=peterv
Andrew McCreight <continuation@gmail.com> - Mon, 22 Apr 2019 16:34:51 +0000 - rev 470366
Push 35903 by opoprus@mozilla.com at Mon, 22 Apr 2019 21:46:44 +0000
Bug 1535403 - Take indirection into account for the CC optimizations for the outer window wrapper. r=peterv Most wrapper cached C++ objects are held alive by their wrapper. The cycle collector takes advantage of this in many classes and ignores the C++ object if the wrapper is marked black. However, this is not true for the outer window's wrapper. Instead, the outer window's wrapper keeps the inner window alive. The inner window usually keeps its outer window alive, but not after it has been unlinked. For reasons I do not yet understand, the outer window's wrapper can be kept alive after the inner window it is a proxy for is unlinked. This patch fixes the cycle collector optimization for the outer window by only applying it if the outer window still has a weak reference to the inner window, which it will until the inner no longer holds the outer alive. This in turn fixes, or at least helps fix, window leaks seen intermittently when the lifetime of outer windows and docshells are tied together. The code comment is based on a review comment by peterv. Differential Revision: https://phabricator.services.mozilla.com/D27981
607e1bc95c9bd82cbf4dc5426cfa66147f1d9458: Bug 1542790 - Part 2: Use BC::GetParent and BC::GetTop for local windows, r=peterv
Nika Layzell <nika@thelayzells.com> - Wed, 17 Apr 2019 00:53:09 +0000 - rev 469827
Push 35883 by btara@mozilla.com at Wed, 17 Apr 2019 21:47:29 +0000
Bug 1542790 - Part 2: Use BC::GetParent and BC::GetTop for local windows, r=peterv This is required to support getting the `parent` and `top` properties from within remote subframes. Differential Revision: https://phabricator.services.mozilla.com/D26559
5fde2cc9277a3d4bb73d859ba571c84fdc2ead9b: Bug 1542790 - Part 1: BC::GetParent on toplevel windows should be self, r=peterv
Nika Layzell <nika@thelayzells.com> - Wed, 17 Apr 2019 00:53:05 +0000 - rev 469826
Push 35883 by btara@mozilla.com at Wed, 17 Apr 2019 21:47:29 +0000
Bug 1542790 - Part 1: BC::GetParent on toplevel windows should be self, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D26558
ca2c4053e33c353f361daa7036ebf7a9a960c50a: Bug 1542787 - Support getting contentWindow on out-of-process frames, r=peterv
Nika Layzell <nika@thelayzells.com> - Thu, 11 Apr 2019 18:56:48 +0000 - rev 469521
Push 35873 by ccoroiu@mozilla.com at Mon, 15 Apr 2019 21:36:26 +0000
Bug 1542787 - Support getting contentWindow on out-of-process frames, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D26556
0b0a39e79b6e4c96aede5823b97ceb9b66e8e010: Bug 1539694 - Part 3: Update xray tests for Promise. r=peterv
André Bargull <andre.bargull@gmail.com> - Thu, 11 Apr 2019 21:07:00 +0000 - rev 469095
Push 35856 by csabou@mozilla.com at Fri, 12 Apr 2019 03:19:48 +0000
Bug 1539694 - Part 3: Update xray tests for Promise. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D26144
b69cb7f4f3059c56434b82641db3ae813e7f9036: Bug 1539694 - Part 3: Update xray tests for Promise. r=peterv
André Bargull <andre.bargull@gmail.com> - Wed, 10 Apr 2019 10:29:49 +0000 - rev 469064
Push 35856 by csabou@mozilla.com at Fri, 12 Apr 2019 03:19:48 +0000
Bug 1539694 - Part 3: Update xray tests for Promise. r=peterv Depends on D25209 Differential Revision: https://phabricator.services.mozilla.com/D26144
e251a566abb693ee0f12419bf52b39fe4df7a7f3: bug 1524359 - 49,600 instances of "NS_ENSURE_SUCCESS(rv, false) failed with result 0x80004005" emitted from docshell/shistory/nsSHistory.cpp during linux64 debug testing r=peterv
Khyati Agarwal <f20160385@hyderabad.bits-pilani.ac.in> - Thu, 11 Apr 2019 12:11:05 +0000 - rev 468995
Push 35856 by csabou@mozilla.com at Fri, 12 Apr 2019 03:19:48 +0000
bug 1524359 - 49,600 instances of "NS_ENSURE_SUCCESS(rv, false) failed with result 0x80004005" emitted from docshell/shistory/nsSHistory.cpp during linux64 debug testing r=peterv Replaced "NS_ENSURE_SUCCESS" with 'if' condition Differential Revision: https://phabricator.services.mozilla.com/D25529
e93e17bb399ae84a0f80ab7e3974cd0495d13cdf: Bug 1543461. Add the missing newline after a static assert in Web IDL codegen. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 10 Apr 2019 19:05:15 +0000 - rev 468903
Push 35854 by aciure@mozilla.com at Thu, 11 Apr 2019 09:50:57 +0000
Bug 1543461. Add the missing newline after a static assert in Web IDL codegen. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D26960
65f7904484c803a15084966557ca68bb0856a0f1: Bug 1507004, get the contentDocument for all iframes, to ensure that the iframe is focusable, r=peterv
Neil Deakin <neil@mozilla.com> - Mon, 01 Apr 2019 09:09:04 -0400 - rev 467098
Push 35796 by csabou@mozilla.com at Mon, 01 Apr 2019 21:56:51 +0000
Bug 1507004, get the contentDocument for all iframes, to ensure that the iframe is focusable, r=peterv
95f9efbbf8051d65db8e0c77aa3eda4893786a12: Bug 1533413 - Add Symbol.matchAll to list of expected RegExp methods. r=peterv
Jason Orendorff <jorendorff@mozilla.com> - Mon, 11 Mar 2019 10:20:38 +0000 - rev 463441
Push 35682 by rgurzau@mozilla.com at Mon, 11 Mar 2019 16:49:48 +0000
Bug 1533413 - Add Symbol.matchAll to list of expected RegExp methods. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D22583
60142f1fcb4c417e648e11875b4ada3720d5a2e8: Bug 1527277 - Part 4: Add crashtest. r=peterv
Eric Rahm <erahm@mozilla.com> - Wed, 06 Mar 2019 18:54:27 +0000 - rev 462674
Push 35657 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:32:57 +0000
Bug 1527277 - Part 4: Add crashtest. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D20581
b4fef176bc8fde4e580823740639f51c6e43c58f: Bug 1527277 - Part 3: Validate usage of string iterator. r=peterv
Eric Rahm <erahm@mozilla.com> - Wed, 06 Mar 2019 18:55:54 +0000 - rev 462673
Push 35657 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:32:57 +0000
Bug 1527277 - Part 3: Validate usage of string iterator. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D20580
7ce2309548dab8af0285f3224cb344640089f59b: Bug 1527277 - Part 2: Use unique pointer to manage buffer lifetime. r=peterv
Eric Rahm <erahm@mozilla.com> - Thu, 21 Feb 2019 23:06:04 +0000 - rev 462672
Push 35657 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:32:57 +0000
Bug 1527277 - Part 2: Use unique pointer to manage buffer lifetime. r=peterv Switch to managing the buffer lifetime with a UniquePtr. This will make handling errors simpler in the next patch. Differential Revision: https://phabricator.services.mozilla.com/D20579
62aba7d6d779e6a5e3a088b94ea0df7eef2d92bd: Bug 1527277 - Part 1: Refactor error reporting logic. r=peterv
Eric Rahm <erahm@mozilla.com> - Thu, 21 Feb 2019 23:07:05 +0000 - rev 462671
Push 35657 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:32:57 +0000
Bug 1527277 - Part 1: Refactor error reporting logic. r=peterv Add a common function for reporting an invalid argument. Differential Revision: https://phabricator.services.mozilla.com/D20578
d7d6b249119a5c8a8b179407f801152f09acb0b3: Bug 1497147 - Rewrite "mapFrameTree" implementation to C++ r=peterv
Alphan Chen <alchen@mozilla.com> - Thu, 28 Feb 2019 13:09:54 +0000 - rev 461726
Push 35627 by opoprus@mozilla.com at Thu, 28 Feb 2019 21:44:07 +0000
Bug 1497147 - Rewrite "mapFrameTree" implementation to C++ r=peterv Get rid of mapFrameTree() implementation Differential Revision: https://phabricator.services.mozilla.com/D17149
fcf3d5468b1f1838504b2b75f856f2beff73fab7: Bug 1525101 - adjust nsIFormFillController to make custom elements popup working, r=peterv
Alexander Surkov <surkov.alexander@gmail.com> - Mon, 25 Feb 2019 20:02:35 +0000 - rev 460968
Push 35613 by nerli@mozilla.com at Tue, 26 Feb 2019 03:52:35 +0000
Bug 1525101 - adjust nsIFormFillController to make custom elements popup working, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D20505
bea571f9708b466869f9032e2faedac64e62f05b: Bug 1525101 - adjust nsIAutoCompletePopup to make custom element popups working, r=peterv
Alexander Surkov <surkov.alexander@gmail.com> - Mon, 25 Feb 2019 20:02:17 +0000 - rev 460967
Push 35613 by nerli@mozilla.com at Tue, 26 Feb 2019 03:52:35 +0000
Bug 1525101 - adjust nsIAutoCompletePopup to make custom element popups working, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D20504
996e8765c85a16605c098144e8e95f97e89b70ea: Bug 1515646 - Test BrowsingContext::FindWithName. r=peterv
Andreas Farre <farre@mozilla.com> - Fri, 15 Feb 2019 11:17:50 +0000 - rev 459410
Push 35561 by csabou@mozilla.com at Fri, 15 Feb 2019 18:37:54 +0000
Bug 1515646 - Test BrowsingContext::FindWithName. r=peterv Test that BrowsingContext::FindWithName finds the expected BrowsingContexts and also that BrowsingContext::FindWithName finds the same browsing contexts as if nsIDocShellTreeItem::FindItemWithName had been used. Differential Revision: https://phabricator.services.mozilla.com/D15191
9243ddacadcca22365599b018d279a026cc51b8c: Bug 1515646 - Add FindWithName and FindChildWithName to BrowsingContext. r=peterv
Andreas Farre <farre@mozilla.com> - Fri, 15 Feb 2019 09:59:21 +0000 - rev 459407
Push 35561 by csabou@mozilla.com at Fri, 15 Feb 2019 18:37:54 +0000
Bug 1515646 - Add FindWithName and FindChildWithName to BrowsingContext. r=peterv This implements the step of choosing a browsing context with FindWithName, which should be equivalent to calling nsIDocShellTreeItem.findItemWithName passing null for 'aRequestor' and 'aOriginalRequestor' and false for 'aSkipTabGroup'. Differential Revision: https://phabricator.services.mozilla.com/D15190
3dd87564278ec6eeebab2ebf633b92a21d58c113: Bug 1525145, remove harmless assertions by using IgnoredErrorResult, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Wed, 13 Feb 2019 22:51:10 +0200 - rev 458981
Push 35553 by shindli@mozilla.com at Thu, 14 Feb 2019 04:41:18 +0000
Bug 1525145, remove harmless assertions by using IgnoredErrorResult, r=peterv
100d9de169abb02adbdef29a056ea3ce45a74d95: Bug 1525673. Don't assume that same-compartment means same-realm in WrapNewBindingNonWrapperCache. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 11 Feb 2019 13:33:23 +0000 - rev 458478
Push 35536 by btara@mozilla.com at Mon, 11 Feb 2019 21:54:04 +0000
Bug 1525673. Don't assume that same-compartment means same-realm in WrapNewBindingNonWrapperCache. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D18863
57664c81a1de82de2e2dc34a9a2806fccf2cc5c0: Bug 1516642 - Add a function declaration for arc4random_buf in expat. r=peterv
Mike Hommey <mh+mozilla@glandium.org> - Fri, 08 Feb 2019 13:48:36 +0000 - rev 458384
Push 35526 by dvarga@mozilla.com at Sat, 09 Feb 2019 21:44:33 +0000
Bug 1516642 - Add a function declaration for arc4random_buf in expat. r=peterv The function has been in bionic (Android's libc since the first commit in the upstream repository), but it's not been in stdlib.h until recently. As it happens, we have a similar declaration in xpcom/base/nsUUIDGenerator.cpp. Differential Revision: https://phabricator.services.mozilla.com/D19120
b7646b8ccfd38b1ef1b61d3170d3223b05628b80: Bug 1525355. Make sure to clear out the cached-function-map slot on WindowProxy before we transplant it. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 06 Feb 2019 13:01:27 +0000 - rev 457419
Push 35510 by rgurzau@mozilla.com at Wed, 06 Feb 2019 21:55:51 +0000
Bug 1525355. Make sure to clear out the cached-function-map slot on WindowProxy before we transplant it. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D18725
4d21e1285e2a334414eb1d45446fdea9c4922072: Bug 1514098 - Don't call into UA Widget distructor if the element is being CC'd r=peterv,bgrins
Timothy Guan-tin Chien <timdream@gmail.com> - Mon, 04 Feb 2019 13:56:22 +0000 - rev 456755
Push 35504 by csabou@mozilla.com at Tue, 05 Feb 2019 21:57:12 +0000
Bug 1514098 - Don't call into UA Widget distructor if the element is being CC'd r=peterv,bgrins Differential Revision: https://phabricator.services.mozilla.com/D18130
f39008382451ae45616ff3263421c2affc716cbc: Bug 1521907 part 6. Start using CheckedUnwrapStatic/Dynamic in toolkit. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Sat, 02 Feb 2019 03:25:07 +0000 - rev 456513
Push 35487 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:42:37 +0000
Bug 1521907 part 6. Start using CheckedUnwrapStatic/Dynamic in toolkit. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D17886
a0b9977daa361c63bae40a7caf6dbfd2130558fa: Bug 1521907 part 5. Start using CheckedUnwrapStatic/Dynamic in XPConnect. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Sat, 02 Feb 2019 03:24:45 +0000 - rev 456512
Push 35487 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:42:37 +0000
Bug 1521907 part 5. Start using CheckedUnwrapStatic/Dynamic in XPConnect. r=peterv I am not a huge fan of the UnwrapReflectorToISupports setup here. Maybe we should introduce two differently-named methods that make it somewhat clear what the limitations of not taking a JSContext are? I couldn't think of sane naming... Differential Revision: https://phabricator.services.mozilla.com/D17885
f41215bdded6614b78f6b371a23f842a07c20bfa: Bug 1521907 part 4. Start using CheckedUnwrapStatic/Dynamic in non-binding DOM code. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Sat, 02 Feb 2019 03:24:22 +0000 - rev 456511
Push 35487 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:42:37 +0000
Bug 1521907 part 4. Start using CheckedUnwrapStatic/Dynamic in non-binding DOM code. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D17884
64af12d24e9defd3823252921ea0d51cbf2bfef1: Bug 1521907 part 3. Start using CheckedUnwrapStatic/Dynamic in bindings. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Sat, 02 Feb 2019 03:23:49 +0000 - rev 456510
Push 35487 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:42:37 +0000
Bug 1521907 part 3. Start using CheckedUnwrapStatic/Dynamic in bindings. r=peterv The basic idea for the changes around UnwrapObjectInternal and its callers (UnwrapObject, UNWRAP_OBJECT, etc) is to add a parameter to the guts of the object-unwrapping code in bindings which can be either a JSContext* or nullptr (statically typed). Then we test which type it is and do either a CheckedUnwrapDynamic or CheckedUnwrapStatic. Since the type is known at compile time, there is no actual runtime check; the compiler just emits a call to the right thing directly (verified by examining the assembly output on Linux). The rest of the changes are mostly propagating through that template parameter, adding static asserts to make sure people don't accidentally pass nullptr while trying to unwrap to a type that might be a WindowProxy or Location, etc. There are also some changes to places that were calling CheckedUnwrap directly to use either the static or dynamic version, as needed. Differential Revision: https://phabricator.services.mozilla.com/D17883
46854f5097bbe5c3ab485667753d3e368f152193: Bug 1521907 part 2. Add dynamic CheckedUnwrap support to CrossOriginObjectWrapper. r=peterv,sfink
Boris Zbarsky <bzbarsky@mit.edu> - Sat, 02 Feb 2019 03:23:16 +0000 - rev 456509
Push 35487 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:42:37 +0000
Bug 1521907 part 2. Add dynamic CheckedUnwrap support to CrossOriginObjectWrapper. r=peterv,sfink This will allow us to correctly handle CheckedUnwrapDynamic on wrappers around WindowProxy and Location. Differential Revision: https://phabricator.services.mozilla.com/D17882
ac1c61bf61e990ea7100932636a096a1d09a049f: Bug 1521907 part 6. Start using CheckedUnwrapStatic/Dynamic in toolkit. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 01 Feb 2019 18:49:45 +0000 - rev 456488
Push 35487 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:42:37 +0000
Bug 1521907 part 6. Start using CheckedUnwrapStatic/Dynamic in toolkit. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D17886
df09b7be63c5a642faf52ec29ff5da15d5ae4b04: Bug 1521907 part 5. Start using CheckedUnwrapStatic/Dynamic in XPConnect. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 01 Feb 2019 18:49:04 +0000 - rev 456487
Push 35487 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:42:37 +0000
Bug 1521907 part 5. Start using CheckedUnwrapStatic/Dynamic in XPConnect. r=peterv I am not a huge fan of the UnwrapReflectorToISupports setup here. Maybe we should introduce two differently-named methods that make it somewhat clear what the limitations of not taking a JSContext are? I couldn't think of sane naming... Differential Revision: https://phabricator.services.mozilla.com/D17885
585fa0024d46a6ee33266c11bbe07a40be1be470: Bug 1521907 part 4. Start using CheckedUnwrapStatic/Dynamic in non-binding DOM code. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 01 Feb 2019 18:48:36 +0000 - rev 456486
Push 35487 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:42:37 +0000
Bug 1521907 part 4. Start using CheckedUnwrapStatic/Dynamic in non-binding DOM code. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D17884
e593c29aaff4ef032f7c8ede910dd8331d8c9a40: Bug 1521907 part 3. Start using CheckedUnwrapStatic/Dynamic in bindings. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 01 Feb 2019 18:48:13 +0000 - rev 456485
Push 35487 by dvarga@mozilla.com at Sat, 02 Feb 2019 09:42:37 +0000
Bug 1521907 part 3. Start using CheckedUnwrapStatic/Dynamic in bindings. r=peterv The basic idea for the changes around UnwrapObjectInternal and its callers (UnwrapObject, UNWRAP_OBJECT, etc) is to add a parameter to the guts of the object-unwrapping code in bindings which can be either a JSContext* or nullptr (statically typed). Then we test which type it is and do either a CheckedUnwrapDynamic or CheckedUnwrapStatic. Since the type is known at compile time, there is no actual runtime check; the compiler just emits a call to the right thing directly (verified by examining the assembly output on Linux). The rest of the changes are mostly propagating through that template parameter, adding static asserts to make sure people don't accidentally pass nullptr while trying to unwrap to a type that might be a WindowProxy or Location, etc. There are also some changes to places that were calling CheckedUnwrap directly to use either the static or dynamic version, as needed. Differential Revision: https://phabricator.services.mozilla.com/D17883