searching for reviewer(peterv)
2b13a09333e7: Bug 1502704, overlay scrollbars don't fade out properly as no QI to nsStyledElement is available r=peterv
Neil Deakin <neil@mozilla.com> - Mon, 29 Oct 2018 07:00:00 +0200 - rev 446935
Push 35059 by cbrindusan@mozilla.com at Sun, 18 Nov 2018 11:17:46 +0000
Bug 1502704, overlay scrollbars don't fade out properly as no QI to nsStyledElement is available r=peterv
2c428c8fc568: Bug 1496722 - Make nsIDocShellTreeItem.itemType readonly. r=peterv
Andreas Farre <farre@mozilla.com> - Thu, 08 Nov 2018 21:58:58 +0000 - rev 445235
Push 35012 by btara@mozilla.com at Fri, 09 Nov 2018 05:26:19 +0000
Bug 1496722 - Make nsIDocShellTreeItem.itemType readonly. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D7900
9daebaa1526d: Bug 1501138 - Make sure that timeout iterator advances. r=peterv
Andreas Farre <farre@mozilla.com> - Thu, 08 Nov 2018 17:10:59 +0000 - rev 445172
Push 35012 by btara@mozilla.com at Fri, 09 Nov 2018 05:26:19 +0000
Bug 1501138 - Make sure that timeout iterator advances. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D11327
071d5917ee35: Bug 1504989 - Add ifdef for nightly only function. r=peterv
Andreas Farre <farre@mozilla.com> - Tue, 06 Nov 2018 19:35:25 +0000 - rev 444706
Push 35001 by ncsoregi@mozilla.com at Wed, 07 Nov 2018 09:52:11 +0000
Bug 1504989 - Add ifdef for nightly only function. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D11045
5da3c0dad67a: Bug 1480198 - Construct nsDocShell objects inside BrowsingContext. r=peterv
Andreas Farre <farre@mozilla.com> - Mon, 05 Nov 2018 12:43:10 +0000 - rev 444411
Push 34995 by nbeleuzu@mozilla.com at Mon, 05 Nov 2018 21:51:47 +0000
Bug 1480198 - Construct nsDocShell objects inside BrowsingContext. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D7400
ec8ecded5823: Bug 1500200 - Add non-default implementations of various ways to construct NonRefcountedDOMObject r=peterv
Andrew McCreight <continuation@gmail.com> - Wed, 31 Oct 2018 10:45:15 +0000 - rev 443763
Push 34969 by cbrindusan@mozilla.com at Wed, 31 Oct 2018 21:39:53 +0000
Bug 1500200 - Add non-default implementations of various ways to construct NonRefcountedDOMObject r=peterv The Rule of Three means that a class with a non-default dtor should also have a non-default copy constructor and copy assignment operator. If the default versions of any of these constructors are used, then you end up with negative leaks. Differential Revision: https://phabricator.services.mozilla.com/D9305
5cdef82c0fb0: Bug 1500869 - Test that BrowsingContexts work with BFCache. r=peterv
Andreas Farre <farre@mozilla.com> - Tue, 30 Oct 2018 09:58:47 +0000 - rev 443487
Push 34961 by aciure@mozilla.com at Tue, 30 Oct 2018 22:06:02 +0000
Bug 1500869 - Test that BrowsingContexts work with BFCache. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D9367
2a0dfe99894b: Bug 1498222 - Add BrowsingContext.docShell webidl. r=peterv
Andreas Farre <farre@mozilla.com> - Thu, 18 Oct 2018 06:52:30 +0000 - rev 442305
Push 34904 by archaeopteryx@coole-files.de at Mon, 22 Oct 2018 17:25:25 +0000
Bug 1498222 - Add BrowsingContext.docShell webidl. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D8381
26d29ab41cdf: Bug 1497110 - remove currencySystem from PaymentRequest. r=edenchuang, peterv
Marcos Cáceres <mcaceres@mozilla.com> - Sun, 07 Oct 2018 21:00:00 +0300 - rev 441510
Push 34867 by shindli@mozilla.com at Wed, 17 Oct 2018 00:55:53 +0000
Bug 1497110 - remove currencySystem from PaymentRequest. r=edenchuang, peterv
9d7540135cac: Bug 1492823 - Ensure user input suppression works correctly even after document.open. r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 09 Oct 2018 08:56:01 -0400 - rev 440238
Push 34810 by shindli@mozilla.com at Tue, 09 Oct 2018 16:24:56 +0000
Bug 1492823 - Ensure user input suppression works correctly even after document.open. r=peterv
892a0ef87998: Bug 1491122 - Fix GetCCParticipant comment r=peterv
Andrew McCreight <continuation@gmail.com> - Fri, 28 Sep 2018 09:28:02 +0000 - rev 438699
Push 34734 by aiakab@mozilla.com at Fri, 28 Sep 2018 21:57:52 +0000
Bug 1491122 - Fix GetCCParticipant comment r=peterv Differential Revision: https://phabricator.services.mozilla.com/D5889
1de6dfd1e6ed: Bug 1480113 - Split parent process specific parts out of BrowsingContext r=peterv
Andreas Farre <farre@mozilla.com> - Fri, 14 Sep 2018 14:57:18 +0000 - rev 436676
Push 34657 by rgurzau@mozilla.com at Mon, 17 Sep 2018 16:45:13 +0000
Bug 1480113 - Split parent process specific parts out of BrowsingContext r=peterv Create ChromeBrowsingContext and move parent process specific parts from BrowsingContext there. After that make sure that all BrowsingContexts created in the parent process is actually ChromeBrowsingContexts and all BrowsingContexts in the child processes are BrowsingContexts. Differential Revision: https://phabricator.services.mozilla.com/D5419
fa0aa4da4ea6: Bug 1490503 - Mark more XPConnect classes builtinclass r=peterv
Andrew McCreight <continuation@gmail.com> - Fri, 14 Sep 2018 17:52:36 +0000 - rev 436370
Push 34643 by btara@mozilla.com at Fri, 14 Sep 2018 21:48:55 +0000
Bug 1490503 - Mark more XPConnect classes builtinclass r=peterv Also, make nsIXPCWrappedJSObjectGetter not scriptable to save a tiny amount of binary size. Differential Revision: https://phabricator.services.mozilla.com/D5613
ea41800d0ae0: Bug 1489098 - Remove useless use of PromiseFlatString. r=peterv
Henri Sivonen <hsivonen@hsivonen.fi> - Tue, 11 Sep 2018 17:17:05 +0000 - rev 435780
Push 34619 by btara@mozilla.com at Wed, 12 Sep 2018 03:11:51 +0000
Bug 1489098 - Remove useless use of PromiseFlatString. r=peterv MozReview-Commit-ID: 10JE4PRp8i0 Differential Revision: https://phabricator.services.mozilla.com/D5237
b5c403ab80f9: Bug 1481238 - Create WebIDL interface for BrowsingContext. r=peterv
Andreas Farre <farre@mozilla.com> - Wed, 29 Aug 2018 05:00:00 +0300 - rev 433892
Push 34523 by csabou@mozilla.com at Wed, 29 Aug 2018 17:34:43 +0000
Bug 1481238 - Create WebIDL interface for BrowsingContext. r=peterv Expose Chrome only WebIDL to interface with BrowsingContext from script. The API consists of parent, firstChild and nextSibling attributes for BrowsingContext, and the browsingContext attribute for Window.
612ca23ddb81: Bug 1481238 - Add tests for BrowsingContext. r=peterv
Andreas Farre <farre@mozilla.com> - Tue, 28 Aug 2018 02:41:00 +0300 - rev 433891
Push 34523 by csabou@mozilla.com at Wed, 29 Aug 2018 17:34:43 +0000
Bug 1481238 - Add tests for BrowsingContext. r=peterv
ed3c662bb21d: Bug 1469019 - Object.fromEntries. r=evilpie, r=peterv
Jason Orendorff <jorendorff@mozilla.com> - Tue, 14 Aug 2018 13:25:30 -0500 - rev 432483
Push 34478 by dluca@mozilla.com at Tue, 21 Aug 2018 09:54:49 +0000
Bug 1469019 - Object.fromEntries. r=evilpie, r=peterv
76659fa6e0e0: Bug 1483487 - Add asertions around creating and retrieving DOM proxy expando objects r=peterv
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 20 Aug 2018 10:12:35 +0100 - rev 432340
Push 34474 by shindli@mozilla.com at Mon, 20 Aug 2018 16:31:49 +0000
Bug 1483487 - Add asertions around creating and retrieving DOM proxy expando objects r=peterv
425a0334587b: Bug 1393306 - Add deprecation warning in 57 for removal of stat.isRemote in 58. r=ng,peterv
Jan-Ivar Bruaroey <jib@mozilla.com> - Fri, 01 Sep 2017 22:35:56 -0400 - rev 430162
Push 34384 by dvarga@mozilla.com at Sat, 04 Aug 2018 21:44:57 +0000
Bug 1393306 - Add deprecation warning in 57 for removal of stat.isRemote in 58. r=ng,peterv MozReview-Commit-ID: 7wKBg3KQxjo
10b4f3fa453f: Bug 1445659 - Make BrowsingContext interact with bfcache. r=peterv
Andreas Farre <farre@mozilla.com> - Thu, 28 Jun 2018 05:40:00 +0300 - rev 428831
Push 34346 by rgurzau@mozilla.com at Sat, 28 Jul 2018 09:46:41 +0000
Bug 1445659 - Make BrowsingContext interact with bfcache. r=peterv Have BrowsingContext keep its own cache to enable caching of BrowsingContexts, especially in the parent process. This isn't really optimal, since it effectively duplicates the cache in the child process. BFcache keeps a list of strong pointers to the list of cached nsDocShells, where each nsDocShell in turn keeps a reciprocated strong pointer to its BrowsingContext, which in turn is held in the BrowsingContexts list of cached contexts. Ideally these caches should be merged.
c70a61e3f34a: Bug 1445659 - Create basic Browsing Context in Content Parent and Child. r=peterv
Andreas Farre <farre@mozilla.com> - Thu, 26 Jul 2018 10:31:00 +0300 - rev 428830
Push 34346 by rgurzau@mozilla.com at Sat, 28 Jul 2018 09:46:41 +0000
Bug 1445659 - Create basic Browsing Context in Content Parent and Child. r=peterv Add BrowsingContext to allow the tree structure of docshells to exist in several processes simultaneously. This is a first step towards allowing a tree structure preserving separation of docshells across processes.
3f78090c350c: Bug 1382035. Treat Promise return values like undefined for javascript: urls. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 23 Jul 2018 16:18:33 -0400 - rev 427865
Push 34320 by rgurzau@mozilla.com at Tue, 24 Jul 2018 09:50:07 +0000
Bug 1382035. Treat Promise return values like undefined for javascript: urls. r=peterv
13efb4f58614: Bug 1453795 - DOM - Initialize member fields in classes/ structures. r=peterv
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Sat, 16 Jun 2018 17:21:46 +0300 - rev 426380
Push 34271 by apavel@mozilla.com at Thu, 12 Jul 2018 21:52:15 +0000
Bug 1453795 - DOM - Initialize member fields in classes/ structures. r=peterv
2379329b1413: Bug 1475003, don't notify DOM of SMIL changes, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 12 Jul 2018 13:04:26 +0300 - rev 426362
Push 34271 by apavel@mozilla.com at Thu, 12 Jul 2018 21:52:15 +0000
Bug 1475003, don't notify DOM of SMIL changes, r=peterv
16581950a2b9: Bug 1472618 - Make navigator.platform return "Win32", even on Win64 OS. r=peterv
Chris Peterson <cpeterson@mozilla.com> - Mon, 02 Jul 2018 11:02:23 -0700 - rev 425744
Push 34264 by shindli@mozilla.com at Wed, 11 Jul 2018 09:41:50 +0000
Bug 1472618 - Make navigator.platform return "Win32", even on Win64 OS. r=peterv navigator.platform returns "Win64" in 64-bit Firefox and IE, but "Win32" in 64-bit Chrome and Edge. "Win32" appears to be the de facto platform value for Windows. This change doesn't hide the OS architecture from web content because navigator.userAgent still mentions "Win64; x64" in 64-bit Firefox, Chrome, Edge, and IE. MozReview-Commit-ID: CplYnGDQgTe
e8c0ffefb34f: Bug 1428246 - The attributeChangedCallback is fired twice for the *first* style attribute change, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 26 Jun 2018 12:54:00 +0300 - rev 423682
Push 34190 by ebalazs@mozilla.com at Tue, 26 Jun 2018 14:53:39 +0000
Bug 1428246 - The attributeChangedCallback is fired twice for the *first* style attribute change, r=peterv The idea with this patch is that style code will first call InlineStyleDeclarationWillChange before style declaration has changed, and SetInlineStyleDeclaration once it has changed. In order to be able to report old attribute value, InlineStyleDeclarationWillChange reads the value and also calls AttributeWillChange (so that DOMMutationObserser can grab the old value). Later SetInlineStyleDeclaration passes the old value to SetAttrAndNotify so that mutation events and attributeChanged callbacks are handled correctly. Because of performance, declaration can't be cloned for reading the old value. And that is why the recently-added callback is used to detect when declaration is about to change (bug 1466963 and followup bug 1468665). To keep the expected existing behavior, even if declaration isn't changed, but just a new declaration was created (since there wasn't any), we need to still run all these willchange/set calls. That is when the code has 'if (created)' checks. Since there are several declaration implementation and only nsDOMCSSAttributeDeclaration needs the about-to-change callback, GetPropertyChangeClosure is the one to initialize the callback closure, and the struct which is then passes as data to the closure. Apparently we lost mutation event testing on style attribute when the pref was added, so test_style_attr_listener.html is modified to test both pref values.
f18328bef6bb: Bug 1453795 - XPConnect - Initialize member fields in classes/ structures. r=peterv
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Fri, 15 Jun 2018 14:25:49 +0300 - rev 423265
Push 34170 by ncsoregi@mozilla.com at Thu, 21 Jun 2018 21:50:44 +0000
Bug 1453795 - XPConnect - Initialize member fields in classes/ structures. r=peterv
32d9328cab02: Bug 1453795 - XPConnect - Initialize member fields in classes/ structures. r=peterv
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Fri, 15 Jun 2018 14:25:49 +0300 - rev 423262
Push 34170 by ncsoregi@mozilla.com at Thu, 21 Jun 2018 21:50:44 +0000
Bug 1453795 - XPConnect - Initialize member fields in classes/ structures. r=peterv
668a0db86e1e: Bug 1453795 - DOM/XSLT - Initialize member fields in classes/ structures. r=peterv
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Fri, 15 Jun 2018 13:59:04 +0300 - rev 423261
Push 34170 by ncsoregi@mozilla.com at Thu, 21 Jun 2018 21:50:44 +0000
Bug 1453795 - DOM/XSLT - Initialize member fields in classes/ structures. r=peterv
292092eabd6f: Bug 1466221. Implement ToJSValue variants for non-refcounted (so owned) DOM objects. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Sat, 09 Jun 2018 01:03:15 -0400 - rev 422058
Push 34114 by btara@mozilla.com at Sat, 09 Jun 2018 15:31:58 +0000
Bug 1466221. Implement ToJSValue variants for non-refcounted (so owned) DOM objects. r=peterv
4d39fdf74ae7: bug 1442776 make CycleCollectedJSContext accessible from JSContext private r=peterv
Karl Tomlinson <karlt+@karlt.net> - Thu, 10 May 2018 17:04:12 +1200 - rev 421533
Push 34097 by nbeleuzu@mozilla.com at Wed, 06 Jun 2018 16:59:16 +0000
bug 1442776 make CycleCollectedJSContext accessible from JSContext private r=peterv Inheriting PerThreadAtomCache on CycleCollectedJSContext permits use of static_cast, avoiding one level of indirection compared to adding a CycleCollectedJSContext* to PerThreadAtomCache. PerThreadAtomCache is over 18kB, and so WorkerJSContext and WorkletJSContext are moved from the stack to the heap. MozReview-Commit-ID: 6jdJeZcviK4
c116c385bb02: Bug 1461321 - input.list should work in shadow DOM, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 24 May 2018 22:46:11 +0300 - rev 419747
Push 34046 by cbrindusan@mozilla.com at Fri, 25 May 2018 00:04:29 +0000
Bug 1461321 - input.list should work in shadow DOM, r=peterv
29b727bc2caa: Bug 1459309 - currentScript should be null when evaluating scripts from shadow DOM, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Fri, 11 May 2018 20:24:50 +0300 - rev 419581
Push 34039 by apavel@mozilla.com at Wed, 23 May 2018 22:01:03 +0000
Bug 1459309 - currentScript should be null when evaluating scripts from shadow DOM, r=peterv
69256fdf60d6: Bug 1404864 - ensure HTMLInputElement.form works per spec in Shadow DOM, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Fri, 18 May 2018 20:02:14 +0300 - rev 418947
Push 34015 by aciure@mozilla.com at Fri, 18 May 2018 22:06:41 +0000
Bug 1404864 - ensure HTMLInputElement.form works per spec in Shadow DOM, r=peterv
dbb42b18303a: Bug 1455802. Get rid of web-visible XMLStyleSheetProcessingInstruction. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 14 May 2018 18:54:16 -0400 - rev 418293
Push 33997 by ncsoregi@mozilla.com at Tue, 15 May 2018 09:53:53 +0000
Bug 1455802. Get rid of web-visible XMLStyleSheetProcessingInstruction. r=peterv MozReview-Commit-ID: GBumpNuvzZf
cc0781a78634: Bug 1460435 - Move ID observing from Document to DocumentOrShadowRoot, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Mon, 14 May 2018 21:39:53 +0300 - rev 418258
Push 33997 by ncsoregi@mozilla.com at Tue, 15 May 2018 09:53:53 +0000
Bug 1460435 - Move ID observing from Document to DocumentOrShadowRoot, r=peterv
10fdb852c81a: Bug 1460334 - Fix crash caused when attempting to migrate <deck> from a XBL binding to a Custom Element. r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 10 May 2018 14:08:00 -0400 - rev 418201
Push 33995 by nbeleuzu@mozilla.com at Mon, 14 May 2018 21:37:08 +0000
Bug 1460334 - Fix crash caused when attempting to migrate <deck> from a XBL binding to a Custom Element. r=peterv
e4cfb8924eea: Bug 1455796 - Make browser_messagemanager_loadprocessscript.js aware of OOP WebExtensions r=peterv
Dennis Schubert <dschubert@mozilla.com> - Tue, 08 May 2018 15:18:08 +0200 - rev 417341
Push 33966 by aciure@mozilla.com at Tue, 08 May 2018 22:55:45 +0000
Bug 1455796 - Make browser_messagemanager_loadprocessscript.js aware of OOP WebExtensions r=peterv MozReview-Commit-ID: KENm9TmElUU
f3ad04730dd3: Bug 1451908 - Check for infinite value in txFormatNumberFunctionCall. r=peterv a=abillings
Eric Rahm <erahm@mozilla.com> - Tue, 17 Apr 2018 11:22:04 -0700 - rev 415617
Push 33901 by apavel@mozilla.com at Thu, 26 Apr 2018 06:05:37 +0000
Bug 1451908 - Check for infinite value in txFormatNumberFunctionCall. r=peterv a=abillings
e47d7dbc1cd2: Bug 1451908 - Check for infinite value in txFormatNumberFunctionCall. r=peterv
Eric Rahm <erahm@mozilla.com> - Tue, 17 Apr 2018 11:22:04 -0700 - rev 415488
Push 33896 by rgurzau@mozilla.com at Wed, 25 Apr 2018 09:36:32 +0000
Bug 1451908 - Check for infinite value in txFormatNumberFunctionCall. r=peterv
438494d2d17b: Bug 1453339. Make it harder to mess up Promise::All. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 13 Apr 2018 19:31:42 -0400 - rev 413837
Push 33852 by shindli@mozilla.com at Mon, 16 Apr 2018 21:59:17 +0000
Bug 1453339. Make it harder to mess up Promise::All. r=peterv MozReview-Commit-ID: UO4wssYHj7
91406356569c: Bug 1453339 - Make it harder to mess up Promise::All. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 12 Apr 2018 17:03:49 -0400 - rev 413365
Push 33845 by csabou@mozilla.com at Sat, 14 Apr 2018 23:37:33 +0000
Bug 1453339 - Make it harder to mess up Promise::All. r=peterv MozReview-Commit-ID: UO4wssYHj7
7c5124a18c41: Bug 1445912 - Remove PopupBoxObject::enableKeyboardNavigator/enableRollup/setConsumeRollupEvent in favor of DOM attributes. r=enn,peterv
Dão Gottwald <dao@mozilla.com> - Thu, 12 Apr 2018 16:55:50 +0200 - rev 413176
Push 33837 by aiakab@mozilla.com at Fri, 13 Apr 2018 16:02:32 +0000
Bug 1445912 - Remove PopupBoxObject::enableKeyboardNavigator/enableRollup/setConsumeRollupEvent in favor of DOM attributes. r=enn,peterv
7c26bbdac00f: Bug 1445710. Reduce codesize a bit by removing DOM DefineInterfaceObject methods. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 04 Apr 2018 15:32:19 -0400 - rev 411796
Push 33771 by nerli@mozilla.com at Thu, 05 Apr 2018 10:02:37 +0000
Bug 1445710. Reduce codesize a bit by removing DOM DefineInterfaceObject methods. r=peterv MozReview-Commit-ID: 6JRYz4FV9vP
5cc5f9c978a3: Bug 1447454. Stop allowing implicit downcasts in StrongOrRawPtr. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 04 Apr 2018 15:32:19 -0400 - rev 411793
Push 33771 by nerli@mozilla.com at Thu, 05 Apr 2018 10:02:37 +0000
Bug 1447454. Stop allowing implicit downcasts in StrongOrRawPtr. r=peterv MozReview-Commit-ID: BSXp3ThY1dC
7271d56c190d: Bug 1085062 followup. Actually address the review comments. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 04 Apr 2018 14:43:41 -0400 - rev 411785
Push 33771 by nerli@mozilla.com at Thu, 05 Apr 2018 10:02:37 +0000
Bug 1085062 followup. Actually address the review comments. r=peterv
6d94022fef7a: Bug 1085062. Remove hasXPConnectImpls support from bindings codegen. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 04 Apr 2018 14:39:52 -0400 - rev 411783
Push 33771 by nerli@mozilla.com at Thu, 05 Apr 2018 10:02:37 +0000
Bug 1085062. Remove hasXPConnectImpls support from bindings codegen. r=peterv
a9a254ed2869: Bug 1085061. Remove the hasXPConnectImpls flag from EventTarget. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 04 Apr 2018 14:39:48 -0400 - rev 411782
Push 33771 by nerli@mozilla.com at Thu, 05 Apr 2018 10:02:37 +0000
Bug 1085061. Remove the hasXPConnectImpls flag from EventTarget. r=peterv This is the behavior change. The cleanup will be in bug 1085062.
9ed0718ede32: Bug 1446246 part 2. Combine HTMLConstructor and CreateXULOrHTMLElement into a single function. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 27 Mar 2018 15:49:02 -0400 - rev 410329
Push 33725 by csabou@mozilla.com at Wed, 28 Mar 2018 09:50:28 +0000
Bug 1446246 part 2. Combine HTMLConstructor and CreateXULOrHTMLElement into a single function. r=peterv This fixes an observable bug we had due to doing the steps in a different order from the spec: the 'prototype' get can have side-effects so needs to happen after some of the other sanity checks. MozReview-Commit-ID: 83zNhqfqFRu
b470762b4676: Bug 1446246 part 1. Use a single handwritten HTMLConstructor implementation, instead of code-generating lots of very similar implementations. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 27 Mar 2018 15:49:02 -0400 - rev 410328
Push 33725 by csabou@mozilla.com at Wed, 28 Mar 2018 09:50:28 +0000
Bug 1446246 part 1. Use a single handwritten HTMLConstructor implementation, instead of code-generating lots of very similar implementations. r=peterv The codegen changes are mostly a backout of the changes made in bug 1274159. The HTMLConstructor implementation is mostly copied from one of the code-generated ones, with a few modifications: * Derive the interface name from the proto id instead of hardcoding it. * Use the proto/constructor ids to get constructor and prototype objects. * Use ErrorResult instead of FastErrorResult; we don't want the precedent of using FastErrorResult in non-generated code. There will be further changes to combine HTMLConstructor and CreateXULOrHTMLElement, in a separate changeset. MozReview-Commit-ID: 44D0qw23ioP