searching for reviewer(peterv)
0a045042fc65d4ad6bfeb91432ac3215a000cf48: Bug 1747059 - Gecko support for ShadowRealms r=peterv,smaug
Matthew Gaudet <mgaudet@mozilla.com> - Tue, 28 Jun 2022 22:04:18 +0000 - rev 622405
Push 39912 by mlaza@mozilla.com at Wed, 29 Jun 2022 03:44:30 +0000
Bug 1747059 - Gecko support for ShadowRealms r=peterv,smaug This connects [Exposed=*] in WebIDL to ShadowRealms Differential Revision: https://phabricator.services.mozilla.com/D146349
f7b049ef3b8c7a42a5d0a580688ab982dfb7cb03: Bug 1747059 - Gecko support for ShadowRealms r=peterv,smaug
Matthew Gaudet <mgaudet@mozilla.com> - Mon, 27 Jun 2022 21:17:36 +0000 - rev 622215
Push 39910 by bszekely@mozilla.com at Tue, 28 Jun 2022 09:16:40 +0000
Bug 1747059 - Gecko support for ShadowRealms r=peterv,smaug This connects [Exposed=*] in WebIDL to ShadowRealms Differential Revision: https://phabricator.services.mozilla.com/D146349
fc6cfc9ff71dead4c1df1ca557eb8322e49fe2ec: Bug 1770237: Part 8 - Remove legacy component registration for TestInterfaceJS. r=peterv
Kris Maglione <maglione.k@gmail.com> - Wed, 22 Jun 2022 20:31:34 +0000 - rev 621814
Push 39885 by nfay@mozilla.com at Thu, 23 Jun 2022 03:54:50 +0000
Bug 1770237: Part 8 - Remove legacy component registration for TestInterfaceJS. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D148188
57fad07090a4c5b37531f276b8ca6da5d857969b: Bug 1387334 - Don't call JS_DefineProfilingFunctions in CreateGlobal. r=peterv
Andrew McCreight <continuation@gmail.com> - Wed, 22 Jun 2022 15:54:16 +0000 - rev 621770
Push 39885 by nfay@mozilla.com at Thu, 23 Jun 2022 03:54:50 +0000
Bug 1387334 - Don't call JS_DefineProfilingFunctions in CreateGlobal. r=peterv In the modern age of the Gecko Profiler, surely nobody is using this. Differential Revision: https://phabricator.services.mozilla.com/D148438
32b1bc49e7f812d1224e229bde44686c376169b0: Bug 1774475, add missing await to the test to ensure loading a new page and going back have been processed, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 21 Jun 2022 11:38:38 +0000 - rev 621567
Push 39880 by ccozmuta@mozilla.com at Wed, 22 Jun 2022 03:32:25 +0000
Bug 1774475, add missing await to the test to ensure loading a new page and going back have been processed, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D149875
8414c5a1553177d60a395208562b5452e8f1504c: Bug 1756995 - Optimize docshell load end session store collection. r=peterv
Andreas Farre <farre@mozilla.com> - Wed, 15 Jun 2022 11:15:35 +0000 - rev 620965
Push 39856 by abutkovits@mozilla.com at Wed, 15 Jun 2022 21:49:08 +0000
Bug 1756995 - Optimize docshell load end session store collection. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D146207
3f8e81810ce266813f0474f0277e8891a91f0d0c: Bug 1773732 - Set proto outparam in RemoteObjectProxyBase::getPrototypeIfOrdinary. r=peterv
Jan de Mooij <jdemooij@mozilla.com> - Wed, 15 Jun 2022 09:30:33 +0000 - rev 620946
Push 39854 by imoraru@mozilla.com at Wed, 15 Jun 2022 15:46:59 +0000
Bug 1773732 - Set proto outparam in RemoteObjectProxyBase::getPrototypeIfOrdinary. r=peterv This prevents us from ilooping in `SetPrototype`. Differential Revision: https://phabricator.services.mozilla.com/D149261
902294133e7ffb8b16f4de20917a9494f5ee88f3: Bug 1756995 - Optimize docshell load end session store collection. r=peterv
Andreas Farre <farre@mozilla.com> - Tue, 14 Jun 2022 11:54:45 +0000 - rev 620834
Push 39850 by ctuns@mozilla.com at Tue, 14 Jun 2022 21:37:29 +0000
Bug 1756995 - Optimize docshell load end session store collection. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D146207
bd3ddd2bbefa230939811492cba6ee8390951930: Bug 1772494 - Remove ErrorEventInit's error default, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Mon, 13 Jun 2022 09:33:24 +0000 - rev 620642
Push 39841 by ctuns@mozilla.com at Mon, 13 Jun 2022 15:12:39 +0000
Bug 1772494 - Remove ErrorEventInit's error default, r=peterv Tests will be added in https://github.com/web-platform-tests/wpt/pull/34297/files Differential Revision: https://phabricator.services.mozilla.com/D148243
9bff6c2a2b5960a3ae4c813a60f1acb487b280cc: Bug 1771084 part 3 - Freeze builtins for the shared system global. r=mccr8,peterv
Nika Layzell <nika@thelayzells.com> - Tue, 07 Jun 2022 19:44:59 +0000 - rev 619998
Push 39813 by nfay@mozilla.com at Wed, 08 Jun 2022 03:52:13 +0000
Bug 1771084 part 3 - Freeze builtins for the shared system global. r=mccr8,peterv Differential Revision: https://phabricator.services.mozilla.com/D147305
b0f53121ccf21bc41fba4ea0b2e1d025edce3a44: Bug 1771084 part 3 - Freeze builtins for system globals. r=mccr8,peterv
Nika Layzell <nika@thelayzells.com> - Tue, 07 Jun 2022 17:01:52 +0000 - rev 619975
Push 39813 by nfay@mozilla.com at Wed, 08 Jun 2022 03:52:13 +0000
Bug 1771084 part 3 - Freeze builtins for system globals. r=mccr8,peterv Differential Revision: https://phabricator.services.mozilla.com/D147305
6ad49f7d560a59cebad7e445bb7f57b17662f2a8: Bug 1756995 - Optimize docshell load end session store collection. r=peterv
Andreas Farre <farre@mozilla.com> - Wed, 25 May 2022 16:33:54 +0000 - rev 618864
Push 39750 by nfay@mozilla.com at Thu, 26 May 2022 09:33:28 +0000
Bug 1756995 - Optimize docshell load end session store collection. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D146207
bc029159cd39b8e65679856e4de0cf4cd8e73b44: Bug 1743636 - Call SynchronizeLayoutHistoryState before ReplacedBy. r=peterv
Andrew McCreight <continuation@gmail.com> - Tue, 17 May 2022 14:21:09 +0000 - rev 617873
Push 39711 by apavel@mozilla.com at Tue, 17 May 2022 21:26:38 +0000
Bug 1743636 - Call SynchronizeLayoutHistoryState before ReplacedBy. r=peterv Bug 1766131 added a call to this method before the other call to ReplacedBy, but apparently the other call site comes into play in some tests, at least when parent controlled navigation is enabled. This fixes browser_scrollPositions.js with parent controlled navigation, and is a step towards fixing browser_test_shentry_wireframe.js. It sounds like the issue happens when you navigate to one page, then to another in the same site, via BrowserTestUtils. Because these are initiated from the parent process, then end up getting redirected to the content process in another docshell. We have to save the layout history state before doing this, or we lose the scroll information. Differential Revision: https://phabricator.services.mozilla.com/D146140
8ae7a015ae192e0689e63cbc865e1a272ec6580d: Bug 1769758 - Remove window.mozPaintCount. r=webidl,peterv
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 17 May 2022 14:14:10 +0000 - rev 617870
Push 39711 by apavel@mozilla.com at Tue, 17 May 2022 21:26:38 +0000
Bug 1769758 - Remove window.mozPaintCount. r=webidl,peterv We unshipped it successfully a while ago (bug 1591968). Differential Revision: https://phabricator.services.mozilla.com/D146575
e8eab3bfc4ef7b7d87ed9a763edd2fc680a5e797: Bug 1766909 - Wrap ObservableArray proxy on getter, rather than throwing. r=peterv
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 12 May 2022 07:36:03 +0000 - rev 617064
Push 39685 by bszekely@mozilla.com at Thu, 12 May 2022 09:49:57 +0000
Bug 1766909 - Wrap ObservableArray proxy on getter, rather than throwing. r=peterv This will still prevent them from accessing stuff (.length will be undefined, etc), but seems better than unexpectedly throwing. This fixes the issue at hand at least. With this patch, we reject length accesses here: https://searchfox.org/mozilla-central/rev/86c98c486f03b598d0f80356b69163fd400ec8aa/js/xpconnect/wrappers/XrayWrapper.cpp#229-233 Your call on whether this patch is enough as-is, or more work is needed. Also your call on whether if more work is needed that needs to happen on this bug or somewhere else. I'm not sure what we'd need to do to support this more "properly", presumably we'd need to add special XRay support to ObservableArrayProxyHandler or so? Pointers (or patches of course ;)) welcome. Also unsure about the setter situation, I _think_ it's fine not to throw given the code I read, but please sanity-check. Differential Revision: https://phabricator.services.mozilla.com/D145045
68895ba20051ad85a4fabdaf51b5f9bde2ee6f9f: Bug 1661862 - Don't assert when we leak nsSHistories. r=peterv
Andrew McCreight <continuation@gmail.com> - Wed, 11 May 2022 14:00:57 +0000 - rev 616986
Push 39683 by ccozmuta@mozilla.com at Wed, 11 May 2022 21:49:30 +0000
Bug 1661862 - Don't assert when we leak nsSHistories. r=peterv nsSHistories are kept in a linked list. When we leak one, we hit a linked list assertion. This patch works around that by adding a helper that removes everything from the list before it is destroyed. We'll still have test failures, but they'll be in the leak checker, which is hopefully more informative. Differential Revision: https://phabricator.services.mozilla.com/D145977
6867e23dd9628e8a725c714f1e1baa50e96f9896: Bug 1761728, MaybeDiscarded::IsNull doesn't mean the value isn't null, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 21 Apr 2022 08:56:25 +0000 - rev 614882
Push 39596 by ncsoregi@mozilla.com at Thu, 21 Apr 2022 15:23:18 +0000
Bug 1761728, MaybeDiscarded::IsNull doesn't mean the value isn't null, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D144003
7f523f9cd22dd9dffb5db8a7de2631fd5c759e02: Bug 1739450 - Part 2: Collect session history when wireframes are collected. r=peterv,mconley
Andreas Farre <farre@mozilla.com> - Tue, 19 Apr 2022 15:19:22 +0000 - rev 614604
Push 39588 by mlaza@mozilla.com at Tue, 19 Apr 2022 21:46:07 +0000
Bug 1739450 - Part 2: Collect session history when wireframes are collected. r=peterv,mconley Because wireframes are collected together with the session history entry for its docshell, we need to collect session history to make sure that collected wireframes show up. Differential Revision: https://phabricator.services.mozilla.com/D143368
1fcfc31bc6c35aababed1abb36efe5ca1b8f3fc5: Bug 1739450 - Part 1: Move ownership of session store scroll and form data to platform. r=peterv
Andreas Farre <farre@mozilla.com> - Tue, 19 Apr 2022 15:19:22 +0000 - rev 614603
Push 39588 by mlaza@mozilla.com at Tue, 19 Apr 2022 21:46:07 +0000
Bug 1739450 - Part 1: Move ownership of session store scroll and form data to platform. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D130389
a5503ab9c9eb9fbf05c2277c3319728c77e9eff6: Bug 1763617, GetPerformance may return null, so null-check it before use in bfcache, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 19 Apr 2022 13:34:52 +0000 - rev 614586
Push 39588 by mlaza@mozilla.com at Tue, 19 Apr 2022 21:46:07 +0000
Bug 1763617, GetPerformance may return null, so null-check it before use in bfcache, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D143506
a6e6ce53432f3dd786dd5994681f97909acdce4f: Bug 1755147 - Disable `dom.webidl.crosscontext_hasinstance.enabled` on EARLY_BETA_OR_EARLIER r=peterv,edgar
Kagami Sascha Rosylight <krosylight@mozilla.com> - Wed, 06 Apr 2022 13:08:11 +0000 - rev 613507
Push 39530 by nfay@mozilla.com at Thu, 07 Apr 2022 09:29:59 +0000
Bug 1755147 - Disable `dom.webidl.crosscontext_hasinstance.enabled` on EARLY_BETA_OR_EARLIER r=peterv,edgar Differential Revision: https://phabricator.services.mozilla.com/D138676
641671b45e41eed33868ef05192c54a5f16b5ab9: Bug 1762993 - Merge Interface{Is,Has}Instance implementation r=peterv
Kagami Sascha Rosylight <krosylight@mozilla.com> - Tue, 05 Apr 2022 22:20:35 +0000 - rev 613459
Push 39524 by ctuns@mozilla.com at Wed, 06 Apr 2022 04:35:13 +0000
Bug 1762993 - Merge Interface{Is,Has}Instance implementation r=peterv Differential Revision: https://phabricator.services.mozilla.com/D142896
9895ddf7829bb0cd46eab03b6c0d97c3247d62dd: Bug 1762965 - Handle RemoteObjectProxies in isInstance() r=peterv
Kagami Sascha Rosylight <krosylight@mozilla.com> - Tue, 05 Apr 2022 22:20:35 +0000 - rev 613458
Push 39524 by ctuns@mozilla.com at Wed, 06 Apr 2022 04:35:13 +0000
Bug 1762965 - Handle RemoteObjectProxies in isInstance() r=peterv Applying what bug 1576787 did in InterfaceHasInstance. Differential Revision: https://phabricator.services.mozilla.com/D142892
aac6275b5cf551c80e18d0faedcbf8d797707830: Bug 1758709: Add Telemetry for XSLT use r=peterv
Tom Ritter <tom@mozilla.com> - Tue, 05 Apr 2022 14:29:50 +0000 - rev 613404
Push 39523 by ctuns@mozilla.com at Tue, 05 Apr 2022 21:23:13 +0000
Bug 1758709: Add Telemetry for XSLT use r=peterv Differential Revision: https://phabricator.services.mozilla.com/D141240
34f5687c0372b277b23b5e11b588e9aa82a38dcc: Bug 1760844 part 1 - Remove hasInstance proxy trap. r=iain,peterv,robwu
Jan de Mooij <jdemooij@mozilla.com> - Mon, 04 Apr 2022 15:09:29 +0000 - rev 613276
Push 39518 by nbeleuzu@mozilla.com at Mon, 04 Apr 2022 21:49:47 +0000
Bug 1760844 part 1 - Remove hasInstance proxy trap. r=iain,peterv,robwu This removes the non-standard `hasInstance` proxy trap. All objects will now use the algorithm in `JS::InstanceofOperator`. That function uses other primitives and proxy traps already available to JS code. As discussed in the bug, there's a minor difference in behavior: for `xrayWrapper instanceof xrayWaiver` we used to always return false but we can now invoke `xrayWaiver[Symbol.hasInstance]()`. Differential Revision: https://phabricator.services.mozilla.com/D142061
8fdefc93e70f20fabdce819f088f4f41b89adccd: Bug 1758164 - Align the behavior of defining non-configurable properties on a WindowProxy on Nightly with Release/Beta; r=peterv
Edgar Chen <echen@mozilla.com> - Tue, 29 Mar 2022 20:33:24 +0000 - rev 612737
Push 39492 by ncsoregi@mozilla.com at Wed, 30 Mar 2022 03:54:32 +0000
Bug 1758164 - Align the behavior of defining non-configurable properties on a WindowProxy on Nightly with Release/Beta; r=peterv Differential Revision: https://phabricator.services.mozilla.com/D141732
e881ef466324323602dbb3dac1882dc732ec7388: Bug 1752250 - Part 2: [SHIP] Don't restore form data when reload a page with a no-store header; r=peterv
Edgar Chen <echen@mozilla.com> - Tue, 29 Mar 2022 20:27:09 +0000 - rev 612735
Push 39492 by ncsoregi@mozilla.com at Wed, 30 Mar 2022 03:54:32 +0000
Bug 1752250 - Part 2: [SHIP] Don't restore form data when reload a page with a no-store header; r=peterv Sync mSaveLayoutState to child process, so when the LayoutHistoryState is created and add into SessionHistoryInfo in child process, we could update its mScrollPositionOnly flag directly. Differential Revision: https://phabricator.services.mozilla.com/D141365
8d40bb06b8e4db5b5d6ea44542b5f65545fd418b: Bug 1752250 - Part 1: Refactor form restoration test; r=peterv
Edgar Chen <echen@mozilla.com> - Tue, 29 Mar 2022 20:27:09 +0000 - rev 612734
Push 39492 by ncsoregi@mozilla.com at Wed, 30 Mar 2022 03:54:32 +0000
Bug 1752250 - Part 1: Refactor form restoration test; r=peterv to make adding new tests easier. Differential Revision: https://phabricator.services.mozilla.com/D141364
decad054432ae4aedf75651ef3ddb089656e4183: Bug 1448400 - Remove hasInstance workarounds in SpecialPowers WrapPrivileged.jsm. r=peterv
Jan de Mooij <jdemooij@mozilla.com> - Tue, 29 Mar 2022 16:52:35 +0000 - rev 612714
Push 39492 by ncsoregi@mozilla.com at Wed, 30 Mar 2022 03:54:32 +0000
Bug 1448400 - Remove hasInstance workarounds in SpecialPowers WrapPrivileged.jsm. r=peterv The hasInstance JSClass hook was removed in bug 1270746. Differential Revision: https://phabricator.services.mozilla.com/D141731
18c2025ccfab71b9181f83714c8741bb10fa15d0: Bug 1270746 part 3 - Replace hasInstance JSClass hook on wrapped natives with a Symbol.hasInstance native. r=peterv
Jan de Mooij <jdemooij@mozilla.com> - Sun, 20 Mar 2022 11:28:03 +0000 - rev 611048
Push 39448 by mlaza@mozilla.com at Sun, 20 Mar 2022 21:39:21 +0000
Bug 1270746 part 3 - Replace hasInstance JSClass hook on wrapped natives with a Symbol.hasInstance native. r=peterv Resolve a `Symbol.hasInstance` native function that works like the class hook. Differential Revision: https://phabricator.services.mozilla.com/D141344
1fd694e26ee5eaefed65f75974bd6e8a5001a1cf: Bug 1756280: Test combinations of privacy.resistFingerprinting and pdfjs.disabled in navigator r=peterv
David Parks <daparks@mozilla.com> - Thu, 17 Mar 2022 20:15:21 +0000 - rev 610903
Push 39436 by smolnar@mozilla.com at Fri, 18 Mar 2022 04:08:44 +0000
Bug 1756280: Test combinations of privacy.resistFingerprinting and pdfjs.disabled in navigator r=peterv RFP should make navigator ignore pdfjs.disabled and always report that a PDF viewer is supported. It should also return the hard-coded values for navigator.plugins and navigator.mimeTypes. Without RFP, navigator.pdfViewerSupported should be false and plugins and mimeTypes should be empty when pdfjs.disabled is set. Differential Revision: https://phabricator.services.mozilla.com/D140763
a1e111031e92752a28310a9ddfed003e2cad37a5: Bug 1756280: Force navigator.pdfViewerEnabled, etc. if privacy.resistFingerprinting is set r=peterv,tjr
David Parks <daparks@mozilla.com> - Thu, 17 Mar 2022 20:15:20 +0000 - rev 610902
Push 39436 by smolnar@mozilla.com at Fri, 18 Mar 2022 04:08:44 +0000
Bug 1756280: Force navigator.pdfViewerEnabled, etc. if privacy.resistFingerprinting is set r=peterv,tjr navigator.{pdfViewerEnabled, mimeTypes, plugins} should ignore pdfjs.disabled when RFP is set. Differential Revision: https://phabricator.services.mozilla.com/D140762
c0d6793b3c6fded138906645dbc3354c61faaf46: Bug 1756280: Force navigator.pdfViewerEnabled, etc. if privacy.resistFingerprinting is set r=peterv,tjr
David Parks <daparks@mozilla.com> - Wed, 16 Mar 2022 16:40:11 +0000 - rev 610776
Push 39429 by ctuns@mozilla.com at Wed, 16 Mar 2022 21:49:37 +0000
Bug 1756280: Force navigator.pdfViewerEnabled, etc. if privacy.resistFingerprinting is set r=peterv,tjr navigator.{pdfViewerEnabled, mimeTypes, plugins} should ignore pdfjs.disabled when RFP is set. Differential Revision: https://phabricator.services.mozilla.com/D140762
0cc154fee1b1a5829812a7e0542d35f47bab15b6: Bug 1759444, null check webProgress before using it, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 15 Mar 2022 16:28:42 +0000 - rev 610659
Push 39423 by mlaza@mozilla.com at Tue, 15 Mar 2022 21:39:24 +0000
Bug 1759444, null check webProgress before using it, r=peterv this should fix the crash, but I'm investigating if beforeunload handling should be tweaked too as followup work. Differential Revision: https://phabricator.services.mozilla.com/D141117
a487e8d56a0b594cdacf6e6a1b311823a6d29d67: Bug 1759074 - Make generated bindings include necessary headers for ObservableArray type; r=peterv
Edgar Chen <echen@mozilla.com> - Mon, 14 Mar 2022 15:45:32 +0000 - rev 610550
Push 39417 by imoraru@mozilla.com at Mon, 14 Mar 2022 21:49:02 +0000
Bug 1759074 - Make generated bindings include necessary headers for ObservableArray type; r=peterv Differential Revision: https://phabricator.services.mozilla.com/D140832
acaa10b52cec3ceb8001debfca5030a36ebbf61d: Bug 1757727 - Regenerated ExtensionTest API webidl definitions and update implementation accordingly. r=mixedpuppy,peterv
Luca Greco <lgreco@mozilla.com> - Mon, 14 Mar 2022 13:27:21 +0000 - rev 610534
Push 39417 by imoraru@mozilla.com at Mon, 14 Mar 2022 21:49:02 +0000
Bug 1757727 - Regenerated ExtensionTest API webidl definitions and update implementation accordingly. r=mixedpuppy,peterv Differential Revision: https://phabricator.services.mozilla.com/D140047
55e7751e83952860f74636ab43d808b8679407ce: Bug 1748714 - Regenerated ExtensionRuntime API webidl definitions. r=peterv
Luca Greco <lgreco@mozilla.com> - Mon, 14 Mar 2022 13:27:21 +0000 - rev 610533
Push 39417 by imoraru@mozilla.com at Mon, 14 Mar 2022 21:49:02 +0000
Bug 1748714 - Regenerated ExtensionRuntime API webidl definitions. r=peterv ExtensionRuntime does also include some APIs that would need multiple signatures for the WebIDL methods with optional parameters to match the behavior of the current Extensions API bindings. Differential Revision: https://phabricator.services.mozilla.com/D136952
d29943b5e5fd01eefa1cb5ee868586e124b5d5c9: Bug 1748714 - Regenerate ExtensionAlarms.webidl and remove skip on test_alarms_get_and_clear_single_argument. r=mixedpuppy,webidl,peterv
Luca Greco <lgreco@mozilla.com> - Mon, 14 Mar 2022 13:27:20 +0000 - rev 610531
Push 39417 by imoraru@mozilla.com at Mon, 14 Mar 2022 21:49:02 +0000
Bug 1748714 - Regenerate ExtensionAlarms.webidl and remove skip on test_alarms_get_and_clear_single_argument. r=mixedpuppy,webidl,peterv Differential Revision: https://phabricator.services.mozilla.com/D135420
97d819698581462b580a2bad6b344fad42c00118: Bug 1683281 - Part 7: Generate example code for ObservableArray; r=peterv
Edgar Chen <echen@mozilla.com> - Thu, 10 Mar 2022 22:44:29 +0000 - rev 610272
Push 39399 by abutkovits@mozilla.com at Fri, 11 Mar 2022 09:41:23 +0000
Bug 1683281 - Part 7: Generate example code for ObservableArray; r=peterv Depends on D113862 Differential Revision: https://phabricator.services.mozilla.com/D115747
d62f0deb85785c42783aeac45e14557a355d7239: Bug 1683281 - Part 6-2: C++ helper function for ObservableArray; r=peterv
Edgar Chen <echen@mozilla.com> - Thu, 10 Mar 2022 22:44:29 +0000 - rev 610271
Push 39399 by abutkovits@mozilla.com at Fri, 11 Mar 2022 09:41:23 +0000
Bug 1683281 - Part 6-2: C++ helper function for ObservableArray; r=peterv Generate helper function for C++ to perform operations on backing objects for each observable array attribute, - ElementAt: Get the item at that index. Throw error if fail to get the element. - ReplaceElementAt: Replace the item at the index, this will also trigger OnDelete and OnSet callback. Throw error if fail to replace the element. - AppendElement: Append one element to the end of the array, this will also trigger OnSet callback. Throw error if fail to append the element. - RemoveLastElement: Remove the element at the last index, this will also trigger OnDelete callback. Throw error if fail to remove the element. - Length: Get the number of the indexd value. Throw error if fail to get the length. Depends on D113728 Differential Revision: https://phabricator.services.mozilla.com/D113862
8af8c4503d684f8924b48e9f6bb044a134a4083c: Bug 1683281 - Part 6-1: Create CGHelperFunctionGenerator and refactor into more generic base class; r=peterv
Edgar Chen <echen@mozilla.com> - Thu, 10 Mar 2022 22:44:29 +0000 - rev 610270
Push 39399 by abutkovits@mozilla.com at Fri, 11 Mar 2022 09:41:23 +0000
Bug 1683281 - Part 6-1: Create CGHelperFunctionGenerator and refactor into more generic base class; r=peterv So we could reuse it to generate helper function for observable array type Depends on D112280 Differential Revision: https://phabricator.services.mozilla.com/D113728
bd45b431c375b7eaea49f7f1be11f967089c0cec: Bug 1683281 - Part 5: Generate binding code for ObservableArray type; r=peterv
Edgar Chen <echen@mozilla.com> - Thu, 10 Mar 2022 22:44:28 +0000 - rev 610269
Push 39399 by abutkovits@mozilla.com at Fri, 11 Mar 2022 09:41:23 +0000
Bug 1683281 - Part 5: Generate binding code for ObservableArray type; r=peterv The highlevel architecture: - Each observable array attribute has corresponding ES proxy exotic object stored in DOM reflector's reserved slot. It use the ObservableArrayProxyHandler as proxy handler which implements the behaviour defined in the spec. - Each observable array exotic objects has 2 reserved slots: * one is to store the raw pointer of the interface, it is cleaned up when the DOM reflector is finalized. It is used to run the SetAlgorithm and DeleteAlgorithm defined in the spec. * one is to store the backing list used to store the indexed value. The additional properties are stored in the proxy target instead. Depends on D112279 Differential Revision: https://phabricator.services.mozilla.com/D112280
5e3348c86dfd834b64160a510dbc34ceecd6cf53: Bug 1683281 - Part 4: Add helper method to get ObservableArray backing object; r=peterv
Edgar Chen <echen@mozilla.com> - Thu, 10 Mar 2022 22:44:28 +0000 - rev 610268
Push 39399 by abutkovits@mozilla.com at Fri, 11 Mar 2022 09:41:23 +0000
Bug 1683281 - Part 4: Add helper method to get ObservableArray backing object; r=peterv Depends on D112278 Differential Revision: https://phabricator.services.mozilla.com/D112279
95071f254b91881a2f819f5f424c10e5aab88e0c: Bug 1683281 - Part 3: Add ObservableArrayProxyHandler base class; r=peterv
Edgar Chen <echen@mozilla.com> - Thu, 10 Mar 2022 22:44:27 +0000 - rev 610267
Push 39399 by abutkovits@mozilla.com at Fri, 11 Mar 2022 09:41:23 +0000
Bug 1683281 - Part 3: Add ObservableArrayProxyHandler base class; r=peterv This implements the base class for proxy handler of observable array exotic objects, it implments the proxy behaviour define in https://webidl.spec.whatwg.org/#es-observable-arrays, the virtual functions , OnDeleteItem() and OnSetItem(), are for SetAlgorithm and DeleteAlgorithm that are defined and implemented per interface. Depends on D112277 Differential Revision: https://phabricator.services.mozilla.com/D112278
3b574e19dc4549a2502b47781cb694491da432a9: Bug 1683281 - Part 2: Move proxy handler utility functions from DOMJSProxyHandler.h to ProxyHandlerUtils.h; r=peterv
Edgar Chen <echen@mozilla.com> - Thu, 10 Mar 2022 22:44:27 +0000 - rev 610266
Push 39399 by abutkovits@mozilla.com at Fri, 11 Mar 2022 09:41:23 +0000
Bug 1683281 - Part 2: Move proxy handler utility functions from DOMJSProxyHandler.h to ProxyHandlerUtils.h; r=peterv Depends on D103469 Differential Revision: https://phabricator.services.mozilla.com/D112277
2e3a03440cb06c4768d24576cbcd68fa3768f50e: Bug 1683281 - Part 1: Make WebIDL parser support ObservableArray type; r=peterv
Edgar Chen <echen@mozilla.com> - Thu, 10 Mar 2022 22:44:27 +0000 - rev 610265
Push 39399 by abutkovits@mozilla.com at Fri, 11 Mar 2022 09:41:23 +0000
Bug 1683281 - Part 1: Make WebIDL parser support ObservableArray type; r=peterv Differential Revision: https://phabricator.services.mozilla.com/D103469
a86b169665d20a4e4c79d24ccbbea173a7e17ab3: Bug 1758552 - Shrink PrefableDisablers in 32-bit builds. r=peterv
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 10 Mar 2022 15:25:17 +0000 - rev 610232
Push 39397 by nbeleuzu@mozilla.com at Thu, 10 Mar 2022 21:50:57 +0000
Bug 1758552 - Shrink PrefableDisablers in 32-bit builds. r=peterv As per suggestion raised in bug 1756500. Differential Revision: https://phabricator.services.mozilla.com/D140557
794afc641923ffdaf37c8760ae4a47cdba895356: Bug 1757458, replace loading session history entry only right before redirecting load to real channel r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 10 Mar 2022 10:41:20 +0000 - rev 610199
Push 39395 by smolnar@mozilla.com at Thu, 10 Mar 2022 17:23:56 +0000
Bug 1757458, replace loading session history entry only right before redirecting load to real channel r=peterv Differential Revision: https://phabricator.services.mozilla.com/D140559
966d676908b33872a19cc58ca3737443e09985bf: Bug 1758664, don't try to recheck possible session history entry in the parent process if we're doing such check already, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 10 Mar 2022 10:19:57 +0000 - rev 610194
Push 39395 by smolnar@mozilla.com at Thu, 10 Mar 2022 17:23:56 +0000
Bug 1758664, don't try to recheck possible session history entry in the parent process if we're doing such check already, r=peterv The code which this patch removes was clearly an oversight in the regressing patch. Differential Revision: https://phabricator.services.mozilla.com/D140690
104e8296211b0b773be8fa56d93557af21d4241b: Bug 1756500 - Add [Trial="Name"] condition to WebIDL. r=peterv
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 08 Mar 2022 15:24:15 +0000 - rev 610003
Push 39389 by apavel@mozilla.com at Tue, 08 Mar 2022 22:01:59 +0000
Bug 1756500 - Add [Trial="Name"] condition to WebIDL. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D139315