searching for reviewer(peterv)
ae7324598802d7433ac9c54efca2f3d09ccdc1b9: Bug 1730977 - Check the existence of requests before calling Stop(), r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Fri, 17 Sep 2021 14:18:20 +0000 - rev 592316
Push 38798 by mlaza@mozilla.com at Fri, 17 Sep 2021 21:50:08 +0000
Bug 1730977 - Check the existence of requests before calling Stop(), r=peterv Differential Revision: https://phabricator.services.mozilla.com/D125752
033efa2f5f0cea4e16a000d6039857699644ce8d: Bug 1730836, wallpaper the old issue where code expects GetDocShell to return non-null, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 16 Sep 2021 12:29:59 +0000 - rev 592159
Push 38794 by ccozmuta@mozilla.com at Thu, 16 Sep 2021 21:45:06 +0000
Bug 1730836, wallpaper the old issue where code expects GetDocShell to return non-null, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D125669
2d49d73f38aacf9b5b0b211574b60152f413d0a3: Bug 1727514 - media playback should stop in the bfcache, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Mon, 13 Sep 2021 12:40:18 +0000 - rev 591740
Push 38786 by mlaza@mozilla.com at Mon, 13 Sep 2021 21:32:24 +0000
Bug 1727514 - media playback should stop in the bfcache, r=peterv SetContainer handling is similar to what DocumentViewer does for the old bfcache implementation. (The old implementation hides it quite well). The changes to HTMLMediaElement are needed to ensure page can enter bfcache. Removed erroneous MOZ_ASSERT in nsPresContext, it is ok to trigger that code path in the new implementation. And the Run() method of the relevant nsIRunnable already deals with that case. Differential Revision: https://phabricator.services.mozilla.com/D124684
65e88b6f9cee0f9ba9ef4466fcebbca266ce8cbe: Bug 1727374 - Root Init dictionaries to fix rooting hazards. r=peterv
Steve Fink <sfink@mozilla.com> - Thu, 02 Sep 2021 19:06:58 +0000 - rev 590854
Push 38757 by malexandru@mozilla.com at Fri, 03 Sep 2021 03:51:58 +0000
Bug 1727374 - Root Init dictionaries to fix rooting hazards. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D123633
b330339294630e6628832ec908d87c96087c9f40: Bug 1723282, let nonbfcacheable page update layout history state when the new page is coming from the bfcache, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Mon, 30 Aug 2021 19:50:05 +0000 - rev 590246
Push 38748 by mlaza@mozilla.com at Tue, 31 Aug 2021 03:18:05 +0000
Bug 1723282, let nonbfcacheable page update layout history state when the new page is coming from the bfcache, r=peterv The fix let's ContentParent::RecvSynchronizeLayoutHistoryState update the layout history state. Using an existing test to launch a subtest for this. Hopefully the description of the test helps with reviewing it. (These BroadcastChannel based tests can be hard to follow.) Differential Revision: https://phabricator.services.mozilla.com/D122376
20cdfb2cb9d9acaa924640fe5a43353841010b6d: Bug 1670973, add a test to check how http redirects affect to the session history, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Mon, 30 Aug 2021 19:33:52 +0000 - rev 590243
Push 38748 by mlaza@mozilla.com at Tue, 31 Aug 2021 03:18:05 +0000
Bug 1670973, add a test to check how http redirects affect to the session history, r=peterv The old implementation and SHIP seem to have the same behavior. Differential Revision: https://phabricator.services.mozilla.com/D123117
94d021b67f6f52a4c9a9a1457121635e4eb0cf3a: Bug 1716594, clear the requested index after replacing an entry, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 12 Aug 2021 14:19:16 +0000 - rev 588687
Push 38700 by nbeleuzu@mozilla.com at Thu, 12 Aug 2021 21:41:21 +0000
Bug 1716594, clear the requested index after replacing an entry, r=peterv Looks like the code below does similar thing already for iframes, so this is adding InternalSetRequestedIndex call only for the top level case. This is based on the same assumptions as bug 1697905, but unfortunately testing this is still super hard. Differential Revision: https://phabricator.services.mozilla.com/D122355
d47214bb80b452b84b9685a7f8c21f2aee417cf6: Bug 1718021 - Add name attribute to PermissionStatus r=johannh,peterv
Marcos Cáceres <marcos@marcosc.com> - Wed, 11 Aug 2021 22:34:41 +0000 - rev 588605
Push 38697 by cbrindusan@mozilla.com at Thu, 12 Aug 2021 03:38:31 +0000
Bug 1718021 - Add name attribute to PermissionStatus r=johannh,peterv Spec change https://github.com/w3c/permissions/pull/248 Differential Revision: https://phabricator.services.mozilla.com/D118692
2cb9f52db17eabf59f8ca7d5e6aa261558473319: Bug 1721306, hide the tooltip when deactivating a BrowserParent, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Fri, 06 Aug 2021 19:33:04 +0000 - rev 588113
Push 38682 by smolnar@mozilla.com at Sat, 07 Aug 2021 09:26:14 +0000
Bug 1721306, hide the tooltip when deactivating a BrowserParent, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D121756
37008f131c6f343da69c7e9f1bb3ab7531ad00c9: Bug 1721306, hide the tooltip when deactivating a BrowserParent, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Fri, 06 Aug 2021 15:13:36 +0000 - rev 588080
Push 38681 by cbrindusan@mozilla.com at Fri, 06 Aug 2021 21:39:01 +0000
Bug 1721306, hide the tooltip when deactivating a BrowserParent, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D121756
c0047df3261fe66ead7fdb55eded6012e8a24b97: Bug 1723641 - Remove OS.Constants.Path.libsqlite3. r=peterv
Mike Hommey <mh+mozilla@glandium.org> - Thu, 05 Aug 2021 07:43:44 +0000 - rev 587876
Push 38676 by dluca@mozilla.com at Thu, 05 Aug 2021 16:34:46 +0000
Bug 1723641 - Remove OS.Constants.Path.libsqlite3. r=peterv It was added in bug 951838 for bug 853439, which never actually used it. It is also actually subtly wrong (sqlite3 is not in libxul). And the code added in bug 853439 was eventually removed in bug 1339444. Differential Revision: https://phabricator.services.mozilla.com/D121587
aa2d36f98b68c779c8b9438c30c9f3b1bffaa0c7: Bug 1719998 - Don't use lookupForAdd in GetOrCreateProxyObject. r=peterv,jonco
Andrew McCreight <continuation@gmail.com> - Tue, 20 Jul 2021 23:42:00 +0000 - rev 586263
Push 38629 by archaeopteryx@coole-files.de at Wed, 21 Jul 2021 09:23:53 +0000
Bug 1719998 - Don't use lookupForAdd in GetOrCreateProxyObject. r=peterv,jonco Differential Revision: https://phabricator.services.mozilla.com/D119699
b68a422ad6202e5356d0cef5d9b86db5f37f2d88: Bug 1720733 - Try to ensure SessionHistoryEntry::mFrameLoader isn't replaced accidentally, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Sat, 17 Jul 2021 09:34:46 +0000 - rev 585777
Push 38620 by csabou@mozilla.com at Sun, 18 Jul 2021 09:08:29 +0000
Bug 1720733 - Try to ensure SessionHistoryEntry::mFrameLoader isn't replaced accidentally, r=peterv I don't have a test for this, since the race condition is super hard to trigger. The patch is based on code auditing. The patch just prevents bfcaching if we're in middle of another load. Differential Revision: https://phabricator.services.mozilla.com/D119992
bd12f699ea33307b0749231f6ab276d1920dfeaa: Bug 1719795 part 3 - Inline XPC_WRAPPER_FLAGS. r=jonco,peterv
Jan de Mooij <jdemooij@mozilla.com> - Tue, 13 Jul 2021 09:31:33 +0000 - rev 585376
Push 38611 by dluca@mozilla.com at Tue, 13 Jul 2021 21:42:32 +0000
Bug 1719795 part 3 - Inline XPC_WRAPPER_FLAGS. r=jonco,peterv It's easier to reason about the JSClass flags without the extra level of indirection. Depends on D119499 Differential Revision: https://phabricator.services.mozilla.com/D119500
1ba3d134e71dbe7dbdcc8d94523c4b83db678884: Bug 1719178 - properly disconnect nsSHistory from the owner object, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 08 Jul 2021 11:08:19 +0000 - rev 585066
Push 38594 by smolnar@mozilla.com at Thu, 08 Jul 2021 15:46:14 +0000
Bug 1719178 - properly disconnect nsSHistory from the owner object, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D119114
f282075686a50dcd87590e0d4df1644af7f81186: Bug 1717765, tweak the check when creating a new content viewer shouldn't succeed, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Wed, 07 Jul 2021 16:55:23 +0000 - rev 585002
Push 38591 by mlaza@mozilla.com at Wed, 07 Jul 2021 21:52:19 +0000
Bug 1717765, tweak the check when creating a new content viewer shouldn't succeed, r=peterv The patch is based on the assumption that the assertion fails because of https://searchfox.org/mozilla-central/rev/1c5c3f4ec274462b92cf5bd82235ae3a56c508e9/dom/base/nsGlobalWindowInner.cpp#2775 Differential Revision: https://phabricator.services.mozilla.com/D119233
55cb6696ad3bdf0e2a1b8e1af8b8f0100a7d3329: Bug 1679653 - Part 5: Add xray support for the Error cause property. r=peterv
André Bargull <andre.bargull@gmail.com> - Thu, 24 Jun 2021 16:10:39 +0000 - rev 584281
Push 38563 by cbrindusan@mozilla.com at Fri, 25 Jun 2021 09:34:36 +0000
Bug 1679653 - Part 5: Add xray support for the Error cause property. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D115353
8742cb4bb4bee9bbcc84ee7c9b781407f5f007b1: Bug 1714703 - Promisify GamepadServiceTest r=tjr,peterv
Marcos Cáceres <marcos@marcosc.com> - Tue, 22 Jun 2021 08:45:59 +0000 - rev 583978
Push 38557 by malexandru@mozilla.com at Tue, 22 Jun 2021 21:29:07 +0000
Bug 1714703 - Promisify GamepadServiceTest r=tjr,peterv make GamepadServiceTest's methods return promises, so to avoid testing with flaky setTimeout(). Differential Revision: https://phabricator.services.mozilla.com/D117258
cd1fcf6de56339ea4c69cacdb5ed3249479b681c: Bug 1697905, requestedIndex may not always be cleared, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 15 Jun 2021 16:21:07 +0000 - rev 583271
Push 38541 by csabou@mozilla.com at Wed, 16 Jun 2021 03:36:43 +0000
Bug 1697905, requestedIndex may not always be cleared, r=peterv The previous version was trying to make index handling too generic. But history loads need to update index to the requested index, not to the index of the current entry, because the requested index was already passed to the child process when the history load started. If there are several pending history loads, commit of the first one will update the index based on requested index and send new index to the child. When child side receives the index update, other pending history loads have been already processed. New loads can just clear the requested index, since the child side has PendingSHistoryChange object to update the effective index and length to the correct one and when parent side sends back the current index and length the relevant PendingSHistoryChange object is removed. With this version both testing/web-platform/tests/old-tests/submission/Microsoft/history/history_000.htm and docshell/test/navigation/browser_test_simultaneous_normal_and_history_loads.js pass now even on a debug build. I think there might be a case for the issue happening also without SHIP, but since it is way less asynchronous, triggering that issue is hard. So the patch and test are for SHIP only. Differential Revision: https://phabricator.services.mozilla.com/D116744
5bfccedd3a4a05ae7618f715eec3c422585943d9: Bug 1715852 - Fix SessionHistoryEntry::mSrcdocData to work with session restore, r=peterv
Kashav Madan <kshvmdn@gmail.com> - Tue, 15 Jun 2021 13:34:01 +0000 - rev 583244
Push 38540 by smolnar@mozilla.com at Tue, 15 Jun 2021 21:45:02 +0000
Bug 1715852 - Fix SessionHistoryEntry::mSrcdocData to work with session restore, r=peterv Not setting mIsSrcdocEntry causes us to drop srcdoc data and not set INTERNAL_LOAD_FLAGS_IS_SRCDOC in FillLoadInfo for srcdoc restores. Differential Revision: https://phabricator.services.mozilla.com/D117479
01222f8a4306a18243b8fd26abcf0eaacb1894a8: Bug 1716437 - Disable /fetch/metadata/prefetch.https.sub.html on Fission for now, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 15 Jun 2021 12:28:48 +0000 - rev 583242
Push 38540 by smolnar@mozilla.com at Tue, 15 Jun 2021 21:45:02 +0000
Bug 1716437 - Disable /fetch/metadata/prefetch.https.sub.html on Fission for now, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D117717
d15ff67b02ffdaffbfcfea2436251e7869d1968a: Bug 1682632 - part1.1: WebExtensionStub extended attribute in WebIDL generator. r=peterv,mixedpuppy
Luca Greco <lgreco@mozilla.com> - Fri, 11 Jun 2021 18:58:06 +0000 - rev 582862
Push 38533 by nerli@mozilla.com at Sat, 12 Jun 2021 09:41:20 +0000
Bug 1682632 - part1.1: WebExtensionStub extended attribute in WebIDL generator. r=peterv,mixedpuppy Define a new WebExtensionStub extended attribute in the WebIDL generator to be used in the WebExtensions API WebIDL definitions. Depends on D70372 Differential Revision: https://phabricator.services.mozilla.com/D84681
7b8016e5f3fb8219ba0ad56565809e0b044b2078: Bug 1682632 - part1.1: WebExtensionStub extended attribute in WebIDL generator. r=peterv,mixedpuppy
Luca Greco <lgreco@mozilla.com> - Thu, 10 Jun 2021 09:34:52 +0000 - rev 582627
Push 38530 by imoraru@mozilla.com at Thu, 10 Jun 2021 21:50:38 +0000
Bug 1682632 - part1.1: WebExtensionStub extended attribute in WebIDL generator. r=peterv,mixedpuppy Define a new WebExtensionStub extended attribute in the WebIDL generator to be used in the WebExtensions API WebIDL definitions. Depends on D70372 Differential Revision: https://phabricator.services.mozilla.com/D84681
16d334e1548f38cec256aaa28090667a6ba081cb: Bug 1682632 - part1.1: WebExtensionStub extended attribute in WebIDL generator. r=peterv,mixedpuppy
Luca Greco <lgreco@mozilla.com> - Wed, 09 Jun 2021 19:20:40 +0000 - rev 582523
Push 38527 by ncsoregi@mozilla.com at Thu, 10 Jun 2021 03:46:06 +0000
Bug 1682632 - part1.1: WebExtensionStub extended attribute in WebIDL generator. r=peterv,mixedpuppy Define a new WebExtensionStub extended attribute in the WebIDL generator to be used in the WebExtensions API WebIDL definitions. Depends on D70372 Differential Revision: https://phabricator.services.mozilla.com/D84681
1968ba484b6fc3223e10526756c7a54595ef8566: Bug 1697905, requestedIndex may not always be cleared, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 08 Jun 2021 14:23:10 +0000 - rev 582220
Push 38524 by nbeleuzu@mozilla.com at Tue, 08 Jun 2021 21:57:51 +0000
Bug 1697905, requestedIndex may not always be cleared, r=peterv I think there might be a case for the issue happening also without SHIP, but since it is way less asynchronous, triggering that issue is hard. So the patch and test are for SHIP only. Differential Revision: https://phabricator.services.mozilla.com/D116744
434d5ad2b9ae6212b8b5ea93a64ab4e77adf6c23: Bug 1706167, don't update SessionHistoryEntry.title when doing same document navigations, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 08 Jun 2021 12:49:47 +0000 - rev 582214
Push 38524 by nbeleuzu@mozilla.com at Tue, 08 Jun 2021 21:57:51 +0000
Bug 1706167, don't update SessionHistoryEntry.title when doing same document navigations, r=peterv The change to DoNotifyPossibleTitleChange handling is needed so that we flush the pending title change before adding a new active entry. aUpdateEntryInSessionHistory is a bit odd name, since it is really about SHIP only. The patch isn't trying to fix non-SHIP UI issues, but just give Fission similar behavior what Chrome has. Differential Revision: https://phabricator.services.mozilla.com/D116504
bb05fe8fa742e7e470509f52a957d3b82ced2acb: Bug 1713365, don't try to bfcache if the session history entry already has a frameloader, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 03 Jun 2021 20:34:24 +0000 - rev 581885
Push 38513 by abutkovits@mozilla.com at Fri, 04 Jun 2021 10:21:11 +0000
Bug 1713365, don't try to bfcache if the session history entry already has a frameloader, r=peterv The crash happens currently when there are more than one loading session history entries at the same time and when the latter load then accesses current active entry, it has already the bfcached frameloader. I have tried and failed to write a testcase for this. The Pernosco record is from running https://searchfox.org/mozilla-central/source/devtools/client/webconsole/test/browser/browser_webconsole_message_categories.js and the crash has happened when there is a race condition between a load initiated in the parent process and another load initiated in a child process. The patch tries to make the setup rather safe. If active entry has changed or it has gotten frameloader, don't try to bfcache. Differential Revision: https://phabricator.services.mozilla.com/D116410
2e2d77222ab7aee2d9f9050929f4a76704fd3dfb: Bug 1711690 - Don't bfcache during session restore. r=kashav,peterv
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 01 Jun 2021 20:05:24 +0000 - rev 581620
Push 38511 by cbrindusan@mozilla.com at Wed, 02 Jun 2021 21:44:47 +0000
Bug 1711690 - Don't bfcache during session restore. r=kashav,peterv Here's what's going on (relevant browser is browser 36). [rr 502130 274898]RestoreDocShellState(browser=36, bc=94, ) [rr 502130 274902]RemoteWebNavigation.currentURI browser=36 bc=94 http://mochi.test:8888/#1 [rr 502130 274906]BrowsingContext::LoadURI(browser=36, bc=94, about:blank) From a previous restore we correctly wait for: 0 _restoreTabContent( <Failed to get argument while inspecting stack frame> <Failed to get argument while inspecting stack frame> ) ["resource:///modules/sessionstore/SessionStore.jsm":5984:30] <failed to get 'this' value> 1 _sendRestoreTabContent( <Failed to get argument while inspecting stack frame> <Failed to get argument while inspecting stack frame> ) ["resource:///modules/sessionstore/SessionStore.jsm":6002:11] <failed to get 'this' value> 2 restoreTabContent( <Failed to get argument while inspecting stack frame> <Failed to get argument while inspecting stack frame> ) ["resource:///modules/sessionstore/SessionStore.jsm":4684:9] <failed to get 'this' value> 3 restoreTab( <Failed to get argument while inspecting stack frame> <Failed to get argument while inspecting stack frame> ) ["resource:///modules/sessionstore/SessionStore.jsm":4565:13] <failed to get 'this' value> 4 restoreTabs( <Failed to get argument while inspecting stack frame> <Failed to get argument while inspecting stack frame> <Failed to get argument while inspecting stack frame> aSelectTab = "1") ["resource:///modules/sessionstore/SessionStore.jsm":4413:11] <failed to get 'this' value> 5 ssi_restoreWindow( <Failed to get argument while inspecting stack frame> <Failed to get argument while inspecting stack frame> <Failed to get argument while inspecting stack frame> ) ["resource:///modules/sessionstore/SessionStore.jsm":4189:11] <failed to get 'this' value> 6 _restoreWindowsFeaturesAndTabs( <Failed to get argument while inspecting stack frame> ) ["resource:///modules/sessionstore/SessionStore.jsm":4275:11] <failed to get 'this' value> 7 _restoreWindowsInReversedZOrder( <Failed to get argument while inspecting stack frame> ) ["resource:///modules/sessionstore/SessionStore.jsm":4299:9] <failed to get 'this' value> 8 ssi_restoreWindows/<( <Failed to get argument while inspecting stack frame> ) ["resource:///modules/sessionstore/SessionStore.jsm":4359:11] [rr 502506 275264]BrowsingContext::LoadURI(browser=36, bc=94, about:blank) [rr 502506 275268]DocumentChannelChild::AsyncOpen(browser=36, bc=94, about:blank) [rr 502130 275388]RemoteWebNavigation.currentURI browser=36 bc=94 http://mochi.test:8888/#1 [rr 502506 275629]BrowserChild::OnLocationChange(browser=36, bc=94, about:blank) [rr 502130 276944]updateForLocationChange browser=36 bc=94 - about:blank [rr 502130 277084]RemoteWebNavigation.currentURI browser=36 bc=94 about:blank [rr 502130 277358]RestoreDocShellState(browser=36, bc=94, http://example.com/browser/browser/base/content/test/tabs/file_new_tab_page.html) [rr 502506 277378]BrowserChild::OnLocationChange(browser=36, bc=94, http://example.com/browser/browser/base/content/test/tabs/file_new_tab_page.html) [rr 502130 277390]RemoteWebNavigation.currentURI browser=36 bc=94 about:blank [rr 502130 277554]BrowserParent::LoadURL(browser=36, bc=94, about:blank) From: #18 0x00007ff0bdb1efcc in mozilla::dom::BrowserParent::LoadURL(nsDocShellLoadState*) (this=0x7ff08f2b9800, aLoadState=0x7ff094e1d580) at /home/emilio/src/moz/gecko/dom/ipc/BrowserParent.cpp:861 #19 0x00007ff0bc1117f9 in nsFrameLoader::ReallyStartLoadingInternal() (this=0x7ff08f283400) at /home/emilio/src/moz/gecko/dom/base/nsFrameLoader.cpp:718 #20 0x00007ff0bc11129f in nsFrameLoader::ReallyStartLoading() (this=0x7ff08f283400) at /home/emilio/src/moz/gecko/dom/base/nsFrameLoader.cpp:640 #21 0x00007ff0bc0002f5 in mozilla::dom::Document::MaybeInitializeFinalizeFrameLoaders() (this=0x7ff0a17e2000) at /home/emilio/src/moz/gecko/dom/base/Document.cpp:9008 #22 0x00007ff0bc057891 in mozilla::detail::RunnableMethodArguments<>::applyImpl<mozilla::dom::Document, void (mozilla::dom::Document::*)()>(mozilla::dom::Document*, void (mozilla::dom::Document::*)(), mozilla::Tuple<>&, std::integer_sequence<unsigned long>) (o=<optimized out>, m=<optimized out>, args=<optimized out>) at /home/emilio/src/moz/gecko/obj-debug/dist/include/nsThreadUtils.h:1150 #23 mozilla::detail::RunnableMethodArguments<>::apply<mozilla::dom::Document, void (mozilla::dom::Document::*)()>(mozilla::dom::Document*, void (mozilla::dom::Document::*)()) (this=<optimized out>, o=<optimized out>, m=<optimized out>) at /home/emilio/src/moz/gecko/obj-debug/dist/include/nsThreadUtils.h:1156 #24 mozilla::detail::RunnableMethodImpl<mozilla::dom::Document*, void (mozilla::dom::Document::*)(), true, (mozilla::RunnableKind)0>::Run() (this=<optimized out>) at /home/emilio/src/moz/gecko/obj-debug/dist/include/nsThreadUtils.h:1203 #25 0x00007ff0bbef8209 in nsContentUtils::RemoveScriptBlocker() () at /home/emilio/src/moz/gecko/dom/base/nsContentUtils.cpp:5696 #26 0x00007ff0bc11c427 in nsAutoScriptBlocker::~nsAutoScriptBlocker() (this=<optimized out>) at /home/emilio/src/moz/gecko/obj-debug/dist/include/nsContentUtils.h:3499 #27 nsFrameLoaderOwner::ChangeRemotenessCommon(nsFrameLoaderOwner::ChangeRemotenessContextType const&, mozilla::dom::RemotenessChangeOptions const&, bool, bool, mozilla::dom::BrowsingContextGroup*, std::function<void ()>&, mozilla::ErrorResult&) (this=<optimized out>, this@entry=0x7ff0a041b608, aContextType=@0x7ffe238847fc: nsFrameLoaderOwner::ChangeRemotenessContextType::PRESERVE, aOptions= ..., aSwitchingInProgressLoad=false, aIsRemote=<optimized out>, aGroup=<optimized out>, aGroup@entry=0x0, aFrameLoaderInit=..., aRv=...) at /home/emilio/src/moz/gecko/dom/base/nsFrameLoaderOwner.cpp:191 #28 0x00007ff0bc11c81f in nsFrameLoaderOwner::ChangeRemoteness(mozilla::dom::RemotenessOptions const&, mozilla::ErrorResult&) (this=0x7ff0a041b608, aOptions=..., rv=...) at /home/emilio/src/moz/gecko/dom/base/nsFrameLoaderOwner.cpp:250 #29 0x00007ff0bcb59003 in mozilla::dom::XULFrameElement_Binding::changeRemoteness(JSContext*, JS::Handle<JSObject*>, void*, JSJitMethodCallArgs const&)Traceback (most recent call last): File "/home/emilio/src/moz/gecko/js/src/gdb/mozilla/Root.py", line 55, in to_string ptr = ptr.dereference() gdb.error: value has been optimized out (cx_=<optimized out>, obj= , void_self=<optimized out>, args=...) at XULFrameElementBinding.cpp:513 #30 0x00007ff0bcecc02a in mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions>(JSContext*, unsigned int, JS::Value*) (cx=0x1, cx@entry=0x7ff0a871b000, argc=<optimized out>, vp=<optimized out>) at /home/emilio/src/moz/gecko/dom/bindings/BindingUtils.cpp:3297 #31 0x00007ff0bf67b1f1 in CallJSNative(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), js::CallReason, JS::CallArgs const&) From: 0 updateBrowserRemoteness( <Failed to get argument while inspecting stack frame> <Failed to get argument while inspecting stack frame> ) ["chrome://browser/content/tabbrowser.js":1937:15] <failed to get 'this' value> 1 updateBrowserRemotenessByURL( <Failed to get argument while inspecting stack frame> aURL = ""http://example.com/browser/browser/base/content/test/tabs/file_new_tab_page.html"") ["chrome://browser/content/tabbrowser.js":2052:20] <failed to get 'this' value> 2 restoreTabContent( <Failed to get argument while inspecting stack frame> <Failed to get argument while inspecting stack frame> ) ["resource:///modules/sessionstore/SessionStore.jsm":4662:38] <failed to get 'this' value> 3 restoreTab( <Failed to get argument while inspecting stack frame> <Failed to get argument while inspecting stack frame> ) ["resource:///modules/sessionstore/SessionStore.jsm":4565:13] <failed to get 'this' value> 4 restoreTabs( <Failed to get argument while inspecting stack frame> <Failed to get argument while inspecting stack frame> <Failed to get argument while inspecting stack frame> aSelectTab = "2") ["resource:///modules/sessionstore/SessionStore.jsm":4413:11] <failed to get 'this' value> 5 ssi_restoreWindow( <Failed to get argument while inspecting stack frame> <Failed to get argument while inspecting stack frame> <Failed to get argument while inspecting stack frame> ) ["resource:///modules/sessionstore/SessionStore.jsm":4189:11] <failed to get 'this' value> 6 _restoreWindowsFeaturesAndTabs( <Failed to get argument while inspecting stack frame> ) ["resource:///modules/sessionstore/SessionStore.jsm":4275:11] <failed to get 'this' value> 7 _restoreWindowsInReversedZOrder( <Failed to get argument while inspecting stack frame> ) ["resource:///modules/sessionstore/SessionStore.jsm":4299:9] <failed to get 'this' value> 8 ssi_restoreWindows/<( <Failed to get argument while inspecting stack frame> ) ["resource:///modules/sessionstore/SessionStore.jsm":4359:11] This load triggers a remoteness change. [rr 502130 277558]RemoteWebNavigation.currentURI browser=36 bc=94 undefined [rr 502130 277561]RemoteWebNavigation.currentURI browser=36 bc=94 about:blank [rr 502130 277564]RestoreDocShellState(browser=36, bc=94, http://example.com/browser/browser/base/content/test/tabs/file_new_tab_page.html) [rr 502130 277568]RemoteWebNavigation.currentURI browser=36 bc=94 about:blank [rr 502130 277572]BrowsingContext::LoadURI(browser=36, bc=94, http://example.com/browser/browser/base/content/test/tabs/file_new_tab_page.html) This is the load that should actually end up in the browsing context. [rr 502578 280053]DocumentChannelChild::AsyncOpen(browser=36, bc=94, about:blank) From the previous remoteness update. [rr 502130 280138]RemoteWebNavigation.currentURI browser=36 bc=94 about:blank [rr 502130 280141]RemoteWebNavigation.currentURI browser=36 bc=94 about:blank [rr 502130 280143]RemoteWebNavigation.currentURI browser=36 bc=94 about:blank [rr 502130 280146]RemoteWebNavigation.currentURI browser=36 bc=94 about:blank At this point, we try to use the BFCache, and end up replacing the browsing context: #0 mozilla::dom::CanonicalBrowsingContext::AllowedInBFCache(mozilla::Maybe<unsigned long> const&) (this=0x7ff08f2b5800, aChannelId=...) at /home/emilio/src/moz/gecko/docshell/base/CanonicalBrowsingContext.cpp:2158 #1 0x00007ff0bb3157c1 in mozilla::net::DocumentLoadListener::MaybeTriggerProcessSwitch(bool*) (this=this@entry=0x7ff093b74090, aWillSwitchToRemote=aWillSwitchToRemote@entry=0x7ffe23887838) at /home/emilio/src/moz/gecko/netwerk/ipc/DocumentLoadListener.cpp:1723 #2 0x00007ff0bb317feb in mozilla::net::DocumentLoadListener::OnStartRequest(nsIRequest*) (this=0x7ff093b74090, aRequest=0x7ff0a0b7a3c8) at /home/emilio/src/moz/gecko/netwerk/ipc/DocumentLoadListener.cpp:2263 #3 0x00007ff0bb238a0c in mozilla::net::ParentChannelListener::OnStartRequest(nsIRequest*) (this=0x7ff08d5c4ee0, aRequest=0x7ff0a0b7a3c8) at /home/emilio/src/moz/gecko/netwerk/protocol/http/ParentChannelListener.cpp:91 #4 0x00007ff0bb9abec2 in nsDocumentOpenInfo::OnStartRequest(nsIRequest*) (this=<optimized out>, request=0x7ff0a0b7a3c8) at /home/emilio/src/moz/gecko/uriloader/base/nsURILoader.cpp:166 #5 0x00007ff0bb32baf0 in mozilla::net::ParentProcessDocumentOpenInfo::OnDocumentStartRequest(nsIRequest*) (this=0x7ff093bc5b80, request=0x7ff0a0b7a3c8) at /home/emilio/src/moz/gecko/netwerk/ipc/DocumentLoadListener.cpp:292 #6 0x00007ff0bae6446c in nsBaseChannel::OnStartRequest(nsIRequest*) (this=<optimized out>, request=<optimized out>) at /home/emilio/src/moz/gecko/netwerk/base/nsBaseChannel.cpp:833 #7 0x00007ff0bae82bdd in nsInputStreamPump::OnStateStart() (this=this@entry=0x7ff08f2593c0) at /home/emilio/src/moz/gecko/netwerk/base/nsInputStreamPump.cpp:481 #8 0x00007ff0bae828d9 in nsInputStreamPump::OnInputStreamReady(nsIAsyncInputStream*) (this=0x7ff08f2593c0, stream=<optimized out>) at /home/emilio/src/moz/gecko/netwerk/base/nsInputStreamPump.cpp:390 #9 0x00007ff0bae8339b in non-virtual thunk to nsInputStreamPump::OnInputStreamReady(nsIAsyncInputStream*) () at /home/emilio/src/moz/gecko/netwerk/base/nsInputStreamPump.cpp:632 #10 0x00007ff0bacd29d5 in mozilla::NonBlockingAsyncInputStream::RunAsyncWaitCallback(mozilla::NonBlockingAsyncInputStream::AsyncWaitRunnable*, already_AddRefed<nsIInputStreamCallback>) (this=this@entry=0x7ff094eb5a50, aRunnable=aRunnable@entry=0x7ff08f228560, aCallback=...) at /home/emilio/src/moz/gecko/xpcom/io/NonBlockingAsyncInputStream.cpp:397 #11 0x00007ff0bacdf2ec in mozilla::NonBlockingAsyncInputStream::AsyncWaitRunnable::Run() (this=0x7ff08f228560) at /home/emilio/src/moz/gecko/xpcom/io/NonBlockingAsyncInputStream.cpp:33 #12 0x00007ff0bad48d04 in mozilla::RunnableTask::Run() (this=0x7ff093bc5980) at /home/emilio/src/moz/gecko/xpcom/threads/TaskController.cpp:482 #13 0x00007ff0bad316d4 in mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) (this=<optimized out>, this@entry=0x7ff0c54f2400, aProofOfLock=...) at /home/emilio/src/moz/gecko/xpcom/threads/TaskController.cpp:766 #14 0x00007ff0bad3091d in mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) (this=this@entry=0x7ff0c54f2400, aProofOfLock=...) at /home/emilio/src/moz/gecko/xpcom/threads/TaskController.cpp:621 #15 0x00007ff0bad30a83 in mozilla::TaskController::ProcessPendingMTTask(bool) (this=0x7ff0c54f2400, aMayWait=false) at /home/emilio/src/moz/gecko/xpcom/threads/TaskController.cpp:405 #16 0x00007ff0bad4388f in mozilla::TaskController::InitializeInternal()::$_0::operator()() const (this=<optimized out>) at /home/emilio/src/moz/gecko/xpcom/threads/TaskController.cpp:138 #17 mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal()::$_0>::Run() (this=<optimized out>) at /home/emilio/src/moz/gecko/obj-debug/dist/include/nsThreadUtils.h:534 #18 0x00007ff0bad3b7f6 in nsThread::ProcessNextEvent(bool, bool*) (this=0x7ff0c541d680, aMayWait=false, aResult=0x7ffe23888437) at /home/emilio/src/moz/gecko/xpcom/threads/nsThread.cpp:1159 #19 0x00007ff0bad3f384 in NS_ProcessNextEvent(nsIThread*, bool) (aThread=0x7ff08f2b5800, aThread@entry=0x7ff0c541d680, aMayWait=false) at /home/emilio/src/moz/gecko/xpcom/threads/nsThreadUtils.cpp:548 #20 0x00007ff0bb43dfe0 in mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) (this=0x7ff0c54d12c0, aDelegate=0x7ff0c54353e0) at /home/emilio/src/moz/gecko/ipc/glue/MessagePump.cpp:85 #21 0x00007ff0bb3be7b7 in MessageLoop::RunInternal() (this=this@entry=0x7ff0c54353e0) at /home/emilio/src/moz/gecko/ipc/chromium/src/base/message_loop.cc:335 #22 0x00007ff0bb3be707 in MessageLoop::RunHandler() (this=0x7ff0c54353e0) at /home/emilio/src/moz/gecko/ipc/chromium/src/base/message_loop.cc:328 #23 MessageLoop::Run() (this=0x7ff0c54353e0) at /home/emilio/src/moz/gecko/ipc/chromium/src/base/message_loop.cc:310 #24 0x00007ff0bded2bdb in nsBaseAppShell::Run() (this=0x7ff0a880c580) at /home/emilio/src/moz/gecko/widget/nsBaseAppShell.cpp:137 #25 0x00007ff0bf449d85 in nsAppStartup::Run() (this=0x7ff0a883de20) at /home/emilio/src/moz/gecko/toolkit/components/startup/nsAppStartup.cpp:273 #26 0x00007ff0bf5428b6 in XREMain::XRE_mainRun() (this=<optimized out>, this@entry=0x7ffe238887c0) at /home/emilio/src/moz/gecko/toolkit/xre/nsAppRunner.cpp:5239 #27 0x00007ff0bf5433ef in XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) (this=this@entry=0x7ffe238887c0, argc=argc@entry=5, argv=argv@entry=0x7ffe23889a68, aConfig=<optimized out>) at /home/emilio/src/moz/gecko/toolkit/xre/nsAppRunner.cpp:5437 #28 0x00007ff0bf54385e in XRE_main(int, char**, mozilla::BootstrapConfig const&) (argc=-1816706824, argv=0x7ff0c56441a0, aConfig=...) at /home/emilio/src/moz/gecko/toolkit/xre/nsAppRunner.cpp:5496 #29 0x0000562d08f8e415 in do_main(int, char**, char**) (argc=-1816706824, argv=0x7ffe23889a68, envp=<optimized out>) at /home/emilio/src/moz/gecko/browser/app/nsBrowserApp.cpp:224 [rr 502130 280199]CanonicalBrowsingContext::ReplacedBy(94 -> 104) [rr 502130 280344]didChangeRemoteness browser=36, bc=104 [rr 502130 280348]RemoteWebNavigation.currentURI browser=36 bc=104 undefined [rr 502130 280625]RedirectToRealChannel(36, about:blank) [rr 502578 280695]BrowserChild::OnLocationChange(browser=36, bc=94, http://example.com/browser/browser/base/content/test/tabs/file_new_tab_page.html) [rr 502578 280699]BrowsingContext::LoadURI(browser=36, bc=94, http://example.com/browser/browser/base/content/test/tabs/file_new_tab_page.html) [rr 502578 280703]DocumentChannelChild::AsyncOpen(browser=36, bc=94, http://example.com/browser/browser/base/content/test/tabs/file_new_tab_page.html) This is the LoadURI call for the "final" load, however it went to the wrong browsing context, as we just replaced this! [rr 502130 280803]updateForLocationChange browser=36 bc=104 - http://example.com/browser/browser/base/content/test/tabs/file_new_tab_page.html [rr 502130 280807]RemoteWebNavigation.currentURI browser=36 bc=104 http://example.com/browser/browser/base/content/test/tabs/file_new_tab_page.html [rr 502578 281334]BrowserChild::OnLocationChange(browser=36, bc=104, about:blank) And this one is from the process switch. [rr 502130 281461]updateForLocationChange browser=36 bc=104 - about:blank [rr 502130 281465]RemoteWebNavigation.currentURI browser=36 bc=104 about:blank [rr 502130 282028] ⰲ겿{"action":"test_status","time":1621467211822,"thread":null,"pid":null,"source":"mochitest","test":"chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_new_tab_insert_position.js","subtest":"tab pos 0 matched http://mochi.test:8888/#0","status":"PASS","message":"","js_source":"TestRunner.js"}ⰲ겿 [rr 502130 282031]RemoteWebNavigation.currentURI browser=36 bc=104 about:blank [rr 502130 282033]RemoteWebNavigation.currentURI browser=36 bc=104 about:blank [rr 502130 282117] So this is certainly the easy fix, but I think we should generally try to deal with this better, somehow? Differential Revision: https://phabricator.services.mozilla.com/D115560
9bf3f478c70f75945100464ba8abeb9d07f238be: Bug 1535913 - Part 3: Mark nsWrapperCache as JS_HAZ_ROOTED, r=sfink,peterv
Nika Layzell <nika@thelayzells.com> - Wed, 26 May 2021 15:25:44 +0000 - rev 580765
Push 38493 by imoraru@mozilla.com at Wed, 26 May 2021 21:17:56 +0000
Bug 1535913 - Part 3: Mark nsWrapperCache as JS_HAZ_ROOTED, r=sfink,peterv This was recommended by sfink as a solution to the issue where the custom deleter UniquePtr added by earlier parts of this patch caused rooting failures when the hazard analysis identified it as needing rooting due to containing a manually managed unrooted `JSObject*`. Differential Revision: https://phabricator.services.mozilla.com/D115705
51ac7ee1f56d0aeb3a16291d3f18d33bdaa8cc66: Part 10: Bug 1700623 - Wait for history navigation in browser_history_menu.js r=peterv
Andreas Farre <farre@mozilla.com> - Wed, 26 May 2021 07:14:07 +0000 - rev 580710
Push 38492 by cbrindusan@mozilla.com at Wed, 26 May 2021 16:02:53 +0000
Part 10: Bug 1700623 - Wait for history navigation in browser_history_menu.js r=peterv Differential Revision: https://phabricator.services.mozilla.com/D115898
4f967aad4863c7d2e6822693c515dad195e179aa: Part 4: Bug 1700623 - Add js value conversion for Record. r=peterv
Andreas Farre <farre@mozilla.com> - Wed, 26 May 2021 07:14:05 +0000 - rev 580704
Push 38492 by cbrindusan@mozilla.com at Wed, 26 May 2021 16:02:53 +0000
Part 4: Bug 1700623 - Add js value conversion for Record. r=peterv Depends on D111430 Differential Revision: https://phabricator.services.mozilla.com/D111431
42950d690acd9a5ec81a3b86a3c8dbf4b7c9cebf: Bug 1711821 - Word around GCC bug with nodiscard forwarded nullptr r=peterv
Mike Hommey <mh+mozilla@glandium.org> - Tue, 25 May 2021 20:12:07 +0000 - rev 580656
Push 38491 by malexandru@mozilla.com at Wed, 26 May 2021 09:48:46 +0000
Bug 1711821 - Word around GCC bug with nodiscard forwarded nullptr r=peterv Differential Revision: https://phabricator.services.mozilla.com/D115458
22d00196ed653e11e4050d841245e92a37e11727: Bug 1711753 - Ensure the right URI is used when exempting about: pages from bfcache, r=peterv,marionette-reviewers,whimboo
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 25 May 2021 12:38:55 +0000 - rev 580608
Push 38491 by malexandru@mozilla.com at Wed, 26 May 2021 09:48:46 +0000
Bug 1711753 - Ensure the right URI is used when exempting about: pages from bfcache, r=peterv,marionette-reviewers,whimboo This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1710380 and https://bugzilla.mozilla.org/show_bug.cgi?id=1711733 Differential Revision: https://phabricator.services.mozilla.com/D115602
c26cb04cffdc531c2cc7654aa390e5d8e6a5dc74: Bug 1712355 - Modal dialogs are broken with Fission+BFCache, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 25 May 2021 12:34:05 +0000 - rev 580607
Push 38491 by malexandru@mozilla.com at Wed, 26 May 2021 09:48:46 +0000
Bug 1712355 - Modal dialogs are broken with Fission+BFCache, r=peterv This fixes webdriver/tests/forward/user_prompts.py Differential Revision: https://phabricator.services.mozilla.com/D115761
77d4ae2c214b962030fe2eba4436b8875f201f99: Bug 1711643 - Make layout/base/tests/browser_disableDialogs_onbeforeunload.js work with Fission and BFCache, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 25 May 2021 12:28:56 +0000 - rev 580606
Push 38491 by malexandru@mozilla.com at Wed, 26 May 2021 09:48:46 +0000
Bug 1711643 - Make layout/base/tests/browser_disableDialogs_onbeforeunload.js work with Fission and BFCache, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D115351
425bf307a190bb697e1dc39cded488d50e789fbc: Bug 1711729 - Make browser/components/search/test/browser/browser_search_telemetry_sources_ads.js pass with Fission+BFCache by marking bfcache loads coming from shistory, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 25 May 2021 12:28:07 +0000 - rev 580605
Push 38491 by malexandru@mozilla.com at Wed, 26 May 2021 09:48:46 +0000
Bug 1711729 - Make browser/components/search/test/browser/browser_search_telemetry_sources_ads.js pass with Fission+BFCache by marking bfcache loads coming from shistory, r=peterv With the patch the correct flag is passed up to here https://searchfox.org/mozilla-central/rev/6e630edb09c3ab06d0103665b16c9ea7dce782c5/browser/components/search/SearchSERPTelemetry.jsm#233-234 Differential Revision: https://phabricator.services.mozilla.com/D115639
b586b87e1135dd7b3f0726803b407faad4a070b4: Bug 1710687, null check mDocShell before using it, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 25 May 2021 12:25:41 +0000 - rev 580604
Push 38491 by malexandru@mozilla.com at Wed, 26 May 2021 09:48:46 +0000
Bug 1710687, null check mDocShell before using it, r=peterv The patch is based on code inspection. SizeShell may run scripts https://searchfox.org/mozilla-central/rev/cecdac0aa5733fee515a166b6e31e38cc58abf32/xpfe/appshell/AppWindow.cpp#1180,1182 The patch is very conservative. It keeps returning success code in the cases where it would return such without the patch and only adds null check right before accessing mDocShell. mDebuting value stays false after the method call. Differential Revision: https://phabricator.services.mozilla.com/D115249
88b4add342dfc6fed5de4882b71a37a01960d3ab: Part 4: Bug 1700623 - Add js value conversion for Record. r=peterv
Andreas Farre <farre@mozilla.com> - Thu, 20 May 2021 12:48:21 +0000 - rev 580247
Push 38479 by malexandru@mozilla.com at Fri, 21 May 2021 09:57:54 +0000
Part 4: Bug 1700623 - Add js value conversion for Record. r=peterv Depends on D111430 Differential Revision: https://phabricator.services.mozilla.com/D111431
f7d5b505bd15ad9c10005eecd5dc81b8bc08d0cd: Bug 1710064 - Remove FillPropertyDescriptor. r=peterv
Tom Schuster <evilpies@gmail.com> - Tue, 11 May 2021 09:23:18 +0000 - rev 579325
Push 38453 by cbrindusan@mozilla.com at Tue, 11 May 2021 16:15:28 +0000
Bug 1710064 - Remove FillPropertyDescriptor. r=peterv I hope I got all the PropertyAttributes right, it's easy to get them confused. Differential Revision: https://phabricator.services.mozilla.com/D114595
a76cd358f3037775e8bae268eb8750914990e044: Bug 1708698 - Stop using PropertyDescriptor object in browser. r=peterv
Tom Schuster <evilpies@gmail.com> - Fri, 07 May 2021 12:29:06 +0000 - rev 578849
Push 38445 by imoraru@mozilla.com at Fri, 07 May 2021 21:46:25 +0000
Bug 1708698 - Stop using PropertyDescriptor object in browser. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D113978
f706cd480af2793a40b6996edb508ca401d0db43: Bug 1708698 - Use Maybe<PropertyDescriptor> for Xray resolveOwnProperty and a lot of related code. r=peterv
Tom Schuster <evilpies@gmail.com> - Fri, 07 May 2021 12:29:05 +0000 - rev 578847
Push 38445 by imoraru@mozilla.com at Fri, 07 May 2021 21:46:25 +0000
Bug 1708698 - Use Maybe<PropertyDescriptor> for Xray resolveOwnProperty and a lot of related code. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D113976
191c385d72f71eea331944dcc9308f162d618be6: Bug 1709099 - Remove unused argment from FakeArgument; r=peterv
Edgar Chen <echen@mozilla.com> - Thu, 06 May 2021 22:46:48 +0000 - rev 578796
Push 38443 by nbeleuzu@mozilla.com at Fri, 07 May 2021 09:52:21 +0000
Bug 1709099 - Remove unused argment from FakeArgument; r=peterv Differential Revision: https://phabricator.services.mozilla.com/D114106
ff493a044fa1e3f83c19e3f7f23e3c3bea807c3e: Bug 1704185 - Rename JS::GetRealmWeakMapKey to JS::GetRealmKeyObject. r=peterv
Tooru Fujisawa <arai_a@mac.com> - Tue, 04 May 2021 23:48:26 +0000 - rev 578539
Push 38435 by imoraru@mozilla.com at Wed, 05 May 2021 09:52:49 +0000
Bug 1704185 - Rename JS::GetRealmWeakMapKey to JS::GetRealmKeyObject. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D111635
5ce22f80566d24f6a1f8c759c1e9c598c98e5043: Bug 1707870 - Stop generating empty namespace block; r=peterv
Edgar Chen <echen@mozilla.com> - Mon, 03 May 2021 08:58:56 +0000 - rev 578294
Push 38429 by ncsoregi@mozilla.com at Mon, 03 May 2021 15:32:34 +0000
Bug 1707870 - Stop generating empty namespace block; r=peterv Differential Revision: https://phabricator.services.mozilla.com/D113502
bcd3275d4ab6480e7de89e7deb22b2a8bf7e913d: Bug 1705734 - Enable BFCache for pages with *unload event listeners on Android, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Fri, 30 Apr 2021 11:17:01 +0000 - rev 578151
Push 38421 by abutkovits@mozilla.com at Fri, 30 Apr 2021 15:34:51 +0000
Bug 1705734 - Enable BFCache for pages with *unload event listeners on Android, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D112824
dccbd5752b0584565c92aafa7997f3462203154e: Bug 1703607 - Exempt about:*pages from new bfcache, with the exception of about:blank, r=peterv
Anny Gakhokidze <agakhokidze@mozilla.com> - Wed, 28 Apr 2021 20:17:35 +0000 - rev 577890
Push 38417 by imoraru@mozilla.com at Thu, 29 Apr 2021 09:26:05 +0000
Bug 1703607 - Exempt about:*pages from new bfcache, with the exception of about:blank, r=peterv This also fixes test browser/base/content/test/tabs/browser_navigate_through_urls_origin_attributes.js which was failing for fission + bfcacheInParent, because about:privatebrowsing was getting bfcached, and an extra XULFrameLoaderCreated event was firing, when we were not expecting it. Differential Revision: https://phabricator.services.mozilla.com/D112441
87d9ec38423ca57c65b01723a2274c93ecc0d9ec: Bug 1705734 - Enable BFCache for pages with *unload event listeners on Android, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 27 Apr 2021 23:30:33 +0000 - rev 577734
Push 38413 by abutkovits@mozilla.com at Wed, 28 Apr 2021 03:32:08 +0000
Bug 1705734 - Enable BFCache for pages with *unload event listeners on Android, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D112824
4752e6175a836df23a25ecef9d076a57e98e859f: Bug 1706090 - Only allow unload event listeners in bfcache when doing cross-site navigation, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 27 Apr 2021 23:30:17 +0000 - rev 577733
Push 38413 by abutkovits@mozilla.com at Wed, 28 Apr 2021 03:32:08 +0000
Bug 1706090 - Only allow unload event listeners in bfcache when doing cross-site navigation, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D112621
85701d6f7ab006363a5efbacbead76275965173a: Bug 1707721 - Fix the comment for BindingJSObjectCreator; r=peterv
Edgar Chen <echen@mozilla.com> - Tue, 27 Apr 2021 09:34:12 +0000 - rev 577597
Push 38410 by nbeleuzu@mozilla.com at Tue, 27 Apr 2021 15:52:11 +0000
Bug 1707721 - Fix the comment for BindingJSObjectCreator; r=peterv Differential Revision: https://phabricator.services.mozilla.com/D113414
b4bbe5069c9e268f41fa23a81653326d007bbb99: Bug 1704068 - Enable test_multi_sharedWorker_lifetimes_bfcache.html on Fission, r=peterv,emilio
Olli Pettay <Olli.Pettay@helsinki.fi> - Mon, 26 Apr 2021 22:25:58 +0000 - rev 577551
Push 38409 by imoraru@mozilla.com at Tue, 27 Apr 2021 09:55:09 +0000
Bug 1704068 - Enable test_multi_sharedWorker_lifetimes_bfcache.html on Fission, r=peterv,emilio Differential Revision: https://phabricator.services.mozilla.com/D111403