searching for reviewer(pehrsons)
e4a3279a2c72a90a20292b0ee9e7de0fafdb2833: Bug 1812293: Remove this code that was breaking the replaceTrack(null->non-null) case. r=pehrsons
Byron Campen [:bwc] <docfaraday@gmail.com> - Tue, 31 Jan 2023 16:46:23 +0000 - rev 651071
Push 40593 by nfay@mozilla.com at Wed, 01 Feb 2023 03:47:20 +0000
Bug 1812293: Remove this code that was breaking the replaceTrack(null->non-null) case. r=pehrsons We don't need to do anything like this, since setting the nullptr on the pipeline accomplishes what we want here. Differential Revision: https://phabricator.services.mozilla.com/D168388
9bc3e4eee40fec8ddeab5794082d5ad4ea9e0229: Bug 1775945 - Improve error logging in browser/base/content/test/webrtc/get_user_media.html and friends. r=pehrsons
Jan-Ivar Bruaroey <jib@mozilla.com> - Tue, 31 Jan 2023 08:08:45 +0000 - rev 651020
Push 40592 by nfay@mozilla.com at Tue, 31 Jan 2023 21:03:46 +0000
Bug 1775945 - Improve error logging in browser/base/content/test/webrtc/get_user_media.html and friends. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D168165
a169fe7133a80920b9c40f7af9f39b6f04147d31: Bug 1804288 - (fix-de7ae5755b) reimplement Bug 1748458 - Add TRACE_EVENTs for dropped frames and packets for received video. r=pehrsons
Michael Froman <mfroman@mozilla.com> - Fri, 09 Dec 2022 15:10:37 +0000 - rev 646383
Push 40485 by archaeopteryx@coole-files.de at Thu, 15 Dec 2022 19:31:35 +0000
Bug 1804288 - (fix-de7ae5755b) reimplement Bug 1748458 - Add TRACE_EVENTs for dropped frames and packets for received video. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D163960
c9ca285ff1d7a691770e1c2d4ddc1aa150a73274: Bug 1804288 - (fix-de7ae5755b) reimplement Bug 1742181 - libwebrtc: Implement packetsDiscarded bookkeeping for received video. r=pehrsons
Michael Froman <mfroman@mozilla.com> - Fri, 09 Dec 2022 15:10:37 +0000 - rev 646382
Push 40485 by archaeopteryx@coole-files.de at Thu, 15 Dec 2022 19:31:35 +0000
Bug 1804288 - (fix-de7ae5755b) reimplement Bug 1742181 - libwebrtc: Implement packetsDiscarded bookkeeping for received video. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D163959
e2341923b50f797eb9cc93296708407df2f50455: Bug 1401592: Teach RTCRtpSender to detect encoding config changes. r=mjf,pehrsons
Byron Campen <docfaraday@gmail.com> - Tue, 13 Dec 2022 23:21:59 +0000 - rev 645951
Push 40481 by ctuns@mozilla.com at Wed, 14 Dec 2022 16:24:11 +0000
Bug 1401592: Teach RTCRtpSender to detect encoding config changes. r=mjf,pehrsons JsepTrack used to be in charge of this, but because JSEP doesn't negotiate encoding constraints, it did not make sense to delegate this to the JSEP code. Differential Revision: https://phabricator.services.mozilla.com/D156831
fffc015a5dd5a37b2808a1c4909f4cb1b00d0eb1: Bug 1401592: Teach RTCRtpSender to detect encoding config changes. r=mjf,pehrsons
Byron Campen <docfaraday@gmail.com> - Tue, 13 Dec 2022 16:32:20 +0000 - rev 645870
Push 40480 by nfay@mozilla.com at Wed, 14 Dec 2022 03:34:16 +0000
Bug 1401592: Teach RTCRtpSender to detect encoding config changes. r=mjf,pehrsons JsepTrack used to be in charge of this, but because JSEP doesn't negotiate encoding constraints, it did not make sense to delegate this to the JSEP code. Differential Revision: https://phabricator.services.mozilla.com/D156831
76da88472c6aa4efa63cf5746cb52bb475a9f3cd: Bug 1802908 - Setting minimum size CalculateScaledResolution can return.;r=pehrsons
Dan Baker <dbaker@mozilla.com> - Tue, 29 Nov 2022 15:29:46 +0000 - rev 644013
Push 40441 by imoraru@mozilla.com at Tue, 29 Nov 2022 21:47:49 +0000
Bug 1802908 - Setting minimum size CalculateScaledResolution can return.;r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D163266
17b58f33097cb7d54145e882884d9bf6f2b19ce2: Bug 1802520 - Allow disabling real-time callback tracing in configure. r=glandium,pehrsons,media-playback-reviewers,alwu
Paul Adenot <paul@paul.cx> - Tue, 29 Nov 2022 15:29:08 +0000 - rev 644011
Push 40441 by imoraru@mozilla.com at Tue, 29 Nov 2022 21:47:49 +0000
Bug 1802520 - Allow disabling real-time callback tracing in configure. r=glandium,pehrsons,media-playback-reviewers,alwu Differential Revision: https://phabricator.services.mozilla.com/D163111
8620d07f80547ab4fd461bdade3471f740258841: Bug 1799932: Ensure that we re-create the send audio stream if the extmap changes. r=pehrsons
Byron Campen [:bwc] <docfaraday@gmail.com> - Wed, 16 Nov 2022 22:06:35 +0000 - rev 642582
Push 40411 by sstanca@mozilla.com at Thu, 17 Nov 2022 09:39:01 +0000
Bug 1799932: Ensure that we re-create the send audio stream if the extmap changes. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D161817
90d6fd91376559f3e3b588055285b6ff297df972: Bug 1799932: Test-case for bug. r=pehrsons,mjf
Byron Campen [:bwc] <docfaraday@gmail.com> - Wed, 16 Nov 2022 22:06:34 +0000 - rev 642581
Push 40411 by sstanca@mozilla.com at Thu, 17 Nov 2022 09:39:01 +0000
Bug 1799932: Test-case for bug. r=pehrsons,mjf Differential Revision: https://phabricator.services.mozilla.com/D161816
f130aa968d7eac720e17f4ddef0fec9b57a11d08: Bug 1797362 - Test that downmixing is done appropriately (or not performed) in pass through and non-pass through audio input processing mode. r=pehrsons
Paul Adenot <paul@paul.cx> - Tue, 15 Nov 2022 14:01:45 +0000 - rev 642446
Push 40406 by abutkovits@mozilla.com at Tue, 15 Nov 2022 16:44:51 +0000
Bug 1797362 - Test that downmixing is done appropriately (or not performed) in pass through and non-pass through audio input processing mode. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D161597
07b6b9a7b10186a60f59e5e5778c630176dc3f12: Bug 1797362 - When downmixing audio input that has more than two channels before passing it to webrtc::AudioProcessing, scale by the number of channels to avoid clipping. r=pehrsons
Paul Adenot <paul@paul.cx> - Tue, 15 Nov 2022 14:01:44 +0000 - rev 642445
Push 40406 by abutkovits@mozilla.com at Tue, 15 Nov 2022 16:44:51 +0000
Bug 1797362 - When downmixing audio input that has more than two channels before passing it to webrtc::AudioProcessing, scale by the number of channels to avoid clipping. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D161580
7a27746212225f70b4b3b378f4d03ee8f2550b8b: Bug 1790097 (MOZ) - handle upstream removing SharedModuleThread and changes to Call::Create signatures r=ng,pehrsons
Michael Froman <mfroman@mozilla.com> - Wed, 12 Oct 2022 15:27:52 +0000 - rev 641946
Push 40401 by archaeopteryx@coole-files.de at Mon, 14 Nov 2022 19:15:40 +0000
Bug 1790097 (MOZ) - handle upstream removing SharedModuleThread and changes to Call::Create signatures r=ng,pehrsons Depends on D159096 Differential Revision: https://phabricator.services.mozilla.com/D159097
f2a77659167f9281a97e0b10fd6c45b105382f37: Bug 1797362 - Test that downmixing is done appropriately (or not performed) in pass through and non-pass through audio input processing mode. r=pehrsons
Paul Adenot <paul@paul.cx> - Thu, 10 Nov 2022 17:18:03 +0000 - rev 640977
Push 40394 by sstanca@mozilla.com at Fri, 11 Nov 2022 09:37:17 +0000
Bug 1797362 - Test that downmixing is done appropriately (or not performed) in pass through and non-pass through audio input processing mode. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D161597
277a489162955bcd58feaa3062ae07f9c89fb319: Bug 1797362 - When downmixing audio input that has more than two channels before passing it to webrtc::AudioProcessing, scale by the number of channels to avoid clipping. r=pehrsons
Paul Adenot <paul@paul.cx> - Thu, 10 Nov 2022 17:18:03 +0000 - rev 640976
Push 40394 by sstanca@mozilla.com at Fri, 11 Nov 2022 09:37:17 +0000
Bug 1797362 - When downmixing audio input that has more than two channels before passing it to webrtc::AudioProcessing, scale by the number of channels to avoid clipping. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D161580
48fab6b48e09127d7a069cc855074ad8441a817a: Bug 1797362 - Test that downmixing is done appropriately (or not performed) in pass through and non-pass through audio input processing mode. r=pehrsons
Paul Adenot <paul@paul.cx> - Wed, 09 Nov 2022 10:09:38 +0000 - rev 640793
Push 40391 by imoraru@mozilla.com at Thu, 10 Nov 2022 04:48:58 +0000
Bug 1797362 - Test that downmixing is done appropriately (or not performed) in pass through and non-pass through audio input processing mode. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D161597
3a8f0fce898a18681f0e604259df4d756e12582a: Bug 1797362 - When downmixing audio input that has more than two channels before passing it to webrtc::AudioProcessing, scale by the number of channels to avoid clipping. r=pehrsons
Paul Adenot <paul@paul.cx> - Wed, 09 Nov 2022 10:09:38 +0000 - rev 640792
Push 40391 by imoraru@mozilla.com at Thu, 10 Nov 2022 04:48:58 +0000
Bug 1797362 - When downmixing audio input that has more than two channels before passing it to webrtc::AudioProcessing, scale by the number of channels to avoid clipping. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D161580
1c151606ed1ca94364da60d2c1424ba6584e057a: Bug 1797720 - Add DataMutex around VideoStreamFactory;r=pehrsons
Dan Baker <dbaker@mozilla.com> - Mon, 31 Oct 2022 14:13:26 +0000 - rev 639802
Push 40364 by mlaza@mozilla.com at Mon, 31 Oct 2022 21:44:52 +0000
Bug 1797720 - Add DataMutex around VideoStreamFactory;r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D160654
a88d85edd043ff8127171c48971684c1ecefb9cf: Bug 1797720 - Add DataMutex around VideoStreamFactory;r=pehrsons
Dan Baker <dbaker@mozilla.com> - Sat, 29 Oct 2022 13:26:07 +0000 - rev 639695
Push 40357 by abutkovits@mozilla.com at Sat, 29 Oct 2022 21:29:04 +0000
Bug 1797720 - Add DataMutex around VideoStreamFactory;r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D160654
7e93137be3fcda99964233860f10e04de8a04bbd: Bug 1795119 - Handle IPC failure about invalid webrtc video engine. r=pehrsons
Christian Holler <choller@mozilla.com> - Fri, 28 Oct 2022 11:40:43 +0000 - rev 639606
Push 40355 by smolnar@mozilla.com at Fri, 28 Oct 2022 21:22:11 +0000
Bug 1795119 - Handle IPC failure about invalid webrtc video engine. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D160518
59510b8c5384ab3819a1ae737c4095cfdd067788: Bug 1797479 - Disable two diagnostic asserts in IPC fuzzing. r=pehrsons
Christian Holler <choller@mozilla.com> - Wed, 26 Oct 2022 12:35:22 +0000 - rev 639358
Push 40348 by smolnar@mozilla.com at Wed, 26 Oct 2022 16:23:36 +0000
Bug 1797479 - Disable two diagnostic asserts in IPC fuzzing. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D160357
03d3f61f80e66a6737a4cd995e37d9460becb507: Bug 1780310 - Let libwebrtc not VideoConduit be responsible for scaling video frames for encoding;r=pehrsons
Dan Baker <dbaker@mozilla.com> - Tue, 25 Oct 2022 16:22:05 +0000 - rev 639209
Push 40347 by imoraru@mozilla.com at Wed, 26 Oct 2022 03:47:46 +0000
Bug 1780310 - Let libwebrtc not VideoConduit be responsible for scaling video frames for encoding;r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D158537
f802366520fd00e94d812feaf81cdbd8bc382e81: Bug 1780310 - Let libwebrtc not VideoConduit be responsible for scaling video frames for encoding;r=pehrsons
Dan Baker <dbaker@mozilla.com> - Tue, 25 Oct 2022 14:16:13 +0000 - rev 639068
Push 40347 by imoraru@mozilla.com at Wed, 26 Oct 2022 03:47:46 +0000
Bug 1780310 - Let libwebrtc not VideoConduit be responsible for scaling video frames for encoding;r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D158537
c715a8dc7fae9934ad5625ca70c36ccc516ffcf6: Bug 1596464 - Statically check that we can static_cast a Gecko ChannelLayout to a cubeb_channel_layout. r=pehrsons
Paul Adenot <paul@paul.cx> - Thu, 13 Oct 2022 08:19:23 +0000 - rev 637762
Push 40313 by ncsoregi@mozilla.com at Thu, 13 Oct 2022 15:46:47 +0000
Bug 1596464 - Statically check that we can static_cast a Gecko ChannelLayout to a cubeb_channel_layout. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D159172
e95bf356c0e5f198ad9a30237f9487716fd8327e: Bug 1786306 de-virtualize some methods that are not overridden r=pehrsons
Karl Tomlinson <karlt+@karlt.net> - Fri, 30 Sep 2022 04:13:33 +0000 - rev 636682
Push 40277 by ncsoregi@mozilla.com at Fri, 30 Sep 2022 21:44:39 +0000
Bug 1786306 de-virtualize some methods that are not overridden r=pehrsons These might not have been overridden since https://hg.mozilla.org/mozilla-central/rev/09943651fa85#l15.50 and https://hg.mozilla.org/mozilla-central/rev/9d11ad3a0bf4#l2.89 Depends on D158303 Differential Revision: https://phabricator.services.mozilla.com/D158304
4efaf464a6796fad7a56478020fc7f97f346daef: Bug 1703522. Allow IOSurface capture by default. r=pehrsons
Jeff Muizelaar <jmuizelaar@mozilla.com> - Wed, 14 Sep 2022 14:42:51 +0000 - rev 635514
Push 40236 by abutkovits@mozilla.com at Wed, 14 Sep 2022 21:36:49 +0000
Bug 1703522. Allow IOSurface capture by default. r=pehrsons This cuts the time spent in CaptureFrame for a buffer size of 3072x1920 from ~80ms to ~22ms for me. It makes it so that we use the IOSurfaces provided to the CGDisplayStreamCreate handler instead of calling CGDisplayCreateImage. It was enable by default in Chromium in 2018 via https://source.chromium.org/chromium/chromium/src/+/09cd5826e743af9dbcbde8ab36f73f5e0bd55f6c Differential Revision: https://phabricator.services.mozilla.com/D157273
dee18f437555de463cb1bf10c7868768a2af4cce: Bug 1788790 - Using TimeDelta instead of TimeStamp to allow for negative values when given non spec ntp;r=pehrsons
Dan Baker <dbaker@mozilla.com> - Mon, 12 Sep 2022 22:15:33 +0000 - rev 635306
Push 40231 by nfay@mozilla.com at Tue, 13 Sep 2022 09:28:17 +0000
Bug 1788790 - Using TimeDelta instead of TimeStamp to allow for negative values when given non spec ntp;r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D156243
ba0032034e682e02930b6edc0d36c9a1686cf628: Bug 1783764 - Rename MediaEngineDefault to MediaEngineFake and change Default to Fake inside files.;r=webrtc-reviewers,bwc,pehrsons
Dan Baker <dbaker@mozilla.com> - Fri, 12 Aug 2022 16:54:39 +0000 - rev 627029
Push 40121 by abutkovits@mozilla.com at Sat, 13 Aug 2022 09:22:39 +0000
Bug 1783764 - Rename MediaEngineDefault to MediaEngineFake and change Default to Fake inside files.;r=webrtc-reviewers,bwc,pehrsons Differential Revision: https://phabricator.services.mozilla.com/D154432
eff158481883b600835cfb558ebe727336a48aec: Bug 1238038 - Create a cubeb input stream wrapper r=padenot,pehrsons
Chun-Min Chang <chun.m.chang@gmail.com> - Mon, 18 Apr 2022 18:45:35 +0000 - rev 614503
Push 39583 by imoraru@mozilla.com at Tue, 19 Apr 2022 03:41:49 +0000
Bug 1238038 - Create a cubeb input stream wrapper r=padenot,pehrsons To add a non-native input source in the MediaTrackGraph, we need a input-only cubeb stream. This patch implements a light-weight wrapper to operate the C style Cubeb APIs in a C++-friendly way. Depends on D143101 Differential Revision: https://phabricator.services.mozilla.com/D116535
3aef6c404e07742214a5e3c1ccbcbd2ad1eee959: Bug 1742655 - Rename AudioInputTrack to AudioProcessingTrack r=pehrsons
Chun-Min Chang <chun.m.chang@gmail.com> - Thu, 27 Jan 2022 22:29:35 +0000 - rev 605764
Push 39205 by abutkovits@mozilla.com at Fri, 28 Jan 2022 04:41:16 +0000
Bug 1742655 - Rename AudioInputTrack to AudioProcessingTrack r=pehrsons Depends on D134628 Differential Revision: https://phabricator.services.mozilla.com/D134629
b004b579d1ce8fa91acc2330c436340b099ceccd: Bug 1742655 - Rename functions r=pehrsons
Chun-Min Chang <chun.m.chang@gmail.com> - Thu, 27 Jan 2022 22:29:35 +0000 - rev 605763
Push 39205 by abutkovits@mozilla.com at Fri, 28 Jan 2022 04:41:16 +0000
Bug 1742655 - Rename functions r=pehrsons Rename {Close, Open}AudioInput to {Disc, C}onnectDeviceInput Depends on D134533 Differential Revision: https://phabricator.services.mozilla.com/D134628
8cb7b8231c980aa7830fad2ecc34cb128417d511: Bug 1742655 - Open/Close audio input via NativeInputTrack r=pehrsons
Chun-Min Chang <chun.m.chang@gmail.com> - Thu, 27 Jan 2022 22:29:35 +0000 - rev 605762
Push 39205 by abutkovits@mozilla.com at Fri, 28 Jan 2022 04:41:16 +0000
Bug 1742655 - Open/Close audio input via NativeInputTrack r=pehrsons Move the audio-opening check logic and the creation of NativeInputTrack in one place instead of seperating them in different functions. This reduces the complexity of audio-opening logic in MediaTrackGraph and make it easier to test. Depends on D134627 Differential Revision: https://phabricator.services.mozilla.com/D134533
a1def130c1053111631562df9dbf3545356bc448: Bug 1742655 - Remove NotifyOutputData from NativeInputTrack r=pehrsons
Chun-Min Chang <chun.m.chang@gmail.com> - Thu, 27 Jan 2022 22:29:34 +0000 - rev 605761
Push 39205 by abutkovits@mozilla.com at Fri, 28 Jan 2022 04:41:16 +0000
Bug 1742655 - Remove NotifyOutputData from NativeInputTrack r=pehrsons Depends on D134532 Differential Revision: https://phabricator.services.mozilla.com/D134627
b0a8837110dbafad735178ebd0c640efa7517e0b: Bug 1742655 - Add MaxRequestedInputChannels and HasVoiceInput r=pehrsons
Chun-Min Chang <chun.m.chang@gmail.com> - Thu, 27 Jan 2022 22:29:34 +0000 - rev 605760
Push 39205 by abutkovits@mozilla.com at Fri, 28 Jan 2022 04:41:16 +0000
Bug 1742655 - Add MaxRequestedInputChannels and HasVoiceInput r=pehrsons Implement utility functions to query the input channel count and whether input has voice from NativeInputTrack's users Depends on D134527 Differential Revision: https://phabricator.services.mozilla.com/D134532
ae191833e3afd809ff78bc5aa5b6c38c80e90f2d: Bug 1742655 - Remove mDeviceTrackMap in MediaTrackGraph r=pehrsons
Chun-Min Chang <chun.m.chang@gmail.com> - Thu, 27 Jan 2022 22:29:33 +0000 - rev 605759
Push 39205 by abutkovits@mozilla.com at Fri, 28 Jan 2022 04:41:16 +0000
Bug 1742655 - Remove mDeviceTrackMap in MediaTrackGraph r=pehrsons mDeviceTrackMap only has one element since MediaTrackGraph can have only one input device. Besides, we can get NativeInputTrack directly from mTracks on graph thread without accessing it from mDeviceTrackMap. The only left reason for having mDeviceTrackMap is to check if we have any input device on Android. On Android, the default input device id is always nullptr, so we use a hashmap to check if MediaTrackGraph contains any input device. However, this hashmap can be replaced by a RefPtr storing the MediaTrack for the input device since MediaTrackGraph can have only one input device. Depends on D134530 Differential Revision: https://phabricator.services.mozilla.com/D134527
dc7fbea824ed13940f48a80866a0881d620c8336: Bug 1742655 - Track AudioDeviceID in NativeInputTrack r=pehrsons
Chun-Min Chang <chun.m.chang@gmail.com> - Thu, 27 Jan 2022 22:29:33 +0000 - rev 605758
Push 39205 by abutkovits@mozilla.com at Fri, 28 Jan 2022 04:41:16 +0000
Bug 1742655 - Track AudioDeviceID in NativeInputTrack r=pehrsons NativeInputTrack should have a AudioDeviceID value indicating what device its audio source is from Depends on D134529 Differential Revision: https://phabricator.services.mozilla.com/D134530
5e5441649e645065b1161d45926454861b096845: Bug 1742655 - Reword outdated comments r=pehrsons
Chun-Min Chang <chun.m.chang@gmail.com> - Thu, 27 Jan 2022 22:29:32 +0000 - rev 605757
Push 39205 by abutkovits@mozilla.com at Fri, 28 Jan 2022 04:41:16 +0000
Bug 1742655 - Reword outdated comments r=pehrsons Depends on D134528 Differential Revision: https://phabricator.services.mozilla.com/D134529
53e7f97f8c90e50f449196f34264a9fc66d5d756: Bug 1742655 - Move NativeInputTrack's ctor to cpp file r=pehrsons
Chun-Min Chang <chun.m.chang@gmail.com> - Thu, 27 Jan 2022 22:29:32 +0000 - rev 605756
Push 39205 by abutkovits@mozilla.com at Fri, 28 Jan 2022 04:41:16 +0000
Bug 1742655 - Move NativeInputTrack's ctor to cpp file r=pehrsons Depends on D134526 Differential Revision: https://phabricator.services.mozilla.com/D134528
b8ba26997b4bccffafb03fd934a4c8d69d3fa315: Bug 1742655 - Move AudioInput* implementations to cpp file r=pehrsons
Chun-Min Chang <chun.m.chang@gmail.com> - Thu, 27 Jan 2022 22:29:31 +0000 - rev 605755
Push 39205 by abutkovits@mozilla.com at Fri, 28 Jan 2022 04:41:16 +0000
Bug 1742655 - Move AudioInput* implementations to cpp file r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D134526
1b4bb9f435b1378837566ab92461b72df7796486: Bug 1749372 - Combine chunks in AppendAndConsumeChunk if possible r=pehrsons
Chun-Min Chang <chun.m.chang@gmail.com> - Fri, 14 Jan 2022 18:39:04 +0000 - rev 604595
Push 39152 by abutkovits@mozilla.com at Sat, 15 Jan 2022 09:45:36 +0000
Bug 1749372 - Combine chunks in AppendAndConsumeChunk if possible r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D135542
d8f78e17345f31805becca032929b3d1c6c26ad1: Bug 1748763 - Correct principal labeling mechanism r=pehrsons
Chun-Min Chang <chun.m.chang@gmail.com> - Thu, 13 Jan 2022 21:52:37 +0000 - rev 604516
Push 39149 by ctuns@mozilla.com at Fri, 14 Jan 2022 09:31:02 +0000
Bug 1748763 - Correct principal labeling mechanism r=pehrsons The principal-labeling algorithm fails when AudioSegment is something like [packet-size, packet-size], where the packet-size is length of a packet in AudioInputProcessing's packetizer, and also the length of AudioChunks in one AudioSegment. When simplifying the principal labeling algorithm from https://phabricator.services.mozilla.com/D134228?id=523000: ``` while (!mChunksInPacketizer.empty() && (mChunksInPacketizer.front().first <= (len - start))) { const TrackTime end = start + mChunksInPacketizer.front().first; mSegment.AppendAndConsumeChunk( getAudioChunk(start, end, mChunksInPacketizer.front().second)); start = end; mChunksInPacketizer.pop_front(); } if (start < len) { const TrackTime chunkLen = len - start; MOZ_ASSERT(!mChunksInPacketizer.empty()); MOZ_ASSERT(mChunksInPacketizer.front().first > chunkLen); mSegment.AppendAndConsumeChunk( getAudioChunk(start, len, mChunksInPacketizer.front().second)); mChunksInPacketizer.front().first -= chunkLen; } ``` to https://phabricator.services.mozilla.com/D134228?id=525073: ``` while (!mChunksInPacketizer.empty()) { auto& [frames, principal] = mChunksInPacketizer.front(); const TrackTime end = start + frames; if (end > len) { /* if (len > start) { */ mSegment.AppendAndConsumeChunk(getAudioChunk(start, len, principal)); frames -= len - start; /* } */ break; } mSegment.AppendAndConsumeChunk(getAudioChunk(start, end, principal)); start = end; mChunksInPacketizer.pop_front(); } ``` the code in `/* ... */` is omitted. The former won't call `getAudioChunk` when `start == len` while the latter will do. Without the `if (len > start)`, the `AudioChunk::SliceTo` will be called via `getAudioChunk` in `len == start` case and lead to hit an assertion that requires `start < len` in `SliceTo`. Depends on D135794 Differential Revision: https://phabricator.services.mozilla.com/D135249
e6475ce37586c9584bb412f8998f7b34ac6876cb: Bug 1748763 - Don't append zero-duration AudioChunk r=pehrsons
Chun-Min Chang <chun.m.chang@gmail.com> - Thu, 13 Jan 2022 21:52:36 +0000 - rev 604515
Push 39149 by ctuns@mozilla.com at Fri, 14 Jan 2022 09:31:02 +0000
Bug 1748763 - Don't append zero-duration AudioChunk r=pehrsons Don't append the AudioChunk to the segment in AppendAndConsumeChunk if the chunk's duration is zero. Depends on D135546 Differential Revision: https://phabricator.services.mozilla.com/D135794
64e7cb1087fef9b7b2dd30e4a66fed7cd01033be: Bug 1748763 - No return from AppendAndConsumeChunk r=pehrsons
Chun-Min Chang <chun.m.chang@gmail.com> - Thu, 13 Jan 2022 21:52:36 +0000 - rev 604514
Push 39149 by ctuns@mozilla.com at Fri, 14 Jan 2022 09:31:02 +0000
Bug 1748763 - No return from AppendAndConsumeChunk r=pehrsons The returned value from AppendAndConsumeChunk is never used so there is no need to return value from it. Depends on D135248 Differential Revision: https://phabricator.services.mozilla.com/D135546
f828e7b8d128da004acd201b5380004b0ba49956: Bug 1746738 - Process data chunk by chunk with different Principals r=pehrsons
Chun-Min Chang <chun.m.chang@gmail.com> - Wed, 05 Jan 2022 20:50:52 +0000 - rev 603832
Push 39119 by malexandru@mozilla.com at Thu, 06 Jan 2022 03:47:27 +0000
Bug 1746738 - Process data chunk by chunk with different Principals r=pehrsons Allow AudioInputProcessing::PacketizeAndProcess to process packetizer's output data chunk by chunk with different PrincipalHandle values Depends on D134227 Differential Revision: https://phabricator.services.mozilla.com/D134228
abb0c91fb031c7ccafae952a89a7152483239b0a: Bug 1746738 - Add a test r=pehrsons
Chun-Min Chang <chun.m.chang@gmail.com> - Wed, 05 Jan 2022 20:50:51 +0000 - rev 603831
Push 39119 by malexandru@mozilla.com at Thu, 06 Jan 2022 03:47:27 +0000
Bug 1746738 - Add a test r=pehrsons Add a test to check AudioInputProcessing can work with an input data containing different PrincipalHandle values Depends on D134226 Differential Revision: https://phabricator.services.mozilla.com/D134227
ce47ede20b1670fc898337f21a23912495d4be12: Bug 1746735 - Add test for NativeInputTrack r=pehrsons
Chun-Min Chang <chun.m.chang@gmail.com> - Tue, 04 Jan 2022 23:14:08 +0000 - rev 603718
Push 39116 by nfay@mozilla.com at Wed, 05 Jan 2022 09:33:53 +0000
Bug 1746735 - Add test for NativeInputTrack r=pehrsons Add a simple test checking the data in NativeInputTrack Depends on D131871 Differential Revision: https://phabricator.services.mozilla.com/D130232
0defad64aa8caf502a328cd3d795d2c90961d504: Bug 1746735 - Set a default PrincipalHandle to DeviceInputTrack r=pehrsons
Chun-Min Chang <chun.m.chang@gmail.com> - Tue, 04 Jan 2022 23:14:08 +0000 - rev 603717
Push 39116 by nfay@mozilla.com at Wed, 05 Jan 2022 09:33:53 +0000
Bug 1746735 - Set a default PrincipalHandle to DeviceInputTrack r=pehrsons Give a default PrincipalHandle for all the non-null audio data in DeviceInputTrack Differential Revision: https://phabricator.services.mozilla.com/D131871
c057396a06bbcc078b10e665004df20929255438: Bug 1747344: CamerasParent cleanup r=pehrsons
Randell Jesup <rjesup@wgate.com> - Mon, 03 Jan 2022 15:10:39 +0000 - rev 603560
Push 39111 by ncsoregi@mozilla.com at Mon, 03 Jan 2022 21:55:19 +0000
Bug 1747344: CamerasParent cleanup r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D134590
6ace5bb48f4b49ee48c777ded15ec163ce732baf: Bug 1732409 support main thread enumeration of devices from MediaEngineDefault r=pehrsons
Karl Tomlinson <karlt+@karlt.net> - Thu, 23 Dec 2021 10:01:22 +0000 - rev 603031
Push 39089 by apavel@mozilla.com at Thu, 23 Dec 2021 21:57:35 +0000
Bug 1732409 support main thread enumeration of devices from MediaEngineDefault r=pehrsons MediaDevices are suitable for use on any thread. This will support a simple override of devices from enumerateDevices() when resistFingerprinting is set. Depends on D132900 Differential Revision: https://phabricator.services.mozilla.com/D132901
0714fcb047accbe6a255811801b30634709dbcff: Bug 1746893 - Relax AudioDriftCorrection's thread limitation r=padenot,pehrsons
Chun-Min Chang <chun.m.chang@gmail.com> - Mon, 20 Dec 2021 18:58:45 +0000 - rev 602758
Push 39080 by mlaza@mozilla.com at Mon, 20 Dec 2021 21:51:27 +0000
Bug 1746893 - Relax AudioDriftCorrection's thread limitation r=padenot,pehrsons By the comment in `AudioDriftCorrection`: "The construction can happen in any thread", the `AudioDriftCorrection` class is ought to be created in any thread, but it's not true actually. The fact that ctor calls `Preferences::GetInt` makes it can only be called on main-thread, which is the thread `Preferences::GetInt` should be. To make `AudioDriftCorrection` work as what it's expected, the preference getter should be moved to the `AudioDriftCorrection`'s caller rather than `AudioDriftCorrection'`s ctor. Differential Revision: https://phabricator.services.mozilla.com/D122297