searching for reviewer(pehrsons)
5a01d6d44634a50fe69da6e56d3b050d93812545: Bug 1014393 - Move AudioGenerator to its own files so it can be used in more media gtests. r=pehrsons
Bryce Van Dyk <bvandyk@mozilla.com> - Fri, 12 Jul 2019 13:41:08 +0000 - rev 482597
Push 36284 by apavel@mozilla.com at Fri, 12 Jul 2019 21:43:58 +0000
Bug 1014393 - Move AudioGenerator to its own files so it can be used in more media gtests. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D35389
3457a5065dc4ce6f5075d60bdf89879045b14102: Bug 1014393 - MediaEncoder better orders frames passed to the muxer. r=pehrsons
Bryce Van Dyk <bvandyk@mozilla.com> - Fri, 12 Jul 2019 13:41:01 +0000 - rev 482596
Push 36284 by apavel@mozilla.com at Fri, 12 Jul 2019 21:43:58 +0000
Bug 1014393 - MediaEncoder better orders frames passed to the muxer. r=pehrsons Update MediaEncoder to pass frames to the muxer in order of their time stamps. This should prevent the currently possible scenario where audio and video frames are written with non-monotonically increasing timestamps (in violation of the webm spec). Differential Revision: https://phabricator.services.mozilla.com/D35388
2a4999e0475b6569a0bdf18ba54db17900e1c440: Bug 1014393 - Use MediaQueue to store frames pending write to muxer in MediaEncoder. r=pehrsons
Bryce Van Dyk <bvandyk@mozilla.com> - Fri, 12 Jul 2019 13:40:54 +0000 - rev 482595
Push 36284 by apavel@mozilla.com at Fri, 12 Jul 2019 21:43:58 +0000
Bug 1014393 - Use MediaQueue to store frames pending write to muxer in MediaEncoder. r=pehrsons MediaQueue provides a better interface for interleaving frames when writing to the muxer (this change will follow in another changeset). The queue interface provides a nicer abstraction than manually managing a nsTArray. MozReview-Commit-ID: 5V5XmYODFdA Differential Revision: https://phabricator.services.mozilla.com/D35387
0be3804dc04e36257292b9ccbb3537c2acddaeb3: Bug 1014393 - Update EncodedFrame class to more closely resemble MediaData class. r=pehrsons
Bryce Van Dyk <bvandyk@mozilla.com> - Fri, 12 Jul 2019 13:40:47 +0000 - rev 482594
Push 36284 by apavel@mozilla.com at Fri, 12 Jul 2019 21:43:58 +0000
Bug 1014393 - Update EncodedFrame class to more closely resemble MediaData class. r=pehrsons This changes EncodedFrame to behave more like MediaData, so that EncodedFrame can be used with the MediaQueue data structure. It also provides a somewhat more consistent interface across media data types. MozReview-Commit-ID: I2o6n30ErxB Differential Revision: https://phabricator.services.mozilla.com/D35386
234994d8f1361ba95400aba462436aecc7059fe8: Bug 1014393 - Shift responsibility of adjusting packets with opus codec delay to MediaEncoder. r=pehrsons
Bryce Van Dyk <bvandyk@mozilla.com> - Fri, 12 Jul 2019 13:40:40 +0000 - rev 482593
Push 36284 by apavel@mozilla.com at Fri, 12 Jul 2019 21:43:58 +0000
Bug 1014393 - Shift responsibility of adjusting packets with opus codec delay to MediaEncoder. r=pehrsons Move the responsibility of adjusting opus frame timestamps to the MediaEncoder. This was previously done by the EbmlComposer, but doing so in the MediaEncoder means we can have greater control over handling of time codes and interleaving of frames. MozReview-Commit-ID: 2g9cy1IqOph Differential Revision: https://phabricator.services.mozilla.com/D35385
d17f91ff2014792c69e22274171ce01acd051b58: Bug 1014393 - Remove EncodedFrameContainer. r=pehrsons
Bryce Van Dyk <bvandyk@mozilla.com> - Fri, 12 Jul 2019 13:40:33 +0000 - rev 482592
Push 36284 by apavel@mozilla.com at Fri, 12 Jul 2019 21:43:58 +0000
Bug 1014393 - Remove EncodedFrameContainer. r=pehrsons Remove EncodedFrameContainer and clean up areas where it was used. EncodedFrameContainer provided a wrapper around an nsTArray<RefPtr<EncodedFrame>>, but it simplifies the code to simply expose this array. Also clean up unused enums in EncodedFrame, and clean up some of the outdated comments for our encoded frame handling. MozReview-Commit-ID: Bh3VKesVoJE Differential Revision: https://phabricator.services.mozilla.com/D35384
25f58baa8159b0d68ee3694beda4b07c4ffe4911: Bug 1014393 - Separate MediaEncoders encode and mux steps. r=pehrsons
Bryce Van Dyk <bvandyk@mozilla.com> - Fri, 12 Jul 2019 13:40:25 +0000 - rev 482591
Push 36284 by apavel@mozilla.com at Fri, 12 Jul 2019 21:43:58 +0000
Bug 1014393 - Separate MediaEncoders encode and mux steps. r=pehrsons Separating the encode and mux steps allows for better control over interleaving audio and video data. If encode and mux are done in a single step it's possible to mux large amounts of audio or video data which should have been interleaved with the other data type to give correctly ordered time stamps in the target container. MozReview-Commit-ID: CBYemrkpyF5 Differential Revision: https://phabricator.services.mozilla.com/D35383
718a301a0c6c387a56f236ea88f5f3da6cf9381d: Bug 1324552 - Implement AudioContext baseLatency and outputLatency attributes. r=pehrsons,baku
Paul Adenot <paul@paul.cx> - Fri, 12 Jul 2019 11:28:03 +0000 - rev 482567
Push 36284 by apavel@mozilla.com at Fri, 12 Jul 2019 21:43:58 +0000
Bug 1324552 - Implement AudioContext baseLatency and outputLatency attributes. r=pehrsons,baku Differential Revision: https://phabricator.services.mozilla.com/D37280
088e13476d39b4e54f75df853b6aedeef5eee1d1: Bug 1324552 - Implement AudioContext baseLatency and outputLatency attributes. r=pehrsons,baku
Paul Adenot <paul@paul.cx> - Thu, 11 Jul 2019 13:30:07 +0000 - rev 482382
Push 36280 by ncsoregi@mozilla.com at Thu, 11 Jul 2019 23:02:03 +0000
Bug 1324552 - Implement AudioContext baseLatency and outputLatency attributes. r=pehrsons,baku Differential Revision: https://phabricator.services.mozilla.com/D37280
948869e38bce72ae635e1ab629ab42ce0af444cc: Bug 1528031 - Update tests to work with [SecureContext] navigator.mediaDevices. r=pehrsons,smaug
Jan-Ivar Bruaroey <jib@mozilla.com> - Fri, 05 Jul 2019 21:21:38 +0000 - rev 481522
Push 36248 by dvarga@mozilla.com at Sat, 06 Jul 2019 09:34:01 +0000
Bug 1528031 - Update tests to work with [SecureContext] navigator.mediaDevices. r=pehrsons,smaug Differential Revision: https://phabricator.services.mozilla.com/D35970
6d317cd3124aafefc18ffd0ac2056bfe76a119bb: Bug 1528031 - Require [SecureContext] for navigator.mediaDevices & navigator.mozGetUserMedia(). r=pehrsons,smaug
Jan-Ivar Bruaroey <jib@mozilla.com> - Fri, 05 Jul 2019 21:21:25 +0000 - rev 481521
Push 36248 by dvarga@mozilla.com at Sat, 06 Jul 2019 09:34:01 +0000
Bug 1528031 - Require [SecureContext] for navigator.mediaDevices & navigator.mozGetUserMedia(). r=pehrsons,smaug Differential Revision: https://phabricator.services.mozilla.com/D33836
27ce9b212d26c5185f9e856f7ba3b6247a3e2161: Bug 1528031 - Update tests to work with [SecureContext] navigator.mediaDevices. r=pehrsons,smaug
Jan-Ivar Bruaroey <jib@mozilla.com> - Wed, 26 Jun 2019 18:15:50 +0000 - rev 480225
Push 36208 by ccoroiu@mozilla.com at Thu, 27 Jun 2019 09:34:48 +0000
Bug 1528031 - Update tests to work with [SecureContext] navigator.mediaDevices. r=pehrsons,smaug Differential Revision: https://phabricator.services.mozilla.com/D35970
0a18aa212ee6c1013d9069d2142dbbe8d1fb3715: Bug 1528031 - Require [SecureContext] for navigator.mediaDevices & navigator.mozGetUserMedia(). r=pehrsons,smaug
Jan-Ivar Bruaroey <jib@mozilla.com> - Wed, 26 Jun 2019 18:15:23 +0000 - rev 480224
Push 36208 by ccoroiu@mozilla.com at Thu, 27 Jun 2019 09:34:48 +0000
Bug 1528031 - Require [SecureContext] for navigator.mediaDevices & navigator.mozGetUserMedia(). r=pehrsons,smaug Differential Revision: https://phabricator.services.mozilla.com/D33836
b3cb4712a543ca25c9f2f6253c43c86d07609136: Bug 1429847 - Promote the GraphRunner thread. r=pehrsons
Paul Adenot <paul@paul.cx> - Fri, 21 Jun 2019 19:51:22 +0000 - rev 479831
Push 36184 by dluca@mozilla.com at Sat, 22 Jun 2019 09:36:23 +0000
Bug 1429847 - Promote the GraphRunner thread. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D32499
64070cd015ca9edb956da99d0241f7a6cf5cc4c0: Bug 1552571: Optimize GetUserMediaWindowListener's source listener iteration and ownership. r=pehrsons
Jan-Ivar Bruaroey <jib@mozilla.com> - Thu, 20 Jun 2019 16:43:21 +0000 - rev 479335
Push 36178 by aiakab@mozilla.com at Thu, 20 Jun 2019 21:50:59 +0000
Bug 1552571: Optimize GetUserMediaWindowListener's source listener iteration and ownership. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D31687
85228e5172e3c45a2e4a7397e922d79dc2a94221: Bug 1553215 - Implement the correct behaviour for MediaStreamAudioSource. r=karlt,pehrsons
Paul Adenot <paul@paul.cx> - Wed, 19 Jun 2019 23:06:33 +0000 - rev 479269
Push 36177 by rmaries@mozilla.com at Thu, 20 Jun 2019 09:46:31 +0000
Bug 1553215 - Implement the correct behaviour for MediaStreamAudioSource. r=karlt,pehrsons It should pick and lock to the right track, regardless of if it's still in the MediaStream. The test fix is because we don't expose tracks until the HTMLMediaElement has loaded loading I think. This alignes with a couple spec changes: - https://github.com/WebAudio/web-audio-api/issues/264 - https://github.com/WebAudio/web-audio-api/pull/1829/files and also throws when no valid track are found in the MediaStream, either because it's all video tracks or because it has no tracks. Differential Revision: https://phabricator.services.mozilla.com/D32176
d5a6a97abef4df56fc7ed27fc60395d6d62c1a6f: Bug 1553215 - Start testing MediaStreamAudioSourceNode in WPT. r=karlt,pehrsons
Paul Adenot <paul@paul.cx> - Wed, 19 Jun 2019 23:06:31 +0000 - rev 479268
Push 36177 by rmaries@mozilla.com at Thu, 20 Jun 2019 09:46:31 +0000
Bug 1553215 - Start testing MediaStreamAudioSourceNode in WPT. r=karlt,pehrsons It's not complete I think, but it covers the constructor and some bits of behaviour. Differential Revision: https://phabricator.services.mozilla.com/D32175
992d3dd0cee045520f093b21e8ed1746fcee112a: Bug 1553215 - Implement the correct behaviour for MediaStreamAudioSource. r=karlt,pehrsons
Paul Adenot <paul@paul.cx> - Tue, 11 Jun 2019 09:51:21 +0000 - rev 478402
Push 36143 by aciure@mozilla.com at Wed, 12 Jun 2019 21:41:19 +0000
Bug 1553215 - Implement the correct behaviour for MediaStreamAudioSource. r=karlt,pehrsons It should pick and lock to the right track, regardless of if it's still in the MediaStream. The test fix is because we don't expose tracks until the HTMLMediaElement has loaded loading I think. This alignes with a couple spec changes: - https://github.com/WebAudio/web-audio-api/issues/264 - https://github.com/WebAudio/web-audio-api/pull/1829/files and also throws when no valid track are found in the MediaStream, either because it's all video tracks or because it has no tracks. Differential Revision: https://phabricator.services.mozilla.com/D32176
fad5e3bf0695fa9b172053617eaf618bdab2b9de: Bug 1553215 - Start testing MediaStreamAudioSourceNode in WPT. r=karlt,pehrsons
Paul Adenot <paul@paul.cx> - Tue, 11 Jun 2019 09:51:14 +0000 - rev 478401
Push 36143 by aciure@mozilla.com at Wed, 12 Jun 2019 21:41:19 +0000
Bug 1553215 - Start testing MediaStreamAudioSourceNode in WPT. r=karlt,pehrsons It's not complete I think, but it covers the constructor and some bits of behaviour. Differential Revision: https://phabricator.services.mozilla.com/D32175
71154c8ef814a3e6b10c9789325d4ed5529cf641: Bug 1553215 - Implement the correct behaviour for MediaStreamAudioSource. r=karlt,pehrsons
Paul Adenot <paul@paul.cx> - Mon, 10 Jun 2019 15:33:12 +0000 - rev 478077
Push 36136 by nerli@mozilla.com at Tue, 11 Jun 2019 03:18:15 +0000
Bug 1553215 - Implement the correct behaviour for MediaStreamAudioSource. r=karlt,pehrsons It should pick and lock to the right track, regardless of if it's still in the MediaStream. The test fix is because we don't expose tracks until the HTMLMediaElement has loaded loading I think. This alignes with a couple spec changes: - https://github.com/WebAudio/web-audio-api/issues/264 - https://github.com/WebAudio/web-audio-api/pull/1829/files and also throws when no valid track are found in the MediaStream, either because it's all video tracks or because it has no tracks. Differential Revision: https://phabricator.services.mozilla.com/D32176
80181b642f8195e0788009b4e1aa7af23e11009c: Bug 1553215 - Start testing MediaStreamAudioSourceNode in WPT. r=karlt,pehrsons
Paul Adenot <paul@paul.cx> - Mon, 10 Jun 2019 15:33:13 +0000 - rev 478076
Push 36136 by nerli@mozilla.com at Tue, 11 Jun 2019 03:18:15 +0000
Bug 1553215 - Start testing MediaStreamAudioSourceNode in WPT. r=karlt,pehrsons It's not complete I think, but it covers the constructor and some bits of behaviour. Differential Revision: https://phabricator.services.mozilla.com/D32175
350091c5dde1c2734707b9738395f499e1920ce0: Bug 1552571: Optimize GetUserMediaWindowListener's source listener iteration and ownership. r=pehrsons
Jan-Ivar Bruaroey <jib@mozilla.com> - Tue, 04 Jun 2019 22:39:14 +0000 - rev 476884
Push 36110 by malexandru@mozilla.com at Wed, 05 Jun 2019 09:49:10 +0000
Bug 1552571: Optimize GetUserMediaWindowListener's source listener iteration and ownership. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D31687
f12fb7f69d5180c2c133b441e23b0b8b8d4fe123: Bug 1550955 - Make StopTrack() API require a hard reference. r=pehrsons
Jan-Ivar Bruaroey <jib@mozilla.com> - Fri, 17 May 2019 19:38:44 +0000 - rev 474379
Push 36032 by dluca@mozilla.com at Sat, 18 May 2019 10:23:48 +0000
Bug 1550955 - Make StopTrack() API require a hard reference. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D31555
1e2987994551c0ff48be5aad4a095dc8f0c52366: Bug 1335740 - Update wpt & mochitests to work w/[SecureContext] navigator.mediaDevices. r=pehrsons
Jan-Ivar Bruaroey <jib@mozilla.com> - Tue, 30 Apr 2019 15:20:53 +0000 - rev 471966
Push 35944 by ccoroiu@mozilla.com at Tue, 30 Apr 2019 21:53:37 +0000
Bug 1335740 - Update wpt & mochitests to work w/[SecureContext] navigator.mediaDevices. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D20425
cec93c8315e9f80cdc187dc967e9758634a59c4c: Bug 1335740 - getUserMedia() Add 2 prefs to control A) NotAllowedError in http (pref'd on), and B) [SecureContext] navigator.mediaDevices (pref'd off) r=bzbarsky,pehrsons
Jan-Ivar Bruaroey <jib@mozilla.com> - Tue, 30 Apr 2019 15:20:59 +0000 - rev 471965
Push 35944 by ccoroiu@mozilla.com at Tue, 30 Apr 2019 21:53:37 +0000
Bug 1335740 - getUserMedia() Add 2 prefs to control A) NotAllowedError in http (pref'd on), and B) [SecureContext] navigator.mediaDevices (pref'd off) r=bzbarsky,pehrsons Differential Revision: https://phabricator.services.mozilla.com/D19549
f75aabcf81d0022ac11c173485c1aab2091193d1: Bug 1541290 - Close audio input from main thread to ensure that the message is not executed on a closed graph. r=pehrsons
Alex Chronopoulos <achronop@gmail.com> - Thu, 18 Apr 2019 18:35:20 +0000 - rev 470183
Push 35889 by csabou@mozilla.com at Fri, 19 Apr 2019 16:34:07 +0000
Bug 1541290 - Close audio input from main thread to ensure that the message is not executed on a closed graph. r=pehrsons CloseAudioInut method posts a message, to the graph thread, in order to close the input asynchonously. When CloseAudioInput method was being executed from a thread other than the main thread, a runnable would be posted to main thread in order to post the async message from there. That was a risky path because when the graph was shutting down there were no guarantee that the close-input message would reach the graph thread before destroy takes place. By limiting CloseAudioInput to main thread it is ensured that the close-input message will be executed before destroy. Differential Revision: https://phabricator.services.mozilla.com/D27751
0a351368e1f729dadcd6b98236a5cead18585265: Bug 1531833 - When the input is voice, activate the global communication mode. r=pehrsons
Paul Adenot <paul@paul.cx> - Tue, 16 Apr 2019 15:42:42 +0000 - rev 469694
Push 35879 by nerli@mozilla.com at Tue, 16 Apr 2019 22:01:48 +0000
Bug 1531833 - When the input is voice, activate the global communication mode. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D21738
d47604394f78874f7eb109b49dec1f90ac9dc0f8: Bug 1531833 - Add a way to tell the graph driver that the audio input is voice. r=pehrsons
Paul Adenot <paul@paul.cx> - Tue, 16 Apr 2019 15:42:38 +0000 - rev 469693
Push 35879 by nerli@mozilla.com at Tue, 16 Apr 2019 22:01:48 +0000
Bug 1531833 - Add a way to tell the graph driver that the audio input is voice. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D21737
45f499ef4b625edb5c81dad6e703787756f54360: Bug 1531833 - Expose a way to set a global "communication mode" in CubebUtils, to be use by real-time duplex audio users. r=pehrsons
Paul Adenot <paul@paul.cx> - Tue, 16 Apr 2019 15:42:33 +0000 - rev 469692
Push 35879 by nerli@mozilla.com at Tue, 16 Apr 2019 22:01:48 +0000
Bug 1531833 - Expose a way to set a global "communication mode" in CubebUtils, to be use by real-time duplex audio users. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D21736
465570a54b46a7edd02b0e327c5cde7353dbf224: Bug 1531833 - When the input is voice, activate the global communication mode. r=pehrsons
Paul Adenot <paul@paul.cx> - Thu, 11 Apr 2019 09:19:35 +0000 - rev 468964
Push 35855 by aciure@mozilla.com at Thu, 11 Apr 2019 16:11:15 +0000
Bug 1531833 - When the input is voice, activate the global communication mode. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D21738
e725253ee97629bbed151cb7ba9c9ed0278f9921: Bug 1531833 - Add a way to tell the graph driver that the audio input is voice. r=pehrsons
Paul Adenot <paul@paul.cx> - Thu, 11 Apr 2019 09:19:34 +0000 - rev 468963
Push 35855 by aciure@mozilla.com at Thu, 11 Apr 2019 16:11:15 +0000
Bug 1531833 - Add a way to tell the graph driver that the audio input is voice. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D21737
74ad8e7a722b22087d4a122be3c4f9eb50a04092: Bug 1531833 - Expose a way to set a global "communication mode" in CubebUtils, to be use by real-time duplex audio users. r=pehrsons
Paul Adenot <paul@paul.cx> - Thu, 11 Apr 2019 09:19:34 +0000 - rev 468962
Push 35855 by aciure@mozilla.com at Thu, 11 Apr 2019 16:11:15 +0000
Bug 1531833 - Expose a way to set a global "communication mode" in CubebUtils, to be use by real-time duplex audio users. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D21736
8097b8fdb9bc5b1e47d85c11c098c2fd24b3904c: Bug 1324548 - Add MediaStreamTrackAudioSourceNode. r=pehrsons,baku
Léo Paquet <Léo Paquet> - Wed, 10 Apr 2019 12:14:17 +0000 - rev 468781
Push 35850 by dvarga@mozilla.com at Wed, 10 Apr 2019 21:52:56 +0000
Bug 1324548 - Add MediaStreamTrackAudioSourceNode. r=pehrsons,baku MozReview-Commit-ID: IdVqfNigMyu Differential Revision: https://phabricator.services.mozilla.com/D15958
397a9577d91b77a4d2bfb46f09375345fb022df1: Bug 1324548 - Tests for MediaStreamTrackAudioSourceNode. r=pehrsons
Paul Adenot <paul@paul.cx> - Wed, 10 Apr 2019 12:14:15 +0000 - rev 468780
Push 35850 by dvarga@mozilla.com at Wed, 10 Apr 2019 21:52:56 +0000
Bug 1324548 - Tests for MediaStreamTrackAudioSourceNode. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D16066
055578135fba34c43339630f16e069052d19d5fc: Bug 1324548 - Add MediaStreamTrackAudioSourceNode. r=pehrsons,baku
Léo Paquet <Léo Paquet> - Wed, 03 Apr 2019 17:01:38 +0000 - rev 467808
Push 35810 by aciure@mozilla.com at Thu, 04 Apr 2019 04:33:36 +0000
Bug 1324548 - Add MediaStreamTrackAudioSourceNode. r=pehrsons,baku MozReview-Commit-ID: IdVqfNigMyu Differential Revision: https://phabricator.services.mozilla.com/D15958
7aefaab277fe390ed8537fce35c2a2f73ab54e97: Bug 1324548 - Tests for MediaStreamTrackAudioSourceNode. r=pehrsons
Paul Adenot <paul@paul.cx> - Wed, 03 Apr 2019 17:01:58 +0000 - rev 467807
Push 35810 by aciure@mozilla.com at Thu, 04 Apr 2019 04:33:36 +0000
Bug 1324548 - Tests for MediaStreamTrackAudioSourceNode. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D16066
fda93e03e4696579766232114a61a1daf5248b88: Bug 1324548 - Add MediaStreamTrackAudioSourceNode. r=pehrsons,baku
Léo Paquet <Léo Paquet> - Wed, 03 Apr 2019 14:00:28 +0000 - rev 467780
Push 35810 by aciure@mozilla.com at Thu, 04 Apr 2019 04:33:36 +0000
Bug 1324548 - Add MediaStreamTrackAudioSourceNode. r=pehrsons,baku MozReview-Commit-ID: IdVqfNigMyu Differential Revision: https://phabricator.services.mozilla.com/D15958
8e6135544e33818c92e5fc4ba8d31ba04dab277a: Bug 1324548 - Tests for MediaStreamTrackAudioSourceNode. r=pehrsons
Paul Adenot <paul@paul.cx> - Tue, 02 Apr 2019 15:26:11 +0000 - rev 467779
Push 35810 by aciure@mozilla.com at Thu, 04 Apr 2019 04:33:36 +0000
Bug 1324548 - Tests for MediaStreamTrackAudioSourceNode. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D16066
ec0b9bfa65646a96e0b3a7da3eb8dd9ce81ef085: Bug 1540251 - Workaround unset NAL size in WebrtcGmpVideoEncoder::Encoded; r=pehrsons
Dan Minor <dminor@mozilla.com> - Mon, 01 Apr 2019 13:47:29 +0000 - rev 467042
Push 35795 by csabou@mozilla.com at Mon, 01 Apr 2019 21:54:51 +0000
Bug 1540251 - Workaround unset NAL size in WebrtcGmpVideoEncoder::Encoded; r=pehrsons OpenH264 1.8.1 occasionally generates a size of 0x01000000. This is a magic value in the NAL which should be replaced with a valid size, but for some reason this is not always happening. If we return early here, encoding will continue to work as expected. This workaround can be removed once this issue is addressed upstream, although that may require a new release of OpenH264. Differential Revision: https://phabricator.services.mozilla.com/D25468
c12307f3817bec87712ab5930493c3135c76b0a0: Bug 1539220 - Prefer non-RGB24 capabilities when available; r=pehrsons
Dan Minor <dminor@mozilla.com> - Fri, 29 Mar 2019 18:43:38 +0000 - rev 466906
Push 35784 by nerli@mozilla.com at Sat, 30 Mar 2019 09:32:04 +0000
Bug 1539220 - Prefer non-RGB24 capabilities when available; r=pehrsons We've hit a number of problems with handling of RGB24 video capture on Windows. This adds a check that will ignore any RGB24 capture capabilities when determining a best match if there are other capabilities available to workaround the problems. Differential Revision: https://phabricator.services.mozilla.com/D25449
af3e08c3b74522f184719a3c61ce1ff1bb73b161: Bug 1532465 - Ensure we AddRef prior to early return in MediaType::Assign; r=pehrsons
Dan Minor <dminor@mozilla.com> - Tue, 12 Mar 2019 07:15:58 -0700 - rev 466094
Push 35760 by ncsoregi@mozilla.com at Tue, 26 Mar 2019 17:43:58 +0000
Bug 1532465 - Ensure we AddRef prior to early return in MediaType::Assign; r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D23143
e975f7793042777e88690e2ba5a8f49d5ddc9e5f: Bug 1521169 - Ensure that streamCount is at least one in CreateEncoderStreams; r=pehrsons
Dan Minor <dminor@mozilla.com> - Fri, 22 Mar 2019 15:25:27 -0400 - rev 466092
Push 35760 by ncsoregi@mozilla.com at Tue, 26 Mar 2019 17:43:58 +0000
Bug 1521169 - Ensure that streamCount is at least one in CreateEncoderStreams; r=pehrsons We currently have a check that we create at least one stream in CreateEncoderStreams. This is failing occasionally. This adds a new check to the top of the method to check that at least one stream has been requested. This will help to narrow down where the problem is occurring. Differential Revision: https://phabricator.services.mozilla.com/D24550
51b23951731b47c807861e0122dc6a76c74bc5e1: Bug 1521169 - Check that at least one stream is requested in ConfigureSendMediaCodec; r=pehrsons
Dan Minor <dminor@mozilla.com> - Thu, 21 Feb 2019 13:21:10 -0500 - rev 466091
Push 35760 by ncsoregi@mozilla.com at Tue, 26 Mar 2019 17:43:58 +0000
Bug 1521169 - Check that at least one stream is requested in ConfigureSendMediaCodec; r=pehrsons This moves the existing release assert in CreateSendStream that ensures we have requested at least one stream to ConfigureSendMediaCodec. This covers the case where we don't recreate the send stream when only stream attributes have changed. It does not appear to be possible for no streams to be configured by the Transceivers code. Once we've verified that is the case with the release assert, we can remove it and use error handling code instead. Differential Revision: https://phabricator.services.mozilla.com/D20548
ac642c49a78399d55fe5346f6f00c22d913ebdc3: Bug 1521169 - Remove VideoEncoderConfigBuilder; r=pehrsons
Dan Minor <dminor@mozilla.com> - Fri, 22 Mar 2019 14:23:42 -0400 - rev 466090
Push 35760 by ncsoregi@mozilla.com at Tue, 26 Mar 2019 17:43:58 +0000
Bug 1521169 - Remove VideoEncoderConfigBuilder; r=pehrsons The SimulcastStreamConfig code is unused. Once that is removed, all that remains is a thin wrapper around webrtc::VideoEncoderConfig. We might as well use it directly. Differential Revision: https://phabricator.services.mozilla.com/D24549
ebc9076ea6a5bb3a48425b481b96146fbaa5cb26: Bug 1521169 - Rename SimulcastEncoding to Encoding in VideoCodecConfig; r=pehrsons
Dan Minor <dminor@mozilla.com> - Thu, 21 Feb 2019 13:15:48 -0500 - rev 466089
Push 35760 by ncsoregi@mozilla.com at Tue, 26 Mar 2019 17:43:58 +0000
Bug 1521169 - Rename SimulcastEncoding to Encoding in VideoCodecConfig; r=pehrsons The Transceivers code just calls these encodings, and we use them even if we're not doing simulcast, so we should just call them encodings as well. Differential Revision: https://phabricator.services.mozilla.com/D24548
e712ac9dac7d364e3c7ffcab7a631ad395de47ce: Bug 1538640 wait for GraphRunner thread shutdown r=pehrsons
Karl Tomlinson <karlt+@karlt.net> - Tue, 26 Mar 2019 00:13:55 +0000 - rev 466032
Push 35758 by rgurzau@mozilla.com at Tue, 26 Mar 2019 09:51:47 +0000
Bug 1538640 wait for GraphRunner thread shutdown r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D24673
6e5ccb45dbe1824c4481151a283a68d927aaa07a: bug 1538630 Check a predicate when waiting on condition variables in GraphRunner r=pehrsons
Karl Tomlinson <karlt+@karlt.net> - Mon, 25 Mar 2019 22:49:02 +0000 - rev 466031
Push 35758 by rgurzau@mozilla.com at Tue, 26 Mar 2019 09:51:47 +0000
bug 1538630 Check a predicate when waiting on condition variables in GraphRunner r=pehrsons so as to respond appropriately to spurious wakeups. Checking the predicate before the first wait in Run() makes the mStarted notification unnecessary. Differential Revision: https://phabricator.services.mozilla.com/D24672
1a2c4caa1170c502b3067486e9dd673cd845d977: Bug 1533252 - P4. Serialize all the video MediaCapabilities queries. r=pehrsons
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 15 Mar 2019 13:54:19 +0000 - rev 465311
Push 35736 by ncsoregi@mozilla.com at Thu, 21 Mar 2019 10:40:08 +0000
Bug 1533252 - P4. Serialize all the video MediaCapabilities queries. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D23653
d8d366725967b777f985a4432738ea3c467ec0be: Bug 1533252 - P3. Rename LocalAllocPolicy into SingleAllocPolicy. r=pehrsons
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 15 Mar 2019 13:35:53 +0000 - rev 465310
Push 35736 by ncsoregi@mozilla.com at Thu, 21 Mar 2019 10:40:08 +0000
Bug 1533252 - P3. Rename LocalAllocPolicy into SingleAllocPolicy. r=pehrsons It's more descriptive with what it actually does. Differential Revision: https://phabricator.services.mozilla.com/D23652
f606c812fb5df09d379a8bcc5d6a16e09d12bd19: Bug 1533252 - P2. Make LocalAllocPolicy inherit from AllocPolicy. r=pehrsons
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 15 Mar 2019 13:35:42 +0000 - rev 465309
Push 35736 by ncsoregi@mozilla.com at Thu, 21 Mar 2019 10:40:08 +0000
Bug 1533252 - P2. Make LocalAllocPolicy inherit from AllocPolicy. r=pehrsons Despite its name and apparent use LocalAllocPolicy could only handle a single call to Alloc() at a time which was okay due to how it was used by the MediaFormatReader. However, we do want to handle multiple calls to Alloc(). These changes allow to perform simultaneous requests and have them be processed one at a time serially. Differential Revision: https://phabricator.services.mozilla.com/D23651