searching for reviewer(padenot)
11d856647620c9adb13ff8901ee72d0da8afdb50: Bug 1546154 p6: Remove MSCOMInitThreadPoolListener. r=padenot
Bob Owen <bobowencode@gmail.com> - Mon, 20 Sep 2021 10:09:02 +0000 - rev 592461
Push 38806 by ccozmuta@mozilla.com at Mon, 20 Sep 2021 16:24:09 +0000
Bug 1546154 p6: Remove MSCOMInitThreadPoolListener. r=padenot Threads are implicitly members of the multi-threaded apartment and calls to CoInitializeEx (and CoUninitializeEx) cause user32 to load. Differential Revision: https://phabricator.services.mozilla.com/D124934
b870e2b1de114ef4ef8182bd0d2b5c331c110315: Bug 1678060: Disable this test on linux gli jobs. r=jmaher,padenot
Byron Campen <docfaraday@gmail.com> - Fri, 17 Sep 2021 17:38:18 +0000 - rev 592343
Push 38798 by mlaza@mozilla.com at Fri, 17 Sep 2021 21:50:08 +0000
Bug 1678060: Disable this test on linux gli jobs. r=jmaher,padenot Depends on D125896 Differential Revision: https://phabricator.services.mozilla.com/D125898
a1fee3aaa1b2aef1e51e7ea10e1982c4f5d218db: Bug 1652294 - Relax the test of the number of enumerated devices. r=padenot
Alex Chronopoulos <achronop@gmail.com> - Thu, 16 Sep 2021 22:20:39 +0000 - rev 592247
Push 38795 by nbeleuzu@mozilla.com at Fri, 17 Sep 2021 03:36:17 +0000
Bug 1652294 - Relax the test of the number of enumerated devices. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D85559
611812ee62a2168afd8b1c7b8a9b9584e8dc1aef: Bug 1546154 p6: Remove MSCOMInitThreadPoolListener. r=padenot
Bob Owen <bobowencode@gmail.com> - Wed, 15 Sep 2021 10:21:05 +0000 - rev 592027
Push 38791 by smolnar@mozilla.com at Thu, 16 Sep 2021 09:43:03 +0000
Bug 1546154 p6: Remove MSCOMInitThreadPoolListener. r=padenot Threads are implicitly members of the multi-threaded apartment and calls to CoInitializeEx (and CoUninitializeEx) cause user32 to load. Differential Revision: https://phabricator.services.mozilla.com/D124934
780bbc9a2c16849950364bcba3ed92762cbf36d0: Bug 1721731 - disable 'test_streams_element_capture_mediatrack.html' on Android debug. r=padenot
alwu <alwu@mozilla.com> - Mon, 13 Sep 2021 17:45:52 +0000 - rev 591772
Push 38787 by nbeleuzu@mozilla.com at Tue, 14 Sep 2021 14:35:56 +0000
Bug 1721731 - disable 'test_streams_element_capture_mediatrack.html' on Android debug. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D125250
60c6b98b954e8d31353f9934e4b7c1581fd07d37: Bug 1725810 - Fix audio distortion r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Fri, 03 Sep 2021 16:46:32 +0000 - rev 590946
Push 38761 by mlaza@mozilla.com at Sat, 04 Sep 2021 09:40:24 +0000
Bug 1725810 - Fix audio distortion r=padenot When two successive `AudioInputProcessing::NotifyInputData` calls are followed by only one `AudioInputProcessing::ProcessInput` call, the audio input data in the first `NotifyInputData` call will be dropped silently, and these incomplete audio data will lead to unrecognizable sounds. To avoid dropping any audio input, we need to queue all the unprocessed audio input data from `NotifyInputData` instead of keeping tracking the newest one only. Depends on D123996 Differential Revision: https://phabricator.services.mozilla.com/D123840
45a8bc7cd18be07773098a31a3a3c47ae4e101c0: Bug 1725810 - Remove `AudioDataBuffers` r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Fri, 03 Sep 2021 16:46:32 +0000 - rev 590945
Push 38761 by mlaza@mozilla.com at Sat, 04 Sep 2021 09:40:24 +0000
Bug 1725810 - Remove `AudioDataBuffers` r=padenot `AudioDataBuffers` is used to hold the information of the audio input and output. However, nothing special needs to be done there. Depends on D123997 Differential Revision: https://phabricator.services.mozilla.com/D123996
61ab7a0293f44c58667939e8aa2e8bca737ddd3f: Bug 1725810 - Add a test case simulate the issue r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Fri, 03 Sep 2021 16:46:32 +0000 - rev 590944
Push 38761 by mlaza@mozilla.com at Sat, 04 Sep 2021 09:40:24 +0000
Bug 1725810 - Add a test case simulate the issue r=padenot Add a test for `AudioInputProcessing` to demonstrate the audio distortion problem Differential Revision: https://phabricator.services.mozilla.com/D123997
7ce99e7626d2b9537cfe90dd20c7cea27d9fb154: Bug 1725137 - Fix gtest suite from dom to be buildable outside unified. r=padenot
Andi-Bogdan Postelnicu <andi@mozilla.com> - Sun, 22 Aug 2021 10:21:54 +0000 - rev 589502
Push 38725 by imoraru@mozilla.com at Sun, 22 Aug 2021 21:22:35 +0000
Bug 1725137 - Fix gtest suite from dom to be buildable outside unified. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D122338
ad18766e27c45df2ac6753a433fac0c40ee8537e: Bug 1718630 - Fix browsertime YTP widevine on windows r=perftest-reviewers,davehunt,padenot
Alex Ionescu <aionescu@mozilla.com> - Fri, 20 Aug 2021 12:05:38 +0000 - rev 589419
Push 38722 by mlaza@mozilla.com at Fri, 20 Aug 2021 21:33:13 +0000
Bug 1718630 - Fix browsertime YTP widevine on windows r=perftest-reviewers,davehunt,padenot Differential Revision: https://phabricator.services.mozilla.com/D122853
a80c47c6cc82ff5f461ca01a3ffe1d808ae8d2da: Bug 1718630 - Fix browsertime YTP widevine on windows r=perftest-reviewers,davehunt,padenot
Alex Ionescu <aionescu@mozilla.com> - Thu, 19 Aug 2021 11:50:17 +0000 - rev 589311
Push 38719 by ccozmuta@mozilla.com at Thu, 19 Aug 2021 21:49:42 +0000
Bug 1718630 - Fix browsertime YTP widevine on windows r=perftest-reviewers,davehunt,padenot Differential Revision: https://phabricator.services.mozilla.com/D122853
eb3bb3f300086ebac66d221be986bb04413f9e47: Bug 1726061 - Make mLiveBufferingAppended optional r=padenot,pehrsons
Chun-Min Chang <chun.m.chang@gmail.com> - Wed, 18 Aug 2021 19:22:04 +0000 - rev 589230
Push 38717 by mlaza@mozilla.com at Thu, 19 Aug 2021 03:33:48 +0000
Bug 1726061 - Make mLiveBufferingAppended optional r=padenot,pehrsons `mLiveBufferingAppended` [1] can be wrapped by a `Maybe` naturally since it should only be used when `mLiveFramesAppended` [2] is `true`. It's easier to make sure `mLiveBufferingAppended` be used in a reasonable timing by doing so, instead of checking `mLiveFramesAppended` every time before using `mLiveBufferingAppended`. [1] https://searchfox.org/mozilla-central/rev/d3683dbb252506400c71256ef3994cdbdfb71ada/dom/media/webrtc/MediaEngineWebRTCAudio.h#236 [2] https://searchfox.org/mozilla-central/rev/d3683dbb252506400c71256ef3994cdbdfb71ada/dom/media/webrtc/MediaEngineWebRTCAudio.h#230 Differential Revision: https://phabricator.services.mozilla.com/D122797
2279a9943b89f5f9b5d5e0f25005f1ba83291a00: Bug 1725523 - Use BinaryPath::GetFile to find mozav* libraries. r=padenot
Mike Hommey <mh+mozilla@glandium.org> - Wed, 18 Aug 2021 00:16:51 +0000 - rev 589154
Push 38716 by abutkovits@mozilla.com at Wed, 18 Aug 2021 15:53:06 +0000
Bug 1725523 - Use BinaryPath::GetFile to find mozav* libraries. r=padenot Instead of deriving their location from the location of liblgplglibs. Differential Revision: https://phabricator.services.mozilla.com/D122545
3c045e65fad452e96ecdfbb0830105ff953846f5: Bug 1725523 - Use BinaryPath::GetFile to find mozav* libraries. r=padenot
Mike Hommey <mh+mozilla@glandium.org> - Fri, 13 Aug 2021 08:11:27 +0000 - rev 588787
Push 38703 by abutkovits@mozilla.com at Fri, 13 Aug 2021 16:07:47 +0000
Bug 1725523 - Use BinaryPath::GetFile to find mozav* libraries. r=padenot Instead of deriving their location from the location of liblgplglibs. Differential Revision: https://phabricator.services.mozilla.com/D122545
92c07c54be8adca59a0a4e22076b244ceab0e2e9: Bug 1721569 - Make TracePayload easier to modify, and use maximum space for name - r=padenot
Gerald Squelart <gsquelart@mozilla.com> - Wed, 11 Aug 2021 03:27:50 +0000 - rev 588521
Push 38694 by archaeopteryx@coole-files.de at Wed, 11 Aug 2021 09:37:02 +0000
Bug 1721569 - Make TracePayload easier to modify, and use maximum space for name - r=padenot An upcoming patch will change the size of ProfilerThreadId, which causes troubles with TracePayload. Trying to move members around didn't help, I'm guessing some padding remains, which cannot be accounted for by just enumerating member sizes. The proposed solution is to wrap all members in a macro (so they don't need to be repeated), and create a private struct with these members and a character, in order to find the exact offset at which the name will actually start. This is uglier, but more flexible, and allows future changes (internal or external) more easily, without having to modify the name-size formula. Differential Revision: https://phabricator.services.mozilla.com/D121050
5984d69367e20af1ff185229884bc6313eefd3fb: Bug 1723799 - part2 : add test. r=padenot,webidl,smaug
alwu <alwu@mozilla.com> - Mon, 09 Aug 2021 19:30:12 +0000 - rev 588263
Push 38690 by imoraru@mozilla.com at Tue, 10 Aug 2021 03:24:07 +0000
Bug 1723799 - part2 : add test. r=padenot,webidl,smaug Differential Revision: https://phabricator.services.mozilla.com/D121681
ec32e714bc0e23fe04f524177a89b14f99242e92: Bug 1723799 - part1 : collect height for visible video playtime. r=padenot
alwu <alwu@mozilla.com> - Mon, 09 Aug 2021 19:30:11 +0000 - rev 588262
Push 38690 by imoraru@mozilla.com at Tue, 10 Aug 2021 03:24:07 +0000
Bug 1723799 - part1 : collect height for visible video playtime. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D121680
83e526a0208562abe9958500375d1c82c4565446: Bug 1719183 - part3 : let running audio context to keep tab awake. r=padenot,nika
alwu <alwu@mozilla.com> - Tue, 03 Aug 2021 21:32:27 +0000 - rev 587717
Push 38671 by malexandru@mozilla.com at Wed, 04 Aug 2021 09:39:31 +0000
Bug 1719183 - part3 : let running audio context to keep tab awake. r=padenot,nika Let running AudioContext also prevents tab from being suspended by asking/revoking the page awake via the browsing context. Differential Revision: https://phabricator.services.mozilla.com/D119839
952d19f991b39cf4f718d96caa37eb24c4a71f91: Bug 1722440 - Update cubeb to e1456788. r=cubeb-reviewers,padenot
Matthew Gregan <kinetik@flim.org> - Tue, 27 Jul 2021 20:56:30 +0000 - rev 586767
Push 38647 by smolnar@mozilla.com at Wed, 28 Jul 2021 09:43:36 +0000
Bug 1722440 - Update cubeb to e1456788. r=cubeb-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D120925
b33035a7f3a293c55395a17493e5ef3dbdf01b0b: no bug - fx doc: adjust the link to 'contribute to moz projects' r=padenot DONTBUILD
Sylvestre Ledru <sledru@mozilla.com> - Tue, 27 Jul 2021 14:44:11 +0000 - rev 586731
Push 38646 by malexandru@mozilla.com at Tue, 27 Jul 2021 21:40:00 +0000
no bug - fx doc: adjust the link to 'contribute to moz projects' r=padenot DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D120974
1be8159477cb9a8c66ebf0e209e03802d3e914c1: Bug 1701383: Move the deregistration of the device changed callback to mInitShutdownThread. r=padenot
Byron Campen <docfaraday@gmail.com> - Tue, 06 Jul 2021 14:12:15 +0000 - rev 584842
Push 38588 by apavel@mozilla.com at Tue, 06 Jul 2021 21:42:42 +0000
Bug 1701383: Move the deregistration of the device changed callback to mInitShutdownThread. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D118860
e9b1ff2959608e83903589fafe1a0a5d808a04a5: Bug 1716248 - Change AppendAndConsumeChunk's input parameter type r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Wed, 23 Jun 2021 00:24:16 +0000 - rev 584102
Push 38558 by mlaza@mozilla.com at Wed, 23 Jun 2021 09:53:24 +0000
Bug 1716248 - Change AppendAndConsumeChunk's input parameter type r=padenot It's better to change the input parameter's type of `AppendAndConsumeChunk` from `AudioChunk*` to `AudioChunk&&` since the `AudioChunk` will be consumed once it's fed to this function. One benefit for doing so is to prevent the consumed `AudioChunk` from being used again after it's moved/consumed. Gecko has a clang-tidy check, bugprone-use-after-move [1], to avoid this kind of error. We should utilize this check instead of catching used-after-move error by human eyes. [1]: https://searchfox.org/mozilla-central/rev/f351e19360729b351bfc7c1386d6e4ca4ea676e2/tools/clang-tidy/config.yaml#70 Differential Revision: https://phabricator.services.mozilla.com/D117714
da97faf315ee132ea0e55811d084e4de78346ed6: Bug 1716248 - Change AppendAndConsumeChunk's input parameter type r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Mon, 21 Jun 2021 21:50:45 +0000 - rev 583926
Push 38557 by malexandru@mozilla.com at Tue, 22 Jun 2021 21:29:07 +0000
Bug 1716248 - Change AppendAndConsumeChunk's input parameter type r=padenot It's better to change the input parameter's type of `AppendAndConsumeChunk` from `AudioChunk*` to `AudioChunk&&` since the `AudioChunk` will be consumed once it's fed to this function. One benefit for doing so is to prevent the consumed `AudioChunk` from being used again after it's moved/consumed. Gecko has a clang-tidy check, bugprone-use-after-move [1], to avoid this kind of error. We should utilize this check instead of catching used-after-move error by human eyes. Differential Revision: https://phabricator.services.mozilla.com/D117714
f0c736218ab6592dbd8f973af162fbac414266fd: Bug 1702646 - Add an util-function to append interleaved buffer in AudioSegment r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Tue, 08 Jun 2021 00:48:21 +0000 - rev 582169
Push 38522 by archaeopteryx@coole-files.de at Tue, 08 Jun 2021 09:18:19 +0000
Bug 1702646 - Add an util-function to append interleaved buffer in AudioSegment r=padenot Add an utility function named AppendFromInterleavedBuffer in AudioSegment to append data from the given interleaved buffer. This function does the same job as what AudioInputProcessing::InsertInGraph and NativeInputTrack::ProcessInput were used to do. As a result, these two functions can be eliminated or simplified. Depends on D116673 Differential Revision: https://phabricator.services.mozilla.com/D116674
c450c5d35c614a45866ee86aa5d56efde8b98d88: Bug 1702646 - Fix TestAudioInputProcessing tests r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Tue, 08 Jun 2021 00:48:20 +0000 - rev 582168
Push 38522 by archaeopteryx@coole-files.de at Tue, 08 Jun 2021 09:18:19 +0000
Bug 1702646 - Fix TestAudioInputProcessing tests r=padenot The AudioInputProcessing now needs to call ProcessInput to process the given input data instead of processing them in NotifyInputData Differential Revision: https://phabricator.services.mozilla.com/D116673
303bfb969f5275ed0e957d60fcdd1a2e98a2ae17: Bug 1702646 - Share AudioSegments among AudioInputTrack r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Tue, 08 Jun 2021 00:48:20 +0000 - rev 582167
Push 38522 by archaeopteryx@coole-files.de at Tue, 08 Jun 2021 09:18:19 +0000
Bug 1702646 - Share AudioSegments among AudioInputTrack r=padenot Each AudioInputTrack has its own AudioSegments storing the input audio data. When the AudioInputTrack is in pass-through mode, the AudioSegment is just the data de-interleaved from its raw data, without any audio processing magic applied on it. If there are multiple AudioInputTracks in pass-through mode exist in the same graph, then all of their AudioSegments are same. Before this patch, each of these AudioInputTracks allocates its own space to store its own AudioSegments even those data are same. This patch makes it possible for these AudioInputTracks to share the same AudioSegment data they need. By creating the AudioSegment in the NativeInputTrack, which is mapped to one specific device and is connected to the AudioInputTrack, the AudioInputTrack can fetch the AudioSegment data when they need and then append shared-references of the AudioChunk, inside the fetched AudioSegment, into their own AudioSegment. Therefore, we can have some AudioChunks created by the NativeInputTrack and shared among the AudioInputTracks in pass-through mode. Differential Revision: https://phabricator.services.mozilla.com/D114801
98aad7de92bf6d821b5b43bba6f223b642d01aed: Bug 1702646 - Process audio input in ProcessInput r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Tue, 08 Jun 2021 00:48:19 +0000 - rev 582166
Push 38522 by archaeopteryx@coole-files.de at Tue, 08 Jun 2021 09:18:19 +0000
Bug 1702646 - Process audio input in ProcessInput r=padenot Instead of receiving and processing audio input data in AudioInputProcessing::NotifyInputData, we can get the audio input data from the connected source via the MediaInputPort and process it in AudioInputTrack::ProcessInput Differential Revision: https://phabricator.services.mozilla.com/D114807
dad561cb1cfb13f166775687bacb5cfb3979d567: Bug 1702646 - Use NativeInputTrack to deliver audio data r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Tue, 08 Jun 2021 00:48:19 +0000 - rev 582165
Push 38522 by archaeopteryx@coole-files.de at Tue, 08 Jun 2021 09:18:19 +0000
Bug 1702646 - Use NativeInputTrack to deliver audio data r=padenot - Create a NativeInputTrack that is managed by main-thread in MTG - Replace mInputDeviceUsers by a <device-id, NativeInputTrack> map Differential Revision: https://phabricator.services.mozilla.com/D113680
2d291a99004dd0aea5304bb8cae306a47083ff94: Bug 1517199 - part6 : add A/V sync test case for changing playback rate dynamically. r=padenot
alwu <alwu@mozilla.com> - Wed, 02 Jun 2021 16:39:03 +0000 - rev 581729
Push 38511 by cbrindusan@mozilla.com at Wed, 02 Jun 2021 21:44:47 +0000
Bug 1517199 - part6 : add A/V sync test case for changing playback rate dynamically. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D116285
b1945b56639872fa75cb1a0baf89f135ca35adb7: Bug 1517199 - part5 : handle the playback rate change on video track and add crash test. r=padenot
alwu <alwu@mozilla.com> - Wed, 02 Jun 2021 16:39:02 +0000 - rev 581728
Push 38511 by cbrindusan@mozilla.com at Wed, 02 Jun 2021 21:44:47 +0000
Bug 1517199 - part5 : handle the playback rate change on video track and add crash test. r=padenot When we adjust the playback rate on the audio track, the audio clock time would be no longer align with the graph time. Eg. playback rate=2, when the graph time passes 10s, the audio clock time actually already goes forward 20s. After audio track ended, the video track would start to drive the clock time but the video clock time is align with the graph time, which means it would be smaller than the audio clock in that situation. Therefore, we have to ignore the video clock time in that case. In addition, this patch also address the duration change on video frames based on the playback rate. Differential Revision: https://phabricator.services.mozilla.com/D115035
1c845c5e12535086d8351a3e836a72e8c7c8ac36: Bug 1517199 - part4 : add gtest. r=padenot
alwu <alwu@mozilla.com> - Wed, 02 Jun 2021 16:39:02 +0000 - rev 581727
Push 38511 by cbrindusan@mozilla.com at Wed, 02 Jun 2021 21:44:47 +0000
Bug 1517199 - part4 : add gtest. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D114922
8d6a8d4836ea68e925e470bf8598443373a99bb3: Bug 1517199 - part3 : add more logs. r=padenot
alwu <alwu@mozilla.com> - Wed, 02 Jun 2021 16:39:02 +0000 - rev 581726
Push 38511 by cbrindusan@mozilla.com at Wed, 02 Jun 2021 21:44:47 +0000
Bug 1517199 - part3 : add more logs. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D114921
772b0a55567475dffcd3dcccbae2f7e837eb6e83: Bug 1517199 - part2 : enable wpts. r=padenot
alwu <alwu@mozilla.com> - Wed, 02 Jun 2021 16:39:01 +0000 - rev 581725
Push 38511 by cbrindusan@mozilla.com at Wed, 02 Jun 2021 21:44:47 +0000
Bug 1517199 - part2 : enable wpts. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D114916
172ef2cae6ed889015f0f2ecd24e76fdb5d2404f: Bug 1517199 - part1 : time stretching samples in AudioDecoderInputTrack. r=padenot
alwu <alwu@mozilla.com> - Wed, 02 Jun 2021 16:39:01 +0000 - rev 581724
Push 38511 by cbrindusan@mozilla.com at Wed, 02 Jun 2021 21:44:47 +0000
Bug 1517199 - part1 : time stretching samples in AudioDecoderInputTrack. r=padenot By using the soundtouch library, this patch implements the time stretching on the samples in AudioDecoderInputTrack when its playback rate is not 1.0f, in order to support changing playback rate on the captured media stream. As the time stretcher has to be initialized by a fixed channel count, we would perform a realtime up-mix/down-mix for those audio chunks which have different channel count thant AudioDecoderInputTrack's initial channel count. Differential Revision: https://phabricator.services.mozilla.com/D114560
2b5f35e21e84a3310fd6f238cb79469ffc325ec2: Bug 1702646 - Share AudioSegments among AudioInputTrack r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Wed, 02 Jun 2021 01:05:20 +0000 - rev 581647
Push 38511 by cbrindusan@mozilla.com at Wed, 02 Jun 2021 21:44:47 +0000
Bug 1702646 - Share AudioSegments among AudioInputTrack r=padenot Each AudioInputTrack has its own AudioSegments storing the input audio data. When the AudioInputTrack is in pass-through mode, the AudioSegment is just the data de-interleaved from its raw data, without any audio processing magic applied on it. If there are multiple AudioInputTracks in pass-through mode exist in the same graph, then all of their AudioSegments are same. Before this patch, each of these AudioInputTracks allocates its own space to store its own AudioSegments even those data are same. This patch makes it possible for these AudioInputTracks to share the same AudioSegment data they need. By creating the AudioSegment in the NativeInputTrack, which is mapped to one specific device and is connected to the AudioInputTrack, the AudioInputTrack can fetch the AudioSegment data when they need and then append shared-references of the AudioChunk, inside the fetched AudioSegment, into their own AudioSegment. Therefore, we can have some AudioChunks created by the NativeInputTrack and shared among the AudioInputTracks in pass-through mode. Differential Revision: https://phabricator.services.mozilla.com/D114801
13dc1577b2a0137b9336b210373afb0e22ce9204: Bug 1702646 - Process audio input in ProcessInput r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Wed, 02 Jun 2021 01:05:20 +0000 - rev 581646
Push 38511 by cbrindusan@mozilla.com at Wed, 02 Jun 2021 21:44:47 +0000
Bug 1702646 - Process audio input in ProcessInput r=padenot Instead of receiving and processing audio input data in AudioInputProcessing::NotifyInputData, we can get the audio input data from the connected source via the MediaInputPort and process it in AudioInputTrack::ProcessInput Differential Revision: https://phabricator.services.mozilla.com/D114807
f87a905f445aeaffd29e80f0b4f05957f59dadc9: Bug 1702646 - Use NativeInputTrack to deliver audio data r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Wed, 02 Jun 2021 01:05:20 +0000 - rev 581645
Push 38511 by cbrindusan@mozilla.com at Wed, 02 Jun 2021 21:44:47 +0000
Bug 1702646 - Use NativeInputTrack to deliver audio data r=padenot - Create a NativeInputTrack that is managed by main-thread in MTG - Replace mInputDeviceUsers by a <device-id, NativeInputTrack> map Differential Revision: https://phabricator.services.mozilla.com/D113680
97a63d63d2191f411fd313555b1a3f7c7128a3c3: Bug 1712598 - part2 : add a test for A/V sync. r=padenot
alwu <alwu@mozilla.com> - Fri, 28 May 2021 19:11:19 +0000 - rev 581353
Push 38499 by nerli@mozilla.com at Sat, 29 May 2021 03:43:09 +0000
Bug 1712598 - part2 : add a test for A/V sync. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D116055
49489b3d5a3e02113481c536155ff6a1097d95f2: Bug 1712598 - part1 : fill silence if detecting a gap in audio. r=padenot
alwu <alwu@mozilla.com> - Fri, 28 May 2021 19:11:19 +0000 - rev 581352
Push 38499 by nerli@mozilla.com at Sat, 29 May 2021 03:43:09 +0000
Bug 1712598 - part1 : fill silence if detecting a gap in audio. r=padenot If there is a gap bewteen the audio that is going to be appended next and the amount of frames that we've appended, then we need to fill silence data in order to keep A/V sync correct. We did that for the DecodedStream [1] before, but that got removed during the refactoring. [1] https://searchfox.org/mozilla-central/rev/36181d2c169bafd5e13c534851c8b25d1567cfc3/dom/media/mediasink/DecodedStream.cpp#660-667 Differential Revision: https://phabricator.services.mozilla.com/D115857
70c1e268265af47a516ec9e66540face6eb30d81: Bug 1712595 - ensure AudioSink won't discard frames that are not played yet. r=padenot
alwu <alwu@mozilla.com> - Fri, 28 May 2021 19:11:18 +0000 - rev 581351
Push 38499 by nerli@mozilla.com at Sat, 29 May 2021 03:43:09 +0000
Bug 1712595 - ensure AudioSink won't discard frames that are not played yet. r=padenot When we switch to the DecodedStream from AudioSink. AudioSink would store some frames in its own media queue before those audio frames get played. After AudioSink got shutdown, it doesn't push those frames back to the original audio queue. Therefore, when DecodedStream starts, it try to retrieve audio data from the audio queue, but it doesn't know that there is already a gap between "the audio DecodedStream is going to play" and "the audio that AudioSink had played". Differential Revision: https://phabricator.services.mozilla.com/D115749
2db5c88a50e2a52198dc2539bea4477903ddda62: Bug 1712621 - Update cubeb to 5ebe69c. r=cubeb-reviewers,padenot
Matthew Gregan <kinetik@flim.org> - Tue, 25 May 2021 10:44:33 +0000 - rev 580596
Push 38490 by apavel@mozilla.com at Tue, 25 May 2021 15:34:49 +0000
Bug 1712621 - Update cubeb to 5ebe69c. r=cubeb-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D115837
4766a5d3c31256c0f4ea3de152c0e489c8485ac9: Bug 1712031 - Adjust the type of fallbackIterations to match that of IterationCount(). r=padenot
Mike Hommey <mh+mozilla@glandium.org> - Mon, 24 May 2021 21:40:27 +0000 - rev 580555
Push 38489 by abutkovits@mozilla.com at Tue, 25 May 2021 09:34:31 +0000
Bug 1712031 - Adjust the type of fallbackIterations to match that of IterationCount(). r=padenot Differential Revision: https://phabricator.services.mozilla.com/D115564
b2bb0180d7b9146b0c55d71c9a5623453ded2f04: Bug 1709899 - batch all data together when appending data to 'AudioDecoderInputTrack' to further ensure the free spaces in SPSC queue. r=padenot.
alwu <alwu@mozilla.com> - Mon, 10 May 2021 22:18:26 +0000 - rev 579296
Push 38452 by imoraru@mozilla.com at Tue, 11 May 2021 09:33:39 +0000
Bug 1709899 - batch all data together when appending data to 'AudioDecoderInputTrack' to further ensure the free spaces in SPSC queue. r=padenot. Differential Revision: https://phabricator.services.mozilla.com/D114559
256849121aa4975b93e8fad156db2c1e0deaea4e: Bug 1710095 - Update audioipc to 7537bfad for memmap -> memmap2 transition. r=chunmin,cubeb-reviewers,padenot
Matthew Gregan <kinetik@flim.org> - Mon, 10 May 2021 20:40:40 +0000 - rev 579289
Push 38452 by imoraru@mozilla.com at Tue, 11 May 2021 09:33:39 +0000
Bug 1710095 - Update audioipc to 7537bfad for memmap -> memmap2 transition. r=chunmin,cubeb-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D114665
ca8e5adefcbed526e5bb7decd82c88da98a47352: Bug 1709684 - disable test on OSX. r=padenot
alwu <alwu@mozilla.com> - Thu, 06 May 2021 16:23:23 +0000 - rev 578747
Push 38441 by smolnar@mozilla.com at Thu, 06 May 2021 21:43:11 +0000
Bug 1709684 - disable test on OSX. r=padenot I acutally discovered that during testing the bug1709130, but I forgot to update that in D114150. We would get an decoding error during testing, which is a different issue from what bug1709130 encountered. That error only happens on testing, directly playing that video on Firefox works. So disabling the test on OSX for now, we can dig into that later if that really causes a problem. Differential Revision: https://phabricator.services.mozilla.com/D114400
dabcebd90cf4597f9606d511b6e4cc4573717161: Bug 1709130 - part1 : extend the SPSC queue's capacity for AudioDecoderInputTrack. r=padenot
alwu <alwu@mozilla.com> - Wed, 05 May 2021 16:50:33 +0000 - rev 578599
Push 38437 by ncsoregi@mozilla.com at Wed, 05 May 2021 21:52:08 +0000
Bug 1709130 - part1 : extend the SPSC queue's capacity for AudioDecoderInputTrack. r=padenot In the initial implementation, we only used 20 capacity for SPSC queue and added some mechanisms (batched data to save the free space of SPSC queue/clean SPSC queue in each graph iteration) to prevent it from being full. But that seems not working in some extreme cases where decoding is too fast and the graph thread can't catch up the speef of processing the input. So extend the queue size to 40 that should allow SPSC to work without being full again. Differential Revision: https://phabricator.services.mozilla.com/D114150
79b910105bf022de748b88dfa5371fc93cf703d7: Bug 1708179 Test PannerNode.setPosition() throws with parameter out of range of float r=padenot
Karl Tomlinson <karlt+@karlt.net> - Tue, 04 May 2021 03:48:34 +0000 - rev 578397
Push 38433 by nbeleuzu@mozilla.com at Tue, 04 May 2021 21:49:50 +0000
Bug 1708179 Test PannerNode.setPosition() throws with parameter out of range of float r=padenot Depends on D113943 Differential Revision: https://phabricator.services.mozilla.com/D113944
287e7da8b0d5a3a6d18d3bdb2cc257efe97467c7: Bug 1708179 throw when PannerNode param value a not in the range of float r=padenot
Karl Tomlinson <karlt+@karlt.net> - Tue, 04 May 2021 03:48:34 +0000 - rev 578396
Push 38433 by nbeleuzu@mozilla.com at Tue, 04 May 2021 21:49:50 +0000
Bug 1708179 throw when PannerNode param value a not in the range of float r=padenot This is similar to what WebIDL bindings would do for us when the AudioParam setters are called. setPosition() "is equivalent to setting positionX.value, positionY.value, and positionZ.value attribute directly with the x, y and z parameters, respectively." https://webaudio.github.io/web-audio-api/#dom-pannernode-setposition Differential Revision: https://phabricator.services.mozilla.com/D113943
a08e66f10499dbc7f8a6cd32736007a858ad2d9d: Bug 1708179 switch from PannerNode.setPosition() parameters close to DBL_MAX to FLT_MAX r=padenot
Karl Tomlinson <karlt+@karlt.net> - Tue, 04 May 2021 03:48:33 +0000 - rev 578395
Push 38433 by nbeleuzu@mozilla.com at Tue, 04 May 2021 21:49:50 +0000
Bug 1708179 switch from PannerNode.setPosition() parameters close to DBL_MAX to FLT_MAX r=padenot The large numbers were to test https://hg.mozilla.org/integration/mozilla-inbound/rev/084b01d1b6b3 but were ignored after https://hg.mozilla.org/integration/mozilla-inbound/rev/8799895ca858 Depends on D113941 Differential Revision: https://phabricator.services.mozilla.com/D113942
aff5404e2d744f19cb1b6cec16ebff0718d21f3a: Bug 1708179 Test AudioParam value setter throws during setValueCurveAtTime() interval r=padenot
Karl Tomlinson <karlt+@karlt.net> - Tue, 04 May 2021 03:48:33 +0000 - rev 578394
Push 38433 by nbeleuzu@mozilla.com at Tue, 04 May 2021 21:49:50 +0000
Bug 1708179 Test AudioParam value setter throws during setValueCurveAtTime() interval r=padenot Depends on D113940 Differential Revision: https://phabricator.services.mozilla.com/D113941