searching for reviewer(padenot)
f211cbbd473bdf1d4c0c802594dd85427e5209d3: Bug 1665431 - [ci] Exclusively schedule android when only dom/media/systemservices/android_video_capture is modified, r=padenot
Andrew Halberstadt <ahal@pm.me> - Thu, 17 Sep 2020 07:37:39 +0000 - rev 549242
Push 37793 by cbrindusan@mozilla.com at Fri, 18 Sep 2020 15:11:18 +0000
Bug 1665431 - [ci] Exclusively schedule android when only dom/media/systemservices/android_video_capture is modified, r=padenot Differential Revision: https://phabricator.services.mozilla.com/D90449
3d0dd2de6a45027def8f73ada94ad0e06e76db5f: Bug 1656438 - Tighten PreSilence checks in TestAudioTrackGraph.cpp. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:13:50 +0000 - rev 549116
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Tighten PreSilence checks in TestAudioTrackGraph.cpp. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D90436
e054117630cb2429ad45a42e62935ee10e2a1061: Bug 1656438 - Tighten estimated frequency check by accounting for drift factor. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:13:42 +0000 - rev 549115
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Tighten estimated frequency check by accounting for drift factor. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D89987
5d2a5063ef6f5ae38a508468869e9ed78b81eb8c: Bug 1656438 - Make integer types explicit and unsigned in AudioDriftCorrection and friends. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:13:40 +0000 - rev 549114
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Make integer types explicit and unsigned in AudioDriftCorrection and friends. r=padenot In particular, this patch gets rid of signed integers where negative values don't make sense anyway. Differential Revision: https://phabricator.services.mozilla.com/D89777
2f3a801569ab51f6af12087f1edc9b181f8c0688: Bug 1656438 - Rework the audio drift correction logic. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:13:32 +0000 - rev 549113
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Rework the audio drift correction logic. r=padenot This patch simplifies the logic by reducing the number of paths, from two to one method that changes the correction. This method now weighs the calculated correction by 60% and the previous correction by 40% when setting the new value, to provide a negative feedback loop that stabilizes around the desired amount of buffering. This leads to a smoother output with less noticable changes in the correction value, while still reaching the desired amount of buffering quickly. Tests are updated with new expectations accordingly. Differential Revision: https://phabricator.services.mozilla.com/D89776
c875169cf76cc8519b8bbd2864db2fecf739483a: Bug 1656438 - Remove logic that ignores correction changes that are too small. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:13:30 +0000 - rev 549112
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Remove logic that ignores correction changes that are too small. r=padenot The removed logic complicates tests, as the correction code does not always strive to reach the desired buffering level. If the changes are small enough the buffer continues to shrink or grow until we get close to the edge and then a much more abrupt correction change is applied, something noticable by ear. Differential Revision: https://phabricator.services.mozilla.com/D89775
acc2f0ebdbfc81a213a718f75d91d8a068fedfc6: Bug 1656438 - Avoid overflowing the internal AudioResampler ring buffer. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:13:27 +0000 - rev 549111
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Avoid overflowing the internal AudioResampler ring buffer. r=padenot Depends on D89773 Differential Revision: https://phabricator.services.mozilla.com/D89774
92a13f4e141490ed9ae0c15d3a0eead59606ef0c: Bug 1656438 - Handle null chunks in AudioVerifier. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:12:46 +0000 - rev 549110
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Handle null chunks in AudioVerifier. r=padenot Depends on D89772 Differential Revision: https://phabricator.services.mozilla.com/D89773
858acfa421fb27e4a3673d3a09ad74e081931f01: Bug 1656438 - Run all MockCubebStreams off the same fake audio thread to avoid unwanted drift. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:13:25 +0000 - rev 549109
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Run all MockCubebStreams off the same fake audio thread to avoid unwanted drift. r=padenot With this patch, there is a fake audio thread present on a MockCubeb context as soon as one MockCubebStream is running under that context. When the last running MockCubebStream is stopped, the fake audio thread is joined and unset. This adds a tad bit of complexity but results in zero unwanted drift between MockCubebStreams under the same MockCubeb context. This is essential for stable CrossGraphTrack tests. A side effect of this is that the drift factor of a MockCubebStream does not affect the interval at which data is processed, but rather the amount of data processed each interval. This patch also allows us to process data with virtually no wait time between iterations (as opposed to wall-time 10ms-waits), for (much) speedier tests. Differential Revision: https://phabricator.services.mozilla.com/D89772
161fffd38aec4969c4b49ece877c8e919805298b: Bug 1656438 - Remove unused LOG macro from MockCubeb.h. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:13:23 +0000 - rev 549108
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Remove unused LOG macro from MockCubeb.h. r=padenot Depends on D89770 Differential Revision: https://phabricator.services.mozilla.com/D89771
4d8478bb956708852f0b381ed0d6ab9cc836d9c2: Bug 1656438 - Add license info to MockCubeb.h. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:13:20 +0000 - rev 549107
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Add license info to MockCubeb.h. r=padenot Depends on D89769 Differential Revision: https://phabricator.services.mozilla.com/D89770
430041e6976efc5c1c7493aeab71d72bd5381ec6: Bug 1656438 - Rid MockCubeb.h of `using namespace` lines. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:13:18 +0000 - rev 549106
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Rid MockCubeb.h of `using namespace` lines. r=padenot Depends on D89768 Differential Revision: https://phabricator.services.mozilla.com/D89769
9c32acffc007f19dbb5c653d304baf65415f4b38: Bug 1656438 - Spell check and nits. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:12:06 +0000 - rev 549105
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Spell check and nits. r=padenot Depends on D89767 Differential Revision: https://phabricator.services.mozilla.com/D89768
df67e69cda9b4fab7ddba6efdc7d20109efbb9aa: Bug 1656438 - Test odd rates in TestAudioDriftCorrection. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:11:58 +0000 - rev 549104
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Test odd rates in TestAudioDriftCorrection. r=padenot Depends on D89766 Differential Revision: https://phabricator.services.mozilla.com/D89767
baa63e933c9226d8b81cf4efcb59a03870c36ea3: Bug 1656438 - Add a warning when running out of resampler buffer. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:11:44 +0000 - rev 549103
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Add a warning when running out of resampler buffer. r=padenot Depends on D89765 Differential Revision: https://phabricator.services.mozilla.com/D89766
2594f7cc9016f66dd5d6789dce570b047ec0109d: Bug 1656438 - Guard against making drift worse when the desired buffer is large. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:11:36 +0000 - rev 549102
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Guard against making drift worse when the desired buffer is large. r=padenot The resampled source clock can become negative with a large desired buffer and a small current buffer. This patch clamps it above 1 so we never drift-correct in the wrong direction. Differential Revision: https://phabricator.services.mozilla.com/D89765
99609c0402583abc0f4a123b28e55d9d49ff99ac: Bug 1656438 - Verify that the current buffer is close to the desired buffer in length. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:11:36 +0000 - rev 549101
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Verify that the current buffer is close to the desired buffer in length. r=padenot Depends on D89763 Differential Revision: https://phabricator.services.mozilla.com/D89764
fbafdfaa1dbac5d1aeeab0eea088bf9c567e19fb: Bug 1656438 - Get rid of NUM_OF_FRAMES from MockCubeb. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:11:28 +0000 - rev 549100
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Get rid of NUM_OF_FRAMES from MockCubeb. r=padenot This allows us to configure the number of frames more dynamically, and update it on the fly to simulate drift. Differential Revision: https://phabricator.services.mozilla.com/D89763
36e8c0eac2a3862048908f3775bc92558e5df7f1: Bug 1656438 - Update the resampler after a fixed duration instead of a fixed number of iterations. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:11:11 +0000 - rev 549099
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Update the resampler after a fixed duration instead of a fixed number of iterations. r=padenot This makes the tests more similar to real-world scenarios, where the duration of an iteration may vary. Differential Revision: https://phabricator.services.mozilla.com/D89762
2660b04913a787e0fafd2a7a4d3a7af8ac254efd: Bug 1656438 - Fix the unit of the desired buffering. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:11:10 +0000 - rev 549098
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Fix the unit of the desired buffering. r=padenot Comments mention 5ms, but code says it's 50ms. Differential Revision: https://phabricator.services.mozilla.com/D89761
b89f16819d2bd5e795503580b5689d5c6f61b2e7: Bug 1656438 - Take the desired buffering as parameter in ClockDrift, AudioResampler, and friends. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:10:54 +0000 - rev 549097
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Take the desired buffering as parameter in ClockDrift, AudioResampler, and friends. r=padenot This makes us able to write tests for different buffer lengths. Differential Revision: https://phabricator.services.mozilla.com/D89760
d280a287155461c3834e9b89402693757d3c1140: Bug 1656438 - Report pre-buffer as current buffer size before receiving data in DynamicResampler. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:10:47 +0000 - rev 549096
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Report pre-buffer as current buffer size before receiving data in DynamicResampler. r=padenot Without this patch we return 0, and that can be misinterpreted by AudioDriftCorrection so it thinks we have drifted a lot. This becomes more obvious with a large desired buffer. Differential Revision: https://phabricator.services.mozilla.com/D89759
550746dd0946920630d659a927469ecb3cb0b917: Bug 1656438 - Make const DynamicResampler members public. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:10:47 +0000 - rev 549095
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Make const DynamicResampler members public. r=padenot Depends on D89757 Differential Revision: https://phabricator.services.mozilla.com/D89758
6d1ff697b42f9247bf483283a5945e7f58959456: Bug 1656438 - Test CrossGraph ports with a multi-second buffer. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:10:32 +0000 - rev 549094
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Test CrossGraph ports with a multi-second buffer. r=padenot The buffer size is exposed as a pref, so it better have a bit of test coverage. Differential Revision: https://phabricator.services.mozilla.com/D89757
6618cac882fb973a5f1a94f18d0eb32e21bf4443: Bug 1656438 - Elaborate on CrossGraphPort tests. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:10:25 +0000 - rev 549093
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Elaborate on CrossGraphPort tests. r=padenot This patch lets us pass in a drift factor to allow for testing of the drift correction code. It also enables output verification for the CrossGraph tests. Differential Revision: https://phabricator.services.mozilla.com/D89756
34f42101f9cb7ef0a7c83b093705b397bf6a9c2c: Bug 1656438 - Prune chunks after 50ms without imagining the samplerate. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:10:18 +0000 - rev 549092
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Prune chunks after 50ms without imagining the samplerate. r=padenot In a CrossGraphReceiver there is 100ms worth of buffering in AudioChunks. Without this patch the graph will buffer 2400 frames in each track before removing data from them. If a graph contains a CrossGraphReceiver and runs at a sample rate lower than 24000Hz, that CrossGraphReceiver will run out of chunks and an assertion failure happens at best. Differential Revision: https://phabricator.services.mozilla.com/D89755
cb764411f0b82bb182837087b615a3aa463dcbad: Bug 1656438 - Do output verification in the gtest body. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:10:19 +0000 - rev 549091
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Do output verification in the gtest body. r=padenot Depends on D89753 Differential Revision: https://phabricator.services.mozilla.com/D89754
8280b08292e9f364c324518a9355716d6bceae32: Bug 1656438 - Only raise the FramesProcessedEvent once there is no silence. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:10:04 +0000 - rev 549090
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Only raise the FramesProcessedEvent once there is no silence. r=padenot Because an audio driver starts out with its fallback driver running the graph, we might use unnecessary amounts of silence for the verification. Especially with the `GoFaster()` mode turned on, as the fallback driver's thread runs rarely compared to how often we are feeding the graph audio data from the MockCubebStream. Differential Revision: https://phabricator.services.mozilla.com/D89753
62c35a6a0fd4b841ba50e12f2e3d88a37f8138ad: Bug 1656438 - Remove MockCubeb::GetCurrentStream. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:09:56 +0000 - rev 549089
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Remove MockCubeb::GetCurrentStream. r=padenot It is a fragile and timing-sensitive way of getting the stream. Differential Revision: https://phabricator.services.mozilla.com/D89752
69d48ebdfaccb6fae91a3900c2387964f1ee6815: Bug 1656438 - Remove dependency on GMPTestMonitor in TestAudioTrackGraph.cpp. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:09:56 +0000 - rev 549088
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Remove dependency on GMPTestMonitor in TestAudioTrackGraph.cpp. r=padenot Depends on D89749 Differential Revision: https://phabricator.services.mozilla.com/D89751
87e0c52fe19ef1528021c7e17db5d149f9051ac0: Bug 1656438 - Simplify TestAudioTrackGraph.CrossGraphPort. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:09:49 +0000 - rev 549087
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Simplify TestAudioTrackGraph.CrossGraphPort. r=padenot Depends on D89748 Differential Revision: https://phabricator.services.mozilla.com/D89749
22a0a139d9df5ed9b359b99037c0e0c7eb3158a7: Bug 1656438 - Simplify TestAudioTrackGraph.SourceTrack. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:09:46 +0000 - rev 549086
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Simplify TestAudioTrackGraph.SourceTrack. r=padenot Depends on D89747 Differential Revision: https://phabricator.services.mozilla.com/D89748
9a5f9512c70236ea74eba5486e1f0403a02fe183: Bug 1656438 - Simplify TestAudioTrackGraph.ErrorStateCrash. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:09:38 +0000 - rev 549085
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Simplify TestAudioTrackGraph.ErrorStateCrash. r=padenot Depends on D89746 Differential Revision: https://phabricator.services.mozilla.com/D89747
ecb65e2201404f2c3fe43793166f926bda3a6c70: Bug 1656438 - Simplify TestAudioTrackGraph.NotifyDeviceStarted. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:09:31 +0000 - rev 549084
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Simplify TestAudioTrackGraph.NotifyDeviceStarted. r=padenot Depends on D89745 Differential Revision: https://phabricator.services.mozilla.com/D89746
b067afd21774a7280822f8b3a481aa8295c9490d: Bug 1656438 - Simplify TestAudioTrackGraph.SetOutputDeviceID. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:09:23 +0000 - rev 549083
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Simplify TestAudioTrackGraph.SetOutputDeviceID. r=padenot Depends on D89744 Differential Revision: https://phabricator.services.mozilla.com/D89745
763cad55099f749fe9f7536ef50548e9ca92c8c0: Bug 1656438 - Simplify TestAudioTrackGraph.DifferentDeviceIDs. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:09:15 +0000 - rev 549082
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Simplify TestAudioTrackGraph.DifferentDeviceIDs. r=padenot Depends on D89743 Differential Revision: https://phabricator.services.mozilla.com/D89744
f9b79874d1f456ded38e74c79754a20ce9d2b533: Bug 1656438 - Add explainer for the need for asyncness in TestAudioTrackGraph.cpp. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:09:08 +0000 - rev 549081
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Add explainer for the need for asyncness in TestAudioTrackGraph.cpp. r=padenot Depends on D89742 Differential Revision: https://phabricator.services.mozilla.com/D89743
9cc7dae0f6cece7efc93fe1929659d547519d7ad: Bug 1656438 - Break out and simplify the StartStop ControlMessage for re-use. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:09:00 +0000 - rev 549080
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Break out and simplify the StartStop ControlMessage for re-use. r=padenot Depends on D89741 Differential Revision: https://phabricator.services.mozilla.com/D89742
71eb16751143f47d3c9418fa957fef26f299fdd2: Bug 1656438 - Add async flow helpers to TestAudioTrackGraph. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:08:52 +0000 - rev 549079
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Add async flow helpers to TestAudioTrackGraph. r=padenot Depends on D89740 Differential Revision: https://phabricator.services.mozilla.com/D89741
fdace333aa6745d4ae3ef6ad2a2a334f9f208177: Bug 1656438 - Speed up MediaTrackGraph gtests. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:08:39 +0000 - rev 549077
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Speed up MediaTrackGraph gtests. r=padenot Depends on D85558 Differential Revision: https://phabricator.services.mozilla.com/D89739
252ec1467765f70a26fa8aeefc30b761b2dd4e97: Bug 1656438 - Create a unittest for CrossGraphTrack. r=padenot
Alex Chronopoulos <achronop@gmail.com> - Thu, 17 Sep 2020 06:08:24 +0000 - rev 549076
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Create a unittest for CrossGraphTrack. r=padenot The unittest does not verify that the input is forwarded to the output of the CrossGraphReceiver because it is not easy to get the corresponding MockCubebStream. This has been left as future work. Depends on D85557 Differential Revision: https://phabricator.services.mozilla.com/D85558
182d3a61c1766a2a2c9e89d40e8e84dbc49f53a6: Bug 1656438 - Create a unittest for SourceMediaTrack and AudioInputProcessing. r=padenot
Alex Chronopoulos <achronop@gmail.com> - Thu, 17 Sep 2020 06:16:18 +0000 - rev 549075
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Create a unittest for SourceMediaTrack and AudioInputProcessing. r=padenot Use the newly added functionality in MockCubeb to verify that the input is forwarded to the output. Depends on D85556 Differential Revision: https://phabricator.services.mozilla.com/D85557
64db6defa1538e890e9321a6756a84367d20c743: Bug 1656438 - Simulate audio input and verify audio output in MockCubeb. r=padenot
Alex Chronopoulos <achronop@gmail.com> - Thu, 17 Sep 2020 06:08:06 +0000 - rev 549074
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Simulate audio input and verify audio output in MockCubeb. r=padenot With this patch, AudioGenerator is used to create a sine tone audio input to a duplex stream. In parallel, the AudioVerifier is used to verify that this sine tone exists in the output (on demand). This is the first approach. Fancier generators/verifiers can be future work. Depends on D85554 Differential Revision: https://phabricator.services.mozilla.com/D85555
c88d14bbe784adbe2f457474ec88762ffc84a5da: Bug 1656438 - Add interleaved buffer support in AudioGenerator/Verifier. r=padenot
Alex Chronopoulos <achronop@gmail.com> - Thu, 17 Sep 2020 06:07:59 +0000 - rev 549073
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Add interleaved buffer support in AudioGenerator/Verifier. r=padenot This is useful in order to be used by the low-level part of the stack (MockCubeb) where the buffers contain interleaved channels. Depends on D85553 Differential Revision: https://phabricator.services.mozilla.com/D85554
3030d1b69789fd52d41f2fef068d09323032c236: Bug 1656438 - Remove AudioToneGenerator and move AudioToneVerifier to dedicated file. r=padenot
Alex Chronopoulos <achronop@gmail.com> - Thu, 17 Sep 2020 06:16:49 +0000 - rev 549072
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Remove AudioToneGenerator and move AudioToneVerifier to dedicated file. r=padenot The existing AudioGenerator takes over the job of AudioToneGenerator. AudioToneVerifier becomes AudioVerifier to match the naming pattern. In order to reuse the functionality for other tests. Depends on D85552 Differential Revision: https://phabricator.services.mozilla.com/D85553
f0b7c4adc147e134e446348684755e6d5fdc7665: Bug 1656438 - Generalize AudioGenerator and SineWaveGenerator to support AudioToneGenerator's use cases. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 17 Sep 2020 06:07:50 +0000 - rev 549071
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Generalize AudioGenerator and SineWaveGenerator to support AudioToneGenerator's use cases. r=padenot Depends on D85552 Differential Revision: https://phabricator.services.mozilla.com/D89738
6924873d9f6a60f1b46b16ff629803211a6cae09: Bug 1656438 - Replace dos EOL with unix one. r=padenot
Alex Chronopoulos <achronop@gmail.com> - Thu, 17 Sep 2020 06:16:49 +0000 - rev 549070
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1656438 - Replace dos EOL with unix one. r=padenot In addition to that remove it from the exclude list of the whitespace sanity check assuming that the dos EOL had made it fail. Differential Revision: https://phabricator.services.mozilla.com/D85552
b0ef6aa3f4f19eca33149a5e63d6e9925659c084: Bug 1646601 test AudioContext constructor throws when not fully active r=padenot
Karl Tomlinson <karlt+@karlt.net> - Wed, 16 Sep 2020 16:28:36 +0000 - rev 549046
Push 37790 by btara@mozilla.com at Thu, 17 Sep 2020 10:09:40 +0000
Bug 1646601 test AudioContext constructor throws when not fully active r=padenot Differential Revision: https://phabricator.services.mozilla.com/D90218
104d93996c65f7bb8a11f4c3e2756bede2c2c6b6: Bug 1646601 add crashtest with AudioContext after unload r=padenot
Karl Tomlinson <karlt+@karlt.net> - Tue, 15 Sep 2020 22:13:21 +0000 - rev 548856
Push 37787 by malexandru@mozilla.com at Wed, 16 Sep 2020 09:56:56 +0000
Bug 1646601 add crashtest with AudioContext after unload r=padenot Differential Revision: https://phabricator.services.mozilla.com/D84300
308379f9ee0ebd06a2398395624f3abb36b10884: Bug 1646601 throw InvalidStateError on (Offline)AudioContext construction when not fully active r=padenot
Karl Tomlinson <karlt+@karlt.net> - Tue, 15 Sep 2020 22:13:22 +0000 - rev 548855
Push 37787 by malexandru@mozilla.com at Wed, 16 Sep 2020 09:56:56 +0000
Bug 1646601 throw InvalidStateError on (Offline)AudioContext construction when not fully active r=padenot https://github.com/WebAudio/web-audio-api/pull/1425/files#diff-eacf331f0ffc35d4b482f1d15a887d3bR2245 Differential Revision: https://phabricator.services.mozilla.com/D84302