Bug 1766307 - Add H264 include / namespace specifier for PlanarYCbCrImage to fix try build errors r=media-playback-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D148574

Bug 1766310 - Return HW decode support from WMFMediaDataDecoder r=media-playback-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D147390

Bug 1779097 - Fix issues in midir that would be rejected by recent compilers r=padenot Differential Revision: https://phabricator.services.mozilla.com/D152507

Bug 1766307 - Add H264 include / namespace specifier for PlanarYCbCrImage to fix try build errors r=media-playback-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D148574

Bug 1766310 - Return HW decode support from WMFMediaDataDecoder r=media-playback-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D147390

Bug 1773752: Remove more workarounds for old macOS SDKs. r=mstange,media-playback-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D151532

Bug 1766307 - Add H264 include / namespace specifier for PlanarYCbCrImage to fix try build errors r=media-playback-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D148574

Bug 1766310 - Return HW decode support from WMFMediaDataDecoder r=media-playback-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D147390

Bug 1777656: Delete mozilla::ipc::SharedMemory::SharedMemorytype. r=nika,media-playback-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D150852

Bug 1777499 - set several color_quads tests as passing with macOS on AArch64. r=padenot Since bug 1776429 ffvpx is used for decoding. Differential Revision: https://phabricator.services.mozilla.com/D150978

Bug 1773797 - Replace do_CreateInstance for nsICryptoHash with NS_NewCryptoHash r=Gijs,media-playback-reviewers,padenot,nika,ckerschb Differential Revision: https://phabricator.services.mozilla.com/D148968

Bug 1770905 - Allow GeckoMediaPlugin processes on Linux to be profiled if memfd_create is available. r=gcp,mstange,media-playback-reviewers,padenot There are two parts to this patch; both affect only Linux: 1. The GMP sandbox policy is adjusted to allow certain syscalls used in shared memory creation (ftruncate and fallocate). However, the file broker is not used; the process still has no access to files in /dev/shm. 2. The profiler is not initialized for GMP processes unless memfd_create is available (so the process can create shared memory to send profiling data back, without filesystem access), or the GMP sandbox is disabled (either at runtime or build time). As of this patch, profiling GMP processes on Linux should succeed on distros with kernel >=3.17 (Oct. 2014), but native stack frames won't have symbols (and may be incorrectly unwound, not that it matters much without symbols); see the bug for more info. Pseudo-stack frames and markers should work, however. Differential Revision: https://phabricator.services.mozilla.com/D148470

Bug 1767899 - add `explicit` on EventTargetCapability ctor to fix build error. r=media-playback-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D148846

Bug 1773577 - enable the pref 'media.autoplay.block-webaudio'. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D148849

Bug 1773353: Prevent ResourceQueue::EvictAll and ::EvictBefore from attempting to retrieve elements of an empty queue. r=media-playback-reviewers,padenot These early exits prevent calls to `ResourceAt(0)` on an empty queue. Such a call emits an NS_WARN message. Both calls can either start with an empty queue or loop until they empty the queue. Since these functions are called frequently, the NS_WARN messages can fill up the console. Differential Revision: https://phabricator.services.mozilla.com/D148678

Bug 1519636 - Reformat recent changes to the Google coding style r=andi,media-playback-reviewers,necko-reviewers,padenot,dragana # ignore-this-changeset Differential Revision: https://phabricator.services.mozilla.com/D148375

Bug 1771069 wait for context.state == running so AudioContext will capture start of Audio element playback r=padenot https://webaudio.github.io/web-audio-api/#MediaElementAudioSourceNode > The HTMLMediaElement MUST behave in an identical fashion after the > MediaElementAudioSourceNode has been created, except that the rendered audio > will no longer be heard directly, but instead will be heard as a consequence > of the MediaElementAudioSourceNode being connected through the routing > graph. Thus pausing, seeking, volume, src attribute changes, and other > aspects of the HTMLMediaElement MUST behave as they normally would if not > used with a MediaElementAudioSourceNode. https://webaudio.github.io/web-audio-api/#dom-audiocontext-audiocontext > Sending a control message to start processing means executing the following > steps: > 1. Attempt to acquire system resources. In case of failure, abort the > following steps. > 2. Set the [[rendering thread state]] to running on the AudioContext. Differential Revision: https://phabricator.services.mozilla.com/D148097

Bug 1764186 - Make ConnectTo(Non)NativeDevice main-thread only r=padenot After making `MediaInputPort::Get{Source, Destination}` graph-thread only, we can no longer use them in `ConnectToNativeDevice` and `ConnectToNonNativeDevice` since their caller run these two functions in the main thread in our tests. It's better to re-implement `ConnectToNativeDevice` and `ConnectToNonNativeDevice` as main-thread APIs now. Depends on D143780 Differential Revision: https://phabricator.services.mozilla.com/D147790

Bug 1764186 - Make sure MediaInputPort::Get{Source, Destination} are graph-thread only r=bwc,padenot `MediaInputPort::Get{Source, Destination}` should be graph-thread only since the `MediaInputPort`'s `mSource` and `mDest` will be cleaned up on the graph thread [1], in case of causing some potential racing issues. [1] https://searchfox.org/mozilla-central/rev/10edce3685369a4c73955cc8d5fcbc5a9d7598af/dom/media/MediaTrackGraph.cpp#2944-2945 Differential Revision: https://phabricator.services.mozilla.com/D143780

Bug 1770894 - Upgrade coreaudio-sys to 0.2.10. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D147222

Bug 1764186 - Make sure MediaInputPort::Get{Source, Destination} are graph-thread only r=bwc,padenot `MediaInputPort::Get{Source, Destination}` should be graph-thread only since the `MediaInputPort`'s `mSource` and `mDest` will be cleaned up on the graph thread [1], in case of causing some potential racing issues. [1] https://searchfox.org/mozilla-central/rev/10edce3685369a4c73955cc8d5fcbc5a9d7598af/dom/media/MediaTrackGraph.cpp#2944-2945 Differential Revision: https://phabricator.services.mozilla.com/D143780

Bug 1769009 - Refresh the list of MIDI devices both when navigating to a new page and away from an old one r=padenot Differential Revision: https://phabricator.services.mozilla.com/D146564

Bug 1769033 - Dont use major version for libavcodec on OpenBSD r=gaston,media-playback-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D146444

Bug 1766469 - Handle empty data fields when creating MIDIMessageEvent objects r=padenot This change matches Chrome's behavior of not throwing in cases when the data field is null. However contrary to Chrome we populate the object with an empty array instead of a null reference. Differential Revision: https://phabricator.services.mozilla.com/D146672

Bug 1769009 - Refresh the list of MIDI devices both when navigating to a new page and away from an old one r=padenot Differential Revision: https://phabricator.services.mozilla.com/D146564

Bug 1766469 - Handle empty data fields when creating MIDIMessageEvent objects r=padenot This change matches Chrome's behavior of not throwing in cases when the data field is null. However contrary to Chrome we populate the object with an empty array instead of a null reference. Differential Revision: https://phabricator.services.mozilla.com/D146672

Bug 1766469 - Handle empty data fields when creating MIDIMessageEvent objects r=padenot This change matches Chrome's behavior of not throwing in cases when the data field is null. However contrary to Chrome we populate the object with an empty array instead of a null reference. Differential Revision: https://phabricator.services.mozilla.com/D146672

Bug 1765230 - Rename test name and correct comments r=padenot Differential Revision: https://phabricator.services.mozilla.com/D146476

Bug 1765230 - Wait for error stop before `StopAudio()` r=padenot `TestDeviceInputTrack.ErrorCallback` has the same racing issue as the bug 1765312's one (See D144637). We should wait for the cubeb-stream-stop called by the forced-error's background thread before calling `NonNativeInputTrack::StopAudio()` to avoid getting the stopped state callback before the error callback. Differential Revision: https://phabricator.services.mozilla.com/D146475

Bug 1769484 - Replace std::memory_order::memory_order_XYZ with std::memory_order_XYZ. r=padenot C++20 renamed the `std::memory_order` enum's enumerators from `std::memory_order::memory_order_XYZ` to `std::memory_order::XYZ`. To maintain source compatibility with both C++17 and C++20, use `std::memory_order_XYZ`. https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2016/p0439r0.html https://en.cppreference.com/w/cpp/atomic/memory_order Differential Revision: https://phabricator.services.mozilla.com/D146395

Bug 1768999 - Replace unqualified use of std::move in ChromiumCDMAdapter.cpp. r=media-playback-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D146153

Bug 1768047 - introduce HMAC C++ helper and remove nsICryptoHMAC r=jschanck,necko-reviewers,kershaw,padenot This patch removes the redundant nsICryptoHMAC interface and implementation, updates front-end code to use WebCrypto, and changes back-end code to use the helper class HMAC introduced by this patch. This also removes the last uses of nsIKeyObject and nsIKeyObjectFactory, and thus those interfaces and implementations as well. Differential Revision: https://phabricator.services.mozilla.com/D145656

Bug 1763281 allow one byte 206 Partial Content responses r=media-playback-reviewers,padenot These were disallowed on initial implementation. https://hg.mozilla.org/mozilla-central/rev/6df63191884b8631984d92bef4b937ab084042cd#l1.166 https://httpwg.org/specs/rfc7233.html#header.content-range "A Content-Range field value is invalid if it contains a byte-range-resp that has a last-byte-pos value less than its first-byte-pos value". The aRangeEnd < aRangeTotal test correctly understands that aRangeEnd is an inclusive index. [range responses from multiple origins (cross-origin first)] fails because Firefox reuses the media resource loaded in [range responses from single origin (same-origin)] for subsequent resources with the same URL, without any re-fetch (bug 1129121). Depends on D143119 Differential Revision: https://phabricator.services.mozilla.com/D143120

Bug 1763281 mute test video so that autoplay is allowed r=padenot This is not so important when running tests with special prefs set, but is useful to run the tests from a standard browser instance. Depends on D143120 Differential Revision: https://phabricator.services.mozilla.com/D143677

Bug 1763281 serve movie_5.ogv with Content-Type:video/ogg r=media-playback-reviewers,padenot Firefox uses only the first of Partial Content responses to sniff the type, but falls back to the Content-Type because the initial response is so short. https://bugzilla.mozilla.org/show_bug.cgi?id=1763277 Firefox behavior weakly arguably conforms with the permitted abort of "read the resource header" when "a reasonable amount of time has elapsed, as determined by the user agent", https://mimesniff.spec.whatwg.org/#read-the-resource-header but the purpose of the tests is not to test sniffing, https://github.com/web-platform-tests/wpt/commit/67593065a83156851279d1751fc865131e8dbff9#diff-4cc71e3c53ed088f2f437b1c43d9bec445827f10a4f6dce0615eb0f4e7823e3dR37 so let's keep the results independent of this edge case. Differential Revision: https://phabricator.services.mozilla.com/D143119

Bug 1766561 - Fix various formatting errors. r=media-playback-reviewers,gfx-reviewers,nika,necko-reviewers,rkraesig,alwu,padenot,kershaw - Missing/Extra formatting directives - Typos in formatting directives - Non-literal strings used as formatting strings - Wrong types passed as argument - Swapped/Wrong arguments - Commas between parts of unique formatting strings Differential Revision: https://phabricator.services.mozilla.com/D144921

Bug 1765312 - Wait for error stop before AudioInputSource::Stop() r=padenot We need to wait for the stream stop called by the forced error before calling `AudioInputSource::Stop` to ensure the callback order in the test. Otherwise, the stream stop called by the forced error on the background thread will race with the stream stop called by the `AudioInputSource::Stop` in its task thread. The problem of the intermittently unexpected callbacks can be reproduced by adding a delay/thread-sleep in the forced-error's background thread task. When MockCubeb runs into the error state by `ForceError()`, it will create a background-thread task to stop the cubeb stream. On the other hand, when `AuidioInputSource::Stop` is called, it will create a task to stop the cubeb stream first and then destroy the cubeb stream, on its own task thread. Most of time, when `AudioInputSource::Stop` is called, the underlying cubeb stream has been stopped by the brackground task, so the `MockCubebStream` won't fire the stopped-state callback. `MockCubeb::StopStream` in `MockCubebStream::Stop()` called by `AudioInputSource::Stop()` will return a `CUBEB_ERROR` in this case since no stream needs to be stopped, and so no callback need to be fired. However, in rare cases, the stream stop on the AudioInputSource's task thread finishes before the one in the background thread. Hence, the `MockCubebStream::Stop()` called by `AudioInputSource::Stop()` can stop the stream successfully and then fire a stopped state callback. We don't care what thread stop the stream in `TestAudioInputSource.ErrorCallback` test, as long as the error-state cabllback can be forwarded correctly and the stream can be destroyed in the end. To avoid the racy stream stop calls between the background thread and the task thread, we don't call `AudioInputSource::Stop()` until stream is stopped in background thread. Differential Revision: https://phabricator.services.mozilla.com/D144637

Bug 1765474 - Fix unused-but-set-variable warning in OggDemuxer.cpp. r=media-playback-reviewers,padenot dom/media/ogg/OggDemuxer.cpp:1905:7: error: variable 'hops' set but not used [-Werror,-Wunused-but-set-variable] int hops = 0; ^ Differential Revision: https://phabricator.services.mozilla.com/D144147

Bug 1765627 - Make sure {Disc, C}onnectDeviceInput are correctly called r=padenot Add some assertions to make sure the ConnectDeviceInput and DisconnectDeviceInput are called at the right time. Differential Revision: https://phabricator.services.mozilla.com/D144218

Bug 1761691 - Fix audio_thread_priority build when dbus is build disabled. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D144077

Bug 1238038 - Mochitest for opening multi mics r=padenot Add a test to verify we can open multiple microphones Depends on D139445 Differential Revision: https://phabricator.services.mozilla.com/D143102

Bug 1238038 - Remove mInputDeviceID in MediaTrackGraph r=padenot The mInputDeviceID can be removed now since we can get the input-device id via the DeviceInputTrackManager on the graph-thread side now. Depends on D139444 Differential Revision: https://phabricator.services.mozilla.com/D139445

Bug 1238038 - Manage MediaTrack for devices in one class r=padenot This patch creates a class to manage all DeviceInputTracks in one place, which simplify the code in the MediaTrackGraph. Depends on D138726 Differential Revision: https://phabricator.services.mozilla.com/D139444

Bug 1238038 - Allow opening multiple devices r=padenot This patch allows website users to open multiple microphones in the same MediaTrackGraph. Depends on D138189 Differential Revision: https://phabricator.services.mozilla.com/D138726

Bug 1238038 - Start non-native audio in NonNativeInputTrack r=padenot This patch implements all the functionalities allowing us to use a AudioInputSource to generate audio in NonNativeInputTrack. Depends on D137911 Differential Revision: https://phabricator.services.mozilla.com/D138189

Bug 1238038 - Create an input-only audio source r=padenot This patch creates an class managing an input-only audio stream within a task thread. This class will be used as a source generating the audio data to a NonNativeInputTrack in the following patch. Depends on D116535 Differential Revision: https://phabricator.services.mozilla.com/D137911

Bug 1238038 - Create a cubeb input stream wrapper r=padenot,pehrsons To add a non-native input source in the MediaTrackGraph, we need a input-only cubeb stream. This patch implements a light-weight wrapper to operate the C style Cubeb APIs in a C++-friendly way. Depends on D143101 Differential Revision: https://phabricator.services.mozilla.com/D116535

Bug 1238038 - Notify state changed in MockCubeb r=padenot Add a waitable event that will be fired when the state is changed, so the user can wait for certain state of the cubeb stream. Depends on D143100 Differential Revision: https://phabricator.services.mozilla.com/D143101

Bug 1238038 - Relax channel limit in FromInterleavedBuffer r=padenot Depends on D137910 Differential Revision: https://phabricator.services.mozilla.com/D143100

Bug 1238038 - Create AudioChunk from interleaved buffer r=padenot This patch adds a method to create an AudioChunk from an interleaved buffer. Depends on D130233 Differential Revision: https://phabricator.services.mozilla.com/D137910