searching for reviewer(padenot)
6f5d35b414562c7dc3c411bac73f534924b71d19: Bug 1766307 - Add H264 include / namespace specifier for PlanarYCbCrImage to fix try build errors r=media-playback-reviewers,padenot
az <azebrowski@mozilla.com> - Fri, 22 Jul 2022 23:08:10 +0000 - rev 624971
Push 40021 by smolnar@mozilla.com at Sat, 23 Jul 2022 09:14:44 +0000
Bug 1766307 - Add H264 include / namespace specifier for PlanarYCbCrImage to fix try build errors r=media-playback-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D148574
cecda7810781b44f7e71658f8938a2af261c71ed: Bug 1766310 - Return HW decode support from WMFMediaDataDecoder r=media-playback-reviewers,padenot
az <azebrowski@mozilla.com> - Fri, 22 Jul 2022 23:08:10 +0000 - rev 624970
Push 40021 by smolnar@mozilla.com at Sat, 23 Jul 2022 09:14:44 +0000
Bug 1766310 - Return HW decode support from WMFMediaDataDecoder r=media-playback-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D147390
14fa0be716d8d74863e3cedd18159b2ad48ccaa4: Bug 1779097 - Fix issues in midir that would be rejected by recent compilers r=padenot
Gabriele Svelto <gsvelto@mozilla.com> - Fri, 22 Jul 2022 21:29:30 +0000 - rev 624959
Push 40021 by smolnar@mozilla.com at Sat, 23 Jul 2022 09:14:44 +0000
Bug 1779097 - Fix issues in midir that would be rejected by recent compilers r=padenot Differential Revision: https://phabricator.services.mozilla.com/D152507
19800bb8974ec639e4a0b4e0afe0bb3ac0eace69: Bug 1766307 - Add H264 include / namespace specifier for PlanarYCbCrImage to fix try build errors r=media-playback-reviewers,padenot
az <azebrowski@mozilla.com> - Tue, 19 Jul 2022 23:27:43 +0000 - rev 624439
Push 40005 by ncsoregi@mozilla.com at Wed, 20 Jul 2022 09:59:35 +0000
Bug 1766307 - Add H264 include / namespace specifier for PlanarYCbCrImage to fix try build errors r=media-playback-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D148574
40ec827944975c2d40987550db6c19bb3dde80c1: Bug 1766310 - Return HW decode support from WMFMediaDataDecoder r=media-playback-reviewers,padenot
az <azebrowski@mozilla.com> - Tue, 19 Jul 2022 23:27:43 +0000 - rev 624438
Push 40005 by ncsoregi@mozilla.com at Wed, 20 Jul 2022 09:59:35 +0000
Bug 1766310 - Return HW decode support from WMFMediaDataDecoder r=media-playback-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D147390
76918c8b1adc20a4a970674d1c7e01c38c2eb5c6: Bug 1773752: Remove more workarounds for old macOS SDKs. r=mstange,media-playback-reviewers,padenot
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Mon, 18 Jul 2022 17:08:59 +0000 - rev 624291
Push 40001 by abutkovits@mozilla.com at Tue, 19 Jul 2022 09:34:24 +0000
Bug 1773752: Remove more workarounds for old macOS SDKs. r=mstange,media-playback-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D151532
5fb04c68ae7a333e3ac7a1cc73115d6847239793: Bug 1766307 - Add H264 include / namespace specifier for PlanarYCbCrImage to fix try build errors r=media-playback-reviewers,padenot
az <azebrowski@mozilla.com> - Thu, 14 Jul 2022 00:32:39 +0000 - rev 623890
Push 39980 by nfay@mozilla.com at Thu, 14 Jul 2022 03:48:49 +0000
Bug 1766307 - Add H264 include / namespace specifier for PlanarYCbCrImage to fix try build errors r=media-playback-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D148574
ee76505a46ffc11cde6add34677d08a8b12448a6: Bug 1766310 - Return HW decode support from WMFMediaDataDecoder r=media-playback-reviewers,padenot
az <azebrowski@mozilla.com> - Thu, 14 Jul 2022 00:32:39 +0000 - rev 623889
Push 39980 by nfay@mozilla.com at Thu, 14 Jul 2022 03:48:49 +0000
Bug 1766310 - Return HW decode support from WMFMediaDataDecoder r=media-playback-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D147390
50b54e22d6035b40467167e09ca9837650b7f552: Bug 1777656: Delete mozilla::ipc::SharedMemory::SharedMemorytype. r=nika,media-playback-reviewers,padenot
Jim Blandy <jimb@red-bean.com> - Tue, 05 Jul 2022 20:08:31 +0000 - rev 623073
Push 39942 by bszekely@mozilla.com at Wed, 06 Jul 2022 09:40:22 +0000
Bug 1777656: Delete mozilla::ipc::SharedMemory::SharedMemorytype. r=nika,media-playback-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D150852
e7d8d0ab92f2e8896399c06cd855ed6adbeeb1b8: Bug 1777499 - set several color_quads tests as passing with macOS on AArch64. r=padenot
Sebastian Hengst <archaeopteryx@coole-files.de> - Tue, 05 Jul 2022 08:01:09 +0000 - rev 622974
Push 39938 by imoraru@mozilla.com at Tue, 05 Jul 2022 15:54:46 +0000
Bug 1777499 - set several color_quads tests as passing with macOS on AArch64. r=padenot Since bug 1776429 ffvpx is used for decoding. Differential Revision: https://phabricator.services.mozilla.com/D150978
e6471acf5208f3184d8efd08a3de127eab7dcbe1: Bug 1773797 - Replace do_CreateInstance for nsICryptoHash with NS_NewCryptoHash r=Gijs,media-playback-reviewers,padenot,nika,ckerschb
Barret Rennie <barret@brennie.ca> - Mon, 20 Jun 2022 13:57:29 +0000 - rev 621435
Push 39874 by csabou@mozilla.com at Mon, 20 Jun 2022 21:49:56 +0000
Bug 1773797 - Replace do_CreateInstance for nsICryptoHash with NS_NewCryptoHash r=Gijs,media-playback-reviewers,padenot,nika,ckerschb Differential Revision: https://phabricator.services.mozilla.com/D148968
9a4be9c8c0c631596e5a7aa96612a0b4b842c668: Bug 1770905 - Allow GeckoMediaPlugin processes on Linux to be profiled if memfd_create is available. r=gcp,mstange,media-playback-reviewers,padenot
Jed Davis <jld@mozilla.com> - Wed, 15 Jun 2022 20:55:24 +0000 - rev 621026
Push 39858 by bszekely@mozilla.com at Thu, 16 Jun 2022 09:30:51 +0000
Bug 1770905 - Allow GeckoMediaPlugin processes on Linux to be profiled if memfd_create is available. r=gcp,mstange,media-playback-reviewers,padenot There are two parts to this patch; both affect only Linux: 1. The GMP sandbox policy is adjusted to allow certain syscalls used in shared memory creation (ftruncate and fallocate). However, the file broker is not used; the process still has no access to files in /dev/shm. 2. The profiler is not initialized for GMP processes unless memfd_create is available (so the process can create shared memory to send profiling data back, without filesystem access), or the GMP sandbox is disabled (either at runtime or build time). As of this patch, profiling GMP processes on Linux should succeed on distros with kernel >=3.17 (Oct. 2014), but native stack frames won't have symbols (and may be incorrectly unwound, not that it matters much without symbols); see the bug for more info. Pseudo-stack frames and markers should work, however. Differential Revision: https://phabricator.services.mozilla.com/D148470
ee981764696b6aba52410f750e2b54eae1f51884: Bug 1767899 - add `explicit` on EventTargetCapability ctor to fix build error. r=media-playback-reviewers,padenot
alwu <alwu@mozilla.com> - Fri, 10 Jun 2022 18:08:12 +0000 - rev 620538
Push 39831 by nbeleuzu@mozilla.com at Sat, 11 Jun 2022 09:51:55 +0000
Bug 1767899 - add `explicit` on EventTargetCapability ctor to fix build error. r=media-playback-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D148846
afb7205c7b9fb16bf5767ca412e69c6b6abbdbdd: Bug 1773577 - enable the pref 'media.autoplay.block-webaudio'. r=padenot
alwu <alwu@mozilla.com> - Fri, 10 Jun 2022 18:07:50 +0000 - rev 620536
Push 39831 by nbeleuzu@mozilla.com at Sat, 11 Jun 2022 09:51:55 +0000
Bug 1773577 - enable the pref 'media.autoplay.block-webaudio'. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D148849
c2501a5ed77c4b3a790af7120942c35e30a57edc: Bug 1773353: Prevent ResourceQueue::EvictAll and ::EvictBefore from attempting to retrieve elements of an empty queue. r=media-playback-reviewers,padenot
Brad Werth <bwerth@mozilla.com> - Thu, 09 Jun 2022 17:28:12 +0000 - rev 620332
Push 39824 by smolnar@mozilla.com at Thu, 09 Jun 2022 22:00:48 +0000
Bug 1773353: Prevent ResourceQueue::EvictAll and ::EvictBefore from attempting to retrieve elements of an empty queue. r=media-playback-reviewers,padenot These early exits prevent calls to `ResourceAt(0)` on an empty queue. Such a call emits an NS_WARN message. Both calls can either start with an empty queue or loop until they empty the queue. Since these functions are called frequently, the NS_WARN messages can fill up the console. Differential Revision: https://phabricator.services.mozilla.com/D148678
f5c3a162f850d3485f8cce57e2d930f93a64d43e: Bug 1519636 - Reformat recent changes to the Google coding style r=andi,media-playback-reviewers,necko-reviewers,padenot,dragana
Sylvestre Ledru <sledru@mozilla.com> - Tue, 07 Jun 2022 12:32:55 +0000 - rev 619950
Push 39812 by imoraru@mozilla.com at Tue, 07 Jun 2022 21:47:25 +0000
Bug 1519636 - Reformat recent changes to the Google coding style r=andi,media-playback-reviewers,necko-reviewers,padenot,dragana # ignore-this-changeset Differential Revision: https://phabricator.services.mozilla.com/D148375
7f91228378fefc3d1ee86d287a3033653846b40a: Bug 1771069 wait for context.state == running so AudioContext will capture start of Audio element playback r=padenot
Karl Tomlinson <karlt+@karlt.net> - Thu, 02 Jun 2022 21:19:40 +0000 - rev 619611
Push 39788 by nfay@mozilla.com at Fri, 03 Jun 2022 03:41:38 +0000
Bug 1771069 wait for context.state == running so AudioContext will capture start of Audio element playback r=padenot https://webaudio.github.io/web-audio-api/#MediaElementAudioSourceNode > The HTMLMediaElement MUST behave in an identical fashion after the > MediaElementAudioSourceNode has been created, except that the rendered audio > will no longer be heard directly, but instead will be heard as a consequence > of the MediaElementAudioSourceNode being connected through the routing > graph. Thus pausing, seeking, volume, src attribute changes, and other > aspects of the HTMLMediaElement MUST behave as they normally would if not > used with a MediaElementAudioSourceNode. https://webaudio.github.io/web-audio-api/#dom-audiocontext-audiocontext > Sending a control message to start processing means executing the following > steps: > 1. Attempt to acquire system resources. In case of failure, abort the > following steps. > 2. Set the [[rendering thread state]] to running on the AudioContext. Differential Revision: https://phabricator.services.mozilla.com/D148097
657f2e3cd5ee61947d3da69981b7e866d609fb6b: Bug 1764186 - Make ConnectTo(Non)NativeDevice main-thread only r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Wed, 01 Jun 2022 16:52:07 +0000 - rev 619439
Push 39783 by apavel@mozilla.com at Wed, 01 Jun 2022 21:31:38 +0000
Bug 1764186 - Make ConnectTo(Non)NativeDevice main-thread only r=padenot After making `MediaInputPort::Get{Source, Destination}` graph-thread only, we can no longer use them in `ConnectToNativeDevice` and `ConnectToNonNativeDevice` since their caller run these two functions in the main thread in our tests. It's better to re-implement `ConnectToNativeDevice` and `ConnectToNonNativeDevice` as main-thread APIs now. Depends on D143780 Differential Revision: https://phabricator.services.mozilla.com/D147790
7ed0cb45fa752b448b74afcea1986fedc2055cd9: Bug 1764186 - Make sure MediaInputPort::Get{Source, Destination} are graph-thread only r=bwc,padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Wed, 01 Jun 2022 16:52:07 +0000 - rev 619438
Push 39783 by apavel@mozilla.com at Wed, 01 Jun 2022 21:31:38 +0000
Bug 1764186 - Make sure MediaInputPort::Get{Source, Destination} are graph-thread only r=bwc,padenot `MediaInputPort::Get{Source, Destination}` should be graph-thread only since the `MediaInputPort`'s `mSource` and `mDest` will be cleaned up on the graph thread [1], in case of causing some potential racing issues. [1] https://searchfox.org/mozilla-central/rev/10edce3685369a4c73955cc8d5fcbc5a9d7598af/dom/media/MediaTrackGraph.cpp#2944-2945 Differential Revision: https://phabricator.services.mozilla.com/D143780
130b56f5be8f81c0456d83417f1cad07fa9fe1ff: Bug 1770894 - Upgrade coreaudio-sys to 0.2.10. r=padenot
Mike Hommey <mh+mozilla@glandium.org> - Mon, 30 May 2022 21:37:32 +0000 - rev 619232
Push 39775 by imoraru@mozilla.com at Tue, 31 May 2022 15:29:54 +0000
Bug 1770894 - Upgrade coreaudio-sys to 0.2.10. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D147222
8ff752dc79b27b5c0fd565d508fde3fa3bef45ef: Bug 1764186 - Make sure MediaInputPort::Get{Source, Destination} are graph-thread only r=bwc,padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Thu, 26 May 2022 23:17:49 +0000 - rev 619024
Push 39756 by nfay@mozilla.com at Fri, 27 May 2022 09:26:03 +0000
Bug 1764186 - Make sure MediaInputPort::Get{Source, Destination} are graph-thread only r=bwc,padenot `MediaInputPort::Get{Source, Destination}` should be graph-thread only since the `MediaInputPort`'s `mSource` and `mDest` will be cleaned up on the graph thread [1], in case of causing some potential racing issues. [1] https://searchfox.org/mozilla-central/rev/10edce3685369a4c73955cc8d5fcbc5a9d7598af/dom/media/MediaTrackGraph.cpp#2944-2945 Differential Revision: https://phabricator.services.mozilla.com/D143780
f282648916d5478a189449e1402d56f9adafe58c: Bug 1769009 - Refresh the list of MIDI devices both when navigating to a new page and away from an old one r=padenot
Gabriele Svelto <gsvelto@mozilla.com> - Mon, 23 May 2022 19:59:57 +0000 - rev 618559
Push 39737 by imoraru@mozilla.com at Tue, 24 May 2022 03:33:01 +0000
Bug 1769009 - Refresh the list of MIDI devices both when navigating to a new page and away from an old one r=padenot Differential Revision: https://phabricator.services.mozilla.com/D146564
fd2fdaf884e2c805b20216d0fafb8d8a63be0ad3: Bug 1769033 - Dont use major version for libavcodec on OpenBSD r=gaston,media-playback-reviewers,padenot
Alexandre Lissy <lissyx+mozillians@lissyx.dyndns.org> - Fri, 20 May 2022 08:25:03 +0000 - rev 618339
Push 39723 by abutkovits@mozilla.com at Fri, 20 May 2022 15:37:03 +0000
Bug 1769033 - Dont use major version for libavcodec on OpenBSD r=gaston,media-playback-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D146444
b602dc09f1de0665d1bb646347ef4bfc2310b465: Bug 1766469 - Handle empty data fields when creating MIDIMessageEvent objects r=padenot
Gabriele Svelto <gsvelto@mozilla.com> - Fri, 20 May 2022 05:58:03 +0000 - rev 618325
Push 39723 by abutkovits@mozilla.com at Fri, 20 May 2022 15:37:03 +0000
Bug 1766469 - Handle empty data fields when creating MIDIMessageEvent objects r=padenot This change matches Chrome's behavior of not throwing in cases when the data field is null. However contrary to Chrome we populate the object with an empty array instead of a null reference. Differential Revision: https://phabricator.services.mozilla.com/D146672
69f265c469f654fa351cba1bd2072d6568761cb3: Bug 1769009 - Refresh the list of MIDI devices both when navigating to a new page and away from an old one r=padenot
Gabriele Svelto <gsvelto@mozilla.com> - Thu, 19 May 2022 20:56:52 +0000 - rev 618282
Push 39722 by nfay@mozilla.com at Fri, 20 May 2022 09:31:26 +0000
Bug 1769009 - Refresh the list of MIDI devices both when navigating to a new page and away from an old one r=padenot Differential Revision: https://phabricator.services.mozilla.com/D146564
aaaed875acb35024eb955fca92ba50ae244be85c: Bug 1766469 - Handle empty data fields when creating MIDIMessageEvent objects r=padenot
Gabriele Svelto <gsvelto@mozilla.com> - Thu, 19 May 2022 11:41:58 +0000 - rev 618224
Push 39719 by smolnar@mozilla.com at Thu, 19 May 2022 16:03:14 +0000
Bug 1766469 - Handle empty data fields when creating MIDIMessageEvent objects r=padenot This change matches Chrome's behavior of not throwing in cases when the data field is null. However contrary to Chrome we populate the object with an empty array instead of a null reference. Differential Revision: https://phabricator.services.mozilla.com/D146672
52649d6014b8cf4227d336ba4495b1219e4f857a: Bug 1766469 - Handle empty data fields when creating MIDIMessageEvent objects r=padenot
Gabriele Svelto <gsvelto@mozilla.com> - Thu, 19 May 2022 09:38:17 +0000 - rev 618220
Push 39719 by smolnar@mozilla.com at Thu, 19 May 2022 16:03:14 +0000
Bug 1766469 - Handle empty data fields when creating MIDIMessageEvent objects r=padenot This change matches Chrome's behavior of not throwing in cases when the data field is null. However contrary to Chrome we populate the object with an empty array instead of a null reference. Differential Revision: https://phabricator.services.mozilla.com/D146672
8e5847d574bf32904fce3b73b55e521d89969acd: Bug 1765230 - Rename test name and correct comments r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Tue, 17 May 2022 23:08:04 +0000 - rev 618051
Push 39712 by abutkovits@mozilla.com at Wed, 18 May 2022 03:14:37 +0000
Bug 1765230 - Rename test name and correct comments r=padenot Differential Revision: https://phabricator.services.mozilla.com/D146476
491c635cc3be3b15da5bb04b414075de50c17c40: Bug 1765230 - Wait for error stop before `StopAudio()` r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Tue, 17 May 2022 23:08:04 +0000 - rev 618050
Push 39712 by abutkovits@mozilla.com at Wed, 18 May 2022 03:14:37 +0000
Bug 1765230 - Wait for error stop before `StopAudio()` r=padenot `TestDeviceInputTrack.ErrorCallback` has the same racing issue as the bug 1765312's one (See D144637). We should wait for the cubeb-stream-stop called by the forced-error's background thread before calling `NonNativeInputTrack::StopAudio()` to avoid getting the stopped state callback before the error callback. Differential Revision: https://phabricator.services.mozilla.com/D146475
ae3b557d999973ce7d8a6ddf5d334dc075da6be4: Bug 1769484 - Replace std::memory_order::memory_order_XYZ with std::memory_order_XYZ. r=padenot
Chris Peterson <cpeterson@mozilla.com> - Tue, 17 May 2022 03:24:09 +0000 - rev 617828
Push 39708 by bszekely@mozilla.com at Tue, 17 May 2022 09:27:45 +0000
Bug 1769484 - Replace std::memory_order::memory_order_XYZ with std::memory_order_XYZ. r=padenot C++20 renamed the `std::memory_order` enum's enumerators from `std::memory_order::memory_order_XYZ` to `std::memory_order::XYZ`. To maintain source compatibility with both C++17 and C++20, use `std::memory_order_XYZ`. https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2016/p0439r0.html https://en.cppreference.com/w/cpp/atomic/memory_order Differential Revision: https://phabricator.services.mozilla.com/D146395
bbb75aa6c4f2525fcf4e5d26218e9dc413ec12c1: Bug 1768999 - Replace unqualified use of std::move in ChromiumCDMAdapter.cpp. r=media-playback-reviewers,padenot
Mike Hommey <mh+mozilla@glandium.org> - Fri, 13 May 2022 00:45:24 +0000 - rev 617145
Push 39689 by bszekely@mozilla.com at Fri, 13 May 2022 09:35:38 +0000
Bug 1768999 - Replace unqualified use of std::move in ChromiumCDMAdapter.cpp. r=media-playback-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D146153
0d45c671d9e341d0f07bd5ab3f1edec1d2752a1c: Bug 1768047 - introduce HMAC C++ helper and remove nsICryptoHMAC r=jschanck,necko-reviewers,kershaw,padenot
Dana Keeler <dkeeler@mozilla.com> - Thu, 12 May 2022 22:24:29 +0000 - rev 617134
Push 39689 by bszekely@mozilla.com at Fri, 13 May 2022 09:35:38 +0000
Bug 1768047 - introduce HMAC C++ helper and remove nsICryptoHMAC r=jschanck,necko-reviewers,kershaw,padenot This patch removes the redundant nsICryptoHMAC interface and implementation, updates front-end code to use WebCrypto, and changes back-end code to use the helper class HMAC introduced by this patch. This also removes the last uses of nsIKeyObject and nsIKeyObjectFactory, and thus those interfaces and implementations as well. Differential Revision: https://phabricator.services.mozilla.com/D145656
db225af058979a560d8a418c5a5fda4b2a9d844d: Bug 1763281 allow one byte 206 Partial Content responses r=media-playback-reviewers,padenot
Karl Tomlinson <karlt+@karlt.net> - Tue, 03 May 2022 23:52:11 +0000 - rev 616066
Push 39647 by nfay@mozilla.com at Wed, 04 May 2022 09:37:59 +0000
Bug 1763281 allow one byte 206 Partial Content responses r=media-playback-reviewers,padenot These were disallowed on initial implementation. https://hg.mozilla.org/mozilla-central/rev/6df63191884b8631984d92bef4b937ab084042cd#l1.166 https://httpwg.org/specs/rfc7233.html#header.content-range "A Content-Range field value is invalid if it contains a byte-range-resp that has a last-byte-pos value less than its first-byte-pos value". The aRangeEnd < aRangeTotal test correctly understands that aRangeEnd is an inclusive index. [range responses from multiple origins (cross-origin first)] fails because Firefox reuses the media resource loaded in [range responses from single origin (same-origin)] for subsequent resources with the same URL, without any re-fetch (bug 1129121). Depends on D143119 Differential Revision: https://phabricator.services.mozilla.com/D143120
f36375cb4a022fee61f790bd4ce9ffedc90db34a: Bug 1763281 mute test video so that autoplay is allowed r=padenot
Karl Tomlinson <karlt+@karlt.net> - Tue, 03 May 2022 22:24:26 +0000 - rev 616037
Push 39645 by imoraru@mozilla.com at Wed, 04 May 2022 03:39:47 +0000
Bug 1763281 mute test video so that autoplay is allowed r=padenot This is not so important when running tests with special prefs set, but is useful to run the tests from a standard browser instance. Depends on D143120 Differential Revision: https://phabricator.services.mozilla.com/D143677
6a14acfccd63afe33856eaeaee34b6f152e54522: Bug 1763281 serve movie_5.ogv with Content-Type:video/ogg r=media-playback-reviewers,padenot
Karl Tomlinson <karlt+@karlt.net> - Tue, 03 May 2022 22:24:25 +0000 - rev 616036
Push 39645 by imoraru@mozilla.com at Wed, 04 May 2022 03:39:47 +0000
Bug 1763281 serve movie_5.ogv with Content-Type:video/ogg r=media-playback-reviewers,padenot Firefox uses only the first of Partial Content responses to sniff the type, but falls back to the Content-Type because the initial response is so short. https://bugzilla.mozilla.org/show_bug.cgi?id=1763277 Firefox behavior weakly arguably conforms with the permitted abort of "read the resource header" when "a reasonable amount of time has elapsed, as determined by the user agent", https://mimesniff.spec.whatwg.org/#read-the-resource-header but the purpose of the tests is not to test sniffing, https://github.com/web-platform-tests/wpt/commit/67593065a83156851279d1751fc865131e8dbff9#diff-4cc71e3c53ed088f2f437b1c43d9bec445827f10a4f6dce0615eb0f4e7823e3dR37 so let's keep the results independent of this edge case. Differential Revision: https://phabricator.services.mozilla.com/D143119
50248597686ab377aa77ccaeb77439846db742b6: Bug 1766561 - Fix various formatting errors. r=media-playback-reviewers,gfx-reviewers,nika,necko-reviewers,rkraesig,alwu,padenot,kershaw
Mike Hommey <mh+mozilla@glandium.org> - Tue, 03 May 2022 20:49:10 +0000 - rev 616028
Push 39645 by imoraru@mozilla.com at Wed, 04 May 2022 03:39:47 +0000
Bug 1766561 - Fix various formatting errors. r=media-playback-reviewers,gfx-reviewers,nika,necko-reviewers,rkraesig,alwu,padenot,kershaw - Missing/Extra formatting directives - Typos in formatting directives - Non-literal strings used as formatting strings - Wrong types passed as argument - Swapped/Wrong arguments - Commas between parts of unique formatting strings Differential Revision: https://phabricator.services.mozilla.com/D144921
8d29346322957a0dcd4cae09221b759a35712fbb: Bug 1765312 - Wait for error stop before AudioInputSource::Stop() r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Fri, 29 Apr 2022 16:30:29 +0000 - rev 615690
Push 39630 by apavel@mozilla.com at Sat, 30 Apr 2022 09:19:22 +0000
Bug 1765312 - Wait for error stop before AudioInputSource::Stop() r=padenot We need to wait for the stream stop called by the forced error before calling `AudioInputSource::Stop` to ensure the callback order in the test. Otherwise, the stream stop called by the forced error on the background thread will race with the stream stop called by the `AudioInputSource::Stop` in its task thread. The problem of the intermittently unexpected callbacks can be reproduced by adding a delay/thread-sleep in the forced-error's background thread task. When MockCubeb runs into the error state by `ForceError()`, it will create a background-thread task to stop the cubeb stream. On the other hand, when `AuidioInputSource::Stop` is called, it will create a task to stop the cubeb stream first and then destroy the cubeb stream, on its own task thread. Most of time, when `AudioInputSource::Stop` is called, the underlying cubeb stream has been stopped by the brackground task, so the `MockCubebStream` won't fire the stopped-state callback. `MockCubeb::StopStream` in `MockCubebStream::Stop()` called by `AudioInputSource::Stop()` will return a `CUBEB_ERROR` in this case since no stream needs to be stopped, and so no callback need to be fired. However, in rare cases, the stream stop on the AudioInputSource's task thread finishes before the one in the background thread. Hence, the `MockCubebStream::Stop()` called by `AudioInputSource::Stop()` can stop the stream successfully and then fire a stopped state callback. We don't care what thread stop the stream in `TestAudioInputSource.ErrorCallback` test, as long as the error-state cabllback can be forwarded correctly and the stream can be destroyed in the end. To avoid the racy stream stop calls between the background thread and the task thread, we don't call `AudioInputSource::Stop()` until stream is stopped in background thread. Differential Revision: https://phabricator.services.mozilla.com/D144637
c8a797895bf9395fe4de5ab89ef1b00388fccc53: Bug 1765474 - Fix unused-but-set-variable warning in OggDemuxer.cpp. r=media-playback-reviewers,padenot
Mike Hommey <mh+mozilla@glandium.org> - Fri, 22 Apr 2022 01:25:08 +0000 - rev 615053
Push 39600 by nbeleuzu@mozilla.com at Fri, 22 Apr 2022 10:03:51 +0000
Bug 1765474 - Fix unused-but-set-variable warning in OggDemuxer.cpp. r=media-playback-reviewers,padenot dom/media/ogg/OggDemuxer.cpp:1905:7: error: variable 'hops' set but not used [-Werror,-Wunused-but-set-variable] int hops = 0; ^ Differential Revision: https://phabricator.services.mozilla.com/D144147
52b93d9f82e293add9601892f18f9b12b794d29d: Bug 1765627 - Make sure {Disc, C}onnectDeviceInput are correctly called r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Thu, 21 Apr 2022 16:09:58 +0000 - rev 614988
Push 39598 by nfay@mozilla.com at Fri, 22 Apr 2022 03:39:15 +0000
Bug 1765627 - Make sure {Disc, C}onnectDeviceInput are correctly called r=padenot Add some assertions to make sure the ConnectDeviceInput and DisconnectDeviceInput are called at the right time. Differential Revision: https://phabricator.services.mozilla.com/D144218
0a1ce7fa5835669130bec677738a517e5a25a98d: Bug 1761691 - Fix audio_thread_priority build when dbus is build disabled. r=padenot
Matthew Gregan <kinetik@flim.org> - Wed, 20 Apr 2022 21:37:06 +0000 - rev 614839
Push 39595 by ncsoregi@mozilla.com at Thu, 21 Apr 2022 09:43:46 +0000
Bug 1761691 - Fix audio_thread_priority build when dbus is build disabled. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D144077
2b2de9f71e7f917e1732bc12a2ddd4cc64d663cf: Bug 1238038 - Mochitest for opening multi mics r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Mon, 18 Apr 2022 18:45:37 +0000 - rev 614509
Push 39583 by imoraru@mozilla.com at Tue, 19 Apr 2022 03:41:49 +0000
Bug 1238038 - Mochitest for opening multi mics r=padenot Add a test to verify we can open multiple microphones Depends on D139445 Differential Revision: https://phabricator.services.mozilla.com/D143102
eb898ad02abd6bff2d5846be306ae711425349ec: Bug 1238038 - Remove mInputDeviceID in MediaTrackGraph r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Mon, 18 Apr 2022 18:45:37 +0000 - rev 614508
Push 39583 by imoraru@mozilla.com at Tue, 19 Apr 2022 03:41:49 +0000
Bug 1238038 - Remove mInputDeviceID in MediaTrackGraph r=padenot The mInputDeviceID can be removed now since we can get the input-device id via the DeviceInputTrackManager on the graph-thread side now. Depends on D139444 Differential Revision: https://phabricator.services.mozilla.com/D139445
a1e8aebd2e88e453d3473d82aa826d82fa415c59: Bug 1238038 - Manage MediaTrack for devices in one class r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Mon, 18 Apr 2022 18:45:36 +0000 - rev 614507
Push 39583 by imoraru@mozilla.com at Tue, 19 Apr 2022 03:41:49 +0000
Bug 1238038 - Manage MediaTrack for devices in one class r=padenot This patch creates a class to manage all DeviceInputTracks in one place, which simplify the code in the MediaTrackGraph. Depends on D138726 Differential Revision: https://phabricator.services.mozilla.com/D139444
8f7feefeda0c6bf0e6e029f8490982a29d7ed2e4: Bug 1238038 - Allow opening multiple devices r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Mon, 18 Apr 2022 18:45:36 +0000 - rev 614506
Push 39583 by imoraru@mozilla.com at Tue, 19 Apr 2022 03:41:49 +0000
Bug 1238038 - Allow opening multiple devices r=padenot This patch allows website users to open multiple microphones in the same MediaTrackGraph. Depends on D138189 Differential Revision: https://phabricator.services.mozilla.com/D138726
80575371d79fc2ebe326f5e5a3c43f685bd31552: Bug 1238038 - Start non-native audio in NonNativeInputTrack r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Mon, 18 Apr 2022 18:45:36 +0000 - rev 614505
Push 39583 by imoraru@mozilla.com at Tue, 19 Apr 2022 03:41:49 +0000
Bug 1238038 - Start non-native audio in NonNativeInputTrack r=padenot This patch implements all the functionalities allowing us to use a AudioInputSource to generate audio in NonNativeInputTrack. Depends on D137911 Differential Revision: https://phabricator.services.mozilla.com/D138189
b662201583989cd35f18f2775d69b3ff1b5e8618: Bug 1238038 - Create an input-only audio source r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Mon, 18 Apr 2022 18:45:35 +0000 - rev 614504
Push 39583 by imoraru@mozilla.com at Tue, 19 Apr 2022 03:41:49 +0000
Bug 1238038 - Create an input-only audio source r=padenot This patch creates an class managing an input-only audio stream within a task thread. This class will be used as a source generating the audio data to a NonNativeInputTrack in the following patch. Depends on D116535 Differential Revision: https://phabricator.services.mozilla.com/D137911
eff158481883b600835cfb558ebe727336a48aec: Bug 1238038 - Create a cubeb input stream wrapper r=padenot,pehrsons
Chun-Min Chang <chun.m.chang@gmail.com> - Mon, 18 Apr 2022 18:45:35 +0000 - rev 614503
Push 39583 by imoraru@mozilla.com at Tue, 19 Apr 2022 03:41:49 +0000
Bug 1238038 - Create a cubeb input stream wrapper r=padenot,pehrsons To add a non-native input source in the MediaTrackGraph, we need a input-only cubeb stream. This patch implements a light-weight wrapper to operate the C style Cubeb APIs in a C++-friendly way. Depends on D143101 Differential Revision: https://phabricator.services.mozilla.com/D116535
28f666109dfaf43b08a6cbe6c3399a8261ef95f4: Bug 1238038 - Notify state changed in MockCubeb r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Mon, 18 Apr 2022 18:45:34 +0000 - rev 614502
Push 39583 by imoraru@mozilla.com at Tue, 19 Apr 2022 03:41:49 +0000
Bug 1238038 - Notify state changed in MockCubeb r=padenot Add a waitable event that will be fired when the state is changed, so the user can wait for certain state of the cubeb stream. Depends on D143100 Differential Revision: https://phabricator.services.mozilla.com/D143101
f2c23215c842226711ab6d488c536dcbea2ce9cd: Bug 1238038 - Relax channel limit in FromInterleavedBuffer r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Mon, 18 Apr 2022 18:45:34 +0000 - rev 614501
Push 39583 by imoraru@mozilla.com at Tue, 19 Apr 2022 03:41:49 +0000
Bug 1238038 - Relax channel limit in FromInterleavedBuffer r=padenot Depends on D137910 Differential Revision: https://phabricator.services.mozilla.com/D143100
3e81a5bebba2273509f5f71ab820f21f1755cadd: Bug 1238038 - Create AudioChunk from interleaved buffer r=padenot
Chun-Min Chang <chun.m.chang@gmail.com> - Mon, 18 Apr 2022 18:45:34 +0000 - rev 614500
Push 39583 by imoraru@mozilla.com at Tue, 19 Apr 2022 03:41:49 +0000
Bug 1238038 - Create AudioChunk from interleaved buffer r=padenot This patch adds a method to create an AudioChunk from an interleaved buffer. Depends on D130233 Differential Revision: https://phabricator.services.mozilla.com/D137910