Bug 1821931 - [devtools] Add the micromatch package to MC r=ochameau,devtools-reviewers,mhoye Differential Revision: https://phabricator.services.mozilla.com/D172380

Bug 1815460 - [devtools] Merge addRequestPostData, addResponseHeaders, addResponseCookies into addResponseStart r=webdriver-reviewers,ochameau,bomsy,devtools-reviewers,whimboo Differential Revision: https://phabricator.services.mozilla.com/D168538

Bug 1815460 - [devtools] Merge addRequestPostData, addResponseHeaders, addResponseCookies into addResponseStart r=webdriver-reviewers,ochameau,bomsy,devtools-reviewers,whimboo Depends on D169361 Differential Revision: https://phabricator.services.mozilla.com/D168538

Bug 1815460 - [devtools] Netmonitor waterfall sort should fallback to resource ids r=ochameau,bomsy,devtools-reviewers resource ids are channel ids and should be incrementally generated. The current id is actually an actor id, meaning it is a string which will lead to incorrect comparisons (eg "Actor10" will be considered "lower" than "Actor2") and also fully depends on the order in which we create the actors. On some platform / configurations we get identical timestamps for batches of requests, so the fallback mechanism should be reliable Differential Revision: https://phabricator.services.mozilla.com/D169361

Bug 1822937 - Add devtools test to ensure we are no longer crashing; r=ochameau,devtools-reviewers The test times out when it is unsuccessful. Differential Revision: https://phabricator.services.mozilla.com/D173277

Bug 1010150 - [devtools] Allow to pretty-print inline scripts. r=devtools-reviewers,ochameau. To do this, we need to only have a single SourceMapGenerator instance for all the inline scripts of an HTML file, for which we add mappings with offsets based on where the inline script is in the HTML file. To support that, we add a new prettyPrintInlineScript task, which takes a taskId so we can have one SourceMapGenerator for a given taskId, that we then pass to prettyFast. A test is added to ensure different cases of inline scripts are pretty printed as expected, that resulting console messages location are updated and that the event tooltip in the inspector shows the pretty file as well. `findColumnBreakpoint` helper was fixed to look into the correct location for original file (which pretty-printed file are) `assertLineIsBreakable` is modified to show the text of the line so it's easier to debug failures. Differential Revision: https://phabricator.services.mozilla.com/D170751

Bug 1815937 - [devtools] Remove inline script displacement handling in source actor. r=devtools-reviewers,ochameau. This is all made unnecessary by the previous patch of the stack. Differential Revision: https://phabricator.services.mozilla.com/D170581

Bug 1815937 - Set ScriptLoadContext column number for inline scripts. r=smaug,devtools-reviewers,ochameau. Differential Revision: https://phabricator.services.mozilla.com/D170580

Bug 1815937 - Set ScriptLoadContext column number for inline scripts. r=smaug,devtools-reviewers,ochameau. Differential Revision: https://phabricator.services.mozilla.com/D170580

Bug 1818962 - [devtools] Refactor search modifiers actions and reducers r=ochameau,devtools-reviewers This patch makes the SearchInput a connected component, This allows us cleanup all the seperate actions and reducer logic and makes it easier to add new SearchInput with modifers functionality. Differential Revision: https://phabricator.services.mozilla.com/D171034

Bug 1818806 [devtools] Local overrides feature in the debugger r=ochameau,devtools-backward-compat-reviewers,devtools-reviewers Highlights for this patch - Support for the script overrides feature - Overrides for html files are not supported - Add styling to indicate overrides - Add mochitests Depends on D163600 Differential Revision: https://phabricator.services.mozilla.com/D163610

Bug 1815937 - [devtools] Remove inline script displacement handling in source actor. r=devtools-reviewers,ochameau. This is all made unnecessary by the previous patch of the stack. Differential Revision: https://phabricator.services.mozilla.com/D170581

Bug 1815937 - Set ScriptLoadContext column number for inline scripts. r=smaug,devtools-reviewers,ochameau. Differential Revision: https://phabricator.services.mozilla.com/D170580

Bug 1806794 - Support "network.response" events for cached responses r=webdriver-reviewers,whimboo,devtools-reviewers,ochameau This fixes two issues: - the transferred size was missing from cached responseStarted events - the fromCache flag needs to be read on the initial network event payload from devtools, because relying on the isFromCache logic used to build the addResponseStart payload does not properly detect all cached responses (eg for a cached 301) Differential Revision: https://phabricator.services.mozilla.com/D171508

Bug 1557196 - [devtools] Don't buffer lines in pretty-fast. r=ochameau,devtools-reviewers. This allows us to get accurate mappings for columns as well, which is required for column breakpoints to work. To mitigate the performance regression we'd get from adding many more mappings, instead of using a SourceNode, then adding children to it, and at the end add all the mapping in a SourceMapGenerator, we directly use the SourceMapGenerator in the `write` function. This means that we need to compute the pretty-printed code ourselves, but it's easy to borrow the logic in `toStringWithSourceMap`. We also only add mappings in the SourceMapGenerator for tokens (and not for whitespaces), as it reduces the amount of elements we have to go through, while still producing a valid source map in the end. By doing that, we can also invert the mapping directly in `write`, so we don't have to do it later in the worker code, and avoid having to re-sort the mappings array. A test is added to ensure column breakpoints work as expected after pretty-printing Differential Revision: https://phabricator.services.mozilla.com/D168383

Bug 1767693 - [devtools] Fix browser_viewport_fallback_width.js intermittent. r=devtools-reviewers,ochameau. Wait for apz flush after resizing RDM ui. Differential Revision: https://phabricator.services.mozilla.com/D172143

Bug 1821316 - [devtools] Fix browser_webconsole_custom_formatters_errors.js perma fail on beta. r=devtools-reviewers,ochameau. Differential Revision: https://phabricator.services.mozilla.com/D172132

Bug 1805288 - Part 2: Use ChromeUtils.defineLazyGetter from XPCOMUtils.defineLazyGetter. r=smaug,devtools-reviewers,ochameau Also fix test_safe-getter.js not to use defineLazyGetter, given the test expects the getter function be scripted function, while the getter function created by ChromeUtils.defineLazyGetter is native. Rewriting XPCOMUtils.defineLazyGetter consumers should be done in separate bugs. Differential Revision: https://phabricator.services.mozilla.com/D171320

Bug 1815459 - [devtools] Remove NetworkUtils.createNetworkEvent r=ochameau,bomsy,devtools-reviewers Depends on D168537 Differential Revision: https://phabricator.services.mozilla.com/D168791

Bug 1815459 - [devtools] Remove addRequestHeaders and addRequestCookies r=webdriver-reviewers,ochameau,bomsy,whimboo,devtools-reviewers Depends on D168536 Differential Revision: https://phabricator.services.mozilla.com/D168537

Bug 1815459 - [devtools] Rename extraStringData to rawHeaders r=ochameau Depends on D168535 Differential Revision: https://phabricator.services.mozilla.com/D168536

Bug 1815459 - [devtools] Remove unused arguments for network onEventUpdate r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D168535

Bug 1790542 - [devtools] Convert browser_source_map-reload.js test from using .sjs files to createTestHTTPServer r=ochameau,devtools-reviewers .sjs files depend on redirects to load static files. In D168648 we block redirects on sourceMappingUrl, so this browser_source_map-reload.js fails because we use .sjs to serve the content. This patch refactors to no longer use .sjs files Differential Revision: https://phabricator.services.mozilla.com/D169739

Bug 1817984 - [devtools] Add Search Modifiers for the project search component r=ochameau In this patch - Move search modifiers support into the SearchInput component, so that it can be shared across the Project Search, File Search and the Quick modal Search. - Add on the actions, reducers and workers support for search modifiers to project search Differential Revision: https://phabricator.services.mozilla.com/D168932

Bug 1817984 - [devtools] Add Search Modifiers for the project search component r=ochameau In this patch - Move search modifiers support into the SearchInput component, so that it can be shared across the Project Search, File Search and the Quick modal Search. - Add on the actions, reducers and workers support for search modifiers to project search Differential Revision: https://phabricator.services.mozilla.com/D168932

Bug 1818205 - [devtools] Update debugger jest obsolete snapshots. r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D170600

Bug 1817036 - Remove osfile.jsm and ospath.jsm usage from devtools/ r=ochameau The implementation of base-loader operates on stringly-typed URIs with path methods. Refactoring this module to use paths and URIs is beyond the scope of removing OS.File, so the methods from ospath_unix.jsm have been copied into the module. Differential Revision: https://phabricator.services.mozilla.com/D170107

Bug 1818037 - [devtools] Update test for text selection in netmonitor response preview r=ochameau Depends on D170405 Fails without the previous patch, passes now Differential Revision: https://phabricator.services.mozilla.com/D170503

Bug 1811004 - [devtools] Rename project search selectors accordingly r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D169900

Bug 1811004 - [devtools] Make the search modifiers a shared component r=ochameau This patch makes the search modifiers a shared component so we can use this for project search. Differential Revision: https://phabricator.services.mozilla.com/D168931

Bug 1816342 - [devtools] Fix `valid` getter in color.js. r=ochameau. It used to return true only if `colorToRGBA` wasn't returning null. We changed it to be an alias of `isValidCSSColor` but this had unintended effect We need to consider a color valid if we can get the rgba tuples from it, as we need them to run the different methods/operation in this module. Differential Revision: https://phabricator.services.mozilla.com/D169592

Bug 1815877 - [devtools] Don't include CSS property preferences in devtools/shared/css/generated/properties-db.js. r=ochameau. This was only used in a XPCShell test, where we can directly use InspectorUtils.getCSSPropertyPrefs() instead. Differential Revision: https://phabricator.services.mozilla.com/D169338

Bug 1789723 - [devtools] fix intermittent devtools/client/inspector/animation/test/browser_animation_current-time-label.js r=devtools-reviewers,ochameau This should fix the issue, seems low frequency on try but no failure detected with the patch. Differential Revision: https://phabricator.services.mozilla.com/D169568

Bug 1814830 - [devtools] Drop side-effect free requirement for custom formatter hooks. r=ochameau. Since we will handle a single Debugger now, we can simplify some code. Differential Revision: https://phabricator.services.mozilla.com/D168770

Bug 1815850 - [devtools] Remove check on CSS color level 4 syntax support. r=ochameau. It's enabled for a while now, we don't need to check it in our codebase. Differential Revision: https://phabricator.services.mozilla.com/D169306

Bug 1814629 - [devtools] Load target-actor-registry in the shared global but exclude browser-element targets r=ochameau Depends on D168438 Differential Revision: https://phabricator.services.mozilla.com/D168677

Bug 1792559 - BaseContext applySafeWithoutClone should log errors associated to the extension page innerWindowID. r=willdurand,ochameau,extension-reviewers Differential Revision: https://phabricator.services.mozilla.com/D166461

Bug 1803546 - [devtools] Show errored request for those that are for non-existing domain r=ochameau #### Highlights of this patch - We are now tracking errors that show up later in the cycle. - Errors related to 301 redirects are ignored as we show those as 301's in the netmonitor. - Using `waitForLoad` in a couple of more places as when a domain is not found, we have `await`'s that do not resolve. - `NS_IMAGELIB_ERROR_FAILURE` is now emitted for the stub network request in the console, which was not exposed previously. Differential Revision: https://phabricator.services.mozilla.com/D166882

Bug 1792559 - BaseContext applySafeWithoutClone should log errors associated to the extension page innerWindowID. r=willdurand,ochameau Differential Revision: https://phabricator.services.mozilla.com/D166461

Bug 1814652 - [devtools] Rename SourceMapLoader#applySourceMap and change its signature. r=ochameau. Let's make it take an array of ids so we don't need to create multiple SourceMapConsumer. Differential Revision: https://phabricator.services.mozilla.com/D168685

Bug 1815452 - [devtools] Simplify mapping structure posted to/from workers. r=ochameau,bomsy. We used to get the mappings array from the pretty fast worker to the prettyPrint action, and then pass this array to the sourceMap service (also a worker). As the mapping can be quite large, and given it has a complex shape, passing it to and from workers (via `postMessage`) was costly. So here, instead of passing only the mapping, we directly generate the sourceMap from the pretty fast worker, and pass it to the action which forwards it to the sourceMap service. This helps reduce the overhead we were seeing when not buffering the lines in the pretty print worker, in the previous patch of this stack. Differential Revision: https://phabricator.services.mozilla.com/D168384

Bug 1792559 - BaseContext applySafeWithoutClone should log errors associated to the extension page innerWindowID. r=willdurand,ochameau Differential Revision: https://phabricator.services.mozilla.com/D166461

Bug 1814620 - [devtools] Remove color.js rgbToColorName. r=ochameau. Make the callsites call InspectorUtils.rgbToColorName instead. Since it was throwing when passed a non-valid named color, which wasn't the expected outcome in DevTools, modify the c++ method so it return an empty string instead. Add a dedicated test since there wasn't one. Differential Revision: https://phabricator.services.mozilla.com/D168989

Bug 1814620 - [devtools] Replace custom color.js method with InspectorUtils ones. r=ochameau. Let's use `InspectorUtils` `isValidCSSColor`, `rgbToColorName` and `colorToRGBA` instead of their js-counterpart. Differential Revision: https://phabricator.services.mozilla.com/D168669

Bug 1814620 - [devtools] Remove color.js rgbToColorName. r=ochameau. Make the callsites call InspectorUtils.rgbToColorName instead. Since it was throwing when passed a non-valid named color, which wasn't the expected outcome in DevTools, modify the c++ method so it return an empty string instead. Add a dedicated test since there wasn't one. Differential Revision: https://phabricator.services.mozilla.com/D168989

Bug 1814620 - [devtools] Replace custom color.js method with InspectorUtils ones. r=ochameau. Let's use `InspectorUtils` `isValidCSSColor`, `rgbToColorName` and `colorToRGBA` instead of their js-counterpart. Differential Revision: https://phabricator.services.mozilla.com/D168669

Bug 1811138 - [devtools] Remove require calls to InspectorUtils r=ochameau,perftest-reviewers,sparky Depends on D167211 Differential Revision: https://phabricator.services.mozilla.com/D167308

Bug 1811138 - [devtools] Move ensureCSSErrorReportingEnabled to the CSS_MESSAGE watcher r=ochameau,perftest-reviewers,sparky,devtools-backward-compat-reviewers We can also remove the legacy listener, as it is only ever triggered by worker toolboxes. Differential Revision: https://phabricator.services.mozilla.com/D167211

Bug 1812521 - [devtools] Don't rely on custom formatter index for body hook. r=ochameau. Instead of keeping track of an index, store the formatter entry in the object actor from `customFormatterHeader` so we can re-use it in `customFormatterBody`. Differential Revision: https://phabricator.services.mozilla.com/D167905

Bug 1813341 - Check topBrowsingContext is not null before using it. r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D168202