searching for reviewer(ochameau)
56f96e016e98d17af44a470ef6bdd07cd6d420a4: Bug 1605330 - [devtools] Enable context selector on Nightly. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 25 Nov 2021 13:05:39 +0000 - rev 600114
Push 39010 by mlaza@mozilla.com at Thu, 25 Nov 2021 21:41:04 +0000
Bug 1605330 - [devtools] Enable context selector on Nightly. r=ochameau. We take this opportunity to merge the browser toolbox and content toolbox preferences into a single one. Depends on D131600 Differential Revision: https://phabricator.services.mozilla.com/D131770
5acc79a9a45252dbecbc760987f0c1c614e7e542: Bug 1742800 - [devtools] Fix custom inspector DAMP test with EFT. r=ochameau,perftest-reviewers,AlexandruIonescu.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 25 Nov 2021 13:05:38 +0000 - rev 600112
Push 39010 by mlaza@mozilla.com at Thu, 25 Nov 2021 21:41:04 +0000
Bug 1742800 - [devtools] Fix custom inspector DAMP test with EFT. r=ochameau,perftest-reviewers,AlexandruIonescu. Use nodeFront walkerFront instead of root one. Differential Revision: https://phabricator.services.mozilla.com/D132027
c88308a203222a64f9438f62c22164a82f9b9452: Bug 1742541 - [devtools] Don't try to show PausedDebuggerOverlay if document isn't ready. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 25 Nov 2021 06:24:12 +0000 - rev 600100
Push 39009 by ccozmuta@mozilla.com at Thu, 25 Nov 2021 16:28:30 +0000
Bug 1742541 - [devtools] Don't try to show PausedDebuggerOverlay if document isn't ready. r=ochameau. At the moment, the overlay can't be displayed if the DOM isn't loaded, and we were waiting for that state before trying to show the overlay. But we can't move forward in the document loading process until we resume, which mean we could end up in weird state with the overlay, where the page wasn't paused anymore, but we'd display it. In this patch, we simply bail out if the document isn't ready. Differential Revision: https://phabricator.services.mozilla.com/D131884
762649eb6709733b5685608445d490fe20152e73: Bug 1742541 - [devtools] Don't try to show PausedDebuggerOverlay if document isn't ready. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 25 Nov 2021 06:24:12 +0000 - rev 600091
Push 39009 by ccozmuta@mozilla.com at Thu, 25 Nov 2021 16:28:30 +0000
Bug 1742541 - [devtools] Don't try to show PausedDebuggerOverlay if document isn't ready. r=ochameau. At the moment, the overlay can't be displayed if the DOM isn't loaded, and we were waiting for that state before trying to show the overlay. But we can't move forward in the document loading process until we resume, which mean we could end up in weird state with the overlay, where the page wasn't paused anymore, but we'd display it. In this patch, we simply bail out if the document isn't ready. Differential Revision: https://phabricator.services.mozilla.com/D131884
fe65ddb40037dcbd40fa07de66c7cbc619b55e12: Bug 1605330 - [devtools] Enable context selector on Nightly. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 23 Nov 2021 18:56:55 +0000 - rev 599962
Push 39005 by apavel@mozilla.com at Wed, 24 Nov 2021 03:53:13 +0000
Bug 1605330 - [devtools] Enable context selector on Nightly. r=ochameau. We take this opportunity to merge the browser toolbox and content toolbox preferences into a single one. Depends on D131600 Differential Revision: https://phabricator.services.mozilla.com/D131770
bd54eacb2d7c2fbfd34753aeeea85bfc3b2d9ff5: Bug 1742541 - [devtools] Don't try to show PausedDebuggerOverlay if document isn't ready. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 23 Nov 2021 18:56:54 +0000 - rev 599959
Push 39005 by apavel@mozilla.com at Wed, 24 Nov 2021 03:53:13 +0000
Bug 1742541 - [devtools] Don't try to show PausedDebuggerOverlay if document isn't ready. r=ochameau. At the moment, the overlay can't be displayed if the DOM isn't loaded, and we were waiting for that state before trying to show the overlay. But we can't move forward in the document loading process until we resume, which mean we could end up in weird state with the overlay, where the page wasn't paused anymore, but we'd display it. In this patch, we simply bail out if the document isn't ready. Differential Revision: https://phabricator.services.mozilla.com/D131884
5dc30455b150dbef0fa8050da52e009bf8aa71a2: Bug 1741811 - [devtools] Make watchTargets take a single object param. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 23 Nov 2021 13:23:35 +0000 - rev 599886
Push 39004 by abutkovits@mozilla.com at Tue, 23 Nov 2021 21:51:13 +0000
Bug 1741811 - [devtools] Make watchTargets take a single object param. r=ochameau. Differential Revision: https://phabricator.services.mozilla.com/D131755
9dfd5e6601a160c4cc9f2225b995e4b2bc8a7ed6: Bug 1505304 - [devtools] Make watchTargets take a single object param. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 23 Nov 2021 12:39:19 +0000 - rev 599879
Push 39003 by mlaza@mozilla.com at Tue, 23 Nov 2021 16:53:32 +0000
Bug 1505304 - [devtools] Make watchTargets take a single object param. r=ochameau. Differential Revision: https://phabricator.services.mozilla.com/D131755
788aa2665cfb52eca1ffef838ff8e371c706fd17: Bug 1742329 - [devtools] Fix server chrome inspector test when EFT is enabled. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 22 Nov 2021 13:38:44 +0000 - rev 599785
Push 39000 by csabou@mozilla.com at Mon, 22 Nov 2021 21:05:14 +0000
Bug 1742329 - [devtools] Fix server chrome inspector test when EFT is enabled. r=ochameau. We were always using the top level walker front, but as some tests are using iframes, we need to use the node fronts dedicated walker front instead. test_inspector-dead-nodes.html is purely skipped when EFT is enabled as it triggers failures more frequently and it doesn't make much sense anyway (this test will be migrated to a command test when we move walkerFront#children to a command). Differential Revision: https://phabricator.services.mozilla.com/D131599
7085fccf9bd8b94593d6aa5e71785cf7049f9eaf: Bug 1742330 - [devtools] Make browser_resources_document_events.js handle EFT. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 22 Nov 2021 13:38:43 +0000 - rev 599783
Push 39000 by csabou@mozilla.com at Mon, 22 Nov 2021 21:05:14 +0000
Bug 1742330 - [devtools] Make browser_resources_document_events.js handle EFT. r=ochameau. Differential Revision: https://phabricator.services.mozilla.com/D131476
bd34ae315b23097d524b5536f49ec32228be8a42: Bug 1731556 - [remote] Apply events from session data for new window globals r=webdriver-reviewers,ochameau,whimboo,jgraham
Julian Descottes <jdescottes@mozilla.com> - Fri, 19 Nov 2021 15:39:12 +0000 - rev 599663
Push 38993 by ncsoregi@mozilla.com at Fri, 19 Nov 2021 21:29:37 +0000
Bug 1731556 - [remote] Apply events from session data for new window globals r=webdriver-reviewers,ochameau,whimboo,jgraham Depends on D127698 Differential Revision: https://phabricator.services.mozilla.com/D128284
a091d9b9bee6644f600129585a00460e5e8043ee: Bug 1741808 - [devtools] Fix increased failures on browser_toolbox_backward_forward_navigation.js when EFT is enabled. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 18 Nov 2021 13:22:35 +0000 - rev 599542
Push 38988 by nbeleuzu@mozilla.com at Thu, 18 Nov 2021 16:26:28 +0000
Bug 1741808 - [devtools] Fix increased failures on browser_toolbox_backward_forward_navigation.js when EFT is enabled. r=ochameau. Differential Revision: https://phabricator.services.mozilla.com/D131475
a9e82612a156fe0fa0254d2067b48bcead668194: Bug 1741803 - [devtools] Fix browser_inspector_iframe-picker-bfcache-navigation with EFT. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 18 Nov 2021 13:22:35 +0000 - rev 599541
Push 38988 by nbeleuzu@mozilla.com at Thu, 18 Nov 2021 16:26:28 +0000
Bug 1741803 - [devtools] Fix browser_inspector_iframe-picker-bfcache-navigation with EFT. r=ochameau. This required 2 changes: - fixing WatcherActor notifyTargetAvailable so we get notified about the iframe target when doing a bfcache navigation (a test case is added in browser_target_command_bfcache.js as well) - Checking is the target isn't destroyed in inspector onTargetSelected Differential Revision: https://phabricator.services.mozilla.com/D131471
64f6fc1a3ec77ceeb3caf05f0ca4c4dcc4c74d22: Bug 1740453 - [devtools] Handle onTargetSelected in accessibility panel. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 18 Nov 2021 13:22:34 +0000 - rev 599540
Push 38988 by nbeleuzu@mozilla.com at Thu, 18 Nov 2021 16:26:28 +0000
Bug 1740453 - [devtools] Handle onTargetSelected in accessibility panel. r=ochameau. A couple tests are added to check that the panel works fine when using the iframe picker. Differential Revision: https://phabricator.services.mozilla.com/D130611
182de405dd613e6292f3ac1560a51f32512d5e16: Bug 1740455 - [devtools] Add a test for TabbingOrder highlighter. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 17 Nov 2021 14:07:38 +0000 - rev 599442
Push 38986 by smolnar@mozilla.com at Wed, 17 Nov 2021 21:41:26 +0000
Bug 1740455 - [devtools] Add a test for TabbingOrder highlighter. r=ochameau. A new method is added in the HighlighterTestActor to retrieve information about the highglighter. The test highlights (pun intended) the issue described in Bug 1740509. Differential Revision: https://phabricator.services.mozilla.com/D130875
1f0c8ee5b3db39543e4ce7ac58be5f61c6d1c7d9: Bug 1741369 - [devtools] Import devtools require in head.js for some xpcshell test suites r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 17 Nov 2021 12:43:27 +0000 - rev 599438
Push 38986 by smolnar@mozilla.com at Wed, 17 Nov 2021 21:41:26 +0000
Bug 1741369 - [devtools] Import devtools require in head.js for some xpcshell test suites r=ochameau Depends on D131218 Differential Revision: https://phabricator.services.mozilla.com/D131329
61b20eff7ece91835c76606c87ad85c5fcbc8ba5: Bug 1741369 - [devtools] Update paths to loader files in devtools/ r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 17 Nov 2021 12:43:26 +0000 - rev 599436
Push 38986 by smolnar@mozilla.com at Wed, 17 Nov 2021 21:41:26 +0000
Bug 1741369 - [devtools] Update paths to loader files in devtools/ r=ochameau Depends on D131216 Differential Revision: https://phabricator.services.mozilla.com/D131217
2ec616d81fd9c485da870e5b69d1f6c9cd797b61: Bug 1741369 - [devtools] Move all loader-related files to devtools/shared/loader r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 17 Nov 2021 12:43:26 +0000 - rev 599435
Push 38986 by smolnar@mozilla.com at Wed, 17 Nov 2021 21:41:26 +0000
Bug 1741369 - [devtools] Move all loader-related files to devtools/shared/loader r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D131216
4191c68c7655deaf395fb09bb6598cb3824c79ba: Bug 1736366 - [devtools] Refactor the getBreakpointSources selector to no longer use makeShallowQuery r=ochameau
Hubert Boma Manilla <hmanilla@mozilla.com> - Tue, 16 Nov 2021 09:51:18 +0000 - rev 599288
Push 38982 by ccozmuta@mozilla.com at Tue, 16 Nov 2021 15:59:54 +0000
Bug 1736366 - [devtools] Refactor the getBreakpointSources selector to no longer use makeShallowQuery r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D128742
0ea31fd939c805259e79272c1e46df08bc2d3e3b: Bug 1740454 - [devtools] Fix a11y panel react warnings. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 15 Nov 2021 07:00:03 +0000 - rev 599090
Push 38979 by ctuns@mozilla.com at Mon, 15 Nov 2021 09:39:17 +0000
Bug 1740454 - [devtools] Fix a11y panel react warnings. r=ochameau. Differential Revision: https://phabricator.services.mozilla.com/D130855
162323da0ea56ec3dc5351041f8daeec4cd04665: Bug 1713443 - [remote] Support shared global session data that supports BiDi and CDP r=webdriver-reviewers,whimboo,ochameau
Julian Descottes <jdescottes@mozilla.com> - Thu, 11 Nov 2021 22:01:46 +0000 - rev 599007
Push 38972 by ccozmuta@mozilla.com at Fri, 12 Nov 2021 09:23:17 +0000
Bug 1713443 - [remote] Support shared global session data that supports BiDi and CDP r=webdriver-reviewers,whimboo,ochameau Differential Revision: https://phabricator.services.mozilla.com/D127698
a49406d072724da3d2b5785244ad9e352080c584: Bug 1740548 - [devtools] Fix browser_rules_selector-highlighter-iframe-picker.js intermittent. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 10 Nov 2021 17:03:22 +0000 - rev 598898
Push 38968 by nbeleuzu@mozilla.com at Wed, 10 Nov 2021 21:49:46 +0000
Bug 1740548 - [devtools] Fix browser_rules_selector-highlighter-iframe-picker.js intermittent. r=ochameau. Make the test wait until we don't have an active highlighter anymore. Differential Revision: https://phabricator.services.mozilla.com/D130888
0e2ff229163c6c661ed2266f0da50191944aab38: Bug 1713443 - [remote] Support shared global session data that supports BiDi and CDP r=webdriver-reviewers,whimboo,ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 10 Nov 2021 16:45:20 +0000 - rev 598896
Push 38968 by nbeleuzu@mozilla.com at Wed, 10 Nov 2021 21:49:46 +0000
Bug 1713443 - [remote] Support shared global session data that supports BiDi and CDP r=webdriver-reviewers,whimboo,ochameau Differential Revision: https://phabricator.services.mozilla.com/D127698
88f109171700585d376f90d8e445d44fd5debf07: Bug 1740296 - [devtools] Fix accessibility test names. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 10 Nov 2021 16:30:08 +0000 - rev 598894
Push 38968 by nbeleuzu@mozilla.com at Wed, 10 Nov 2021 21:49:46 +0000
Bug 1740296 - [devtools] Fix accessibility test names. r=ochameau. Differential Revision: https://phabricator.services.mozilla.com/D130765
5ae8cb91f3e16b5815d2829a9fdfdd8945bf3918: Bug 1739061 - [devtools] Remove skip-if annotation on console context selector tests. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 10 Nov 2021 14:51:06 +0000 - rev 598879
Push 38968 by nbeleuzu@mozilla.com at Wed, 10 Nov 2021 21:49:46 +0000
Bug 1739061 - [devtools] Remove skip-if annotation on console context selector tests. r=ochameau. Those tests are passing with Fission enabled, as well as with EFT enabled. it would be better to not skip them, so we remove the annotation, and use specific assertions to handle cases where the tests shouldn't pass. Differential Revision: https://phabricator.services.mozilla.com/D130244
09dd3df16a8f1363645d08c0779039db1692e839: Bug 1738915 - [devtools] Set webconsole context when selecting frame in iframe picker. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 10 Nov 2021 14:51:05 +0000 - rev 598878
Push 38968 by nbeleuzu@mozilla.com at Wed, 10 Nov 2021 21:49:46 +0000
Bug 1738915 - [devtools] Set webconsole context when selecting frame in iframe picker. r=ochameau. Differential Revision: https://phabricator.services.mozilla.com/D130180
8b8b731d4ac405f20bc29705afa4f815c0f5ffed: Bug 1730148 - [devtools] Handle onTargetSelected in DOM panel. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 10 Nov 2021 14:51:05 +0000 - rev 598877
Push 38968 by nbeleuzu@mozilla.com at Wed, 10 Nov 2021 21:49:46 +0000
Bug 1730148 - [devtools] Handle onTargetSelected in DOM panel. r=ochameau. Differential Revision: https://phabricator.services.mozilla.com/D130332
285c6dd1bde8c1bcf532966ac00fb5d94fab2ff4: Bug 1730148 - [devtools] Add a `onSelect` argument to `targetCommand.watchTargets` . r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 10 Nov 2021 14:51:04 +0000 - rev 598876
Push 38968 by nbeleuzu@mozilla.com at Wed, 10 Nov 2021 21:49:46 +0000
Bug 1730148 - [devtools] Add a `onSelect` argument to `targetCommand.watchTargets` . r=ochameau. This will allow panels to react to a given target being selected in the iframe picker when EFT is enabled. We add support for onTargetSelected in the inspector and add a few test cases for it (checking that highlighters are hidden when selecting a frame, checking that selecting an iframe and then removing it does update the markup view). Differential Revision: https://phabricator.services.mozilla.com/D130177
ad17653a4658d679914229e01b4b266af86dc0a9: Bug 1730148 - [devtools] Use targetCommand to populate iframe picker when EFT is enabled. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 10 Nov 2021 14:51:04 +0000 - rev 598875
Push 38968 by nbeleuzu@mozilla.com at Wed, 10 Nov 2021 21:49:46 +0000
Bug 1730148 - [devtools] Use targetCommand to populate iframe picker when EFT is enabled. r=ochameau. The iframe picker code is refactored a bit so it's easier to follow. This patch makes it so we support both EFT and non EFT scenarios. Differential Revision: https://phabricator.services.mozilla.com/D130241
24c1a120bb770fb03128ff494ba973b442478290: Bug 1739061 - [devtools] Remove skip-if annotation on console context selector tests. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 10 Nov 2021 10:44:52 +0000 - rev 598856
Push 38968 by nbeleuzu@mozilla.com at Wed, 10 Nov 2021 21:49:46 +0000
Bug 1739061 - [devtools] Remove skip-if annotation on console context selector tests. r=ochameau. Those tests are passing with Fission enabled, as well as with EFT enabled. it would be better to not skip them, so we remove the annotation, and use specific assertions to handle cases where the tests shouldn't pass. Differential Revision: https://phabricator.services.mozilla.com/D130244
eb9953fd3252cb5f859396fa389b4e96b7b42117: Bug 1738915 - [devtools] Set webconsole context when selecting frame in iframe picker. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 10 Nov 2021 10:44:52 +0000 - rev 598855
Push 38968 by nbeleuzu@mozilla.com at Wed, 10 Nov 2021 21:49:46 +0000
Bug 1738915 - [devtools] Set webconsole context when selecting frame in iframe picker. r=ochameau. Differential Revision: https://phabricator.services.mozilla.com/D130180
9bd72db885eb6b79b0af02421f4f473986dedf8a: Bug 1730148 - [devtools] Handle onTargetSelected in DOM panel. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 10 Nov 2021 10:44:51 +0000 - rev 598854
Push 38968 by nbeleuzu@mozilla.com at Wed, 10 Nov 2021 21:49:46 +0000
Bug 1730148 - [devtools] Handle onTargetSelected in DOM panel. r=ochameau. Differential Revision: https://phabricator.services.mozilla.com/D130332
819078e24fa6e86663bd86eeadaff441557e3dc1: Bug 1730148 - [devtools] Add a `onSelect` argument to `targetCommand.watchTargets` . r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 10 Nov 2021 10:44:51 +0000 - rev 598853
Push 38968 by nbeleuzu@mozilla.com at Wed, 10 Nov 2021 21:49:46 +0000
Bug 1730148 - [devtools] Add a `onSelect` argument to `targetCommand.watchTargets` . r=ochameau. This will allow panels to react to a given target being selected in the iframe picker when EFT is enabled. We add support for onTargetSelected in the inspector and add a few test cases for it (checking that highlighters are hidden when selecting a frame, checking that selecting an iframe and then removing it does update the markup view). Differential Revision: https://phabricator.services.mozilla.com/D130177
a0e706688adcf69f1c4540725849093b8a39b0dd: Bug 1730148 - [devtools] Use targetCommand to populate iframe picker when EFT is enabled. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 10 Nov 2021 10:44:51 +0000 - rev 598852
Push 38968 by nbeleuzu@mozilla.com at Wed, 10 Nov 2021 21:49:46 +0000
Bug 1730148 - [devtools] Use targetCommand to populate iframe picker when EFT is enabled. r=ochameau. The iframe picker code is refactored a bit so it's easier to follow. This patch makes it so we support both EFT and non EFT scenarios. Differential Revision: https://phabricator.services.mozilla.com/D130241
29c0cdd335be62a0883ea8f11d7dde40e5fc2894: Bug 1739371 - [devtools] Fix browser_inspector_command_findNodeFrontFromSelectors.js intermittent. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 08 Nov 2021 14:25:49 +0000 - rev 598508
Push 38960 by nbeleuzu@mozilla.com at Mon, 08 Nov 2021 16:38:54 +0000
Bug 1739371 - [devtools] Fix browser_inspector_command_findNodeFrontFromSelectors.js intermittent. r=ochameau. The 0 timeout wasn't enough on some platform, so we reload the page before calling the method; since we're targetting an iframe that takes a few seconds to load, the call should time out every time. Differential Revision: https://phabricator.services.mozilla.com/D130612
064c8d22b1e6169db3b625e6c3150f3847ddc4d5: Bug 1738941 - [devtools] Resume the toolbox state if paused on target destroyed r=ochameau
Hubert Boma Manilla <hmanilla@mozilla.com> - Mon, 08 Nov 2021 14:04:35 +0000 - rev 598506
Push 38960 by nbeleuzu@mozilla.com at Mon, 08 Nov 2021 16:38:54 +0000
Bug 1738941 - [devtools] Resume the toolbox state if paused on target destroyed r=ochameau Enabled an existing test relating to Bug 1722305, that tests the fix in this patch. Differential Revision: https://phabricator.services.mozilla.com/D130256
710c7e460146e6e0e4f71710efa8a95ab8c7f1c6: Bug 1737865 - [devtools] Do not treat xpcshell targets as parent process targets r=ochameau,nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Mon, 08 Nov 2021 08:03:08 +0000 - rev 598475
Push 38960 by nbeleuzu@mozilla.com at Mon, 08 Nov 2021 16:38:54 +0000
Bug 1737865 - [devtools] Do not treat xpcshell targets as parent process targets r=ochameau,nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D130212
5a2367e856d2afe4e429c0c1570d8bb6b0b0c048: Bug 1735551 - [devtools] Add a timeout to findNodeFrontFromSelectors. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 04 Nov 2021 08:58:04 +0000 - rev 598211
Push 38948 by ccozmuta@mozilla.com at Thu, 04 Nov 2021 15:41:26 +0000
Bug 1735551 - [devtools] Add a timeout to findNodeFrontFromSelectors. r=ochameau. Since the method might wait for iframe to load, it could stay unsettled for a while. Adding a timeout will make the callsites not wait for ever, at the expense of correctness. This should be okay as this function is mainly called to re-set things after reloading the page, which is a nice to have, but not critical feature. Differential Revision: https://phabricator.services.mozilla.com/D128854
a351a8718aea0cea6511720d67ed0dfcf263c05d: Bug 1735551 - [devtools] Make findNodeFrontFromSelectors command handle remote iframes. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 04 Nov 2021 08:58:04 +0000 - rev 598210
Push 38948 by ccozmuta@mozilla.com at Thu, 04 Nov 2021 15:41:26 +0000
Bug 1735551 - [devtools] Make findNodeFrontFromSelectors command handle remote iframes. r=ochameau. Differential Revision: https://phabricator.services.mozilla.com/D128714
d445f5d8b08a9f4873534322b952953f3fd5323a: Bug 1735551 - [devtools] Make NodeActor#waitForFrameLoad handle transient about:blank document. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 04 Nov 2021 08:58:03 +0000 - rev 598209
Push 38948 by ccozmuta@mozilla.com at Thu, 04 Nov 2021 15:41:26 +0000
Bug 1735551 - [devtools] Make NodeActor#waitForFrameLoad handle transient about:blank document. r=ochameau. At the moment we call `waitForFrameLoad`, the iframe `contentDocument` might be a transient about:blank document, and in such case we weren't waiting properly for it to be loaded. To fix this, we wait until the final document is inserted first. Tests will be added in another commit of this queue. Differential Revision: https://phabricator.services.mozilla.com/D128713
d046e576646aeecd8990f2ff63b58e404fc4e746: Bug 1735551 - [devtools] Turn WalkerFront#findNodeFront into a command. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 04 Nov 2021 08:58:03 +0000 - rev 598208
Push 38948 by ccozmuta@mozilla.com at Thu, 04 Nov 2021 15:41:26 +0000
Bug 1735551 - [devtools] Turn WalkerFront#findNodeFront into a command. r=ochameau. The callsites are migrated to the new command, except from the webconsole test in which we replace usage with existing inspector test helper. Differential Revision: https://phabricator.services.mozilla.com/D128712
9b8ae63f20bade99b4e34121b80e467d0a36d4ff: Bug 1738058 - [devtools] Fix browser_styleeditor_syncIntoRuleView.js intermittent. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 04 Nov 2021 06:14:59 +0000 - rev 598197
Push 38947 by nfay@mozilla.com at Thu, 04 Nov 2021 09:46:42 +0000
Bug 1738058 - [devtools] Fix browser_styleeditor_syncIntoRuleView.js intermittent. r=ochameau. This patch sets the focus on the editor before simulating typing. Differential Revision: https://phabricator.services.mozilla.com/D130243
d36477fa1ade9b1cda9b6be71d1464e2fff579b2: Bug 1738255 - [devtools] Use async/await and promises for the in the netmonitor test pages r=ochameau
Hubert Boma Manilla <hmanilla@mozilla.com> - Wed, 03 Nov 2021 12:45:01 +0000 - rev 598111
Push 38945 by abutkovits@mozilla.com at Wed, 03 Nov 2021 21:36:18 +0000
Bug 1738255 - [devtools] Use async/await and promises for the in the netmonitor test pages r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D129816
6e151e3c599fe9e7e92214f68d5027159a5e5acc: Bug 1735024 - [devtools] Fix the leaks from firefox data provider r=ochameau
Hubert Boma Manilla <hmanilla@mozilla.com> - Mon, 25 Oct 2021 13:57:44 +0000 - rev 596840
Push 38912 by ncsoregi@mozilla.com at Mon, 25 Oct 2021 21:41:06 +0000
Bug 1735024 - [devtools] Fix the leaks from firefox data provider r=ochameau Fixes the leaks of the cached stacktrace info in stackTraceInfoByActorID. Prior to this fix, the stacktrace info in the cache is only removed when the stacktrace details panel is opened, meaning if the details panel is never opened the info is never cleared and leaks. This fixes the netmonitor and the webconsole as they both use the data provider ### Leak Info #### Netmonitor Before: 151 leaked objects (14611 with missing allocation site) in the parent process After: -111 leaked objects (14150 with missing allocation site) in the parent process #### Webconsole Before: 271 leaked objects (13996 with missing allocation site) in the parent process After: 1 leaked objects (13810 with missing allocation site) in the parent process Differential Revision: https://phabricator.services.mozilla.com/D128015
5d37c5a5e07adac114e3f8ba24f3581d0b2d7917: Bug 1735024 - [devtools] Fix the leaks from firefox data provider r=ochameau
Hubert Boma Manilla <hmanilla@mozilla.com> - Fri, 22 Oct 2021 10:43:34 +0000 - rev 596700
Push 38907 by malexandru@mozilla.com at Fri, 22 Oct 2021 21:32:34 +0000
Bug 1735024 - [devtools] Fix the leaks from firefox data provider r=ochameau Fixes the leaks of the cached stacktrace info in stackTraceInfoByActorID. Prior to this fix, the stacktrace info in the cache is only removed when the stacktrace details panel is opened, meaning if the details panel is never opened the info is never cleared and leaks. This fixes the netmonitor and the webconsole as they both use the data provider ### Leak Info #### Netmonitor Before: 151 leaked objects (14611 with missing allocation site) in the parent process After: -111 leaked objects (14150 with missing allocation site) in the parent process #### Webconsole Before: 271 leaked objects (13996 with missing allocation site) in the parent process After: 1 leaked objects (13810 with missing allocation site) in the parent process Differential Revision: https://phabricator.services.mozilla.com/D128015
c77f299cfcbd4bf125bbdfbdc5f1137c8178f36d: Bug 1735154 - [devtools] Fix screenshot in same-remote frame when EFT is enabled. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 14 Oct 2021 06:11:21 +0000 - rev 595832
Push 38877 by mlaza@mozilla.com at Thu, 14 Oct 2021 15:48:30 +0000
Bug 1735154 - [devtools] Fix screenshot in same-remote frame when EFT is enabled. r=ochameau. Differential Revision: https://phabricator.services.mozilla.com/D128363
d5b874f9c64365c3c43a5b24737bc25e6efe6272: Bug 1734149 - [devtools] Disable browser_inspector-retain test task when EFT is enabled. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 12 Oct 2021 15:36:20 +0000 - rev 595524
Push 38871 by nerli@mozilla.com at Tue, 12 Oct 2021 21:40:32 +0000
Bug 1734149 - [devtools] Disable browser_inspector-retain test task when EFT is enabled. r=ochameau. With EFT, what's done in the task is not relevant anymore. Differential Revision: https://phabricator.services.mozilla.com/D127541
60c5ef76eb4455c15f5bf6718d142efeed90878e: Bug 1733421 - [devtools] Fix BrowserToolbox node picker. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 12 Oct 2021 15:36:20 +0000 - rev 595523
Push 38871 by nerli@mozilla.com at Tue, 12 Oct 2021 21:40:32 +0000
Bug 1733421 - [devtools] Fix BrowserToolbox node picker. r=ochameau. This patch sort of reverts to what existed before Bug 1731996, except that we still handle hovering on iframe padding. The "refactoring" that was done in Bug 1731996 made the Browser Toolbox nodePicker misbehaving. Unfortunately, it's hard to have a test for the Browser Toolbox nodePicker, as when we use `BrowserTestUtils.synthesizeMouse` we explicitely pass the window we want the event to happen in so we don't hit any of the propagation stopper that might occur when using it manually. Depends on D127224 Differential Revision: https://phabricator.services.mozilla.com/D127540
32a3cf57dd4396e123ebbba2f894e540528d0781: Bug 1384527 - [devtools] Stop using Promise.jsm in DevTools. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 11 Oct 2021 16:30:06 +0000 - rev 595379
Push 38868 by mlaza@mozilla.com at Mon, 11 Oct 2021 21:46:13 +0000
Bug 1384527 - [devtools] Stop using Promise.jsm in DevTools. r=ochameau. Differential Revision: https://phabricator.services.mozilla.com/D127930
2720b60b28d7fd797b33412f593ca6ede0722772: Bug 1734785 - [devtools] Remove Promise.jsm usage in toolbox.js. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 11 Oct 2021 16:30:04 +0000 - rev 595376
Push 38868 by mlaza@mozilla.com at Mon, 11 Oct 2021 21:46:13 +0000
Bug 1734785 - [devtools] Remove Promise.jsm usage in toolbox.js. r=ochameau. Differential Revision: https://phabricator.services.mozilla.com/D127925