searching for reviewer(ochameau)
b16a957f53f7be1b7414ba1c00d74328f640e7e2: Bug 1543071 - Test remote Target.closeTarget and targetDestroyed event r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 19 Jun 2019 00:15:34 +0000 - rev 479201
Push 36173 by rgurzau@mozilla.com at Wed, 19 Jun 2019 15:50:11 +0000
Bug 1543071 - Test remote Target.closeTarget and targetDestroyed event r=ochameau Depends on D35107 Differential Revision: https://phabricator.services.mozilla.com/D35108
bf1bc7abe7b6dd4a0539f494daafaf9434c03b84: Bug 1559257 - Removing getSameTypeRootTreeItemIgnoreBrowserBoundaries and getSameTypeParentIgnoreBrowserBoundaries usage; r=ochameau
Patrick Brosset <pbrosset@mozilla.com> - Tue, 18 Jun 2019 15:59:29 +0000 - rev 479148
Push 36170 by cbrindusan@mozilla.com at Wed, 19 Jun 2019 03:56:45 +0000
Bug 1559257 - Removing getSameTypeRootTreeItemIgnoreBrowserBoundaries and getSameTypeParentIgnoreBrowserBoundaries usage; r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D34940
2960e77ad5a62b3361dc831b4d92a9db64822c50: Bug 1307227 - Ensure the provider is always initialized for calls to lazyRequireGetter; r=ochameau
Greg Tatum <gtatum@mozilla.com> - Fri, 31 May 2019 15:54:03 +0000 - rev 476419
Push 36094 by aiakab@mozilla.com at Fri, 31 May 2019 21:48:40 +0000
Bug 1307227 - Ensure the provider is always initialized for calls to lazyRequireGetter; r=ochameau The performance profiler pop-up menu wants to be near DevTools, but work without the complete DevTools initialization. This patch ensure that any calls to lazyRequireGetter properly initialize the provider. Differential Revision: https://phabricator.services.mozilla.com/D31628
34cc442a91cb99a9ef2f3090db57c9825ae5d4b5: bug 1553317: remote: improve error message on missing method; r=remote-protocol-reviewers,ochameau CLOSED TREE
Andreas Tolfsen <ato@sny.no> - Mon, 27 May 2019 11:39:16 +0000 - rev 475758
Push 36072 by dluca@mozilla.com at Tue, 28 May 2019 09:38:00 +0000
bug 1553317: remote: improve error message on missing method; r=remote-protocol-reviewers,ochameau CLOSED TREE We return with this rather omnious message when we are missing the implementation of a CDP method: Error: Protocol error (Target.createBrowserContext): TypeError: inst[command] is not a function: This patch improves the error message so that debugging is not necessary to find out which domain or command is missing. Ideally Session.jsm and ContentProcessSession.jsm would share the same execute() function (there's really not reason they don't), but that involves more work. Differential Revision: https://phabricator.services.mozilla.com/D32069
f3d44dbce7e3d1b529ce37b21a4d7471a918edd4: bug 1553317: remote: improve error message on missing method; r=remote-protocol-reviewers,ochameau
Andreas Tolfsen <ato@sny.no> - Mon, 27 May 2019 11:39:16 +0000 - rev 475704
Push 36072 by dluca@mozilla.com at Tue, 28 May 2019 09:38:00 +0000
bug 1553317: remote: improve error message on missing method; r=remote-protocol-reviewers,ochameau We return with this rather omnious message when we are missing the implementation of a CDP method: Error: Protocol error (Target.createBrowserContext): TypeError: inst[command] is not a function: This patch improves the error message so that debugging is not necessary to find out which domain or command is missing. Ideally Session.jsm and ContentProcessSession.jsm would share the same execute() function (there's really not reason they don't), but that involves more work. Differential Revision: https://phabricator.services.mozilla.com/D32069
9216a8250cb834d0ed5d8da01265add23a006037: Bug 1553437 - Add cold-open talos DAMP test for jsdebugger, webconsole, netmonitor r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Thu, 23 May 2019 08:41:19 +0000 - rev 475136
Push 36054 by dvarga@mozilla.com at Thu, 23 May 2019 15:52:15 +0000
Bug 1553437 - Add cold-open talos DAMP test for jsdebugger, webconsole, netmonitor r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D32122
65de6e306adb3257187dcb00fab74b0333765ab3: Bug 1549786 - Add test for Page.navigate reloads the page with the same URL r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 22 May 2019 08:58:08 +0000 - rev 474888
Push 36050 by shindli@mozilla.com at Wed, 22 May 2019 15:25:01 +0000
Bug 1549786 - Add test for Page.navigate reloads the page with the same URL r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D32027
c4af6879f495591ca82b946a4fc1717e0322847d: Bug 1392411 Part 3 - Add test for capturing websocket stacks in net monitor, r=ochameau.
Brian Hackett <bhackett1024@gmail.com> - Sun, 19 May 2019 12:45:19 -1000 - rev 474457
Push 36038 by malexandru@mozilla.com at Mon, 20 May 2019 09:54:18 +0000
Bug 1392411 Part 3 - Add test for capturing websocket stacks in net monitor, r=ochameau.
3e0d5c61f31e3fd31726f5b4769e734a8e933008: Bug 1392411 Part 2 - Report stacks for websocket construction in net monitor, r=ochameau.
Brian Hackett <bhackett1024@gmail.com> - Sun, 19 May 2019 12:44:55 -1000 - rev 474456
Push 36038 by malexandru@mozilla.com at Mon, 20 May 2019 09:54:18 +0000
Bug 1392411 Part 2 - Report stacks for websocket construction in net monitor, r=ochameau.
1c23ba0f835f1a097ba5249bbef8e5c79308ae29: Bug 1392411 Part 3 - Add test for capturing websocket stacks in net monitor, r=ochameau.
Brian Hackett <bhackett1024@gmail.com> - Fri, 19 Apr 2019 07:50:02 -1000 - rev 474192
Push 36026 by malexandru@mozilla.com at Fri, 17 May 2019 09:30:40 +0000
Bug 1392411 Part 3 - Add test for capturing websocket stacks in net monitor, r=ochameau. Differential Revision: https://phabricator.services.mozilla.com/D28231
fce11a50c0589bb63a61abc716ea05ca1c53f12f: Bug 1392411 Part 2 - Report stacks for websocket construction in net monitor, r=ochameau.
Brian Hackett <bhackett1024@gmail.com> - Fri, 19 Apr 2019 07:42:58 -1000 - rev 474191
Push 36026 by malexandru@mozilla.com at Fri, 17 May 2019 09:30:40 +0000
Bug 1392411 Part 2 - Report stacks for websocket construction in net monitor, r=ochameau. Differential Revision: https://phabricator.services.mozilla.com/D28229
5168e91ed5b4da5b8c9c9a05cfc7f250a6de47af: Bug 1392408 Part 6 - Add test for capturing worker stacks in net monitor, r=ochameau.
Brian Hackett <bhackett1024@gmail.com> - Thu, 16 May 2019 08:09:31 -1000 - rev 474189
Push 36026 by malexandru@mozilla.com at Fri, 17 May 2019 09:30:40 +0000
Bug 1392408 Part 6 - Add test for capturing worker stacks in net monitor, r=ochameau.
8a7327b91ed243944681e5a82c1da2db7023d297: Bug 1392408 Part 5 - Listen for alternate stack traces in StackTraceCollector, r=ochameau.
Brian Hackett <bhackett1024@gmail.com> - Thu, 16 May 2019 08:09:07 -1000 - rev 474188
Push 36026 by malexandru@mozilla.com at Fri, 17 May 2019 09:30:40 +0000
Bug 1392408 Part 5 - Listen for alternate stack traces in StackTraceCollector, r=ochameau.
a2f8435fe7ed425c770d4ee59143dada8aab143b: Bug 1546736 Part 2 - Set flag on docshell when devtools are watching it, r=ochameau.
Brian Hackett <bhackett1024@gmail.com> - Wed, 08 May 2019 09:28:53 -1000 - rev 474169
Push 36023 by ncsoregi@mozilla.com at Thu, 16 May 2019 21:56:43 +0000
Bug 1546736 Part 2 - Set flag on docshell when devtools are watching it, r=ochameau.
b8c66ae8e149ff7dd0be76a815ffb43060ba482a: Bug 1546513 - Closing the network panel with many entries takes multiple seconds r=ochameau
Jan Odvarko <odvarko@gmail.com> - Wed, 15 May 2019 08:59:29 +0000 - rev 473905
Push 36018 by rgurzau@mozilla.com at Wed, 15 May 2019 15:58:16 +0000
Bug 1546513 - Closing the network panel with many entries takes multiple seconds r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D31037
8a76118beb7bfd13c4d8e01514f7905c62285a1b: Bug 1551198 - Ensure project search DAMP test display UI r=ochameau
David Walsh <dwalsh@mozilla.com> - Tue, 14 May 2019 21:08:35 +0000 - rev 473867
Push 36017 by rgurzau@mozilla.com at Wed, 15 May 2019 09:25:56 +0000
Bug 1551198 - Ensure project search DAMP test display UI r=ochameau Adds two methods to make the UI display and close for search Differential Revision: https://phabricator.services.mozilla.com/D30916
dd5b92f8983514052be15d7f88a3dd0cfec9b892: Bug 1450284 - Complete method set in the Spec for Thread; r=jdescottes,ochameau
yulia <ystartsev@mozilla.com> - Mon, 13 May 2019 13:55:44 +0000 - rev 473617
Push 36007 by apavel@mozilla.com at Mon, 13 May 2019 21:45:52 +0000
Bug 1450284 - Complete method set in the Spec for Thread; r=jdescottes,ochameau We need a complete specification in order to move forward with the front conversion. I think this will also impact other parts of the refactoring, such as some of the thread specific code in the debugger-client. This is a first pass, I did not go into detail about the return types. Differential Revision: https://phabricator.services.mozilla.com/D28640
96e678846de742425e0f48cbea15bad6731160f4: bug 1551188: remote: print listening address similarly to chrome; r=remote-protocol-reviewers,ochameau
Andreas Tolfsen <ato@sny.no> - Mon, 13 May 2019 14:43:21 +0000 - rev 473605
Push 36007 by apavel@mozilla.com at Mon, 13 May 2019 21:45:52 +0000
bug 1551188: remote: print listening address similarly to chrome; r=remote-protocol-reviewers,ochameau Puppeteer parses stderr looking for the regular expression ^DevTools listening on (ws:\/\/.*)$. For Puppeteer to be able to connect to Firefox, we need to change the line we print slightly to conform with this expression. The remote agent also uses Log.jsm to print it, but we cannot rely on logging always being enabled, e.g. if remote.log.level is set to Warn or above. For this reason we should use dump(). The patch also instantiates the main target before starting the HTTPD. Differential Revision: https://phabricator.services.mozilla.com/D30913
8fa4f7a2ab42ff565a7839bd401273c195f52bd4: Bug 1543940 - Remove useTopLevelWindow option from DevTools menu/utils.js helper r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 08 May 2019 21:37:01 +0000 - rev 473136
Push 35988 by opoprus@mozilla.com at Thu, 09 May 2019 03:32:40 +0000
Bug 1543940 - Remove useTopLevelWindow option from DevTools menu/utils.js helper r=ochameau Depends on D27696 Differential Revision: https://phabricator.services.mozilla.com/D29887
6907e6f93141299a40d3824c8cd8de8b00dcc765: Bug 1543940 - Update tests to use toolbox.topDoc to query context-menu elements r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 08 May 2019 21:36:37 +0000 - rev 473135
Push 35988 by opoprus@mozilla.com at Thu, 09 May 2019 03:32:40 +0000
Bug 1543940 - Update tests to use toolbox.topDoc to query context-menu elements r=ochameau Depends on D27695 Differential Revision: https://phabricator.services.mozilla.com/D27696
a0768b78ff32581c457122430db68e11a0a5c479: Bug 1543940 - Use the toolbox top window for context menus r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 08 May 2019 21:36:04 +0000 - rev 473134
Push 35988 by opoprus@mozilla.com at Thu, 09 May 2019 03:32:40 +0000
Bug 1543940 - Use the toolbox top window for context menus r=ochameau Depends on D28036 If a context menu is opened in the toolbox document when running in a frame with type=content, keyboard navigation will not move to the context menu when it's opened. Differential Revision: https://phabricator.services.mozilla.com/D27695
388f61b1b134177011dcfe55f52faff072a50052: Bug 1543940 - menu.popup() should take a document argument instead of toolbox r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 08 May 2019 21:35:36 +0000 - rev 473133
Push 35988 by opoprus@mozilla.com at Thu, 09 May 2019 03:32:40 +0000
Bug 1543940 - menu.popup() should take a document argument instead of toolbox r=ochameau Depends on D27693 Menu::popup and popupAtZoom are expecting a toolbox argument as last argument. However, half of the callsites do not have access to the toolbox and just pass a { doc } object. This is misleading when trying to work on menu.js because you cannot rely on toolbox APIs. Differential Revision: https://phabricator.services.mozilla.com/D28036
0484e2e8f7fd170c14218dcf60c9c3983e1a8267: Bug 1543940 - Rely on chromeEventHandler for toolboxContextMenu events r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 08 May 2019 21:35:02 +0000 - rev 473132
Push 35988 by opoprus@mozilla.com at Thu, 09 May 2019 03:32:40 +0000
Bug 1543940 - Rely on chromeEventHandler for toolboxContextMenu events r=ochameau Using chromeEventHandler will allow us to catch events fired from any frame. By default when DevTools are in a type=chrome frame, events also bubble across frames. With type=content this is no longer the case. Differential Revision: https://phabricator.services.mozilla.com/D27693
590b72185b691bbb7a8cbf48e93373f1eecad035: Bug 1543940 - Remove useTopLevelWindow option from DevTools menu/utils.js helper r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 08 May 2019 15:15:22 +0000 - rev 473078
Push 35988 by opoprus@mozilla.com at Thu, 09 May 2019 03:32:40 +0000
Bug 1543940 - Remove useTopLevelWindow option from DevTools menu/utils.js helper r=ochameau Depends on D27696 Differential Revision: https://phabricator.services.mozilla.com/D29887
42e2136f684fd55780c7a8e63227c0bc64e4b6ef: Bug 1543940 - Update tests to use toolbox.topDoc to query context-menu elements r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 08 May 2019 15:14:54 +0000 - rev 473077
Push 35988 by opoprus@mozilla.com at Thu, 09 May 2019 03:32:40 +0000
Bug 1543940 - Update tests to use toolbox.topDoc to query context-menu elements r=ochameau Depends on D27695 Differential Revision: https://phabricator.services.mozilla.com/D27696
a66967f1704278ebfee2dfd560c2ccba84953395: Bug 1543940 - Use the toolbox top window for context menus r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 08 May 2019 15:14:05 +0000 - rev 473076
Push 35988 by opoprus@mozilla.com at Thu, 09 May 2019 03:32:40 +0000
Bug 1543940 - Use the toolbox top window for context menus r=ochameau Depends on D28036 If a context menu is opened in the toolbox document when running in a frame with type=content, keyboard navigation will not move to the context menu when it's opened. Differential Revision: https://phabricator.services.mozilla.com/D27695
b1e6e932873c26533fe57f4d87e4c99f45f4097b: Bug 1543940 - menu.popup() should take a document argument instead of toolbox r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 08 May 2019 15:13:40 +0000 - rev 473075
Push 35988 by opoprus@mozilla.com at Thu, 09 May 2019 03:32:40 +0000
Bug 1543940 - menu.popup() should take a document argument instead of toolbox r=ochameau Depends on D27693 Menu::popup and popupAtZoom are expecting a toolbox argument as last argument. However, half of the callsites do not have access to the toolbox and just pass a { doc } object. This is misleading when trying to work on menu.js because you cannot rely on toolbox APIs. Differential Revision: https://phabricator.services.mozilla.com/D28036
7fe9661e8510f9bf0430573aaceb7ed478e472b2: Bug 1543940 - Rely on chromeEventHandler for toolboxContextMenu events r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 08 May 2019 15:13:32 +0000 - rev 473074
Push 35988 by opoprus@mozilla.com at Thu, 09 May 2019 03:32:40 +0000
Bug 1543940 - Rely on chromeEventHandler for toolboxContextMenu events r=ochameau Using chromeEventHandler will allow us to catch events fired from any frame. By default when DevTools are in a type=chrome frame, events also bubble across frames. With type=content this is no longer the case. Differential Revision: https://phabricator.services.mozilla.com/D27693
20a54f437d518408622e82484c9b5a6997766dab: Bug 1541175 Part 3: Update test expectations. r=ochameau
Brad Werth <bwerth@mozilla.com> - Fri, 03 May 2019 23:06:54 +0000 - rev 472946
Push 35983 by ncsoregi@mozilla.com at Wed, 08 May 2019 03:38:51 +0000
Bug 1541175 Part 3: Update test expectations. r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D26614
2f85ada34acb9da79c83f9fb73b59f8d8d295a8d: Bug 1541175 Part 2: Force RDM UI to be at 100% zoom. r=pbro,ochameau
Brad Werth <bwerth@mozilla.com> - Mon, 06 May 2019 07:21:13 +0000 - rev 472945
Push 35983 by ncsoregi@mozilla.com at Wed, 08 May 2019 03:38:51 +0000
Bug 1541175 Part 2: Force RDM UI to be at 100% zoom. r=pbro,ochameau Once RDM is up-and-running, the Zoom UI will stay synchronized with the zoom level of the RDM content pane. These changes ensure that the RDM tools are forced to 100%, and then does a fixup to get the Zoom UI to match the RDM content pane zoom level again. Differential Revision: https://phabricator.services.mozilla.com/D26045
b377b5bdd883b97fedbfc61666edb780964c1f96: Bug 1541175 Part 1: Prevent fullZoom and textZoom from being remapped on RDM docshell swap. r=ochameau
Brad Werth <bwerth@mozilla.com> - Tue, 07 May 2019 17:59:36 +0000 - rev 472944
Push 35983 by ncsoregi@mozilla.com at Wed, 08 May 2019 03:38:51 +0000
Bug 1541175 Part 1: Prevent fullZoom and textZoom from being remapped on RDM docshell swap. r=ochameau There is no need to transfer these properties because the swap makes the outer browser act as if it is remote, and then the message manager tunnel ensures that the outer browser will get and set the zoom values from the inner browser. Differential Revision: https://phabricator.services.mozilla.com/D29911
ac9c08f90cd070b591211a51419b8e301470a911: Bug 1392408 Part 6 - Add test for capturing worker stacks in net monitor, r=ochameau.
Brian Hackett <bhackett1024@gmail.com> - Thu, 02 May 2019 08:35:50 -1000 - rev 472449
Push 35957 by dluca@mozilla.com at Fri, 03 May 2019 13:01:47 +0000
Bug 1392408 Part 6 - Add test for capturing worker stacks in net monitor, r=ochameau.
855b8dd227f92048824ff83ee46855f6f9bf010f: Bug 1392408 Part 5 - Listen for alternate stack traces in StackTraceCollector, r=ochameau.
Brian Hackett <bhackett1024@gmail.com> - Thu, 02 May 2019 08:35:34 -1000 - rev 472448
Push 35957 by dluca@mozilla.com at Fri, 03 May 2019 13:01:47 +0000
Bug 1392408 Part 5 - Listen for alternate stack traces in StackTraceCollector, r=ochameau.
92678c01ead789b2951fe1880c30d5251d2e5785: Bug 1494796 - Use promise pattern rather than callback pattern for threadClient methods; r=ochameau
yulia <ystartsev@mozilla.com> - Thu, 02 May 2019 15:39:20 +0000 - rev 472316
Push 35954 by rgurzau@mozilla.com at Fri, 03 May 2019 04:14:31 +0000
Bug 1494796 - Use promise pattern rather than callback pattern for threadClient methods; r=ochameau This is preparation for moving the threadClient to a front. Fronts do not support the callback style that clients have, they only support promises. As such, this patch migrates all instances of the threadClient using callback style methods to promises. I have cc'd the debugger team so that they are aware of this change and it doesn't take them by surprise. try run : https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=242251058&revision=dbd6cca9619ca0880e920d5b86fc6d6e0c728113 Differential Revision: https://phabricator.services.mozilla.com/D28966
a32ab60deb60961bfa7f5df95a93aa8c7976a4d2: Bug 1392408 Part 6 - Add test for capturing worker stacks in net monitor, r=ochameau.
Brian Hackett <bhackett1024@gmail.com> - Fri, 19 Apr 2019 07:34:51 -1000 - rev 472300
Push 35953 by rgurzau@mozilla.com at Thu, 02 May 2019 22:03:33 +0000
Bug 1392408 Part 6 - Add test for capturing worker stacks in net monitor, r=ochameau.
69cbc0afb1f17679877c442b1e9e4fe1ffabe07a: Bug 1392408 Part 5 - Listen for alternate stack traces in StackTraceCollector, r=ochameau.
Brian Hackett <bhackett1024@gmail.com> - Fri, 19 Apr 2019 07:25:52 -1000 - rev 472299
Push 35953 by rgurzau@mozilla.com at Thu, 02 May 2019 22:03:33 +0000
Bug 1392408 Part 5 - Listen for alternate stack traces in StackTraceCollector, r=ochameau.
05e9997b6809900677149992d3a5634ae43b3a11: Bug 1529247 - remove unused pausedLongString method, threadLongString and arrayBuffer methods; r=ochameau
yulia <ystartsev@mozilla.com> - Tue, 30 Apr 2019 14:44:23 +0000 - rev 471977
Push 35944 by ccoroiu@mozilla.com at Tue, 30 Apr 2019 21:53:37 +0000
Bug 1529247 - remove unused pausedLongString method, threadLongString and arrayBuffer methods; r=ochameau Finally! the goal of all of this: removing three functions from threadClient that really belong as part of source client. PauseLongString is never used except in tests. ThreadLongString is only ever used by sourceClient. Same goes for the arrayBuffer method. This clears all of that out. Differential Revision: https://phabricator.services.mozilla.com/D21715
78df5dc92c3f9a0c58043d625a3c93352135948f: Bug 1545021 - Convert ArrayBuffer to a Front and Protocoljs actor; r=ochameau,jdescottes
yulia <ystartsev@mozilla.com> - Tue, 30 Apr 2019 14:40:43 +0000 - rev 471976
Push 35944 by ccoroiu@mozilla.com at Tue, 30 Apr 2019 21:53:37 +0000
Bug 1545021 - Convert ArrayBuffer to a Front and Protocoljs actor; r=ochameau,jdescottes This introduces an ArrayBuffer front, so that we no longer need to go through the thread client to get an array buffer for the sourceFront (this is the only place it is used). It also converts the arrayBufferActor to a protocol.js actor. I was running into an issue between them. I need to double check what this issue was. If these two refactors need to be split, I can do that, but for now it looks like it wasn’t that large of a change. Differential Revision: https://phabricator.services.mozilla.com/D27878
542c3b51efa1deda9a07a1081d635150a0d8d45f: Bug 1544697 - use LongStringFront in SourceFront; r=ochameau,jdescottes
yulia <ystartsev@mozilla.com> - Tue, 30 Apr 2019 08:04:33 +0000 - rev 471975
Push 35944 by ccoroiu@mozilla.com at Tue, 30 Apr 2019 21:53:37 +0000
Bug 1544697 - use LongStringFront in SourceFront; r=ochameau,jdescottes This change does two things: it starts returning the longstring actor directly from the server. It also introduces a new type in the spec — sourcedata. This sourcedata can handle either a plain form (for array buffer) or it writes to and from a front. This is the major change. It could be the basis for writing a union type for protocol.js, which would do the same thing based on a list (ie — RetVal(“nullable:arraybuffer|nullable:longstring”)) This could be useful for getting handling the return value of createValueGrip (https://searchfox.org/mozilla-central/rev/f46e2bf881d522a440b30cbf5cf8d76fc212eaf4/devtools/server/actors/object/utils.js#75) This requires that this stack lands first: https://phabricator.services.mozilla.com/D27709 Differential Revision: https://phabricator.services.mozilla.com/D27877
d59b5153250dc33091def93327d1134164fadbbb: bug 1547679: remote: disable browser-chrome tests on asan; r=remote-protocol-reviewers,ochameau
Andreas Tolfsen <ato@sny.no> - Tue, 30 Apr 2019 10:00:35 +0000 - rev 471907
Push 35944 by ccoroiu@mozilla.com at Tue, 30 Apr 2019 21:53:37 +0000
bug 1547679: remote: disable browser-chrome tests on asan; r=remote-protocol-reviewers,ochameau We should also disable browser-chrome tests on ASan, as some of the leaks reported were caught by LeakSanitizer, which is run as part of AddressSanitizer. Follow-up from https://bugzilla.mozilla.org/show_bug.cgi?id=1547679#c3. Differential Revision: https://phabricator.services.mozilla.com/D29327
58ac3afa5e9a346fbc66396219f3d8be7f3b781d: bug 1547679: remote: disable all browser-chrome tests on debug; r=remote-protocol-reviewers,ochameau
Andreas Tolfsen <ato@sny.no> - Mon, 29 Apr 2019 12:50:15 +0000 - rev 471730
Push 35932 by csabou@mozilla.com at Mon, 29 Apr 2019 15:59:55 +0000
bug 1547679: remote: disable all browser-chrome tests on debug; r=remote-protocol-reviewers,ochameau Before landing the remote agent in Firefox Nightly, we had to disable remote/test/browser/browser_cdp.js because it caused a permafailure on debug due to a memory leak. We thought the problem was limited to this specific test, but over the weekend two more intermittent leaks were discovered: * https://bugzilla.mozilla.org/show_bug.cgi?id=1546850 * https://bugzilla.mozilla.org/show_bug.cgi?id=1547303 Until we have had time to investigate and plug the leak, we will disable all the browser-chrome tests on all debug platforms. Differential Revision: https://phabricator.services.mozilla.com/D29181
1b7dc4afb065cf062dbf29500b05991319052132: Bug 1544709 - Register global keyboard shortcuts on chromeEventHandler r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Fri, 26 Apr 2019 16:40:57 +0000 - rev 471600
Push 35921 by nbeleuzu@mozilla.com at Sat, 27 Apr 2019 09:45:52 +0000
Bug 1544709 - Register global keyboard shortcuts on chromeEventHandler r=ochameau Depends on D27686 Toolbox, zoom keys and inspector search should use the chromeeventhandler as event target. They need to capture events from inner frames. Differential Revision: https://phabricator.services.mozilla.com/D27688
fa356a2cccc627f97437fb183240dcd73704eb2e: Bug 1544709 - Use chromeEventHandler for splitConsole events r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Fri, 26 Apr 2019 15:45:33 +0000 - rev 471599
Push 35921 by nbeleuzu@mozilla.com at Sat, 27 Apr 2019 09:45:52 +0000
Bug 1544709 - Use chromeEventHandler for splitConsole events r=ochameau Depends on D27685 Differential Revision: https://phabricator.services.mozilla.com/D27686
4d4a1d1d3b7f6cca17d845616eb7a5f034e60347: Bug 1544709 - Move all shortcuts registration for toolbox in addShortcuts method r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Fri, 26 Apr 2019 15:43:33 +0000 - rev 471598
Push 35921 by nbeleuzu@mozilla.com at Sat, 27 Apr 2019 09:45:52 +0000
Bug 1544709 - Move all shortcuts registration for toolbox in addShortcuts method r=ochameau As we will move shortcuts to use chromeEventHandler as their target, we need an easy way to add and remove them on host switch. The chromeEventHandler will change when switching from window to docked hosts (and vice versa) Differential Revision: https://phabricator.services.mozilla.com/D27685
96682cfce65c88f4075349abf2aec0d766601dde: Bug 1544694 - move and rename SourceClient to SourceFront; r=ochameau,jdescottes
yulia <ystartsev@mozilla.com> - Fri, 26 Apr 2019 13:50:47 +0000 - rev 471480
Push 35920 by aiakab@mozilla.com at Fri, 26 Apr 2019 22:02:33 +0000
Bug 1544694 - move and rename SourceClient to SourceFront; r=ochameau,jdescottes Differential Revision: https://phabricator.services.mozilla.com/D27709
27e6d1a417e2e5b67996c0625868a147b051b7ab: Bug 1544694 - Convert Source Client to a Front; r=ochameau,jdescottes
yulia <ystartsev@mozilla.com> - Fri, 26 Apr 2019 12:51:07 +0000 - rev 471479
Push 35920 by aiakab@mozilla.com at Fri, 26 Apr 2019 22:02:33 +0000
Bug 1544694 - Convert Source Client to a Front; r=ochameau,jdescottes Differential Revision: https://phabricator.services.mozilla.com/D27708
9c36551d262a0581a34d7a450bd2284d76f3e8cf: Bug 1544694 - remove unused client getters 'request' and '_transport' from sourceClient; r=ochameau,jdescottes
yulia <ystartsev@mozilla.com> - Fri, 26 Apr 2019 12:43:45 +0000 - rev 471478
Push 35920 by aiakab@mozilla.com at Fri, 26 Apr 2019 22:02:33 +0000
Bug 1544694 - remove unused client getters 'request' and '_transport' from sourceClient; r=ochameau,jdescottes Differential Revision: https://phabricator.services.mozilla.com/D27707
868b1bf043dc9d8f622e4ff0a56031da5aa5429d: bug 1546945: remote: re-enable remote agent in Firefox Nightly; r=ochameau
Andreas Tolfsen <ato@sny.no> - Thu, 25 Apr 2019 18:03:12 +0000 - rev 471378
Push 35916 by rmaries@mozilla.com at Fri, 26 Apr 2019 09:46:15 +0000
bug 1546945: remote: re-enable remote agent in Firefox Nightly; r=ochameau This patch negates the effect of 004d050a8ec4 (git 6dd9496ac0f9). Differential Revision: https://phabricator.services.mozilla.com/D28873
f04e1e9c54aaf387c1ee748cd59328bee2bbd687: bug 1546945: remote: disable browser_cdp.js browser-chrome test on debug; r=ochameau
Andreas Tolfsen <ato@sny.no> - Thu, 25 Apr 2019 18:27:05 +0000 - rev 471377
Push 35916 by rmaries@mozilla.com at Fri, 26 Apr 2019 09:46:15 +0000
bug 1546945: remote: disable browser_cdp.js browser-chrome test on debug; r=ochameau As detailed in https://bugzilla.mozilla.org/show_bug.cgi?id=1546945, there is a memory leak in the remote agent that is triggered by code paths in the remote/test/browser/browser_cdp.js browser-chrome test. It is possible the memory leak is related to holding onto a reference of the XPConnect C++ object nsSocketTransportService, but this has yet to be confirmed. This patch disables the test in question on debug builds, where we run reference counting leakchecks, in order to get the remote agent enabled in default Firefox Nightly builds. Thanks-to: Alexandre Poirot <poirot.alex@gmail.com> Differential Revision: https://phabricator.services.mozilla.com/D28872
635e8833ed5fe4aba5d86721cdd57251f5e471cc: bug 1546714: remote: fix bug component mapping for remote/targets/; r=ochameau
Andreas Tolfsen <ato@sny.no> - Thu, 25 Apr 2019 13:49:57 +0000 - rev 471321
Push 35915 by opoprus@mozilla.com at Thu, 25 Apr 2019 22:08:17 +0000
bug 1546714: remote: fix bug component mapping for remote/targets/; r=ochameau There are two concepts of targets in CDP: the target web document, and the Target domain. The remote/targets/ subfolder is related to the first, which should have bugs filed under Remote Protocol :: Agent, covered by the preceding rule. DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D28689