searching for reviewer(nchevobbe)
78d987be12f9d0bdb9776906b23af8761f6be5d1: Bug 1775058 - [devtools] Functionality to disable webconsole messages r=nchevobbe
Hubert Boma Manilla <hmanilla@mozilla.com> - Mon, 04 Jul 2022 17:18:50 +0000 - rev 622937
Push 39935 by ctuns@mozilla.com at Mon, 04 Jul 2022 21:42:52 +0000
Bug 1775058 - [devtools] Functionality to disable webconsole messages r=nchevobbe This introduces functionality to support disabling weconsole messages. Also introduces code to disable all network messages, which would be used by the netmonitor. You'll probably need the fullstack of patches to test easily Will add mochitest in a followup Differential Revision: https://phabricator.services.mozilla.com/D149753
698a0d887bfac208434ffece1c3f73f0db2fdcd5: Bug 1775058 - [devtools] Add support for custom titles to MessageIcon r=nchevobbe
Hubert Boma Manilla <hmanilla@mozilla.com> - Mon, 04 Jul 2022 17:18:49 +0000 - rev 622936
Push 39935 by ctuns@mozilla.com at Mon, 04 Jul 2022 21:42:52 +0000
Bug 1775058 - [devtools] Add support for custom titles to MessageIcon r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D150474
bc16e1023d45a2d1edd0f8b84c1c38b0aed6582c: Bug 1777829 - Fix DevTools stub generator. r=devtools-reviewers,nchevobbe
Tooru Fujisawa <arai_a@mac.com> - Mon, 04 Jul 2022 10:33:41 +0000 - rev 622917
Push 39935 by ctuns@mozilla.com at Mon, 04 Jul 2022 21:42:52 +0000
Bug 1777829 - Fix DevTools stub generator. r=devtools-reviewers,nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D150885
e580dab63309bdb2bd901397b32ae65894ca6901: Bug 1777924 - [devtools] Use legacy wrapper in update_remote_settings_records.mjs for forward compatibility with Node 16+ r=nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Mon, 04 Jul 2022 09:43:11 +0000 - rev 622911
Push 39935 by ctuns@mozilla.com at Mon, 04 Jul 2022 21:42:52 +0000
Bug 1777924 - [devtools] Use legacy wrapper in update_remote_settings_records.mjs for forward compatibility with Node 16+ r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D150939
8ed909886b3e43f2e709949593c2b26bdc5a32a1: Bug 1583910 - New inactive CSS rule to show warning when border-image is made inactive by border-collapse. r=nchevobbe,fluent-reviewers,flod
Raphael Ferrand <raphael.ferrand@yara.com> - Mon, 04 Jul 2022 07:59:23 +0000 - rev 622875
Push 39935 by ctuns@mozilla.com at Mon, 04 Jul 2022 21:42:52 +0000
Bug 1583910 - New inactive CSS rule to show warning when border-image is made inactive by border-collapse. r=nchevobbe,fluent-reviewers,flod Differential Revision: https://phabricator.services.mozilla.com/D147205
a3bc429f351d43f5599e890db0ab918d7f3014d0: Bug 1767684 - [devtools] Skip browser_rules_cycle-angle.js on linux r=devtools-reviewers,nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Mon, 04 Jul 2022 06:30:51 +0000 - rev 622873
Push 39935 by ctuns@mozilla.com at Mon, 04 Jul 2022 21:42:52 +0000
Bug 1767684 - [devtools] Skip browser_rules_cycle-angle.js on linux r=devtools-reviewers,nchevobbe I checked that skipping the test does not move the intermittent to the next test. I am not sure what makes this test problematic, I suppose this has to do with initializing widgets in the inspector to handler filters. Let's skip this on linux for now. Differential Revision: https://phabricator.services.mozilla.com/D150859
69a6f5c01627356149f460a2ec7c45d63ad5a021: Bug 1777205 - [devtools] Ensure displaying worker sources loaded via relative URLs. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 30 Jun 2022 18:31:38 +0000 - rev 622757
Push 39921 by smolnar@mozilla.com at Fri, 01 Jul 2022 04:18:35 +0000
Bug 1777205 - [devtools] Ensure displaying worker sources loaded via relative URLs. r=nchevobbe Note that I'm not sure the bug is so common. The test involved here use a very old deprecated codepath, where we spawn a toolbox for a given worker. Nowadays we only support that for service workers. I had to tweak a couple of tests in order to acknowledge that the worker url could be absolute URL now (instead of only a file name). Differential Revision: https://phabricator.services.mozilla.com/D150543
f37fd9ea18f7f486117c648de1f65dfa4b85268a: Bug 1772847 - [devtools] Enable devtools.responsive.showUserAgentInput on all channels r=devtools-reviewers,nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Tue, 28 Jun 2022 12:56:25 +0000 - rev 622326
Push 39912 by mlaza@mozilla.com at Wed, 29 Jun 2022 03:44:30 +0000
Bug 1772847 - [devtools] Enable devtools.responsive.showUserAgentInput on all channels r=devtools-reviewers,nchevobbe This preference drives the "Show user agent" feature accessible from the RDM options. Flipping it to true will make the User agent input visible on all channels by default, but the feature itself was already available everywhere. You just had to first select "Show user agent" in devedition/beta/release to show the input. I think the feature is useful enough to enable it by default. Also we run all our tests with the preference forced to true. Differential Revision: https://phabricator.services.mozilla.com/D150455
b38dd3b5ddee21ec58eddbe070643b1277bb9e09: Bug 1774687 - Stop debouncing with DeferredTask in DevTools r=devtools-reviewers,nchevobbe
Michael Ratcliffe <mratcliffe@mozilla.com> - Wed, 22 Jun 2022 21:15:12 +0000 - rev 621826
Push 39885 by nfay@mozilla.com at Thu, 23 Jun 2022 03:54:50 +0000
Bug 1774687 - Stop debouncing with DeferredTask in DevTools r=devtools-reviewers,nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D149575
c02f4c8572182a3d0cae73bb41b82fb5ad5e890d: Bug 1767787 - [devtools] Wait until default editor has focus in browser_styleeditor_bug_851132_middle_click.js r=nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Wed, 22 Jun 2022 07:20:06 +0000 - rev 621653
Push 39883 by ctuns@mozilla.com at Wed, 22 Jun 2022 16:10:22 +0000
Bug 1767787 - [devtools] Wait until default editor has focus in browser_styleeditor_bug_851132_middle_click.js r=nchevobbe I could reproduce the intermittent locally and when it occurs, the initial editor actually didn't have focus. I think that what happens is that we hit a race condition where the focus is stolen by the initial editor after we clicked on a new stylesheet and switched to a new editor. Differential Revision: https://phabricator.services.mozilla.com/D149952
b22029c96f670c2a187682a280191f399c5de4d3: Bug 1768494 - Preserve devtools profile outside of ephemeral background profile. r=devtools-reviewers,nchevobbe
Nick Alexander <nalexander@mozilla.com> - Wed, 22 Jun 2022 04:05:26 +0000 - rev 621644
Push 39882 by bszekely@mozilla.com at Wed, 22 Jun 2022 09:43:42 +0000
Bug 1768494 - Preserve devtools profile outside of ephemeral background profile. r=devtools-reviewers,nchevobbe For `--backgroundtask ... --jsdebugger` invocations, the devtools profile is kept inside the ephemeral background profile. This means that breakpoints, etc are not preserved across repeated debugging invocations. This change eases the debugging process. Differential Revision: https://phabricator.services.mozilla.com/D145893
e86098a5b60d9a3d790676cf936fc605279a11e8: Bug 1583179 - [devtools] Remove the reload and analyze performance buttons in the browser toolbox r=nchevobbe
Hubert Boma Manilla <hmanilla@mozilla.com> - Tue, 21 Jun 2022 15:15:49 +0000 - rev 621579
Push 39880 by ccozmuta@mozilla.com at Wed, 22 Jun 2022 03:32:25 +0000
Bug 1583179 - [devtools] Remove the reload and analyze performance buttons in the browser toolbox r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D149610
0c6d39a1c5d119771af7cb45dfc03f01442bb476: Bug 1770363 - [devtools] Fix iframe dropdown on target destruction from the MBT r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 20 Jun 2022 10:12:32 +0000 - rev 621417
Push 39874 by csabou@mozilla.com at Mon, 20 Jun 2022 21:49:56 +0000
Bug 1770363 - [devtools] Fix iframe dropdown on target destruction from the MBT r=nchevobbe This only fail on MBT because it still uses non-EFT and the top level document is displayed in the iframe dropdown via the old "listFrames/frameUpdate" codepath. So that its frameData's id isn't related to a target actor but rather to a frame of the parent-process/window-global target actor... I'm adding test coverage for the regular web toolbox, but the fix only reproduce in the context of the browser toolbox. Depends on D149257 Differential Revision: https://phabricator.services.mozilla.com/D148793
f064334afbb9fec6e0d3c88e4fca2a348c94a88c: Bug 1770363 - [devtools] Cover browser toolbox scope feature with a test around the iframe dropdown. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 20 Jun 2022 10:12:32 +0000 - rev 621416
Push 39874 by csabou@mozilla.com at Mon, 20 Jun 2022 21:49:56 +0000
Bug 1770363 - [devtools] Cover browser toolbox scope feature with a test around the iframe dropdown. r=nchevobbe This add some minimal test coverage for the UI bits. But more detailed test should rather be done around the TargetCommand API (browser_target_command_scope_flag.js). Depends on D149256 Differential Revision: https://phabricator.services.mozilla.com/D149257
de1150e010e73872598562f7bb665c6d1a0b0479: Bug 1770363 - [devtools] Allow to pass any JSON value to ToolboxTask.spawn. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 20 Jun 2022 10:12:31 +0000 - rev 621415
Push 39874 by csabou@mozilla.com at Mon, 20 Jun 2022 21:49:56 +0000
Bug 1770363 - [devtools] Allow to pass any JSON value to ToolboxTask.spawn. r=nchevobbe When passing an array, only booleans and number were accepted. Also arrays were stringified to list of value coma separated, as if arrays were refering to list of arguments. That while passing a primitive value would be passed as a unique argument. Clarify this by explicitely accepting arrays refering as list of argument, or a primitive value being a unique argument. I'm also fixing an issue with exceptions not being correctly reported. Depends on D148527 Differential Revision: https://phabricator.services.mozilla.com/D149256
d3db0ae3be2e4f9c65e3f501450c45aee51ee17f: Bug 1770363 - [devtools] Introduce on-demand multiprocess browser toolbox. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 20 Jun 2022 10:12:31 +0000 - rev 621414
Push 39874 by csabou@mozilla.com at Mon, 20 Jun 2022 21:49:56 +0000
Bug 1770363 - [devtools] Introduce on-demand multiprocess browser toolbox. r=nchevobbe This introduces a checkbox in the iframe dropdown to enable/disable multiprocess debugging live. Switching between: - debugging only the main process (all documents, workers and priviledged JS) - debugging all the processes (same, for each process, we will debug documents, workers, JS, ...) This helps significantly speed up the browser toolbox when debugging only parent process resources, while still allowing to switch to debug everything when required. Depends on D146891 Differential Revision: https://phabricator.services.mozilla.com/D148527
7c409831fd659c18ea8451cb1df6d1db2fbe7e4b: Bug 1770363 - [devtools] Implement on-demand multiprocess debugging in TargetCommand API. r=nchevobbe,rpl
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 20 Jun 2022 10:12:30 +0000 - rev 621413
Push 39874 by csabou@mozilla.com at Mon, 20 Jun 2022 21:49:56 +0000
Bug 1770363 - [devtools] Implement on-demand multiprocess debugging in TargetCommand API. r=nchevobbe,rpl This new feature will only work in the "MBT", when devtools.browsertoolbox.fission is true. It is based on yet another preference, devtools.browsertoolbox.scope, which is meant to be toggle by DevTools UI only (see next patches). When the new pref is set to "everything", we will observe FRAME and PROCESS targets and so debug everything running in content processes. But when it is set to "parent-process", we will only observe WORKER and be restricted to parent process resources only. Differential Revision: https://phabricator.services.mozilla.com/D146891
91b52e45081624f8799ed6a7db5ff422a4cd9ebc: Bug 1774913 - [devtools] Enable devtools tests depending on emptyClipboard r=nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Mon, 20 Jun 2022 06:03:37 +0000 - rev 621400
Push 39874 by csabou@mozilla.com at Mon, 20 Jun 2022 21:49:56 +0000
Bug 1774913 - [devtools] Enable devtools tests depending on emptyClipboard r=nchevobbe After Bug 666254 was fixed, we should be able to run those checks on all platforms Differential Revision: https://phabricator.services.mozilla.com/D149689
de8b150f349479f66dac66f8d539f1ac7b41304a: Bug 1590031 - [devtools] Compute CSS changes based on actual values applied by the engine r=nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Fri, 17 Jun 2022 17:21:22 +0000 - rev 621310
Push 39865 by smolnar@mozilla.com at Sat, 18 Jun 2022 09:30:37 +0000
Bug 1590031 - [devtools] Compute CSS changes based on actual values applied by the engine r=nchevobbe Delay computing the CSS changes until the declarations have been updated to reflect the values understood by the engine. This avoids trusting authored values for CSS changes, and fixes all scenarios where users typed an opening character (single quote, double quote etc...) or an escape character. Differential Revision: https://phabricator.services.mozilla.com/D149603
b0323f813b8788ed211830c87f2fbf303ae1f78a: Bug 1772718 - Reduce mozilla/reject-scriptableunicodeconverter eslint warnings in DevTools code r=nchevobbe
Michael Ratcliffe <mratcliffe@mozilla.com> - Thu, 16 Jun 2022 18:24:17 +0000 - rev 621186
Push 39861 by nfay@mozilla.com at Fri, 17 Jun 2022 09:39:07 +0000
Bug 1772718 - Reduce mozilla/reject-scriptableunicodeconverter eslint warnings in DevTools code r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D148346
d29f5041fd98c488e7a1f0ba5ba66410c2702aaf: Bug 1770363 - [devtools] Fix iframe dropdown on target destruction from the MBT r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 16 Jun 2022 17:19:07 +0000 - rev 621175
Push 39861 by nfay@mozilla.com at Fri, 17 Jun 2022 09:39:07 +0000
Bug 1770363 - [devtools] Fix iframe dropdown on target destruction from the MBT r=nchevobbe This only fail on MBT because it still uses non-EFT and the top level document is displayed in the iframe dropdown via the old "listFrames/frameUpdate" codepath. So that its frameData's id isn't related to a target actor but rather to a frame of the parent-process/window-global target actor... I'm adding test coverage for the regular web toolbox, but the fix only reproduce in the context of the browser toolbox. Differential Revision: https://phabricator.services.mozilla.com/D148793
a91879be9b4a5e1740c3cd88a77746b57caa2bf5: Bug 1770363 - [devtools] Cover browser toolbox scope feature with a test around the iframe dropdown. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 16 Jun 2022 17:19:06 +0000 - rev 621174
Push 39861 by nfay@mozilla.com at Fri, 17 Jun 2022 09:39:07 +0000
Bug 1770363 - [devtools] Cover browser toolbox scope feature with a test around the iframe dropdown. r=nchevobbe This add some minimal test coverage for the UI bits. But more detailed test should rather be done around the TargetCommand API (browser_target_command_scope_flag.js). Differential Revision: https://phabricator.services.mozilla.com/D149257
27e78762006f00f3b42f46b707435873d1d4c3ab: Bug 1770363 - [devtools] Allow to pass any JSON value to ToolboxTask.spawn. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 16 Jun 2022 17:19:06 +0000 - rev 621173
Push 39861 by nfay@mozilla.com at Fri, 17 Jun 2022 09:39:07 +0000
Bug 1770363 - [devtools] Allow to pass any JSON value to ToolboxTask.spawn. r=nchevobbe When passing an array, only booleans and number were accepted. Also arrays were stringified to list of value coma separated, as if arrays were refering to list of arguments. That while passing a primitive value would be passed as a unique argument. Clarify this by explicitely accepting arrays refering as list of argument, or a primitive value being a unique argument. I'm also fixing an issue with exceptions not being correctly reported. Differential Revision: https://phabricator.services.mozilla.com/D149256
18a6433fd24ac5b208f9238e8da39106a07cc12d: Bug 1770363 - [devtools] Introduce on-demand multiprocess browser toolbox. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 16 Jun 2022 17:19:06 +0000 - rev 621172
Push 39861 by nfay@mozilla.com at Fri, 17 Jun 2022 09:39:07 +0000
Bug 1770363 - [devtools] Introduce on-demand multiprocess browser toolbox. r=nchevobbe This introduces a checkbox in the iframe dropdown to enable/disable multiprocess debugging live. Switching between: - debugging only the main process (all documents, workers and priviledged JS) - debugging all the processes (same, for each process, we will debug documents, workers, JS, ...) This helps significantly speed up the browser toolbox when debugging only parent process resources, while still allowing to switch to debug everything when required. Differential Revision: https://phabricator.services.mozilla.com/D148527
5cdcd2318a9f5879144a6be578a53fc65bb4e6d1: Bug 1770363 - [devtools] Implement on-demand multiprocess debugging in TargetCommand API. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 16 Jun 2022 17:19:05 +0000 - rev 621171
Push 39861 by nfay@mozilla.com at Fri, 17 Jun 2022 09:39:07 +0000
Bug 1770363 - [devtools] Implement on-demand multiprocess debugging in TargetCommand API. r=nchevobbe This new feature will only work in the "MBT", when devtools.browsertoolbox.fission is true. It is based on yet another preference, devtools.browsertoolbox.scope, which is meant to be toggle by DevTools UI only (see next patches). When the new pref is set to "everything", we will observe FRAME and PROCESS targets and so debug everything running in content processes. But when it is set to "parent-process", we will only observe WORKER and be restricted to parent process resources only. Differential Revision: https://phabricator.services.mozilla.com/D146891
569f2357ff4ecedc2fe28501dcf36375990cecff: Bug 1508688 - Enable 'react/no-deprecated' ESLint rule for devtools/. r=devtools-reviewers,nchevobbe
Tetsuharu Ohzeki <tetsuharu.ohzeki@gmail.com> - Thu, 16 Jun 2022 10:03:12 +0000 - rev 621115
Push 39861 by nfay@mozilla.com at Fri, 17 Jun 2022 09:39:07 +0000
Bug 1508688 - Enable 'react/no-deprecated' ESLint rule for devtools/. r=devtools-reviewers,nchevobbe This enables https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/no-deprecated.md Differential Revision: https://phabricator.services.mozilla.com/D149485
b33c102a1d59f763f131c0580b79feb6423913bd: Bug 1508688 - Add `UNSAFE_` prefix to React deprecated lifecycle methods in devtools/client/webconsole/. r=devtools-reviewers,nchevobbe
Tetsuharu Ohzeki <tetsuharu.ohzeki@gmail.com> - Thu, 16 Jun 2022 10:03:11 +0000 - rev 621114
Push 39861 by nfay@mozilla.com at Fri, 17 Jun 2022 09:39:07 +0000
Bug 1508688 - Add `UNSAFE_` prefix to React deprecated lifecycle methods in devtools/client/webconsole/. r=devtools-reviewers,nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D149484
d0d38a13dd1db8a3ca821878b25a453c8ce32424: Bug 1508688 - Add `UNSAFE_` prefix to React deprecated lifecycle methods in devtools/client/shared/. r=devtools-reviewers,nchevobbe
Tetsuharu Ohzeki <tetsuharu.ohzeki@gmail.com> - Thu, 16 Jun 2022 10:03:11 +0000 - rev 621113
Push 39861 by nfay@mozilla.com at Fri, 17 Jun 2022 09:39:07 +0000
Bug 1508688 - Add `UNSAFE_` prefix to React deprecated lifecycle methods in devtools/client/shared/. r=devtools-reviewers,nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D149483
9e180a5e537eee4d893d4283d8013f352e65b9fc: Bug 1508688 - Add `UNSAFE_` prefix to React deprecated lifecycle methods in devtools/client/responsive/. r=devtools-reviewers,nchevobbe
Tetsuharu Ohzeki <tetsuharu.ohzeki@gmail.com> - Thu, 16 Jun 2022 10:03:11 +0000 - rev 621112
Push 39861 by nfay@mozilla.com at Fri, 17 Jun 2022 09:39:07 +0000
Bug 1508688 - Add `UNSAFE_` prefix to React deprecated lifecycle methods in devtools/client/responsive/. r=devtools-reviewers,nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D149482
2edcfb56a5b35082d0375913ba0b71c04529db53: Bug 1508688 - Add `UNSAFE_` prefix to React deprecated lifecycle methods in devtools/client/netmonitor/. r=devtools-reviewers,nchevobbe
Tetsuharu Ohzeki <tetsuharu.ohzeki@gmail.com> - Thu, 16 Jun 2022 10:03:10 +0000 - rev 621111
Push 39861 by nfay@mozilla.com at Fri, 17 Jun 2022 09:39:07 +0000
Bug 1508688 - Add `UNSAFE_` prefix to React deprecated lifecycle methods in devtools/client/netmonitor/. r=devtools-reviewers,nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D149481
c60b6b4b8e0502669191458fd5bae0f0519fd111: Bug 1508688 - Add `UNSAFE_` prefix to React deprecated lifecycle methods in devtools/client/inspector/. r=devtools-reviewers,nchevobbe
Tetsuharu Ohzeki <tetsuharu.ohzeki@gmail.com> - Thu, 16 Jun 2022 10:03:10 +0000 - rev 621110
Push 39861 by nfay@mozilla.com at Fri, 17 Jun 2022 09:39:07 +0000
Bug 1508688 - Add `UNSAFE_` prefix to React deprecated lifecycle methods in devtools/client/inspector/. r=devtools-reviewers,nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D149480
0696b251d05b1cc24df7ff6381577b79e936dede: Bug 1508688 - Add `UNSAFE_` prefix to React deprecated lifecycle methods in devtools/client/framework/. r=devtools-reviewers,nchevobbe
Tetsuharu Ohzeki <tetsuharu.ohzeki@gmail.com> - Thu, 16 Jun 2022 10:03:09 +0000 - rev 621109
Push 39861 by nfay@mozilla.com at Fri, 17 Jun 2022 09:39:07 +0000
Bug 1508688 - Add `UNSAFE_` prefix to React deprecated lifecycle methods in devtools/client/framework/. r=devtools-reviewers,nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D149479
e4d4b5d9796451f31c6f1fa4b7ce85f5abb91962: Bug 1508688 - Add `UNSAFE_` prefix to React deprecated lifecycle methods in devtools/client/debugger/. r=devtools-reviewers,nchevobbe
Tetsuharu Ohzeki <tetsuharu.ohzeki@gmail.com> - Thu, 16 Jun 2022 10:03:09 +0000 - rev 621108
Push 39861 by nfay@mozilla.com at Fri, 17 Jun 2022 09:39:07 +0000
Bug 1508688 - Add `UNSAFE_` prefix to React deprecated lifecycle methods in devtools/client/debugger/. r=devtools-reviewers,nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D149478
0e9065aceda944cdb5eb9d06e5acb514992665c4: Bug 1508688 - Add `UNSAFE_` prefix to React deprecated lifecycle methods in devtools/client/accessibility/. r=devtools-reviewers,nchevobbe
Tetsuharu Ohzeki <tetsuharu.ohzeki@gmail.com> - Thu, 16 Jun 2022 10:03:09 +0000 - rev 621107
Push 39861 by nfay@mozilla.com at Fri, 17 Jun 2022 09:39:07 +0000
Bug 1508688 - Add `UNSAFE_` prefix to React deprecated lifecycle methods in devtools/client/accessibility/. r=devtools-reviewers,nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D149477
b55d74e32d805ac944c2030ee226a9ffb3e5beb8: Bug 1508688 - Add `UNSAFE_` prefix to React deprecated lifecycle methods in devtools/client/aboutdebugging/. r=devtools-reviewers,nchevobbe
Tetsuharu Ohzeki <tetsuharu.ohzeki@gmail.com> - Thu, 16 Jun 2022 10:03:08 +0000 - rev 621106
Push 39861 by nfay@mozilla.com at Fri, 17 Jun 2022 09:39:07 +0000
Bug 1508688 - Add `UNSAFE_` prefix to React deprecated lifecycle methods in devtools/client/aboutdebugging/. r=devtools-reviewers,nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D149476
57c458e03d13d47fb60d54fb4b3e0cb9ed683b52: Bug 1508688 - Add 'UNSAFE_' lifecycle methods to 'react/sort-comp' rule for devtools/. r=devtools-reviewers,nchevobbe
Tetsuharu Ohzeki <tetsuharu.ohzeki@gmail.com> - Thu, 16 Jun 2022 10:03:08 +0000 - rev 621105
Push 39861 by nfay@mozilla.com at Fri, 17 Jun 2022 09:39:07 +0000
Bug 1508688 - Add 'UNSAFE_' lifecycle methods to 'react/sort-comp' rule for devtools/. r=devtools-reviewers,nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D149475
e033ff580f53f8745f8ef4941dbb2a50d8ef745d: Bug 1773882 - Part 2: Add more testcase. r=nchevobbe
Tooru Fujisawa <arai_a@mac.com> - Wed, 15 Jun 2022 05:36:10 +0000 - rev 620928
Push 39854 by imoraru@mozilla.com at Wed, 15 Jun 2022 15:46:59 +0000
Bug 1773882 - Part 2: Add more testcase. r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D149213
0646b8bb3ec5f7a7119bdbff631de569d1d509a9: Bug 1773882 - Show getter/setter in array element. r=nchevobbe
Tooru Fujisawa <arai_a@mac.com> - Wed, 15 Jun 2022 05:36:10 +0000 - rev 620927
Push 39854 by imoraru@mozilla.com at Wed, 15 Jun 2022 15:46:59 +0000
Bug 1773882 - Show getter/setter in array element. r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D149042
786400ce2e54b7c791e0d21c40b93b1431ab91be: Bug 1772905 - Update DevTools DOM panel tests that fails if InstallTrigger is not listed anymore as a window global. r=nchevobbe
Luca Greco <lgreco@mozilla.com> - Tue, 14 Jun 2022 19:29:06 +0000 - rev 620905
Push 39851 by nerli@mozilla.com at Wed, 15 Jun 2022 03:55:43 +0000
Bug 1772905 - Update DevTools DOM panel tests that fails if InstallTrigger is not listed anymore as a window global. r=nchevobbe These two DevTools DOM panel tests are expecting the elements being inspected to be at a certain row index which depends (likely due to alphabetic order) that InstallTrigger is listed as a global in the window being inspected (it doesn't matter what the value is, the failure is triggered because when InstallTrigger is completely hidden the elements expected by the tests are shift by one row position). And so these two tests would be currently permafailing when "extensions.InstallTrigger.enabled" is set to `false` (but they are completely uneffected when "extensions.InstallTriggerImpl.enabled" is set to `false`, because the InstallTrigger global is still defined, just set to null instead of providing the API defined by the InstallTriggerImpl interface). This patch changes name of the global properties to which they are set to "A" and "B", to make sure those properties are going to be in rows listed in the DOM panel before the two non-standard globals `InstallTrigger` and `SpecialPowers` and so that the visibility of the InstallTrigger global (either disabled or still visible) doesn't affect the test case. Differential Revision: https://phabricator.services.mozilla.com/D148975
d8d49ed79fa62a1ffea1d2fd12d6a2ed1776d601: Bug 1773340 - [devtools] Ensure destroying TargetCommand when destroying commands object. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 13 Jun 2022 09:00:03 +0000 - rev 620638
Push 39841 by ctuns@mozilla.com at Mon, 13 Jun 2022 15:12:39 +0000
Bug 1773340 - [devtools] Ensure destroying TargetCommand when destroying commands object. r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D148673
20fcac3d2b62a91cd722984d561954b05bd0d31d: Bug 1685949 - [devtools] Fix perma fail on browser_console_context_menu_entries.js r=nchevobbe
Hubert Boma Manilla <hmanilla@mozilla.com> - Thu, 09 Jun 2022 13:54:14 +0000 - rev 620300
Push 39824 by smolnar@mozilla.com at Thu, 09 Jun 2022 22:00:48 +0000
Bug 1685949 - [devtools] Fix perma fail on browser_console_context_menu_entries.js r=nchevobbe Since Network monitoring is switched of by default in the browser console, we need to switch it on explicitly for the browser_console_context_menu_entries.js test. Differential Revision: https://phabricator.services.mozilla.com/D148776
1362c690f9d03061202db52df17c227005b3d851: Bug 1604562 - [devtools] Add mochitest for CORS request issue from DevTools style update r=emilio,nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Wed, 08 Jun 2022 21:36:09 +0000 - rev 620190
Push 39820 by mlaza@mozilla.com at Thu, 09 Jun 2022 03:45:01 +0000
Bug 1604562 - [devtools] Add mochitest for CORS request issue from DevTools style update r=emilio,nchevobbe Depends on D148396 Differential Revision: https://phabricator.services.mozilla.com/D148657
f46a69b06fc27af22338d655732dd637fb9e2053: Bug 1773018 - [devtools] Fix PERMA failure on BETA by enabling MBT r=nchevobbe
Hubert Boma Manilla <hmanilla@mozilla.com> - Wed, 08 Jun 2022 19:26:21 +0000 - rev 620164
Push 39819 by nbeleuzu@mozilla.com at Wed, 08 Jun 2022 21:48:24 +0000
Bug 1773018 - [devtools] Fix PERMA failure on BETA by enabling MBT r=nchevobbe We get multiple network stacktrace event resources for a specific network event, the second is unneccecary and does not have a `cause` object. So let's ignore the second one. Also there is no way to destroy legacy-listeners so each time unwatchResources/watchResources we create a new instance of the legacy listener for the resource type, this also has issues. Talked with Alex and since we moving towards enabling MBT on release and getting rid of the legacy listeners, it ok to enable MBT for the tests. Differential Revision: https://phabricator.services.mozilla.com/D148507
fdbc7a65f87df60eb27827f82b7ee66d4fdd2ba3: Bug 1773155 - Ensure highlighter iframe for parent process is transparent. r=nchevobbe
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 08 Jun 2022 11:14:19 +0000 - rev 620084
Push 39819 by nbeleuzu@mozilla.com at Wed, 08 Jun 2022 21:48:24 +0000
Bug 1773155 - Ensure highlighter iframe for parent process is transparent. r=nchevobbe By ensuring that it has color-scheme: light in both the embedder and the embedded page. Usually only the outer styling is necessary, but we generally assume that chrome pages follow the OS color-scheme, so we need to make sure both are set as light. This might be able to go away depending on the resolution of https://github.com/mozilla/wg-decisions/issues/774 Differential Revision: https://phabricator.services.mozilla.com/D148585
ff27d6ba3491ede0585035caf9997c1a5f3eedf2: Bug 1773037 - [devtools] Disable safe mode and session restore in the browser toolbox. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 08 Jun 2022 08:25:27 +0000 - rev 620070
Push 39817 by smolnar@mozilla.com at Wed, 08 Jun 2022 16:01:29 +0000
Bug 1773037 - [devtools] Disable safe mode and session restore in the browser toolbox. r=nchevobbe The safe mode dialog will be displayed instead of the browser toolbox when the previous browser toolbox has been closed too brutaly. This happens every now and then. Also, when you opened a URL from the browser toolbox, this will then trigger a transient browser window that appears and immediately disappear when opening the browser toolbox all next time you start it. It might be related to session restore, but it looks like it is not enough to get rid of this blinking window. Differential Revision: https://phabricator.services.mozilla.com/D148515
813f753a3b83adb6796f5e79ec5dbb5bd50f5fe7: Bug 1773203 - [devtools] Improve failure message and documentation for devtools-bundle job r=nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Wed, 08 Jun 2022 07:47:25 +0000 - rev 620067
Push 39817 by smolnar@mozilla.com at Wed, 08 Jun 2022 16:01:29 +0000
Bug 1773203 - [devtools] Improve failure message and documentation for devtools-bundle job r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D148607
65e47e5dc7b5d03d66092a7f80586108a51cd113: Bug 1772851 - Fix devtools tests to not rely on ambient XUL. r=devtools-reviewers,nchevobbe
Andrew McCreight <continuation@gmail.com> - Mon, 06 Jun 2022 16:33:35 +0000 - rev 619816
Push 39807 by abutkovits@mozilla.com at Tue, 07 Jun 2022 04:23:49 +0000
Bug 1772851 - Fix devtools tests to not rely on ambient XUL. r=devtools-reviewers,nchevobbe Instead, explicitly add permissions for the domain that needs it. Also browser_bug331772_xul_tooltiptext_in_html.js. Differential Revision: https://phabricator.services.mozilla.com/D148406
5e5d5e5ae556044efa64e955371fd100d551dd78: Bug 1764348 - Enable browser console / browser toolbox console users turn on network monitoring manually r=nchevobbe
Hubert Boma Manilla <hmanilla@mozilla.com> - Mon, 06 Jun 2022 13:56:05 +0000 - rev 619807
Push 39806 by apavel@mozilla.com at Mon, 06 Jun 2022 21:25:03 +0000
Bug 1764348 - Enable browser console / browser toolbox console users turn on network monitoring manually r=nchevobbe Highlights - Network monitoring is turned off by default in browser console/ browser toolbox console on initial load. - A new "Enable Network Monitoring" setting is added to enable users toggle on an off as they desire. - The user setting is persisted across toolbox reopens. Differential Revision: https://phabricator.services.mozilla.com/D145234
bbec7952f80ec8ca0dd3a9e350c60ef2aa8d445f: Bug 1764348 - Cleanup hidePersistLogsCheckbox and hideShowContentMessagesCheckbox property r=nchevobbe
Hubert Boma Manilla <hmanilla@mozilla.com> - Mon, 06 Jun 2022 13:56:05 +0000 - rev 619806
Push 39806 by apavel@mozilla.com at Mon, 06 Jun 2022 21:25:03 +0000
Bug 1764348 - Cleanup hidePersistLogsCheckbox and hideShowContentMessagesCheckbox property r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D145550
47658c248d9e77faddc4901ac578c456cb8cfd54: Bug 1764348 - Enable browser console / browser toolbox console users turn on network monitoring manually r=nchevobbe
Hubert Boma Manilla <hmanilla@mozilla.com> - Thu, 02 Jun 2022 14:35:24 +0000 - rev 619574
Push 39788 by nfay@mozilla.com at Fri, 03 Jun 2022 03:41:38 +0000
Bug 1764348 - Enable browser console / browser toolbox console users turn on network monitoring manually r=nchevobbe Highlights - Network monitoring is turned off by default in browser console/ browser toolbox console on initial load. - A new "Enable Network Monitoring" setting is added to enable users toggle on an off as they desire. - The user setting is persisted across toolbox reopens. Differential Revision: https://phabricator.services.mozilla.com/D145234