searching for reviewer(nchevobbe)
3dc5333dfc77950ef0142d2bc576163e80f8f6a9: Bug 1677856 - [devtools] Update codemirror javascript mode r=nchevobbe
Hubert Boma Manilla <hmanilla@mozilla.com> - Tue, 01 Dec 2020 13:13:30 +0000 - rev 558908
Push 37994 by abutkovits@mozilla.com at Tue, 01 Dec 2020 21:53:01 +0000
Bug 1677856 - [devtools] Update codemirror javascript mode r=nchevobbe This patch updates the modes file for javascript. It fixes particularly the issue with the source editors syntax highlighting issue, caused by the usage of optional chaining inside template strings. It also benefits of any other improvements that have been made. Differential Revision: https://phabricator.services.mozilla.com/D98106
fa29b052066874836933b78c8b6d0812d58239ab: Bug 1678613 - Use property descriptors in promise previewers. r=nchevobbe
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 27 Nov 2020 15:53:55 +0000 - rev 558566
Push 37985 by dluca@mozilla.com at Sat, 28 Nov 2020 09:27:06 +0000
Bug 1678613 - Use property descriptors in promise previewers. r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D97760
51115684d88b3eca88d6ea2947837a94cb71f22e: Bug 1676476 - Replace grip.promiseState with a preview. r=nchevobbe
Oriol Brufau <oriol-bugzilla@hotmail.com> - Thu, 19 Nov 2020 21:51:56 +0000 - rev 558097
Push 37967 by abutkovits@mozilla.com at Fri, 20 Nov 2020 09:45:11 +0000
Bug 1676476 - Replace grip.promiseState with a preview. r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D97340
cf1a7a72636f1509fd349b025bac070641bd49f5: Bug 1676769 - [devtools] Try catch around instantiateTarget/addWatcherDataEntry in DevTools parent actors r=ochameau,nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Tue, 17 Nov 2020 13:15:45 +0000 - rev 557556
Push 37959 by btara@mozilla.com at Tue, 17 Nov 2020 21:55:29 +0000
Bug 1676769 - [devtools] Try catch around instantiateTarget/addWatcherDataEntry in DevTools parent actors r=ochameau,nchevobbe Depends on D97153 DevTools window actors rely on sendQuery for 2 APIs: instantiateTarget and addWatcherDataEntry. If an exception occurs in the child actor, it will be propagated back to the parent, which will reject the sendQuery. This can make the code revolving around those APIs very fragile. Since this code is involved in setting up the initial targets, it could be nice to catch errors there to avoid too many potential blank toolbox situations. Differential Revision: https://phabricator.services.mozilla.com/D97155
1766ea267c5e6ccad0961d2fde92a670dc476ad3: Bug 1577900: Add a prettyPrint button to the multiline editor of devtools. r=nchevobbe
Ping Chen <remotenonsense@gmail.com> - Tue, 17 Nov 2020 07:38:54 +0000 - rev 557493
Push 37959 by btara@mozilla.com at Tue, 17 Nov 2020 21:55:29 +0000
Bug 1577900: Add a prettyPrint button to the multiline editor of devtools. r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D95457
0affc83cf6d5e3cbf8db56e021e43b37c95252cf: Bug 1552648 - Avoid too much recursion when inspecting nested promises. r=nchevobbe,devtools-backward-compat-reviewers
Oriol Brufau <oriol-bugzilla@hotmail.com> - Mon, 16 Nov 2020 18:15:14 +0000 - rev 557455
Push 37957 by malexandru@mozilla.com at Tue, 17 Nov 2020 09:44:06 +0000
Bug 1552648 - Avoid too much recursion when inspecting nested promises. r=nchevobbe,devtools-backward-compat-reviewers Differential Revision: https://phabricator.services.mozilla.com/D96317
341abc5d6ef70b8d6e40b2c0d5224cc5cc0baab0: Bug 1674841 - [devtools] Clean up devtools/shared/protocol/tests/xpcshell/test_protocol_async.js r=nchevobbe
Andrey Bienkowski <hexagonrecursion@gmail.com> - Tue, 10 Nov 2020 12:55:29 +0000 - rev 556559
Push 37937 by csabou@mozilla.com at Tue, 10 Nov 2020 16:35:10 +0000
Bug 1674841 - [devtools] Clean up devtools/shared/protocol/tests/xpcshell/test_protocol_async.js r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D95553
66f20cfaba5dc6e066b46fe9ddccdaea66bc37bb: Bug 1676139 - [devtools] Update devtools presets to include fission jobs r=nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Tue, 10 Nov 2020 09:42:21 +0000 - rev 556536
Push 37937 by csabou@mozilla.com at Tue, 10 Nov 2020 16:35:10 +0000
Bug 1676139 - [devtools] Update devtools presets to include fission jobs r=nchevobbe The DevTools mochitests on Fission platforms have been promoted to tier 1. This changeset updates our try presets to increase our coverage of fission platforms. Differential Revision: https://phabricator.services.mozilla.com/D96407
fdc2974ccfc0338955fa6e5059eb110a00e48626: Bug 1672826 - [devtools] Unmanage fronts when we purge a whole prefix. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 09 Nov 2020 12:29:53 +0000 - rev 556404
Push 37935 by nbeleuzu@mozilla.com at Mon, 09 Nov 2020 21:53:49 +0000
Bug 1672826 - [devtools] Unmanage fronts when we purge a whole prefix. r=nchevobbe Previous `purgeRequestForDestroy` method was only rejecting all pending requests. The new `syncFrontDestroy` allows to fully destroy the front, including unregistering it/unmanage it. So that if we receive a packet from a brand new actor, with the same prefix and actor ID, DevToolsClient.getFront doesn't return the old destroyed front. This issue was making pending requests that were never resolved. Differential Revision: https://phabricator.services.mozilla.com/D94718
b6d78ba82b0d8dea9c2f66173de1dd67c66ef014: Bug 1672826 - [devtools] Close ChildDebuggerTransport in the parent process when we destroy content process targets. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 09 Nov 2020 12:26:41 +0000 - rev 556403
Push 37935 by nbeleuzu@mozilla.com at Mon, 09 Nov 2020 21:53:49 +0000
Bug 1672826 - [devtools] Close ChildDebuggerTransport in the parent process when we destroy content process targets. r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D94485
abfc63bf202b47a9d0a4a2d0c048a92f2a37349b: Bug 1674590 - Show reason of rejected promise in console, and allow it to be inspected. r=nchevobbe
Oriol Brufau <oriol-bugzilla@hotmail.com> - Thu, 05 Nov 2020 14:28:01 +0000 - rev 556021
Push 37924 by apavel@mozilla.com at Thu, 05 Nov 2020 21:37:48 +0000
Bug 1674590 - Show reason of rejected promise in console, and allow it to be inspected. r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D95450
ffd66d7f1d8b6da4cf54e75d85e251fbff9c74f7: Bug 1673419 - [devtools] Run performance node tests in the devtools-tests suite on CI r=nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Fri, 30 Oct 2020 17:20:04 +0000 - rev 555254
Push 37906 by nbeleuzu@mozilla.com at Fri, 30 Oct 2020 21:38:50 +0000
Bug 1673419 - [devtools] Run performance node tests in the devtools-tests suite on CI r=nchevobbe Depends on D95234 This will enable running the typescript checks for the performance-new panel on try. Differential Revision: https://phabricator.services.mozilla.com/D95235
9ba009e152c7f333996214d5144a922e41d02bc3: Bug 1673419 - [devtools] Run shared_components node tests in the devtools-tests suite on CI r=nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Fri, 30 Oct 2020 17:21:57 +0000 - rev 555253
Push 37906 by nbeleuzu@mozilla.com at Fri, 30 Oct 2020 21:38:50 +0000
Bug 1673419 - [devtools] Run shared_components node tests in the devtools-tests suite on CI r=nchevobbe Depends on D95232 The tests were previously added to the runner, but they were not included in the test suite. Differential Revision: https://phabricator.services.mozilla.com/D95234
de9bc70b4ec22b0ec2ef617c3386af02e1ea6a8c: Bug 1673419 - [devtools] Support performance-new typescript checks in devtools node try runner r=gregtatum,nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Fri, 30 Oct 2020 17:15:55 +0000 - rev 555252
Push 37906 by nbeleuzu@mozilla.com at Fri, 30 Oct 2020 21:38:50 +0000
Bug 1673419 - [devtools] Support performance-new typescript checks in devtools node try runner r=gregtatum,nchevobbe This allows to run the performance-new typescript checks via "node devtools/client/bin/devtools-node-test-runner.js --suite=performance" Differential Revision: https://phabricator.services.mozilla.com/D95232
3fda2292a5f3940fbc53127f7539765b388586b5: Bug 1623906 - [devtools] Dispatch thunks from Flexbox panel React components to highlight nodes r=gl,jdescottes,nchevobbe
Razvan Caliman <rcaliman@mozilla.com> - Thu, 29 Oct 2020 14:35:55 +0000 - rev 555215
Push 37906 by nbeleuzu@mozilla.com at Fri, 30 Oct 2020 21:38:50 +0000
Bug 1623906 - [devtools] Dispatch thunks from Flexbox panel React components to highlight nodes r=gl,jdescottes,nchevobbe ### Problem There is a lot of [prop drilling](https://kentcdodds.com/blog/prop-drilling) in React components to pass down a callback that is invoked at the bottom of a long chain of components. [onShowBoxModelHighlighterForNode()](https://searchfox.org/mozilla-central/search?path=&q=onShowBoxModelHighlighterForNode) is one such example. It is created at the [Inspector client level](https://searchfox.org/mozilla-central/rev/25d491b7924493b5d4bedc07841a1cd92f271100/devtools/client/inspector/inspector.js#1885-1908) then passed to React components for panels, then drilled down to the consumer component which invokes it. There is also some [needless duplication](https://searchfox.org/mozilla-central/source/devtools/client/inspector/layout/layout.js#85-86) with [onShowBoxModelHighlighter](https://searchfox.org/mozilla-central/search?q=onShowBoxModelHighlighter%5CW&path=&case=false&regexp=true). ### Solution With this patch, we leverage thunks in Redux. In Redux, you can `dispatch()`: - actions -> an object with an action type string which is matched by reducers - thunks -> a function which can be async and can itself dispatch actions or other thunks Thunks are supported by middleware already set up in the DevTools Redux [createStore()](https://searchfox.org/mozilla-central/source/devtools/client/shared/redux/create-store.js#54,104) helper. During store setup, we pass `thunkOptions` to the middleware, an object with arguments which will be available to all thunks when invoked. This is where we pass in the inspector client as a thunk option so we can invoke the highlighter. This is the replacement for prop drilling the `onShowBoxModelHighlighterForNode()` method. The same way they dispatch actions, components can now dispatch the thunk to show/hide the highlighter when they need it without direct knowledge of the `inspector`, thus satisfying the original intent of passing down the `onShowBoxModelHighlighterForNode()` callback while cleaning up the code. ### Prior art Thunks are not something new to DevTools. They are extensively used by the WebConsole, for example: - passing [thunk options to the store](https://searchfox.org/mozilla-central/rev/25d491b7924493b5d4bedc07841a1cd92f271100/devtools/client/webconsole/webconsole-wrapper.js#95-104) - making use of thunk options, [webConsoleUI and hud](https://searchfox.org/mozilla-central/source/devtools/client/webconsole/actions/autocomplete.js#14-91) in a thunk to handle autocomplete ###Useful context: DevTools helpers - [thunkWithOptions](https://searchfox.org/mozilla-central/source/devtools/client/shared/redux/middleware/thunk-with-options.js) - [shared Redux createStore helper with thunks middleware](https://searchfox.org/mozilla-central/source/devtools/client/shared/redux/create-store.js#54,104) Redux docs - [Async Actions in Redux](https://redux.js.org/advanced/async-actions) - [dispatch() as default prop with redux-connect](https://react-redux.js.org/using-react-redux/connect-mapdispatch#default-dispatch-as-a-prop) Differential Revision: https://phabricator.services.mozilla.com/D79556
b0a13898111c6548427a451993ce69e0d8eeb749: Bug 1673328 - [devtools] Stop using requestTypes in ThreadActor. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 29 Oct 2020 18:58:33 +0000 - rev 555141
Push 37903 by apavel@mozilla.com at Fri, 30 Oct 2020 03:48:30 +0000
Bug 1673328 - [devtools] Stop using requestTypes in ThreadActor. r=nchevobbe This was hacking the internals of RDP/protocol.js in order to provide different names to the actor prototype. I had to rename existing `skipBreakpoints` getter in order to avoid name collision with the RDP method of the same name. I also had to tweak a few method arguments as they weren't following protocol.js spec. They were called without protocol.js automatic marshalling of values. Finally, hack something in protocol.js in order to avoid duplicated response for ThreadActor.attach. Differential Revision: https://phabricator.services.mozilla.com/D94958
f560d280f658584218a828e8dd7697fbfa809199: Bug 1673328 - [devtools] Rename TabSources to SourcesManager. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 29 Oct 2020 19:00:26 +0000 - rev 555140
Push 37903 by apavel@mozilla.com at Fri, 30 Oct 2020 03:48:30 +0000
Bug 1673328 - [devtools] Rename TabSources to SourcesManager. r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D95042
6d8c713f14342ab8822af1f009bd36d23cc962f9: Bug 1673328 - [devtools] Drop ThreadActor.exit in favor of destroy. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 29 Oct 2020 18:59:35 +0000 - rev 555139
Push 37903 by apavel@mozilla.com at Fri, 30 Oct 2020 03:48:30 +0000
Bug 1673328 - [devtools] Drop ThreadActor.exit in favor of destroy. r=nchevobbe We no longer need to manuall call threadActor.exit from Target Actors as the ThreadActor is managed by the Target Actors, so that managed children will be destroyed when the target actor is destroyed. Differential Revision: https://phabricator.services.mozilla.com/D94957
8d8ad7afc62a9c55f3991e17ba8054bfdf417cad: Bug 1673328 - [devtools] Drop unused ThreadActor.detach method. r=nchevobbe,devtools-backward-compat-reviewers
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 29 Oct 2020 19:00:39 +0000 - rev 555138
Push 37903 by apavel@mozilla.com at Fri, 30 Oct 2020 03:48:30 +0000
Bug 1673328 - [devtools] Drop unused ThreadActor.detach method. r=nchevobbe,devtools-backward-compat-reviewers Differential Revision: https://phabricator.services.mozilla.com/D94956
198f287bb29920e9a3a895243b958ef565531fbb: Bug 1673974 - [devtools] Remove defer usage in browser_console_webconsole_ctrlw_close_tab.js. r=nchevobbe.
Ben Delevingne <rockingskier@gmail.com> - Thu, 29 Oct 2020 14:41:32 +0000 - rev 555088
Push 37903 by apavel@mozilla.com at Fri, 30 Oct 2020 03:48:30 +0000
Bug 1673974 - [devtools] Remove defer usage in browser_console_webconsole_ctrlw_close_tab.js. r=nchevobbe. Differential Revision: https://phabricator.services.mozilla.com/D95080
78d0de3437ab12e222d2ebdfcffbc1ac6a293d30: Bug 1623906 - [devtools] Dispatch thunks from Flexbox panel React components to highlight nodes r=gl,jdescottes,nchevobbe
Razvan Caliman <rcaliman@mozilla.com> - Thu, 29 Oct 2020 14:04:25 +0000 - rev 555077
Push 37903 by apavel@mozilla.com at Fri, 30 Oct 2020 03:48:30 +0000
Bug 1623906 - [devtools] Dispatch thunks from Flexbox panel React components to highlight nodes r=gl,jdescottes,nchevobbe ### Problem There is a lot of [prop drilling](https://kentcdodds.com/blog/prop-drilling) in React components to pass down a callback that is invoked at the bottom of a long chain of components. [onShowBoxModelHighlighterForNode()](https://searchfox.org/mozilla-central/search?path=&q=onShowBoxModelHighlighterForNode) is one such example. It is created at the [Inspector client level](https://searchfox.org/mozilla-central/rev/25d491b7924493b5d4bedc07841a1cd92f271100/devtools/client/inspector/inspector.js#1885-1908) then passed to React components for panels, then drilled down to the consumer component which invokes it. There is also some [needless duplication](https://searchfox.org/mozilla-central/source/devtools/client/inspector/layout/layout.js#85-86) with [onShowBoxModelHighlighter](https://searchfox.org/mozilla-central/search?q=onShowBoxModelHighlighter%5CW&path=&case=false&regexp=true). ### Solution With this patch, we leverage thunks in Redux. In Redux, you can `dispatch()`: - actions -> an object with an action type string which is matched by reducers - thunks -> a function which can be async and can itself dispatch actions or other thunks Thunks are supported by middleware already set up in the DevTools Redux [createStore()](https://searchfox.org/mozilla-central/source/devtools/client/shared/redux/create-store.js#54,104) helper. During store setup, we pass `thunkOptions` to the middleware, an object with arguments which will be available to all thunks when invoked. This is where we pass in the inspector client as a thunk option so we can invoke the highlighter. This is the replacement for prop drilling the `onShowBoxModelHighlighterForNode()` method. The same way they dispatch actions, components can now dispatch the thunk to show/hide the highlighter when they need it without direct knowledge of the `inspector`, thus satisfying the original intent of passing down the `onShowBoxModelHighlighterForNode()` callback while cleaning up the code. ### Prior art Thunks are not something new to DevTools. They are extensively used by the WebConsole, for example: - passing [thunk options to the store](https://searchfox.org/mozilla-central/rev/25d491b7924493b5d4bedc07841a1cd92f271100/devtools/client/webconsole/webconsole-wrapper.js#95-104) - making use of thunk options, [webConsoleUI and hud](https://searchfox.org/mozilla-central/source/devtools/client/webconsole/actions/autocomplete.js#14-91) in a thunk to handle autocomplete ###Useful context: DevTools helpers - [thunkWithOptions](https://searchfox.org/mozilla-central/source/devtools/client/shared/redux/middleware/thunk-with-options.js) - [shared Redux createStore helper with thunks middleware](https://searchfox.org/mozilla-central/source/devtools/client/shared/redux/create-store.js#54,104) Redux docs - [Async Actions in Redux](https://redux.js.org/advanced/async-actions) - [dispatch() as default prop with redux-connect](https://react-redux.js.org/using-react-redux/connect-mapdispatch#default-dispatch-as-a-prop) Differential Revision: https://phabricator.services.mozilla.com/D79556
5362c99dfe66bb3bf7077415e99e2a45d5ac4fa3: Bug 1673440 - Update devtools evaluationResult test after illegal character error message change r=nchevobbe
Tom Schuster <evilpies@gmail.com> - Tue, 27 Oct 2020 15:33:39 +0000 - rev 554709
Push 37898 by abutkovits@mozilla.com at Wed, 28 Oct 2020 09:24:21 +0000
Bug 1673440 - Update devtools evaluationResult test after illegal character error message change r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D94823
c4448be58fcb409e1aac608238cb5d38a4d29509: Bug 1673440 - Update devtools evaluationResult test after illegal character error message change r=nchevobbe
Tom Schuster <evilpies@gmail.com> - Tue, 27 Oct 2020 13:53:44 +0000 - rev 554658
Push 37897 by ncsoregi@mozilla.com at Tue, 27 Oct 2020 21:20:52 +0000
Bug 1673440 - Update devtools evaluationResult test after illegal character error message change r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D94823
ae8a567008d636de24d09834c046ec76555a9a2c: Bug 1671080 - [devtools] Remove unused devtools/client/shared/components/reps/reps/caption.js. r=nchevobbe
Naman Jain <namandude1008@gmail.com> - Tue, 27 Oct 2020 12:44:59 +0000 - rev 554653
Push 37896 by rmaries@mozilla.com at Tue, 27 Oct 2020 15:58:19 +0000
Bug 1671080 - [devtools] Remove unused devtools/client/shared/components/reps/reps/caption.js. r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D94814
a5286c19dc66bbfe81a839c65b6f58e051cb0dac: Bug 1673421 - [devtools] Remove double await in devtools codebase r=nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Tue, 27 Oct 2020 08:34:33 +0000 - rev 554593
Push 37896 by rmaries@mozilla.com at Tue, 27 Oct 2020 15:58:19 +0000
Bug 1673421 - [devtools] Remove double await in devtools codebase r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D94752
08b581a0fb92615e57a5b7b947fe301ec2458408: Bug 1671926 - [devtools] Test EvaluationContext in the Browser Toolbox. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 26 Oct 2020 16:46:07 +0000 - rev 554545
Push 37894 by dluca@mozilla.com at Tue, 27 Oct 2020 04:41:26 +0000
Bug 1671926 - [devtools] Test EvaluationContext in the Browser Toolbox. r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D94282
43b98bc28bdc8cd5de8b9134e7efd15bdf4ef04e: Bug 1672778 - [devtools] Avoid trying to send new-source event if the thread actor has been destroyed. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Fri, 23 Oct 2020 10:24:57 +0000 - rev 554370
Push 37894 by dluca@mozilla.com at Tue, 27 Oct 2020 04:41:26 +0000
Bug 1672778 - [devtools] Avoid trying to send new-source event if the thread actor has been destroyed. r=nchevobbe This may prevent logging a few exception or error messages. But thanks to the other patch of this bug, we should try to stop listening for sources as soon as the thread actor is destroyed. Differential Revision: https://phabricator.services.mozilla.com/D94484
9620179e672b4295d0a01b9cc7c6f9353cc42398: Bug 1672778 - [devtools] Destroy the thread actor when the content process actor is destroyed. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 26 Oct 2020 11:00:05 +0000 - rev 554369
Push 37894 by dluca@mozilla.com at Tue, 27 Oct 2020 04:41:26 +0000
Bug 1672778 - [devtools] Destroy the thread actor when the content process actor is destroyed. r=nchevobbe We have to manually call `exit` as calling `destroy` won't completely destroy it. ThreadActor.destroy do not call protocoljs.Actor.destroy, ThreadActor.exit does it. Differential Revision: https://phabricator.services.mozilla.com/D94483
b13fc7fd2bb8d1e2021b5a2bf02843fbb0bc1033: Bug 1671163 - [devtools] Move object inspector out of reps folder. r=nchevobbe
seunbayo <seunbayo83@gmail.com> - Fri, 23 Oct 2020 14:50:09 +0000 - rev 554244
Push 37889 by btara@mozilla.com at Fri, 23 Oct 2020 21:47:13 +0000
Bug 1671163 - [devtools] Move object inspector out of reps folder. r=nchevobbe require for files in this folder are updated accordingly. Differential Revision: https://phabricator.services.mozilla.com/D94582
21911a1b5adc18d43e2bfecea6cbb6130ab36a1d: Bug 1623667 - [devtools] Update Console to use Box Model Highlighter r=nchevobbe
Razvan Caliman <rcaliman@mozilla.com> - Tue, 20 Oct 2020 14:43:28 +0000 - rev 554195
Push 37889 by btara@mozilla.com at Fri, 23 Oct 2020 21:47:13 +0000
Bug 1623667 - [devtools] Update Console to use Box Model Highlighter r=nchevobbe Depends on D92226 Update Console tests to use the Toolbox shortcut to the highlighter. See D92222. The Console itself [already uses that shortcut](https://searchfox.org/mozilla-central/rev/222e4f64b769413ac1a1991d2397b13a0acb5d9d/devtools/client/webconsole/webconsole.js#385-396). Differential Revision: https://phabricator.services.mozilla.com/D92227
673c2917910463c63c977d7ebc263666488397ba: Bug 1672660 - [devtools] Unregister docshell listeners only if we had time to register them. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 22 Oct 2020 20:13:28 +0000 - rev 554106
Push 37888 by smolnar@mozilla.com at Fri, 23 Oct 2020 09:46:15 +0000
Bug 1672660 - [devtools] Unregister docshell listeners only if we had time to register them. r=nchevobbe It looks like we are destroying the target actor immediately, without having time to call _watchDocshells. And given that removeObserver throws if there is no matching listener already registered, it prevent detaching the target correctly, and, introduces a leak. Differential Revision: https://phabricator.services.mozilla.com/D94452
e08c452d0fa219ee5d71645a2894d2ca9b0f8a8c: Bug 1620248 - [devtools] Test content process console messages in a resource watcher test. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 22 Oct 2020 10:02:44 +0000 - rev 554012
Push 37885 by apavel@mozilla.com at Thu, 22 Oct 2020 14:54:09 +0000
Bug 1620248 - [devtools] Test content process console messages in a resource watcher test. r=nchevobbe For now, resource watcher tests were only testing resources from a single tab. This test targets the main process, like the browser toolbox and so will listen to all targets, including content process targets. Differential Revision: https://phabricator.services.mozilla.com/D93734
1e6f907ccf911613a5a6c52c2c054fba16b56b83: Bug 1620248 - [devtools] Create ContentProcessTarget from the server side via the Watcher Actor. r=nchevobbe,jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 22 Oct 2020 10:02:42 +0000 - rev 554011
Push 37885 by apavel@mozilla.com at Thu, 22 Oct 2020 14:54:09 +0000
Bug 1620248 - [devtools] Create ContentProcessTarget from the server side via the Watcher Actor. r=nchevobbe,jdescottes Before, targets were created on-demand, from the frontend, by calling ProcessDescriptor.getTarget when the root actor informed the frontend of a creation of a content process via processListChanged event and the notification of a new ProcessDescriptor. This previous behavior was making so that the target actor was created very late and did not allow recording for resources (console messages for ex), nor setting breakpoints very early during the process startup. With this new implementation, the watcher actor allows knowing if the frontend cares about content process target or not. We should only create these targets if the browser toolbox is opened, and typically not if we are only debugging a tab via a regular web toolbox. We do that via WatcherActor.watchTarget and sharedData object. content-process-script.js is loaded in all processes. Process script are loaded quite early during process startup. Soonish after `sharedData` is passed to the content process. So that it is hopefully executed before most privileged javascript runs. Javascript code where we possibly want to debug/observe/set a breakpoint on. This setup allows us to create the Content Process Target actor much earlier than the previous setup. When created, the target actor immediately start listening for resources (console message and others) via its `addWatcherDataEntry` method. In a near future, breakpoints will also be set via this method. We should also followup to use something else than Process Script and sharedData in order to create the target earlier, before any JS runs. Differential Revision: https://phabricator.services.mozilla.com/D65529
696737f76f6940ed3601cbce357b3fd7fa1050b7: Bug 1620248 - [devtools] Make hooks.onClosed optional for all Transport classes. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 22 Oct 2020 10:02:34 +0000 - rev 554010
Push 37885 by apavel@mozilla.com at Thu, 22 Oct 2020 14:54:09 +0000
Bug 1620248 - [devtools] Make hooks.onClosed optional for all Transport classes. r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D93193
cc538aba0b5ec54101845122d768aa5ba8d36986: Bug 1620248 - [devtools] Ensure destroying ContentProcess target when the target is destroyed before process shutdown. r=nchevobbe,jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 22 Oct 2020 10:02:31 +0000 - rev 554009
Push 37885 by apavel@mozilla.com at Thu, 22 Oct 2020 14:54:09 +0000
Bug 1620248 - [devtools] Ensure destroying ContentProcess target when the target is destroyed before process shutdown. r=nchevobbe,jdescottes For now, we were emitting the "tabDetached" event on message-manager-close (=process shutdown), or when the DevToolsServerConnection closes (=client closes the connection). But not when the target is being destroyed by the frontend when calling ResourceWatcher.unwatchTargets, which is calling process-helper's destroyTargets. This was introducing test failure (browser_target_list_watchTargets.js) with never resolving RDP requests. Differential Revision: https://phabricator.services.mozilla.com/D91559
ce62de8733f1752dde6a1a38632b9b53cf38be35: Bug 1623667 - [devtools] Update Console to use Box Model Highlighter r=nchevobbe
Razvan Caliman <rcaliman@mozilla.com> - Thu, 08 Oct 2020 07:15:56 +0000 - rev 553633
Push 37880 by rmaries@mozilla.com at Wed, 21 Oct 2020 03:56:30 +0000
Bug 1623667 - [devtools] Update Console to use Box Model Highlighter r=nchevobbe Depends on D92226 Update Console tests to use the Toolbox shortcut to the highlighter. See D92222. The Console itself [already uses that shortcut](https://searchfox.org/mozilla-central/rev/222e4f64b769413ac1a1991d2397b13a0acb5d9d/devtools/client/webconsole/webconsole.js#385-396). Differential Revision: https://phabricator.services.mozilla.com/D92227
be30ef2e65137b95a1833d58adf631c58c387b9c: Bug 1671973 - [devtools] Add a test to check that DevTools forceReload bypasses the cache r=nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Tue, 20 Oct 2020 07:53:48 +0000 - rev 553515
Push 37879 by nerli@mozilla.com at Tue, 20 Oct 2020 14:55:47 +0000
Bug 1671973 - [devtools] Add a test to check that DevTools forceReload bypasses the cache r=nchevobbe This is a test for the bug fix that landed in https://bugzilla.mozilla.org/show_bug.cgi?id=1671959 A new test is added, forked from devtools/client/framework/test/browser_toolbox_window_reload_target.js Most of the testReload helper from the original test is moved to the head.js of the folder. The new test relies on a simple sjs file which simply prints the value of the cache-control header. Differential Revision: https://phabricator.services.mozilla.com/D94041
247c0c79dc07293c7245d3f3d17b9daa5bd5a5ba: Bug 1671419 - [devtools] Avoid updating resource types if the list is empty. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 15 Oct 2020 18:55:59 +0000 - rev 553220
Push 37865 by malexandru@mozilla.com at Fri, 16 Oct 2020 03:25:18 +0000
Bug 1671419 - [devtools] Avoid updating resource types if the list is empty. r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D93657
b5017b0a0b5d10f00957b15fa9081d3f755dad76: Bug 1593728 Part 3: [devtools] Expand console DAMP test to log from cross-origin domains. r=perftest-reviewers,nchevobbe,sparky
Brad Werth <bwerth@mozilla.com> - Thu, 15 Oct 2020 01:03:23 +0000 - rev 553189
Push 37865 by malexandru@mozilla.com at Fri, 16 Oct 2020 03:25:18 +0000
Bug 1593728 Part 3: [devtools] Expand console DAMP test to log from cross-origin domains. r=perftest-reviewers,nchevobbe,sparky This allows this test to measure the performance of console messages arriving from cross-origin domains. Differential Revision: https://phabricator.services.mozilla.com/D93433
f3d078512924b6355be2084b438b8874dc88b362: Bug 1593728 Part 2: [devtools] Add a simple log message param and function to a console DAMP test. r=perftest-reviewers,nchevobbe,sparky
Brad Werth <bwerth@mozilla.com> - Thu, 15 Oct 2020 01:03:18 +0000 - rev 553188
Push 37865 by malexandru@mozilla.com at Fri, 16 Oct 2020 03:25:18 +0000
Bug 1593728 Part 2: [devtools] Add a simple log message param and function to a console DAMP test. r=perftest-reviewers,nchevobbe,sparky This new param is used to allow testing of simple messages in high volume. Differential Revision: https://phabricator.services.mozilla.com/D93432
d0c4371a455fc77378b132ae6f5b0f718e62d0e7: Bug 1593728 Part 1: [devtools] Rename parameter in a test to avoid using the async keyword. r=perftest-reviewers,nchevobbe,sparky
Brad Werth <bwerth@mozilla.com> - Thu, 15 Oct 2020 00:58:03 +0000 - rev 553187
Push 37865 by malexandru@mozilla.com at Fri, 16 Oct 2020 03:25:18 +0000
Bug 1593728 Part 1: [devtools] Rename parameter in a test to avoid using the async keyword. r=perftest-reviewers,nchevobbe,sparky This is just cleanup to avoid the "async" keyword as an identifier, plus using const where appropriate. Differential Revision: https://phabricator.services.mozilla.com/D93431
4e44940803cdb6b8c117a036f95b999e05690c23: Bug 1608074 - Set channel ReferrerInfo in privileged code instead of referrer header r=nchevobbe,mixedpuppy,valentin
JulianWels <julianwels@mozilla.com> - Tue, 13 Oct 2020 12:27:26 +0000 - rev 552811
Push 37858 by btara@mozilla.com at Tue, 13 Oct 2020 21:43:51 +0000
Bug 1608074 - Set channel ReferrerInfo in privileged code instead of referrer header r=nchevobbe,mixedpuppy,valentin Differential Revision: https://phabricator.services.mozilla.com/D59856
b3fb1b5bbe34b2d2daff194ca67110cfd8146c47: Bug 1608074 - Set channel ReferrerInfo in privileged code instead of referrer header r=nchevobbe,mixedpuppy,valentin
JulianWels <julianwels@mozilla.com> - Tue, 13 Oct 2020 10:39:11 +0000 - rev 552804
Push 37858 by btara@mozilla.com at Tue, 13 Oct 2020 21:43:51 +0000
Bug 1608074 - Set channel ReferrerInfo in privileged code instead of referrer header r=nchevobbe,mixedpuppy,valentin Differential Revision: https://phabricator.services.mozilla.com/D59856
e04f6c54d7cd164d617cae5f1e982076274eb581: Bug 1582699 - [devtools] Consolidate thunk middlewares. r=nchevobbe
Ben Delevingne <rockingskier@gmail.com> - Tue, 13 Oct 2020 07:45:52 +0000 - rev 552781
Push 37858 by btara@mozilla.com at Tue, 13 Oct 2020 21:43:51 +0000
Bug 1582699 - [devtools] Consolidate thunk middlewares. r=nchevobbe Merge `thunk-with-options` behavior directly into `thunk`, update `thunk` and `thunk-with-options` callsites and finally remove now unused `thunk-with-options` (as well as netmonitor's own `thunk`) Depends on D92888 Differential Revision: https://phabricator.services.mozilla.com/D93195
136b56e3833301deba8f64963d5b6d714d089489: Bug 1582699 - [devtools] Update thunk actions to take an object as an argument. r=nchevobbe
Ben Delevingne <rockingskier@gmail.com> - Tue, 13 Oct 2020 07:48:12 +0000 - rev 552780
Push 37858 by btara@mozilla.com at Tue, 13 Oct 2020 21:43:51 +0000
Bug 1582699 - [devtools] Update thunk actions to take an object as an argument. r=nchevobbe In short, thunk actions are changing from a signature with 2 parameters (dispatch and getState): `(dispatch, getState)`, to an object that contains those properties: `({ dispatch, getState })`. This is done so we can merge thunk and thunk-with-options Differential Revision: https://phabricator.services.mozilla.com/D92888
cdf395992b18cc43924e1e80413d55309fc19386: Bug 1593933 - [devtools] Navigating should close existing console.group messages. r=nchevobbe
Miguel Roncancio <mroncancio19@gmail.com> - Mon, 12 Oct 2020 08:36:19 +0000 - rev 552662
Push 37855 by apavel@mozilla.com at Mon, 12 Oct 2020 15:27:19 +0000
Bug 1593933 - [devtools] Navigating should close existing console.group messages. r=nchevobbe When a navigation message is added into the store, reset the currentGroup property This adds a test to ensure the fix works as expected. Differential Revision: https://phabricator.services.mozilla.com/D92778
79707fcdaa2d026678b1e9f0f19ef27a1d3a9002: Bug 1440068 - Fix filtering on console groups r=nchevobbe
Miguel Roncancio <mroncancio19@gmail.com> - Mon, 12 Oct 2020 06:41:33 +0000 - rev 552652
Push 37853 by apavel@mozilla.com at Mon, 12 Oct 2020 09:36:05 +0000
Bug 1440068 - Fix filtering on console groups r=nchevobbe Bug 1440068 - Fix filtering on console groups. implement more thorough check of collapsed group messages expand test suite Differential Revision: https://phabricator.services.mozilla.com/D91065
1e2735ca642f910a3f59e21052d9353d30a3080d: Bug 1670191 - [devtools] Remove mentions about remote debugging in target-mixin r=nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Fri, 09 Oct 2020 12:22:28 +0000 - rev 552371
Push 37849 by apavel@mozilla.com at Fri, 09 Oct 2020 21:45:45 +0000
Bug 1670191 - [devtools] Remove mentions about remote debugging in target-mixin r=nchevobbe Remote debugging in those method names and comments refered to e10s. Nowadays remote debugging is rather used to talk about remote "browser" debugging, via about:debugging. The comments give the false impression that those events are only used for about:debugging, which is not true. Differential Revision: https://phabricator.services.mozilla.com/D93063
057106d68590463ff1fad6cbe97fcc58d437c9a9: Bug 1667839 - Test console message resources against remoted iframes. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 05 Oct 2020 20:52:00 +0000 - rev 551749
Push 37840 by rmaries@mozilla.com at Wed, 07 Oct 2020 09:42:23 +0000
Bug 1667839 - Test console message resources against remoted iframes. r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D91970
015a1ec40270892d58e1816f93cf8e7b795e3911: Bug 1667839 - Pass watchedData to already existing targets. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 05 Oct 2020 20:52:23 +0000 - rev 551748
Push 37840 by rmaries@mozilla.com at Wed, 07 Oct 2020 09:42:23 +0000
Bug 1667839 - Pass watchedData to already existing targets. r=nchevobbe The previous code was all wrong and we weren't correctly listening to resource for already existing additional targets. Top level target was still working fine thanks to WatcherActor.watchResources calling watchTargetResource directly. Differential Revision: https://phabricator.services.mozilla.com/D91969