searching for reviewer(nchevobbe)
5b857315a92a9e0ec5f71c4bfc29acb639cbf59d: Bug 1748621 - [devtools] Add tests for blackboxing a source r=nchevobbe
Hubert Boma Manilla <hmanilla@mozilla.com> - Tue, 25 Jan 2022 08:12:00 +0000 - rev 605396
Push 39193 by abutkovits@mozilla.com at Tue, 25 Jan 2022 16:37:35 +0000
Bug 1748621 - [devtools] Add tests for blackboxing a source r=nchevobbe The tests covers most of the blackbox functionality Notably it covers issues fixed in D135393 and D135614 Differential Revision: https://phabricator.services.mozilla.com/D135496
1f98776f62ee391886cc5a33afcfd06d0206cd46: Bug 1751235 - [devtools] Fix isPopup flag for iframes loaded via window.open(url, "iframe-name"). r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 24 Jan 2022 10:16:04 +0000 - rev 605303
Push 39190 by mlaza@mozilla.com at Mon, 24 Jan 2022 21:42:29 +0000
Bug 1751235 - [devtools] Fix isPopup flag for iframes loaded via window.open(url, "iframe-name"). r=nchevobbe This flag should really only be true for document loaded in distinct tabs. Differential Revision: https://phabricator.services.mozilla.com/D136505
4faa241cfe3e9ad798eb1d9d7993cb954555e6ca: Bug 1751207 - [devtools] Allow debugging popups when a toolbox is opened for its opener tab. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 24 Jan 2022 10:16:04 +0000 - rev 605302
Push 39190 by mlaza@mozilla.com at Mon, 24 Jan 2022 21:42:29 +0000
Bug 1751207 - [devtools] Allow debugging popups when a toolbox is opened for its opener tab. r=nchevobbe This is only an issue when devtools.popups.debug is false, when it is true, the toolbox is move and a warning message is printed if we request to open a new toolbox. Differential Revision: https://phabricator.services.mozilla.com/D136498
f2e7497ddfd1d0287daa3e7e8ef86fe21408f0e0: Bug 1748805 - Add setOverflowHighlight method to ReadOnlyEditor. r=nchevobbe
Sai Hemanth B <saihemanth9019@gmail.com> - Mon, 24 Jan 2022 07:15:51 +0000 - rev 605289
Push 39190 by mlaza@mozilla.com at Mon, 24 Jan 2022 21:42:29 +0000
Bug 1748805 - Add setOverflowHighlight method to ReadOnlyEditor. r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D136688
80aa48474d45350bf785ba373564572455201a36: Bug 1746830 - Added preference for the custom formatters feature. r=nchevobbe
Sebastian Zartner <sebastianzartner@gmail.com> - Mon, 24 Jan 2022 06:17:17 +0000 - rev 605285
Push 39187 by smolnar@mozilla.com at Mon, 24 Jan 2022 09:35:41 +0000
Bug 1746830 - Added preference for the custom formatters feature. r=nchevobbe This preference is temporary and will be removed again once the feature is stable enough to ship. It is meant to control whether the feature is generally available. There will be a second preference added in bug 1746831 that will control whether the feature is enabled and can be toggled from within the settings. Differential Revision: https://phabricator.services.mozilla.com/D136271
378e84b5ef258453a630682342701dee7c26f00b: Bug 1636262 - [devtools] Update Edge browser icon for the compatibility panel r=nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Fri, 21 Jan 2022 13:18:15 +0000 - rev 605136
Push 39175 by imoraru@mozilla.com at Fri, 21 Jan 2022 16:47:10 +0000
Bug 1636262 - [devtools] Update Edge browser icon for the compatibility panel r=nchevobbe The SVG was created from scratch, so no issue with licensing hopefully Differential Revision: https://phabricator.services.mozilla.com/D136595
71af3a0623c43b1a17d7ca71b2d6c538883a7775: Bug 1747371 - [devtools] Set the session context for the parent process target. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 20 Jan 2022 13:20:33 +0000 - rev 605020
Push 39169 by abutkovits@mozilla.com at Thu, 20 Jan 2022 16:22:53 +0000
Bug 1747371 - [devtools] Set the session context for the parent process target. r=nchevobbe We were missing cached image request and probably CSP blocked request from the parent process because of this. We are spawning a NetworkEventContentWatcher for the parent process target. That's semi-intentional. This might better be done via a parent process resource type, like NETWORK_EVENT. But the current Resource framework doesn't allow to do that easily. So that we currently spawn the NetworkEventContentWatcher (and NetworkEventStackTraceWatcher) against the parent process target actor as a "FRAME" resource type. This is handy as we need at least one of these two watchers for the parent process. Differential Revision: https://phabricator.services.mozilla.com/D136325
06d8de7f3dda2c94452cc0b31894e4ed3578667b: Bug 1688168 - Isolate bidi text in the console. r=nchevobbe
Oriol Brufau <oriol-bugzilla@hotmail.com> - Tue, 18 Jan 2022 11:47:50 +0000 - rev 604771
Push 39160 by nerli@mozilla.com at Tue, 18 Jan 2022 15:42:25 +0000
Bug 1688168 - Isolate bidi text in the console. r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D135458
5284347025e8f543f0d86f87cb3b05dc609e52f5: Bug 1748621 - [devtools] Add tests for blackboxing a source r=nchevobbe
Hubert Boma Manilla <hmanilla@mozilla.com> - Mon, 17 Jan 2022 14:01:13 +0000 - rev 604678
Push 39156 by ctuns@mozilla.com at Mon, 17 Jan 2022 21:49:41 +0000
Bug 1748621 - [devtools] Add tests for blackboxing a source r=nchevobbe The tests covers most of the blackbox functionality Notably it covers issues fixed in D135393 and D135614 Differential Revision: https://phabricator.services.mozilla.com/D135496
698709d24aa5c8f024f6e2eb3b5fec9ebbf02aba: Bug 1749769 - [devtools] Lazy load target legacy listeners. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Fri, 14 Jan 2022 17:03:35 +0000 - rev 604584
Push 39151 by mlaza@mozilla.com at Fri, 14 Jan 2022 22:01:51 +0000
Bug 1749769 - [devtools] Lazy load target legacy listeners. r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D135832
e6ba00a49c0bc9a6065d8713be37723f63cbd8f4: Bug 1749769 - [devtools] Lazy load all resource legacy listeners. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Fri, 14 Jan 2022 17:03:35 +0000 - rev 604583
Push 39151 by mlaza@mozilla.com at Fri, 14 Jan 2022 22:01:51 +0000
Bug 1749769 - [devtools] Lazy load all resource legacy listeners. r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D135831
7f038064b3a2e806a083cfd3eae6a6f7b36c3ebb: Bug 1749769 - [devtools] Lazy load all resource transformers. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Fri, 14 Jan 2022 17:03:34 +0000 - rev 604582
Push 39151 by mlaza@mozilla.com at Fri, 14 Jan 2022 22:01:51 +0000
Bug 1749769 - [devtools] Lazy load all resource transformers. r=nchevobbe Doing this helps load resource-command module from jest tests which were throwing when loading the transformers. And it probably is a small performance improvement. Differential Revision: https://phabricator.services.mozilla.com/D135719
8dec33948dffec45cace2e72faf2f32fa6d700e8: Bug 1569859 - [devtools] Automagically move the toolbox between the original tab we debug and its popups. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Fri, 14 Jan 2022 12:02:25 +0000 - rev 604558
Push 39151 by mlaza@mozilla.com at Fri, 14 Jan 2022 22:01:51 +0000
Bug 1569859 - [devtools] Automagically move the toolbox between the original tab we debug and its popups. r=nchevobbe This is also behind "devtools.popups.debug", to be set to true manually. This special mode break the old fundamental principal where a given toolbox is bound to one unique given tab. Now one toolbox starts being shared between many tabs. When we select the original tab we debug, or any of its popups opened in distinct tabs, we will move the toolbox between each of these tabs. We will have one toolbox instance, one toolbox iframe, which will be moved around each tab's host. This is somewhat similar to host switching within the same tab. This is all based on the same trick where we swap the toolbox iframe to another location. Differential Revision: https://phabricator.services.mozilla.com/D131802
cd1af14d868ca2c56afc44590d55cd947b977306: Bug 1569859 - [devtools] Fix SourceActor's url having stack trace in it. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Fri, 14 Jan 2022 12:02:25 +0000 - rev 604557
Push 39151 by mlaza@mozilla.com at Fri, 14 Jan 2022 22:01:51 +0000
Bug 1569859 - [devtools] Fix SourceActor's url having stack trace in it. r=nchevobbe Debugger.Source.url attribute may be of the form: "http://example.com/foo line 10 > inlineScript" because of the following function `js::FormatIntroducedFilename`: https://searchfox.org/mozilla-central/rev/253ae246f642fe9619597f44de3b087f94e45a2d/js/src/vm/JSScript.cpp#1816-1846 This isn't so easy to reproduce, but in next changeset, browser_dbg-breakpoints-popup.js's testPausedInTwoPopups covers this Differential Revision: https://phabricator.services.mozilla.com/D135145
01825e43f4506b0a385c075b10a70eab2a3dd5f2: Bug 1569859 - [devtools] Always return sync content when using SourcesManager.urlContents with partial=true. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Fri, 14 Jan 2022 12:02:25 +0000 - rev 604556
Push 39151 by mlaza@mozilla.com at Fri, 14 Jan 2022 22:01:51 +0000
Bug 1569859 - [devtools] Always return sync content when using SourcesManager.urlContents with partial=true. r=nchevobbe With popup debugging (next patches), we trigger a race condition in this code where `SourcesManager.urlContents` is called *after* `devtools-html-content` is fired. i.e. after the HTML document is parsed. This lead to return an async promise instead of an immediate value. This confuses `SourceActor._getStartLineColumnDisplacement` which no longer apply breakpoints right away. We miss early breakpoint support for popups. This isn't easy to reproduce beyond popup debugging, in next changeset, browser_dbg-breakpoints-popup.js's testPausedByBreakpoint covers this. Differential Revision: https://phabricator.services.mozilla.com/D135144
5b1158612d0df867def1fa22768944ab1978dcd5: Bug 1569859 - [devtools] Spawn WindowGlobal targets for popup opened by the currently debugged tab r=nchevobbe,devtools-backward-compat-reviewers
Alexandre Poirot <poirot.alex@gmail.com> - Fri, 14 Jan 2022 12:02:24 +0000 - rev 604555
Push 39151 by mlaza@mozilla.com at Fri, 14 Jan 2022 22:01:51 +0000
Bug 1569859 - [devtools] Spawn WindowGlobal targets for popup opened by the currently debugged tab r=nchevobbe,devtools-backward-compat-reviewers For now, we only do that when "devtools.popups.debug" is manually set to true. This is introducing some complexity in the way we filter out the WindowGlobal we should consider or not. Before this patch it was quite straightforward. We accepted all WindowGlobal's matching the tab's `browserId`. Now we also accept the WindowGlobal whose `opener`'s `browserId` matches. With this patch only, popups start appearing in the iframe dropdown. You still have to manually switch to the popup via the dropdown to debug it in the inspector or console. In the debugger, you will already start seeing the popup source and break on it. Differential Revision: https://phabricator.services.mozilla.com/D133350
fd80cd422b4b45657ec04614d962e50f4bfd9cc6: Bug 1748618 - [devtools] Add blackbox line context menu item r=nchevobbe
Hubert Boma Manilla <hmanilla@mozilla.com> - Wed, 12 Jan 2022 14:26:31 +0000 - rev 604386
Push 39143 by abutkovits@mozilla.com at Wed, 12 Jan 2022 21:30:02 +0000
Bug 1748618 - [devtools] Add blackbox line context menu item r=nchevobbe This patch adds context menu item to ignore single lines in the editor and in the gutter Differential Revision: https://phabricator.services.mozilla.com/D135116
8f317a43f9f592d052af4d0922397cf9cb5c0c30: Bug 1749519 - [devtools] Prevent exception when reloading a page while having devtools opened. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 11 Jan 2022 16:16:33 +0000 - rev 604237
Push 39139 by smolnar@mozilla.com at Tue, 11 Jan 2022 21:32:55 +0000
Bug 1749519 - [devtools] Prevent exception when reloading a page while having devtools opened. r=nchevobbe Unfortunately, I haven't find any useful attribute on JSWindowActorChild/WindowGlobalChild/BrowsingContext to detect that things are destroyed, or to be destroyed and avoid calling sendAsyncMessage, or detect in the exception handler that we got destroyed. So I'm falling back to ignore the exception based on its message... Differential Revision: https://phabricator.services.mozilla.com/D135608
aa51d27a4da58b64b10e33998ebb208ad7388e1e: Bug 1745240 - [devtools] Factorize some more code around isBrowsingContextPartOfContext. r=nchevobbe,jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 10 Jan 2022 17:42:10 +0000 - rev 604079
Push 39136 by malexandru@mozilla.com at Mon, 10 Jan 2022 21:31:34 +0000
Bug 1745240 - [devtools] Factorize some more code around isBrowsingContextPartOfContext. r=nchevobbe,jdescottes Track all code which may filter BrowsingContext or WindowGlobal in the server codebase in order to use a unique filtering method. Differential Revision: https://phabricator.services.mozilla.com/D134423
2c11b1939c3e58f27e4793d5467e5ad1ca86a62d: Bug 1745240 - [devtools] Use only one method to filter both BrowsingContext and WindowGlobals. r=nchevobbe,jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 10 Jan 2022 17:42:09 +0000 - rev 604078
Push 39136 by malexandru@mozilla.com at Mon, 10 Jan 2022 21:31:34 +0000
Bug 1745240 - [devtools] Use only one method to filter both BrowsingContext and WindowGlobals. r=nchevobbe,jdescottes Differential Revision: https://phabricator.services.mozilla.com/D135098
f751667f77b09792b5eb7b566721ee5ff9baaf58: Bug 1745240 - [devtools] Unify target helpers and JS Window actors to use a shared method to filter BrowsingContext/WindowGlobal's. r=nchevobbe,jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 10 Jan 2022 17:42:09 +0000 - rev 604077
Push 39136 by malexandru@mozilla.com at Mon, 10 Jan 2022 21:31:34 +0000
Bug 1745240 - [devtools] Unify target helpers and JS Window actors to use a shared method to filter BrowsingContext/WindowGlobal's. r=nchevobbe,jdescottes Popup debugging (bug 1569859) will force to revisit how we filter out the BrowsingContext that are meant to be debugged. We won't only accept BrowsingContext based on their browserId. This would force us to carefuly review all the codes where we filter BrowsingContexts. And if we later have to tweak this, do this again. It would be nice to have a unique method to filter things out. It will also be beneficial once we add new debuggable contexts like workers as we would only have to tweak this method. For now, this patch focuses only on Target helpers and JSWindowActor's, but I'll followup to other server modules. Note that I'm changing the behavior of getAllRemoteBrowsingContexts in order to also return the top browsing context by default. We were having a few places where we were re-adding it after, but that's not trivial. It is easier to remove it in the rare function that need that. Differential Revision: https://phabricator.services.mozilla.com/D134422
e8e4a1f1d8a105942c4b0d30f2aa6e535b43e9eb: Bug 1745240 - [devtools] Move WatcherActor.isServerTargetSwitchingEnabled into session's context. r=nchevobbe,jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 10 Jan 2022 17:42:08 +0000 - rev 604076
Push 39136 by malexandru@mozilla.com at Mon, 10 Jan 2022 21:31:34 +0000
Bug 1745240 - [devtools] Move WatcherActor.isServerTargetSwitchingEnabled into session's context. r=nchevobbe,jdescottes This boolean helps know for which BrowsingContext we should create a target or track resources. So that it is part of what defines the context we should debug and will be handy to have in all filtering functions we use to filter browsing context or platform objects. Differential Revision: https://phabricator.services.mozilla.com/D134421
9b4893bbbde8a618c1765ffe7d93f28304f84500: Bug 1580599 Add a Fluent string helper to shared-head.js - r=nchevobbe
Greg Tatum <tatum.creative@gmail.com> - Mon, 10 Jan 2022 17:09:17 +0000 - rev 604073
Push 39136 by malexandru@mozilla.com at Mon, 10 Jan 2022 21:31:34 +0000
Bug 1580599 Add a Fluent string helper to shared-head.js - r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D135358
ee4372d071a035a245a767690639f7adc2d5aec1: Bug 1580599 - Add pseudo-locale configuration to the browser toolbox; r=platform-i18n-reviewers,devtools-reviewers,fluent-reviewers,nchevobbe,dminor
Greg Tatum <tatum.creative@gmail.com> - Mon, 10 Jan 2022 17:09:17 +0000 - rev 604072
Push 39136 by malexandru@mozilla.com at Mon, 10 Jan 2022 21:31:34 +0000
Bug 1580599 - Add pseudo-locale configuration to the browser toolbox; r=platform-i18n-reviewers,devtools-reviewers,fluent-reviewers,nchevobbe,dminor This commit adds support for setting the pseudo-locale for the browser UI directly from the Browser Toolbox. This places the icons in the same place as the "Disable Popup Autohide" command. This will make it easier for Firefox developers to test that their UI is properly localized. The SVGs were optimized for size using an optimizer that dropped the path precision and any extra tags. I tested that they work correctly in both light and dark modes. Pseudo-localization is documented here: https://firefox-source-docs.mozilla.org/l10n/fluent/tutorial.html#pseudolocalization After this patch lands I'll follow-up with updating that documentation. Differential Revision: https://phabricator.services.mozilla.com/D134420
e31b11d305386ceabc713f5214092e1b2010926d: Bug 1580599 - Migrate DevTools toolbox meatball menu to fluent; r=devtools-reviewers,fluent-reviewers,nchevobbe,flod
Greg Tatum <tatum.creative@gmail.com> - Mon, 10 Jan 2022 17:09:16 +0000 - rev 604071
Push 39136 by malexandru@mozilla.com at Mon, 10 Jan 2022 21:31:34 +0000
Bug 1580599 - Migrate DevTools toolbox meatball menu to fluent; r=devtools-reviewers,fluent-reviewers,nchevobbe,flod Differential Revision: https://phabricator.services.mozilla.com/D134419
01987cdc73f18006b6d5ed008d55864f724b8b82: Bug 1737968 - Replace lodash difference usage with filter. r=nchevobbe
Sai Hemanth B <saihemanth9019@gmail.com> - Mon, 10 Jan 2022 09:30:10 +0000 - rev 604041
Push 39136 by malexandru@mozilla.com at Mon, 10 Jan 2022 21:31:34 +0000
Bug 1737968 - Replace lodash difference usage with filter. r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D135443
d5428b3d0a08dbd7be2325f65625bd7243b67867: Bug 1653779 - Lazily create parent map r=nchevobbe,bomsy
wartmanm <wartmanm@tutanota.com> - Fri, 07 Jan 2022 09:54:21 +0000 - rev 603949
Push 39126 by mlaza@mozilla.com at Fri, 07 Jan 2022 15:55:14 +0000
Bug 1653779 - Lazily create parent map r=nchevobbe,bomsy parentMap appears to only be used when pressing the left arrow key to navigate to the parent folder in the source tree. If this is too slow it could be replaced with a traverseTree search. Differential Revision: https://phabricator.services.mozilla.com/D115318
5565c42f8ca920a3889cb2daf467933d87f92484: Bug 1720371 - [devtools] Fix eyedropper on pages with CSP r=nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Wed, 05 Jan 2022 13:46:22 +0000 - rev 603777
Push 39119 by malexandru@mozilla.com at Thu, 06 Jan 2022 03:47:27 +0000
Bug 1720371 - [devtools] Fix eyedropper on pages with CSP r=nchevobbe Load the png dataURL in a blob instead of an image to avoid CSP issues. Differential Revision: https://phabricator.services.mozilla.com/D134969
e77dc7c84f5b7e45696e5bb92e5941b9fb46aba2: Bug 1737971 - Remove lodash flatten/flattenDeep usage r=nchevobbe
Joaquín Serna <bubuanabelas@cryptolab.net> - Wed, 05 Jan 2022 08:58:46 +0000 - rev 603743
Push 39118 by abutkovits@mozilla.com at Wed, 05 Jan 2022 17:03:24 +0000
Bug 1737971 - Remove lodash flatten/flattenDeep usage r=nchevobbe Depends on D135081 Differential Revision: https://phabricator.services.mozilla.com/D135092
27c12803c96b8af1c269fbb2136e769930af354b: Bug 1737983 - Remove lodash `remove` usage r=nchevobbe
Joaquín Serna <bubuanabelas@cryptolab.net> - Wed, 05 Jan 2022 08:58:46 +0000 - rev 603742
Push 39118 by abutkovits@mozilla.com at Wed, 05 Jan 2022 17:03:24 +0000
Bug 1737983 - Remove lodash `remove` usage r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D135081
0b10ddd0ec1720ecbc12d910f8a79e695d8b8403: Bug 1747804 - [devtools] Fix har export when some requests can't be retrieved. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 04 Jan 2022 21:37:11 +0000 - rev 603684
Push 39116 by nfay@mozilla.com at Wed, 05 Jan 2022 09:33:53 +0000
Bug 1747804 - [devtools] Fix har export when some requests can't be retrieved. r=nchevobbe HAR export was still producing empty har files if any of the request currently displayed in the netmonitor can't be completely retrieved. This includes all lazy data. But if any request has been destroyed in the server fetching any lazy data will throw. Differential Revision: https://phabricator.services.mozilla.com/D134789
4ea2e2e52761573b3867207cc5ed44099a62a43e: Bug 1747805 - [devtools] Fix NETWORK_EVENT's innerWindowID and clear requests of iframe when they get destroyed. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 04 Jan 2022 21:37:11 +0000 - rev 603683
Push 39116 by nfay@mozilla.com at Wed, 05 Jan 2022 09:33:53 +0000
Bug 1747805 - [devtools] Fix NETWORK_EVENT's innerWindowID and clear requests of iframe when they get destroyed. r=nchevobbe This also fixes the targetFront attribute for NETWORK_EVENT resources of iframes. Differential Revision: https://phabricator.services.mozilla.com/D134788
4f4e935acf4cbf75d364013e8cbb6645e968a76f: Bug 1745238 - [devtools] Use context in NetworkEventActor to know if we are debugging a tab. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 22 Dec 2021 13:17:12 +0000 - rev 602956
Push 39086 by imoraru@mozilla.com at Wed, 22 Dec 2021 16:58:57 +0000
Bug 1745238 - [devtools] Use context in NetworkEventActor to know if we are debugging a tab. r=nchevobbe This is more reliable check and it feels more common type of check we already do elsewhere. It also helps expose less convoluted objects to NetworkEventActor and so simplify it. Differential Revision: https://phabricator.services.mozilla.com/D133474
9bbaf0d2cbe11ea35d81b04df763412c5848e62b: Bug 1745238 - [devtools] Use watcher actor context or target actor to filter out network event requests r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 22 Dec 2021 13:17:11 +0000 - rev 602955
Push 39086 by imoraru@mozilla.com at Wed, 22 Dec 2021 16:58:57 +0000
Bug 1745238 - [devtools] Use watcher actor context or target actor to filter out network event requests r=nchevobbe This will help always use context to filter out resources. Differential Revision: https://phabricator.services.mozilla.com/D133473
1af93ade7986d02a61f1e5a285e022e8caf8b9d5: Bug 1745238 - [devtools] Pass watcher actor's `context` down to WindowGlobalTargetActor r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 22 Dec 2021 13:17:11 +0000 - rev 602954
Push 39086 by imoraru@mozilla.com at Wed, 22 Dec 2021 16:58:57 +0000
Bug 1745238 - [devtools] Pass watcher actor's `context` down to WindowGlobalTargetActor r=nchevobbe This will be useful in next patch to know what is the overall debugged context. We can finally know if that's the browser context/toolbox from almost any part of the server codebase! Differential Revision: https://phabricator.services.mozilla.com/D133472
65845fd3f8532a0417fcd926d692bec011c4fc75: Bug 1745238 - [devtools] Rename WatcherActor and SessionData "context" to "sessionContext". r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 22 Dec 2021 13:17:11 +0000 - rev 602953
Push 39086 by imoraru@mozilla.com at Wed, 22 Dec 2021 16:58:57 +0000
Bug 1745238 - [devtools] Rename WatcherActor and SessionData "context" to "sessionContext". r=nchevobbe In prevision of a broader use of this existing "context" object, I'm renaming it in order to make this important object clearer and more easily identifiable. SessionContext object defines what we are debugging (everything, only one tab, an addon,...) and so controls which platform data we should expose back to the client. Differential Revision: https://phabricator.services.mozilla.com/D134411
bd77231a9a74d72fa95ee89fe02e986b7359ec31: Bug 1746952 - [devtools] Avoid notifying about same-process storage values when EFT is enabled. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 22 Dec 2021 09:59:09 +0000 - rev 602939
Push 39086 by imoraru@mozilla.com at Wed, 22 Dec 2021 16:58:57 +0000
Bug 1746952 - [devtools] Avoid notifying about same-process storage values when EFT is enabled. r=nchevobbe We were notifying about same-process storage values twice. Once with the top document target and another time via the iframe target. This was probably invisible from the UI. We were probably only updating things twice without any visible breakage. But this also highlighted that the test was quite wrong. It was only asserting about the last resource for each storage type. Luckily, the last resource to be notified was the one from the top document. So that it contained all the storage values about all the iframes. When I fix EFT implementation, now, iframe data is only visible in the iframe's related storage resource. I tweaked the test to correctly assert data against the many resources for a single storage type. Differential Revision: https://phabricator.services.mozilla.com/D134378
81e94060bda39d8ab7c250fcc12fea6d2d8f53a3: Bug 1746952 - [devtools] Fix targetFront attribute of all storage resources. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 22 Dec 2021 09:59:09 +0000 - rev 602938
Push 39086 by imoraru@mozilla.com at Wed, 22 Dec 2021 16:58:57 +0000
Bug 1746952 - [devtools] Fix targetFront attribute of all storage resources. r=nchevobbe Most children of the target fronts are target scoped actors, like console, inspector, thread,... All these target scoped actor's fronts are created via: https://searchfox.org/mozilla-central/rev/7d17fd1fe9f0005a2fb19e5d53da4741b06a98ba/devtools/shared/protocol/types.js#539-540 And so aren't going throught this `types.addActorType` inner function. So fix the targetFront attribute for all fronts created via this `read` method where the immediate parent is the targetFront. Differential Revision: https://phabricator.services.mozilla.com/D134377
6746ca879e1d31eb554a0b8e2d04382bfe724653: Bug 1746952 - [devtools] Acknowledge the distinct storage resource for each target in browser_storage_dynamic_windows.js. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 22 Dec 2021 09:59:08 +0000 - rev 602937
Push 39086 by imoraru@mozilla.com at Wed, 22 Dec 2021 16:58:57 +0000
Bug 1746952 - [devtools] Acknowledge the distinct storage resource for each target in browser_storage_dynamic_windows.js. r=nchevobbe This test was brittle as it was assuming that only one resource was notified per storage type. But this wasn't the case since fission or EFT! We were lucky that the assertion were correct only against the latest resource and not against the aggregate of the many resource (one per target). Differential Revision: https://phabricator.services.mozilla.com/D134376
e28f3304f362272876af4a675c4e0a8557401eee: Bug 1746370 - [devtools] Pass SOURCE resources down to newGeneratedSources. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 21 Dec 2021 09:15:32 +0000 - rev 602821
Push 39084 by ccozmuta@mozilla.com at Tue, 21 Dec 2021 21:41:51 +0000
Bug 1746370 - [devtools] Pass SOURCE resources down to newGeneratedSources. r=nchevobbe Actually I was wrong in bug 1745795. This wasn't SourceFront but SOURCE resources, which are SourceActor's form and not a Front. Let's make it clear and simplify the code some more. Also stop calling makeSourceId from create.js as we already have the reducer's source id via the reducer's source-actor's source attribute. Differential Revision: https://phabricator.services.mozilla.com/D134006
ae93faa865c76a21f140c6f02a7674d08c154ce5: Bug 1746370 - [devtools] Remove stringToSourceActorId as this was a workaround for flow. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 21 Dec 2021 09:15:32 +0000 - rev 602820
Push 39084 by ccozmuta@mozilla.com at Tue, 21 Dec 2021 21:41:51 +0000
Bug 1746370 - [devtools] Remove stringToSourceActorId as this was a workaround for flow. r=nchevobbe This was only useful when flow was used. Differential Revision: https://phabricator.services.mozilla.com/D134005
cf1d3a34a897bdcad705da7f606366cfbc28c84b: Bug 1746370 - [devtools] Simplify SourceQueue as it only handles original sources. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 21 Dec 2021 09:15:31 +0000 - rev 602819
Push 39084 by ccozmuta@mozilla.com at Tue, 21 Dec 2021 21:41:51 +0000
Bug 1746370 - [devtools] Simplify SourceQueue as it only handles original sources. r=nchevobbe SourceQueue used to throttle both generated and original sources. But since we migrated to ResourceCommand, and it comes with a builtin throttling, we only use SourceQueue for original sources. So we can acknowledge that and simplify this a bit. Differential Revision: https://phabricator.services.mozilla.com/D134004
46458f3503d7823f984d9910a3825c0c43032e83: Bug 1746366 - [devtools] Remove outdated backward compat code from debugger frontend. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 21 Dec 2021 09:15:31 +0000 - rev 602818
Push 39084 by ccozmuta@mozilla.com at Tue, 21 Dec 2021 21:41:51 +0000
Bug 1746366 - [devtools] Remove outdated backward compat code from debugger frontend. r=nchevobbe * SourceActor's introductionUrl has been removed in Fx77 in bug 1607639. * getBreakableLines has been added in Fx68 in bug 1537779. * getAvailableEventBreakpoints changed to return an array in Fx69 in bug 1549999. Differential Revision: https://phabricator.services.mozilla.com/D134003
fb195fa55987137376f046cafca224779a9f7aed: Bug 1736183 - [devtools] Reset hovered node reference when cancelling node picker r=nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Fri, 17 Dec 2021 07:18:17 +0000 - rev 602394
Push 39072 by ccozmuta@mozilla.com at Fri, 17 Dec 2021 15:25:42 +0000
Bug 1736183 - [devtools] Reset hovered node reference when cancelling node picker r=nchevobbe Quick patch, but needs test coverage Differential Revision: https://phabricator.services.mozilla.com/D131375
fb36d632474d37c6a6341e28f488c447efd4aabc: Bug 1745940 - [devtools] Implement blackboxing lines UI functionality r=nchevobbe
Hubert Boma Manilla <hmanilla@mozilla.com> - Thu, 16 Dec 2021 23:53:26 +0000 - rev 602375
Push 39072 by ccozmuta@mozilla.com at Fri, 17 Dec 2021 15:25:42 +0000
Bug 1745940 - [devtools] Implement blackboxing lines UI functionality r=nchevobbe Basic UI functionality for blackboxing Enable this feature pref `devtools.debugger.features.blackbox-lines` This is mainly to gather feeback from the team and webcompat, things like the selection colors will likely change, maybe we can add a context menu to the editor gutter as well etc. Differential Revision: https://phabricator.services.mozilla.com/D132368
8bde59d048c881e6b00651f0389967f631e5b268: Bug 1740116 - [devtools] Fix fetching extra data about cancelled navigation request. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 16 Dec 2021 21:59:09 +0000 - rev 602351
Push 39071 by ctuns@mozilla.com at Fri, 17 Dec 2021 03:51:53 +0000
Bug 1740116 - [devtools] Fix fetching extra data about cancelled navigation request. r=nchevobbe These exception may happen when some pending request from the previous page are received lated by the netmonitor, which tries to fetch extra data about these old requests. On the server side, these requests are destroyed when devtools.netmonitor.persistlog=false. (which is the default behavior) Differential Revision: https://phabricator.services.mozilla.com/D132495
f73088ff3b941ce4ea22266236ae8e9be1cedac4: Bug 1745944 - [devtools] Use new ChromeUtils.getXPCOMErrorName() method to get platform error names. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 15 Dec 2021 16:12:33 +0000 - rev 602137
Push 39068 by mlaza@mozilla.com at Wed, 15 Dec 2021 21:51:13 +0000
Bug 1745944 - [devtools] Use new ChromeUtils.getXPCOMErrorName() method to get platform error names. r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D133758
10b6a52576302beb2ba495e8d68def8504ff23fb: Bug 1745944 - [devtools] Make browser_resources_network_events.js generic enough to be used for other test pages. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 15 Dec 2021 16:12:33 +0000 - rev 602136
Push 39068 by mlaza@mozilla.com at Wed, 15 Dec 2021 21:51:13 +0000
Bug 1745944 - [devtools] Make browser_resources_network_events.js generic enough to be used for other test pages. r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D133769
0f4c55b3bea723116fa81a471580b631c948593d: Bug 1745944 - [devtools] Clarify the two tests against ResourceCommand cache for NETWORK_EVENT's. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 15 Dec 2021 16:12:33 +0000 - rev 602135
Push 39068 by mlaza@mozilla.com at Wed, 15 Dec 2021 21:51:13 +0000
Bug 1745944 - [devtools] Clarify the two tests against ResourceCommand cache for NETWORK_EVENT's. r=nchevobbe In this test, there is two that are actually dedicated to cover ResourceCommand internal cache and the precise behavior of ignoreExistingResources: true/false. I pulled them off in a dedicated test file and tried to simplified them a bit. Because the server doesn't really support fetch request done before calling watchResources, this test is a bit hard to understand. So I tried to make it clear via extensive comments. Then, my goal is to reuse the third and simplier test to extend the coverage of NETWORK_EVENT with many other assertions. Differential Revision: https://phabricator.services.mozilla.com/D133768
4599cdc0137b41e27fde2b640d2839271cfc2ee9: Bug 1729674 - [devtools] Re-enable browser_aboutdebugging_devtoolstoolbox_navigate_back_forward.js for BFCache. r=nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 15 Dec 2021 13:30:57 +0000 - rev 602114
Push 39068 by mlaza@mozilla.com at Wed, 15 Dec 2021 21:51:13 +0000
Bug 1729674 - [devtools] Re-enable browser_aboutdebugging_devtoolstoolbox_navigate_back_forward.js for BFCache. r=nchevobbe This has been made possible thanks to bug 1675456. Differential Revision: https://phabricator.services.mozilla.com/D133874