searching for reviewer(nbp)
c5a3b99be19a38842c377e586217368af6313221: Bug 1811171: Update comment r=nbp
Iain Ireland <iireland@mozilla.com> - Fri, 27 Jan 2023 17:47:42 +0000 - rev 650822
Push 40584 by smolnar@mozilla.com at Sat, 28 Jan 2023 21:11:06 +0000
Bug 1811171: Update comment r=nbp After some discussion, we came to the conclusion that this code still needs to exist, but the comment is misleading. Hopefully this describes the justification better. Depends on D168001 Differential Revision: https://phabricator.services.mozilla.com/D168002
2b5e50a4ff190703f16bae1021df38221cd8fb07: Bug 1811171: Don't invalidate in OnLeaveIonFrame r=nbp
Iain Ireland <iireland@mozilla.com> - Fri, 27 Jan 2023 17:47:42 +0000 - rev 650821
Push 40584 by smolnar@mozilla.com at Sat, 28 Jan 2023 21:11:06 +0000
Bug 1811171: Don't invalidate in OnLeaveIonFrame r=nbp Differential Revision: https://phabricator.services.mozilla.com/D168001
74ac0beba129f99bd69f8009d4493ce0a572c648: Bug 1800431 - Add riscv64 backend.r=nbp,jseward,mgaudet
Lu Yahan <yahan@iscas.ac.cn> - Mon, 23 Jan 2023 11:51:35 +0000 - rev 650192
Push 40572 by ncsoregi@mozilla.com at Mon, 23 Jan 2023 18:05:32 +0000
Bug 1800431 - Add riscv64 backend.r=nbp,jseward,mgaudet Differential Revision: https://phabricator.services.mozilla.com/D161986
49c9f7b06869290181744fe20edba13aa1783460: Bug 1804461: Remove `SingleByteRegs` from non x86 architectures r=nbp
Michael Holloway <mdh@mdholloway.org> - Thu, 19 Jan 2023 10:29:52 +0000 - rev 649556
Push 40562 by csabou@mozilla.com at Thu, 19 Jan 2023 16:36:52 +0000
Bug 1804461: Remove `SingleByteRegs` from non x86 architectures r=nbp Remove `SingleByteRegs` constants from non-x86 architectures for which they don't make sense. Differential Revision: https://phabricator.services.mozilla.com/D165485
f93a220d341ca70a5c139ab3e6f41301e21dcaeb: Bug 1799025: Part 13: Fix intermittent failure r=nbp
Iain Ireland <iireland@mozilla.com> - Thu, 19 Jan 2023 00:33:29 +0000 - rev 649509
Push 40561 by smolnar@mozilla.com at Thu, 19 Jan 2023 09:31:27 +0000
Bug 1799025: Part 13: Fix intermittent failure r=nbp Without this change I saw intermittent failures with '--ion-check-range-analysis', because we inserted an extra use of an IteratorHasIndices and triggered an assertion during lowering. Differential Revision: https://phabricator.services.mozilla.com/D167108
7097d24a54666d10cfd2c5f5b9c7c94b00e85d3e: Bug 1809125 - Part 4: Rename MDefinition::needTruncation() to MDefinition::canTrucate(). r=iain,nbp
André Bargull <andre.bargull@gmail.com> - Tue, 17 Jan 2023 08:28:17 +0000 - rev 649080
Push 40558 by mlaza@mozilla.com at Tue, 17 Jan 2023 16:13:02 +0000
Bug 1809125 - Part 4: Rename MDefinition::needTruncation() to MDefinition::canTrucate(). r=iain,nbp Rename to `canTruncate` to match other methods like `canConsumeFloat32`, `canProduceFloat32`, `canEmitAtUses`, and `canRecoverOnBailouts`. Depends on D166289 Differential Revision: https://phabricator.services.mozilla.com/D166290
0a7443f8c95c1af83536dea7c896b04b84bff3ed: Bug 1809125 - Part 3: Simplify MPhi::needTruncation(). r=iain,nbp
André Bargull <andre.bargull@gmail.com> - Tue, 17 Jan 2023 08:28:17 +0000 - rev 649079
Push 40558 by mlaza@mozilla.com at Tue, 17 Jan 2023 16:13:02 +0000
Bug 1809125 - Part 3: Simplify MPhi::needTruncation(). r=iain,nbp Other `needTruncation` methods also use a single `return` statement. Depends on D166288 Differential Revision: https://phabricator.services.mozilla.com/D166289
a5f7b15e7a968f9e13c720c0c96ae46a8c4435f6: Bug 1809125 - Part 2: Remove unreachable check in MCompare::needTruncation(). r=iain,nbp
André Bargull <andre.bargull@gmail.com> - Tue, 17 Jan 2023 08:28:16 +0000 - rev 649078
Push 40558 by mlaza@mozilla.com at Tue, 17 Jan 2023 16:13:02 +0000
Bug 1809125 - Part 2: Remove unreachable check in MCompare::needTruncation(). r=iain,nbp RangeAnalysis-based truncation is disabled for WASM, so this check isn't needed. Depends on D166287 Differential Revision: https://phabricator.services.mozilla.com/D166288
55e2f09ce725b73fd24cbd39789772450acee467: Bug 1809125 - Part 1: Remove unused `TruncateKind` parameter from MDefinition::needTruncation(). r=iain,nbp
André Bargull <andre.bargull@gmail.com> - Tue, 17 Jan 2023 08:28:16 +0000 - rev 649077
Push 40558 by mlaza@mozilla.com at Tue, 17 Jan 2023 16:13:02 +0000
Bug 1809125 - Part 1: Remove unused `TruncateKind` parameter from MDefinition::needTruncation(). r=iain,nbp Differential Revision: https://phabricator.services.mozilla.com/D166287
52ca397752ae84863879b82c43d342f7a4e28702: No Bug - Comment Fix for LCov format r=nbp DONTBUILD
Matthew Gaudet <mgaudet@mozilla.com> - Mon, 16 Jan 2023 16:27:28 +0000 - rev 648965
Push 40558 by mlaza@mozilla.com at Tue, 17 Jan 2023 16:13:02 +0000
No Bug - Comment Fix for LCov format r=nbp DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D166802
8baadad13803cfc14b2bcc1ca8c66b962a136345: Bug 1745665 - Avoid AutoSuppressNurseryCellAlloc in off-thread delazification. r=nbp
Ted Campbell <tcampbell@mozilla.com> - Fri, 09 Dec 2022 18:44:19 +0000 - rev 645203
Push 40470 by abutkovits@mozilla.com at Sat, 10 Dec 2022 09:28:30 +0000
Bug 1745665 - Avoid AutoSuppressNurseryCellAlloc in off-thread delazification. r=nbp There shouldn't be any GC allocations any more. This looks like an minor oversight that snuck in during a rebase. Depends on D164299 Differential Revision: https://phabricator.services.mozilla.com/D164300
ad181853d252b39c83c6a4ac7c5bdce3aabe60fe: Bug 1782573 - Document use of JSStringBuilder, ManualReportFrontendContext r=nbp
Bryan Thrall <bthrall@mozilla.com> - Tue, 06 Dec 2022 18:15:34 +0000 - rev 644842
Push 40459 by ctuns@mozilla.com at Wed, 07 Dec 2022 04:11:18 +0000
Bug 1782573 - Document use of JSStringBuilder, ManualReportFrontendContext r=nbp Differential Revision: https://phabricator.services.mozilla.com/D162429
c9090ffb135860a6274edd07d641963c37e6f2ec: Bug 1782573 - Avoid rooting hazards now that JSStringBuffer::finishString() can GC r=nbp
Bryan Thrall <bthrall@mozilla.com> - Tue, 06 Dec 2022 18:15:34 +0000 - rev 644841
Push 40459 by ctuns@mozilla.com at Wed, 07 Dec 2022 04:11:18 +0000
Bug 1782573 - Avoid rooting hazards now that JSStringBuffer::finishString() can GC r=nbp Differential Revision: https://phabricator.services.mozilla.com/D162428
e07073e852aa5c1b6540e7fe3ef8322138c0497c: Bug 1782573 - Use ErrorContext as AllocPolicy in StringBuffer r=nbp
Bryan Thrall <bthrall@mozilla.com> - Tue, 06 Dec 2022 18:15:33 +0000 - rev 644840
Push 40459 by ctuns@mozilla.com at Wed, 07 Dec 2022 04:11:18 +0000
Bug 1782573 - Use ErrorContext as AllocPolicy in StringBuffer r=nbp JSStringBuilder now needs to be 'complete' before its destructor is called. To complete it, call ok() (if there are no pending errors), failure() (to report pending errors). Differential Revision: https://phabricator.services.mozilla.com/D161461
8e5880a50a25b4f3b4fa2426ed1036375d6ac8d6: Bug 1782573 - Verify JSContext is not used to alloc memory from helper threads r=nbp
Bryan Thrall <bthrall@mozilla.com> - Tue, 06 Dec 2022 18:15:33 +0000 - rev 644839
Push 40459 by ctuns@mozilla.com at Wed, 07 Dec 2022 04:11:18 +0000
Bug 1782573 - Verify JSContext is not used to alloc memory from helper threads r=nbp The off-thread-inner-fcn.js test verifies that ParseContext is using ErrorContext as AllocPolicy. It seems like a fragile test, so perhaps I should convert it to a jsapi test. TempAllocPolicy::assertNotJSContextOnHelperThread() needs to be defined in the .cpp file because the header would have a circular dependency on JSContext.h if it #included it. We do want to make sure it is inlined, though, to avoid the extra function calls. Differential Revision: https://phabricator.services.mozilla.com/D160697
bb40d4e3d34d40efb1c02cc5ee464ff015b4ea47: Bug 1782573 - Use ErrorContext as AllocPolicy in ParseContext r=nbp
Bryan Thrall <bthrall@mozilla.com> - Tue, 06 Dec 2022 18:15:32 +0000 - rev 644838
Push 40459 by ctuns@mozilla.com at Wed, 07 Dec 2022 04:11:18 +0000
Bug 1782573 - Use ErrorContext as AllocPolicy in ParseContext r=nbp Differential Revision: https://phabricator.services.mozilla.com/D160285
bf9b68ce91c8a4107162db705ba9b03d9335a294: Bug 1782573 - Prepare for Stencil instantiation using ErrorContext r=nbp
Bryan Thrall <bthrall@mozilla.com> - Tue, 06 Dec 2022 18:15:32 +0000 - rev 644837
Push 40459 by ctuns@mozilla.com at Wed, 07 Dec 2022 04:11:18 +0000
Bug 1782573 - Prepare for Stencil instantiation using ErrorContext r=nbp Since prepareForInstantiate() can be called from off the main thread, we should be using ErrorContext. Instantiating the Stencil is done on the main thread, so using JSContext and AutoReportFrontendContext there works. Differential Revision: https://phabricator.services.mozilla.com/D160086
2571eea1a22b807bfb5b6e02405df984d0159052: Bug 1782573 - Use ErrorContext as AllocPolicy for AsmJS r=nbp
Bryan Thrall <bthrall@mozilla.com> - Tue, 06 Dec 2022 18:15:32 +0000 - rev 644836
Push 40459 by ctuns@mozilla.com at Wed, 07 Dec 2022 04:11:18 +0000
Bug 1782573 - Use ErrorContext as AllocPolicy for AsmJS r=nbp Differential Revision: https://phabricator.services.mozilla.com/D160085
823478a58a51c4a2cc9354250bf6c78c094a509b: Bug 1782573 - Use ErrorContext as AllocPolicy for ModuleBuilder r=nbp
Bryan Thrall <bthrall@mozilla.com> - Tue, 06 Dec 2022 18:15:31 +0000 - rev 644835
Push 40459 by ctuns@mozilla.com at Wed, 07 Dec 2022 04:11:18 +0000
Bug 1782573 - Use ErrorContext as AllocPolicy for ModuleBuilder r=nbp Differential Revision: https://phabricator.services.mozilla.com/D160084
6dacc6cfa571ccd1633478a28a78a2a2a3907374: Bug 1782573 - Use ErrorContext as AllocPolicy for CompilationState, UsedNameTracker, GeneralParser, PerHandlerParser r=nbp
Bryan Thrall <bthrall@mozilla.com> - Tue, 06 Dec 2022 18:15:31 +0000 - rev 644834
Push 40459 by ctuns@mozilla.com at Wed, 07 Dec 2022 04:11:18 +0000
Bug 1782573 - Use ErrorContext as AllocPolicy for CompilationState, UsedNameTracker, GeneralParser, PerHandlerParser r=nbp Differential Revision: https://phabricator.services.mozilla.com/D160083
3f9fa65a2d62db53cb0a5d4a8dc3202b34aca115: Bug 1782573 - Use ErrorContext for AllocPolicy in New*ScopeData() r=nbp
Bryan Thrall <bthrall@mozilla.com> - Tue, 06 Dec 2022 18:15:30 +0000 - rev 644833
Push 40459 by ctuns@mozilla.com at Wed, 07 Dec 2022 04:11:18 +0000
Bug 1782573 - Use ErrorContext for AllocPolicy in New*ScopeData() r=nbp Differential Revision: https://phabricator.services.mozilla.com/D160082
82dba8241fbd9745d5fe4bfb62ded7e311e94c19: Bug 1782573 - Use ErrorContext as the AllocPolicy in TokenStreamAnyChars r=nbp
Bryan Thrall <bthrall@mozilla.com> - Tue, 06 Dec 2022 18:15:30 +0000 - rev 644832
Push 40459 by ctuns@mozilla.com at Wed, 07 Dec 2022 04:11:18 +0000
Bug 1782573 - Use ErrorContext as the AllocPolicy in TokenStreamAnyChars r=nbp Differential Revision: https://phabricator.services.mozilla.com/D160081
987a41209bd421ac528b4fad3e62fdee79949277: Bug 1782573 - Remove unneeded parameters r=nbp
Bryan Thrall <bthrall@mozilla.com> - Tue, 06 Dec 2022 18:15:29 +0000 - rev 644831
Push 40459 by ctuns@mozilla.com at Wed, 07 Dec 2022 04:11:18 +0000
Bug 1782573 - Remove unneeded parameters r=nbp Differential Revision: https://phabricator.services.mozilla.com/D160080
10480474d421713cd440969675e5e698eefe8190: Bug 1782573 - Allow ErrorContext in TempAllocPolicy r=nbp
Bryan Thrall <bthrall@mozilla.com> - Tue, 06 Dec 2022 18:15:29 +0000 - rev 644830
Push 40459 by ctuns@mozilla.com at Wed, 07 Dec 2022 04:11:18 +0000
Bug 1782573 - Allow ErrorContext in TempAllocPolicy r=nbp Reduce struct size by using a tagged pointer for the JSContext/ErrorContext member, since they are mutually exclusive. According to JS::PropertyKey, it is better to use XOR instead of `& ~JsContextTag` because small immediates can be encoded more efficiently on some platorms. Differential Revision: https://phabricator.services.mozilla.com/D160079
cc9006d171ff7f206f4eac8f48a1cfc0ec9726a9: Bug 1782573 - Use ErrorContext allocator instead of JSContext r=nbp
Bryan Thrall <bthrall@mozilla.com> - Tue, 06 Dec 2022 18:15:28 +0000 - rev 644829
Push 40459 by ctuns@mozilla.com at Wed, 07 Dec 2022 04:11:18 +0000
Bug 1782573 - Use ErrorContext allocator instead of JSContext r=nbp Differential Revision: https://phabricator.services.mozilla.com/D158849
f2c05b5421b8709a4722de40940a43bcbfe7859c: Bug 1782573 - Document use of JSStringBuilder, ManualReportFrontendContext r=nbp
Bryan Thrall <bthrall@mozilla.com> - Thu, 01 Dec 2022 17:48:12 +0000 - rev 644385
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1782573 - Document use of JSStringBuilder, ManualReportFrontendContext r=nbp Differential Revision: https://phabricator.services.mozilla.com/D162429
331da8c788e755c40ada774c479f75c31e940ed6: Bug 1782573 - Avoid rooting hazards now that JSStringBuffer::finishString() can GC r=nbp
Bryan Thrall <bthrall@mozilla.com> - Thu, 01 Dec 2022 17:48:12 +0000 - rev 644384
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1782573 - Avoid rooting hazards now that JSStringBuffer::finishString() can GC r=nbp Differential Revision: https://phabricator.services.mozilla.com/D162428
dcce81857b439524295571fedb2d843d042acc61: Bug 1782573 - Use ErrorContext as AllocPolicy in StringBuffer r=nbp
Bryan Thrall <bthrall@mozilla.com> - Thu, 01 Dec 2022 17:48:11 +0000 - rev 644383
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1782573 - Use ErrorContext as AllocPolicy in StringBuffer r=nbp JSStringBuilder now needs to be 'complete' before its destructor is called. To complete it, call ok() (if there are no pending errors), failure() (to report pending errors). Differential Revision: https://phabricator.services.mozilla.com/D161461
df81042e37c0e3e170f78d87274f5708957ca489: Bug 1782573 - Verify JSContext is not used to alloc memory from helper threads r=nbp
Bryan Thrall <bthrall@mozilla.com> - Thu, 01 Dec 2022 17:48:11 +0000 - rev 644382
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1782573 - Verify JSContext is not used to alloc memory from helper threads r=nbp The off-thread-inner-fcn.js test verifies that ParseContext is using ErrorContext as AllocPolicy. It seems like a fragile test, so perhaps I should convert it to a jsapi test. TempAllocPolicy::assertNotJSContextOnHelperThread() needs to be defined in the .cpp file because the header would have a circular dependency on JSContext.h if it #included it. We do want to make sure it is inlined, though, to avoid the extra function calls. Differential Revision: https://phabricator.services.mozilla.com/D160697
00aa0f405dcd468099df029f7426c29a140791bf: Bug 1782573 - Use ErrorContext as AllocPolicy in ParseContext r=nbp
Bryan Thrall <bthrall@mozilla.com> - Thu, 01 Dec 2022 17:48:10 +0000 - rev 644381
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1782573 - Use ErrorContext as AllocPolicy in ParseContext r=nbp Differential Revision: https://phabricator.services.mozilla.com/D160285
da904e5e68f7671e483296f57c5debf20dd2caf2: Bug 1782573 - Prepare for Stencil instantiation using ErrorContext r=nbp
Bryan Thrall <bthrall@mozilla.com> - Thu, 01 Dec 2022 17:48:10 +0000 - rev 644380
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1782573 - Prepare for Stencil instantiation using ErrorContext r=nbp Since prepareForInstantiate() can be called from off the main thread, we should be using ErrorContext. Instantiating the Stencil is done on the main thread, so using JSContext and AutoReportFrontendContext there works. Differential Revision: https://phabricator.services.mozilla.com/D160086
f00adbdce5cbf4fe031d50731faa7550171ebfd7: Bug 1782573 - Use ErrorContext as AllocPolicy for AsmJS r=nbp
Bryan Thrall <bthrall@mozilla.com> - Thu, 01 Dec 2022 17:48:10 +0000 - rev 644379
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1782573 - Use ErrorContext as AllocPolicy for AsmJS r=nbp Differential Revision: https://phabricator.services.mozilla.com/D160085
dd02cbc4aa3f4f55f5baf2a12e18e435fffd3c4f: Bug 1782573 - Use ErrorContext as AllocPolicy for ModuleBuilder r=nbp
Bryan Thrall <bthrall@mozilla.com> - Thu, 01 Dec 2022 17:48:09 +0000 - rev 644378
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1782573 - Use ErrorContext as AllocPolicy for ModuleBuilder r=nbp Differential Revision: https://phabricator.services.mozilla.com/D160084
5c7b4fb51254d69118b859da567f636f706a7282: Bug 1782573 - Use ErrorContext as AllocPolicy for CompilationState, UsedNameTracker, GeneralParser, PerHandlerParser r=nbp
Bryan Thrall <bthrall@mozilla.com> - Thu, 01 Dec 2022 17:48:09 +0000 - rev 644377
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1782573 - Use ErrorContext as AllocPolicy for CompilationState, UsedNameTracker, GeneralParser, PerHandlerParser r=nbp Differential Revision: https://phabricator.services.mozilla.com/D160083
153d7e396ffc44cddc12e6c6660b566562a21517: Bug 1782573 - Use ErrorContext for AllocPolicy in New*ScopeData() r=nbp
Bryan Thrall <bthrall@mozilla.com> - Thu, 01 Dec 2022 17:48:08 +0000 - rev 644376
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1782573 - Use ErrorContext for AllocPolicy in New*ScopeData() r=nbp Differential Revision: https://phabricator.services.mozilla.com/D160082
9b71fb2990722ac7c0490701896ac39668070811: Bug 1782573 - Use ErrorContext as the AllocPolicy in TokenStreamAnyChars r=nbp
Bryan Thrall <bthrall@mozilla.com> - Thu, 01 Dec 2022 17:48:08 +0000 - rev 644375
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1782573 - Use ErrorContext as the AllocPolicy in TokenStreamAnyChars r=nbp Differential Revision: https://phabricator.services.mozilla.com/D160081
b29b7014af5b5d201a1736416d6356ff6aa3a499: Bug 1782573 - Remove unneeded parameters r=nbp
Bryan Thrall <bthrall@mozilla.com> - Thu, 01 Dec 2022 17:48:07 +0000 - rev 644374
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1782573 - Remove unneeded parameters r=nbp Differential Revision: https://phabricator.services.mozilla.com/D160080
e40a6f2e15b0dc2a9920720c3332e1b4de4d83f7: Bug 1782573 - Allow ErrorContext in TempAllocPolicy r=nbp
Bryan Thrall <bthrall@mozilla.com> - Thu, 01 Dec 2022 17:48:07 +0000 - rev 644373
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1782573 - Allow ErrorContext in TempAllocPolicy r=nbp Reduce struct size by using a tagged pointer for the JSContext/ErrorContext member, since they are mutually exclusive. According to JS::PropertyKey, it is better to use XOR instead of `& ~JsContextTag` because small immediates can be encoded more efficiently on some platorms. Differential Revision: https://phabricator.services.mozilla.com/D160079
9859ab59082d35008e14d551a4b45406195af828: Bug 1782573 - Use ErrorContext allocator instead of JSContext r=nbp
Bryan Thrall <bthrall@mozilla.com> - Thu, 01 Dec 2022 17:48:07 +0000 - rev 644372
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1782573 - Use ErrorContext allocator instead of JSContext r=nbp Differential Revision: https://phabricator.services.mozilla.com/D158849
ad8fea940705bcc32afc14f517af14657e7eb825: Bug 1782573 - Document use of JSStringBuilder, ManualReportFrontendContext r=nbp
Bryan Thrall <bthrall@mozilla.com> - Thu, 01 Dec 2022 16:18:32 +0000 - rev 644355
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1782573 - Document use of JSStringBuilder, ManualReportFrontendContext r=nbp Differential Revision: https://phabricator.services.mozilla.com/D162429
e1d56f3496e938ace0b2be0d8cd7e40e6b9c4083: Bug 1782573 - Avoid rooting hazards now that JSStringBuffer::finishString() can GC r=nbp
Bryan Thrall <bthrall@mozilla.com> - Thu, 01 Dec 2022 16:18:32 +0000 - rev 644354
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1782573 - Avoid rooting hazards now that JSStringBuffer::finishString() can GC r=nbp Differential Revision: https://phabricator.services.mozilla.com/D162428
8fda1e5dc8019c0a17ab869fc16cd057a1d4ef2f: Bug 1782573 - Use ErrorContext as AllocPolicy in StringBuffer r=nbp
Bryan Thrall <bthrall@mozilla.com> - Thu, 01 Dec 2022 16:18:31 +0000 - rev 644353
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1782573 - Use ErrorContext as AllocPolicy in StringBuffer r=nbp JSStringBuilder now needs to be 'complete' before its destructor is called. To complete it, call ok() (if there are no pending errors), failure() (to report pending errors). Differential Revision: https://phabricator.services.mozilla.com/D161461
f5e18e5385aec08737f8fe55adab259fdb28e098: Bug 1782573 - Verify JSContext is not used to alloc memory from helper threads r=nbp
Bryan Thrall <bthrall@mozilla.com> - Thu, 01 Dec 2022 16:18:31 +0000 - rev 644352
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1782573 - Verify JSContext is not used to alloc memory from helper threads r=nbp The off-thread-inner-fcn.js test verifies that ParseContext is using ErrorContext as AllocPolicy. It seems like a fragile test, so perhaps I should convert it to a jsapi test. TempAllocPolicy::assertNotJSContextOnHelperThread() needs to be defined in the .cpp file because the header would have a circular dependency on JSContext.h if it #included it. We do want to make sure it is inlined, though, to avoid the extra function calls. Differential Revision: https://phabricator.services.mozilla.com/D160697
fedf38a13d7fbd3aa3f43d4c732f196aeb5d70a9: Bug 1782573 - Use ErrorContext as AllocPolicy in ParseContext r=nbp
Bryan Thrall <bthrall@mozilla.com> - Thu, 01 Dec 2022 16:18:31 +0000 - rev 644351
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1782573 - Use ErrorContext as AllocPolicy in ParseContext r=nbp Differential Revision: https://phabricator.services.mozilla.com/D160285
2c2d004da9b63690f89748fb81af90c38b8a9098: Bug 1782573 - Prepare for Stencil instantiation using ErrorContext r=nbp
Bryan Thrall <bthrall@mozilla.com> - Thu, 01 Dec 2022 16:18:30 +0000 - rev 644350
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1782573 - Prepare for Stencil instantiation using ErrorContext r=nbp Since prepareForInstantiate() can be called from off the main thread, we should be using ErrorContext. Instantiating the Stencil is done on the main thread, so using JSContext and AutoReportFrontendContext there works. Differential Revision: https://phabricator.services.mozilla.com/D160086
27dab284b1d4c9a3862204b26cf6be43f980b5de: Bug 1782573 - Use ErrorContext as AllocPolicy for AsmJS r=nbp
Bryan Thrall <bthrall@mozilla.com> - Thu, 01 Dec 2022 16:18:30 +0000 - rev 644349
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1782573 - Use ErrorContext as AllocPolicy for AsmJS r=nbp Differential Revision: https://phabricator.services.mozilla.com/D160085
b00f72e73b139d32ea507761cb531fd0ac754dc6: Bug 1782573 - Use ErrorContext as AllocPolicy for ModuleBuilder r=nbp
Bryan Thrall <bthrall@mozilla.com> - Thu, 01 Dec 2022 16:18:29 +0000 - rev 644348
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1782573 - Use ErrorContext as AllocPolicy for ModuleBuilder r=nbp Differential Revision: https://phabricator.services.mozilla.com/D160084
6522a100cd02f10d5ad97db47bcf3f4e8bb74c72: Bug 1782573 - Use ErrorContext as AllocPolicy for CompilationState, UsedNameTracker, GeneralParser, PerHandlerParser r=nbp
Bryan Thrall <bthrall@mozilla.com> - Thu, 01 Dec 2022 16:18:29 +0000 - rev 644347
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1782573 - Use ErrorContext as AllocPolicy for CompilationState, UsedNameTracker, GeneralParser, PerHandlerParser r=nbp Differential Revision: https://phabricator.services.mozilla.com/D160083
5915ec4af33b70c567a80a068d99b51378320598: Bug 1782573 - Use ErrorContext for AllocPolicy in New*ScopeData() r=nbp
Bryan Thrall <bthrall@mozilla.com> - Thu, 01 Dec 2022 16:18:29 +0000 - rev 644346
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1782573 - Use ErrorContext for AllocPolicy in New*ScopeData() r=nbp Differential Revision: https://phabricator.services.mozilla.com/D160082
64d6d6bd54aa39daa7164d1d710ae2818f5ff490: Bug 1782573 - Use ErrorContext as the AllocPolicy in TokenStreamAnyChars r=nbp
Bryan Thrall <bthrall@mozilla.com> - Thu, 01 Dec 2022 16:18:28 +0000 - rev 644345
Push 40447 by ncsoregi@mozilla.com at Fri, 02 Dec 2022 09:34:01 +0000
Bug 1782573 - Use ErrorContext as the AllocPolicy in TokenStreamAnyChars r=nbp Differential Revision: https://phabricator.services.mozilla.com/D160081