searching for reviewer(nalexander)
014541f7b1523d7793a4206da55a218ec2a9f0ed: Bug 1650206 - If set, check JAVA_HOME for java instead of path. r=nalexander
Bryce <bvandyk@mozilla.com> - Mon, 06 Jul 2020 19:58:01 +0000 - rev 538970
Push 37576 by ncsoregi@mozilla.com at Tue, 07 Jul 2020 09:47:47 +0000
Bug 1650206 - If set, check JAVA_HOME for java instead of path. r=nalexander Prior to this patch JAVA_HOME was appended to path and then the first instance of java on those paths was used and checked for version compatibility. This meant that if an incompatible version on java is on the path JAVA_HOME could not be used to point to a different, compatible version. Following this patch, JAVA_HOME can be used as a more fine grained selector of java. Only if JAVA_HOME is not set will we check the path. To be clear, even if JAVA_HOME is set incorrectly, we will not fall back to path -- only if JAVA_HOME is not set will we try and use the path. Differential Revision: https://phabricator.services.mozilla.com/D82418
6367a90c7cc308a4097979c64ffe1fcb22a2c6fd: Bug 1649850 - Refactor minimum Rust version into a common place for `bootstrap` and `configure` r=nalexander
Ricky Stewart <rstewart@mozilla.com> - Thu, 02 Jul 2020 18:05:58 +0000 - rev 538485
Push 37564 by nbeleuzu@mozilla.com at Fri, 03 Jul 2020 03:56:55 +0000
Bug 1649850 - Refactor minimum Rust version into a common place for `bootstrap` and `configure` r=nalexander The lack of duplication should prevent bugs like bug 1649039 popping up again. Differential Revision: https://phabricator.services.mozilla.com/D82060
fb2ec0915cb9a20f12423fee161edcc8b55617c8: Bug 1647481 - bump sccache version to pick up zstd changes; r=nalexander
Nathan Froyd <froydnj@mozilla.com> - Wed, 01 Jul 2020 21:18:27 +0000 - rev 538330
Push 37561 by ncsoregi@mozilla.com at Thu, 02 Jul 2020 09:46:06 +0000
Bug 1647481 - bump sccache version to pick up zstd changes; r=nalexander Differential Revision: https://phabricator.services.mozilla.com/D80550
ac0cffd433df4837a5d9f92efb05dfc597f7be46: Bug 1647489 - Ensure WDBA notification data is not lost r=mhowell,agashlin,nalexander
Kirk Steuber <ksteuber@mozilla.com> - Wed, 01 Jul 2020 18:46:30 +0000 - rev 538310
Push 37560 by rmaries@mozilla.com at Thu, 02 Jul 2020 03:58:28 +0000
Bug 1647489 - Ensure WDBA notification data is not lost r=mhowell,agashlin,nalexander Use caching to ensure that data collected when a ping is not sent eventually gets sent in a later ping. This is necessary only when a notification has actually been shown. Differential Revision: https://phabricator.services.mozilla.com/D80711
e454276078d6bf5d26082c20ad6d548c9baf39c6: Bug 1644270 - Save default browser values for telemetry separately r=mhowell,agashlin,nalexander
Kirk Steuber <ksteuber@mozilla.com> - Wed, 01 Jul 2020 18:46:10 +0000 - rev 538309
Push 37560 by rmaries@mozilla.com at Thu, 02 Jul 2020 03:58:28 +0000
Bug 1644270 - Save default browser values for telemetry separately r=mhowell,agashlin,nalexander We need to consider the impact of multiple installations that don't all send telemetry every time they are called. If a default browser transition is detected and recorded in the registry, but no telemetry is shown, the default browser change event is lost. To avoid this, we will cache the last default browser value that was actually sent in a ping and report that as the previous browser, rather than reporting the most recent default browser that we saw. Differential Revision: https://phabricator.services.mozilla.com/D80710
f7fd8a17cc44b41c307936e220d7423bdf47baba: Bug 1638393 - Properly remove all possibly registry values when unregistering the WDBA r=mhowell,nalexander
Kirk Steuber <ksteuber@mozilla.com> - Wed, 01 Jul 2020 18:45:51 +0000 - rev 538308
Push 37560 by rmaries@mozilla.com at Thu, 02 Jul 2020 03:58:28 +0000
Bug 1638393 - Properly remove all possibly registry values when unregistering the WDBA r=mhowell,nalexander Differential Revision: https://phabricator.services.mozilla.com/D75605
63c0fc65889be50136adb88895a62dad88b9e10b: Bug 1621703 - Only send one ping per day r=mhowell,nalexander,agashlin
Kirk Steuber <ksteuber@mozilla.com> - Wed, 01 Jul 2020 18:45:33 +0000 - rev 538307
Push 37560 by rmaries@mozilla.com at Thu, 02 Jul 2020 03:58:28 +0000
Bug 1621703 - Only send one ping per day r=mhowell,nalexander,agashlin Differential Revision: https://phabricator.services.mozilla.com/D80708
2fedf44d9f2ae87bffd444089a649c6b4510f331: Bug 1621703 - Add mutex to protect the registry r=mhowell,agashlin,nalexander
Kirk Steuber <ksteuber@mozilla.com> - Wed, 01 Jul 2020 18:45:05 +0000 - rev 538306
Push 37560 by rmaries@mozilla.com at Thu, 02 Jul 2020 03:58:28 +0000
Bug 1621703 - Add mutex to protect the registry r=mhowell,agashlin,nalexander Since the WDBA now accesses registry values whose names are not prefixed, it could have concurrency problems when running at the same time as agents from other installations. This patch adds a mutex to address that problem. Differential Revision: https://phabricator.services.mozilla.com/D80707
edfbd5a25c68cdf879e4f478d91fbe38710530f5: Bug 1621703 - Migrate prefixed CurrentDefault registry value name to an unprefixed one r=mhowell,agashlin,nalexander
Kirk Steuber <ksteuber@mozilla.com> - Wed, 01 Jul 2020 18:44:47 +0000 - rev 538305
Push 37560 by rmaries@mozilla.com at Thu, 02 Jul 2020 03:58:28 +0000
Bug 1621703 - Migrate prefixed CurrentDefault registry value name to an unprefixed one r=mhowell,agashlin,nalexander This patch also adds an install-directory-prefixed "Installed" value since RemoveAllRegistryEntries relies on prefixed value names and we no longer use any other install-directory-prefixed value names in the WDBA. Differential Revision: https://phabricator.services.mozilla.com/D80706
abfba63bc3c1b83d20becc363f7acf8a858d90fe: Bug 1621703 - Replace variable with existing macro with the same value r=mhowell,nalexander
Kirk Steuber <ksteuber@mozilla.com> - Wed, 01 Jul 2020 18:44:09 +0000 - rev 538304
Push 37560 by rmaries@mozilla.com at Thu, 02 Jul 2020 03:58:28 +0000
Bug 1621703 - Replace variable with existing macro with the same value r=mhowell,nalexander Differential Revision: https://phabricator.services.mozilla.com/D80713
c313c7e92aad555c561ef62fa3bc4fa48a9e4c4b: Bug 1621703 - Windows Default Browser Agent Telemetry r=mhowell,agashlin,nalexander,chutten
Kirk Steuber <ksteuber@mozilla.com> - Wed, 01 Jul 2020 18:43:56 +0000 - rev 538303
Push 37560 by rmaries@mozilla.com at Thu, 02 Jul 2020 03:58:28 +0000
Bug 1621703 - Windows Default Browser Agent Telemetry r=mhowell,agashlin,nalexander,chutten Differential Revision: https://phabricator.services.mozilla.com/D74956
392bc8ad6fea1953416105d7b594236ed5b87527: Bug 1621696 - Suppress the followup notification if the default browser has been changed r=mhowell,agashlin,nalexander
Kirk Steuber <ksteuber@mozilla.com> - Wed, 01 Jul 2020 18:43:14 +0000 - rev 538302
Push 37560 by rmaries@mozilla.com at Thu, 02 Jul 2020 03:58:28 +0000
Bug 1621696 - Suppress the followup notification if the default browser has been changed r=mhowell,agashlin,nalexander Differential Revision: https://phabricator.services.mozilla.com/D80704
d573712ab88e95aad88e605a3095c6ede40db9fb: Bug 1621696 - Show toast notification when default browser changes from Firefox to Edge with the Blink engine r=mhowell,agashlin,nalexander
Kirk Steuber <ksteuber@mozilla.com> - Wed, 01 Jul 2020 18:43:01 +0000 - rev 538301
Push 37560 by rmaries@mozilla.com at Thu, 02 Jul 2020 03:58:28 +0000
Bug 1621696 - Show toast notification when default browser changes from Firefox to Edge with the Blink engine r=mhowell,agashlin,nalexander Differential Revision: https://phabricator.services.mozilla.com/D73964
01b470cc5910c308fc708641572f5900d9f7b067: Bug 1621696 - Add localization for the default browser agent r=Pike,froydnj,nalexander
Kirk Steuber <ksteuber@mozilla.com> - Wed, 01 Jul 2020 18:40:29 +0000 - rev 538296
Push 37560 by rmaries@mozilla.com at Thu, 02 Jul 2020 03:58:28 +0000
Bug 1621696 - Add localization for the default browser agent r=Pike,froydnj,nalexander Make default browser agent aware of the package-time locale, and lay the foundation for future localization. The `locale.ini` file captures the package-time locale. It is equivalent to `update.locale`, except it is formatted as an INI file and is not packaged into the omnijar. The string are processing is structured to use `LOCALIZED_GENERATED_FILES` in the future, but at this time there's no localization. Differential Revision: https://phabricator.services.mozilla.com/D73955
a47f14392a5bd3feb81329c9751e7a73e4c343a3: Bug 1648528 - Consolidate registry access functionality in the WDBA r=mhowell,agashlin,nalexander
Kirk Steuber <ksteuber@mozilla.com> - Wed, 01 Jul 2020 18:38:38 +0000 - rev 538292
Push 37560 by rmaries@mozilla.com at Thu, 02 Jul 2020 03:58:28 +0000
Bug 1648528 - Consolidate registry access functionality in the WDBA r=mhowell,agashlin,nalexander The pattern with /mfbt/Poison.cpp and IMPL_MFBT is well-established in the tree. Thanks to nalexander@mozilla.com for writing much of the code in this patch. Differential Revision: https://phabricator.services.mozilla.com/D81233
95500c7e488bd31ec0226aff98a639787265d101: Bug 1647830 - Users trying to build Firefox for Android on Windows should get a warning in `bootstrap` and `configure` r=nalexander
Ricky Stewart <rstewart@mozilla.com> - Mon, 29 Jun 2020 22:36:02 +0000 - rev 538013
Push 37556 by abutkovits@mozilla.com at Tue, 30 Jun 2020 21:45:13 +0000
Bug 1647830 - Users trying to build Firefox for Android on Windows should get a warning in `bootstrap` and `configure` r=nalexander We get a lot of bugs about building Firefox for Android not working, and there's been ongoing confusion about whether this is something that does work or who has ever worked. The warning should hopefully clarify the current situation for people. Differential Revision: https://phabricator.services.mozilla.com/D81585
8fe985b593dbf79daa034f3311bf30772f595caf: Bug 1582562 - Do not build/install geckoview_example.test. r=nalexander,owlish
Agi Sferro <agi@sferro.dev> - Mon, 29 Jun 2020 23:28:02 +0000 - rev 537864
Push 37554 by nbeleuzu@mozilla.com at Tue, 30 Jun 2020 10:00:42 +0000
Bug 1582562 - Do not build/install geckoview_example.test. r=nalexander,owlish We don't use it and causes confusion when `mach install` fails because the signature of `geckoview_example.test` doesn't match. Differential Revision: https://phabricator.services.mozilla.com/D81606
030fc276c426f2ffea2404eda190f1f1b8aed1cf: Bug 1648575 - Fix Android artifact builds after bug 1645986. r=nalexander
Mike Hommey <mh+mozilla@glandium.org> - Thu, 25 Jun 2020 22:31:02 +0000 - rev 537502
Push 37543 by abutkovits@mozilla.com at Fri, 26 Jun 2020 03:24:35 +0000
Bug 1648575 - Fix Android artifact builds after bug 1645986. r=nalexander Differential Revision: https://phabricator.services.mozilla.com/D81240
4ea81cb5b59d92456c3c1c93759d501ae3da0a79: Bug 1647873 - Remove "`mach bootstrap` is not fully implemented in MozillaBuild" message r=nalexander
Ricky Stewart <rstewart@mozilla.com> - Wed, 24 Jun 2020 02:47:43 +0000 - rev 537183
Push 37537 by ncsoregi@mozilla.com at Wed, 24 Jun 2020 21:50:10 +0000
Bug 1647873 - Remove "`mach bootstrap` is not fully implemented in MozillaBuild" message r=nalexander This message dates from bug 1177128, the commit where this bootstrapper was added. At the time of writing that was certainly true, but today it doesn't appear to be true in any meaningful way. There's certainly an expectation that installing MozillaBuild and running `mach bootstrap` will get your machine ready to build Firefox; or at least, if it doesn't, it prints out some error messages telling you to do extra stuff, like we see in bug 1644794 for example. Therefore, I don't see how this message is relevant at all any more. Differential Revision: https://phabricator.services.mozilla.com/D80730
bf8020bac507c8f40fc9d923f4a70a1af6317bb3: Bug 1638964 - run mach gradle with python3 r=nalexander
Edwin Takahashi <egao@mozilla.com> - Mon, 22 Jun 2020 16:22:07 +0000 - rev 536610
Push 37531 by nbeleuzu@mozilla.com at Tue, 23 Jun 2020 03:44:39 +0000
Bug 1638964 - run mach gradle with python3 r=nalexander Differential Revision: https://phabricator.services.mozilla.com/D80286
d18affbd9da18aeba669b0ccccdd462c260f2b6f: Bug 1600530 - Consider MOZ_OBJDIR from the environment when there is no mozconfig. r=nalexander
Mike Hommey <mh+mozilla@glandium.org> - Fri, 19 Jun 2020 03:31:11 +0000 - rev 536445
Push 37521 by rmaries@mozilla.com at Fri, 19 Jun 2020 09:21:44 +0000
Bug 1600530 - Consider MOZ_OBJDIR from the environment when there is no mozconfig. r=nalexander We currently only deal with MOZ_OBJDIR in the environment when there is a mozconfig. Differential Revision: https://phabricator.services.mozilla.com/D80308
7b74749687e7d0d2e54d99423e76348d6e25e5aa: Bug 1646190 - Remove pymake from tree r=nalexander
Ricky Stewart <rstewart@mozilla.com> - Thu, 18 Jun 2020 21:06:32 +0000 - rev 536388
Push 37520 by dluca@mozilla.com at Fri, 19 Jun 2020 04:04:08 +0000
Bug 1646190 - Remove pymake from tree r=nalexander Differential Revision: https://phabricator.services.mozilla.com/D79920
6e8e506628d4859167df39ea33de07851423c282: Bug 1646508 - Add --setenv to |mach geckoview-junit|. r=nalexander
Agi Sferro <agi@sferro.dev> - Thu, 18 Jun 2020 19:42:00 +0000 - rev 536377
Push 37520 by dluca@mozilla.com at Fri, 19 Jun 2020 04:04:08 +0000
Bug 1646508 - Add --setenv to |mach geckoview-junit|. r=nalexander Differential Revision: https://phabricator.services.mozilla.com/D80077
914e5bf52768f3cb18aaeab86874587da7134d3e: Bug 1646748 - `mach clobber python` no longer deletes arbitrary untracked files in `python/` r=nalexander
Ricky Stewart <rstewart@mozilla.com> - Thu, 18 Jun 2020 16:42:51 +0000 - rev 536333
Push 37520 by dluca@mozilla.com at Fri, 19 Jun 2020 04:04:08 +0000
Bug 1646748 - `mach clobber python` no longer deletes arbitrary untracked files in `python/` r=nalexander This is a documented feature of `mach clobber python`, which I never noticed until bug 1645889 landed. I think it's fair to say that this is not how one would intuitively expect the command to work given that I'm the "owner" of this `mach` command and I never noticed this quirk until today. :) `python/` shouldn't contain compiled C extensions or anything and the existing `*.py[cdo]` and `*/__pycache__` clauses should get rid of most, if not all, of the relevant garbage in the directory. If the original behavior turns out to be desirable, we can add it back in (maybe we can use the `--full` command line option?) Differential Revision: https://phabricator.services.mozilla.com/D80204
8b56bdf1ba1342e75cca587f38d3bf1f4edd8f2f: Bug 1646508 - Add --setenv to |mach geckoview-junit|. r=nalexander
Agi Sferro <agi@sferro.dev> - Thu, 18 Jun 2020 16:22:04 +0000 - rev 536326
Push 37520 by dluca@mozilla.com at Fri, 19 Jun 2020 04:04:08 +0000
Bug 1646508 - Add --setenv to |mach geckoview-junit|. r=nalexander Differential Revision: https://phabricator.services.mozilla.com/D80077
634c757320020075aa630fae3222f6eb9eb7d6d3: Bug 1646431 - Fix type error in `mach file-info bugzilla-component` r=nalexander
Ricky Stewart <rstewart@mozilla.com> - Wed, 17 Jun 2020 17:16:06 +0000 - rev 536147
Push 37516 by cbrindusan@mozilla.com at Wed, 17 Jun 2020 21:52:06 +0000
Bug 1646431 - Fix type error in `mach file-info bugzilla-component` r=nalexander The `key` function to the `sort` call here was janky, so this produced an error if you tried to invoke this command on a path that doesn't have an owner (`TypeError: '<' not supported between instances of 'TypedTuple' and 'NoneType'`). Differential Revision: https://phabricator.services.mozilla.com/D80043
4d8ee4696e136413de723034a5df51aeb94e9cbe: Bug 1642121 - Remove directory dependence of GDB init files. r=nalexander
Steve Fink <sfink@mozilla.com> - Tue, 16 Jun 2020 15:45:43 +0000 - rev 535881
Push 37513 by rmaries@mozilla.com at Wed, 17 Jun 2020 03:41:56 +0000
Bug 1642121 - Remove directory dependence of GDB init files. r=nalexander I wrote this patch to address two problems: 1. if I do `mach run` from a directory other than $topsrcdir, $objdir, or $objdir/dist/bin, then .gdbinit will not be loaded. 2. Debugging the firefox binary will never load the JS prettyprinters in any case. I believe this patch fixes other problems as well, such as .gdbinit_python not being found, and the gdbpp pretty-printers not getting loaded in various situations. The main changes of this patch are: 1. Move .gdbinit into build/ (and $objdir/build/) to delay it from getting loaded until the search path is configured. 2. Move libxul.so-gdb.py into the correct directory. 3. Use either libxul.so-gdb.py or js-gdb.py to configure the correct search path then load .gdbinit, and have .gdbinit load all of the pretty-printers (Gecko and JS). 4. Use a single preprocessed file to configure the source directory. Use relative paths within the objdir for everything else. Differential Revision: https://phabricator.services.mozilla.com/D77589
40ff90d21697cbb314702f9cd9ad920e389dad45: Bug 1645889 - `mach clobber` clobbers Python files as well as objdir files r=nalexander
Ricky Stewart <rstewart@mozilla.com> - Tue, 16 Jun 2020 15:24:57 +0000 - rev 535878
Push 37513 by rmaries@mozilla.com at Wed, 17 Jun 2020 03:41:56 +0000
Bug 1645889 - `mach clobber` clobbers Python files as well as objdir files r=nalexander With the ongoing artifact issues, I find myself asking people to run `mach clobber python` quite frequently. Very often, those people come back and tell me that they tried to `mach clobber` and it didn't work, which is of course no surprise to me because `mach clobber` and `mach clobber python` do different things; so I have to repeat myself and we waste time going through the cycle multiple times for no reason. It's not crazy to assume that `mach clobber` will do as much as, or more, work than `mach clobber python`, so this change should bring the actual functionality of the code in sync with what people tend to assume. People tend to instinctively `mach clobber` when something has gone wrong locally and since `mach clobber python` does actually fix a set of local issues that `mach clobber` does not, this could also result in fewer bugs being reported in the long run. This is technically a back-incompatible change, but unlike a clobber of the `objdir` which can require you to do an expensive full rebuild, nobody's going to miss their `.pyc` files being deleted. Differential Revision: https://phabricator.services.mozilla.com/D79733
97216905ee9b6aeff670c33a38c005ec496c6821: Bug 1643842: Don't try generate artifact builds of builds without tests; r=nalexander
Tom Prince <mozilla@hocat.ca> - Mon, 15 Jun 2020 20:26:58 +0000 - rev 535751
Push 37509 by csabou@mozilla.com at Tue, 16 Jun 2020 03:30:48 +0000
Bug 1643842: Don't try generate artifact builds of builds without tests; r=nalexander There are various binaries that are included in test archives that are necessary for artifact builds to be repackaged. Don't generate artifact build variants of tasks without them. Differential Revision: https://phabricator.services.mozilla.com/D79575
3e3de4d0afc89cdb232394aaa88ccedda33bc8a8: Bug 1643842: Don't try run multi-l10n in artifact builds; r=nalexander
Tom Prince <mozilla@hocat.ca> - Mon, 15 Jun 2020 20:07:40 +0000 - rev 535750
Push 37509 by csabou@mozilla.com at Tue, 16 Jun 2020 03:30:48 +0000
Bug 1643842: Don't try run multi-l10n in artifact builds; r=nalexander Differential Revision: https://phabricator.services.mozilla.com/D79565
d31329aee3156b3784725c4752b393f6c78fe15e: Bug 1643842: Allow tests to be in en-US directory for artifact builds; r=nalexander
Tom Prince <mozilla@hocat.ca> - Mon, 15 Jun 2020 19:49:31 +0000 - rev 535749
Push 37509 by csabou@mozilla.com at Tue, 16 Jun 2020 03:30:48 +0000
Bug 1643842: Allow tests to be in en-US directory for artifact builds; r=nalexander The android shippable builds have the test artifacts in a en-US directory, since the builds are multi-l10n builds. Differential Revision: https://phabricator.services.mozilla.com/D79551
10af23bd0fd78588d938023678feef1e0cfd9bfb: Bug 1643842: Use shippable builds for artifact builds; r=nalexander
Tom Prince <mozilla@hocat.ca> - Mon, 15 Jun 2020 19:49:30 +0000 - rev 535748
Push 37509 by csabou@mozilla.com at Tue, 16 Jun 2020 03:30:48 +0000
Bug 1643842: Use shippable builds for artifact builds; r=nalexander Differential Revision: https://phabricator.services.mozilla.com/D78621
eb5c2760e3f2e62e2df2bb3df99aaa7377693815: Bug 1643842: Don't depend on profile-generation if we are an artifact build; r=nalexander
Tom Prince <mozilla@hocat.ca> - Mon, 15 Jun 2020 19:49:30 +0000 - rev 535747
Push 37509 by csabou@mozilla.com at Tue, 16 Jun 2020 03:30:48 +0000
Bug 1643842: Don't depend on profile-generation if we are an artifact build; r=nalexander Differential Revision: https://phabricator.services.mozilla.com/D79550
ad901d67145ba17b18ac93c45c371466112eacb9: Bug 1643842: Add an attribute to indicate which builds are explicitly artifact builds; r=nalexander
Tom Prince <mozilla@hocat.ca> - Mon, 15 Jun 2020 19:49:30 +0000 - rev 535746
Push 37509 by csabou@mozilla.com at Tue, 16 Jun 2020 03:30:48 +0000
Bug 1643842: Add an attribute to indicate which builds are explicitly artifact builds; r=nalexander This deliberately excludes builds that are implemented using the artifact build machinery, but are not primarly intended to short-circuit build time. In particular the Windows aarch64 builds are not marked this way. Differential Revision: https://phabricator.services.mozilla.com/D79549
df0d6b993ad6feb4ebe87c69d630015466dbfeb5: Bug 1642121 - Remove directory dependence of GDB init files. r=nalexander
Steve Fink <sfink@mozilla.com> - Mon, 15 Jun 2020 03:27:49 +0000 - rev 535626
Push 37506 by abutkovits@mozilla.com at Mon, 15 Jun 2020 09:26:24 +0000
Bug 1642121 - Remove directory dependence of GDB init files. r=nalexander I wrote this patch to address two problems: 1. if I do `mach run` from a directory other than $topsrcdir, $objdir, or $objdir/dist/bin, then .gdbinit will not be loaded. 2. Debugging the firefox binary will never load the JS prettyprinters in any case. I believe this patch fixes other problems as well, such as .gdbinit_python not being found, and the gdbpp pretty-printers not getting loaded in various situations. The main changes of this patch are: 1. Move .gdbinit into build/ (and $objdir/build/) to delay it from getting loaded until the search path is configured. 2. Move libxul.so-gdb.py into the correct directory. 3. Use either libxul.so-gdb.py or js-gdb.py to configure the correct search path then load .gdbinit, and have .gdbinit load all of the pretty-printers (Gecko and JS). 4. Use a single preprocessed file to configure the source directory. Use relative paths within the objdir for everything else. Differential Revision: https://phabricator.services.mozilla.com/D77589
c1628d8da86fff9d408cb53d1a3c886c57099101: Bug 1642032 - part 2 - install non-wildcard absolute FINAL_TARGET_FILES during misc; r=nalexander
Nathan Froyd <froydnj@mozilla.com> - Tue, 09 Jun 2020 20:23:29 +0000 - rev 534758
Push 37494 by nbeleuzu@mozilla.com at Wed, 10 Jun 2020 14:02:18 +0000
Bug 1642032 - part 2 - install non-wildcard absolute FINAL_TARGET_FILES during misc; r=nalexander Such files are, at least as of this writing, only libraries, and we can get by with installing them later. This change will also avoid having them added to the dependent libraries list. Differential Revision: https://phabricator.services.mozilla.com/D78618
a9239d02662726ebc80e3c0b02213b32795feaf4: Bug 1642032 - part 1 - factor out install targets for final target files; r=nalexander
Nathan Froyd <froydnj@mozilla.com> - Tue, 09 Jun 2020 20:23:24 +0000 - rev 534757
Push 37494 by nbeleuzu@mozilla.com at Wed, 10 Jun 2020 14:02:18 +0000
Bug 1642032 - part 1 - factor out install targets for final target files; r=nalexander We're going to reuse this machinery in a subsequent patch. I think this change, by virtue of moving all the output to a single place, also makes things clearer. Differential Revision: https://phabricator.services.mozilla.com/D78617
e8d03b25d0a0d9110d1ade68a01963300e34d3c4: Bug 1643504 - Upgrade visual metrics docker image to Debian buster. r=nalexander
Mike Hommey <mh+mozilla@glandium.org> - Tue, 09 Jun 2020 01:02:04 +0000 - rev 534565
Push 37491 by apavel@mozilla.com at Tue, 09 Jun 2020 09:21:34 +0000
Bug 1643504 - Upgrade visual metrics docker image to Debian buster. r=nalexander Differential Revision: https://phabricator.services.mozilla.com/D78421
12870272f1fab88b6462c6f19e616c36686bc459: Bug 1643504 - Upgrade android build docker images to Debian buster. r=nalexander
Mike Hommey <mh+mozilla@glandium.org> - Mon, 08 Jun 2020 10:53:29 +0000 - rev 534516
Push 37491 by apavel@mozilla.com at Tue, 09 Jun 2020 09:21:34 +0000
Bug 1643504 - Upgrade android build docker images to Debian buster. r=nalexander Differential Revision: https://phabricator.services.mozilla.com/D78418
1ea444c1373321aaec1e943ca9dec4e7175be210: Bug 1643504 - Build wine on Debian buster. r=nalexander
Mike Hommey <mh+mozilla@glandium.org> - Sun, 07 Jun 2020 22:29:15 +0000 - rev 534328
Push 37488 by btara@mozilla.com at Mon, 08 Jun 2020 09:48:42 +0000
Bug 1643504 - Build wine on Debian buster. r=nalexander Differential Revision: https://phabricator.services.mozilla.com/D78428
c324ff9bf17e4355f8296cebc064de6a46664539: Bug 1643504 - Upgrade android build docker images to Debian buster. r=nalexander
Mike Hommey <mh+mozilla@glandium.org> - Sun, 07 Jun 2020 22:28:57 +0000 - rev 534320
Push 37488 by btara@mozilla.com at Mon, 08 Jun 2020 09:48:42 +0000
Bug 1643504 - Upgrade android build docker images to Debian buster. r=nalexander Differential Revision: https://phabricator.services.mozilla.com/D78418
fc754ed98c417ae5931e0a438487c52dea77d388: Bug 1642630, explicitly copy l10n dictionaries to l10n merge dir, r=nalexander
Axel Hecht <axel@pike.org> - Thu, 04 Jun 2020 18:52:01 +0000 - rev 533963
Push 37481 by ncsoregi@mozilla.com at Fri, 05 Jun 2020 04:39:26 +0000
Bug 1642630, explicitly copy l10n dictionaries to l10n merge dir, r=nalexander Hunspell dictionaries are interesting, as we don't ship the en-US dictionary in repacks. Thus we can't use the merge logic from compare-locales, which would add en-US.dic and en-US.aff to the merge directory. Copy them to the merge dir, if exist. The repackaged app can still decide on whether to package them or not in `libs-%` and `chrome-%`. Differential Revision: https://phabricator.services.mozilla.com/D77863
7039e542f69a00725f35f2c708ea8220989f64da: Bug 1642630, explicitly copy l10n dictionaries to l10n merge dir, r=nalexander
Axel Hecht <axel@pike.org> - Thu, 04 Jun 2020 17:02:39 +0000 - rev 533953
Push 37480 by ncsoregi@mozilla.com at Thu, 04 Jun 2020 22:00:12 +0000
Bug 1642630, explicitly copy l10n dictionaries to l10n merge dir, r=nalexander Hunspell dictionaries are interesting, as we don't ship the en-US dictionary in repacks. Thus we can't use the merge logic from compare-locales, which would add en-US.dic and en-US.aff to the merge directory. Copy them to the merge dir, if exist. The repackaged app can still decide on whether to package them or not in `libs-%` and `chrome-%`. Differential Revision: https://phabricator.services.mozilla.com/D77863
a4626e14ed0db20b1df27999b173c9d40e34d450: Bug 1643026 - Squash stray reference to deleted global variable in virtualenv.py r=nalexander
Ricky Stewart <rstewart@mozilla.com> - Wed, 03 Jun 2020 17:23:30 +0000 - rev 533748
Push 37477 by dluca@mozilla.com at Thu, 04 Jun 2020 04:19:27 +0000
Bug 1643026 - Squash stray reference to deleted global variable in virtualenv.py r=nalexander Differential Revision: https://phabricator.services.mozilla.com/D78069
0f5a98fe760847762c1536443c87fa81349c70fe: Bug 1575999 - Always run javadoc tasks during lint. r=nalexander,esawin
Agi Sferro <agi@sferro.dev> - Mon, 01 Jun 2020 15:58:03 +0000 - rev 533323
Push 37469 by apavel@mozilla.com at Mon, 01 Jun 2020 21:42:28 +0000
Bug 1575999 - Always run javadoc tasks during lint. r=nalexander,esawin Differential Revision: https://phabricator.services.mozilla.com/D77489
4618c9093d0e36521021f3dde91c5e86e2da54ce: Bug 1641711 - Update artifacts for mozlint-android. r=nalexander
Agi Sferro <agi@sferro.dev> - Mon, 01 Jun 2020 15:57:58 +0000 - rev 533321
Push 37469 by apavel@mozilla.com at Mon, 01 Jun 2020 21:42:28 +0000
Bug 1641711 - Update artifacts for mozlint-android. r=nalexander Differential Revision: https://phabricator.services.mozilla.com/D77544
f7b9cdfbc377dcbfc2c5c4e77411d4dbe965acfc: Bug 1641711 - Don't fail the build if javadoc fails. r=nalexander,snorp,esawin
Agi Sferro <agi@sferro.dev> - Mon, 01 Jun 2020 15:58:13 +0000 - rev 533320
Push 37469 by apavel@mozilla.com at Mon, 01 Jun 2020 21:42:28 +0000
Bug 1641711 - Don't fail the build if javadoc fails. r=nalexander,snorp,esawin `|mach lint -f treeherder|` expects lint to not fail ever, if a lint fails it's just ignored. This means that when our javadoc errors out and fails the build all lints are ignored. To avoid that we add `failOnError = false` to the javadoc job so that we can finish the build and actually report the errors. This patch also adds gradle output `|mach lint|` to make it easier to diagnose errors in the lint. Differential Revision: https://phabricator.services.mozilla.com/D77373
96d034123ad99ca5a8f28bd7f694d29456cdfdd3: Bug 1642092, find toolkit/locales/en-US/defines.inc for comm* builds, r=nalexander
Axel Hecht <axel@pike.org> - Sun, 31 May 2020 01:30:57 +0000 - rev 533140
Push 37464 by cbrindusan@mozilla.com at Sun, 31 May 2020 09:50:24 +0000
Bug 1642092, find toolkit/locales/en-US/defines.inc for comm* builds, r=nalexander This was regressed by bug 1641791, mostly for the lack of comments in at least two places. Differential Revision: https://phabricator.services.mozilla.com/D77590
9e44d574b5c150c08c421fab825ce585dcbb1a43: Bug 1641848 - Import https://developer.mozilla.org/en-US/docs/Mozilla/Using_CXX_in_Mozilla_code in-tree r=nalexander
Sylvestre Ledru <sledru@mozilla.com> - Fri, 29 May 2020 19:28:52 +0000 - rev 533039
Push 37462 by malexandru@mozilla.com at Sat, 30 May 2020 09:46:43 +0000
Bug 1641848 - Import https://developer.mozilla.org/en-US/docs/Mozilla/Using_CXX_in_Mozilla_code in-tree r=nalexander I replaced the color by bold on "No". It seems we can't have color in cells with rst :/ Differential Revision: https://phabricator.services.mozilla.com/D77444
dcd6c6877bbada009660718512ebb864e725e704: Bug 1641791, remove special build fallback for LANGPACK_DEFINES, r=nalexander
Axel Hecht <axel@pike.org> - Fri, 29 May 2020 15:47:42 +0000 - rev 533008
Push 37461 by ccoroiu@mozilla.com at Fri, 29 May 2020 21:46:31 +0000
Bug 1641791, remove special build fallback for LANGPACK_DEFINES, r=nalexander This is a follow-up to bug 1641184, which I missed due to the special special logic for `defines.inc` here. Differential Revision: https://phabricator.services.mozilla.com/D77422