searching for reviewer(mstange)
ba212049d3c03367539fe10a67dc1b2fb7c42a86: Bug 1722359 - Remove ui.showHideScrollbars. r=mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 26 Jul 2021 18:42:36 +0000 - rev 586660
Push 38643 by imoraru@mozilla.com at Mon, 26 Jul 2021 21:59:52 +0000
Bug 1722359 - Remove ui.showHideScrollbars. r=mstange It probably did something more useful in the past, but right now it's only used to avoid throttling some overflow-causing animations. It returns 0 everywhere except on Android (for some reason?), but in any case it doesn't seem this would need to be a LookAndFeel integer, it could just be a regular pref that we turn on for tests. However the tests pass with this patch locally, so for now I'm not adding a pref to replace it. Differential Revision: https://phabricator.services.mozilla.com/D120871
7a7d9a6cc5134befe051de531f8f04c1b76e0f7b: Bug 1722031 - Tweak accent-color foreground computation and let it ride the trains. r=mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 24 Jul 2021 13:30:25 +0000 - rev 586577
Push 38640 by cbrindusan@mozilla.com at Sun, 25 Jul 2021 09:47:03 +0000
Bug 1722031 - Tweak accent-color foreground computation and let it ride the trains. r=mstange The accent-color computation right now chooses between black and white, which is not ideal. I tried to make it so that authors could choose the foreground colors in the linked CSSWG issue from the comment, but that didn't go anywhere. I think choosing a contrasting color that is in-line and contrasting enough with the accent-color chosen by the page when darkening is better than just black or white. If we want the black-or-white behavior we can just change layout.css.accent-color.target-contrast-ratio to something large enough. https://accent-color.glitch.me/ is a nice playground to see this patch in action. Differential Revision: https://phabricator.services.mozilla.com/D120723
ef0ebe9d47b32fc358c94870e47a13aac8cf4503: Bug 1722031 - Fix RelativeLuminanceUtils::Adjust to not choke on blacks / zero components. r=mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 24 Jul 2021 13:30:25 +0000 - rev 586576
Push 38640 by cbrindusan@mozilla.com at Sun, 25 Jul 2021 09:47:03 +0000
Bug 1722031 - Fix RelativeLuminanceUtils::Adjust to not choke on blacks / zero components. r=mstange Differential Revision: https://phabricator.services.mozilla.com/D120722
2a0274aa40148b9d89d79d844aa27b3ae2430bd8: Bug 1722031 - Fix an accent-color test. r=mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 24 Jul 2021 12:55:39 +0000 - rev 586575
Push 38640 by cbrindusan@mozilla.com at Sun, 25 Jul 2021 09:47:03 +0000
Bug 1722031 - Fix an accent-color test. r=mstange No other property returns `currentcolor` in the computed style, and Chrome agrees with us on this test. Differential Revision: https://phabricator.services.mozilla.com/D120725
13dddaa7a69ce11e51f6d71cae99df05afa7fc56: Bug 1721606 - Improve dark-color check to actually account for luminance. r=mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 22 Jul 2021 10:29:52 +0000 - rev 586417
Push 38635 by dluca@mozilla.com at Thu, 22 Jul 2021 21:48:15 +0000
Bug 1721606 - Improve dark-color check to actually account for luminance. r=mstange See the discussion in https://groups.google.com/a/chromium.org/g/blink-dev/c/WwYkLjbGhoA/m/EftJoLN_AwAJ for some background. Differential Revision: https://phabricator.services.mozilla.com/D120471
0a565118c5819a0f8c2d4efd1ab51e94ad21a53a: Bug 1711261 - Increase toolbar contrast in Mac HCM. r=mstange,desktop-theme-reviewers,dao
Harry Twyford <htwyford@mozilla.com> - Wed, 21 Jul 2021 15:41:50 +0000 - rev 586318
Push 38631 by apavel@mozilla.com at Wed, 21 Jul 2021 21:26:17 +0000
Bug 1711261 - Increase toolbar contrast in Mac HCM. r=mstange,desktop-theme-reviewers,dao This patch draws a 1px black line around the Urlbar in macOS HCM, which resembles other high contrast macOS apps. This patch only supports Light HCM mode. Since we apply the Firefox Dark lwttheme when in Dark mode, and we do not support lightweight themes in high contrast mode, significantly more work is required to implement basic support for dark HCM on Mac. Differential Revision: https://phabricator.services.mozilla.com/D116406
bdf8efe1293550c4ba26e0fac8d6e91c5f8878ae: Bug 1719734 - Enable widget.macos.support-dark-appearance by default on Release. r=mac-reviewers,mstange
Harry Twyford <htwyford@mozilla.com> - Wed, 14 Jul 2021 13:36:54 +0000 - rev 585486
Push 38613 by ncsoregi@mozilla.com at Wed, 14 Jul 2021 21:50:10 +0000
Bug 1719734 - Enable widget.macos.support-dark-appearance by default on Release. r=mac-reviewers,mstange Differential Revision: https://phabricator.services.mozilla.com/D119440
45c823bd6f287d984b4c03436489f88905b2349e: Bug 1688584: Add the ability to exit window fullscreen on macOS by pressing the escape key. r=mstange
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Tue, 13 Jul 2021 17:49:38 +0000 - rev 585432
Push 38611 by dluca@mozilla.com at Tue, 13 Jul 2021 21:42:32 +0000
Bug 1688584: Add the ability to exit window fullscreen on macOS by pressing the escape key. r=mstange Differential Revision: https://phabricator.services.mozilla.com/D116661
74a832b24286179042454aa2ca566b6900765688: Bug 1719734 - Enable widget.macos.support-dark-appearance by default on Release. r=mac-reviewers,mstange
Harry Twyford <htwyford@mozilla.com> - Tue, 13 Jul 2021 14:20:42 +0000 - rev 585415
Push 38611 by dluca@mozilla.com at Tue, 13 Jul 2021 21:42:32 +0000
Bug 1719734 - Enable widget.macos.support-dark-appearance by default on Release. r=mac-reviewers,mstange Differential Revision: https://phabricator.services.mozilla.com/D119440
94b5b21a2e3f2c160e0f05d4d739a77089a1aa87: Bug 1719708 - Improve the precision of profile start/end time. r=gfx-reviewers,mstange
Nicolas Silva <nsilva@mozilla.com> - Fri, 09 Jul 2021 08:20:16 +0000 - rev 585185
Push 38598 by ncsoregi@mozilla.com at Fri, 09 Jul 2021 21:40:06 +0000
Bug 1719708 - Improve the precision of profile start/end time. r=gfx-reviewers,mstange Instead of storing the start time which can be a very large number as f64, keep it in ns as u64 and do the float conversion for the time difference instead. In addition, the merge function was not behaving synmetrically. It was intended to work as old.merge(new) but we have at least one place in the code where we write it as new.merge(old). In practice takiung the max of the start times when merging two start times does what we want in both direction and makes merging less error prone. Differential Revision: https://phabricator.services.mozilla.com/D119432
30b55234a3d6907f9900acff119657f0484eeddf: Bug 1719516 - Add names to some AutoLock arguments in NativeLayerCA. r=mstange
Robert Mader <robert.mader@posteo.de> - Fri, 09 Jul 2021 06:49:33 +0000 - rev 585163
Push 38597 by abutkovits@mozilla.com at Fri, 09 Jul 2021 09:46:09 +0000
Bug 1719516 - Add names to some AutoLock arguments in NativeLayerCA. r=mstange To be more consistent with the rest of the code base and make the header file easier to read. Also remove an usused function declaration. Differential Revision: https://phabricator.services.mozilla.com/D119335
9361677296f530e66d2efd3bed727bb65bae659c: Bug 1715369. Handle the case of a StackingContextHelper inside a deferred transform item with a different asr. r=mstange
Timothy Nikkel <tnikkel@gmail.com> - Thu, 08 Jul 2021 23:07:11 +0000 - rev 585151
Push 38597 by abutkovits@mozilla.com at Fri, 09 Jul 2021 09:46:09 +0000
Bug 1715369. Handle the case of a StackingContextHelper inside a deferred transform item with a different asr. r=mstange Whenever the asr of the deferred transform item differs from the current asr and we are about to enter a new StackingContextHelper (as opposed to just when we enter a transformed frame) flush the deferred transform item, so it's transform doesn't get lost. This is similar to https://phabricator.services.mozilla.com/D8111. In fact we are extending https://phabricator.services.mozilla.com/D8111 to every time we enter a StackingContextHelper. https://phabricator.services.mozilla.com/D8111 was concerned with solving the case of having two nested transform items with different asrs and making sure we don't lose the outer transform item, here we need to solve the case of an outer transformed item and an inner StackingContextHelper (which is not for a transform) with a different asr and making sure we don't lose the outer transform item. Note that some of the items I added CreatesStackingContextHelper return true don't always make a new StackingContextHelper. It seemed better to be consistent and I think the only downside is a little less perf because we have to create a few more scrolldata nodes. Differential Revision: https://phabricator.services.mozilla.com/D118815
d06a9296cfab476b49da4fda4e8b720bf0bf826c: Bug 1718934 - Parse -webkit-focus-ring-color (computing to black). r=mstange,geckoview-reviewers,aklotz
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 08 Jul 2021 15:27:27 +0000 - rev 585093
Push 38595 by dluca@mozilla.com at Thu, 08 Jul 2021 21:46:16 +0000
Bug 1718934 - Parse -webkit-focus-ring-color (computing to black). r=mstange,geckoview-reviewers,aklotz Some pages use this to hide the focus outline. On Blink it seems black, WebKit uses it to expose the OS accent color. Make it black, which is the default when the color isn't implemented on a given platform. Differential Revision: https://phabricator.services.mozilla.com/D119036
66a4844007997a6d169829582df1bcbdbcefd346: Bug 1718934 - Parse -webkit-focus-ring-color (computing to black). r=mstange,geckoview-reviewers,aklotz
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 07 Jul 2021 19:24:29 +0000 - rev 585029
Push 38592 by nbeleuzu@mozilla.com at Thu, 08 Jul 2021 03:08:15 +0000
Bug 1718934 - Parse -webkit-focus-ring-color (computing to black). r=mstange,geckoview-reviewers,aklotz Some pages use this to hide the focus outline. On Blink it seems black, WebKit uses it to expose the OS accent color. Make it black, which is the default when the color isn't implemented on a given platform. Differential Revision: https://phabricator.services.mozilla.com/D119036
039a381447eae574b3b08731b70fdc46024337b9: Bug 1716545 - Remove Mac-specific DevTools light theme overrides. r=mac-reviewers,mstange
Harry Twyford <htwyford@mozilla.com> - Mon, 05 Jul 2021 13:33:25 +0000 - rev 584774
Push 38585 by smolnar@mozilla.com at Mon, 05 Jul 2021 21:30:49 +0000
Bug 1716545 - Remove Mac-specific DevTools light theme overrides. r=mac-reviewers,mstange Differential Revision: https://phabricator.services.mozilla.com/D118617
fcca441f1fc8dbcabba14eb511bb70833e6d2803: Bug 1717245 - Don't use system colors in the non-native theme if we're not painting backgrounds. r=mstange
Emilio Cobos Alvarez <emilio@crisal.io> - Tue, 22 Jun 2021 10:43:17 +0000 - rev 583991
Push 38557 by malexandru@mozilla.com at Tue, 22 Jun 2021 21:29:07 +0000
Bug 1717245 - Don't use system colors in the non-native theme if we're not painting backgrounds. r=mstange (Like for printing with backgrounds disabled). Otherwise layout darkens our foreground colors etc, and that causes contrast to be poor. Since the point of not painting backgrounds is saving ink, using the regular colors seems fine. Differential Revision: https://phabricator.services.mozilla.com/D118276
cef163a931a71beda1e3594a0a0e10d65cb5ed43: Bug 1678102 - Store the set of pending transactions in ClientLayerManager, to ensure we clear all of them during Destroy. r=mstange
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 14 Jun 2021 23:43:21 +0000 - rev 583081
Push 38539 by mlaza@mozilla.com at Tue, 15 Jun 2021 13:44:18 +0000
Bug 1678102 - Store the set of pending transactions in ClientLayerManager, to ensure we clear all of them during Destroy. r=mstange Differential Revision: https://phabricator.services.mozilla.com/D117588
1e2005661e7066c00fd214b1e9e18fafad80e0ae: Bug 1715452 - Disable widget.non-native-theme.webrender in macOS beta/release. r=mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 11 Jun 2021 18:56:25 +0000 - rev 582860
Push 38533 by nerli@mozilla.com at Sat, 12 Jun 2021 09:41:20 +0000
Bug 1715452 - Disable widget.non-native-theme.webrender in macOS beta/release. r=mstange Differential Revision: https://phabricator.services.mozilla.com/D117558
3ec370f03e4d78e8b5b7a188621947e1fdf31d1b: Bug 1710164 - Use appropriate system colors for in-content pages in HCM on macOS. r=mstange,desktop-theme-reviewers,dao
Harry Twyford <htwyford@mozilla.com> - Thu, 10 Jun 2021 16:00:40 +0000 - rev 582710
Push 38531 by mlaza@mozilla.com at Fri, 11 Jun 2021 09:42:05 +0000
Bug 1710164 - Use appropriate system colors for in-content pages in HCM on macOS. r=mstange,desktop-theme-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D115649
a79ab3a25a8dd4fe6929e71a582ffb7b2e8beedb: Bug 1715619 - Enable widget.macos.support-dark-appearance by default on Nightly and Early Beta. r=mstange
Harry Twyford <htwyford@mozilla.com> - Wed, 09 Jun 2021 21:01:06 +0000 - rev 582553
Push 38527 by ncsoregi@mozilla.com at Thu, 10 Jun 2021 03:46:06 +0000
Bug 1715619 - Enable widget.macos.support-dark-appearance by default on Nightly and Early Beta. r=mstange Differential Revision: https://phabricator.services.mozilla.com/D117357
56aa4be0522c12a278dea513f518054500f90d3c: Bug 1710164 - Use appropriate system colors for in-content pages in HCM on macOS. r=mstange,desktop-theme-reviewers,dao
Harry Twyford <htwyford@mozilla.com> - Wed, 09 Jun 2021 20:02:14 +0000 - rev 582544
Push 38527 by ncsoregi@mozilla.com at Thu, 10 Jun 2021 03:46:06 +0000
Bug 1710164 - Use appropriate system colors for in-content pages in HCM on macOS. r=mstange,desktop-theme-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D115649
806def5efd965e3350ced789156ed7acdfeb8d73: Bug 1714524 - Don't draw native theme focus outlines if the author specifies a non-auto outline. r=mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 08 Jun 2021 12:16:08 +0000 - rev 582211
Push 38524 by nbeleuzu@mozilla.com at Tue, 08 Jun 2021 21:57:51 +0000
Bug 1714524 - Don't draw native theme focus outlines if the author specifies a non-auto outline. r=mstange While this doesn't match traditional Gecko behavior, the non-native theme has much more opinionated focus outlines so I think this makes sense. It also matches Safari and Chrome, afaict. Differential Revision: https://phabricator.services.mozilla.com/D116831
c97ffb4d1b95626ddd8f0986a412a7189826784d: Bug 1714524 - Don't draw native theme focus outlines if the author specifies a non-auto outline. r=mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 07 Jun 2021 23:54:21 +0000 - rev 582157
Push 38522 by archaeopteryx@coole-files.de at Tue, 08 Jun 2021 09:18:19 +0000
Bug 1714524 - Don't draw native theme focus outlines if the author specifies a non-auto outline. r=mstange While this doesn't match traditional Gecko behavior, the non-native theme has much more opinionated focus outlines so I think this makes sense. It also matches Safari and Chrome, afaict. Differential Revision: https://phabricator.services.mozilla.com/D116831
647c4394be56d3118bad829a14a70ff37bcad037: WIP: Bug 1708121, keep ticking after page load r=mstange
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 27 May 2021 16:08:04 +0000 - rev 580995
Push 38497 by apavel@mozilla.com at Thu, 27 May 2021 21:28:01 +0000
WIP: Bug 1708121, keep ticking after page load r=mstange Differential Revision: https://phabricator.services.mozilla.com/D116040
04e81660c75f672645af2a8694194d21e112bacc: Bug 1669840 Part 1 - Allow applying opacity to nsDisplayBackgroundImage items r=jrmuizel,mstange
Miko Mynttinen <mikokm@gmail.com> - Sun, 23 May 2021 00:09:03 +0000 - rev 580498
Push 38485 by cbrindusan@mozilla.com at Sun, 23 May 2021 09:23:07 +0000
Bug 1669840 Part 1 - Allow applying opacity to nsDisplayBackgroundImage items r=jrmuizel,mstange Differential Revision: https://phabricator.services.mozilla.com/D92941
a4d21aa2f97d277ac9fa2f97d040b5c3f942c554: Bug 1669840 Part 1 - Allow applying opacity to nsDisplayBackgroundImage items r=jrmuizel,mstange
Miko Mynttinen <mikokm@gmail.com> - Thu, 20 May 2021 21:02:52 +0000 - rev 580336
Push 38479 by malexandru@mozilla.com at Fri, 21 May 2021 09:57:54 +0000
Bug 1669840 Part 1 - Allow applying opacity to nsDisplayBackgroundImage items r=jrmuizel,mstange Differential Revision: https://phabricator.services.mozilla.com/D92941
8444d88d18697206fa34c99acebd41f61497dccd: Bug 1669840 Part 1 - Allow applying opacity to nsDisplayBackgroundImage items r=jrmuizel,mstange
Miko Mynttinen <mikokm@gmail.com> - Thu, 20 May 2021 15:59:04 +0000 - rev 580290
Push 38479 by malexandru@mozilla.com at Fri, 21 May 2021 09:57:54 +0000
Bug 1669840 Part 1 - Allow applying opacity to nsDisplayBackgroundImage items r=jrmuizel,mstange Differential Revision: https://phabricator.services.mozilla.com/D92941
3f007ac3eea6eaec5bddfc97ef686cf15effac16: Bug 1710533 - Apply the widget size constraints to newBounds r=mstange,gfx-reviewers
sotaro <sotaro.ikeda.g@gmail.com> - Thu, 13 May 2021 09:34:26 +0000 - rev 579570
Push 38460 by imoraru@mozilla.com at Thu, 13 May 2021 21:48:00 +0000
Bug 1710533 - Apply the widget size constraints to newBounds r=mstange,gfx-reviewers When nsView::CalcWidgetBounds() size might be applied to widget with modification. And next widget->GetClientBounds() could be different than nsView::CalcWidgetBounds() again with several reasons. But it seems OK to apply widget->ConstrainSize() in nsView::DoResetWidgetBounds(). It could remove repaint because of widget->ConstrainSize() call in the Resize(). Differential Revision: https://phabricator.services.mozilla.com/D114814
79a02e8fc876666721aa7d31c889385ff16cf349: Bug 1707832: Ensure that SurfacePoolCA doesn't store or give out null recycled surfaces. r=mstange
Brad Werth <bwerth@mozilla.com> - Wed, 12 May 2021 22:38:52 +0000 - rev 579541
Push 38459 by ncsoregi@mozilla.com at Thu, 13 May 2021 09:33:03 +0000
Bug 1707832: Ensure that SurfacePoolCA doesn't store or give out null recycled surfaces. r=mstange The general contract of a SurfacePoolEntry is that mIOSurface should be non-null, but this isn't asserted. This patch adds release asserts to ensure that these surfaces are non-null at the time they are stored and released. It is one of the possible non-OOM ways that NativeLayerCA::NextSurface could store a null surface. Differential Revision: https://phabricator.services.mozilla.com/D113870
5073cf1f18fa91a88c56810c6fe41a339b617ed9: Bug 1709173 - Extend the checkmark phase of the download-finish animation by 100 frames. r=sfoster,mstange
Jared Wein <jwein@mozilla.com> - Wed, 12 May 2021 19:33:12 +0000 - rev 579525
Push 38458 by abutkovits@mozilla.com at Thu, 13 May 2021 03:26:48 +0000
Bug 1709173 - Extend the checkmark phase of the download-finish animation by 100 frames. r=sfoster,mstange Differential Revision: https://phabricator.services.mozilla.com/D114396
64abec51f1cb5e876da8adb3a475384e147fdc31: Bug 1710533 - Apply the widget size constraints to newBounds r=mstange,gfx-reviewers
sotaro <sotaro.ikeda.g@gmail.com> - Wed, 12 May 2021 16:34:54 +0000 - rev 579496
Push 38458 by abutkovits@mozilla.com at Thu, 13 May 2021 03:26:48 +0000
Bug 1710533 - Apply the widget size constraints to newBounds r=mstange,gfx-reviewers When nsView::CalcWidgetBounds() size might be applied to widget with modification. And next widget->GetClientBounds() could be different than nsView::CalcWidgetBounds() again with several reasons. But it seems OK to apply widget->ConstrainSize() in nsView::DoResetWidgetBounds(). It could remove repaint because of widget->ConstrainSize() call in the Resize(). Differential Revision: https://phabricator.services.mozilla.com/D114814
26b31c2612b4b6ea5b1771b3bdef1031f457a98f: Bug 454059 - Generate hyperlinks in PDF output for HTML link elements. r=mstange,mattwoodrow
Jonathan Kew <jkew@mozilla.com> - Tue, 11 May 2021 17:00:30 +0000 - rev 579393
Push 38454 by smolnar@mozilla.com at Tue, 11 May 2021 21:39:06 +0000
Bug 454059 - Generate hyperlinks in PDF output for HTML link elements. r=mstange,mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D114208
5d1efa61543d3a464e98767ef97cf081e65c0682: Bug 454059 - Add a new PaintForPrinting display list builder mode, and only create a Linkifier when printing. r=mstange
Jonathan Kew <jkew@mozilla.com> - Tue, 11 May 2021 17:00:30 +0000 - rev 579392
Push 38454 by smolnar@mozilla.com at Tue, 11 May 2021 21:39:06 +0000
Bug 454059 - Add a new PaintForPrinting display list builder mode, and only create a Linkifier when printing. r=mstange Differential Revision: https://phabricator.services.mozilla.com/D114474
93850ff5a79f4483ce04a5cdc847d5ebe1d0c7de: Bug 1710324 - Tweak dark background detection so that it works for XUL use cases. r=mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 11 May 2021 13:57:18 +0000 - rev 579364
Push 38453 by cbrindusan@mozilla.com at Tue, 11 May 2021 16:15:28 +0000
Bug 1710324 - Tweak dark background detection so that it works for XUL use cases. r=mstange Two changes: * Make it work across document boundaries, so that it works on e.g., the bookmarks sidebar. * Don't bail out if there's no scrollable frame, as XUL <tree>s use raw <scrollbar> elements without any scrollframe (gnarly). In that case, just use the target frame, but make sure to skip over themed elements (like the scrollbars themselves) so that we can find the right background. The logic to check the canvas frame background etcetera was simpler in FindNonTransparentBackgroundFrame. The only caller other than the scrollbar darkening code is nsTextFrame, which should find a non-canvas frame before anyways, but it doesn't hurt there. Differential Revision: https://phabricator.services.mozilla.com/D114697
ac3dcf91080f8e37d4dc62bb4781e03b1c3c548f: Bug 1699985 - Implement basic native Wayland compositor backend, r=stransky,mstange,aosmond
Robert Mader <robert.mader@posteo.de> - Tue, 11 May 2021 13:38:59 +0000 - rev 579362
Push 38453 by cbrindusan@mozilla.com at Tue, 11 May 2021 16:15:28 +0000
Bug 1699985 - Implement basic native Wayland compositor backend, r=stransky,mstange,aosmond This implements a mostly working native backend for Wayland. It can be enabled via `gfx.webrender.compositor.force-enabled`. The focus here was to get a basic structure in place while mini- mising changes in shared code. Known issues and limitations: - No readback - this will likely require an internal compositor again, as Wayland doesn't allow easily allow readback of the composited image, at least not without asking for permission. Alternatively, a new Wayland extension could be written for it. - Frame-call related issues when using a compositor that optimizes them (e.g. Gnome-Shell). This will be fixed in a follow-up, in the mean time disabling `widget.wayland.opaque-region.enabled` and `widget.wayland.vsync.enabled` works around the issues. - Only works on Weston or very recent versions of Gnome-Shell, see bug 1699754 Differential Revision: https://phabricator.services.mozilla.com/D111662
aa852464d828d28da1b8772a95f836ddc13522eb: Bug 1710324 - Tweak dark background detection so that it works for XUL use cases. r=mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 10 May 2021 23:33:33 +0000 - rev 579299
Push 38452 by imoraru@mozilla.com at Tue, 11 May 2021 09:33:39 +0000
Bug 1710324 - Tweak dark background detection so that it works for XUL use cases. r=mstange Two changes: * Make it work across document boundaries, so that it works on e.g., the bookmarks sidebar. * Don't bail out if there's no scrollable frame, as XUL <tree>s use raw <scrollbar> elements without any scrollframe (gnarly). In that case, just use the target frame, but make sure to skip over themed elements (like the scrollbars themselves) so that we can find the right background. The logic to check the canvas frame background etcetera was simpler in FindNonTransparentBackgroundFrame. The only caller other than the scrollbar darkening code is nsTextFrame, which should find a non-canvas frame before anyways, but it doesn't hurt there. Differential Revision: https://phabricator.services.mozilla.com/D114697
3aa2ee5149389cf0bd39e22b15c79a3eea121c29: Bug 1709900 - Do not call ScreenshotGrabber::MaybeGrabScreenshot() when RenderCompositorLayersSWGL::mCompositingStarted is false r=mstange,gfx-reviewers
sotaro <sotaro.ikeda.g@gmail.com> - Mon, 10 May 2021 20:48:02 +0000 - rev 579290
Push 38452 by imoraru@mozilla.com at Tue, 11 May 2021 09:33:39 +0000
Bug 1709900 - Do not call ScreenshotGrabber::MaybeGrabScreenshot() when RenderCompositorLayersSWGL::mCompositingStarted is false r=mstange,gfx-reviewers mCompositor->BeginFrameForWindow() needs to be called for ScreenshotGrabber::MaybeGrabScreenshot() with CompositorD3D11. Differential Revision: https://phabricator.services.mozilla.com/D114714
98b251a30b42e435eb73a448008eee724a4e97a8: Bug 1709439, activateItem should allow any descendant of an open submenu to be used, r=mstange,emilio
Neil Deakin <neil@mozilla.com> - Mon, 10 May 2021 18:44:03 +0000 - rev 579267
Push 38451 by ncsoregi@mozilla.com at Tue, 11 May 2021 02:09:31 +0000
Bug 1709439, activateItem should allow any descendant of an open submenu to be used, r=mstange,emilio This patch also fixes an issue where hidden native items could be activated, and makes the error message consistent between both implementations in this case. Differential Revision: https://phabricator.services.mozilla.com/D114503
f8c4ab91bbbff043768b2aa86b2127264bd005b9: Bug 1710269 - Use the correct system colors for Window/WindowFrame on macOS. r=mac-reviewers,mstange
Harry Twyford <htwyford@mozilla.com> - Mon, 10 May 2021 15:47:29 +0000 - rev 579247
Push 38451 by ncsoregi@mozilla.com at Tue, 11 May 2021 02:09:31 +0000
Bug 1710269 - Use the correct system colors for Window/WindowFrame on macOS. r=mac-reviewers,mstange The sanitize window is the only place we use these colors on macOS: https://searchfox.org/mozilla-central/search?q=Window&path=.css&case=true&regexp=false. They're also used in toolkit/themes/shared/notification.css, but we override the notification API with macOS native notifications. Differential Revision: https://phabricator.services.mozilla.com/D114752
ed8ff73df9a2bc82aa1a59a4d8106043c5b335c3: Bug 1708325 - Allow doing an extra refresh driver tick for user input events. r=mstange,bas
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 10 May 2021 00:00:51 +0000 - rev 579196
Push 38449 by abutkovits@mozilla.com at Mon, 10 May 2021 09:35:55 +0000
Bug 1708325 - Allow doing an extra refresh driver tick for user input events. r=mstange,bas Differential Revision: https://phabricator.services.mozilla.com/D113737
c26142ed63a90f324ffe350c352b92b6591023f5: Bug 1708325 - Change frame throttling code in nsRefreshDriver to explicitly track the pending frames. r=mstange
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 10 May 2021 00:00:50 +0000 - rev 579195
Push 38449 by abutkovits@mozilla.com at Mon, 10 May 2021 09:35:55 +0000
Bug 1708325 - Change frame throttling code in nsRefreshDriver to explicitly track the pending frames. r=mstange This makes it easier to understand and will make it easier to not include 'extra' frames (as we're hoping they will coalesce with the original frame on the compositor). Differential Revision: https://phabricator.services.mozilla.com/D113736
3fe338644983f2459578097142f226d92aaa41c5: Bug 1708325 - Allow doing an extra refresh driver tick for user input events. r=mstange,bas
Matt Woodrow <mwoodrow@mozilla.com> - Sun, 09 May 2021 22:35:44 +0000 - rev 579193
Push 38449 by abutkovits@mozilla.com at Mon, 10 May 2021 09:35:55 +0000
Bug 1708325 - Allow doing an extra refresh driver tick for user input events. r=mstange,bas Differential Revision: https://phabricator.services.mozilla.com/D113737
edf1ac18cc8ccddb0619d1a06870f265af5c23d1: Bug 1708325 - Change frame throttling code in nsRefreshDriver to explicitly track the pending frames. r=mstange
Matt Woodrow <mwoodrow@mozilla.com> - Sun, 09 May 2021 22:35:44 +0000 - rev 579192
Push 38449 by abutkovits@mozilla.com at Mon, 10 May 2021 09:35:55 +0000
Bug 1708325 - Change frame throttling code in nsRefreshDriver to explicitly track the pending frames. r=mstange This makes it easier to understand and will make it easier to not include 'extra' frames (as we're hoping they will coalesce with the original frame on the compositor). Differential Revision: https://phabricator.services.mozilla.com/D113736
89c299ded7a275459397c74df011e097b8db244e: Bug 1698754 - Set listbox backgrounds to controlBackgroundColor. r=mstange
Harry Twyford <htwyford@mozilla.com> - Fri, 07 May 2021 23:33:24 +0000 - rev 578927
Push 38446 by nerli@mozilla.com at Sat, 08 May 2021 09:56:13 +0000
Bug 1698754 - Set listbox backgrounds to controlBackgroundColor. r=mstange Differential Revision: https://phabricator.services.mozilla.com/D114650
52ebc9d40f371f853da03bf9fbb2cff418a7744a: Bug 1698763 - Part 3 - Remove custom 10.15-style toolbarbuttons. r=mac-reviewers,mstange
Harry Twyford <htwyford@mozilla.com> - Fri, 07 May 2021 16:23:13 +0000 - rev 578884
Push 38445 by imoraru@mozilla.com at Fri, 07 May 2021 21:46:25 +0000
Bug 1698763 - Part 3 - Remove custom 10.15-style toolbarbuttons. r=mac-reviewers,mstange Differential Revision: https://phabricator.services.mozilla.com/D114410
c1188e42ad46a17a12fe783bd1b9ae39b7b8538a: Bug 1698763 - Part 2 - Draw treeheadercells with NSTableHeaderCell. r=mstange
Harry Twyford <htwyford@mozilla.com> - Fri, 07 May 2021 16:23:12 +0000 - rev 578883
Push 38445 by imoraru@mozilla.com at Fri, 07 May 2021 21:46:25 +0000
Bug 1698763 - Part 2 - Draw treeheadercells with NSTableHeaderCell. r=mstange Differential Revision: https://phabricator.services.mozilla.com/D114409
f3f7f23f3ec0f54e525c8c7559c217377218c9cb: Bug 1698763 - Part 1 - Use color-mix for borders in macOS Library window. r=mac-reviewers,mstange
Harry Twyford <htwyford@mozilla.com> - Fri, 07 May 2021 16:23:12 +0000 - rev 578882
Push 38445 by imoraru@mozilla.com at Fri, 07 May 2021 21:46:25 +0000
Bug 1698763 - Part 1 - Use color-mix for borders in macOS Library window. r=mac-reviewers,mstange Differential Revision: https://phabricator.services.mozilla.com/D114408
e7f5b9027004c5cf713708fa53bee4e51918e1bb: Bug 1709634 - Fix -moz-accent-color on macOS. r=mstange,mac-reviewers
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 06 May 2021 01:22:53 +0000 - rev 578660
Push 38439 by cbrindusan@mozilla.com at Thu, 06 May 2021 09:25:58 +0000
Bug 1709634 - Fix -moz-accent-color on macOS. r=mstange,mac-reviewers When I initially implemented it for GTK, I just followed the Highlight color everywhere, but on macOS it makes of course a lot of sense to use NSColor.controlAccentColor. Differential Revision: https://phabricator.services.mozilla.com/D114430
7addaf5b3a614796465ddd45234fd8725e775178: Bug 1708562 - avoid stopping the profiler on customizationchange events when profiling mochitests, r=mstange,julienw.
Florian Quèze <florian@queze.net> - Mon, 03 May 2021 18:44:12 +0000 - rev 578342
Push 38430 by cbrindusan@mozilla.com at Mon, 03 May 2021 21:42:10 +0000
Bug 1708562 - avoid stopping the profiler on customizationchange events when profiling mochitests, r=mstange,julienw. Differential Revision: https://phabricator.services.mozilla.com/D113880
d689f6b43a56fd367b8c30b015a17a7fcd1949da: Bug 1706901 - Allow the toolbar to shift with position: relative. r=mstange,desktop-theme-reviewers,dao
Harry Twyford <htwyford@mozilla.com> - Wed, 28 Apr 2021 20:15:38 +0000 - rev 577889
Push 38417 by imoraru@mozilla.com at Thu, 29 Apr 2021 09:26:05 +0000
Bug 1706901 - Allow the toolbar to shift with position: relative. r=mstange,desktop-theme-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D113612