searching for reviewer(mixedpuppy)
969ae3ea41e7313a820272e41ca9aa97e973e5e1: Bug 1781998 - Make hidden and browser_action or action mutually exclusive. r=mixedpuppy
William Durand <will+git@drnd.me> - Mon, 08 Aug 2022 17:09:39 +0000 - rev 626432
Push 40101 by nerli@mozilla.com at Tue, 09 Aug 2022 03:57:17 +0000
Bug 1781998 - Make hidden and browser_action or action mutually exclusive. r=mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D153924
a920014426ba2d053c421ec24a490040f780024b: Bug 1728482 - Add to browser_newwindow.js an explicit await on BTU.openNewForegroundTab returned promise. r=mixedpuppy
Luca Greco <lgreco@mozilla.com> - Thu, 04 Aug 2022 15:38:31 +0000 - rev 626218
Push 40087 by nfay@mozilla.com at Fri, 05 Aug 2022 09:28:51 +0000
Bug 1728482 - Add to browser_newwindow.js an explicit await on BTU.openNewForegroundTab returned promise. r=mixedpuppy Unfortunately I was not able to trigger locally the same unhandled rejection (`tabbrowser.ownerGlobal.windowGlobalChild is null` triggered by BTU.openNewForegroundTab from BrowserTestUtils.jsm line 279), but looking to the test case it seems not unlikely that the test case may be getting to the call to `BTU.closeWindow` (nearby the end of `finish_test` test helper function) while the promise returned from BTU.openNewForegroundTab was not resolved yet and that the call to BTU.openNewForegroundTab is then trying to access tabbrowser.ownerGlobal.windowGlobalChild well the tab and the window where it was open are already gone. This patch adds an explicit await on the promise returned by BTU.openNewForegroundTab right before calling BTU.closeWindow to make sure that the browser window containing that tab isn't closed until BTU.openNewForegroundTab promise is resolved. Differential Revision: https://phabricator.services.mozilla.com/D153375
891d9a47a5c0fa7b196b5d22d094afd73398dcab: Bug 1781512 - Fix browser_ext_getViews.js test_getViews_excludes_blocked_parsing_documents intermittent. r=mixedpuppy
Luca Greco <lgreco@mozilla.com> - Thu, 04 Aug 2022 15:36:30 +0000 - rev 626217
Push 40087 by nfay@mozilla.com at Fri, 05 Aug 2022 09:28:51 +0000
Bug 1781512 - Fix browser_ext_getViews.js test_getViews_excludes_blocked_parsing_documents intermittent. r=mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D153094
2452afd0a51668e56d87580798eeba7795161612: Bug 1772943 - Port osfile.jsm usage to IOUtils in toolkit/mozapps/ r=Gijs,mixedpuppy
Barret Rennie <barret@brennie.ca> - Thu, 28 Jul 2022 20:21:55 +0000 - rev 625441
Push 40051 by ccozmuta@mozilla.com at Fri, 29 Jul 2022 03:54:04 +0000
Bug 1772943 - Port osfile.jsm usage to IOUtils in toolkit/mozapps/ r=Gijs,mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D148967
baf27e2f44d6297fc4aef99d0139ae891ef06fd8: Bug 1777483 - Part 3 - Open context menu when clicking the menu button. r=mixedpuppy
William Durand <will+git@drnd.me> - Thu, 28 Jul 2022 20:13:49 +0000 - rev 625439
Push 40051 by ccozmuta@mozilla.com at Fri, 29 Jul 2022 03:54:04 +0000
Bug 1777483 - Part 3 - Open context menu when clicking the menu button. r=mixedpuppy This patch allows to open the context menu on (primary) button click, and that also works with keyboard navigation. Depends on D152755 Differential Revision: https://phabricator.services.mozilla.com/D152853
9207592916180ec80a025b4ad55800fec06f3939: Bug 1777483 - Part 1 - Add a new context menu for extensions in the unified extensions panel. r=mixedpuppy,desktop-theme-reviewers
William Durand <will+git@drnd.me> - Thu, 28 Jul 2022 20:13:48 +0000 - rev 625437
Push 40051 by ccozmuta@mozilla.com at Fri, 29 Jul 2022 03:54:04 +0000
Bug 1777483 - Part 1 - Add a new context menu for extensions in the unified extensions panel. r=mixedpuppy,desktop-theme-reviewers Differential Revision: https://phabricator.services.mozilla.com/D152665
df2c0e3d08ee18b6f63416f8edade39b81dbe852: Bug 1780680 - More cleanly return "normal" state for closed windows. r=mixedpuppy
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 26 Jul 2022 12:02:46 +0000 - rev 625144
Push 40037 by nfay@mozilla.com at Tue, 26 Jul 2022 15:39:15 +0000
Bug 1780680 - More cleanly return "normal" state for closed windows. r=mixedpuppy It bit me in the dependent bug because bug, see the comment in: https://hg.mozilla.org/integration/autoland/rev/8bbec265ab8c Differential Revision: https://phabricator.services.mozilla.com/D152480
b45962248b4c58a74879a798fcfa4014045e133b: Bug 1780229 - Prevent test_ext_native_messaging.js intermittent failures. r=mixedpuppy
Luca Greco <lgreco@mozilla.com> - Fri, 22 Jul 2022 08:10:25 +0000 - rev 624883
Push 40019 by imoraru@mozilla.com at Fri, 22 Jul 2022 21:46:25 +0000
Bug 1780229 - Prevent test_ext_native_messaging.js intermittent failures. r=mixedpuppy This patch includes the following tweaks to the new test cases as introduced from Bug 1770696: - Added an explicit `await waitForSubprocessExit();` to the two new test cases which are starting a NativeApplication as part of the test case, to make sure to wait for the subprocess to have been fully exited, otherwise that triggers a failure on windows 10 because the files that should be removed when the test task is exiting would still be in use (and trying to remove them fails only on the windows platform) - Reworked the NativeApp used by the testSendNativeMessage test task to don't wrongly assume the NativeApp handling all the messages sent to be the same one even if one is still running to handle a delayed message pending a reply: - Each sendNativeMessage call will be spawning its own NativeApp instance and so the test native app is now resorting to a `time.sleep(...)` call to delay replying to any message received, to give some time for the test case to cover the behavior expected while a native message is still pending a reply. - Added Some stderr logs to the NativeApp, to make it easier to see at which point of the test case the NativeApp is being started, replying to a message and terminated, along with including the process pid to more easily determine if the NativeApp instance is still the one we expect to be running and replying to the native messages received. Differential Revision: https://phabricator.services.mozilla.com/D152292
81c9cc81146b08ed739c7218b206d4bcfed1d9b3: Bug 1780372 - Make extension APIs deal with async window state changes. r=mixedpuppy
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 21 Jul 2022 23:04:08 +0000 - rev 624832
Push 40014 by abutkovits@mozilla.com at Fri, 22 Jul 2022 03:25:11 +0000
Bug 1780372 - Make extension APIs deal with async window state changes. r=mixedpuppy Before my previous patch, the widget code lied, and always returned the requested window state before it had actually happened. Instead, teach the extension code to wait if necessary for the window state to be effective. Differential Revision: https://phabricator.services.mozilla.com/D152394
951002217e9f0add2ce093bf9975de8099dfc11a: Bug 1780576 - Clean up test_ext_userScripts_register.js on failure. r=extension-reviewers,mixedpuppy
Andrew McCreight <continuation@gmail.com> - Thu, 21 Jul 2022 17:55:45 +0000 - rev 624803
Push 40014 by abutkovits@mozilla.com at Fri, 22 Jul 2022 03:25:11 +0000
Bug 1780576 - Clean up test_ext_userScripts_register.js on failure. r=extension-reviewers,mixedpuppy equal throws immediately, so if it fails you get some follow-on failures because the test didn't clean up that make it confusing to figure out what actually failed. This patch fixes that by using registerCleanupFunction to remove the extension, and waits to do the check until after contentPage has been closed. Differential Revision: https://phabricator.services.mozilla.com/D152419
5a336820e40bb1d5878bf5dacc7be104140ce7d5: Bug 1756758 - Add support for `restrictSchemes` in `registerContentScripts()` (MV2). r=mixedpuppy
William Durand <will+git@drnd.me> - Thu, 21 Jul 2022 08:08:55 +0000 - rev 624727
Push 40011 by mlaza@mozilla.com at Thu, 21 Jul 2022 15:47:47 +0000
Bug 1756758 - Add support for `restrictSchemes` in `registerContentScripts()` (MV2). r=mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D147654
c6db198ff02c50edbc149735e55e9c3166a7e9aa: Bug 1772943 - Port osfile.jsm usage to IOUtils in toolkit/mozapps/ r=Gijs,mixedpuppy
Barret Rennie <barret@brennie.ca> - Thu, 21 Jul 2022 04:44:40 +0000 - rev 624713
Push 40011 by mlaza@mozilla.com at Thu, 21 Jul 2022 15:47:47 +0000
Bug 1772943 - Port osfile.jsm usage to IOUtils in toolkit/mozapps/ r=Gijs,mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D148967
332735992b446f420df154d331ef4d47a61bf92f: Bug 1779381 - Fully enable `browser_toolbar_prefers_color_scheme.js`. r=mixedpuppy
William Durand <will+git@drnd.me> - Wed, 20 Jul 2022 19:00:16 +0000 - rev 624559
Push 40008 by csabou@mozilla.com at Thu, 21 Jul 2022 03:47:38 +0000
Bug 1779381 - Fully enable `browser_toolbar_prefers_color_scheme.js`. r=mixedpuppy I was super conservative in Bug 1779380 because, although I couldn't reproduce actual failures locally, one of the leakcheck reports was consistently failing. I tested a few other things and it looks like some tests on MacOS often have leaks [1]. I get leakcheck errors with many other test files so I doubt it is this one specific test file. [1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1541628#c4 Differential Revision: https://phabricator.services.mozilla.com/D151914
8eebf167e42ccb0b5e47a8e203c9b0fa5202ea04: Bug 1780008 - browserAction preload popup should not be listed in extension.getViews results. r=mixedpuppy,willdurand
Luca Greco <lgreco@mozilla.com> - Tue, 19 Jul 2022 18:34:36 +0000 - rev 624395
Push 40005 by ncsoregi@mozilla.com at Wed, 20 Jul 2022 09:59:35 +0000
Bug 1780008 - browserAction preload popup should not be listed in extension.getViews results. r=mixedpuppy,willdurand Differential Revision: https://phabricator.services.mozilla.com/D152022
d9d595b22939271eaf75676007ec3ab2bd510bb1: Bug 1770696 - Reset the background script idle timer if the extension have native app ports still open. r=mixedpuppy
Luca Greco <lgreco@mozilla.com> - Tue, 19 Jul 2022 13:39:09 +0000 - rev 624363
Push 40003 by ctuns@mozilla.com at Tue, 19 Jul 2022 21:35:33 +0000
Bug 1770696 - Reset the background script idle timer if the extension have native app ports still open. r=mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D151647
d41d9a65cf6fb8f5b295d55eb0df452b5ac635a8: Bug 1773695 - Part 6: Removing the startup cache file in the beginning of the test test_ext_webRequest_urlclassification.js. r=mixedpuppy
Tim Huang <tihuang@mozilla.com> - Mon, 18 Jul 2022 21:48:16 +0000 - rev 624321
Push 40001 by abutkovits@mozilla.com at Tue, 19 Jul 2022 09:34:24 +0000
Bug 1773695 - Part 6: Removing the startup cache file in the beginning of the test test_ext_webRequest_urlclassification.js. r=mixedpuppy The patch adds a code to remove the startup cache file "webext.sc.lz4" before running the tests in test_ext_webRequest_urlclassification.js. This avoids the test to use an old web_request schema that is cached by the StartupCache. Depends on D151051 Differential Revision: https://phabricator.services.mozilla.com/D152029
cb8f4b8ff31d671e7dc967a25db1c89f655a11ec: Bug 1773695 - Part 4: Add email tracking flags to webrequest. r=mixedpuppy
Tim Huang <tihuang@mozilla.com> - Mon, 18 Jul 2022 21:48:16 +0000 - rev 624319
Push 40001 by abutkovits@mozilla.com at Tue, 19 Jul 2022 09:34:24 +0000
Bug 1773695 - Part 4: Add email tracking flags to webrequest. r=mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D151151
db926abd402c74707eae1166c5d58c0694cbc70f: Bug 1773695 - Part 4: Add email tracking flags to webrequest. r=mixedpuppy
Tim Huang <tihuang@mozilla.com> - Fri, 15 Jul 2022 14:30:21 +0000 - rev 624162
Push 39989 by apavel@mozilla.com at Fri, 15 Jul 2022 21:29:53 +0000
Bug 1773695 - Part 4: Add email tracking flags to webrequest. r=mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D151151
8f23067c327c4a82235719e5ae4c398bf13adb08: Bug 1762462 - Make tests in toolkit/components/extensions/test/ reflect Always Partitioning Storage; r=mixedpuppy
Thomas Wisniewski <twisniewski@mozilla.com> - Fri, 15 Jul 2022 13:26:23 +0000 - rev 624154
Push 39989 by apavel@mozilla.com at Fri, 15 Jul 2022 21:29:53 +0000
Bug 1762462 - Make tests in toolkit/components/extensions/test/ reflect Always Partitioning Storage; r=mixedpuppy Depends on D151393 Differential Revision: https://phabricator.services.mozilla.com/D151394
001c38822c532939379dd44319c93738779c9662: Bug 1773695 - Part 4: Add email tracking flags to webrequest. r=mixedpuppy
Tim Huang <tihuang@mozilla.com> - Thu, 14 Jul 2022 19:39:33 +0000 - rev 624072
Push 39985 by ctuns@mozilla.com at Fri, 15 Jul 2022 03:58:18 +0000
Bug 1773695 - Part 4: Add email tracking flags to webrequest. r=mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D151151
4e46a6f209b400b1285c0994fdde28313f1266d0: Bug 1762462 - Make tests in toolkit/components/extensions/test/ reflect Always Partitioning Storage; r=mixedpuppy
Thomas Wisniewski <twisniewski@mozilla.com> - Thu, 14 Jul 2022 19:26:32 +0000 - rev 624066
Push 39985 by ctuns@mozilla.com at Fri, 15 Jul 2022 03:58:18 +0000
Bug 1762462 - Make tests in toolkit/components/extensions/test/ reflect Always Partitioning Storage; r=mixedpuppy Depends on D151393 Differential Revision: https://phabricator.services.mozilla.com/D151394
17f012e450913d550cac207541b6fa6d3d5d8eea: Bug 1777402 - Remove WEBEXT_* userScripts API histograms and renew all the other ones expiring in Firefox 105. r=mixedpuppy
Luca Greco <lgreco@mozilla.com> - Thu, 14 Jul 2022 13:49:22 +0000 - rev 623946
Push 39984 by ccozmuta@mozilla.com at Thu, 14 Jul 2022 21:44:18 +0000
Bug 1777402 - Remove WEBEXT_* userScripts API histograms and renew all the other ones expiring in Firefox 105. r=mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D151032
a27ae15872a9c8c0f07957134a47e30d795c6212: Bug 1762462 - Make tests in toolkit/components/extensions/test/ reflect Always Partitioning Storage; r=mixedpuppy
Thomas Wisniewski <twisniewski@mozilla.com> - Wed, 13 Jul 2022 22:45:04 +0000 - rev 623877
Push 39980 by nfay@mozilla.com at Thu, 14 Jul 2022 03:48:49 +0000
Bug 1762462 - Make tests in toolkit/components/extensions/test/ reflect Always Partitioning Storage; r=mixedpuppy Depends on D151393 Differential Revision: https://phabricator.services.mozilla.com/D151394
e3ba86211812a83c970c347c9847169db1b02d5b: Bug 1772943 - Port osfile.jsm usage to IOUtils in toolkit/mozapps/ r=Gijs,mixedpuppy
Barret Rennie <barret@brennie.ca> - Tue, 12 Jul 2022 10:09:15 +0000 - rev 623630
Push 39972 by imoraru@mozilla.com at Tue, 12 Jul 2022 21:56:41 +0000
Bug 1772943 - Port osfile.jsm usage to IOUtils in toolkit/mozapps/ r=Gijs,mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D148967
e64335287775a14a194324f52a3ea7bd65198f79: Bug 1772943 - Port osfile.jsm usage to IOUtils in toolkit/mozapps/ r=Gijs,mixedpuppy
Barret Rennie <barret@brennie.ca> - Sun, 10 Jul 2022 02:04:13 +0000 - rev 623428
Push 39961 by ncsoregi@mozilla.com at Sun, 10 Jul 2022 09:44:29 +0000
Bug 1772943 - Port osfile.jsm usage to IOUtils in toolkit/mozapps/ r=Gijs,mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D148967
205ee354f1982f2a4badc380bdeda0d0dbb09f41: Bug 1777487 - Only query active StreamFilters if webRequestBlocking permission is granted and prevent race with extension shutdown. r=mixedpuppy
Luca Greco <lgreco@mozilla.com> - Thu, 07 Jul 2022 18:55:38 +0000 - rev 623255
Push 39951 by imoraru@mozilla.com at Fri, 08 Jul 2022 04:09:57 +0000
Bug 1777487 - Only query active StreamFilters if webRequestBlocking permission is granted and prevent race with extension shutdown. r=mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D150753
3bf89bb940fbff65a906417989cef419ffcd3708: Bug 1770651 - Make sure tabs.update don't use loadURI on a discarded tab. r=mixedpuppy
kernp25 <kernp25@yahoo.com> - Mon, 04 Jul 2022 09:10:38 +0000 - rev 622883
Push 39935 by ctuns@mozilla.com at Mon, 04 Jul 2022 21:42:52 +0000
Bug 1770651 - Make sure tabs.update don't use loadURI on a discarded tab. r=mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D149702
19ba3abb0124b13bf23df41b9b228495327f5031: Bug 1770030 - [Colorway Closet] Localize colorway names and descriptions. r=kpatenio,extension-reviewers,flod,rpl,mixedpuppy
Dão Gottwald <dao@mozilla.com> - Thu, 30 Jun 2022 19:44:31 +0000 - rev 622773
Push 39921 by smolnar@mozilla.com at Fri, 01 Jul 2022 04:18:35 +0000
Bug 1770030 - [Colorway Closet] Localize colorway names and descriptions. r=kpatenio,extension-reviewers,flod,rpl,mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D150510
4c9f1546521177b1fd2592597908bc7be9377e63: Bug 1774844 - avoid failures of the test_ext_geckoProfiler_schema.js test when running with a conditioned profile, r=extension-reviewers,mixedpuppy
Florian Quèze <florian@queze.net> - Wed, 29 Jun 2022 21:24:11 +0000 - rev 622608
Push 39918 by bszekely@mozilla.com at Thu, 30 Jun 2022 09:55:19 +0000
Bug 1774844 - avoid failures of the test_ext_geckoProfiler_schema.js test when running with a conditioned profile, r=extension-reviewers,mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D150615
53c490e52eb639ccf88ffe9fff6db010cc90209f: Bug 1685627 - Use extension CSP for workers with a moz-extension url. r=asuth,mixedpuppy
Luca Greco <lgreco@mozilla.com> - Tue, 28 Jun 2022 21:23:39 +0000 - rev 622393
Push 39912 by mlaza@mozilla.com at Wed, 29 Jun 2022 03:44:30 +0000
Bug 1685627 - Use extension CSP for workers with a moz-extension url. r=asuth,mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D149755
dc669c3991aac59e7c3237d454513d3a06842b1d: Bug 1772704 - Fix browser/components/extensions/test/browser/browser_ext_sessions_incognito.js test. r=mixedpuppy
kernp25 <kernp25@yahoo.com> - Thu, 23 Jun 2022 08:46:33 +0000 - rev 621856
Push 39889 by smolnar@mozilla.com at Thu, 23 Jun 2022 15:57:48 +0000
Bug 1772704 - Fix browser/components/extensions/test/browser/browser_ext_sessions_incognito.js test. r=mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D148344
fe89c8b44d1261af78acaad4897c37fff7fae59a: Bug 1771173 - Clean up unused definitions of console in extension modules. r=mixedpuppy
Mark Banner <standard8@mozilla.com> - Tue, 21 Jun 2022 20:42:15 +0000 - rev 621617
Push 39880 by ccozmuta@mozilla.com at Wed, 22 Jun 2022 03:32:25 +0000
Bug 1771173 - Clean up unused definitions of console in extension modules. r=mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D149785
b1415a0f03a0b11db5cbc8ab98c8b2de01342343: Bug 1771173 - Make XPIDatabase/XPIInstall lazy getters easier to work with linters. r=mixedpuppy
Mark Banner <standard8@mozilla.com> - Tue, 21 Jun 2022 20:42:15 +0000 - rev 621616
Push 39880 by ccozmuta@mozilla.com at Wed, 22 Jun 2022 03:32:25 +0000
Bug 1771173 - Make XPIDatabase/XPIInstall lazy getters easier to work with linters. r=mixedpuppy It is difficult for linters to analyse loops around functions which get symbols. Instead, use the symbols directly from the imported module. Differential Revision: https://phabricator.services.mozilla.com/D149717
e0df31655cc033f3f365d53e05fe92ffb9e62af0: Bug 1773762 - Add ifdefs to allow Thunderbird builds to use mozAddonManager. r=mixedpuppy
Rob Lemley <rob@thunderbird.net> - Fri, 17 Jun 2022 19:38:04 +0000 - rev 621322
Push 39865 by smolnar@mozilla.com at Sat, 18 Jun 2022 09:30:37 +0000
Bug 1773762 - Add ifdefs to allow Thunderbird builds to use mozAddonManager. r=mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D149340
9d1112a401dcca08f50e8f42d6bf5d28cbb5463a: Bug 1768722 - Use std::ofstream in nsProfiler::DumpProfileToFileAsync, and reject promise in case of failure - r=florian,mixedpuppy
Gerald Squelart <gsquelart@mozilla.com> - Wed, 15 Jun 2022 06:12:08 +0000 - rev 620929
Push 39854 by imoraru@mozilla.com at Wed, 15 Jun 2022 15:46:59 +0000
Bug 1768722 - Use std::ofstream in nsProfiler::DumpProfileToFileAsync, and reject promise in case of failure - r=florian,mixedpuppy The geckoProfiler.dumpProfileToFile (extension API) needed to be updated, to create the target directory if necessary. Some xpcshell tests would fail otherwise. Also improved nsIProfiler.idl docs of dumpProfileToFile{,Async}. *** Use ofstream, fixed xpcshell tests. Differential Revision: https://phabricator.services.mozilla.com/D148610
aeb84c394d41e49d5e377c3ec5776e89a2162d79: Bug 1772101 - Part 18: Use plain object for lazy getter in toolkit/components/extensions/ExtensionShortcuts.jsm. r=mixedpuppy,extension-reviewers
Tooru Fujisawa <arai_a@mac.com> - Tue, 07 Jun 2022 04:30:58 +0000 - rev 619891
Push 39810 by ccozmuta@mozilla.com at Tue, 07 Jun 2022 15:57:48 +0000
Bug 1772101 - Part 18: Use plain object for lazy getter in toolkit/components/extensions/ExtensionShortcuts.jsm. r=mixedpuppy,extension-reviewers Differential Revision: https://phabricator.services.mozilla.com/D147959
47bea50b199980b2393b81f8507beb1880d096fa: Bug 1772101 - Part 17: Use plain object for lazy getter in toolkit/components/extensions/. r=mixedpuppy
Tooru Fujisawa <arai_a@mac.com> - Tue, 07 Jun 2022 04:30:57 +0000 - rev 619890
Push 39810 by ccozmuta@mozilla.com at Tue, 07 Jun 2022 15:57:48 +0000
Bug 1772101 - Part 17: Use plain object for lazy getter in toolkit/components/extensions/. r=mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D147958
52aefe6ea99743be642d723078fed0b51873ee11: Bug 1772099 - Part 8: Use plain object for lazy getter in toolkit/mozapps/extensions/. r=mixedpuppy
Tooru Fujisawa <arai_a@mac.com> - Tue, 07 Jun 2022 04:29:51 +0000 - rev 619875
Push 39810 by ccozmuta@mozilla.com at Tue, 07 Jun 2022 15:57:48 +0000
Bug 1772099 - Part 8: Use plain object for lazy getter in toolkit/mozapps/extensions/. r=mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D147934
1cfa66fd30720ec79d5ecb00d34eb08f3742b6d9: Bug 1772100 - Part 8: Use plain object for lazy getter in browser/components/extensions/. r=mixedpuppy
Tooru Fujisawa <arai_a@mac.com> - Mon, 06 Jun 2022 22:46:22 +0000 - rev 619839
Push 39807 by abutkovits@mozilla.com at Tue, 07 Jun 2022 04:23:49 +0000
Bug 1772100 - Part 8: Use plain object for lazy getter in browser/components/extensions/. r=mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D148018
755482f14c262f2aed36a91ec88e518ba39ba2d0: Bug 1769143 - add new colorways section and colorways collection card in about:addon. r=dao,fluent-reviewers,mixedpuppy
Katherine Patenio <kpatenio@mozilla.com> - Tue, 31 May 2022 15:54:27 +0000 - rev 619324
Push 39777 by smolnar@mozilla.com at Tue, 31 May 2022 21:47:21 +0000
Bug 1769143 - add new colorways section and colorways collection card in about:addon. r=dao,fluent-reviewers,mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D146583
1561d8316c29da5cb0a9e55964c22d874a62e146: Bug 1739114 Enforce addon privilege during manifest parsing for access to privileged features from temporarily installed addons. r=robwu,mixedpuppy,willdurand
Shane Caraveo <scaraveo@mozilla.com> - Mon, 30 May 2022 18:41:37 +0000 - rev 619213
Push 39773 by ccozmuta@mozilla.com at Tue, 31 May 2022 04:09:28 +0000
Bug 1739114 Enforce addon privilege during manifest parsing for access to privileged features from temporarily installed addons. r=robwu,mixedpuppy,willdurand Differential Revision: https://phabricator.services.mozilla.com/D145687
c69d8f06c75bd10f88071cf0550509b3504602ef: Bug 1767550 - Make sure defaultSearch overrides levelOfControl is consistent with the default engine currently set before overriding the current default. r=mixedpuppy
Luca Greco <lgreco@mozilla.com> - Wed, 25 May 2022 18:46:12 +0000 - rev 618887
Push 39750 by nfay@mozilla.com at Thu, 26 May 2022 09:33:28 +0000
Bug 1767550 - Make sure defaultSearch overrides levelOfControl is consistent with the default engine currently set before overriding the current default. r=mixedpuppy For add-ons installed before the changes introduced by Bug 1757760 ExtensionSettingStorage.getLevelOfControl resolves to "controlled_by_this_extension" even if the user did not opt-in when prompted (either by never answer the prompt, or by setting No). The changes landed by Bug 1757760 did make sure that for a newly installed extensions ExtensionSettingsStorage.getLevelOfControl resolves to "controllable_by_this_extension" until the user actually explicitly opt-in to the default search engine provided by the installed extension, by making sure to initially set as disabled the defaultSearch setting for a newly installed extension (which will then be enabled if the user does explicitly opt-in). Unfortunately, that change doesn't have any effect if the extension has been installed in a Firefox version that did not yet include Bug 1757760 changes, in that case the setting listed in the pre-existing extension-settings.json file in the Firefox profile will still have the setting marked as enabled even if the user did never opt-in. This patch includes a new test task that is injecting into extension-settings.json the data needed to recreate the inconsistent state (level of control set to "controlled_by_this_extension" while the related search engine isn't actually set as default). In addition to the new test case, this patch is applying the following changes to `chrome_settings_overrides`: - in the `setDefault` method: if ExtensionSettingsStorage.getLevelOfControl resolves to "controlled_by_this_extension" but the default search engine currently set is not the one associated to the extension, then explicitly disable the setting and recompute the level of control (which will resolve to "controllable_by_this_extension" as a side effect of explicitly disable the setting) - in the `ensureSetting` method: remove the check on `item?.enabled`, because the result of ExtensionSettingsStorage.getSetting does actually never have an `enabled` property set, instead it is part of the content of the extension-settings.json file and it is used internally by ExtensionSettingsStorage without being returning in the format of the object returned by calling ExtensionSettingsStorage.getSetting (see https://searchfox.org/mozilla-central/rev/97c902e8f92b15dc63eb584bfc594ecb041242a4/toolkit/components/extensions/ExtensionSettingsStore.jsm#164-177) Differential Revision: https://phabricator.services.mozilla.com/D146294
770d8fede01a8390fe6bb7df2876db9df8da72ec: Bug 1770896 - Remove unused extensions.dtd file, r=mixedpuppy
Francesco Lodolo (:flod) <flod@lodolo.net> - Tue, 24 May 2022 16:26:40 +0000 - rev 618758
Push 39743 by mlaza@mozilla.com at Tue, 24 May 2022 21:44:48 +0000
Bug 1770896 - Remove unused extensions.dtd file, r=mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D147151
f9d3225a4e4c9c33b8f666070fc02f98a11d627b: Bug 1770468 - Report-only wasm-unsafe-eval in MV2 r=mixedpuppy,freddyb,ckerschb
Rob Wu <rob@robwu.nl> - Tue, 24 May 2022 13:56:22 +0000 - rev 618736
Push 39743 by mlaza@mozilla.com at Tue, 24 May 2022 21:44:48 +0000
Bug 1770468 - Report-only wasm-unsafe-eval in MV2 r=mixedpuppy,freddyb,ckerschb For backcompat, do not enforce wasm-unsafe-eval even if the extension has specified a custom CSP. Do report the errors though, to allow extension authors to discover the issue and fix it. Differential Revision: https://phabricator.services.mozilla.com/D147105
2285a531fc2de89c2263008783fc4d7af63e1512: Bug 1770468 - Refactor test_ext_wasm.js r=mixedpuppy
Rob Wu <rob@robwu.nl> - Tue, 24 May 2022 13:56:21 +0000 - rev 618735
Push 39743 by mlaza@mozilla.com at Tue, 24 May 2022 21:44:48 +0000
Bug 1770468 - Refactor test_ext_wasm.js r=mixedpuppy Refactor test to remove duplication, and onsecuritypolicyviolation event handler to observe CSP violation reports. Differential Revision: https://phabricator.services.mozilla.com/D147104
d8df5666ec7dab641fc5f321fac71d63229ca867: Bug 1752979 - Tests for file changes during addon installs r=mixedpuppy
Rob Wu <rob@robwu.nl> - Mon, 23 May 2022 12:39:10 +0000 - rev 618520
Push 39734 by nerli@mozilla.com at Mon, 23 May 2022 16:22:16 +0000
Bug 1752979 - Tests for file changes during addon installs r=mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D137693
37372e77b28202eed1ad2ae0f1b2994b36a02614: Bug 1739114 - Moved privileged WebExtensions permissions in their own JSONSchema type and added a new custom privileged keyword on each privileged manifest fields. r=robwu,mixedpuppy
Luca Greco <lgreco@mozilla.com> - Fri, 20 May 2022 08:55:03 +0000 - rev 618351
Push 39723 by abutkovits@mozilla.com at Fri, 20 May 2022 15:37:03 +0000
Bug 1739114 - Moved privileged WebExtensions permissions in their own JSONSchema type and added a new custom privileged keyword on each privileged manifest fields. r=robwu,mixedpuppy This patch includes only the subset of D145687 changes related to the reworked JSONSchema data, plus some minor changes to Schemas.jsm to take the new JSONSchema type ("PrivilegedPermissions") and the new custom JSONSchema keyword (the boolean "privileged" property used to identify manifest fields only allowed in privileged extensions). Besides the changes to the schema data, this patch is not expected to introduce any difference in behavior and so it could also land on its own if needed (and the rest of the changes landed separately). Differential Revision: https://phabricator.services.mozilla.com/D146800
d3577f741ef539b9e092e67defbe32556c3d47e2: Bug 1739114 - Moved privileged WebExtensions permissions in their own JSONSchema type and added a new custom privileged keyword on each privileged manifest fields. r=robwu,mixedpuppy
Luca Greco <lgreco@mozilla.com> - Thu, 19 May 2022 18:20:59 +0000 - rev 618271
Push 39722 by nfay@mozilla.com at Fri, 20 May 2022 09:31:26 +0000
Bug 1739114 - Moved privileged WebExtensions permissions in their own JSONSchema type and added a new custom privileged keyword on each privileged manifest fields. r=robwu,mixedpuppy This patch includes only the subset of D145687 changes related to the reworked JSONSchema data, plus some minor changes to Schemas.jsm to take the new JSONSchema type ("PrivilegedPermissions") and the new custom JSONSchema keyword (the boolean "privileged" property used to identify manifest fields only allowed in privileged extensions). Besides the changes to the schema data, this patch is not expected to introduce any difference in behavior and so it could also land on its own if needed (and the rest of the changes landed separately). Differential Revision: https://phabricator.services.mozilla.com/D146800
e0600a5f234b8590c9cb914613b7b069c41dcc70: Bug 1740263 - Continue to allow WASM by default in Webextensions v2. r=mixedpuppy,robwu
Tom Schuster <tschuster@mozilla.com> - Thu, 19 May 2022 14:13:51 +0000 - rev 618245
Push 39720 by nbeleuzu@mozilla.com at Thu, 19 May 2022 18:03:18 +0000
Bug 1740263 - Continue to allow WASM by default in Webextensions v2. r=mixedpuppy,robwu Differential Revision: https://phabricator.services.mozilla.com/D142953
2f5ec6ad0f8168ff57342b3bfaf09666b24851e6: Bug 1740263 - Continue to allow WASM by default in Webextensions v2. r=mixedpuppy,robwu
Tom Schuster <tschuster@mozilla.com> - Wed, 18 May 2022 21:39:30 +0000 - rev 618176
Push 39718 by ccozmuta@mozilla.com at Thu, 19 May 2022 09:37:29 +0000
Bug 1740263 - Continue to allow WASM by default in Webextensions v2. r=mixedpuppy,robwu Differential Revision: https://phabricator.services.mozilla.com/D142953