searching for reviewer(me)
1f2e86c2d6912946eac17beabdd27e4c42accf27: Bug 1525720 - Try to fix build bustage. r=me on a CLOSED TREE
Ryan Hunt <rhunt@eqrion.net> - Wed, 22 May 2019 16:03:26 -0500 - rev 475025
Push 36053 by btara@mozilla.com at Thu, 23 May 2019 04:41:59 +0000
Bug 1525720 - Try to fix build bustage. r=me on a CLOSED TREE
d95cd825926d605de6b821a4d99f01fb462d756f: Bug 1550889 - land NSS ec6843bc0ce7 UPGRADE_NSS_RELEASE, r=me
J.C. Jones <jc@mozilla.com> - Tue, 21 May 2019 20:39:24 +0000 - rev 475006
Push 36053 by btara@mozilla.com at Thu, 23 May 2019 04:41:59 +0000
Bug 1550889 - land NSS ec6843bc0ce7 UPGRADE_NSS_RELEASE, r=me
ff74ba96073a389344f51067f3e00f49eb5e0fb0: Make |ScriptSource::codeRetrievableData| set |ss->data| to contain |Retrievable<Unit>()|, not |Retrievable<char16_t>()| which obviously does not work for UTF-8. No bug, r=me as so stupidly trivially thinko-obvious to be not worth a review-interrupt on anyone
Jeff Walden <jwalden@mit.edu> - Tue, 21 May 2019 22:27:47 -0700 - rev 475001
Push 36053 by btara@mozilla.com at Thu, 23 May 2019 04:41:59 +0000
Make |ScriptSource::codeRetrievableData| set |ss->data| to contain |Retrievable<Unit>()|, not |Retrievable<char16_t>()| which obviously does not work for UTF-8. No bug, r=me as so stupidly trivially thinko-obvious to be not worth a review-interrupt on anyone
272a61f8978bd2ec910d6c4abc19d08d7d8cf5fd: bug 1553316: remote: update reference to sync communication; r=me a=doc
Andreas Tolfsen <ato@sny.no> - Tue, 21 May 2019 22:47:21 +0100 - rev 474914
Push 36051 by shindli@mozilla.com at Wed, 22 May 2019 15:28:21 +0000
bug 1553316: remote: update reference to sync communication; r=me a=doc The remote protocol work has moved from IRC to Slack. DONTBUILD
41abcc2640371974e4067240da2885ddcf0a805c: Bug 1551991 - followup: Don't derive the destructor of CounterSpeakAs so that we can return it safely by value in Win32. r=me
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 17 May 2019 05:23:26 +0200 - rev 474285
Push 36027 by shindli@mozilla.com at Fri, 17 May 2019 16:24:38 +0000
Bug 1551991 - followup: Don't derive the destructor of CounterSpeakAs so that we can return it safely by value in Win32. r=me
1be11bf256eea87f795b6cac5b3ee2656b98cc6f: Bug 1551745 - Remove false positive rooting hazard calculating allocation size until there's a fix r=me
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 16 May 2019 12:41:10 +0100 - rev 474126
Push 36023 by ncsoregi@mozilla.com at Thu, 16 May 2019 21:56:43 +0000
Bug 1551745 - Remove false positive rooting hazard calculating allocation size until there's a fix r=me
8e08545bfa2801b245bfdb2755da8563c7f2664b: Bug 1353312 - Add crashtest. r=me
Ryan VanderMeulen <ryanvm@gmail.com> - Tue, 14 May 2019 12:27:21 -0400 - rev 473809
Push 36016 by cbrindusan@mozilla.com at Tue, 14 May 2019 21:42:17 +0000
Bug 1353312 - Add crashtest. r=me
47ce033ef46a724bd37f1ce3743358de93888066: Bug 1340248 - Add crashtest. r=me
Ryan VanderMeulen <ryanvm@gmail.com> - Tue, 14 May 2019 12:21:55 -0400 - rev 473808
Push 36016 by cbrindusan@mozilla.com at Tue, 14 May 2019 21:42:17 +0000
Bug 1340248 - Add crashtest. r=me
4440662cd0177f3fc3200cff190daed47d71a167: Bug 1223368 - Followup: fix browser_inspector_search-01/06.js failures on a CLOSED TREE. r=me
Tim Nguyen <ntim.bugs@gmail.com> - Sat, 11 May 2019 21:00:17 +0200 - rev 473523
Push 36000 by nerli@mozilla.com at Sat, 11 May 2019 22:09:02 +0000
Bug 1223368 - Followup: fix browser_inspector_search-01/06.js failures on a CLOSED TREE. r=me
131aa3a88866bc3886463b9c53710522e061b12d: Bug 1539227 - land NSS NSS_3_44_RTM UPGRADE_NSS_RELEASE, r=me
J.C. Jones <jc@mozilla.com> - Fri, 10 May 2019 22:43:57 +0000 - rev 473511
Push 35999 by rmaries@mozilla.com at Sat, 11 May 2019 09:48:14 +0000
Bug 1539227 - land NSS NSS_3_44_RTM UPGRADE_NSS_RELEASE, r=me
34a413cfb0d225c4a2007b4d37bb63087d5a1436: Bug 1539227 - land NSS NSS_3_44_BETA3 UPGRADE_NSS_RELEASE, r=me
J.C. Jones <jc@mozilla.com> - Fri, 10 May 2019 16:53:27 +0000 - rev 473445
Push 35997 by dvarga@mozilla.com at Fri, 10 May 2019 21:49:31 +0000
Bug 1539227 - land NSS NSS_3_44_BETA3 UPGRADE_NSS_RELEASE, r=me
e68228c66c551c0e34b6e17454cd6909f910ef22: Bug 1539227 - land NSS NSS_3_44_BETA2 UPGRADE_NSS_RELEASE, r=me
J.C. Jones <jc@mozilla.com> - Tue, 07 May 2019 20:39:31 +0000 - rev 473048
Push 35987 by opoprus@mozilla.com at Wed, 08 May 2019 21:51:44 +0000
Bug 1539227 - land NSS NSS_3_44_BETA2 UPGRADE_NSS_RELEASE, r=me
08f33d113371a6ae036f9ea9de35f0df48ce4142: Bug 1539227 - land NSS NSS_3_44_BETA1 UPGRADE_NSS_RELEASE, r=me
J.C. Jones <jc@mozilla.com> - Sat, 04 May 2019 00:18:13 +0000 - rev 472736
Push 35977 by opoprus@mozilla.com at Mon, 06 May 2019 21:46:17 +0000
Bug 1539227 - land NSS NSS_3_44_BETA1 UPGRADE_NSS_RELEASE, r=me
0371011915fdf65cc123410f2be8198ae1da79a8: Bug 1540911 - Fix lint error r=me on a CLOSED TREE
Coroiu Cristina <ccoroiu@mozilla.com> - Fri, 03 May 2019 09:35:35 +0300 - rev 472430
Push 35956 by dluca@mozilla.com at Fri, 03 May 2019 12:59:14 +0000
Bug 1540911 - Fix lint error r=me on a CLOSED TREE
11f4bd1a3b416c6b892b3dde7e6069b5de04c97f: Bug 1539227 - land NSS 4e4eb31ce200 UPGRADE_NSS_RELEASE, r=me
J.C. Jones <jc@mozilla.com> - Wed, 01 May 2019 19:07:31 +0000 - rev 472284
Push 35953 by rgurzau@mozilla.com at Thu, 02 May 2019 22:03:33 +0000
Bug 1539227 - land NSS 4e4eb31ce200 UPGRADE_NSS_RELEASE, r=me
ad1c4dfe793c9ac49b511eb02cc3626e712677b6: Bug 1548057 - followup: Unbust opt builds. r=me
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 01 May 2019 17:00:42 +0200 - rev 472120
Push 35948 by nerli@mozilla.com at Wed, 01 May 2019 21:55:33 +0000
Bug 1548057 - followup: Unbust opt builds. r=me CLOSED TREE
0353393f9465101ca820aaa0bc2b495ca85f5485: No Bug: Update directory ownership for some web platform tests. r=me
David Burns <dburns@mozilla.com> - Tue, 30 Apr 2019 21:20:13 +0100 - rev 472097
Push 35947 by apavel@mozilla.com at Wed, 01 May 2019 15:57:23 +0000
No Bug: Update directory ownership for some web platform tests. r=me
f35554baa67f6159f3b13de8fb9335b24c5cef76: No Bug: Update directory ownership for some web platform tests. r=me
David Burns <dburns@mozilla.com> - Tue, 30 Apr 2019 21:09:35 +0100 - rev 472096
Push 35947 by apavel@mozilla.com at Wed, 01 May 2019 15:57:23 +0000
No Bug: Update directory ownership for some web platform tests. r=me
20ef9d4a05c755e2154a294629b0543de11f9a5b: Bug 1548086 - Fix ESlint r=me
Coroiu Cristina <ccoroiu@mozilla.com> - Wed, 01 May 2019 04:29:10 +0300 - rev 472038
Push 35945 by ccoroiu@mozilla.com at Wed, 01 May 2019 04:21:12 +0000
Bug 1548086 - Fix ESlint r=me
2d94a6f65792aff0b4638dd8a94ed23213c27626: Bug 1547290 - Mark CaptureConfig::file_path allow(dead_code) on a CLOSED TREE. r=me
Nicolas Silva <nsilva@mozilla.com> - Tue, 30 Apr 2019 09:39:15 +0200 - rev 471893
Push 35942 by archaeopteryx@coole-files.de at Tue, 30 Apr 2019 11:33:43 +0000
Bug 1547290 - Mark CaptureConfig::file_path allow(dead_code) on a CLOSED TREE. r=me
116b2213c4261383a5e279f65edcca069ca8df81: Bug 1547478 - Whoops, stylemageddon style patrol nitfixes. r=me, DONTBUILD
Jeff Walden <jwalden@mit.edu> - Mon, 29 Apr 2019 20:46:13 -0700 - rev 471890
Push 35942 by archaeopteryx@coole-files.de at Tue, 30 Apr 2019 11:33:43 +0000
Bug 1547478 - Whoops, stylemageddon style patrol nitfixes. r=me, DONTBUILD
c59a8b50305b960e027e5dc83c04d3f8a95b68ff: bug 1547700: remote: document headless mode for M-bc tests; r=me a=doc
Andreas Tolfsen <ato@sny.no> - Mon, 29 Apr 2019 14:24:33 +0100 - rev 471737
Push 35933 by csabou@mozilla.com at Mon, 29 Apr 2019 16:02:45 +0000
bug 1547700: remote: document headless mode for M-bc tests; r=me a=doc DONTBUILD
5ce9edd26ca11e54d49980e92afc2ac73eca3383: bug 1547700: remote: simplify mochitest command; r=me a=doc
Andreas Tolfsen <ato@sny.no> - Mon, 29 Apr 2019 14:24:08 +0100 - rev 471736
Push 35933 by csabou@mozilla.com at Mon, 29 Apr 2019 16:02:45 +0000
bug 1547700: remote: simplify mochitest command; r=me a=doc DONTBUILD
808fc8c6a041279ded9368af57e4c1ae2e7d34cc: Bug 1547261 - Add a crashtest. r=me
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 27 Apr 2019 13:21:01 +0200 - rev 471651
Push 35923 by rmaries@mozilla.com at Sat, 27 Apr 2019 21:37:34 +0000
Bug 1547261 - Add a crashtest. r=me
58e4cb8fa6400778d4962986c6dec5e63b22ea7d: Bug 1538416: Get more details from test failure for extra notification, r=me a=testonly
Adam Gashlin <agashlin@mozilla.com> - Thu, 25 Apr 2019 15:47:24 -0700 - rev 471443
Push 35917 by rmaries@mozilla.com at Fri, 26 Apr 2019 09:49:13 +0000
Bug 1538416: Get more details from test failure for extra notification, r=me a=testonly
ec15db17478768038e372a69583e9a76949896f6: bug 1546935: remote: reflect that remote agent is disabled in usage docs; r=me a=doc
Andreas Tolfsen <ato@sny.no> - Thu, 25 Apr 2019 12:01:12 +0100 - rev 471280
Push 35914 by rgurzau@mozilla.com at Thu, 25 Apr 2019 16:20:57 +0000
bug 1546935: remote: reflect that remote agent is disabled in usage docs; r=me a=doc DONTBUILD
8988649ab71dfb53a9d083be8e34f3547a2c4477: bug 1546933: remote: clarify that tests are run on try; r=me a=doc
Andreas Tolfsen <ato@sny.no> - Thu, 25 Apr 2019 11:49:31 +0100 - rev 471279
Push 35914 by rgurzau@mozilla.com at Thu, 25 Apr 2019 16:20:57 +0000
bug 1546933: remote: clarify that tests are run on try; r=me a=doc DONTBUILD
b79b875c82881c48b3529daa6da012a1095367bb: bug 1546933: remote: drop unnecessary flags for ./mach test; r=me a=doc
Andreas Tolfsen <ato@sny.no> - Thu, 25 Apr 2019 11:47:31 +0100 - rev 471278
Push 35914 by rgurzau@mozilla.com at Thu, 25 Apr 2019 16:20:57 +0000
bug 1546933: remote: drop unnecessary flags for ./mach test; r=me a=doc The tests are instrumented to automatically set the remote.enabled preference as part of their manifests. In the case of xpcshell, it is also technically not need it as they do not trigger the command-line-handler.js code path. DONTBUILD
4615f45cd4fe856b37ae10d9f9579d6c808ca2f4: Bug 1533545 - Backout because of build bustage on a CLOSED TREE. r=me
Nicolas Silva <nsilva@mozilla.com> - Wed, 24 Apr 2019 21:01:23 +0200 - rev 471265
Push 35914 by rgurzau@mozilla.com at Thu, 25 Apr 2019 16:20:57 +0000
Bug 1533545 - Backout because of build bustage on a CLOSED TREE. r=me
5a2478c53c19d8bdc10539572bee37c4586dfdcc: Bug 1534395 - Fixup unified build bustage. r=me on a CLOSED TREE
Ryan Hunt <rhunt@eqrion.net> - Tue, 23 Apr 2019 21:47:12 -0500 - rev 470939
Push 35911 by cbrindusan@mozilla.com at Wed, 24 Apr 2019 21:55:25 +0000
Bug 1534395 - Fixup unified build bustage. r=me on a CLOSED TREE
a9a59b71e96aa44e602d8b5bd6144b3c0cfed172: Bug 1545394 - fix ESlint failure r=me on a CLOSED TREE
Coroiu Cristina <ccoroiu@mozilla.com> - Fri, 19 Apr 2019 23:54:08 +0300 - rev 470246
Push 35891 by rgurzau@mozilla.com at Sat, 20 Apr 2019 09:35:22 +0000
Bug 1545394 - fix ESlint failure r=me on a CLOSED TREE
790532ec47385794ffb7a8cf1330ecef7c5b3aa9: Bug 1544199 - Allow `rv = shutdown->RemoveBlocker()` to be unused in SpeechRecognition. r=me
Andreas Pehrson <apehrson@mozilla.com> - Mon, 15 Apr 2019 11:10:41 +0200 - rev 469592
Push 35875 by ccoroiu@mozilla.com at Tue, 16 Apr 2019 04:06:16 +0000
Bug 1544199 - Allow `rv = shutdown->RemoveBlocker()` to be unused in SpeechRecognition. r=me
5704d0949b15dae6b17c659c0822c713983ce66b: bug 1543946: geckodriver: clarify that Marionette is used in README; r=me a=doc
Andreas Tolfsen <ato@sny.no> - Fri, 12 Apr 2019 11:40:06 +0100 - rev 469272
Push 35860 by shindli@mozilla.com at Fri, 12 Apr 2019 15:48:50 +0000
bug 1543946: geckodriver: clarify that Marionette is used in README; r=me a=doc DONTBUILD
c607bbc0b3acc0714621f42ef7b367d42187876a: bug 1543946: geckodriver: move license info to bottom of README; r=me a=doc
Andreas Tolfsen <ato@sny.no> - Fri, 12 Apr 2019 11:38:43 +0100 - rev 469271
Push 35860 by shindli@mozilla.com at Fri, 12 Apr 2019 15:48:50 +0000
bug 1543946: geckodriver: move license info to bottom of README; r=me a=doc DONTBUILD
3f2512f0e48e962a7c3f7569b41290aa8a02a1c7: bug 1543946: geckodriver: clarify where source code is in README; r=me a=doc
Andreas Tolfsen <ato@sny.no> - Fri, 12 Apr 2019 11:36:16 +0100 - rev 469270
Push 35860 by shindli@mozilla.com at Fri, 12 Apr 2019 15:48:50 +0000
bug 1543946: geckodriver: clarify where source code is in README; r=me a=doc DONTBUILD
ab86ec916c5e6788066841789677b91958838b5d: bug 1543946: geckodriver: link to developer docs in README; r=me a=doc
Andreas Tolfsen <ato@sny.no> - Fri, 12 Apr 2019 11:32:44 +0100 - rev 469269
Push 35860 by shindli@mozilla.com at Fri, 12 Apr 2019 15:48:50 +0000
bug 1543946: geckodriver: link to developer docs in README; r=me a=doc DONTBUILD
a6acd34bd6f264c1f0946671b1aaa81d3f176562: Bug 1541577 followup: fix racy test r=me
Andrew Swan <aswan@mozilla.com> - Thu, 11 Apr 2019 15:43:14 -0700 - rev 469183
Push 35857 by csabou@mozilla.com at Fri, 12 Apr 2019 03:46:07 +0000
Bug 1541577 followup: fix racy test r=me
0f940b496e58fe766632d9917a573eb757171a51: Bug 1540387 - De-duplicate theme experiment CSS files. r=me on a CLOSED TREE
Tim Nguyen <ntim.bugs@gmail.com> - Wed, 10 Apr 2019 23:23:43 +0200 - rev 468859
Push 35852 by dvarga@mozilla.com at Thu, 11 Apr 2019 04:19:28 +0000
Bug 1540387 - De-duplicate theme experiment CSS files. r=me on a CLOSED TREE
f8e11c0bb2a4c873350c86a28c6dfe39a68c4288: Bug 1540387 - Remove now obsolete browser_compacttheme.js test. r=me on a CLOSED TREE
Tim Nguyen <ntim.bugs@gmail.com> - Wed, 10 Apr 2019 23:10:46 +0200 - rev 468858
Push 35852 by dvarga@mozilla.com at Thu, 11 Apr 2019 04:19:28 +0000
Bug 1540387 - Remove now obsolete browser_compacttheme.js test. r=me on a CLOSED TREE
401de283153dda1ef37d6e203a86e2116704fe7e: Bug 1540719 - Fix rooting hazard in test code r=me
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 09 Apr 2019 10:48:13 +0100 - rev 468542
Push 35842 by csabou@mozilla.com at Tue, 09 Apr 2019 16:24:26 +0000
Bug 1540719 - Fix rooting hazard in test code r=me
9bdd75e358d19acb969e38572e1eeee810313104: Bug 1509466 - Drop no-longer-needed additions to ServoBindings.toml; r=me
Brian Birtles <birtles@gmail.com> - Fri, 05 Apr 2019 13:38:32 +0900 - rev 468108
Push 35818 by btara@mozilla.com at Fri, 05 Apr 2019 09:50:28 +0000
Bug 1509466 - Drop no-longer-needed additions to ServoBindings.toml; r=me According to https://bugzilla.mozilla.org/show_bug.cgi?id=1509466#c26 the necessary changes to bindgen should now be in mozilla-central.
7c286b126aabca3f79de9d781aa5240d12c08b99: Bug 1539227 - land NSS e5e10a46b9ad UPGRADE_NSS_RELEASE, r=me
J.C. Jones <jc@mozilla.com> - Tue, 02 Apr 2019 20:29:18 +0000 - rev 467896
Push 35811 by aciure@mozilla.com at Thu, 04 Apr 2019 04:34:36 +0000
Bug 1539227 - land NSS e5e10a46b9ad UPGRADE_NSS_RELEASE, r=me
ff6b2d1aff7a8e1bd32b6c7134fdf4704c57034d: Bug 1540856: Part 5 - Restore lightweightThemes.getMoreURL preference. r=me
Kris Maglione <maglione.k@gmail.com> - Wed, 03 Apr 2019 12:29:12 -0700 - rev 467895
Push 35811 by aciure@mozilla.com at Thu, 04 Apr 2019 04:34:36 +0000
Bug 1540856: Part 5 - Restore lightweightThemes.getMoreURL preference. r=me It's still used by the customize mode UI, but the tests for that feature explicitly set it to a different value, so don't fail if it's removed.
e8d7542e19fc43a6640cbbb482bdb0e092bd19e3: Bug 1539303 - Add a crashtest. r=me
Mats Palmgren <mats@mozilla.com> - Mon, 01 Apr 2019 23:41:01 +0200 - rev 467671
Push 35808 by aciure@mozilla.com at Wed, 03 Apr 2019 20:46:05 +0000
Bug 1539303 - Add a crashtest. r=me
85476bad25bfbd3525d6d8779f4705a3fedf9103: Followup for bug 1538060 again. More bustage fix. r=me,a=CristianB
Mike Hommey <mh+mozilla@glandium.org> - Tue, 02 Apr 2019 23:48:01 +0900 - rev 467517
Push 35801 by mh@glandium.org at Tue, 02 Apr 2019 14:49:06 +0000
Followup for bug 1538060 again. More bustage fix. r=me,a=CristianB
41e4fc459ec96f96d1e49a203717a7d233f075ce: Followup for bug 1538060 - Unbust OSX ccov builds. r=me,a=CristianB
Mike Hommey <mh+mozilla@glandium.org> - Tue, 02 Apr 2019 20:45:25 +0900 - rev 467516
Push 35800 by mh@glandium.org at Tue, 02 Apr 2019 14:24:36 +0000
Followup for bug 1538060 - Unbust OSX ccov builds. r=me,a=CristianB We rename the gcov_flush patch to force a rebuild of clang with the updated patch.
ac337210f1802a23ba1d158f668f56e4995ae572: Followup for bug 1539355: Make it work for the root directory. r=me
Mike Hommey <mh+mozilla@glandium.org> - Sun, 31 Mar 2019 07:24:23 +0900 - rev 466993
Push 35789 by btara@mozilla.com at Sun, 31 Mar 2019 09:00:52 +0000
Followup for bug 1539355: Make it work for the root directory. r=me When an added file is not under an app or addon directory, its base directory is ''. The code added in bug 1539355 would skip doing its thing in that case, which it shouldn't. Also revert the workaround from bug 1525762.
282f0d42dfc0f64d60c4202286839d8f15f405c5: Bug 1529957 - Fix test for platforms without asm.js support (r=me)
Luke Wagner <luke@mozilla.com> - Thu, 28 Mar 2019 17:37:44 -0500 - rev 466813
Push 35781 by opoprus@mozilla.com at Fri, 29 Mar 2019 21:56:26 +0000
Bug 1529957 - Fix test for platforms without asm.js support (r=me)
7970abe6388bd9fca94eceaa7cafbb36d8819f92: Bug 288704 - Follow-up: remove unnecessary .ini since the test pass. r=me DONTBUILD
Mats Palmgren <mats@mozilla.com> - Thu, 28 Mar 2019 10:39:37 +0100 - rev 466560
Push 35772 by opoprus@mozilla.com at Thu, 28 Mar 2019 17:31:41 +0000
Bug 288704 - Follow-up: remove unnecessary .ini since the test pass. r=me DONTBUILD
19ede4b24924b2893bce5f19e405ad53da493065: Bug 1539227 - land NSS 67c41e385581 UPGRADE_NSS_RELEASE, r=me
J.C. Jones <jc@mozilla.com> - Tue, 26 Mar 2019 18:48:46 +0000 - rev 466274
Push 35763 by csabou@mozilla.com at Wed, 27 Mar 2019 04:45:26 +0000
Bug 1539227 - land NSS 67c41e385581 UPGRADE_NSS_RELEASE, r=me