searching for reviewer(mconley)
00766f389b9f68bd9193bf05bb1af6569262f317: Bug 1812590, revert back to using a process script for setting up the about:tabswitch module as on some configurations it isn't set up before the page needs to create the about tabswitch channel, r=mconley,perftest-reviewers,kshampur
Neil Deakin <neil@mozilla.com> - Sat, 04 Feb 2023 14:36:48 +0000 - rev 651751
Push 40603 by ctuns@mozilla.com at Sat, 04 Feb 2023 21:26:31 +0000
Bug 1812590, revert back to using a process script for setting up the about:tabswitch module as on some configurations it isn't set up before the page needs to create the about tabswitch channel, r=mconley,perftest-reviewers,kshampur Differential Revision: https://phabricator.services.mozilla.com/D168739
df27c8d9f35887680c14e24a507d319287ea2a40: Bug 1813350 - [ContextualIdentity] Add getPublicUserContextIds() to service r=mconley
CanadaHonk <oj@oojmed.com> - Fri, 03 Feb 2023 16:07:35 +0000 - rev 651676
Push 40602 by abutkovits@mozilla.com at Sat, 04 Feb 2023 09:11:16 +0000
Bug 1813350 - [ContextualIdentity] Add getPublicUserContextIds() to service r=mconley Added getPublicUserContextIds API to ContextualIdentityService to allow easier getting of identities from user context IDs. Also added subtests. Differential Revision: https://phabricator.services.mozilla.com/D168203
f00c3546b0a5f36c6f201b35cb9d523cc25808da: Bug 1781768 - When live language switching ensure that search engines installed via add-ons also update. r=search-reviewers,settings-reviewers,mconley,daleharvey
Mark Banner <standard8@mozilla.com> - Thu, 02 Feb 2023 11:38:28 +0000 - rev 651539
Push 40598 by nerli@mozilla.com at Thu, 02 Feb 2023 17:20:03 +0000
Bug 1781768 - When live language switching ensure that search engines installed via add-ons also update. r=search-reviewers,settings-reviewers,mconley,daleharvey Differential Revision: https://phabricator.services.mozilla.com/D168279
402a6235cd745ea687b4d01bca521463a4690770: Bug 1703006 - Add 4px border radius to the folder tree and tag selector in the bookmark panel r=mconley
Itiel <itiel_yn8@walla.com> - Wed, 01 Feb 2023 20:28:13 +0000 - rev 651432
Push 40597 by ctuns@mozilla.com at Thu, 02 Feb 2023 09:15:42 +0000
Bug 1703006 - Add 4px border radius to the folder tree and tag selector in the bookmark panel r=mconley Also remove custom styling for the New Folder button on macOS Differential Revision: https://phabricator.services.mozilla.com/D168463
1da22d92c592f690fe3e6594fc7e0a6bfac148ed: Bug 1770429 - set PiP originating window as active when window is occluded r=mconley,pip-reviewers
Katherine Patenio <kpatenio@mozilla.com> - Wed, 01 Feb 2023 01:39:15 +0000 - rev 651148
Push 40594 by mlaza@mozilla.com at Wed, 01 Feb 2023 09:43:56 +0000
Bug 1770429 - set PiP originating window as active when window is occluded r=mconley,pip-reviewers Utilizes `browsingContext.forceAppWindowActive` from Bug 1808748 to ensure that a browser window remains active when Picture-in-Picture is enabled in that window. This is to fix an issue where PiP captions do not correctly update when the originating browser window is occluded. Differential Revision: https://phabricator.services.mozilla.com/D166619
1d49d18466b728ce4d01501220a0f5e3bb0aca62: Bug 1814063 - Minor tweak to site data settings dialog styles. r=mconley,settings-reviewers
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 31 Jan 2023 19:13:50 +0000 - rev 651107
Push 40593 by nfay@mozilla.com at Wed, 01 Feb 2023 03:47:20 +0000
Bug 1814063 - Minor tweak to site data settings dialog styles. r=mconley,settings-reviewers I can repro the issue with a larger size in the CSS (though I couldn't find a screen size+resolution combo that caused this "naturally"). That said, 36em seems quite a lot, so reduce it to 20em which is what the other dialogs use. Also, use max-height rather than height so that the box is smaller for smaller lists. We know this list has at least two elements so it should look fine. Differential Revision: https://phabricator.services.mozilla.com/D168400
4ea502fb23571a29a517cc17e79d46d3082561a2: Bug 791594 - Set tab title state while auth prompt is open. r=pbz,mconley,Gijs
Hannah Peuckmann <hpeuckmann@mozilla.com> - Tue, 31 Jan 2023 18:16:54 +0000 - rev 651098
Push 40593 by nfay@mozilla.com at Wed, 01 Feb 2023 03:47:20 +0000
Bug 791594 - Set tab title state while auth prompt is open. r=pbz,mconley,Gijs Differential Revision: https://phabricator.services.mozilla.com/D164442
63d1f8a23fb4433f92d618d0e6164b669816a7a1: Bug 791594 - Gray out content behind cross origin auth requests. r=pbz,Gijs,mconley
Hannah Peuckmann <hpeuckmann@mozilla.com> - Tue, 31 Jan 2023 18:16:53 +0000 - rev 651096
Push 40593 by nfay@mozilla.com at Wed, 01 Feb 2023 03:47:20 +0000
Bug 791594 - Gray out content behind cross origin auth requests. r=pbz,Gijs,mconley Differential Revision: https://phabricator.services.mozilla.com/D164440
3479f77e7402f18d6e3638ff131c0f35386fb493: Bug 1802621 - Move browser_datetime tests in their own subdirectory. r=mconley
Anna Yeddi <ayeddi@mozilla.com> - Mon, 30 Jan 2023 23:53:14 +0000 - rev 651013
Push 40590 by ctuns@mozilla.com at Tue, 31 Jan 2023 04:25:26 +0000
Bug 1802621 - Move browser_datetime tests in their own subdirectory. r=mconley Moved the datepicker-related browser tests in the new subdirectory `datetime` within `toolkit/content/tests/browser/`. Besides `browser_datetime_*` tests `browser_spinner*` ones were also moved, because they share a lot of helper functions and are used for DateTimePicker widgets as well. The subdirectory includes a `header.js` with the `DateTimeTestHelper` class constructor and opther helper functions used across the DateTimePicker test files. It also splits larger test files to avoid intermittent timeouts caused by the large sets of use cases performed. `Browser.ini` includes `skip-if` cases for `browser_datetime_datepicker_*` tests that were provided initially but were not copied to the expanded browser test files in the bug 1676068 work. Differential Revision: https://phabricator.services.mozilla.com/D168140
9c8083315f17e6759d57e80d672d95e287ccea65: Bug 1812977 - Remove now unnecessary import-globals-from statements in browser. r=settings-reviewers,mconley
Mark Banner <standard8@mozilla.com> - Mon, 30 Jan 2023 19:33:37 +0000 - rev 650991
Push 40590 by ctuns@mozilla.com at Tue, 31 Jan 2023 04:25:26 +0000
Bug 1812977 - Remove now unnecessary import-globals-from statements in browser. r=settings-reviewers,mconley Differential Revision: https://phabricator.services.mozilla.com/D168070
ee5d1898fc4badc97182bf7c6bf2aee8321946ac: Bug 1812819 - Update cookie banner preferences checkbox to toggle reject-only mode. r=settings-reviewers,mconley
Jared Hirsch <jhirsch@mozilla.com> - Mon, 30 Jan 2023 18:51:58 +0000 - rev 650978
Push 40590 by ctuns@mozilla.com at Tue, 31 Jan 2023 04:25:26 +0000
Bug 1812819 - Update cookie banner preferences checkbox to toggle reject-only mode. r=settings-reviewers,mconley Differential Revision: https://phabricator.services.mozilla.com/D168285
c0a63e75f4d198497fe1f059712a04be1d230f27: Bug 1803673: checkbox hover radius too big for checkbox labels. r=mconley.
brian <brianpt1106@gmail.com> - Mon, 30 Jan 2023 17:01:56 +0000 - rev 650971
Push 40590 by ctuns@mozilla.com at Tue, 31 Jan 2023 04:25:26 +0000
Bug 1803673: checkbox hover radius too big for checkbox labels. r=mconley. Differential Revision: https://phabricator.services.mozilla.com/D166765
ab00cf793f293710cbd216cd5c0c62fed1d6040e: Bug 1800417 - Fix the use of both `toolbarbutton-1` and `subviewbutton` CSS classes in extension widgets. r=Itiel,mconley,dao,rpl
William Durand <will+git@drnd.me> - Mon, 30 Jan 2023 13:36:07 +0000 - rev 650947
Push 40590 by ctuns@mozilla.com at Tue, 31 Jan 2023 04:25:26 +0000
Bug 1800417 - Fix the use of both `toolbarbutton-1` and `subviewbutton` CSS classes in extension widgets. r=Itiel,mconley,dao,rpl Differential Revision: https://phabricator.services.mozilla.com/D162712
6312bb43e1366032ad2cb5d14f1e60af45aafb42: Bug 1811053 - update text for CBH in about:prefs. r=settings-reviewers,fluent-reviewers,flod,mconley
DJ <dj@walker.dev> - Fri, 27 Jan 2023 19:54:02 +0000 - rev 650840
Push 40584 by smolnar@mozilla.com at Sat, 28 Jan 2023 21:11:06 +0000
Bug 1811053 - update text for CBH in about:prefs. r=settings-reviewers,fluent-reviewers,flod,mconley Differential Revision: https://phabricator.services.mozilla.com/D167631
7ffbae36bda7275109daaeb9d114fc7031b72131: Bug 1801929 - Replace 'Top pick' link with support-link. r=settings-reviewers,mconley
Tim Giles <tgiles@mozilla.com> - Wed, 25 Jan 2023 18:56:21 +0000 - rev 650550
Push 40580 by ctuns@mozilla.com at Thu, 26 Jan 2023 04:53:27 +0000
Bug 1801929 - Replace 'Top pick' link with support-link. r=settings-reviewers,mconley Differential Revision: https://phabricator.services.mozilla.com/D167439
9452aa9343139e31960270ad44f8b320066e36cf: Bug 1801929 - Replace learn more link under 'Custom' option with support-link. r=mconley
Tim Giles <tgiles@mozilla.com> - Wed, 25 Jan 2023 18:56:14 +0000 - rev 650533
Push 40580 by ctuns@mozilla.com at Thu, 26 Jan 2023 04:53:27 +0000
Bug 1801929 - Replace learn more link under 'Custom' option with support-link. r=mconley Differential Revision: https://phabricator.services.mozilla.com/D167422
ca481ff3de0b0303de93132756d2f333a150fb6f: Bug 1801929 - Replace 'Strict' option learn more link with support-link. r=settings-reviewers,mconley
Tim Giles <tgiles@mozilla.com> - Wed, 25 Jan 2023 18:56:13 +0000 - rev 650532
Push 40580 by ctuns@mozilla.com at Thu, 26 Jan 2023 04:53:27 +0000
Bug 1801929 - Replace 'Strict' option learn more link with support-link. r=settings-reviewers,mconley Differential Revision: https://phabricator.services.mozilla.com/D167421
bcd9295250a79675c435ca96a7746332958eb2a8: Bug 1801929 - Replace 'Total Cookie Protection' learn more link with support-link. r=pbz,mconley,settings-reviewers
Tim Giles <tgiles@mozilla.com> - Wed, 25 Jan 2023 18:56:13 +0000 - rev 650531
Push 40580 by ctuns@mozilla.com at Thu, 26 Jan 2023 04:53:27 +0000
Bug 1801929 - Replace 'Total Cookie Protection' learn more link with support-link. r=pbz,mconley,settings-reviewers Differential Revision: https://phabricator.services.mozilla.com/D167420
98727345818f33fb06d22d3e9890a666d7abf1aa: Bug 1801929 - Refactor 'Enhanced Tracking Protection' link with support-link r=settings-reviewers,mconley,mstriemer
Tim Giles <tgiles@mozilla.com> - Wed, 25 Jan 2023 18:56:12 +0000 - rev 650530
Push 40580 by ctuns@mozilla.com at Thu, 26 Jan 2023 04:53:27 +0000
Bug 1801929 - Refactor 'Enhanced Tracking Protection' link with support-link r=settings-reviewers,mconley,mstriemer We need the .learnMore class here, otherwise the "Learn more" link does not move to a new line, which is the current behavior. Differential Revision: https://phabricator.services.mozilla.com/D167419
43057cac15f3e42ade102169ab59888d7ff9a915: Bug 1811581 - Show a time picker on click on time inputs (when pref is on). r=emilio,mconley
Anna Yeddi <ayeddi@mozilla.com> - Wed, 25 Jan 2023 17:26:26 +0000 - rev 650521
Push 40579 by nerli@mozilla.com at Wed, 25 Jan 2023 21:52:01 +0000
Bug 1811581 - Show a time picker on click on time inputs (when pref is on). r=emilio,mconley Returning the functionality to show a time picker panel when an `<input type=time>` is clicked that was removed by the D141175 patch. Providing automatic tests for this required updating the main timepicker component to dispatch an event to communicate that the picker is, in fact, ready. To test, ensure that the `dom.forms.datetime.timepicker` pref is set to `true`. Differential Revision: https://phabricator.services.mozilla.com/D167458
aa03b5c7d577909dca2747d1eca23c5071700b17: Bug 1663647, convert talos tab switching test to use actor-based RemotePageChild and remove usage of old RemotePageManager, r=mconley,perftest-reviewers,sparky
Neil Deakin <neil@mozilla.com> - Tue, 24 Jan 2023 14:47:08 +0000 - rev 650383
Push 40578 by abutkovits@mozilla.com at Wed, 25 Jan 2023 16:29:55 +0000
Bug 1663647, convert talos tab switching test to use actor-based RemotePageChild and remove usage of old RemotePageManager, r=mconley,perftest-reviewers,sparky Differential Revision: https://phabricator.services.mozilla.com/D167358
4cc07e621c7478d5b90623eb4d6cb06f0b53faf5: Bug 1809840, tabs sharing devices menu is not showing captured windows, r=mconley
Neil Deakin <neil@mozilla.com> - Mon, 23 Jan 2023 15:14:22 +0000 - rev 650214
Push 40574 by smolnar@mozilla.com at Tue, 24 Jan 2023 09:30:00 +0000
Bug 1809840, tabs sharing devices menu is not showing captured windows, r=mconley Differential Revision: https://phabricator.services.mozilla.com/D167355
91a26c6b212aaf351dd06c07cd4ee172af902bb1: Bug 1799009 - Remove `gUnifiedExtensions.isEnabled`. r=rpl,mconley
William Durand <will+git@drnd.me> - Mon, 23 Jan 2023 10:39:29 +0000 - rev 650189
Push 40572 by ncsoregi@mozilla.com at Mon, 23 Jan 2023 18:05:32 +0000
Bug 1799009 - Remove `gUnifiedExtensions.isEnabled`. r=rpl,mconley Depends on D166923 Differential Revision: https://phabricator.services.mozilla.com/D166934
d0fbd5534ca0a7e787158b8ec20f90368bbb7a7c: Bug 1799009 - Remove `promiseEnableUnifiedExtensions()` in test files. r=mconley,rpl
William Durand <will+git@drnd.me> - Mon, 23 Jan 2023 10:39:29 +0000 - rev 650188
Push 40572 by ncsoregi@mozilla.com at Mon, 23 Jan 2023 18:05:32 +0000
Bug 1799009 - Remove `promiseEnableUnifiedExtensions()` in test files. r=mconley,rpl Depends on D166908 Differential Revision: https://phabricator.services.mozilla.com/D166923
37a00f91d082cc1036a2b11253bd5112cf78ec4a: Bug 1803608 - Update calendar code to handle key events using dateKeeper. r=mconley,kcochrane
Anna Yeddi <ayeddi@mozilla.com> - Fri, 20 Jan 2023 21:39:58 +0000 - rev 649875
Push 40566 by ncsoregi@mozilla.com at Sat, 21 Jan 2023 09:30:30 +0000
Bug 1803608 - Update calendar code to handle key events using dateKeeper. r=mconley,kcochrane Adds `focusedDate` into the Calendar state object to track and update focusable elements for the grid when a dateView is rendered and especially handle keyboard events. The calculation of the next focused date is improved and delegated to the combination of the dateKeeper's `setCalendarMonth` method and vanilla JavaScript Date object methods. This patch also refactors the logic for updating the grid based on the different states of the next focused day (i.e. when it is a day from another month, when it is the same day of another month, or the first of the month). This resolves the [Page Up/Page Down related bug 1806645](https://bugzilla.mozilla.org/show_bug.cgi?id=1806645) as well. Correct focus placement when Previous/Next Month buttons are used. This will be another patch in this stack - in the D167310 Differential Revision: https://phabricator.services.mozilla.com/D167099
c2c3f0f8eef130d727d29ec92554bab424025bd7: Bug 1811334 - Automatically replace Cu.reportError with console.error (most of browser/components). r=settings-reviewers,mconley
Mark Banner <standard8@mozilla.com> - Fri, 20 Jan 2023 17:49:21 +0000 - rev 649843
Push 40565 by ctuns@mozilla.com at Fri, 20 Jan 2023 21:21:03 +0000
Bug 1811334 - Automatically replace Cu.reportError with console.error (most of browser/components). r=settings-reviewers,mconley Differential Revision: https://phabricator.services.mozilla.com/D167297
a79e2353352b538d07f9bea7a0dbda746eecb06a: Bug 1808803 - Move panel-item attribute/observer setting to connectedCallback() r=mconley
Mark Striemer <mstriemer@mozilla.com> - Fri, 20 Jan 2023 16:40:51 +0000 - rev 649820
Push 40565 by ctuns@mozilla.com at Fri, 20 Jan 2023 21:21:03 +0000
Bug 1808803 - Move panel-item attribute/observer setting to connectedCallback() r=mconley Differential Revision: https://phabricator.services.mozilla.com/D167332
286a4fd230f79efe89dc707149b4e9c42729e118: Bug 1799563 - Refresh swipe-to-navigation UX. r=mconley,emilio
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Fri, 20 Jan 2023 00:05:25 +0000 - rev 649672
Push 40563 by mlaza@mozilla.com at Fri, 20 Jan 2023 03:46:23 +0000
Bug 1799563 - Refresh swipe-to-navigation UX. r=mconley,emilio Differential Revision: https://phabricator.services.mozilla.com/D164271
e122b53c08138f4c5d3e3f42b085aabdb4ba2ee7: Bug 1799009 - Remove unified extensions pref and non-unified extensions variants from test suite. r=rpl,mconley,fluent-reviewers,desktop-theme-reviewers,Itiel
William Durand <will+git@drnd.me> - Thu, 19 Jan 2023 10:59:25 +0000 - rev 649565
Push 40562 by csabou@mozilla.com at Thu, 19 Jan 2023 16:36:52 +0000
Bug 1799009 - Remove unified extensions pref and non-unified extensions variants from test suite. r=rpl,mconley,fluent-reviewers,desktop-theme-reviewers,Itiel This patch removes the use of the "unified extensions" pref and adjust the existing tests. More clean-ups will be done in follow-ups, e.g. the removal of `gUnifiedExtensions.isEnabled` and some test-only changes to no longer create a new window in each test file. Differential Revision: https://phabricator.services.mozilla.com/D166908
eacffbce1d15712de7e0740c8560596602b0d531: Bug 1810038 - actually sort browser/base/content/test/tabs/browser.ini, r=mconley
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 18 Jan 2023 21:41:37 +0000 - rev 649476
Push 40560 by sstanca@mozilla.com at Thu, 19 Jan 2023 04:46:07 +0000
Bug 1810038 - actually sort browser/base/content/test/tabs/browser.ini, r=mconley Differential Revision: https://phabricator.services.mozilla.com/D166738
ac83d4b916b705de1e89fe55bf42577efa96cf83: Bug 1801927 - refactor media control learn more link. r=settings-reviewers,mconley
Tim Giles <tgiles@mozilla.com> - Wed, 18 Jan 2023 19:13:34 +0000 - rev 649442
Push 40560 by sstanca@mozilla.com at Thu, 19 Jan 2023 04:46:07 +0000
Bug 1801927 - refactor media control learn more link. r=settings-reviewers,mconley Replaces the "Control media via keyboard, headset, or virtual interface" XUL label with the moz-support-link element. Differential Revision: https://phabricator.services.mozilla.com/D166469
4ed9185d279fc48b7d17460c9720d108ab9e5119: Bug 1801927 - refactor configure how firefox connects learn more link. r=mconley
Tim Giles <tgiles@mozilla.com> - Wed, 18 Jan 2023 19:13:34 +0000 - rev 649441
Push 40560 by sstanca@mozilla.com at Thu, 19 Jan 2023 04:46:07 +0000
Bug 1801927 - refactor configure how firefox connects learn more link. r=mconley Replaces the "Configure how Nightly connects to the internet" XUL label with the moz-support-link element. Differential Revision: https://phabricator.services.mozilla.com/D166468
d6cc24c27b0c4f3cbce8821618e3b42bfe873053: Bug 1801927 - refactor containers learn more link. r=hjones,settings-reviewers,mconley
Tim Giles <tgiles@mozilla.com> - Wed, 18 Jan 2023 19:13:31 +0000 - rev 649436
Push 40560 by sstanca@mozilla.com at Thu, 19 Jan 2023 04:46:07 +0000
Bug 1801927 - refactor containers learn more link. r=hjones,settings-reviewers,mconley Replaces the XUL label for the "Enable Container Tabs" with the moz-support-link element Differential Revision: https://phabricator.services.mozilla.com/D166463
4e5bd1922ed2c78b16ef6a52bfbb1ba45cbb2a67: Bug 1316727 - Ensure we cannot create a containers with no name r=mconley
Danny Colin <contact@dannycolin.com> - Wed, 18 Jan 2023 18:16:32 +0000 - rev 649431
Push 40560 by sstanca@mozilla.com at Thu, 19 Jan 2023 04:46:07 +0000
Bug 1316727 - Ensure we cannot create a containers with no name r=mconley Differential Revision: https://phabricator.services.mozilla.com/D165488
b2954fa754d2278755983253752f01634bac3c39: Bug 1635761 - disable cancel drag animation on macOS for tabs dragged out of the window, r=emilio,mconley
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 17 Jan 2023 19:48:24 +0000 - rev 649177
Push 40559 by nerli@mozilla.com at Wed, 18 Jan 2023 09:51:31 +0000
Bug 1635761 - disable cancel drag animation on macOS for tabs dragged out of the window, r=emilio,mconley Differential Revision: https://phabricator.services.mozilla.com/D166963
1d2c27f01644ab0768310a0d65664d5290843702: Bug 1810755 - add Mike as a peer for profile import/migration, r=mconley,zeid DONTBUILD
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 17 Jan 2023 16:28:40 +0000 - rev 649145
Push 40559 by nerli@mozilla.com at Wed, 18 Jan 2023 09:51:31 +0000
Bug 1810755 - add Mike as a peer for profile import/migration, r=mconley,zeid DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D167032
986601ae958ab8efdd6c7b8ddaee40f572f5a2d4: Bug 1810018 - drop obsolete comments from various XUL components that no longer use DTDs, r=mconley
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 17 Jan 2023 14:44:33 +0000 - rev 649117
Push 40559 by nerli@mozilla.com at Wed, 18 Jan 2023 09:51:31 +0000
Bug 1810018 - drop obsolete comments from various XUL components that no longer use DTDs, r=mconley Differential Revision: https://phabricator.services.mozilla.com/D166731
ca8e38b36b74efbf4b734017317d1c00c3d997db: Bug 1810004 - Allow hr in panel-list to hide on [hidden] r=mconley
Mark Striemer <mstriemer@mozilla.com> - Thu, 12 Jan 2023 22:22:45 +0000 - rev 648814
Push 40548 by nerli@mozilla.com at Fri, 13 Jan 2023 09:40:38 +0000
Bug 1810004 - Allow hr in panel-list to hide on [hidden] r=mconley Differential Revision: https://phabricator.services.mozilla.com/D166713
4b436cbbbe8ea544a5936f93b6a7d52b1dfcf03a: Bug 1807249 - consolidate and simplify video/audio control position and duration setting, r=mconley
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 12 Jan 2023 15:22:29 +0000 - rev 648784
Push 40547 by nfay@mozilla.com at Thu, 12 Jan 2023 21:30:33 +0000
Bug 1807249 - consolidate and simplify video/audio control position and duration setting, r=mconley Notes: - showHours could force the use of hours, and was true if the millisecond duration was >=3600000, but inside formatTime we also end up using hours if rounded division of ms duration by 1000 and then 3600 was non-0, so it would result in strictly more cases getting hours displayed, e.g. a 59 minute 59 second 500ms video would get hours shown anyway. So I removed showHours. - I consolidated attributes into markup and removed runtime initialization of the duration span - I reorganized duration+position setting to deal with the labeling in 1 function, and a separate function to deal with normalizing the raw ms duration/position (which can be missing or infinity) and setting scrubber bounds and the 'modifier' prop which gets used by CSS logic. Differential Revision: https://phabricator.services.mozilla.com/D166106
26ed4b6da1187fd5e7fae47716699edf2ba936f2: Bug 1803664 - Provide spinner keyboard navigation tests. r=mconley,kcochrane
Anna Yeddi <ayeddi@mozilla.com> - Wed, 11 Jan 2023 17:14:20 +0000 - rev 648699
Push 40543 by smolnar@mozilla.com at Wed, 11 Jan 2023 21:56:57 +0000
Bug 1803664 - Provide spinner keyboard navigation tests. r=mconley,kcochrane Provide reliable keyboard tests for Home/End and PageUp/PageDown for both month and year spinbuttons of the datepicker for `<input type=date>` and `<input type=datetime-local>`. These tests were removed from [the original Datepicker patch 4](https://phabricator.services.mozilla.com/D142743?id=654574) because of failing tests. Using reduced motion pref to utilize instant scrolling behavior to avoid failures during automatic test runs. Depends on D165646 that implements the respect to the `prefers-reduced-motion` settings and changes the scrolling behavior from `smooth` to `instant` when the pref is on. Differential Revision: https://phabricator.services.mozilla.com/D166378
4a1eacd096737ca2d805fea7a7de4dab31af9471: Bug 1809512 - Use a MutationObserver in two tests in toolkit/content/tests/browser/browser_datetime_datepicker_keynav.js. r=Jamie,mconley
Anna Yeddi <ayeddi@mozilla.com> - Wed, 11 Jan 2023 17:03:58 +0000 - rev 648695
Push 40543 by smolnar@mozilla.com at Wed, 11 Jan 2023 21:56:57 +0000
Bug 1809512 - Use a MutationObserver in two tests in toolkit/content/tests/browser/browser_datetime_datepicker_keynav.js. r=Jamie,mconley In `toolkit/content/tests/browser/browser_datetime_datepicker_keynav.js` replace 2 instances of `await BrowserTestUtils.waitForCondition()` with `await BrowserTestUtils.waitForMutationCondition()` per [the recommendation](https://phabricator.services.mozilla.com/D166378#anchor-inline-917416), because if possible, we should avoid polling with waitForCondition. If we're waiting for some DOM to change on us, we can use waitForMutationCondition instead, which uses a MutationObserver rather than an interval for polling. Differential Revision: https://phabricator.services.mozilla.com/D166456
772169dc0fccb9d0bca08ab2d182e3e604fc727e: Bug 1800675 - Add about:preferences entry for cookie banner handling. r=fluent-reviewers,flod,mconley
Jared Hirsch <jhirsch@mozilla.com> - Wed, 11 Jan 2023 15:54:01 +0000 - rev 648683
Push 40543 by smolnar@mozilla.com at Wed, 11 Jan 2023 21:56:57 +0000
Bug 1800675 - Add about:preferences entry for cookie banner handling. r=fluent-reviewers,flod,mconley Differential Revision: https://phabricator.services.mozilla.com/D164632
bec193e3e12b0e70118ac39cb311d78b23a5f667: Bug 1765635 - Extract panel-list from aboutaddons to widgets r=mconley
Mark Striemer <mstriemer@mozilla.com> - Mon, 09 Jan 2023 22:22:20 +0000 - rev 648504
Push 40539 by sstanca@mozilla.com at Tue, 10 Jan 2023 09:36:39 +0000
Bug 1765635 - Extract panel-list from aboutaddons to widgets r=mconley Differential Revision: https://phabricator.services.mozilla.com/D144224
f1639812175b9ba66533e45504ce995725d82e73: Bug 1807249 - consolidate and simplify video/audio control position and duration setting, r=mconley
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Sat, 07 Jan 2023 00:04:17 +0000 - rev 648289
Push 40532 by mlaza@mozilla.com at Sat, 07 Jan 2023 09:34:42 +0000
Bug 1807249 - consolidate and simplify video/audio control position and duration setting, r=mconley Notes: - showHours could force the use of hours, and was true if the millisecond duration was >=3600000, but inside formatTime we also end up using hours if rounded division of ms duration by 1000 and then 3600 was non-0, so it would result in strictly more cases getting hours displayed, e.g. a 59 minute 59 second 500ms video would get hours shown anyway. So I removed showHours. - I consolidated attributes into markup and removed runtime initialization of the duration span - I reorganized duration+position setting to deal with the labeling in 1 function, and a separate function to deal with normalizing the raw ms duration/position (which can be missing or infinity) and setting scrubber bounds and the 'modifier' prop which gets used by CSS logic. Differential Revision: https://phabricator.services.mozilla.com/D166106
da24ae3723ce649d98ff283f4e638eb6ca12d989: Bug 1765635 - Extract panel-list from aboutaddons to widgets r=mconley
Mark Striemer <mstriemer@mozilla.com> - Thu, 05 Jan 2023 16:32:19 +0000 - rev 648160
Push 40528 by ctuns@mozilla.com at Fri, 06 Jan 2023 04:14:44 +0000
Bug 1765635 - Extract panel-list from aboutaddons to widgets r=mconley Differential Revision: https://phabricator.services.mozilla.com/D144224
38be9015acf75cefc65057701bd7e06c3d299779: Bug 1619090 - Clean up crypto modules that are used/referenced from various platforms. r=mconley,credential-management-reviewers,dimi.
brian <brianpt1106@gmail.com> - Thu, 05 Jan 2023 15:38:11 +0000 - rev 648155
Push 40527 by nerli@mozilla.com at Thu, 05 Jan 2023 21:31:09 +0000
Bug 1619090 - Clean up crypto modules that are used/referenced from various platforms. r=mconley,credential-management-reviewers,dimi. Differential Revision: https://phabricator.services.mozilla.com/D164831
620cc421d8298b2f4dfcb04698835e15a04f70e6: Bug 1792774 - Don't constrain <select> menus in the print settings dialog. r=mconley
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 04 Jan 2023 19:30:15 +0000 - rev 647967
Push 40525 by mlaza@mozilla.com at Thu, 05 Jan 2023 03:40:49 +0000
Bug 1792774 - Don't constrain <select> menus in the print settings dialog. r=mconley Differential Revision: https://phabricator.services.mozilla.com/D165972
b8a68d9d33594b99785594e7b5aed6f8882ed032: Bug 1806359 - Convert telemetry imports to direct ES imports. r=necko-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,janerik,mconley,sgalich,bytesized,kershaw
Mark Banner <standard8@mozilla.com> - Fri, 23 Dec 2022 12:37:07 +0000 - rev 647345
Push 40503 by nfay@mozilla.com at Fri, 23 Dec 2022 21:29:57 +0000
Bug 1806359 - Convert telemetry imports to direct ES imports. r=necko-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,janerik,mconley,sgalich,bytesized,kershaw Differential Revision: https://phabricator.services.mozilla.com/D165002
afbcc32c88d21689fe42826f1d8a02fffb811667: Bug 1753861 - end drag sessions before opening any subdialogs, r=mconley
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 21 Dec 2022 18:01:48 +0000 - rev 647009
Push 40498 by sstanca@mozilla.com at Thu, 22 Dec 2022 09:45:20 +0000
Bug 1753861 - end drag sessions before opening any subdialogs, r=mconley When opening new 'real' windows, the window mediator/watcher code takes care of this. For windows inside frames, such as the SubDialog code uses, it does not. The reason this is needed is related to a few different things: - drag processing is different on different OSes. For example, on Windows, once we're getting a 'drop' event we'll get a 'dragend' (which sorts out the tabstrip dragging) immediately afterwards. On macOS, this goes via the event loop. So some of the timing of this is unpredictable. - dialogs can call 'sizeToContent', which in turn checks if the window can even be resized by the calling principal, which suspends drag operations (see bug 329385), which ends the drag *without* notifying dragend, which in turn makes things sad. - dialog opening code such as the prompter code spins event loops. This messes with event handling some more. As SubDialog is the common bit between all 3 types of prompts (browser window, tab, content modal) that don't open separate 'real' external windows, this seems the logical place to put this. Unfortunately no tests because simulating native drag events is... not straightforward. Differential Revision: https://phabricator.services.mozilla.com/D139557
1de20be14b0d2c1f6897654fe57c659bcfdf5df6: Bug 1804669 - Do not remove a Calendar button from date input on Backspace. r=mconley
Anna Yeddi <ayeddi@mozilla.com> - Wed, 21 Dec 2022 17:52:49 +0000 - rev 647007
Push 40497 by ctuns@mozilla.com at Wed, 21 Dec 2022 21:21:23 +0000
Bug 1804669 - Do not remove a Calendar button from date input on Backspace. r=mconley Prevent removing a Calendar button when a `Backspace` is pressed while it's focused for `<input type=date>` and `<input type=datetime-local>`. This patch does not add cleaning the entire field as this is to be decided under [a separate enhancement bug 1806587](https://bugzilla.mozilla.org/show_bug.cgi?id=1806587) Differential Revision: https://phabricator.services.mozilla.com/D165186