searching for reviewer(mconley)
28cfd20eeb70f99deb3eb3dbe215317c2deb8b8f: Bug 1558930 - Disable tab unloading when memory is running low r=mconley
Gabriele Svelto <gsvelto@mozilla.com> - Fri, 14 Jun 2019 18:22:40 +0000 - rev 478919
Push 36155 by apavel@mozilla.com at Sat, 15 Jun 2019 09:53:16 +0000
Bug 1558930 - Disable tab unloading when memory is running low r=mconley Differential Revision: https://phabricator.services.mozilla.com/D35037
ec8bf3fa989d552b6730b1fcad10ecad305e0769: Bug 1510569 - Port Content:LoadURIResult message to IPDL r=mconley
Barret Rennie <barret@brennie.ca> - Thu, 13 Jun 2019 21:00:34 +0000 - rev 478774
Push 36150 by shindli@mozilla.com at Fri, 14 Jun 2019 03:39:39 +0000
Bug 1510569 - Port Content:LoadURIResult message to IPDL r=mconley The `WebProgress#sendLoadCallResult` method only existed to send a empty async message and was only called from the `WebNavigationChild`. Since `WebNavigationChild` is in the process of being removed, it makes sense to inline the replaced method into its call site. Differential Revision: https://phabricator.services.mozilla.com/D34566
b723e35febfc3e26104d2ffce1a9c1dc2d9a7065: Bug 1510569 - Move Content:BrowserChildReady from WebProgressChild.jsm into the browser child frame script r=mconley
Barret Rennie <barret@brennie.ca> - Thu, 13 Jun 2019 21:00:14 +0000 - rev 478773
Push 36150 by shindli@mozilla.com at Fri, 14 Jun 2019 03:39:39 +0000
Bug 1510569 - Move Content:BrowserChildReady from WebProgressChild.jsm into the browser child frame script r=mconley Differential Revision: https://phabricator.services.mozilla.com/D34565
4f0f5351be8b5e5f62c4cfede98848b4000968e9: Bug 1510569 - Port Content:LoadURIResult message to IPDL r=mconley
Barret Rennie <barret@brennie.ca> - Thu, 13 Jun 2019 17:55:04 +0000 - rev 478746
Push 36150 by shindli@mozilla.com at Fri, 14 Jun 2019 03:39:39 +0000
Bug 1510569 - Port Content:LoadURIResult message to IPDL r=mconley The `WebProgress#sendLoadCallResult` method only existed to send a empty async message and was only called from the `WebNavigationChild`. Since `WebNavigationChild` is in the process of being removed, it makes sense to inline the replaced method into its call site. Differential Revision: https://phabricator.services.mozilla.com/D34566
14bbe0916bdd3b990ea48e008ab7f80a9eb54dfa: Bug 1510569 - Move Content:BrowserChildReady from WebProgressChild.jsm into the browser child frame script r=mconley
Barret Rennie <barret@brennie.ca> - Thu, 13 Jun 2019 17:54:50 +0000 - rev 478745
Push 36150 by shindli@mozilla.com at Fri, 14 Jun 2019 03:39:39 +0000
Bug 1510569 - Move Content:BrowserChildReady from WebProgressChild.jsm into the browser child frame script r=mconley Differential Revision: https://phabricator.services.mozilla.com/D34565
6759badeec0e4accbd7f98d39d821c276212faef: Bug 1488953 - Allows toolbar background paint flash along with the urlbar flickers on MacOSX in browser_windowopen.js. r=mconley
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 13 Jun 2019 02:30:25 +0000 - rev 478592
Push 36146 by opoprus@mozilla.com at Thu, 13 Jun 2019 09:54:24 +0000
Bug 1488953 - Allows toolbar background paint flash along with the urlbar flickers on MacOSX in browser_windowopen.js. r=mconley On MacOSX, especially on MacOS 10.10, the toolbar paint flush happens along with the urlbar flickers. Differential Revision: https://phabricator.services.mozilla.com/D34489
5c23b9ba930f958144fab1cb7f814a19c8bb73d7: Bug 1557887 - Part 5: Pass a storage principal argument through the browser loadURI()/addTab() APIs; r=baku,mconley
Ehsan Akhgari <ehsan@mozilla.com> - Wed, 12 Jun 2019 23:05:36 +0000 - rev 478555
Push 36145 by aciure@mozilla.com at Thu, 13 Jun 2019 03:50:31 +0000
Bug 1557887 - Part 5: Pass a storage principal argument through the browser loadURI()/addTab() APIs; r=baku,mconley Differential Revision: https://phabricator.services.mozilla.com/D34459
762351d3c242b4ff914f4649f16af4fcb5fc6a4d: Bug 1557887 - Part 1: Add the browser.contentStoragePrincipal attribute; r=mconley
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 11 Jun 2019 17:14:11 +0000 - rev 478551
Push 36145 by aciure@mozilla.com at Thu, 13 Jun 2019 03:50:31 +0000
Bug 1557887 - Part 1: Add the browser.contentStoragePrincipal attribute; r=mconley Differential Revision: https://phabricator.services.mozilla.com/D34455
12409096d0188d0e0a6cb03cd4b37f9d036257a8: Bug 1558306 - Clean up app-startup category/topics for readability. r=mconley
Zibi Braniecki <zbraniecki@mozilla.com> - Wed, 12 Jun 2019 17:50:13 +0000 - rev 478478
Push 36143 by aciure@mozilla.com at Wed, 12 Jun 2019 21:41:19 +0000
Bug 1558306 - Clean up app-startup category/topics for readability. r=mconley Differential Revision: https://phabricator.services.mozilla.com/D34573
912ea3c956b31d5b08b439bb894a8536b25c82b4: Bug 1558306 - Switch L10nRegistry initialization to happen right before the first content process gets created. r=mconley
Zibi Braniecki <zbraniecki@mozilla.com> - Wed, 12 Jun 2019 17:49:56 +0000 - rev 478477
Push 36143 by aciure@mozilla.com at Wed, 12 Jun 2019 21:41:19 +0000
Bug 1558306 - Switch L10nRegistry initialization to happen right before the first content process gets created. r=mconley Differential Revision: https://phabricator.services.mozilla.com/D34572
a09644bb0e6efbd856d89ab0ae8e4161294f81c6: Bug 1558306 - Clean up app-startup category/topics for readability. r=mconley
Zibi Braniecki <zbraniecki@mozilla.com> - Wed, 12 Jun 2019 15:14:12 +0000 - rev 478452
Push 36143 by aciure@mozilla.com at Wed, 12 Jun 2019 21:41:19 +0000
Bug 1558306 - Clean up app-startup category/topics for readability. r=mconley Differential Revision: https://phabricator.services.mozilla.com/D34573
7832d4ed2c618373154359843513e691dec95f2e: Bug 1558306 - Switch L10nRegistry initialization to happen right before the first content process gets created. r=mconley
Zibi Braniecki <zbraniecki@mozilla.com> - Wed, 12 Jun 2019 15:15:48 +0000 - rev 478451
Push 36143 by aciure@mozilla.com at Wed, 12 Jun 2019 21:41:19 +0000
Bug 1558306 - Switch L10nRegistry initialization to happen right before the first content process gets created. r=mconley Differential Revision: https://phabricator.services.mozilla.com/D34572
910ee59da71cdcb3e13c34bce22224d749120e86: Bug 1553200 - Do not receive unwanted nsIWebProgress events in addon discovery view r=mconley
Barret Rennie <barret@brennie.ca> - Tue, 11 Jun 2019 17:47:52 +0000 - rev 478294
Push 36140 by dluca@mozilla.com at Wed, 12 Jun 2019 12:02:49 +0000
Bug 1553200 - Do not receive unwanted nsIWebProgress events in addon discovery view r=mconley Depends on D33996 Differential Revision: https://phabricator.services.mozilla.com/D33997
61dee4121753ac1568cadbacb334236c95735a63: Bug 1533948, change BrowserTabChild to inherit from JSWindowActor, r=mconley
Neil Deakin <neil@mozilla.com> - Tue, 11 Jun 2019 09:05:33 -0400 - rev 478284
Push 36139 by rgurzau@mozilla.com at Tue, 11 Jun 2019 21:35:17 +0000
Bug 1533948, change BrowserTabChild to inherit from JSWindowActor, r=mconley
abd13cb2e8095cf94a55b881420fdab1c12ef444: Bug 1541226 - Cache GetUserDataDirectory to improve IO performance r=mconley
mandy cheang <mcheang@mozilla.com> - Wed, 05 Jun 2019 15:36:44 +0000 - rev 476983
Push 36114 by aiakab@mozilla.com at Wed, 05 Jun 2019 21:59:57 +0000
Bug 1541226 - Cache GetUserDataDirectory to improve IO performance r=mconley Differential Revision: https://phabricator.services.mozilla.com/D32825
2d70e6f3a03acd7f10b084949d4708f391174c3d: Bug 1543508 - revert will-change additions now that layers no longer cause compositor bugs, r=mconley
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 03 Jun 2019 20:10:44 +0000 - rev 476674
Push 36104 by cbrindusan@mozilla.com at Tue, 04 Jun 2019 03:45:41 +0000
Bug 1543508 - revert will-change additions now that layers no longer cause compositor bugs, r=mconley Differential Revision: https://phabricator.services.mozilla.com/D33165
0ca9a03071b76cb0aca81b83ed451dedd2b7c1f5: Bug 1553694 - accept a second PCompositorBridge::Msg_WillClose sync IPC in the 'before handling user events' phase, r=mconley.
Florian Quèze <florian@queze.net> - Fri, 31 May 2019 15:54:32 +0000 - rev 476635
Push 36104 by cbrindusan@mozilla.com at Tue, 04 Jun 2019 03:45:41 +0000
Bug 1553694 - accept a second PCompositorBridge::Msg_WillClose sync IPC in the 'before handling user events' phase, r=mconley. Differential Revision: https://phabricator.services.mozilla.com/D32986
eddcd90c1ffa0f64c6601111a099e9bc3c6e22ae: Bug 1488871 - Add an exception for the placeholder in the urlbar flickers to browser_windowopen.js. r=mconley
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 01 Jun 2019 03:26:36 +0000 - rev 476496
Push 36096 by ncsoregi@mozilla.com at Sat, 01 Jun 2019 21:36:13 +0000
Bug 1488871 - Add an exception for the placeholder in the urlbar flickers to browser_windowopen.js. r=mconley recordFrames has been wallpapering these flickers because the function ends up calling FlushPendingNotifications in AsyncScrollPortEvent::Run() and we hadn't noticed the wallpaper until we tried to remove the FlushPendingNotifications in AsyncScrollPortEvent::Run(). Differential Revision: https://phabricator.services.mozilla.com/D33226
5f35e6fc8f915fb9eede822910a38636aa28516b: Bug 1488871 - Make browser_windowopen.js workaround account for the toolbar background. r=florian,mconley
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 01 Jun 2019 03:26:36 +0000 - rev 476495
Push 36096 by ncsoregi@mozilla.com at Sat, 01 Jun 2019 21:36:13 +0000
Bug 1488871 - Make browser_windowopen.js workaround account for the toolbar background. r=florian,mconley With the other patch in this bug, we get two rects, not > 5. Differential Revision: https://phabricator.services.mozilla.com/D5240
bacf3c56e94081b742fb2f1b75620aeedc59a25e: Bug 1555421 - Include 'other' and 'g5' test suites in perf-chrome preset;r=mconley
Brian Grinstead <bgrinstead@mozilla.com> - Fri, 31 May 2019 15:53:48 +0000 - rev 476425
Push 36094 by aiakab@mozilla.com at Fri, 31 May 2019 21:48:40 +0000
Bug 1555421 - Include 'other' and 'g5' test suites in perf-chrome preset;r=mconley Differential Revision: https://phabricator.services.mozilla.com/D33049
7f30c1db8835cf11237b51835ca26522f8d0c06d: Bug 1539595 - Rename Priveleged Content Process to PrivlegedAbout Content Process r=mconley,flod
Tom Ritter <tom@mozilla.com> - Wed, 29 May 2019 11:31:31 +0000 - rev 476047
Push 36083 by nerli@mozilla.com at Wed, 29 May 2019 15:58:28 +0000
Bug 1539595 - Rename Priveleged Content Process to PrivlegedAbout Content Process r=mconley,flod We do this because we will be introducing more privileged content processes and we want to be able to distinguish them. Differential Revision: https://phabricator.services.mozilla.com/D30274
81792a8b6423bd9bf3b7023740d0c047b77b2919: Bug 1543439 - Part 4: Add tests; r=mconley
Edgar Chen <echen@mozilla.com> - Tue, 28 May 2019 23:47:48 +0000 - rev 476031
Push 36083 by nerli@mozilla.com at Wed, 29 May 2019 15:58:28 +0000
Bug 1543439 - Part 4: Add tests; r=mconley Differential Revision: https://phabricator.services.mozilla.com/D32600
ba3e353c69578a9d9bea098d31961ba89b0f8d5a: Bug 1539595 - Rename Priveleged Content Process to PrivlegedAbout Content Process r=mconley,flod
Tom Ritter <tom@mozilla.com> - Tue, 28 May 2019 14:19:11 +0000 - rev 475862
Push 36076 by opoprus@mozilla.com at Tue, 28 May 2019 21:44:47 +0000
Bug 1539595 - Rename Priveleged Content Process to PrivlegedAbout Content Process r=mconley,flod We do this because we will be introducing more privileged content processes and we want to be able to distinguish them. Differential Revision: https://phabricator.services.mozilla.com/D30274
fa7dcd1f369cf19b7af37d9cfc953fe1d131e1c4: Bug 1553745 - Introduce a toolkit.legacyUserProfileCustomizations.windowIcon preference to allow users to enable per-window icon, r=mconley.
Florian Quèze <florian@queze.net> - Mon, 27 May 2019 17:35:31 +0000 - rev 475822
Push 36076 by opoprus@mozilla.com at Tue, 28 May 2019 21:44:47 +0000
Bug 1553745 - Introduce a toolkit.legacyUserProfileCustomizations.windowIcon preference to allow users to enable per-window icon, r=mconley. Differential Revision: https://phabricator.services.mozilla.com/D32440
14c9835bfca5c478fd9d822f0621f4054b7facb5: Bug 1554280 - Part 2: Add an IsProcessRoot() getter to WindowGlobalActor, r=mconley
Nika Layzell <nika@thelayzells.com> - Mon, 27 May 2019 18:42:37 +0000 - rev 475765
Push 36072 by dluca@mozilla.com at Tue, 28 May 2019 09:38:00 +0000
Bug 1554280 - Part 2: Add an IsProcessRoot() getter to WindowGlobalActor, r=mconley Differential Revision: https://phabricator.services.mozilla.com/D32516
9b03e3640b09713ea027467bca40ebeac9ec2775: Bug 1554280 - Part 1: Expose the ContentParentId of a WindowGlobalActor, r=mconley
Nika Layzell <nika@thelayzells.com> - Mon, 27 May 2019 18:42:35 +0000 - rev 475764
Push 36072 by dluca@mozilla.com at Tue, 28 May 2019 09:38:00 +0000
Bug 1554280 - Part 1: Expose the ContentParentId of a WindowGlobalActor, r=mconley Differential Revision: https://phabricator.services.mozilla.com/D32515
4a491cff07b243433dfd14ba63fd35717fda546c: Bug 1553952 - Fire oop-browser-crashed when mBrowserParent construction fails, r=mconley
Nika Layzell <nika@thelayzells.com> - Fri, 24 May 2019 22:14:44 +0000 - rev 475499
Push 36062 by aciure@mozilla.com at Sat, 25 May 2019 09:39:13 +0000
Bug 1553952 - Fire oop-browser-crashed when mBrowserParent construction fails, r=mconley This is an attempt to reduce the negative impact of bug 1553644 by replacing a remote browser which fails to create an `mBrowserParent` actor with a tab crashed display rather than a failed `nsFrameLoader`. This is done by firing the `oop-browser-crashed` event on the owner `<browser>` element when the attempt fails, even if no `BrowserParent` was ever created. This does not fix the root cause of bug 1553644, but may make the browser better at recovering. Differential Revision: https://phabricator.services.mozilla.com/D32381
f104f127518e7a5265155186168c02e592cc9080: Bug 1510569 - Keep track of whether we are navigating to a new URI in nsDocShell r=mconley,kmag,qdot
Barret Rennie <barret@brennie.ca> - Thu, 23 May 2019 18:48:48 +0000 - rev 475427
Push 36062 by aciure@mozilla.com at Sat, 25 May 2019 09:39:13 +0000
Bug 1510569 - Keep track of whether we are navigating to a new URI in nsDocShell r=mconley,kmag,qdot Previously the `WebNavigationChild` would keep track of when triggering its `nsIWebNavigation`, `goForward`, `goBack`, `gotoIndex`, and `loadURI` methods. It's `nsIWebNavigation` instance is always an `nsIDocShell` and as part of porting `OnStateChange` and `OnLocationChange` events from `WebProgressChild`/`RemoteWebProgress` to `BrowserChild`/`BrowserParent`, this informations needs to be available from the `BrowserChild`. As it stands, it is currently an expando property on the `WebProgressChild`. Instead of introducing yet another XPCOM interface for the WebProgressChild, we now store this information directly on the `nsDocShell`. Furthermore, instead of having the `WebNavigationChild` manage this part of the `nsDocShell`'s state, we can have the `nsDocShell` manage this state itself so it is always consistent. Differential Revision: https://phabricator.services.mozilla.com/D28124
7718aebfcc5203dd29e5e7609aca8aa8ff1e446c: Bug 1510569 - Only forward nsIWebProgress events to the BrowserParent after the WebProgressChild has loaded r=kmag,mconley
Barret Rennie <barret@brennie.ca> - Thu, 23 May 2019 18:48:18 +0000 - rev 475425
Push 36062 by aciure@mozilla.com at Sat, 25 May 2019 09:39:13 +0000
Bug 1510569 - Only forward nsIWebProgress events to the BrowserParent after the WebProgressChild has loaded r=kmag,mconley Before the WebProgress event handlers started migrating to C++, the parent process would only receive WebProgress events after the child process had finished loading the WebProgressChild script. Now that listeners are registered much earlier (before the BrowserChild has finished setting up its frame scripts), the BrowserParent would receive WebProgress events that were heretofore not received unless the BrowserChild was *very* careful about when it sent the IPC messages. However, even while being very careful, the OnStateChange event handler would always fire events for initial about:blank loads that break a lot of unit tests. Before porting that event, we are now ensuring that the WebProgressChild has finished loading before the BrowserChild will send IPC messages for these events to the BrowserParent. Differential Revision: https://phabricator.services.mozilla.com/D30252
e1d9f28fbaaaa0923d91a113810496feecb80db5: Bug 1541233 - Remove expired USER_CHROME_CSS_LOADED probe. r=mconley
mandy cheang <mcheang@mozilla.com> - Thu, 23 May 2019 12:06:09 +0000 - rev 475200
Push 36057 by aciure@mozilla.com at Thu, 23 May 2019 21:52:03 +0000
Bug 1541233 - Remove expired USER_CHROME_CSS_LOADED probe. r=mconley Differential Revision: https://phabricator.services.mozilla.com/D32025
409b2e43be0e312669b5662940f500401806d2cf: Bug 1541233 - Don't load customization style sheets if toolkit.legacyUserProfileCustomizations.stylesheets pref is not set. r=mconley,emilio
mandy cheang <mcheang@mozilla.com> - Thu, 23 May 2019 12:06:09 +0000 - rev 475199
Push 36057 by aciure@mozilla.com at Thu, 23 May 2019 21:52:03 +0000
Bug 1541233 - Don't load customization style sheets if toolkit.legacyUserProfileCustomizations.stylesheets pref is not set. r=mconley,emilio Differential Revision: https://phabricator.services.mozilla.com/D31670
1c62e73258b4bb23885b3dd0b4b5818234b6b69f: Bug 1528459 - Show PiP Icon in parent tab of media. r=mconley
meandave <djustice@mozilla.com> - Wed, 22 May 2019 18:44:28 +0000 - rev 475041
Push 36054 by dvarga@mozilla.com at Thu, 23 May 2019 15:52:15 +0000
Bug 1528459 - Show PiP Icon in parent tab of media. r=mconley Differential Revision: https://phabricator.services.mozilla.com/D29023
39c6818fdb12675afb6f25cdb467b54e02f907d2: Bug 1510569 - Keep track of whether we are navigating to a new URI in nsDocShell r=mconley,kmag,qdot
Barret Rennie <barret@brennie.ca> - Tue, 21 May 2019 21:34:54 +0000 - rev 475033
Push 36054 by dvarga@mozilla.com at Thu, 23 May 2019 15:52:15 +0000
Bug 1510569 - Keep track of whether we are navigating to a new URI in nsDocShell r=mconley,kmag,qdot Previously the `WebNavigationChild` would keep track of when triggering its `nsIWebNavigation`, `goForward`, `goBack`, `gotoIndex`, and `loadURI` methods. It's `nsIWebNavigation` instance is always an `nsIDocShell` and as part of porting `OnStateChange` and `OnLocationChange` events from `WebProgressChild`/`RemoteWebProgress` to `BrowserChild`/`BrowserParent`, this informations needs to be available from the `BrowserChild`. As it stands, it is currently an expando property on the `WebProgressChild`. Instead of introducing yet another XPCOM interface for the WebProgressChild, we now store this information directly on the `nsDocShell`. Furthermore, instead of having the `WebNavigationChild` manage this part of the `nsDocShell`'s state, we can have the `nsDocShell` manage this state itself so it is always consistent. Differential Revision: https://phabricator.services.mozilla.com/D28124
418a61f5f87bff0dfceae36f3bbde0a242076cad: Bug 1510569 - Only forward nsIWebProgress events to the BrowserParent after the WebProgressChild has loaded r=kmag,mconley
Barret Rennie <barret@brennie.ca> - Wed, 22 May 2019 17:49:29 +0000 - rev 475031
Push 36054 by dvarga@mozilla.com at Thu, 23 May 2019 15:52:15 +0000
Bug 1510569 - Only forward nsIWebProgress events to the BrowserParent after the WebProgressChild has loaded r=kmag,mconley Before the WebProgress event handlers started migrating to C++, the parent process would only receive WebProgress events after the child process had finished loading the WebProgressChild script. Now that listeners are registered much earlier (before the BrowserChild has finished setting up its frame scripts), the BrowserParent would receive WebProgress events that were heretofore not received unless the BrowserChild was *very* careful about when it sent the IPC messages. However, even while being very careful, the OnStateChange event handler would always fire events for initial about:blank loads that break a lot of unit tests. Before porting that event, we are now ensuring that the WebProgressChild has finished loading before the BrowserChild will send IPC messages for these events to the BrowserParent. Differential Revision: https://phabricator.services.mozilla.com/D30252
6d0bd1cdd4beabe88d1040e537b129ce364ffeee: Bug 1549548 - update browser tests for plugin blocking, r=mconley
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 22 May 2019 14:48:04 +0000 - rev 474973
Push 36052 by btara@mozilla.com at Thu, 23 May 2019 04:37:46 +0000
Bug 1549548 - update browser tests for plugin blocking, r=mconley Differential Revision: https://phabricator.services.mozilla.com/D31346
012f377d8d8286d0122072e4ad2ea7552e356e92: Bug 1552524 - Add a mochitest to avoid more sync IPC being introduced during startup, r=mconley.
Florian Quèze <florian@queze.net> - Wed, 22 May 2019 14:15:29 +0000 - rev 474968
Push 36052 by btara@mozilla.com at Thu, 23 May 2019 04:37:46 +0000
Bug 1552524 - Add a mochitest to avoid more sync IPC being introduced during startup, r=mconley. Differential Revision: https://phabricator.services.mozilla.com/D31644
0a9f9f076b93f3d456a3f11a330aae3d42ed6f78: Bug 1553113 - Rename the profiles uploaded by startup main thread IO tests so that treeherder offers to open them in Firefox Profiler, r=mconley.
Florian Quèze <florian@queze.net> - Wed, 22 May 2019 10:03:48 +0000 - rev 474894
Push 36050 by shindli@mozilla.com at Wed, 22 May 2019 15:25:01 +0000
Bug 1553113 - Rename the profiles uploaded by startup main thread IO tests so that treeherder offers to open them in Firefox Profiler, r=mconley. Differential Revision: https://phabricator.services.mozilla.com/D31994
df98eef1f640b109944ec52da0932e62763bbac6: Bug 1510569 - Keep track of whether we are navigating to a new URI in nsDocShell r=mconley,kmag,qdot
Barret Rennie <barret@brennie.ca> - Tue, 21 May 2019 19:28:39 +0000 - rev 474818
Push 36047 by nerli@mozilla.com at Wed, 22 May 2019 03:40:58 +0000
Bug 1510569 - Keep track of whether we are navigating to a new URI in nsDocShell r=mconley,kmag,qdot Previously the `WebNavigationChild` would keep track of when triggering its `nsIWebNavigation`, `goForward`, `goBack`, `gotoIndex`, and `loadURI` methods. It's `nsIWebNavigation` instance is always an `nsIDocShell` and as part of porting `OnStateChange` and `OnLocationChange` events from `WebProgressChild`/`RemoteWebProgress` to `BrowserChild`/`BrowserParent`, this informations needs to be available from the `BrowserChild`. As it stands, it is currently an expando property on the `WebProgressChild`. Instead of introducing yet another XPCOM interface for the WebProgressChild, we now store this information directly on the `nsDocShell`. Furthermore, instead of having the `WebNavigationChild` manage this part of the `nsDocShell`'s state, we can have the `nsDocShell` manage this state itself so it is always consistent. Differential Revision: https://phabricator.services.mozilla.com/D28124
fb696b92c13dfcc10af3c528c013e3d513510c12: Bug 1510569 - Only forward nsIWebProgress events to the BrowserParent after the WebProgressChild has loaded r=kmag,mconley
Barret Rennie <barret@brennie.ca> - Tue, 21 May 2019 19:28:04 +0000 - rev 474816
Push 36047 by nerli@mozilla.com at Wed, 22 May 2019 03:40:58 +0000
Bug 1510569 - Only forward nsIWebProgress events to the BrowserParent after the WebProgressChild has loaded r=kmag,mconley Before the WebProgress event handlers started migrating to C++, the parent process would only receive WebProgress events after the child process had finished loading the WebProgressChild script. Now that listeners are registered much earlier (before the BrowserChild has finished setting up its frame scripts), the BrowserParent would receive WebProgress events that were heretofore not received unless the BrowserChild was *very* careful about when it sent the IPC messages. However, even while being very careful, the OnStateChange event handler would always fire events for initial about:blank loads that break a lot of unit tests. Before porting that event, we are now ensuring that the WebProgressChild has finished loading before the BrowserChild will send IPC messages for these events to the BrowserParent. Differential Revision: https://phabricator.services.mozilla.com/D30252
de97a258fcfdc7de3668acf70c2f6732335eac6c: Bug 1510569 - Keep track of whether we are navigating to a new URI in nsDocShell r=mconley,kmag,qdot
Barret Rennie <barret@brennie.ca> - Tue, 21 May 2019 17:08:57 +0000 - rev 474794
Push 36046 by aiakab@mozilla.com at Tue, 21 May 2019 21:45:52 +0000
Bug 1510569 - Keep track of whether we are navigating to a new URI in nsDocShell r=mconley,kmag,qdot Previously the `WebNavigationChild` would keep track of when triggering its `nsIWebNavigation`, `goForward`, `goBack`, `gotoIndex`, and `loadURI` methods. It's `nsIWebNavigation` instance is always an `nsIDocShell` and as part of porting `OnStateChange` and `OnLocationChange` events from `WebProgressChild`/`RemoteWebProgress` to `BrowserChild`/`BrowserParent`, this informations needs to be available from the `BrowserChild`. As it stands, it is currently an expando property on the `WebProgressChild`. Instead of introducing yet another XPCOM interface for the WebProgressChild, we now store this information directly on the `nsDocShell`. Furthermore, instead of having the `WebNavigationChild` manage this part of the `nsDocShell`'s state, we can have the `nsDocShell` manage this state itself so it is always consistent. Differential Revision: https://phabricator.services.mozilla.com/D28124
1d8ab383d3e9643073e95ae257ffde377de3cfd9: Bug 1510569 - Only forward nsIWebProgress events to the BrowserParent after the WebProgressChild has loaded r=kmag,mconley
Barret Rennie <barret@brennie.ca> - Tue, 21 May 2019 17:08:25 +0000 - rev 474792
Push 36046 by aiakab@mozilla.com at Tue, 21 May 2019 21:45:52 +0000
Bug 1510569 - Only forward nsIWebProgress events to the BrowserParent after the WebProgressChild has loaded r=kmag,mconley Before the WebProgress event handlers started migrating to C++, the parent process would only receive WebProgress events after the child process had finished loading the WebProgressChild script. Now that listeners are registered much earlier (before the BrowserChild has finished setting up its frame scripts), the BrowserParent would receive WebProgress events that were heretofore not received unless the BrowserChild was *very* careful about when it sent the IPC messages. However, even while being very careful, the OnStateChange event handler would always fire events for initial about:blank loads that break a lot of unit tests. Before porting that event, we are now ensuring that the WebProgressChild has finished loading before the BrowserChild will send IPC messages for these events to the BrowserParent. Differential Revision: https://phabricator.services.mozilla.com/D30252
ab585bce1f5bee00fa4dcad39f7701359ceba6a0: Bug 1536465 - remove expiring FX_TAB_REMOTE_NAVIGATION_DELAY_MS telemetry probe. r=mconley
Julien Cristau <jcristau@mozilla.com> - Mon, 20 May 2019 11:57:42 +0200 - rev 474480
Push 36040 by rgurzau@mozilla.com at Mon, 20 May 2019 13:43:21 +0000
Bug 1536465 - remove expiring FX_TAB_REMOTE_NAVIGATION_DELAY_MS telemetry probe. r=mconley Differential Revision: https://phabricator.services.mozilla.com/D27328
c3954692e846bb23528d8838ff736977e0e678f5: Bug 1322385 Part 1: Make BrowserUtils.shouldFastFind avoid triggering on iframes. r=mconley
Brad Werth <bwerth@mozilla.com> - Thu, 16 May 2019 18:32:29 +0000 - rev 474233
Push 36027 by shindli@mozilla.com at Fri, 17 May 2019 16:24:38 +0000
Bug 1322385 Part 1: Make BrowserUtils.shouldFastFind avoid triggering on iframes. r=mconley Differential Revision: https://phabricator.services.mozilla.com/D28920
742a8ae0110dc3d862a637e4348b587fe431938f: Bug 1550034 - avoid most failures of the browser_startup_mainthreadio.js and browser_startup_content_mainthreadio.js tests, r=mconley.
Florian Quèze <florian@queze.net> - Thu, 16 May 2019 17:56:57 +0000 - rev 474223
Push 36027 by shindli@mozilla.com at Fri, 17 May 2019 16:24:38 +0000
Bug 1550034 - avoid most failures of the browser_startup_mainthreadio.js and browser_startup_content_mainthreadio.js tests, r=mconley. This patch contains the following changes: - upload a startup profile when there are unused mainthread I/O whitelist entries, - avoid 'unused whitelist entry' failures in devedition beta builds (where the IOInterposer is ifdef'ed out) while keeping coverage that ensures we are able to produce valid startup profiles, - completely disable on Windows Arm64 where the IO interposer is broken, - mark as ignoreIfUnused the whitelist entry that caused most intermittent failures. Differential Revision: https://phabricator.services.mozilla.com/D31268
d8d0020e4b9edce245d75feb0f0670f2247d4a73: Bug 1551609. Follow-up to mark PrintUtils.enterPrintPreview internal. r=mconley
Jonathan Watt <jwatt@jwatt.org> - Tue, 30 Apr 2019 10:40:13 +0100 - rev 474160
Push 36023 by ncsoregi@mozilla.com at Thu, 16 May 2019 21:56:43 +0000
Bug 1551609. Follow-up to mark PrintUtils.enterPrintPreview internal. r=mconley
8e07958a53a27c09737a770979a19874bbb38161: Bug 1551609. Make printUtils.js consistent about internal/external naming. r=mconley
Jonathan Watt <jwatt@jwatt.org> - Mon, 29 Apr 2019 19:15:48 +0100 - rev 474115
Push 36023 by ncsoregi@mozilla.com at Thu, 16 May 2019 21:56:43 +0000
Bug 1551609. Make printUtils.js consistent about internal/external naming. r=mconley Differential Revision: https://phabricator.services.mozilla.com/D31096
db99095ae0b53c30927add34be3dc20a7bdcb52e: Bug 1392320 - Enable browser_urlbar_keyed_search.js on Linux and Windows debug. r=mconley
Mark Banner <standard8@mozilla.com> - Mon, 13 May 2019 17:52:45 +0000 - rev 473734
Push 36012 by aiakab@mozilla.com at Tue, 14 May 2019 09:42:36 +0000
Bug 1392320 - Enable browser_urlbar_keyed_search.js on Linux and Windows debug. r=mconley It seems to be no longer affected by the previous intermittent/perma failures. Differential Revision: https://phabricator.services.mozilla.com/D30942
eb384663078998538a5af4dfa7f45972fe29da49: Bug 1546983 - followup: use background-color instead of background so that browser_parsable_css.js doesn't get mad. rs=mconley
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 08 May 2019 21:03:40 +0200 - rev 473106
Push 35988 by opoprus@mozilla.com at Thu, 09 May 2019 03:32:40 +0000
Bug 1546983 - followup: use background-color instead of background so that browser_parsable_css.js doesn't get mad. rs=mconley It would detect the variable as unreferenced because the background-repeat that was added on this bug makes the values not serialize, see https://github.com/w3c/csswg-drafts/issues/2515 CLOSED TREE of course
d81d08e2b3a115f803bfb2c033b885470a3e6a9d: Bug 1549723 - disable browser_startup_mainthreadio.js and browser_startup_content_mainthreadio.js mochitests for debug builds, r=mconley.
Florian Quèze <florian@queze.net> - Wed, 08 May 2019 08:56:26 +0000 - rev 473029
Push 35986 by opoprus@mozilla.com at Wed, 08 May 2019 21:49:24 +0000
Bug 1549723 - disable browser_startup_mainthreadio.js and browser_startup_content_mainthreadio.js mochitests for debug builds, r=mconley. Differential Revision: https://phabricator.services.mozilla.com/D30220
5add0a9fd0fb6f0f50df29e04b52a16b2975c373: Bug 1540135 - follow up to fix browser_startup_mainthreadio.js on asan builds where the crash reporter is disabled, r=mconley CLOSED TREE
Florian Quèze <florian@queze.net> - Tue, 07 May 2019 21:58:37 +0200 - rev 472963
Push 35983 by ncsoregi@mozilla.com at Wed, 08 May 2019 03:38:51 +0000
Bug 1540135 - follow up to fix browser_startup_mainthreadio.js on asan builds where the crash reporter is disabled, r=mconley CLOSED TREE