Bug 1473736 - Implement necko part of ESNI r=mak,kmag,mcmanus

Bug 1473736 - Implement necko part of ESNI r=mak,kmag,mcmanus Implement necko part of ESNI Differential Revision: https://phabricator.services.mozilla.com/D2716

Bug 1473736 - Implement necko part of ESNI r=mcmanus Implement necko part of ESNI Differential Revision: https://phabricator.services.mozilla.com/D2716

Bug 1468222 Consolidate nsISSLStatus info nsITransportSecurityInfo r=Gijs,snorp,jcj,mcmanus,sfraser,keeler,baku,ato Move all fields of nsISSLStatus to nsITransportSecurityProvider Remove nsISSLStatus interface and definition Update all code and test references to nsISSLStatus Maintain ability to read in older version of serialized nsISSLStatus. This is verified with psm_DeserializeCert gtest. Differential Revision: https://phabricator.services.mozilla.com/D3704

Bug 1468222 Consolidate nsISSLStatus info nsITransportSecurityInfo r=snorp,ato,sfraser,keeler,baku,mcmanus,Gijs Move all fields of nsISSLStatus to nsITransportSecurityProvider Remove nsISSLStatus interface and definition Update all code and test references to nsISSLStatus Maintain ability to read in older version of serialized nsISSLStatus. This is verified with psm_DeserializeCert gtest. Differential Revision: https://phabricator.services.mozilla.com/D3704

bug 1486137 - TRR: fix the FAMILY field in the ECS code r=mcmanus ... since AF_INET wouldn't actually use IPv4! MozReview-Commit-ID: FCf7psawENI Differential Revision: https://phabricator.services.mozilla.com/D4328

bug 1483311 - add LOAD_DISABLE_TRR as a loadflag r=mcmanus Disable TRR at will without needing to toggle the pref. MozReview-Commit-ID: 1Ept6kDrjN3 Differential Revision: https://phabricator.services.mozilla.com/D3399

bug 1466462 - TRR: disable EDNS Client Subnet by default r=mcmanus Set the "network.trr.disable-ECS" pref to false to disable. MozReview-Commit-ID: GE6L8Vpvuu0 Differential Revision: https://phabricator.services.mozilla.com/D2933

bug 1475781 - revert the doubled DNS cache r=mcmanus Almost no cache hit improvement was detected. Differential Revision: https://phabricator.services.mozilla.com/D3189

Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov This introduces the machinery needed to generate crash annotations from a YAML file. The relevant C++ functions are updated to take a typed enum. JavaScript calls are unaffected but they will throw if the string argument does not correspond to one of the known entries in the C++ enum. The existing whitelists and blacklists of annotations are also generated from the YAML file and all duplicate code related to them has been consolidated. Once written out to the .extra file the annotations are converted in string form and are no different than the existing ones. All existing annotations have been included in the list (and some obsolete ones have been removed) and all call sites have been updated including tests where appropriate.

bug 1466860 - upgrade DOH code to draft-12 level r=mcmanus MozReview-Commit-ID: FSVh7qUbBig Differential Revision: https://phabricator.services.mozilla.com/D2828

Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov This introduces the machinery needed to generate crash annotations from a YAML file. The relevant functions are updated to take a typed enum (in C++) and an integer constant (in JavaScript). A JavaScript wrapper around the crash reporter service is provided to hold the constants. The existing whitelists and blacklists of annotations are also generated from the YAML file and the existing duplicate code has been consolidated. Once written out to the .extra file the annotations are converted in string form and are no different than the existing ones. All existing annotations have been included (and some obsolete ones removed) and all call sites have been updated including tests.

Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov This introduces the machinery needed to generate crash annotations from a YAML file. The relevant functions are updated to take a typed enum (in C++) and an integer constant (in JavaScript). A JavaScript wrapper around the crash reporter service is provided to hold the constants. The existing whitelists and blacklists of annotations are also generated from the YAML file and the existing duplicate code has been consolidated. Once written out to the .extra file the annotations are converted in string form and are no different than the existing ones. All existing annotations have been included (and some obsolete ones removed) and all call sites have been updated including tests.

Bug 1475647 - Remove nsISSLStatusProvider interface. r=baku,Gijs,jchen,jryans,keeler,mcmanus - Access nsISSLStatus directly as a member of nsITransportSecurityInfo and nsISecureBrowserUI. This is part of a larger effort to consolidate nsISSLStatus and nsITransportSecurityInfo. - The TabParent implementation of GetSecInfo will always return null. - Removed unnecessary QueryInterface calls - Style adherence updates MozReview-Commit-ID: Dzy6t2zYljL

Bug 1475647 - Remove nsISSLStatusProvider interface. r=baku,Gijs,jchen,jryans,keeler,mcmanus - Access nsISSLStatus directly as a member of nsITransportSecurityInfo and nsISecureBrowserUI. This is part of a larger effort to consolidate nsISSLStatus and nsITransportSecurityInfo. - The TabParent implementation of GetSecInfo will always return null. - Removed unnecessary QueryInterface calls - Style adherence updates MozReview-Commit-ID: Dzy6t2zYljL

Bug 1475647 - Remove nsISSLStatusProvider interface. r=baku,Gijs,jchen,jryans,keeler,mcmanus - Access nsISSLStatus directly as a member of nsITransportSecurityInfo and nsISecureBrowserUI. This is part of a larger effort to consolidate nsISSLStatus and nsITransportSecurityInfo. - The TabParent implementation of GetSecInfo will always return null. - Removed unnecessary QueryInterface calls - Style adherence updates MozReview-Commit-ID: Dzy6t2zYljL

bug 1472662 - only send DNS_TRR_NS_VERIFIED telemetry once r=mcmanus ... by making sure we only retry TRR when we go from CP bad=>good. MozReview-Commit-ID: FcDwzSHm6Ia

bug 1473333 - add Telemetry probe HTTP_CHANNEL_ONSTART_SUCCESS r=mcmanus Measure success rate in nsHttpChannel::OnStartRequest MozReview-Commit-ID: Ia8h8acIvSA

bug 1472656 - only do DNS_TRR_COMPARE in shadow or parallel mode r=mcmanus MozReview-Commit-ID: 5eQb3pCNIwK

bug 1472659 - add Telemetry::DNS_TRR_FIRST and Telemetry::DNS_TRR_DISABLED r=mcmanus To help evaluate TRRfirst sucess/error rates. MozReview-Commit-ID: Ljrbed6UDG2

bug 1470215 let Telemetry::DNS_NATIVE_QUEUING measure queue times r=mcmanus MozReview-Commit-ID: 77FE4SJOXMG

Bug 1470455 - Add the 'expected' arguments to throws/rejects for netwerk. r=mcmanus MozReview-Commit-ID: 40K0YkBQfue

Bug 1468198 - remove tests that only run on b2g. r=smaug,mcmanus,whimboo

bug 1471156 - double the DNS cache size to 800 entries r=mcmanus ... but leave it at 400 for Android. MozReview-Commit-ID: 1Tni6zWrYNL

bug 1471217 - ignore the network.dns.get-ttl pref on non-supported systems r=mcmanus Which is how the pref is documented in all.js MozReview-Commit-ID: 5ONQgZ1wO5G

bug 1470093 - fix telemetry::DNS_TRR_LOOKUP_TIME r=mcmanus MozReview-Commit-ID: 80jrEQ4kLM6

bug 1470005 - change default TRR blacklist duration to 60 seconds r=mcmanus MozReview-Commit-ID: FGQCmhlBBG8

bug 1463356 do not count "not started" TRR resolves as failures r=mcmanus ... when comparing against the native resolver. DNS_TRR_COMPARE is meant to compare how the actually performed name resolves fare against each other. MozReview-Commit-ID: 98NoUGPpHr6

Bug 1465884: Back out no-longer-needed diagnostic for networking crash. r=mcmanus This commit is a (rebased) backout of changeset 016bcae14073 from bug 1322610, which simply added a diagnostic to gather more information about a crash. We can remove that diagnostic now, hence this commit. MozReview-Commit-ID: 6ea7SAX4PSV

Bug 1328695 - Use protocol flags to determine if a URI is potentially trustworthy r=ckerschb, r=dveditz, r=mcmanus, r=bz Before this change, the trusted URI schemes, based on a string whitelist, were: https, file, resource, app, moz-extension and wss. This change removes "app" from the list (since we don't implement it), and adds "about" to the list (because we control the delivery of that).

bug 1460327 - make the DNS packet decoder verify the answer qname r=mcmanus ... and before chasing a cname, check if the address record for that CNAME is actually in fact already provided in the DNS packet that passed on the CNAME! Some existing tests ajusted for this. Two new tests added. MozReview-Commit-ID: CBMO7N7jMEX

Bug 1401776 - Raise fd limit to 4096 on Unix. r=glandium,mcmanus This is to accommodate non-networking fd usage (IPC transports, various databases, .xpi files, etc.), so it's separate from Necko's existing manipulation of the fd limit, which is tied into Necko's internal limits on how many sockets it will try to poll at once. Note that resource limits are inherited by child processes, so this needs to be done only in the parent. This patch also removes similar code used on Solaris and Mac OS X. The Mac case (bug 1036682) refers to fd use by graphics textures, which shouldn't be consuming fds anymore (even transiently) as of bug 1161166. MozReview-Commit-ID: 2uodrkW5sUn

Bug 1460313 - Remove unused mForTakeResponseHead. r=mcmanus MozReview-Commit-ID: BIJvKrEeKiV

Bug 1460589 - Add DNS vs TRR success/fail telemetry counter. r=mcmanus

Bug 1460305 - Add DNS_PREMATURE_EVICTION telemetry probe. r=mcmanus Counts age of non-expired DNS cache entries being evicted.

Bug 1460330 - Always use use TTL with TRR. r=mcmanus

Bug 1452436 - Callback when resolving a host already in progress. r=mcmanus If a callback has already been called for the hostrecord, it is partially resolved already by TRR so the new callback should be called at once.

Bug 1436610 - Send "TE: Trailers" header on h2 requests. r=mcmanus MozReview-Commit-ID: 6Hpj5RcCb4I

Bug 1460251 - Up cookie limit to 180 per host and expose prefs. r=mcmanus MozReview-Commit-ID: 1zFMQ4pbntp

bug 1450630 - use DataStorage in main thread only r=mcmanus Move the TRR blacklist check to the main thread, and since it is now done a little later and for each separate request, make sure to only do the telemetry counting for one of the record types (A) so that we don't count them twice. MozReview-Commit-ID: BgvU4TzrpCq

bug 1457005 - TRR: reset confirmation state machine on prefs update r=mcmanus If the confirmation state machine has gone into FAILED mode, updated prefs is reason enough to try again and possibly get TRR verified proper. MozReview-Commit-ID: ALRbNJdvxdn

bug 1455972 - make TRR prefer address responses to CNAME r=mcmanus In a DOH response to a query asking for an A or AAAA record, a CNAME response is often accompanied by A/AAAA resources as well. With this change, TRR now rather use those address records than following the CNAME record. This saves name resolver round-trips. MozReview-Commit-ID: GcjZj5Ehz68

bug 1454307 - revert TRR telemetry histogram label addition r=mcmanus It isn't supported server side, so make the TRRoff mode instead count as nativeonly. MozReview-Commit-ID: 73si3kam6xU

bug 1453825 - add telemetry for TRR NS confirmation checks r=mcmanus MozReview-Commit-ID: 3FAdEhlH5VI

bug 1453806 - verify that cookies aren't sent back by TRR r=mcmanus MozReview-Commit-ID: LOeDNqhNZYN

bug 1452616 - make TRR not wait for captive portal on Android by default r=mcmanus MozReview-Commit-ID: DR3PgYuzZWs

bug 1453822 - TRR: add a mode for "explicitly turned off" r=mcmanus ... as opposed to off by default. MozReview-Commit-ID: EClrW33xGkb

bug 1451883 - fix pointer handling in the DOH response decoding r=mcmanus In the section of the response body parser that just skips over the answer section, the code wrongly assumed there could only be a pointer at the start, while in fact every label can be made as a pointer. Just turned out to not be used very often. MozReview-Commit-ID: 8ZYtlq8HDPw

bug 1451750 - treat rrsets from different resolvers as different r=mcmanus ... even if all the addresses are identical. Otherwise the IsTRR() bit would be dropped, resulting in about:networking showing false for this entry while in reality being TRR. Or vice versa. MozReview-Commit-ID: JABLm09iCnn

bug 1451011 - expire TRR blacklist entries after 20 minutes by default r=mcmanus MozReview-Commit-ID: 1FYM86WNeW1