searching for reviewer(mayhemer)
65e6c73de900d697b3720c5d11408636d5f62635: Bug 1649807 - Ignore Pragma: no-cache if Cache-Control is specified. r=mayhemer,necko-reviewers
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 03 Jul 2020 14:04:31 +0000 - rev 538833
Push 37571 by btara@mozilla.com at Sun, 05 Jul 2020 21:40:03 +0000
Bug 1649807 - Ignore Pragma: no-cache if Cache-Control is specified. r=mayhemer,necko-reviewers See bug 1599160 comment 43 for an example in the wild (though it has been fixed since) which prevents us from caching resources unnecessarily. Differential Revision: https://phabricator.services.mozilla.com/D81879
24628212bbf298b14c803e4c9e22f1bf5b89aca9: Bug 1607426 - Add a mutex to protect nsPACMan::mLoader r=mayhemer
Kershaw Chang <kershaw@mozilla.com> - Fri, 03 Jul 2020 12:31:31 +0000 - rev 538723
Push 37567 by dluca@mozilla.com at Fri, 03 Jul 2020 21:50:22 +0000
Bug 1607426 - Add a mutex to protect nsPACMan::mLoader r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D73286
8881ac68a975fbd1560aeca746f60b7e6503157d: Bug 1648035 - remove the false alarm assertion given mChild could be destroied by ActorDestory, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Thu, 02 Jul 2020 01:07:34 +0000 - rev 538346
Push 37561 by ncsoregi@mozilla.com at Thu, 02 Jul 2020 09:46:06 +0000
Bug 1648035 - remove the false alarm assertion given mChild could be destroied by ActorDestory, r=mayhemer,necko-reviewers Differential Revision: https://phabricator.services.mozilla.com/D81625
68dc9e49b744691851ca852f6b5d61a7ec44908b: Bug 1618271 - Fail DNS requests when proxy is in use r=mayhemer,necko-reviewers
Valentin Gosu <valentin.gosu@gmail.com> - Wed, 01 Jul 2020 16:49:19 +0000 - rev 538271
Push 37559 by rmaries@mozilla.com at Wed, 01 Jul 2020 21:32:12 +0000
Bug 1618271 - Fail DNS requests when proxy is in use r=mayhemer,necko-reviewers Differential Revision: https://phabricator.services.mozilla.com/D80889
f900ff75a000e83d228da49da2dbdbd0de6fc192: Bug 1618271 - Move network.proxy.type to StaticPrefList.yaml r=mayhemer,necko-reviewers
Valentin Gosu <valentin.gosu@gmail.com> - Wed, 01 Jul 2020 16:49:05 +0000 - rev 538270
Push 37559 by rmaries@mozilla.com at Wed, 01 Jul 2020 21:32:12 +0000
Bug 1618271 - Move network.proxy.type to StaticPrefList.yaml r=mayhemer,necko-reviewers Differential Revision: https://phabricator.services.mozilla.com/D80888
ccfa8f4641dbb93b9878190985d632d5df96b53a: Bug 1649404 - Enforce the reading completeness in any PermissionManager methods, r=mayhemer
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 30 Jun 2020 18:34:51 +0000 - rev 538138
Push 37558 by dluca@mozilla.com at Wed, 01 Jul 2020 09:30:12 +0000
Bug 1649404 - Enforce the reading completeness in any PermissionManager methods, r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D81681
3a12b1eccd8ff22d687b35bc7ef0af1e4b9747b0: Bug 1578230 - do not process transactions blocked on tunnel before a final response, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 18:37:28 +0000 - rev 538071
Push 37557 by abutkovits@mozilla.com at Wed, 01 Jul 2020 03:27:11 +0000
Bug 1578230 - do not process transactions blocked on tunnel before a final response, r=mayhemer,necko-reviewers Depends on D80261 Differential Revision: https://phabricator.services.mozilla.com/D81620
352726f9bd296da32170dcd3c49c660bdff3e390: Bug 1578230 - skip 1xx pre-response for H2 CONNECT proxy, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Mon, 29 Jun 2020 23:33:44 +0000 - rev 538070
Push 37557 by abutkovits@mozilla.com at Wed, 01 Jul 2020 03:27:11 +0000
Bug 1578230 - skip 1xx pre-response for H2 CONNECT proxy, r=mayhemer,necko-reviewers We already able to allow more headers after 1xx for H2. https://searchfox.org/mozilla-central/rev/5e6c7717255ca9638b2856c2b2058919aec1d21d/netwerk/protocol/http/Http2Session.cpp#1547-1550 What we need to do is a special handle in H2 Tunneling: Create the transport shims and decide if we need secondary TLS when we have a final response. Differential Revision: https://phabricator.services.mozilla.com/D80261
cc60e258290ea538e6f63b60d1c3080917d0e5a9: Bug 1646592 - P4 Remove the depedency between OnStartRequestSent and AttachStreamFilter, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 00:35:22 +0000 - rev 538044
Push 37557 by abutkovits@mozilla.com at Wed, 01 Jul 2020 03:27:11 +0000
Bug 1646592 - P4 Remove the depedency between OnStartRequestSent and AttachStreamFilter, r=mayhemer,necko-reviewers We're shorter the name! Differential Revision: https://phabricator.services.mozilla.com/D81275
3a514b227127c94f54f690ba3ad179eb4eb96bf1: Bug 1646592 - P3 Sending endpoint of stream filter via PHttpBackgroundChannel, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 00:35:12 +0000 - rev 538043
Push 37557 by abutkovits@mozilla.com at Wed, 01 Jul 2020 03:27:11 +0000
Bug 1646592 - P3 Sending endpoint of stream filter via PHttpBackgroundChannel, r=mayhemer,necko-reviewers Endpoint would be passed by a series of std::move via nsHttpChannel -> HttpChannelParent -> HttpBackgroundChannelParent ---> HttpBackgroundChannelChild -> HttpChannelChild | | Resolve promise after successfully send IPC<-/ Differential Revision: https://phabricator.services.mozilla.com/D81274
de9ba1eaded125fa3c3c1ea50154dbe59ef608db: Bug 1646592 - P2 remove NeckoTargetChannelEvent which could not be specialized for HttpChannelChild, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 00:34:54 +0000 - rev 538042
Push 37557 by abutkovits@mozilla.com at Wed, 01 Jul 2020 03:27:11 +0000
Bug 1646592 - P2 remove NeckoTargetChannelEvent which could not be specialized for HttpChannelChild, r=mayhemer,necko-reviewers NeckoTargetChannelEvent uses a protected member function, which couldn't compile with instantiation of HttpChannelChild https://searchfox.org/mozilla-central/rev/cfaa250d14e344834932de4c2eed0061701654da/netwerk/ipc/ChannelEventQueue.h#64 Differential Revision: https://phabricator.services.mozilla.com/D81273
ce326495d23b554b1c28a4ddc3bd2a25b717df95: Bug 1648898 - Fix data race on STS loop start. r=mayhemer
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 30 Jun 2020 11:06:31 +0000 - rev 537964
Push 37555 by cbrindusan@mozilla.com at Tue, 30 Jun 2020 14:45:59 +0000
Bug 1648898 - Fix data race on STS loop start. r=mayhemer The STS dispatched the first event before setting mThread member. It was possible that the STS::Run() task got started before mThread was set and causing one of the nsISerialEventTarget methods to read mThread/mInitialised/mShuttingDown value as null or zero and they would have returned an error. We rewrite and simplify the access to mThread such that it's a lockless operation. ApplyPortRemapPreference assert that it's running on the taskqueue; however if called before initialization, it would have been run on whatever thread called ApplyPortRemap. Differential Revision: https://phabricator.services.mozilla.com/D81334
b3c38ba32f0b6d62ac3164d6e00c5576ffd62d75: Bug 1648134 - Permission Manager does not save changes when scope is changed., r=mayhemer
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 30 Jun 2020 09:44:00 +0000 - rev 537947
Push 37555 by cbrindusan@mozilla.com at Tue, 30 Jun 2020 14:45:59 +0000
Bug 1648134 - Permission Manager does not save changes when scope is changed., r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D81292
d529ccb6638b92890550fc5c8a13092b6b72e450: Bug 1633935 - P13 Avoid ODA message being processed when the channel is already failed, r=mayhemer,kershaw,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 00:34:39 +0000 - rev 537881
Push 37554 by nbeleuzu@mozilla.com at Tue, 30 Jun 2020 10:00:42 +0000
Bug 1633935 - P13 Avoid ODA message being processed when the channel is already failed, r=mayhemer,kershaw,necko-reviewers One line fix with a bunch of explanation. When we perform networking on the socket process, OnDataAvailable could be sent directly from socket process to child process. Therefore, it could be racy with OnStartRequest which is from parent process to child process by nature. This patch is to resolve the failure (cancel) by parent process. For example, https://searchfox.org/mozilla-central/rev/027893497316897b8f292bde48dbb6da2391a331/netwerk/protocol/http/nsHttpChannel.cpp#2713 Bug 1641496 introduce a status check to avoid ODA message being process [2] https://searchfox.org/mozilla-central/rev/027893497316897b8f292bde48dbb6da2391a331/netwerk/protocol/http/HttpBackgroundChannelChild.cpp#163-171 It prevents putting ODA to the channel event queue in child process. However, this is based on that `OnStartRequest` already finished excution, which is usually true if OnStartRequest is sent via PHttpChannel. https://searchfox.org/mozilla-central/rev/027893497316897b8f292bde48dbb6da2391a331/netwerk/protocol/http/HttpChannelChild.cpp#417-422 ChannelEventQueue::RunOrEnque simply runs the OnStartRequest given there on the same thread and the queue is empty, since no blocking events from different thread are before OnStartRequest. Now we are moving the next chapter. OnStartRequest is queued given we want to switch thread. The failure status, which is initiated in parent process, is set in HttpChannelChild::OnStartRequest which could be later than the status check [2] Therefore, we need another check to prevent ODA, which is already in the event queue, being processed. We intentionally keep [2] for performance. Differential Revision: https://phabricator.services.mozilla.com/D79771
cad764eb15a4a42cfdb2468ce762029130c0b9fc: Bug 1633935 - P12 top-level IPC stream filter should happen before OnStartRequest, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 00:34:32 +0000 - rev 537880
Push 37554 by nbeleuzu@mozilla.com at Tue, 30 Jun 2020 10:00:42 +0000
Bug 1633935 - P12 top-level IPC stream filter should happen before OnStartRequest, r=mayhemer,necko-reviewers The WebRequest will suspend the channel in nsHttpChannel::PrepareToConnect(), apply the stream filter, send the main thread IPC and resume. That is, PHttpChannel::AttachStreamFilter should be handled in Child before OnStartRequest goes to listener. Differential Revision: https://phabricator.services.mozilla.com/D79770
f75cc7d5f40e5973936997f7a0f66707860c9be0: Bug 1633935 - P11 Move classification IPC methods back to PHttpChannel. r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 00:34:24 +0000 - rev 537879
Push 37554 by nbeleuzu@mozilla.com at Tue, 30 Jun 2020 10:00:42 +0000
Bug 1633935 - P11 Move classification IPC methods back to PHttpChannel. r=mayhemer,necko-reviewers Bug 1015466 move them from PContent to Pbg since it believes those events are fine to received before OnStopRequest. Bug 1588241 move it back to PContent since those events are before OnStartRequest. Now we're moving OnStartRequest to pBg, so here's another ping-pong time :) Differential Revision: https://phabricator.services.mozilla.com/D79587
2289e685031e878fee593b86cea90025b43d1fe9: Bug 1633935 - P10 wait PHttpChannel::OnStartRequestSent for permission/cookie update from parent, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 00:34:06 +0000 - rev 537878
Push 37554 by nbeleuzu@mozilla.com at Tue, 30 Jun 2020 10:00:42 +0000
Bug 1633935 - P10 wait PHttpChannel::OnStartRequestSent for permission/cookie update from parent, r=mayhemer,necko-reviewers Depends on D77751 Differential Revision: https://phabricator.services.mozilla.com/D77752
673030046319948020e1e2100e2db3cf753dbaba: Bug 1633935 - P9 send OnAfterLastPart via pBg IPC to avoid race between OS*R, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 00:33:54 +0000 - rev 537877
Push 37554 by nbeleuzu@mozilla.com at Tue, 30 Jun 2020 10:00:42 +0000
Bug 1633935 - P9 send OnAfterLastPart via pBg IPC to avoid race between OS*R, r=mayhemer,necko-reviewers Depends on D77750 Differential Revision: https://phabricator.services.mozilla.com/D77751
045271cd2ca65fd83484574c24cb508e3aaa6579: Bug 1633935 - P8 suspend event queue in HttpChannelChild which needs listener for redirection, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 00:33:41 +0000 - rev 537876
Push 37554 by nbeleuzu@mozilla.com at Tue, 30 Jun 2020 10:00:42 +0000
Bug 1633935 - P8 suspend event queue in HttpChannelChild which needs listener for redirection, r=mayhemer,necko-reviewers Now OnStartRequest is passed to child process via pBg. Every IPC which is passed thru main thread could become a race. For the redirection flow in child process is: (1) HTC::ConnectParent(): Let parent know this is the targeted child, so OnStartRequest could start here. (2) HTC::CompleteRedirectSetup(listener): Now we're finish the setup, including listener. From now on, we're ready to accept OnStartRequest Hence, between (1) and (2), and need to suspend the eventQ to prevent OnStartRequest pump without listener. On the other hand, if the redirection is vetoed by parent, (2) will not be sent. RecvDeleteSelf instead. Resuming the eventQ to prevent leakage. Depends on D77749 Differential Revision: https://phabricator.services.mozilla.com/D77750
4214217c588cd8f5a21acf197698905528f1ea17: Bug 1633935 - P5 allow OnProgress/OnStatus going thru pBg IPC, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 00:33:19 +0000 - rev 537873
Push 37554 by nbeleuzu@mozilla.com at Tue, 30 Jun 2020 10:00:42 +0000
Bug 1633935 - P5 allow OnProgress/OnStatus going thru pBg IPC, r=mayhemer,necko-reviewers Depends on D76971 Differential Revision: https://phabricator.services.mozilla.com/D76972
e6c12eec1cef32987b7a0b79ccf4420ee097b868: Bug 1633935 - P4 Remove On[Start|Stop]Request/OnTransportAndData in PHttpChannel, r=mayhemer,nika,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 00:33:01 +0000 - rev 537872
Push 37554 by nbeleuzu@mozilla.com at Tue, 30 Jun 2020 10:00:42 +0000
Bug 1633935 - P4 Remove On[Start|Stop]Request/OnTransportAndData in PHttpChannel, r=mayhemer,nika,necko-reviewers We move OnStartRequest from PHttpChannel to PHttpBackgroundChannel, thus adjusting message-metadata.ini Depends on D76970 Differential Revision: https://phabricator.services.mozilla.com/D76971
d59b42f58f861e049c1270035ea7568acc0605b9: Bug 1633935 - P3 send OS*R and ODA via pHttpChannel for multipart channel, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 00:32:53 +0000 - rev 537871
Push 37554 by nbeleuzu@mozilla.com at Tue, 30 Jun 2020 10:00:42 +0000
Bug 1633935 - P3 send OS*R and ODA via pHttpChannel for multipart channel, r=mayhemer,necko-reviewers Depends on D76969 Differential Revision: https://phabricator.services.mozilla.com/D76970
cbcd3ee87d283caccf60c8b9dc40dabb819e5942: Bug 1633935 - P2 remove OnStartRequestSent since OnStartRequest is passed thru pBg, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 00:32:38 +0000 - rev 537870
Push 37554 by nbeleuzu@mozilla.com at Tue, 30 Jun 2020 10:00:42 +0000
Bug 1633935 - P2 remove OnStartRequestSent since OnStartRequest is passed thru pBg, r=mayhemer,necko-reviewers Depends on D73529 Differential Revision: https://phabricator.services.mozilla.com/D76969
b8f55064bfeb151f77c084d04f3def3bcd96679a: Bug 1633935 - P1 allow OnStartRequest go thru pBg IPC, r=mayhemer
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 00:32:25 +0000 - rev 537869
Push 37554 by nbeleuzu@mozilla.com at Tue, 30 Jun 2020 10:00:42 +0000
Bug 1633935 - P1 allow OnStartRequest go thru pBg IPC, r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D73529
f16199c7d45e574841e27330397e0a4c67456d61: Bug 1648898 - Fix data race on STS loop start. r=mayhemer
Jean-Yves Avenard <jyavenard@mozilla.com> - Mon, 29 Jun 2020 22:59:20 +0000 - rev 537863
Push 37554 by nbeleuzu@mozilla.com at Tue, 30 Jun 2020 10:00:42 +0000
Bug 1648898 - Fix data race on STS loop start. r=mayhemer The STS dispatched the first event before setting mThread member. It was possible that the STS::Run() task got started before mThread was set and causing one of the nsISerialEventTarget methods to read mThread/mInitialised/mShuttingDown value as null or zero and they would have returned an error. We rewrite and simplify the access to mThread such that it's a lockless operation. ApplyPortRemapPreference assert that it's running on the taskqueue; however if called before initialization, it would have been run on whatever thread called ApplyPortRemap. Differential Revision: https://phabricator.services.mozilla.com/D81334
34d09061d8272ede6d1bf4ce0cb91b223eabd5d2: Bug 1648134 - Permission Manager does not save changes when scope is changed., r=mayhemer
Andrea Marchesini <amarchesini@mozilla.com> - Mon, 29 Jun 2020 14:37:19 +0000 - rev 537790
Push 37553 by ncsoregi@mozilla.com at Tue, 30 Jun 2020 02:09:30 +0000
Bug 1648134 - Permission Manager does not save changes when scope is changed., r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D81292
8cb44457d71805d8300eaf3d54a2a08317112880: Bug 1645901 - only waiting for main thread OnStartRequestSent for LOAD_DOCUMENT_NEEDS_COOKIE, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Wed, 24 Jun 2020 14:01:02 +0000 - rev 537226
Push 37539 by nerli@mozilla.com at Thu, 25 Jun 2020 03:22:32 +0000
Bug 1645901 - only waiting for main thread OnStartRequestSent for LOAD_DOCUMENT_NEEDS_COOKIE, r=mayhemer,necko-reviewers Depends on D79771 Differential Revision: https://phabricator.services.mozilla.com/D80682
0fa32f49b4e02b93a74a007b9bd7523818a8954e: Bug 1646136 - Improve the comments in the preload/prefetch tests for network state isolation, r=mayhemer
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 24 Jun 2020 16:16:00 +0000 - rev 537192
Push 37537 by ncsoregi@mozilla.com at Wed, 24 Jun 2020 21:50:10 +0000
Bug 1646136 - Improve the comments in the preload/prefetch tests for network state isolation, r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D80903
8d5bc317935c4ae68dcb14fab6f027d1aa247c10: Bug 1646136 - Isolate preload channels per first-party when privacy.partition.network_state is set to true, r=mayhemer
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 24 Jun 2020 15:34:33 +0000 - rev 537189
Push 37537 by ncsoregi@mozilla.com at Wed, 24 Jun 2020 21:50:10 +0000
Bug 1646136 - Isolate preload channels per first-party when privacy.partition.network_state is set to true, r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D80047
baa45f675f4cb872342c5ac92bbd0411bd2701e6: Bug 1646136 - Isolate prefetch channels per first-party when privacy.partition.network_state is set to true, r=mayhemer
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 24 Jun 2020 15:31:31 +0000 - rev 537188
Push 37537 by ncsoregi@mozilla.com at Wed, 24 Jun 2020 21:50:10 +0000
Bug 1646136 - Isolate prefetch channels per first-party when privacy.partition.network_state is set to true, r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D80046
012d160f7e5d47a737c3a177e964c6f80894f0d0: Bug 1647638 - Fix static-analysis warnings in nsStandardURL r=mayhemer,necko-reviewers
Valentin Gosu <valentin.gosu@gmail.com> - Wed, 24 Jun 2020 10:18:49 +0000 - rev 537078
Push 37536 by rmaries@mozilla.com at Wed, 24 Jun 2020 16:24:33 +0000
Bug 1647638 - Fix static-analysis warnings in nsStandardURL r=mayhemer,necko-reviewers Differential Revision: https://phabricator.services.mozilla.com/D80624
1bffa7a16cf9645cf787f0b98f66b768978c199c: Bug 1647638 - Add nsStandardURL assertions r=mayhemer,necko-reviewers
Valentin Gosu <valentin.gosu@gmail.com> - Wed, 24 Jun 2020 10:12:15 +0000 - rev 537077
Push 37536 by rmaries@mozilla.com at Wed, 24 Jun 2020 16:24:33 +0000
Bug 1647638 - Add nsStandardURL assertions r=mayhemer,necko-reviewers Differential Revision: https://phabricator.services.mozilla.com/D80600
398fc19f5f6adf0a58ddb43e2efbaac571db320b: Bug 1633935 - P13 Avoid ODA message being processed when the channel is already failed, r=mayhemer,kershaw,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 17:02:55 +0000 - rev 536992
Push 37534 by malexandru@mozilla.com at Wed, 24 Jun 2020 09:31:07 +0000
Bug 1633935 - P13 Avoid ODA message being processed when the channel is already failed, r=mayhemer,kershaw,necko-reviewers One line fix with a bunch of explanation. When we perform networking on the socket process, OnDataAvailable could be sent directly from socket process to child process. Therefore, it could be racy with OnStartRequest which is from parent process to child process by nature. This patch is to resolve the failure (cancel) by parent process. For example, https://searchfox.org/mozilla-central/rev/027893497316897b8f292bde48dbb6da2391a331/netwerk/protocol/http/nsHttpChannel.cpp#2713 Bug 1641496 introduce a status check to avoid ODA message being process [2] https://searchfox.org/mozilla-central/rev/027893497316897b8f292bde48dbb6da2391a331/netwerk/protocol/http/HttpBackgroundChannelChild.cpp#163-171 It prevents putting ODA to the channel event queue in child process. However, this is based on that `OnStartRequest` already finished excution, which is usually true if OnStartRequest is sent via PHttpChannel. https://searchfox.org/mozilla-central/rev/027893497316897b8f292bde48dbb6da2391a331/netwerk/protocol/http/HttpChannelChild.cpp#417-422 ChannelEventQueue::RunOrEnque simply runs the OnStartRequest given there on the same thread and the queue is empty, since no blocking events from different thread are before OnStartRequest. Now we are moving the next chapter. OnStartRequest is queued given we want to switch thread. The failure status, which is initiated in parent process, is set in HttpChannelChild::OnStartRequest which could be later than the status check [2] Therefore, we need another check to prevent ODA, which is already in the event queue, being processed. We intentionally keep [2] for performance. Differential Revision: https://phabricator.services.mozilla.com/D79771
25822279ba5b7b695bd9173969877e8d5ba19000: Bug 1633935 - P12 top-level IPC stream filter should happen before OnStartRequest, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 16:58:40 +0000 - rev 536991
Push 37534 by malexandru@mozilla.com at Wed, 24 Jun 2020 09:31:07 +0000
Bug 1633935 - P12 top-level IPC stream filter should happen before OnStartRequest, r=mayhemer,necko-reviewers The WebRequest will suspend the channel in nsHttpChannel::PrepareToConnect(), apply the stream filter, send the main thread IPC and resume. That is, PHttpChannel::AttachStreamFilter should be handled in Child before OnStartRequest goes to listener. Differential Revision: https://phabricator.services.mozilla.com/D79770
e87b11c172b91358388fe38edf7cb15b35ed13eb: Bug 1633935 - P11 Move classification IPC methods back to PHttpChannel. r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 16:58:38 +0000 - rev 536990
Push 37534 by malexandru@mozilla.com at Wed, 24 Jun 2020 09:31:07 +0000
Bug 1633935 - P11 Move classification IPC methods back to PHttpChannel. r=mayhemer,necko-reviewers Bug 1015466 move them from PContent to Pbg since it believes those events are fine to received before OnStopRequest. Bug 1588241 move it back to PContent since those events are before OnStartRequest. Now we're moving OnStartRequest to pBg, so here's another ping-pong time :) Differential Revision: https://phabricator.services.mozilla.com/D79587
709f8d50aa33f299e1e72366c59b1c28ad0b547b: Bug 1633935 - P10 wait PHttpChannel::OnStartRequestSent for permission/cookie update from parent, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 16:58:36 +0000 - rev 536989
Push 37534 by malexandru@mozilla.com at Wed, 24 Jun 2020 09:31:07 +0000
Bug 1633935 - P10 wait PHttpChannel::OnStartRequestSent for permission/cookie update from parent, r=mayhemer,necko-reviewers Depends on D77751 Differential Revision: https://phabricator.services.mozilla.com/D77752
3b268ac50692bae6b1bcd0c41e61e267a6735e68: Bug 1633935 - P9 send OnAfterLastPart via pBg IPC to avoid race between OS*R, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 16:58:33 +0000 - rev 536988
Push 37534 by malexandru@mozilla.com at Wed, 24 Jun 2020 09:31:07 +0000
Bug 1633935 - P9 send OnAfterLastPart via pBg IPC to avoid race between OS*R, r=mayhemer,necko-reviewers Depends on D77750 Differential Revision: https://phabricator.services.mozilla.com/D77751
ac9c5c1e51626997c1d28923e07d220780ed02a5: Bug 1633935 - P8 suspend event queue in HttpChannelChild which needs listener for redirection, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 16:58:29 +0000 - rev 536987
Push 37534 by malexandru@mozilla.com at Wed, 24 Jun 2020 09:31:07 +0000
Bug 1633935 - P8 suspend event queue in HttpChannelChild which needs listener for redirection, r=mayhemer,necko-reviewers Now OnStartRequest is passed to child process via pBg. Every IPC which is passed thru main thread could become a race. For the redirection flow in child process is: (1) HTC::ConnectParent(): Let parent know this is the targeted child, so OnStartRequest could start here. (2) HTC::CompleteRedirectSetup(listener): Now we're finish the setup, including listener. From now on, we're ready to accept OnStartRequest Hence, between (1) and (2), and need to suspend the eventQ to prevent OnStartRequest pump without listener. On the other hand, if the redirection is vetoed by parent, (2) will not be sent. RecvDeleteSelf instead. Resuming the eventQ to prevent leakage. Depends on D77749 Differential Revision: https://phabricator.services.mozilla.com/D77750
73b51a139c915c7e4aa7b9bff58769bd21cfcd78: Bug 1633935 - P5 allow OnProgress/OnStatus going thru pBg IPC, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 16:57:10 +0000 - rev 536984
Push 37534 by malexandru@mozilla.com at Wed, 24 Jun 2020 09:31:07 +0000
Bug 1633935 - P5 allow OnProgress/OnStatus going thru pBg IPC, r=mayhemer,necko-reviewers Depends on D76971 Differential Revision: https://phabricator.services.mozilla.com/D76972
2a9873ad68561b991cef5795e239a571f08e5aac: Bug 1633935 - P4 Remove On[Start|Stop]Request/OnTransportAndData in PHttpChannel, r=mayhemer,nika,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 16:56:53 +0000 - rev 536983
Push 37534 by malexandru@mozilla.com at Wed, 24 Jun 2020 09:31:07 +0000
Bug 1633935 - P4 Remove On[Start|Stop]Request/OnTransportAndData in PHttpChannel, r=mayhemer,nika,necko-reviewers We move OnStartRequest from PHttpChannel to PHttpBackgroundChannel, thus adjusting message-metadata.ini Depends on D76970 Differential Revision: https://phabricator.services.mozilla.com/D76971
be03e0e7b64568618b834834602b5ba303b32214: Bug 1633935 - P3 send OS*R and ODA via pHttpChannel for multipart channel, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 16:56:45 +0000 - rev 536982
Push 37534 by malexandru@mozilla.com at Wed, 24 Jun 2020 09:31:07 +0000
Bug 1633935 - P3 send OS*R and ODA via pHttpChannel for multipart channel, r=mayhemer,necko-reviewers Depends on D76969 Differential Revision: https://phabricator.services.mozilla.com/D76970
df5abc2c0734e00ba28aa345d04515509c8921fc: Bug 1633935 - P2 remove OnStartRequestSent since OnStartRequest is passed thru pBg, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 16:56:32 +0000 - rev 536981
Push 37534 by malexandru@mozilla.com at Wed, 24 Jun 2020 09:31:07 +0000
Bug 1633935 - P2 remove OnStartRequestSent since OnStartRequest is passed thru pBg, r=mayhemer,necko-reviewers Depends on D73529 Differential Revision: https://phabricator.services.mozilla.com/D76969
19dcca77a1cf1c590dfda293418aec84cce701de: Bug 1633935 - P1 allow OnStartRequest go thru pBg IPC, r=mayhemer
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 16:56:15 +0000 - rev 536980
Push 37534 by malexandru@mozilla.com at Wed, 24 Jun 2020 09:31:07 +0000
Bug 1633935 - P1 allow OnStartRequest go thru pBg IPC, r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D73529
be056dc9e0f172d138765164fa3740ccbf314532: Bug 1646776 - Move the preloader for stylesheets to SheetLoadData rather than StreamLoader. r=mayhemer
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 22 Jun 2020 18:10:07 +0000 - rev 536707
Push 37532 by abutkovits@mozilla.com at Tue, 23 Jun 2020 16:15:06 +0000
Bug 1646776 - Move the preloader for stylesheets to SheetLoadData rather than StreamLoader. r=mayhemer So as to make sense in a world where we can coalesce loads across documents. The per-load object is the SheetLoadData, so this way we guarantee that we fire the right events in presence of the load coalescing that the SharedStyleSheetCache does. Differential Revision: https://phabricator.services.mozilla.com/D80380
5855c8067f8d77342cecef75362ba97fab20e2b4: Bug 1646776 - Make sure to fire load rather than error events for preload links that hit the CSS cache. r=mayhemer
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 22 Jun 2020 14:18:19 +0000 - rev 536585
Push 37531 by nbeleuzu@mozilla.com at Tue, 23 Jun 2020 03:44:39 +0000
Bug 1646776 - Make sure to fire load rather than error events for preload links that hit the CSS cache. r=mayhemer When we hit the stylesheet cache for an existing stylesheet in a different document: * There's no existing preload in the PreloadService (because the sheet was loaded in another document). * We don't create a PreloaderBase (because we don't trigger a load at all). * And thus we believe the load has just errored, which is wrong... Fix it by properly passing through the "already complete" status from PreloadStyle. Note that there's still another issue, which is that we'd still hit this broken path if two stylesheets with the same URI are loading in different documents and the CSS loader coalesces them. For that, I think we'd have to make SheetLoadData the thing that actually implements PreloaderBase. This is kind of an obscure case, and SheetLoadData has a pretty complex lifetime already (keeps alive a whole lot of stuff), so I'd prefer to do this in a separate bug. Differential Revision: https://phabricator.services.mozilla.com/D80289
d1ad1625fbaf418fa03a101b35c98b9bd49702a2: Bug 1642591 - Remove two subtests that are no longer expected to pass. r=mayhemer
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 18 Jun 2020 14:09:29 +0000 - rev 536309
Push 37519 by ccoroiu@mozilla.com at Thu, 18 Jun 2020 21:28:28 +0000
Bug 1642591 - Remove two subtests that are no longer expected to pass. r=mayhemer I feel a bit torn about these because they test real (if obscure) issues with the speculative loader... But it's not clear to me it's worth it to add plumbing to only check referrer policy if the load is speculative, and our behavior matches Chrome in the following test-case[1][2]. [1]: https://crisal.io/tmp/meta_referrer.html [2]: https://crisal.io/tmp/referrer.php?source Differential Revision: https://phabricator.services.mozilla.com/D79861
5655f189181d5db549a16bc4ad58850d9f82d57d: Bug 1646056 - Use const references as keys instead of raw pointers for PreloadHashKey. r=mayhemer
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 18 Jun 2020 14:06:34 +0000 - rev 536308
Push 37519 by ccoroiu@mozilla.com at Thu, 18 Jun 2020 21:28:28 +0000
Bug 1646056 - Use const references as keys instead of raw pointers for PreloadHashKey. r=mayhemer Feels a bit more natural for the callers this way. This should have no behavior change. Differential Revision: https://phabricator.services.mozilla.com/D79831
bd0e0254827d374d5346648963ba63f7f7f99276: Bug 1642591 - Don't make referrer policy a cache miss for sub-resource {pre,}loads. r=mayhemer,tnikkel
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 18 Jun 2020 14:06:20 +0000 - rev 536307
Push 37519 by ccoroiu@mozilla.com at Thu, 18 Jun 2020 21:28:28 +0000
Bug 1642591 - Don't make referrer policy a cache miss for sub-resource {pre,}loads. r=mayhemer,tnikkel For preload we're already effectively not using it, I think, due to bug 1642325. For images, this matches the spec, see earlier comments in this bug and https://bugzilla.mozilla.org/show_bug.cgi?id=1174921#c17. I think it makes sense for other sub-resources to align as well. Differential Revision: https://phabricator.services.mozilla.com/D79812
8150a441755b5f616e8bbd8ffc9d05436109fbf6: Bug 1641303 - Use query and ref lengths if available r=mayhemer,necko-reviewers
Valentin Gosu <valentin.gosu@gmail.com> - Wed, 17 Jun 2020 08:29:21 +0000 - rev 536227
Push 37517 by malexandru@mozilla.com at Thu, 18 Jun 2020 04:43:29 +0000
Bug 1641303 - Use query and ref lengths if available r=mayhemer,necko-reviewers Differential Revision: https://phabricator.services.mozilla.com/D77418
f637e40aae7926d379e6801663c1aec5eba4e11f: Bug 1646032 - Avoid a silly string copy in PreloadService. r=mayhemer
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 16 Jun 2020 14:07:18 +0000 - rev 535905
Push 37513 by rmaries@mozilla.com at Wed, 17 Jun 2020 03:41:56 +0000
Bug 1646032 - Avoid a silly string copy in PreloadService. r=mayhemer There's no real need to go through a DOMString here. Differential Revision: https://phabricator.services.mozilla.com/D79815