searching for reviewer(mats)
3654d1720dab: Bug 1543672 - The counters code should use atoms rather than strings. r=mats,boris
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 15 Apr 2019 20:11:45 +0000 - rev 469560
Push 35874 by ccoroiu@mozilla.com at Tue, 16 Apr 2019 04:04:58 +0000
Bug 1543672 - The counters code should use atoms rather than strings. r=mats,boris Servo already atomizes the counter names, it makes no sense to copy the string rather than bumping the refcount. Differential Revision: https://phabricator.services.mozilla.com/D27061
e4d51df238b6: Bug 1543758 - Pseudo-elements should be allowed to be list-items. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 13 Apr 2019 22:22:51 +0000 - rev 469423
Push 35867 by aiakab@mozilla.com at Sun, 14 Apr 2019 09:57:35 +0000
Bug 1543758 - Pseudo-elements should be allowed to be list-items. r=mats Per https://github.com/w3c/csswg-drafts/issues/3766 Differential Revision: https://phabricator.services.mozilla.com/D27122
78ed7f9d6566: Bug 1542530 - Selection.toString() works correctly when text is selected together with a set of div+svg elements, r=mats
Andrea Marchesini <amarchesini@mozilla.com> - Thu, 11 Apr 2019 14:13:24 +0000 - rev 469016
Push 35856 by csabou@mozilla.com at Fri, 12 Apr 2019 03:19:48 +0000
Bug 1542530 - Selection.toString() works correctly when text is selected together with a set of div+svg elements, r=mats Differential Revision: https://phabricator.services.mozilla.com/D27064
4ec02d2be99e: Bug 1539171 - Make the list-item increment not visible from the computed style. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 11 Apr 2019 15:21:17 +0000 - rev 469013
Push 35856 by csabou@mozilla.com at Fri, 12 Apr 2019 03:19:48 +0000
Bug 1539171 - Make the list-item increment not visible from the computed style. r=mats This is per https://drafts.csswg.org/css-lists/#declaring-a-list-item. I intentionally kept <li value> defined using attribute mapping, I think that's saner than special-casing it in layout. Differential Revision: https://phabricator.services.mozilla.com/D24935
441551c28fbf: Bug 1543401 - Use rust lengths for row-gap / column-gap. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 10 Apr 2019 16:00:03 +0000 - rev 468907
Push 35854 by aciure@mozilla.com at Thu, 11 Apr 2019 09:50:57 +0000
Bug 1543401 - Use rust lengths for row-gap / column-gap. r=mats Differential Revision: https://phabricator.services.mozilla.com/D26915
399822369a16: Bug 1543161 - Simplify some rules used for file inputs. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 09 Apr 2019 18:05:18 +0200 - rev 468884
Push 35853 by dvarga@mozilla.com at Thu, 11 Apr 2019 04:22:28 +0000
Bug 1543161 - Simplify some rules used for file inputs. r=mats There's only one button in a file input. This used to be an input[type="button"]. There's no point in using more specific rules or such, the regular UA rules just work, and content can't style this button so it can't be overriden. This should be an idempotent patch. Differential Revision: https://phabricator.services.mozilla.com/D26753
34c20181c54f: Bug 1541668 - Make nsTextFrame::GetRenderedText ignore full-width and full-size-kana transforms. r=Jamie,mats
Jonathan Kew <jkew@mozilla.com> - Fri, 05 Apr 2019 14:44:43 +0000 - rev 468174
Push 35822 by shindli@mozilla.com at Fri, 05 Apr 2019 21:47:45 +0000
Bug 1541668 - Make nsTextFrame::GetRenderedText ignore full-width and full-size-kana transforms. r=Jamie,mats Differential Revision: https://phabricator.services.mozilla.com/D26146
14fdab21409c: Bug 1533554 - check for integer overflow; r=mats
Alex Gaynor <agaynor@mozilla.com> - Mon, 25 Mar 2019 17:02:11 +0000 - rev 467590
Push 35804 by rgurzau@mozilla.com at Tue, 02 Apr 2019 21:49:08 +0000
Bug 1533554 - check for integer overflow; r=mats Differential Revision: https://phabricator.services.mozilla.com/D22770
83ef6d9515c9: Bug 1517080 Part 6 - Remove nsFrameItems alias, and rename variables with suffix "Items" to "List". r=mats
Ting-Yu Lin <tlin@mozilla.com> - Sat, 30 Mar 2019 04:45:47 +0000 - rev 466937
Push 35787 by nbeleuzu@mozilla.com at Sat, 30 Mar 2019 21:44:18 +0000
Bug 1517080 Part 6 - Remove nsFrameItems alias, and rename variables with suffix "Items" to "List". r=mats Differential Revision: https://phabricator.services.mozilla.com/D15556
ede8668de94c: Bug 1517080 Part 5 - Rename nsAbsoluteItems to mozilla::AbsoluteFrameList. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Sat, 30 Mar 2019 04:45:40 +0000 - rev 466936
Push 35787 by nbeleuzu@mozilla.com at Sat, 30 Mar 2019 21:44:18 +0000
Bug 1517080 Part 5 - Rename nsAbsoluteItems to mozilla::AbsoluteFrameList. r=mats Also, rename variables that have suffix "Items" to "List". Differential Revision: https://phabricator.services.mozilla.com/D15555
7d5192894473: Bug 1517080 Part 4 - Make nsFrameItems an alias of nFrameList, and remove nsFrameItems. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Sat, 30 Mar 2019 03:25:10 +0000 - rev 466935
Push 35787 by nbeleuzu@mozilla.com at Sat, 30 Mar 2019 21:44:18 +0000
Bug 1517080 Part 4 - Make nsFrameItems an alias of nFrameList, and remove nsFrameItems. r=mats nsFrameItems will be removed in Part 6. Differential Revision: https://phabricator.services.mozilla.com/D15554
c838c81514b3: Bug 1517080 Part 3 - Replace remaining nsFrameItem::Add() with nsFrameList::AppendFrame(). r=mats
Ting-Yu Lin <tlin@mozilla.com> - Sat, 30 Mar 2019 03:31:21 +0000 - rev 466934
Push 35787 by nbeleuzu@mozilla.com at Sat, 30 Mar 2019 21:44:18 +0000
Bug 1517080 Part 3 - Replace remaining nsFrameItem::Add() with nsFrameList::AppendFrame(). r=mats This patch is a mechanical replacement without any reparent, i.e. passing nullptr as parent into nsFrameList::AppendFrame(). Differential Revision: https://phabricator.services.mozilla.com/D25337
2721d70f1b6a: Bug 1517080 Part 2 - Replace nsFrameItems::AddChild() with nsFrameList::AppendFrame() in FinishBuildingScrollFrame(). r=mats
Ting-Yu Lin <tlin@mozilla.com> - Sat, 30 Mar 2019 02:56:27 +0000 - rev 466933
Push 35787 by nbeleuzu@mozilla.com at Sat, 30 Mar 2019 21:44:18 +0000
Bug 1517080 Part 2 - Replace nsFrameItems::AddChild() with nsFrameList::AppendFrame() in FinishBuildingScrollFrame(). r=mats Differential Revision: https://phabricator.services.mozilla.com/D25336
ae2fe9b13897: Bug 1517080 Part 1 - Do not adjust table captions' parent when they're created. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Sat, 30 Mar 2019 02:59:25 +0000 - rev 466932
Push 35787 by nbeleuzu@mozilla.com at Sat, 30 Mar 2019 21:44:18 +0000
Bug 1517080 Part 1 - Do not adjust table captions' parent when they're created. r=mats In order to get rid of nsFrameItems::AddChild() and use nsFrameList::AppendFrame() instead, we need to keep table captions' parent to be nsTableFrame when they're created (no adjust in ConstructFramesFromItem) so that their parent remain the same as other frames in the table when appending into the temporary aFrameItems. We then adjust captions' parent right before we call SetInitialChildList()/AppendFrames/InsertFrames(). Also, pass nullptr to AppendFrames() in nsTableWrapperFrame::AppendFrames() because callers should already set captions' parent frame properly. No need to reparent them again. Differential Revision: https://phabricator.services.mozilla.com/D25335
46ad671b9faf: Bug 1540093 - Unship line-height: -moz-block-height. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 29 Mar 2019 11:11:27 +0000 - rev 466744
Push 35780 by opoprus@mozilla.com at Fri, 29 Mar 2019 21:53:01 +0000
Bug 1540093 - Unship line-height: -moz-block-height. r=mats They're only used in forms.css, and only for some anonymous content, which are not content-accessible in the first place. The only place where this could be exposed is calling getComputedStyle(input, "::placeholder"), so I think this should be pretty safe, but I've added a pref just in case. While at it, also derive the Parse implementation. Less code is better. Differential Revision: https://phabricator.services.mozilla.com/D25118
7077ebbd4677: Bug 1540093 - Refactor some enabledness checks. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 29 Mar 2019 11:12:12 +0000 - rev 466743
Push 35780 by opoprus@mozilla.com at Fri, 29 Mar 2019 21:53:01 +0000
Bug 1540093 - Refactor some enabledness checks. r=mats There are some common checks that could get some easy-to-use aliases. Differential Revision: https://phabricator.services.mozilla.com/D25117
52bda46586ef: Bug 1538589 - Fix ::marker invalidation when we need to potentially insert a marker as a result of a style change. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 28 Mar 2019 13:50:13 +0000 - rev 466573
Push 35773 by ncsoregi@mozilla.com at Fri, 29 Mar 2019 04:11:36 +0000
Bug 1538589 - Fix ::marker invalidation when we need to potentially insert a marker as a result of a style change. r=mats Differential Revision: https://phabricator.services.mozilla.com/D24888
1803e27751d6: Bug 1539267 - Bug 1539171 - Follow the list-item definition from the spec a bit more closely. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 27 Mar 2019 15:03:20 +0000 - rev 466379
Push 35768 by opoprus@mozilla.com at Thu, 28 Mar 2019 09:55:54 +0000
Bug 1539267 - Bug 1539171 - Follow the list-item definition from the spec a bit more closely. r=mats The HTML restriction doesn't match any browser. This matches Edge, though I filed https://github.com/w3c/csswg-drafts/issues/3766 about the pseudo-element condition. Differential Revision: https://phabricator.services.mozilla.com/D24936
1070ea9495a0: Bug 1535200 Part 1 - In fieldset, make absolute positioned frames relative to multicol container, not the column content frames. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Mon, 18 Mar 2019 05:47:53 +0000 - rev 465354
Push 35736 by ncsoregi@mozilla.com at Thu, 21 Mar 2019 10:40:08 +0000
Bug 1535200 Part 1 - In fieldset, make absolute positioned frames relative to multicol container, not the column content frames. r=mats Per spec, "Note: Column boxes do not become the containing block for elements with position: fixed or position: absolute. The containing block is the multicol container, it being the principal box." https://drafts.csswg.org/css-multicol-1/#the-multi-column-model contentFrame and contentFrameTop are different only if fieldset has multicol layout. In that case, contentFrameTop is nsColumnSetFrame (or ColumnSetWrapperFrame after applying Part 2 with layout.css.column-span.enabled=true). Differential Revision: https://phabricator.services.mozilla.com/D23617
9e30503eb033: Bug 1468140 - Call AccessibleCaretEventHub::Init in a ScriptRunner. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Wed, 20 Mar 2019 18:15:55 +0000 - rev 465285
Push 35735 by shindli@mozilla.com at Thu, 21 Mar 2019 04:34:45 +0000
Bug 1468140 - Call AccessibleCaretEventHub::Init in a ScriptRunner. r=mats Differential Revision: https://phabricator.services.mozilla.com/D9568
afb8dc106fc6: Bug 1493317 Part 1 - Fix pending popup group assertion after enabling AccessibleCaret in unittest. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Sat, 16 Mar 2019 07:29:11 +0000 - rev 464480
Push 35716 by aciure@mozilla.com at Sun, 17 Mar 2019 09:42:17 +0000
Bug 1493317 Part 1 - Fix pending popup group assertion after enabling AccessibleCaret in unittest. r=mats The assertion can be reproduced locally by running "./mach test dom/canvas/test/chrome/test_drawWindow_widget_layers.html" with layout.accessiblecaret.enabled=true. When AccessibleCaret is enabled, caret elements will be inserted into nsCanvasFrame::mCustomContentContainer, thus it recursively invokes ConstructFramesFromItemList() to construct frames for carets before it had a chance to construct popup group. I feel it's too strict to assume that ConstructFramesFromItemList() cannot be invoke recursively whenever there's a popup group item. I move the assertion to the end of ConstructDocElementFrame() to ensure the popup group is processed by then. Differential Revision: https://phabricator.services.mozilla.com/D10298
5edf9199407c: Bug 1450652 - Remove platform support for display="" in XBL bindings. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 06 Mar 2019 00:47:13 +0000 - rev 462534
Push 35655 by ncsoregi@mozilla.com at Wed, 06 Mar 2019 16:12:01 +0000
Bug 1450652 - Remove platform support for display="" in XBL bindings. r=mats Differential Revision: https://phabricator.services.mozilla.com/D12586
4c9a6871dc03: Bug 1512993 - Get rid of XBL display usage for buttons and toolbarbuttons. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 04 Mar 2019 17:20:29 +0000 - rev 462346
Push 35650 by shindli@mozilla.com at Tue, 05 Mar 2019 21:40:07 +0000
Bug 1512993 - Get rid of XBL display usage for buttons and toolbarbuttons. r=mats This is the last use of them! Differential Revision: https://phabricator.services.mozilla.com/D21924
14009f721da2: Bug 1354933. Assert that the frame pointer is null in the nsView destructor. r=mats
Timothy Nikkel <tnikkel@gmail.com> - Thu, 14 Feb 2019 23:07:21 -0600 - rev 459529
Push 35562 by csabou@mozilla.com at Fri, 15 Feb 2019 18:40:35 +0000
Bug 1354933. Assert that the frame pointer is null in the nsView destructor. r=mats
08b5d795ff19: Bug 1527519 Part 3 - Replace remaining nsLayoutUtils::GetAsBlock() with do_QueryFrame(), and delete nsLayoutUtils::GetAsBlock(). r=mats
Ting-Yu Lin <tlin@mozilla.com> - Fri, 15 Feb 2019 01:38:05 +0000 - rev 459355
Push 35559 by rmaries@mozilla.com at Fri, 15 Feb 2019 09:55:16 +0000
Bug 1527519 Part 3 - Replace remaining nsLayoutUtils::GetAsBlock() with do_QueryFrame(), and delete nsLayoutUtils::GetAsBlock(). r=mats Depends on D19861 Differential Revision: https://phabricator.services.mozilla.com/D19863
430adf8ca6b2: Bug 1527519 Part 2 - Replace some nsLayoutUtils::GetAsBlock() with nsIFrame::IsBlockFrameOrSubclass(). r=mats
Ting-Yu Lin <tlin@mozilla.com> - Fri, 15 Feb 2019 01:38:04 +0000 - rev 459354
Push 35559 by rmaries@mozilla.com at Fri, 15 Feb 2019 09:55:16 +0000
Bug 1527519 Part 2 - Replace some nsLayoutUtils::GetAsBlock() with nsIFrame::IsBlockFrameOrSubclass(). r=mats Depends on D19860 Differential Revision: https://phabricator.services.mozilla.com/D19861
7e808f7e5cf9: Bug 1527519 Part 1 - Make do_QueryFrame more const-friendly, and mark nsIFrame::IsBlockFrameOrSubclass() as a const method. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Fri, 15 Feb 2019 01:38:04 +0000 - rev 459353
Push 35559 by rmaries@mozilla.com at Fri, 15 Feb 2019 09:55:16 +0000
Bug 1527519 Part 1 - Make do_QueryFrame more const-friendly, and mark nsIFrame::IsBlockFrameOrSubclass() as a const method. r=mats This patch makes do_QueryFrame() accept const frame pointer e.g. "const nsIFrame*", and also helps eliminate a few const_cast in Part 3. Note that the fast path of do_QueryFrame is const-correct, but the slow path is not (due to nsIFrame::QueryFrame() returns void*). For example: ``` const nsIFrame* f; nsBlockFrame* a = do_QueryFrame(f); // fast path, compile error. nsIAnonymousContentCreator* b = do_QueryFrame(f); // slow path, still compiles. ``` Differential Revision: https://phabricator.services.mozilla.com/D19860
c405d8906d7c: Bug 1525101 - Make the XULPopupManager caller to GenerateChildFrames sound. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 12 Feb 2019 18:53:22 +0000 - rev 458777
Push 35548 by opoprus@mozilla.com at Wed, 13 Feb 2019 09:48:26 +0000
Bug 1525101 - Make the XULPopupManager caller to GenerateChildFrames sound. r=mats It only works basically by chance with XBL and doesn't handle any kind of dynamic insertion. See comment 4 in the bug for the diagnostic. Differential Revision: https://phabricator.services.mozilla.com/D19489
7f9e50bfaad1: Bug 1525101 - Make the XULPopupManager caller to GenerateChildFrames sound. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 12 Feb 2019 14:49:57 +0000 - rev 458752
Push 35548 by opoprus@mozilla.com at Wed, 13 Feb 2019 09:48:26 +0000
Bug 1525101 - Make the XULPopupManager caller to GenerateChildFrames sound. r=mats It only works basically by chance with XBL and doesn't handle any kind of dynamic insertion. See comment 4 in the bug for the diagnostic. Differential Revision: https://phabricator.services.mozilla.com/D19489
bf40d50fa8af: Bug 1526971 - Revert over-zealous error checking in nsDataObj::GetDownloadDetails() from bug 571074. r=mats
Jorg K <jorgk@jorgk.com> - Mon, 11 Feb 2019 15:44:00 +0200 - rev 458694
Push 35544 by ccoroiu@mozilla.com at Tue, 12 Feb 2019 16:29:08 +0000
Bug 1526971 - Revert over-zealous error checking in nsDataObj::GetDownloadDetails() from bug 571074. r=mats
ee8803de7f47: Bug 1525628 part 2: Generalize block-frame special case in scrollframe baseline code, so that it includes block subclasses like `<details>`. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 08 Feb 2019 00:38:24 +0000 - rev 458276
Push 35522 by nbeleuzu@mozilla.com at Sat, 09 Feb 2019 03:34:29 +0000
Bug 1525628 part 2: Generalize block-frame special case in scrollframe baseline code, so that it includes block subclasses like `<details>`. r=mats Depends on D19083 Differential Revision: https://phabricator.services.mozilla.com/D19084
91eea845d54e: Bug 1525628 part 1: Add nsIFrame::IsBlockFrameOrSubclass() convenience accessor. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 08 Feb 2019 00:38:12 +0000 - rev 458275
Push 35522 by nbeleuzu@mozilla.com at Sat, 09 Feb 2019 03:34:29 +0000
Bug 1525628 part 1: Add nsIFrame::IsBlockFrameOrSubclass() convenience accessor. r=mats Differential Revision: https://phabricator.services.mozilla.com/D19083
21b74260c8a9: Bug 969874: Make scrollable frames derive their baseline from their scrolled content (unless their display value is block-inside). r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 06 Feb 2019 00:22:56 +0000 - rev 457349
Push 35506 by opoprus@mozilla.com at Wed, 06 Feb 2019 09:47:29 +0000
Bug 969874: Make scrollable frames derive their baseline from their scrolled content (unless their display value is block-inside). r=mats Before this patch, we made scrollable frames derive their baseline from their margin-box, because that's what the spec requires for scrollable inline-block boxes. However, the spec now singles out inline-block as a special case, and other sorts of scrollable inline-level containers are supposed to derive their baseline from the scrolled content. So, this patch makes us do that, with an exception for scrollable inline-block boxes. For more info about the block-inside special case, see the end of the "block containers" chunk here: https://drafts.csswg.org/css-align/#baseline-export (Though that spec text may be a bit too specific, per my spec issue at https://github.com/w3c/csswg-drafts/issues/3611 -- that's why this patch checks for block-inside rather than inline-block.) Differential Revision: https://phabricator.services.mozilla.com/D18481
dbdbcc95849b: Bug 1525133: Explicitly skip orthogonal-flow children when determining last-baseline of a block from its children. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 05 Feb 2019 19:45:46 +0000 - rev 457320
Push 35506 by opoprus@mozilla.com at Wed, 06 Feb 2019 09:47:29 +0000
Bug 1525133: Explicitly skip orthogonal-flow children when determining last-baseline of a block from its children. r=mats Without the check that I'm adding in this patch, we'd violate the "parallel writing mode" expectation of some baseline accessors that we use in the now-guarded code. And we'd produce bogus layout as a result. The added assertions are just for good measure. The included testcase causes us to fail both assertions, in a build that's missing the fix. Differential Revision: https://phabricator.services.mozilla.com/D18715
1c3a7347d224: Bug 1522898: Account for box-sizing (add border & padding) when setting a main-size property value override on a flex item (which it uses for aspect ratio calculations). r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 04 Feb 2019 23:06:16 +0000 - rev 456754
Push 35504 by csabou@mozilla.com at Tue, 05 Feb 2019 21:57:12 +0000
Bug 1522898: Account for box-sizing (add border & padding) when setting a main-size property value override on a flex item (which it uses for aspect ratio calculations). r=mats For elements that have box-sizing:border-box specified, the aspect ratio calculation code subtracts out border & padding from any specified property values. So, when we create a fake "override" specified property value for a flex item whose main size has been resolved, we need to add in the border and padding to account for the fact that they're going to be subtracted out later. Differential Revision: https://phabricator.services.mozilla.com/D17712
06e188d40c8d: Bug 1490619 - Fall back to the computed value for overconstrained abspos / fixed pos. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 04 Feb 2019 23:28:44 +0000 - rev 456745
Push 35504 by csabou@mozilla.com at Tue, 05 Feb 2019 21:57:12 +0000
Bug 1490619 - Fall back to the computed value for overconstrained abspos / fixed pos. r=mats Differential Revision: https://phabricator.services.mozilla.com/D5667
53951b4b6ac2: Bug 1524266 - Should be able to delete non-selectable and non-editable content in a contenteditable subtree. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 01 Feb 2019 18:13:28 +0100 - rev 456606
Push 35496 by btara@mozilla.com at Mon, 04 Feb 2019 17:36:40 +0000
Bug 1524266 - Should be able to delete non-selectable and non-editable content in a contenteditable subtree. r=mats This makes our behavior a bit closer to Blink / WebKit. This patch fixes multiple issues: First, fixes the caret movement getting stuck on a <select> element inside an editor. This is because of the IsRootOfAnonymousSubtree() check that I'm removing. Instead of that, consider NAC unselectable in UsedUserSelect, just like generated content. This makes us jump across it correctly, and doesn't regress the test-case that was added in bug 989012. Second, it allows to select nodes with user-select: none as long as you're on an editor. This matches WebKit and Blink. It's something you could do earlier regardless with user-select: all on the parent, which is why the reporter's test-case worked before my patch. I think being able to jump across these and delete them on an editor is the right thing to do. It adds tests for all this plus the same thing working for non-editable contents (there was no pre-existing test for that). Differential Revision: https://phabricator.services.mozilla.com/D18494
4d5cbdd05859: Bug 1524266 - Should be able to delete non-selectable and non-editable content in a contenteditable subtree. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 03 Feb 2019 23:13:09 +0000 - rev 456596
Push 35494 by opoprus@mozilla.com at Mon, 04 Feb 2019 09:23:09 +0000
Bug 1524266 - Should be able to delete non-selectable and non-editable content in a contenteditable subtree. r=mats This makes our behavior a bit closer to Blink / WebKit. This patch fixes multiple issues: First, fixes the caret movement getting stuck on a <select> element inside an editor. This is because of the IsRootOfAnonymousSubtree() check that I'm removing. Instead of that, consider NAC unselectable in UsedUserSelect, just like generated content. This makes us jump across it correctly, and doesn't regress the test-case that was added in bug 989012. Second, it allows to select nodes with user-select: none as long as you're on an editor. This matches WebKit and Blink. It's something you could do earlier regardless with user-select: all on the parent, which is why the reporter's test-case worked before my patch. I think being able to jump across these and delete them on an editor is the right thing to do. It adds tests for all this plus the same thing working for non-editable contents (there was no pre-existing test for that). Differential Revision: https://phabricator.services.mozilla.com/D18494
46591113989e: Bug 1515822 - Capture frame state in nsCSSFrameConstructor::ContentRemoved. r=emilio,mats
Wei-Cheng Pan <legnaleurc@gmail.com> - Mon, 28 Jan 2019 11:55:03 +0000 - rev 455602
Push 35453 by rmaries@mozilla.com at Mon, 28 Jan 2019 21:44:32 +0000
Bug 1515822 - Capture frame state in nsCSSFrameConstructor::ContentRemoved. r=emilio,mats Move CaptureStateForFramesOf into ContentRemoved, so we can traverse frames which were under display: contents as well. Differential Revision: https://phabricator.services.mozilla.com/D15319
176554242eb3: Bug 886716 - Fix sorting of text-overflow:ellipsis relative to positioned content. r=mats
Cameron McCormack <cam@mcc.id.au> - Fri, 18 Jan 2019 04:50:02 +0000 - rev 454654
Push 35409 by rmaries@mozilla.com at Mon, 21 Jan 2019 17:48:45 +0000
Bug 886716 - Fix sorting of text-overflow:ellipsis relative to positioned content. r=mats Differential Revision: https://phabricator.services.mozilla.com/D15504
824c36902a37: Bug 1520229 - [css-logical] Implement the inset shorthand. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 20 Jan 2019 16:48:19 +0100 - rev 454633
Push 35407 by rmaries@mozilla.com at Mon, 21 Jan 2019 11:35:14 +0000
Bug 1520229 - [css-logical] Implement the inset shorthand. r=mats Reviewers: mats Reviewed By: mats Bug #: 1520229 Differential Revision: https://phabricator.services.mozilla.com/D16704
14691f8af836: Bug 1521399 - Remove layout.css.overflow.moz-scrollbars.enabled. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 21 Jan 2019 01:35:00 +0000 - rev 454628
Push 35406 by rmaries@mozilla.com at Mon, 21 Jan 2019 11:32:31 +0000
Bug 1521399 - Remove layout.css.overflow.moz-scrollbars.enabled. r=mats We've been shipping it for a few releases already, see bug 1481125. Differential Revision: https://phabricator.services.mozilla.com/D17081
d50d152c74c7: Bug 957915 - Handle calc(%) on tables. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 15 Jan 2019 19:39:23 +0000 - rev 454101
Push 35387 by aiakab@mozilla.com at Thu, 17 Jan 2019 04:19:37 +0000
Bug 957915 - Handle calc(%) on tables. r=mats This patch makes us handle calc with percentages when we can convert to percentages the same way we handle plain percentages in table layout. We still treat length + percentage as auto (this matches Blink / WebKit as well). There's one case we differ with Blink / WebKit, which is calc(% + 0px), which they'd treat as auto instead of a percentage. I think this is a bug on them (or at least worth some spec clarification). I filed https://github.com/w3c/csswg-drafts/issues/3482 for that. In practice what that'd means for us if the WG decides that Blink / WebKit is right in that case is that we'd need to keep track of whether the calc() specifies lengths, and return false from ConvertsToPercent if so. In any case, nothing that would massively change this patch, and I think enough of an edge case that is not worth blocking on the CSSWG decision here. Though I could be convinced otherwise of course. Differential Revision: https://phabricator.services.mozilla.com/D15719
b8346afda87b: Bug 1516410 - Fix some display: contents code in ContentRemoved. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 15 Jan 2019 18:19:36 +0000 - rev 453966
Push 35382 by dvarga@mozilla.com at Wed, 16 Jan 2019 04:47:18 +0000
Bug 1516410 - Fix some display: contents code in ContentRemoved. r=mats There's no real behavior change, since: * aFlags right now is only used for whitespace suppression optimizations (which we don't do when display: contents is involved anyway). * The CouldBeDisplayContents() check is only an optimization: we're unconditionally recursing into ContentRemoved now, which is not incorrect, just inefficient. I found this while reviewing https://phabricator.services.mozilla.com/D15319 (where this _would_ have an impact on behavior). Differential Revision: https://phabricator.services.mozilla.com/D15373
80dc7df104e6: Bug 1348519 - Part 3: Add web platform tests for grid-template-{columns|rows}. r=mats
Boris Chiou <boris.chiou@gmail.com> - Sat, 12 Jan 2019 02:22:46 +0000 - rev 453599
Push 35360 by nbeleuzu@mozilla.com at Sat, 12 Jan 2019 09:39:47 +0000
Bug 1348519 - Part 3: Add web platform tests for grid-template-{columns|rows}. r=mats Add wpt for testing interpolation result on grid-template-{columns|rows}. Depends on D16129 Differential Revision: https://phabricator.services.mozilla.com/D16130
0bacb9f000cc: Bug 1518339 - Make user-select: auto behave like user-select: text for editing roots. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 08 Jan 2019 20:21:12 +0000 - rev 452955
Push 35336 by rmaries@mozilla.com at Wed, 09 Jan 2019 03:47:21 +0000
Bug 1518339 - Make user-select: auto behave like user-select: text for editing roots. r=mats This is the closest to the spec behavior, I think, and less likely to cause interop issues, but if you prefer me to stop the 'inheritance' chain at contenteditable elements or what not I can also do that. Differential Revision: https://phabricator.services.mozilla.com/D15963
2e4c5ef41c73: Bug 571074 - Mark nsITransferable.getTransferData as [must_use]. r=mats
Tom Schuster <evilpies@gmail.com> - Fri, 04 Jan 2019 16:16:59 +0000 - rev 452553
Push 35314 by shindli@mozilla.com at Fri, 04 Jan 2019 21:48:06 +0000
Bug 571074 - Mark nsITransferable.getTransferData as [must_use]. r=mats Differential Revision: https://phabricator.services.mozilla.com/D13454
7fde7d6f3628: Bug 1513749 - Deduplicate NodesFromRect and Element(s)FromPoint. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 21 Dec 2018 11:00:47 +0000 - rev 451662
Push 35249 by rgurzau@mozilla.com at Fri, 21 Dec 2018 16:34:09 +0000
Bug 1513749 - Deduplicate NodesFromRect and Element(s)FromPoint. r=mats Differential Revision: https://phabricator.services.mozilla.com/D14358
4cea8f588b87: Bug 1513749 - Rename and make nodesFromRect infallible. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 21 Dec 2018 11:00:38 +0000 - rev 451661
Push 35249 by rgurzau@mozilla.com at Fri, 21 Dec 2018 16:34:09 +0000
Bug 1513749 - Rename and make nodesFromRect infallible. r=mats This way it has a more WebIDL-like signature, which will be helpful in a second. Differential Revision: https://phabricator.services.mozilla.com/D14357
72b9ffb09547: Bug 1513749 - Move NodesFromRectHelper to DocumentOrShadowRoot. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 21 Dec 2018 11:30:28 +0000 - rev 451660
Push 35249 by rgurzau@mozilla.com at Fri, 21 Dec 2018 16:34:09 +0000
Bug 1513749 - Move NodesFromRectHelper to DocumentOrShadowRoot. r=mats We'll factor the commont bits out in a bit. Differential Revision: https://phabricator.services.mozilla.com/D14356