searching for reviewer(masayuki)
89f2a15823bc3c64a5e2b55c0d593b4e3949d2a7: Bug 1558704 - Fix spellchecker when XUL is loaded as XHTML r=masayuki
Brendan Dahl <bdahl@mozilla.com> - Thu, 13 Jun 2019 11:53:12 +0000 - rev 478713
Push 36148 by shindli@mozilla.com at Thu, 13 Jun 2019 21:50:57 +0000
Bug 1558704 - Fix spellchecker when XUL is loaded as XHTML r=masayuki Temporary workaround to use the document element as the root content node in XHTML pages that have a XUL root element. Differential Revision: https://phabricator.services.mozilla.com/D34657
c259c1017aa193b8b4a2031488aab0dc779b3a2f: Bug 1557231. Stop using [array] in nsIInlineSpellChecker. r=masayuki
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 06 Jun 2019 06:59:37 +0000 - rev 477577
Push 36119 by ncsoregi@mozilla.com at Thu, 06 Jun 2019 21:52:09 +0000
Bug 1557231. Stop using [array] in nsIInlineSpellChecker. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D33908
325b4a93e95a609fec789dd015c8c84dead86499: Bug 1556656 - Restrict script access for some methods in nsIEditingSession r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Thu, 06 Jun 2019 05:31:16 +0000 - rev 477060
Push 36115 by shindli@mozilla.com at Thu, 06 Jun 2019 09:29:49 +0000
Bug 1556656 - Restrict script access for some methods in nsIEditingSession r=masayuki Some methods in `nsIEditingSession` isn't used from script. So we should move these to `nsEditingSession` or add `[noscript]`. Differential Revision: https://phabricator.services.mozilla.com/D33606
8a3012b4964721cd2bf5800dd910f842901b0d22: Bug 1556799 - Remove manual NAC as soon as parent chain changes. r=masayuki
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 06 Jun 2019 01:48:10 +0000 - rev 477054
Push 36115 by shindli@mozilla.com at Thu, 06 Jun 2019 09:29:49 +0000
Bug 1556799 - Remove manual NAC as soon as parent chain changes. r=masayuki Having NAC bound to the tree when not connected is not quite fine, make sure to clean up properly. Differential Revision: https://phabricator.services.mozilla.com/D33704
da42679e0f9aaab9e950bbb22df89fba3c65208b: Bug 1556925 part 2. Stop using [array] in mozISpellCheckingEngine.getDictionaryList. r=masayuki
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 05 Jun 2019 12:57:32 +0000 - rev 476965
Push 36114 by aiakab@mozilla.com at Wed, 05 Jun 2019 21:59:57 +0000
Bug 1556925 part 2. Stop using [array] in mozISpellCheckingEngine.getDictionaryList. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D33744
8e68aafb0f3cbd0799302a64ef647d1fa5534d88: Bug 1556925 part 1. Stop using [array] in mozISpellCheckingEngine.suggest. r=masayuki
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 05 Jun 2019 12:50:13 +0000 - rev 476964
Push 36114 by aiakab@mozilla.com at Wed, 05 Jun 2019 21:59:57 +0000
Bug 1556925 part 1. Stop using [array] in mozISpellCheckingEngine.suggest. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D33743
9c513f0d9c67fc9545de85e471a5fe0f1ccb4643: Bug 1556922. Stop using [array] in nsIEditorSpellCheck. r=masayuki
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 05 Jun 2019 04:07:28 +0000 - rev 476910
Push 36110 by malexandru@mozilla.com at Wed, 05 Jun 2019 09:49:10 +0000
Bug 1556922. Stop using [array] in nsIEditorSpellCheck. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D33742
1a77272644bc3d6706edb8b6b83b39012d97bcbf: Bug 1551835 - Add Google Docs back to legacy keycode allowlist. r=masayuki
Mike Taylor <miket@mozilla.com> - Tue, 04 Jun 2019 13:52:39 +0000 - rev 476813
Push 36108 by nbeleuzu@mozilla.com at Tue, 04 Jun 2019 21:42:40 +0000
Bug 1551835 - Add Google Docs back to legacy keycode allowlist. r=masayuki Google is aware of the reported issue, but have asked us to opt back into legacy behavior until they can investigate and deploy a fix. Differential Revision: https://phabricator.services.mozilla.com/D33541
9b8cf182a743e50fab37a4a10294ee62e1099a8c: Bug 1415270 - Part 3: Prevent the editing APIs from being called on non-HTML documents; r=masayuki
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 30 May 2019 17:14:05 +0000 - rev 476401
Push 36094 by aiakab@mozilla.com at Fri, 31 May 2019 21:48:40 +0000
Bug 1415270 - Part 3: Prevent the editing APIs from being called on non-HTML documents; r=masayuki This is similar to this Chromium change: https://codereview.chromium.org/1155353002 The editing spec doesn't mention editing non-HTML documents, and historically this is only a feature that WebKit has supported. Supporting this feature increases the attack surface of the browser without a clear benefit, so it seems like a good idea to converge on this behaviour. Differential Revision: https://phabricator.services.mozilla.com/D32913
060d26dc9d2f5410b140c6619634d44dd4be3125: Bug 1415270 - Part 2: Enable editing support for non-HTML documents as well; r=masayuki
Ehsan Akhgari <ehsan@mozilla.com> - Fri, 31 May 2019 01:38:58 +0000 - rev 476400
Push 36094 by aiakab@mozilla.com at Fri, 31 May 2019 21:48:40 +0000
Bug 1415270 - Part 2: Enable editing support for non-HTML documents as well; r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D32912
7910719718f46dfaef7b6124e72b8c2ed2db60f6: Bug 1415270 - Part 1: Move nsHTMLDocument editing APIs to Document; r=farre,masayuki
Ehsan Akhgari <ehsan@mozilla.com> - Fri, 31 May 2019 01:37:26 +0000 - rev 476399
Push 36094 by aiakab@mozilla.com at Fri, 31 May 2019 21:48:40 +0000
Bug 1415270 - Part 1: Move nsHTMLDocument editing APIs to Document; r=farre,masayuki Differential Revision: https://phabricator.services.mozilla.com/D32911
7576696daadb68ac6bf3dd8614e4d90a4dc79eb8: Bug 1554998 - Fix the handling of numeric characters by word-break:break-all. r=masayuki
Jonathan Kew <jkew@mozilla.com> - Wed, 29 May 2019 12:05:20 +0000 - rev 476087
Push 36084 by shindli@mozilla.com at Wed, 29 May 2019 21:50:20 +0000
Bug 1554998 - Fix the handling of numeric characters by word-break:break-all. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D32969
febbc0b025c5ab6d1d96516698fe4374e6d7f63e: Bug 1543439 - Part 3: change and click event fired from browser UI should be considered as an user interaction event; r=masayuki
Edgar Chen <echen@mozilla.com> - Mon, 27 May 2019 12:50:33 +0000 - rev 476030
Push 36083 by nerli@mozilla.com at Wed, 29 May 2019 15:58:28 +0000
Bug 1543439 - Part 3: change and click event fired from browser UI should be considered as an user interaction event; r=masayuki In general case, we set `IsHandlingUserInput` flag in `PresShell::EventHandler::HandleEventWithCurrentEventInfo()` for user interaction event. However the interaction could happen on parent process, like e10s select and input date etc., whose dropdown/popup menu is implemented on parent process and it sends the interaction result to content process, then generates/dispatches corresponding event on content process directly. For such case, we need an addition hook before calling the event listener, just like what we do for popup blocker. It also makes more sense that we handle `popup blocker state` and `IsHandlingUserInput` flag at a consistent time. Differential Revision: https://phabricator.services.mozilla.com/D32020
ffc50cffcf1e0e2362db446bf3415b894bd05a85: Bug 1543439 - Part 2: Move is-user-interaction checks out of PresShell::EventHandler::PrepareToDispatchEvent; r=masayuki
Edgar Chen <echen@mozilla.com> - Mon, 27 May 2019 10:14:06 +0000 - rev 476029
Push 36083 by nerli@mozilla.com at Wed, 29 May 2019 15:58:28 +0000
Bug 1543439 - Part 2: Move is-user-interaction checks out of PresShell::EventHandler::PrepareToDispatchEvent; r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D32019
750e3e013c4cd367bb20592bb6693dee0125dede: Bug 1543439 - Part 1: Move special handling for MouseDown/Up event out of AutoHandlingUserInputStatePusher; r=masayuki
Edgar Chen <echen@mozilla.com> - Wed, 29 May 2019 07:48:16 +0000 - rev 476028
Push 36083 by nerli@mozilla.com at Wed, 29 May 2019 15:58:28 +0000
Bug 1543439 - Part 1: Move special handling for MouseDown/Up event out of AutoHandlingUserInputStatePusher; r=masayuki PresShell::EventHandler::HandleEventWithCurrentEventInfo is the only possible place will do such handling; other places pass either a nullptr or a non-MouseDown/Up event. Differential Revision: https://phabricator.services.mozilla.com/D32431
79436da3bf790b64e33d87f48ee9e2d3a315b109: Bug 1549930 - Avoid popping BrowserParent in response to window lowering. r=masayuki
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 27 May 2019 12:22:37 +0000 - rev 475719
Push 36072 by dluca@mozilla.com at Tue, 28 May 2019 09:38:00 +0000
Bug 1549930 - Avoid popping BrowserParent in response to window lowering. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D30873
5efa9947f556303da0f08a4d8d47d6edd547e72e: Bug 1520456 - test_CF_HTML_clipboard.html should skip non-mac platform instead of detecting platform in html file. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 24 May 2019 06:28:02 +0000 - rev 475340
Push 36060 by cbrindusan@mozilla.com at Fri, 24 May 2019 21:47:21 +0000
Bug 1520456 - test_CF_HTML_clipboard.html should skip non-mac platform instead of detecting platform in html file. r=masayuki test_CF_HTML_clipboard.html does nothing if platform isn't mac. But according to intermittent failure log, this is often failure on Android. I guess that this is infra issue, but we should use skip-if to avoid this failure instead. Differential Revision: https://phabricator.services.mozilla.com/D32413
cc747448727b98078f1369335a61e84fd80bd015: Bug 1550927. Stop using idl [array] for getting supported controller commands. r=masayuki
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 21 May 2019 17:06:06 +0000 - rev 474791
Push 36046 by aiakab@mozilla.com at Tue, 21 May 2019 21:45:52 +0000
Bug 1550927. Stop using idl [array] for getting supported controller commands. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D30764
f6b2612701f631484e59c793308e955b01eada99: Bug 1551086 - Do not finish edit action when unbinding the frame from the editing state. r=masayuki
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 20 May 2019 05:53:24 +0000 - rev 474508
Push 36041 by ccoroiu@mozilla.com at Mon, 20 May 2019 21:55:28 +0000
Bug 1551086 - Do not finish edit action when unbinding the frame from the editing state. r=masayuki The code here was introduced to fix bug 1053048, but the test there and the test-case there no longer need this, and it's generally unsound to do stuff that changes the state of the input from UnbindFromFrame(). I'll file a new bug for the bogus disabled styling in the test-case in a second. I don't know how to add a test for this (no less because the testcase crashes on debug builds regardless of this patch, see bug 1551192). Differential Revision: https://phabricator.services.mozilla.com/D30914
66cff9aa39bcbf1b39aaf21c6759d1c97ad2fe1b: Bug 1174452: Part 2 -- scan `nsTextNode`'s parent element for preformat in nsDocumentEncoder r=masayuki,hsivonen
Mirko Brodesser <mbrodesser@mozilla.com> - Thu, 09 May 2019 07:40:47 +0000 - rev 473754
Push 36013 by csabou@mozilla.com at Tue, 14 May 2019 16:01:08 +0000
Bug 1174452: Part 2 -- scan `nsTextNode`'s parent element for preformat in nsDocumentEncoder r=masayuki,hsivonen This takes into account `white-space: pre` style of `nsTextNode`'s parent element when formatting the selected text of the `nsTextNode` node. Differential Revision: https://phabricator.services.mozilla.com/D29159
adb37249163ee7243b14417e5771faa8564c985e: Bug 1543578 - Avoid synthetizing BrowserParent IME focus change when opening a menu. r=masayuki
Henri Sivonen <hsivonen@hsivonen.fi> - Thu, 09 May 2019 13:42:22 +0000 - rev 473348
Push 35996 by dvarga@mozilla.com at Fri, 10 May 2019 21:46:48 +0000
Bug 1543578 - Avoid synthetizing BrowserParent IME focus change when opening a menu. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D28470
395d80953041add27448419fd58a0682b2795455: Bug 1524443 - Hold mozSpellChecker when using async IPC. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 08 May 2019 13:21:55 +0000 - rev 473181
Push 35990 by nerli@mozilla.com at Thu, 09 May 2019 15:34:57 +0000
Bug 1524443 - Hold mozSpellChecker when using async IPC. r=masayuki When using `CheckAsync` IPC, we don't hold `mozSpellChecker`. It causes that `mozSpellChecker` may be destroyed during IPC call. The destructor of `mozSpellChecker` destroys actor of spellchecker IPC via `Send__delete__`. Although IPC rejects pending promises of async IPC during destroying actor, it cannot remove replay messages from parent process. So route error occurs. So we have to keep `mozSpellChecker` during async IPC. And we cannot convert attached test case to crashtest or mochitest since this depends on navigation and timing. So I don't add it. Differential Revision: https://phabricator.services.mozilla.com/D30347
ced775b2651e581ecf7d4ade35e39f1791f703d0: Bug 1544632 - Check for BrowserParent destruction before sending StopIMEStateManagement IPC message. r=masayuki
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 06 May 2019 12:00:03 +0000 - rev 472847
Push 35980 by shindli@mozilla.com at Tue, 07 May 2019 14:47:21 +0000
Bug 1544632 - Check for BrowserParent destruction before sending StopIMEStateManagement IPC message. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D30007
e3f73de9200d562c134c39e5dceaa96f67c1d012: Bug 1546493 - fixed editor/libeditor mochitests to work outside of isolated clipboard job. r=masayuki
Joel Maher <jmaher@mozilla.com> - Sun, 28 Apr 2019 00:07:39 +0000 - rev 471687
Push 35925 by dluca@mozilla.com at Sun, 28 Apr 2019 09:38:09 +0000
Bug 1546493 - fixed editor/libeditor mochitests to work outside of isolated clipboard job. r=masayuki fixed editor/libeditor mochitests to work outside of isolated clipboard job. Differential Revision: https://phabricator.services.mozilla.com/D28837
40ccb621b5d137feb6d7f82eb2b7facd8d8f837f: Bug 1440537 - Introduce an explicit flush in text_composition_querycontent.xul. r=masayuki
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 20 Apr 2019 19:15:54 +0200 - rev 471645
Push 35923 by rmaries@mozilla.com at Sat, 27 Apr 2019 21:37:34 +0000
Bug 1440537 - Introduce an explicit flush in text_composition_querycontent.xul. r=masayuki The iframe test runs on an cross-docgroup iframe, even though chrome JS can observe it in this test. This test is relying on the getBoundingClientRect() call below in order to flush the parent document layout as well, but that's going to stop happening (see the bug and patch). Differential Revision: https://phabricator.services.mozilla.com/D28302
9d3956ea78a8ddb36e0ee683e9f4ef7cc604e7c9: Bug 1545699 - Track editor stylesheets better. r=masayuki
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 19 Apr 2019 16:34:36 +0200 - rev 471295
Push 35915 by opoprus@mozilla.com at Thu, 25 Apr 2019 22:08:17 +0000
Bug 1545699 - Track editor stylesheets better. r=masayuki Replacing the whole set of user-agent stylesheets seems a bit overkill. Differential Revision: https://phabricator.services.mozilla.com/D28212
361eca0b25e50f71808a8897ed2ec413573b443a: Bug 1543363 - Use TabParent::GetWidget() for IME purposes. r=masayuki
Henri Sivonen <hsivonen@hsivonen.fi> - Wed, 24 Apr 2019 05:59:17 +0000 - rev 470596
Push 35910 by cbrindusan@mozilla.com at Wed, 24 Apr 2019 21:51:39 +0000
Bug 1543363 - Use TabParent::GetWidget() for IME purposes. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D28458
b061de30553d63447163d449f1ae78c8e8cb7827: Bug 1259660 - Moved mozilla::WidgetMosueEventBase::buttonType in MouseEvents.h to mozilla::MouseButton in EventForwards.h, and mozilla::WidgetMouseEventBase::buttonsFlag to mozilla::MouseButtonsFlag r=masayuki
Srujana Peddinti <srujana.htt121@gmail.com> - Sun, 21 Apr 2019 20:13:34 +0000 - rev 470321
Push 35898 by shindli@mozilla.com at Mon, 22 Apr 2019 09:39:21 +0000
Bug 1259660 - Moved mozilla::WidgetMosueEventBase::buttonType in MouseEvents.h to mozilla::MouseButton in EventForwards.h, and mozilla::WidgetMouseEventBase::buttonsFlag to mozilla::MouseButtonsFlag r=masayuki Moved mozilla::WidgetMosueEventBase::buttonType in MouseEvents.h to mozilla::MouseButton in EventForwards.h, and mozilla::WidgetMouseEventBase::buttonsFlag to mozilla::MouseButtonsFlag so that any referer in header files do not need to include MouseEvents.h only for referring them. Instead, they just need to include EventForwards.h. Now when MouseEvents.h is changed, the rebuild speed becomes faster. Differential Revision: https://phabricator.services.mozilla.com/D25325
8c32486b90c57e1f104ea8e6415a9f53436050ae: Bug 1259660 - Reordered the member definition in the class WidgetMouseEventBase to reduce the instance size. r=masayuki
Srujana Peddinti <srujana.htt121@gmail.com> - Sun, 21 Apr 2019 18:20:58 +0000 - rev 470320
Push 35898 by shindli@mozilla.com at Mon, 22 Apr 2019 09:39:21 +0000
Bug 1259660 - Reordered the member definition in the class WidgetMouseEventBase to reduce the instance size. r=masayuki To reduce the instance size, reordered the member definition in the class WidgetMouseEventBase, in the decreasing order of alignment size (alignof() value) to optimize the packing. Differential Revision: https://phabricator.services.mozilla.com/D25308
71f22c1e59a9e20c48bcb2713e02f8c5ef1a4f18: Bug 1259660 - Cleaned up WidgetMouseEventBase by renaming WidgetMouseEventBase::region to WidgetMouseEventBase::mRegion r=masayuki
Srujana Peddinti <srujana.htt121@gmail.com> - Sun, 21 Apr 2019 18:20:22 +0000 - rev 470319
Push 35898 by shindli@mozilla.com at Mon, 22 Apr 2019 09:39:21 +0000
Bug 1259660 - Cleaned up WidgetMouseEventBase by renaming WidgetMouseEventBase::region to WidgetMouseEventBase::mRegion r=masayuki Renamed all class member instances from WidgetMouseEventBase::region to WidgetMouseEventBase::mRegion Differential Revision: https://phabricator.services.mozilla.com/D25323
d4d915be6dcf0825ef3ceea5441a30a203f3c55e: Bug 1259660 - Cleaned up WidgetMouseEventBase by renaming WidgetMouseEventBase::inputSource to WidgetMouseEventBase::mInputSource r=masayuki
Srujana Peddinti <srujana.htt121@gmail.com> - Sun, 21 Apr 2019 18:19:43 +0000 - rev 470318
Push 35898 by shindli@mozilla.com at Mon, 22 Apr 2019 09:39:21 +0000
Bug 1259660 - Cleaned up WidgetMouseEventBase by renaming WidgetMouseEventBase::inputSource to WidgetMouseEventBase::mInputSource r=masayuki Renamed all class member instances from WidgetMouseEventBase::inputSource to WidgetMouseEventBase::mInputSource Differential Revision: https://phabricator.services.mozilla.com/D25322
d0d15e6fc468f908e3b6a36de706fb64de38bed1: Bug 1259660 - Cleaned up WidgetMouseEventBase by renaming WidgetMouseEventBase::hitCluster to WidgetMouseEventBase::mHitCluster r=masayuki
Srujana Peddinti <srujana.htt121@gmail.com> - Sun, 21 Apr 2019 18:19:20 +0000 - rev 470317
Push 35898 by shindli@mozilla.com at Mon, 22 Apr 2019 09:39:21 +0000
Bug 1259660 - Cleaned up WidgetMouseEventBase by renaming WidgetMouseEventBase::hitCluster to WidgetMouseEventBase::mHitCluster r=masayuki Renamed all class member instances from WidgetMouseEventBase::hitCluster to WidgetMouseEventBase::mHitCluster Differential Revision: https://phabricator.services.mozilla.com/D25318
cb6da071dc038e2c4cf2a7fd250acea4445a734d: Bug 1259660 - Cleaned up WidgetMouseEventBase by renaming WidgetMouseEventBase::pressure to WidgetMouseEventBase::mPressure r=masayuki
Srujana Peddinti <srujana.htt121@gmail.com> - Sun, 21 Apr 2019 18:19:18 +0000 - rev 470316
Push 35898 by shindli@mozilla.com at Mon, 22 Apr 2019 09:39:21 +0000
Bug 1259660 - Cleaned up WidgetMouseEventBase by renaming WidgetMouseEventBase::pressure to WidgetMouseEventBase::mPressure r=masayuki Renamed all class member instances from WidgetMouseEventBase::pressure to WidgetMouseEventBase::mPressure Differential Revision: https://phabricator.services.mozilla.com/D25314
912e85a1cbdf90ce1cd853462ae938e1a3fd935f: Bug 1259660 - Cleaned up WidgetMouseEventBase by renaming WidgetMouseEventBase::button to WidgetMouseEventBase::mButton. r=masayuki
Srujana Peddinti <srujana.htt121@gmail.com> - Sun, 21 Apr 2019 18:17:10 +0000 - rev 470315
Push 35898 by shindli@mozilla.com at Mon, 22 Apr 2019 09:39:21 +0000
Bug 1259660 - Cleaned up WidgetMouseEventBase by renaming WidgetMouseEventBase::button to WidgetMouseEventBase::mButton. r=masayuki Renamed all class member instances from WidgetMouseEventBase::button to WidgetMouseEventBase::mButton. Differential Revision: https://phabricator.services.mozilla.com/D25309
89c2646562d42c496b592e42948caff37aad719b: Bug 1259660 - Cleaned up WidgetMouseEventBase by renaming WidgetMouseEventBase::buttons to WidgetMouseEventBase::mButtons r=masayuki
Srujana Peddinti <srujana.htt121@gmail.com> - Sun, 21 Apr 2019 19:42:37 +0000 - rev 470314
Push 35898 by shindli@mozilla.com at Mon, 22 Apr 2019 09:39:21 +0000
Bug 1259660 - Cleaned up WidgetMouseEventBase by renaming WidgetMouseEventBase::buttons to WidgetMouseEventBase::mButtons r=masayuki Renamed all class member instances from WidgetMouseEventBase::buttons to WidgetMouseEventBase::mButtons Differential Revision: https://phabricator.services.mozilla.com/D25297
273553e141f1188c807488a12e45ab12c9ccb8a8: Bug 1379466 - Make editor listen for auxclick mouse events. r=smaug,masayuki
Ian Moody <moz-ian@perix.co.uk> - Thu, 18 Apr 2019 12:57:36 +0000 - rev 470159
Push 35888 by aiakab@mozilla.com at Fri, 19 Apr 2019 09:47:45 +0000
Bug 1379466 - Make editor listen for auxclick mouse events. r=smaug,masayuki Editable elements will no longer get click events for non-primary mouse buttons since they are being unshipped from the web in favour of auxclick events. Listen for auxclick as well so middle-click paste still works. Don't stop propagation after middle-click paste, instead ignore clicks on contenteditable elements in ClickHandlerChild. Update test_middle_click_paste.html for the new behaviour. Also remove the mNoContentDispatch overrides in HTMLInputElement and HTMLTextAreaElement that were needed for middle-pasting. Differential Revision: https://phabricator.services.mozilla.com/D26792
a34e5dcf0fe8277176fb505348fdf85a1f22e1fb: Bug 1543585 - Clean up finding words for spellchecker. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 12 Apr 2019 03:54:18 +0000 - rev 469248
Push 35859 by shindli@mozilla.com at Fri, 12 Apr 2019 15:46:45 +0000
Bug 1543585 - Clean up finding words for spellchecker. r=masayuki `mozSpellChecker::Replace` and `mozSpellChecker::NextMisspelledWord` have a loop to find word from text content. But `mozEnglishWordUtils::FindNextWord` always returns `NS_OK` and some code doesn't check error even if `nsresult` local variable is used. So I would like to clean up this loop. - `mozEnglishWordUtils::FindNextWord` should return true if word is found - We should use reference type for some `TextServicesDocument`'s methods. - Add more check for error Differential Revision: https://phabricator.services.mozilla.com/D27037
c5898e18dedf71cc3189151d053874d3235886e5: Bug 1535232 - Take account the scroll-snap-margin and scroll-snap-padding into the position where we scroll to on Element.focus() call. r=masayuki,botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 11 Apr 2019 06:22:38 +0000 - rev 468954
Push 35855 by aciure@mozilla.com at Thu, 11 Apr 2019 16:11:15 +0000
Bug 1535232 - Take account the scroll-snap-margin and scroll-snap-padding into the position where we scroll to on Element.focus() call. r=masayuki,botond We also take account those values in the case of `Find in page`. The corresponding web platform tests will be coming from this PR. https://github.com/web-platform-tests/wpt/pull/8575 Though some of them will not be passed, the failure reason is not related to this change, I will take a look when the PR gets merged into mozilla-central. Differential Revision: https://phabricator.services.mozilla.com/D25915
98305e6fa0d6111c18a458b4370e116525bf42c4: Bug 1474902 - Part 5. Add mochitest. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 05 Apr 2019 17:15:15 +0900 - rev 468141
Push 35821 by btara@mozilla.com at Fri, 05 Apr 2019 16:19:03 +0000
Bug 1474902 - Part 5. Add mochitest. r=masayuki Reviewers: masayuki Reviewed By: masayuki Bug #: 1474902 Differential Revision: https://phabricator.services.mozilla.com/D24842
f190032bbb2ebb952dc95656d7c0e9878b32a024: Bug 1474902 - Part 4. Set hint to next when next focusable element is input element that is text control. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 05 Apr 2019 17:14:47 +0900 - rev 468140
Push 35821 by btara@mozilla.com at Fri, 05 Apr 2019 16:19:03 +0000
Bug 1474902 - Part 4. Set hint to next when next focusable element is input element that is text control. r=masayuki Summary: Currently, `IMEStateManager::SetIMEState` sets hint to the following logic. - If there is no submit button into form element, set `next` - If there is submit button, set `search` or `go` - If there isn't into form element, no hint. But Chrome sets `next` hint when next focusable element is input that is text control. So even if there is submit button into form element, we should set `next` to hint when next focusable element is input that is text/number control and is in form. Also, If current focused element isn't in `<form>`, I don't still set hint. `nsFocusManager::DetermineElementToMoveFocus` may set focus to cross-process document. So `next` is set when in form and it isn't last element in form. Reviewers: masayuki Reviewed By: masayuki Subscribers: JanH Bug #: 1474902 Differential Revision: https://phabricator.services.mozilla.com/D12885
1848a0f1a98275eb37f03989fb064dc2ecea6fda: Bug 1474902 - Part 3. Move setting action hint to static function. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 05 Apr 2019 17:13:59 +0900 - rev 468139
Push 35821 by btara@mozilla.com at Fri, 05 Apr 2019 16:19:03 +0000
Bug 1474902 - Part 3. Move setting action hint to static function. r=masayuki Summary: To make setting action hint simple, I would like to move it to static function. Reviewers: masayuki Reviewed By: masayuki Bug #: 1474902 Differential Revision: https://phabricator.services.mozilla.com/D24832
e61e3556b5f8a4a18687b64d9badb72143ae0352: Bug 1540107 - Use nsEditingSession directly in nsDocShellEditorData. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 03 Apr 2019 01:56:31 +0000 - rev 467709
Push 35810 by aciure@mozilla.com at Thu, 04 Apr 2019 04:33:36 +0000
Bug 1540107 - Use nsEditingSession directly in nsDocShellEditorData. r=masayuki `nsIEditingSession.SetupEditorOnWindow` is used in `nsDocShellEditorData`. To get rid of it, I would like to use `nsEditSession` directly instead of `nsIEditingSession`. Differential Revision: https://phabricator.services.mozilla.com/D25537
6977e33ca9496ff2c8b4b9feeace89307aed07ec: Bug 1524975 addendum - Disable browser_library_middleclick.js on Mac. r=masayuki
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 01 Apr 2019 12:14:08 +0000 - rev 467080
Push 35795 by csabou@mozilla.com at Mon, 01 Apr 2019 21:54:51 +0000
Bug 1524975 addendum - Disable browser_library_middleclick.js on Mac. r=masayuki Depends on D23655 Differential Revision: https://phabricator.services.mozilla.com/D25559
c8cf9b256323da1c2f488ccef3a88369ffa3c051: Bug 1524975 - Split cross-process IME committing and blurring out of IMEStateManager::OnChangeFocusInternal(). r=masayuki
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 01 Apr 2019 07:22:54 +0000 - rev 467079
Push 35795 by csabou@mozilla.com at Mon, 01 Apr 2019 21:54:51 +0000
Bug 1524975 - Split cross-process IME committing and blurring out of IMEStateManager::OnChangeFocusInternal(). r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D23655
800d46efef526243036570465ab99000f61117d5: Bug 1540062 - Get rid of nsIPlaintextEditor.setWrapColumn. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 29 Mar 2019 09:44:36 +0000 - rev 466732
Push 35780 by opoprus@mozilla.com at Fri, 29 Mar 2019 21:53:01 +0000
Bug 1540062 - Get rid of nsIPlaintextEditor.setWrapColumn. r=masayuki No one (m-c, c-c and bluegriffon) uses nsIPlaintextEditor.setWrapColumn from script. It is used from C++ only. Differential Revision: https://phabricator.services.mozilla.com/D25363
d8dcb951f8318bbbca0f7bbc007cd6e764d3483b: Bug 1531693 - Relax the assertion for another editor handling the composition to take account of cycle collection. r=masayuki
Mark Banner <standard8@mozilla.com> - Tue, 26 Mar 2019 18:01:01 +0000 - rev 466137
Push 35761 by dvarga@mozilla.com at Tue, 26 Mar 2019 21:49:44 +0000
Bug 1531693 - Relax the assertion for another editor handling the composition to take account of cycle collection. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D24529
15a1ecb3c2541e851517ab2ec1f21cc277977359: Bug 1538966 - Use legacy keyCode and charCode for sites with known issues. r=masayuki
Dennis Schubert <dschubert@mozilla.com> - Mon, 25 Mar 2019 23:40:25 +0000 - rev 466039
Push 35758 by rgurzau@mozilla.com at Tue, 26 Mar 2019 09:51:47 +0000
Bug 1538966 - Use legacy keyCode and charCode for sites with known issues. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D24820
bf5460df1909428629cc22e1a7d697a778042548: Bug 1531693 - Relax the assertion for another editor handling the composition to take account of cycle collection. r=masayuki
Mark Banner <standard8@mozilla.com> - Sat, 23 Mar 2019 11:54:24 +0000 - rev 465882
Push 35753 by aiakab@mozilla.com at Mon, 25 Mar 2019 15:52:30 +0000
Bug 1531693 - Relax the assertion for another editor handling the composition to take account of cycle collection. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D24529
342c28406c954c7757d32cd533271e9b8556f0d5: Bug 1536453 - Use legacy keyCode and charCode for powerpoint.officeapps.live.com. r=masayuki
Dennis Schubert <dschubert@mozilla.com> - Thu, 21 Mar 2019 09:50:43 +0000 - rev 465391
Push 35738 by ccoroiu@mozilla.com at Thu, 21 Mar 2019 21:59:09 +0000
Bug 1536453 - Use legacy keyCode and charCode for powerpoint.officeapps.live.com. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D24294
2244c803a5d08806b9824af9f2f8700791034cd0: Bug 1524242 - Capture TabParent of out-of-process iframe when creating TextComposition. r=masayuki
Henri Sivonen <hsivonen@hsivonen.fi> - Tue, 19 Mar 2019 13:37:20 +0000 - rev 465021
Push 35730 by rmaries@mozilla.com at Tue, 19 Mar 2019 21:51:47 +0000
Bug 1524242 - Capture TabParent of out-of-process iframe when creating TextComposition. r=masayuki Depends on D23641 Differential Revision: https://phabricator.services.mozilla.com/D20981