searching for reviewer(mak)
7d86a83672c5a74ae17f5f9141babb1c25293a89: Bug 1672680 - Properly handle non-ASCII spaces in search alias and restriction token searches. r=mak
Drew Willcoxon <adw@mozilla.com> - Fri, 23 Oct 2020 13:49:20 +0000 - rev 554253
Push 37890 by ccoroiu@mozilla.com at Sat, 24 Oct 2020 09:41:39 +0000
Bug 1672680 - Properly handle non-ASCII spaces in search alias and restriction token searches. r=mak This fixes all the problems created by bug 1658964 and modifies existing tests so we check a variety of spaces. Differential Revision: https://phabricator.services.mozilla.com/D94555
5edc54d87ce82ee7866c30fd08225f21025ed755: Bug 1672643 - Do not show form history (search suggestions from history) at all when browser.urlbar.maxHistoricalSearchSuggestions == 0. r=mak
Drew Willcoxon <adw@mozilla.com> - Thu, 22 Oct 2020 22:25:12 +0000 - rev 554129
Push 37888 by smolnar@mozilla.com at Fri, 23 Oct 2020 09:46:15 +0000
Bug 1672643 - Do not show form history (search suggestions from history) at all when browser.urlbar.maxHistoricalSearchSuggestions == 0. r=mak Differential Revision: https://phabricator.services.mozilla.com/D94504
81801ba1e2cf64a98d7e632d444310e92b08700b: Bug 1670356 - use case insensitive comparisons when checking Windows executables, r=mak
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 21 Oct 2020 11:24:41 +0000 - rev 553853
Push 37883 by dluca@mozilla.com at Wed, 21 Oct 2020 21:30:07 +0000
Bug 1670356 - use case insensitive comparisons when checking Windows executables, r=mak Differential Revision: https://phabricator.services.mozilla.com/D93852
2769479fb1a29a2826023045bbf531c63aa0e4ea: Bug 1671045 - Fix intermittent in browser_searchMode_sessionStore.js by requesting a longer timeout and disabling on Mac debug. r=mak
Drew Willcoxon <adw@mozilla.com> - Tue, 20 Oct 2020 21:06:11 +0000 - rev 553705
Push 37880 by rmaries@mozilla.com at Wed, 21 Oct 2020 03:56:30 +0000
Bug 1671045 - Fix intermittent in browser_searchMode_sessionStore.js by requesting a longer timeout and disabling on Mac debug. r=mak This test times out on macOS 10.14 opt and debug. Logs show that the test finishes properly but it exceeds the timeout threshold, so it appears that it just takes too long. Increasing the timeout threshold fixes the problem on opt, but it reveals another problem on debug where the watchdog process kills the main process because its shutdown lasts too long. This happens during step 3 of test-verify, which is "Run each test 10 times in one browser, in chaos mode." Around the time that the crash happens, logs show that there are "2047 DOMWINDOW created and 2037 destroyed log strings." The test opens, closes, and reopens many windows -- with chaos mode on top of that -- so it's possible that debug window instrumentation or just the debug nature of the build itself, plus slow machines, causes all the window opening and closing to perform very poorly and take a long time. This patch increases the timeout, which fixes opt, and disables the test entirely on debug -- and to reiterate, it's Mac only. Maybe the test could open and close tabs instead of windows in order to test session store, but I'm not sure it's worth rewriting. Here's a successful try run with an earlier version of this patch that did not disable the test on debug, but it shows that opt is green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ab33a9225b9edf0cb8a95d556f9b76c7fc69470 And here's a run without the patch that shows opt is always orange: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1e02bfc26ecb67f503cb24a180536e8c220226d5 Differential Revision: https://phabricator.services.mozilla.com/D94069
a3815d601038dc3b8103224a5da4d6fa76aea511: Bug 1667787 - fix saving webp images served with jpeg extensions without content-disposition information, r=mak
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 20 Oct 2020 20:35:26 +0000 - rev 553698
Push 37880 by rmaries@mozilla.com at Wed, 21 Oct 2020 03:56:30 +0000
Bug 1667787 - fix saving webp images served with jpeg extensions without content-disposition information, r=mak This changes two bits of Firefox that, together with the mime service, end up very confused over webp + jpeg. 1) it changes contentAreaUtils.js' getDefaultExtension that if it gets an image mimetype as the content type, it should ignore the URL. It doesn't have full channel info so it can't really do better anyway. This fixes the context menu's "save image as..." case. 2) it changes the external helper app service to do a few things slightly differently: a. If we're told not to get an extension out of a URL, really don't. Don't just get the filename and then get it from there anyway... b. If we've got a suggested filename, and a primary extension for the mimetype, and the extension on the file is not one of the known extensions for the mimetype, replace it with the primary extension. This fixes the link case. It also adds tests for both of these mechanisms as well as "save image as." Differential Revision: https://phabricator.services.mozilla.com/D92306
ff2ad4b3e863195075076107dc008bf248da9a91: Bug 1667787 - fix saving webp images served with jpeg extensions without content-disposition information, r=mak
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 20 Oct 2020 12:05:10 +0000 - rev 553646
Push 37880 by rmaries@mozilla.com at Wed, 21 Oct 2020 03:56:30 +0000
Bug 1667787 - fix saving webp images served with jpeg extensions without content-disposition information, r=mak This changes two bits of Firefox that, together with the mime service, end up very confused over webp + jpeg. 1) it changes contentAreaUtils.js' getDefaultExtension that if it gets an image mimetype as the content type, it should ignore the URL. It doesn't have full channel info so it can't really do better anyway. This fixes the context menu's "save image as..." case. 2) it changes the external helper app service to do a few things slightly differently: a. If we're told not to get an extension out of a URL, really don't. Don't just get the filename and then get it from there anyway... b. If we've got a suggested filename, and a primary extension for the mimetype, and the extension on the file is not one of the known extensions for the mimetype, replace it with the primary extension. This fixes the link case. It also adds tests for both of these mechanisms as well as "save image as." Differential Revision: https://phabricator.services.mozilla.com/D92306
6c5473b9d35095bda629a2b58f529c3e1f37c4a2: Bug 1671803 - Add localized names for Baidu and Yandex to WEB_ENGINE_NAMES. r=mak
Harry Twyford <htwyford@mozilla.com> - Mon, 19 Oct 2020 18:33:51 +0000 - rev 553456
Push 37878 by smolnar@mozilla.com at Tue, 20 Oct 2020 09:40:32 +0000
Bug 1671803 - Add localized names for Baidu and Yandex to WEB_ENGINE_NAMES. r=mak Differential Revision: https://phabricator.services.mozilla.com/D94012
19f174844357ed8d5ae122082e929b0ebc0b9afe: Bug 1667787 - fix saving webp images served with jpeg extensions without content-disposition information, r=mak
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 19 Oct 2020 16:14:13 +0000 - rev 553454
Push 37878 by smolnar@mozilla.com at Tue, 20 Oct 2020 09:40:32 +0000
Bug 1667787 - fix saving webp images served with jpeg extensions without content-disposition information, r=mak This changes two bits of Firefox that, together with the mime service, end up very confused over webp + jpeg. 1) it changes contentAreaUtils.js' getDefaultExtension that if it gets an image mimetype as the content type, it should ignore the URL. It doesn't have full channel info so it can't really do better anyway. This fixes the context menu's "save image as..." case. 2) it changes the external helper app service to do a few things slightly differently: a. If we're told not to get an extension out of a URL, really don't. Don't just get the filename and then get it from there anyway... b. If we've got a suggested filename, and a primary extension for the mimetype, and the extension on the file is not one of the known extensions for the mimetype, replace it with the primary extension. This fixes the link case. It also adds tests for both of these mechanisms as well as "save image as." Differential Revision: https://phabricator.services.mozilla.com/D92306
cc5b59f193168024c08ba046f95bef975d8572a2: Bug 1597084 - Set the image attribute on the bookmark-items in the toolbar when creating them to prevent flickering of the default favicon. r=mak
Jared Wein <jwein@mozilla.com> - Mon, 19 Oct 2020 16:52:32 +0000 - rev 553435
Push 37877 by nbeleuzu@mozilla.com at Mon, 19 Oct 2020 21:38:35 +0000
Bug 1597084 - Set the image attribute on the bookmark-items in the toolbar when creating them to prevent flickering of the default favicon. r=mak Differential Revision: https://phabricator.services.mozilla.com/D93301
73e461c6ee8d400dcd1ba402b15b82893e69f7b4: Bug 1671803 - Add localized names for Baidu and Yandex to WEB_ENGINE_NAMES. r=mak
Harry Twyford <htwyford@mozilla.com> - Mon, 19 Oct 2020 15:05:09 +0000 - rev 553425
Push 37877 by nbeleuzu@mozilla.com at Mon, 19 Oct 2020 21:38:35 +0000
Bug 1671803 - Add localized names for Baidu and Yandex to WEB_ENGINE_NAMES. r=mak Differential Revision: https://phabricator.services.mozilla.com/D94012
08932b37efb3b9d405183d42093262729d8cb435: Bug 1671404 - Add Provider Name to the urlbar engagement telemetry. r=mak
Mark Banner <standard8@mozilla.com> - Fri, 16 Oct 2020 14:39:50 +0000 - rev 553278
Push 37868 by dluca@mozilla.com at Fri, 16 Oct 2020 21:45:37 +0000
Bug 1671404 - Add Provider Name to the urlbar engagement telemetry. r=mak Differential Revision: https://phabricator.services.mozilla.com/D93660
4595a3aa2d7a817a4a95d717c2b235d4c5767564: Bug 1670944 - Allow tabbing past tab-to-search results after focusing the Urlbar with the keyboard. r=mak
Harry Twyford <htwyford@mozilla.com> - Fri, 16 Oct 2020 13:53:03 +0000 - rev 553276
Push 37868 by dluca@mozilla.com at Fri, 16 Oct 2020 21:45:37 +0000
Bug 1670944 - Allow tabbing past tab-to-search results after focusing the Urlbar with the keyboard. r=mak Differential Revision: https://phabricator.services.mozilla.com/D93601
fa95a02b2c90cf90108326785de43f8970ed647b: Bug 1671404 - Add Provider Name to the urlbar engagement telemetry. r=mak
Mark Banner <standard8@mozilla.com> - Fri, 16 Oct 2020 11:17:07 +0000 - rev 553260
Push 37868 by dluca@mozilla.com at Fri, 16 Oct 2020 21:45:37 +0000
Bug 1671404 - Add Provider Name to the urlbar engagement telemetry. r=mak Differential Revision: https://phabricator.services.mozilla.com/D93660
1a7978303f2281bea2315ab74a00ff8adb544b9f: Bug 1647929 - Announce tab-to-search results to screen readers. r=Jamie,mak,fluent-reviewers,flod
Harry Twyford <htwyford@mozilla.com> - Wed, 14 Oct 2020 17:22:33 +0000 - rev 553028
Push 37862 by apavel@mozilla.com at Thu, 15 Oct 2020 03:57:02 +0000
Bug 1647929 - Announce tab-to-search results to screen readers. r=Jamie,mak,fluent-reviewers,flod This is a pretty simple implementation of the approach discussed in the bug. When a tab-to-search result is shown, we announce it to screen readers. We keep track of which engines are announced to be sure we don't keep announcing the same engine as the user types. This approach is maybe slightly crude, but I didn't find a working elegant approach. One approach I considered is checking for tab-to-search results in the loop in UrlbarView._updateResults. After the loop is finished, if we found a tab-to-search result, we go back and change the aria-label on the action text of the prior result to something like "Visit, or press Tab to search with { $engine }. This didn't work because we don't read action text for the heuristic result as the user types. This is presumbably to avoid disrupting the user as they type. This is what my patch does regardless, however... Since Jamie was skeptical about whether we should announce this at all, I put this behaviour behind a default-true pref, browser.urlbar.tabToSearch.accessibility.announceResults. Differential Revision: https://phabricator.services.mozilla.com/D93451
ff449df608ecf9f3b2c0e2d2c393f949c9713f19: Bug 1670932 - Don't restore urlbar search mode due to remoteness change. r=mak
Drew Willcoxon <adw@mozilla.com> - Wed, 14 Oct 2020 13:23:31 +0000 - rev 553021
Push 37862 by apavel@mozilla.com at Thu, 15 Oct 2020 03:57:02 +0000
Bug 1670932 - Don't restore urlbar search mode due to remoteness change. r=mak When navigating to a new URL that requires a remoteness change, session store restores the tab after the change. The restore races the `gURLBar.setURI` call that happens due to the location change. If the restore happens after the `setURI` call, then the search mode is "restored" even though a new page was loaded. The session store code surrounding the chunk that I modified in bug 1655486 checks for a remoteness change before trying to restore `userTypedValue`. If the restore is due to a remoteness change, then it doesn't restore `userTypedValue`. We just need to do the same for search mode. Also, I think we should be using `TabStateCache` here, not `TabState.collect`. `TabStateCache` is updated in `restoreTab` and is available throughout the restore process. `TabState.collect` on the other hand is a live view of the given tab, so if search mode happens to be active when `collect` is called, then the returned tab state will have `searchMode` defined, which is not what we want here. But I'm not sure why the surrounding code here uses `TabState.collect` instead of `TabStateCache` in order to restore `userTypedValue`. It seems like an error to me, but I might be missing something. Due to the racey nature of this bug, writing a test isn't so easy, so this patch doesn't have one. It will be obvious through manual testing if this regresses. Differential Revision: https://phabricator.services.mozilla.com/D93455
61dae93abcb1c9cac902ccea55f70183d826c6de: Bug 1665294: Avoid capturing click event twice from search mode close button. r=mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Wed, 14 Oct 2020 12:18:31 +0000 - rev 552956
Push 37860 by ccoroiu@mozilla.com at Wed, 14 Oct 2020 16:38:28 +0000
Bug 1665294: Avoid capturing click event twice from search mode close button. r=mak Differential Revision: https://phabricator.services.mozilla.com/D93466
582e4890127f023dca0e3b932f2f2195f35413dc: Bug 1665115 - Update userTypedValue when entering search mode so that search strings are properly restored. r=mak
Drew Willcoxon <adw@mozilla.com> - Tue, 13 Oct 2020 14:47:52 +0000 - rev 552843
Push 37859 by smolnar@mozilla.com at Wed, 14 Oct 2020 09:52:12 +0000
Bug 1665115 - Update userTypedValue when entering search mode so that search strings are properly restored. r=mak Differential Revision: https://phabricator.services.mozilla.com/D93289
fc8c5c66f08174e819906d68852a6bc48275415e: Bug 1667787 - fix saving webp images served with jpeg extensions without content-disposition information, r=mak
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 13 Oct 2020 14:00:41 +0000 - rev 552819
Push 37858 by btara@mozilla.com at Tue, 13 Oct 2020 21:43:51 +0000
Bug 1667787 - fix saving webp images served with jpeg extensions without content-disposition information, r=mak This changes two bits of Firefox that, together with the mime service, end up very confused over webp + jpeg. 1) it changes contentAreaUtils.js' getDefaultExtension that if it gets an image mimetype as the content type, it should ignore the URL. It doesn't have full channel info so it can't really do better anyway. This fixes the context menu's "save image as..." case. 2) it changes the external helper app service to do a few things slightly differently: a. If we're told not to get an extension out of a URL, really don't. Don't just get the filename and then get it from there anyway... b. If we've got a suggested filename, and a primary extension for the mimetype, and the extension on the file is not one of the known extensions for the mimetype, replace it with the primary extension. This fixes the link case. It also adds tests for both of these mechanisms as well as "save image as." Differential Revision: https://phabricator.services.mozilla.com/D92306
9b3560927e84c06331ce8671c0d5e03fece55e8e: Bug 1655486 - Support search mode across sessions. r=mak
Drew Willcoxon <adw@mozilla.com> - Mon, 12 Oct 2020 03:34:59 +0000 - rev 552650
Push 37853 by apavel@mozilla.com at Mon, 12 Oct 2020 09:36:05 +0000
Bug 1655486 - Support search mode across sessions. r=mak * Always update the `_searchModesByBrowser` map when entering/exiting search mode, not only for non-selected browsers, so that search mode can be saved and restored properly per tab. * Rename `setSearchMode` to `_updateSearchModeUI` and make it only update the UI. * Add a new `setSearchMode` method that takes a browser and updates the map. * Add `getSearchMode` so that SessionStore can get the search mode for a given browser. * Add a `searchMode` getter and setter for convenience. They call `getSearchMode` and `setSearchMode` with the selected browser. Differential Revision: https://phabricator.services.mozilla.com/D91910
c52fe184a543b9430e18d5433d56c58cb04d9ebb: Bug 1669477 - Simplify resultDomain handling. Remove from OpenSearch as it isn't an OpenSearch requirement. r=mak
Mark Banner <standard8@mozilla.com> - Fri, 09 Oct 2020 11:27:31 +0000 - rev 552367
Push 37849 by apavel@mozilla.com at Fri, 09 Oct 2020 21:45:45 +0000
Bug 1669477 - Simplify resultDomain handling. Remove from OpenSearch as it isn't an OpenSearch requirement. r=mak Differential Revision: https://phabricator.services.mozilla.com/D92611
5be393d34bbdcbb4a45d3000a32a6eb3f3d51fef: Bug 1668389 - Only set #urlbar[open] if we are sure there will be either results or one-offs. r=mak
Harry Twyford <htwyford@mozilla.com> - Wed, 07 Oct 2020 15:02:16 +0000 - rev 551929
Push 37843 by abutkovits@mozilla.com at Thu, 08 Oct 2020 09:49:50 +0000
Bug 1668389 - Only set #urlbar[open] if we are sure there will be either results or one-offs. r=mak This was more difficult to solve than I expected. The main issue is that the `[open]` attribute on `#urlbar` wasn't accurate when the view was "open" but there were no results or one-offs, so it was in fact closed. This broke a few style rules. This bug can also be reached when the user has no engines and clears the search string while in search mode. This includes pressing Accel+K when typing a search string while not in search mode. The relationship between the UrlbarView and the one-offs is complex and depends on a lot of listeners and async calls made in synchronous contexts. Furthermore, most of the UrlbarView open/close code is synchronous, but checking the number of engines (to determine if the one-offs will open) is an async operation. These factors make it difficult for the view to discern any state about the one-offs and plan accordingly. First I tried adding a [oneoff] attribute to .urlbarView, set asynchronously when the one-offs are built. Then I changed CSS rules to check ``` .urlbarView:not([noresults]), .urlbarView[oneoffs] ``` instead of just `#urlbar[open]`. This approach would've required changing a bunch of CSS from the simple `#urlbar[open]` to the more complicated CSS above, which was not good for code readability. Also it would keep `[open]` in a weird useless state where it couldn't really be trusted. This would've caused other styling problems. I settled on adding a `.then` call around the affected UrlbarView opening. The view opens only if we are sure that we will have either results or one-offs, so we can once again trust the `[open]` parameter. This approach has its drawbacks. Mainly, it's a more JavaScript-heavy solution so it's possibly slow. Thankfully, it's something that can be easily cached. Differential Revision: https://phabricator.services.mozilla.com/D92526
def86333dcc51c3cbb752d7e4b6f731b9564748e: Bug 1669271: Set browser.urlbar.update2.oneOffsRefresh pref to avoid failing tests for besides nightly. r=mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Tue, 06 Oct 2020 08:10:30 +0000 - rev 551660
Push 37839 by btara@mozilla.com at Tue, 06 Oct 2020 16:17:06 +0000
Bug 1669271: Set browser.urlbar.update2.oneOffsRefresh pref to avoid failing tests for besides nightly. r=mak Differential Revision: https://phabricator.services.mozilla.com/D92513
82b0f23e0785d6adf8b34d51deffd178e2d94d8e: Bug 1668212: Unselect one-off button when exiting search mode. r=mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Mon, 05 Oct 2020 21:53:32 +0000 - rev 551621
Push 37838 by cbrindusan@mozilla.com at Tue, 06 Oct 2020 04:10:51 +0000
Bug 1668212: Unselect one-off button when exiting search mode. r=mak Depends on D92022 Differential Revision: https://phabricator.services.mozilla.com/D92023
5e046f6d0e25660878d8f65952acfc29601c5421: Bug 1668430: Add a test about search mode when typing an alias after selecting one-off button. r=mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Sun, 04 Oct 2020 21:42:43 +0000 - rev 551433
Push 37834 by rmaries@mozilla.com at Mon, 05 Oct 2020 03:57:15 +0000
Bug 1668430: Add a test about search mode when typing an alias after selecting one-off button. r=mak Depends on D91393 Differential Revision: https://phabricator.services.mozilla.com/D92022
10d626f2709c82ec6dc1f05f52adaf1f57d6dace: Bug 1644972 - Restrict browser.urlbar.disableExtendForTests to tests and remove it from tests that don't need it. r=mak
Dão Gottwald <dao@mozilla.com> - Fri, 02 Oct 2020 11:56:16 +0000 - rev 551256
Push 37830 by nbeleuzu@mozilla.com at Sat, 03 Oct 2020 10:23:35 +0000
Bug 1644972 - Restrict browser.urlbar.disableExtendForTests to tests and remove it from tests that don't need it. r=mak Differential Revision: https://phabricator.services.mozilla.com/D92154
7bc5f7b549126cc35cc68d9ecb65c43b402f8b85: Bug 1665908: Remove one-off button selection when entering search mode. r=mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Thu, 01 Oct 2020 08:40:03 +0000 - rev 551025
Push 37825 by abutkovits@mozilla.com at Fri, 02 Oct 2020 04:10:47 +0000
Bug 1665908: Remove one-off button selection when entering search mode. r=mak Differential Revision: https://phabricator.services.mozilla.com/D91393
a45e38af7380ec85ae9696ddcaaaf8b33e8e2594: Bug 1638633: Introduce loadSearchFromExtension to use same mechanism as loadSearchFrom*. r=mak,robwu
Daisuke Akatsuka <daisuke@birchill.co.jp> - Thu, 01 Oct 2020 00:12:15 +0000 - rev 550999
Push 37824 by csabou@mozilla.com at Thu, 01 Oct 2020 09:40:20 +0000
Bug 1638633: Introduce loadSearchFromExtension to use same mechanism as loadSearchFrom*. r=mak,robwu Differential Revision: https://phabricator.services.mozilla.com/D91560
76f2bb2215b501a4414a090b07c5821647ddd5d1: Bug 1658229 - Exclude moz-extension:// urls from being saved in history. r=mak
Mark Banner <standard8@mozilla.com> - Wed, 30 Sep 2020 09:27:58 +0000 - rev 550879
Push 37823 by cbrindusan@mozilla.com at Wed, 30 Sep 2020 21:45:29 +0000
Bug 1658229 - Exclude moz-extension:// urls from being saved in history. r=mak Differential Revision: https://phabricator.services.mozilla.com/D91767
9d511473dace227eddcd9b019f607d0087209406: Bug 1663984: Add a test for the interaction with the ESC key on browsing page. r=mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Fri, 25 Sep 2020 00:35:43 +0000 - rev 550280
Push 37811 by malexandru@mozilla.com at Fri, 25 Sep 2020 15:57:49 +0000
Bug 1663984: Add a test for the interaction with the ESC key on browsing page. r=mak Depends on D91099 Differential Revision: https://phabricator.services.mozilla.com/D91232
755c5f1200f4fe04374ecf41b998ba773edcee87: Bug 1663984: Show browsing url if the page is not initial page when reverting from search mode. r=mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Fri, 25 Sep 2020 07:11:52 +0000 - rev 550279
Push 37811 by malexandru@mozilla.com at Fri, 25 Sep 2020 15:57:49 +0000
Bug 1663984: Show browsing url if the page is not initial page when reverting from search mode. r=mak Differential Revision: https://phabricator.services.mozilla.com/D91099
a5311124f88e7ed5a46d85f5922bda8ea6932d24: Bug 1667031 - URLBarInput's nsIObserver implementation should QI its 'subject' argument before using it, r=mak
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 24 Sep 2020 09:53:43 +0000 - rev 550118
Push 37808 by apavel@mozilla.com at Thu, 24 Sep 2020 21:53:48 +0000
Bug 1667031 - URLBarInput's nsIObserver implementation should QI its 'subject' argument before using it, r=mak Differential Revision: https://phabricator.services.mozilla.com/D91249
5b2d0635405cf3a28280d43e187dfecdf5606778: Bug 1535950 - On Linux the download URI is saved to GVFS/GIO metadata even in private browsing. r=mak
M. Sirringhaus <msirringhaus@suse.de> - Tue, 22 Sep 2020 12:26:43 +0000 - rev 549601
Push 37805 by abutkovits@mozilla.com at Wed, 23 Sep 2020 09:59:09 +0000
Bug 1535950 - On Linux the download URI is saved to GVFS/GIO metadata even in private browsing. r=mak Differential Revision: https://phabricator.services.mozilla.com/D90844
c39d8dfb3cd1cb9ceb0ba7fcef6ef2d4f77d9ee5: Bug 1666087 - Fix beta failure in browser_searchMode_preview.js. r=mak
Harry Twyford <htwyford@mozilla.com> - Mon, 21 Sep 2020 14:51:28 +0000 - rev 549468
Push 37800 by dluca@mozilla.com at Mon, 21 Sep 2020 21:36:12 +0000
Bug 1666087 - Fix beta failure in browser_searchMode_preview.js. r=mak Differential Revision: https://phabricator.services.mozilla.com/D90876
763a0359244d88b37c9e3ccab354e3849563003b: Bug 1659204 - Don't show a heuristic in local search modes except for autofill. r=mak,harry
Drew Willcoxon <adw@mozilla.com> - Sat, 19 Sep 2020 00:34:26 +0000 - rev 549355
Push 37795 by ccoroiu@mozilla.com at Sat, 19 Sep 2020 09:34:53 +0000
Bug 1659204 - Don't show a heuristic in local search modes except for autofill. r=mak,harry Differential Revision: https://phabricator.services.mozilla.com/D90671
8c8cb264f283b9ca9e124b06d0283dde1e760db3: Bug 1659204 - Don't show a heuristic in local search modes except for autofill. r=mak,harry
Drew Willcoxon <adw@mozilla.com> - Fri, 18 Sep 2020 21:37:28 +0000 - rev 549349
Push 37795 by ccoroiu@mozilla.com at Sat, 19 Sep 2020 09:34:53 +0000
Bug 1659204 - Don't show a heuristic in local search modes except for autofill. r=mak,harry Differential Revision: https://phabricator.services.mozilla.com/D90671
708170892bc8c587d9d6c322da53be5fd01f26d8: Bug 1664516 - Update frecency top sites from default top sites with %YYYYMMDDHH% to use the current datetime. r=mak
Dão Gottwald <dao@mozilla.com> - Thu, 17 Sep 2020 09:50:03 +0000 - rev 549137
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1664516 - Update frecency top sites from default top sites with %YYYYMMDDHH% to use the current datetime. r=mak Differential Revision: https://phabricator.services.mozilla.com/D90494
75f7048e9d0af7f1ef5ff34fc6a807ecfb0fbd86: Bug 1665301 - Disable separate private default search engine in Nightly. r=mak
Mark Banner <standard8@mozilla.com> - Wed, 16 Sep 2020 15:41:13 +0000 - rev 548972
Push 37790 by btara@mozilla.com at Thu, 17 Sep 2020 10:09:40 +0000
Bug 1665301 - Disable separate private default search engine in Nightly. r=mak Differential Revision: https://phabricator.services.mozilla.com/D90439
05007ff436a531b1992e8938e7c4f41922e52f53: Bug 1375244 - Remove sync KeywordToURI and related IPC messages as they are no longer required. r=Gijs,mak,mccr8
Mark Banner <standard8@mozilla.com> - Fri, 11 Sep 2020 07:15:21 +0000 - rev 548274
Push 37776 by btara@mozilla.com at Fri, 11 Sep 2020 15:10:42 +0000
Bug 1375244 - Remove sync KeywordToURI and related IPC messages as they are no longer required. r=Gijs,mak,mccr8 Differential Revision: https://phabricator.services.mozilla.com/D89486
6ccaf90187247f6c615f512e7eeb2686e310c79e: Bug 1658993 - Disable the context menu for local one-off search buttons. r=mak
Drew Willcoxon <adw@mozilla.com> - Tue, 01 Sep 2020 20:01:26 +0000 - rev 547319
Push 37748 by apavel@mozilla.com at Wed, 02 Sep 2020 03:31:14 +0000
Bug 1658993 - Disable the context menu for local one-off search buttons. r=mak Differential Revision: https://phabricator.services.mozilla.com/D88948
a819df5c171760b1bf2baf6c9665ad319bd614d5: Bug 1661811 - Move obsolete/deprecated sections in telemetry.rst to make it less misleading. r=mak
Drew Willcoxon <adw@mozilla.com> - Tue, 01 Sep 2020 19:44:36 +0000 - rev 547315
Push 37748 by apavel@mozilla.com at Wed, 02 Sep 2020 03:31:14 +0000
Bug 1661811 - Move obsolete/deprecated sections in telemetry.rst to make it less misleading. r=mak This adds an Obsolete section to the doc. I overused the word "obsolete" in order to make it hard for your eyes to skip over just an "Obsolete" section heading as you're skimming this page for info. Also, `SELECTED_RESULT_TYPES` by itself wasn't clear, so I changed it to `UrlbarUtils.SELECTED_RESULT_TYPES` and added a link that shouldn't be broken by future changes. Differential Revision: https://phabricator.services.mozilla.com/D88675
4a3d16542cb169c272c300c51ab40f4557e44064: Bug 1660530 - Transition the docshell URIFixup tests to work with the modern search engine configuration. r=mak
Mark Banner <standard8@mozilla.com> - Wed, 26 Aug 2020 14:19:41 +0000 - rev 546282
Push 37733 by nbeleuzu@mozilla.com at Wed, 26 Aug 2020 21:41:21 +0000
Bug 1660530 - Transition the docshell URIFixup tests to work with the modern search engine configuration. r=mak Differential Revision: https://phabricator.services.mozilla.com/D87894
bb37e118e155d92c74de9d820655ebb13d9f4965: Bug 1659397 - Upgrade to SQLite 3.33.0. r=mak
Ryan VanderMeulen <ryanvm@gmail.com> - Tue, 25 Aug 2020 15:39:54 +0000 - rev 546139
Push 37731 by apavel@mozilla.com at Wed, 26 Aug 2020 03:24:37 +0000
Bug 1659397 - Upgrade to SQLite 3.33.0. r=mak Differential Revision: https://phabricator.services.mozilla.com/D88055
996954d1f980f0380206f56705f1e69651288a4e: Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 11 Aug 2020 20:55:33 +0000 - rev 544302
Push 37692 by cbrindusan@mozilla.com at Wed, 12 Aug 2020 03:44:18 +0000
Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak Includes baddataDB.sqlite which is a copy of goodDB.sqlite but with what appears to be the row count inflated beyond the end of the file. This causes loading the database to succeed but queries to fail. This increments a scalar for every database open and for every database query where a query is the full execution of a statement from start to completion. If a statement is re-used then the scalar will be incremented once for each use. Differential Revision: https://phabricator.services.mozilla.com/D73938
af815754d58aec3cc9d25edd2cbab28e7131c685: Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak
Dave Townsend <dtownsend@oxymoronical.com> - Mon, 10 Aug 2020 20:09:27 +0000 - rev 544150
Push 37688 by apavel@mozilla.com at Tue, 11 Aug 2020 03:16:35 +0000
Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak Includes baddataDB.sqlite which is a copy of goodDB.sqlite but with what appears to be the row count inflated beyond the end of the file. This causes loading the database to succeed but queries to fail. This increments a scalar for every database open and for every database query where a query is the full execution of a statement from start to completion. If a statement is re-used then the scalar will be incremented once for each use. Differential Revision: https://phabricator.services.mozilla.com/D73938
840272088ab1ee282b937ee38d9dc9f95b4d54b1: Bug 1655457 - improve case handling when normalizing file names in contentAreaUtils.js, r=mak
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 06 Aug 2020 19:51:02 +0000 - rev 543751
Push 37681 by abutkovits@mozilla.com at Fri, 07 Aug 2020 21:36:18 +0000
Bug 1655457 - improve case handling when normalizing file names in contentAreaUtils.js, r=mak Depends on D85927 Differential Revision: https://phabricator.services.mozilla.com/D86041
d00bcc7e317ad8e92be69514f80c83c4e8518921: Bug 1655457 - always lowercase file extensions used in the Windows external helper app code, r=mak
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 06 Aug 2020 20:09:55 +0000 - rev 543750
Push 37681 by abutkovits@mozilla.com at Fri, 07 Aug 2020 21:36:18 +0000
Bug 1655457 - always lowercase file extensions used in the Windows external helper app code, r=mak Differential Revision: https://phabricator.services.mozilla.com/D85927
170550855ee2faa4d38a74a2eae00530e70b7c00: Bug 1553945 - Added a keyboard shortcut to show history on macOS r=mak,fluent-reviewers,flod
Asif Youssuff <yoasif@gmail.com> - Thu, 30 Jul 2020 08:54:56 +0000 - rev 542844
Push 37657 by nerli@mozilla.com at Sat, 01 Aug 2020 09:48:10 +0000
Bug 1553945 - Added a keyboard shortcut to show history on macOS r=mak,fluent-reviewers,flod Differential Revision: https://phabricator.services.mozilla.com/D84897
396895ff559dc2fe6f1ab5cfbca5afc5578abe76: Bug 1656007 - Move URLBAR_SELECTED_RESULT_TYPES to UrlbarUtils since it is not used in BrowserUsageTelemetry. r=mak
Mark Banner <standard8@mozilla.com> - Thu, 30 Jul 2020 14:27:50 +0000 - rev 542618
Push 37653 by btara@mozilla.com at Thu, 30 Jul 2020 21:54:52 +0000
Bug 1656007 - Move URLBAR_SELECTED_RESULT_TYPES to UrlbarUtils since it is not used in BrowserUsageTelemetry. r=mak Differential Revision: https://phabricator.services.mozilla.com/D85302
f88987c08d985aea13406a3234ac5feb5585f856: Bug 1656007 - Move URLBAR_SELECTED_RESULT_METHODS to UrlbarTestUtils as it is only used in tests. r=mak
Mark Banner <standard8@mozilla.com> - Thu, 30 Jul 2020 15:04:20 +0000 - rev 542617
Push 37653 by btara@mozilla.com at Thu, 30 Jul 2020 21:54:52 +0000
Bug 1656007 - Move URLBAR_SELECTED_RESULT_METHODS to UrlbarTestUtils as it is only used in tests. r=mak Differential Revision: https://phabricator.services.mozilla.com/D85301
188fed33437c561c87b85ec7f46956deaf40f6a9: Bug 1655034 - Ensure UnifiedComplete waits for browser.urlbar.delay in most cases. r=mak
Harry Twyford <htwyford@mozilla.com> - Tue, 28 Jul 2020 16:28:36 +0000 - rev 542367
Push 37647 by csabou@mozilla.com at Tue, 28 Jul 2020 21:32:49 +0000
Bug 1655034 - Ensure UnifiedComplete waits for browser.urlbar.delay in most cases. r=mak Differential Revision: https://phabricator.services.mozilla.com/D85158