searching for reviewer(mak)
1a604880aa8ea667797876af0e59fad78ecb9b97: Bug 1702806 - Fix issues with intermittient failures in places tests and due to the way the dialogs interact with PlacesTransactions. r=mak
Mark Banner <standard8@mozilla.com> - Mon, 04 Jul 2022 14:32:50 +0000 - rev 622930
Push 39935 by ctuns@mozilla.com at Mon, 04 Jul 2022 21:42:52 +0000
Bug 1702806 - Fix issues with intermittient failures in places tests and due to the way the dialogs interact with PlacesTransactions. r=mak There's are a couple of issues that this fixes, they are both based around the issue that because tests run fast they tend to not give time for batches to complete. This can lead to incomplete batches between tests, which tends to mess up subsequent tests or cause hangs. In normal usage this is not an issue, as the user is not able to go as fast as tests. The first issue is that in PlacesUIUtils.showBookmarkDialog we may resolve the dialog deferred promise before the transaction batch has had change to complete. The second issue is that the star UI runs batches, and that again we do not wait for the batch to be complete. Working an await into the star UI/tests is more difficult due to the way that code is structured. With a planned switch to non-instant apply, it also feels too complicated to be worth it at this time. As a workaround for this issue, we ensure that the transaction queue is cleared between each test run via a registerCleanupFunction in the head.js file. Differential Revision: https://phabricator.services.mozilla.com/D147535
f3f245c5226c94af5429451a8b8b06a336e2ffdc: Bug 1704922 - Fix intermittent failure in browser_check_correct_controllers.js. r=mak
Mark Banner <standard8@mozilla.com> - Thu, 30 Jun 2022 22:37:21 +0000 - rev 622809
Push 39921 by smolnar@mozilla.com at Fri, 01 Jul 2022 04:18:35 +0000
Bug 1704922 - Fix intermittent failure in browser_check_correct_controllers.js. r=mak The test seems to sometimes fail because the toolbar hasn't been updated with the bookmarks, so we wait for that. Differential Revision: https://phabricator.services.mozilla.com/D150370
5ff5566688462dc0ae916616b784650050945581: Bug 1702806 - Fix issues with intermittient failures in places tests and due to the way the dialogs interact with PlacesTransactions. r=mak
Mark Banner <standard8@mozilla.com> - Thu, 30 Jun 2022 19:29:41 +0000 - rev 622770
Push 39921 by smolnar@mozilla.com at Fri, 01 Jul 2022 04:18:35 +0000
Bug 1702806 - Fix issues with intermittient failures in places tests and due to the way the dialogs interact with PlacesTransactions. r=mak There's are a couple of issues that this fixes, they are both based around the issue that because tests run fast they tend to not give time for batches to complete. This can lead to incomplete batches between tests, which tends to mess up subsequent tests or cause hangs. In normal usage this is not an issue, as the user is not able to go as fast as tests. The first issue is that in PlacesUIUtils.showBookmarkDialog we may resolve the dialog deferred promise before the transaction batch has had change to complete. The second issue is that the star UI runs batches, and that again we do not wait for the batch to be complete. Working an await into the star UI/tests is more difficult due to the way that code is structured. With a planned switch to non-instant apply, it also feels too complicated to be worth it at this time. As a workaround for this issue, we ensure that the transaction queue is cleared between each test run via a registerCleanupFunction in the head.js file. Differential Revision: https://phabricator.services.mozilla.com/D147535
d5ef7ee3de514d7b41005020a2358813e75ba42f: Bug 1735534 - Set browser.urlbar.dnsResolveSingleWordsAfterSearch to 0 by default - r=mak
James Teow <jteow@mozilla.com> - Thu, 30 Jun 2022 16:15:04 +0000 - rev 622719
Push 39921 by smolnar@mozilla.com at Fri, 01 Jul 2022 04:18:35 +0000
Bug 1735534 - Set browser.urlbar.dnsResolveSingleWordsAfterSearch to 0 by default - r=mak Differential Revision: https://phabricator.services.mozilla.com/D149159
dbccc564b0f8ab005e0cd02c172bc98a70937d1e: Bug 1776242 - Remove unused PLACES_AUTOCOMPLETE_URLINLINE_DOMAIN_QUERY_TIME_MS histogram definition. r=mak
Mark Banner <standard8@mozilla.com> - Thu, 23 Jun 2022 17:08:11 +0000 - rev 621896
Push 39892 by nfay@mozilla.com at Fri, 24 Jun 2022 09:35:42 +0000
Bug 1776242 - Remove unused PLACES_AUTOCOMPLETE_URLINLINE_DOMAIN_QUERY_TIME_MS histogram definition. r=mak Differential Revision: https://phabricator.services.mozilla.com/D150149
881b04553e0dc72cd12053b012d78400043fefbf: Bug 1775312 - Add simple tests for user and policy engines. r=mak
Mark Banner <standard8@mozilla.com> - Wed, 22 Jun 2022 10:51:13 +0000 - rev 621728
Push 39885 by nfay@mozilla.com at Thu, 23 Jun 2022 03:54:50 +0000
Bug 1775312 - Add simple tests for user and policy engines. r=mak Depends on D149929 Differential Revision: https://phabricator.services.mozilla.com/D149930
7e53862a3c3d52e6722a5db7c276f568d468ce57: Bug 1775312 - When reporting an empty submission url to Glean, use a dummy value as it requires a non-empty string. r=mak
Mark Banner <standard8@mozilla.com> - Wed, 22 Jun 2022 10:51:12 +0000 - rev 621727
Push 39885 by nfay@mozilla.com at Thu, 23 Jun 2022 03:54:50 +0000
Bug 1775312 - When reporting an empty submission url to Glean, use a dummy value as it requires a non-empty string. r=mak Differential Revision: https://phabricator.services.mozilla.com/D149929
f51a28b89a841c560a2a88a8ad88013ed651b06f: Bug 1672427 - Remove FX_URLBAR_SELECTED_RESULT_INDEX, FX_URLBAR_SELECTED_RESULT_TYPE_2 and FX_URLBAR_SELECTED_RESULT_INDEX_BY_TYPE_2 histograms r=mak
Michael Kohler <me@michaelkohler.info> - Fri, 17 Jun 2022 09:04:27 +0000 - rev 621272
Push 39863 by ncsoregi@mozilla.com at Fri, 17 Jun 2022 21:46:21 +0000
Bug 1672427 - Remove FX_URLBAR_SELECTED_RESULT_INDEX, FX_URLBAR_SELECTED_RESULT_TYPE_2 and FX_URLBAR_SELECTED_RESULT_INDEX_BY_TYPE_2 histograms r=mak Differential Revision: https://phabricator.services.mozilla.com/D148359
e334384093e74f0df66e36ca9583de8f56f99bbb: Bug 1774587: Expose a function for creating `moz_places` entries on `PlacesUtils.jsm`. r=mak
Dave Townsend <dtownsend@oxymoronical.com> - Fri, 17 Jun 2022 08:28:33 +0000 - rev 621268
Push 39863 by ncsoregi@mozilla.com at Fri, 17 Jun 2022 21:46:21 +0000
Bug 1774587: Expose a function for creating `moz_places` entries on `PlacesUtils.jsm`. r=mak Differential Revision: https://phabricator.services.mozilla.com/D149516
bdd0e402bb142911af2b5dfad475493e0d3e7e3a: Bug 1772906, switch to use validateFileNameForSaving to verify the filename when opening view source in an external editor, r=mak
Neil Deakin <neil@mozilla.com> - Wed, 15 Jun 2022 14:33:28 +0000 - rev 620983
Push 39856 by abutkovits@mozilla.com at Wed, 15 Jun 2022 21:49:08 +0000
Bug 1772906, switch to use validateFileNameForSaving to verify the filename when opening view source in an external editor, r=mak Differential Revision: https://phabricator.services.mozilla.com/D148535
de9ad4f5b1ea064b3df5b4bd2239aae974d12398: Bug 1772906, switch to use validateFileNameForSaving to verify the filename when opening view source in an external editor, r=mak
Neil Deakin <neil@mozilla.com> - Tue, 14 Jun 2022 14:02:57 +0000 - rev 620864
Push 39850 by ctuns@mozilla.com at Tue, 14 Jun 2022 21:37:29 +0000
Bug 1772906, switch to use validateFileNameForSaving to verify the filename when opening view source in an external editor, r=mak Differential Revision: https://phabricator.services.mozilla.com/D148535
7860e59e272d8697fc3e2edae35db2a15b0474c7: Bug 1774190: Handle null titles in PlacesUIUtils.insertTitleStartDiffs. r=mak
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 14 Jun 2022 12:24:57 +0000 - rev 620837
Push 39850 by ctuns@mozilla.com at Tue, 14 Jun 2022 21:37:29 +0000
Bug 1774190: Handle null titles in PlacesUIUtils.insertTitleStartDiffs. r=mak Differential Revision: https://phabricator.services.mozilla.com/D149239
9756645733e93b9d4273e3b8566438ea114c3181: Bug 1772906, switch to use validateFileNameForSaving to verify the filename when opening view source in an external editor, r=mak
Neil Deakin <neil@mozilla.com> - Fri, 10 Jun 2022 12:41:15 +0000 - rev 620501
Push 39829 by csabou@mozilla.com at Fri, 10 Jun 2022 21:34:50 +0000
Bug 1772906, switch to use validateFileNameForSaving to verify the filename when opening view source in an external editor, r=mak Differential Revision: https://phabricator.services.mozilla.com/D148535
5562cae92eb595d7e4f538a9c38b369cf1160bc8: Bug 1760130 - Run FileTestUtils cleanup at the latest possible phase r=mak
Barret Rennie <barret@brennie.ca> - Thu, 09 Jun 2022 16:11:13 +0000 - rev 620324
Push 39824 by smolnar@mozilla.com at Thu, 09 Jun 2022 22:00:48 +0000
Bug 1760130 - Run FileTestUtils cleanup at the latest possible phase r=mak Differential Revision: https://phabricator.services.mozilla.com/D148147
b8a1318e4c13e381e4e3bcc8ddae94089b3ffe25: Bug 1772100 - Part 24: Use plain object for lazy getter in browser/components/BrowserGlue.jsm. r=mak
Tooru Fujisawa <arai_a@mac.com> - Wed, 08 Jun 2022 20:47:42 +0000 - rev 620186
Push 39820 by mlaza@mozilla.com at Thu, 09 Jun 2022 03:45:01 +0000
Bug 1772100 - Part 24: Use plain object for lazy getter in browser/components/BrowserGlue.jsm. r=mak Differential Revision: https://phabricator.services.mozilla.com/D148034
7d34a43bda82f7fdc854207c6702c5e333210dc9: Bug 1772100 - Part 6: Use plain object for lazy getter in browser/components/downloads/DownloadsViewUI.jsm. r=mak
Tooru Fujisawa <arai_a@mac.com> - Wed, 08 Jun 2022 20:47:41 +0000 - rev 620184
Push 39820 by mlaza@mozilla.com at Thu, 09 Jun 2022 03:45:01 +0000
Bug 1772100 - Part 6: Use plain object for lazy getter in browser/components/downloads/DownloadsViewUI.jsm. r=mak Differential Revision: https://phabricator.services.mozilla.com/D148016
cacf593bf250b1f836a9a7f536e9e933b8d6299e: Bug 1772100 - Part 5: Use plain object for lazy getter in browser/components/downloads/. r=mak
Tooru Fujisawa <arai_a@mac.com> - Wed, 08 Jun 2022 20:47:40 +0000 - rev 620183
Push 39820 by mlaza@mozilla.com at Thu, 09 Jun 2022 03:45:01 +0000
Bug 1772100 - Part 5: Use plain object for lazy getter in browser/components/downloads/. r=mak Differential Revision: https://phabricator.services.mozilla.com/D148015
145b3ab52b716b62dd662ddbef2ed686a2fabb0c: Bug 1772101 - Part 32: Use plain object for lazy getter in toolkit/components/places/. r=mak
Tooru Fujisawa <arai_a@mac.com> - Wed, 08 Jun 2022 20:45:18 +0000 - rev 620178
Push 39820 by mlaza@mozilla.com at Thu, 09 Jun 2022 03:45:01 +0000
Bug 1772101 - Part 32: Use plain object for lazy getter in toolkit/components/places/. r=mak Differential Revision: https://phabricator.services.mozilla.com/D147973
3b2091b4dc4a78ce95aae4dc3804ca34289d969b: Bug 1772101 - Part 15: Use plain object for lazy getter in toolkit/components/downloads/Downloads.jsm. r=mak
Tooru Fujisawa <arai_a@mac.com> - Wed, 08 Jun 2022 20:45:17 +0000 - rev 620176
Push 39820 by mlaza@mozilla.com at Thu, 09 Jun 2022 03:45:01 +0000
Bug 1772101 - Part 15: Use plain object for lazy getter in toolkit/components/downloads/Downloads.jsm. r=mak Differential Revision: https://phabricator.services.mozilla.com/D147956
dce66a729e3d036d9fe0c0ed91dc221c1964e1cf: Bug 1772101 - Part 14: Use plain object for lazy getter in toolkit/components/downloads/DownloadIntegration.jsm. r=mak
Tooru Fujisawa <arai_a@mac.com> - Wed, 08 Jun 2022 20:45:17 +0000 - rev 620175
Push 39820 by mlaza@mozilla.com at Thu, 09 Jun 2022 03:45:01 +0000
Bug 1772101 - Part 14: Use plain object for lazy getter in toolkit/components/downloads/DownloadIntegration.jsm. r=mak Differential Revision: https://phabricator.services.mozilla.com/D147955
6ef1eabd31dc968e1f104aca262b417cb1817493: Bug 1772101 - Part 13: Use plain object for lazy getter in toolkit/components/downloads/DownloadCore.jsm. r=mak
Tooru Fujisawa <arai_a@mac.com> - Wed, 08 Jun 2022 20:45:16 +0000 - rev 620174
Push 39820 by mlaza@mozilla.com at Thu, 09 Jun 2022 03:45:01 +0000
Bug 1772101 - Part 13: Use plain object for lazy getter in toolkit/components/downloads/DownloadCore.jsm. r=mak Differential Revision: https://phabricator.services.mozilla.com/D147953
99f097b1f5461c7ab0549752ac4e4ddc80983fc7: Bug 1772101 - Part 12: Use plain object for lazy getter in toolkit/components/downloads/. r=mak
Tooru Fujisawa <arai_a@mac.com> - Wed, 08 Jun 2022 20:45:16 +0000 - rev 620173
Push 39820 by mlaza@mozilla.com at Thu, 09 Jun 2022 03:45:01 +0000
Bug 1772101 - Part 12: Use plain object for lazy getter in toolkit/components/downloads/. r=mak Differential Revision: https://phabricator.services.mozilla.com/D147952
6d059743dca3bdfc68d3284ca0062468b14b92d9: Bug 1772101 - Part 8: Use plain object for lazy getter in toolkit/components/contentprefs/. r=mak
Tooru Fujisawa <arai_a@mac.com> - Wed, 08 Jun 2022 20:45:15 +0000 - rev 620172
Push 39820 by mlaza@mozilla.com at Thu, 09 Jun 2022 03:45:01 +0000
Bug 1772101 - Part 8: Use plain object for lazy getter in toolkit/components/contentprefs/. r=mak Differential Revision: https://phabricator.services.mozilla.com/D147948
c525ab3649a1e9e96e6f2e1478bc3e9ba5929aa9: Bug 1772099 - Part 7: Use plain object for lazy getter in toolkit/mozapps/downloads/HelperAppDlg.jsm. r=mak
Tooru Fujisawa <arai_a@mac.com> - Wed, 08 Jun 2022 13:01:35 +0000 - rev 620098
Push 39819 by nbeleuzu@mozilla.com at Wed, 08 Jun 2022 21:48:24 +0000
Bug 1772099 - Part 7: Use plain object for lazy getter in toolkit/mozapps/downloads/HelperAppDlg.jsm. r=mak Differential Revision: https://phabricator.services.mozilla.com/D147933
d0a5cd47568e1db4b43f2ac752238bfd066503b0: Bug 1772099 - Part 6: Use plain object for lazy getter in toolkit/mozapps/downloads/. r=mak
Tooru Fujisawa <arai_a@mac.com> - Wed, 08 Jun 2022 13:01:35 +0000 - rev 620097
Push 39819 by nbeleuzu@mozilla.com at Wed, 08 Jun 2022 21:48:24 +0000
Bug 1772099 - Part 6: Use plain object for lazy getter in toolkit/mozapps/downloads/. r=mak Differential Revision: https://phabricator.services.mozilla.com/D147932
55a802c01286c3fe7cc7651a1b74048fcca05112: Bug 1772094 - Part 1: Use plain object for lazy getter in docshell/base/. r=mak
Tooru Fujisawa <arai_a@mac.com> - Tue, 07 Jun 2022 16:23:07 +0000 - rev 619971
Push 39813 by nfay@mozilla.com at Wed, 08 Jun 2022 03:52:13 +0000
Bug 1772094 - Part 1: Use plain object for lazy getter in docshell/base/. r=mak Differential Revision: https://phabricator.services.mozilla.com/D147908
2f3bf2d5f1a66850239a153c79f308dcc637423f: Bug 1354248 - Part 4: Make PageIconProtocolHandler use RemoteStreamGetter. r=necko-reviewers,nika,mak,ckerschb,kershaw
Mike Conley <mconley@mozilla.com> - Fri, 03 Jun 2022 15:17:34 +0000 - rev 619656
Push 39793 by mlaza@mozilla.com at Fri, 03 Jun 2022 21:43:55 +0000
Bug 1354248 - Part 4: Make PageIconProtocolHandler use RemoteStreamGetter. r=necko-reviewers,nika,mak,ckerschb,kershaw This makes it so that PageIconProtocolHandler uses RemoteStreamGetter in the event that the privileged about content process attempts to use the page-icon: protocol. This allows the parent to then remotely stream the favicons down to the privileged about content process. This also adds a test to check that only the privileged about content process can use this protocol, and that "normal" web content processes cannot. Differential Revision: https://phabricator.services.mozilla.com/D147335
49a45dfe12aa30b08973da2618c0849bbd5e3b17: Bug 1770331: Store user's input in moz_inputhistory as lower case. r=adw,mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Thu, 26 May 2022 13:05:00 +0000 - rev 618972
Push 39753 by apavel@mozilla.com at Thu, 26 May 2022 21:36:38 +0000
Bug 1770331: Store user's input in moz_inputhistory as lower case. r=adw,mak Differential Revision: https://phabricator.services.mozilla.com/D147050
3c9653131b8f9f84c8b754896b90188e4f172277: Bug 1738574 - add an option to put downloads in tmp to start with, r=mak,mkaply,fluent-reviewers,flod
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 24 May 2022 12:54:42 +0000 - rev 618704
Push 39743 by mlaza@mozilla.com at Tue, 24 May 2022 21:44:48 +0000
Bug 1738574 - add an option to put downloads in tmp to start with, r=mak,mkaply,fluent-reviewers,flod Differential Revision: https://phabricator.services.mozilla.com/D146719
de69bcacb61e2f55759da9fb1ddfcdb26f588270: Bug 1707462 - use system localized paths for settings' download folder display, and don't show 'Downloads' on Linux if that's not the folder's name, r=mak
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 23 May 2022 21:57:03 +0000 - rev 618576
Push 39739 by bszekely@mozilla.com at Tue, 24 May 2022 09:36:49 +0000
Bug 1707462 - use system localized paths for settings' download folder display, and don't show 'Downloads' on Linux if that's not the folder's name, r=mak Depends on D143480 Differential Revision: https://phabricator.services.mozilla.com/D143481
d999522dda59374b3f624f71c57a9234fbd3e2e3: Bug 1770239 - Fix the edit bookmarks panel to be not flush with the bookmark star icon on the URL bar r=mak
Itiel <itiel_yn8@walla.com> - Sat, 21 May 2022 17:39:33 +0000 - rev 618432
Push 39730 by mlaza@mozilla.com at Sun, 22 May 2022 09:46:33 +0000
Bug 1770239 - Fix the edit bookmarks panel to be not flush with the bookmark star icon on the URL bar r=mak Differential Revision: https://phabricator.services.mozilla.com/D146845
caee82a6f5b6fcbb0b1ff839279b4e53fc6b3dfb: Bug 1769783 - Disable adaptive history autofill on Nightly until the matching logic is improved. r=mak
Drew Willcoxon <adw@mozilla.com> - Tue, 17 May 2022 18:25:49 +0000 - rev 618025
Push 39712 by abutkovits@mozilla.com at Wed, 18 May 2022 03:14:37 +0000
Bug 1769783 - Disable adaptive history autofill on Nightly until the matching logic is improved. r=mak Differential Revision: https://phabricator.services.mozilla.com/D146595
4e81d38260422d3b1fa04e9f940a0c03ab7c44a3: Bug 1760637 - Upgrade initPanel in instantEditBookmark.js to async r=mak
James Teow <jteow@mozilla.com> - Tue, 17 May 2022 00:32:48 +0000 - rev 617808
Push 39708 by bszekely@mozilla.com at Tue, 17 May 2022 09:27:45 +0000
Bug 1760637 - Upgrade initPanel in instantEditBookmark.js to async r=mak In addition to adding async/await, I also added early return statements when we know initialization is occuring again, or if there is evidence that it has been uninitialized. A concrete example of this would be from the Library, where clicking on on a folder/category on the left will run initPanel at the same time as the highlighted folder/bookmark on the right changes (also runs initPanel). Differential Revision: https://phabricator.services.mozilla.com/D141800
7b1519f1aea8e2bd4f9f4705ee376aaf7ec88cc9: Bug 1767434 - Make updateDetailsPane always retrieve treeIndex r=mak
James Teow <jteow@mozilla.com> - Mon, 16 May 2022 14:21:59 +0000 - rev 617738
Push 39704 by csabou@mozilla.com at Mon, 16 May 2022 21:54:06 +0000
Bug 1767434 - Make updateDetailsPane always retrieve treeIndex r=mak The problem with my previous solution for bug 1471546 was that bookmarkIndex is not updated when a user sorts the list of bookmarks. So my solution is to always use the treeIndex since its more reliable. I've also added two tests: the first checks if the row the visible after clicking a bookmark that's close to the bottom of the viewable area, and the second does the same after re-sorting the list. Differential Revision: https://phabricator.services.mozilla.com/D145509
92cdeadc813e111076a531e78472a3c97fbf8c9a: Bug 1597791: Support adaptive history autofill. r=adw,mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Fri, 13 May 2022 22:46:36 +0000 - rev 617286
Push 39692 by imoraru@mozilla.com at Sat, 14 May 2022 04:09:48 +0000
Bug 1597791: Support adaptive history autofill. r=adw,mak Differential Revision: https://phabricator.services.mozilla.com/D144393
74fd29f80fe3f60cc90289633c461c7dd76a85aa: Bug 1767975 - For groups of snapshot, add an indication of where the title is different for providing UI hints. r=mak
Mark Banner <standard8@mozilla.com> - Tue, 10 May 2022 16:59:06 +0000 - rev 616872
Push 39678 by ctuns@mozilla.com at Tue, 10 May 2022 21:39:54 +0000
Bug 1767975 - For groups of snapshot, add an indication of where the title is different for providing UI hints. r=mak Differential Revision: https://phabricator.services.mozilla.com/D145612
a3a1f2370418db03e482a07929757b440d5b87a9: Bug 1474137 - Invalidate previous result when datalist is changed. r=mak
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 10 May 2022 01:45:30 +0000 - rev 616782
Push 39675 by apavel@mozilla.com at Tue, 10 May 2022 09:55:38 +0000
Bug 1474137 - Invalidate previous result when datalist is changed. r=mak Even if `<datalist>` is dynamically changed, autocomplete controller still uses previous search result. If changed, we have to ignore previous result that may be invalid. Also, even if `<datalist>` is changed, we have to keep selected index (Bug 595069), so we cannot use `ResetInternalState` at this situation. It resets selected index. Differential Revision: https://phabricator.services.mozilla.com/D116679
98d24e564a255daba7377d7432a7aa203cc03e44: Bug 1746052, use validateFileNameForSaving in DownloadPaths.sanitize with flags to emulate something similar to the existing behaviour, r=mak
Neil Deakin <neil@mozilla.com> - Fri, 06 May 2022 10:00:56 +0000 - rev 616472
Push 39659 by csabou@mozilla.com at Fri, 06 May 2022 21:56:34 +0000
Bug 1746052, use validateFileNameForSaving in DownloadPaths.sanitize with flags to emulate something similar to the existing behaviour, r=mak Differential Revision: https://phabricator.services.mozilla.com/D138738
d65e39e825687f80e7a676ba7f8faddb403b99f2: Bug 1749998 - Expose alwaysOpenPanel in context menu. r=mak,Gijs,fluent-reviewers,flod
Shane Hughes <shmediaproductions@gmail.com> - Fri, 06 May 2022 08:21:41 +0000 - rev 616443
Push 39659 by csabou@mozilla.com at Fri, 06 May 2022 21:56:34 +0000
Bug 1749998 - Expose alwaysOpenPanel in context menu. r=mak,Gijs,fluent-reviewers,flod This patch adds a new menuitem to the toolbar context menu that functions analogously to the downloads button auto-hide menuitem. It's visible when the context menu is opened on the downloads button, and hidden otherwise. It toggles browser.download.alwaysOpenPanel. Also add some tests to make sure it's showing in the correct conditions and having the correct effect in practice. While we're at it, make some slight simplifications of related tests. Differential Revision: https://phabricator.services.mozilla.com/D145284
cf50b25d52a09930662e62c1c79e761ca8b6f316: Bug 1749998 - Expose alwaysOpenPanel in context menu. r=mak,Gijs,fluent-reviewers,flod
Shane Hughes <shmediaproductions@gmail.com> - Thu, 05 May 2022 21:25:40 +0000 - rev 616363
Push 39657 by imoraru@mozilla.com at Fri, 06 May 2022 09:50:52 +0000
Bug 1749998 - Expose alwaysOpenPanel in context menu. r=mak,Gijs,fluent-reviewers,flod This patch adds a new menuitem to the toolbar context menu that functions analogously to the downloads button auto-hide menuitem. It's visible when the context menu is opened on the downloads button, and hidden otherwise. It toggles browser.download.alwaysOpenPanel. Also add some tests to make sure it's showing in the correct conditions and having the correct effect in practice. While we're at it, make some slight simplifications of related tests. Differential Revision: https://phabricator.services.mozilla.com/D145284
684b2aca10bbbb04b928b355da256db51a6dd8e7: Bug 1746052, use validateFileNameForSaving in DownloadPaths.sanitize with flags to emulate something similar to the existing behaviour, r=mak
Neil Deakin <neil@mozilla.com> - Thu, 05 May 2022 19:46:49 +0000 - rev 616340
Push 39657 by imoraru@mozilla.com at Fri, 06 May 2022 09:50:52 +0000
Bug 1746052, use validateFileNameForSaving in DownloadPaths.sanitize with flags to emulate something similar to the existing behaviour, r=mak Differential Revision: https://phabricator.services.mozilla.com/D138738
d19cc58e3cab262ccf4f7e908d59f8b08903a67e: Bug 1746052, use validateFileNameForSaving in DownloadPaths.sanitize with flags to emulate something similar to the existing behaviour, r=mak
Neil Deakin <neil@mozilla.com> - Tue, 03 May 2022 19:44:29 +0000 - rev 616007
Push 39645 by imoraru@mozilla.com at Wed, 04 May 2022 03:39:47 +0000
Bug 1746052, use validateFileNameForSaving in DownloadPaths.sanitize with flags to emulate something similar to the existing behaviour, r=mak Differential Revision: https://phabricator.services.mozilla.com/D138738
289271bc4f8bca711e1ad50414dd7729a905300b: Bug 1766853 - Upgrade to SQLite 3.38.3. r=mak
Ryan VanderMeulen <ryanvm@gmail.com> - Thu, 28 Apr 2022 14:32:54 +0000 - rev 615581
Push 39625 by nfay@mozilla.com at Thu, 28 Apr 2022 21:47:15 +0000
Bug 1766853 - Upgrade to SQLite 3.38.3. r=mak Differential Revision: https://phabricator.services.mozilla.com/D144962
1eb191c96aef875637c15331ec4ff7752774a50e: Bug 1759231 - Downloads panel should not open on extension created downloads created while not handling user input. r=mak,robwu
Luca Greco <lgreco@mozilla.com> - Wed, 27 Apr 2022 15:51:00 +0000 - rev 615474
Push 39622 by apavel@mozilla.com at Wed, 27 Apr 2022 21:34:31 +0000
Bug 1759231 - Downloads panel should not open on extension created downloads created while not handling user input. r=mak,robwu Differential Revision: https://phabricator.services.mozilla.com/D143268
34f595d131ad1311a23108686b4db141243255d9: Bug 1762033 - Add download property to prevent showing panel. r=mak
Shane Hughes <shmediaproductions@gmail.com> - Wed, 27 Apr 2022 15:51:00 +0000 - rev 615473
Push 39622 by apavel@mozilla.com at Wed, 27 Apr 2022 21:34:31 +0000
Bug 1762033 - Add download property to prevent showing panel. r=mak Add a property `openDownloadsListOnStart` to the download object prototype. It is true by default. When passed a false value, it will prevent the usual behavior of opening the downloads panel when the download starts. This will allow some (forthcoming) internal code in the WebExtensions API to prevent showing the downloads panel when a download is created without any user input (see bug 1759231 for details). Differential Revision: https://phabricator.services.mozilla.com/D142503
ee0ab9901b3cc0b4bec2b06d4fcbf25718222454: Bug 1765427 - Remove initializedModules from BrowserGlue as they don't actually work. r=mak
Mark Banner <standard8@mozilla.com> - Tue, 26 Apr 2022 22:08:38 +0000 - rev 615380
Push 39619 by mlaza@mozilla.com at Wed, 27 Apr 2022 09:44:29 +0000
Bug 1765427 - Remove initializedModules from BrowserGlue as they don't actually work. r=mak Differential Revision: https://phabricator.services.mozilla.com/D144061
9c48b6682930e7db58d4a4d194f55b6477183105: Bug 1765427 - Remove initializedModules from BrowserGlue as they don't actually work. r=mak
Mark Banner <standard8@mozilla.com> - Tue, 26 Apr 2022 16:19:31 +0000 - rev 615345
Push 39619 by mlaza@mozilla.com at Wed, 27 Apr 2022 09:44:29 +0000
Bug 1765427 - Remove initializedModules from BrowserGlue as they don't actually work. r=mak Differential Revision: https://phabricator.services.mozilla.com/D144061
2ca189b8925dba3f28a1cefdc3e6f143ffbee290: Bug 1471546 - Scroll to bookmark in bookmark library on initial selection when it's not visible r=mak
James Teow <jteow@mozilla.com> - Fri, 22 Apr 2022 13:14:41 +0000 - rev 615097
Push 39603 by smolnar@mozilla.com at Fri, 22 Apr 2022 21:28:46 +0000
Bug 1471546 - Scroll to bookmark in bookmark library on initial selection when it's not visible r=mak Differential Revision: https://phabricator.services.mozilla.com/D139905
dd89e81f8178448146e063b02a4751787637e8c9: Bug 1760851 - Fix intermittent error on browser_controller_onDrop_sidebar.js r=mak
James Teow <jteow@mozilla.com> - Tue, 19 Apr 2022 12:35:39 +0000 - rev 614582
Push 39586 by smolnar@mozilla.com at Tue, 19 Apr 2022 16:03:23 +0000
Bug 1760851 - Fix intermittent error on browser_controller_onDrop_sidebar.js r=mak Differential Revision: https://phabricator.services.mozilla.com/D142016
848dee4a355372caba9f451af91234df50b9d924: Bug 1764689 - Remove unnnecessary global this reference in BOOKMARK_VALIDATORS.url. r=mak
Tooru Fujisawa <arai_a@mac.com> - Tue, 19 Apr 2022 11:57:20 +0000 - rev 614574
Push 39586 by smolnar@mozilla.com at Tue, 19 Apr 2022 16:03:23 +0000
Bug 1764689 - Remove unnnecessary global this reference in BOOKMARK_VALIDATORS.url. r=mak Depends on D143713 Differential Revision: https://phabricator.services.mozilla.com/D143714