searching for reviewer(mak)
7281e581b824ad84f51f376ff2eb6c1af85da50e: Bug 1737033 - Remove workaround for bug 420033. r=mak
Dão Gottwald <dao@mozilla.com> - Fri, 22 Oct 2021 09:46:05 +0000 - rev 596692
Push 38905 by abutkovits@mozilla.com at Fri, 22 Oct 2021 15:45:01 +0000
Bug 1737033 - Remove workaround for bug 420033. r=mak Differential Revision: https://phabricator.services.mozilla.com/D129149
c0a0a871cb91cb933f3d33f9f7b4aceb1ee288c9: Bug 1690731 - Move Places telemetry startup to a scheduled task to ensure it runs after hanlding of user events has started. r=mak
Mark Banner <standard8@mozilla.com> - Thu, 21 Oct 2021 11:34:54 +0000 - rev 596565
Push 38901 by smolnar@mozilla.com at Thu, 21 Oct 2021 16:02:15 +0000
Bug 1690731 - Move Places telemetry startup to a scheduled task to ensure it runs after hanlding of user events has started. r=mak Differential Revision: https://phabricator.services.mozilla.com/D128711
5c1abf7e1da996f27765867249139ab8945059ab: Bug 1736756 - Replace Places' GenerateRandomBytes() with MFBT's GenerateRandomBytesFromOS(). r=mak
Chris Peterson <cpeterson@mozilla.com> - Thu, 21 Oct 2021 02:19:38 +0000 - rev 596522
Push 38900 by nfay@mozilla.com at Thu, 21 Oct 2021 09:36:31 +0000
Bug 1736756 - Replace Places' GenerateRandomBytes() with MFBT's GenerateRandomBytesFromOS(). r=mak Differential Revision: https://phabricator.services.mozilla.com/D128979
14ee535024d7f12a55eccfc253306dacc34a6087: Bug 1434245 - Use defineLazyModuleGetters more often with PlacesUtils. r=mak
Leslie Orellana <lesore0789@gmail.com> - Tue, 19 Oct 2021 16:07:25 +0000 - rev 596368
Push 38896 by abutkovits@mozilla.com at Tue, 19 Oct 2021 21:51:00 +0000
Bug 1434245 - Use defineLazyModuleGetters more often with PlacesUtils. r=mak Differential Revision: https://phabricator.services.mozilla.com/D128581
5243c0c312339bb42709453c8b27afbfeef56795: Bug 1729447 - Changed downloads context menu string for non-Mac from "Open Containing Folder" to "Show in Folder" to align terminology. r=mak,fluent-reviewers,flod
Lebar <lebar@internet-mail.org> - Tue, 19 Oct 2021 15:15:26 +0000 - rev 596364
Push 38896 by abutkovits@mozilla.com at Tue, 19 Oct 2021 21:51:00 +0000
Bug 1729447 - Changed downloads context menu string for non-Mac from "Open Containing Folder" to "Show in Folder" to align terminology. r=mak,fluent-reviewers,flod Differential Revision: https://phabricator.services.mozilla.com/D128538
7713d58b648ec60b98fd00c3779e4b2d596422dd: Bug 1728610 - changed all instance of Cu.reportError with logger.error or this.logger.error where appropriate. r=mak
tanju brunostar <tanjubrunostar0@gmail.com> - Mon, 18 Oct 2021 14:01:10 +0000 - rev 596196
Push 38891 by csabou@mozilla.com at Mon, 18 Oct 2021 21:44:42 +0000
Bug 1728610 - changed all instance of Cu.reportError with logger.error or this.logger.error where appropriate. r=mak Differential Revision: https://phabricator.services.mozilla.com/D128200
63d10a00d25619d4a11c08a96749dad932dc0bec: Bug 1678607: Make BookmarkTagsChanged event have tags. r=mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Mon, 18 Oct 2021 04:43:44 +0000 - rev 596139
Push 38888 by imoraru@mozilla.com at Mon, 18 Oct 2021 09:51:59 +0000
Bug 1678607: Make BookmarkTagsChanged event have tags. r=mak Differential Revision: https://phabricator.services.mozilla.com/D128328
13868a361ad3c4004be8450d7119faaa820e05bc: Bug 1678607: Apply bookmark-tags-changed event. r=mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Mon, 18 Oct 2021 04:43:44 +0000 - rev 596138
Push 38888 by imoraru@mozilla.com at Mon, 18 Oct 2021 09:51:59 +0000
Bug 1678607: Apply bookmark-tags-changed event. r=mak Depends on D128326 Differential Revision: https://phabricator.services.mozilla.com/D128327
7705a6b69701b3c852548c04ced4b4ca7f88f181: Bug 1678607: Implement a mechanism to fire bookmark-tags-changed event. r=mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Mon, 18 Oct 2021 04:43:44 +0000 - rev 596137
Push 38888 by imoraru@mozilla.com at Mon, 18 Oct 2021 09:51:59 +0000
Bug 1678607: Implement a mechanism to fire bookmark-tags-changed event. r=mak Differential Revision: https://phabricator.services.mozilla.com/D128326
bf20be578758bb517b79e7bd1d494a581e5c0f53: Bug 1678607: Make BookmarkTagsChanged event have tags. r=mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Sun, 17 Oct 2021 22:47:37 +0000 - rev 596133
Push 38888 by imoraru@mozilla.com at Mon, 18 Oct 2021 09:51:59 +0000
Bug 1678607: Make BookmarkTagsChanged event have tags. r=mak Differential Revision: https://phabricator.services.mozilla.com/D128328
fd3fbf15e95df232a1ae494349cfd9ce57e428e2: Bug 1678607: Apply bookmark-tags-changed event. r=mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Sun, 17 Oct 2021 22:47:37 +0000 - rev 596132
Push 38888 by imoraru@mozilla.com at Mon, 18 Oct 2021 09:51:59 +0000
Bug 1678607: Apply bookmark-tags-changed event. r=mak Differential Revision: https://phabricator.services.mozilla.com/D128327
2688fa3d2bc2a39100e28464cf415eae7bdf26be: Bug 1678607: Implement a mechanism to fire bookmark-tags-changed event. r=mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Sun, 17 Oct 2021 22:47:36 +0000 - rev 596131
Push 38888 by imoraru@mozilla.com at Mon, 18 Oct 2021 09:51:59 +0000
Bug 1678607: Implement a mechanism to fire bookmark-tags-changed event. r=mak Differential Revision: https://phabricator.services.mozilla.com/D128326
ab41490c55e02600845ce9f96cf8ecd982983042: Bug 1672486 - Remove browser.toolbars.bookmarks.2h2020 pref from firefox.js r=mak,Gijs
Michael Kohler <me@michaelkohler.info> - Thu, 14 Oct 2021 07:51:16 +0000 - rev 595838
Push 38877 by mlaza@mozilla.com at Thu, 14 Oct 2021 15:48:30 +0000
Bug 1672486 - Remove browser.toolbars.bookmarks.2h2020 pref from firefox.js r=mak,Gijs Depends on D127590 Differential Revision: https://phabricator.services.mozilla.com/D127591
6981831be52e4fe63df2088012c262e6fa6478df: Bug 1672486 - Remove browser.toolbars.bookmarks.2h2020 pref in migration r=mak
Michael Kohler <me@michaelkohler.info> - Thu, 14 Oct 2021 07:51:15 +0000 - rev 595837
Push 38877 by mlaza@mozilla.com at Thu, 14 Oct 2021 15:48:30 +0000
Bug 1672486 - Remove browser.toolbars.bookmarks.2h2020 pref in migration r=mak Depends on D127589 Differential Revision: https://phabricator.services.mozilla.com/D127590
ec76ea1a53cb0db0a8261c7f68bfc38b4684a9b9: Bug 1672486 - Remove browser.toolbars.bookmarks.2h2020 pref in policies r=mak
Michael Kohler <me@michaelkohler.info> - Thu, 14 Oct 2021 07:51:15 +0000 - rev 595836
Push 38877 by mlaza@mozilla.com at Thu, 14 Oct 2021 15:48:30 +0000
Bug 1672486 - Remove browser.toolbars.bookmarks.2h2020 pref in policies r=mak Depends on D127588 Differential Revision: https://phabricator.services.mozilla.com/D127589
e412f90c3aeb824d451493fad9928291c9b4b3e3: Bug 1672486 - Remove browser.toolbars.bookmarks.2h2020 pref from browser/customizableui/places r=mak
Michael Kohler <me@michaelkohler.info> - Thu, 14 Oct 2021 07:51:14 +0000 - rev 595835
Push 38877 by mlaza@mozilla.com at Thu, 14 Oct 2021 15:48:30 +0000
Bug 1672486 - Remove browser.toolbars.bookmarks.2h2020 pref from browser/customizableui/places r=mak Differential Revision: https://phabricator.services.mozilla.com/D127588
33152631ec4026cdb7207d970ebee172d92dccc1: Bug 1706004 - Delete reference to document.popupNode in Places. r=mak
Leslie Orellana <lesore0789@gmail.com> - Wed, 13 Oct 2021 08:52:10 +0000 - rev 595628
Push 38873 by ncsoregi@mozilla.com at Wed, 13 Oct 2021 16:41:37 +0000
Bug 1706004 - Delete reference to document.popupNode in Places. r=mak Differential Revision: https://phabricator.services.mozilla.com/D128038
75507ac63638feb100443876ff9d301893f5145e: Bug 1734765 - Move quick suggest test helpers into QuickSuggestTestUtils.jsm. r=mak
Drew Willcoxon <adw@mozilla.com> - Tue, 12 Oct 2021 00:27:18 +0000 - rev 595425
Push 38870 by ccozmuta@mozilla.com at Tue, 12 Oct 2021 09:32:00 +0000
Bug 1734765 - Move quick suggest test helpers into QuickSuggestTestUtils.jsm. r=mak This consolidates and moves quick suggest test helpers into a new QuickSuggestTestUtils.jsm. I'm working on https://mozilla-hub.atlassian.net/browse/SNT-34 and I'm adding a couple of test files that need many of the same helpers in browser_urlbar_telemetry_quicksuggest.js. We already have some quick suggest helpers in head.js, but instead of adding more, I think it would be useful to have a new module analogous to UrlbarTestUtils. This is mostly a straight port of those helpers to the new module, but some changes were necessary so that the module doesn't make unnecessary assumptions that the helpers in browser_urlbar_telemetry_quicksuggest.js made. That means I added more params to some of these functions. I also improved some of them a little bit where I noticed some small improvements could be made and improved some function names. Finally, I also removed `UrlbarProviderQuickSuggest._helpUrl` while I was here. I added that property specifically so tests could override the help URL to avoid accessing a remote URL, but at the time I didn't realize that `Services.urlFormatter.formatURLPref("app.support.baseURL")` returns a local URL when running tests. Differential Revision: https://phabricator.services.mozilla.com/D127915
6d56fccea656ff72f190974ad38ef3867f660e80: Bug 1733511 - Set currentDropTarget in PMDH_onDragOver r=mak
Kagami Sascha Rosylight <krosylight@mozilla.com> - Mon, 11 Oct 2021 15:12:53 +0000 - rev 595369
Push 38868 by mlaza@mozilla.com at Mon, 11 Oct 2021 21:46:13 +0000
Bug 1733511 - Set currentDropTarget in PMDH_onDragOver r=mak PMDH_onDragEnter sets it but it can be immediately nullified by a dragleave listener of a menu popup. Having null ultimately triggers closeParentMenus() by closeMenuTimer, and setting the proper drop target in dragover prevents that. Running closeMenuTimer immediately after openen a popup sounds weird but that's an existing behavior and is out of scope of this patch. Differential Revision: https://phabricator.services.mozilla.com/D127971
59182ddb0043fc907429a46c8476633872a7d759: Bug 1734823 - Follow-up to drop unused NUMBER_OF_BACKUPS from test_utils_backups_hasRecent.js. r=mak CLOSED TREE DONTBUILD
Mark Banner <standard8@mozilla.com> - Mon, 11 Oct 2021 11:55:27 +0000 - rev 595326
Push 38868 by mlaza@mozilla.com at Mon, 11 Oct 2021 21:46:13 +0000
Bug 1734823 - Follow-up to drop unused NUMBER_OF_BACKUPS from test_utils_backups_hasRecent.js. r=mak CLOSED TREE DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D128080
6f77c033653ce267fbb339052a2f993596d12d6c: Bug 1678627: Apply bookmark-time-changed event. r=mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Thu, 07 Oct 2021 22:10:20 +0000 - rev 595145
Push 38858 by malexandru@mozilla.com at Fri, 08 Oct 2021 03:38:35 +0000
Bug 1678627: Apply bookmark-time-changed event. r=mak Differential Revision: https://phabricator.services.mozilla.com/D125925
061c362857d386078401e66c9172b59e60facc1b: Bug 1678627: Implement a mechanism to fire bookmark-time-changed event. r=mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Thu, 07 Oct 2021 22:10:20 +0000 - rev 595144
Push 38858 by malexandru@mozilla.com at Fri, 08 Oct 2021 03:38:35 +0000
Bug 1678627: Implement a mechanism to fire bookmark-time-changed event. r=mak Differential Revision: https://phabricator.services.mozilla.com/D125924
d0180eae3832b10e90f9815b0f4f79b071b25dbe: Bug 1678626: Apply bookmark-guid-changed event. r=mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Tue, 05 Oct 2021 00:53:46 +0000 - rev 594537
Push 38847 by ctuns@mozilla.com at Tue, 05 Oct 2021 03:52:32 +0000
Bug 1678626: Apply bookmark-guid-changed event. r=mak Differential Revision: https://phabricator.services.mozilla.com/D125771
82662a4822c4a06c75b89e830a7bf5607725a4e4: Bug 1678626: Implement a mechanism to fire bookmark-guid-changed event. r=mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Tue, 05 Oct 2021 00:53:46 +0000 - rev 594536
Push 38847 by ctuns@mozilla.com at Tue, 05 Oct 2021 03:52:32 +0000
Bug 1678626: Implement a mechanism to fire bookmark-guid-changed event. r=mak Differential Revision: https://phabricator.services.mozilla.com/D125770
20d941890bd1251384f6bbd02e67cd995860923b: Bug 1678626: Introduce PlacesBookmarkChanged class. r=mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Tue, 05 Oct 2021 00:53:45 +0000 - rev 594535
Push 38847 by ctuns@mozilla.com at Tue, 05 Oct 2021 03:52:32 +0000
Bug 1678626: Introduce PlacesBookmarkChanged class. r=mak Differential Revision: https://phabricator.services.mozilla.com/D125769
cb7432a73c166d45b9021e95c5e842ac1c2d8f71: Bug 1678624: Apply bookmark-url-changed event. r=mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Tue, 05 Oct 2021 00:53:45 +0000 - rev 594534
Push 38847 by ctuns@mozilla.com at Tue, 05 Oct 2021 03:52:32 +0000
Bug 1678624: Apply bookmark-url-changed event. r=mak Depends on D103883 Differential Revision: https://phabricator.services.mozilla.com/D103884
78dd2fb234eef4c07e9889d551b7e17a815e37ad: Bug 1678624: Implement a mechanism to fire bookmark-url-changed event. r=mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Tue, 05 Oct 2021 00:53:44 +0000 - rev 594533
Push 38847 by ctuns@mozilla.com at Tue, 05 Oct 2021 03:52:32 +0000
Bug 1678624: Implement a mechanism to fire bookmark-url-changed event. r=mak Depends on D103148 Differential Revision: https://phabricator.services.mozilla.com/D103883
2d75255c3a30e11d80ef6285bfee2497d8e0662a: Bug 1678623: Apply bookmark-title-changed event. r=mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Fri, 01 Oct 2021 12:01:29 +0000 - rev 593921
Push 38837 by smolnar@mozilla.com at Fri, 01 Oct 2021 15:49:07 +0000
Bug 1678623: Apply bookmark-title-changed event. r=mak Depends on D103147 Differential Revision: https://phabricator.services.mozilla.com/D103148
4b915555ae3d8b61f5bc87cbbf2a5acffa76e7e8: Bug 1678623: Implement a mechanism to fire bookmark-title-changed event. r=mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Fri, 01 Oct 2021 12:01:29 +0000 - rev 593920
Push 38837 by smolnar@mozilla.com at Fri, 01 Oct 2021 15:49:07 +0000
Bug 1678623: Implement a mechanism to fire bookmark-title-changed event. r=mak Differential Revision: https://phabricator.services.mozilla.com/D103147
4ca3428ff5d0889a32c8547f327a602950ef2bd5: Bug 1730040 - drop PLACES_BOOKMARKS_TOOLBAR_RENDER_DELAY_MS probe, r=mak
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 01 Oct 2021 11:12:23 +0000 - rev 593917
Push 38837 by smolnar@mozilla.com at Fri, 01 Oct 2021 15:49:07 +0000
Bug 1730040 - drop PLACES_BOOKMARKS_TOOLBAR_RENDER_DELAY_MS probe, r=mak Differential Revision: https://phabricator.services.mozilla.com/D126904
d8d430de152a06e892a36a7b9756ab3fa0aaa84a: Bug 1729195 - When the heuristic is hidden, include results that dupe it. r=mak
Drew Willcoxon <adw@mozilla.com> - Thu, 30 Sep 2021 18:31:07 +0000 - rev 593852
Push 38836 by ctuns@mozilla.com at Fri, 01 Oct 2021 09:33:23 +0000
Bug 1729195 - When the heuristic is hidden, include results that dupe it. r=mak When the heuristic is hidden, we shouldn't exclude results that dupe it. I realized this while working on the top hit bug 1723160. I have nytimes.com in my profile with a very high frecency. When I enable the `hideHeuristic` pref, nytimes.com autofills but it doesn't appear anywhere in the results, which is confusing. After autofill, if I start to backspace over characters, then it appears as the top hit because when backspacing the heuristic becomes a search result. There are three cases where we dedupe that currently depend on the heuristic and therefore need to take into account when the heuristic is hidden: * Autofill * Prefix ranking/priority * Search suggestions The search suggestions case is maybe debatable. If you type "foo" and there's a "foo" search suggestion but the heuristic is hidden, should we exclude the suggestion? IMO we should include it because it may not be clear to the user that pressing enter without selecting a result will perform a search for "foo". It's better to let them see the result and select it. That means we may end up pushing out the last search suggestion we would have otherwise shown, but the last suggestion would have been pushed out anyway if the heuristic weren't hidden, and IIRC we know that people rarely pick suggestions or results far down the list anyway. In fact excluding the first suggestion probably excludes exactly what they want to search for. I've updated the relevant tests so they run some tasks with `hideHeuristic` enabled. I removed test_dupe_urls.js because I checked it to see if it needs updating and it doesn't really do anything. It doesn't even call `PlacesTestUtils.addVisits` correctly because it passes in two URLs, but `addVisits` only takes one argument. Differential Revision: https://phabricator.services.mozilla.com/D124564
9237deee110beeaa7605195528a273b2bbc77352: Bug 350079 - Esc in search box now selects all and reverts. r=mak
Antonin LOUBIERE <pyjacpp@laposte.net> - Sun, 26 Sep 2021 09:10:02 +0000 - rev 593160
Push 38824 by nbeleuzu@mozilla.com at Sun, 26 Sep 2021 21:01:58 +0000
Bug 350079 - Esc in search box now selects all and reverts. r=mak Fix bug, now escape in the search box (if the popup is disimissed) will select all the content and will revert to the last search. Differential Revision: https://phabricator.services.mozilla.com/D120137
76dbe48227dfec1c13baaefd647da0ea529587db: Bug 1703979 - Removing unused/unwanted Confirmation Hints r=mak
Bernard Igiri <bigiri@mozilla.com> - Tue, 21 Sep 2021 14:09:27 +0000 - rev 592649
Push 38811 by nbeleuzu@mozilla.com at Wed, 22 Sep 2021 04:09:13 +0000
Bug 1703979 - Removing unused/unwanted Confirmation Hints r=mak Removing unused and unwanted Confirmation Hints. Differential Revision: https://phabricator.services.mozilla.com/D126016
a6a90cc466ac41e61b2032fb972637a140606147: Bug 1730696 - Add triggers for snapshot and session tables, update places maintenance task. r=mak
Mark Banner <standard8@mozilla.com> - Fri, 17 Sep 2021 11:34:40 +0000 - rev 592291
Push 38798 by mlaza@mozilla.com at Fri, 17 Sep 2021 21:50:08 +0000
Bug 1730696 - Add triggers for snapshot and session tables, update places maintenance task. r=mak Differential Revision: https://phabricator.services.mozilla.com/D125584
54b20adae1935f8057318be0d5b1abf038f90e97: Bug 1730876 - Never discard quick suggest results and dedupe other URL results with a lower or same prefix rank. r=mak
Drew Willcoxon <adw@mozilla.com> - Thu, 16 Sep 2021 16:12:01 +0000 - rev 592195
Push 38794 by ccozmuta@mozilla.com at Thu, 16 Sep 2021 21:45:06 +0000
Bug 1730876 - Never discard quick suggest results and dedupe other URL results with a lower or same prefix rank. r=mak This makes a couple of changes: * Never discard quick suggest results. At some point we may want to revisit, but right now we should always show them. * Discard other URL results whose URLs dupe the URLs of quick suggest results or whose URLs have a lower prefix rank. The first change by itself fixes the bug, but without the second change, we'll still show the eBay history result above the eBay quick suggest, which I confirmed with Natalie is not what we want. We only want to show the quick suggest. Keep in mind that the results in this case have the same URLs, same prefixes. When a non-quick-suggest result has a *higher* prefix rank, I think we should *not* discard it. In that case we should show both the quick suggest with its lower prefix rank and the other result with its higher rank. Differential Revision: https://phabricator.services.mozilla.com/D125768
2437b6208eb429c26cc269a8eb1c68e43c3e3b21: Bug 1729587 - Tweaks to the Firefox Suggest preferences UI. r=mak,preferences-reviewers,jaws,fluent-reviewers
Drew Willcoxon <adw@mozilla.com> - Sat, 11 Sep 2021 02:27:38 +0000 - rev 591677
Push 38779 by smolnar@mozilla.com at Sat, 11 Sep 2021 09:51:21 +0000
Bug 1729587 - Tweaks to the Firefox Suggest preferences UI. r=mak,preferences-reviewers,jaws,fluent-reviewers Per spec, the informational description about data collection under the main Firefox Suggest checkbox should be hidden except for the "online" scenario, since only the online scenario sends data to Mozilla. We're also changing the two checkbox labels and adding another description under the sponsored checkbox. Depends on D125024 Differential Revision: https://phabricator.services.mozilla.com/D125031
04a89fcd740094b3cfcf8bad71c3195fd730a663: Bug 1729776 - Enable the Firefox Suggest "offline" scenario by default for users in the US region with en-* locales. r=mythmon,daleharvey,mak
Drew Willcoxon <adw@mozilla.com> - Sat, 11 Sep 2021 02:27:38 +0000 - rev 591676
Push 38779 by smolnar@mozilla.com at Sat, 11 Sep 2021 09:51:21 +0000
Bug 1729776 - Enable the Firefox Suggest "offline" scenario by default for users in the US region with en-* locales. r=mythmon,daleharvey,mak Enable the Firefox Suggest "offline" scenario by default for users in the US region with en-* locales. Previously we relied on Nimbus to enable the offline scenario, and the goal here is to make it permanent for all users in the US `home` region using en-* locales so that we don't need Nimbus for it anymore. With Nimbus, there were two essential mechanisms that restricted the scenario to the desired population: the `browser.urlbar.quicksuggest.enabled` pref, which is a global toggle for Firefox Suggest suggestions regardless of region and locale, and a Nimbus recipe that enabled the pref for US en-* users only. Without Nimbus, we have only the `browser.urlbar.quicksuggest.enabled` pref. We can't rely on a server-side solution to target a specific population, so we need to do it in the client. This patch keeps the default `false` value of `browser.urlbar.quicksuggest.enabled` in firefox.js, and then it sets a new default-branch value for the pref for the US en-* population on app startup. There's actually a set of prefs related to the offline scenario that need to be set, not only `browser.urlbar.quicksuggest.enabled`. Depends on D124943 Differential Revision: https://phabricator.services.mozilla.com/D125024
423c9445cbf6c4c911d64b5804d115d76cb5a769: Bug 1727261 - make toolkit/modules/tests/xpcshell/test_sqlite.js pass for Thunderbird even if it's not collecting the Telemetry. r=mak DONTBUILD
Magnus Melin <mkmelin+mozilla@iki.fi> - Fri, 10 Sep 2021 11:44:13 +0000 - rev 591613
Push 38778 by imoraru@mozilla.com at Fri, 10 Sep 2021 21:18:00 +0000
Bug 1727261 - make toolkit/modules/tests/xpcshell/test_sqlite.js pass for Thunderbird even if it's not collecting the Telemetry. r=mak DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D125153
6247e5593f369b69e415f6a6a3f31f8659702378: Bug 1729519 - Correct amount of places.sqlite-wal read and writes to cover correct amounts after bug 1727783. r=mak
Mark Banner <standard8@mozilla.com> - Thu, 09 Sep 2021 14:07:30 +0000 - rev 591504
Push 38775 by mlaza@mozilla.com at Thu, 09 Sep 2021 21:27:46 +0000
Bug 1729519 - Correct amount of places.sqlite-wal read and writes to cover correct amounts after bug 1727783. r=mak Differential Revision: https://phabricator.services.mozilla.com/D125064
22435794988317395d15648e70950645a4f8349e: Bug 1729519 - Extend places.sqlite-wal writes to cover amount of writes on windows after bug 1727783. r=mak
Mark Banner <standard8@mozilla.com> - Wed, 08 Sep 2021 16:11:23 +0000 - rev 591345
Push 38773 by smolnar@mozilla.com at Wed, 08 Sep 2021 21:39:05 +0000
Bug 1729519 - Extend places.sqlite-wal writes to cover amount of writes on windows after bug 1727783. r=mak Differential Revision: https://phabricator.services.mozilla.com/D124926
ad74307b0b8e9a57dc55f2b8e88fc0df492e216d: Bug 1722066 - P3. Implement a testcase for DOWNLOADS_USER_ACTION_ON_BLOCKED_DOWNLOAD telemetry probe r=mak
Dimi Lee <dlee@mozilla.com> - Wed, 08 Sep 2021 10:55:34 +0000 - rev 591305
Push 38773 by smolnar@mozilla.com at Wed, 08 Sep 2021 21:39:05 +0000
Bug 1722066 - P3. Implement a testcase for DOWNLOADS_USER_ACTION_ON_BLOCKED_DOWNLOAD telemetry probe r=mak Differential Revision: https://phabricator.services.mozilla.com/D124055
05080731654175a32e22417bb322c85bba6014fa: Bug 1722066 - P2. Move utility functions from common_test_Download.js to head.js r=mak
Dimi Lee <dlee@mozilla.com> - Wed, 08 Sep 2021 10:55:34 +0000 - rev 591304
Push 38773 by smolnar@mozilla.com at Wed, 08 Sep 2021 21:39:05 +0000
Bug 1722066 - P2. Move utility functions from common_test_Download.js to head.js r=mak This patch is used by the next patch so the newly added testcase can use utility functions defined in common_test_Download.js. Differential Revision: https://phabricator.services.mozilla.com/D124054
98ad9316f3ece394277260981934c2c4691f02b2: Bug 1722066 - P1. Add a telemetry probe to record user's decision on blocked download r=mak
Dimi Lee <dlee@mozilla.com> - Wed, 08 Sep 2021 10:55:33 +0000 - rev 591303
Push 38773 by smolnar@mozilla.com at Wed, 08 Sep 2021 21:39:05 +0000
Bug 1722066 - P1. Add a telemetry probe to record user's decision on blocked download r=mak This telemetry shows how users usually react with blocked downloads. I want to monitor this data to understand the accuracy of the download protection service. Differential Revision: https://phabricator.services.mozilla.com/D124053
7158e56a1e80d707734c2515b1e88812a927c49f: Bug 1727783 - Add tables for session metadata storage to places DB. r=mak
Mark Banner <standard8@mozilla.com> - Tue, 07 Sep 2021 14:32:07 +0000 - rev 591198
Push 38771 by csabou@mozilla.com at Wed, 08 Sep 2021 03:24:17 +0000
Bug 1727783 - Add tables for session metadata storage to places DB. r=mak Differential Revision: https://phabricator.services.mozilla.com/D123780
04e64eeedc0508f41ded7af0ce18ee333da14e9a: Bug 1728430 - Part 2: Update the Firefox Suggest preferences UI. r=mak
Drew Willcoxon <adw@mozilla.com> - Mon, 06 Sep 2021 18:56:11 +0000 - rev 591133
Push 38768 by ctuns@mozilla.com at Tue, 07 Sep 2021 09:48:49 +0000
Bug 1728430 - Part 2: Update the Firefox Suggest preferences UI. r=mak This implements the spec in https://mozilla-hub.atlassian.net/browse/SNT-26, but Natalie and I have made some tweaks over Slack that aren't reflected in that ticket. We want to move the Firefox Suggest preferences from the Search pane to the Address Bar section of the Privacy pane. There are now two Firefox Suggest checkboxes instead of one: a main one that enables Firefox Suggest suggestions and another one that enables sponsored suggestions separately. If the main one is checked but the sponsored one isn't, then the user will see only non-sponsored suggestions. I renamed and modified the browser_searchQuickSuggest.js test I added in D105701, but a lot of the test changed and it's probably not helpful to look at the diff against the old version. Previously strings were hardcoded in search.js. I've added the new ones to the new preview Fluent file for Firefox Suggest. Depends on D124300 Differential Revision: https://phabricator.services.mozilla.com/D124431
7477b503e4d03b64831386189bfddea04ac66e50: Bug 1728430 - Part 1: Add a separate pref for sponsored Firefox Suggest results. r=mak
Drew Willcoxon <adw@mozilla.com> - Mon, 06 Sep 2021 18:56:10 +0000 - rev 591132
Push 38768 by ctuns@mozilla.com at Tue, 07 Sep 2021 09:48:49 +0000
Bug 1728430 - Part 1: Add a separate pref for sponsored Firefox Suggest results. r=mak The Jira ticket (link in the bug) calls for two separate checkboxes for Firefox Suggest results: a main checkbox plus a sponsored-suggestions checkbox. The sponsored-suggestions checkbox is subordinate to the main checkbox, i.e., the main checkbox has to be checked to turn on sponsored suggestions. This will allow users to toggle sponsored suggestions separately from non-sponsored suggestions. It's a change from the current situation where we have only one pref and checkbox that control both sponsored and non-sponsored suggestions. So part 1 of fixing this bug is to add a new pref for sponsored suggestions. This revision keeps the current `suggest.quicksuggest` pref as the main pref and adds a new `suggest.quicksuggest.sponsored` pref. I confirmed with Natalie that we want to enable both prefs when the user opts in through the onboarding dialog. We currently record a telemetry event when `suggest.quicksuggest` is toggled. We also want a similar event for the new pref, so this adds one. The pref situation for Firefox Suggest is confusing but in summary: * `browser.urlbar.quicksuggest.enabled`: The global toggle for the entire Firefox Suggest rollout involving sponsored and non-sponsored suggestions, the related telemetry and preferences UI, etc. This pref can be overridden by the `quickSuggestEnabled` Nimbus variable. If false, neither sponsored nor non-sponsored suggestions will be shown. If true, then we look at the individual `suggest.quicksuggest` and `suggest.quicksuggest.sponsored` prefs. * `browser.urlbar.suggest.quicksuggest`: Whether any Firefox Suggest results are shown. This must be true to show both non-sponsored and sponsored results. * `browser.urlbar.suggest.quicksuggest.sponsored`: Whether sponsored Firefox Suggest results are shown. Both this pref and `suggest.quicksuggest` must be true to show sponsored results. Differential Revision: https://phabricator.services.mozilla.com/D124300
faee833c5198eacc435cebfb48069531fd4511d6: Bug 1714478 - go back to using 'edit' and 'delete' for bookmark menus, r=mak,fluent-reviewers,flod
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 01 Sep 2021 16:08:50 +0000 - rev 590463
Push 38755 by nbeleuzu@mozilla.com at Wed, 01 Sep 2021 21:45:53 +0000
Bug 1714478 - go back to using 'edit' and 'delete' for bookmark menus, r=mak,fluent-reviewers,flod Differential Revision: https://phabricator.services.mozilla.com/D124045
1bce8ba91f7be021a4983a140abf4f10db71caa2: Bug 1727799 - Add telemetry probe to measure Merino latency. r=mythmon,mak
Drew Willcoxon <adw@mozilla.com> - Wed, 01 Sep 2021 16:03:51 +0000 - rev 590462
Push 38755 by nbeleuzu@mozilla.com at Wed, 01 Sep 2021 21:45:53 +0000
Bug 1727799 - Add telemetry probe to measure Merino latency. r=mythmon,mak This uses `TelemetryStopwatch` to record the time between the `fetch` start and its resolve. The new histogram is `FX_URLBAR_MERINO_LATENCY_MS`. Depends on D124132 Differential Revision: https://phabricator.services.mozilla.com/D123993
6a86c7fa1ffe703ff70f26456c94976db74eefa5: Bug 1726798 - Replace OS.File with IOUtils in the places toolkit code. r=mak
Mark Banner <standard8@mozilla.com> - Wed, 01 Sep 2021 12:41:26 +0000 - rev 590448
Push 38755 by nbeleuzu@mozilla.com at Wed, 01 Sep 2021 21:45:53 +0000
Bug 1726798 - Replace OS.File with IOUtils in the places toolkit code. r=mak Differential Revision: https://phabricator.services.mozilla.com/D123313
2a4b0e5b3079bbb432a520bb558521024a3f1f0c: Bug 1726798 - Replace OS.File with IOUtils in the places toolkit code. r=mak
Mark Banner <standard8@mozilla.com> - Wed, 01 Sep 2021 07:14:02 +0000 - rev 590416
Push 38754 by smolnar@mozilla.com at Wed, 01 Sep 2021 15:51:13 +0000
Bug 1726798 - Replace OS.File with IOUtils in the places toolkit code. r=mak Differential Revision: https://phabricator.services.mozilla.com/D123313