searching for reviewer(leplatrem)
6435c885b3cbeec0e5d817723d3422c5f9225840: Bug 1134852 - Update password manager recipes from Remote Settings. r=sfoster,leplatrem,geckoview-reviewers,esawin
Tim Giles <tgiles@mozilla.com> - Fri, 02 Oct 2020 19:45:03 +0000 - rev 551367
Push 37831 by btara@mozilla.com at Sat, 03 Oct 2020 21:53:56 +0000
Bug 1134852 - Update password manager recipes from Remote Settings. r=sfoster,leplatrem,geckoview-reviewers,esawin Differential Revision: https://phabricator.services.mozilla.com/D89821
f420690e43612a43ff317145823492dbf29405b2: No bug - Delete the onboarding dump as the collection is already retired on RemoteSettings r=leplatrem
Nan Jiang <njiang028@gmail.com> - Wed, 16 Sep 2020 16:16:37 +0000 - rev 548947
Push 37790 by btara@mozilla.com at Thu, 17 Sep 2020 10:09:40 +0000
No bug - Delete the onboarding dump as the collection is already retired on RemoteSettings r=leplatrem Differential Revision: https://phabricator.services.mozilla.com/D90412
c92f286ce680a2c40fce42a11d717437dacbad11: Bug 1612380 - don't verify content signatures for Thunderbird. r=leplatrem
Magnus Melin <mkmelin+mozilla@iki.fi> - Wed, 02 Sep 2020 14:22:52 +0000 - rev 547489
Push 37750 by nerli@mozilla.com at Wed, 02 Sep 2020 21:57:21 +0000
Bug 1612380 - don't verify content signatures for Thunderbird. r=leplatrem Differential Revision: https://phabricator.services.mozilla.com/D88541
b9cd6b7047b9ccc640cf3dec8ab940a2454eafee: Bug 1612380 - don't verify content signatures for Thunderbird. r=leplatrem
Magnus Melin <mkmelin+mozilla@iki.fi> - Tue, 01 Sep 2020 12:51:08 +0000 - rev 547226
Push 37748 by apavel@mozilla.com at Wed, 02 Sep 2020 03:31:14 +0000
Bug 1612380 - don't verify content signatures for Thunderbird. r=leplatrem Differential Revision: https://phabricator.services.mozilla.com/D88541
504fea031a58e6a930329deb1979e168d1a8e957: Bug 1653988 - Extend the loading of dump fallback for Remote Settings to cover more indexedDB failure areas. r=leplatrem
Mark Banner <standard8@mozilla.com> - Tue, 21 Jul 2020 08:15:48 +0000 - rev 541394
Push 37622 by ccoroiu@mozilla.com at Tue, 21 Jul 2020 16:07:32 +0000
Bug 1653988 - Extend the loading of dump fallback for Remote Settings to cover more indexedDB failure areas. r=leplatrem This extends the current try/catch to cover writing of the dump to the database and reading it back again. It does not cover the verify signature section, as it is expected that it will need to be known if the signature fails. Differential Revision: https://phabricator.services.mozilla.com/D84234
eed56319e02a52e465929b50cccab29e34102833: Bug 1646860 - Pioneer badge call-out on RemoteSettings update r=leplatrem
Robert Helmer <rhelmer@mozilla.com> - Tue, 07 Jul 2020 14:57:27 +0000 - rev 539130
Push 37577 by abutkovits@mozilla.com at Tue, 07 Jul 2020 21:31:11 +0000
Bug 1646860 - Pioneer badge call-out on RemoteSettings update r=leplatrem Differential Revision: https://phabricator.services.mozilla.com/D82255
5455671d51b2b2c8aa934a886251638941bf1ad6: Bug 1646860 - Pioneer badge call-out on RemoteSettings update r=leplatrem
Robert Helmer <rhelmer@mozilla.com> - Mon, 06 Jul 2020 23:55:44 +0000 - rev 539042
Push 37577 by abutkovits@mozilla.com at Tue, 07 Jul 2020 21:31:11 +0000
Bug 1646860 - Pioneer badge call-out on RemoteSettings update r=leplatrem Differential Revision: https://phabricator.services.mozilla.com/D82255
97acb45d8efb67d91cfd2b99d54345018e4d5e9e: Bug 1646860 - Pioneer badge call-out on RemoteSettings update r=leplatrem
Robert Helmer <rhelmer@mozilla.com> - Mon, 06 Jul 2020 20:28:40 +0000 - rev 538961
Push 37576 by ncsoregi@mozilla.com at Tue, 07 Jul 2020 09:47:47 +0000
Bug 1646860 - Pioneer badge call-out on RemoteSettings update r=leplatrem Differential Revision: https://phabricator.services.mozilla.com/D82255
e89aaae327560aa0334d90a7b1a87f1eb9269f45: Bug 1646149 - Switch about:pioneer from AMO API to Remote Settings r=leplatrem
Robert Helmer <rhelmer@mozilla.com> - Thu, 25 Jun 2020 17:23:06 +0000 - rev 537653
Push 37545 by nerli@mozilla.com at Sat, 27 Jun 2020 09:38:32 +0000
Bug 1646149 - Switch about:pioneer from AMO API to Remote Settings r=leplatrem Differential Revision: https://phabricator.services.mozilla.com/D80978
bdb066a162676f51b179daa3c95e7b077c888276: Bug 1627550 - Trigger download of region maps when pref enabled r=leplatrem
Dale Harvey <dale@arandomurl.com> - Thu, 11 Jun 2020 08:10:50 +0000 - rev 535047
Push 37498 by apavel@mozilla.com at Fri, 12 Jun 2020 03:05:25 +0000
Bug 1627550 - Trigger download of region maps when pref enabled r=leplatrem Differential Revision: https://phabricator.services.mozilla.com/D78884
0db96886becffc200d806b098fb480e7957ae9e2: Bug 1641736 - Add randomizationId to ClientEnvironmentBase r=mythmon,leplatrem
Kate Hudson <k88hudson@gmail.com> - Fri, 29 May 2020 16:06:04 +0000 - rev 533040
Push 37462 by malexandru@mozilla.com at Sat, 30 May 2020 09:46:43 +0000
Bug 1641736 - Add randomizationId to ClientEnvironmentBase r=mythmon,leplatrem Differential Revision: https://phabricator.services.mozilla.com/D77393
96c36737f7284db368e3d63e3531a0aa86a9962a: Bug 1640291 - Account for last_modified in attachment downloader r=leplatrem
Rob Wu <rob@robwu.nl> - Wed, 27 May 2020 11:28:27 +0000 - rev 532577
Push 37456 by rmaries@mozilla.com at Thu, 28 May 2020 03:25:13 +0000
Bug 1640291 - Account for last_modified in attachment downloader r=leplatrem Differential Revision: https://phabricator.services.mozilla.com/D76963
32e4360d472a5c0410636a900e2a41ec75f57512: Bug 1640291 - Read RemoteSettings dump before cache, and minimize unnecessary reads r=leplatrem
Rob Wu <rob@robwu.nl> - Wed, 27 May 2020 08:00:43 +0000 - rev 532576
Push 37456 by rmaries@mozilla.com at Thu, 28 May 2020 03:25:13 +0000
Bug 1640291 - Read RemoteSettings dump before cache, and minimize unnecessary reads r=leplatrem This commit does the following: - Feature / Optimization: Check the dump before the cache, instead of the reverse. The dump is expected to match the requested attachment in the common case, and checking it first helps with ensuring that the expected (packaged dump) is used when available. - Optimization: Defer reading the cached attachment until it's needed. - Refactor / Feature: Treat a missing `.meta.json` file as a sign that the attachment dump does not exist, rather than an error. Previously, if an attachment cannot be downloaded from the network, that error would be replaced with a generic `DownloadError` (from the missing `.meta.json` file). This is mostly relevant for telemetry. - Refactor / Maintainability: Create helper to manage lazy access to the record and attachment, to ensure that the record and attachment is only read on demand, and at most once. - Refactor / Readability: Move the common return value generation logic to the helper as `getResult`, to avoid the verbose duplication of the logic. Now the return value fits in one line instead of 5-6 lines. - Fix test: Rename filename-of-dump.meta.json and fix test expectation to ensure that the test checks the absence of the file content, rather than the absence of the meta data file. Differential Revision: https://phabricator.services.mozilla.com/D76962
0833992af392073de02e74dcf8558fab974a9d4c: Bug 1640291 - Add test coverage for corrupted cache r=leplatrem
Rob Wu <rob@robwu.nl> - Wed, 27 May 2020 07:50:12 +0000 - rev 532575
Push 37456 by rmaries@mozilla.com at Thu, 28 May 2020 03:25:13 +0000
Bug 1640291 - Add test coverage for corrupted cache r=leplatrem In practice, the cache of the attachment downloader can become corrupt and unusable when IndexedDB breaks. The implementation correctly handled this case, but there were no tests that verified that it did. This patch adds test coverage for the scenario of a broken cache, to ensure that the implementation continues to behave in a sane way. Differential Revision: https://phabricator.services.mozilla.com/D76961
ddc560ee9d0206a760f89feab19169603bf1e25f: Bug 1640292 - Move RemoteSettingsWorker.checkContentHash to main thread r=leplatrem
Rob Wu <rob@robwu.nl> - Wed, 27 May 2020 13:54:37 +0000 - rev 532574
Push 37456 by rmaries@mozilla.com at Thu, 28 May 2020 03:25:13 +0000
Bug 1640292 - Move RemoteSettingsWorker.checkContentHash to main thread r=leplatrem The crypto API does most of its work on the background thread. There is no benefit in posting the buffer to a worker thread. Differential Revision: https://phabricator.services.mozilla.com/D76960
049bdaa3e410558ddcb1a71bbc26f3a16b13d0ed: Bug 1636158 - Document how to use attachment dumps in RemoteSettings r=leplatrem
Rob Wu <rob@robwu.nl> - Fri, 22 May 2020 13:09:50 +0000 - rev 531643
Push 37441 by apavel@mozilla.com at Fri, 22 May 2020 21:38:53 +0000
Bug 1636158 - Document how to use attachment dumps in RemoteSettings r=leplatrem Differential Revision: https://phabricator.services.mozilla.com/D76159
52e5c30dc235792952fd4610ed04bee5c6ee0419: Bug 1636256 - abort importJSONDump tasks in the remote settings worker at shutdown, r=leplatrem,asuth
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 11 May 2020 12:53:23 +0000 - rev 529070
Push 37404 by csabou@mozilla.com at Mon, 11 May 2020 21:47:06 +0000
Bug 1636256 - abort importJSONDump tasks in the remote settings worker at shutdown, r=leplatrem,asuth To use a single transaction for `importJSONDump`, this commit: - changes IDBHelpers' `executeIDB` method to take either a string or array pointing to `objectStore`s that the caller wants to use. - uses that from RemoteSettingsWorker to start a single transaction using both the `records` and the `timestamps` store - updates `bulkOperationHelper` to take an optional `completion` callback, in addition to the rejection callback, to be called when all the bulk operations are complete - uses that optional argument from RemoteSettingsWorker's `importDumpIDB` (the actual implementation of IDB access from `importJSONDump`) to first bulk-import the actual records, and then update the timestamp stored for that remote settings collection. Then to abort that single transaction, this commit: - stores pending transactions in a set, similar to what Database.jsm already does, and removes items from that set when the `promise` from `executeIDB` either resolves or rejects. - adds a `prepareShutdown` action on the RemoteSettingsWorker's `Agent` class, to be called by the jsm side of the worker manager when shutdown happens. When called, it iterates over the pending transactions and aborts all of them. This also sets a `gShutdown` flag. - ensures that where code `await`s in the middle of an operation, it stops (throws) immediately if `gShutdown` has been set. - adds a test to test_shutdown_handling.js to verify that this mechanism now stops pending import tasks in the worker. Finally, as a driveby, fixes an oversight in test_remote_settings_worker.js where the second `.get()` call wasn't actually testing whether the `importJSONDump` call in the worker had succeeded, because if the collection was empty it would do the import itself, which I realized when I used similar code in the shutdown test... Differential Revision: https://phabricator.services.mozilla.com/D74315
5db356e1bb9414fff740f81c03c07e9a2dfb3561: Bug 1635408 - abort non-critical RemoteSettingsWorker tasks at shutdown, r=leplatrem
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 05 May 2020 23:52:17 +0000 - rev 528311
Push 37383 by rgurzau@mozilla.com at Wed, 06 May 2020 09:37:16 +0000
Bug 1635408 - abort non-critical RemoteSettingsWorker tasks at shutdown, r=leplatrem Differential Revision: https://phabricator.services.mozilla.com/D73858
819c1fb3e5544ec5c7beaa1dfe32528267d75854: Bug 1635408 - abort non-critical RemoteSettingsWorker tasks at shutdown, r=leplatrem
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 05 May 2020 14:01:28 +0000 - rev 528140
Push 37382 by malexandru@mozilla.com at Tue, 05 May 2020 21:38:25 +0000
Bug 1635408 - abort non-critical RemoteSettingsWorker tasks at shutdown, r=leplatrem Differential Revision: https://phabricator.services.mozilla.com/D73858
c4a4b03a764749f222131f6bbbfcb0ad91c15704: Bug 1620621 - Add support for fallback to dumps for attachments r=Gijs,leplatrem
Rob Wu <rob@robwu.nl> - Thu, 30 Apr 2020 10:02:30 +0000 - rev 526916
Push 37365 by apavel@mozilla.com at Thu, 30 Apr 2020 15:50:41 +0000
Bug 1620621 - Add support for fallback to dumps for attachments r=Gijs,leplatrem With this piece, it is now possible for RemoteSettings clients to always have a valid attachment. This adds the client APIs that could support bug 1542177. Differential Revision: https://phabricator.services.mozilla.com/D72417
c0a18dbb6c502c21d36affbc8c44f5e26e4eb1c3: Bug 1620621 - Add caching and recovery mechanisms to RemoteSettings's download() method r=Gijs,leplatrem
Rob Wu <rob@robwu.nl> - Thu, 30 Apr 2020 10:02:27 +0000 - rev 526915
Push 37365 by apavel@mozilla.com at Thu, 30 Apr 2020 15:50:41 +0000
Bug 1620621 - Add caching and recovery mechanisms to RemoteSettings's download() method r=Gijs,leplatrem The current RemoteSettings API has two methods for downloading: - `download(record)` to download an attachment to disk, with a filename given by the record. The file is read and returned before downloading. A new download attempt overwrites the file, with no recovery mechanism if the download fails. - `downloadAsBytes(record)` to download an attachment in memory. The `download` method does have a cache, but it is only useful for reducing bandwidth usage, not for availability of data. Moreover, if its associated record is removed from the collection, then callers do not have a way to delete the file since its identifier (filename) originates from the record. The `downloadAsBytes` method does not have this file tracking issue since it does not persist the data, but it forces callers to implement their own attachment storing mechanism. This commit adds the `useCache` option to the `download()` method to enable callers to use an IndexedDB-based cache instead of the filesystem. The following options unlock significant features: - `fallbackToCache` - If the requested attachment is not available, the last known attachment is returned. - `fallbackToDump` - If the requested attachment is not available, nor cached, then the attachment (dump) that is packaged with the client is returned instead. This is implemented in the next commit (D72417). The original record is cached along with the attachment, to allow callers to use the file (identified by the given `attachmentId`) and its metadata, even when the original record has been removed from the collection. This is particularly useful for scenarios where one wants to keep a file (and metadata) up to date via RemoteSettings, without having to develop a separate storage and synchronization mechanism. The deprecation of the old behavior will be handled in bug 1634127. Differential Revision: https://phabricator.services.mozilla.com/D72416
e0f3e057b31145e892937ee465431d3241b80fa8: Bug 1620621 - Add support for fallback to dumps for attachments r=Gijs,leplatrem
Rob Wu <rob@robwu.nl> - Thu, 30 Apr 2020 02:48:37 +0000 - rev 526889
Push 37365 by apavel@mozilla.com at Thu, 30 Apr 2020 15:50:41 +0000
Bug 1620621 - Add support for fallback to dumps for attachments r=Gijs,leplatrem With this piece, it is now possible for RemoteSettings clients to always have a valid attachment. This adds the client APIs that could support bug 1542177. Differential Revision: https://phabricator.services.mozilla.com/D72417
12817823a3c95de80f029fe407bf1fc3f2fe4142: Bug 1620621 - Add caching and recovery mechanisms to RemoteSettings's download() method r=Gijs,leplatrem
Rob Wu <rob@robwu.nl> - Thu, 30 Apr 2020 09:02:14 +0000 - rev 526888
Push 37365 by apavel@mozilla.com at Thu, 30 Apr 2020 15:50:41 +0000
Bug 1620621 - Add caching and recovery mechanisms to RemoteSettings's download() method r=Gijs,leplatrem The current RemoteSettings API has two methods for downloading: - `download(record)` to download an attachment to disk, with a filename given by the record. The file is read and returned before downloading. A new download attempt overwrites the file, with no recovery mechanism if the download fails. - `downloadAsBytes(record)` to download an attachment in memory. The `download` method does have a cache, but it is only useful for reducing bandwidth usage, not for availability of data. Moreover, if its associated record is removed from the collection, then callers do not have a way to delete the file since its identifier (filename) originates from the record. The `downloadAsBytes` method does not have this file tracking issue since it does not persist the data, but it forces callers to implement their own attachment storing mechanism. This commit adds the `useCache` option to the `download()` method to enable callers to use an IndexedDB-based cache instead of the filesystem. The following options unlock significant features: - `fallbackToCache` - If the requested attachment is not available, the last known attachment is returned. - `fallbackToDump` - If the requested attachment is not available, nor cached, then the attachment (dump) that is packaged with the client is returned instead. This is implemented in the next commit (D72417). The original record is cached along with the attachment, to allow callers to use the file (identified by the given `attachmentId`) and its metadata, even when the original record has been removed from the collection. This is particularly useful for scenarios where one wants to keep a file (and metadata) up to date via RemoteSettings, without having to develop a separate storage and synchronization mechanism. The deprecation of the old behavior will be handled in bug 1634127. Differential Revision: https://phabricator.services.mozilla.com/D72416
62c33b392c0a655cd3065ebd3c71988c4f3f9078: Bug 1630766 - use Remote Settings instead of kinto-offline-client for remote_settings_worker sanity checks, r=leplatrem
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 30 Apr 2020 08:23:36 +0000 - rev 526880
Push 37365 by apavel@mozilla.com at Thu, 30 Apr 2020 15:50:41 +0000
Bug 1630766 - use Remote Settings instead of kinto-offline-client for remote_settings_worker sanity checks, r=leplatrem Depends on D72063 Differential Revision: https://phabricator.services.mozilla.com/D72064
fbc794579e358c3009df71e00f3987546cd0a13a: Bug 1630766 - handle abort events in Remote Settings' executeIDB and test that this works, r=asuth,leplatrem
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 30 Apr 2020 08:17:54 +0000 - rev 526878
Push 37365 by apavel@mozilla.com at Thu, 30 Apr 2020 15:50:41 +0000
Bug 1630766 - handle abort events in Remote Settings' executeIDB and test that this works, r=asuth,leplatrem This adds abort handlers to Database.jsm and RemoteSettingsWorker.js's indexedDB transactions, so we handle transaction aborts appropriately and do not leave consumers waiting forever. It also adds explicit error passing to places where we continue operating on a store via a live transaction after control flow passes back to executeIDB, because we use the `onsuccess` handler of earlier IDBRequests to run more requests in the transaction. In this case, in theory exceptions get handled by IndexedDB by invoking the abort handler on the transaction (which we do not have right now...), but as a belt-and-braces approach, it's probably better to do this explicitly. Differential Revision: https://phabricator.services.mozilla.com/D71326
90c08438be0a88acd118ff6ea0f8fd0caf164e4e: Bug 1620621 - Add support for fallback to dumps for attachments r=Gijs,leplatrem
Rob Wu <rob@robwu.nl> - Wed, 29 Apr 2020 23:08:08 +0000 - rev 526807
Push 37364 by apavel@mozilla.com at Thu, 30 Apr 2020 08:26:21 +0000
Bug 1620621 - Add support for fallback to dumps for attachments r=Gijs,leplatrem With this piece, it is now possible for RemoteSettings clients to always have a valid attachment. This adds the client APIs that could support bug 1542177. Differential Revision: https://phabricator.services.mozilla.com/D72417
723a3b4e7bbf5598238a77db246de682f4b928e9: Bug 1620621 - Add caching and recovery mechanisms to RemoteSettings's download() method r=Gijs,leplatrem
Rob Wu <rob@robwu.nl> - Wed, 29 Apr 2020 23:39:07 +0000 - rev 526806
Push 37364 by apavel@mozilla.com at Thu, 30 Apr 2020 08:26:21 +0000
Bug 1620621 - Add caching and recovery mechanisms to RemoteSettings's download() method r=Gijs,leplatrem The current RemoteSettings API has two methods for downloading: - `download(record)` to download an attachment to disk, with a filename given by the record. The file is read and returned before downloading. A new download attempt overwrites the file, with no recovery mechanism if the download fails. - `downloadAsBytes(record)` to download an attachment in memory. The `download` method does have a cache, but it is only useful for reducing bandwidth usage, not for availability of data. Moreover, if its associated record is removed from the collection, then callers do not have a way to delete the file since its identifier (filename) originates from the record. The `downloadAsBytes` method does not have this file tracking issue since it does not persist the data, but it forces callers to implement their own attachment storing mechanism. This commit adds the `useCache` option to the `download()` method to enable callers to use an IndexedDB-based cache instead of the filesystem. The following options unlock significant features: - `fallbackToCache` - If the requested attachment is not available, the last known attachment is returned. - `fallbackToDump` - If the requested attachment is not available, nor cached, then the attachment (dump) that is packaged with the client is returned instead. This is implemented in the next commit (D72417). The original record is cached along with the attachment, to allow callers to use the file (identified by the given `attachmentId`) and its metadata, even when the original record has been removed from the collection. This is particularly useful for scenarios where one wants to keep a file (and metadata) up to date via RemoteSettings, without having to develop a separate storage and synchronization mechanism. The deprecation of the old behavior will be handled in bug 1634127. Differential Revision: https://phabricator.services.mozilla.com/D72416
22a36b11aa1aa9c48817a41d16da6a91242c76bc: Bug 1624301 - optimize remote settings Database list calls without filters, r=leplatrem
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 23 Apr 2020 16:19:27 +0000 - rev 525640
Push 37341 by cbrindusan@mozilla.com at Thu, 23 Apr 2020 21:43:09 +0000
Bug 1624301 - optimize remote settings Database list calls without filters, r=leplatrem Differential Revision: https://phabricator.services.mozilla.com/D72137
faf910a5ca7011d37fb1a76f4d4b41c14cb339d8: Bug 1631484 - make bulk imports / deletes in remote settings faster, r=asuth,leplatrem
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 22 Apr 2020 00:04:19 +0000 - rev 525339
Push 37337 by ccoroiu@mozilla.com at Wed, 22 Apr 2020 16:35:21 +0000
Bug 1631484 - make bulk imports / deletes in remote settings faster, r=asuth,leplatrem Differential Revision: https://phabricator.services.mozilla.com/D71588
8559ad2eaf2ae14576537657aa7700e18ec11042: Bug 1627179 - ensure we deal with transaction.abort() throwing r=leplatrem
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 03 Apr 2020 13:17:38 +0000 - rev 522001
Push 37281 by btara@mozilla.com at Sat, 04 Apr 2020 09:29:13 +0000
Bug 1627179 - ensure we deal with transaction.abort() throwing r=leplatrem Differential Revision: https://phabricator.services.mozilla.com/D69511
7312dfafef584fae2a15388e76e069caabbfa8d5: Bug 1624983 - abort pending read transactions from the DB when quitting, r=asuth,leplatrem
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 02 Apr 2020 14:40:33 +0000 - rev 521860
Push 37275 by shindli@mozilla.com at Fri, 03 Apr 2020 01:02:14 +0000
Bug 1624983 - abort pending read transactions from the DB when quitting, r=asuth,leplatrem Differential Revision: https://phabricator.services.mozilla.com/D68465
15a52d0bf11640e0fbbbd30c09d7a7e822e0524a: Bug 1624983 - abort pending read transactions from the DB when quitting, r=asuth,leplatrem
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 27 Mar 2020 16:05:00 +0000 - rev 520763
Push 37259 by dluca@mozilla.com at Sat, 28 Mar 2020 09:32:56 +0000
Bug 1624983 - abort pending read transactions from the DB when quitting, r=asuth,leplatrem Differential Revision: https://phabricator.services.mozilla.com/D68465
354489628b3985c7dc385f039f763b15c05ccec7: Bug 1598924 - make remote settings handle shutdown gracefully, r=leplatrem,asuth
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 24 Mar 2020 14:55:41 +0000 - rev 520221
Push 37245 by opoprus@mozilla.com at Tue, 24 Mar 2020 21:46:41 +0000
Bug 1598924 - make remote settings handle shutdown gracefully, r=leplatrem,asuth By and large, this change accomplishes two things: 1. Run db.close() in finally clauses so that even if db access fails, we close our connections. It also tries to avoid waiting on other, non-DB operations before calling close, to avoid the DB connection needlessly hanging around. 2. Intercept all async database operations from the remote settings client to kinto and ensuring they complete before the end of `profile-before-change`. Any operations started after Services.startup.isShuttingDown (so after quit/restart is initiated by the user) will throw. Operations started beforehand are put in a set of operations, and remove themselves once complete. We AsyncShutdown block on that set of operations completing. Differential Revision: https://phabricator.services.mozilla.com/D66995
3b7ccffc05460949c4d5503ae2acd800eb0b8364: Bug 1598924 - make remote settings handle shutdown gracefully, r=leplatrem,asuth
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 23 Mar 2020 16:35:08 +0000 - rev 520116
Push 37243 by shindli@mozilla.com at Tue, 24 Mar 2020 03:03:23 +0000
Bug 1598924 - make remote settings handle shutdown gracefully, r=leplatrem,asuth By and large, this change accomplishes two things: 1. Run db.close() in finally clauses so that even if db access fails, we close our connections. It also tries to avoid waiting on other, non-DB operations before calling close, to avoid the DB connection needlessly hanging around. 2. Intercept all async database operations from the remote settings client to kinto and ensuring they complete before the end of `profile-before-change`. Any operations started after Services.startup.isShuttingDown (so after quit/restart is initiated by the user) will throw. Operations started beforehand are put in a set of operations, and remove themselves once complete. We AsyncShutdown block on that set of operations completing. Differential Revision: https://phabricator.services.mozilla.com/D66995
ade1286ccf20b2c2acb7e10c92644bb3cc64dc37: Bug 1607894 - Add debugging assert to Normandy test for intermittent r=leplatrem
Michael Cooper <mcooper@mozilla.com> - Fri, 06 Mar 2020 17:47:12 +0000 - rev 517277
Push 37189 by cbrindusan@mozilla.com at Sat, 07 Mar 2020 09:32:21 +0000
Bug 1607894 - Add debugging assert to Normandy test for intermittent r=leplatrem Differential Revision: https://phabricator.services.mozilla.com/D63936
e385c9242708eb4cae1fd0dfe200874c71b20423: Bug 1607894 - Add debugging assert to Normandy test for intermittent r=leplatrem
Michael Cooper <mcooper@mozilla.com> - Tue, 25 Feb 2020 11:15:33 +0000 - rev 515781
Push 37162 by nbeleuzu@mozilla.com at Thu, 27 Feb 2020 09:49:56 +0000
Bug 1607894 - Add debugging assert to Normandy test for intermittent r=leplatrem Differential Revision: https://phabricator.services.mozilla.com/D63936
7f51f4442842647d44dbd6bc36c4d39e9f3a69a9: Bug 1617011 - handle errors in get()/list() when they get called in the middle of shutdown, r=leplatrem
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 26 Feb 2020 14:42:52 +0000 - rev 515655
Push 37160 by aciure@mozilla.com at Wed, 26 Feb 2020 21:39:03 +0000
Bug 1617011 - handle errors in get()/list() when they get called in the middle of shutdown, r=leplatrem Differential Revision: https://phabricator.services.mozilla.com/D64329
69f48c79c9f02be1944af0c6ebbcdca97ffb83c1: Bug 1615450 - Add `Services.appinfo` to JEXL filter context r=leplatrem
Michael Cooper <mcooper@mozilla.com> - Wed, 19 Feb 2020 18:04:39 +0000 - rev 514632
Push 37140 by malexandru@mozilla.com at Thu, 20 Feb 2020 09:35:08 +0000
Bug 1615450 - Add `Services.appinfo` to JEXL filter context r=leplatrem Differential Revision: https://phabricator.services.mozilla.com/D62839
fa39628146a6895acafe694066cc82be86196d11: Bug 1606883 - Remove legacy method of fetching Normandy recipes directly from the server r=leplatrem
Michael Cooper <mcooper@mozilla.com> - Mon, 13 Jan 2020 17:24:50 +0000 - rev 509977
Push 37012 by apavel@mozilla.com at Tue, 14 Jan 2020 03:45:02 +0000
Bug 1606883 - Remove legacy method of fetching Normandy recipes directly from the server r=leplatrem Differential Revision: https://phabricator.services.mozilla.com/D58651
a4eb4001b5ac7660600764fe0a6136b0ea1be897: Bug 1606883 - Remove legacy method of fetching Normandy recipes directly from the server r=leplatrem
Michael Cooper <mcooper@mozilla.com> - Fri, 10 Jan 2020 21:52:56 +0000 - rev 509825
Push 37004 by shindli@mozilla.com at Sat, 11 Jan 2020 09:48:29 +0000
Bug 1606883 - Remove legacy method of fetching Normandy recipes directly from the server r=leplatrem Differential Revision: https://phabricator.services.mozilla.com/D58651
4c4f32adf0451ac85d99989bb92eef4d0eb49461: Bug 1606883 - Remove legacy method of fetching Normandy recipes directly from the server r=leplatrem
Michael Cooper <mcooper@mozilla.com> - Tue, 07 Jan 2020 17:04:01 +0000 - rev 509423
Push 36996 by apavel@mozilla.com at Thu, 09 Jan 2020 03:40:18 +0000
Bug 1606883 - Remove legacy method of fetching Normandy recipes directly from the server r=leplatrem Differential Revision: https://phabricator.services.mozilla.com/D58651
d66517bc41f0fc49451d02cdc6b616ae8db2a436: bug 1603833 - re-purpose unused intermediate preloading failure telemetry categories to investigate failures r=kjacobs,leplatrem
Dana Keeler <dkeeler@mozilla.com> - Thu, 19 Dec 2019 10:29:57 +0000 - rev 507876
Push 36932 by aciure@mozilla.com at Thu, 19 Dec 2019 21:52:02 +0000
bug 1603833 - re-purpose unused intermediate preloading failure telemetry categories to investigate failures r=kjacobs,leplatrem Intermediate preloading telemetry is overwhelmingly "failedToObserve", which at the moment is a catch-all indicating that something in updatePreloadedIntermediates failed. We need to figure out why, so this patch re-purposes the categories "emptyAttachment", "failedToFetch", and "unexpectedLength", which are currently not used, to indicate failures in specific sub-operations in that function. Differential Revision: https://phabricator.services.mozilla.com/D57676
7cfb4262cf1ce4416ef80ed374e6f70d2578e96e: Bug 1594521 - avoid instantiating remote settings worker after shutdown, r=leplatrem,asuth
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 19 Nov 2019 15:14:07 +0000 - rev 502618
Push 36819 by ffxbld at Tue, 19 Nov 2019 21:20:10 +0000
Bug 1594521 - avoid instantiating remote settings worker after shutdown, r=leplatrem,asuth Differential Revision: https://phabricator.services.mozilla.com/D53751
29b831ba782de6ee59b707b829bf7cbd854ced74: Bug 1589410 - fix how remote-settings blocklist handles the absence of a `blockID` property in the blocklist entry, r=leplatrem
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 18 Oct 2019 20:55:56 +0000 - rev 498268
Push 36709 by aiakab@mozilla.com at Sat, 19 Oct 2019 09:53:21 +0000
Bug 1589410 - fix how remote-settings blocklist handles the absence of a `blockID` property in the blocklist entry, r=leplatrem Differential Revision: https://phabricator.services.mozilla.com/D49673
e1a1b2085ee21cd5a02cd69c6f7b56185841f8da: Bug 1584368 - Fetch Normandy recipes from capabilities-aware locations r=Gijs,leplatrem
Michael Cooper <mcooper@mozilla.com> - Tue, 15 Oct 2019 19:28:04 +0000 - rev 497713
Push 36695 by csabou@mozilla.com at Wed, 16 Oct 2019 05:20:00 +0000
Bug 1584368 - Fetch Normandy recipes from capabilities-aware locations r=Gijs,leplatrem This indicates to the Normandy server that this client understands the capabilities model, which is used for backwards compatibility. Without this change, the server will only send recipes that are compatible with the functionality that existed in Firefox 70, and other recipes will not be included. With this change, we'll get the full picture of recipe. Differential Revision: https://phabricator.services.mozilla.com/D48448
2751ade4931f6ccadd26f014f0d1f6fbc2a8e4c4: Bug 1581160 - Part 2: Do not prevent the local database from being checked in UrlClassifierSkipListService.jsm; r=johannh,leplatrem
Ehsan Akhgari <ehsan@mozilla.com> - Mon, 16 Sep 2019 21:48:26 +0000 - rev 493445
Push 36582 by rgurzau@mozilla.com at Tue, 17 Sep 2019 09:36:29 +0000
Bug 1581160 - Part 2: Do not prevent the local database from being checked in UrlClassifierSkipListService.jsm; r=johannh,leplatrem Differential Revision: https://phabricator.services.mozilla.com/D46029
92ed48a0afb31560c9d51d29e8d9760bfc10cb52: Bug 1581160 - Part 2: Do not prevent the local database from being checked in UrlClassifierSkipListService.jsm; r=johannh,leplatrem
Ehsan Akhgari <ehsan@mozilla.com> - Mon, 16 Sep 2019 15:02:06 +0000 - rev 493367
Push 36581 by shindli@mozilla.com at Tue, 17 Sep 2019 04:35:35 +0000
Bug 1581160 - Part 2: Do not prevent the local database from being checked in UrlClassifierSkipListService.jsm; r=johannh,leplatrem Differential Revision: https://phabricator.services.mozilla.com/D46029
97189ab333717f28d909f50efcde7832a0a388f6: Bug 1581160 - Prepackage url-classifier-skip-urls into the binaries; r=leplatrem,glasserc
Ehsan Akhgari <ehsan@mozilla.com> - Fri, 13 Sep 2019 16:26:57 +0000 - rev 493083
Push 36572 by dvarga@mozilla.com at Fri, 13 Sep 2019 21:44:59 +0000
Bug 1581160 - Prepackage url-classifier-skip-urls into the binaries; r=leplatrem,glasserc Differential Revision: https://phabricator.services.mozilla.com/D45871
83644c7869d240531503433b780c4e7c1303d457: Bug 1580273 - Add the needed head files to support-files; r=leplatrem
Ehsan Akhgari <ehsan@mozilla.com> - Fri, 13 Sep 2019 09:55:59 +0000 - rev 493072
Push 36572 by dvarga@mozilla.com at Fri, 13 Sep 2019 21:44:59 +0000
Bug 1580273 - Add the needed head files to support-files; r=leplatrem Differential Revision: https://phabricator.services.mozilla.com/D45409
1d6442adb7b916d5cf9da755a99149d29409eae9: Bug 1578885 - use AttributionCode directly from ClientEnvironment, rather than Telemetry r=leplatrem
Robert Helmer <rhelmer@mozilla.com> - Fri, 13 Sep 2019 14:21:14 +0000 - rev 493067
Push 36572 by dvarga@mozilla.com at Fri, 13 Sep 2019 21:44:59 +0000
Bug 1578885 - use AttributionCode directly from ClientEnvironment, rather than Telemetry r=leplatrem Differential Revision: https://phabricator.services.mozilla.com/D45433