searching for reviewer(kvark)
7c911a7be80e21eef29b4fe3485abcdfbd1433bf: Bug 1560499 - Fix subpixel detection for transparent tile caches. r=kvark
Glenn Watson <github@intuitionlibrary.com> - Mon, 24 Jun 2019 17:32:36 +0000 - rev 479978
Push 36197 by aciure@mozilla.com at Tue, 25 Jun 2019 09:39:03 +0000
Bug 1560499 - Fix subpixel detection for transparent tile caches. r=kvark Some pages from Gecko produce a display list for the main content tile cache that has a transparent background. Detect these cases and disable subpixel text rendering to ensure correct blending. Differential Revision: https://phabricator.services.mozilla.com/D35627
72d858dcdb26047b09afc9cda33c18dc14b44b52: Bug 1519598 - Add a mach command to import PRs from github. r=kvark,ahal
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 24 Jun 2019 20:30:32 +0000 - rev 479970
Push 36197 by aciure@mozilla.com at Tue, 25 Jun 2019 09:39:03 +0000
Bug 1519598 - Add a mach command to import PRs from github. r=kvark,ahal This is a simple mach command that imports a PR from a whitelisted set of github repositories into the local m-c clone. It works by downloading the .patch file from github, splitting the different commits, and applying those commits to the local repo via the `patch` tool and git/hg commit. It optionally allows filing a bug or providing a bug number, and specifying a reviewer. This is one part of a larger workflow that facilitates landing contributor patches into m-c when those patches are submitted as PRs. Other components of the workflow (to be added in the future) will make it easier to actually test and land the patch. Differential Revision: https://phabricator.services.mozilla.com/D35206
33ef5e8d04f8a28ce8f6c6ba35ee6ec37babb97d: Bug 1559295 - Support multiple picture cache tile sizes in WR texture cache. r=kvark
Glenn Watson <github@intuitionlibrary.com> - Wed, 19 Jun 2019 15:46:18 +0000 - rev 479210
Push 36174 by opoprus@mozilla.com at Wed, 19 Jun 2019 21:38:13 +0000
Bug 1559295 - Support multiple picture cache tile sizes in WR texture cache. r=kvark In future, picture cache tiles will support different sizes, depending on the size of the content slice being cached, and how frequently parts of the slice are changing. Although currently unused, this patch adds support for specifying multiple different tile sizes for the picture cache texture array. Differential Revision: https://phabricator.services.mozilla.com/D34989
be881e8aa8d9e12d4a78e2116c9750f1d8d24049: Bug 1559295 - Support multiple picture cache tile sizes in WR texture cache. r=kvark
Glenn Watson <github@intuitionlibrary.com> - Fri, 14 Jun 2019 19:38:34 +0000 - rev 479204
Push 36174 by opoprus@mozilla.com at Wed, 19 Jun 2019 21:38:13 +0000
Bug 1559295 - Support multiple picture cache tile sizes in WR texture cache. r=kvark In future, picture cache tiles will support different sizes, depending on the size of the content slice being cached, and how frequently parts of the slice are changing. Although currently unused, this patch adds support for specifying multiple different tile sizes for the picture cache texture array. Differential Revision: https://phabricator.services.mozilla.com/D34989
11f0e1ee8f0c9ec82c81ed842fc68402429d4441: Bug 1559535 - Fix crash related to mismatched clips with picture caching. r=kvark
Glenn Watson <github@intuitionlibrary.com> - Wed, 19 Jun 2019 08:40:27 +0000 - rev 479195
Push 36173 by rgurzau@mozilla.com at Wed, 19 Jun 2019 15:50:11 +0000
Bug 1559535 - Fix crash related to mismatched clips with picture caching. r=kvark Fixes an edge case where splitting the top level primitive list for picture caching may result in a mismatched push/pop clip pair. This is not a particularly efficient fix, but it's a rare enough edge case for now that this fix will be good enough until we work out the long term solution for the push/pop clip chain instances. Differential Revision: https://phabricator.services.mozilla.com/D35139
501698e75525e076352bc02bfcb22a8b5ddf8d85: Bug 1556763 - Add layout qualifier to fragment shader output for advanced blend. r=kvark
Jamie Nicol <jnicol@mozilla.com> - Sat, 15 Jun 2019 11:56:14 +0000 - rev 479032
Push 36157 by shindli@mozilla.com at Sat, 15 Jun 2019 21:44:24 +0000
Bug 1556763 - Add layout qualifier to fragment shader output for advanced blend. r=kvark When using an advanced blend equation, fragment shader output must be marked with a matching layout qualifier. Not doing so was causing subsequent glDraw* operations to fail. This patch adds a new shader feature, WR_FEATURE_ADVANCED_BLEND, which requires the necessary extension and adds the qualifier. Variants of the brush_image shaders are created with this feature, and are used whenever a brush_image shader is requested for BlendMode::Advanced. Differential Revision: https://phabricator.services.mozilla.com/D34617
431c5142ff3ad102328d90cb29470b20ccd1271e: Bug 1558106 - Support picture caching for multiple scroll roots. r=kvark
Glenn Watson <github@intuitionlibrary.com> - Thu, 13 Jun 2019 04:43:56 +0000 - rev 478631
Push 36148 by shindli@mozilla.com at Thu, 13 Jun 2019 21:50:57 +0000
Bug 1558106 - Support picture caching for multiple scroll roots. r=kvark This patch implements the majority of the planned picture caching improvements. It supports most of the functionality required to (as a follow up) support OS compositor integration. It also improves on the robustness and functionality of the previous picture caching implementation. There are some expected temporary performance regressions in some cases (such as content that is constantly invalidating) and during initial page render when many render targets must be drawn to. These performance regressions will be resolved in follow up commits by supporting multi-resolution tiles. The scene is split into a number of slices, determined by the scroll root of each primitive, which can be found by the primitive's spatial node indices. If a scene contains too many slices, then picture caching is disabled on the page, to avoid excessive texture memory usage, and rendering falls back to rasterizing each frame. The specific changes in this patch are: * Support tile caches for multiple scroll roots, allowing the entire page (including fixed divs and the main UI bar) to be cached in most cases, in addition to the main content. * Remove requirement to read tiles back from the framebuffer. Instead, they are drawn into the picture cache target tiles, and blitted to the screen. This is slightly slower than the existing picture caching when content is constantly changing, however this cost will disappear / become irrelevant when the OS compositor integration work is complete. * Switch picture cache render targets to be nearest sampled (they are always rendered 1:1) and support depth buffer targets. * Make use of the external scroll offset support to allow removal of the primitive correlation hacks in the previous picture caching implementation. Also allows storing of primitive dependencies in picture space rather than world space, which reduces floating point inaccuracies. * Determine if each tile and picture cache can be considered opaque. This is used to determine whether subpixel AA text rendering is available on a slice, and for rendering optimizations related to disabling blending and/or tile clears. * Use the clip chain instance results from the recent visibility pass work to determine clip chain dependencies. This results in fewer clip item dependencies in tiles, which is faster to check validity and reduces redundant invalidations. * Remove extra overhead during batching related to batch lists, and region iteration, as they are no longer required. * Support PrimitiveVisibilityMask during batching. This allows a single traversal of a picture (surface) root during batching to efficiently construct multiple alpha batcher objects (typically one per invalida tile). * Picture caching is now handled implicitly by WR, depending on the content of the scene. There is no requirement for client code to manually select which stacking context should be cached. * Simplify how clip chain / transform dependencies are tracked by picture cache tiles. * Support pushing / popping enclosing clip chain roots without the need for a stacking context / picture in some cases. This simplifies the logic to split the scene into multiple slices. The main remaining work in this area is (a) extend the code to optionally provide each slice as an input to the OS compositor rather than drawing the tiles in WR, and (b) support multi-resolution tiles so that we reduce the draw call, batching and render target overhead in cases where much of the page content is changing. Differential Revision: https://phabricator.services.mozilla.com/D34319
19764943976509e21bb37ae61a88120dd11046d9: Bug 1557721 - Use unwrap_or_default where possible. r=kvark
Bruce Mitchener <bruce.mitchener@gmail.com> - Fri, 07 Jun 2019 16:19:22 +0000 - rev 477884
Push 36125 by apavel@mozilla.com at Fri, 07 Jun 2019 22:00:07 +0000
Bug 1557721 - Use unwrap_or_default where possible. r=kvark [wrupdater] From https://github.com/servo/webrender/pull/3667 Depends on D34166 Differential Revision: https://phabricator.services.mozilla.com/D34167
6569dc72b7f9d3c8094b469141cf9a7856f38149: Bug 1557721 - Remove redundant closure. r=kvark
Bruce Mitchener <bruce.mitchener@gmail.com> - Fri, 07 Jun 2019 16:19:14 +0000 - rev 477883
Push 36125 by apavel@mozilla.com at Fri, 07 Jun 2019 22:00:07 +0000
Bug 1557721 - Remove redundant closure. r=kvark [wrupdater] From https://github.com/servo/webrender/pull/3667 Depends on D34165 Differential Revision: https://phabricator.services.mozilla.com/D34166
64ea2a3f0d4dd88bd83a03b811ecf4197a2723c8: Bug 1557721 - Simplify boolean expression. r=kvark
Bruce Mitchener <bruce.mitchener@gmail.com> - Fri, 07 Jun 2019 16:18:25 +0000 - rev 477882
Push 36125 by apavel@mozilla.com at Fri, 07 Jun 2019 22:00:07 +0000
Bug 1557721 - Simplify boolean expression. r=kvark [wrupdater] From https://github.com/servo/webrender/pull/3667 Depends on D34164 Differential Revision: https://phabricator.services.mozilla.com/D34165
5d31dd07595a0485d74f4653dbaf2aed5e38ac10: Bug 1557721 - Use or_insert_with where possible. r=kvark
Bruce Mitchener <bruce.mitchener@gmail.com> - Fri, 07 Jun 2019 16:17:52 +0000 - rev 477881
Push 36125 by apavel@mozilla.com at Fri, 07 Jun 2019 22:00:07 +0000
Bug 1557721 - Use or_insert_with where possible. r=kvark [wrupdater] From https://github.com/servo/webrender/pull/3667 Depends on D34162 Differential Revision: https://phabricator.services.mozilla.com/D34164
1d9c323e12cef1ee5878bc65c4ad8cd17bd9a889: Bug 1557721 - Remove redundant field names. r=kvark
Bruce Mitchener <bruce.mitchener@gmail.com> - Fri, 07 Jun 2019 16:17:29 +0000 - rev 477880
Push 36125 by apavel@mozilla.com at Fri, 07 Jun 2019 22:00:07 +0000
Bug 1557721 - Remove redundant field names. r=kvark [wrupdater] From https://github.com/servo/webrender/pull/3667 Depends on D34161 Differential Revision: https://phabricator.services.mozilla.com/D34162
a18263c690b31c1629fed59b67300730ad0dd2e5: Bug 1557721 - Use unwrap_or_else where possible. r=kvark
Bruce Mitchener <bruce.mitchener@gmail.com> - Fri, 07 Jun 2019 16:17:07 +0000 - rev 477879
Push 36125 by apavel@mozilla.com at Fri, 07 Jun 2019 22:00:07 +0000
Bug 1557721 - Use unwrap_or_else where possible. r=kvark [wrupdater] From https://github.com/servo/webrender/pull/3667 Depends on D34160 Differential Revision: https://phabricator.services.mozilla.com/D34161
df0f7465489c6724f3f10545b1f17f07febceb4b: Bug 1557721 - Remove identical conversion. r=kvark
Bruce Mitchener <bruce.mitchener@gmail.com> - Fri, 07 Jun 2019 16:16:12 +0000 - rev 477878
Push 36125 by apavel@mozilla.com at Fri, 07 Jun 2019 22:00:07 +0000
Bug 1557721 - Remove identical conversion. r=kvark [wrupdater] From https://github.com/servo/webrender/pull/3667 Depends on D34159 Differential Revision: https://phabricator.services.mozilla.com/D34160
f3ff3843ce7d12f94463fc6ad5ef53b2c38e3916: Bug 1557721 - Remove unneeded return statement. r=kvark
Bruce Mitchener <bruce.mitchener@gmail.com> - Fri, 07 Jun 2019 16:15:55 +0000 - rev 477877
Push 36125 by apavel@mozilla.com at Fri, 07 Jun 2019 22:00:07 +0000
Bug 1557721 - Remove unneeded return statement. r=kvark [wrupdater] From https://github.com/servo/webrender/pull/3667 Differential Revision: https://phabricator.services.mozilla.com/D34159
b50cc27685799e82400e75b7823efb90b4705808: Bug 1474294 - Add reftest for a box-shadow in perspective transform without preserve-3d. r=kvark
Alexis Beingessner <a.beingessner@gmail.com> - Fri, 07 Jun 2019 14:40:30 +0000 - rev 477852
Push 36125 by apavel@mozilla.com at Fri, 07 Jun 2019 22:00:07 +0000
Bug 1474294 - Add reftest for a box-shadow in perspective transform without preserve-3d. r=kvark Differential Revision: https://phabricator.services.mozilla.com/D30980
d0a95f14f1fe4a7a347ccbb87de1f67c9135661f: Bug 1555827. Disable disabling blob invalidation. r=kvark
Jeff Muizelaar <jrmuizel@gmail.com> - Fri, 31 May 2019 19:07:17 +0000 - rev 476446
Push 36095 by dvarga@mozilla.com at Sat, 01 Jun 2019 09:40:47 +0000
Bug 1555827. Disable disabling blob invalidation. r=kvark Not using blob invalidation is broken. Having this pref accidentally flipped has wasted multiple people's time. Differential Revision: https://phabricator.services.mozilla.com/D33327
ced6621fcb1b3e02bb6d5ac4903887760a671c6f: Bug 1551735 - Add a thread-safe composition recorder for WebRender r=kvark,kats
Barret Rennie <barret@brennie.ca> - Fri, 31 May 2019 00:31:24 +0000 - rev 476296
Push 36090 by nbeleuzu@mozilla.com at Fri, 31 May 2019 03:59:09 +0000
Bug 1551735 - Add a thread-safe composition recorder for WebRender r=kvark,kats Since WebRender does its rendering on a separate thread from the compositor thread, we need a composition recorder that can be shared between threads. Differential Revision: https://phabricator.services.mozilla.com/D32231
58dd508e43e6932b4606865282967f57927b757c: Bug 1551735 - Expose bindings to the Renderer's composition recorder structures r=kvark
Barret Rennie <barret@brennie.ca> - Fri, 31 May 2019 00:31:05 +0000 - rev 476295
Push 36090 by nbeleuzu@mozilla.com at Fri, 31 May 2019 03:59:09 +0000
Bug 1551735 - Expose bindings to the Renderer's composition recorder structures r=kvark Differential Revision: https://phabricator.services.mozilla.com/D32233
b09d27fc1584716e7b31b68f4f4830336076f3d7: Bug 1551735 - Add a mode to the AsyncScreenshotGrabber to enable composition recording r=kvark
Barret Rennie <barret@brennie.ca> - Fri, 31 May 2019 00:30:52 +0000 - rev 476294
Push 36090 by nbeleuzu@mozilla.com at Fri, 31 May 2019 03:59:09 +0000
Bug 1551735 - Add a mode to the AsyncScreenshotGrabber to enable composition recording r=kvark The AsyncScreenshotGrabber now can operate in two modes: * `ProfilerScreenshots`, which does asynchronous scaling of the captured frames for inclusion in profiles by the Gecko Profiler; and * `CompositionRecorder`, which does not do any scaling and is used for visual metrics computations. The latter mode is exposed by on the `Renderer` via the `record_frame`, `map_recorded_frame`, and `release_composition_recorder_structures` methods. A different handle type (`RecordedFrameHandle`) is returned and consumed by these functions, but they translate between `RecordedFrameHandle` and `AsyncScreenshotHandle` when communicating with the underlying `AsyncScreenshotGrabber`. I considered making the `AsyncScreenshotGrabber` generic over its handle type, but the extra cost of monomorphization just to change the handle type did not seem worth it. Differential Revision: https://phabricator.services.mozilla.com/D32232
caca3a7d4c2f4468bf5503cbde79576f06aa7a10: Bug 1551735 - Split out screenshot grabbing infrasturcture into a new module r=kvark
Barret Rennie <barret@brennie.ca> - Fri, 31 May 2019 00:30:37 +0000 - rev 476293
Push 36090 by nbeleuzu@mozilla.com at Fri, 31 May 2019 03:59:09 +0000
Bug 1551735 - Split out screenshot grabbing infrasturcture into a new module r=kvark Differential Revision: https://phabricator.services.mozilla.com/D32523
9deb5350e244951200b6d1c1411b281b4afcc9f8: Bug 1551735 - Add a thread-safe composition recorder for WebRender r=kvark,kats
Barret Rennie <barret@brennie.ca> - Thu, 30 May 2019 20:32:42 +0000 - rev 476276
Push 36090 by nbeleuzu@mozilla.com at Fri, 31 May 2019 03:59:09 +0000
Bug 1551735 - Add a thread-safe composition recorder for WebRender r=kvark,kats Since WebRender does its rendering on a separate thread from the compositor thread, we need a composition recorder that can be shared between threads. Differential Revision: https://phabricator.services.mozilla.com/D32231
6154bdfe6fad96980583857e001187abb84f3c18: Bug 1551735 - Expose bindings to the Renderer's composition recorder structures r=kvark
Barret Rennie <barret@brennie.ca> - Thu, 30 May 2019 20:18:23 +0000 - rev 476275
Push 36090 by nbeleuzu@mozilla.com at Fri, 31 May 2019 03:59:09 +0000
Bug 1551735 - Expose bindings to the Renderer's composition recorder structures r=kvark Differential Revision: https://phabricator.services.mozilla.com/D32233
4a0936bda490634eaf51cb1c9f89f9df2bcdc2e9: Bug 1551735 - Add a mode to the AsyncScreenshotGrabber to enable composition recording r=kvark
Barret Rennie <barret@brennie.ca> - Thu, 30 May 2019 20:18:09 +0000 - rev 476274
Push 36090 by nbeleuzu@mozilla.com at Fri, 31 May 2019 03:59:09 +0000
Bug 1551735 - Add a mode to the AsyncScreenshotGrabber to enable composition recording r=kvark The AsyncScreenshotGrabber now can operate in two modes: * `ProfilerScreenshots`, which does asynchronous scaling of the captured frames for inclusion in profiles by the Gecko Profiler; and * `CompositionRecorder`, which does not do any scaling and is used for visual metrics computations. The latter mode is exposed by on the `Renderer` via the `record_frame`, `map_recorded_frame`, and `release_composition_recorder_structures` methods. A different handle type (`RecordedFrameHandle`) is returned and consumed by these functions, but they translate between `RecordedFrameHandle` and `AsyncScreenshotHandle` when communicating with the underlying `AsyncScreenshotGrabber`. I considered making the `AsyncScreenshotGrabber` generic over its handle type, but the extra cost of monomorphization just to change the handle type did not seem worth it. Differential Revision: https://phabricator.services.mozilla.com/D32232
a7868d694fe115c432015a01be88cf44d88308d9: Bug 1551735 - Split out screenshot grabbing infrasturcture into a new module r=kvark
Barret Rennie <barret@brennie.ca> - Thu, 30 May 2019 20:17:52 +0000 - rev 476273
Push 36090 by nbeleuzu@mozilla.com at Fri, 31 May 2019 03:59:09 +0000
Bug 1551735 - Split out screenshot grabbing infrasturcture into a new module r=kvark Differential Revision: https://phabricator.services.mozilla.com/D32523
57861a1ded5abaf82a1b4e7c95a0bd1bf60f62a0: Bug 1536240 - Add debug option to wrench to output specified shader source r=kvark
Connor Brewster <cbrewster@mozilla.com> - Thu, 30 May 2019 19:28:10 +0000 - rev 476265
Push 36090 by nbeleuzu@mozilla.com at Fri, 31 May 2019 03:59:09 +0000
Bug 1536240 - Add debug option to wrench to output specified shader source r=kvark Differential Revision: https://phabricator.services.mozilla.com/D33088
f2a2396a0d4a63b57a9ca072c67d9e4235cf0d20: Bug 1551735 - Add a thread-safe composition recorder for WebRender r=kvark,kats
Barret Rennie <barret@brennie.ca> - Thu, 30 May 2019 13:06:43 +0000 - rev 476257
Push 36090 by nbeleuzu@mozilla.com at Fri, 31 May 2019 03:59:09 +0000
Bug 1551735 - Add a thread-safe composition recorder for WebRender r=kvark,kats Since WebRender does its rendering on a separate thread from the compositor thread, we need a composition recorder that can be shared between threads. Differential Revision: https://phabricator.services.mozilla.com/D32231
5891d00fca8535e64c6009860e93132c6ce44a6f: Bug 1551735 - Expose bindings to the Renderer's composition recorder structures r=kvark
Barret Rennie <barret@brennie.ca> - Wed, 29 May 2019 21:52:57 +0000 - rev 476256
Push 36090 by nbeleuzu@mozilla.com at Fri, 31 May 2019 03:59:09 +0000
Bug 1551735 - Expose bindings to the Renderer's composition recorder structures r=kvark Differential Revision: https://phabricator.services.mozilla.com/D32233
2e6ca6d6c527229f7a8e7d96e1616c8aeda2d0d2: Bug 1551735 - Add a mode to the AsyncScreenshotGrabber to enable composition recording r=kvark
Barret Rennie <barret@brennie.ca> - Wed, 29 May 2019 21:52:44 +0000 - rev 476255
Push 36090 by nbeleuzu@mozilla.com at Fri, 31 May 2019 03:59:09 +0000
Bug 1551735 - Add a mode to the AsyncScreenshotGrabber to enable composition recording r=kvark The AsyncScreenshotGrabber now can operate in two modes: * `ProfilerScreenshots`, which does asynchronous scaling of the captured frames for inclusion in profiles by the Gecko Profiler; and * `CompositionRecorder`, which does not do any scaling and is used for visual metrics computations. The latter mode is exposed by on the `Renderer` via the `record_frame`, `map_recorded_frame`, and `release_composition_recorder_structures` methods. A different handle type (`RecordedFrameHandle`) is returned and consumed by these functions, but they translate between `RecordedFrameHandle` and `AsyncScreenshotHandle` when communicating with the underlying `AsyncScreenshotGrabber`. I considered making the `AsyncScreenshotGrabber` generic over its handle type, but the extra cost of monomorphization just to change the handle type did not seem worth it. Differential Revision: https://phabricator.services.mozilla.com/D32232
3b2078f907151398e4e55a9276fddef213c48416: Bug 1551735 - Split out screenshot grabbing infrasturcture into a new module r=kvark
Barret Rennie <barret@brennie.ca> - Wed, 29 May 2019 21:52:25 +0000 - rev 476254
Push 36090 by nbeleuzu@mozilla.com at Fri, 31 May 2019 03:59:09 +0000
Bug 1551735 - Split out screenshot grabbing infrasturcture into a new module r=kvark Differential Revision: https://phabricator.services.mozilla.com/D32523
cb8c60790fd9a7fcd503e97b83de101daee39e77: Bug 1536240 - Add debug option to wrench to output specified shader source r=kvark
Connor Brewster <cbrewster@mozilla.com> - Thu, 30 May 2019 16:18:42 +0000 - rev 476249
Push 36090 by nbeleuzu@mozilla.com at Fri, 31 May 2019 03:59:09 +0000
Bug 1536240 - Add debug option to wrench to output specified shader source r=kvark Differential Revision: https://phabricator.services.mozilla.com/D33088
6e69ff803ac9930aeb479e1462f46f941a17104c: Bug 1553701 - Remove the clip chain stack during the prepare_prims pass in WR. r=kvark,nical
Glenn Watson <github@intuitionlibrary.com> - Fri, 24 May 2019 03:09:28 +0000 - rev 475311
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1553701 - Remove the clip chain stack during the prepare_prims pass in WR. r=kvark,nical During the visibility pass, the main clip chain instance for each primitive is created. In the prim prepare pass, a clip chain instance is generated for each segment (of primitives that are segmented). This previously required maintaining the active clip chain stack during both passes. However, this is not ideal for a number of reasons: the code is somewhat complicated / error prone and the segment clip chain building step does more work than required. This patch changes the segment clip chain building code to set up the active clip nodes based on the result of the initial clip chain built for the overall primitive during the visibility pass. This means that it's no longer necessary to maintain the active clip chain stack during the prepare pass. This simplifies some upcoming picture caching changes related to avoiding redundant cache invalidations, which is the main motivation for the change. Differential Revision: https://phabricator.services.mozilla.com/D32250
a0fa1beba2b3a0d30a5b1c8077462a72d5995cfd: Bug 1552984 - Refactor parts of the WR batching and flattening code, to support future picture caching improvements. r=kvark
Glenn Watson <github@intuitionlibrary.com> - Wed, 22 May 2019 14:57:10 +0000 - rev 475038
Push 36054 by dvarga@mozilla.com at Thu, 23 May 2019 15:52:15 +0000
Bug 1552984 - Refactor parts of the WR batching and flattening code, to support future picture caching improvements. r=kvark This patch contains two isolated changes related to upcoming picture caching improvements. Specifically: * Determine the blit reason for stacking contexts with clips earlier, during scene building. This simplifies the code and allows better detection of redundant stacking contexts. * Centralize the code for pushing batch instances into a small number of places. This will simplify the switch to adding a single primitive to multiple batch lists, in the case of dirty regions with different batchers. Differential Revision: https://phabricator.services.mozilla.com/D31898
76e3a842e496d78a80cd547b7bf94f041f9bc612: Bug 1551187 - Rename DropShadowStack into DropShadows. r=kvark"
Nicolas Silva <nsilva@mozilla.com> - Wed, 15 May 2019 15:21:53 +0200 - rev 474354
Push 36031 by rgurzau@mozilla.com at Fri, 17 May 2019 21:43:13 +0000
Bug 1551187 - Rename DropShadowStack into DropShadows. r=kvark" Differential Revision: https://phabricator.services.mozilla.com/D31248
f8516287a42503baa4cce8bee1a6025fa92f6095: Bug 1551187 - Box the color matrix in Filter. r=kvark
Nicolas Silva <nsilva@mozilla.com> - Mon, 13 May 2019 14:55:57 +0200 - rev 474120
Push 36023 by ncsoregi@mozilla.com at Thu, 16 May 2019 21:56:43 +0000
Bug 1551187 - Box the color matrix in Filter. r=kvark ColorMatrix is rarely used but takes most space in the Filter enum. This removes 44 bytes from the enum and all structs that embed it. Differential Revision: https://phabricator.services.mozilla.com/D30910
f92d432ffcc8bff708398c39548caa5898be4c03: Bug 1551187 - Rename render task tree into render task graph. r=kvark
Nicolas Silva <nsilva@mozilla.com> - Wed, 15 May 2019 15:11:42 +0200 - rev 474119
Push 36023 by ncsoregi@mozilla.com at Thu, 16 May 2019 21:56:43 +0000
Bug 1551187 - Rename render task tree into render task graph. r=kvark Differential Revision: https://phabricator.services.mozilla.com/D30897
091801115a02d2bcfbacada8a3367c3bdd805a9a: Bug 1551187 - Remove the single-shadow picture composite code. r=kvark
Nicolas Silva <nsilva@mozilla.com> - Wed, 15 May 2019 15:57:34 +0200 - rev 474118
Push 36023 by ncsoregi@mozilla.com at Thu, 16 May 2019 21:56:43 +0000
Bug 1551187 - Remove the single-shadow picture composite code. r=kvark Differential Revision: https://phabricator.services.mozilla.com/D30896
3339438190872637a2fbb4225ff3dc71e61721a9: Bug 1551187 - Box the color matrix in Filter. r=kvark
Nicolas Silva <nsilva@mozilla.com> - Wed, 15 May 2019 13:15:55 +0000 - rev 473923
Push 36019 by dvarga@mozilla.com at Wed, 15 May 2019 21:30:39 +0000
Bug 1551187 - Box the color matrix in Filter. r=kvark ColorMatrix is rarely used but takes most space in the Filter enum. This removes 44 bytes from the enum and all structs that embed it. Differential Revision: https://phabricator.services.mozilla.com/D30910
dc83934fa03259f44e80c9529320b280d15ae042: Bug 1551187 - Rename render task tree into render task graph. r=kvark
Nicolas Silva <nsilva@mozilla.com> - Wed, 15 May 2019 13:16:17 +0000 - rev 473922
Push 36019 by dvarga@mozilla.com at Wed, 15 May 2019 21:30:39 +0000
Bug 1551187 - Rename render task tree into render task graph. r=kvark sed -i 's/RenderTaskTree/RenderTaskGraph/g' gfx/wr/webrender/**/*.rs sed -i 's/task tree/task graph/g' gfx/wr/webrender/**/*.rs Differential Revision: https://phabricator.services.mozilla.com/D30897
aa02e32fd5bfe34931068d3906cc68a3993ad60e: Bug 1551187 - Remove the single-shadow picture composite code. r=kvark
Nicolas Silva <nsilva@mozilla.com> - Wed, 15 May 2019 13:16:19 +0000 - rev 473921
Push 36019 by dvarga@mozilla.com at Wed, 15 May 2019 21:30:39 +0000
Bug 1551187 - Remove the single-shadow picture composite code. r=kvark Differential Revision: https://phabricator.services.mozilla.com/D30896
a2fe99cb693af42947db157c030ac85c47002c0d: Bug 1551353 - Correctly map PBOs for readback on GLES r=kvark
Barret Rennie <barret@brennie.ca> - Tue, 14 May 2019 22:54:19 +0000 - rev 473875
Push 36017 by rgurzau@mozilla.com at Wed, 15 May 2019 09:25:56 +0000
Bug 1551353 - Correctly map PBOs for readback on GLES r=kvark The implementation of `Device::map_pbo_for_readback` on GLES (e.g., Windows with ANGLE) was using the incorrect enumeration value when attempting to map the buffer into memory. Differential Revision: https://phabricator.services.mozilla.com/D31156
bcbaf50dca2841ec7a86f208661a5c27c49fd5fb: Bug 1536021 - Gecko side changes. r=kvark
Nicolas Silva <nsilva@mozilla.com> - Fri, 10 May 2019 22:13:31 +0200 - rev 473551
Push 36003 by ncsoregi@mozilla.com at Sun, 12 May 2019 21:42:32 +0000
Bug 1536021 - Gecko side changes. r=kvark Differential Revision: https://phabricator.services.mozilla.com/D30618
82e5affb98af1ae4e697c32e1a83d40b6ced69ea: Bug 1536021 - Sanitize filters in place. r=kvark
Nicolas Silva <nsilva@mozilla.com> - Fri, 10 May 2019 01:23:54 +0200 - rev 473550
Push 36003 by ncsoregi@mozilla.com at Sun, 12 May 2019 21:42:32 +0000
Bug 1536021 - Sanitize filters in place. r=kvark
d8bd0fd8057945c2798d0cc489bd84a50607da95: Bug 1536021 - Shadow stack implementation. r=kvark
Nicolas Silva <nsilva@mozilla.com> - Sun, 12 May 2019 12:27:44 +0200 - rev 473549
Push 36003 by ncsoregi@mozilla.com at Sun, 12 May 2019 21:42:32 +0000
Bug 1536021 - Shadow stack implementation. r=kvark Differential Revision: https://phabricator.services.mozilla.com/D30620
0849b28c8e3db984273f97a8d6ea4f7284802f49: Bug 1550725 - Cull primitives with an empty clip. r=kvark
Andrew Osmond <aosmond@mozilla.com> - Fri, 10 May 2019 11:17:10 -0400 - rev 473508
Push 35999 by rmaries@mozilla.com at Sat, 11 May 2019 09:48:14 +0000
Bug 1550725 - Cull primitives with an empty clip. r=kvark When the clip chain generates the local clip rect for a primitive, it can be empty. This violated the assumption that the visible rect will never be empty, and so when we snap, it produces NaNs, which in turn, violates other assumptions when converting between spaces, and hence the crash. Now we cull the primitive from the visible list if the local clip rect is empty, or if the visible rect is empty. Differential Revision: https://phabricator.services.mozilla.com/D30659
d8fa440167f565c4553fc09e55caceb6544e2d89: Bug 1524427 - Fix panic when clip mask is supplied with non-existent image key. r=kvark
Glenn Watson <github@intuitionlibrary.com> - Thu, 09 May 2019 21:23:58 +0000 - rev 473329
Push 35993 by nbeleuzu@mozilla.com at Fri, 10 May 2019 02:54:27 +0000
Bug 1524427 - Fix panic when clip mask is supplied with non-existent image key. r=kvark In some cases, Gecko supplies a display item with an image clip mask where the image itself does not exist in the resource cache. In these cases, WR would skip requesting the image, but would still try to fetch the image info during batching, causing a panic. This patch skips adding clip items to the batching pass if the image mask does not exist. It also adds support to wrench for a crash test when the image mask is invalid. Differential Revision: https://phabricator.services.mozilla.com/D30560
b54d90e1c6814f37918a8a6a1e6fc5054ea6e868: Bug 1549921 - Refactor batch building code in preparation for multiple alpha batchers per picture. r=kvark
Glenn Watson <github@intuitionlibrary.com> - Wed, 08 May 2019 20:32:39 +0000 - rev 473118
Push 35988 by opoprus@mozilla.com at Thu, 09 May 2019 03:32:40 +0000
Bug 1549921 - Refactor batch building code in preparation for multiple alpha batchers per picture. r=kvark This patch is scaffolding only - there shouldn't be any functional changes as a result of these changes. Differential Revision: https://phabricator.services.mozilla.com/D30330
a8b4591d504eef634e7c88e774591a84666cf8cc: Bug 1547833 - Check for the KHR_debug extension before trying to use it. r=gw,kvark
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 06 May 2019 12:16:15 +0000 - rev 472890
Push 35983 by ncsoregi@mozilla.com at Wed, 08 May 2019 03:38:51 +0000
Bug 1547833 - Check for the KHR_debug extension before trying to use it. r=gw,kvark Differential Revision: https://phabricator.services.mozilla.com/D29824
2371d3a7ab2d46e91f4a71d1accfb74c5b01429e: Bug 1525402 - Mark all gfx/wr crates as Rust 2018. r=kvark
Alexis Beingessner <a.beingessner@gmail.com> - Tue, 07 May 2019 01:39:22 +0000 - rev 472822
Push 35978 by shindli@mozilla.com at Tue, 07 May 2019 09:44:39 +0000
Bug 1525402 - Mark all gfx/wr crates as Rust 2018. r=kvark Differential Revision: https://phabricator.services.mozilla.com/D29569
f072f15ba54ede2c3c1eb24c09593284b3bc7c72: Bug 1525402 - Run `cargo fix --edition` on webrender on macos. r=kvark
Alexis Beingessner <a.beingessner@gmail.com> - Tue, 07 May 2019 01:40:23 +0000 - rev 472821
Push 35978 by shindli@mozilla.com at Tue, 07 May 2019 09:44:39 +0000
Bug 1525402 - Run `cargo fix --edition` on webrender on macos. r=kvark Differential Revision: https://phabricator.services.mozilla.com/D29567