searching for reviewer(kmag)
2050f2cde1353983a160cb922ca32fc8e5a5f8ea: Bug 1715311 - Null check GetBrowserParent() in ProcessPriorityManagerImpl::ActivityChanged. r=kmag
Andrew McCreight <continuation@gmail.com> - Thu, 10 Jun 2021 23:06:57 +0000 - rev 582764
Push 38531 by mlaza@mozilla.com at Fri, 11 Jun 2021 09:42:05 +0000
Bug 1715311 - Null check GetBrowserParent() in ProcessPriorityManagerImpl::ActivityChanged. r=kmag Differential Revision: https://phabricator.services.mozilla.com/D117455
8addd27bba14bbb00270ab158150b2d0676e8274: Bug 1709346 - Part 2: Add test for cancelling a long-running load by removing its subframes, r=kmag
Nika Layzell <nika@thelayzells.com> - Thu, 03 Jun 2021 16:59:32 +0000 - rev 581852
Push 38513 by abutkovits@mozilla.com at Fri, 04 Jun 2021 10:21:11 +0000
Bug 1709346 - Part 2: Add test for cancelling a long-running load by removing its subframes, r=kmag This seems to be the behaviour which was causing the failures with twitter embeds. Differential Revision: https://phabricator.services.mozilla.com/D115707
866026daf2b27a3837fac56feb7e476b8ea3de54: Bug 1709346 - Part 1: Track BrowsingContextWebProgress for subframes, r=mattwoodrow,kmag,necko-reviewers
Nika Layzell <nika@thelayzells.com> - Thu, 03 Jun 2021 16:59:32 +0000 - rev 581851
Push 38513 by abutkovits@mozilla.com at Fri, 04 Jun 2021 10:21:11 +0000
Bug 1709346 - Part 1: Track BrowsingContextWebProgress for subframes, r=mattwoodrow,kmag,necko-reviewers This allows loads to be tracked as they are ongoing on a per-context basis in the parent process, and for events to be generated for each subframe as it is destroyed. This patch also stops sending the `IsLoadingDocument` flag on the request to the main process and removes RemoteWebProgress, as they are no longer necessary due to being tracked directly. Finally this patch also adds some logging to BrowsingContextWebProgress to make it easier to diagnose this type of issue in the future. Differential Revision: https://phabricator.services.mozilla.com/D115706
671001812b0fb13cb699697ad14207525e58101a: Bug 1712357 - Don't adjust the priority of ContentParents that are going away. r=kmag
Andrew McCreight <continuation@gmail.com> - Tue, 01 Jun 2021 22:49:50 +0000 - rev 581641
Push 38511 by cbrindusan@mozilla.com at Wed, 02 Jun 2021 21:44:47 +0000
Bug 1712357 - Don't adjust the priority of ContentParents that are going away. r=kmag Differential Revision: https://phabricator.services.mozilla.com/D116496
1bc11fed0fa79a2935b70bb491270d2f28afdfcc: Bug 1695817 - Part 2: Introduce a blank page about:third-party r=Gijs,fluent-reviewers,xpcom-reviewers,kmag
Toshihito Kikuchi <tkikuchi@mozilla.com> - Fri, 28 May 2021 22:35:57 +0000 - rev 581384
Push 38500 by smolnar@mozilla.com at Sat, 29 May 2021 09:25:54 +0000
Bug 1695817 - Part 2: Introduce a blank page about:third-party r=Gijs,fluent-reviewers,xpcom-reviewers,kmag This patch adds a blank page about:third-party along with a skeleton XPCOM object AboutThirdParty which has a method to invoke a background task in C++. Differential Revision: https://phabricator.services.mozilla.com/D109303
e3f2bed63c330c0bd35f18319e46f2297b1ef4e3: Bug 1695817 - Part 2: Introduce a blank page about:third-party r=Gijs,fluent-reviewers,xpcom-reviewers,kmag
Toshihito Kikuchi <tkikuchi@mozilla.com> - Fri, 28 May 2021 15:32:29 +0000 - rev 581229
Push 38499 by nerli@mozilla.com at Sat, 29 May 2021 03:43:09 +0000
Bug 1695817 - Part 2: Introduce a blank page about:third-party r=Gijs,fluent-reviewers,xpcom-reviewers,kmag This patch adds a blank page about:third-party along with a skeleton XPCOM object AboutThirdParty which has a method to invoke a background task in C++. Differential Revision: https://phabricator.services.mozilla.com/D109303
4860450c2e2370b661e2110fd82af10ebc7fc9c1: Bug 1695817 - Part 2: Introduce a blank page about:third-party r=Gijs,fluent-reviewers,xpcom-reviewers,kmag
Toshihito Kikuchi <tkikuchi@mozilla.com> - Fri, 28 May 2021 04:19:06 +0000 - rev 581183
Push 38498 by malexandru@mozilla.com at Fri, 28 May 2021 21:48:03 +0000
Bug 1695817 - Part 2: Introduce a blank page about:third-party r=Gijs,fluent-reviewers,xpcom-reviewers,kmag This patch adds a blank page about:third-party along with a skeleton XPCOM object AboutThirdParty which has a method to invoke a background task in C++. Differential Revision: https://phabricator.services.mozilla.com/D109303
a2d11a0849d5576259c38a77076e4b6e3b6ee275: Bug 1695817 - Part 2: Introduce a blank page about:third-party r=Gijs,fluent-reviewers,xpcom-reviewers,kmag
Toshihito Kikuchi <tkikuchi@mozilla.com> - Thu, 27 May 2021 21:14:12 +0000 - rev 581145
Push 38498 by malexandru@mozilla.com at Fri, 28 May 2021 21:48:03 +0000
Bug 1695817 - Part 2: Introduce a blank page about:third-party r=Gijs,fluent-reviewers,xpcom-reviewers,kmag This patch adds a blank page about:third-party along with a skeleton XPCOM object AboutThirdParty which has a method to invoke a background task in C++. Differential Revision: https://phabricator.services.mozilla.com/D109303
d71ae45a7ff6cf32309e5f9864d6f9f6bb01a13b: Bug 1535913 - Part 2: Hold a keepalive for extension BCGs in WebExtensionPolicy, r=kmag
Nika Layzell <nika@thelayzells.com> - Wed, 26 May 2021 15:25:43 +0000 - rev 580764
Push 38493 by imoraru@mozilla.com at Wed, 26 May 2021 21:17:56 +0000
Bug 1535913 - Part 2: Hold a keepalive for extension BCGs in WebExtensionPolicy, r=kmag Differential Revision: https://phabricator.services.mozilla.com/D114889
7c1e15680741ff8e18835b771c27bc7a7f0c0c53: Bug 1709346 - Part 2: Add test for cancelling a long-running load by removing its subframes, r=kmag
Nika Layzell <nika@thelayzells.com> - Tue, 25 May 2021 17:31:54 +0000 - rev 580639
Push 38491 by malexandru@mozilla.com at Wed, 26 May 2021 09:48:46 +0000
Bug 1709346 - Part 2: Add test for cancelling a long-running load by removing its subframes, r=kmag This seems to be the behaviour which was causing the failures with twitter embeds. Differential Revision: https://phabricator.services.mozilla.com/D115707
34eff34306743d01ffb72e3ff671152a83f0dcab: Bug 1709346 - Part 1: Track BrowsingContextWebProgress for subframes, r=mattwoodrow,kmag,necko-reviewers
Nika Layzell <nika@thelayzells.com> - Tue, 25 May 2021 17:31:53 +0000 - rev 580638
Push 38491 by malexandru@mozilla.com at Wed, 26 May 2021 09:48:46 +0000
Bug 1709346 - Part 1: Track BrowsingContextWebProgress for subframes, r=mattwoodrow,kmag,necko-reviewers This allows loads to be tracked as they are ongoing on a per-context basis in the parent process, and for events to be generated for each subframe as it is destroyed. This patch also stops sending the `IsLoadingDocument` flag on the request to the main process and removes RemoteWebProgress, as they are no longer necessary due to being tracked directly. Finally this patch also adds some logging to BrowsingContextWebProgress to make it easier to diagnose this type of issue in the future. Differential Revision: https://phabricator.services.mozilla.com/D115706
19df1a8bfacc64af8cd90926550cd820e1709957: Bug 1709346 - Part 2: Add test for cancelling a long-running load by removing its subframes, r=kmag
Nika Layzell <nika@thelayzells.com> - Tue, 25 May 2021 15:54:49 +0000 - rev 580626
Push 38491 by malexandru@mozilla.com at Wed, 26 May 2021 09:48:46 +0000
Bug 1709346 - Part 2: Add test for cancelling a long-running load by removing its subframes, r=kmag This seems to be the behaviour which was causing the failures with twitter embeds. Differential Revision: https://phabricator.services.mozilla.com/D115707
602a7b4a41de9c06a75f895a27d874f76811e752: Bug 1709346 - Part 1: Track BrowsingContextWebProgress for subframes, r=mattwoodrow,kmag,necko-reviewers
Nika Layzell <nika@thelayzells.com> - Tue, 25 May 2021 15:54:48 +0000 - rev 580625
Push 38491 by malexandru@mozilla.com at Wed, 26 May 2021 09:48:46 +0000
Bug 1709346 - Part 1: Track BrowsingContextWebProgress for subframes, r=mattwoodrow,kmag,necko-reviewers This allows loads to be tracked as they are ongoing on a per-context basis in the parent process, and for events to be generated for each subframe as it is destroyed. This patch also stops sending the `IsLoadingDocument` flag on the request to the main process and removes RemoteWebProgress, as they are no longer necessary due to being tracked directly. Finally this patch also adds some logging to BrowsingContextWebProgress to make it easier to diagnose this type of issue in the future. Differential Revision: https://phabricator.services.mozilla.com/D115706
72ca306baa234461ec8bcdadf0457b38a652121f: Bug 1709715 - Take advantage of CTAD for GetParticularProcessPriorityManager(). r=kmag
Andrew McCreight <continuation@gmail.com> - Fri, 21 May 2021 21:13:05 +0000 - rev 580480
Push 38482 by smolnar@mozilla.com at Sat, 22 May 2021 03:53:20 +0000
Bug 1709715 - Take advantage of CTAD for GetParticularProcessPriorityManager(). r=kmag Differential Revision: https://phabricator.services.mozilla.com/D114406
1675ff18e322d1f42fb0e3fc214b32c5cffa65f7: Bug 1535913 - Part 2: Hold a keepalive for extension BCGs in WebExtensionPolicy, r=kmag
Nika Layzell <nika@thelayzells.com> - Wed, 19 May 2021 17:17:35 +0000 - rev 580044
Push 38476 by dluca@mozilla.com at Wed, 19 May 2021 21:47:56 +0000
Bug 1535913 - Part 2: Hold a keepalive for extension BCGs in WebExtensionPolicy, r=kmag Differential Revision: https://phabricator.services.mozilla.com/D114889
7b3a831a0f6b5437890e681902ab3e8ec2971588: Bug 1471327 - Eagerly create initial about:blank document for in-process browsers, r=kmag
Nika Layzell <nika@thelayzells.com> - Wed, 19 May 2021 16:02:33 +0000 - rev 580033
Push 38476 by dluca@mozilla.com at Wed, 19 May 2021 21:47:56 +0000
Bug 1471327 - Eagerly create initial about:blank document for in-process browsers, r=kmag Differential Revision: https://phabricator.services.mozilla.com/D114788
368d0fd83186cc406ad6cb06afe82dc87ccbc38d: Bug 1711714 Update PBM tests within browser/components/extensions/test/browser/browser_ext_tabs_zoom to work with https-first-mode enabled. r=kmag,ckerschb
lyavor <lyavor@mozilla.com> - Wed, 19 May 2021 12:13:36 +0000 - rev 580018
Push 38476 by dluca@mozilla.com at Wed, 19 May 2021 21:47:56 +0000
Bug 1711714 Update PBM tests within browser/components/extensions/test/browser/browser_ext_tabs_zoom to work with https-first-mode enabled. r=kmag,ckerschb Differential Revision: https://phabricator.services.mozilla.com/D115378
10151fddafaf084b8579f68cce7f8f04a2b8af19: Bug 1710145 - Deduction guide RefPtr(already_AddRefed<T>) -> RefPtr<T> - r=kmag
Gerald Squelart <gsquelart@mozilla.com> - Tue, 11 May 2021 21:55:21 +0000 - rev 579432
Push 38455 by csabou@mozilla.com at Wed, 12 May 2021 04:08:16 +0000
Bug 1710145 - Deduction guide RefPtr(already_AddRefed<T>) -> RefPtr<T> - r=kmag Differential Revision: https://phabricator.services.mozilla.com/D114809
0849b7003a19ed9ac42f1ef9210d7ac08cf9f7f7: Bug 1708734 - Part 3: Add tests for createActor: false, r=kmag
Nika Layzell <nika@thelayzells.com> - Tue, 11 May 2021 17:29:25 +0000 - rev 579398
Push 38454 by smolnar@mozilla.com at Tue, 11 May 2021 21:39:06 +0000
Bug 1708734 - Part 3: Add tests for createActor: false, r=kmag Differential Revision: https://phabricator.services.mozilla.com/D114793
93b3e76c8702309ce26a0a662d0f09826b4c8885: Bug 1708734 - Part 2: Allow specifying that an actor should not be created when event is fired, r=kmag
Nika Layzell <nika@thelayzells.com> - Tue, 11 May 2021 17:29:25 +0000 - rev 579397
Push 38454 by smolnar@mozilla.com at Tue, 11 May 2021 21:39:06 +0000
Bug 1708734 - Part 2: Allow specifying that an actor should not be created when event is fired, r=kmag Differential Revision: https://phabricator.services.mozilla.com/D114792
e3a2ec3b19b4c4ca7a0e862b3def2633695e75f7: Bug 1708734 - Part 1: Add getExistingActor to actor managers, r=kmag
Nika Layzell <nika@thelayzells.com> - Tue, 11 May 2021 17:29:24 +0000 - rev 579396
Push 38454 by smolnar@mozilla.com at Tue, 11 May 2021 21:39:06 +0000
Bug 1708734 - Part 1: Add getExistingActor to actor managers, r=kmag Differential Revision: https://phabricator.services.mozilla.com/D114791
c6eded2d86cb8bde35890d00d48c01034bde25ce: Bug 1707711 - Stop using ChromeUtils.import(..., null) in testing/. r=kmag
Mark Banner <standard8@mozilla.com> - Mon, 10 May 2021 08:56:05 +0000 - rev 579216
Push 38450 by abutkovits@mozilla.com at Mon, 10 May 2021 16:02:29 +0000
Bug 1707711 - Stop using ChromeUtils.import(..., null) in testing/. r=kmag Also clean up some unused exclusions in .eslintrc.js. Differential Revision: https://phabricator.services.mozilla.com/D114623
ed582ad8db975657f512bb8ed6960ec63897fc30: Bug 1707711 - Stop using ChromeUtils.import(..., null) in testing/. r=kmag
Mark Banner <standard8@mozilla.com> - Sun, 09 May 2021 08:06:41 +0000 - rev 579180
Push 38448 by dluca@mozilla.com at Sun, 09 May 2021 21:36:23 +0000
Bug 1707711 - Stop using ChromeUtils.import(..., null) in testing/. r=kmag Also clean up some unused exclusions in .eslintrc.js. Differential Revision: https://phabricator.services.mozilla.com/D114623
07c8392cb04d095caa8e65ee1a10ccc5f7352eb6: Bug 1618547 - Support Fission in the process priority manager. r=kmag,gsvelto
Andrew McCreight <continuation@gmail.com> - Fri, 07 May 2021 17:51:34 +0000 - rev 578902
Push 38445 by imoraru@mozilla.com at Fri, 07 May 2021 21:46:25 +0000
Bug 1618547 - Support Fission in the process priority manager. r=kmag,gsvelto With Fission, there can be multiple BrowserParents in a single tab, so this patch moves the tracking of active tabs onto the top BrowsingContext in a tab. If the priority of a top BC is changed, then the activity of all of the BPs of the BCs in the tree are all adjusted. The flag that tracks this state gets carried forward to the new BC in the case of a cross-group navigation by the changes in ReplacedBy(). The other change here covers the case where we do a process-switching navigation on an iframe. If we create a new BrowserParent with an active top BC, then the BP gets marked as active in the priority manager. Doing this tracking on the BP instead of the BC (both here in and in the part that landed previously in BrowserParent::Deactivated()) means that we don't need to track down every place that a BC switches processes. I left the tracking of activity in ParticularProcessPriorityManager centered around BrowserParents, instead of changing it to BCs, to minimize the changes required. There are some tricky interactions there with wakelocks that I didn't want to have to figure out. browser_ProcessPriorityManager.js was set up to track a mapping of browsers to priorities, but for the purposes of testing Fission support I changed it to track a mapping of child IDs to priorities. In the test, I also removed an assignment (this.window = null) that didn't seem to be doing anything. Differential Revision: https://phabricator.services.mozilla.com/D112213
21020c5c5fce5119df645d4326e04fc83bd29cb6: Bug 1706365 - Part 2: Add tests for mozilla::Queue, r=xpcom-reviewers,kmag
Nika Layzell <nika@thelayzells.com> - Thu, 06 May 2021 20:05:34 +0000 - rev 578778
Push 38443 by nbeleuzu@mozilla.com at Fri, 07 May 2021 09:52:21 +0000
Bug 1706365 - Part 2: Add tests for mozilla::Queue, r=xpcom-reviewers,kmag Differential Revision: https://phabricator.services.mozilla.com/D114523
8ad05b43479e12c7802fa294b5ab16e55ee5e51c: Bug 1706365 - Part 1: Safely invoke destructors and constructors in mozilla::Queue, r=xpcom-reviewers,kmag
Nika Layzell <nika@thelayzells.com> - Thu, 06 May 2021 20:05:34 +0000 - rev 578777
Push 38443 by nbeleuzu@mozilla.com at Fri, 07 May 2021 09:52:21 +0000
Bug 1706365 - Part 1: Safely invoke destructors and constructors in mozilla::Queue, r=xpcom-reviewers,kmag This allows the `mozilla::Queue` type to be used more easily and without causing assertion failures, leaks, or unsafe behaviour. Differential Revision: https://phabricator.services.mozilla.com/D112763
074fb49ff6a8831a9ed0502df1dbff18ffd300da: Bug 1709700 - Clarify that subframes cannot cross-group navigate in docs, r=kmag DONTBUILD
Nika Layzell <nika@thelayzells.com> - Thu, 06 May 2021 14:44:25 +0000 - rev 578734
Push 38441 by smolnar@mozilla.com at Thu, 06 May 2021 21:43:11 +0000
Bug 1709700 - Clarify that subframes cannot cross-group navigate in docs, r=kmag DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D114398
f45996fe15b23696c88f85a6b154146d3717fc58: Bug 1618547 - Support Fission in the process priority manager. r=kmag,gsvelto
Andrew McCreight <continuation@gmail.com> - Wed, 05 May 2021 20:29:14 +0000 - rev 578628
Push 38438 by ncsoregi@mozilla.com at Thu, 06 May 2021 03:49:11 +0000
Bug 1618547 - Support Fission in the process priority manager. r=kmag,gsvelto With Fission, there can be multiple BrowserParents in a single tab, so this patch moves the tracking of active tabs onto the top BrowsingContext in a tab. If the priority of a top BC is changed, then the activity of all of the BPs of the BCs in the tree are all adjusted. The flag that tracks this state gets carried forward to the new BC in the case of a cross-group navigation by the changes in ReplacedBy(). The other change here covers the case where we do a process-switching navigation on an iframe. If we create a new BrowserParent with an active top BC, then the BP gets marked as active in the priority manager. Doing this tracking on the BP instead of the BC (both here in and in the part that landed previously in BrowserParent::Deactivated()) means that we don't need to track down every place that a BC switches processes. I left the tracking of activity in ParticularProcessPriorityManager centered around BrowserParents, instead of changing it to BCs, to minimize the changes required. There are some tricky interactions there with wakelocks that I didn't want to have to figure out. browser_ProcessPriorityManager.js was set up to track a mapping of browsers to priorities, but for the purposes of testing Fission support I changed it to track a mapping of child IDs to priorities. In the test, I also removed an assignment (this.window = null) that didn't seem to be doing anything. Differential Revision: https://phabricator.services.mozilla.com/D112213
2ecbfdd5087b627ff6e94846ea40cfc3f986f73e: Bug 1709200 - Rename nsContentUtils::GetRootDocument to GetInProcessSubtreeRootDocument; r=kmag
Edgar Chen <echen@mozilla.com> - Wed, 05 May 2021 09:42:20 +0000 - rev 578567
Push 38437 by ncsoregi@mozilla.com at Wed, 05 May 2021 21:52:08 +0000
Bug 1709200 - Rename nsContentUtils::GetRootDocument to GetInProcessSubtreeRootDocument; r=kmag Differential Revision: https://phabricator.services.mozilla.com/D114177
5ec8c0e30942e92d0f323eb95c9eda0e1b7fcef0: Bug 1705768 - Update dom/ipc/tests/JSWindowActor/browser_contentWindow.js to pass with Fission+BFCache, r=kmag
Olli Pettay <Olli.Pettay@helsinki.fi> - Mon, 26 Apr 2021 22:25:59 +0000 - rev 577552
Push 38409 by imoraru@mozilla.com at Tue, 27 Apr 2021 09:55:09 +0000
Bug 1705768 - Update dom/ipc/tests/JSWindowActor/browser_contentWindow.js to pass with Fission+BFCache, r=kmag Differential Revision: https://phabricator.services.mozilla.com/D112377
02a698f7345f268ef2ec171c980fb7bcec3cbff5: Bug 1702116 - Fix races in AddonManager & XPIDatabase r=kmag
Barret Rennie <barret@brennie.ca> - Thu, 22 Apr 2021 01:15:54 +0000 - rev 577024
Push 38398 by imoraru@mozilla.com at Thu, 22 Apr 2021 09:31:15 +0000
Bug 1702116 - Fix races in AddonManager & XPIDatabase r=kmag Differential Revision: https://phabricator.services.mozilla.com/D110363
db03ed8185997f681c2c9e2010a2c1c3bebb1344: Bug 1702116 - Fix races in AddonManager & XPIDatabase r=kmag
Barret Rennie <barret@brennie.ca> - Tue, 20 Apr 2021 16:09:25 +0000 - rev 576797
Push 38391 by ncsoregi@mozilla.com at Tue, 20 Apr 2021 21:39:49 +0000
Bug 1702116 - Fix races in AddonManager & XPIDatabase r=kmag Differential Revision: https://phabricator.services.mozilla.com/D110363
b1e78dca3b80b3586228db2a14ee6d0462d9553e: Bug 1705660 - Remove nsIDOMWindowUtils::deprecatedOuterWindowID; r=kmag
Edgar Chen <echen@mozilla.com> - Tue, 20 Apr 2021 09:04:42 +0000 - rev 576737
Push 38391 by ncsoregi@mozilla.com at Tue, 20 Apr 2021 21:39:49 +0000
Bug 1705660 - Remove nsIDOMWindowUtils::deprecatedOuterWindowID; r=kmag As it is not used now (after bug 1612831). Differential Revision: https://phabricator.services.mozilla.com/D112327
30f92429e81b48118a57dc238da98286a3676a04: Bug 1699569 - Null terminate copied string under error condition r=evilpie,kmag
Matthew Gaudet <mgaudet@mozilla.com> - Fri, 16 Apr 2021 16:32:29 +0000 - rev 576376
Push 38381 by nbeleuzu@mozilla.com at Sat, 17 Apr 2021 09:50:08 +0000
Bug 1699569 - Null terminate copied string under error condition r=evilpie,kmag Differential Revision: https://phabricator.services.mozilla.com/D112047
b29fdf0da851cfd9eb8cd1f08263c09c2c997d21: Bug 1704545, part 3 - Tell the priority manager when a browser parent is deactivated. r=gsvelto,kmag
Andrew McCreight <continuation@gmail.com> - Mon, 12 Apr 2021 23:42:53 +0000 - rev 575566
Push 38367 by abutkovits@mozilla.com at Tue, 13 Apr 2021 03:56:47 +0000
Bug 1704545, part 3 - Tell the priority manager when a browser parent is deactivated. r=gsvelto,kmag The priority manager tracks which browser parents are active in each process, so it needs to be told when a browser parent is no longer active. This is currently implemented by observing ipc:browser-destroyed, which happens in BrowserHost::DestroyComplete(). However, with Fission, not all BrowserParents are held by BrowserHosts. I don't think this is an issue right now, but if the priority manager is going to properly prioritize processes due to the presence of active non-top-level frames, then it needs to also deprioritize them when they go away. This patch deals with this situation by directly telling the priority manager that the browser parent is becoming inactive via the existing ActivityChanged method, in the BrowserParent::Deactivated() method, which is called when a browser parent is being destroyed or entering the BF cache. I think it makes sense in both cases that we no longer want to prioritize the process that the page is in. This does mean that we are telling the priority manager about more ContentParents which is potentially more expensive, but the old code also ended up doing a hashtable remove in every single ParticularProcessPriorityManager, whereas the new code only does it for one, so hopefully it is a net win overall. (The reason for this is that in ParticularProcessPriorityManager's OnBrowserParentDestroyed() method the browserHost->GetContentParent() check will always return null because the browser host nulls out mRoot immediately before it does ipc:browser-destroyed, so the hash table remove is never skipped.) This patch also removes the last thing that ParticularProcessPriorityManager was observing, so it no longer needs to be an nsIObserver. Differential Revision: https://phabricator.services.mozilla.com/D111654
058a3d269e3a25219eef7ec3380ec928378a1040: Bug 1702321 - Improve crash reports for some rust panics; r=kmag
Geoff Brown <whole.grains@protonmail.com> - Mon, 12 Apr 2021 20:00:58 +0000 - rev 575531
Push 38367 by abutkovits@mozilla.com at Tue, 13 Apr 2021 03:56:47 +0000
Bug 1702321 - Improve crash reports for some rust panics; r=kmag Add some additional patterns for well-known panic frames. This should improve crash signature reporting for some rust panics. Differential Revision: https://phabricator.services.mozilla.com/D111690
335755f56e63798fa89aefc32bbde881b44b3259: Bug 1703083 - Don't run maybeShowOtherBookmarksFolder if doc has gone away. r=kmag
Andrew McCreight <continuation@gmail.com> - Thu, 08 Apr 2021 23:21:43 +0000 - rev 575168
Push 38358 by archaeopteryx@coole-files.de at Fri, 09 Apr 2021 09:20:20 +0000
Bug 1703083 - Don't run maybeShowOtherBookmarksFolder if doc has gone away. r=kmag This can also touch the doc, so we don't want to run it if the doc has been unlinked. Differential Revision: https://phabricator.services.mozilla.com/D111332
6dcf9156484f47f390e57819340fe948396b803d: Bug 1702608, ensure the same docshell is used in nsDSURIContentListener, r=kmag
Olli Pettay <Olli.Pettay@helsinki.fi> - Wed, 07 Apr 2021 10:24:58 +0000 - rev 574797
Push 38353 by dluca@mozilla.com at Wed, 07 Apr 2021 15:47:02 +0000
Bug 1702608, ensure the same docshell is used in nsDSURIContentListener, r=kmag Differential Revision: https://phabricator.services.mozilla.com/D110599
cc59feb1fe6990c66ecb04c73866cdfde47cf891: Bug 1698661 - Use the id of top browsing context to dispatch transactions, r=necko-reviewers,kmag,dragana
Kershaw Chang <kershaw@mozilla.com> - Wed, 07 Apr 2021 07:59:18 +0000 - rev 574699
Push 38353 by dluca@mozilla.com at Wed, 07 Apr 2021 15:47:02 +0000
Bug 1698661 - Use the id of top browsing context to dispatch transactions, r=necko-reviewers,kmag,dragana Differential Revision: https://phabricator.services.mozilla.com/D110219
de070731df265ac92f5e85eb5c95c893a6e68522: Bug 1701668, remove nsIWebBrowserChrome3 interface, r=kmag
Neil Deakin <neil@mozilla.com> - Tue, 06 Apr 2021 18:52:47 +0000 - rev 574584
Push 38351 by btara@mozilla.com at Wed, 07 Apr 2021 03:19:44 +0000
Bug 1701668, remove nsIWebBrowserChrome3 interface, r=kmag Differential Revision: https://phabricator.services.mozilla.com/D110103
da0d62a0534b60a964918d43f8c105c699157dd0: Bug 1701668, remove onBeforeLinkTraversal implementations and handle links in docshell, r=kmag,mixedpuppy,geckoview-reviewers,agi
Neil Deakin <neil@mozilla.com> - Tue, 06 Apr 2021 18:52:46 +0000 - rev 574583
Push 38351 by btara@mozilla.com at Wed, 07 Apr 2021 03:19:44 +0000
Bug 1701668, remove onBeforeLinkTraversal implementations and handle links in docshell, r=kmag,mixedpuppy,geckoview-reviewers,agi This also fixes links in top or in-process subframes and out-of-process subframes in extensions sidebars and panels so that they open in new tabs. Differential Revision: https://phabricator.services.mozilla.com/D110102
abf5af44055dc85e86dab855cf338c97ddd5fd34: Bug 1701668, remove shouldLoadURI and shouldLoadURIInThisProcess methods now that all implementers return true, r=kmag
Neil Deakin <neil@mozilla.com> - Tue, 06 Apr 2021 18:52:46 +0000 - rev 574582
Push 38351 by btara@mozilla.com at Wed, 07 Apr 2021 03:19:44 +0000
Bug 1701668, remove shouldLoadURI and shouldLoadURIInThisProcess methods now that all implementers return true, r=kmag Differential Revision: https://phabricator.services.mozilla.com/D110101
c41a7b705276329e9f3c961f095f0f7d62f7813a: Bug 1697721 - Have nsLocalFile::CreateAllAncestors make each path component. r=xpcom-reviewers,kmag
RJ Johnson <mrrjj@protonmail.com> - Tue, 06 Apr 2021 11:49:24 +0000 - rev 574474
Push 38350 by malexandru@mozilla.com at Tue, 06 Apr 2021 15:29:48 +0000
Bug 1697721 - Have nsLocalFile::CreateAllAncestors make each path component. r=xpcom-reviewers,kmag Some systems hide path components. Determine access by creating the whole path. Differential Revision: https://phabricator.services.mozilla.com/D107970
86015112dd62e230030072e94d618373898940a2: Bug 1702405 - Add missing #include for MakeScopeExit. r=kmag
Petr Sumbera <petr.sumbera@oracle.com> - Tue, 06 Apr 2021 07:34:00 +0000 - rev 574450
Push 38350 by malexandru@mozilla.com at Tue, 06 Apr 2021 15:29:48 +0000
Bug 1702405 - Add missing #include for MakeScopeExit. r=kmag Differential Revision: https://phabricator.services.mozilla.com/D110517
fc396e06eb5f99ff6901e2f91989fd176d8f6725: Bug 1702516 - Remove all terminateGlobal uses r=kmag
Doug Thayer <dothayer@mozilla.com> - Mon, 05 Apr 2021 16:00:09 +0000 - rev 574336
Push 38349 by smolnar@mozilla.com at Tue, 06 Apr 2021 09:47:06 +0000
Bug 1702516 - Remove all terminateGlobal uses r=kmag This never actually worked, because nothing ever listened to the notification sent in XPCJSContext (kill-content-script-sandbox). We're also removing the "Temporarily disable extension" button in the slow addon notification, which was the primary caller of this - however, that's in a separate patch. Differential Revision: https://phabricator.services.mozilla.com/D110583
ec7220b67affa44a91830b937050c3c3598852df: Bug 1702245 - Expand XPCOM's in-tree documentation, r=xpcom-reviewers,kmag
Nika Layzell <nika@thelayzells.com> - Mon, 05 Apr 2021 15:56:18 +0000 - rev 574333
Push 38348 by nerli@mozilla.com at Mon, 05 Apr 2021 21:28:12 +0000
Bug 1702245 - Expand XPCOM's in-tree documentation, r=xpcom-reviewers,kmag This change involved migrating a number of pages, including the DMD documentation, XPIDL documentation, and the Internal String Guide to Firefox Source Docs, as well as performing a review/update to these documents to be more accurate and current. In addition, some additional sections were written in the various documents to elaborate on important features which were not present when the documents were originally written, and a few new documents were written to add basic documentaiton for other XPCOM components. The following MDN pages were migrated in this patch: https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPIDL https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Guide/Internal_strings https://developer.mozilla.org/en-US/docs/Mozilla/Performance/DMD Differential Revision: https://phabricator.services.mozilla.com/D110424
5969838fee530d5fa88e025a2d4d4f8ef31a3f59: Bug 1699721 - Part 3: Add test for switching back into unloading process, r=kmag
Nika Layzell <nika@thelayzells.com> - Wed, 31 Mar 2021 16:51:59 +0000 - rev 573914
Push 38338 by ncsoregi@mozilla.com at Thu, 01 Apr 2021 03:12:48 +0000
Bug 1699721 - Part 3: Add test for switching back into unloading process, r=kmag This was somewhat convoluted to get to both reliably reproduce and not timeout after the fixes were applied. The test can't run without Fission, as it requires a process switch to occur on the navigation to/from http://example.com. Without part 2 of this patch stack, this test will crash after the process switch. Differential Revision: https://phabricator.services.mozilla.com/D110003
e1fd1fa67a6554ae8dc206a6fed9e5405a0bf778: Bug 1699721 - Part 2: Track BrowserParent lifecycles during process switches, r=kmag
Nika Layzell <nika@thelayzells.com> - Wed, 31 Mar 2021 16:51:58 +0000 - rev 573913
Push 38338 by ncsoregi@mozilla.com at Thu, 01 Apr 2021 03:12:48 +0000
Bug 1699721 - Part 2: Track BrowserParent lifecycles during process switches, r=kmag This patch contains a large number of changes around the process switching mechanism in order to avoid issues which are caused by a mismatched understanding of the state of the process switch between processes in the presence of nested event loops. This includes: 1. The "InFlightProcessId" value is no longer recorded. All remaining uses were removed in part 1, and the new mechanism tracks this information in a better way. 2. The current BrowserParent instance is now tracked on CanonicalBrowsingContext, meaning that logic which needs to work with this information can now access it without depending on the current WindowGlobalParent instance. 3. When doing a process switch, the previous host process for the BrowsingContext is tracked until the process switch is completed, allowing for future attempts to switch into that process to be delayed until the previous unload event has finished running. 4. The process switch logic was refactored to simplify some of the error-handling logic, and share more code between different cases. Differential Revision: https://phabricator.services.mozilla.com/D110002
2b3a6042d48e25d09c77b91003e2b64a70e7ddcf: Bug 1699721 - Part 1: Fully remove LegacyCheckOnlyOwningProcess, r=kmag
Nika Layzell <nika@thelayzells.com> - Wed, 31 Mar 2021 16:51:58 +0000 - rev 573912
Push 38338 by ncsoregi@mozilla.com at Thu, 01 Apr 2021 03:12:48 +0000
Bug 1699721 - Part 1: Fully remove LegacyCheckOnlyOwningProcess, r=kmag This is necessary as in part 2 the InFlightProcessId value will no longer be tracked, so any remaining code which depends on it needs to be removed. Differential Revision: https://phabricator.services.mozilla.com/D110001
ed3feb80101797a1813d09387e17c6b3f3a266bf: Bug 1699721 - Part 3: Add test for switching back into unloading process, r=kmag
Nika Layzell <nika@thelayzells.com> - Wed, 31 Mar 2021 15:37:49 +0000 - rev 573894
Push 38337 by ncsoregi@mozilla.com at Wed, 31 Mar 2021 21:54:44 +0000
Bug 1699721 - Part 3: Add test for switching back into unloading process, r=kmag This was somewhat convoluted to get to both reliably reproduce and not timeout after the fixes were applied. The test can't run without Fission, as it requires a process switch to occur on the navigation to/from http://example.com. Without part 2 of this patch stack, this test will crash after the process switch. Differential Revision: https://phabricator.services.mozilla.com/D110003