searching for reviewer(kmag)
2c4d12bdfec3bf98237db563eb30005eb67035e9: Bug 1479960 - Convert MemMapSnapshot to use frozen shared memory. r=kmag
Jed Davis <jld@mozilla.com> - Thu, 20 Jun 2019 22:40:38 +0000 - rev 479754
Push 36180 by shindli@mozilla.com at Fri, 21 Jun 2019 09:33:06 +0000
Bug 1479960 - Convert MemMapSnapshot to use frozen shared memory. r=kmag Depends on D26745 Differential Revision: https://phabricator.services.mozilla.com/D26746
8a322064cf6ddadf52024551427231266686091f: Bug 1479960 - Give SharedStringMap a magic number so that all zeroes isn't a valid instance. r=kmag
Jed Davis <jld@mozilla.com> - Thu, 20 Jun 2019 22:40:36 +0000 - rev 479753
Push 36180 by shindli@mozilla.com at Fri, 21 Jun 2019 09:33:06 +0000
Bug 1479960 - Give SharedStringMap a magic number so that all zeroes isn't a valid instance. r=kmag There was a strange bug when converting SharedStringMap to use shared memory: on Android, some tests would fail because a pref wasn't set or there was something wrong with an expected error message. The root cause was that mapping ashmem with MAP_PRIVATE results in all zeroes (see bug 1525803), but that was read as a valid SharedStringMap with length 0. To prevent any possible future issues like that, this patch adds a nonzero magic number to the header. It fits into padding on 64-bit and the cost of setting and checking it should be essentially free. Depends on D26744 Differential Revision: https://phabricator.services.mozilla.com/D26745
47d387b6cd4a2160078c5754c87adb4b0a3add1e: Bug 1479960 - Make AutoMemMap not fstat() the mapped object if it doesn't need to. r=kmag
Jed Davis <jld@mozilla.com> - Thu, 20 Jun 2019 22:40:34 +0000 - rev 479752
Push 36180 by shindli@mozilla.com at Fri, 21 Jun 2019 09:33:06 +0000
Bug 1479960 - Make AutoMemMap not fstat() the mapped object if it doesn't need to. r=kmag One problem with using shared memory instead of files for MemMapSnapshot is that AutoMemMap was trying to use fstat() to obtain the object size; that doesn't work with ashmem on Android and was causing problems with the Mac sandbox, but it's not necessary, because we already know the size. This patch changes it to not do that. Depends on D26743 Differential Revision: https://phabricator.services.mozilla.com/D26744
8332565a694348a31409eec871750bef02cd03d7: Bug 1479960 - Add freezing of IPC shared memory. r=froydnj,kmag
Jed Davis <jld@mozilla.com> - Thu, 20 Jun 2019 22:40:32 +0000 - rev 479751
Push 36180 by shindli@mozilla.com at Fri, 21 Jun 2019 09:33:06 +0000
Bug 1479960 - Add freezing of IPC shared memory. r=froydnj,kmag This allows writing to shared memory and then making it read-only before sharing it to other processes, such that a malicious sandboxed process cannot regain write access. This is currently available only in the low-level base::SharedMemory interface. The freeze operation exposes the common subset of read-only shared memory that we can implement on all supported OSes: with some APIs (POSIX shm_open) we can't revoke writeability from existing capabilies, while for others (Android ashmem) we *must* revoke it. Thus, we require that the writeable capability not have been duplicated or shared to another process, and consume it as part of freezing. Also, because in some backends need special handling at creation time, freezeability must be explicitly requested. In particular, this doesn't allow giving an untrusted process read-only access to memory that the original process can write. Note that on MacOS before 10.12 this will use temporary files in order to avoid an OS security bug that allows regaining write access; those OS versions are no longer supported by Apple (but are supported by Firefox). Depends on D26742 Differential Revision: https://phabricator.services.mozilla.com/D26743
41080844e645c7be1263290bb7c9c6dc0cc5b764: Bug 1479960 - Convert MemMapSnapshot to use frozen shared memory. r=kmag
Jed Davis <jld@mozilla.com> - Mon, 17 Jun 2019 02:20:05 +0000 - rev 479328
Push 36178 by aiakab@mozilla.com at Thu, 20 Jun 2019 21:50:59 +0000
Bug 1479960 - Convert MemMapSnapshot to use frozen shared memory. r=kmag Depends on D26745 Differential Revision: https://phabricator.services.mozilla.com/D26746
fdba3c5f8fd0ad4609117645caae72e5524ea27b: Bug 1479960 - Give SharedStringMap a magic number so that all zeroes isn't a valid instance. r=kmag
Jed Davis <jld@mozilla.com> - Mon, 17 Jun 2019 02:19:57 +0000 - rev 479327
Push 36178 by aiakab@mozilla.com at Thu, 20 Jun 2019 21:50:59 +0000
Bug 1479960 - Give SharedStringMap a magic number so that all zeroes isn't a valid instance. r=kmag There was a strange bug when converting SharedStringMap to use shared memory: on Android, some tests would fail because a pref wasn't set or there was something wrong with an expected error message. The root cause was that mapping ashmem with MAP_PRIVATE results in all zeroes (see bug 1525803), but that was read as a valid SharedStringMap with length 0. To prevent any possible future issues like that, this patch adds a nonzero magic number to the header. It fits into padding on 64-bit and the cost of setting and checking it should be essentially free. Depends on D26744 Differential Revision: https://phabricator.services.mozilla.com/D26745
26a8ebcb2db4555b03ebc189bb8931a34455eb3d: Bug 1479960 - Make AutoMemMap not fstat() the mapped object if it doesn't need to. r=kmag
Jed Davis <jld@mozilla.com> - Mon, 17 Jun 2019 02:19:55 +0000 - rev 479326
Push 36178 by aiakab@mozilla.com at Thu, 20 Jun 2019 21:50:59 +0000
Bug 1479960 - Make AutoMemMap not fstat() the mapped object if it doesn't need to. r=kmag One problem with using shared memory instead of files for MemMapSnapshot is that AutoMemMap was trying to use fstat() to obtain the object size; that doesn't work with ashmem on Android and was causing problems with the Mac sandbox, but it's not necessary, because we already know the size. This patch changes it to not do that. Depends on D26743 Differential Revision: https://phabricator.services.mozilla.com/D26744
d0d383e5bae129d20e2cb7712a0c6ec9ff4def93: Bug 1479960 - Add freezing of IPC shared memory. r=froydnj,kmag
Jed Davis <jld@mozilla.com> - Thu, 20 Jun 2019 16:05:13 +0000 - rev 479325
Push 36178 by aiakab@mozilla.com at Thu, 20 Jun 2019 21:50:59 +0000
Bug 1479960 - Add freezing of IPC shared memory. r=froydnj,kmag This allows writing to shared memory and then making it read-only before sharing it to other processes, such that a malicious sandboxed process cannot regain write access. This is currently available only in the low-level base::SharedMemory interface. The freeze operation exposes the common subset of read-only shared memory that we can implement on all supported OSes: with some APIs (POSIX shm_open) we can't revoke writeability from existing capabilies, while for others (Android ashmem) we *must* revoke it. Thus, we require that the writeable capability not have been duplicated or shared to another process, and consume it as part of freezing. Also, because in some backends need special handling at creation time, freezeability must be explicitly requested. In particular, this doesn't allow giving an untrusted process read-only access to memory that the original process can write. Note that on MacOS before 10.12 this will use temporary files in order to avoid an OS security bug that allows regaining write access; those OS versions are no longer supported by Apple (but are supported by Firefox). Depends on D26742 Differential Revision: https://phabricator.services.mozilla.com/D26743
3c83d9936c2c2b2ecaf2944db29f2ecb56950cf3: Bug 1559275 - Use JS::CompileOptions in AsyncScriptCompiler. r=kmag
Ted Campbell <tcampbell@mozilla.com> - Wed, 19 Jun 2019 00:27:41 +0000 - rev 479166
Push 36172 by rgurzau@mozilla.com at Wed, 19 Jun 2019 09:55:37 +0000
Bug 1559275 - Use JS::CompileOptions in AsyncScriptCompiler. r=kmag Initializing OwningCompileOptions directly will soon be deprecated in order to have consistent defaults. This results in more consistent behavior of experimental features that are enabled based on realm flags. Differential Revision: https://phabricator.services.mozilla.com/D35071
496c1e094336f6658e6f961ae3ab108ed56d2927: Bug 1533308 - Report rejected non-exception objects to the console, r=kmag,arai.
Brian Hackett <bhackett1024@gmail.com> - Tue, 11 Jun 2019 11:53:27 -1000 - rev 479012
Push 36156 by apavel@mozilla.com at Sat, 15 Jun 2019 09:57:03 +0000
Bug 1533308 - Report rejected non-exception objects to the console, r=kmag,arai.
c89f432a864f7ffb4a6f4f78aab550a99f505cd5: Bug 1540368 Fix XPIDatabase migration when skipping schema versions r=kmag
Andrew Swan <aswan@mozilla.com> - Wed, 12 Jun 2019 16:56:04 +0000 - rev 478455
Push 36143 by aciure@mozilla.com at Wed, 12 Jun 2019 21:41:19 +0000
Bug 1540368 Fix XPIDatabase migration when skipping schema versions r=kmag Differential Revision: https://phabricator.services.mozilla.com/D34424
54a97cd3d2e6ad6ffac30efebf48ea1d527cb747: Bug 1551490 - Fix test failures with inline options in HTML about:addons r=kmag
Rob Wu <rob@robwu.nl> - Sun, 09 Jun 2019 11:18:54 +0000 - rev 478010
Push 36133 by rmaries@mozilla.com at Mon, 10 Jun 2019 09:38:15 +0000
Bug 1551490 - Fix test failures with inline options in HTML about:addons r=kmag Differential Revision: https://phabricator.services.mozilla.com/D34078
8c02c8dfd2373fda7faba9a06b898a0ecbb981ec: Bug 1551490 - Disable HTML about:addons on legacy XUL about:addons tests. r=kmag,rpl
Luca Greco <lgreco@mozilla.com> - Sat, 08 Jun 2019 16:03:59 +0000 - rev 478009
Push 36133 by rmaries@mozilla.com at Mon, 10 Jun 2019 09:38:15 +0000
Bug 1551490 - Disable HTML about:addons on legacy XUL about:addons tests. r=kmag,rpl Depends on D31782 Differential Revision: https://phabricator.services.mozilla.com/D31789
a9b1a1ab0ec51f5ba72ff2f493e18fec73868458: Bug 1551490 - Rename browser_bug562797 to browser_history_navigation and run on XUL and HTML about:addons. r=kmag,rpl
Luca Greco <lgreco@mozilla.com> - Sun, 09 Jun 2019 23:50:18 +0000 - rev 478008
Push 36133 by rmaries@mozilla.com at Mon, 10 Jun 2019 09:38:15 +0000
Bug 1551490 - Rename browser_bug562797 to browser_history_navigation and run on XUL and HTML about:addons. r=kmag,rpl Depends on D31780 Differential Revision: https://phabricator.services.mozilla.com/D31782
92b3d4c40e67f9b98e589fabe0b57863520a485d: Bug 1551490 - Fix browser_dragdrop.js and fold browser_dragdrop_incompat into it. r=kmag
Luca Greco <lgreco@mozilla.com> - Fri, 24 May 2019 16:07:07 +0000 - rev 478007
Push 36133 by rmaries@mozilla.com at Mon, 10 Jun 2019 09:38:15 +0000
Bug 1551490 - Fix browser_dragdrop.js and fold browser_dragdrop_incompat into it. r=kmag Depends on D31779 Differential Revision: https://phabricator.services.mozilla.com/D31780
89603d14c1def68aa175fed7480d766cf7475e2b: Bug 1555662 - Register L10nRegistry sources using categories. r=kmag
Zibi Braniecki <zbraniecki@mozilla.com> - Sat, 08 Jun 2019 04:37:31 +0000 - rev 477958
Push 36129 by ncsoregi@mozilla.com at Sun, 09 Jun 2019 09:06:18 +0000
Bug 1555662 - Register L10nRegistry sources using categories. r=kmag Differential Revision: https://phabricator.services.mozilla.com/D34227
9b1b87784a6fe458877e8833f1487a14282aed3a: Bug 1555662 - Register L10nRegistry sources using categories. r=kmag
Zibi Braniecki <zbraniecki@mozilla.com> - Fri, 07 Jun 2019 20:11:00 +0000 - rev 477953
Push 36128 by nbeleuzu@mozilla.com at Sat, 08 Jun 2019 09:42:03 +0000
Bug 1555662 - Register L10nRegistry sources using categories. r=kmag Differential Revision: https://phabricator.services.mozilla.com/D34227
d08ae3b73857fa05a83bcd320022481cf6684018: Bug 1505909 - Don't forward non-existant contextmenu messages to the main window from about:addons. r=mixedpuppy,kmag
Mike Conley <mconley@mozilla.com> - Sat, 08 Jun 2019 01:11:14 +0000 - rev 477935
Push 36127 by nbeleuzu@mozilla.com at Sat, 08 Jun 2019 09:39:25 +0000
Bug 1505909 - Don't forward non-existant contextmenu messages to the main window from about:addons. r=mixedpuppy,kmag Differential Revision: https://phabricator.services.mozilla.com/D33166
ede8b931ee0da1fc13cd1ca8ad0c567670481088: Bug 1555662 - Register L10nRegistry sources using categories. r=kmag
Zibi Braniecki <zbraniecki@mozilla.com> - Fri, 07 Jun 2019 20:11:00 +0000 - rev 477919
Push 36127 by nbeleuzu@mozilla.com at Sat, 08 Jun 2019 09:39:25 +0000
Bug 1555662 - Register L10nRegistry sources using categories. r=kmag Differential Revision: https://phabricator.services.mozilla.com/D34227
57336967a6c75c6d7070bd4bba81e258977c709b: Bug 1505909 - Don't forward non-existant contextmenu messages to the main window from about:addons. r=mixedpuppy,kmag
Mike Conley <mconley@mozilla.com> - Fri, 07 Jun 2019 14:29:53 +0000 - rev 477843
Push 36125 by apavel@mozilla.com at Fri, 07 Jun 2019 22:00:07 +0000
Bug 1505909 - Don't forward non-existant contextmenu messages to the main window from about:addons. r=mixedpuppy,kmag Differential Revision: https://phabricator.services.mozilla.com/D33166
56449fd37aee9aaf1faf0aeefab2cd80d6c20d03: Bug 1505909 - Don't forward non-existant contextmenu messages to the main window from about:addons. r=mixedpuppy,kmag
Mike Conley <mconley@mozilla.com> - Thu, 06 Jun 2019 20:33:29 +0000 - rev 477727
Push 36121 by dvarga@mozilla.com at Fri, 07 Jun 2019 09:47:19 +0000
Bug 1505909 - Don't forward non-existant contextmenu messages to the main window from about:addons. r=mixedpuppy,kmag Differential Revision: https://phabricator.services.mozilla.com/D33166
c62af311d39b9cc954eec3b7726ab64f11b3a75e: Bug 1547331 - Don't initialize legacy telemetry in GeckoView. r=chutten,kmag
Alessio Placitelli <alessio.placitelli@gmail.com> - Wed, 05 Jun 2019 11:03:57 +0000 - rev 476984
Push 36114 by aiakab@mozilla.com at Wed, 05 Jun 2019 21:59:57 +0000
Bug 1547331 - Don't initialize legacy telemetry in GeckoView. r=chutten,kmag This changes the registration code so that categories are still registered in the manifest (and thus not registered in GeckoView), but the component is still always shipped. Differential Revision: https://phabricator.services.mozilla.com/D33478
6323cc613f96f3d15a515d3aa72b0bcdbba77351: Bug 1548515 - Make quitter wait until we've run idle tasks, r=kmag
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 24 May 2019 12:58:43 +0100 - rev 476700
Push 36105 by cbrindusan@mozilla.com at Tue, 04 Jun 2019 03:48:44 +0000
Bug 1548515 - Make quitter wait until we've run idle tasks, r=kmag Differential Revision: https://phabricator.services.mozilla.com/D32470
a55afb0346770d95e0d978538ce79023597df785: Bug 1551213 - Update commands on show in HTML about:addons r=mixedpuppy,kmag
Mark Striemer <mstriemer@mozilla.com> - Fri, 31 May 2019 22:19:50 +0000 - rev 476474
Push 36095 by dvarga@mozilla.com at Sat, 01 Jun 2019 09:40:47 +0000
Bug 1551213 - Update commands on show in HTML about:addons r=mixedpuppy,kmag Differential Revision: https://phabricator.services.mozilla.com/D33304
e3e8eaff2fd1e5ab4981aa64f7836c861abfe730: Bug 1514809 - Enable userScripts API on release by default r=kmag
Tomislav Jovanovic <tomica@gmail.com> - Fri, 31 May 2019 22:05:17 +0000 - rev 476469
Push 36095 by dvarga@mozilla.com at Sat, 01 Jun 2019 09:40:47 +0000
Bug 1514809 - Enable userScripts API on release by default r=kmag Differential Revision: https://phabricator.services.mozilla.com/D33356
3be150246a0b7c53bbfc39ca995a95ff55027c4a: Bug 1532724 - Part 2: Handle HTML about:addons options page in APIs r=kmag
Mark Striemer <mstriemer@mozilla.com> - Fri, 31 May 2019 16:21:02 +0000 - rev 476459
Push 36095 by dvarga@mozilla.com at Sat, 01 Jun 2019 09:40:47 +0000
Bug 1532724 - Part 2: Handle HTML about:addons options page in APIs r=kmag Differential Revision: https://phabricator.services.mozilla.com/D30731
dc4d628f9cdbaac84a3b3ff92938840a94c7f82c: Bug 1532724 - Part 1: Inline options browser for HTML about:addons details r=rpl,kmag
Mark Striemer <mstriemer@mozilla.com> - Fri, 31 May 2019 14:05:53 +0000 - rev 476458
Push 36095 by dvarga@mozilla.com at Sat, 01 Jun 2019 09:40:47 +0000
Bug 1532724 - Part 1: Inline options browser for HTML about:addons details r=rpl,kmag Differential Revision: https://phabricator.services.mozilla.com/D29787
0b881c6d162006ef2f27f96db695edd434a33739: No bug Add bugzilla component annotations for blocklist r=kmag DONTBUILD
Andrew Swan <aswan@mozilla.com> - Thu, 30 May 2019 09:31:53 -0700 - rev 476370
Push 36093 by archaeopteryx@coole-files.de at Fri, 31 May 2019 17:06:18 +0000
No bug Add bugzilla component annotations for blocklist r=kmag DONTBUILD
27e7793c61a11b96fb854da61830ff785203df64: Bug 1553995 - Improve logging of UpdateTimerManager r=kmag
Mathieu Leplatre <mathieu@mozilla.com> - Fri, 31 May 2019 10:19:27 +0000 - rev 476351
Push 36092 by archaeopteryx@coole-files.de at Fri, 31 May 2019 17:03:46 +0000
Bug 1553995 - Improve logging of UpdateTimerManager r=kmag Differential Revision: https://phabricator.services.mozilla.com/D32548
e2ec538a2cd8bd0c9bee7dc2e460da090ba80eb1: Bug 1553416 - Show system add-ons with shortcuts r=mixedpuppy,kmag
Rob Wu <rob@robwu.nl> - Thu, 30 May 2019 22:44:41 +0000 - rev 476324
Push 36092 by archaeopteryx@coole-files.de at Fri, 31 May 2019 17:03:46 +0000
Bug 1553416 - Show system add-ons with shortcuts r=mixedpuppy,kmag Differential Revision: https://phabricator.services.mozilla.com/D32118
9a811a4d134d5e6e7d17457271d19c5ebc4891af: Bug 1551563 - Hide hidden/builtin extensions in shortcuts view r=mstriemer,mixedpuppy,kmag
Rob Wu <rob@robwu.nl> - Thu, 30 May 2019 22:44:48 +0000 - rev 476323
Push 36092 by archaeopteryx@coole-files.de at Fri, 31 May 2019 17:03:46 +0000
Bug 1551563 - Hide hidden/builtin extensions in shortcuts view r=mstriemer,mixedpuppy,kmag Differential Revision: https://phabricator.services.mozilla.com/D31795
9d69224b5529cbb90bc1b6056921e2547d588643: Bug 1550422 - P13. Add Skip, Once and Live cached preference policy. r=njn,kmag
Jean-Yves Avenard <jyavenard@mozilla.com> - Sun, 26 May 2019 14:29:52 +0000 - rev 475615
Push 36067 by ccoroiu@mozilla.com at Sun, 26 May 2019 21:12:53 +0000
Bug 1550422 - P13. Add Skip, Once and Live cached preference policy. r=njn,kmag This works identically to what gfxPrefs UpdatePolicy offers. Differential Revision: https://phabricator.services.mozilla.com/D31257
d4cbcf4f190095d7c1a78909875038bdf14c0177: Bug 1550422 - P8. Add shared pref serializer/deserializer to VR process. r=kmag,daoshengmu
Jean-Yves Avenard <jyavenard@mozilla.com> - Sat, 25 May 2019 10:12:45 +0000 - rev 475610
Push 36067 by ccoroiu@mozilla.com at Sun, 26 May 2019 21:12:53 +0000
Bug 1550422 - P8. Add shared pref serializer/deserializer to VR process. r=kmag,daoshengmu Differential Revision: https://phabricator.services.mozilla.com/D31016
8ae5ae35d3ced3bfbf895fa62b266bd838327a3b: Bug 1550422 - P2. add shared pref serializer/deserializer to GPU process. r=kmag
Jean-Yves Avenard <jyavenard@mozilla.com> - Sun, 26 May 2019 02:33:12 +0000 - rev 475604
Push 36067 by ccoroiu@mozilla.com at Sun, 26 May 2019 21:12:53 +0000
Bug 1550422 - P2. add shared pref serializer/deserializer to GPU process. r=kmag Differential Revision: https://phabricator.services.mozilla.com/D30587
77d2f80257d192d689db0e52061f129169b7fa53: Bug 1550422 - P13. Add Skip, Once and Live cached preference policy. r=njn,kmag
Jean-Yves Avenard <jyavenard@mozilla.com> - Sat, 25 May 2019 00:03:53 +0000 - rev 475525
Push 36062 by aciure@mozilla.com at Sat, 25 May 2019 09:39:13 +0000
Bug 1550422 - P13. Add Skip, Once and Live cached preference policy. r=njn,kmag This works identically to what gfxPrefs UpdatePolicy offers. Differential Revision: https://phabricator.services.mozilla.com/D31257
6dc82f88333d1c76be3a848afcec72d97e9bf289: Bug 1550422 - P8. Add shared pref serializer/deserializer to VR process. r=kmag,daoshengmu
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 23 May 2019 04:13:07 +0000 - rev 475520
Push 36062 by aciure@mozilla.com at Sat, 25 May 2019 09:39:13 +0000
Bug 1550422 - P8. Add shared pref serializer/deserializer to VR process. r=kmag,daoshengmu Differential Revision: https://phabricator.services.mozilla.com/D31016
7d3c2d48670620bf37673194755164e175f209d3: Bug 1550422 - P2. add shared pref serializer/deserializer to GPU process. r=kmag
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 23 May 2019 04:13:05 +0000 - rev 475514
Push 36062 by aciure@mozilla.com at Sat, 25 May 2019 09:39:13 +0000
Bug 1550422 - P2. add shared pref serializer/deserializer to GPU process. r=kmag Differential Revision: https://phabricator.services.mozilla.com/D30587
9c779a0d65aeaacc948bb8c29dcc3c7e70f521f4: Bug 1510569 - Port onStateChange notifications inside WebProgressChild.jsm to C++ r=baku,kmag
Barret Rennie <barret@brennie.ca> - Thu, 23 May 2019 18:49:08 +0000 - rev 475428
Push 36062 by aciure@mozilla.com at Sat, 25 May 2019 09:39:13 +0000
Bug 1510569 - Port onStateChange notifications inside WebProgressChild.jsm to C++ r=baku,kmag We now also only access the document when the state is nsIWebProgress::STATE_STOP. The comments in the previous code indicated that touching the document inside the event handler when the state is not STATE_STOP would result in the content creating a new about:blank document to retrieve the values from. However, it then went on to do this in another location, causing a document to be created whenever we received an onStateChange event. This should no longer occur. Differential Revision: https://phabricator.services.mozilla.com/D28125
f104f127518e7a5265155186168c02e592cc9080: Bug 1510569 - Keep track of whether we are navigating to a new URI in nsDocShell r=mconley,kmag,qdot
Barret Rennie <barret@brennie.ca> - Thu, 23 May 2019 18:48:48 +0000 - rev 475427
Push 36062 by aciure@mozilla.com at Sat, 25 May 2019 09:39:13 +0000
Bug 1510569 - Keep track of whether we are navigating to a new URI in nsDocShell r=mconley,kmag,qdot Previously the `WebNavigationChild` would keep track of when triggering its `nsIWebNavigation`, `goForward`, `goBack`, `gotoIndex`, and `loadURI` methods. It's `nsIWebNavigation` instance is always an `nsIDocShell` and as part of porting `OnStateChange` and `OnLocationChange` events from `WebProgressChild`/`RemoteWebProgress` to `BrowserChild`/`BrowserParent`, this informations needs to be available from the `BrowserChild`. As it stands, it is currently an expando property on the `WebProgressChild`. Instead of introducing yet another XPCOM interface for the WebProgressChild, we now store this information directly on the `nsDocShell`. Furthermore, instead of having the `WebNavigationChild` manage this part of the `nsDocShell`'s state, we can have the `nsDocShell` manage this state itself so it is always consistent. Differential Revision: https://phabricator.services.mozilla.com/D28124
85f424c7b1f8e0fa584bec06bba5358f11a7722f: Bug 1510569 - Refactor BrowserParent nsIWebProgress handlers r=kmag
Barret Rennie <barret@brennie.ca> - Fri, 24 May 2019 15:45:05 +0000 - rev 475426
Push 36062 by aciure@mozilla.com at Sat, 25 May 2019 09:39:13 +0000
Bug 1510569 - Refactor BrowserParent nsIWebProgress handlers r=kmag The BrowserParent's IPC receive methods for nsIWebProgress events in the BrowserChild were all doing the same set up to ensure they had the correct state to process them. This has now been refactored out into a single method. Differential Revision: https://phabricator.services.mozilla.com/D30730
7718aebfcc5203dd29e5e7609aca8aa8ff1e446c: Bug 1510569 - Only forward nsIWebProgress events to the BrowserParent after the WebProgressChild has loaded r=kmag,mconley
Barret Rennie <barret@brennie.ca> - Thu, 23 May 2019 18:48:18 +0000 - rev 475425
Push 36062 by aciure@mozilla.com at Sat, 25 May 2019 09:39:13 +0000
Bug 1510569 - Only forward nsIWebProgress events to the BrowserParent after the WebProgressChild has loaded r=kmag,mconley Before the WebProgress event handlers started migrating to C++, the parent process would only receive WebProgress events after the child process had finished loading the WebProgressChild script. Now that listeners are registered much earlier (before the BrowserChild has finished setting up its frame scripts), the BrowserParent would receive WebProgress events that were heretofore not received unless the BrowserChild was *very* careful about when it sent the IPC messages. However, even while being very careful, the OnStateChange event handler would always fire events for initial about:blank loads that break a lot of unit tests. Before porting that event, we are now ensuring that the WebProgressChild has finished loading before the BrowserChild will send IPC messages for these events to the BrowserParent. Differential Revision: https://phabricator.services.mozilla.com/D30252
be1723043e976056d8cbb139912c9f2a325e190e: Bug 1543384 - Fix race in extension state setter r=kmag
Rob Wu <rob@robwu.nl> - Thu, 23 May 2019 20:39:13 +0000 - rev 475292
Push 36059 by csabou@mozilla.com at Fri, 24 May 2019 09:53:37 +0000
Bug 1543384 - Fix race in extension state setter r=kmag As a side effect of this patch, the format of the "state" value of "async shutdown timeout" crash reports will change, as follows: "Run manifest: " has been replaced with "Run manifest, ": ``` - Startup: Run manifest: asyncEmitManifestEntry("background") + Startup: Run manifest, asyncEmitManifestEntry("background") ``` Multiple states are now separated by ", " instead of ",": ``` - Startup: Run manifest: manifest_name,manifest_version + Startup: Run manifest, manifest_name, manifest_version ``` "Run manifest" will always have a "Startup: " in front of it: ``` - Startup: Emit Startup,Run manifest + Startup: Emit Startup, Startup: Run manifest ``` And removed the `manifest_*` event dispatch since it has no listeners. Differential Revision: https://phabricator.services.mozilla.com/D26986
f781d415cef6c8fce8abeaf8d93cfb52ee4aa8cb: Bug 1550422 - P13. Add Skip, Once and Live cached preference policy. r=njn,kmag
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 22 May 2019 16:59:29 +0000 - rev 475074
Push 36054 by dvarga@mozilla.com at Thu, 23 May 2019 15:52:15 +0000
Bug 1550422 - P13. Add Skip, Once and Live cached preference policy. r=njn,kmag This works identically to what gfxPrefs UpdatePolicy offers. Differential Revision: https://phabricator.services.mozilla.com/D31257
10c153ddbaea7474d33e781eab9996d589ac32ca: Bug 1550422 - P8. Add shared pref serializer/deserializer to VR process. r=kmag,daoshengmu
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 22 May 2019 13:23:07 +0000 - rev 475069
Push 36054 by dvarga@mozilla.com at Thu, 23 May 2019 15:52:15 +0000
Bug 1550422 - P8. Add shared pref serializer/deserializer to VR process. r=kmag,daoshengmu Differential Revision: https://phabricator.services.mozilla.com/D31016
ca47ef6c59f7f25ee070e0bce5f459de6ae84c78: Bug 1550422 - P2. add shared pref serializer/deserializer to GPU process. r=kmag
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 22 May 2019 13:05:09 +0000 - rev 475063
Push 36054 by dvarga@mozilla.com at Thu, 23 May 2019 15:52:15 +0000
Bug 1550422 - P2. add shared pref serializer/deserializer to GPU process. r=kmag Differential Revision: https://phabricator.services.mozilla.com/D30587
fe4c28957f15f8f17707ff13866663b2321d5a12: Bug 1552537 - Include preferences option for plugins r=kmag
Mark Striemer <mstriemer@mozilla.com> - Wed, 22 May 2019 20:01:52 +0000 - rev 475045
Push 36054 by dvarga@mozilla.com at Thu, 23 May 2019 15:52:15 +0000
Bug 1552537 - Include preferences option for plugins r=kmag Differential Revision: https://phabricator.services.mozilla.com/D31707
756519a7cf79069510c83d82f7616a5cf5aa741e: Bug 1510569 - Port onStateChange notifications inside WebProgressChild.jsm to C++ r=baku,kmag
Barret Rennie <barret@brennie.ca> - Tue, 21 May 2019 21:35:04 +0000 - rev 475034
Push 36054 by dvarga@mozilla.com at Thu, 23 May 2019 15:52:15 +0000
Bug 1510569 - Port onStateChange notifications inside WebProgressChild.jsm to C++ r=baku,kmag We now also only access the document when the state is nsIWebProgress::STATE_STOP. The comments in the previous code indicated that touching the document inside the event handler when the state is not STATE_STOP would result in the content creating a new about:blank document to retrieve the values from. However, it then went on to do this in another location, causing a document to be created whenever we received an onStateChange event. This should no longer occur. Differential Revision: https://phabricator.services.mozilla.com/D28125
39c6818fdb12675afb6f25cdb467b54e02f907d2: Bug 1510569 - Keep track of whether we are navigating to a new URI in nsDocShell r=mconley,kmag,qdot
Barret Rennie <barret@brennie.ca> - Tue, 21 May 2019 21:34:54 +0000 - rev 475033
Push 36054 by dvarga@mozilla.com at Thu, 23 May 2019 15:52:15 +0000
Bug 1510569 - Keep track of whether we are navigating to a new URI in nsDocShell r=mconley,kmag,qdot Previously the `WebNavigationChild` would keep track of when triggering its `nsIWebNavigation`, `goForward`, `goBack`, `gotoIndex`, and `loadURI` methods. It's `nsIWebNavigation` instance is always an `nsIDocShell` and as part of porting `OnStateChange` and `OnLocationChange` events from `WebProgressChild`/`RemoteWebProgress` to `BrowserChild`/`BrowserParent`, this informations needs to be available from the `BrowserChild`. As it stands, it is currently an expando property on the `WebProgressChild`. Instead of introducing yet another XPCOM interface for the WebProgressChild, we now store this information directly on the `nsDocShell`. Furthermore, instead of having the `WebNavigationChild` manage this part of the `nsDocShell`'s state, we can have the `nsDocShell` manage this state itself so it is always consistent. Differential Revision: https://phabricator.services.mozilla.com/D28124
3d9715a5ecd43cf7414133b5aae5e537f333231f: Bug 1510569 - Refactor BrowserParent nsIWebProgress handlers r=kmag
Barret Rennie <barret@brennie.ca> - Tue, 21 May 2019 21:34:40 +0000 - rev 475032
Push 36054 by dvarga@mozilla.com at Thu, 23 May 2019 15:52:15 +0000
Bug 1510569 - Refactor BrowserParent nsIWebProgress handlers r=kmag The BrowserParent's IPC receive methods for nsIWebProgress events in the BrowserChild were all doing the same set up to ensure they had the correct state to process them. This has now been refactored out into a single method. Differential Revision: https://phabricator.services.mozilla.com/D30730
418a61f5f87bff0dfceae36f3bbde0a242076cad: Bug 1510569 - Only forward nsIWebProgress events to the BrowserParent after the WebProgressChild has loaded r=kmag,mconley
Barret Rennie <barret@brennie.ca> - Wed, 22 May 2019 17:49:29 +0000 - rev 475031
Push 36054 by dvarga@mozilla.com at Thu, 23 May 2019 15:52:15 +0000
Bug 1510569 - Only forward nsIWebProgress events to the BrowserParent after the WebProgressChild has loaded r=kmag,mconley Before the WebProgress event handlers started migrating to C++, the parent process would only receive WebProgress events after the child process had finished loading the WebProgressChild script. Now that listeners are registered much earlier (before the BrowserChild has finished setting up its frame scripts), the BrowserParent would receive WebProgress events that were heretofore not received unless the BrowserChild was *very* careful about when it sent the IPC messages. However, even while being very careful, the OnStateChange event handler would always fire events for initial about:blank loads that break a lot of unit tests. Before porting that event, we are now ensuring that the WebProgressChild has finished loading before the BrowserChild will send IPC messages for these events to the BrowserParent. Differential Revision: https://phabricator.services.mozilla.com/D30252