searching for reviewer(kats)
0b9e3c47482e1e2ea95eef86f2a2ac0b258bcd45: Bug 1665764 - Expose in about:support hardware stretching support and scaling status. r=kats
Andrew Osmond <aosmond@mozilla.com> - Fri, 18 Sep 2020 15:56:12 +0000 - rev 549324
Push 37794 by btara@mozilla.com at Fri, 18 Sep 2020 21:14:11 +0000
Bug 1665764 - Expose in about:support hardware stretching support and scaling status. r=kats Differential Revision: https://phabricator.services.mozilla.com/D90703
c966611ae0ad67660f64389416060a4fad060e4d: Bug 1665326. Make the APZ pure relative scroll path in ScrollFrameHelper::ScrollBy handle ScrollUnit::WHOLE scrolls as well. r=kats
Timothy Nikkel <tnikkel@gmail.com> - Thu, 17 Sep 2020 12:34:49 +0000 - rev 549230
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1665326. Make the APZ pure relative scroll path in ScrollFrameHelper::ScrollBy handle ScrollUnit::WHOLE scrolls as well. r=kats Differential Revision: https://phabricator.services.mozilla.com/D90371
018626d3fbfd60d25326128790c365472158fb05: Bug 1665648 - Initialize GPU process config before WebRender. r=kats
Andrew Osmond <aosmond@mozilla.com> - Thu, 17 Sep 2020 14:04:24 +0000 - rev 549175
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1665648 - Initialize GPU process config before WebRender. r=kats We need to initialize the GPU process config before WebRender because we have a dependency on the GPU process to enable WebRender. Without this patch, it gives very confusing initialization failures, which it should be clear that it was disabled because there is no GPU process. The GPU process feature itself will then have a clear reason why it was disabled, typically because Windows did not support remote windowing (e.g. too old). Differential Revision: https://phabricator.services.mozilla.com/D90564
016c30822cea1a36e95cf74f4dc0cbac04003b68: Bug 1662894 - Expand fuzzy range for mix-blend-mode-and-filter.svg; r=kats
Geoff Brown <whole.grains@protonmail.com> - Thu, 17 Sep 2020 10:41:00 +0000 - rev 549171
Push 37792 by malexandru@mozilla.com at Fri, 18 Sep 2020 09:45:00 +0000
Bug 1662894 - Expand fuzzy range for mix-blend-mode-and-filter.svg; r=kats Update fuzzy range by +1 to avoid frequent intermittent failures in this test. Differential Revision: https://phabricator.services.mozilla.com/D90507
092dc1009fdf4cfa2619894ddb2a7a820e0cb5f3: Bug 1664802 - Avoid data race in accessing APZCTreeManager::mCurrentMousePosition. r=kats
Botond Ballo <botond@mozilla.com> - Wed, 16 Sep 2020 22:49:44 +0000 - rev 549028
Push 37790 by btara@mozilla.com at Thu, 17 Sep 2020 10:09:40 +0000
Bug 1664802 - Avoid data race in accessing APZCTreeManager::mCurrentMousePosition. r=kats Differential Revision: https://phabricator.services.mozilla.com/D90491
8c19ed451d123a3ffb58d616035e6179ce54d147: Bug 1661117 - Switch to Mesa 20 r=gw,kats
Dzmitry Malyshau <dmalyshau@mozilla.com> - Tue, 15 Sep 2020 19:37:28 +0000 - rev 548812
Push 37787 by malexandru@mozilla.com at Wed, 16 Sep 2020 09:56:56 +0000
Bug 1661117 - Switch to Mesa 20 r=gw,kats updates to https://github.com/servo/osmesa-src PRs: 40, 41, 42 Differential Revision: https://phabricator.services.mozilla.com/D88448
01991b20e8a2505b6b6edd41015f915fdacca01b: Bug 1665064 - Honor print background image settings on WebRender too. r=kats,jwatt CLOSED TREE
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 15 Sep 2020 16:26:05 +0000 - rev 548811
Push 37787 by malexandru@mozilla.com at Wed, 16 Sep 2020 09:56:56 +0000
Bug 1665064 - Honor print background image settings on WebRender too. r=kats,jwatt CLOSED TREE We usually suppress background images in nsCSSRendering::PaintStyleImageLayerWithSC, but that codepath isn't hit by WebRender, so instead do it during display list building, the same way we suppress background colors. Differential Revision: https://phabricator.services.mozilla.com/D90278
a572a639204f2d4fef44548dd7552f5b626517a0: Bug 1665064 - Honor print background image settings on WebRender too. r=kats,jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 15 Sep 2020 16:26:05 +0000 - rev 548766
Push 37787 by malexandru@mozilla.com at Wed, 16 Sep 2020 09:56:56 +0000
Bug 1665064 - Honor print background image settings on WebRender too. r=kats,jwatt We usually suppress background images in nsCSSRendering::PaintStyleImageLayerWithSC, but that codepath isn't hit by WebRender, so instead do it during display list building, the same way we suppress background colors. Differential Revision: https://phabricator.services.mozilla.com/D90278
9dd986a71b7171ce2b27b6c8c27e4b3e4c6dcdc6: Bug 1664419. Need to suppress scrollbar repaint when seting visual viewport offset. r=kats,botond
Timothy Nikkel <tnikkel@gmail.com> - Mon, 14 Sep 2020 21:38:25 +0000 - rev 548669
Push 37786 by nerli@mozilla.com at Tue, 15 Sep 2020 15:47:19 +0000
Bug 1664419. Need to suppress scrollbar repaint when seting visual viewport offset. r=kats,botond In ScrollFrameHelper::ScrollToImpl we suppress repainting scrollbars when calling UpdateScrollbarPosition if we've decided not to schedule a paint (because we are sending a pending scroll update instead). Otherwise we repaint which is what we are trying to avoid. The desktop zooming scrollbars code added a call to UpdateScrollbarPosition in SetVisualViewportOffset because the vv offset is what determines the scrollbar position, no longer the layout scroll position. This means that we can trigger a repaint via that path, and there is a test that checks that we don't. This patch moves the SetVisualViewportOffset call to just after the code that determines if we need to schedule a paint (it was just before it), and then add the AutoScrollbarRepaintSuppression class. Differential Revision: https://phabricator.services.mozilla.com/D89902
de1e92b1db17ee00871213ed87e4631ecb5a8f95: Bug 1663537. Use overlay scrollbars in a few reftests. r=kats
Timothy Nikkel <tnikkel@gmail.com> - Thu, 10 Sep 2020 21:19:34 +0000 - rev 548637
Push 37786 by nerli@mozilla.com at Tue, 15 Sep 2020 15:47:19 +0000
Bug 1663537. Use overlay scrollbars in a few reftests. r=kats All of these reftests end up using a minimum scale with layout/classic scrollbars. (They hit the assert from the patch in bug 1663534.) Some of them are only written with overlay scrollbars in mind (for example overflow-hidden-region-with-negative-left-positioned-element.html which I looked at in detail). The change that causes them to fail is the code in nsHTMLScrollFrame::TryLayout that decides if we need scrollbars. Before desktop zooming scrollbars we compared the visual viewport size and the scrolled rect size. With desktop zooming scrollbars we compare the (layout) scrollport and the scrolled rect to determine if we need regular scrollbars and then compare the visual viewport size to the (layout) scrollport to determine if we need scrollbars to scroll the visual viewport inside the scrollport. Then can get different results. Differential Revision: https://phabricator.services.mozilla.com/D89407
cb92660b87e5a63ed15e7c2f6b47f03a549d82c6: Bug 1663562. Call MaybeReflowForInflationScreenSizeChange when any prefs that could affect font inflation change. r=kats
Timothy Nikkel <tnikkel@gmail.com> - Tue, 15 Sep 2020 04:33:38 +0000 - rev 548635
Push 37786 by nerli@mozilla.com at Tue, 15 Sep 2020 15:47:19 +0000
Bug 1663562. Call MaybeReflowForInflationScreenSizeChange when any prefs that could affect font inflation change. r=kats When I start setting the pref ui.useOverlayScrollbars in bug 1663537 we trigger this assert ``` ###!!! ASSERTION: can't mark frame dirty during reflow: '!mIsReflowing', file /builds/worker/checkouts/gecko/layout/base/PresShell.cpp, line 2677 #01: mozilla::PresShell::MaybeReflowForInflationScreenSizeChange() [layout/base/PresShell.cpp:11148] #02: mozilla::PresShell::CompleteChangeToVisualViewportSize() [layout/base/PresShell.cpp:11177] #03: MobileViewportManager::UpdateVisualViewportSize(mozilla::gfx::IntSizeTyped<mozilla::ScreenPixel> const&, mozilla::gfx::ScaleFactor<mozilla::CSSPixel, mozilla::ScreenPixel> const&) [layout/base/MobileViewportManager.cpp:504] #04: MobileViewportManager::RefreshVisualViewportSize() [layout/base/MobileViewportManager.cpp:557] #05: nsHTMLScrollFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) [layout/generic/nsGfxScrollFrame.cpp:1340] #06: nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, int, int, nsIFrame::ReflowChildFlags, nsReflowStatus&, nsOverflowContinuationTracker*) [layout/generic/nsContainerFrame.cpp:1115] #07: mozilla::ViewportFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) [layout/generic/ViewportFrame.cpp:297] #08: mozilla::PresShell::DoReflow(nsIFrame*, bool, mozilla::OverflowChangedTracker*) [layout/base/PresShell.cpp:9650] #09: mozilla::PresShell::ProcessReflowCommands(bool) [layout/base/PresShell.cpp:9816] #10: mozilla::PresShell::DoFlushPendingNotifications(mozilla::ChangesToFlush) [layout/base/PresShell.cpp:4239] #11: nsRefreshDriver::Tick(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) [layout/base/nsRefreshDriver.cpp:2139] ``` This happens after the test is finish when we unset the ui.useOverlayScrollbars pref which (I'm assuming because it must) causes reflow. When running a font-inflation related reftest we also unset the font inflation related prefs that were specified in the reftest.list file. This causes font-inflation to go from enabled to disabled and we detect that for the first time while reflowing the scroll frame. Instead we should reflow when any pref that could affect font inflation is changed. I scanned the font-inflation code in PresShell and Document::GetViewportInfo for prefs are consulted, but I didn't go a super exhaustive search. Differential Revision: https://phabricator.services.mozilla.com/D89409
57470917615238e6a9a0ab2648e6b607ad8064de: Bug 1663562. Call MaybeReflowForInflationScreenSizeChange when any prefs that could affect font inflation change. r=kats
Timothy Nikkel <tnikkel@gmail.com> - Mon, 14 Sep 2020 22:19:09 +0000 - rev 548629
Push 37786 by nerli@mozilla.com at Tue, 15 Sep 2020 15:47:19 +0000
Bug 1663562. Call MaybeReflowForInflationScreenSizeChange when any prefs that could affect font inflation change. r=kats When I start setting the pref ui.useOverlayScrollbars in bug 1663537 we trigger this assert ``` ###!!! ASSERTION: can't mark frame dirty during reflow: '!mIsReflowing', file /builds/worker/checkouts/gecko/layout/base/PresShell.cpp, line 2677 #01: mozilla::PresShell::MaybeReflowForInflationScreenSizeChange() [layout/base/PresShell.cpp:11148] #02: mozilla::PresShell::CompleteChangeToVisualViewportSize() [layout/base/PresShell.cpp:11177] #03: MobileViewportManager::UpdateVisualViewportSize(mozilla::gfx::IntSizeTyped<mozilla::ScreenPixel> const&, mozilla::gfx::ScaleFactor<mozilla::CSSPixel, mozilla::ScreenPixel> const&) [layout/base/MobileViewportManager.cpp:504] #04: MobileViewportManager::RefreshVisualViewportSize() [layout/base/MobileViewportManager.cpp:557] #05: nsHTMLScrollFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) [layout/generic/nsGfxScrollFrame.cpp:1340] #06: nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, int, int, nsIFrame::ReflowChildFlags, nsReflowStatus&, nsOverflowContinuationTracker*) [layout/generic/nsContainerFrame.cpp:1115] #07: mozilla::ViewportFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) [layout/generic/ViewportFrame.cpp:297] #08: mozilla::PresShell::DoReflow(nsIFrame*, bool, mozilla::OverflowChangedTracker*) [layout/base/PresShell.cpp:9650] #09: mozilla::PresShell::ProcessReflowCommands(bool) [layout/base/PresShell.cpp:9816] #10: mozilla::PresShell::DoFlushPendingNotifications(mozilla::ChangesToFlush) [layout/base/PresShell.cpp:4239] #11: nsRefreshDriver::Tick(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) [layout/base/nsRefreshDriver.cpp:2139] ``` This happens after the test is finish when we unset the ui.useOverlayScrollbars pref which (I'm assuming because it must) causes reflow. When running a font-inflation related reftest we also unset the font inflation related prefs that were specified in the reftest.list file. This causes font-inflation to go from enabled to disabled and we detect that for the first time while reflowing the scroll frame. Instead we should reflow when any pref that could affect font inflation is changed. I scanned the font-inflation code in PresShell and Document::GetViewportInfo for prefs are consulted, but I didn't go a super exhaustive search. Differential Revision: https://phabricator.services.mozilla.com/D89409
7849377294cb0380ff910a0f3ffce05adc013002: Bug 1664661. Make ScrollFrameHelper::UpdateScrollbarPosition use the same calculation for scrollbar attributes as ScrollFrameHelper::ReflowFinished. r=kats
Timothy Nikkel <tnikkel@gmail.com> - Sun, 13 Sep 2020 15:27:34 +0000 - rev 548478
Push 37782 by ccoroiu@mozilla.com at Mon, 14 Sep 2020 16:07:13 +0000
Bug 1664661. Make ScrollFrameHelper::UpdateScrollbarPosition use the same calculation for scrollbar attributes as ScrollFrameHelper::ReflowFinished. r=kats UpdateScrollbarPosition should have been using scroll range and not scrolled rect for a long time. It didn't matter because we only used the top left of the rect which matched until bug 1654933 made GetScrollRangeForUserInputEvents return a rect that wasn't located at 0,0. Differential Revision: https://phabricator.services.mozilla.com/D90031
f51b6c3688a43eeb552349f171c4fa4c8a35d797: Bug 1664446. Properly wait to make sure any potential scroll events get fired in several tests. r=kats
Timothy Nikkel <tnikkel@gmail.com> - Sun, 13 Sep 2020 20:21:11 +0000 - rev 548466
Push 37781 by dluca@mozilla.com at Mon, 14 Sep 2020 09:51:01 +0000
Bug 1664446. Properly wait to make sure any potential scroll events get fired in several tests. r=kats Doing rAF rAF flushApzRepaints is not enough to make sure that any potential scroll events are sent to content. The reason is that if the apz repaint request causes us to do scrolling on the main thread then the scrolling will be finished after flushApzRepaints, and the scroll event will be pending, but it's not sent until the next refresh driver tick. So we need to do at least one rAF after flushApzRepaints. Differential Revision: https://phabricator.services.mozilla.com/D90035
375219cab02b14a616fbdc01914ea13eb7c573b6: Bug 1655130. Handle non-smooth scrolling with desktop zooming scrollbars. r=kats
Timothy Nikkel <tnikkel@gmail.com> - Sun, 13 Sep 2020 08:31:54 +0000 - rev 548457
Push 37780 by btara@mozilla.com at Sun, 13 Sep 2020 21:38:03 +0000
Bug 1655130. Handle non-smooth scrolling with desktop zooming scrollbars. r=kats Differential Revision: https://phabricator.services.mozilla.com/D89408
88f3ed4eed62fb4715e98d057958e37dfc67850d: Bug 1661117 - Switch to Mesa 20 r=gw,kats
Dzmitry Malyshau <dmalyshau@mozilla.com> - Fri, 11 Sep 2020 20:16:56 +0000 - rev 548396
Push 37778 by ccoroiu@mozilla.com at Sat, 12 Sep 2020 09:26:23 +0000
Bug 1661117 - Switch to Mesa 20 r=gw,kats updates to https://github.com/servo/osmesa-src PRs: 40, 41, 42 Differential Revision: https://phabricator.services.mozilla.com/D88448
30cd33572b3d5c4bfa8e5883396dc3aa84a62e0b: Bug 1663537. Fix various tests for desktop zooming scrollbars. r=kats
Timothy Nikkel <tnikkel@gmail.com> - Fri, 11 Sep 2020 10:45:28 +0000 - rev 548296
Push 37776 by btara@mozilla.com at Fri, 11 Sep 2020 15:10:42 +0000
Bug 1663537. Fix various tests for desktop zooming scrollbars. r=kats The test fixes all fell into the follow categories: A) The test uses requestAnimationFrame to wait one frame and expects scrolling to be complete. With the desktop zooming scrollbars in order for the scrolling to show up on the main thread we need to send the scroll request to the compositor and then hear back from it via an apz repaint request (apz callback helper). Waiting on requestAnimationFrame will complete the first part, but not necessarily the second part. The fix is to wait for a scroll event. B) Switching tests to wait for scroll events exposes another problem: the test can do things that cause a scroll in order to setup the test (and that may not be obvious that it causes a scroll) before actually proceeding to do the test and do something that causes a scroll and then checks for the scroll change of the second thing. Waiting for a requestAnimationFrame would include both those scrolls without desktop zooming scrollbars, but if we wait for a scroll event we will get the scroll event for the first thing which we are not interested in. So we need to make sure scroll events are cleared out before waiting for any scroll events. We do this by waiting two requestAnimationFrame's and waiting for apz to be flushed. We also use this when a test does something and it wants to test that scrolling is not performed. The main thing that causes scrolling that may not be obvious: calling node.focus(). With stacks like: from test_scroll_per_page.html ``` #01: mozilla::ScrollFrameHelper::CompleteAsyncScroll(nsRect const&, mozilla::ScrollOrigin) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x47d6cc0] #02: mozilla::ScrollFrameHelper::ScrollToWithOrigin(nsPoint, mozilla::ScrollMode, mozilla::ScrollOrigin, nsRect const*, nsIScrollbarMediator::ScrollSnapMode) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x47d7732] #03: mozilla::layout::ScrollAnchorContainer::ApplyAdjustments() [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x4742913] #04: mozilla::PresShell::FlushPendingScrollAnchorAdjustments() [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x4650069] #05: mozilla::PresShell::ProcessReflowCommands(bool) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x465742b] #06: mozilla::PresShell::DoFlushPendingNotifications(mozilla::ChangesToFlush) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x4656af8] #07: mozilla::dom::Document::FlushPendingNotifications(mozilla::ChangesToFlush) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x1a87d3c] #08: mozilla::PresShell::ScrollContentIntoView(nsIContent*, mozilla::ScrollAxis, mozilla::ScrollAxis, mozilla::ScrollFlags) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x4652b96] #09: nsFocusManager::ScrollIntoView(mozilla::PresShell*, nsIContent*, unsigned int) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x1bedd1c] #10: nsFocusManager::Focus(nsPIDOMWindowOuter*, mozilla::dom::Element*, unsigned int, bool, bool, bool, bool, bool, nsIContent*) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x1be6be0] #11: nsFocusManager::SetFocusInner(mozilla::dom::Element*, int, bool, bool) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x1be212f] #12: nsFocusManager::SetFocus(mozilla::dom::Element*, unsigned int) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x1be32ba] #13: mozilla::dom::Element::Focus(mozilla::dom::FocusOptions const&, mozilla::dom::CallerType, mozilla::ErrorResult&) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x1aaf283] #14: mozilla::dom::HTMLElement_Binding::focus(JSContext*, JS::Handle<JSObject*>, void*, JSJitMethodCallArgs const&) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x2d65f3b] ``` from editor/libeditor/tests/test_bug549262.html ``` #01: mozilla::ScrollFrameHelper::CompleteAsyncScroll(nsRect const&, mozilla::ScrollOrigin) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x47d6cc0] #02: mozilla::ScrollFrameHelper::ScrollToWithOrigin(nsPoint, mozilla::ScrollMode, mozilla::ScrollOrigin, nsRect const*, nsIScrollbarMediator::ScrollSnapMode) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x47d7732] #03: mozilla::PresShell::ScrollFrameRectIntoView(nsIFrame*, nsRect const&, mozilla::ScrollAxis, mozilla::ScrollAxis, mozilla::ScrollFlags) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x46541bc] #04: mozilla::PresShell::DoScrollContentIntoView() [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x4653776] #05: mozilla::PresShell::DoFlushPendingNotifications(mozilla::ChangesToFlush) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x4656b11] #06: mozilla::dom::Document::FlushPendingNotifications(mozilla::ChangesToFlush) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x1a87d3c] #07: mozilla::PresShell::ScrollContentIntoView(nsIContent*, mozilla::ScrollAxis, mozilla::ScrollAxis, mozilla::ScrollFlags) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x4652b96] #08: nsFocusManager::ScrollIntoView(mozilla::PresShell*, nsIContent*, unsigned int) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x1bedd1c] #09: nsFocusManager::Focus(nsPIDOMWindowOuter*, mozilla::dom::Element*, unsigned int, bool, bool, bool, bool, bool, nsIContent*) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x1be6be0] #10: nsFocusManager::SetFocusInner(mozilla::dom::Element*, int, bool, bool) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x1be212f] #11: nsFocusManager::SetFocus(mozilla::dom::Element*, unsigned int) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x1be32ba] #12: mozilla::dom::Element::Focus(mozilla::dom::FocusOptions const&, mozilla::dom::CallerType, mozilla::ErrorResult&) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x1aaf283] #13: mozilla::dom::HTMLElement_Binding::focus(JSContext*, JS::Handle<JSObject*>, void*, JSJitMethodCallArgs const&) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x2d65f3b] ``` C) Several tests use nsIDOMWindowUtils advanceTimeAndRefresh/restoreNormalRefresh and expect scrolling to be done after a call to advanceTimeAndRefresh. This is basically A), advanceTimeAndRefresh does a refresh driver tick but doesn't allow a repaint request to come back to the main thread. Differential Revision: https://phabricator.services.mozilla.com/D89403
657830ceac83f3c20b0d3657875175aa7b20003a: Bug 1663537. Use overlay scrollbars in a few reftests. r=kats
Timothy Nikkel <tnikkel@gmail.com> - Tue, 08 Sep 2020 23:47:48 +0000 - rev 547941
Push 37767 by dluca@mozilla.com at Wed, 09 Sep 2020 09:39:57 +0000
Bug 1663537. Use overlay scrollbars in a few reftests. r=kats All of these reftests end up using a minimum scale with layout/classic scrollbars. (They hit the assert from the patch in bug 1663534.) Some of them are only written with overlay scrollbars in mind (for example overflow-hidden-region-with-negative-left-positioned-element.html which I looked at in detail). The change that causes them to fail is the code in nsHTMLScrollFrame::TryLayout that decides if we need scrollbars. Before desktop zooming scrollbars we compared the visual viewport size and the scrolled rect size. With desktop zooming scrollbars we compare the (layout) scrollport and the scrolled rect to determine if we need regular scrollbars and then compare the visual viewport size to the (layout) scrollport to determine if we need scrollbars to scroll the visual viewport inside the scrollport. Then can get different results. Differential Revision: https://phabricator.services.mozilla.com/D89407
6698b842822e238196b46001e4d4770bb8781bec: Bug 1663562. Call MaybeReflowForInflationScreenSizeChange when any prefs that could affect font inflation change. r=kats
Timothy Nikkel <tnikkel@gmail.com> - Tue, 08 Sep 2020 20:03:09 +0000 - rev 547913
Push 37767 by dluca@mozilla.com at Wed, 09 Sep 2020 09:39:57 +0000
Bug 1663562. Call MaybeReflowForInflationScreenSizeChange when any prefs that could affect font inflation change. r=kats When I start setting the pref ui.useOverlayScrollbars in bug 1663537 we trigger this assert ``` ###!!! ASSERTION: can't mark frame dirty during reflow: '!mIsReflowing', file /builds/worker/checkouts/gecko/layout/base/PresShell.cpp, line 2677 #01: mozilla::PresShell::MaybeReflowForInflationScreenSizeChange() [layout/base/PresShell.cpp:11148] #02: mozilla::PresShell::CompleteChangeToVisualViewportSize() [layout/base/PresShell.cpp:11177] #03: MobileViewportManager::UpdateVisualViewportSize(mozilla::gfx::IntSizeTyped<mozilla::ScreenPixel> const&, mozilla::gfx::ScaleFactor<mozilla::CSSPixel, mozilla::ScreenPixel> const&) [layout/base/MobileViewportManager.cpp:504] #04: MobileViewportManager::RefreshVisualViewportSize() [layout/base/MobileViewportManager.cpp:557] #05: nsHTMLScrollFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) [layout/generic/nsGfxScrollFrame.cpp:1340] #06: nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, int, int, nsIFrame::ReflowChildFlags, nsReflowStatus&, nsOverflowContinuationTracker*) [layout/generic/nsContainerFrame.cpp:1115] #07: mozilla::ViewportFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) [layout/generic/ViewportFrame.cpp:297] #08: mozilla::PresShell::DoReflow(nsIFrame*, bool, mozilla::OverflowChangedTracker*) [layout/base/PresShell.cpp:9650] #09: mozilla::PresShell::ProcessReflowCommands(bool) [layout/base/PresShell.cpp:9816] #10: mozilla::PresShell::DoFlushPendingNotifications(mozilla::ChangesToFlush) [layout/base/PresShell.cpp:4239] #11: nsRefreshDriver::Tick(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) [layout/base/nsRefreshDriver.cpp:2139] ``` This happens after the test is finish when we unset the ui.useOverlayScrollbars pref which (I'm assuming because it must) causes reflow. When running a font-inflation related reftest we also unset the font inflation related prefs that were specified in the reftest.list file. This causes font-inflation to go from enabled to disabled and we detect that for the first time while reflowing the scroll frame. Instead we should reflow when any pref that could affect font inflation is changed. I scanned the font-inflation code in PresShell and Document::GetViewportInfo for prefs are consulted, but I didn't go a super exhaustive search. Differential Revision: https://phabricator.services.mozilla.com/D89409
95fc865fc8cfef1cfbfdde8ac099cbc435f63625: Bug 1663537. Use overlay scrollbars in a few reftests. r=kats
Timothy Nikkel <tnikkel@gmail.com> - Tue, 08 Sep 2020 08:27:30 +0000 - rev 547812
Push 37765 by abutkovits@mozilla.com at Tue, 08 Sep 2020 16:13:32 +0000
Bug 1663537. Use overlay scrollbars in a few reftests. r=kats All of these reftests end up using a minimum scale with layout/classic scrollbars. (They hit the assert from the patch in bug 1663534.) Some of them are only written with overlay scrollbars in mind (for example overflow-hidden-region-with-negative-left-positioned-element.html which I looked at in detail). The change that causes them to fail is the code in nsHTMLScrollFrame::TryLayout that decides if we need scrollbars. Before desktop zooming scrollbars we compared the visual viewport size and the scrolled rect size. With desktop zooming scrollbars we compare the (layout) scrollport and the scrolled rect to determine if we need regular scrollbars and then compare the visual viewport size to the (layout) scrollport to determine if we need scrollbars to scroll the visual viewport inside the scrollport. Then can get different results. Differential Revision: https://phabricator.services.mozilla.com/D89407
642018ee31387190c8d61bad7adb432041fbfdc9: Bug 1663532. Support setting/clearing prefs that don't have a default value in the reftest harness. r=kats
Timothy Nikkel <tnikkel@gmail.com> - Tue, 08 Sep 2020 08:45:56 +0000 - rev 547811
Push 37765 by abutkovits@mozilla.com at Tue, 08 Sep 2020 16:13:32 +0000
Bug 1663532. Support setting/clearing prefs that don't have a default value in the reftest harness. r=kats In order to fix bug 1657822 we need to run some reftests with the pref ui.useOverlayScrollbars. This preference doesn't have a default value (it is not set by anything on desktop, it appears only in mobile/android/app/mobile.js and when we set the pref for some mochitests, the look and feel code looks at this pref, which is how we almost (?) always query for overlay scrollbars.). The reftest harness doesn't currently handle this because it gets the current value first and doesn't expect the pref to not exist. Differential Revision: https://phabricator.services.mozilla.com/D89399
51c3ae02e5ebe85771ca162de5ea2a54af15ba9a: Bug 1663535. Handle scroll snapping with desktop zooming scrollbars. r=kats
Timothy Nikkel <tnikkel@gmail.com> - Tue, 08 Sep 2020 08:08:32 +0000 - rev 547809
Push 37765 by abutkovits@mozilla.com at Tue, 08 Sep 2020 16:13:32 +0000
Bug 1663535. Handle scroll snapping with desktop zooming scrollbars. r=kats If we need to snap we just don't use the desktop zooming scrollbar path. A quick look into the scroll snapping code looks like it uses layout only aware things. This should be good enough for now, we can look into supporting scroll snap + pinch zoom later if we need to. Differential Revision: https://phabricator.services.mozilla.com/D89400
397ccd5f59910a64185a2892fba8bad2400fc5ee: Bug 1663537. Fix layout/base/tests/test_scroll_event_ordering.html to work with desktop zooming scrollbars. r=kats
Timothy Nikkel <tnikkel@gmail.com> - Tue, 08 Sep 2020 08:12:25 +0000 - rev 547807
Push 37765 by abutkovits@mozilla.com at Tue, 08 Sep 2020 16:13:32 +0000
Bug 1663537. Fix layout/base/tests/test_scroll_event_ordering.html to work with desktop zooming scrollbars. r=kats sendKey uses our new relative scroll path that does the scroll by the apz. But we don't have any scroll event ordering expectations when apz is doing the scroll. We trade lossing those expectations for smoother apz scrolling. So change the test to use a method that doesn't use our new relative apz scroll path and goes back to main thread scrolling. Differential Revision: https://phabricator.services.mozilla.com/D89402
d871d71f519666171d7c300d585125d98ffd6a4e: Bug 1661108. Only send pan events from DManip if the delta is at least 1. r=kats
Timothy Nikkel <tnikkel@gmail.com> - Fri, 04 Sep 2020 03:27:09 +0000 - rev 547673
Push 37754 by ccoroiu@mozilla.com at Fri, 04 Sep 2020 09:43:41 +0000
Bug 1661108. Only send pan events from DManip if the delta is at least 1. r=kats This seems to match what Chrome does. On macOS we only get sent deltas from the OS that are at least 1. Differential Revision: https://phabricator.services.mozilla.com/D88542
a95c23aa4e100b62e71ceda1014629d77e2e4760: Bug 1661108. Only send pan events from DManip if the delta is at least 1. r=kats
Timothy Nikkel <tnikkel@gmail.com> - Thu, 03 Sep 2020 13:10:38 +0000 - rev 547652
Push 37753 by btara@mozilla.com at Fri, 04 Sep 2020 03:35:04 +0000
Bug 1661108. Only send pan events from DManip if the delta is at least 1. r=kats This seems to match what Chrome does. On macOS we only get sent deltas from the OS that are at least 1. Differential Revision: https://phabricator.services.mozilla.com/D88542
a59319f92fd1b183a3382c5d613a2be3c5db2fed: Bug 1662655 - Elements with pointer event are considered clickable. r=kats
lonocvb <lonocvb@gmail.com> - Thu, 03 Sep 2020 08:03:32 +0000 - rev 547630
Push 37752 by cbrindusan@mozilla.com at Thu, 03 Sep 2020 15:18:16 +0000
Bug 1662655 - Elements with pointer event are considered clickable. r=kats Differential Revision: https://phabricator.services.mozilla.com/D89236
346a825d1ce6ee78605895adbe48ad6e3a635867: Bug 1661531 - Ensure we always update the gfx feature failure reason. r=kats
Andrew Osmond <aosmond@mozilla.com> - Thu, 27 Aug 2020 17:04:27 +0000 - rev 546627
Push 37735 by abutkovits@mozilla.com at Thu, 27 Aug 2020 21:29:40 +0000
Bug 1661531 - Ensure we always update the gfx feature failure reason. r=kats Differential Revision: https://phabricator.services.mozilla.com/D88454
4486accecad143a257e95ee7e318d9fc1c146322: Bug 1659761 - Restrict the fix of bug 1650488 to desktop only. r=kats
Botond Ballo <botond@mozilla.com> - Thu, 27 Aug 2020 00:01:07 +0000 - rev 546388
Push 37734 by ccoroiu@mozilla.com at Thu, 27 Aug 2020 09:30:43 +0000
Bug 1659761 - Restrict the fix of bug 1650488 to desktop only. r=kats Differential Revision: https://phabricator.services.mozilla.com/D88356
30a51a3b31acb4c1d0475b51069cd5dd4cc2ae31: Bug 1661356 - Change nsLayoutUtils::ComputeScrollMetadata() to take a scrollport size instead of a scrollport rect. r=kats
Botond Ballo <botond@mozilla.com> - Thu, 27 Aug 2020 01:40:19 +0000 - rev 546387
Push 37734 by ccoroiu@mozilla.com at Thu, 27 Aug 2020 09:30:43 +0000
Bug 1661356 - Change nsLayoutUtils::ComputeScrollMetadata() to take a scrollport size instead of a scrollport rect. r=kats No one meaningfully uses the scrollport rect's origin, so there's no point in having callers compute it. Differential Revision: https://phabricator.services.mozilla.com/D88337
1aa2067bb18315b517a2cdee1c33d4e3b2969eb5: Bug 1661185 - Remove implicit scroll/hit-test APIs. r=kats
Glenn Watson <git@intuitionlibrary.com> - Wed, 26 Aug 2020 20:38:46 +0000 - rev 546359
Push 37734 by ccoroiu@mozilla.com at Thu, 27 Aug 2020 09:30:43 +0000
Bug 1661185 - Remove implicit scroll/hit-test APIs. r=kats Previously, it was possible to instruct WR to find the closest scroll node, and apply a scroll delta to that. However, it's generally the case that there is more context required that the application applies in selecting which frame to scroll. This patch removes the unused APIs, which simplifies some of the hit-testing code. In turn, this simplifies some in-progress optimization and refactoring of the hit-test internals. Differential Revision: https://phabricator.services.mozilla.com/D88234
c1ab9962ae12c983c6aa344cc31ff28bf87d61c3: Bug 1635256 - Avoid unnecessary array copies in NotifyLayerTransforms and SetConfirmedTargetAPZC. r=kats
Botond Ballo <botond@mozilla.com> - Tue, 25 Aug 2020 02:17:06 +0000 - rev 545899
Push 37729 by ccoroiu@mozilla.com at Tue, 25 Aug 2020 09:46:22 +0000
Bug 1635256 - Avoid unnecessary array copies in NotifyLayerTransforms and SetConfirmedTargetAPZC. r=kats Differential Revision: https://phabricator.services.mozilla.com/D88083
86ec8b287a676330cca66c661fdef8efc519e06c: Bug 166061 - Bug 1660661 - adjust svg alpha reftest expectations for windows 10 on hardware. r=kats
Joel Maher <jmaher@mozilla.com> - Sun, 23 Aug 2020 16:04:52 +0000 - rev 545756
Push 37723 by nerli@mozilla.com at Sun, 23 Aug 2020 21:15:33 +0000
Bug 166061 - Bug 1660661 - adjust svg alpha reftest expectations for windows 10 on hardware. r=kats adjust svg alpha reftest expectations for windows 10 on hardware Differential Revision: https://phabricator.services.mozilla.com/D87968
bf45efb282cee760ae78cbfc199c68393cd63e57: Bug 1659973 - Bring back FrameMetrics::mVisualViewportOffset (but call it mVisualDestination). r=kats
Botond Ballo <botond@mozilla.com> - Sat, 22 Aug 2020 22:59:47 +0000 - rev 545738
Push 37722 by ccoroiu@mozilla.com at Sun, 23 Aug 2020 09:31:12 +0000
Bug 1659973 - Bring back FrameMetrics::mVisualViewportOffset (but call it mVisualDestination). r=kats Differential Revision: https://phabricator.services.mozilla.com/D87941
7081efd3ac36173be4420b1e4e836cf0760a97a3: Bug 1659973 - Fix some include-what-you-use errors. r=kats
Botond Ballo <botond@mozilla.com> - Sat, 22 Aug 2020 23:01:06 +0000 - rev 545737
Push 37722 by ccoroiu@mozilla.com at Sun, 23 Aug 2020 09:31:12 +0000
Bug 1659973 - Fix some include-what-you-use errors. r=kats Differential Revision: https://phabricator.services.mozilla.com/D87940
5718234b1f27780b0d98ca4e6f1a22e1b012205a: Bug 1660211 - Respect iterator invalidation rules in ComputeClippedCompositionBounds(). r=kats
Botond Ballo <botond@mozilla.com> - Fri, 21 Aug 2020 19:57:01 +0000 - rev 545686
Push 37719 by btara@mozilla.com at Sat, 22 Aug 2020 09:46:59 +0000
Bug 1660211 - Respect iterator invalidation rules in ComputeClippedCompositionBounds(). r=kats Differential Revision: https://phabricator.services.mozilla.com/D87893
a6dd2a21308adfa4c0a7b2dd1c1e00d3fc9dcacc: Bug 1543485 - Update wpt expectations. r=kats
Botond Ballo <botond@mozilla.com> - Fri, 21 Aug 2020 00:09:19 +0000 - rev 545608
Push 37717 by malexandru@mozilla.com at Fri, 21 Aug 2020 15:43:14 +0000
Bug 1543485 - Update wpt expectations. r=kats The patches get several previously-failing assertions passing. Depends on D87692 Differential Revision: https://phabricator.services.mozilla.com/D87816
7a196504e6d300cd62b753b4dd2c01c6adf115ea: Bug 1543485 - Also update the code in ScrollToImpl() that proactively updates the callback transform and main thread visual viewport offset. r=kats
Botond Ballo <botond@mozilla.com> - Fri, 21 Aug 2020 01:24:59 +0000 - rev 545607
Push 37717 by malexandru@mozilla.com at Fri, 21 Aug 2020 15:43:14 +0000
Bug 1543485 - Also update the code in ScrollToImpl() that proactively updates the callback transform and main thread visual viewport offset. r=kats Differential Revision: https://phabricator.services.mozilla.com/D87692
7397af51480fa9662f1420c82c5b60f98e8664f0: Bug 1543485 - Back out the hacky fix for bug 1549625. r=kats
Botond Ballo <botond@mozilla.com> - Thu, 20 Aug 2020 23:30:13 +0000 - rev 545606
Push 37717 by malexandru@mozilla.com at Fri, 21 Aug 2020 15:43:14 +0000
Bug 1543485 - Back out the hacky fix for bug 1549625. r=kats Now that main thread scroll updates preserve the relative scroll offset in APZ, this hacky fix is no longer necessary. Differential Revision: https://phabricator.services.mozilla.com/D87687
e995ac2f9e47142426af905ab10b922ca6859dc1: Bug 1543485 - Preserve the relative scroll offset of the two viewports when accepting a main thread scroll update. r=kats
Botond Ballo <botond@mozilla.com> - Fri, 21 Aug 2020 01:25:37 +0000 - rev 545605
Push 37717 by malexandru@mozilla.com at Fri, 21 Aug 2020 15:43:14 +0000
Bug 1543485 - Preserve the relative scroll offset of the two viewports when accepting a main thread scroll update. r=kats Differential Revision: https://phabricator.services.mozilla.com/D87686
3953149e9b4a74713c7f17f28ca6711de5e0df71: Bug 1633322 - Add an input block callback facility to allow senders of input events to receive a delayed notification of whether the event was processed by the root APZC. r=kats
Botond Ballo <botond@mozilla.com> - Thu, 20 Aug 2020 20:40:51 +0000 - rev 545573
Push 37716 by apavel@mozilla.com at Fri, 21 Aug 2020 03:37:46 +0000
Bug 1633322 - Add an input block callback facility to allow senders of input events to receive a delayed notification of whether the event was processed by the root APZC. r=kats This facility is only implemented for in-process senders of input events (i.e. not for GPU process setups). Differential Revision: https://phabricator.services.mozilla.com/D79931
a0291bc39a664056e42e367471d7613f835cff46: Bug 1633322 - Turn APZEventResult::mHandledByRootApzc into a Maybe. r=kats,geckoview-reviewers,snorp
Botond Ballo <botond@mozilla.com> - Thu, 20 Aug 2020 00:10:09 +0000 - rev 545572
Push 37716 by apavel@mozilla.com at Fri, 21 Aug 2020 03:37:46 +0000
Bug 1633322 - Turn APZEventResult::mHandledByRootApzc into a Maybe. r=kats,geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D79930
9025714892ac0bbe0625d87a00faa67040f95589: Bug 1633322 - Combine APZEventResult::mTargetIsRoot and mHitRegionWithApzAwareListeners into a single flag. r=kats,geckoview-reviewers,snorp
Botond Ballo <botond@mozilla.com> - Thu, 20 Aug 2020 00:10:12 +0000 - rev 545571
Push 37716 by apavel@mozilla.com at Fri, 21 Aug 2020 03:37:46 +0000
Bug 1633322 - Combine APZEventResult::mTargetIsRoot and mHitRegionWithApzAwareListeners into a single flag. r=kats,geckoview-reviewers,snorp GeckoView uses these flags for the same purpose: to determine whether or not to allow certain effects, such as pull to refresh or dynamic toolbar movement, that should be limited to cases where an event manipulates the root scrollable. In a subsequent patch, we will enhance the API between APZ and GeckoView such that in cases where we don't know for sure whether an event will manipulate the root scrollable until it is dispatched to content, we tell GV the answer asynchronously. This is easier if there is only one flag to report. Differential Revision: https://phabricator.services.mozilla.com/D79929
825258a33c913585fecd3bcad0ddef0d08d8cf0a: Bug 1659585 - Let DisplayItemCache grow dynamically r=kats
Miko Mynttinen <mikokm@gmail.com> - Thu, 20 Aug 2020 17:06:54 +0000 - rev 545514
Push 37715 by apavel@mozilla.com at Thu, 20 Aug 2020 21:21:07 +0000
Bug 1659585 - Let DisplayItemCache grow dynamically r=kats Differential Revision: https://phabricator.services.mozilla.com/D87752
c9b17e5a44a897f4b583132a788017c8c66c9dc4: Bug 1659636 - Use the effective scroll offset and zoom in NotifyUpdateScreenMetrics. r=kats
Botond Ballo <botond@mozilla.com> - Thu, 20 Aug 2020 01:16:14 +0000 - rev 545433
Push 37713 by abutkovits@mozilla.com at Thu, 20 Aug 2020 09:32:09 +0000
Bug 1659636 - Use the effective scroll offset and zoom in NotifyUpdateScreenMetrics. r=kats Differential Revision: https://phabricator.services.mozilla.com/D87666
250b5004cf20d5ffdbcd248757f77238fce557fb: Bug 1659636 - Fix CompositorBridgeParent.h include in AsyncCompositionManager.h. r=kats
Botond Ballo <botond@mozilla.com> - Thu, 20 Aug 2020 01:15:51 +0000 - rev 545432
Push 37713 by abutkovits@mozilla.com at Thu, 20 Aug 2020 09:32:09 +0000
Bug 1659636 - Fix CompositorBridgeParent.h include in AsyncCompositionManager.h. r=kats Being in gfx/layers/composite, AsyncCompositionManager.h does not get to include CompositorBridgeParent.h (which is in gfx/layers/ipc) as simply '#include "CompositorBridgeParent.h"'. Differential Revision: https://phabricator.services.mozilla.com/D87665
3c9d5f8ee7e14a5d1845e703ed9262644a0170b0: Bug 1659636 - Fix variable naming. r=kats
Botond Ballo <botond@mozilla.com> - Thu, 20 Aug 2020 01:15:38 +0000 - rev 545431
Push 37713 by abutkovits@mozilla.com at Thu, 20 Aug 2020 09:32:09 +0000
Bug 1659636 - Fix variable naming. r=kats Differential Revision: https://phabricator.services.mozilla.com/D87664
84454fa520be12989d31ed9f9abed4922ea4d520: Bug 1633322 - Add an input block callback facility to allow senders of input events to receive a delayed notification of whether the event was processed by the root APZC. r=kats
Botond Ballo <botond@mozilla.com> - Wed, 19 Aug 2020 21:31:47 +0000 - rev 545394
Push 37713 by abutkovits@mozilla.com at Thu, 20 Aug 2020 09:32:09 +0000
Bug 1633322 - Add an input block callback facility to allow senders of input events to receive a delayed notification of whether the event was processed by the root APZC. r=kats This facility is only implemented for in-process senders of input events (i.e. not for GPU process setups). Differential Revision: https://phabricator.services.mozilla.com/D79931
1aa6be4971779183756c6992b4f1c0002735bd89: Bug 1633322 - Turn APZEventResult::mHandledByRootApzc into a Maybe. r=kats,geckoview-reviewers,snorp
Botond Ballo <botond@mozilla.com> - Tue, 18 Aug 2020 21:14:32 +0000 - rev 545393
Push 37713 by abutkovits@mozilla.com at Thu, 20 Aug 2020 09:32:09 +0000
Bug 1633322 - Turn APZEventResult::mHandledByRootApzc into a Maybe. r=kats,geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D79930
9be548b05e86837a11bd8402e5f6eff6e77095b9: Bug 1633322 - Combine APZEventResult::mTargetIsRoot and mHitRegionWithApzAwareListeners into a single flag. r=kats,geckoview-reviewers,snorp
Botond Ballo <botond@mozilla.com> - Tue, 18 Aug 2020 21:14:35 +0000 - rev 545392
Push 37713 by abutkovits@mozilla.com at Thu, 20 Aug 2020 09:32:09 +0000
Bug 1633322 - Combine APZEventResult::mTargetIsRoot and mHitRegionWithApzAwareListeners into a single flag. r=kats,geckoview-reviewers,snorp GeckoView uses these flags for the same purpose: to determine whether or not to allow certain effects, such as pull to refresh or dynamic toolbar movement, that should be limited to cases where an event manipulates the root scrollable. In a subsequent patch, we will enhance the API between APZ and GeckoView such that in cases where we don't know for sure whether an event will manipulate the root scrollable until it is dispatched to content, we tell GV the answer asynchronously. This is easier if there is only one flag to report. Differential Revision: https://phabricator.services.mozilla.com/D79929
b803fd88181eaf33ed1932e959cbf538f7d95e58: Bug 1659676 - Simplify WR hit-test API. r=kats,kvark,nical
Glenn Watson <git@intuitionlibrary.com> - Wed, 19 Aug 2020 15:05:30 +0000 - rev 545362
Push 37713 by abutkovits@mozilla.com at Thu, 20 Aug 2020 09:32:09 +0000
Bug 1659676 - Simplify WR hit-test API. r=kats,kvark,nical Specifically: - Remove hit test tag from common display item properties. - Simplify WR bindings to use hit-test items exclusively. - Remove support for transparent rectangles to be hit-test items. - Remove support for any primitive to be a hit-test item. Differential Revision: https://phabricator.services.mozilla.com/D87421