searching for reviewer(julienw)
bf8deb0029c44ef01cfa023f10d68231246acfdb: Bug 1650843 - fix the opacity of the profiler toolbar down arrow when a light weight theme is in use, r=julienw.
Florian Quèze <florian@queze.net> - Wed, 08 Jul 2020 17:24:10 +0000 - rev 539391
Push 37579 by dluca@mozilla.com at Wed, 08 Jul 2020 21:49:35 +0000
Bug 1650843 - fix the opacity of the profiler toolbar down arrow when a light weight theme is in use, r=julienw. Differential Revision: https://phabricator.services.mozilla.com/D82404
efa2336315eda0aaf78c2e94d6c9c98106ea136b: Bug 1621015 - Profiler popup button should be split into a start/stop button, and a down arrow, r=julienw.
Florian Quèze <florian@queze.net> - Fri, 03 Jul 2020 14:28:17 +0000 - rev 538753
Push 37567 by dluca@mozilla.com at Fri, 03 Jul 2020 21:50:22 +0000
Bug 1621015 - Profiler popup button should be split into a start/stop button, and a down arrow, r=julienw. Differential Revision: https://phabricator.services.mozilla.com/D77680
5a8c95e9db1c33ce2072ea4366efaa0759f009a8: Bug 1625044 - Do not run the profiler private browsing test on linux; r=julienw
Greg Tatum <gtatum@mozilla.com> - Tue, 30 Jun 2020 19:46:21 +0000 - rev 538073
Push 37557 by abutkovits@mozilla.com at Wed, 01 Jul 2020 03:27:11 +0000
Bug 1625044 - Do not run the profiler private browsing test on linux; r=julienw I spent some time looking into this, and the Linux runs when opening up the popup and the private browser are not working consistently. The popupshown and popuphidden events are not firing consistently. It's probably good enough to just disable this test on Linux, as it's mainly a UI test, and it works on the other platforms. Differential Revision: https://phabricator.services.mozilla.com/D81602
fb44b6cd09799f45536c88054f1e3bf6b58adae1: Bug 1625044 - Handle profile popup showing more correctly in tests; r=julienw
Greg Tatum <gtatum@mozilla.com> - Tue, 30 Jun 2020 19:45:08 +0000 - rev 538072
Push 37557 by abutkovits@mozilla.com at Wed, 01 Jul 2020 03:27:11 +0000
Bug 1625044 - Handle profile popup showing more correctly in tests; r=julienw Some intermittents were caused by the failure to ensure the popup was closed. This patch creates a new API that explicitly ensures that the popup is actually closed in the patch. It also adds a listener to the popupshown and popuphidden events dispatched by the XUL elements to ensure that we're not just relying on a single requestAnimationFrame tick. Differential Revision: https://phabricator.services.mozilla.com/D79332
b6b19313bfb52e9a664e1f62772f603d7143f53d: Bug 1624993 - Add a marker API inside the non-public Android Java sampler. r=geckoview-reviewers,julienw,esawin
Nazım Can Altınova <canaltinova@gmail.com> - Thu, 25 Jun 2020 14:42:45 +0000 - rev 537421
Push 37542 by abutkovits@mozilla.com at Thu, 25 Jun 2020 21:45:10 +0000
Bug 1624993 - Add a marker API inside the non-public Android Java sampler. r=geckoview-reviewers,julienw,esawin Differential Revision: https://phabricator.services.mozilla.com/D79123
463cb8d56f90da1a77c4b3b904072ad0c50a39b4: Bug 1642330 - Fix profiler icon in the overflow menu; r=julienw
Greg Tatum <gtatum@mozilla.com> - Thu, 11 Jun 2020 21:35:07 +0000 - rev 535186
Push 37498 by apavel@mozilla.com at Fri, 12 Jun 2020 03:05:25 +0000
Bug 1642330 - Fix profiler icon in the overflow menu; r=julienw Differential Revision: https://phabricator.services.mozilla.com/D78143
becb52cac8b505e27e1a1f1f42a33b97aa8f49f2: Bug 1639144 - Fix the dropdown arrow in the profiler popup; r=julienw
Greg Tatum <gtatum@mozilla.com> - Wed, 03 Jun 2020 19:28:43 +0000 - rev 533763
Push 37477 by dluca@mozilla.com at Thu, 04 Jun 2020 04:19:27 +0000
Bug 1639144 - Fix the dropdown arrow in the profiler popup; r=julienw Differential Revision: https://phabricator.services.mozilla.com/D77479
552f7e2d9aae9656db8c361017e058113c57de5c: Bug 1633855 - Break out the about:profiling features into separate sub-sections; r=julienw
Greg Tatum <gtatum@mozilla.com> - Wed, 27 May 2020 22:07:30 +0000 - rev 532616
Push 37457 by nerli@mozilla.com at Thu, 28 May 2020 15:51:15 +0000
Bug 1633855 - Break out the about:profiling features into separate sub-sections; r=julienw Differential Revision: https://phabricator.services.mozilla.com/D76512
7c750b9483f3588ef18c1f1bb05e51324f1644ec: Bug 1633855 - Re-work the experimental definitions for features; r=julienw
Greg Tatum <gtatum@mozilla.com> - Wed, 27 May 2020 22:07:08 +0000 - rev 532615
Push 37457 by nerli@mozilla.com at Thu, 28 May 2020 15:51:15 +0000
Bug 1633855 - Re-work the experimental definitions for features; r=julienw This commit changes up the definitions of the presets a bit. I promoted the allocations work to non-experimental, as it's fairly well supported now in the UI. Others I demoted to experimental if they were not supported in our current UI, or flat out don't work. Differential Revision: https://phabricator.services.mozilla.com/D76511
2a2f8dd306554fbdcfeedf5916fadcb1a30f8f99: Bug 1633855 - Clean up some old getSupportedFeatures actor compatibility; r=julienw
Greg Tatum <gtatum@mozilla.com> - Wed, 27 May 2020 22:06:54 +0000 - rev 532614
Push 37457 by nerli@mozilla.com at Thu, 28 May 2020 15:51:15 +0000
Bug 1633855 - Clean up some old getSupportedFeatures actor compatibility; r=julienw This is a drive-by clean-up, as I was touching this code. Differential Revision: https://phabricator.services.mozilla.com/D76510
d45e2b2a949175d04e83651c1295495355f06478: Bug 1639630 - Increase the java sample count limit to 120000 to cover up to 2 mins with 1ms interval. r=julienw,geckoview-reviewers,agi
Nazım Can Altınova <canaltinova@gmail.com> - Thu, 21 May 2020 21:20:38 +0000 - rev 531659
Push 37441 by apavel@mozilla.com at Fri, 22 May 2020 21:38:53 +0000
Bug 1639630 - Increase the java sample count limit to 120000 to cover up to 2 mins with 1ms interval. r=julienw,geckoview-reviewers,agi Depends on D76180 Differential Revision: https://phabricator.services.mozilla.com/D76181
f785828241b79ef1aa99d587b7463d8a6dcedb99: Bug 1639630 - Use the limited sample count instead of non-limited one. r=julienw,geckoview-reviewers,agi
Nazım Can Altınova <canaltinova@gmail.com> - Thu, 21 May 2020 21:20:37 +0000 - rev 531658
Push 37441 by apavel@mozilla.com at Fri, 22 May 2020 21:38:53 +0000
Bug 1639630 - Use the limited sample count instead of non-limited one. r=julienw,geckoview-reviewers,agi Differential Revision: https://phabricator.services.mozilla.com/D76180
0d900cb13dd4be5a94a7622f413d90cf77b4df7e: Bug 1623594 - Add recording state UI to the profiling popup; r=julienw
Greg Tatum <gtatum@mozilla.com> - Mon, 04 May 2020 15:05:23 +0000 - rev 527866
Push 37378 by ccoroiu@mozilla.com at Mon, 04 May 2020 20:53:24 +0000
Bug 1623594 - Add recording state UI to the profiling popup; r=julienw Differential Revision: https://phabricator.services.mozilla.com/D73332
f0c994cfb342f39aaf87441917e11d1f516692f9: Bug 1545069 - report the mime type as specified by the response headers r=julienw,gerald,mayhemer
Michael Hoffmann <brennan.brisad@gmail.com> - Mon, 04 May 2020 07:13:47 +0000 - rev 527847
Push 37377 by malexandru@mozilla.com at Mon, 04 May 2020 15:50:58 +0000
Bug 1545069 - report the mime type as specified by the response headers r=julienw,gerald,mayhemer Differential Revision: https://phabricator.services.mozilla.com/D68481
8dfe8cb5a8311dc6062c8d9a421dbbf65bc5050e: Bug 1607801 - Pre-define ChromeUtils.import paths; r=julienw
Greg Tatum <gtatum@mozilla.com> - Tue, 28 Apr 2020 17:49:59 +0000 - rev 526537
Push 37358 by opoprus@mozilla.com at Wed, 29 Apr 2020 03:05:14 +0000
Bug 1607801 - Pre-define ChromeUtils.import paths; r=julienw This patch takes the approach from mossop on pre-defining ChromeUtils.import paths, so that they don't need to be defined where they are used. Perhaps in the future we could automate this more, but for now this will make the current approach more ergonomic for consumers of the types. Differential Revision: https://phabricator.services.mozilla.com/D59206
79e01e02fa5ebaa2bd4cf7c98043fdf687651555: Bug 1607801 - Upgrade TypeScript to v3.8.3; r=julienw
Greg Tatum <gtatum@mozilla.com> - Tue, 28 Apr 2020 17:48:53 +0000 - rev 526536
Push 37358 by opoprus@mozilla.com at Wed, 29 Apr 2020 03:05:14 +0000
Bug 1607801 - Upgrade TypeScript to v3.8.3; r=julienw Differential Revision: https://phabricator.services.mozilla.com/D70439
1e06eab47c7a65d6ff0a8671a8f678c8c53ba40c: Bug 1612251 - Use Executors.newSingleThreadScheduledExecutor to support <10ms sampling. r=julienw
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 27 Apr 2020 02:16:54 +0000 - rev 526157
Push 37353 by shindli@mozilla.com at Mon, 27 Apr 2020 21:46:18 +0000
Bug 1612251 - Use Executors.newSingleThreadScheduledExecutor to support <10ms sampling. r=julienw Actually, we use `Thread.sleep` to get next sampling duration. But as long as old comment, this sampling min duration is 10ms. But when I test `Executors.newSingleThreadScheduledExecutor` on old device (10 year's old Galaxy Nexus) instead of Thread.sleep, it can use 2ms sampling duration. So we should use ScheduledExecutorService instead. Differential Revision: https://phabricator.services.mozilla.com/D70401
aa0bb0e058f09865cd3ff53eac90f163a4e89b97: Bug 1603182: Get rid of gFront from window. r=julienw
Daisuke Akatsuka <daisuke@birchill.co.jp> - Tue, 07 Apr 2020 13:46:25 +0000 - rev 523334
Push 37299 by shindli@mozilla.com at Fri, 10 Apr 2020 09:54:19 +0000
Bug 1603182: Get rid of gFront from window. r=julienw Depends on D69488 Differential Revision: https://phabricator.services.mozilla.com/D69898
0ffce188e5b878e62fbaa50e47f17d48039e2be1: Bug 1603182: Add a test for target-switching of performance panel. r=julienw
Daisuke Akatsuka <daisuke@birchill.co.jp> - Tue, 07 Apr 2020 00:09:38 +0000 - rev 523333
Push 37299 by shindli@mozilla.com at Fri, 10 Apr 2020 09:54:19 +0000
Bug 1603182: Add a test for target-switching of performance panel. r=julienw Depends on D68537 Differential Revision: https://phabricator.services.mozilla.com/D69488
e4261f9f80873db93a21766b4da79430c6563c85: Bug 1603182: Address target-switching for performance panel. r=julienw,ochameau
Daisuke Akatsuka <daisuke@birchill.co.jp> - Thu, 09 Apr 2020 23:21:31 +0000 - rev 523332
Push 37299 by shindli@mozilla.com at Fri, 10 Apr 2020 09:54:19 +0000
Bug 1603182: Address target-switching for performance panel. r=julienw,ochameau Depends on D68536 Differential Revision: https://phabricator.services.mozilla.com/D68537
5e09656d7e72a670621d59e8a244832199cff577: Bug 1603182: Remove unused variables. r=julienw
Daisuke Akatsuka <daisuke@birchill.co.jp> - Mon, 06 Apr 2020 03:29:19 +0000 - rev 523331
Push 37299 by shindli@mozilla.com at Fri, 10 Apr 2020 09:54:19 +0000
Bug 1603182: Remove unused variables. r=julienw Differential Revision: https://phabricator.services.mozilla.com/D68536
5ecb361bcfc0b3d34ac7dcf1934ffed69cf03266: Bug 1627933 - Fix preference name to disable new perf panel for the Browser Toolbox r=julienw
Julian Descottes <jdescottes@mozilla.com> - Tue, 07 Apr 2020 13:18:55 +0000 - rev 522595
Push 37293 by apavel@mozilla.com at Tue, 07 Apr 2020 21:44:02 +0000
Bug 1627933 - Fix preference name to disable new perf panel for the Browser Toolbox r=julienw This line was introduced in https://bugzilla.mozilla.org/show_bug.cgi?id=1408124 However the preference is incorrectly named. It should be devtools.performance.new-panel-enabled instead of devtools.preference.new-panel-enabled (which doesn't exist) Differential Revision: https://phabricator.services.mozilla.com/D69985
89453cbdf2433f9c3bb2729b6cc2616a299f672a: Bug 1625145 - Ensure the profiler menu button feature flag is enabled in tests; r=julienw
Greg Tatum <gtatum@mozilla.com> - Mon, 30 Mar 2020 07:47:11 +0000 - rev 521077
Push 37266 by ccoroiu@mozilla.com at Mon, 30 Mar 2020 22:01:01 +0000
Bug 1625145 - Ensure the profiler menu button feature flag is enabled in tests; r=julienw Differential Revision: https://phabricator.services.mozilla.com/D68616
d44263e0b47bc0435f6533e98ee28f0fef4c9279: Bug 1623529 - Fix supported features used in the profiler; r=julienw
Greg Tatum <gtatum@mozilla.com> - Tue, 24 Mar 2020 20:45:22 +0000 - rev 520278
Push 37246 by opoprus@mozilla.com at Wed, 25 Mar 2020 03:40:33 +0000
Bug 1623529 - Fix supported features used in the profiler; r=julienw about:profiling was failing to use the supported features of the target and was instead only checking the locally supported features. Differential Revision: https://phabricator.services.mozilla.com/D67528
5eacb3c300294f8de6d4dc81b627dac2cfb887a1: Bug 1623529 - Add "java" to the profiler presets by default; r=julienw
Greg Tatum <gtatum@mozilla.com> - Tue, 24 Mar 2020 20:45:18 +0000 - rev 520277
Push 37246 by opoprus@mozilla.com at Wed, 25 Mar 2020 03:40:33 +0000
Bug 1623529 - Add "java" to the profiler presets by default; r=julienw The feature should only be enabled if it's supported, e.g on mobile phones. Differential Revision: https://phabricator.services.mozilla.com/D67527
054d227f6c631f7a5a7723d082a6147ce7b811fd: Bug 1623529 - Clean up PerfFront.getSupportedFeatures backwards FF 72 compatibility; r=julienw
Greg Tatum <gtatum@mozilla.com> - Tue, 24 Mar 2020 20:43:37 +0000 - rev 520276
Push 37246 by opoprus@mozilla.com at Wed, 25 Mar 2020 03:40:33 +0000
Bug 1623529 - Clean up PerfFront.getSupportedFeatures backwards FF 72 compatibility; r=julienw The current Firefox release channel is 74, which means this old mitigation is no longer needed. getSupportedFeatures is supported on all targets. Differential Revision: https://phabricator.services.mozilla.com/D67526
e4d6a3862857a9bc615439a4b8e7c859cf4fcaa3: Bug 1620323 - Revert preferences in the head file for performance-new tests; r=julienw
Greg Tatum <gtatum@mozilla.com> - Mon, 09 Mar 2020 15:04:22 +0000 - rev 517579
Push 37198 by opoprus@mozilla.com at Mon, 09 Mar 2020 21:52:54 +0000
Bug 1620323 - Revert preferences in the head file for performance-new tests; r=julienw Differential Revision: https://phabricator.services.mozilla.com/D65578
8af24b826e20ae5cd9a6012302f7ac7051699cb0: Bug 1619748 - Update code documentation for the new about:profiling workflow; r=julienw
Greg Tatum <gtatum@mozilla.com> - Mon, 09 Mar 2020 15:02:17 +0000 - rev 517578
Push 37198 by opoprus@mozilla.com at Mon, 09 Mar 2020 21:52:54 +0000
Bug 1619748 - Update code documentation for the new about:profiling workflow; r=julienw Differential Revision: https://phabricator.services.mozilla.com/D65203
aafa4f9d6d92591af1fd38a4738c4bad04e32d43: Bug 1611817 - Migrate remaining chrome tests to devtools browser tests; r=julienw
Greg Tatum <gtatum@mozilla.com> - Mon, 09 Mar 2020 15:01:26 +0000 - rev 517577
Push 37198 by opoprus@mozilla.com at Mon, 09 Mar 2020 21:52:54 +0000
Bug 1611817 - Migrate remaining chrome tests to devtools browser tests; r=julienw Differential Revision: https://phabricator.services.mozilla.com/D65153
19ad6553c0ef747d62be4cbad186570b5a762bb3: Bug 1597388 - Hook about:profiling up to remote debugging; r=julienw,jdescottes
Greg Tatum <gtatum@mozilla.com> - Mon, 09 Mar 2020 15:01:02 +0000 - rev 517576
Push 37198 by opoprus@mozilla.com at Mon, 09 Mar 2020 21:52:54 +0000
Bug 1597388 - Hook about:profiling up to remote debugging; r=julienw,jdescottes Differential Revision: https://phabricator.services.mozilla.com/D65152
733c2c65e834ea73c5603429fe5ec9a70f1aa975: Bug 1611817 - Add mochitests for the performance-new panel in DevTools; r=julienw
Greg Tatum <gtatum@mozilla.com> - Mon, 09 Mar 2020 14:57:56 +0000 - rev 517575
Push 37198 by opoprus@mozilla.com at Mon, 09 Mar 2020 21:52:54 +0000
Bug 1611817 - Add mochitests for the performance-new panel in DevTools; r=julienw Note that this patch also updates the setReactFriendlyInputValue function in head.js, as it was not working for selects. Differential Revision: https://phabricator.services.mozilla.com/D65151
47f2ae8298a9195d7fd428aea55204a07ec6120d: Bug 1611817 - Fix race condition in DevTools shutdown and stopProfilerAndDiscardProfile; r=julienw
Greg Tatum <gtatum@mozilla.com> - Mon, 09 Mar 2020 14:57:05 +0000 - rev 517574
Push 37198 by opoprus@mozilla.com at Mon, 09 Mar 2020 21:52:54 +0000
Bug 1611817 - Fix race condition in DevTools shutdown and stopProfilerAndDiscardProfile; r=julienw This race condition is really only exposed in automated testing, but it was making the DevTools performance-new mochitests intermittent. The race looks like this: * stopProfilerAndDiscardProfiler() request * perf actor process the request * The gecko profiler sends an event notifying that the profiler stopped * DevTools updates the UI upon receiving the event * The test suite sees the UI update, and triggers a close of DevTools * Error: Connection closed, pending request * stopProfilerAndDiscardProfiler still hasn't sent the response yet This patch fixes it by not throwing an error if the panel is already destroyed. Differential Revision: https://phabricator.services.mozilla.com/D65150
723168776bd4b87069c3fabd5e1d1a63cdba3923: Bug 1618002 - Migrate about:profiling chrome tests to only browser tests;r=julienw
Greg Tatum <gtatum@mozilla.com> - Mon, 09 Mar 2020 14:56:21 +0000 - rev 517573
Push 37198 by opoprus@mozilla.com at Mon, 09 Mar 2020 21:52:54 +0000
Bug 1618002 - Migrate about:profiling chrome tests to only browser tests;r=julienw The browser chrome tests previously only tested the performance-new client from a unit testing perspective. I originally wrote them this way so that they would be fast, and not flaky, as the client actually runs the profiler and full browser infrastructure. However, these tests haven't been really great at catching bugs, and the tests break pretty easy to due implementation changes for the client. The new browser tests have been proving fast, reliable, and great at catching regressions. This patch moves all of the about:profiling related tests to be exclusively mochitests. Differential Revision: https://phabricator.services.mozilla.com/D65149
79f957c57550674192769fe6714bcc24eb70c970: Bug 1594798 - Store remote prefs on the client under a separate pref branch; r=julienw
Greg Tatum <gtatum@mozilla.com> - Mon, 09 Mar 2020 14:55:16 +0000 - rev 517572
Push 37198 by opoprus@mozilla.com at Mon, 09 Mar 2020 21:52:54 +0000
Bug 1594798 - Store remote prefs on the client under a separate pref branch; r=julienw Currently the preferences for remote profiling are stored on the debuggee. This leads to a negative user experience, as oftentimes phones do not persist the preferences. This patch changes the strategy to store one set of preferences for local profiling, and a second set of preferences for remote profiling. Differential Revision: https://phabricator.services.mozilla.com/D65148
32d96429648fa44250ed70d06ec613f6d5656594: Bug 1597385 - Remove unused codepaths and style in the DevTools panel migration; r=julienw
Greg Tatum <gtatum@mozilla.com> - Mon, 09 Mar 2020 14:54:35 +0000 - rev 517571
Push 37198 by opoprus@mozilla.com at Mon, 09 Mar 2020 21:52:54 +0000
Bug 1597385 - Remove unused codepaths and style in the DevTools panel migration; r=julienw Differential Revision: https://phabricator.services.mozilla.com/D65147
9bf3c2de07907f9aff58444301867ee00872251d: Bug 1597385 - Create a stripped down version of the profiler front-end; r=julienw
Greg Tatum <gtatum@mozilla.com> - Mon, 09 Mar 2020 14:52:57 +0000 - rev 517570
Push 37198 by opoprus@mozilla.com at Mon, 09 Mar 2020 21:52:54 +0000
Bug 1597385 - Create a stripped down version of the profiler front-end; r=julienw Differential Revision: https://phabricator.services.mozilla.com/D65146
54da0fefab67fc382a8328c686b0e8715792e97a: Bug 1597385 - Move the features descriptions to a shared location; r=julienw
Greg Tatum <gtatum@mozilla.com> - Mon, 09 Mar 2020 14:51:42 +0000 - rev 517569
Push 37198 by opoprus@mozilla.com at Mon, 09 Mar 2020 21:52:54 +0000
Bug 1597385 - Move the features descriptions to a shared location; r=julienw DevTools and about:profiling will both use them, so place them in a shared utils folder, and put the type definition in a shared location. Differential Revision: https://phabricator.services.mozilla.com/D65145
d9783d21479192b44a52b30855d19514210d4789: Bug 1603363: Get rid of variables that no longer used in new performance panel. r=jdescottes,julienw
Daisuke Akatsuka <daisuke@birchill.co.jp> - Thu, 05 Mar 2020 02:04:00 +0000 - rev 516944
Push 37184 by csabou@mozilla.com at Thu, 05 Mar 2020 09:55:41 +0000
Bug 1603363: Get rid of variables that no longer used in new performance panel. r=jdescottes,julienw Differential Revision: https://phabricator.services.mozilla.com/D62702
5189b1fee20f71ef2a520e57c73a30ccd811ff53: Bug 1616622 - Increase the buffer limit and refactor the java code r=gerald,julienw
Nazım Can Altınova <canaltinova@gmail.com> - Tue, 03 Mar 2020 17:14:19 +0000 - rev 516698
Push 37178 by apavel@mozilla.com at Wed, 04 Mar 2020 03:43:50 +0000
Bug 1616622 - Increase the buffer limit and refactor the java code r=gerald,julienw Differential Revision: https://phabricator.services.mozilla.com/D64754
43be1e5178c718cb6e8736979da6bcd789e279f1: Bug 1616622 - Rename SamplingThread class to SamplingRunnable instead. r=julienw
Nazım Can Altınova <canaltinova@gmail.com> - Tue, 03 Mar 2020 17:10:42 +0000 - rev 516697
Push 37178 by apavel@mozilla.com at Wed, 04 Mar 2020 03:43:50 +0000
Bug 1616622 - Rename SamplingThread class to SamplingRunnable instead. r=julienw This class is not technically the thread itself, it's the runnable that the sampling thread uses. This name is more accurate and clear for it. Differential Revision: https://phabricator.services.mozilla.com/D64753
af4a2ed60003a21d68ae53d37f1b812be15b12c7: Bug 1616622 - Remove the SparseArray from the samples array since we only profile the main thread. r=julienw
Nazım Can Altınova <canaltinova@gmail.com> - Tue, 03 Mar 2020 17:10:19 +0000 - rev 516696
Push 37178 by apavel@mozilla.com at Wed, 04 Mar 2020 03:43:50 +0000
Bug 1616622 - Remove the SparseArray from the samples array since we only profile the main thread. r=julienw Currently we only profile the Java Main Thread, and don't profile anything else. This is not ideal, but this is how it works right now. And inside the code index `0` was hardcoded on the most parts of the code. We can rollback this patch once we want to implement profiling more than one thread, or we can think about something more clever. Differential Revision: https://phabricator.services.mozilla.com/D64752
37df598adc9a6283de1973ed3f131ae2cff71386: Bug 1617208 - Make about:profiling available everywhere by removing ifdef; r=julienw
Greg Tatum <gtatum@mozilla.com> - Mon, 02 Mar 2020 16:43:25 +0000 - rev 516464
Push 37174 by btara@mozilla.com at Tue, 03 Mar 2020 03:53:06 +0000
Bug 1617208 - Make about:profiling available everywhere by removing ifdef; r=julienw This enables about:profiling everywhere, and removes the ifdefs. I can confirm that it does not break things on a full Beta simulation in my manual tests. The DevTools panel cannot be enabled. The popup cannot be enabled either. Differential Revision: https://phabricator.services.mozilla.com/D63706
c6e4d7a385ccd7fb46144b6a456e5d9725f842fd: Bug 1597378 - Migrate profiler popup tests; r=julienw
Greg Tatum <gtatum@mozilla.com> - Mon, 02 Mar 2020 16:43:16 +0000 - rev 516463
Push 37174 by btara@mozilla.com at Tue, 03 Mar 2020 03:53:06 +0000
Bug 1597378 - Migrate profiler popup tests; r=julienw This commit adds tests for the profiler popup, and migrates some of the older ones to use about:profiling instead. Differential Revision: https://phabricator.services.mozilla.com/D62915
2f59a08c4beff25276228f80b0e7d7f89b364f6e: Bug 1597378 - Create new UI for the profiler popup; r=julienw
Greg Tatum <gtatum@mozilla.com> - Mon, 02 Mar 2020 16:40:38 +0000 - rev 516462
Push 37174 by btara@mozilla.com at Tue, 03 Mar 2020 03:53:06 +0000
Bug 1597378 - Create new UI for the profiler popup; r=julienw This commit implements the actual UI changes. A follow-up commit adds the tests for the changes. The CSS is a little bit awkard since it uses lots of ID selectors rather than class selectors. I wanted to be able to write quick selects, since it's selecting across the entire browser document. I feel a little conflicted with the approach, as I would prefer to use classes in general. The panel.jsm.js file collects all of the UI handling changes rather than having everything in menu-button.jsm.js, as the latter can get loaded at startup. I'm not sure if it's completely worth the trouble of having two files, as most of it should be pretty light. This commit does not handle localization for the panel, as we should be moving to Fluent. Rather than solve that here, I will follow-up with it in Bug 1599774. Differential Revision: https://phabricator.services.mozilla.com/D62914
bee9d5fc55aa57445f2e2ea604f605cab7242207: Bug 1597378 - Remove old popup implementation; r=julienw
Greg Tatum <gtatum@mozilla.com> - Mon, 02 Mar 2020 16:39:17 +0000 - rev 516461
Push 37174 by btara@mozilla.com at Tue, 03 Mar 2020 03:53:06 +0000
Bug 1597378 - Remove old popup implementation; r=julienw This commit removes the old popup implementation, but does not implement the new one yet. This is in a follow-up commit. The client is in a bit of an awkard state where it is mid-transition to a new architecture. Some of the code comments and documentation were updated to reflect the changes coming up. Differential Revision: https://phabricator.services.mozilla.com/D62913
41f2f089537dd14bfa060a4426fc0e9fdf566b7b: Bug 1597378 - Change location of the presets; r=julienw
Greg Tatum <gtatum@mozilla.com> - Mon, 02 Mar 2020 16:53:39 +0000 - rev 516460
Push 37174 by btara@mozilla.com at Tue, 03 Mar 2020 03:53:06 +0000
Bug 1597378 - Change location of the presets; r=julienw The presets in recording-utils.js couldn't be shared via the ChromeUtils.import mechanism. When they were in recording-utils.js they could only be loaded in via the DevTools require() loader. This commit changes it so that they are stored in a jsm, and are also injected to each UI interface where the ChromeUtils.import function is available (only in the initializers). Differential Revision: https://phabricator.services.mozilla.com/D62912
39c6564c2a6ef03c86be4edaebb35781b2b821c5: Bug 1144438 - Remove false error notification when the profiler stops; r=julienw
Greg Tatum <gtatum@mozilla.com> - Mon, 02 Mar 2020 16:37:04 +0000 - rev 516459
Push 37174 by btara@mozilla.com at Tue, 03 Mar 2020 03:53:06 +0000
Bug 1144438 - Remove false error notification when the profiler stops; r=julienw If the profiler unexpectedly stops, this is fine, as the new recording infrastructure is most likely in control of it. This was leading to lots of spurious errors when working on the new about:profiling infrastructure. Differential Revision: https://phabricator.services.mozilla.com/D62911
eef173a3678d6b219ba25f583434621c7b883463: Bug 1617208 - Make about:profiling available everywhere by removing ifdef; r=julienw
Greg Tatum <gtatum@mozilla.com> - Tue, 25 Feb 2020 20:42:10 +0000 - rev 515542
Push 37158 by opoprus@mozilla.com at Wed, 26 Feb 2020 09:27:57 +0000
Bug 1617208 - Make about:profiling available everywhere by removing ifdef; r=julienw This enables about:profiling everywhere, and removes the ifdefs. I can confirm that it does not break things on a full Beta simulation in my manual tests. The DevTools panel cannot be enabled. The popup cannot be enabled either. Differential Revision: https://phabricator.services.mozilla.com/D63706
cc21fa09b88d409dde28dbff62711e3889fef6db: Bug 1597378 - Migrate profiler popup tests; r=julienw
Greg Tatum <gtatum@mozilla.com> - Tue, 25 Feb 2020 20:41:15 +0000 - rev 515541
Push 37158 by opoprus@mozilla.com at Wed, 26 Feb 2020 09:27:57 +0000
Bug 1597378 - Migrate profiler popup tests; r=julienw This commit adds tests for the profiler popup, and migrates some of the older ones to use about:profiling instead. Differential Revision: https://phabricator.services.mozilla.com/D62915
b802ce66aa59112f801243fe6bcc05b76a25eb2e: Bug 1597378 - Create new UI for the profiler popup; r=julienw
Greg Tatum <gtatum@mozilla.com> - Tue, 25 Feb 2020 20:39:27 +0000 - rev 515540
Push 37158 by opoprus@mozilla.com at Wed, 26 Feb 2020 09:27:57 +0000
Bug 1597378 - Create new UI for the profiler popup; r=julienw This commit implements the actual UI changes. A follow-up commit adds the tests for the changes. The CSS is a little bit awkard since it uses lots of ID selectors rather than class selectors. I wanted to be able to write quick selects, since it's selecting across the entire browser document. I feel a little conflicted with the approach, as I would prefer to use classes in general. The panel.jsm.js file collects all of the UI handling changes rather than having everything in menu-button.jsm.js, as the latter can get loaded at startup. I'm not sure if it's completely worth the trouble of having two files, as most of it should be pretty light. This commit does not handle localization for the panel, as we should be moving to Fluent. Rather than solve that here, I will follow-up with it in Bug 1599774. Differential Revision: https://phabricator.services.mozilla.com/D62914