searching for reviewer(jonco)
23e671a7f6fbf43b738409c7d22ea4a5479d1246: Bug 1814619 - update wpt ini file for referrer-policy/gen/srcdoc-inherit.http-rp files; r=jonco
Yulia <ystartsev@mozilla.com> - Fri, 03 Feb 2023 11:24:19 +0000 - rev 651658
Push 40602 by abutkovits@mozilla.com at Sat, 04 Feb 2023 09:11:16 +0000
Bug 1814619 - update wpt ini file for referrer-policy/gen/srcdoc-inherit.http-rp files; r=jonco Worker modules is currently behind a flag. These were missed and were failing on beta. Differential Revision: https://phabricator.services.mozilla.com/D168664
b8b31239ec9f3aad62a89696efe6e79f1a4654ef: Bug 1812628 - add new tests for beta/release; r=jonco
Yulia Startsev <ystartsev@mozilla.com> - Wed, 01 Feb 2023 15:30:16 +0000 - rev 651399
Push 40595 by smolnar@mozilla.com at Wed, 01 Feb 2023 21:51:12 +0000
Bug 1812628 - add new tests for beta/release; r=jonco Differential Revision: https://phabricator.services.mozilla.com/D168130
1f5f65f28752375edcdd8211f57e6a25eeaab701: Bug 1812628 - put worker modules behind a flag; r=jonco
Yulia Startsev <ystartsev@mozilla.com> - Wed, 01 Feb 2023 15:30:15 +0000 - rev 651398
Push 40595 by smolnar@mozilla.com at Wed, 01 Feb 2023 21:51:12 +0000
Bug 1812628 - put worker modules behind a flag; r=jonco Differential Revision: https://phabricator.services.mozilla.com/D168129
da2c075d45247751e05fe70de970f0637032238c: Bug 1812628 - add new tests for beta/release; r=jonco
Yulia Startsev <ystartsev@mozilla.com> - Tue, 31 Jan 2023 15:24:04 +0000 - rev 651049
Push 40593 by nfay@mozilla.com at Wed, 01 Feb 2023 03:47:20 +0000
Bug 1812628 - add new tests for beta/release; r=jonco Differential Revision: https://phabricator.services.mozilla.com/D168130
cc6317f62e54b4164b01fa9bf334916191481a9e: Bug 1812628 - put worker modules behind a flag; r=jonco
Yulia Startsev <ystartsev@mozilla.com> - Tue, 31 Jan 2023 15:24:03 +0000 - rev 651048
Push 40593 by nfay@mozilla.com at Wed, 01 Feb 2023 03:47:20 +0000
Bug 1812628 - put worker modules behind a flag; r=jonco Differential Revision: https://phabricator.services.mozilla.com/D168129
338bc68a11145d6bfa9ae687ecde9229b95521b0: Bug 1812239 - Log budgetWasIncreased in the GC log r=jonco
Paul Bone <pbone@mozilla.com> - Mon, 30 Jan 2023 10:27:52 +0000 - rev 650930
Push 40589 by ctuns@mozilla.com at Mon, 30 Jan 2023 21:44:13 +0000
Bug 1812239 - Log budgetWasIncreased in the GC log r=jonco Differential Revision: https://phabricator.services.mozilla.com/D167765
825630b15ea3c1eceffb3dbeb063fa2f8a55c140: Bug 1812239 - Use rounding when extending GC budgets r=jonco
Paul Bone <pbone@mozilla.com> - Mon, 30 Jan 2023 10:27:52 +0000 - rev 650929
Push 40589 by ctuns@mozilla.com at Mon, 30 Jan 2023 21:44:13 +0000
Bug 1812239 - Use rounding when extending GC budgets r=jonco Differential Revision: https://phabricator.services.mozilla.com/D167764
56318716c945c14a0b5f6b89567c6253b4c6db86: Bug 1811737 - Move processAssertions before append in ModuleBuilder::appendModuleRequest r=jonco
Jonatan Klemets <jonatan.r.klemets@gmail.com> - Mon, 23 Jan 2023 17:50:03 +0000 - rev 650234
Push 40574 by smolnar@mozilla.com at Tue, 24 Jan 2023 09:30:00 +0000
Bug 1811737 - Move processAssertions before append in ModuleBuilder::appendModuleRequest r=jonco We need to call `processAssertions` before we append `moduleRequests_` because the append will invoke the `StencilModuleRequest` copy constructor. Differential Revision: https://phabricator.services.mozilla.com/D167489
78addb6af24dee4a16278274104a8b06c418884d: Bug 1247687 - Initial wpt-tests; r=jonco,asuth
Yulia Startsev <ystartsev@mozilla.com> - Wed, 18 Jan 2023 13:46:32 +0000 - rev 649392
Push 40560 by sstanca@mozilla.com at Thu, 19 Jan 2023 04:46:07 +0000
Bug 1247687 - Initial wpt-tests; r=jonco,asuth Depends on D155568 Differential Revision: https://phabricator.services.mozilla.com/D155691
a1900e8b640c845614da76612f92b76b3f199a75: Bug 1247687 - Handle cancellation of long running modules; r=jonco
Yulia Startsev <ystartsev@mozilla.com> - Wed, 18 Jan 2023 13:46:32 +0000 - rev 649391
Push 40560 by sstanca@mozilla.com at Thu, 19 Jan 2023 04:46:07 +0000
Bug 1247687 - Handle cancellation of long running modules; r=jonco This is a slightly annoying thing that can happen. When we abruptly cancel (such as an infinitely running script being forcibly terminated) we will be in a state where the EvaluateModule call will finish _after_ the loader is destroyed. So, instead we track if there has been a forcible cancelation, and exit early. Depends on D155690 Differential Revision: https://phabricator.services.mozilla.com/D155568
c585aea29f0c6aae1f3c6117915616dab06b62b5: Bug 1247687 - Use requestCredentials to set secFlags for modules; r=jonco
Yulia Startsev <ystartsev@mozilla.com> - Wed, 18 Jan 2023 13:46:32 +0000 - rev 649390
Push 40560 by sstanca@mozilla.com at Thu, 19 Jan 2023 04:46:07 +0000
Bug 1247687 - Use requestCredentials to set secFlags for modules; r=jonco This implements the specified request credentials behavior from the spec, and is tested in wpt. Depends on D155566 Differential Revision: https://phabricator.services.mozilla.com/D155690
f3204b9ec0dc99aad004ce80499052fe5dcd5494: Bug 1247687 - Implement requestCredentials for Module Workers; r=jonco
Yulia Startsev <ystartsev@mozilla.com> - Wed, 18 Jan 2023 13:46:31 +0000 - rev 649389
Push 40560 by sstanca@mozilla.com at Thu, 19 Jan 2023 04:46:07 +0000
Bug 1247687 - Implement requestCredentials for Module Workers; r=jonco This weaves credentials through from the private to script creation. Depends on D155567 Differential Revision: https://phabricator.services.mozilla.com/D155566
7327e643834332ee953c1b627a6fbef17ea50bff: Bug 1247687 - Implement correct referrer for modules; r=jonco
Yulia Startsev <ystartsev@mozilla.com> - Wed, 18 Jan 2023 13:46:31 +0000 - rev 649388
Push 40560 by sstanca@mozilla.com at Thu, 19 Jan 2023 04:46:07 +0000
Bug 1247687 - Implement correct referrer for modules; r=jonco In our implementation, we do not have "client" as a referrer, so we resolve the URI directly as part of ScriptLoadRequest creation. Depends on D147327 Differential Revision: https://phabricator.services.mozilla.com/D155567
474668f6615eafb7bc9a94b5bcf6aada66ea5d99: Bug 1247687 - Implement initial Static Module Loading for Workers; r=jonco
Yulia Startsev <ystartsev@mozilla.com> - Wed, 18 Jan 2023 13:46:30 +0000 - rev 649387
Push 40560 by sstanca@mozilla.com at Thu, 19 Jan 2023 04:46:07 +0000
Bug 1247687 - Implement initial Static Module Loading for Workers; r=jonco This is the first pass of getting static module loading to work. This roughly implements https://html.spec.whatwg.org/multipage/webappapis.html#fetch-a-worklet/module-worker-script-graph -- without some of the settings objects correctly set. Th WorkerModuleLoader itself is implementing step 5, with the StartFetch method handling moving the work back to the main thread. The algorithm in step 5 is generic to all modules. Depends on D147329 Differential Revision: https://phabricator.services.mozilla.com/D147327
15eb9daca66122a5d891bc721fd554d377238d60: Bug 1247687 - Disallow ImportScripts from module workers; r=jonco
Yulia Startsev <ystartsev@mozilla.com> - Wed, 18 Jan 2023 13:46:30 +0000 - rev 649386
Push 40560 by sstanca@mozilla.com at Thu, 19 Jan 2023 04:46:07 +0000
Bug 1247687 - Disallow ImportScripts from module workers; r=jonco ImportScripts should be disallowed for module works, which are initialized in the following way: `new Worker("url", { module:true})`. We set the WorkerType for workers accordingly, and can use that to detect if import scripts are being incorrectly used. Depends on D147326 Differential Revision: https://phabricator.services.mozilla.com/D147329
997e9ca2e1e9d636f8f956151db81ca2a8a60c82: Bug 1247687 - Implement InitModuleLoader methods for WorkerScriptLoader and WorkerGlobalScope; r=jonco
Yulia Startsev <ystartsev@mozilla.com> - Wed, 18 Jan 2023 13:46:29 +0000 - rev 649385
Push 40560 by sstanca@mozilla.com at Thu, 19 Jan 2023 04:46:07 +0000
Bug 1247687 - Implement InitModuleLoader methods for WorkerScriptLoader and WorkerGlobalScope; r=jonco This implements a method to initialize the moduleLoader for workers. This will initialize only once, for all worker types (module and classic). Depends on D147324 Differential Revision: https://phabricator.services.mozilla.com/D147326
ebeb65b422125be469fe6ee8b1bd6a88ccf55f04: Bug 1247687 - Add WorkerModuleLoader skeleton; r=jonco
Yulia Startsev <ystartsev@mozilla.com> - Wed, 18 Jan 2023 13:46:29 +0000 - rev 649384
Push 40560 by sstanca@mozilla.com at Thu, 19 Jan 2023 04:46:07 +0000
Bug 1247687 - Add WorkerModuleLoader skeleton; r=jonco Initial Skeleton for module loader work. Depends on D134052 Differential Revision: https://phabricator.services.mozilla.com/D147324
885973f84babb2482daeb7ab0e7a9791a7c2615d: Bug 1810366 - Remove unused requestedModule variable in ModuleLoaderBase::ResolveRequestedModules r=jonco
Jonatan Klemets <jonatan.r.klemets@gmail.com> - Mon, 16 Jan 2023 20:17:30 +0000 - rev 648994
Push 40558 by mlaza@mozilla.com at Tue, 17 Jan 2023 16:13:02 +0000
Bug 1810366 - Remove unused requestedModule variable in ModuleLoaderBase::ResolveRequestedModules r=jonco Differential Revision: https://phabricator.services.mozilla.com/D166879
d7404b879d9a5445cc08c848cd8a19767fe327d5: Bug 1808373: Set warmup threshold using |jit-test| r=jonco
Iain Ireland <iireland@mozilla.com> - Mon, 16 Jan 2023 17:57:24 +0000 - rev 648972
Push 40558 by mlaza@mozilla.com at Tue, 17 Jan 2023 16:13:02 +0000
Bug 1808373: Set warmup threshold using |jit-test| r=jonco With `--baseline-eager`, the default Ion warmup threshold gets baked into the top-level script before we can set it with `setJitCompilerOption`. This can prevent us from getting into Ion when expected. To be safe, in addition to fixing bug1343513.js and bug1343513-2.js, I updated every jit-test that uses `inIon()` and `setJitCompilerOption("ion.warmup.trigger", ...)`. I don't think anything can go wrong if `inIon` is not in the top level script, but better safe than sorry. Differential Revision: https://phabricator.services.mozilla.com/D166815
c2654480f6bfc569528d221930122a3cf810720d: Bug 1685588 - Pass through some command-line parameters from `mach analyze` r=jonco
Steve Fink <sfink@mozilla.com> - Tue, 10 Jan 2023 22:33:50 +0000 - rev 648641
Push 40541 by ctuns@mozilla.com at Wed, 11 Jan 2023 04:39:19 +0000
Bug 1685588 - Pass through some command-line parameters from `mach analyze` r=jonco Differential Revision: https://phabricator.services.mozilla.com/D101059
05d23ba4b590bc65dacbd61944487c4f1ed16e51: Bug 1808357: Add better error message for importmaps of invalid JSON format. r=jonco
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Fri, 06 Jan 2023 13:34:17 +0000 - rev 648218
Push 40531 by smolnar@mozilla.com at Fri, 06 Jan 2023 21:47:42 +0000
Bug 1808357: Add better error message for importmaps of invalid JSON format. r=jonco Differential Revision: https://phabricator.services.mozilla.com/D166084
891c7d2112df313391c2f66878e68d0b4a4a2f56: Bug 1808744 part 2 - Remove ChunkStoreBufferOffsetFromLastByte. r=jonco
Jan de Mooij <jdemooij@mozilla.com> - Fri, 06 Jan 2023 12:29:51 +0000 - rev 648216
Push 40531 by smolnar@mozilla.com at Fri, 06 Jan 2023 21:47:42 +0000
Bug 1808744 part 2 - Remove ChunkStoreBufferOffsetFromLastByte. r=jonco We can use `andPtr` with a 32-bit value because it's sign-extended. We already rely on this in other places where we do similar masking. On ARM64, use 3-operand And to avoid an extra register move. Depends on D166137 Differential Revision: https://phabricator.services.mozilla.com/D166138
5112c24286468e311156eb1f2eca8005ba8a29ec: Bug 1808744 part 1 - Combine Value unboxing mask with ChunkMask for Value barriers in JIT code. r=jonco
Jan de Mooij <jdemooij@mozilla.com> - Fri, 06 Jan 2023 12:29:51 +0000 - rev 648215
Push 40531 by smolnar@mozilla.com at Fri, 06 Jan 2023 21:47:42 +0000
Bug 1808744 part 1 - Combine Value unboxing mask with ChunkMask for Value barriers in JIT code. r=jonco This gets rid of an extra or-instruction on 64-bit platforms and simplifies loading the store buffer. Differential Revision: https://phabricator.services.mozilla.com/D166137
302bffceb24a11e4e53693b5c342cac782468730: Bug 1808360 - Add error message for external import maps. r=jonco,flod
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Thu, 05 Jan 2023 14:16:58 +0000 - rev 648138
Push 40527 by nerli@mozilla.com at Thu, 05 Jan 2023 21:31:09 +0000
Bug 1808360 - Add error message for external import maps. r=jonco,flod Differential Revision: https://phabricator.services.mozilla.com/D166028
2620571c3526e3a04a72eeffe07edae0434d4ae3: Bug 1794514 - skip testcases bug-1791363.js/bug-1792338.js on android-hw/debug. r=jonco
Joel Maher <jmaher@mozilla.com> - Tue, 03 Jan 2023 14:42:40 +0000 - rev 647765
Push 40521 by imoraru@mozilla.com at Wed, 04 Jan 2023 04:29:41 +0000
Bug 1794514 - skip testcases bug-1791363.js/bug-1792338.js on android-hw/debug. r=jonco Differential Revision: https://phabricator.services.mozilla.com/D165684
300945b39f8101b03e3f265d6f1adb625eca987e: Bug 1806169 - Add ScriptLoader::ConvertToUTF8 overload r=jonco
Ted Campbell <tcampbell@mozilla.com> - Fri, 23 Dec 2022 21:26:25 +0000 - rev 647370
Push 40504 by nerli@mozilla.com at Sat, 24 Dec 2022 09:06:45 +0000
Bug 1806169 - Add ScriptLoader::ConvertToUTF8 overload r=jonco Similar to the ConvertToUTF16 overload for JS owned strings, add an overload for the UTF8 case. This simplifies later work to switch parsing to UTF8. Differential Revision: https://phabricator.services.mozilla.com/D164930
31888ffde37aea2fe6c0c04d43fb01937f299b09: Bug 1247687 - Initial wpt-tests; r=jonco,asuth
Yulia Startsev <ystartsev@mozilla.com> - Tue, 20 Dec 2022 20:56:15 +0000 - rev 646915
Push 40497 by ctuns@mozilla.com at Wed, 21 Dec 2022 21:21:23 +0000
Bug 1247687 - Initial wpt-tests; r=jonco,asuth Depends on D155568 Differential Revision: https://phabricator.services.mozilla.com/D155691
9153182c650d0455a6376e071bc230d8803fd4ea: Bug 1247687 - Handle cancellation of long running modules; r=jonco
Yulia Startsev <ystartsev@mozilla.com> - Tue, 20 Dec 2022 20:56:14 +0000 - rev 646914
Push 40497 by ctuns@mozilla.com at Wed, 21 Dec 2022 21:21:23 +0000
Bug 1247687 - Handle cancellation of long running modules; r=jonco This is a slightly annoying thing that can happen. When we abruptly cancel (such as an infinitely running script being forcibly terminated) we will be in a state where the EvaluateModule call will finish _after_ the loader is destroyed. So, instead we track if there has been a forcible cancelation, and exit early. Depends on D155690 Differential Revision: https://phabricator.services.mozilla.com/D155568
45de9ffeec19c604f94fa1fe490cd90be2f39ba2: Bug 1247687 - Use requestCredentials to set secFlags for modules; r=jonco
Yulia Startsev <ystartsev@mozilla.com> - Tue, 20 Dec 2022 20:56:14 +0000 - rev 646913
Push 40497 by ctuns@mozilla.com at Wed, 21 Dec 2022 21:21:23 +0000
Bug 1247687 - Use requestCredentials to set secFlags for modules; r=jonco This implements the specified request credentials behavior from the spec, and is tested in wpt. Depends on D155566 Differential Revision: https://phabricator.services.mozilla.com/D155690
59207e959b7c3476cc21409d61c8dd03d22a816b: Bug 1247687 - Implement requestCredentials for Module Workers; r=jonco
Yulia Startsev <ystartsev@mozilla.com> - Tue, 20 Dec 2022 20:56:13 +0000 - rev 646912
Push 40497 by ctuns@mozilla.com at Wed, 21 Dec 2022 21:21:23 +0000
Bug 1247687 - Implement requestCredentials for Module Workers; r=jonco This weaves credentials through from the private to script creation. Depends on D155567 Differential Revision: https://phabricator.services.mozilla.com/D155566
49f18430c465b8d78e2c31db09cd524765e08d06: Bug 1247687 - Implement correct referrer for modules; r=jonco
Yulia Startsev <ystartsev@mozilla.com> - Tue, 20 Dec 2022 20:56:13 +0000 - rev 646911
Push 40497 by ctuns@mozilla.com at Wed, 21 Dec 2022 21:21:23 +0000
Bug 1247687 - Implement correct referrer for modules; r=jonco In our implementation, we do not have "client" as a referrer, so we resolve the URI directly as part of ScriptLoadRequest creation. Depends on D147327 Differential Revision: https://phabricator.services.mozilla.com/D155567
0ae1fd421d4fbb45b956df108f1cd13626eb3a3e: Bug 1247687 - Implement initial Static Module Loading for Workers; r=jonco
Yulia Startsev <ystartsev@mozilla.com> - Tue, 20 Dec 2022 20:56:13 +0000 - rev 646910
Push 40497 by ctuns@mozilla.com at Wed, 21 Dec 2022 21:21:23 +0000
Bug 1247687 - Implement initial Static Module Loading for Workers; r=jonco This is the first pass of getting static module loading to work. This roughly implements https://html.spec.whatwg.org/multipage/webappapis.html#fetch-a-worklet/module-worker-script-graph -- without some of the settings objects correctly set. Th WorkerModuleLoader itself is implementing step 5, with the StartFetch method handling moving the work back to the main thread. The algorithm in step 5 is generic to all modules. Depends on D147329 Differential Revision: https://phabricator.services.mozilla.com/D147327
7770ec4717fdce23c2e399fcbbd93a42a69c7721: Bug 1247687 - Disallow ImportScripts from module workers; r=jonco
Yulia Startsev <ystartsev@mozilla.com> - Tue, 20 Dec 2022 20:56:12 +0000 - rev 646909
Push 40497 by ctuns@mozilla.com at Wed, 21 Dec 2022 21:21:23 +0000
Bug 1247687 - Disallow ImportScripts from module workers; r=jonco ImportScripts should be disallowed for module works, which are initialized in the following way: `new Worker("url", { module:true})`. We set the WorkerType for workers accordingly, and can use that to detect if import scripts are being incorrectly used. Depends on D147326 Differential Revision: https://phabricator.services.mozilla.com/D147329
68b476066248deb9b80b0be44bebb991fdc94a6d: Bug 1247687 - Implement InitModuleLoader methods for WorkerScriptLoader and WorkerGlobalScope; r=jonco
Yulia Startsev <ystartsev@mozilla.com> - Tue, 20 Dec 2022 20:56:12 +0000 - rev 646908
Push 40497 by ctuns@mozilla.com at Wed, 21 Dec 2022 21:21:23 +0000
Bug 1247687 - Implement InitModuleLoader methods for WorkerScriptLoader and WorkerGlobalScope; r=jonco This implements a method to initialize the moduleLoader for workers. This will initialize only once, for all worker types (module and classic). Depends on D147324 Differential Revision: https://phabricator.services.mozilla.com/D147326
c94a9dc60dff122afed6748392f9de31a8989eb4: Bug 1247687 - Add WorkerModuleLoader skeleton; r=jonco
Yulia Startsev <ystartsev@mozilla.com> - Tue, 20 Dec 2022 20:56:11 +0000 - rev 646907
Push 40497 by ctuns@mozilla.com at Wed, 21 Dec 2022 21:21:23 +0000
Bug 1247687 - Add WorkerModuleLoader skeleton; r=jonco Initial Skeleton for module loader work. Depends on D134052 Differential Revision: https://phabricator.services.mozilla.com/D147324
0468f7d935568f6b4e3584cfde616f00ddf9f853: Bug 1806389 part 2 - Use shape to check for native objects in object trace and finalize code. r=jonco
Jan de Mooij <jdemooij@mozilla.com> - Mon, 19 Dec 2022 16:17:18 +0000 - rev 646733
Push 40494 by smolnar@mozilla.com at Tue, 20 Dec 2022 09:39:56 +0000
Bug 1806389 part 2 - Use shape to check for native objects in object trace and finalize code. r=jonco We have to load the `JSClass` anyway so it's not clear how much it helps, but it also shouldn't be worse. Differential Revision: https://phabricator.services.mozilla.com/D165016
4065668599134774df166c80b02a5331b1902588: Bug 1806389 part 1 - Optimize proxy check in obj_toString. r=jonco
Jan de Mooij <jdemooij@mozilla.com> - Mon, 19 Dec 2022 16:17:18 +0000 - rev 646732
Push 40494 by smolnar@mozilla.com at Tue, 20 Dec 2022 09:39:56 +0000
Bug 1806389 part 1 - Optimize proxy check in obj_toString. r=jonco `obj->is<ProxyObject>()` now checks the shape and avoids loading the `JSClass`. We can then also remove the `JSClass` argument from `GetBuiltinTagFast`. Differential Revision: https://phabricator.services.mozilla.com/D165015
013db6a0d8d12eceb52ab7ff72cd1fca02f1b822: Bug 1805873 - Clean up HasWorkerLoadContext code related to non-cc'd load context;r=jonco
Yulia Startsev <ystartsev@mozilla.com> - Mon, 19 Dec 2022 15:34:10 +0000 - rev 646719
Push 40494 by smolnar@mozilla.com at Tue, 20 Dec 2022 09:39:56 +0000
Bug 1805873 - Clean up HasWorkerLoadContext code related to non-cc'd load context;r=jonco Differential Revision: https://phabricator.services.mozilla.com/D165040
354711cf113aa12d1ddaf7d017da40c4bb787741: Bug 1247687 - Initial wpt-tests; r=jonco,asuth
Yulia Startsev <ystartsev@mozilla.com> - Wed, 14 Dec 2022 14:55:37 +0000 - rev 646034
Push 40483 by smolnar@mozilla.com at Thu, 15 Dec 2022 09:27:59 +0000
Bug 1247687 - Initial wpt-tests; r=jonco,asuth Depends on D155568 Differential Revision: https://phabricator.services.mozilla.com/D155691
40b8abaf1c0b4e4041d5974de350b9c6e2b1ec0d: Bug 1247687 - Handle cancellation of long running modules; r=jonco
Yulia Startsev <ystartsev@mozilla.com> - Wed, 14 Dec 2022 14:55:37 +0000 - rev 646033
Push 40483 by smolnar@mozilla.com at Thu, 15 Dec 2022 09:27:59 +0000
Bug 1247687 - Handle cancellation of long running modules; r=jonco This is a slightly annoying thing that can happen. When we abruptly cancel (such as an infinitely running script being forcibly terminated) we will be in a state where the EvaluateModule call will finish _after_ the loader is destroyed. So, instead we track if there has been a forcible cancelation, and exit early. Depends on D155690 Differential Revision: https://phabricator.services.mozilla.com/D155568
0c9650a1ac48ca7e8fd2c60f7f498f381d32a591: Bug 1247687 - Use requestCredentials to set secFlags for modules; r=jonco
Yulia Startsev <ystartsev@mozilla.com> - Wed, 14 Dec 2022 14:55:37 +0000 - rev 646032
Push 40483 by smolnar@mozilla.com at Thu, 15 Dec 2022 09:27:59 +0000
Bug 1247687 - Use requestCredentials to set secFlags for modules; r=jonco This implements the specified request credentials behavior from the spec, and is tested in wpt. Depends on D155566 Differential Revision: https://phabricator.services.mozilla.com/D155690
e7b103c79b1aafa9e4f01f4c976e0d2ef46b7c41: Bug 1247687 - Implement requestCredentials for Module Workers; r=jonco
Yulia Startsev <ystartsev@mozilla.com> - Wed, 14 Dec 2022 14:55:36 +0000 - rev 646031
Push 40483 by smolnar@mozilla.com at Thu, 15 Dec 2022 09:27:59 +0000
Bug 1247687 - Implement requestCredentials for Module Workers; r=jonco This weaves credentials through from the private to script creation. Depends on D155567 Differential Revision: https://phabricator.services.mozilla.com/D155566
4dbd510fb042e57f8f817b0c3032dafc78143b39: Bug 1247687 - Implement correct referrer for modules; r=jonco
Yulia Startsev <ystartsev@mozilla.com> - Wed, 14 Dec 2022 14:55:36 +0000 - rev 646030
Push 40483 by smolnar@mozilla.com at Thu, 15 Dec 2022 09:27:59 +0000
Bug 1247687 - Implement correct referrer for modules; r=jonco In our implementation, we do not have "client" as a referrer, so we resolve the URI directly as part of ScriptLoadRequest creation. Depends on D147327 Differential Revision: https://phabricator.services.mozilla.com/D155567
9276c7e1ddd98ccc725dbbe43353a8d988f8f454: Bug 1247687 - Implement initial Static Module Loading for Workers; r=jonco
Yulia Startsev <ystartsev@mozilla.com> - Wed, 14 Dec 2022 14:55:35 +0000 - rev 646029
Push 40483 by smolnar@mozilla.com at Thu, 15 Dec 2022 09:27:59 +0000
Bug 1247687 - Implement initial Static Module Loading for Workers; r=jonco This is the first pass of getting static module loading to work. This roughly implements https://html.spec.whatwg.org/multipage/webappapis.html#fetch-a-worklet/module-worker-script-graph -- without some of the settings objects correctly set. Th WorkerModuleLoader itself is implementing step 5, with the StartFetch method handling moving the work back to the main thread. The algorithm in step 5 is generic to all modules. Depends on D147329 Differential Revision: https://phabricator.services.mozilla.com/D147327
6ee318df664183094387ff4cde3ee8437df0240e: Bug 1247687 - Disallow ImportScripts from module workers; r=jonco
Yulia Startsev <ystartsev@mozilla.com> - Wed, 14 Dec 2022 14:55:35 +0000 - rev 646028
Push 40483 by smolnar@mozilla.com at Thu, 15 Dec 2022 09:27:59 +0000
Bug 1247687 - Disallow ImportScripts from module workers; r=jonco ImportScripts should be disallowed for module works, which are initialized in the following way: `new Worker("url", { module:true})`. We set the WorkerType for workers accordingly, and can use that to detect if import scripts are being incorrectly used. Depends on D147326 Differential Revision: https://phabricator.services.mozilla.com/D147329
6c129bd72b61cf6d096dcec6c7bb188e3ddb37c7: Bug 1247687 - Implement InitModuleLoader methods for WorkerScriptLoader and WorkerGlobalScope; r=jonco
Yulia Startsev <ystartsev@mozilla.com> - Wed, 14 Dec 2022 14:55:35 +0000 - rev 646027
Push 40483 by smolnar@mozilla.com at Thu, 15 Dec 2022 09:27:59 +0000
Bug 1247687 - Implement InitModuleLoader methods for WorkerScriptLoader and WorkerGlobalScope; r=jonco This implements a method to initialize the moduleLoader for workers. This will initialize only once, for all worker types (module and classic). Depends on D147324 Differential Revision: https://phabricator.services.mozilla.com/D147326
4b0a4fcc6894016cab4aca8f4a5024a950176ba7: Bug 1247687 - Add WorkerModuleLoader skeleton; r=jonco
Yulia Startsev <ystartsev@mozilla.com> - Wed, 14 Dec 2022 14:55:34 +0000 - rev 646026
Push 40483 by smolnar@mozilla.com at Thu, 15 Dec 2022 09:27:59 +0000
Bug 1247687 - Add WorkerModuleLoader skeleton; r=jonco Initial Skeleton for module loader work. Depends on D134052 Differential Revision: https://phabricator.services.mozilla.com/D147324
5f0c1d5305969fb70c42515c019c357f9f85b9fd: Bug 1805430 part 3 - Use replaceShape also for dictionary shapes in changeProperty. r=jonco
Jan de Mooij <jdemooij@mozilla.com> - Tue, 13 Dec 2022 16:57:17 +0000 - rev 645890
Push 40480 by nfay@mozilla.com at Wed, 14 Dec 2022 03:34:16 +0000
Bug 1805430 part 3 - Use replaceShape also for dictionary shapes in changeProperty. r=jonco Now that `replaceShape` also works for dictionary shapes, we don't need the `isShared` check anymore. Depends on D164572 Differential Revision: https://phabricator.services.mozilla.com/D164575
84cd838aa64cc2ec9c6f4e54322f518b0489efb1: Bug 1805430 part 2 - Optimize generateNewDictionaryShape a bit. r=jonco
Jan de Mooij <jdemooij@mozilla.com> - Tue, 13 Dec 2022 16:57:16 +0000 - rev 645889
Push 40480 by nfay@mozilla.com at Wed, 14 Dec 2022 03:34:16 +0000
Bug 1805430 part 2 - Optimize generateNewDictionaryShape a bit. r=jonco Adds a constructor that takes the object for which we want to create a new shape, so that we can get rid of some roots. Differential Revision: https://phabricator.services.mozilla.com/D164572
6116446bee0d7040759293cdee089fc45ba371e4: Bug 1805430 part 1 - Handle dictionary shapes in Shape::replaceShape too. r=jonco
Jan de Mooij <jdemooij@mozilla.com> - Tue, 13 Dec 2022 16:57:16 +0000 - rev 645888
Push 40480 by nfay@mozilla.com at Wed, 14 Dec 2022 03:34:16 +0000
Bug 1805430 part 1 - Handle dictionary shapes in Shape::replaceShape too. r=jonco This makes the code for dictionary shapes more similar to the other shapes and simplifies the callers. It's also more efficient because instead of cloning the shape and then mutating it, the new shape now has the right contents from the start. Differential Revision: https://phabricator.services.mozilla.com/D164571