searching for reviewer(jmathies)
0d00c57ab29c8e98ede494a765c78bbb5b2269db: Bug 1560081 - Convert CSS pixels to device pixels in CursorForImage. r=jmathies
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Thu, 20 Jun 2019 20:00:24 +0000 - rev 479736
Push 36180 by shindli@mozilla.com at Fri, 21 Jun 2019 09:33:06 +0000
Bug 1560081 - Convert CSS pixels to device pixels in CursorForImage. r=jmathies Differential Revision: https://phabricator.services.mozilla.com/D35325
6fc16812b03938bcff91832fba033a2b7adf1c9d: Bug 1519434 - make nsPluginTag and the addon manager agree about what is and isn't flash, r=jmathies,aswan
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 13 Jun 2019 08:41:43 +0000 - rev 478657
Push 36148 by shindli@mozilla.com at Thu, 13 Jun 2019 21:50:57 +0000
Bug 1519434 - make nsPluginTag and the addon manager agree about what is and isn't flash, r=jmathies,aswan Differential Revision: https://phabricator.services.mozilla.com/D34214
96fe8a446f82be1d908ca0d38996c19b59dc6cc6: Bug 1519434 - only allow perma-enabling non-flash plugins, r=jmathies,aswan
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 13 Jun 2019 08:41:28 +0000 - rev 478656
Push 36148 by shindli@mozilla.com at Thu, 13 Jun 2019 21:50:57 +0000
Bug 1519434 - only allow perma-enabling non-flash plugins, r=jmathies,aswan Differential Revision: https://phabricator.services.mozilla.com/D34213
49c64ed2e67b4e7dbb6a2c3736744acce3fda5c7: Bug 1519434 - make nsPluginTag and the addon manager agree about what is and isn't flash, r=jmathies,aswan
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 12 Jun 2019 18:49:56 +0000 - rev 478519
Push 36145 by aciure@mozilla.com at Thu, 13 Jun 2019 03:50:31 +0000
Bug 1519434 - make nsPluginTag and the addon manager agree about what is and isn't flash, r=jmathies,aswan Differential Revision: https://phabricator.services.mozilla.com/D34214
dd009a001c6ca677f794f4a84fe2471af5e3707c: Bug 1519434 - only allow perma-enabling non-flash plugins, r=jmathies,aswan
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 12 Jun 2019 18:49:42 +0000 - rev 478518
Push 36145 by aciure@mozilla.com at Thu, 13 Jun 2019 03:50:31 +0000
Bug 1519434 - only allow perma-enabling non-flash plugins, r=jmathies,aswan Differential Revision: https://phabricator.services.mozilla.com/D34213
29bf2cb2b9f3738cbd132c36d3143ade994dc383: Bug 1548630: Preload wintypes.dll off main thread; r=jmathies
Aaron Klotz <aklotz@mozilla.com> - Mon, 10 Jun 2019 18:43:23 +0000 - rev 478108
Push 36136 by nerli@mozilla.com at Tue, 11 Jun 2019 03:18:15 +0000
Bug 1548630: Preload wintypes.dll off main thread; r=jmathies Differential Revision: https://phabricator.services.mozilla.com/D34030
0039b4ffc66b12682f787bad0eb949afe73216c3: Bug 1557282: Add SetLockdownDefaultDacl to the content process sandbox policy. r=jmathies
Bob Owen <bobowencode@gmail.com> - Thu, 06 Jun 2019 12:05:04 +0100 - rev 477659
Push 36120 by ncsoregi@mozilla.com at Thu, 06 Jun 2019 21:53:19 +0000
Bug 1557282: Add SetLockdownDefaultDacl to the content process sandbox policy. r=jmathies
2292724aa3f9057a968858119527ca0cf197741c: Bug 1543804 - Don't allow cross-origin POST redirects on 308 codes; r=jmathies
Kyle Machulis <kyle@nonpolynomial.com> - Tue, 21 May 2019 15:05:23 +0000 - rev 476961
Push 36112 by malexandru@mozilla.com at Wed, 05 Jun 2019 15:52:48 +0000
Bug 1543804 - Don't allow cross-origin POST redirects on 308 codes; r=jmathies We already don't allow cross origin POST redirects on 307 redirects, this adds extra guards to make sure we don't allow them on 308s either. Differential Revision: https://phabricator.services.mozilla.com/D28927
a32eceb33855532895ec8fbec096b8d8294f684d: Bug 1555783 - [Wayland] Don't send XDisplay fd over IPC on Wayland, r=jmathies
Martin Stransky <stransky@redhat.com> - Fri, 31 May 2019 16:19:48 +0000 - rev 476513
Push 36097 by dluca@mozilla.com at Sun, 02 Jun 2019 09:42:12 +0000
Bug 1555783 - [Wayland] Don't send XDisplay fd over IPC on Wayland, r=jmathies Differential Revision: https://phabricator.services.mozilla.com/D33255
8f236d0ba0fac44d77a3098b85adf085feef9e3a: Bug 1549972 - Use ClientMarginHitTestPoint when checking if the mouse is within a draggable region. r=jmathies
Mike Conley <mconley@mozilla.com> - Thu, 09 May 2019 15:00:34 +0000 - rev 473463
Push 35998 by rmaries@mozilla.com at Sat, 11 May 2019 09:44:50 +0000
Bug 1549972 - Use ClientMarginHitTestPoint when checking if the mouse is within a draggable region. r=jmathies ClientMarginHitTestPoint takes into account the fact that we want a minimum of kResizableBorderMinSize pixels thickness around the window to trigger resizing. Differential Revision: https://phabricator.services.mozilla.com/D30427
d1615ffd338f011c56be6810eda9bd53782c272a: Bug 1548475 - [Wayland] Disable Flash on Wayland backend, r=jmathies
Martin Stransky <stransky@redhat.com> - Thu, 09 May 2019 15:03:13 +0000 - rev 473295
Push 35993 by nbeleuzu@mozilla.com at Fri, 10 May 2019 02:54:27 +0000
Bug 1548475 - [Wayland] Disable Flash on Wayland backend, r=jmathies Differential Revision: https://phabricator.services.mozilla.com/D30020
81f1c693b2dd58da05c719269dfbde369ed127db: Bug 1547422 - Make widget use mozilla::PresShell directly rather than via nsIPresShell r=jmathies
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 01 May 2019 18:52:59 +0000 - rev 472192
Push 35950 by cbrindusan@mozilla.com at Thu, 02 May 2019 09:52:27 +0000
Bug 1547422 - Make widget use mozilla::PresShell directly rather than via nsIPresShell r=jmathies This patch makes widget use `mozilla::PresShell` directly rather than via `nsIPresShell` and changes some pure virtual methods of `nsIPresShell` which called by widget to `mozilla::PresShell`'s non-virtual methods. Differential Revision: https://phabricator.services.mozilla.com/D29112
e8b8985aa697ef4dad6ed72957186c658669bc1d: Bug 1531789 - skip browser_checkdllblockliststate.js on win-ccov. r=jmathies
Julien Cristau <jcristau@mozilla.com> - Fri, 26 Apr 2019 16:27:48 +0000 - rev 471580
Push 35921 by nbeleuzu@mozilla.com at Sat, 27 Apr 2019 09:45:52 +0000
Bug 1531789 - skip browser_checkdllblockliststate.js on win-ccov. r=jmathies Differential Revision: https://phabricator.services.mozilla.com/D28803
434766cf660f8af665892473b7eb8a4b98b8e0f9: Bug 1546836 - Video Playback and Form Rendering Issues on macOS Version 10.14.5 Beta r=jmathies
Haik Aftandilian <haftandilian@mozilla.com> - Fri, 26 Apr 2019 16:28:06 +0000 - rev 471534
Push 35920 by aiakab@mozilla.com at Fri, 26 Apr 2019 22:02:33 +0000
Bug 1546836 - Video Playback and Form Rendering Issues on macOS Version 10.14.5 Beta r=jmathies Allow access to Apple's Metal shader language compiler in our content process sandbox. Limit the sandbox policy change to 10.14 and newer OS versions to reduce risk given that problems have only been reported on 10.14.5. Differential Revision: https://phabricator.services.mozilla.com/D28904
0930049c0ca984c909d11ba2853ef6d96e43e242: Bug 1534389 - Send normal mouse events when cursor is over a draggable region on Windows. r=jmathies
Mike Conley <mconley@mozilla.com> - Wed, 17 Apr 2019 18:08:22 +0000 - rev 469954
Push 35884 by apavel@mozilla.com at Thu, 18 Apr 2019 21:35:00 +0000
Bug 1534389 - Send normal mouse events when cursor is over a draggable region on Windows. r=jmathies Differential Revision: https://phabricator.services.mozilla.com/D23231
41227706dc2976d7234149cff0bf148ddc3b1d0a: Bug 1539348 - Write old bitmap format for wallpaper support of Windows 7. r=jmathies
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 15 Apr 2019 19:47:28 +0000 - rev 469634
Push 35878 by apavel@mozilla.com at Tue, 16 Apr 2019 15:43:40 +0000
Bug 1539348 - Write old bitmap format for wallpaper support of Windows 7. r=jmathies This is regression by bug 1502772. Windows 7 doesn't support bitmap v4 format for wallpaper. So I revert to previous code to write wallpaper bitmap. Differential Revision: https://phabricator.services.mozilla.com/D27465
883a5cbce017cf7e4e63595f2b764f896923823c: Bug 1534389 - Send normal mouse events when cursor is over a draggable region on Windows. r=jmathies
Mike Conley <mconley@mozilla.com> - Fri, 12 Apr 2019 13:10:23 +0000 - rev 469294
Push 35861 by btara@mozilla.com at Fri, 12 Apr 2019 21:56:33 +0000
Bug 1534389 - Send normal mouse events when cursor is over a draggable region on Windows. r=jmathies Differential Revision: https://phabricator.services.mozilla.com/D23231
4217a9f913d036c5473f5d6596503a1d5a9efcfa: Bug 1534196: Correct return values from failed brokering. r=jmathies
Bob Owen <bobowencode@gmail.com> - Mon, 08 Apr 2019 08:54:27 +0100 - rev 468318
Push 35832 by dluca@mozilla.com at Mon, 08 Apr 2019 10:46:25 +0000
Bug 1534196: Correct return values from failed brokering. r=jmathies
a22437396b3703927e1c2e453e2fee3166311c45: Bug 1525583 - Add more null checks for NPN_RetainObject; r=jmathies
Kyle Machulis <kyle@nonpolynomial.com> - Wed, 03 Apr 2019 19:52:40 +0000 - rev 467834
Push 35810 by aciure@mozilla.com at Thu, 04 Apr 2019 04:33:36 +0000
Bug 1525583 - Add more null checks for NPN_RetainObject; r=jmathies Don't try to change refcount on null pointer if one is passed. Differential Revision: https://phabricator.services.mozilla.com/D25982
946839452979779d172ac4e85d2c65730d553da7: Bug 1522848 - Add Lock Aspect Ratio feature. r=mconley,jmathies.
meandave <djustice@mozilla.com> - Mon, 18 Mar 2019 20:07:31 +0000 - rev 464900
Push 35727 by dvarga@mozilla.com at Tue, 19 Mar 2019 09:48:59 +0000
Bug 1522848 - Add Lock Aspect Ratio feature. r=mconley,jmathies. *** Bug 1522848 - Smoothing out Lock Aspect Ratio feature r?mconley. Differential Revision: https://phabricator.services.mozilla.com/D20713
c26e947b78c28aebdfe2e6e96331f8e90de1d9f9: Bug 1534389 - Send normal mouse events when cursor is over a draggable region on Windows. r=jmathies
Mike Conley <mconley@mozilla.com> - Mon, 18 Mar 2019 20:02:27 +0000 - rev 464884
Push 35727 by dvarga@mozilla.com at Tue, 19 Mar 2019 09:48:59 +0000
Bug 1534389 - Send normal mouse events when cursor is over a draggable region on Windows. r=jmathies Differential Revision: https://phabricator.services.mozilla.com/D23231
8db388171af6d6d1f9737923f988df27f67bdb33: Bug 1534935: Fix non-nsView ShouldNotBeVisible(). r=jmathies
Adam Gashlin <agashlin@mozilla.com> - Fri, 15 Mar 2019 21:21:05 +0000 - rev 464459
Push 35716 by aciure@mozilla.com at Sun, 17 Mar 2019 09:42:17 +0000
Bug 1534935: Fix non-nsView ShouldNotBeVisible(). r=jmathies The comment was correct, the base impl should always return false as we don't have an opinion about visibility. Differential Revision: https://phabricator.services.mozilla.com/D23598
767ee8714acf825c878a4079eeb40aaf27abb738: Bug 1535144: Make -new-instance only stop searching for existing instances on startup. r=jmathies
Dave Townsend <dtownsend@oxymoronical.com> - Thu, 14 Mar 2019 13:28:16 +0000 - rev 464000
Push 35705 by rmaries@mozilla.com at Thu, 14 Mar 2019 21:39:47 +0000
Bug 1535144: Make -new-instance only stop searching for existing instances on startup. r=jmathies Differential Revision: https://phabricator.services.mozilla.com/D23411
19d90e94a7ece27154c6ed35466d86072910041d: Bug 1532140 - Cleanup nsDataObj. r=jmathies
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Wed, 13 Mar 2019 19:00:59 +0000 - rev 463967
Push 35703 by dluca@mozilla.com at Thu, 14 Mar 2019 16:23:33 +0000
Bug 1532140 - Cleanup nsDataObj. r=jmathies * Removed dead code. * Removed a duplicated field (`m_cRef`) from the derived class. * Removed #ifdefs for older SDKs that we no longer support. * Made access specifiers more restrictive. * Added `override` and `final`. * De-virtualized member functions unless it is neccessary. Differential Revision: https://phabricator.services.mozilla.com/D21864
fdd61e6fb91139bedb183b393f4eecd45f914356: Bug 1533708: Properly shut down the remote service before launching Firefox again. r=jmathies
Dave Townsend <dtownsend@oxymoronical.com> - Mon, 11 Mar 2019 14:58:08 +0000 - rev 463502
Push 35686 by btara@mozilla.com at Tue, 12 Mar 2019 09:50:48 +0000
Bug 1533708: Properly shut down the remote service before launching Firefox again. r=jmathies The main changes here are to stop checking if we're shutting down when we already know we are shutting down and making sure the windows remote server shuts down properly. I also spotted that nsINativeAppSupport.quit is now unused so I removed it. Differential Revision: https://phabricator.services.mozilla.com/D22771
067c36284e776e3e03d33d3ad99d110be04230af: Bug 1498973: Don't show a popup that should be hidden. r=jmathies
Adam Gashlin <agashlin@mozilla.com> - Wed, 06 Mar 2019 18:48:50 +0000 - rev 462686
Push 35657 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:32:57 +0000
Bug 1498973: Don't show a popup that should be hidden. r=jmathies Differential Revision: https://phabricator.services.mozilla.com/D21801
e1b938568978bc8912e269a924074bb54737c348: Bug 1528353 - Re-enable browser_checkdllblockliststate.js on Win10 now that we're using version 1803 in CI. r=jmathies
Ryan VanderMeulen <ryanvm@gmail.com> - Thu, 28 Feb 2019 22:33:12 +0000 - rev 461826
Push 35629 by opoprus@mozilla.com at Fri, 01 Mar 2019 05:20:57 +0000
Bug 1528353 - Re-enable browser_checkdllblockliststate.js on Win10 now that we're using version 1803 in CI. r=jmathies Differential Revision: https://phabricator.services.mozilla.com/D19977
be96f71b4344ffa18e7621bbc21e236f1a596d31: Bug 1525583 - Add null checks for before retaining NPAPI objects; r=jmathies
Kyle Machulis <kyle@nonpolynomial.com> - Mon, 25 Feb 2019 19:28:51 +0000 - rev 460966
Push 35613 by nerli@mozilla.com at Tue, 26 Feb 2019 03:52:35 +0000
Bug 1525583 - Add null checks for before retaining NPAPI objects; r=jmathies Remove assertion and add actual checks to make sure we're retaining live objects, not nullptrs. Return error if retain doesn't work. Differential Revision: https://phabricator.services.mozilla.com/D20538
0176f4dc4345f1e7620f3984a7be294757616b2b: Bug 1521928 - Enable Eslint for widget (manual changes). r=Standard8,jmathies
championshuttler <shivams2799@gmail.com> - Thu, 14 Feb 2019 20:20:18 +0000 - rev 459393
Push 35561 by csabou@mozilla.com at Fri, 15 Feb 2019 18:37:54 +0000
Bug 1521928 - Enable Eslint for widget (manual changes). r=Standard8,jmathies Differential Revision: https://phabricator.services.mozilla.com/D18580
0e0638c8ef27dea641754aae390213e829eb71f3: Bug 1521928 - Enable ESLint for widget (automatic changes). r=Standard8,jmathies
championshuttler <shivams2799@gmail.com> - Thu, 14 Feb 2019 20:20:20 +0000 - rev 459392
Push 35561 by csabou@mozilla.com at Fri, 15 Feb 2019 18:37:54 +0000
Bug 1521928 - Enable ESLint for widget (automatic changes). r=Standard8,jmathies Differential Revision: https://phabricator.services.mozilla.com/D18579
e3a71ebe4064261d62f1e36fc9915471663905c0: Bug 1527717 - Check the registry for 'URL Protocol' when checking if a protocol handler exists. r=jmathies
Robert Strong <robert.bugzilla@gmail.com> - Fri, 15 Feb 2019 00:36:26 +0000 - rev 459351
Push 35559 by rmaries@mozilla.com at Fri, 15 Feb 2019 09:55:16 +0000
Bug 1527717 - Check the registry for 'URL Protocol' when checking if a protocol handler exists. r=jmathies Differential Revision: https://phabricator.services.mozilla.com/D19775
9dc88ca66bfa8bf16f1cfd5af000bf06ff75245d: Bug 1519131 - Remove unused preference cache for pointer event; r=jmathies
Edgar Chen <echen@mozilla.com> - Mon, 04 Feb 2019 09:16:30 +0000 - rev 456604
Push 35496 by btara@mozilla.com at Mon, 04 Feb 2019 17:36:40 +0000
Bug 1519131 - Remove unused preference cache for pointer event; r=jmathies Differential Revision: https://phabricator.services.mozilla.com/D16198
8a968b7beaba6fb6f5e6323298db98501e28ef44: Bug 1521690 - Use `Unused <<` instead of `(void*)` in nsWindow.cpp r=aklotz,jmathies
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 01 Feb 2019 20:15:04 +0000 - rev 456574
Push 35490 by aiakab@mozilla.com at Sun, 03 Feb 2019 09:50:26 +0000
Bug 1521690 - Use `Unused <<` instead of `(void*)` in nsWindow.cpp r=aklotz,jmathies Casting non-void result to `void*` causes warning of clang. Additionally, perhaps, we should use `Unused <<` because of modern style. And also this patch makes widget/windows is treated as "warning as errors" because this patch fixes the last warning. Differential Revision: https://phabricator.services.mozilla.com/D17216
edfd8a13603c0d5ebb69362dff02bb138f616127: Bug 1520502 - Set the standard cursor and the custom cursor in the same IPC message. r=jmathies
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 15 Jan 2019 14:56:52 +0100 - rev 455520
Push 35439 by aciure@mozilla.com at Sat, 26 Jan 2019 09:35:29 +0000
Bug 1520502 - Set the standard cursor and the custom cursor in the same IPC message. r=jmathies This cleans up a bit and allows us to be smarter about which cursors should we allow from content or what not, which will help with bug 1445844 and co. Differential Revision: https://phabricator.services.mozilla.com/D16711
3883a443b7f893bb8424c8a57ba376bbd1d3d275: Bug 1521694 - Make DisplaySystemMenu() handle all nsSizeMode value r=jmathies
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 25 Jan 2019 22:17:26 +0000 - rev 455513
Push 35439 by aciure@mozilla.com at Sat, 26 Jan 2019 09:35:29 +0000
Bug 1521694 - Make DisplaySystemMenu() handle all nsSizeMode value r=jmathies DisplaySystemMenu() does not handle nsSizeMode_Invalid that causes warning of clang. This patch makes it treat nsSizeMode_Invalid. When it receives the value, it will call NS_ASSERTION() to be detectable on debug builds during automated tests. Additionally, this adds default case into the switch statement with MOZ_ASSERT_UNREACHABLE(). Then, when somebody adds new nsSizeMode, they can detect it with crash in debug build if they forget to change this method. Differential Revision: https://phabricator.services.mozilla.com/D17217
bdf350144ce46d0e5ab7974ca365a034bec09457: Bug 1521686 - Get rid of unused EnsureSharedSurfaceSize() method r=jmathies
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 25 Jan 2019 22:18:28 +0000 - rev 455512
Push 35439 by aciure@mozilla.com at Sat, 26 Jan 2019 09:35:29 +0000
Bug 1521686 - Get rid of unused EnsureSharedSurfaceSize() method r=jmathies The method was added by bug 506926, but not sure when this becomes an orphan. Differential Revision: https://phabricator.services.mozilla.com/D17215
49be7aaa199c0be85ec2667c650d4627cfec84c1: Bug 1449736: Properly detect failure in receiving plugin NPObjects (r=jmathies)
David Parks <dparks@mozilla.com> - Wed, 09 Jan 2019 16:36:59 +0000 - rev 453328
Push 35352 by dvarga@mozilla.com at Fri, 11 Jan 2019 04:12:48 +0000
Bug 1449736: Properly detect failure in receiving plugin NPObjects (r=jmathies) We need to recognize IPDL errors in order to return the proper error status when the right PluginScriptableObject could not be found. Differential Revision: https://phabricator.services.mozilla.com/D15469
34d4a5081960a1623e0ebdf9e4fb60c7b167b8f4: Bug 1514715 - Update color prefs for new color IDs including -moz-win-accentcolor r=jmathies
Kestrel <ke5trel@protonmail.com> - Wed, 09 Jan 2019 16:37:34 +0000 - rev 453235
Push 35349 by btara@mozilla.com at Thu, 10 Jan 2019 17:19:27 +0000
Bug 1514715 - Update color prefs for new color IDs including -moz-win-accentcolor r=jmathies Differential Revision: https://phabricator.services.mozilla.com/D14723
741ded5432288db8ea024097cd3e597ddde895fa: Bug 1514501 - Fix screen selection and scaling for fullscreen r=jmathies
Adam Gashlin <agashlin@mozilla.com> - Wed, 09 Jan 2019 16:35:40 +0000 - rev 453143
Push 35346 by shindli@mozilla.com at Thu, 10 Jan 2019 04:03:25 +0000
Bug 1514501 - Fix screen selection and scaling for fullscreen r=jmathies I needed to scale the layout device pixels coming from Windows before passing them to ScreenForRect(). Also, I'm using GetRect() directly instead of GetRectDisplayPix() * scale now, to avoid an unnecessary double scale & round which was making fullscreen windows off by one pixel in many cases. Differential Revision: https://phabricator.services.mozilla.com/D15604
96a8f877b609085e221449cb97626fd1dee8c4f6: Bug 1516068 - Fix a wrong indentation in nsNativeThemeWin. r=jmathies
Xidorn Quan <me@upsuper.org> - Wed, 09 Jan 2019 16:37:02 +0000 - rev 453139
Push 35346 by shindli@mozilla.com at Thu, 10 Jan 2019 04:03:25 +0000
Bug 1516068 - Fix a wrong indentation in nsNativeThemeWin. r=jmathies Differential Revision: https://phabricator.services.mozilla.com/D15246
79479820561019d20b344650b7b3c72fb0321aaa: Bug 1513066 - Scale monitor size when forcing fullscreen. r=jmathies
Adam Gashlin <agashlin@mozilla.com> - Thu, 13 Dec 2018 20:35:23 +0000 - rev 450479
Push 35202 by btara@mozilla.com at Fri, 14 Dec 2018 05:43:22 +0000
Bug 1513066 - Scale monitor size when forcing fullscreen. r=jmathies Differential Revision: https://phabricator.services.mozilla.com/D14328
c0d6af045dff28630000382155d8c0632c7e1913: Bug 1501433 - Remove nsNativeTheme::GetScrollbar{Face,Track}Color. r=jmathies
Xidorn Quan <me@upsuper.org> - Wed, 24 Oct 2018 07:21:51 +1100 - rev 448732
Push 35124 by dvarga@mozilla.com at Thu, 29 Nov 2018 17:00:30 +0000
Bug 1501433 - Remove nsNativeTheme::GetScrollbar{Face,Track}Color. r=jmathies The functions were introduced in bug 1460456 as part of the initial impl of scrollbar color properties, and then got moved to nsNativeTheme in bug 1464722 to be shared with cocoa impl. Its usage is later removed in bug 1494607 and bug 1498216 as we turn to rely on native blending instead, and these functions become unused. Differential Revision: https://phabricator.services.mozilla.com/D9596
bcc079816150ebbb4e20c2cb7c68560b8cdfb075: Bug 1482920: Force fullscreen window position. r=jmathies
Adam Gashlin <agashlin@mozilla.com> - Wed, 28 Nov 2018 20:05:06 +0000 - rev 448576
Push 35119 by ccoroiu@mozilla.com at Thu, 29 Nov 2018 04:26:53 +0000
Bug 1482920: Force fullscreen window position. r=jmathies Differential Revision: https://phabricator.services.mozilla.com/D13042
646caf2d457718a4931d31f637be2e2757c72127: Bug 1502977 - Reinstate the code blocking the "Facebook Photo Uploader" plugin on Mac and update the associated annotation r=jmathies
Gabriele Svelto <gsvelto@mozilla.com> - Wed, 28 Nov 2018 18:52:41 +0000 - rev 448566
Push 35119 by ccoroiu@mozilla.com at Thu, 29 Nov 2018 04:26:53 +0000
Bug 1502977 - Reinstate the code blocking the "Facebook Photo Uploader" plugin on Mac and update the associated annotation r=jmathies Differential Revision: https://phabricator.services.mozilla.com/D12354
943c165146e677a243702a51d5d9f3a5cfe163ba: Bug 1498831: Exclude ID_GetFileAttributesW enum from Windows builds without MOZ_SANDBOX (r=jmathies)
David Parks <dparks@mozilla.com> - Tue, 16 Oct 2018 11:48:51 +0000 - rev 441502
Push 34866 by shindli@mozilla.com at Wed, 17 Oct 2018 00:54:47 +0000
Bug 1498831: Exclude ID_GetFileAttributesW enum from Windows builds without MOZ_SANDBOX (r=jmathies) All of the enum entries must have a FunctionHook object but GetFileAttributesW only gets one if MOZ_SANDBOX is defined. This aligns the #define behavior of the enum with the #define behavior of its usage in FunctionHook. Differential Revision: https://phabricator.services.mozilla.com/D8745
e63e2e4c0484d98b97a39215387553fca3d52b8d: Bug 1488439: Part 2 - Patch GetFileAttributesW for appdata parent folders in sandboxed plugin process (r=bobowen,jmathies)
David Parks <dparks@mozilla.com> - Fri, 12 Oct 2018 22:36:56 +0000 - rev 440961
Push 34841 by aciure@mozilla.com at Sat, 13 Oct 2018 09:35:03 +0000
Bug 1488439: Part 2 - Patch GetFileAttributesW for appdata parent folders in sandboxed plugin process (r=bobowen,jmathies) Flash analyzes the parents of the path to its appdata folder on Windows using GetFileAttributesW. If it runs into an error, it makes some internal decisions that cause it to break DRM video. Our new sandbox hardening causes GetFileAttributesW to return an error for some components of the path. This patch alters the behavior of GetFileAttributesW so that it always reports FILE_ATTRIBUTE_DIRECTORY for any path that both 1) would otherwise return an error and 2) is an ancestor of the appdata folder. This may not always be 100% accurate (for instance, if the folder is a reparse point) but restores video functionality. Depends on D7532 Differential Revision: https://phabricator.services.mozilla.com/D7533
74b2087ee696eb7369b65727b81fc67121789f7d: Bug 1488439: Part 2 - Patch GetFileAttributesW for appdata parent folders in sandboxed plugin process (r=bobowen,jmathies)
David Parks <dparks@mozilla.com> - Fri, 12 Oct 2018 17:41:29 +0000 - rev 440912
Push 34841 by aciure@mozilla.com at Sat, 13 Oct 2018 09:35:03 +0000
Bug 1488439: Part 2 - Patch GetFileAttributesW for appdata parent folders in sandboxed plugin process (r=bobowen,jmathies) Flash analyzes the parents of the path to its appdata folder on Windows using GetFileAttributesW. If it runs into an error, it makes some internal decisions that cause it to break DRM video. Our new sandbox hardening causes GetFileAttributesW to return an error for some components of the path. This patch alters the behavior of GetFileAttributesW so that it always reports FILE_ATTRIBUTE_DIRECTORY for any path that both 1) would otherwise return an error and 2) is an ancestor of the appdata folder. This may not always be 100% accurate (for instance, if the folder is a reparse point) but restores video functionality. Depends on D7532 Differential Revision: https://phabricator.services.mozilla.com/D7533
b85ace8c5339f5f24e7d104b4a8146dc92bb694d: Bug 1497221 - Fix warnings in nsNativeThemeWin.cpp when built with clang r=jmathies
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 09 Oct 2018 17:01:19 +0000 - rev 440360
Push 34814 by rgurzau@mozilla.com at Wed, 10 Oct 2018 04:34:57 +0000
Bug 1497221 - Fix warnings in nsNativeThemeWin.cpp when built with clang r=jmathies nsNativeThemeWin.cpp has a lot of warnings at build time. They hides preceding errors and warning due to too many. This patch avoids the warnings with: - adding |default| case of each |switch| statement with widget type. - removing unused overload of ScaleForFrameDPI(). Differential Revision: https://phabricator.services.mozilla.com/D8055
87fec627956b5fa5a56138ae8f4bb9e7c0e9d943: Bug 1495245 - Refactor AudioDeviceMessageRunnable's use of the PluginModuleSet. r=jmathies
David Parks <dparks@mozilla.com> - Tue, 09 Oct 2018 18:02:12 -0400 - rev 440341
Push 34814 by rgurzau@mozilla.com at Wed, 10 Oct 2018 04:34:57 +0000
Bug 1495245 - Refactor AudioDeviceMessageRunnable's use of the PluginModuleSet. r=jmathies Changes AudioDeviceMessageRunnable to hold the AudioNotification instead of its PluginModuleSet to simplify object lifetime issues. AudioNotification is ref-counted so we can increment its ref-count during the asynchronous Runnable. Differential Revision: https://phabricator.services.mozilla.com/D7555
91e7bbcc957a87805acaf96fe699df741f6a20ce: Bug 1494607 - Paint on gfxContext directly for custom scrollbar parts. r=jmathies
Xidorn Quan <me@upsuper.org> - Tue, 09 Oct 2018 17:03:35 +0000 - rev 440329
Push 34814 by rgurzau@mozilla.com at Wed, 10 Oct 2018 04:34:57 +0000
Bug 1494607 - Paint on gfxContext directly for custom scrollbar parts. r=jmathies The main benefit of doing this is that if semi-transparent colors are specified on scrollbar-color, they can blend natively with underlying content. This may match authors' expectation better. Differential Revision: https://phabricator.services.mozilla.com/D7154