searching for reviewer(jld)
182966bfca87b7f3b4897b760113da45c84c043a: Bug 1529022 - Add a GeckoChildProcessHosts iterator r=jld
Tarek Ziadé <tarek@mozilla.com> - Fri, 21 Jun 2019 01:33:47 +0000 - rev 479777
Push 36180 by shindli@mozilla.com at Fri, 21 Jun 2019 09:33:06 +0000
Bug 1529022 - Add a GeckoChildProcessHosts iterator r=jld Adds GeckoChildProcessHost::GetAll() and use it in ChromeUtils::GetProcInfo() Differential Revision: https://phabricator.services.mozilla.com/D33920
f79736d79ee10a1d26cbf42ec9fe02a303b74e22: Bug 1529022 - Add a GeckoChildProcessHosts iterator r=jld
Tarek Ziadé <tarek@mozilla.com> - Wed, 19 Jun 2019 06:13:50 +0000 - rev 479222
Push 36174 by opoprus@mozilla.com at Wed, 19 Jun 2019 21:38:13 +0000
Bug 1529022 - Add a GeckoChildProcessHosts iterator r=jld Adds GeckoChildProcessHost::GetAll() and use it in ChromeUtils::GetProcInfo() Differential Revision: https://phabricator.services.mozilla.com/D33920
11c118fa5f2bfe81cda414f9108e4f71f7e8fe64: Bug 1529022 - Add a GeckoChildProcessHosts iterator r=jld
Tarek Ziadé <tarek@mozilla.com> - Tue, 18 Jun 2019 16:36:52 +0000 - rev 479130
Push 36170 by cbrindusan@mozilla.com at Wed, 19 Jun 2019 03:56:45 +0000
Bug 1529022 - Add a GeckoChildProcessHosts iterator r=jld Adds GeckoChildProcessHost::GetAll() and use it in ChromeUtils::GetProcInfo() Differential Revision: https://phabricator.services.mozilla.com/D33920
381a74484140c4183bc8d3b094848a95214795ed: Bug 1315460 - Removal of keygen element r=keeler,baku,jld,hsivonen
Jonathan Kingston <jkt@mozilla.com> - Thu, 13 Jun 2019 08:58:07 +0000 - rev 478642
Push 36148 by shindli@mozilla.com at Thu, 13 Jun 2019 21:50:57 +0000
Bug 1315460 - Removal of keygen element r=keeler,baku,jld,hsivonen Differential Revision: https://phabricator.services.mozilla.com/D22810
370c40e4923073a87845b57c1f4851bacd9663da: Bug 1552160 Part 1: Roll-up of chromium sandbox update and mozilla patches to get a running browser. r=jld,aklotz,tjr,bobowen
Bob Owen <bobowencode@gmail.com> - Wed, 12 Jun 2019 11:10:48 +0100 - rev 478495
Push 36144 by aciure@mozilla.com at Wed, 12 Jun 2019 21:42:35 +0000
Bug 1552160 Part 1: Roll-up of chromium sandbox update and mozilla patches to get a running browser. r=jld,aklotz,tjr,bobowen This updates security/sandbox/chromium/ files to chromium commit 84108231f6e6e0772fb9a4643679ce76aa771e67. Existing and new patches applied from security/sandbox/chromium-shim/patches/with_update/ to give a compiling and mostly working browser. See patch files for additional commit comments.
b2cb7ee93eef1d56006716ed24f3d0c11e071f11: Bug 1555076 - avoid a potential timeout race on Windows RDD launch. r=jld
Michael Froman <mfroman@mozilla.com> - Mon, 10 Jun 2019 15:03:46 +0000 - rev 478240
Push 36138 by rgurzau@mozilla.com at Tue, 11 Jun 2019 21:33:19 +0000
Bug 1555076 - avoid a potential timeout race on Windows RDD launch. r=jld Differential Revision: https://phabricator.services.mozilla.com/D34186
1d330fafedddde0c820308cddfd4e30351bfd477: Bug 1555891 - Merge PVideoDecoder into PRemoteDecoder. r=jya,jld
Matt Woodrow <mwoodrow@mozilla.com> - Tue, 11 Jun 2019 02:01:51 +0000 - rev 478152
Push 36137 by cbrindusan@mozilla.com at Tue, 11 Jun 2019 09:40:01 +0000
Bug 1555891 - Merge PVideoDecoder into PRemoteDecoder. r=jya,jld Differential Revision: https://phabricator.services.mozilla.com/D33587
a1198059b0809f9c752511256aaaec26a2c56a29: Bug 1555891 - Merge PVideoDecoderManager into PRemoteDecoderManager. r=jya,jld
Matt Woodrow <mwoodrow@mozilla.com> - Tue, 11 Jun 2019 02:01:34 +0000 - rev 478151
Push 36137 by cbrindusan@mozilla.com at Tue, 11 Jun 2019 09:40:01 +0000
Bug 1555891 - Merge PVideoDecoderManager into PRemoteDecoderManager. r=jya,jld Differential Revision: https://phabricator.services.mozilla.com/D33586
5a608649393bef07f165cba9526c5e859b9da090: Bug 1529023 - Enable threads on macOS for GetProcInfo r=jld,mstange
Tarek Ziadé <tarek@mozilla.com> - Fri, 07 Jun 2019 19:56:51 +0000 - rev 477959
Push 36129 by ncsoregi@mozilla.com at Sun, 09 Jun 2019 09:06:18 +0000
Bug 1529023 - Enable threads on macOS for GetProcInfo r=jld,mstange To run task_for_pid() on child processes, we need the child task port for security reasons. This port can be obtained via a Mach IPC exchange. This is what GeckoChildProcessHost::GetChildTask() provides, so we use it in cocoa's version of GetProcInfo() Differential Revision: https://phabricator.services.mozilla.com/D25927
0635eeb2fad4f1bae96a51c85f8adddc11693e41: Bug 1529023 - Enable threads on macOS for GetProcInfo r=jld,mstange
Tarek Ziadé <tarek@mozilla.com> - Fri, 07 Jun 2019 07:48:37 +0000 - rev 477876
Push 36125 by apavel@mozilla.com at Fri, 07 Jun 2019 22:00:07 +0000
Bug 1529023 - Enable threads on macOS for GetProcInfo r=jld,mstange To run task_for_pid() on child processes, we need the child task port for security reasons. This port can be obtained via a Mach IPC exchange. This is what GeckoChildProcessHost::GetChildTask() provides, so we use it in cocoa's version of GetProcInfo() Differential Revision: https://phabricator.services.mozilla.com/D25927
4357d695b8d5dd901788d922b73e89f16c45b2c9: Bug 1464032 Part 12: Add CanvasParent, CanvasChild and RecordedTextureData. r=mattwoodrow, jld
Bob Owen <bobowencode@gmail.com> - Sun, 02 Dec 2018 14:19:11 +0000 - rev 477808
Push 36124 by dvarga@mozilla.com at Fri, 07 Jun 2019 16:20:31 +0000
Bug 1464032 Part 12: Add CanvasParent, CanvasChild and RecordedTextureData. r=mattwoodrow, jld RecordedTextureData records TextureData calls for play back in the GPU process. CanvasChild and CanvasParent set up the recorder and translator. They also help to manage the starting of translation and co-ordinating the translation with the frame transactions. This patch also includes other changes to wire up recording and playback.
eba3d102aaaec6b608d61f35fb5043a44213c3da: Bug 1555589 - Include sys/prctl.h not linux/prctl.h. r=jld
Gian-Carlo Pascutto <gcp@mozilla.com> - Mon, 03 Jun 2019 21:35:44 +0000 - rev 476818
Push 36108 by nbeleuzu@mozilla.com at Tue, 04 Jun 2019 21:42:40 +0000
Bug 1555589 - Include sys/prctl.h not linux/prctl.h. r=jld Differential Revision: https://phabricator.services.mozilla.com/D33517
aba5bfdd772bbc630ed53edb59aa43c0544484e8: Bug 1550771 - Deadlock in SharedMemoryBasic_mach triggered by AV1 playback r=jld
Haik Aftandilian <haftandilian@mozilla.com> - Wed, 22 May 2019 01:33:46 +0000 - rev 474881
Push 36048 by shindli@mozilla.com at Wed, 22 May 2019 09:10:21 +0000
Bug 1550771 - Deadlock in SharedMemoryBasic_mach triggered by AV1 playback r=jld Don't hold gMutex when calling HandleSharePortsMessage() from PortServerThread to avoid deadlock. Differential Revision: https://phabricator.services.mozilla.com/D31694
969f29e56fa1b018fe790d888e05df6f1ddbdbb1: Bug 1547085 - Discard messages sent to dead actors, r=jld
Nika Layzell <nika@thelayzells.com> - Tue, 21 May 2019 17:04:25 +0000 - rev 474784
Push 36046 by aiakab@mozilla.com at Tue, 21 May 2019 21:45:52 +0000
Bug 1547085 - Discard messages sent to dead actors, r=jld Historically we've failed very loudly when receiving a message which was destined for an actor which had already been destroyed. This had the effect of requiring manual teardown for most actors, as work would need to be done to ensure messages weren't sent when the target actor might be about to tear itself down. In addition, due to this teardown work being done outside of IPDL, this work would have to manually be checked in subactors, and involved the addition of new flags, such as `mIPCOpen`, in order to track whether IPC had begun to be shut down, and discard messages manually if it had. It is an ongoing issue that we occasionally miss places where we need to discard messages, and it is easy to not remember to perform async destruction when building a new actor, meaning that extra work is required to correctly discard messages when the actor is being torn down. Due to the correct decision, almost all of the time, being to discard the message, this patch takes the approach of transforming the crash which was previously performed into a message discard. The hope is that this will reduce the burden on actor implementors, by allowing the use of `Send__delete__` without first synchronizing with the remote actor, as well as reduce unintentional crashes. Differential Revision: https://phabricator.services.mozilla.com/D28892
a64a71ccebf79139da2288edca29186292c5a257: Bug 1513915 - LSNG: LoadItem could return more items (up to the prefill limit); r=asuth,jld
Jan Varga <jan.varga@gmail.com> - Mon, 08 Apr 2019 10:56:19 +0200 - rev 472576
Push 35968 by ccoroiu@mozilla.com at Sun, 05 May 2019 21:39:08 +0000
Bug 1513915 - LSNG: LoadItem could return more items (up to the prefill limit); r=asuth,jld Differential Revision: https://phabricator.services.mozilla.com/D26476
7de7d6a0be86d400ee23ca1ac806eb358555b28d: Bug 1514869 - patch 8 - Make the SetCharacterMap message async, and use the unshared gfxCharacterMap in the content process until the shared one is in place. r=jwatt,jld
Jonathan Kew <jkew@mozilla.com> - Mon, 29 Apr 2019 14:39:05 +0000 - rev 471760
Push 35934 by shindli@mozilla.com at Mon, 29 Apr 2019 21:53:38 +0000
Bug 1514869 - patch 8 - Make the SetCharacterMap message async, and use the unshared gfxCharacterMap in the content process until the shared one is in place. r=jwatt,jld Differential Revision: https://phabricator.services.mozilla.com/D24137
21ef00977ab69cd330d727d582fef291276391c4: Bug 1514869 - patch 1 - Basic implementation of a cross-process sharable font list, using shared memory to store the list of families & faces, and per-font character maps. r=jwatt,jld
Jonathan Kew <jkew@mozilla.com> - Sat, 27 Apr 2019 15:37:29 +0000 - rev 471753
Push 35934 by shindli@mozilla.com at Mon, 29 Apr 2019 21:53:38 +0000
Bug 1514869 - patch 1 - Basic implementation of a cross-process sharable font list, using shared memory to store the list of families & faces, and per-font character maps. r=jwatt,jld Differential Revision: https://phabricator.services.mozilla.com/D22937
e25e95c59e6b1b913d895183d00461175ae5ab74: Bug 1494469 - Removed duplicate IPC::MAX_MESSAGE_SIZE constant r=jld
hafsa <hijitsuhisa@gmail.com> - Fri, 12 Apr 2019 13:01:41 +0000 - rev 469512
Push 35873 by ccoroiu@mozilla.com at Mon, 15 Apr 2019 21:36:26 +0000
Bug 1494469 - Removed duplicate IPC::MAX_MESSAGE_SIZE constant r=jld The maximum size of an IPC message is defined twice; IPC::Channel::kMaximumMessageSize = 256 MiB and IPC::MAX_MESSAGE_SIZE = 65 KiB . The latter one is used for Windows printing and its small size could cause errors. I removed the small constant, and made changes to the files using it : - The windows printing file now uses kMaximumMessageSize / 2 - nsWebBrowserPersist uses its old constant Differential Revision: https://phabricator.services.mozilla.com/D24972
b34795658d239ba6415a9ad5e72fe10d7de38265: Bug 1541130: Add XRE_GetChildProcBinPathType to nsXULAppAPI.h; r=froydnj,jld on a CLOSED TREE
Aaron Klotz <aklotz@mozilla.com> - Tue, 09 Apr 2019 00:45:24 +0300 - rev 468431
Push 35837 by rmaries@mozilla.com at Tue, 09 Apr 2019 03:43:40 +0000
Bug 1541130: Add XRE_GetChildProcBinPathType to nsXULAppAPI.h; r=froydnj,jld on a CLOSED TREE The binary path type of a particular content process is useful information outside of IPC. Given that `XRE_EnableSameExecutableForContentProc` already exists, and given that the binary path type is closely related to `GeckoProcessType`, I've added a new function, `XRE_GetContentProcBinPathType`. The mapping of process type to binary type has been moved to the `GeckoProcessTypes` definitions. This patch also modifies `ipc::GeckoChildProcessHost` to call into the new function. Differential Revision: https://phabricator.services.mozilla.com/D25816
7ecc024df5d45ada7499e2f70d79670e8c9d4d51: Bug 1541130: Add XRE_GetChildProcBinPathType to nsXULAppAPI.h; r=froydnj,jld
Aaron Klotz <aklotz@mozilla.com> - Mon, 08 Apr 2019 20:19:51 +0000 - rev 468426
Push 35837 by rmaries@mozilla.com at Tue, 09 Apr 2019 03:43:40 +0000
Bug 1541130: Add XRE_GetChildProcBinPathType to nsXULAppAPI.h; r=froydnj,jld The binary path type of a particular content process is useful information outside of IPC. Given that `XRE_EnableSameExecutableForContentProc` already exists, and given that the binary path type is closely related to `GeckoProcessType`, I've added a new function, `XRE_GetContentProcBinPathType`. The mapping of process type to binary type has been moved to the `GeckoProcessTypes` definitions. This patch also modifies `ipc::GeckoChildProcessHost` to call into the new function. Differential Revision: https://phabricator.services.mozilla.com/D25816
656108173cde7bbc6bab7dfee15dea907b0af05a: Bug 1541130: Follow-up: Add more missing parts that had been stripped during rebase; r=froydnj, jld on a CLOSED TREE
Aaron Klotz <aklotz@mozilla.com> - Mon, 08 Apr 2019 13:28:04 -0600 - rev 468406
Push 35837 by rmaries@mozilla.com at Tue, 09 Apr 2019 03:43:40 +0000
Bug 1541130: Follow-up: Add more missing parts that had been stripped during rebase; r=froydnj, jld on a CLOSED TREE
5914a425bc67dc5131c9625052362ebd777aa841: Bug 1541130: Follow-up: Add missing parts that had been stripped out during rebase; r=froydnj, jld on a CLOSED TREE
Aaron Klotz <aklotz@mozilla.com> - Mon, 08 Apr 2019 12:55:55 -0600 - rev 468405
Push 35837 by rmaries@mozilla.com at Tue, 09 Apr 2019 03:43:40 +0000
Bug 1541130: Follow-up: Add missing parts that had been stripped out during rebase; r=froydnj, jld on a CLOSED TREE
8ef30ebad16c538e39b9fb4648a551a3257d9729: Bug 1541130: Add XRE_GetChildProcBinPathType to nsXULAppAPI.h; r=froydnj,jld
Aaron Klotz <aklotz@mozilla.com> - Mon, 08 Apr 2019 18:19:06 +0000 - rev 468399
Push 35835 by aciure@mozilla.com at Mon, 08 Apr 2019 19:00:29 +0000
Bug 1541130: Add XRE_GetChildProcBinPathType to nsXULAppAPI.h; r=froydnj,jld The binary path type of a particular content process is useful information outside of IPC. Given that `XRE_EnableSameExecutableForContentProc` already exists, and given that the binary path type is closely related to `GeckoProcessType`, I've added a new function, `XRE_GetContentProcBinPathType`. The mapping of process type to binary type has been moved to the `GeckoProcessTypes` definitions. This patch also modifies `ipc::GeckoChildProcessHost` to call into the new function. Differential Revision: https://phabricator.services.mozilla.com/D25816
8075337e7cf44caf1b78bc41918c9e475e858a13: bug 1469694 - GeckoChildProcessHost should check the return value of LaunchApp r=jld
Khyati Agarwal <f20160385@hyderabad.bits-pilani.ac.in> - Mon, 01 Apr 2019 21:58:23 +0000 - rev 467769
Push 35810 by aciure@mozilla.com at Thu, 04 Apr 2019 04:33:36 +0000
bug 1469694 - GeckoChildProcessHost should check the return value of LaunchApp r=jld Differential Revision: https://phabricator.services.mozilla.com/D24837
80945e722421a005e54c3c37725c14992b32a23a: Bug 1535794 - Allow getrandom() in all sandbox policies. r=jld
Gian-Carlo Pascutto <gcp@mozilla.com> - Tue, 02 Apr 2019 12:37:58 +0000 - rev 467597
Push 35804 by rgurzau@mozilla.com at Tue, 02 Apr 2019 21:49:08 +0000
Bug 1535794 - Allow getrandom() in all sandbox policies. r=jld Differential Revision: https://phabricator.services.mozilla.com/D25610
42b734a0a83dac48657497ba3ac904915f3e479e: Bug 1536137 - Add getrusage to RDD policy. r=jld
Gian-Carlo Pascutto <gcp@mozilla.com> - Mon, 01 Apr 2019 16:10:05 +0000 - rev 467074
Push 35795 by csabou@mozilla.com at Mon, 01 Apr 2019 21:54:51 +0000
Bug 1536137 - Add getrusage to RDD policy. r=jld Depends on D24190 Differential Revision: https://phabricator.services.mozilla.com/D25621
6de4d77e6769db34a26ef40d8558da9ddbf1ada7: Bug 1536127 - Add F_SETFD/CLOEXEC logic to RDD process. r=jld
Gian-Carlo Pascutto <gcp@mozilla.com> - Mon, 01 Apr 2019 16:10:07 +0000 - rev 467073
Push 35795 by csabou@mozilla.com at Mon, 01 Apr 2019 21:54:51 +0000
Bug 1536127 - Add F_SETFD/CLOEXEC logic to RDD process. r=jld Differential Revision: https://phabricator.services.mozilla.com/D24190
d5b5baea492ae20badf1a8d45189aeaa0ef0cc7d: Bug 1538045 - use MAP_FAILED instead of (void*)-1 in shared_memory_posix.cc. r=jld
Cameron McCormack <cam@mcc.id.au> - Tue, 26 Mar 2019 22:06:18 +0000 - rev 466248
Push 35762 by csabou@mozilla.com at Wed, 27 Mar 2019 04:44:00 +0000
Bug 1538045 - use MAP_FAILED instead of (void*)-1 in shared_memory_posix.cc. r=jld Differential Revision: https://phabricator.services.mozilla.com/D24458
9d97860471b45d4096acb7d9ed8c10c7d3c602ff: Bug 1212103 : Added assert to check if the id is exceeding bounds of signed 32 bit integer r=jld
srujana <srujana.peddinti@students.iiit.ac.in> - Fri, 22 Mar 2019 19:06:02 +0000 - rev 465767
Push 35746 by shindli@mozilla.com at Sat, 23 Mar 2019 09:46:24 +0000
Bug 1212103 : Added assert to check if the id is exceeding bounds of signed 32 bit integer r=jld Added assert to check if the id is exceeding bounds of signed 32 bit integer. ``` x < (1<<29) x+1 <= (1<<29) ((x+1)<<2) <= (1<<31) ((x+1)<<2) | (two bit tag t)<= (1<<31) ``` Differential Revision: https://phabricator.services.mozilla.com/D23808
dc8935d7c0b10afc0401049936cc9d5f9fc5b003: Bug 1375863 - fold MOZ_CONTENT_SANDBOX and MOZ_GMP_SANDBOX into MOZ_SANDBOX; r=jld,firefox-build-system-reviewers
Alex Gaynor <agaynor@mozilla.com> - Mon, 18 Mar 2019 22:31:59 +0000 - rev 465024
Push 35730 by rmaries@mozilla.com at Tue, 19 Mar 2019 21:51:47 +0000
Bug 1375863 - fold MOZ_CONTENT_SANDBOX and MOZ_GMP_SANDBOX into MOZ_SANDBOX; r=jld,firefox-build-system-reviewers Differential Revision: https://phabricator.services.mozilla.com/D22975
64abd0254f73af2d4580b5ec7188f513a3fc785a: Bug 1530245 - Launch sandbox from new remote sandbox broker process. r=jld,bobowen
Chris Pearce <cpearce@mozilla.com> - Wed, 13 Mar 2019 09:24:52 +0000 - rev 463794
Push 35697 by opoprus@mozilla.com at Wed, 13 Mar 2019 16:13:53 +0000
Bug 1530245 - Launch sandbox from new remote sandbox broker process. r=jld,bobowen Depends on D22051 Differential Revision: https://phabricator.services.mozilla.com/D22052
2302287136a3aed6a9a445377ee588ad7b05c2ab: Bug 1527135 - Remove unnecessary EI_OSABI and EI_ABIVERSION checks. r=jld
Markus Stange <mstange@themasta.com> - Tue, 19 Feb 2019 20:10:56 +0000 - rev 459950
Push 35580 by dvarga@mozilla.com at Wed, 20 Feb 2019 04:03:23 +0000
Bug 1527135 - Remove unnecessary EI_OSABI and EI_ABIVERSION checks. r=jld Differential Revision: https://phabricator.services.mozilla.com/D20069
cce258ac041bd88e0414a836de77eb86abe9753a: Bug 1500596 - pt1 - modify IPC sync message name for making remote decoders. r=jld
Michael Froman <mfroman@mozilla.com> - Thu, 14 Feb 2019 19:07:08 +0000 - rev 459566
Push 35563 by ccoroiu@mozilla.com at Sat, 16 Feb 2019 09:36:04 +0000
Bug 1500596 - pt1 - modify IPC sync message name for making remote decoders. r=jld Differential Revision: https://phabricator.services.mozilla.com/D18639
326199603b5dfa09155f0dbfd203dc477bcac768: Bug 1525813 - Ensure ipc::ShmemCreated message serializes shmem size as uint32_t. r=jld
Chris Pearce <cpearce@mozilla.com> - Thu, 07 Feb 2019 16:25:37 +1300 - rev 458207
Push 35518 by opoprus@mozilla.com at Fri, 08 Feb 2019 09:55:14 +0000
Bug 1525813 - Ensure ipc::ShmemCreated message serializes shmem size as uint32_t. r=jld Shmem sizes serialized in an ipc::ShmemCreated message should be sent as an uint32_t rather than a size_t, as size_t is defined as different sizes in 64 and 32 bit builds. If the size isn't consistent, we won't be able to reliably send this message between cross architecture processes. Also, Shmem's have a limit of 32bit for their size anyway: https://searchfox.org/mozilla-central/rev/e00ea598e52bbb35f8c45abf9c2eade17962bb5e/ipc/glue/Shmem.cpp#127 So this patch should not affect allocations of shmems. Differential Revision: https://phabricator.services.mozilla.com/D18909
4dfee3ce7d5eda9eb7ba1d0f4e91b18b11caecdb: Bug 1498079 - Use a var cache for the PreallocatedProcessManager delay pref. r=jld
Mike Conley <mconley@mozilla.com> - Tue, 15 Jan 2019 20:17:13 +0000 - rev 453979
Push 35382 by dvarga@mozilla.com at Wed, 16 Jan 2019 04:47:18 +0000
Bug 1498079 - Use a var cache for the PreallocatedProcessManager delay pref. r=jld This should allow us to avoid accessing this pref too many times during start-up. Differential Revision: https://phabricator.services.mozilla.com/D16584
c28b226ee6c1d383487fb7dd75a14f419221a143: Bug 1514874 - start RDD process on-demand r=jya,jld
Michael Froman <mfroman@mozilla.com> - Sat, 12 Jan 2019 04:51:20 +0000 - rev 453596
Push 35360 by nbeleuzu@mozilla.com at Sat, 12 Jan 2019 09:39:47 +0000
Bug 1514874 - start RDD process on-demand r=jya,jld Differential Revision: https://phabricator.services.mozilla.com/D15775
36802e2a349090305f53f7ef345bfe6a3f324243: Bug 1354200 - Exit instead of MOZ_CRASH on channel error in child process r=jld
James Willcox <snorp@snorp.net> - Thu, 10 Jan 2019 22:45:44 +0000 - rev 453359
Push 35352 by dvarga@mozilla.com at Fri, 11 Jan 2019 04:12:48 +0000
Bug 1354200 - Exit instead of MOZ_CRASH on channel error in child process r=jld Android mercilessly kills the parent in low memory situations, and we don't want that to trigger a crash when the child is abruptly disconnected. Differential Revision: https://phabricator.services.mozilla.com/D16234
8d953c25fdef67aac8b006988f072a1594516938: Bug 1514874 - start RDD process on-demand r=jya,jld
Michael Froman <mfroman@mozilla.com> - Thu, 10 Jan 2019 18:35:06 +0000 - rev 453336
Push 35352 by dvarga@mozilla.com at Fri, 11 Jan 2019 04:12:48 +0000
Bug 1514874 - start RDD process on-demand r=jya,jld Differential Revision: https://phabricator.services.mozilla.com/D15775
6a7b315a82b2ebc9402166d886fa8c93d805df10: Bug 1511099 - Make MAY_CREATE handling more consistent. r=jld
Gian-Carlo Pascutto <gcp@mozilla.com> - Mon, 07 Jan 2019 15:21:32 +0000 - rev 452712
Push 35328 by ncsoregi@mozilla.com at Mon, 07 Jan 2019 21:46:20 +0000
Bug 1511099 - Make MAY_CREATE handling more consistent. r=jld Differential Revision: https://phabricator.services.mozilla.com/D13523
a925aa11dd43eeddf065ec9f795ef4ab17050ea4: Bug 1517567 - remove unused FILETIME-related functions from chromium ipc; r=jld
Nathan Froyd <froydnj@mozilla.com> - Fri, 04 Jan 2019 09:13:05 -0500 - rev 452589
Push 35316 by shindli@mozilla.com at Sat, 05 Jan 2019 04:03:40 +0000
Bug 1517567 - remove unused FILETIME-related functions from chromium ipc; r=jld This removes one include of windows.h, which is nice.
71cbbfe1d55b826bb101e1a1f8cb6abc050bb913: Bug 1511557 - Do not leak the pipe used for sending crash annotations when hitting errors during startup r=jld
Gabriele Svelto <gsvelto@mozilla.com> - Wed, 19 Dec 2018 15:29:09 +0000 - rev 451316
Push 35234 by rmaries@mozilla.com at Wed, 19 Dec 2018 21:56:37 +0000
Bug 1511557 - Do not leak the pipe used for sending crash annotations when hitting errors during startup r=jld Differential Revision: https://phabricator.services.mozilla.com/D14744
3d060df6e3258ed74b800c7ee0e89e001116f98d: Bug 1497749: Get hello message from channel ID when pipe handle passed. r=jld
Bob Owen <bobowencode@gmail.com> - Tue, 18 Dec 2018 14:26:26 +0000 - rev 451220
Push 35230 by btara@mozilla.com at Wed, 19 Dec 2018 04:55:30 +0000
Bug 1497749: Get hello message from channel ID when pipe handle passed. r=jld
15f8b27f13054b6c1029d2b2c47968a63cbd9c93: Bug 1511557 - Do not leak the pipe used for sending crash annotations when hitting errors during startup r=jld
Gabriele Svelto <gsvelto@mozilla.com> - Fri, 14 Dec 2018 02:47:03 +0000 - rev 450493
Push 35203 by rmaries@mozilla.com at Fri, 14 Dec 2018 16:18:46 +0000
Bug 1511557 - Do not leak the pipe used for sending crash annotations when hitting errors during startup r=jld Differential Revision: https://phabricator.services.mozilla.com/D13999
1c1f445a9b6a98cc10348c6eb1c9d8bdf72ca412: Bug 1509362 - Don't crash when constructing actor during content shutdown, r=jld
Nika Layzell <nika@thelayzells.com> - Thu, 22 Nov 2018 13:40:32 -0500 - rev 449430
Push 35163 by shindli@mozilla.com at Wed, 05 Dec 2018 21:36:23 +0000
Bug 1509362 - Don't crash when constructing actor during content shutdown, r=jld When shutting down a content process, we call `Close` on the `IToplevelProtocol`. This causes the MessageChannel to be `Close`-ed, which in turn sends a `GOODBYE_MESSAGE`: https://searchfox.org/mozilla-central/rev/876022232b15425bb9efde189caf747823b39567/ipc/glue/MessageChannel.cpp#2852 This message is intercepted on the I/O thread in the content process, before any code is informed in content, and used to set the `mChannelState` property to `ChannelClosing`: https://searchfox.org/mozilla-central/rev/876022232b15425bb9efde189caf747823b39567/ipc/glue/MessageChannel.cpp#1176 Once this state has been set, which is performed as soon as the message is received, whether or not other messages have been processed yet, no messages can be sent back to the parent process. This is usually what causes the 'Too late to send/recv' message spam in the console, as we're still trying to send messages at this time. Usually this is fine - the message send fails, but we gracefully recover, and the process begins shutting down like normal. Unfortunately, child actor constructors currently have code automatically generated in them which causes a process crash if the send fails. As it's impossible for the main thread to know that the channel has been closed ahead of time (due to this happening out-of-band), we can then cause random content process crashes during shutdown due to actor construction. Unfortunately, we can't just destroy the actor, as our caller may (and often do) depend on the actor reference they gave us still being valid after calling Send*Constructor. Fortunately, if a message send failed, it means we're in the process of being shut down. This patch handles this by ignoring ctor send errors, and treating them like messages which successfully were queued to send, but got lost due to the other side hanging up. The actor will be gracefully destroyed in DestroySubtree when its manager is destroyed. Differential Revision: https://phabricator.services.mozilla.com/D12695
7e23a1b903356b3bdfbf1844bee62513969b93a6: Bug 1509362 - Don't crash when constructing actor during content shutdown, r=jld
Nika Layzell <nika@thelayzells.com> - Thu, 22 Nov 2018 13:40:32 -0500 - rev 449371
Push 35159 by csabou@mozilla.com at Wed, 05 Dec 2018 10:20:00 +0000
Bug 1509362 - Don't crash when constructing actor during content shutdown, r=jld When shutting down a content process, we call `Close` on the `IToplevelProtocol`. This causes the MessageChannel to be `Close`-ed, which in turn sends a `GOODBYE_MESSAGE`: https://searchfox.org/mozilla-central/rev/876022232b15425bb9efde189caf747823b39567/ipc/glue/MessageChannel.cpp#2852 This message is intercepted on the I/O thread in the content process, before any code is informed in content, and used to set the `mChannelState` property to `ChannelClosing`: https://searchfox.org/mozilla-central/rev/876022232b15425bb9efde189caf747823b39567/ipc/glue/MessageChannel.cpp#1176 Once this state has been set, which is performed as soon as the message is received, whether or not other messages have been processed yet, no messages can be sent back to the parent process. This is usually what causes the 'Too late to send/recv' message spam in the console, as we're still trying to send messages at this time. Usually this is fine - the message send fails, but we gracefully recover, and the process begins shutting down like normal. Unfortunately, child actor constructors currently have code automatically generated in them which causes a process crash if the send fails. As it's impossible for the main thread to know that the channel has been closed ahead of time (due to this happening out-of-band), we can then cause random content process crashes during shutdown due to actor construction. Unfortunately, we can't just destroy the actor, as our caller may (and often do) depend on the actor reference they gave us still being valid after calling Send*Constructor. Fortunately, if a message send failed, it means we're in the process of being shut down. This patch handles this by ignoring ctor send errors, and treating them like messages which successfully were queued to send, but got lost due to the other side hanging up. The actor will be gracefully destroyed in DestroySubtree when its manager is destroyed. Differential Revision: https://phabricator.services.mozilla.com/D12695
7725c317d72320510a3c792a60185179a4183632: Bug 1507830 - When using Wayland, don't allow connections to the X server. r=jld
Gian-Carlo Pascutto <gcp@mozilla.com> - Fri, 30 Nov 2018 22:23:31 +0000 - rev 449020
Push 35139 by ccoroiu@mozilla.com at Sat, 01 Dec 2018 02:30:08 +0000
Bug 1507830 - When using Wayland, don't allow connections to the X server. r=jld Differential Revision: https://phabricator.services.mozilla.com/D13560
a06e4cff09e6fe6ca41626310d6494a3d276772a: Bug 1509930 - Simplify CycleCollectWithLogsChild's lifetime, r=jld
Nika Layzell <nika@thelayzells.com> - Fri, 23 Nov 2018 17:07:41 -0500 - rev 448614
Push 35120 by ccoroiu@mozilla.com at Thu, 29 Nov 2018 04:28:09 +0000
Bug 1509930 - Simplify CycleCollectWithLogsChild's lifetime, r=jld Previously this actor would call `Send__delete__` in its destructor, meaning that the lifetime of the actor is a bit hard to follow. This changes the actor to instead use a separate object for XPCOM, and use refcounting universally. This should also help with the transition to universally refcounted actors. Differential Revision: https://phabricator.services.mozilla.com/D12955
c3fe435e473a463fbc22d4afa531bdedb757079c: Bug 1509362 - Don't crash when constructing actor during content shutdown, r=jld
Nika Layzell <nika@thelayzells.com> - Thu, 22 Nov 2018 13:40:32 -0500 - rev 448447
Push 35112 by csabou@mozilla.com at Wed, 28 Nov 2018 04:08:44 +0000
Bug 1509362 - Don't crash when constructing actor during content shutdown, r=jld When shutting down a content process, we call `Close` on the `IToplevelProtocol`. This causes the MessageChannel to be `Close`-ed, which in turn sends a `GOODBYE_MESSAGE`: https://searchfox.org/mozilla-central/rev/876022232b15425bb9efde189caf747823b39567/ipc/glue/MessageChannel.cpp#2852 This message is intercepted on the I/O thread in the content process, before any code is informed in content, and used to set the `mChannelState` property to `ChannelClosing`: https://searchfox.org/mozilla-central/rev/876022232b15425bb9efde189caf747823b39567/ipc/glue/MessageChannel.cpp#1176 Once this state has been set, which is performed as soon as the message is received, whether or not other messages have been processed yet, no messages can be sent back to the parent process. This is usually what causes the 'Too late to send/recv' message spam in the console, as we're still trying to send messages at this time. Usually this is fine - the message send fails, but we gracefully recover, and the process begins shutting down like normal. Unfortunately, child actor constructors currently have code automatically generated in them which causes a process crash if the send fails. As it's impossible for the main thread to know that the channel has been closed ahead of time (due to this happening out-of-band), we can then cause random content process crashes during shutdown due to actor construction. Unfortunately, we can't just destroy the actor, as our caller may (and often do) depend on the actor reference they gave us still being valid after calling Send*Constructor. Fortunately, if a message send failed, it means we're in the process of being shut down. This patch handles this by ignoring ctor send errors, and treating them like messages which successfully were queued to send, but got lost due to the other side hanging up. The actor will be gracefully destroyed in DestroySubtree when its manager is destroyed. Differential Revision: https://phabricator.services.mozilla.com/D12695
bce195f98895f82bd5ace5fc5ed5a5ca3b9f1afd: Bug 1509930 - Simplify CycleCollectWithLogsChild's lifetime, r=jld
Nika Layzell <nika@thelayzells.com> - Fri, 23 Nov 2018 17:07:41 -0500 - rev 448444
Push 35112 by csabou@mozilla.com at Wed, 28 Nov 2018 04:08:44 +0000
Bug 1509930 - Simplify CycleCollectWithLogsChild's lifetime, r=jld Previously this actor would call `Send__delete__` in its destructor, meaning that the lifetime of the actor is a bit hard to follow. This changes the actor to instead use a separate object for XPCOM, and use refcounting universally. This should also help with the transition to universally refcounted actors. Differential Revision: https://phabricator.services.mozilla.com/D12955
b4754021fc2dbeb9a96fc85cacc52ec1c63d1453: Bug 1499465 - Don't collect KillHard crashes on Beta or Release. r=jld,gsvelto
Mike Conley <mconley@mozilla.com> - Tue, 20 Nov 2018 21:34:36 +0000 - rev 447417
Push 35078 by btara@mozilla.com at Wed, 21 Nov 2018 09:38:45 +0000
Bug 1499465 - Don't collect KillHard crashes on Beta or Release. r=jld,gsvelto Differential Revision: https://phabricator.services.mozilla.com/D10968