searching for reviewer(jimm)
c627801eeecc8bf6100c723b435138b2f47179e8: Bug 1552160 Part 2: Roll-up patch to apply remaining mozilla changes to chromium sandbox. r=tabraldes,aklotz,jimm,bobowen
Bob Owen <bobowencode@gmail.com> - Sat, 29 Nov 2014 17:12:18 +0000 - rev 478496
Push 36144 by aciure@mozilla.com at Wed, 12 Jun 2019 21:42:35 +0000
Bug 1552160 Part 2: Roll-up patch to apply remaining mozilla changes to chromium sandbox. r=tabraldes,aklotz,jimm,bobowen Patches re-applied from security/sandbox/chromium-shim/patches/after_update/. See patch files for additional commit comments.
fe3cd9f0d12bae82190bd17ea474d1a2f4bb80a2: Bug 1518639: Implement windows remoting server and client. r=jimm
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 06 Feb 2019 14:18:35 -0800 - rev 462763
Push 35658 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:34:33 +0000
Bug 1518639: Implement windows remoting server and client. r=jimm Implements the windows remove client and server based on the current remoting code in nsNativeAppSupportWin.cpp. Makes the hidden window classname encode both program name and profile name. nsNativeAppSupportWin is now just used for setting up the console. Differential Revision: https://phabricator.services.mozilla.com/D19076
61ed2a0798487c50c5faf70241aa637d01da6b10: Bug 513742: Remove support for DDE from toolkit. r=jimm
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 22 Jan 2019 14:48:43 -0800 - rev 462762
Push 35658 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:34:33 +0000
Bug 513742: Remove support for DDE from toolkit. r=jimm Differential Revision: https://phabricator.services.mozilla.com/D19075
fbef638149b4426032f58903a9abf480341a3ff8: Bug 1518639: Add boilerplate support for a windows remote client and server. r=jimm,froydnj
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 06 Feb 2019 11:09:06 -0800 - rev 462761
Push 35658 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:34:33 +0000
Bug 1518639: Add boilerplate support for a windows remote client and server. r=jimm,froydnj Adds build config and stubs for a windows implementation of the remote client and server. Differential Revision: https://phabricator.services.mozilla.com/D19074
30cd61daa60513ca4c31cd466ad6868fb7859317: Bug 1518639: Move remote client call to after we have a profile. r=jimm
Dave Townsend <dtownsend@oxymoronical.com> - Thu, 31 Jan 2019 17:06:00 -0800 - rev 462759
Push 35658 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:34:33 +0000
Bug 1518639: Move remote client call to after we have a profile. r=jimm Makes it so we always know which profile we want to remote the command line to. Differential Revision: https://phabricator.services.mozilla.com/D19073
03c9381974486d342d41f010a60eb436b546ec7a: Bug 1518639: Move command line handing to nsRemoteService. r=jimm
Dave Townsend <dtownsend@oxymoronical.com> - Thu, 31 Jan 2019 12:13:34 -0800 - rev 462758
Push 35658 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:34:33 +0000
Bug 1518639: Move command line handing to nsRemoteService. r=jimm Makes nsRemoteService handle the command line parsing, though this will end up being removed in a later patch. Differential Revision: https://phabricator.services.mozilla.com/D19071
b9d78d81a381350aa548ce7d6b640b93d57ebb7c: Bug 1518639: Move startup locking to the remote service. r=jimm
Dave Townsend <dtownsend@oxymoronical.com> - Thu, 31 Jan 2019 12:13:34 -0800 - rev 462757
Push 35658 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:34:33 +0000
Bug 1518639: Move startup locking to the remote service. r=jimm Makes nsRemoteService responsible for the shared lock for the time between attempting to contact a remote server and starting up our own server. Differential Revision: https://phabricator.services.mozilla.com/D19070
34d973f8ea5b4acb22e4ad2a0ced65c2583f6397: Bug 1518639: Move the calls to the remote clients into nsRemoteService. r=jimm
Dave Townsend <dtownsend@oxymoronical.com> - Thu, 31 Jan 2019 12:13:34 -0800 - rev 462756
Push 35658 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:34:33 +0000
Bug 1518639: Move the calls to the remote clients into nsRemoteService. r=jimm Makes nsRemoteService responsible for managing the clients too, simplifying nsAppRunner. Differential Revision: https://phabricator.services.mozilla.com/D19069
2ac2c7a2a9a61bb33802721ff73163a1403f3c54: Bug 1518639: Move widget/xremote code to toolkit/components/remote. r=jimm
Dave Townsend <dtownsend@oxymoronical.com> - Thu, 31 Jan 2019 12:13:34 -0800 - rev 462755
Push 35658 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:34:33 +0000
Bug 1518639: Move widget/xremote code to toolkit/components/remote. r=jimm It makes more sense for the remote client to live alongside the server. Differential Revision: https://phabricator.services.mozilla.com/D19068
d1f158c2928f02fe725038bdda99b13c4366bc6c: Bug 1518639: Break out the remote server pieces from nsRemoteService and deCOMtaminate. r=jimm
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 27 Feb 2019 15:45:51 -0800 - rev 462754
Push 35658 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:34:33 +0000
Bug 1518639: Break out the remote server pieces from nsRemoteService and deCOMtaminate. r=jimm This code is only ever used from c++ so does not need to be an XPCOM component. Broken out a single nsRemoteService that is responsible for choosing the server implementation to use. Differential Revision: https://phabricator.services.mozilla.com/D19067
940349bea8e88038b8f3727ea225b6ad9aa2bbd2: Bug 1518639: Remove the ability to remote to a different user or application. r=jimm
Dave Townsend <dtownsend@oxymoronical.com> - Thu, 31 Jan 2019 11:12:32 -0800 - rev 462753
Push 35658 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:34:33 +0000
Bug 1518639: Remove the ability to remote to a different user or application. r=jimm Remoting to a different user isn't supported everywhere and being able to remote to a different application entirely is kind of odd. I don't think it makes sense to continue to support these operations. Differential Revision: https://phabricator.services.mozilla.com/D19066
84e8066625fd72fdb1eb6eab85621ae842fe91b4: Bug 1518639: Implement windows remoting server and client. r=jimm
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 06 Feb 2019 14:18:35 -0800 - rev 462749
Push 35658 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:34:33 +0000
Bug 1518639: Implement windows remoting server and client. r=jimm Implements the windows remove client and server based on the current remoting code in nsNativeAppSupportWin.cpp. Makes the hidden window classname encode both program name and profile name. nsNativeAppSupportWin is now just used for setting up the console. Differential Revision: https://phabricator.services.mozilla.com/D19076
4ef3cc37f719d02443a2058192fdb4c61d3e3dca: Bug 513742: Remove support for DDE from toolkit. r=jimm
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 22 Jan 2019 14:48:43 -0800 - rev 462748
Push 35658 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:34:33 +0000
Bug 513742: Remove support for DDE from toolkit. r=jimm Differential Revision: https://phabricator.services.mozilla.com/D19075
276ca640adc8ff16ff3ff7252e8aa5016205b1e0: Bug 1518639: Add boilerplate support for a windows remote client and server. r=jimm,froydnj
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 06 Feb 2019 11:09:06 -0800 - rev 462747
Push 35658 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:34:33 +0000
Bug 1518639: Add boilerplate support for a windows remote client and server. r=jimm,froydnj Adds build config and stubs for a windows implementation of the remote client and server. Differential Revision: https://phabricator.services.mozilla.com/D19074
967993505a3d00a79cd81dccf66ffa0612a58ad4: Bug 1518639: Move remote client call to after we have a profile. r=jimm
Dave Townsend <dtownsend@oxymoronical.com> - Thu, 31 Jan 2019 17:06:00 -0800 - rev 462745
Push 35658 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:34:33 +0000
Bug 1518639: Move remote client call to after we have a profile. r=jimm Makes it so we always know which profile we want to remote the command line to. Differential Revision: https://phabricator.services.mozilla.com/D19073
fc466857ab39e3d2371f13ddae553c921fb727d2: Bug 1518639: Move command line handing to nsRemoteService. r=jimm
Dave Townsend <dtownsend@oxymoronical.com> - Thu, 31 Jan 2019 12:13:34 -0800 - rev 462744
Push 35658 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:34:33 +0000
Bug 1518639: Move command line handing to nsRemoteService. r=jimm Makes nsRemoteService handle the command line parsing, though this will end up being removed in a later patch. Differential Revision: https://phabricator.services.mozilla.com/D19071
28404f97bb22b726afee8df04184da81138497a2: Bug 1518639: Move startup locking to the remote service. r=jimm
Dave Townsend <dtownsend@oxymoronical.com> - Thu, 31 Jan 2019 12:13:34 -0800 - rev 462743
Push 35658 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:34:33 +0000
Bug 1518639: Move startup locking to the remote service. r=jimm Makes nsRemoteService responsible for the shared lock for the time between attempting to contact a remote server and starting up our own server. Differential Revision: https://phabricator.services.mozilla.com/D19070
5373c5bb9ad5bb7c3af1cae390c3612be51176b5: Bug 1518639: Move the calls to the remote clients into nsRemoteService. r=jimm
Dave Townsend <dtownsend@oxymoronical.com> - Thu, 31 Jan 2019 12:13:34 -0800 - rev 462742
Push 35658 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:34:33 +0000
Bug 1518639: Move the calls to the remote clients into nsRemoteService. r=jimm Makes nsRemoteService responsible for managing the clients too, simplifying nsAppRunner. Differential Revision: https://phabricator.services.mozilla.com/D19069
a7490cdfb635f95c1eb8c33283064842bc490cbd: Bug 1518639: Move widget/xremote code to toolkit/components/remote. r=jimm
Dave Townsend <dtownsend@oxymoronical.com> - Thu, 31 Jan 2019 12:13:34 -0800 - rev 462741
Push 35658 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:34:33 +0000
Bug 1518639: Move widget/xremote code to toolkit/components/remote. r=jimm It makes more sense for the remote client to live alongside the server. Differential Revision: https://phabricator.services.mozilla.com/D19068
28c7186745e3d5de5f44a72a81e0068cb23ce547: Bug 1518639: Break out the remote server pieces from nsRemoteService and deCOMtaminate. r=jimm
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 27 Feb 2019 15:45:51 -0800 - rev 462740
Push 35658 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:34:33 +0000
Bug 1518639: Break out the remote server pieces from nsRemoteService and deCOMtaminate. r=jimm This code is only ever used from c++ so does not need to be an XPCOM component. Broken out a single nsRemoteService that is responsible for choosing the server implementation to use. Differential Revision: https://phabricator.services.mozilla.com/D19067
35287afd3acea1602bed159dc879aa666e64b9c8: Bug 1518639: Remove the ability to remote to a different user or application. r=jimm
Dave Townsend <dtownsend@oxymoronical.com> - Thu, 31 Jan 2019 11:12:32 -0800 - rev 462739
Push 35658 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 04:34:33 +0000
Bug 1518639: Remove the ability to remote to a different user or application. r=jimm Remoting to a different user isn't supported everywhere and being able to remote to a different application entirely is kind of odd. I don't think it makes sense to continue to support these operations. Differential Revision: https://phabricator.services.mozilla.com/D19066
17ad931f439ce74288a8777400c40a19aa6971c6: Bug 1529954: Move ARM64 Windows content sandbox back to level 5. r=jimm
Bob Owen <bobowencode@gmail.com> - Tue, 26 Feb 2019 10:39:48 +0000 - rev 461141
Push 35618 by shindli@mozilla.com at Tue, 26 Feb 2019 16:54:44 +0000
Bug 1529954: Move ARM64 Windows content sandbox back to level 5. r=jimm
211fcf7cb803afac968c00334fada58cb516bd2d: Bug 1528586 - Remove PluginContextProxy. r=jimm
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Sun, 17 Feb 2019 12:38:39 +0900 - rev 461093
Push 35618 by shindli@mozilla.com at Tue, 26 Feb 2019 16:54:44 +0000
Bug 1528586 - Remove PluginContextProxy. r=jimm
55a7c08b3b67c472266f383b14cc4ca3803849c9: Bug 1511438 Part 2: Enable win32k lockdown on RDD process. r=jimm
Bob Owen <bobowencode@gmail.com> - Tue, 29 Jan 2019 08:49:13 +0000 - rev 455940
Push 35463 by shindli@mozilla.com at Tue, 29 Jan 2019 21:38:17 +0000
Bug 1511438 Part 2: Enable win32k lockdown on RDD process. r=jimm This stops the use of some win32k calls during start-up that will fail and in some cases cause a crash. It also moves the MITIGATION_DYNAMIC_CODE_DISABLE to be enabled after start-up. This is required because the hooks to fake the user32 and gdi32 initialization are applied as the DLLs load and the dynamic code disable blocks that.
5c1a8f06c28b16f7e151ed7f678194a9bda0f5d6: Bug 1489796: On Windows resolve junction points and symlinks in the sys user extensions directories. r=jimm
Bob Owen <bobowencode@gmail.com> - Thu, 13 Dec 2018 09:08:40 +0000 - rev 453243
Push 35350 by btara@mozilla.com at Thu, 10 Jan 2019 17:21:43 +0000
Bug 1489796: On Windows resolve junction points and symlinks in the sys user extensions directories. r=jimm This is needed because they are currently used in sandbox rules.
ea26467472df9849f0f59a2179493ca7295870ee: Bug 1483240 - Disable plugins in recording/replaying processes, r=jimm.
Brian Hackett <bhackett1024@gmail.com> - Tue, 21 Aug 2018 00:56:47 +0000 - rev 432644
Push 34482 by toros@mozilla.com at Tue, 21 Aug 2018 21:56:56 +0000
Bug 1483240 - Disable plugins in recording/replaying processes, r=jimm.
2e16db6bbb2106bc2fde665626d0013020651623: Bug 1430038 - Part 3: Construct IPC connection for VR/GPU process; r=kip, jimm, jgilbert
Daosheng Mu <daoshengmu@gmail.com> - Mon, 06 Aug 2018 22:47:18 -0700 - rev 432489
Push 34478 by dluca@mozilla.com at Tue, 21 Aug 2018 09:54:49 +0000
Bug 1430038 - Part 3: Construct IPC connection for VR/GPU process; r=kip, jimm, jgilbert Summary: MozReview-Commit-ID: 2kOyfC4TFZP Tags: #secure-revision Differential Revision: https://phabricator.services.mozilla.com/D2879 MozReview-Commit-ID: 17O2xbRMOFJ
57c32dd4f6e6ac28787e207f6854b9e0ab4ede65: Bug 1430038 - Part 2: launch VR process and communicate with GPU process; r=kip, jimm
Daosheng Mu <daoshengmu@gmail.com> - Tue, 07 Aug 2018 11:20:34 -0700 - rev 432488
Push 34478 by dluca@mozilla.com at Tue, 21 Aug 2018 09:54:49 +0000
Bug 1430038 - Part 2: launch VR process and communicate with GPU process; r=kip, jimm Summary: MozReview-Commit-ID: IQZVIYVSCxe Tags: #secure-revision Differential Revision: https://phabricator.services.mozilla.com/D2877 MozReview-Commit-ID: 4sT6fqk7MpT
1a61001aaee6db940509579078fa9807fd80b01c: Bug 1430038 - Part 1: Add VR process to the process list; r=kip, jimm
Daosheng Mu <daoshengmu@gmail.com> - Fri, 22 Jun 2018 16:30:14 -0700 - rev 432487
Push 34478 by dluca@mozilla.com at Tue, 21 Aug 2018 09:54:49 +0000
Bug 1430038 - Part 1: Add VR process to the process list; r=kip, jimm Summary: MozReview-Commit-ID: AWyFur2gLCQ Tags: #secure-revision Differential Revision: https://phabricator.services.mozilla.com/D2876 MozReview-Commit-ID: HHGDiXyaqnB
dbfd2f2016a4538b96863a16a96ffe43a6e9eceb: Bug 1475033 part 7 - Implement scrollbar-width: thin for Windows. r=jimm
Xidorn Quan <me@upsuper.org> - Mon, 06 Aug 2018 15:18:27 +1000 - rev 432052
Push 34457 by ebalazs@mozilla.com at Fri, 17 Aug 2018 09:45:26 +0000
Bug 1475033 part 7 - Implement scrollbar-width: thin for Windows. r=jimm Since Windows doesn't provide native thin scrollbar variant, this patch tries to synthesize one by doing the following: * force to use custom scrollbar, and * hide the scrollbar button by giving them zero size, and * cut the thickness of scrollbar by half. Half thickness is picked randomly, but it seems to work fine. A third of the size also looks fine, but maybe a bit harder to drag. Note: Universal Windows Platform apps seem to have an overlay style of scrollbar by default, but I cannot find any Windows API to render that, so that may be a builtin component of UWP. We may want to do that at some point, but this is probably good enough for now. MozReview-Commit-ID: KfHjy8WdweT
1972d9de2b1014ffd032565578d4ca1d5016e846: Bug 1475033 part 6 - Have scrollbar auto colors resolve to the corresponding colors on Windows 10. r=jimm
Xidorn Quan <me@upsuper.org> - Mon, 06 Aug 2018 15:13:17 +1000 - rev 432051
Push 34457 by ebalazs@mozilla.com at Fri, 17 Aug 2018 09:45:26 +0000
Bug 1475033 part 6 - Have scrollbar auto colors resolve to the corresponding colors on Windows 10. r=jimm So that we can use custom scrollbar for thin scrollbar. MozReview-Commit-ID: FCHzV5MJbx
76149510c0f0a2f7843bacb06239106f1013bd4e: Bug 1475033 part 5 - Remove scrollbarbutton min-{width,height} rule. r=jimm
Xidorn Quan <me@upsuper.org> - Mon, 06 Aug 2018 14:21:40 +1000 - rev 432050
Push 34457 by ebalazs@mozilla.com at Fri, 17 Aug 2018 09:45:26 +0000
Bug 1475033 part 5 - Remove scrollbarbutton min-{width,height} rule. r=jimm Almost all widgets provide a non-overridable size for scrollbar buttons, so it makes no sense to specify min size for them. It is probably a layout bug that min size properties can override the value returned by GetMinimumWidgetSize even if aIsOverridable is set to false, but removing this rule is simpler than locating and fixing the issue in layout code :) MozReview-Commit-ID: 58pmxQaHlGe
fb3e5d2dd1d7c918fab39b3ef32908928eb299ec: Bug 1478576 - A mochitest for system font change notification. r=froydnj,jimm,karlt
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 07 Aug 2018 11:58:36 +0900 - rev 432039
Push 34457 by ebalazs@mozilla.com at Fri, 17 Aug 2018 09:45:26 +0000
Bug 1478576 - A mochitest for system font change notification. r=froydnj,jimm,karlt The test case in this patch fails without the proper fix in the first patch in this patch series. In this patch two new nsIDOMWindowUtils APIs are introduced to change the system font settins in tests. Currently the APIs work only on GTK+ platform. Also to work the test case properly we need to open a new XUL window because we don't propagate font changes into descendant documents yet (bug 1478212). MozReview-Commit-ID: 4OLxEkEuF8d
c108e6f927d1483985981647ddff204c706baed7: Bug 1476212 - Notify the system setting change corresponding to prefers-reduced-motion. r=jimm
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Wed, 25 Jul 2018 14:41:13 +0900 - rev 428636
Push 34338 by dluca@mozilla.com at Fri, 27 Jul 2018 09:54:52 +0000
Bug 1476212 - Notify the system setting change corresponding to prefers-reduced-motion. r=jimm Even with this patch, the setting change doesn't affect media queries in sub frames due to bug 1478212. But the bug is a pre-existing issue, for example system color settings don't affect contents in sub frames either. So we can land this patch as it is. Note that there is no way to write an automation test for this unfortunately. MozReview-Commit-ID: L2Knhp1IjrU
6479d0bf85bc163082859c3d70f6b8c5e1d199f6: Bug 1465477 Part 2 - Add --save-recordings option to the firefox command line, r=jimm.
Brian Hackett <bhackett1024@gmail.com> - Mon, 23 Jul 2018 21:52:10 +0000 - rev 428119
Push 34327 by archaeopteryx@coole-files.de at Wed, 25 Jul 2018 14:18:02 +0000
Bug 1465477 Part 2 - Add --save-recordings option to the firefox command line, r=jimm.
928316e1492327b97ffc7bc01f01c400a4b8a90c: Bug 1365045 - Implement prefers-reduced-motion for Windows. r=jimm
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 24 Jul 2018 16:50:48 +0900 - rev 427983
Push 34323 by rgurzau@mozilla.com at Tue, 24 Jul 2018 15:50:11 +0000
Bug 1365045 - Implement prefers-reduced-motion for Windows. r=jimm https://msdn.microsoft.com/en-us/library/windows/desktop/ms724947(v=vs.85).aspx MozReview-Commit-ID: APERUPoSaz
0bce1e5b252a300d14ee22b408f76574c01553cd: Bug 1476476 - Remove some unused const variables in JumpListBuilder. r=jimm
Xidorn Quan <me@upsuper.org> - Wed, 18 Jul 2018 10:24:04 +1000 - rev 427390
Push 34303 by toros@mozilla.com at Fri, 20 Jul 2018 09:55:38 +0000
Bug 1476476 - Remove some unused const variables in JumpListBuilder. r=jimm MozReview-Commit-ID: 4UPr0lWd4iQ
59221b30f49baa42ee9f8d12a087e093398165ce: Bug 1445444: Properly initialize plugin window drawing type on Windows r=jimm
David Parks <dparks@mozilla.com> - Mon, 25 Jun 2018 13:16:44 -0700 - rev 426858
Push 34287 by ccoroiu@mozilla.com at Tue, 17 Jul 2018 09:42:00 +0000
Bug 1445444: Properly initialize plugin window drawing type on Windows r=jimm Sets the default plugin window type to windowed on Windows. Most of the time, plugins use async drawing so this will be overwritten but it should be properly initialized for cases where we do not switch to async.
26163df1083ea2847022e60518ab973360b9d7c1: Bug 1412081 - Call KillClearOnShutdown(ShutdownPhase::ShutdownFinal) in PluginProcessChild on all platforms r=jimm
Valentin Gosu <valentin.gosu@gmail.com> - Thu, 05 Jul 2018 17:20:58 +0200 - rev 426729
Push 34284 by btara@mozilla.com at Mon, 16 Jul 2018 21:55:18 +0000
Bug 1412081 - Call KillClearOnShutdown(ShutdownPhase::ShutdownFinal) in PluginProcessChild on all platforms r=jimm This call gated by ifdef OS_WIN - so on Linux it would leak objects that were supposed to be ClearOnShutdown in the plugin process
0c8bac19dc29429dba2092091fd5f77f3c4f8237: Bug 1470341 - Also call UIResolutionChanged from WM_MOVING. r=jimm
Dão Gottwald <dao@mozilla.com> - Wed, 04 Jul 2018 12:58:33 +0200 - rev 426470
Push 34274 by nerli@mozilla.com at Fri, 13 Jul 2018 21:51:36 +0000
Bug 1470341 - Also call UIResolutionChanged from WM_MOVING. r=jimm MozReview-Commit-ID: 2qyYncBG9jf
9c66627fee188569cc6509ac4f2282f1edf68fd9: Bug 1399126 - Make nsWindow for Windows not notify widget listener of activated/inactivated if active window is changed from/to popup window r=jimm
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 10 Jul 2018 21:24:06 +0900 - rev 426438
Push 34272 by ebalazs@mozilla.com at Fri, 13 Jul 2018 08:51:04 +0000
Bug 1399126 - Make nsWindow for Windows not notify widget listener of activated/inactivated if active window is changed from/to popup window r=jimm Some odd mouse drivers try to activate a window which the mouse driver wants to scroll its content (such window is typically under the mouse cursor when mouse wheel is turned). However, this is illegal behavior and such odd mouse drivers try to activate our popup windows which won't be activated without such apps. We prevented this odd focus behavior with fixing of bug 953146. However, it did NOT stop notifying widget listener of activating nor inactivating the windows. Therefore, that caused a lot of reflow for supporting -moz-window-inactive pseudo class. This patch makes nsWindow::DealWithPopups() consume WM_ACTIVATE message before nsWindow::ProcessMessage() because nsWindow::ProcessMessage() notifies widget listener of activating and inactivating window even when focus move from and to our popup window. So, in other words, this patch stops notifying widget listener of activating and inactivating window when focus moves from/to a popup window. MozReview-Commit-ID: 2dyq07zHZKp
48bb14249b0667377ba8b598fd890ca876539118: Bug 1368808 - Honor the system light/dark mode setting on Windows 10. r=jimm
Matt Howell <mhowell@mozilla.com> - Sun, 08 Jul 2018 17:32:52 -0700 - rev 425531
Push 34258 by toros@mozilla.com at Tue, 10 Jul 2018 09:43:53 +0000
Bug 1368808 - Honor the system light/dark mode setting on Windows 10. r=jimm MozReview-Commit-ID: 3bzhX9bfR4s
9e9a332fe140be7a4935e79535e0fd61aa2b9625: Bug 1449388 - Send NPNVaudioDeviceStateChanged to plugins when any Windows audio device changes state. r=jimm
David Parks <dparks@mozilla.com> - Wed, 13 Jun 2018 13:12:54 -0700 - rev 424883
Push 34225 by shindli@mozilla.com at Tue, 03 Jul 2018 21:57:02 +0000
Bug 1449388 - Send NPNVaudioDeviceStateChanged to plugins when any Windows audio device changes state. r=jimm This message allows plugins to detect when any audio devices change state, even when running inside of our plugin sandbox.
cbbdabbed7e04b5ddcb65daa89b625b9ad3ae60b: Bug 1215818 - part 1: Add telemetry probe to collect TIP names of TSF which are actually used by the users r=jimm,m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 19 Jun 2018 21:00:01 +0900 - rev 424005
Push 34197 by csabou@mozilla.com at Thu, 28 Jun 2018 09:44:02 +0000
Bug 1215818 - part 1: Add telemetry probe to collect TIP names of TSF which are actually used by the users r=jimm,m_kato We always struggle with a lot of IME bugs on Windows. Currently, any IME vendors should've already released TIP for TSF rather than legacy IMM-IME since IMM-IME is not available on UWP apps. Additionally, due to API limitation, it's difficult to get human-friendly name of IMM-IME. So, let's collect only TIP names of TSF on Windows. This must be enough. Note that we cannot get common-English name even though the API to retrieve TIP name taking language code. Therefore, a TIP may be collected with different name, e.g., one is Japanese name and the other is English name. If we collect GUIDs of TIP, we can avoid this issue. However, it's difficult to collect both GUID and human-friendly name since Telemetry key is up to 72 characters. Currently, I give up to avoid this duplicated issue. Perhaps, this is not so serious issue since most TIP users must match language of TIP and their system language settings. Therefore, this patch collects Locale ID of TIP and description of it. Locale ID is necessary because some TIPs may be named same name for different languages. For example, both Japanese and Hangul IMEs of Microsoft are named as "Microsoft IME". MozReview-Commit-ID: IeSxfeqS62a
199da6ff2b796f0a802f46a2dae983d243002a97: Bug 1464722 part 1 - Move functions related to custom scrollbars into nsNativeTheme. r=jimm
Xidorn Quan <me@upsuper.org> - Thu, 21 Jun 2018 16:32:17 +1000 - rev 423982
Push 34197 by csabou@mozilla.com at Thu, 28 Jun 2018 09:44:02 +0000
Bug 1464722 part 1 - Move functions related to custom scrollbars into nsNativeTheme. r=jimm MozReview-Commit-ID: 4URdu5Tj5dg
b8390bf6dda0b3c79744087f76d4b999199cb3dc: Bug 1467452 - Back out f5f49315fec2 to restore getJavaEnv/getJavaPeer NPAPIs to fix Flash crash. r=jimm
Chris Peterson <cpeterson@mozilla.com> - Wed, 20 Jun 2018 12:42:39 -0700 - rev 423181
Push 34164 by csabou@mozilla.com at Thu, 21 Jun 2018 01:17:13 +0000
Bug 1467452 - Back out f5f49315fec2 to restore getJavaEnv/getJavaPeer NPAPIs to fix Flash crash. r=jimm Flash still calls these NPAPIs to initialize some ancient LiveConnect code.
a4f65ee3cba7d71084e92113ce1a3e2ffe428842: Bug 1453795 - Widget - Initialize member fields in classes/ structures. r=jimm
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Fri, 15 Jun 2018 17:48:51 +0300 - rev 423167
Push 34164 by csabou@mozilla.com at Thu, 21 Jun 2018 01:17:13 +0000
Bug 1453795 - Widget - Initialize member fields in classes/ structures. r=jimm
d69617c50c04497f084bd5a39ee698dff4cb4282: Bug 1463917 part 2 - Have windows widget render scrollcorner. r=jimm
Xidorn Quan <me@upsuper.org> - Fri, 11 May 2018 10:21:22 +1000 - rev 423124
Push 34163 by csabou@mozilla.com at Thu, 21 Jun 2018 01:14:46 +0000
Bug 1463917 part 2 - Have windows widget render scrollcorner. r=jimm MozReview-Commit-ID: K4Cu1mL6xvH
bf083b3c02c76bca8786d8e0330e07ddd03c5901: Bug 1463088 - Whitelist self-assigns in browser/base/content/test/plugins/ ready for the next version of ESLint. r=jimm
Mark Banner <standard8@mozilla.com> - Thu, 07 Jun 2018 14:42:37 +0100 - rev 421932
Push 34110 by cbrindusan@mozilla.com at Fri, 08 Jun 2018 21:51:53 +0000
Bug 1463088 - Whitelist self-assigns in browser/base/content/test/plugins/ ready for the next version of ESLint. r=jimm MozReview-Commit-ID: 67uodWaF8sO
5fd3144d5d009fdac3fae2ee33143901164e0d12: Bug 1401883 - don't hold unnecessary references to the Windows app shell; r=jimm
Ting-Yu Chou <janus926@gmail.com> - Wed, 06 Jun 2018 11:05:18 -0400 - rev 421680
Push 34102 by ccoroiu@mozilla.com at Thu, 07 Jun 2018 09:48:05 +0000
Bug 1401883 - don't hold unnecessary references to the Windows app shell; r=jimm When runnables are posted to the main thread's event loop, the event loop notifies any thread observers that this has been done. The app shell registers itself as just such a runnable, and posts messages to the native event loop that processing native events needs to be done. On Windows, this posting takes an extra reference to the app shell, to keep it alive until the message is processed by the native event loop, since app shell code needs to be invoked during that processing. The processing releases this extra reference, so everything stays balanced. Except that it's possible for messages to be posted to the native event loop, and then browser shutdown happens. Those messages are not processed and the associated references taken are not released. This imbalance means that in debug builds, we appear to be leaking the app shell, and that leaking results in intermittent oranges. This intermittent orange has manifested itself in a variety of ways over the years, depending on how big the app shell itself was (since that changes the number of bytes leaked) and how many leak-checked things the app shell was holding on to. This bug is merely the latest manifestation; the last serious work on analyzing the phenomenon and fixing it was done in bug 1220517. The solution proposed in that bug was that we simply stop the extra reference counting; when the app shell is destroyed normally, we shouldn't be processing the native event loop any more anyway. So even if the native event loop is holding (freed) pointers to the app shell, we'd never execute the callback and perform a use-after-free. Reading through the code suggests that this *ought* to be the case, but the potential for shooting ourselves in the foot seems awfully high. In any event, this is not a problem unique to Windows; we have seen this same sort of thing happen on OS X. See nsAppShell::ProcessGeckoEvents in widget/cocoa/nsAppShell.mm. Here we propose a slightly different solution: we keep track of the number of native event callbacks we have scheduled, incrementing when we schedule, and decrementing when we actually run one. When the app shell is destroyed, we simply set the number of outstanding events to zero, and we prohibit the callback from accessing the app shell if there are no outstanding events. This solution is analogous to dropping the extra reference counting, but avoids potential badness if we do wind up processing native events after the app shell is destroyed.